Skip to content
Snippets Groups Projects
Commit b7b560cb authored by Christopher O'Toole's avatar Christopher O'Toole
Browse files

MAGETWO-35060: Copy and Paste detector is run against test files that are blacklisted

The blacklist file has paths that are relative to the white list and to BP,
as a result only half the blacklist can ever be honored.  Previous commits
fixed the testCopyPaste test to use the whitelist like all other tests
in LiveCodeTest class.

Since this change has caused some confusion and since there is already
evidence of confusion on how to use the blacklist for copy paste detection,
this commit will revert functionality back to the old behavior of using BP.

In the future the whitelist should be used consistently for all tests in the
LiveCodeTest class and the blacklist should be cleaned up.
parent e2ef0d54
Branches
No related merge requests found
...@@ -204,7 +204,7 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase ...@@ -204,7 +204,7 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase
$copyPasteDetector->setBlackList($blackList); $copyPasteDetector->setBlackList($blackList);
$this->assertTrue( $this->assertTrue(
$copyPasteDetector->run(self::getWhitelist(['php'])), $copyPasteDetector->run([BP]),
"PHP Copy/Paste Detector has found error(s): See detailed report in {$reportFile}" "PHP Copy/Paste Detector has found error(s): See detailed report in {$reportFile}"
); );
} }
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment