From b7b560cb3755633e79f30c577852b322c84ae892 Mon Sep 17 00:00:00 2001
From: Christopher O'Toole <otoolec@x.com>
Date: Sat, 14 Mar 2015 14:55:33 -0500
Subject: [PATCH] MAGETWO-35060: Copy and Paste detector is run against test
files that are blacklisted
The blacklist file has paths that are relative to the white list and to BP,
as a result only half the blacklist can ever be honored. Previous commits
fixed the testCopyPaste test to use the whitelist like all other tests
in LiveCodeTest class.
Since this change has caused some confusion and since there is already
evidence of confusion on how to use the blacklist for copy paste detection,
this commit will revert functionality back to the old behavior of using BP.
In the future the whitelist should be used consistently for all tests in the
LiveCodeTest class and the blacklist should be cleaned up.
---
dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php b/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php
index dd564c8fc6f..03153c58c0f 100644
--- a/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php
+++ b/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php
@@ -204,7 +204,7 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase
$copyPasteDetector->setBlackList($blackList);
$this->assertTrue(
- $copyPasteDetector->run(self::getWhitelist(['php'])),
+ $copyPasteDetector->run([BP]),
"PHP Copy/Paste Detector has found error(s): See detailed report in {$reportFile}"
);
}
--
GitLab