Skip to content
Snippets Groups Projects
Commit df0b6c30 authored by Alifioditya's avatar Alifioditya
Browse files

fix: false entity usage for dosen pembimbing

parent ff2ce8f3
Branches
Tags
1 merge request!8Feat: test deployment
...@@ -20,7 +20,7 @@ export class RegistrasiTesisController { ...@@ -20,7 +20,7 @@ export class RegistrasiTesisController {
@Body() topicRegistrationDto: RegistrasiTopikDto, @Body() topicRegistrationDto: RegistrasiTopikDto,
) { ) {
return this.registrasiTesisService.createTopicRegistration( return this.registrasiTesisService.createTopicRegistration(
"test_id", // TODO: Get user id from request "1dceb29c-1e95-4dc6-895e-1321972e27d3", // TODO: Get user id from request, for now use generated UUID
topicRegistrationDto, topicRegistrationDto,
); );
} }
......
import { Injectable, NotFoundException } from "@nestjs/common"; import { Injectable, NotFoundException } from "@nestjs/common";
import { InjectRepository } from "@nestjs/typeorm"; import { InjectRepository } from "@nestjs/typeorm";
import { ModuleRef } from "@nestjs/core"; import { Repository } from "typeorm";
import { getEntityManagerToken } from "@nestjs/typeorm";
import { Repository, EntityManager } from "typeorm";
import { PengajuanPengambilanTopik } from "src/entities/pengajuanPengambilanTopik.entity"; import { PengajuanPengambilanTopik } from "src/entities/pengajuanPengambilanTopik.entity";
import { RegistrasiTopikDto } from "src/dto/registrasi-topik"; import { RegistrasiTopikDto } from "src/dto/registrasi-topik";
import { Pengguna } from "src/entities/pengguna.entity"; import { Pengguna } from "src/entities/pengguna.entity";
import { DosenBimbingan } from "src/entities/dosenBimbingan.entity"; import { validateId } from "src/helper/validation";
@Injectable() @Injectable()
export class RegistrasiTesisService { export class RegistrasiTesisService {
...@@ -15,23 +13,7 @@ export class RegistrasiTesisService { ...@@ -15,23 +13,7 @@ export class RegistrasiTesisService {
private pengajuanPengambilanTopikRepository: Repository<PengajuanPengambilanTopik>, private pengajuanPengambilanTopikRepository: Repository<PengajuanPengambilanTopik>,
@InjectRepository(Pengguna) @InjectRepository(Pengguna)
private penggunaRepository: Repository<Pengguna>, private penggunaRepository: Repository<Pengguna>,
@InjectRepository(DosenBimbingan) ) {}
private dosenBimbinganRepository: Repository<DosenBimbingan>,
private readonly moduleRef: ModuleRef,
) {
try {
const connection: EntityManager = this.moduleRef.get(
getEntityManagerToken(""),
{
strict: false,
},
);
connection;
} catch (error: any) {
// Handle request scope
}
}
async createTopicRegistration( async createTopicRegistration(
userId: string, userId: string,
...@@ -39,6 +21,12 @@ export class RegistrasiTesisService { ...@@ -39,6 +21,12 @@ export class RegistrasiTesisService {
): Promise<PengajuanPengambilanTopik> { ): Promise<PengajuanPengambilanTopik> {
// TODO: Proper validations // TODO: Proper validations
// Validate id
validateId([
{ id: userId, object: "Pengguna" },
{ id: topicRegistrationDto.idPembimbing, object: "Pembimbing" },
]);
// Validate user id // Validate user id
const user = await this.penggunaRepository.findOne({ const user = await this.penggunaRepository.findOne({
where: { id: userId }, where: { id: userId },
...@@ -49,8 +37,8 @@ export class RegistrasiTesisService { ...@@ -49,8 +37,8 @@ export class RegistrasiTesisService {
} }
// Validate supervisor id // Validate supervisor id
const supervisor = await this.dosenBimbinganRepository.findOne({ const supervisor = await this.penggunaRepository.findOne({
where: { dosen: topicRegistrationDto.idPembimbing }, where: { id: topicRegistrationDto.idPembimbing },
}); });
if (!supervisor) { if (!supervisor) {
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment