Skip to content
Snippets Groups Projects
Commit e4cf56c9 authored by Joan He's avatar Joan He
Browse files

MAGETWO-59444: Create serializer interface and json class in framework

- Address code review comments
parent 9abe2418
No related merge requests found
...@@ -53,6 +53,9 @@ class DataTest extends \PHPUnit_Framework_TestCase ...@@ -53,6 +53,9 @@ class DataTest extends \PHPUnit_Framework_TestCase
/** @var LayoutInterface |\PHPUnit_Framework_MockObject_MockObject */ /** @var LayoutInterface |\PHPUnit_Framework_MockObject_MockObject */
private $layoutMock; private $layoutMock;
/** @var SerializerInterface|\PHPUnit_Framework_MockObject_MockObject */
private $serializerMock;
protected function setUp() protected function setUp()
{ {
$objectManagerHelper = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this); $objectManagerHelper = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
...@@ -78,15 +81,11 @@ class DataTest extends \PHPUnit_Framework_TestCase ...@@ -78,15 +81,11 @@ class DataTest extends \PHPUnit_Framework_TestCase
] ]
); );
$serializerMock = $this->getMock(SerializerInterface::class, [], [], '', false); $this->serializerMock = $this->getMock(SerializerInterface::class, [], [], '', false);
$serializerMock->method('serialize')
->willReturn('serializedData');
$serializerMock->method('unserialize')
->willReturn(['unserializedData']);
$objectManagerHelper->setBackwardCompatibleProperty( $objectManagerHelper->setBackwardCompatibleProperty(
$this->block, $this->block,
'serializer', 'serializer',
$serializerMock $this->serializerMock
); );
} }
...@@ -171,13 +170,16 @@ class DataTest extends \PHPUnit_Framework_TestCase ...@@ -171,13 +170,16 @@ class DataTest extends \PHPUnit_Framework_TestCase
->method('getCode') ->method('getCode')
->willReturn($storeCode); ->willReturn($storeCode);
$this->serializerMock->method('serialize')
->willReturn('serializedData');
$this->cacheTypeConfigMock->expects($this->once()) $this->cacheTypeConfigMock->expects($this->once())
->method('load') ->method('load')
->with('DIRECTORY_COUNTRY_SELECT_STORE_' . $storeCode) ->with('DIRECTORY_COUNTRY_SELECT_STORE_' . $storeCode)
->willReturn(false); ->willReturn(false);
$this->cacheTypeConfigMock->expects($this->once()) $this->cacheTypeConfigMock->expects($this->once())
->method('save') ->method('save')
->with(json_encode($options), 'DIRECTORY_COUNTRY_SELECT_STORE_' . $storeCode) ->with('serializedData', 'DIRECTORY_COUNTRY_SELECT_STORE_' . $storeCode)
->willReturnSelf(); ->willReturnSelf();
$this->scopeConfigMock->expects($this->once()) $this->scopeConfigMock->expects($this->once())
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment