Skip to content
Snippets Groups Projects
Commit c8cad08b authored by Oleksii Korshenko's avatar Oleksii Korshenko Committed by GitHub
Browse files

MAGETWO-85610: magento/magento2#12656: Checkout: Whitespace in front of coupon...

MAGETWO-85610: magento/magento2#12656: Checkout: Whitespace in front of coupon code causes "Coupon code is not valid" #1021
parents 0383196d 62f6e35e
Branches
No related merge requests found
......@@ -50,6 +50,7 @@ class CouponManagement implements CouponManagementInterface
*/
public function set($cartId, $couponCode)
{
$couponCode = trim($couponCode);
/** @var \Magento\Quote\Model\Quote $quote */
$quote = $this->quoteRepository->getActive($cartId);
if (!$quote->getItemsCount()) {
......
......@@ -297,4 +297,46 @@ class CouponManagementTest extends WebapiAbstract
$this->assertEquals($quoteWithCoupon->getCouponCode(), $couponCode);
}
/**
* @magentoApiDataFixture Magento/Sales/_files/quote.php
* @magentoApiDataFixture Magento/Checkout/_files/discount_10percent.php
*/
public function testSetCouponWihSpaces()
{
/** @var \Magento\Quote\Model\Quote $quote */
$quote = $this->objectManager->create(\Magento\Quote\Model\Quote::class);
$quote->load('test01', 'reserved_order_id');
$cartId = $quote->getId();
/** @var \Magento\SalesRule\Model\Rule $salesRule */
$salesRule = $this->objectManager->create(\Magento\SalesRule\Model\Rule::class);
$salesRuleId = $this->objectManager->get(\Magento\Framework\Registry::class)
->registry('Magento/Checkout/_file/discount_10percent');
$salesRule->load($salesRuleId);
$couponCode = $salesRule->getPrimaryCoupon()->getCode() ;
$serviceInfo = [
'rest' => [
'resourcePath' => self::RESOURCE_PATH . $cartId . '/coupons/'
. rawurlencode(' ') . $couponCode . rawurlencode(' '),
'httpMethod' => \Magento\Framework\Webapi\Rest\Request::HTTP_METHOD_PUT,
],
'soap' => [
'service' => self::SERVICE_NAME,
'serviceVersion' => self::SERVICE_VERSION,
'operation' => self::SERVICE_NAME . 'Set',
],
];
$requestData = [
"cartId" => $cartId,
"couponCode" => $couponCode,
];
$this->assertTrue($this->_webApiCall($serviceInfo, $requestData));
$quoteWithCoupon = $this->objectManager->create(\Magento\Quote\Model\Quote::class);
$quoteWithCoupon->load('test01', 'reserved_order_id');
$this->assertEquals($quoteWithCoupon->getCouponCode(), $couponCode);
}
}
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment