MAGETWO-36071: Move dev/tools/Magento/Tools/Dependency/generate/*.dependencies.php tools

- changed according to CR feedback

dev/tests/integration/testsuite/Magento/Test/Tools/Console/Command/DependenciesShowFrameworkCommandTest.php

@@ -3,7 +3,7 @@
  * Copyright © 2015 Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
-namespace Magento\Test\Tool\Console\Command;
+namespace Magento\Test\Tools\Console\Command;
 
 use Magento\Tools\Console\Command\DependenciesShowFrameworkCommand;
 use Symfony\Component\Console\Tester\CommandTester;
@@ -38,7 +38,7 @@ class DependenciesShowFrameworkCommandTest extends \PHPUnit_Framework_TestCase
         $this->commandTester->execute(
             ['--directory' => __DIR__ . '/_files/root', '--output' => __DIR__ . '/_files/output/framework.csv']
         );
-        $this->assertEquals('Report successfully processed.' . PHP_EOL , $this->commandTester->getDisplay());
+        $this->assertEquals('Report successfully processed.' . PHP_EOL, $this->commandTester->getDisplay());
         $this->assertFileEquals(
             __DIR__ . '/_files/expected/framework.csv',
             __DIR__ . '/_files/output/framework.csv'
@@ -49,7 +49,7 @@ class DependenciesShowFrameworkCommandTest extends \PHPUnit_Framework_TestCase
     {
         $this->commandTester->execute(['--directory' => '/invalid/path']);
         $this->assertContains(
-            'Please, check passed path. Dependencies report generator failed:',
+            'Please check the path you provided. Dependencies report generator failed with error:',
             $this->commandTester->getDisplay()
         );
     }

dev/tests/integration/testsuite/Magento/Test/Tools/Console/Command/DependenciesShowModulesCircularCommandTest.php

@@ -3,7 +3,7 @@
  * Copyright © 2015 Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
-namespace Magento\Test\Tool\Console\Command;
+namespace Magento\Test\Tools\Console\Command;
 
 use Magento\Tools\Console\Command\DependenciesShowModulesCircularCommand;
 use Symfony\Component\Console\Tester\CommandTester;
@@ -38,7 +38,7 @@ class DependenciesShowModulesCircularCommandTest extends \PHPUnit_Framework_Test
         $this->commandTester->execute(
             ['--directory' => __DIR__ . '/_files/root', '--output' => __DIR__ . '/_files/output/circular.csv']
         );
-        $this->assertEquals('Report successfully processed.' . PHP_EOL , $this->commandTester->getDisplay());
+        $this->assertEquals('Report successfully processed.' . PHP_EOL, $this->commandTester->getDisplay());
         $this->assertFileEquals(
             __DIR__ . '/_files/expected/circular.csv',
             __DIR__ . '/_files/output/circular.csv'
@@ -49,7 +49,7 @@ class DependenciesShowModulesCircularCommandTest extends \PHPUnit_Framework_Test
     {
         $this->commandTester->execute(['--directory' => '/invalid/path']);
         $this->assertContains(
-            'Please, check passed path. Dependencies report generator failed:',
+            'Please check the path you provided. Dependencies report generator failed with error:',
             $this->commandTester->getDisplay()
         );
     }

dev/tests/integration/testsuite/Magento/Test/Tools/Console/Command/DependenciesShowModulesCommandTest.php

@@ -3,7 +3,7 @@
  * Copyright © 2015 Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
-namespace Magento\Test\Tool\Console\Command;
+namespace Magento\Test\Tools\Console\Command;
 
 use Magento\Tools\Console\Command\DependenciesShowModulesCommand;
 use Symfony\Component\Console\Tester\CommandTester;
@@ -38,7 +38,7 @@ class DependenciesShowModulesCommandTest extends \PHPUnit_Framework_TestCase
         $this->commandTester->execute(
             ['--directory' => __DIR__ . '/_files/root', '--output' => __DIR__ . '/_files/output/modules.csv']
         );
-        $this->assertEquals('Report successfully processed.' . PHP_EOL , $this->commandTester->getDisplay());
+        $this->assertEquals('Report successfully processed.' . PHP_EOL, $this->commandTester->getDisplay());
         $this->assertFileEquals(
             __DIR__ . '/_files/expected/modules.csv',
             __DIR__ . '/_files/output/modules.csv'
@@ -49,7 +49,7 @@ class DependenciesShowModulesCommandTest extends \PHPUnit_Framework_TestCase
     {
         $this->commandTester->execute(['--directory' => '/invalid/path']);
         $this->assertContains(
-            'Please, check passed path. Dependencies report generator failed:',
+            'Please check the path you provided. Dependencies report generator failed with error:',
             $this->commandTester->getDisplay()
         );
     }

dev/tests/integration/testsuite/Magento/Test/Tools/Console/Command/_files/root/app/code/Magento/A/Model/Foo.php

@@ -7,6 +7,9 @@ namespace Magento\A\Model;
 
 class Foo
 {
+    /**
+     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
+     */
     public function foo()
     {
         $frameworkDependencies = new \Magento\Framework\A();

dev/tests/integration/testsuite/Magento/Test/Tools/Console/Command/_files/root/app/code/Magento/B/Model/Foo.php

@@ -7,6 +7,9 @@ namespace Magento\B\Model;
 
 class Foo
 {
+    /**
+     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
+     */
     public function foo()
     {
         $frameworkDependencies = new \Magento\Framework\B();

dev/tools/Magento/Tools/Console/Command/AbstractDependenciesCommand.php

@@ -40,8 +40,8 @@ abstract class AbstractDependenciesCommand extends Command
                     self::INPUT_KEY_OUTPUT,
                     'o',
                     InputOption::VALUE_REQUIRED,
-                    'Path to report file',
-                    $this->getDefaultOutputPath()
+                    'Report filename',
+                    $this->getDefaultOutputFilename()
                 )
             ]
         );
@@ -57,11 +57,11 @@ abstract class AbstractDependenciesCommand extends Command
     abstract protected function buildReport($outputPath);
 
     /**
-     * Get path to the default output report file
+     * Get the default output report filename
      *
      * @return string
      */
-    abstract protected function getDefaultOutputPath();
+    abstract protected function getDefaultOutputFilename();
 
     /**
      * {@inheritdoc}
@@ -74,7 +74,7 @@ abstract class AbstractDependenciesCommand extends Command
             $output->writeln('<info>Report successfully processed.</info>');
         } catch (\Exception $e) {
             $output->writeln(
-                '<error>Please, check passed path. Dependencies report generator failed: ' .
+                '<error>Please check the path you provided. Dependencies report generator failed with error: ' .
                 $e->getMessage() . '</error>'
             );
         }

dev/tools/Magento/Tools/Console/Command/DependenciesShowFrameworkCommand.php

@@ -24,11 +24,11 @@ class DependenciesShowFrameworkCommand extends AbstractDependenciesCommand
     }
 
     /**
-     * Return default output file for framework dependencies report
+     * Return default output filename for framework dependencies report
      *
      * @return string
      */
-    protected function getDefaultOutputPath()
+    protected function getDefaultOutputFilename()
     {
         return 'framework-dependencies.csv';
     }

dev/tools/Magento/Tools/Console/Command/DependenciesShowModulesCircularCommand.php

@@ -24,11 +24,11 @@ class DependenciesShowModulesCircularCommand extends AbstractDependenciesCommand
     }
 
     /**
-     * Return default output file for modules circular dependencies report
+     * Return default output filename for modules circular dependencies report
      *
      * @return string
      */
-    protected function getDefaultOutputPath()
+    protected function getDefaultOutputFilename()
     {
         return 'modules-circular-dependencies.csv';
     }

dev/tools/Magento/Tools/Console/Command/DependenciesShowModulesCommand.php

@@ -24,11 +24,11 @@ class DependenciesShowModulesCommand extends AbstractDependenciesCommand
     }
 
     /**
-     * Return default output file for modules dependencies report
+     * Return default output filename for modules dependencies report
      *
      * @return string
      */
-    protected function getDefaultOutputPath()
+    protected function getDefaultOutputFilename()
     {
         return 'modules-dependencies.csv';
     }