Skip to content
Snippets Groups Projects
Commit 912c613d authored by Bryant Luk's avatar Bryant Luk
Browse files

MAGETWO-36189: Customer-facing resources in Sales & Checkout APIs - "/mine" APIs

- Fix misspelling of overriden to overridden
parent d8fbae41
No related merge requests found
...@@ -43,7 +43,7 @@ class ParamOverriderCartId implements ParamOverriderInterface ...@@ -43,7 +43,7 @@ class ParamOverriderCartId implements ParamOverriderInterface
/** /**
* {@inheritDoc} * {@inheritDoc}
*/ */
public function getOverridenValue() public function getOverriddenValue()
{ {
try { try {
if ($this->userContext->getUserType() === UserContextInterface::USER_TYPE_CUSTOMER) { if ($this->userContext->getUserType() === UserContextInterface::USER_TYPE_CUSTOMER) {
......
...@@ -64,7 +64,7 @@ class ParamOverriderCartIdTest extends \PHPUnit_Framework_TestCase ...@@ -64,7 +64,7 @@ class ParamOverriderCartIdTest extends \PHPUnit_Framework_TestCase
->method('getId') ->method('getId')
->will($this->returnValue($retValue)); ->will($this->returnValue($retValue));
$this->assertSame($retValue, $this->model->getOverridenValue()); $this->assertSame($retValue, $this->model->getOverriddenValue());
} }
public function testGetOverridenValueIsCustomerAndCartDoesNotExist() public function testGetOverridenValueIsCustomerAndCartDoesNotExist()
...@@ -83,7 +83,7 @@ class ParamOverriderCartIdTest extends \PHPUnit_Framework_TestCase ...@@ -83,7 +83,7 @@ class ParamOverriderCartIdTest extends \PHPUnit_Framework_TestCase
->with($customerId) ->with($customerId)
->will($this->throwException(new NoSuchEntityException())); ->will($this->throwException(new NoSuchEntityException()));
$this->assertNull($this->model->getOverridenValue()); $this->assertNull($this->model->getOverriddenValue());
} }
public function testGetOverridenValueIsCustomerAndCartIsNull() public function testGetOverridenValueIsCustomerAndCartIsNull()
...@@ -102,7 +102,7 @@ class ParamOverriderCartIdTest extends \PHPUnit_Framework_TestCase ...@@ -102,7 +102,7 @@ class ParamOverriderCartIdTest extends \PHPUnit_Framework_TestCase
->with($customerId) ->with($customerId)
->will($this->returnValue(null)); ->will($this->returnValue(null));
$this->assertNull($this->model->getOverridenValue()); $this->assertNull($this->model->getOverriddenValue());
} }
public function testGetOverridenValueIsNotCustomer() public function testGetOverridenValueIsNotCustomer()
...@@ -111,6 +111,6 @@ class ParamOverriderCartIdTest extends \PHPUnit_Framework_TestCase ...@@ -111,6 +111,6 @@ class ParamOverriderCartIdTest extends \PHPUnit_Framework_TestCase
->method('getUserType') ->method('getUserType')
->will($this->returnValue(UserContextInterface::USER_TYPE_ADMIN)); ->will($this->returnValue(UserContextInterface::USER_TYPE_ADMIN));
$this->assertNull($this->model->getOverridenValue()); $this->assertNull($this->model->getOverriddenValue());
} }
} }
...@@ -32,7 +32,7 @@ class ParamOverriderCustomerId implements ParamOverriderInterface ...@@ -32,7 +32,7 @@ class ParamOverriderCustomerId implements ParamOverriderInterface
/** /**
* {@inheritDoc} * {@inheritDoc}
*/ */
public function getOverridenValue() public function getOverriddenValue()
{ {
if ($this->userContext->getUserType() === UserContextInterface::USER_TYPE_CUSTOMER) { if ($this->userContext->getUserType() === UserContextInterface::USER_TYPE_CUSTOMER) {
return $this->userContext->getUserId(); return $this->userContext->getUserId();
......
...@@ -44,7 +44,7 @@ class ParamsOverrider ...@@ -44,7 +44,7 @@ class ParamsOverrider
if ($paramData[Converter::KEY_FORCE] || !$this->isNestedArrayValueSet($inputData, $arrayKeys)) { if ($paramData[Converter::KEY_FORCE] || !$this->isNestedArrayValueSet($inputData, $arrayKeys)) {
$paramValue = $paramData[Converter::KEY_VALUE]; $paramValue = $paramData[Converter::KEY_VALUE];
if (isset($this->paramOverriders[$paramValue])) { if (isset($this->paramOverriders[$paramValue])) {
$value = $this->paramOverriders[$paramValue]->getOverridenValue(); $value = $this->paramOverriders[$paramValue]->getOverriddenValue();
} else { } else {
$value = $paramData[Converter::KEY_VALUE]; $value = $paramData[Converter::KEY_VALUE];
} }
......
...@@ -45,7 +45,7 @@ class ParamOverriderCustomerIdTest extends \PHPUnit_Framework_TestCase ...@@ -45,7 +45,7 @@ class ParamOverriderCustomerIdTest extends \PHPUnit_Framework_TestCase
->method('getUserId') ->method('getUserId')
->will($this->returnValue($retValue)); ->will($this->returnValue($retValue));
$this->assertSame($retValue, $this->model->getOverridenValue()); $this->assertSame($retValue, $this->model->getOverriddenValue());
} }
public function testGetOverridenValueIsNotCustomer() public function testGetOverridenValueIsNotCustomer()
...@@ -54,6 +54,6 @@ class ParamOverriderCustomerIdTest extends \PHPUnit_Framework_TestCase ...@@ -54,6 +54,6 @@ class ParamOverriderCustomerIdTest extends \PHPUnit_Framework_TestCase
->method('getUserType') ->method('getUserType')
->will($this->returnValue(UserContextInterface::USER_TYPE_ADMIN)); ->will($this->returnValue(UserContextInterface::USER_TYPE_ADMIN));
$this->assertNull($this->model->getOverridenValue()); $this->assertNull($this->model->getOverriddenValue());
} }
} }
...@@ -29,9 +29,9 @@ namespace Magento\Framework\Webapi\Rest\Request; ...@@ -29,9 +29,9 @@ namespace Magento\Framework\Webapi\Rest\Request;
interface ParamOverriderInterface interface ParamOverriderInterface
{ {
/** /**
* Returns the overriden value to use. * Returns the overridden value to use.
* *
* @return string|int|null * @return string|int|null
*/ */
public function getOverridenValue(); public function getOverriddenValue();
} }
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment