From 91854ca60d934d7bf7e2eaf3db207c7ddf27ed25 Mon Sep 17 00:00:00 2001
From: Kurniandha Sukma Yunastrian <13516106@std.stei.itb.ac.id>
Date: Fri, 7 May 2021 15:07:58 +0700
Subject: [PATCH] Refactor submit message

---
 app/Http/Controllers/ProjectController.php    |  6 ++--
 .../Controllers/RequirementController.php     |  2 +-
 resources/views/home.blade.php                | 16 +++++-----
 resources/views/project.blade.php             | 30 +++++--------------
 4 files changed, 18 insertions(+), 36 deletions(-)

diff --git a/app/Http/Controllers/ProjectController.php b/app/Http/Controllers/ProjectController.php
index a613a2a..4d0c8a3 100644
--- a/app/Http/Controllers/ProjectController.php
+++ b/app/Http/Controllers/ProjectController.php
@@ -80,7 +80,7 @@ class ProjectController extends Controller
             'role' => 1
         ]);
 
-        return redirect()->route('home', ['msg' => 1]);
+        return redirect()->route('home')->with('msg', 'Project added successfully');
     }
 
     /**
@@ -94,7 +94,7 @@ class ProjectController extends Controller
             'role' => 2
         ]);
 
-        return redirect()->route('project', ['id' => $request->projectId, 'msg' => 2]);
+        return redirect()->route('project', ['id' => $request->projectId])->with('msg', 'Member added successfully');
     }
 
     /**
@@ -104,6 +104,6 @@ class ProjectController extends Controller
     {
         DB::table('projects')->increment('phase');
 
-        return redirect()->route('project', ['id' => $request->projectId, 'msg' => 3]);
+        return redirect()->route('project', ['id' => $request->projectId])->with('msg', 'Phase updated successfully');
     }
 }
diff --git a/app/Http/Controllers/RequirementController.php b/app/Http/Controllers/RequirementController.php
index 2373004..0a8f0cb 100644
--- a/app/Http/Controllers/RequirementController.php
+++ b/app/Http/Controllers/RequirementController.php
@@ -32,6 +32,6 @@ class RequirementController extends Controller
             'score' => null
         ]);
 
-        return redirect()->route('project', ['id' => $request->projectId, 'msg' => 1]);
+        return redirect()->route('project', ['id' => $request->projectId])->with('msg', 'Requirement added successfully');
     }
 }
diff --git a/resources/views/home.blade.php b/resources/views/home.blade.php
index 5600731..1fcbb5b 100644
--- a/resources/views/home.blade.php
+++ b/resources/views/home.blade.php
@@ -2,15 +2,13 @@
 
 @section('content')
 <div class="container">
-    @isset(request()->msg)
-        @if( request()->get('msg') == 1 )
-            <div class="alert alert-success alert-dismissible fade show" role="alert">
-                Project added successfully
-                <button type="button" class="close" data-dismiss="alert" aria-label="Close">
-                    <span aria-hidden="true">&times;</span>
-                </button>
-            </div>
-        @endif
+    @if(Session::has('msg'))
+        <div class="alert alert-success alert-dismissible fade show" role="alert">
+            {{ Session::get('msg') }}
+            <button type="button" class="close" data-dismiss="alert" aria-label="Close">
+                <span aria-hidden="true">&times;</span>
+            </button>
+        </div>
     @endisset
     <div class="row justify-content-center">
         <div class="col-md-12">
diff --git a/resources/views/project.blade.php b/resources/views/project.blade.php
index bfd0fac..bbb269e 100644
--- a/resources/views/project.blade.php
+++ b/resources/views/project.blade.php
@@ -2,29 +2,13 @@
 
 @section('content')
 <div class="container">
-    @isset(request()->msg)
-        @if( request()->get('msg') == 1 )
-            <div class="alert alert-success alert-dismissible fade show" role="alert">
-                Requirement added successfully
-                <button type="button" class="close" data-dismiss="alert" aria-label="Close">
-                    <span aria-hidden="true">&times;</span>
-                </button>
-            </div>
-        @elseif( request()->get('msg') == 2 )
-            <div class="alert alert-success alert-dismissible fade show" role="alert">
-                Member added successfully
-                <button type="button" class="close" data-dismiss="alert" aria-label="Close">
-                    <span aria-hidden="true">&times;</span>
-                </button>
-            </div>
-        @elseif( request()->get('msg') == 3 )
-            <div class="alert alert-success alert-dismissible fade show" role="alert">
-                Phase updated successfully
-                <button type="button" class="close" data-dismiss="alert" aria-label="Close">
-                    <span aria-hidden="true">&times;</span>
-                </button>
-            </div>
-        @endif
+    @if(Session::has('msg'))
+        <div class="alert alert-success alert-dismissible fade show" role="alert">
+            {{ Session::get('msg') }}
+            <button type="button" class="close" data-dismiss="alert" aria-label="Close">
+                <span aria-hidden="true">&times;</span>
+            </button>
+        </div>
     @endisset
     <div class="row justify-content-center">
         <div class="col-md-8">
-- 
GitLab