From 45bff16ca6a53a79c96bc9b8d9e803e9cffd7c34 Mon Sep 17 00:00:00 2001
From: Ilham Firdausi Putra <ilhamfputra31@gmail.com>
Date: Sat, 23 Feb 2019 10:41:32 +0700
Subject: [PATCH] remove redundant variable on profile, home, and bot fragment
---
.../main/java/com/chatman/BotFragment.java | 30 ++-----------------
.../main/java/com/chatman/HomeFragment.java | 1 -
.../main/java/com/chatman/MainActivity.java | 9 ------
.../java/com/chatman/ProfileFragment.java | 24 +--------------
4 files changed, 4 insertions(+), 60 deletions(-)
diff --git a/android/app/src/main/java/com/chatman/BotFragment.java b/android/app/src/main/java/com/chatman/BotFragment.java
index 842c3d9..254883a 100644
--- a/android/app/src/main/java/com/chatman/BotFragment.java
+++ b/android/app/src/main/java/com/chatman/BotFragment.java
@@ -18,14 +18,6 @@ import android.view.ViewGroup;
* create an instance of this fragment.
*/
public class BotFragment extends Fragment {
- // TODO: Rename parameter arguments, choose names that match
- // the fragment initialization parameters, e.g. ARG_ITEM_NUMBER
- private static final String ARG_PARAM1 = "param1";
- private static final String ARG_PARAM2 = "param2";
-
- // TODO: Rename and change types of parameters
- private String mParam1;
- private String mParam2;
private OnFragmentInteractionListener mListener;
@@ -33,41 +25,25 @@ public class BotFragment extends Fragment {
// Required empty public constructor
}
- /**
- * Use this factory method to create a new instance of
- * this fragment using the provided parameters.
- *
- * @param param1 Parameter 1.
- * @param param2 Parameter 2.
- * @return A new instance of fragment BotFragment.
- */
- // TODO: Rename and change types and number of parameters
- public static BotFragment newInstance(String param1, String param2) {
+
+ public static BotFragment newInstance() {
BotFragment fragment = new BotFragment();
- Bundle args = new Bundle();
- args.putString(ARG_PARAM1, param1);
- args.putString(ARG_PARAM2, param2);
- fragment.setArguments(args);
return fragment;
}
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
- if (getArguments() != null) {
- mParam1 = getArguments().getString(ARG_PARAM1);
- mParam2 = getArguments().getString(ARG_PARAM2);
- }
}
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
Bundle savedInstanceState) {
+
// Inflate the layout for this fragment
return inflater.inflate(R.layout.fragment_bot, container, false);
}
- // TODO: Rename method, update argument and hook method into UI event
public void onButtonPressed(Uri uri) {
if (mListener != null) {
mListener.onFragmentInteraction(uri);
diff --git a/android/app/src/main/java/com/chatman/HomeFragment.java b/android/app/src/main/java/com/chatman/HomeFragment.java
index ec4c937..3eeacaa 100644
--- a/android/app/src/main/java/com/chatman/HomeFragment.java
+++ b/android/app/src/main/java/com/chatman/HomeFragment.java
@@ -64,7 +64,6 @@ public class HomeFragment extends Fragment {
return view;
}
- // TODO: Rename method, update argument and hook method into UI event
public void onButtonPressed(Uri uri) {
if (mListener != null) {
mListener.onFragmentInteraction(uri);
diff --git a/android/app/src/main/java/com/chatman/MainActivity.java b/android/app/src/main/java/com/chatman/MainActivity.java
index 3285408..a3bbfaa 100644
--- a/android/app/src/main/java/com/chatman/MainActivity.java
+++ b/android/app/src/main/java/com/chatman/MainActivity.java
@@ -40,8 +40,6 @@ public class MainActivity extends AppCompatActivity implements
private Context context;
private BottomNavigationView bottomNavbar;
- private Fragment fragment;
-
private BottomNavigationView.OnNavigationItemSelectedListener mOnNavigationItemSelectedListener
= new BottomNavigationView.OnNavigationItemSelectedListener() {
@@ -89,13 +87,6 @@ public class MainActivity extends AppCompatActivity implements
}
}
-// @Override
-// public boolean onCreateOptionsMenu(Menu menu) {
-// // Inflate the menu; this adds items to the action bar if it is present.
-// getMenuInflater().inflate(R.menu.main, menu);
-// return true;
-// }
-
public boolean loadFragment(Fragment fragment) {
diff --git a/android/app/src/main/java/com/chatman/ProfileFragment.java b/android/app/src/main/java/com/chatman/ProfileFragment.java
index 792e7b0..5fb4df3 100644
--- a/android/app/src/main/java/com/chatman/ProfileFragment.java
+++ b/android/app/src/main/java/com/chatman/ProfileFragment.java
@@ -29,14 +29,6 @@ import org.w3c.dom.Text;
* create an instance of this fragment.
*/
public class ProfileFragment extends Fragment {
- // TODO: Rename parameter arguments, choose names that match
- // the fragment initialization parameters, e.g. ARG_ITEM_NUMBER
- private static final String ARG_PARAM1 = "param1";
- private static final String ARG_PARAM2 = "param2";
-
- // TODO: Rename and change types of parameters
- private String mParam1;
- private String mParam2;
private ImageView profileImage;
private TextView profileName;
private Button buttonLogout;
@@ -47,21 +39,8 @@ public class ProfileFragment extends Fragment {
// Required empty public constructor
}
- /**
- * Use this factory method to create a new instance of
- * this fragment using the provided parameters.
- *
- * @param param1 Parameter 1.
- * @param param2 Parameter 2.
- * @return A new instance of fragment ProfileFragment.
- */
- // TODO: Rename and change types and number of parameters
- public static ProfileFragment newInstance(String param1, String param2) {
+ public static ProfileFragment newInstance() {
ProfileFragment fragment = new ProfileFragment();
- Bundle args = new Bundle();
- args.putString(ARG_PARAM1, param1);
- args.putString(ARG_PARAM2, param2);
- fragment.setArguments(args);
return fragment;
}
@@ -106,7 +85,6 @@ public class ProfileFragment extends Fragment {
}
- // TODO: Rename method, update argument and hook method into UI event
public void onButtonPressed(Uri uri) {
if (mListener != null) {
mListener.onFragmentInteraction(uri);
--
GitLab