diff --git a/app/code/Magento/Review/Test/Unit/Model/ResourceModel/Review/Product/CollectionTest.php b/app/code/Magento/Review/Test/Unit/Model/ResourceModel/Review/Product/CollectionTest.php index b1a1b9a69c7ff9905954385d7d685b87f9e2d273..4a61406e8a139bc0ee2688670e955b3e252db9a2 100644 --- a/app/code/Magento/Review/Test/Unit/Model/ResourceModel/Review/Product/CollectionTest.php +++ b/app/code/Magento/Review/Test/Unit/Model/ResourceModel/Review/Product/CollectionTest.php @@ -10,6 +10,11 @@ namespace Magento\Review\Test\Unit\Model\ResourceModel\Review\Product; */ class CollectionTest extends \PHPUnit_Framework_TestCase { + /** + * @var \Magento\Framework\TestFramework\Unit\Helper\ObjectManager + */ + private $objectManager; + /** * @var \Magento\Review\Model\ResourceModel\Review\Product\Collection */ @@ -74,16 +79,27 @@ class CollectionTest extends \PHPUnit_Framework_TestCase false ); $fetchStrategy->expects($this->any())->method('fetchAll')->will($this->returnValue([])); - $this->model = (new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this)) - ->getObject( - \Magento\Review\Model\ResourceModel\Review\Product\Collection::class, - [ - 'universalFactory' => $universalFactory, - 'storeManager' => $storeManager, - 'eavConfig' => $eavConfig, - 'fetchStrategy' => $fetchStrategy - ] - ); + $productLimitationMock = $this->getMock( + \Magento\Catalog\Model\ResourceModel\Product\Collection\ProductLimitation::class + ); + $this->objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this); + $this->objectManager->mockObjectManager([ + \Magento\Catalog\Model\ResourceModel\Product\Collection\ProductLimitation::class => $productLimitationMock + ]); + $this->model = $this->objectManager->getObject( + \Magento\Review\Model\ResourceModel\Review\Product\Collection::class, + [ + 'universalFactory' => $universalFactory, + 'storeManager' => $storeManager, + 'eavConfig' => $eavConfig, + 'fetchStrategy' => $fetchStrategy + ] + ); + } + + protected function tearDown() + { + $this->objectManager->restoreObjectManager(); } /** diff --git a/setup/src/Magento/Setup/Model/ConfigGenerator.php b/setup/src/Magento/Setup/Model/ConfigGenerator.php index 27b3999985743869cdf76fdb3c919d5c56bfecdd..ce86ce4dd471f01876fbc3ba87d6697b5156eea7 100644 --- a/setup/src/Magento/Setup/Model/ConfigGenerator.php +++ b/setup/src/Magento/Setup/Model/ConfigGenerator.php @@ -117,6 +117,7 @@ class ConfigGenerator * @param array $data * @return ConfigData * @deprecated + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function createDefinitionsConfig(array $data) { diff --git a/setup/src/Magento/Setup/Module/Di/Compiler/Config/Writer/Filesystem.php b/setup/src/Magento/Setup/Module/Di/Compiler/Config/Writer/Filesystem.php index add2b0adc8a111f6b3e9a0af2e21994cdb12233e..3207e590adf9746100da28785106b88e6af51ede 100644 --- a/setup/src/Magento/Setup/Module/Di/Compiler/Config/Writer/Filesystem.php +++ b/setup/src/Magento/Setup/Module/Di/Compiler/Config/Writer/Filesystem.php @@ -45,7 +45,7 @@ class Filesystem implements WriterInterface $this->initialize(); file_put_contents( - \Magento\Framework\App\ObjectManager\ConfigLoader\Compiled::getFilePath($key), + $this->directoryList->getPath(DirectoryList::DI) . '/' . $key . '.json', $this->getSerializer()->serialize($config) ); }