diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4e779e9213961dd03ee1e00070c485afdae4385e..d3b08fe76afdf48588eb524c503eba2854446f59 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,44 @@
+0.1.0-alpha105
+=============
+* Various improvements:
+ * Merged SQL and Data Upgrades for the Tax, Weee, Customer, CustomerImportExport, ProductAlert, Sendfriend and Wishlist modules
+ * Added 'Interface' suffix to all interface names
+ * Stabilized functional tests for the following modules:
+ * CheckoutAgreements
+ * Customer
+ * GiftMessage
+ * Integration
+ * Msrp
+ * Reports
+* Added the following functional tests:
+ * Create product attribute from product page
+* Fixed bugs:
+ * Fixed an issue where bundle product price doubled during backend order creation
+ * Fixed an issue where an error was thrown during Tax Rate creation, deletion and update
+ * Fixed an issue where FPT was doubled when creating a refund if two FPTs were applied, and as a result the refund could not be created
+ * Fixed an issue where the subtotal including tax field was not refreshed after removing downloadable product from cart
+ * Fixed an issue where a downloadable link tax was not added to a product price on the product page if price was displayed including tax
+ * Fixed an issue with incorrect product prices for bundle products in shopping cart
+ * Fixed an issue where bundle product price was calculated incorrectly on the product page
+ * Fixed an issue where configurable product options were not updated after changing currency
+ * Fixed an issue where a standalone simple product and the same product as part of the grouped, were not recognized as one product in the shopping cart.
+ * Fixed an issue where the incorrect tier pricing information was displayed in shopping cart
+ * Fixed an issue where no notice was displayed in the shopping cart for products with MAP enabled
+ * Fixed an issue where it was impossible to place an order from customer page in Admin
+ * Fixed an issue where it was impossible to add address for a customer in Admin
+ * Fixed an issue with broken redirect URL after deleting a product from the My Wishlist widget
+ * Fixed an issue where it was impossible to assign an admin user to a user role
+* Service Contracts:
+ * Implemented Service Contracts for the CatalogInventory Module
+* Framework Improvements:
+ * Added the ability to configure the list of loaded modules before installation
+ * Added the ability to use the Composer autoloader instead of the Magento custom autoloaders for tests
+ * Introduced a repository for storing a quote entity
+* Performance improvements:
+ * Split Magento\Customer\Helper\Data
+* Processed GitHub requests:
+ * [#731](https://github.com/magento/magento2/issues/731) -- Filter grid is absent on CMS Pages in Backend
+
0.1.0-alpha104
=============
* Various improvements:
diff --git a/app/autoload.php b/app/autoload.php
index bb250c9ee757b54255a3a621eb8add564947455f..e62465246c3480f46c31d9dc433ab8592d3893bf 100644
--- a/app/autoload.php
+++ b/app/autoload.php
@@ -23,6 +23,8 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
+use Magento\Framework\Autoload\AutoloaderRegistry;
+use Magento\Framework\Autoload\ClassLoaderWrapper;
/**
* Shortcut constant for the root directory
@@ -32,5 +34,10 @@ define('BP', dirname(__DIR__));
$vendorDir = require BP . '/app/etc/vendor_path.php';
$vendorAutoload = BP . "/{$vendorDir}/autoload.php";
if (file_exists($vendorAutoload)) {
- require_once $vendorAutoload;
+ $composerAutoloader = include $vendorAutoload;
}
+
+AutoloaderRegistry::registerAutoloader(new ClassLoaderWrapper($composerAutoloader));
+
+// Sets default autoload mappings, may be overridden in Bootstrap::create
+\Magento\Framework\App\Bootstrap::populateAutoloader(BP, []);
diff --git a/app/code/Magento/AdminNotification/composer.json b/app/code/Magento/AdminNotification/composer.json
index 0a12e71e6b93f78db7c4cc7be5e4a56e9f426fdb..4a6da5988567de588d3e67a775c64f7c6f89f7b8 100644
--- a/app/code/Magento/AdminNotification/composer.json
+++ b/app/code/Magento/AdminNotification/composer.json
@@ -3,15 +3,15 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"lib-libxml": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Authorization/composer.json b/app/code/Magento/Authorization/composer.json
index 2da1ea7e8af43e1ad370aed123019b3df69d534e..a6e58fc3c4dda203ff228fce4c545b8ad94da06c 100644
--- a/app/code/Magento/Authorization/composer.json
+++ b/app/code/Magento/Authorization/composer.json
@@ -3,12 +3,12 @@
"description": "Authorization module provides access to Magento ACL functionality.",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Authorizenet/Controller/Directpost/Payment.php b/app/code/Magento/Authorizenet/Controller/Directpost/Payment.php
index 507ebe70a832ac7457cb25af08a7dd0aeb4fcee2..a66e92a49067938adfd3dbe9470c6c48d8b0ce6b 100644
--- a/app/code/Magento/Authorizenet/Controller/Directpost/Payment.php
+++ b/app/code/Magento/Authorizenet/Controller/Directpost/Payment.php
@@ -134,10 +134,17 @@ class Payment extends \Magento\Framework\App\Action\Action
/* @var $order \Magento\Sales\Model\Order */
$order = $this->_objectManager->create('Magento\Sales\Model\Order')->loadByIncrementId($incrementId);
if ($order->getId()) {
- $quote = $this->_objectManager->create('Magento\Sales\Model\Quote')->load($order->getQuoteId());
- if ($quote->getId()) {
- $quote->setIsActive(1)->setReservedOrderId(null)->save();
+ try {
+ /** @var \Magento\Sales\Model\QuoteRepository $quoteRepository */
+ $quoteRepository = $this->_objectManager->create('Magento\Sales\Model\QuoteRepository');
+ /** @var \Magento\Sales\Model\Quote $quote */
+ $quote = $quoteRepository->get($order->getQuoteId());
+
+ $quote->setIsActive(1)->setReservedOrderId(null);
+ $quoteRepository->save($quote);
$this->_getCheckout()->replaceQuote($quote);
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+
}
$this->_getDirectPostSession()->removeCheckoutOrderIncrementId($incrementId);
$this->_getDirectPostSession()->unsetData('quote_id');
diff --git a/app/code/Magento/Authorizenet/Model/Directpost.php b/app/code/Magento/Authorizenet/Model/Directpost.php
index 0d0088aa172a57334268933b224c28549f8d8579..be220db35a250b29b14b592d6c82fd56ad3ce759 100644
--- a/app/code/Magento/Authorizenet/Model/Directpost.php
+++ b/app/code/Magento/Authorizenet/Model/Directpost.php
@@ -78,9 +78,9 @@ class Directpost extends \Magento\Authorizenet\Model\Authorizenet
protected $_storeManager;
/**
- * @var \Magento\Sales\Model\QuoteFactory
+ * @var \Magento\Sales\Model\QuoteRepository
*/
- protected $_quoteFactory;
+ protected $quoteRepository;
/**
* @var \Magento\Authorizenet\Model\Directpost\Response
@@ -113,7 +113,7 @@ class Directpost extends \Magento\Authorizenet\Model\Authorizenet
* @param \Magento\Framework\Session\SessionManagerInterface $session
* @param \Magento\Authorizenet\Helper\Data $authorizenetData
* @param \Magento\Framework\StoreManagerInterface $storeManager
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param \Magento\Authorizenet\Model\Directpost\RequestFactory $directRequestFactory
* @param \Magento\Authorizenet\Model\Directpost\Response $response
* @param \Magento\Authorizenet\Helper\HelperInterface $helper
@@ -138,7 +138,7 @@ class Directpost extends \Magento\Authorizenet\Model\Authorizenet
\Magento\Framework\Session\SessionManagerInterface $session,
\Magento\Authorizenet\Helper\Data $authorizenetData,
\Magento\Framework\StoreManagerInterface $storeManager,
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
\Magento\Authorizenet\Model\Directpost\RequestFactory $directRequestFactory,
\Magento\Authorizenet\Model\Directpost\Response $response,
\Magento\Authorizenet\Helper\HelperInterface $helper,
@@ -163,7 +163,7 @@ class Directpost extends \Magento\Authorizenet\Model\Authorizenet
$data
);
$this->_storeManager = $storeManager;
- $this->_quoteFactory = $quoteFactory;
+ $this->quoteRepository = $quoteRepository;
$this->_requestFactory = $directRequestFactory;
$this->_response = $response;
$this->_helper = $helper;
@@ -718,7 +718,8 @@ class Directpost extends \Magento\Authorizenet\Model\Authorizenet
$this->orderSender->send($order);
}
- $this->_quoteFactory->create()->load($order->getQuoteId())->setIsActive(false)->save();
+ $quote = $this->quoteRepository->get($order->getQuoteId())->setIsActive(false);
+ $this->quoteRepository->save($quote);
} catch (\Exception $e) {
// do not cancel order if we couldn't send email
}
diff --git a/app/code/Magento/Authorizenet/Model/Directpost/Session.php b/app/code/Magento/Authorizenet/Model/Directpost/Session.php
index 97e56477acc32a95402010a3657fb90c36483d45..a131ac2dbc158d312ce222d06e596bd05023d117 100644
--- a/app/code/Magento/Authorizenet/Model/Directpost/Session.php
+++ b/app/code/Magento/Authorizenet/Model/Directpost/Session.php
@@ -35,7 +35,7 @@ class Session extends \Magento\Framework\Session\SessionManager
* @param \Magento\Framework\Session\SaveHandlerInterface $saveHandler
* @param \Magento\Framework\Session\ValidatorInterface $validator
* @param \Magento\Framework\Session\StorageInterface $storage
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
* @internal param array $data
*/
@@ -46,7 +46,7 @@ class Session extends \Magento\Framework\Session\SessionManager
\Magento\Framework\Session\SaveHandlerInterface $saveHandler,
\Magento\Framework\Session\ValidatorInterface $validator,
\Magento\Framework\Session\StorageInterface $storage,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
) {
parent::__construct(
diff --git a/app/code/Magento/Authorizenet/composer.json b/app/code/Magento/Authorizenet/composer.json
index b70c369f0d14efe3dcd3f2aa643be22d833380ae..d1dc6d32c91f81a870e6703c2ed22b4c16e1929a 100644
--- a/app/code/Magento/Authorizenet/composer.json
+++ b/app/code/Magento/Authorizenet/composer.json
@@ -3,18 +3,18 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/module-centinel": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/module-centinel": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Backend/App/Action/Context.php b/app/code/Magento/Backend/App/Action/Context.php
index 9abde100f481719519315168a85e2564335cc5ae..76686148d03f3360732870eae35805880703df8b 100644
--- a/app/code/Magento/Backend/App/Action/Context.php
+++ b/app/code/Magento/Backend/App/Action/Context.php
@@ -76,7 +76,7 @@ class Context extends \Magento\Framework\App\Action\Context
/**
* @param \Magento\Framework\App\RequestInterface $request
* @param \Magento\Framework\App\ResponseInterface $response
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Event\ManagerInterface $eventManager
* @param \Magento\Framework\UrlInterface $url
* @param \Magento\Framework\App\Response\RedirectInterface $redirect
@@ -96,7 +96,7 @@ class Context extends \Magento\Framework\App\Action\Context
public function __construct(
\Magento\Framework\App\RequestInterface $request,
\Magento\Framework\App\ResponseInterface $response,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Event\ManagerInterface $eventManager,
\Magento\Framework\UrlInterface $url,
\Magento\Framework\App\Response\RedirectInterface $redirect,
diff --git a/app/code/Magento/Backend/Block/System/Config/Form/Field/Factory.php b/app/code/Magento/Backend/Block/System/Config/Form/Field/Factory.php
index 4aaf0290a8aad25af30adef7fee26c0bf97bb699..c55af7de25d679bdc66503aa9374f62c25c0be04 100644
--- a/app/code/Magento/Backend/Block/System/Config/Form/Field/Factory.php
+++ b/app/code/Magento/Backend/Block/System/Config/Form/Field/Factory.php
@@ -30,14 +30,14 @@ namespace Magento\Backend\Block\System\Config\Form\Field;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Block/System/Config/Form/Fieldset/Factory.php b/app/code/Magento/Backend/Block/System/Config/Form/Fieldset/Factory.php
index 383b8d8734f2cacc985786ebc7d3e94f2b9a987c..018e54feb66eea46f72a6e6129d1ec3668ce7278 100644
--- a/app/code/Magento/Backend/Block/System/Config/Form/Fieldset/Factory.php
+++ b/app/code/Magento/Backend/Block/System/Config/Form/Fieldset/Factory.php
@@ -30,14 +30,14 @@ namespace Magento\Backend\Block\System\Config\Form\Fieldset;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Auth/Session.php b/app/code/Magento/Backend/Model/Auth/Session.php
index b30534c6f72c540c0ffdde04d126056836043df6..220706b055fe042d2bd7729dacbf18319a2e8a57 100644
--- a/app/code/Magento/Backend/Model/Auth/Session.php
+++ b/app/code/Magento/Backend/Model/Auth/Session.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Backend\Model\Auth;
-use \Magento\Framework\Stdlib\CookieManager;
+use \Magento\Framework\Stdlib\CookieManagerInterface;
use \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory;
/**
@@ -77,7 +77,7 @@ class Session extends \Magento\Framework\Session\SessionManager implements \Mage
* @param \Magento\Framework\Session\SaveHandlerInterface $saveHandler
* @param \Magento\Framework\Session\ValidatorInterface $validator
* @param \Magento\Framework\Session\StorageInterface $storage
- * @param CookieManager $cookieManager
+ * @param CookieManagerInterface $cookieManager
* @param CookieMetadataFactory $cookieMetadataFactory
* @param \Magento\Framework\Acl\Builder $aclBuilder
* @param \Magento\Backend\Model\UrlInterface $backendUrl
@@ -90,7 +90,7 @@ class Session extends \Magento\Framework\Session\SessionManager implements \Mage
\Magento\Framework\Session\SaveHandlerInterface $saveHandler,
\Magento\Framework\Session\ValidatorInterface $validator,
\Magento\Framework\Session\StorageInterface $storage,
- CookieManager $cookieManager,
+ CookieManagerInterface $cookieManager,
CookieMetadataFactory $cookieMetadataFactory,
\Magento\Framework\Acl\Builder $aclBuilder,
\Magento\Backend\Model\UrlInterface $backendUrl,
diff --git a/app/code/Magento/Backend/Model/Authorization/RoleLocator.php b/app/code/Magento/Backend/Model/Authorization/RoleLocator.php
index 0735b8713f49df61fbc61ae46955649ec945b561..02f3fb5aa91ee64acbe3d48690f74a8875ad9fba 100644
--- a/app/code/Magento/Backend/Model/Authorization/RoleLocator.php
+++ b/app/code/Magento/Backend/Model/Authorization/RoleLocator.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Backend\Model\Authorization;
-class RoleLocator implements \Magento\Framework\Authorization\RoleLocator
+class RoleLocator implements \Magento\Framework\Authorization\RoleLocatorInterface
{
/**
* Authentication service
diff --git a/app/code/Magento/Backend/Model/Config/BackendClone/Factory.php b/app/code/Magento/Backend/Model/Config/BackendClone/Factory.php
index 1ec57da4550c884f356b82c67a90291da989f6a0..2b2a264f9a390112c9713bcc9fba8852a26c7792 100644
--- a/app/code/Magento/Backend/Model/Config/BackendClone/Factory.php
+++ b/app/code/Magento/Backend/Model/Config/BackendClone/Factory.php
@@ -30,14 +30,14 @@ namespace Magento\Backend\Model\Config\BackendClone;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Config/BackendFactory.php b/app/code/Magento/Backend/Model/Config/BackendFactory.php
index 60de26fbd36dd884d4d03dbf93893fcd8f8d9429..1d4e057348e9357a8f75a737c323a0977acc48fb 100644
--- a/app/code/Magento/Backend/Model/Config/BackendFactory.php
+++ b/app/code/Magento/Backend/Model/Config/BackendFactory.php
@@ -28,14 +28,14 @@ class BackendFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectmanager
+ * @param \Magento\Framework\ObjectManagerInterface $objectmanager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectmanager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectmanager)
{
$this->_objectManager = $objectmanager;
}
diff --git a/app/code/Magento/Backend/Model/Config/CommentFactory.php b/app/code/Magento/Backend/Model/Config/CommentFactory.php
index 6e10c4f87cf67aad5c16a789f2e3e8e49a0494e5..4209bdee707e1a79f91c377e07c958e753e4ad64 100644
--- a/app/code/Magento/Backend/Model/Config/CommentFactory.php
+++ b/app/code/Magento/Backend/Model/Config/CommentFactory.php
@@ -30,14 +30,14 @@ namespace Magento\Backend\Model\Config;
class CommentFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Config/Factory.php b/app/code/Magento/Backend/Model/Config/Factory.php
index ba07351dc511616a9932d545dcd0ae4035ca9197..cdb5176520f61a6eb02c6386b85e68f0f3085c66 100644
--- a/app/code/Magento/Backend/Model/Config/Factory.php
+++ b/app/code/Magento/Backend/Model/Config/Factory.php
@@ -30,14 +30,14 @@ namespace Magento\Backend\Model\Config;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Config/SourceFactory.php b/app/code/Magento/Backend/Model/Config/SourceFactory.php
index 723dac1481e500504434ece740e8764f5309bdcb..3833c0b701d1a12d5583edbe42abb1acf82fff59 100644
--- a/app/code/Magento/Backend/Model/Config/SourceFactory.php
+++ b/app/code/Magento/Backend/Model/Config/SourceFactory.php
@@ -28,14 +28,14 @@ class SourceFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Config/Structure/Element/Dependency/FieldFactory.php b/app/code/Magento/Backend/Model/Config/Structure/Element/Dependency/FieldFactory.php
index 7fcd8b79b1d2e86adeae77888d0aae8bd50776dd..f918adfdee70a3fc6b0c43deabdec2c779d598c5 100644
--- a/app/code/Magento/Backend/Model/Config/Structure/Element/Dependency/FieldFactory.php
+++ b/app/code/Magento/Backend/Model/Config/Structure/Element/Dependency/FieldFactory.php
@@ -26,14 +26,14 @@ namespace Magento\Backend\Model\Config\Structure\Element\Dependency;
class FieldFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Config/Structure/Element/FlyweightFactory.php b/app/code/Magento/Backend/Model/Config/Structure/Element/FlyweightFactory.php
index f75d1971617ce94ddaf96c0f26190ce450ec4028..8ce88728566b11334b8a4bd7dbd33760739e6444 100644
--- a/app/code/Magento/Backend/Model/Config/Structure/Element/FlyweightFactory.php
+++ b/app/code/Magento/Backend/Model/Config/Structure/Element/FlyweightFactory.php
@@ -26,7 +26,7 @@ namespace Magento\Backend\Model\Config\Structure\Element;
class FlyweightFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -42,9 +42,9 @@ class FlyweightFactory
);
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Config/Structure/Element/Group/Proxy.php b/app/code/Magento/Backend/Model/Config/Structure/Element/Group/Proxy.php
index 785aa9d378e55c29a9ce0e78e364a8a3e485954f..27cb814b77630ca481c14821e3553770583130ec 100644
--- a/app/code/Magento/Backend/Model/Config/Structure/Element/Group/Proxy.php
+++ b/app/code/Magento/Backend/Model/Config/Structure/Element/Group/Proxy.php
@@ -27,7 +27,7 @@ class Proxy extends \Magento\Backend\Model\Config\Structure\Element\Group
{
/**
* Object manager
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -37,9 +37,9 @@ class Proxy extends \Magento\Backend\Model\Config\Structure\Element\Group
protected $_subject;
/**
- * @param \Magento\Framework\ObjectManager $objectManger
+ * @param \Magento\Framework\ObjectManagerInterface $objectManger
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManger)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManger)
{
$this->_objectManager = $objectManger;
}
diff --git a/app/code/Magento/Backend/Model/Config/Structure/Mapper/Factory.php b/app/code/Magento/Backend/Model/Config/Structure/Mapper/Factory.php
index 8e0ffc191ebaa9a35c537afa3a59f376c7cd2f9a..8e442096470ca41bf90b381d20bd77d015534f92 100644
--- a/app/code/Magento/Backend/Model/Config/Structure/Mapper/Factory.php
+++ b/app/code/Magento/Backend/Model/Config/Structure/Mapper/Factory.php
@@ -42,7 +42,7 @@ class Factory
const MAPPER_EXTENDS = 'extends';
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -59,9 +59,9 @@ class Factory
);
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Config/Structure/Search/Proxy.php b/app/code/Magento/Backend/Model/Config/Structure/Search/Proxy.php
index 6f13dcc6c9fcad0a223b2f58db991ca2316a51c2..c1edfb4388efd6433222225b4171b0d2feca6593 100644
--- a/app/code/Magento/Backend/Model/Config/Structure/Search/Proxy.php
+++ b/app/code/Magento/Backend/Model/Config/Structure/Search/Proxy.php
@@ -27,7 +27,7 @@ class Proxy implements \Magento\Backend\Model\Config\Structure\SearchInterface
{
/**
* Object manager
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -37,9 +37,9 @@ class Proxy implements \Magento\Backend\Model\Config\Structure\SearchInterface
protected $_subject;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Menu/Builder/CommandFactory.php b/app/code/Magento/Backend/Model/Menu/Builder/CommandFactory.php
index 7cd22da49e3c60495dd5a905c3a5ebf0415b710a..3e939737c17c4762026806ad1a25bf79e5e617bf 100644
--- a/app/code/Magento/Backend/Model/Menu/Builder/CommandFactory.php
+++ b/app/code/Magento/Backend/Model/Menu/Builder/CommandFactory.php
@@ -29,14 +29,14 @@ namespace Magento\Backend\Model\Menu\Builder;
class CommandFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Menu/Item/Factory.php b/app/code/Magento/Backend/Model/Menu/Item/Factory.php
index 5a6d3516a3c71f5390c16f02cf4585aeaeb50353..0fdbb3c2eb61277e730ec25240a3fa56c2c7db81 100644
--- a/app/code/Magento/Backend/Model/Menu/Item/Factory.php
+++ b/app/code/Magento/Backend/Model/Menu/Item/Factory.php
@@ -26,14 +26,14 @@ namespace Magento\Backend\Model\Menu\Item;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/Model/Session.php b/app/code/Magento/Backend/Model/Session.php
index 966400d471ac4474b33e5df5da1c1e0c71689f3b..fa209a9f3939e1c16156a03696815ed922958de4 100644
--- a/app/code/Magento/Backend/Model/Session.php
+++ b/app/code/Magento/Backend/Model/Session.php
@@ -34,7 +34,7 @@ class Session extends \Magento\Framework\Session\SessionManager
* @param \Magento\Framework\Session\SaveHandlerInterface $saveHandler
* @param \Magento\Framework\Session\ValidatorInterface $validator
* @param \Magento\Framework\Session\StorageInterface $storage
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
*/
public function __construct(
@@ -44,7 +44,7 @@ class Session extends \Magento\Framework\Session\SessionManager
\Magento\Framework\Session\SaveHandlerInterface $saveHandler,
\Magento\Framework\Session\ValidatorInterface $validator,
\Magento\Framework\Session\StorageInterface $storage,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
) {
parent::__construct(
diff --git a/app/code/Magento/Backend/Model/Session/Quote.php b/app/code/Magento/Backend/Model/Session/Quote.php
index 6f0072df3029fe1595f3880deaaa9bec8c56e0f9..5239bed9d376eb910a88f5d13ce4269f4639f668 100644
--- a/app/code/Magento/Backend/Model/Session/Quote.php
+++ b/app/code/Magento/Backend/Model/Session/Quote.php
@@ -45,21 +45,21 @@ class Quote extends \Magento\Framework\Session\SessionManager
*
* @var \Magento\Sales\Model\Quote
*/
- protected $_quote = null;
+ protected $_quote;
/**
* Store model object
*
* @var \Magento\Store\Model\Store
*/
- protected $_store = null;
+ protected $_store;
/**
* Order model object
*
* @var \Magento\Sales\Model\Order
*/
- protected $_order = null;
+ protected $_order;
/**
* @var \Magento\Sales\Model\OrderFactory
@@ -72,9 +72,11 @@ class Quote extends \Magento\Framework\Session\SessionManager
protected $_customerService;
/**
- * @var \Magento\Sales\Model\QuoteFactory
+ * Sales quote repository
+ *
+ * @var \Magento\Sales\Model\QuoteRepository
*/
- protected $_quoteFactory;
+ protected $quoteRepository;
/**
* @var \Magento\Framework\StoreManagerInterface
@@ -87,15 +89,17 @@ class Quote extends \Magento\Framework\Session\SessionManager
protected $_scopeConfig;
/**
+ * Constructor
+ *
* @param \Magento\Framework\App\Request\Http $request
* @param \Magento\Framework\Session\SidResolverInterface $sidResolver
* @param \Magento\Framework\Session\Config\ConfigInterface $sessionConfig
* @param \Magento\Framework\Session\SaveHandlerInterface $saveHandler
* @param \Magento\Framework\Session\ValidatorInterface $validator
* @param \Magento\Framework\Session\StorageInterface $storage
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param \Magento\Customer\Service\V1\CustomerAccountServiceInterface $customerService
* @param \Magento\Sales\Model\OrderFactory $orderFactory
* @param \Magento\Framework\StoreManagerInterface $storeManager
@@ -108,15 +112,15 @@ class Quote extends \Magento\Framework\Session\SessionManager
\Magento\Framework\Session\SaveHandlerInterface $saveHandler,
\Magento\Framework\Session\ValidatorInterface $validator,
\Magento\Framework\Session\StorageInterface $storage,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory,
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
\Magento\Customer\Service\V1\CustomerAccountServiceInterface $customerService,
\Magento\Sales\Model\OrderFactory $orderFactory,
\Magento\Framework\StoreManagerInterface $storeManager,
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
) {
- $this->_quoteFactory = $quoteFactory;
+ $this->quoteRepository = $quoteRepository;
$this->_customerService = $customerService;
$this->_orderFactory = $orderFactory;
$this->_storeManager = $storeManager;
@@ -144,31 +148,32 @@ class Quote extends \Magento\Framework\Session\SessionManager
*/
public function getQuote()
{
- if (is_null($this->_quote)) {
- $this->_quote = $this->_quoteFactory->create();
- if ($this->getStoreId() && $this->getQuoteId()) {
- $this->_quote->setStoreId($this->getStoreId())->load($this->getQuoteId());
- } elseif ($this->getStoreId() && $this->hasCustomerId()) {
- $customerGroupId = $this->_scopeConfig->getValue(
- \Magento\Customer\Service\V1\CustomerGroupServiceInterface::XML_PATH_DEFAULT_ID,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- $this->_quote
- ->setStoreId($this->getStoreId())
- ->setCustomerGroupId($customerGroupId)
- ->setIsActive(false)
- ->save();
- $this->setQuoteId($this->_quote->getId());
- try {
- $customerData = $this->_customerService->getCustomer($this->getCustomerId());
- $this->_quote->assignCustomer($customerData);
- } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
- /** Customer does not exist */
+ if ($this->_quote === null) {
+ $this->_quote = $this->quoteRepository->create();
+ if ($this->getStoreId()) {
+ if (!$this->getQuoteId()) {
+ $customerGroupId = $this->_scopeConfig->getValue(
+ \Magento\Customer\Service\V1\CustomerGroupServiceInterface::XML_PATH_DEFAULT_ID,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE
+ );
+ $this->_quote->setCustomerGroupId($customerGroupId)
+ ->setIsActive(false)
+ ->setStoreId($this->getStoreId());
+ $this->quoteRepository->save($this->_quote);
+ $this->setQuoteId($this->_quote->getId());
+ } else {
+ $this->_quote = $this->quoteRepository->get($this->getQuoteId());
+ $this->_quote->setStoreId($this->getStoreId());
+ }
+
+ if ($this->getCustomerId()) {
+ $this->_quote->assignCustomer($this->_customerService->getCustomer($this->getCustomerId()));
}
}
$this->_quote->setIgnoreOldQty(true);
$this->_quote->setIsSuperMode(true);
}
+
return $this->_quote;
}
diff --git a/app/code/Magento/Backend/Model/Widget/Grid/Row/UrlGeneratorFactory.php b/app/code/Magento/Backend/Model/Widget/Grid/Row/UrlGeneratorFactory.php
index 24e0fadf121d5071435d162ded9e9eb33d4ca0df..cea99ebdb8974e971a52b1103d9aaf9f16305b28 100644
--- a/app/code/Magento/Backend/Model/Widget/Grid/Row/UrlGeneratorFactory.php
+++ b/app/code/Magento/Backend/Model/Widget/Grid/Row/UrlGeneratorFactory.php
@@ -31,14 +31,14 @@ namespace Magento\Backend\Model\Widget\Grid\Row;
class UrlGeneratorFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backend/composer.json b/app/code/Magento/Backend/composer.json
index bdb90397bc7591a2876cc87a178e9b1274133c33..af0fd86131c36313418c3a6147d600fe1594d8a3 100644
--- a/app/code/Magento/Backend/composer.json
+++ b/app/code/Magento/Backend/composer.json
@@ -3,26 +3,26 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-cron": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-reports": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-user": "0.1.0-alpha104",
- "magento/module-backup": "0.1.0-alpha104",
- "magento/module-email": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-translation": "0.1.0-alpha104",
- "magento/module-require-js": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-cron": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-reports": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-user": "0.1.0-alpha105",
+ "magento/module-backup": "0.1.0-alpha105",
+ "magento/module-email": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-translation": "0.1.0-alpha105",
+ "magento/module-require-js": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Backend/etc/adminhtml/di.xml b/app/code/Magento/Backend/etc/adminhtml/di.xml
index 260504af39ff3937d957772fc6cf5c8b3fecae9f..efa3a861b1bb9733b9b1481ffcb33fca26664562 100644
--- a/app/code/Magento/Backend/etc/adminhtml/di.xml
+++ b/app/code/Magento/Backend/etc/adminhtml/di.xml
@@ -24,7 +24,7 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../lib/internal/Magento/Framework/ObjectManager/etc/config.xsd">
- <preference for="Magento\Framework\Authorization\RoleLocator" type="Magento\Backend\Model\Authorization\RoleLocator" />
+ <preference for="Magento\Framework\Authorization\RoleLocatorInterface" type="Magento\Backend\Model\Authorization\RoleLocator" />
<preference for="Magento\Framework\Locale\ResolverInterface" type="Magento\Backend\Model\Locale\Resolver" />
<preference for="Magento\Framework\App\Action\Context" type="Magento\Backend\App\Action\Context" />
<preference for="Magento\Framework\UrlInterface" type="Magento\Backend\Model\UrlInterface" />
diff --git a/app/code/Magento/Backend/etc/di.xml b/app/code/Magento/Backend/etc/di.xml
index 14b29b543523d51033e5cc45d8460f187675d64b..faa8d7fc6cd3a9ecef42ea5f23403e80ca05dfed 100644
--- a/app/code/Magento/Backend/etc/di.xml
+++ b/app/code/Magento/Backend/etc/di.xml
@@ -104,6 +104,7 @@
<argument name="authSession" xsi:type="object">Magento\Backend\Model\Auth\Session\Proxy</argument>
<argument name="formKey" xsi:type="object">Magento\Framework\Data\Form\FormKey\Proxy</argument>
<argument name="scopeType" xsi:type="const">Magento\Store\Model\ScopeInterface::SCOPE_STORE</argument>
+ <argument name="backendHelper" xsi:type="object">Magento\Backend\Helper\Data\Proxy</argument>
</arguments>
</type>
<type name="Magento\Backend\Helper\Dashboard\Data">
@@ -111,8 +112,8 @@
<argument name="installDate" xsi:type="init_parameter">Magento\Framework\App\State::PARAM_INSTALL_DATE</argument>
</arguments>
</type>
- <preference for="Magento\Framework\Authorization\RoleLocator" type="Magento\Backend\Model\Authorization\RoleLocator" />
- <preference for="Magento\Framework\Authorization\Policy" type="Magento\Framework\Authorization\Policy\Acl"/>
+ <preference for="Magento\Framework\Authorization\RoleLocatorInterface" type="Magento\Backend\Model\Authorization\RoleLocator" />
+ <preference for="Magento\Framework\Authorization\PolicyInterface" type="Magento\Framework\Authorization\Policy\Acl"/>
<preference for="Magento\Framework\Acl\Resource\ProviderInterface" type="Magento\Framework\Acl\Resource\Provider"/>
<type name="Magento\Framework\Acl\Resource\Config\Reader\Filesystem">
<arguments>
diff --git a/app/code/Magento/Backup/Model/BackupFactory.php b/app/code/Magento/Backup/Model/BackupFactory.php
index b1295b731c7f1c1a697501ede188835f7e8be6f7..4b13f0cc823a1e88ad5ed3d104408d2a26c166a1 100644
--- a/app/code/Magento/Backup/Model/BackupFactory.php
+++ b/app/code/Magento/Backup/Model/BackupFactory.php
@@ -32,14 +32,14 @@ namespace Magento\Backup\Model;
class BackupFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Backup/composer.json b/app/code/Magento/Backup/composer.json
index 5d96e1b15253d1e87cc3a524704e92ccabfa9876..d0e6a4635db58e587e6af594f8f3dc9a9aacd250 100644
--- a/app/code/Magento/Backup/composer.json
+++ b/app/code/Magento/Backup/composer.json
@@ -3,15 +3,15 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-cron": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-cron": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle.php b/app/code/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle.php
index 929edba7102cdfda4b9fb6dfde278e646d8f384a..b73e753e64e2b0098c463788874b5b49f52beb3b 100644
--- a/app/code/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle.php
+++ b/app/code/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle.php
@@ -277,7 +277,7 @@ class Bundle extends \Magento\Catalog\Block\Product\View\AbstractView
$productAmount = $currentProduct
->getPriceInfo()
->getPrice(\Magento\Catalog\Pricing\Price\FinalPrice::PRICE_CODE)
- ->getAmount();
+ ->getPriceWithoutOption();
$baseProductAmount = $currentProduct
->getPriceInfo()
diff --git a/app/code/Magento/Bundle/Block/Checkout/Cart/Item/Renderer.php b/app/code/Magento/Bundle/Block/Checkout/Cart/Item/Renderer.php
index f37b1d3f06aa4da4701013fe3b2f697480823361..ba5b5dede1c3655c779d62c2a65422788d077fef 100644
--- a/app/code/Magento/Bundle/Block/Checkout/Cart/Item/Renderer.php
+++ b/app/code/Magento/Bundle/Block/Checkout/Cart/Item/Renderer.php
@@ -43,7 +43,7 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer
*
* @var Configuration
*/
- protected $_bundleProdConfigur = null;
+ protected $_bundleProductConfiguration = null;
/**
* @param \Magento\Framework\View\Element\Template\Context $context
@@ -53,7 +53,8 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer
* @param \Magento\Core\Helper\Url $urlHelper
* @param \Magento\Framework\Message\ManagerInterface $messageManager
* @param PriceCurrencyInterface $priceCurrency
- * @param Configuration $bundleProdConfigur
+ * @param Configuration $bundleProductConfiguration
+ * @param \Magento\Framework\Module\Manager $moduleManager
* @param array $data
*/
public function __construct(
@@ -64,10 +65,11 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer
\Magento\Core\Helper\Url $urlHelper,
\Magento\Framework\Message\ManagerInterface $messageManager,
PriceCurrencyInterface $priceCurrency,
- Configuration $bundleProdConfigur,
+ \Magento\Framework\Module\Manager $moduleManager,
+ Configuration $bundleProductConfiguration,
array $data = array()
) {
- $this->_bundleProdConfigur = $bundleProdConfigur;
+ $this->_bundleProductConfiguration = $bundleProductConfiguration;
parent::__construct(
$context,
$productConfig,
@@ -76,6 +78,7 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer
$urlHelper,
$messageManager,
$priceCurrency,
+ $moduleManager,
$data
);
$this->_isScopePrivate = true;
@@ -87,7 +90,7 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer
protected function _construct()
{
parent::_construct();
- $this->_configurationHelper = $this->_bundleProdConfigur;
+ $this->_configurationHelper = $this->_bundleProductConfiguration;
}
/**
@@ -112,7 +115,7 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer
*/
protected function _getSelectionFinalPrice($selectionProduct)
{
- $helper = $this->_bundleProdConfigur;
+ $helper = $this->_bundleProductConfiguration;
$result = $helper->getSelectionFinalPrice($this->getItem(), $selectionProduct);
return $result;
}
diff --git a/app/code/Magento/Bundle/Pricing/Adjustment/BundleCalculatorInterface.php b/app/code/Magento/Bundle/Pricing/Adjustment/BundleCalculatorInterface.php
index 0c24bb0aee716af757fbb51a237be22c622f61b7..0f8def29c1b8205cbdd302e2c232ed8334fa218e 100644
--- a/app/code/Magento/Bundle/Pricing/Adjustment/BundleCalculatorInterface.php
+++ b/app/code/Magento/Bundle/Pricing/Adjustment/BundleCalculatorInterface.php
@@ -85,4 +85,11 @@ interface BundleCalculatorInterface extends CalculatorInterface
* @return \Magento\Bundle\Pricing\Price\BundleSelectionPrice[]
*/
public function processOptions($option, $selectionPriceList, $searchMin = true);
+
+ /**
+ * @param float $amount
+ * @param Product $saleableItem
+ * @return \Magento\Framework\Pricing\Amount\AmountInterface
+ */
+ public function getAmountWithoutOption($amount, Product $saleableItem);
}
diff --git a/app/code/Magento/Bundle/Pricing/Adjustment/Calculator.php b/app/code/Magento/Bundle/Pricing/Adjustment/Calculator.php
index 15650e0e388745c45e623686308ccb440fd4ed7c..0f65628eabe1be4b53d1b71c2841757d49459a98 100644
--- a/app/code/Magento/Bundle/Pricing/Adjustment/Calculator.php
+++ b/app/code/Magento/Bundle/Pricing/Adjustment/Calculator.php
@@ -139,6 +139,22 @@ class Calculator implements BundleCalculatorInterface
);
}
+ /**
+ * Get base amount without option
+ *
+ * @param float $amount
+ * @param Product $saleableItem
+ * @return \Magento\Framework\Pricing\Amount\AmountInterface|void
+ */
+ public function getAmountWithoutOption($amount, Product $saleableItem)
+ {
+ return $this->calculateBundleAmount(
+ $amount,
+ $saleableItem,
+ []
+ );
+ }
+
/**
* Filter all options for bundle product
*
diff --git a/app/code/Magento/Bundle/Pricing/Price/BundleSelectionFactory.php b/app/code/Magento/Bundle/Pricing/Price/BundleSelectionFactory.php
index 473cd58d3cf94a61c4b76ec7518435d49d89756c..6d10f815e080d2164510ab3a4abf85f6f634f33d 100644
--- a/app/code/Magento/Bundle/Pricing/Price/BundleSelectionFactory.php
+++ b/app/code/Magento/Bundle/Pricing/Price/BundleSelectionFactory.php
@@ -39,16 +39,16 @@ class BundleSelectionFactory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Bundle/Pricing/Price/FinalPrice.php b/app/code/Magento/Bundle/Pricing/Price/FinalPrice.php
index ea0d37e105aa9136d586acfefeea1c5b9568e2b5..bf177c97d642a552c733877e63aa06329209383d 100644
--- a/app/code/Magento/Bundle/Pricing/Price/FinalPrice.php
+++ b/app/code/Magento/Bundle/Pricing/Price/FinalPrice.php
@@ -31,7 +31,7 @@ use Magento\Catalog\Pricing\Price\BasePrice;
/**
* Final price model
*/
-class FinalPrice extends \Magento\Catalog\Pricing\Price\FinalPrice
+class FinalPrice extends \Magento\Catalog\Pricing\Price\FinalPrice implements FinalPriceInterface
{
/**
* @param Product $saleableItem
@@ -87,6 +87,16 @@ class FinalPrice extends \Magento\Catalog\Pricing\Price\FinalPrice
return $this->calculator->getAmount(parent::getValue(), $this->product);
}
+ /**
+ * get bundle product price without any option
+ *
+ * @return \Magento\Framework\Pricing\Amount\AmountInterface
+ */
+ public function getPriceWithoutOption()
+ {
+ return $this->calculator->getAmountWithoutOption(parent::getValue(), $this->product);
+ }
+
/**
* Returns option price
*
diff --git a/app/code/Magento/Bundle/Pricing/Price/FinalPriceInterface.php b/app/code/Magento/Bundle/Pricing/Price/FinalPriceInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..4094b2e4c6a4041ecf81e5cc2ea2144834429b9c
--- /dev/null
+++ b/app/code/Magento/Bundle/Pricing/Price/FinalPriceInterface.php
@@ -0,0 +1,36 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Bundle\Pricing\Price;
+
+/**
+ * Interface FinalPriceInterface
+ */
+interface FinalPriceInterface extends \Magento\Catalog\Pricing\Price\FinalPriceInterface
+{
+ /**
+ * @return \Magento\Framework\Pricing\Amount\AmountInterface
+ */
+ public function getPriceWithoutOption();
+}
diff --git a/app/code/Magento/Bundle/composer.json b/app/code/Magento/Bundle/composer.json
index 3da664632b69b2191d846b4edc09e31b5d45de9b..6589a6630d2b9a0c6e9339421f2a25ef956e2fb9 100644
--- a/app/code/Magento/Bundle/composer.json
+++ b/app/code/Magento/Bundle/composer.json
@@ -3,24 +3,24 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-catalog-rule": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-gift-message": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
- "magento/module-webapi": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-catalog-rule": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-gift-message": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
+ "magento/module-webapi": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/radio.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/radio.phtml
index 589c14a555ca812fd648325a4d405bdd7895a5c2..ed169a66c5ead02b3caa724da982011384c3fd8a 100644
--- a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/radio.phtml
+++ b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/radio.phtml
@@ -38,7 +38,7 @@
<?php echo $this->getSelectionTitlePrice($_selections[0]) ?>
<input type="hidden" name="bundle_option[<?php echo $_option->getId() ?>]"
value="<?php echo $_selections[0]->getSelectionId() ?>"
- price="<?php echo $this->getSelectionPrice($_selections[0]) ?>"/>
+ price="<?php echo $this->getSelectionPrice($_selections[0]) ?>" />
<?php else:?>
<?php if (!$_option->getRequired()): ?>
<div class="field choice">
diff --git a/app/code/Magento/Captcha/Model/CaptchaFactory.php b/app/code/Magento/Captcha/Model/CaptchaFactory.php
index 22a7a899b1786c76d71e46c3ba8bcb2d7eb29e9d..b18a03741ee6cc02ae7d74dfb68ed7459867184b 100644
--- a/app/code/Magento/Captcha/Model/CaptchaFactory.php
+++ b/app/code/Magento/Captcha/Model/CaptchaFactory.php
@@ -28,14 +28,14 @@ namespace Magento\Captcha\Model;
class CaptchaFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Captcha/Model/Observer.php b/app/code/Magento/Captcha/Model/Observer.php
index 9704e53eebca7c180cfa6a0e4e47efad38e3319e..350c7fac8cebb386fec486182aa77b13325a30ff 100644
--- a/app/code/Magento/Captcha/Model/Observer.php
+++ b/app/code/Magento/Captcha/Model/Observer.php
@@ -47,9 +47,9 @@ class Observer
/**
* Customer data
*
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerData;
+ protected $_customerUrl;
/**
* Core data
@@ -98,7 +98,7 @@ class Observer
* @param \Magento\Framework\Session\SessionManagerInterface $session
* @param \Magento\Checkout\Model\Type\Onepage $typeOnepage
* @param \Magento\Core\Helper\Data $coreData
- * @param \Magento\Customer\Helper\Data $customerData
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param \Magento\Captcha\Helper\Data $helper
* @param \Magento\Framework\UrlInterface $urlManager
* @param \Magento\Framework\App\RequestInterface $request
@@ -113,7 +113,7 @@ class Observer
\Magento\Framework\Session\SessionManagerInterface $session,
\Magento\Checkout\Model\Type\Onepage $typeOnepage,
\Magento\Core\Helper\Data $coreData,
- \Magento\Customer\Helper\Data $customerData,
+ \Magento\Customer\Model\Url $customerUrl,
\Magento\Captcha\Helper\Data $helper,
\Magento\Framework\UrlInterface $urlManager,
\Magento\Framework\App\RequestInterface $request,
@@ -125,7 +125,7 @@ class Observer
$this->_session = $session;
$this->_typeOnepage = $typeOnepage;
$this->_coreData = $coreData;
- $this->_customerData = $customerData;
+ $this->_customerUrl = $customerUrl;
$this->_helper = $helper;
$this->_urlManager = $urlManager;
$this->_request = $request;
@@ -197,7 +197,7 @@ class Observer
$this->_actionFlag->set('', \Magento\Framework\App\Action\Action::FLAG_NO_DISPATCH, true);
$this->_session->setUsername($login);
$beforeUrl = $this->_session->getBeforeAuthUrl();
- $url = $beforeUrl ? $beforeUrl : $this->_customerData->getLoginUrl();
+ $url = $beforeUrl ? $beforeUrl : $this->_customerUrl->getLoginUrl();
$controller->getResponse()->setRedirect($url);
}
}
diff --git a/app/code/Magento/Captcha/composer.json b/app/code/Magento/Captcha/composer.json
index b49a2e0e8a4d2a1f993395ae8fc6f40181c2623c..97ac3de59e0a37fb1bcc42ae90f6e232e48a0d11 100644
--- a/app/code/Magento/Captcha/composer.json
+++ b/app/code/Magento/Captcha/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Inventory.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Inventory.php
index 42e110173f360f01a5e825220988f6f973cfecbb..4d2a900201cfb17a66d49f9bc06bb9bdce69a0c1 100644
--- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Inventory.php
+++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Inventory.php
@@ -21,11 +21,8 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-
namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Action\Attribute\Tab;
-use Magento\CatalogInventory\Model\Stock\Item;
-
/**
* Products mass update inventory tab
*/
@@ -36,17 +33,25 @@ class Inventory extends \Magento\Backend\Block\Widget implements \Magento\Backen
*/
protected $_backorders;
+ /**
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface
+ */
+ protected $stockConfiguration;
+
/**
* @param \Magento\Backend\Block\Template\Context $context
* @param \Magento\CatalogInventory\Model\Source\Backorders $backorders
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param array $data
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
\Magento\CatalogInventory\Model\Source\Backorders $backorders,
- array $data = array()
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
+ array $data = []
) {
$this->_backorders = $backorders;
+ $this->stockConfiguration = $stockConfiguration;
parent::__construct($context, $data);
}
@@ -89,11 +94,7 @@ class Inventory extends \Magento\Backend\Block\Widget implements \Magento\Backen
*/
public function getDefaultConfigValue($field)
{
- return $this->_scopeConfig->getValue(
- Item::XML_PATH_ITEM . $field,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- $this->getStoreId()
- );
+ return $this->stockConfiguration->getDefaultConfigValue($field);
}
/**
diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Inventory.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Inventory.php
index 7db4980deaa39cbf100b69068f0bb1d14fd4e55a..a0bf50ac9a045622a329af6f2156130aa992ea63 100644
--- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Inventory.php
+++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Inventory.php
@@ -58,14 +58,14 @@ class Inventory extends \Magento\Backend\Block\Widget
protected $backorders;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
- * @var \Magento\Catalog\Helper\Product\Inventory
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface
*/
- protected $inventoryHelper;
+ protected $stockConfiguration;
/**
* @param \Magento\Backend\Block\Template\Context $context
@@ -73,8 +73,8 @@ class Inventory extends \Magento\Backend\Block\Widget
* @param \Magento\CatalogInventory\Model\Source\Stock $stock
* @param \Magento\Catalog\Helper\Data $catalogData
* @param \Magento\Framework\Registry $coreRegistry
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
- * @param \Magento\Catalog\Helper\Product\Inventory $inventoryHelper
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param array $data
*/
public function __construct(
@@ -83,16 +83,16 @@ class Inventory extends \Magento\Backend\Block\Widget
\Magento\CatalogInventory\Model\Source\Stock $stock,
\Magento\Catalog\Helper\Data $catalogData,
\Magento\Framework\Registry $coreRegistry,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
- \Magento\Catalog\Helper\Product\Inventory $inventoryHelper,
- array $data = array()
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
+ array $data = []
) {
$this->stock = $stock;
$this->backorders = $backorders;
$this->catalogData = $catalogData;
$this->coreRegistry = $coreRegistry;
- $this->stockItemService = $stockItemService;
- $this->inventoryHelper = $inventoryHelper;
+ $this->stockRegistry = $stockRegistry;
+ $this->stockConfiguration = $stockConfiguration;
parent::__construct($context, $data);
}
@@ -105,7 +105,7 @@ class Inventory extends \Magento\Backend\Block\Widget
return $this->backorders->toOptionArray();
}
- return array();
+ return [];
}
/**
@@ -119,7 +119,7 @@ class Inventory extends \Magento\Backend\Block\Widget
return $this->stock->toOptionArray();
}
- return array();
+ return [];
}
/**
@@ -135,11 +135,14 @@ class Inventory extends \Magento\Backend\Block\Widget
/**
* Retrieve Catalog Inventory Stock Item Model
*
- * @return \Magento\CatalogInventory\Service\V1\Data\StockItem
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
*/
- public function getStockItemDo()
+ public function getStockItem()
{
- return $this->stockItemService->getStockItem($this->getProduct()->getId());
+ return $this->stockRegistry->getStockItem(
+ $this->getProduct()->getId(),
+ $this->getProduct()->getStore()->getWebsiteId()
+ );
}
/**
@@ -148,7 +151,14 @@ class Inventory extends \Magento\Backend\Block\Widget
*/
public function getFieldValue($field)
{
- return $this->inventoryHelper->getFieldValue($field, $this->getStockItemDo());
+ $stockItem = $this->getStockItem();
+ if ($stockItem->getId()) {
+ $method = 'get' . \Magento\Framework\Api\SimpleDataObjectConverter::snakeCaseToUpperCamelCase($field);
+ if (method_exists($stockItem, $method)) {
+ return $stockItem->{$method}();
+ }
+ }
+ return $this->stockConfiguration->getDefaultConfigValue($field);
}
/**
@@ -157,7 +167,16 @@ class Inventory extends \Magento\Backend\Block\Widget
*/
public function getConfigFieldValue($field)
{
- return $this->inventoryHelper->getConfigFieldValue($field, $this->getStockItemDo());
+ $stockItem = $this->getStockItem();
+ if ($stockItem->getId()) {
+ $method = 'getUseConfig' . \Magento\Framework\Api\SimpleDataObjectConverter::snakeCaseToUpperCamelCase(
+ $field
+ );
+ if (method_exists($stockItem, $method)) {
+ return $stockItem->{$method}();
+ }
+ }
+ return $this->stockConfiguration->getDefaultConfigValue($field);
}
/**
@@ -166,7 +185,7 @@ class Inventory extends \Magento\Backend\Block\Widget
*/
public function getDefaultConfigValue($field)
{
- return $this->inventoryHelper->getDefaultConfigValue($field);
+ return $this->stockConfiguration->getDefaultConfigValue($field);
}
/**
diff --git a/app/code/Magento/Catalog/Block/Navigation.php b/app/code/Magento/Catalog/Block/Navigation.php
index d1b54065fca2f19ab8bc45e1939156f51c14d5a6..f84ad945889492bd63caab08991d0eea1ddd5e08 100644
--- a/app/code/Magento/Catalog/Block/Navigation.php
+++ b/app/code/Magento/Catalog/Block/Navigation.php
@@ -24,6 +24,7 @@
namespace Magento\Catalog\Block;
use Magento\Catalog\Model\Category;
+use Magento\Customer\Model\Context;
/**
* Catalog navigation
@@ -156,7 +157,7 @@ class Navigation extends \Magento\Framework\View\Element\Template implements \Ma
'CATALOG_NAVIGATION',
$this->_storeManager->getStore()->getId(),
$this->_design->getDesignTheme()->getId(),
- $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_GROUP),
+ $this->httpContext->getValue(Context::CONTEXT_GROUP),
'template' => $this->getTemplate(),
'name' => $this->getNameInLayout(),
$this->getCurrenCategoryKey()
diff --git a/app/code/Magento/Catalog/Block/Product/AbstractProduct.php b/app/code/Magento/Catalog/Block/Product/AbstractProduct.php
index 910efe754782bc84d2826716ffbc5353f0a9f0b6..b1ed236c7a0f73f1f219bb2c9935e07cf88c5a31 100644
--- a/app/code/Magento/Catalog/Block/Product/AbstractProduct.php
+++ b/app/code/Magento/Catalog/Block/Product/AbstractProduct.php
@@ -23,12 +23,15 @@
*/
namespace Magento\Catalog\Block\Product;
+/**
+ * Class AbstractProduct
+ */
class AbstractProduct extends \Magento\Framework\View\Element\Template
{
/**
* @var array
*/
- protected $_priceBlock = array();
+ protected $_priceBlock = [];
/**
* Flag which allow/disallow to use link for as low as price
@@ -49,7 +52,7 @@ class AbstractProduct extends \Magento\Framework\View\Element\Template
*
* @var array
*/
- protected $_columnCountLayoutDepend = array();
+ protected $_columnCountLayoutDepend = [];
/**
* Core registry
@@ -110,18 +113,16 @@ class AbstractProduct extends \Magento\Framework\View\Element\Template
protected $reviewRenderer;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @param Context $context
* @param array $data
*/
- public function __construct(
- \Magento\Catalog\Block\Product\Context $context,
- array $data = array()
- ) {
+ public function __construct(\Magento\Catalog\Block\Product\Context $context, array $data = [])
+ {
$this->_imageHelper = $context->getImageHelper();
$this->_compareProduct = $context->getCompareProduct();
$this->_wishlistHelper = $context->getWishlistHelper();
@@ -132,7 +133,7 @@ class AbstractProduct extends \Magento\Framework\View\Element\Template
$this->_catalogData = $context->getCatalogHelper();
$this->_mathRandom = $context->getMathRandom();
$this->reviewRenderer = $context->getReviewRenderer();
- $this->stockItemService = $context->getStockItemService();
+ $this->stockRegistry = $context->getStockRegistry();
parent::__construct($context, $data);
}
@@ -144,14 +145,14 @@ class AbstractProduct extends \Magento\Framework\View\Element\Template
* @param array $additional
* @return string
*/
- public function getAddToCartUrl($product, $additional = array())
+ public function getAddToCartUrl($product, $additional = [])
{
if ($product->getTypeInstance()->hasRequiredOptions($product)) {
if (!isset($additional['_escape'])) {
$additional['_escape'] = true;
}
if (!isset($additional['_query'])) {
- $additional['_query'] = array();
+ $additional['_query'] = [];
}
$additional['_query']['options'] = 'cart';
@@ -170,12 +171,12 @@ class AbstractProduct extends \Magento\Framework\View\Element\Template
* @param array $additional
* @return string
*/
- public function getSubmitUrl($product, $additional = array())
+ public function getSubmitUrl($product, $additional = [])
{
$submitRouteData = $this->getData('submit_route_data');
if ($submitRouteData) {
$route = $submitRouteData['route'];
- $params = isset($submitRouteData['params']) ? $submitRouteData['params'] : array();
+ $params = isset($submitRouteData['params']) ? $submitRouteData['params'] : [];
$submitUrl = $this->getUrl($route, array_merge($params, $additional));
} else {
$submitUrl = $this->getAddToCartUrl($product, $additional);
@@ -212,7 +213,8 @@ class AbstractProduct extends \Magento\Framework\View\Element\Template
*/
public function getMinimalQty($product)
{
- $minSaleQty = $this->stockItemService->getMinSaleQty($product->getId());
+ $stockItem = $this->stockRegistry->getStockItem($product->getId(), $product->getStore()->getWebsiteId());
+ $minSaleQty = $stockItem->getMinSaleQty();
return $minSaleQty > 0 ? $minSaleQty : null;
}
@@ -292,7 +294,7 @@ class AbstractProduct extends \Magento\Framework\View\Element\Template
* @param array $additional the route params
* @return string
*/
- public function getProductUrl($product, $additional = array())
+ public function getProductUrl($product, $additional = [])
{
if ($this->hasProductUrl($product)) {
if (!isset($additional['_escape'])) {
diff --git a/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php b/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php
index 22319f9b4d34b2175a0c110d5266f0365f8dd5f2..54670860701bd24507206c081f3d44d9cfad43f6 100644
--- a/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php
+++ b/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php
@@ -24,6 +24,7 @@
namespace Magento\Catalog\Block\Product\Compare;
+use Magento\Customer\Model\Context;
use Magento\Framework\App\Action\Action;
use Magento\Catalog\Model\Product;
@@ -169,7 +170,7 @@ class ListCompare extends \Magento\Catalog\Block\Product\Compare\AbstractCompare
$this->_items = $this->_itemCollectionFactory->create();
$this->_items->useProductItem(true)->setStoreId($this->_storeManager->getStore()->getId());
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
$this->_items->setCustomerId($this->currentCustomer->getCustomerId());
} elseif ($this->_customerId) {
$this->_items->setCustomerId($this->_customerId);
diff --git a/app/code/Magento/Catalog/Block/Product/Context.php b/app/code/Magento/Catalog/Block/Product/Context.php
index 30911032871dd1bf0b68d891b1d117aaaf3ee63e..9101de5847376013f6bbe6527b851e6907be2650 100644
--- a/app/code/Magento/Catalog/Block/Product/Context.php
+++ b/app/code/Magento/Catalog/Block/Product/Context.php
@@ -79,9 +79,9 @@ class Context extends \Magento\Framework\View\Element\Template\Context
protected $reviewRenderer;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @var \Magento\Framework\View\Page\Config
@@ -122,7 +122,7 @@ class Context extends \Magento\Framework\View\Element\Template\Context
* @param \Magento\Catalog\Helper\Product\Compare $compareProduct
* @param \Magento\Catalog\Helper\Image $imageHelper
* @param ReviewRendererInterface $reviewRenderer
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param \Magento\Framework\View\Page\Config $pageConfig
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
@@ -162,7 +162,7 @@ class Context extends \Magento\Framework\View\Element\Template\Context
\Magento\Catalog\Helper\Product\Compare $compareProduct,
\Magento\Catalog\Helper\Image $imageHelper,
ReviewRendererInterface $reviewRenderer,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
) {
$this->imageHelper = $imageHelper;
$this->compareProduct = $compareProduct;
@@ -174,7 +174,7 @@ class Context extends \Magento\Framework\View\Element\Template\Context
$this->catalogHelper = $catalogHelper;
$this->mathRandom = $mathRandom;
$this->reviewRenderer = $reviewRenderer;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
parent::__construct(
$request,
$layout,
@@ -204,11 +204,11 @@ class Context extends \Magento\Framework\View\Element\Template\Context
}
/**
- * @return \Magento\CatalogInventory\Service\V1\StockItemService
+ * @return \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- public function getStockItemService()
+ public function getStockRegistry()
{
- return $this->stockItemService;
+ return $this->stockRegistry;
}
/**
diff --git a/app/code/Magento/Catalog/Block/Product/NewProduct.php b/app/code/Magento/Catalog/Block/Product/NewProduct.php
index 8cebb1346225eb371ffffc85526b13c223f9feaf..24d4aa93c03d0fa8fdafb3df36bbfa924ed72612 100644
--- a/app/code/Magento/Catalog/Block/Product/NewProduct.php
+++ b/app/code/Magento/Catalog/Block/Product/NewProduct.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Catalog\Block\Product;
+use Magento\Customer\Model\Context as CustomerContext;
+
/**
* New products block
*
@@ -116,7 +118,7 @@ class NewProduct extends \Magento\Catalog\Block\Product\AbstractProduct implemen
'CATALOG_PRODUCT_NEW',
$this->_storeManager->getStore()->getId(),
$this->_design->getDesignTheme()->getId(),
- $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_GROUP),
+ $this->httpContext->getValue(CustomerContext::CONTEXT_GROUP),
'template' => $this->getTemplate(),
$this->getProductsCount()
);
diff --git a/app/code/Magento/Catalog/Block/Rss/Product/Special.php b/app/code/Magento/Catalog/Block/Rss/Product/Special.php
index 6afff50d20bf300e02c48edc2231954ebbbd61cb..4a0d3688f3d3d86e5137ca56157c768b3de4bbc9 100644
--- a/app/code/Magento/Catalog/Block/Rss/Product/Special.php
+++ b/app/code/Magento/Catalog/Block/Rss/Product/Special.php
@@ -23,6 +23,7 @@
*/
namespace Magento\Catalog\Block\Rss\Product;
+use Magento\Customer\Model\Context;
use Magento\Framework\App\Rss\DataProviderInterface;
/**
@@ -229,7 +230,7 @@ class Special extends \Magento\Framework\View\Element\AbstractBlock implements D
{
$customerGroupId = (int) $this->getRequest()->getParam('cid');
if ($customerGroupId == null) {
- $customerGroupId = $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_GROUP);
+ $customerGroupId = $this->httpContext->getValue(Context::CONTEXT_GROUP);
}
return $customerGroupId;
}
diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/Save.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/Save.php
index 356305b338109c8c2ea4d07f52d00fd8be4714c6..3ac3ac4ec5c060e1d39810e0e0acdcba78807cf6 100644
--- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/Save.php
+++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/Save.php
@@ -26,6 +26,9 @@ namespace Magento\Catalog\Controller\Adminhtml\Product\Action\Attribute;
use Magento\Backend\App\Action;
+/**
+ * Class Save
+ */
class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribute
{
/**
@@ -46,7 +49,7 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribut
protected $_catalogProduct;
/**
- * @var \Magento\CatalogInventory\Service\V1\Data\StockItemBuilder
+ * @var \Magento\CatalogInventory\Api\Data\StockItemDataBuilder
*/
protected $stockItemBuilder;
@@ -69,7 +72,7 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribut
* @param \Magento\Catalog\Model\Indexer\Product\Price\Processor $productPriceIndexerProcessor
* @param \Magento\CatalogInventory\Model\Indexer\Stock\Processor $stockIndexerProcessor
* @param \Magento\Catalog\Helper\Product $catalogProduct
- * @param \Magento\CatalogInventory\Service\V1\Data\StockItemBuilder $stockItemBuilder
+ * @param \Magento\CatalogInventory\Api\Data\StockItemDataBuilder $stockItemBuilder
* @param \Magento\Backend\Model\View\Result\RedirectFactory $resultRedirectFactory
*/
public function __construct(
@@ -79,7 +82,7 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribut
\Magento\Catalog\Model\Indexer\Product\Price\Processor $productPriceIndexerProcessor,
\Magento\CatalogInventory\Model\Indexer\Stock\Processor $stockIndexerProcessor,
\Magento\Catalog\Helper\Product $catalogProduct,
- \Magento\CatalogInventory\Service\V1\Data\StockItemBuilder $stockItemBuilder,
+ \Magento\CatalogInventory\Api\Data\StockItemDataBuilder $stockItemBuilder,
\Magento\Backend\Model\View\Result\RedirectFactory $resultRedirectFactory
) {
$this->_productFlatIndexerProcessor = $productFlatIndexerProcessor;
@@ -109,7 +112,8 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribut
$websiteAddData = $this->getRequest()->getParam('add_website_ids', array());
/* Prepare inventory data item options (use config settings) */
- $options = $this->_objectManager->get('Magento\CatalogInventory\Helper\Data')->getConfigItemOptions();
+ $options = $this->_objectManager->get('Magento\CatalogInventory\Api\StockConfigurationInterface')
+ ->getConfigItemOptions();
foreach ($options as $option) {
if (isset($inventoryData[$option]) && !isset($inventoryData['use_config_' . $option])) {
$inventoryData['use_config_' . $option] = 0;
@@ -117,10 +121,10 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribut
}
try {
+ $storeId = $this->attributeHelper->getSelectedStoreId();
if ($attributesData) {
$dateFormat = $this->_objectManager->get('Magento\Framework\Stdlib\DateTime\TimezoneInterface')
->getDateFormat(\Magento\Framework\Stdlib\DateTime\TimezoneInterface::FORMAT_TYPE_SHORT);
- $storeId = $this->attributeHelper->getSelectedStoreId();
foreach ($attributesData as $attributeCode => $value) {
$attribute = $this->_objectManager->get('Magento\Eav\Model\Config')
@@ -142,7 +146,7 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribut
$attributesData[$attributeCode] = $value;
} elseif ($attribute->getFrontendInput() == 'multiselect') {
// Check if 'Change' checkbox has been checked by admin for this attribute
- $isChanged = (bool) $this->getRequest()->getPost($attributeCode . '_checkbox');
+ $isChanged = (bool)$this->getRequest()->getPost($attributeCode . '_checkbox');
if (!$isChanged) {
unset($attributesData[$attributeCode]);
continue;
@@ -159,19 +163,26 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribut
}
if ($inventoryData) {
- /** @var \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService */
- $stockItemService = $this->_objectManager
- ->create('Magento\CatalogInventory\Service\V1\StockItemService');
+ // TODO why use ObjectManager?
+ /** @var \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry */
+ $stockRegistry = $this->_objectManager
+ ->create('Magento\CatalogInventory\Api\StockRegistryInterface');
+ /** @var \Magento\CatalogInventory\Api\StockItemRepositoryInterface $stockItemRepository */
+ $stockItemRepository = $this->_objectManager
+ ->create('Magento\CatalogInventory\Api\StockItemRepositoryInterface');
foreach ($this->attributeHelper->getProductIds() as $productId) {
- $stockItemDo = $stockItemService->getStockItem($productId);
+ $stockItemDo = $stockRegistry->getStockItem(
+ $productId,
+ $this->attributeHelper->getStoreWebsiteId($storeId)
+ );
if (!$stockItemDo->getProductId()) {
$inventoryData[] = $productId;
}
- $stockItemService->saveStockItem(
- $this->stockItemBuilder->mergeDataObjectWithArray($stockItemDo, $inventoryData)
- ->create()
- );
+ $stockItemId = $stockItemDo->getId();
+ $stockItemToSave = $this->stockItemBuilder->mergeDataObjectWithArray($stockItemDo, $inventoryData);
+ $stockItemToSave->setItemId($stockItemId);
+ $stockItemRepository->save($stockItemToSave);
}
$this->_stockIndexerProcessor->reindexList($this->attributeHelper->getProductIds());
}
diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/HandlerFactory.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/HandlerFactory.php
index 25e531731d65d8d5668de1cc160385b9f887d655..a265e6afc383e3aa6d0178fcc6c3f75eed8dc8d5 100644
--- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/HandlerFactory.php
+++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/HandlerFactory.php
@@ -28,14 +28,14 @@ class HandlerFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilter.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilter.php
index 2af5fda1388b88cdcde41a0b19e495eedad144f7..1c887034729861e89b99d09d8bc078ef50d08e75 100644
--- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilter.php
+++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilter.php
@@ -23,6 +23,12 @@
*/
namespace Magento\Catalog\Controller\Adminhtml\Product\Initialization;
+use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\CatalogInventory\Api\StockConfigurationInterface;
+
+/**
+ * Class StockDataFilter
+ */
class StockDataFilter
{
/**
@@ -31,16 +37,25 @@ class StockDataFilter
const MAX_QTY_VALUE = 99999999.9999;
/**
- * @var \Magento\Framework\App\Config\ScopeConfigInterface
+ * @var ScopeConfigInterface
*/
protected $scopeConfig;
/**
- * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
+ * @var StockConfigurationInterface
*/
- public function __construct(\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig)
- {
+ protected $stockConfiguration;
+
+ /**
+ * @param ScopeConfigInterface $scopeConfig
+ * @param StockConfigurationInterface $stockConfiguration
+ */
+ public function __construct(
+ ScopeConfigInterface $scopeConfig,
+ StockConfigurationInterface $stockConfiguration
+ ) {
$this->scopeConfig = $scopeConfig;
+ $this->stockConfiguration = $stockConfiguration;
}
/**
@@ -56,10 +71,7 @@ class StockDataFilter
}
if ($stockData['use_config_manage_stock'] == 1 && !isset($stockData['manage_stock'])) {
- $stockData['manage_stock'] = $this->scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_MANAGE_STOCK,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
+ $stockData['manage_stock'] = $this->stockConfiguration->getManageStock();
}
if (isset($stockData['qty']) && (double)$stockData['qty'] > self::MAX_QTY_VALUE) {
$stockData['qty'] = self::MAX_QTY_VALUE;
diff --git a/app/code/Magento/Catalog/Helper/Product/ConfigurationPool.php b/app/code/Magento/Catalog/Helper/Product/ConfigurationPool.php
index d1544987b45f482792dc6e018b6a6470e79fcc22..c532838fd190777c1efe144b23f75b367c899b35 100644
--- a/app/code/Magento/Catalog/Helper/Product/ConfigurationPool.php
+++ b/app/code/Magento/Catalog/Helper/Product/ConfigurationPool.php
@@ -26,7 +26,7 @@ namespace Magento\Catalog\Helper\Product;
class ConfigurationPool
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -36,9 +36,9 @@ class ConfigurationPool
private $_instances = array();
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Helper/Product/Edit/Action/Attribute.php b/app/code/Magento/Catalog/Helper/Product/Edit/Action/Attribute.php
index 4d4699f8aa2cd1518d07021f79d4439353f348e7..b3279a4caa00dcb97b5d6f1cac83ae42158213a1 100644
--- a/app/code/Magento/Catalog/Helper/Product/Edit/Action/Attribute.php
+++ b/app/code/Magento/Catalog/Helper/Product/Edit/Action/Attribute.php
@@ -27,6 +27,9 @@
*/
namespace Magento\Catalog\Helper\Product\Edit\Action;
+/**
+ * Class Attribute
+ */
class Attribute extends \Magento\Backend\Helper\Data
{
/**
@@ -65,6 +68,11 @@ class Attribute extends \Magento\Backend\Helper\Data
*/
protected $_eavConfig;
+ /**
+ * @var \Magento\Framework\StoreManagerInterface
+ */
+ protected $_storeManager;
+
/**
* @param \Magento\Framework\App\Helper\Context $context
* @param \Magento\Framework\App\Route\Config $routeConfig
@@ -76,6 +84,7 @@ class Attribute extends \Magento\Backend\Helper\Data
* @param \Magento\Eav\Model\Config $eavConfig
* @param \Magento\Backend\Model\Session $session
* @param \Magento\Catalog\Model\Resource\Product\CollectionFactory $productsFactory
+ * @param \Magento\Framework\StoreManagerInterface $storeManager
*/
public function __construct(
\Magento\Framework\App\Helper\Context $context,
@@ -87,11 +96,13 @@ class Attribute extends \Magento\Backend\Helper\Data
\Magento\Framework\Math\Random $mathRandom,
\Magento\Eav\Model\Config $eavConfig,
\Magento\Backend\Model\Session $session,
- \Magento\Catalog\Model\Resource\Product\CollectionFactory $productsFactory
+ \Magento\Catalog\Model\Resource\Product\CollectionFactory $productsFactory,
+ \Magento\Framework\StoreManagerInterface $storeManager
) {
$this->_eavConfig = $eavConfig;
$this->_session = $session;
$this->_productsFactory = $productsFactory;
+ $this->_storeManager = $storeManager;
parent::__construct($context, $routeConfig, $locale, $backendUrl, $auth, $frontNameResolver, $mathRandom);
}
@@ -188,4 +199,13 @@ class Attribute extends \Magento\Backend\Helper\Data
return $this->_attributes;
}
+
+ /**
+ * @param int $storeId
+ * @return int
+ */
+ public function getStoreWebsiteId($storeId)
+ {
+ return $this->_storeManager->getStore($storeId)->getWebsiteId();
+ }
}
diff --git a/app/code/Magento/Catalog/Helper/Product/Inventory.php b/app/code/Magento/Catalog/Helper/Product/Inventory.php
deleted file mode 100644
index 1857eb1746da1978f169d2d79bb2193169babcca..0000000000000000000000000000000000000000
--- a/app/code/Magento/Catalog/Helper/Product/Inventory.php
+++ /dev/null
@@ -1,114 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\Catalog\Helper\Product;
-
-use \Magento\CatalogInventory\Service\V1\Data\StockItem;
-use Magento\Framework\App\Helper\Context;
-use \Magento\Framework\App\Config\ScopeConfigInterface;
-
-/**
- * Catalog Product Inventory Helper
- */
-class Inventory extends \Magento\Framework\App\Helper\AbstractHelper
-{
- /**
- * @var ScopeConfigInterface
- */
- protected $scopeConfig;
-
- /**
- * @param Context $context
- * @param ScopeConfigInterface $scopeConfig
- */
- public function __construct(
- Context $context,
- ScopeConfigInterface $scopeConfig
- ) {
- $this->scopeConfig = $scopeConfig;
- parent::__construct($context);
- }
-
- /**
- * @param string $field
- * @param StockItem $dataObject
- * @return mixed
- */
- public function getFieldValue($field, StockItem $dataObject)
- {
- if ($dataObject->getStockId()) {
- return $this->getDoFieldData($field, $dataObject);
- }
-
- return $this->getDefaultConfigValue($field);
- }
-
- /**
- * @param string $field
- * @param StockItem $dataObject
- * @return mixed|null|string
- */
- public function getConfigFieldValue($field, StockItem $dataObject)
- {
- if ($dataObject->getStockId()) {
- if ($this->getDoFieldData('use_config_' . $field, $dataObject) == 0) {
- return $this->getDoFieldData($field, $dataObject);
- }
- }
-
- return $this->getDefaultConfigValue($field);
- }
-
- /**
- * @param string $field
- * @return string|null
- */
- public function getDefaultConfigValue($field)
- {
- return $this->scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_ITEM . $field,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- }
-
- /**
- * @param string $field
- * @param StockItem $dataObject
- * @return mixed
- * @throws \BadMethodCallException
- */
- public function getDoFieldData($field, StockItem $dataObject)
- {
- $possibleMethods = array(
- 'get' . \Magento\Framework\Api\SimpleDataObjectConverter::snakeCaseToUpperCamelCase($field),
- 'is' . \Magento\Framework\Api\SimpleDataObjectConverter::snakeCaseToUpperCamelCase($field)
- );
-
- foreach ($possibleMethods as $method) {
- if (method_exists($dataObject, $method)) {
- return $dataObject->{$method}();
- }
- }
- throw new \BadMethodCallException(__('Field "%1" was not found in DO "%2".', $field, get_class($dataObject)));
- }
-}
diff --git a/app/code/Magento/Catalog/Model/Attribute/LockValidatorComposite.php b/app/code/Magento/Catalog/Model/Attribute/LockValidatorComposite.php
index 5cf47867ab077d4c9abc91d637b266454302b27d..3310b7abdcbca3c262bfd36385a62f22f35fa71b 100644
--- a/app/code/Magento/Catalog/Model/Attribute/LockValidatorComposite.php
+++ b/app/code/Magento/Catalog/Model/Attribute/LockValidatorComposite.php
@@ -33,11 +33,11 @@ class LockValidatorComposite implements LockValidatorInterface
protected $validators = array();
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $validators
* @throws \InvalidArgumentException
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, array $validators = array())
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, array $validators = array())
{
foreach ($validators as $validator) {
if (!is_subclass_of($validator, 'Magento\Catalog\Model\Attribute\LockValidatorInterface')) {
diff --git a/app/code/Magento/Catalog/Model/Factory.php b/app/code/Magento/Catalog/Model/Factory.php
index 2a1854cc2beb13b22ebed29469c5b51911213112..393c552e7797ed7c93492ee5e031c9fab0b75c1b 100644
--- a/app/code/Magento/Catalog/Model/Factory.php
+++ b/app/code/Magento/Catalog/Model/Factory.php
@@ -32,16 +32,16 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Model/Indexer/Category/Product/Action/RowsFactory.php b/app/code/Magento/Catalog/Model/Indexer/Category/Product/Action/RowsFactory.php
index 3c3e660c0f0401ceef91934a1fb17317ad2e79c0..c1d12553652c4c7f401165702248bf5d938d6149 100644
--- a/app/code/Magento/Catalog/Model/Indexer/Category/Product/Action/RowsFactory.php
+++ b/app/code/Magento/Catalog/Model/Indexer/Category/Product/Action/RowsFactory.php
@@ -31,7 +31,7 @@ class RowsFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -45,11 +45,11 @@ class RowsFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Catalog\Model\Indexer\Category\Product\Action\Rows'
) {
$this->objectManager = $objectManager;
diff --git a/app/code/Magento/Catalog/Model/Indexer/Product/Category/Action/RowsFactory.php b/app/code/Magento/Catalog/Model/Indexer/Product/Category/Action/RowsFactory.php
index 3108dd2b159fb05a44209592cb922f7a6ac57b2a..a9ab9ec3c81305f2faf7b5ff06e6198b8d28c3b2 100644
--- a/app/code/Magento/Catalog/Model/Indexer/Product/Category/Action/RowsFactory.php
+++ b/app/code/Magento/Catalog/Model/Indexer/Product/Category/Action/RowsFactory.php
@@ -31,11 +31,11 @@ class RowsFactory extends \Magento\Catalog\Model\Indexer\Category\Product\Action
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Catalog\Model\Indexer\Product\Category\Action\Rows'
) {
parent::__construct($objectManager, $instanceName);
diff --git a/app/code/Magento/Catalog/Model/Layer/Filter/Factory.php b/app/code/Magento/Catalog/Model/Layer/Filter/Factory.php
index 08e2c24e38f4ccd73dbcb4ae73d88b48e5184f91..82f8e9bfc9bd9c68fa6f16791dc995a623684c18 100644
--- a/app/code/Magento/Catalog/Model/Layer/Filter/Factory.php
+++ b/app/code/Magento/Catalog/Model/Layer/Filter/Factory.php
@@ -32,16 +32,16 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Model/Layer/FilterList.php b/app/code/Magento/Catalog/Model/Layer/FilterList.php
index bf6a02e4c0fc52f353a54aee181a042935221dd4..705168e9418da3b00cb170651fc1e04002bb195f 100644
--- a/app/code/Magento/Catalog/Model/Layer/FilterList.php
+++ b/app/code/Magento/Catalog/Model/Layer/FilterList.php
@@ -36,7 +36,7 @@ class FilterList
/**
* Filter factory
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -61,12 +61,12 @@ class FilterList
protected $filters = array();
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param FilterableAttributeListInterface $filterableAttributes
* @param array $filters
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
FilterableAttributeListInterface $filterableAttributes,
array $filters = array()
) {
diff --git a/app/code/Magento/Catalog/Model/Product.php b/app/code/Magento/Catalog/Model/Product.php
index f201d28fd7d08af37cc5149cd02e080939527c47..26bab0eb2d06120f0f085873db009fdd568f3e9c 100644
--- a/app/code/Magento/Catalog/Model/Product.php
+++ b/app/code/Magento/Catalog/Model/Product.php
@@ -218,9 +218,9 @@ class Product extends \Magento\Catalog\Model\AbstractModel implements IdentityIn
/**
* Stock item factory
*
- * @var \Magento\CatalogInventory\Model\Stock\ItemFactory
+ * @var \Magento\CatalogInventory\Api\Data\StockItemDataBuilder
*/
- protected $_stockItemFactory;
+ protected $_stockItemBuilder;
/**
* Item option factory
@@ -266,7 +266,7 @@ class Product extends \Magento\Catalog\Model\AbstractModel implements IdentityIn
* @param Product\Url $url
* @param Product\Link $productLink
* @param Product\Configuration\Item\OptionFactory $itemOptionFactory
- * @param \Magento\CatalogInventory\Model\Stock\ItemFactory $stockItemFactory
+ * @param \Magento\CatalogInventory\Api\Data\StockItemDataBuilder $stockItemBuilder
* @param CategoryFactory $categoryFactory
* @param Product\Option $catalogProductOption
* @param Product\Visibility $catalogProductVisibility
@@ -295,7 +295,7 @@ class Product extends \Magento\Catalog\Model\AbstractModel implements IdentityIn
Product\Url $url,
Product\Link $productLink,
\Magento\Catalog\Model\Product\Configuration\Item\OptionFactory $itemOptionFactory,
- \Magento\CatalogInventory\Model\Stock\ItemFactory $stockItemFactory,
+ \Magento\CatalogInventory\Api\Data\StockItemDataBuilder $stockItemBuilder,
\Magento\Catalog\Model\CategoryFactory $categoryFactory,
\Magento\Catalog\Model\Product\Option $catalogProductOption,
\Magento\Catalog\Model\Product\Visibility $catalogProductVisibility,
@@ -316,7 +316,7 @@ class Product extends \Magento\Catalog\Model\AbstractModel implements IdentityIn
array $data = array()
) {
$this->_itemOptionFactory = $itemOptionFactory;
- $this->_stockItemFactory = $stockItemFactory;
+ $this->_stockItemBuilder = $stockItemBuilder;
$this->_categoryFactory = $categoryFactory;
$this->_optionInstance = $catalogProductOption;
$this->_catalogProductVisibility = $catalogProductVisibility;
@@ -435,7 +435,7 @@ class Product extends \Magento\Catalog\Model\AbstractModel implements IdentityIn
/**
* Get product type identifier
*
- * @return string
+ * @return array|string
*/
public function getTypeId()
{
@@ -1533,11 +1533,12 @@ class Product extends \Magento\Catalog\Model\AbstractModel implements IdentityIn
* @param array $data Array to form the object from
* @return \Magento\Catalog\Model\Product
*/
- public function fromArray($data)
+ public function fromArray(array $data)
{
if (isset($data['stock_item'])) {
if ($this->_catalogData->isModuleEnabled('Magento_CatalogInventory')) {
- $stockItem = $this->_stockItemFactory->create()->setData($data['stock_item'])->setProduct($this);
+ $stockItem = $this->_stockItemBuilder->populateWithArray($data['stock_item'])->create();
+ $stockItem->setProduct($this);
$this->setStockItem($stockItem);
}
unset($data['stock_item']);
diff --git a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Groupprice.php b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Groupprice.php
index 43ab6908a589d8b65125260bbb1265811bfd3b51..03a9da41cc41130eee701383b504b1c834842e0d 100644
--- a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Groupprice.php
+++ b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Groupprice.php
@@ -76,4 +76,14 @@ class Groupprice extends \Magento\Catalog\Model\Product\Attribute\Backend\Groupp
{
return __('We found a duplicate website group price customer group.');
}
+
+ /**
+ * By default attribute value is considered non-scalar that can be stored in a generic way
+ *
+ * @return bool
+ */
+ public function isScalar()
+ {
+ return false;
+ }
}
diff --git a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Stock.php b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Stock.php
index 1b8d4c0cd266dfdf09b3a688070abc622cf9e9ea..7aec85995dc00092f0fc38e13653ee34e7aa40fd 100644
--- a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Stock.php
+++ b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Stock.php
@@ -32,20 +32,21 @@ use Magento\Catalog\Model\Product;
class Stock extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend
{
/**
- * Stock item service
+ * Stock Registry
*
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* Construct
*
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
*/
- public function __construct(\Magento\CatalogInventory\Service\V1\StockItemService $stockItemService)
- {
- $this->stockItemService = $stockItemService;
+ public function __construct(
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ ) {
+ $this->stockRegistry = $stockRegistry;
}
/**
@@ -56,10 +57,10 @@ class Stock extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend
*/
public function afterLoad($object)
{
- $stockItemDo = $this->stockItemService->getStockItem($object->getId());
+ $stockItem = $this->stockRegistry->getStockItem($object->getId(), $object->getStore()->getWebsiteId());
$object->setData(
$this->getAttribute()->getAttributeCode(),
- array('is_in_stock' => $stockItemDo->getIsInStock(), 'qty' => $stockItemDo->getQty())
+ array('is_in_stock' => $stockItem->getIsInStock(), 'qty' => $stockItem->getQty())
);
return parent::afterLoad($object);
}
diff --git a/app/code/Magento/Catalog/Model/Product/CatalogPrice.php b/app/code/Magento/Catalog/Model/Product/CatalogPrice.php
index 10f24d040f2050fe449149fdcf5ad91ce575690b..ab4661e1860ec36dd456445edafacdc544cf5c0a 100644
--- a/app/code/Magento/Catalog/Model/Product/CatalogPrice.php
+++ b/app/code/Magento/Catalog/Model/Product/CatalogPrice.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Catalog\Model\Product;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Price model for external catalogs
diff --git a/app/code/Magento/Catalog/Model/Product/CatalogPriceFactory.php b/app/code/Magento/Catalog/Model/Product/CatalogPriceFactory.php
index ec4020d988069c1ff5df0e557514b9eee95932ef..3be438c8c263f8cbd7ad94fa62489210d536215f 100644
--- a/app/code/Magento/Catalog/Model/Product/CatalogPriceFactory.php
+++ b/app/code/Magento/Catalog/Model/Product/CatalogPriceFactory.php
@@ -29,14 +29,14 @@ namespace Magento\Catalog\Model\Product;
class CatalogPriceFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Model/Product/CopyConstructorFactory.php b/app/code/Magento/Catalog/Model/Product/CopyConstructorFactory.php
index a3d863f45bd9c0fd7cb4ed5012f22d53fa53ca91..61c7793fdbc5ce6b39fe6d0da642e623c1e67d44 100644
--- a/app/code/Magento/Catalog/Model/Product/CopyConstructorFactory.php
+++ b/app/code/Magento/Catalog/Model/Product/CopyConstructorFactory.php
@@ -26,14 +26,14 @@ namespace Magento\Catalog\Model\Product;
class CopyConstructorFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Model/Product/Option/Type/Factory.php b/app/code/Magento/Catalog/Model/Product/Option/Type/Factory.php
index 96ef60967e23bb2cb0192b7e8b6de14099215fdf..950191de1a1f1a143c941c94e00a3edba14c2787 100644
--- a/app/code/Magento/Catalog/Model/Product/Option/Type/Factory.php
+++ b/app/code/Magento/Catalog/Model/Product/Option/Type/Factory.php
@@ -32,16 +32,16 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Model/Product/PriceModifier/Composite.php b/app/code/Magento/Catalog/Model/Product/PriceModifier/Composite.php
index 26ac94bca623f6dccce695dc292cc2b6a6a7c5be..940c54f55c6961128166485603dbde8b93f1799f 100644
--- a/app/code/Magento/Catalog/Model/Product/PriceModifier/Composite.php
+++ b/app/code/Magento/Catalog/Model/Product/PriceModifier/Composite.php
@@ -28,12 +28,12 @@ namespace Magento\Catalog\Model\Product\PriceModifier;
use Magento\Catalog\Model\Product\PriceModifierInterface;
use Magento\Catalog\Model\Product;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class Composite implements PriceModifierInterface
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -43,10 +43,10 @@ class Composite implements PriceModifierInterface
protected $modifiers;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param array $modifiers
*/
- public function __construct(ObjectManager $objectManager, array $modifiers = array())
+ public function __construct(ObjectManagerInterface $objectManager, array $modifiers = array())
{
$this->objectManager = $objectManager;
$this->modifiers = $modifiers;
diff --git a/app/code/Magento/Catalog/Model/Product/ProductList/Toolbar.php b/app/code/Magento/Catalog/Model/Product/ProductList/Toolbar.php
index 09d0aa5e7569ca5600f137dcd7747631cec776df..07afaa1534104bc71ce19e9cf09f87c5d4f2ba61 100644
--- a/app/code/Magento/Catalog/Model/Product/ProductList/Toolbar.php
+++ b/app/code/Magento/Catalog/Model/Product/ProductList/Toolbar.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Catalog\Model\Product\ProductList;
-use Magento\Framework\Stdlib\CookieManager;
+use Magento\Framework\Stdlib\CookieManagerInterface;
/**
* Class Toolbar
@@ -58,7 +58,7 @@ class Toolbar
/**
* Cookie manager
*
- * @var CookieManager
+ * @var CookieManagerInterface
*/
protected $cookieManager;
@@ -70,11 +70,11 @@ class Toolbar
protected $request;
/**
- * @param CookieManager $cookieManager
+ * @param CookieManagerInterface $cookieManager
* @param \Magento\Framework\App\Request\Http $request
*/
public function __construct(
- CookieManager $cookieManager,
+ CookieManagerInterface $cookieManager,
\Magento\Framework\App\Request\Http $request
) {
$this->cookieManager = $cookieManager;
diff --git a/app/code/Magento/Catalog/Model/Product/Type/Pool.php b/app/code/Magento/Catalog/Model/Product/Type/Pool.php
index d85e1f830c3f3876f1151e07e66c2f7abec481c6..0665bb51c8ebbcdd1e9bb708a1ebf9a55c58a165 100644
--- a/app/code/Magento/Catalog/Model/Product/Type/Pool.php
+++ b/app/code/Magento/Catalog/Model/Product/Type/Pool.php
@@ -32,16 +32,16 @@ class Pool
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Model/Product/Type/Price/Factory.php b/app/code/Magento/Catalog/Model/Product/Type/Price/Factory.php
index 81fd5f874f0d18b76d0b8b85d2aa72351ae63766..f613727b4763e0d883f2965ea12298b9af2d7e10 100644
--- a/app/code/Magento/Catalog/Model/Product/Type/Price/Factory.php
+++ b/app/code/Magento/Catalog/Model/Product/Type/Price/Factory.php
@@ -32,16 +32,16 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Model/Resource/Category/Collection/Factory.php b/app/code/Magento/Catalog/Model/Resource/Category/Collection/Factory.php
index efd429e7444760c6d40f63ab000844e583d86e75..33ab1e92e1e9d92811089db6b05610fb8ef2c17a 100644
--- a/app/code/Magento/Catalog/Model/Resource/Category/Collection/Factory.php
+++ b/app/code/Magento/Catalog/Model/Resource/Category/Collection/Factory.php
@@ -26,14 +26,14 @@ namespace Magento\Catalog\Model\Resource\Category\Collection;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Model/Resource/Product/Indexer/Price/Factory.php b/app/code/Magento/Catalog/Model/Resource/Product/Indexer/Price/Factory.php
index 16cfd0fbe298ab9c4f7501dcc17d68a1ac40043b..990b12557f08d8c66a1e62acf8f22bf6419d71af 100644
--- a/app/code/Magento/Catalog/Model/Resource/Product/Indexer/Price/Factory.php
+++ b/app/code/Magento/Catalog/Model/Resource/Product/Indexer/Price/Factory.php
@@ -32,16 +32,16 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Model/Template/Filter/Factory.php b/app/code/Magento/Catalog/Model/Template/Filter/Factory.php
index ee503420c2e7cdb54fc57246505c0fde1fa792bd..8e3b4d259fc17598eb8a648cf6da773358240563 100644
--- a/app/code/Magento/Catalog/Model/Template/Filter/Factory.php
+++ b/app/code/Magento/Catalog/Model/Template/Filter/Factory.php
@@ -32,16 +32,16 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Catalog/Pricing/Price/TierPrice.php b/app/code/Magento/Catalog/Pricing/Price/TierPrice.php
index 8d0f92769d46b80ec9e22fd9bd116bbcf2fda291..d12080b57a94f5888eba1296307eabdc5e3b95b8 100644
--- a/app/code/Magento/Catalog/Pricing/Price/TierPrice.php
+++ b/app/code/Magento/Catalog/Pricing/Price/TierPrice.php
@@ -67,13 +67,6 @@ class TierPrice extends AbstractPrice implements TierPriceInterface, BasePricePr
*/
protected $priceList;
- /**
- * Should filter by base price or not
- *
- * @var bool
- */
- protected $filterByBasePrice = true;
-
/**
* @param Product $saleableItem
* @param float $quantity
@@ -179,11 +172,6 @@ class TierPrice extends AbstractPrice implements TierPriceInterface, BasePricePr
unset($priceList[$priceKey]);
continue;
}
- /* select a lower price between Tier price and base price */
- if ($this->filterByBasePrice && $price['price'] > $this->getBasePrice()) {
- unset($priceList[$priceKey]);
- continue;
- }
/* select a lower price for each quantity */
if (isset($qtyCache[$price['price_qty']])) {
$priceQty = $qtyCache[$price['price_qty']];
@@ -216,7 +204,7 @@ class TierPrice extends AbstractPrice implements TierPriceInterface, BasePricePr
public function getSavePercent(AmountInterface $amount)
{
return ceil(
- 100 - ((100 / $this->priceInfo->getPrice(BasePrice::PRICE_CODE)->getAmount()->getBaseAmount())
+ 100 - ((100 / $this->priceInfo->getPrice(RegularPrice::PRICE_CODE)->getAmount()->getBaseAmount())
* $amount->getBaseAmount())
);
}
diff --git a/app/code/Magento/Catalog/composer.json b/app/code/Magento/Catalog/composer.json
index 4bd91b1c76fe64c01ed8de76026768ebb60c2455..72024bf3461e28a6fff3189141bb929c78bc4620 100644
--- a/app/code/Magento/Catalog/composer.json
+++ b/app/code/Magento/Catalog/composer.json
@@ -3,33 +3,33 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/module-indexer": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-log": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-widget": "0.1.0-alpha104",
- "magento/module-wishlist": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-msrp": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-catalog-rule": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-product-alert": "0.1.0-alpha104",
- "magento/module-url-rewrite": "0.1.0-alpha104",
- "magento/module-catalog-url-rewrite": "0.1.0-alpha104",
- "magento/module-page-cache": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/module-indexer": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-log": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-widget": "0.1.0-alpha105",
+ "magento/module-wishlist": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-msrp": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-catalog-rule": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-product-alert": "0.1.0-alpha105",
+ "magento/module-url-rewrite": "0.1.0-alpha105",
+ "magento/module-catalog-url-rewrite": "0.1.0-alpha105",
+ "magento/module-page-cache": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Catalog/data/catalog_setup/data-upgrade-1.6.0.0.17-1.6.0.0.18.php b/app/code/Magento/Catalog/data/catalog_setup/data-upgrade-1.6.0.0.17-1.6.0.0.18.php
index 5c33356bf79decd4c687e8042fcdd48f56bea7ee..6474ef2f3cf10beaf5276afc06004c0b316b1da6 100644
--- a/app/code/Magento/Catalog/data/catalog_setup/data-upgrade-1.6.0.0.17-1.6.0.0.18.php
+++ b/app/code/Magento/Catalog/data/catalog_setup/data-upgrade-1.6.0.0.17-1.6.0.0.18.php
@@ -52,7 +52,7 @@ $this->addAttribute(
'input' => 'select',
'class' => '',
'input_renderer' => 'Magento\CatalogInventory\Block\Adminhtml\Form\Field\Stock',
- 'source' => 'Magento\CatalogInventory\Model\Stock\Status',
+ 'source' => 'Magento\CatalogInventory\Model\Source\Stock',
'global' => \Magento\Catalog\Model\Resource\Eav\Attribute::SCOPE_GLOBAL,
'default' => \Magento\CatalogInventory\Model\Stock::STOCK_IN_STOCK,
'user_defined' => false,
diff --git a/app/code/Magento/Catalog/view/frontend/web/js/price-option.js b/app/code/Magento/Catalog/view/frontend/web/js/price-option.js
index 4fc47ee220117c845512456763759e13fc677e6a..d8a895e90d1525311ddcd8f968c19a8d0b2311ff 100644
--- a/app/code/Magento/Catalog/view/frontend/web/js/price-option.js
+++ b/app/code/Magento/Catalog/view/frontend/web/js/price-option.js
@@ -225,7 +225,9 @@ define([
} else {
price = this.options.priceConfig.showIncludeTax ?
updatedPrice.inclTaxPrice : updatedPrice.exclTaxPrice;
- price = price + getOptionPrices[0];
+ optionPrice = this.options.priceConfig.showIncludeTax ?
+ getOptionPrices[2] : getOptionPrices[3];
+ price = price + optionPrice;
}
var priceHtml = $.tmpl(
@@ -243,4 +245,4 @@ define([
}
}
});
-});
\ No newline at end of file
+});
diff --git a/app/code/Magento/CatalogImportExport/Model/Export/Product/Type/Factory.php b/app/code/Magento/CatalogImportExport/Model/Export/Product/Type/Factory.php
index 40ad5f678ccc14cfec07d6a368f92450b11a2f45..f2b6e299d82d78175a73b4418ff48935d587bcda 100644
--- a/app/code/Magento/CatalogImportExport/Model/Export/Product/Type/Factory.php
+++ b/app/code/Magento/CatalogImportExport/Model/Export/Product/Type/Factory.php
@@ -32,14 +32,14 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/CatalogImportExport/Model/Export/RowCustomizer/Composite.php b/app/code/Magento/CatalogImportExport/Model/Export/RowCustomizer/Composite.php
index d1e93ffcaa6753547dbb4b900ecffe32e7c40d1d..1a9a5bbed1c300ffd127e8782527056b9eba0e59 100644
--- a/app/code/Magento/CatalogImportExport/Model/Export/RowCustomizer/Composite.php
+++ b/app/code/Magento/CatalogImportExport/Model/Export/RowCustomizer/Composite.php
@@ -24,12 +24,12 @@
namespace Magento\CatalogImportExport\Model\Export\RowCustomizer;
use Magento\CatalogImportExport\Model\Export\RowCustomizerInterface;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class Composite implements RowCustomizerInterface
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -39,10 +39,10 @@ class Composite implements RowCustomizerInterface
protected $customizers;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param array $customizers
*/
- public function __construct(ObjectManager $objectManager, $customizers = array())
+ public function __construct(ObjectManagerInterface $objectManager, $customizers = array())
{
$this->objectManager = $objectManager;
$this->customizers = $customizers;
diff --git a/app/code/Magento/CatalogImportExport/Model/Import/Product.php b/app/code/Magento/CatalogImportExport/Model/Import/Product.php
index 2d7ba877fcc2778f3610594d4b88b4dac0440db6..63ff0ed7bd670430293daf89f2abaff29210d35b 100644
--- a/app/code/Magento/CatalogImportExport/Model/Import/Product.php
+++ b/app/code/Magento/CatalogImportExport/Model/Import/Product.php
@@ -393,9 +393,19 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
protected $_catalogData = null;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface
+ */
+ protected $stockConfiguration;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockStateInterface
+ */
+ protected $stockState;
/**
* Core event manager proxy
@@ -503,7 +513,9 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
* @param \Magento\ImportExport\Model\Resource\Helper $resourceHelper
* @param \Magento\Framework\Stdlib\String $string
* @param \Magento\Framework\Event\ManagerInterface $eventManager
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
+ * @param \Magento\CatalogInventory\Api\StockStateInterface $stockState
* @param \Magento\Catalog\Helper\Data $catalogData
* @param \Magento\ImportExport\Model\Import\Config $importConfig
* @param Proxy\Product\ResourceFactory $resourceFactory
@@ -535,7 +547,9 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
\Magento\ImportExport\Model\Resource\Helper $resourceHelper,
\Magento\Framework\Stdlib\String $string,
\Magento\Framework\Event\ManagerInterface $eventManager,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
+ \Magento\CatalogInventory\Api\StockStateInterface $stockState,
\Magento\Catalog\Helper\Data $catalogData,
\Magento\ImportExport\Model\Import\Config $importConfig,
\Magento\CatalogImportExport\Model\Import\Proxy\Product\ResourceFactory $resourceFactory,
@@ -558,7 +572,9 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
array $data = array()
) {
$this->_eventManager = $eventManager;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
+ $this->stockConfiguration = $stockConfiguration;
+ $this->stockState = $stockState;
$this->_catalogData = $catalogData;
$this->_importConfig = $importConfig;
$this->_resourceFactory = $resourceFactory;
@@ -1777,13 +1793,15 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
continue;
}
- $row = array();
+ $row = [];
$row['product_id'] = $this->_newSku[$rowData[self::COL_SKU]]['entity_id'];
$productIdsToReindex[] = $row['product_id'];
- $row['stock_id'] = \Magento\CatalogInventory\Model\Stock\Item::DEFAULT_STOCK_ID;
- $stockItemDo = $this->stockItemService->getStockItem($row['product_id']);
- $existStockData = $stockItemDo->__toArray();
+ $row['website_id'] = $this->stockConfiguration->getDefaultWebsiteId();
+ $row['stock_id'] = $this->stockRegistry->getStock($row['website_id'])->getId();
+
+ $stockItemDo = $this->stockRegistry->getStockItem($row['product_id'], $row['website_id']);
+ $existStockData = $stockItemDo->getData();
$row = array_merge(
$this->defaultStockData,
@@ -1792,19 +1810,13 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
$row
);
- if ($this->stockItemService->isQty($this->_newSku[$rowData[self::COL_SKU]]['type_id'])) {
- $row = $this->stockItemService->processIsInStock($row);
- if ($this->stockItemService->verifyNotification($row['product_id'])) {
- $row['low_stock_date'] = $this->_localeDate->date(
- null,
- null,
- null,
- false
- )->toString(
- \Magento\Framework\Stdlib\DateTime::DATETIME_INTERNAL_FORMAT
- );
+ if ($this->stockConfiguration->isQty($this->_newSku[$rowData[self::COL_SKU]]['type_id'])) {
+ $row['is_in_stock'] = $this->stockState->verifyStock($row['product_id'], $row['website_id']);
+ if ($this->stockState->verifyNotification($row['product_id'], $row['website_id'])) {
+ $row['low_stock_date'] = $this->_localeDate->date(null, null, null, false)
+ ->toString(\Magento\Framework\Stdlib\DateTime::DATETIME_INTERNAL_FORMAT);
}
- $row['stock_status_changed_auto'] = (int) !$this->stockItemService->verifyStock($row['product_id']);
+ $row['stock_status_changed_auto'] = (int) !$this->stockState->verifyStock($row['product_id'], $row['website_id']);
} else {
$row['qty'] = 0;
}
diff --git a/app/code/Magento/CatalogImportExport/Model/Import/Product/Type/Factory.php b/app/code/Magento/CatalogImportExport/Model/Import/Product/Type/Factory.php
index 50c6107622551031e3706d1169454380aec2eb03..7dcf6b301f7a49d737f90ace74a2b3c724f751a4 100644
--- a/app/code/Magento/CatalogImportExport/Model/Import/Product/Type/Factory.php
+++ b/app/code/Magento/CatalogImportExport/Model/Import/Product/Type/Factory.php
@@ -31,14 +31,14 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/CatalogImportExport/composer.json b/app/code/Magento/CatalogImportExport/composer.json
index ce67e7ed7803745c4346c97b4f56d69292084717..61c5665b2d366f8c4a6a32a02cf3b36253ffc5c5 100644
--- a/app/code/Magento/CatalogImportExport/composer.json
+++ b/app/code/Magento/CatalogImportExport/composer.json
@@ -3,20 +3,20 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-import-export": "0.1.0-alpha104",
- "magento/module-indexer": "0.1.0-alpha104",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-import-export": "0.1.0-alpha105",
+ "magento/module-indexer": "0.1.0-alpha105",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"ext-ctype": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/CatalogInventory/Api/Data/StockCollectionInterface.php b/app/code/Magento/CatalogInventory/Api/Data/StockCollectionInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..7f30b82544f3266f106d4777a55898bb74b97b51
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/Data/StockCollectionInterface.php
@@ -0,0 +1,43 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+/**
+ * Stock collection interface
+ */
+namespace Magento\CatalogInventory\Api\Data;
+
+use Magento\Framework\Api\SearchResultsInterface;
+
+/**
+ * Interface StockCollectionInterface
+ */
+interface StockCollectionInterface extends SearchResultsInterface
+{
+ /**
+ * Get items
+ *
+ * @return \Magento\CatalogInventory\Api\Data\StockInterface[]
+ */
+ public function getItems();
+}
diff --git a/app/code/Magento/CatalogInventory/Api/Data/StockInterface.php b/app/code/Magento/CatalogInventory/Api/Data/StockInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..d0e585e8f9d12d47979d68e9b8fa7e5f53687033
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/Data/StockInterface.php
@@ -0,0 +1,61 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api\Data;
+
+use Magento\Framework\Api\ExtensibleDataInterface;
+
+/**
+ * Interface Stock
+ * @package Magento\CatalogInventory\Api\Data
+ * @data-api
+ */
+interface StockInterface extends ExtensibleDataInterface
+{
+ const ID = 'stock_id';
+
+ const WEBSITE_ID = 'website_id';
+
+ const STOCK_NAME = 'stock_name';
+
+ /**
+ * Retrieve stock identifier
+ *
+ * @return int|null
+ */
+ public function getId();
+
+ /**
+ * Retrieve website identifier
+ *
+ * @return int
+ */
+ public function getWebsiteId();
+
+ /**
+ * Retrieve stock name
+ *
+ * @return string
+ */
+ public function getStockName();
+}
diff --git a/app/code/Magento/CatalogInventory/Api/Data/StockItemCollectionInterface.php b/app/code/Magento/CatalogInventory/Api/Data/StockItemCollectionInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..494973b122598c8fc13d703624348546b7802943
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/Data/StockItemCollectionInterface.php
@@ -0,0 +1,51 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+/**
+ * Stock Item collection interface
+ */
+namespace Magento\CatalogInventory\Api\Data;
+
+use Magento\Framework\Api\SearchResultsInterface;
+
+/**
+ * Interface StockItemCollectionInterface
+ * @package Magento\CatalogInventory\Api\Data
+ */
+interface StockItemCollectionInterface extends SearchResultsInterface
+{
+ /**
+ * Get items
+ *
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface[]
+ */
+ public function getItems();
+
+ /**
+ * Get search criteria.
+ *
+ * @return \Magento\CatalogInventory\Api\StockItemCriteriaInterface
+ */
+ public function getSearchCriteria();
+}
diff --git a/app/code/Magento/CatalogInventory/Api/Data/StockItemInterface.php b/app/code/Magento/CatalogInventory/Api/Data/StockItemInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..748fa5cb0290118786ba0276e551ba1ce36dc2e6
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/Data/StockItemInterface.php
@@ -0,0 +1,235 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api\Data;
+
+use Magento\Framework\Api\ExtensibleDataInterface;
+
+/**
+ * Interface StockItem
+ * @data-api
+ */
+interface StockItemInterface extends ExtensibleDataInterface
+{
+ const BACKORDERS_NO = 0;
+
+ const ID = 'item_id';
+ const PRODUCT_ID = 'product_id';
+ const WEBSITE_ID = 'website_id';
+ const STOCK_ID = 'stock_id';
+ const QTY = 'qty';
+ const IS_QTY_DECIMAL = 'is_qty_decimal';
+ const SHOW_DEFAULT_NOTIFICATION_MESSAGE = 'show_default_notification_message';
+
+ const USE_CONFIG_MIN_QTY = 'use_config_min_qty';
+ const MIN_QTY = 'min_qty';
+
+ const USE_CONFIG_MIN_SALE_QTY = 'use_config_min_sale_qty';
+ const MIN_SALE_QTY = 'min_sale_qty';
+
+ const USE_CONFIG_MAX_SALE_QTY = 'use_config_max_sale_qty';
+ const MAX_SALE_QTY = 'max_sale_qty';
+
+ const USE_CONFIG_BACKORDERS = 'use_config_backorders';
+ const BACKORDERS = 'backorders';
+
+ const USE_CONFIG_NOTIFY_STOCK_QTY = 'use_config_notify_stock_qty';
+ const NOTIFY_STOCK_QTY = 'use_config_notify_stock_qty';
+
+ const USE_CONFIG_QTY_INCREMENTS = 'use_config_qty_increments';
+ const QTY_INCREMENTS = 'qty_increments';
+
+ const USE_CONFIG_ENABLE_QTY_INC = 'use_config_enable_qty_inc';
+ const ENABLE_QTY_INCREMENTS = 'enable_qty_increments';
+
+ const USE_CONFIG_MANAGE_STOCK = 'use_config_manage_stock';
+ const MANAGE_STOCK = 'manage_stock';
+
+ const IS_IN_STOCK = 'is_in_stock';
+ const LOW_STOCK_DATE = 'low_stock_date';
+ const IS_DECIMAL_DIVIDED = 'is_decimal_divided';
+ const STOCK_STATUS_CHANGED_AUTO = 'stock_status_changed_auto';
+
+ const STORE_ID = 'store_id';
+ const CUSTOMER_GROUP_ID = 'customer_group_id';
+
+ /**
+ * @return int|null
+ */
+ public function getId();
+
+ /**
+ * @return int
+ */
+ public function getProductId();
+
+ /**
+ * Retrieve Website Id
+ *
+ * @return int
+ */
+ public function getWebsiteId();
+
+ /**
+ * Retrieve stock identifier
+ *
+ * @return int
+ */
+ public function getStockId();
+
+ /**
+ * @return float
+ */
+ public function getQty();
+
+ /**
+ * Retrieve Stock Availability
+ *
+ * @return bool|int
+ */
+ public function getIsInStock();
+
+ /**
+ * @return bool
+ */
+ public function getIsQtyDecimal();
+
+ /**
+ * @return bool
+ */
+ public function getShowDefaultNotificationMessage();
+
+ ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+
+ /**
+ * @return bool
+ */
+ public function getUseConfigMinQty();
+
+ /**
+ * Retrieve minimal quantity available for item status in stock
+ *
+ * @return float
+ */
+ public function getMinQty();
+
+ /**
+ * @return int
+ */
+ public function getUseConfigMinSaleQty();
+
+ /**
+ * Retrieve Minimum Qty Allowed in Shopping Cart or NULL when there is no limitation
+ *
+ * @return float
+ */
+ public function getMinSaleQty();
+
+ /**
+ * @return bool
+ */
+ public function getUseConfigMaxSaleQty();
+
+ /**
+ * Retrieve Maximum Qty Allowed in Shopping Cart data wrapper
+ *
+ * @return float
+ */
+ public function getMaxSaleQty();
+
+ /**
+ * @return bool
+ */
+ public function getUseConfigBackorders();
+
+ /**
+ * Retrieve backorders status
+ *
+ * @return int
+ */
+ public function getBackorders();
+
+ /**
+ * @return bool
+ */
+ public function getUseConfigNotifyStockQty();
+
+ /**
+ * Retrieve Notify for Quantity Below data wrapper
+ *
+ * @return float
+ */
+ public function getNotifyStockQty();
+
+ /**
+ * @return bool
+ */
+ public function getUseConfigQtyIncrements();
+
+ /**
+ * Retrieve Quantity Increments data wrapper
+ *
+ * @return float|false
+ */
+ public function getQtyIncrements();
+
+
+ /**
+ * @return bool
+ */
+ public function getUseConfigEnableQtyInc();
+
+ /**
+ * Retrieve whether Quantity Increments is enabled
+ *
+ * @return bool
+ */
+ public function getEnableQtyIncrements();
+
+ /**
+ * @return bool
+ */
+ public function getUseConfigManageStock();
+
+ /**
+ * Retrieve can Manage Stock
+ *
+ * @return bool
+ */
+ public function getManageStock();
+
+ /**
+ * @return string
+ */
+ public function getLowStockDate();
+
+ /**
+ * @return bool
+ */
+ public function getIsDecimalDivided();
+
+ /**
+ * @return int
+ */
+ public function getStockStatusChangedAuto();
+}
diff --git a/app/code/Magento/CatalogInventory/Api/Data/StockStatusCollectionInterface.php b/app/code/Magento/CatalogInventory/Api/Data/StockStatusCollectionInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..90b1ddeeaf6242da39842b46e21100f6be5694f1
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/Data/StockStatusCollectionInterface.php
@@ -0,0 +1,46 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api\Data;
+
+use Magento\Framework\Api\SearchResultsInterface;
+
+/**
+ * Stock Status collection interface
+ */
+interface StockStatusCollectionInterface extends SearchResultsInterface
+{
+ /**
+ * Get items
+ *
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusInterface[]
+ */
+ public function getItems();
+
+ /**
+ * Get search criteria.
+ *
+ * @return \Magento\CatalogInventory\Api\StockStatusCriteriaInterface
+ */
+ public function getSearchCriteria();
+}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/Data/LowStockResult.php b/app/code/Magento/CatalogInventory/Api/Data/StockStatusInterface.php
similarity index 52%
rename from app/code/Magento/CatalogInventory/Service/V1/Data/LowStockResult.php
rename to app/code/Magento/CatalogInventory/Api/Data/StockStatusInterface.php
index 02b8067efa32a3acc428b9763d907af68d91a5c2..7558c33f471b1cb7bdc44d46ae7a27376e6848ce 100644
--- a/app/code/Magento/CatalogInventory/Service/V1/Data/LowStockResult.php
+++ b/app/code/Magento/CatalogInventory/Api/Data/StockStatusInterface.php
@@ -21,52 +21,55 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\CatalogInventory\Service\V1\Data;
+namespace Magento\CatalogInventory\Api\Data;
-use Magento\Framework\Api\AbstractExtensibleObject;
+use Magento\Framework\Api\ExtensibleDataInterface;
/**
- * Low stock search result data object
- *
- * @codeCoverageIgnore
+ * Interface StockStatusInterface
+ * @data-api
*/
-class LowStockResult extends AbstractExtensibleObject
+interface StockStatusInterface extends ExtensibleDataInterface
{
/**#@+
- * Low stock search result object data keys
+ * Stock status object data keys
*/
- const PRODUCT_SKU_LIST = 'items';
- const SEARCH_CRITERIA = 'search_criteria';
- const TOTAL_COUNT = 'total_count';
+ const PRODUCT_ID = 'product_id';
+ const WEBSITE_ID = 'website_id';
+ const STOCK_ID = 'stock_id';
+ const QTY = 'qty';
+ const STOCK_STATUS = 'stock_status';
+ const STOCK_ITEM = 'stock_item';
+
/**#@-*/
/**
- * Get items
- *
- * @return string[]
+ * @return int
+ */
+ public function getProductId();
+
+ /**
+ * @return int
*/
- public function getItems()
- {
- return is_null($this->_get(self::PRODUCT_SKU_LIST)) ? array() : $this->_get(self::PRODUCT_SKU_LIST);
- }
+ public function getWebsiteId();
/**
- * Get search criteria
- *
- * @return \Magento\CatalogInventory\Service\V1\Data\LowStockCriteria
+ * @return int
*/
- public function getSearchCriteria()
- {
- return $this->_get(self::SEARCH_CRITERIA);
- }
+ public function getStockId();
/**
- * Get total count
- *
* @return int
*/
- public function getTotalCount()
- {
- return $this->_get(self::TOTAL_COUNT);
- }
+ public function getQty();
+
+ /**
+ * @return int
+ */
+ public function getStockStatus();
+
+ /**
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
+ */
+ public function getStockItem();
}
diff --git a/app/code/Magento/CatalogInventory/Api/StockConfigurationInterface.php b/app/code/Magento/CatalogInventory/Api/StockConfigurationInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..4f1e653b404ed66b578f740c9453a9e16ea68d35
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/StockConfigurationInterface.php
@@ -0,0 +1,163 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+/**
+ * Interface StockConfigurationInterface
+ * @package Magento\CatalogInventory\Api
+ * @api
+ */
+interface StockConfigurationInterface
+{
+ /**
+ * Retrieve Default Website ID
+ *
+ * @return int
+ */
+ public function getDefaultWebsiteId();
+
+ /**
+ * @param int|null $filter
+ * @return array
+ */
+ public function getIsQtyTypeIds($filter = null);
+
+ /**
+ * Check if Stock Management is applicable for the given Product Type
+ *
+ * @param int $productTypeId
+ * @return bool
+ */
+ public function isQty($productTypeId);
+
+ /**
+ * Check if is possible subtract value from item qty
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function canSubtractQty($store = null);
+
+ /**
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return float
+ */
+ public function getMinQty($store = null);
+
+ /**
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @param int $customerGroupId
+ * @return float
+ */
+ public function getMinSaleQty($store = null, $customerGroupId = null);
+
+ /**
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return float|null
+ */
+ public function getMaxSaleQty($store = null);
+
+ /**
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return float
+ */
+ public function getNotifyStockQty($store = null);
+
+ /**
+ * Retrieve whether Quantity Increments is enabled
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function getEnableQtyIncrements($store = null);
+
+ /**
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return int
+ */
+ public function getQtyIncrements($store = null);
+
+ /**
+ * Retrieve backorders status
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return int
+ */
+ public function getBackorders($store = null);
+
+ /**
+ * Retrieve Manage Stock data wrapper
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return int
+ */
+ public function getManageStock($store = null);
+
+ /**
+ * Retrieve can Back in stock
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function getCanBackInStock($store = null);
+
+ /**
+ * Display out of stock products option
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function isShowOutOfStock($store = null);
+
+ /**
+ * Check if credit memo items auto return option is enabled
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function isAutoReturnEnabled($store = null);
+
+ /**
+ * Get 'Display product stock status' option value
+ * Shows if it is necessary to show product stock status ('in stock'/'out of stock')
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function isDisplayProductStockStatus($store = null);
+
+ /**
+ * @param string $field
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return string|null
+ */
+ public function getDefaultConfigValue($field, $store = null);
+
+ /**
+ * Retrieve inventory item options (used in config)
+ *
+ * @return string[]
+ */
+ public function getConfigItemOptions();
+}
diff --git a/app/code/Magento/CatalogInventory/Api/StockCriteriaInterface.php b/app/code/Magento/CatalogInventory/Api/StockCriteriaInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..abb4cda0d812bd2a343b7257b2f6ac4c98bf843e
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/StockCriteriaInterface.php
@@ -0,0 +1,46 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+/**
+ * Interface StockCriteriaInterface
+ */
+interface StockCriteriaInterface extends \Magento\Framework\Api\CriteriaInterface
+{
+ /**
+ * Add Criteria object
+ *
+ * @param \Magento\CatalogInventory\Api\StockCriteriaInterface $criteria
+ * @return void
+ */
+ public function addCriteria(\Magento\CatalogInventory\Api\StockCriteriaInterface $criteria);
+
+ /**
+ * Add website filter to collection
+ *
+ * @param array|int|object $website
+ * @return void
+ */
+ public function setWebsiteFilter($website);
+}
diff --git a/app/code/Magento/CatalogInventory/Api/StockIndexInterface.php b/app/code/Magento/CatalogInventory/Api/StockIndexInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..7fd951b1d3d2e5a79b4b8d5678c7d7b5aaa478a2
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/StockIndexInterface.php
@@ -0,0 +1,41 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+/**
+ * Interface StockIndexInterface
+ * @package Magento\CatalogInventory\Api
+ * @api
+ */
+interface StockIndexInterface
+{
+ /**
+ * Rebuild stock index of the given website
+ *
+ * @param int $productId
+ * @param int $websiteId
+ * @return true
+ */
+ public function rebuild($productId = null, $websiteId = null);
+}
diff --git a/app/code/Magento/CatalogInventory/Api/StockItemCriteriaInterface.php b/app/code/Magento/CatalogInventory/Api/StockItemCriteriaInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..5afecda8fec2f5bf2ab472a7b2008166849a566f
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/StockItemCriteriaInterface.php
@@ -0,0 +1,87 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+/**
+ * Interface StockItemCriteriaInterface
+ */
+interface StockItemCriteriaInterface extends \Magento\Framework\Api\CriteriaInterface
+{
+ /**
+ * Add Criteria object
+ *
+ * @param \Magento\CatalogInventory\Api\StockItemCriteriaInterface $criteria
+ * @return void
+ */
+ public function addCriteria(\Magento\CatalogInventory\Api\StockItemCriteriaInterface $criteria);
+
+ /**
+ * Join Stock Status to collection
+ *
+ * @param int $storeId
+ * @return void
+ */
+ public function setStockStatus($storeId = null);
+
+ /**
+ * Add stock filter to collection
+ *
+ * @param \Magento\CatalogInventory\Api\Data\StockInterface|string|array $stock
+ * @return void
+ */
+ public function setStockFilter($stock);
+
+ /**
+ * Add website filter to collection
+ *
+ * @param array|int|object $website
+ * @return void
+ */
+ public function setWebsiteFilter($website);
+
+ /**
+ * Add product filter to collection
+ *
+ * @param array|int|object $products
+ * @return void
+ */
+ public function setProductsFilter($products);
+
+ /**
+ * Add Managed Stock products filter to collection
+ *
+ * @param bool $isStockManagedInConfig
+ * @return void
+ */
+ public function setManagedFilter($isStockManagedInConfig);
+
+ /**
+ * Add filter by quantity to collection
+ *
+ * @param string $comparisonMethod
+ * @param float $qty
+ * @return void
+ */
+ public function setQtyFilter($comparisonMethod, $qty);
+}
diff --git a/app/code/Magento/CatalogInventory/Api/StockItemRepositoryInterface.php b/app/code/Magento/CatalogInventory/Api/StockItemRepositoryInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..8701254867cec55e3d5df9a7b91e2915c0aebb91
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/StockItemRepositoryInterface.php
@@ -0,0 +1,68 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+/**
+ * Interface StockItemRepository
+ */
+interface StockItemRepositoryInterface
+{
+ /**
+ * Save Stock Item data
+ *
+ * @param \Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
+ */
+ public function save(\Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem);
+
+ /**
+ * Load Stock Item data by given stockId and parameters
+ *
+ * @param string $stockId
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
+ */
+ public function get($stockId);
+
+ /**
+ * Load Stock Item data collection by given search criteria
+ *
+ * @param \Magento\CatalogInventory\Api\StockItemCriteriaInterface $criteria
+ * @return \Magento\CatalogInventory\Api\Data\StockItemCollectionInterface
+ */
+ public function getList(\Magento\CatalogInventory\Api\StockItemCriteriaInterface $criteria);
+
+ /**
+ * Delete stock item
+ *
+ * @param \Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem
+ * @return true
+ */
+ public function delete(\Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem);
+
+ /**
+ * @param int $id
+ * @return bool
+ */
+ public function deleteById($id);
+}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/StockStatusServiceInterface.php b/app/code/Magento/CatalogInventory/Api/StockManagementInterface.php
similarity index 54%
rename from app/code/Magento/CatalogInventory/Service/V1/StockStatusServiceInterface.php
rename to app/code/Magento/CatalogInventory/Api/StockManagementInterface.php
index 95fca6c21a104675345e41d408646cd8776bbb63..ad005f436e144e547efc0d613e611ac89193a237 100644
--- a/app/code/Magento/CatalogInventory/Service/V1/StockStatusServiceInterface.php
+++ b/app/code/Magento/CatalogInventory/Api/StockManagementInterface.php
@@ -21,37 +21,40 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\CatalogInventory\Service\V1;
-
-use Magento\CatalogInventory\Model\Stock;
+namespace Magento\CatalogInventory\Api;
/**
- * Interface StockStatusServiceInterface
+ * Interface StockManagementInterface
+ * @package Magento\CatalogInventory\Api
+ * @api
*/
-interface StockStatusServiceInterface
+interface StockManagementInterface
{
/**
- * Retrieve Product Stock Status
+ * Subtract product qtys from stock.
+ * Return array of items that require full save
*
- * @param int $productId
+ * @param array $items
* @param int $websiteId
- * @param int $stockId
- * @return array
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface[]
+ * @throws \Magento\Framework\Model\Exception
*/
- public function getProductStockStatus($productId, $websiteId, $stockId = Stock::DEFAULT_STOCK_ID);
+ public function registerProductsSale($items, $websiteId = null);
/**
- * @param string $sku
- * @return \Magento\CatalogInventory\Service\V1\Data\StockStatus
- * @throw \Magento\Framework\Exception\NoSuchEntityException
+ * @param array $items
+ * @param int $websiteId
+ * @return void
*/
- public function getProductStockStatusBySku($sku);
+ public function revertProductsSale(array $items, $websiteId = null);
/**
- * Retrieves a list of SKU's with low inventory qty
+ * Get back to stock (when order is canceled or whatever else)
*
- * @param \Magento\CatalogInventory\Service\V1\Data\LowStockCriteria $lowStockCriteria
- * @return \Magento\CatalogInventory\Service\V1\Data\LowStockResult contains string[]
+ * @param int $productId
+ * @param int|float $qty
+ * @param int $websiteId
+ * @return void
*/
- public function getLowStockItems($lowStockCriteria);
+ public function backItemQty($productId, $qty, $websiteId = null);
}
diff --git a/app/code/Magento/CatalogInventory/Api/StockRegistryInterface.php b/app/code/Magento/CatalogInventory/Api/StockRegistryInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..41ac62690108c394cab944b951a1f5e314743672
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/StockRegistryInterface.php
@@ -0,0 +1,103 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+/**
+ * Interface StockRegistryInterface
+ * @package Magento\CatalogInventory\Api
+ * @api
+ */
+interface StockRegistryInterface
+{
+ /**
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockInterface
+ */
+ public function getStock($websiteId = null);
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
+ */
+ public function getStockItem($productId, $websiteId = null);
+
+ /**
+ * @param string $productSku
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
+ * @throws \Magento\Framework\Exception\NoSuchEntityException
+ */
+ public function getStockItemBySku($productSku, $websiteId = null);
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusInterface
+ */
+ public function getStockStatus($productId, $websiteId = null);
+
+ /**
+ * @param string $productSku
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusInterface
+ * @throws \Magento\Framework\Exception\NoSuchEntityException
+ */
+ public function getStockStatusBySku($productSku, $websiteId = null);
+
+ /**
+ * Retrieve Product stock status
+ * @param int $productId
+ * @param int $websiteId
+ * @return int
+ */
+ public function getProductStockStatus($productId, $websiteId = null);
+
+ /**
+ * @param string $productSku
+ * @param int $websiteId
+ * @return int
+ * @throw \Magento\Framework\Exception\NoSuchEntityException
+ */
+ public function getProductStockStatusBySku($productSku, $websiteId = null);
+
+ /**
+ * Retrieves a list of SKU's with low inventory qty
+ *
+ * @param int $websiteId
+ * @param float $qty
+ * @param int $currentPage
+ * @param int $pageSize
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusCollectionInterface
+ */
+ public function getLowStockItems($websiteId, $qty, $currentPage = 1, $pageSize = 0);
+
+ /**
+ * @param string $productSku
+ * @param \Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem
+ * @return int
+ * @throws \Magento\Framework\Exception\NoSuchEntityException
+ */
+ public function updateStockItemBySku($productSku, \Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem);
+}
diff --git a/app/code/Magento/CatalogInventory/Api/StockRepositoryInterface.php b/app/code/Magento/CatalogInventory/Api/StockRepositoryInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..0728e24d9e10fc6a57b741fe4f12ea95ab015f19
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/StockRepositoryInterface.php
@@ -0,0 +1,62 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+/**
+ * Interface StockRepositoryInterface
+ */
+interface StockRepositoryInterface
+{
+ /**
+ * Save Stock data
+ *
+ * @param \Magento\CatalogInventory\Api\Data\StockInterface $stock
+ * @return \Magento\CatalogInventory\Api\Data\StockInterface
+ */
+ public function save(\Magento\CatalogInventory\Api\Data\StockInterface $stock);
+
+ /**
+ * Load Stock data by given stockId and parameters
+ *
+ * @param string $stockId
+ * @return \Magento\CatalogInventory\Api\Data\StockInterface
+ */
+ public function get($stockId);
+
+ /**
+ * Load Stock data collection by given search criteria
+ *
+ * @param \Magento\CatalogInventory\Api\StockCriteriaInterface $collectionBuilder
+ * @return \Magento\CatalogInventory\Api\Data\StockCollectionInterface
+ */
+ public function getList(StockCriteriaInterface $collectionBuilder);
+
+ /**
+ * Delete stock by given stockId
+ *
+ * @param \Magento\CatalogInventory\Api\Data\StockInterface $stock
+ * @return bool
+ */
+ public function delete(\Magento\CatalogInventory\Api\Data\StockInterface $stock);
+}
diff --git a/app/code/Magento/CatalogInventory/Api/StockStateInterface.php b/app/code/Magento/CatalogInventory/Api/StockStateInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..6ebc9aaa7d3698108fb0b1d861e906042c50d578
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/StockStateInterface.php
@@ -0,0 +1,95 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+/**
+ * Interface StockStateInterface
+ * @package Magento\CatalogInventory\Api
+ * @api
+ */
+interface StockStateInterface
+{
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return bool
+ */
+ public function verifyStock($productId, $websiteId = null);
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return bool
+ */
+ public function verifyNotification($productId, $websiteId = null);
+
+ /**
+ * @param int $productId
+ * @param int|float $itemQty
+ * @param int|float $qtyToCheck
+ * @param int|float $origQty
+ * @param int $websiteId
+ * @return int
+ */
+ public function checkQuoteItemQty($productId, $itemQty, $qtyToCheck, $origQty, $websiteId = null);
+
+ /**
+ * Check quantity
+ *
+ * @param int $productId
+ * @param int|float $qty
+ * @param int $websiteId
+ * @exception \Magento\Framework\Model\Exception
+ * @return bool
+ */
+ public function checkQty($productId, $qty, $websiteId = null);
+
+ /**
+ * @param int $productId
+ * @param int|float $qty
+ * @param int $websiteId
+ * @return \Magento\Framework\Object
+ */
+ public function checkQtyIncrements($productId, $qty, $websiteId = null);
+
+ /**
+ * Returns suggested qty that satisfies qty increments and minQty/maxQty/minSaleQty/maxSaleQty conditions
+ * or original qty if such value does not exist
+ *
+ * @param int $productId
+ * @param int|float $qty
+ * @param int $websiteId
+ * @return int|float
+ */
+ public function suggestQty($productId, $qty, $websiteId = null);
+
+ /**
+ * Retrieve stock qty whether product is composite or no
+ *
+ * @param int $productId
+ * @param int $websiteId
+ * @return float
+ */
+ public function getStockQty($productId, $websiteId = null);
+}
diff --git a/app/code/Magento/CatalogInventory/Api/StockStatusCriteriaInterface.php b/app/code/Magento/CatalogInventory/Api/StockStatusCriteriaInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..d7f3bbb8dd075264166b34669e408634c95fedd0
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/StockStatusCriteriaInterface.php
@@ -0,0 +1,62 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+/**
+ * Interface StockStatusCriteriaInterface
+ */
+interface StockStatusCriteriaInterface extends \Magento\Framework\Api\CriteriaInterface
+{
+ /**
+ * Add Criteria object
+ *
+ * @param \Magento\CatalogInventory\Api\StockStatusCriteriaInterface $criteria
+ * @return void
+ */
+ public function addCriteria(\Magento\CatalogInventory\Api\StockStatusCriteriaInterface $criteria);
+
+ /**
+ * Filter by website(s)
+ *
+ * @param int|object $website
+ * @return void
+ */
+ public function setWebsiteFilter($website);
+
+ /**
+ * Add product(s) filter
+ *
+ * @param array|int|object $products
+ * @return void
+ */
+ public function setProductsFilter($products);
+
+ /**
+ * Add filter by quantity
+ *
+ * @param float $qty
+ * @return void
+ */
+ public function setQtyFilter($qty);
+}
diff --git a/app/code/Magento/CatalogInventory/Api/StockStatusRepositoryInterface.php b/app/code/Magento/CatalogInventory/Api/StockStatusRepositoryInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..1baa59da55cfe558ec6b7cd13a976939fdbe609e
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Api/StockStatusRepositoryInterface.php
@@ -0,0 +1,62 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+/**
+ * Interface StockStatusRepositoryInterface
+ */
+interface StockStatusRepositoryInterface
+{
+ /**
+ * Save StockStatus data
+ *
+ * @param \Magento\CatalogInventory\Api\Data\StockStatusInterface $stockStatus
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusInterface
+ */
+ public function save(\Magento\CatalogInventory\Api\Data\StockStatusInterface $stockStatus);
+
+ /**
+ * Load StockStatus data by given stockStatusId and parameters
+ *
+ * @param string $stockStatusId
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusInterface
+ */
+ public function get($stockStatusId);
+
+ /**
+ * Load Stock Status data collection by given search criteria
+ *
+ * @param \Magento\CatalogInventory\Api\StockStatusCriteriaInterface $searchCriteria
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusCollectionInterface
+ */
+ public function getList(StockStatusCriteriaInterface $searchCriteria);
+
+ /**
+ * Delete StockStatus entity
+ *
+ * @param \Magento\CatalogInventory\Api\Data\StockStatusInterface $stockStatus
+ * @return true
+ */
+ public function delete(\Magento\CatalogInventory\Api\Data\StockStatusInterface $stockStatus);
+}
diff --git a/app/code/Magento/CatalogInventory/Block/Qtyincrements.php b/app/code/Magento/CatalogInventory/Block/Qtyincrements.php
index d8b57d513fe8a25b6b933145edd199a8af58c4af..ee0837a3724164857c5fef7fe2c004956145dcac 100644
--- a/app/code/Magento/CatalogInventory/Block/Qtyincrements.php
+++ b/app/code/Magento/CatalogInventory/Block/Qtyincrements.php
@@ -47,24 +47,24 @@ class Qtyincrements extends Template implements IdentityInterface
protected $_coreRegistry;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @param \Magento\Framework\View\Element\Template\Context $context
* @param \Magento\Framework\Registry $registry
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param array $data
*/
public function __construct(
\Magento\Framework\View\Element\Template\Context $context,
\Magento\Framework\Registry $registry,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
array $data = array()
) {
$this->_coreRegistry = $registry;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
parent::__construct($context, $data);
}
@@ -96,7 +96,11 @@ class Qtyincrements extends Template implements IdentityInterface
public function getProductQtyIncrements()
{
if ($this->_qtyIncrements === null) {
- $this->_qtyIncrements = $this->stockItemService->getQtyIncrements($this->getProduct()->getId());
+ $stockItem = $this->stockRegistry->getStockItem(
+ $this->getProduct()->getId(),
+ $this->getProduct()->getStore()->getWebsiteId()
+ );
+ $this->_qtyIncrements = $stockItem->getQtyIncrements();
if (!$this->getProduct()->isSaleable()) {
$this->_qtyIncrements = false;
}
diff --git a/app/code/Magento/CatalogInventory/Block/Stockqty/AbstractStockqty.php b/app/code/Magento/CatalogInventory/Block/Stockqty/AbstractStockqty.php
index 59e31b7cc4a2b299a3c8d910d1b1489d26f76a5d..be9990ad13d7c61656cdcf2f901d95a4bf6f18c7 100644
--- a/app/code/Magento/CatalogInventory/Block/Stockqty/AbstractStockqty.php
+++ b/app/code/Magento/CatalogInventory/Block/Stockqty/AbstractStockqty.php
@@ -44,24 +44,33 @@ abstract class AbstractStockqty extends \Magento\Framework\View\Element\Template
protected $_coreRegistry;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockStateInterface
*/
- protected $stockItemService;
+ protected $stockState;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
+ */
+ protected $stockRegistry;
/**
* @param \Magento\Framework\View\Element\Template\Context $context
* @param \Magento\Framework\Registry $registry
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockStateInterface $stockState
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param array $data
*/
public function __construct(
\Magento\Framework\View\Element\Template\Context $context,
\Magento\Framework\Registry $registry,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockStateInterface $stockState,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
array $data = array()
) {
$this->_coreRegistry = $registry;
- $this->stockItemService = $stockItemService;
+ $this->stockState = $stockState;
+ $this->stockRegistry = $stockRegistry;
+
parent::__construct($context, $data);
}
@@ -101,7 +110,7 @@ abstract class AbstractStockqty extends \Magento\Framework\View\Element\Template
*/
public function getProductStockQty($product)
{
- return $this->stockItemService->getStockQty($product->getId());
+ return $this->stockState->getStockQty($product->getId(), $product->getStore()->getWebsiteId());
}
/**
@@ -112,7 +121,7 @@ abstract class AbstractStockqty extends \Magento\Framework\View\Element\Template
public function getThresholdQty()
{
if (!$this->hasData('threshold_qty')) {
- $qty = (float) $this->_scopeConfig->getValue(
+ $qty = (float)$this->_scopeConfig->getValue(
self::XML_PATH_STOCK_THRESHOLD_QTY,
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
);
@@ -148,8 +157,7 @@ abstract class AbstractStockqty extends \Magento\Framework\View\Element\Template
*/
public function getStockQtyLeft()
{
- /** @var \Magento\CatalogInventory\Service\V1\Data\StockItem $stockItem */
- $stockItem = $this->stockItemService->getStockItem($this->getProduct()->getId());
+ $stockItem = $this->stockRegistry->getStockItem($this->getProduct()->getId());
$minStockQty = $stockItem->getMinQty();
return $this->getStockQty() - $minStockQty;
}
diff --git a/app/code/Magento/CatalogInventory/Helper/Data.php b/app/code/Magento/CatalogInventory/Helper/Data.php
index 54849de6512062f5f1b762bedf0aafefddc4c5f2..14969cfd123cfcd012880086dce21769b1fce525 100644
--- a/app/code/Magento/CatalogInventory/Helper/Data.php
+++ b/app/code/Magento/CatalogInventory/Helper/Data.php
@@ -29,21 +29,6 @@ namespace Magento\CatalogInventory\Helper;
*/
class Data extends \Magento\Framework\App\Helper\AbstractHelper
{
- /**
- * Show out of stock config path
- */
- const XML_PATH_SHOW_OUT_OF_STOCK = 'cataloginventory/options/show_out_of_stock';
-
- /**
- * Auto return config path
- */
- const XML_PATH_ITEM_AUTO_RETURN = 'cataloginventory/item_options/auto_return';
-
- /**
- * Path to configuration option 'Display product stock status'
- */
- const XML_PATH_DISPLAY_PRODUCT_STOCK_STATUS = 'cataloginventory/options/display_product_stock_status';
-
/**
* Error codes, that Catalog Inventory module can set to quote or quote items
*/
@@ -53,83 +38,4 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
* Error qty increments
*/
const ERROR_QTY_INCREMENTS = 2;
-
- /**
- * Core store config
- *
- * @var \Magento\Framework\App\Config\ScopeConfigInterface
- */
- protected $scopeConfig;
-
- /**
- * @param \Magento\Framework\App\Helper\Context $context
- * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
- */
- public function __construct(
- \Magento\Framework\App\Helper\Context $context,
- \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
- ) {
- $this->scopeConfig = $scopeConfig;
- parent::__construct($context);
- }
-
- /**
- * Retrieve inventory item options (used in config)
- *
- * @return string[]
- */
- public function getConfigItemOptions()
- {
- return array(
- 'min_qty',
- 'backorders',
- 'min_sale_qty',
- 'max_sale_qty',
- 'notify_stock_qty',
- 'manage_stock',
- 'enable_qty_increments',
- 'qty_increments',
- 'is_decimal_divided'
- );
- }
-
- /**
- * Display out of stock products option
- *
- * @return bool
- */
- public function isShowOutOfStock()
- {
- return $this->scopeConfig->isSetFlag(
- self::XML_PATH_SHOW_OUT_OF_STOCK,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- }
-
- /**
- * Check if credit memo items auto return option is enabled
- *
- * @return bool
- */
- public function isAutoReturnEnabled()
- {
- return $this->scopeConfig->isSetFlag(
- self::XML_PATH_ITEM_AUTO_RETURN,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- }
-
- /**
- * Get 'Display product stock status' option value
- * Shows if it is necessary to show product stock status ('in stock'/'out of stock')
- *
- * @return bool
- */
- public function isDisplayProductStockStatus()
- {
- return $this->scopeConfig->isSetFlag(
- self::XML_PATH_DISPLAY_PRODUCT_STOCK_STATUS,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- }
}
diff --git a/app/code/Magento/CatalogInventory/Helper/Minsaleqty.php b/app/code/Magento/CatalogInventory/Helper/Minsaleqty.php
index 2f7b6bee2e46e59603b9f1dd79f96947e9d7d8aa..064e63385c063230cd2e29812a85b97ced2603c0 100644
--- a/app/code/Magento/CatalogInventory/Helper/Minsaleqty.php
+++ b/app/code/Magento/CatalogInventory/Helper/Minsaleqty.php
@@ -184,7 +184,7 @@ class Minsaleqty
public function getConfigValue($customerGroupId, $store = null)
{
$value = $this->scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_MIN_SALE_QTY,
+ \Magento\CatalogInventory\Model\Configuration::XML_PATH_MIN_SALE_QTY,
\Magento\Store\Model\ScopeInterface::SCOPE_STORE,
$store
);
diff --git a/app/code/Magento/CatalogInventory/Helper/Stock.php b/app/code/Magento/CatalogInventory/Helper/Stock.php
new file mode 100644
index 0000000000000000000000000000000000000000..dee8416a45978c81e182a1077395f6bbcc64caa7
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Helper/Stock.php
@@ -0,0 +1,188 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Helper;
+
+use Magento\CatalogInventory\Api\StockRegistryInterface;
+use Magento\Framework\StoreManagerInterface;
+use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\Framework\ObjectManagerInterface;
+
+/**
+ * Class Stock
+ */
+class Stock
+{
+ /**
+ * @var StockRegistryInterface
+ */
+ protected $stockRegistry;
+
+ /**
+ * Store model manager
+ *
+ * @var StoreManagerInterface
+ */
+ protected $storeManager;
+
+ /**
+ * Core store config
+ *
+ * @var ScopeConfigInterface
+ */
+ protected $scopeConfig;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Resource\Stock\Status
+ */
+ protected $stockStatusResource;
+
+ /**
+ * @var \Magento\Framework\ObjectManagerInterface
+ */
+ protected $objectManger;
+
+ /**
+ * @param StockRegistryInterface $stockRegistry
+ * @param StoreManagerInterface $storeManager
+ * @param ScopeConfigInterface $scopeConfig
+ * @param ObjectManagerInterface $objectManager
+ */
+ public function __construct(
+ StockRegistryInterface $stockRegistry,
+ StoreManagerInterface $storeManager,
+ ScopeConfigInterface $scopeConfig,
+ ObjectManagerInterface $objectManager
+ ) {
+ $this->stockRegistry = $stockRegistry;
+ $this->storeManager = $storeManager;
+ $this->scopeConfig = $scopeConfig;
+ $this->objectManger = $objectManager;
+ }
+
+ /**
+ * Assign stock status information to product
+ *
+ * @param \Magento\Catalog\Model\Product $product
+ * @param int $stockStatus
+ * @return void
+ */
+ public function assignStatusToProduct(\Magento\Catalog\Model\Product $product, $stockStatus = null)
+ {
+ if (is_null($stockStatus)) {
+ $websiteId = $product->getStore()->getWebsiteId();
+ $stockStatus = $this->stockRegistry->getStockStatus($product->getId(), $websiteId);
+ $status = $stockStatus->getStockStatus();
+ }
+ $product->setIsSalable($status);
+ }
+
+ /**
+ * Add stock status information to products
+ *
+ * @param \Magento\Catalog\Model\Resource\Collection\AbstractCollection $productCollection
+ * @return void
+ */
+ public function addStockStatusToProducts(
+ \Magento\Catalog\Model\Resource\Collection\AbstractCollection $productCollection
+ ) {
+ $websiteId = $this->storeManager->getStore($productCollection->getStoreId())->getWebsiteId();
+ $productIds = [];
+ foreach ($productCollection as $product) {
+ $productId = $product->getId();
+ $stockStatus = $this->stockRegistry->getStockStatus($productId, $websiteId);
+ $status = $stockStatus->getStockStatus();
+ $product->setIsSalable($status);
+ }
+ }
+
+ /**
+ * Adds filtering for collection to return only in stock products
+ *
+ * @param \Magento\Catalog\Model\Resource\Product\Link\Product\Collection $collection
+ * @return void
+ */
+ public function addInStockFilterToCollection($collection)
+ {
+ $manageStock = $this->scopeConfig->getValue(
+ \Magento\CatalogInventory\Model\Configuration::XML_PATH_MANAGE_STOCK,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE
+ );
+ $cond = [
+ '{{table}}.use_config_manage_stock = 0 AND {{table}}.manage_stock=1 AND {{table}}.is_in_stock=1',
+ '{{table}}.use_config_manage_stock = 0 AND {{table}}.manage_stock=0'
+ ];
+
+ if ($manageStock) {
+ $cond[] = '{{table}}.use_config_manage_stock = 1 AND {{table}}.is_in_stock=1';
+ } else {
+ $cond[] = '{{table}}.use_config_manage_stock = 1';
+ }
+
+ $collection->joinField(
+ 'inventory_in_stock',
+ 'cataloginventory_stock_item',
+ 'is_in_stock',
+ 'product_id=entity_id',
+ '(' . join(') OR (', $cond) . ')'
+ );
+ }
+
+ /**
+ * Add stock status to prepare index select
+ *
+ * @param \Magento\Framework\DB\Select $select
+ * @param \Magento\Store\Model\Website $website
+ * @return void
+ */
+ public function addStockStatusToSelect(\Magento\Framework\DB\Select $select, \Magento\Store\Model\Website $website)
+ {
+ $resource = $this->getStockStatusResource();
+ $resource->addStockStatusToSelect($select, $website);
+ }
+
+ /**
+ * Add only is in stock products filter to product collection
+ *
+ * @param \Magento\Catalog\Model\Resource\Product\Collection $collection
+ * @return void
+ */
+ public function addIsInStockFilterToCollection($collection)
+ {
+ $resource = $this->getStockStatusResource();
+ $resource->addIsInStockFilterToCollection($collection);
+ }
+
+ /**
+ * @return \Magento\CatalogInventory\Model\Resource\Stock\Status
+ */
+ protected function getStockStatusResource()
+ {
+ if (empty($this->stockStatusResource)) {
+ $this->stockStatusResource = $this->objectManger->get(
+ 'Magento\CatalogInventory\Model\Resource\Stock\Status'
+ );
+ }
+ return $this->stockStatusResource;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Adminhtml/Stock/Item.php b/app/code/Magento/CatalogInventory/Model/Adminhtml/Stock/Item.php
index 7729036c6a4d8f5a374ce696c680fe69a8e15097..a32274d7bbc86bf83957afd3319bb8d48d17da83 100644
--- a/app/code/Magento/CatalogInventory/Model/Adminhtml/Stock/Item.php
+++ b/app/code/Magento/CatalogInventory/Model/Adminhtml/Stock/Item.php
@@ -35,7 +35,7 @@ class Item extends \Magento\CatalogInventory\Model\Stock\Item
*/
public function getCustomerGroupId()
{
- if ($this->_customerGroupId === null) {
+ if ($this->customerGroupId === null) {
return \Magento\Customer\Service\V1\CustomerGroupServiceInterface::CUST_GROUP_ALL;
}
return parent::getCustomerGroupId();
@@ -68,4 +68,12 @@ class Item extends \Magento\CatalogInventory\Model\Stock\Item
{
return true;
}
+
+ /**
+ * @return bool
+ */
+ public function getShowDefaultNotificationMessage()
+ {
+ return true;
+ }
}
diff --git a/app/code/Magento/CatalogInventory/Model/Config/Backend/AbstractValue.php b/app/code/Magento/CatalogInventory/Model/Config/Backend/AbstractValue.php
index 28294ca9eda5e9a9d45cc20b09dfcd80513663a0..24d9038331eddd421704300a82921f91d60ddddf 100644
--- a/app/code/Magento/CatalogInventory/Model/Config/Backend/AbstractValue.php
+++ b/app/code/Magento/CatalogInventory/Model/Config/Backend/AbstractValue.php
@@ -31,9 +31,9 @@ namespace Magento\CatalogInventory\Model\Config\Backend;
abstract class AbstractValue extends \Magento\Framework\App\Config\Value
{
/**
- * @var \Magento\CatalogInventory\Model\Stock\Status
+ * @var \Magento\CatalogInventory\Api\StockIndexInterface
*/
- protected $_stockStatus;
+ protected $stockIndex;
/**
* @var \Magento\CatalogInventory\Model\Indexer\Stock\Processor
@@ -44,7 +44,7 @@ abstract class AbstractValue extends \Magento\Framework\App\Config\Value
* @param \Magento\Framework\Model\Context $context
* @param \Magento\Framework\Registry $registry
* @param \Magento\Framework\App\Config\ScopeConfigInterface $config
- * @param \Magento\CatalogInventory\Model\Stock\Status $stockStatus
+ * @param \Magento\CatalogInventory\Api\StockIndexInterface $stockIndex
* @param \Magento\CatalogInventory\Model\Indexer\Stock\Processor $stockIndexerProcessor
* @param \Magento\Framework\Model\Resource\AbstractResource $resource
* @param \Magento\Framework\Data\Collection\Db $resourceCollection
@@ -54,14 +54,14 @@ abstract class AbstractValue extends \Magento\Framework\App\Config\Value
\Magento\Framework\Model\Context $context,
\Magento\Framework\Registry $registry,
\Magento\Framework\App\Config\ScopeConfigInterface $config,
- \Magento\CatalogInventory\Model\Stock\Status $stockStatus,
+ \Magento\CatalogInventory\Api\StockIndexInterface $stockIndex,
\Magento\CatalogInventory\Model\Indexer\Stock\Processor $stockIndexerProcessor,
\Magento\Framework\Model\Resource\AbstractResource $resource = null,
\Magento\Framework\Data\Collection\Db $resourceCollection = null,
array $data = array()
) {
$this->_stockIndexerProcessor = $stockIndexerProcessor;
- $this->_stockStatus = $stockStatus;
+ $this->stockIndex = $stockIndex;
parent::__construct($context, $registry, $config, $resource, $resourceCollection, $data);
}
}
diff --git a/app/code/Magento/CatalogInventory/Model/Config/Backend/Backorders.php b/app/code/Magento/CatalogInventory/Model/Config/Backend/Backorders.php
index a37250656eab99703b787dc8f9be9406e13a87c1..85d246c9808d2aa861531eb6a7df0f16094344ce 100644
--- a/app/code/Magento/CatalogInventory/Model/Config/Backend/Backorders.php
+++ b/app/code/Magento/CatalogInventory/Model/Config/Backend/Backorders.php
@@ -44,7 +44,7 @@ class Backorders extends AbstractValue
|| $this->getValue() == \Magento\CatalogInventory\Model\Stock::BACKORDERS_NO
)
) {
- $this->_stockStatus->rebuild();
+ $this->stockIndex->rebuild();
$this->_stockIndexerProcessor->markIndexerAsInvalid();
}
return $this;
diff --git a/app/code/Magento/CatalogInventory/Model/Config/Backend/Managestock.php b/app/code/Magento/CatalogInventory/Model/Config/Backend/Managestock.php
index fb7d384834fe03c862499401e576c71b28b12f8f..9fd244ab3c40b5597a447228cc81e95737d92195 100644
--- a/app/code/Magento/CatalogInventory/Model/Config/Backend/Managestock.php
+++ b/app/code/Magento/CatalogInventory/Model/Config/Backend/Managestock.php
@@ -39,7 +39,7 @@ class Managestock extends AbstractValue
protected function _afterSave()
{
if ($this->isValueChanged()) {
- $this->_stockStatus->rebuild();
+ $this->stockIndex->rebuild();
$this->_stockIndexerProcessor->markIndexerAsInvalid();
}
return $this;
diff --git a/app/code/Magento/CatalogInventory/Model/Configuration.php b/app/code/Magento/CatalogInventory/Model/Configuration.php
new file mode 100644
index 0000000000000000000000000000000000000000..6cf1853f70cf6e34981537c30b757f6b353a7560
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Configuration.php
@@ -0,0 +1,426 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model;
+
+use Magento\CatalogInventory\Api\StockConfigurationInterface;
+use Magento\CatalogInventory\Helper\Minsaleqty as MinsaleqtyHelper;
+use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\Catalog\Model\ProductTypes\ConfigInterface;
+use Magento\Framework\StoreManagerInterface;
+
+/**
+ * Class Configuration
+ * @package Magento\CatalogInventory\Model
+ * @api
+ * @spi
+ */
+class Configuration implements StockConfigurationInterface
+{
+ /**
+ * Default website id
+ */
+ const DEFAULT_WEBSITE_ID = 1;
+
+ /**
+ * Inventory options config path
+ */
+ const XML_PATH_GLOBAL = 'cataloginventory/options/';
+
+ /**
+ * Subtract config path
+ */
+ const XML_PATH_CAN_SUBTRACT = 'cataloginventory/options/can_subtract';
+
+ /**
+ * Back in stock config path
+ */
+ const XML_PATH_CAN_BACK_IN_STOCK = 'cataloginventory/options/can_back_in_stock';
+
+ /**
+ * Item options config path
+ */
+ const XML_PATH_ITEM = 'cataloginventory/item_options/';
+
+ /**
+ * Max qty config path
+ */
+ const XML_PATH_MIN_QTY = 'cataloginventory/item_options/min_qty';
+
+ /**
+ * Min sale qty config path
+ */
+ const XML_PATH_MIN_SALE_QTY = 'cataloginventory/item_options/min_sale_qty';
+
+ /**
+ * Max sale qty config path
+ */
+ const XML_PATH_MAX_SALE_QTY = 'cataloginventory/item_options/max_sale_qty';
+
+ /**
+ * Back orders config path
+ */
+ const XML_PATH_BACKORDERS = 'cataloginventory/item_options/backorders';
+
+ /**
+ * Notify stock config path
+ */
+ const XML_PATH_NOTIFY_STOCK_QTY = 'cataloginventory/item_options/notify_stock_qty';
+
+ /**
+ * Manage stock config path
+ */
+ const XML_PATH_MANAGE_STOCK = 'cataloginventory/item_options/manage_stock';
+
+ /**
+ * Enable qty increments config path
+ */
+ const XML_PATH_ENABLE_QTY_INCREMENTS = 'cataloginventory/item_options/enable_qty_increments';
+
+ /**
+ * Qty increments config path
+ */
+ const XML_PATH_QTY_INCREMENTS = 'cataloginventory/item_options/qty_increments';
+
+ /**
+ * Show out of stock config path
+ */
+ const XML_PATH_SHOW_OUT_OF_STOCK = 'cataloginventory/options/show_out_of_stock';
+
+ /**
+ * Auto return config path
+ */
+ const XML_PATH_ITEM_AUTO_RETURN = 'cataloginventory/item_options/auto_return';
+
+ /**
+ * Path to configuration option 'Display product stock status'
+ */
+ const XML_PATH_DISPLAY_PRODUCT_STOCK_STATUS = 'cataloginventory/options/display_product_stock_status';
+
+ /**
+ * @var ConfigInterface
+ */
+ protected $config;
+
+ /**
+ * Core store config
+ *
+ * @var ScopeConfigInterface
+ */
+ protected $scopeConfig;
+
+ /**
+ * @var MinsaleqtyHelper
+ */
+ protected $minsaleqtyHelper;
+
+ /**
+ * All product types registry in scope of quantity availability
+ *
+ * @var array
+ */
+ protected $isQtyTypeIds;
+
+ /**
+ * @var StoreManagerInterface
+ */
+ protected $storeManager;
+
+ /**
+ * @param ConfigInterface $config
+ * @param ScopeConfigInterface $scopeConfig
+ * @param MinsaleqtyHelper $minsaleqtyHelper
+ * @param StoreManagerInterface $storeManager
+ */
+ public function __construct(
+ ConfigInterface $config,
+ ScopeConfigInterface $scopeConfig,
+ MinsaleqtyHelper $minsaleqtyHelper,
+ StoreManagerInterface $storeManager
+ ) {
+ $this->config = $config;
+ $this->scopeConfig = $scopeConfig;
+ $this->minsaleqtyHelper = $minsaleqtyHelper;
+ $this->storeManager = $storeManager;
+ }
+
+ /**
+ * Retrieve Default Website ID
+ *
+ * @return int
+ */
+ public function getDefaultWebsiteId()
+ {
+ return (int) $this->storeManager->getWebsite(true)->getId();
+ }
+
+ /**
+ * @param int|null $filter
+ * @return array
+ */
+ public function getIsQtyTypeIds($filter = null)
+ {
+ if (null === $this->isQtyTypeIds) {
+ $this->isQtyTypeIds = [];
+ foreach ($this->config->getAll() as $typeId => $typeConfig) {
+ $this->isQtyTypeIds[$typeId] = isset($typeConfig['is_qty']) ? $typeConfig['is_qty'] : false;
+ }
+ }
+ $result = $this->isQtyTypeIds;
+ if ($filter !== null) {
+ foreach ($result as $key => $value) {
+ if ($value !== $filter) {
+ unset($result[$key]);
+ }
+ }
+ }
+ return $result;
+ }
+
+ /**
+ * @param int $productTypeId
+ * @return bool
+ */
+ public function isQty($productTypeId)
+ {
+ $result = $this->getIsQtyTypeIds();
+ return isset($result[$productTypeId]) ? $result[$productTypeId] : false;
+ }
+
+ /**
+ * Check if is possible subtract value from item qty
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function canSubtractQty($store = null)
+ {
+ return $this->scopeConfig->isSetFlag(
+ self::XML_PATH_CAN_SUBTRACT,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return float
+ */
+ public function getMinQty($store = null)
+ {
+ return (float)$this->scopeConfig->getValue(
+ self::XML_PATH_MIN_QTY,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @param int $customerGroupId
+ * @return float
+ */
+ public function getMinSaleQty($store = null, $customerGroupId = null)
+ {
+ return (float)$this->minsaleqtyHelper->getConfigValue($customerGroupId, $store);
+ }
+
+ /**
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return float|null
+ */
+ public function getMaxSaleQty($store = null)
+ {
+ return (float)$this->scopeConfig->getValue(
+ self::XML_PATH_MAX_SALE_QTY,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return float
+ */
+ public function getNotifyStockQty($store = null)
+ {
+ return (float) $this->scopeConfig->getValue(
+ self::XML_PATH_NOTIFY_STOCK_QTY,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * Retrieve whether Quantity Increments is enabled
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function getEnableQtyIncrements($store = null)
+ {
+ return (bool) $this->scopeConfig->getValue(
+ self::XML_PATH_ENABLE_QTY_INCREMENTS,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return int
+ */
+ public function getQtyIncrements($store = null)
+ {
+ return (float)$this->scopeConfig->getValue(
+ self::XML_PATH_QTY_INCREMENTS,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * Retrieve backorders status
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return int
+ */
+ public function getBackorders($store = null)
+ {
+ return (int) $this->scopeConfig->getValue(
+ self::XML_PATH_BACKORDERS,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * Retrieve Manage Stock data wrapper
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return int
+ */
+ public function getManageStock($store = null)
+ {
+ return (int) $this->scopeConfig->isSetFlag(
+ self::XML_PATH_MANAGE_STOCK,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * Retrieve can Back in stock
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function getCanBackInStock($store = null)
+ {
+ return $this->scopeConfig->isSetFlag(
+ self::XML_PATH_CAN_BACK_IN_STOCK,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * Display out of stock products option
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function isShowOutOfStock($store = null)
+ {
+ return $this->scopeConfig->isSetFlag(
+ self::XML_PATH_SHOW_OUT_OF_STOCK,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * Check if credit memo items auto return option is enabled
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function isAutoReturnEnabled($store = null)
+ {
+ return $this->scopeConfig->isSetFlag(
+ self::XML_PATH_ITEM_AUTO_RETURN,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * Get 'Display product stock status' option value
+ * Shows if it is necessary to show product stock status ('in stock'/'out of stock')
+ *
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return bool
+ */
+ public function isDisplayProductStockStatus($store = null)
+ {
+ return $this->scopeConfig->isSetFlag(
+ self::XML_PATH_DISPLAY_PRODUCT_STOCK_STATUS,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * @param string $field
+ * @param null|string|bool|int|\Magento\Store\Model\Store $store
+ * @return string|null
+ */
+ public function getDefaultConfigValue($field, $store = null)
+ {
+ return $this->scopeConfig->getValue(
+ self::XML_PATH_ITEM . $field,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * Retrieve inventory item options (used in config)
+ *
+ * @return string[]
+ */
+ public function getConfigItemOptions()
+ {
+ return [
+ 'min_qty',
+ 'backorders',
+ 'min_sale_qty',
+ 'max_sale_qty',
+ 'notify_stock_qty',
+ 'manage_stock',
+ 'enable_qty_increments',
+ 'qty_increments',
+ 'is_decimal_divided'
+ ];
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Observer.php b/app/code/Magento/CatalogInventory/Model/Observer.php
index 42f82adafc319fce6e8e08daa440b4871873f04b..574a5743c6000f480f4c434d9b83d1ae10eb51ab 100644
--- a/app/code/Magento/CatalogInventory/Model/Observer.php
+++ b/app/code/Magento/CatalogInventory/Model/Observer.php
@@ -27,6 +27,10 @@ namespace Magento\CatalogInventory\Model;
use Magento\CatalogInventory\Model\Stock\Item;
use Magento\Framework\Event\Observer as EventObserver;
use Magento\Sales\Model\Quote\Item as QuoteItem;
+use Magento\CatalogInventory\Api\StockRegistryInterface;
+use Magento\CatalogInventory\Api\StockManagementInterface;
+use Magento\CatalogInventory\Api\StockIndexInterface;
+use Magento\CatalogInventory\Api\StockConfigurationInterface;
/**
* Catalog inventory module observer
@@ -47,77 +51,54 @@ class Observer
protected $_stockItemsArray = array();
/**
- * Catalog inventory data
- *
- * @var \Magento\CatalogInventory\Helper\Data
- */
- protected $_catalogInventoryData;
-
- /**
- * Stock item factory
- *
- * @var \Magento\CatalogInventory\Model\Stock\ItemFactory
- */
- protected $_stockItemFactory;
-
- /**
- * Stock model factory
- *
- * @var StockFactory
- */
- protected $_stockFactory;
-
- /**
- * Stock status factory
- *
- * @var \Magento\CatalogInventory\Model\Stock\StatusFactory
+ * @var \Magento\CatalogInventory\Model\Resource\Stock
*/
- protected $_stockStatusFactory;
+ protected $_resourceStock;
/**
- * @var Stock
+ * @var \Magento\CatalogInventory\Model\Indexer\Stock\Processor
*/
- protected $_stock;
+ protected $_stockIndexerProcessor;
/**
- * @var \Magento\CatalogInventory\Model\Stock\Status
+ * @var \Magento\Catalog\Model\ProductTypes\ConfigInterface
*/
- protected $_stockStatus;
+ protected $typeConfig;
/**
- * @var \Magento\CatalogInventory\Model\Resource\Stock
+ * @var \Magento\Catalog\Model\Indexer\Product\Price\Processor
*/
- protected $_resourceStock;
+ protected $_priceIndexer;
/**
- * @var \Magento\CatalogInventory\Model\Indexer\Stock\Processor
+ * @var StockRegistryInterface
*/
- protected $_stockIndexerProcessor;
+ protected $stockRegistry;
/**
- * @var \Magento\Catalog\Model\ProductTypes\ConfigInterface
+ * @var StockManagementInterface
*/
- protected $typeConfig;
+ protected $stockManagement;
/**
- * @var \Magento\Catalog\Model\Indexer\Product\Price\Processor
+ * @var StockIndexInterface
*/
- protected $_priceIndexer;
+ protected $stockIndex;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Helper\Stock
*/
- protected $stockItemService;
+ protected $stockHelper;
/**
- * @var \Magento\CatalogInventory\Service\V1\Data\StockItemBuilder
+ * @var StockConfigurationInterface
*/
- protected $stockItemBuilder;
+ protected $stockConfiguration;
/**
- * @var \Magento\CatalogInventory\Model\Stock\ItemRegistry
+ * @var \Magento\CatalogInventory\Api\StockItemRepositoryInterface
*/
- protected $stockItemRegistry;
+ protected $stockItemRepository;
/**
* @var array
@@ -155,41 +136,36 @@ class Observer
/**
* @param \Magento\Catalog\Model\Indexer\Product\Price\Processor $priceIndexer
- * @param \Magento\CatalogInventory\Model\Indexer\Stock\Processor $stockIndexerProcessor
+ * @param Indexer\Stock\Processor $stockIndexerProcessor
* @param Resource\Stock $resourceStock
- * @param Stock $stock
- * @param Stock\Status $stockStatus
- * @param \Magento\CatalogInventory\Helper\Data $catalogInventoryData
- * @param Stock\ItemFactory $stockItemFactory
- * @param StockFactory $stockFactory
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
- * @param \Magento\CatalogInventory\Service\V1\Data\StockItemBuilder $stockItemBuilder
- * @param Stock\ItemRegistry $stockItemRegistry
+ * @param StockRegistryInterface $stockRegistry
+ * @param StockManagementInterface $stockManagement
+ * @param StockIndexInterface $stockIndex
+ * @param StockConfigurationInterface $stockConfiguration
+ * @param \Magento\CatalogInventory\Helper\Stock $stockHelper
+ * @param \Magento\CatalogInventory\Api\StockItemRepositoryInterface $stockItemRepository
*/
public function __construct(
\Magento\Catalog\Model\Indexer\Product\Price\Processor $priceIndexer,
\Magento\CatalogInventory\Model\Indexer\Stock\Processor $stockIndexerProcessor,
\Magento\CatalogInventory\Model\Resource\Stock $resourceStock,
- Stock $stock,
- \Magento\CatalogInventory\Model\Stock\Status $stockStatus,
- \Magento\CatalogInventory\Helper\Data $catalogInventoryData,
- \Magento\CatalogInventory\Model\Stock\ItemFactory $stockItemFactory,
- StockFactory $stockFactory,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
- \Magento\CatalogInventory\Service\V1\Data\StockItemBuilder $stockItemBuilder,
- \Magento\CatalogInventory\Model\Stock\ItemRegistry $stockItemRegistry
+ StockRegistryInterface $stockRegistry,
+ StockManagementInterface $stockManagement,
+ StockIndexInterface $stockIndex,
+ StockConfigurationInterface $stockConfiguration,
+ \Magento\CatalogInventory\Helper\Stock $stockHelper,
+ \Magento\CatalogInventory\Api\StockItemRepositoryInterface $stockItemRepository
) {
$this->_priceIndexer = $priceIndexer;
$this->_stockIndexerProcessor = $stockIndexerProcessor;
$this->_resourceStock = $resourceStock;
- $this->_stock = $stock;
- $this->_stockStatus = $stockStatus;
- $this->_catalogInventoryData = $catalogInventoryData;
- $this->_stockItemFactory = $stockItemFactory;
- $this->_stockFactory = $stockFactory;
- $this->stockItemService = $stockItemService;
- $this->stockItemBuilder = $stockItemBuilder;
- $this->stockItemRegistry = $stockItemRegistry;
+
+ $this->stockRegistry = $stockRegistry;
+ $this->stockManagement = $stockManagement;
+ $this->stockIndex = $stockIndex;
+ $this->stockHelper = $stockHelper;
+ $this->stockConfiguration = $stockConfiguration;
+ $this->stockItemRepository = $stockItemRepository;
}
/**
@@ -202,8 +178,10 @@ class Observer
{
$product = $observer->getEvent()->getProduct();
if ($product instanceof \Magento\Catalog\Model\Product) {
- $stockItem = $this->stockItemRegistry->retrieve($product->getId());
- $this->_stockStatus->assignProduct($product, $stockItem->getStockId(), $product->getStockStatus());
+ $this->stockHelper->assignStatusToProduct(
+ $product,
+ $product->getStockStatus()
+ );
}
return $this;
}
@@ -218,11 +196,7 @@ class Observer
public function addStockStatusToCollection($observer)
{
$productCollection = $observer->getEvent()->getCollection();
- if ($productCollection->hasFlag('require_stock_items')) {
- $this->_stockFactory->create()->addItemsToProducts($productCollection);
- } else {
- $this->_stockStatus->addStockStatusToProducts($productCollection);
- }
+ $this->stockHelper->addStockStatusToProducts($productCollection);
return $this;
}
@@ -235,8 +209,7 @@ class Observer
public function addInventoryDataToCollection($observer)
{
$productCollection = $observer->getEvent()->getProductCollection();
- $this->_stockFactory->create()->addItemsToProducts($productCollection);
- return $this;
+ $this->stockHelper->addStockStatusToProducts($productCollection);
}
/**
@@ -251,7 +224,10 @@ class Observer
if (is_null($product->getStockData())) {
if ($product->getIsChangedWebsites() || $product->dataHasChangedFor('status')) {
- $this->_stockStatus->updateStatus($product->getId());
+ $this->stockIndex->rebuild(
+ $product->getId(),
+ $product->getStore()->getWebsiteId()
+ );
}
return $this;
}
@@ -270,10 +246,11 @@ class Observer
{
$stockItemData = $product->getStockData();
$stockItemData['product_id'] = $product->getId();
- /**
- * @todo Should be refactored together with \Magento\CatalogInventory\Model\Stock\Item::getStockId
- */
- $stockItemData['stock_id'] = \Magento\CatalogInventory\Model\Stock\Item::DEFAULT_STOCK_ID;
+
+ if (!isset($stockItemData['website_id'])) {
+ $stockItemData['website_id'] = $this->stockConfiguration->getDefaultWebsiteId();
+ }
+ $stockItemData['stock_id'] = $this->stockRegistry->getStock($stockItemData['website_id'])->getId();
foreach ($this->paramListToCheck as $dataKey => $configPath) {
if (null !== $product->getData($configPath['item']) && null === $product->getData($configPath['config'])) {
@@ -287,12 +264,11 @@ class Observer
- $originalQty;
}
- $stockItemDo = $this->stockItemService->getStockItem($product->getId());
- $this->stockItemService->saveStockItem(
- $this->stockItemBuilder->mergeDataObjectWithArray($stockItemDo, $stockItemData)
- ->create()
- );
+ // todo resolve issue with builder and identity field name
+ $stockItem = $this->stockRegistry->getStockItem($stockItemData['product_id'], $stockItemData['website_id']);
+ $stockItem->addData($stockItemData);
+ $this->stockItemRepository->save($stockItem);
return $this;
}
@@ -312,6 +288,58 @@ class Observer
return $this;
}
+ /**
+ * Return creditmemo items qty to stock
+ *
+ * @param EventObserver $observer
+ * @return void
+ */
+ public function refundOrderInventory($observer)
+ {
+ /* @var $creditmemo \Magento\Sales\Model\Order\Creditmemo */
+ $creditmemo = $observer->getEvent()->getCreditmemo();
+ $itemsToUpdate = [];
+ foreach ($creditmemo->getAllItems() as $item) {
+ $qty = $item->getQty();
+ if (($item->getBackToStock() && $qty) || $this->stockConfiguration->isAutoReturnEnabled()) {
+ $productId = $item->getProductId();
+ $parentItemId = $item->getOrderItem()->getParentItemId();
+ /* @var $parentItem \Magento\Sales\Model\Order\Creditmemo\Item */
+ $parentItem = $parentItemId ? $creditmemo->getItemByOrderId($parentItemId) : false;
+ $qty = $parentItem ? $parentItem->getQty() * $qty : $qty;
+ if (isset($itemsToUpdate[$productId])) {
+ $itemsToUpdate[$productId] += $qty;
+ } else {
+ $itemsToUpdate[$productId] = $qty;
+ }
+ }
+ }
+ if (!empty($itemsToUpdate)) {
+ $this->stockManagement->revertProductsSale(
+ $itemsToUpdate,
+ $creditmemo->getStore()->getWebsiteId()
+ );
+
+ $updatedItemIds = array_keys($itemsToUpdate);
+ $this->_stockIndexerProcessor->reindexList($updatedItemIds);
+ $this->_priceIndexer->reindexList($updatedItemIds);
+ }
+ }
+
+ /**
+ * Update items stock status and low stock date.
+ *
+ * @param EventObserver $observer
+ * @return void
+ */
+ public function updateItemsStockUponConfigChange($observer)
+ {
+ $website = $observer->getEvent()->getWebsite();
+ $this->_resourceStock->updateSetOutOfStock($website);
+ $this->_resourceStock->updateSetInStock($website);
+ $this->_resourceStock->updateLowStockDate($website);
+ }
+
/**
* Subtract quote items qtys from stock items related with quote items products.
*
@@ -323,6 +351,7 @@ class Observer
*/
public function subtractQuoteInventory(EventObserver $observer)
{
+ /** @var \Magento\Sales\Model\Quote $quote */
$quote = $observer->getEvent()->getQuote();
// Maybe we've already processed this quote in some event during order placement
@@ -335,7 +364,10 @@ class Observer
/**
* Remember items
*/
- $this->_itemsForReindex = $this->_stock->registerProductsSale($items);
+ $this->_itemsForReindex = $this->stockManagement->registerProductsSale(
+ $items,
+ $quote->getStore()->getWebsiteId()
+ );
$quote->setInventoryProcessed(true);
return $this;
@@ -351,7 +383,7 @@ class Observer
{
$quote = $observer->getEvent()->getQuote();
$items = $this->_getProductsQty($quote->getAllItems());
- $this->_stock->revertProductsSale($items);
+ $this->stockManagement->revertProductsSale($items, $quote->getStore()->getWebsiteId());
$productIds = array_keys($items);
if (!empty($productIds)) {
$this->_stockIndexerProcessor->reindexList($productIds);
@@ -375,21 +407,24 @@ class Observer
* @param array &$items
* @return void
*/
- protected function _addItemToQtyArray($quoteItem, &$items)
+ protected function _addItemToQtyArray(QuoteItem $quoteItem, &$items)
{
$productId = $quoteItem->getProductId();
if (!$productId) {
return;
}
if (isset($items[$productId])) {
- $items[$productId]['qty'] += $quoteItem->getTotalQty();
+ $items[$productId] += $quoteItem->getTotalQty();
} else {
$stockItem = null;
if ($quoteItem->getProduct()) {
/** @var Item $stockItem */
- $stockItem = $this->stockItemRegistry->retrieve($quoteItem->getProduct()->getId());
+ $stockItem = $this->stockRegistry->getStockItem(
+ $quoteItem->getProduct()->getId(),
+ $quoteItem->getStore()->getWebsiteId()
+ );
}
- $items[$productId] = array('item' => $stockItem, 'qty' => $quoteItem->getTotalQty());
+ $items[$productId] = $quoteItem->getTotalQty();
}
}
@@ -407,7 +442,7 @@ class Observer
*/
protected function _getProductsQty($relatedItems)
{
- $items = array();
+ $items = [];
foreach ($relatedItems as $item) {
$productId = $item->getProductId();
if (!$productId) {
@@ -429,7 +464,7 @@ class Observer
* Refresh stock index for specific stock items after successful order placement
*
* @param EventObserver $observer
- * @return $this
+ * @return void
*/
public function reindexQuoteInventory($observer)
{
@@ -461,99 +496,33 @@ class Observer
$this->_priceIndexer->reindexList($productIds);
}
- $this->_itemsForReindex = array();
+ $this->_itemsForReindex = [];
// Clear list of remembered items - we don't need it anymore
-
- return $this;
- }
-
- /**
- * Return creditmemo items qty to stock
- *
- * @param EventObserver $observer
- * @return void
- */
- public function refundOrderInventory($observer)
- {
- /* @var $creditmemo \Magento\Sales\Model\Order\Creditmemo */
- $creditmemo = $observer->getEvent()->getCreditmemo();
- $itemsToUpdate = [];
- foreach ($creditmemo->getAllItems() as $item) {
- $qty = $item->getQty();
- if (($item->getBackToStock() && $qty) || $this->_catalogInventoryData->isAutoReturnEnabled()) {
- $productId = $item->getProductId();
- $parentItemId = $item->getOrderItem()->getParentItemId();
- /* @var $parentItem \Magento\Sales\Model\Order\Creditmemo\Item */
- $parentItem = $parentItemId ? $creditmemo->getItemByOrderId($parentItemId) : false;
- $qty = $parentItem ? $parentItem->getQty() * $qty : $qty;
- if (isset($itemsToUpdate[$productId]['qty'])) {
- $itemsToUpdate[$productId]['qty'] += $qty;
- } else {
- $itemsToUpdate[$productId] = ['qty' => $qty, 'item' => null];
- }
- }
- }
-
- if (!empty($itemsToUpdate)) {
- $this->_stock->revertProductsSale($itemsToUpdate);
-
- $updatedItemIds = array_keys($itemsToUpdate);
- $this->_stockIndexerProcessor->reindexList($updatedItemIds);
- $this->_priceIndexer->reindexList($updatedItemIds);
- }
}
/**
* Cancel order item
*
* @param EventObserver $observer
- * @return $this
+ * @return void
*/
public function cancelOrderItem($observer)
{
+ /** @var \Magento\Sales\Model\Order\Item $item */
$item = $observer->getEvent()->getItem();
-
$children = $item->getChildrenItems();
$qty = $item->getQtyOrdered() - max($item->getQtyShipped(), $item->getQtyInvoiced()) - $item->getQtyCanceled();
-
if ($item->getId() && $item->getProductId() && empty($children) && $qty) {
- $this->_stock->backItemQty($item->getProductId(), $qty);
+ $this->stockManagement->backItemQty($item->getProductId(), $qty, $item->getStore()->getWebsiteId());
}
$this->_priceIndexer->reindexRow($item->getProductId());
- return $this;
- }
-
- /**
- * Update items stock status and low stock date.
- *
- * @return $this
- */
- public function updateItemsStockUponConfigChange()
- {
- $this->_resourceStock->updateSetOutOfStock();
- $this->_resourceStock->updateSetInStock();
- $this->_resourceStock->updateLowStockDate();
- return $this;
- }
-
- /**
- * Update Only product status observer
- *
- * @param EventObserver $observer
- * @return $this
- */
- public function productStatusUpdate(EventObserver $observer)
- {
- $productId = $observer->getEvent()->getProductId();
- $this->_stockStatus->updateStatus($productId);
- return $this;
}
/**
* Catalog Product website update
*
* @param EventObserver $observer
- * @return $this
+ * @return void
*/
public function catalogProductWebsiteUpdate(EventObserver $observer)
{
@@ -562,39 +531,33 @@ class Observer
foreach ($websiteIds as $websiteId) {
foreach ($productIds as $productId) {
- $this->_stockStatus->updateStatus($productId, null, $websiteId);
+ $this->stockIndex->rebuild($productId, $websiteId);
}
}
-
- return $this;
}
/**
* Add stock status to prepare index select
*
* @param EventObserver $observer
- * @return $this
+ * @return void
*/
public function addStockStatusToPrepareIndexSelect(EventObserver $observer)
{
$website = $observer->getEvent()->getWebsite();
$select = $observer->getEvent()->getSelect();
-
- $this->_stockStatus->addStockStatusToSelect($select, $website);
-
- return $this;
+ $this->stockHelper->addStockStatusToSelect($select, $website);
}
/**
* Detects whether product status should be shown
*
* @param EventObserver $observer
- * @return $this
+ * @return void
*/
public function displayProductStatusInfo($observer)
{
$info = $observer->getEvent()->getStatus();
- $info->setDisplayStatus($this->_catalogInventoryData->isDisplayProductStockStatus());
- return $this;
+ $info->setDisplayStatus($this->stockConfiguration->isDisplayProductStockStatus());
}
}
diff --git a/app/code/Magento/CatalogInventory/Model/Plugin/Layer.php b/app/code/Magento/CatalogInventory/Model/Plugin/Layer.php
index 6c2bed641d46dcd8897a38dbaeb8c409c72bf815..43e8fd1bb2b1da67780a8d6a2c9388394be6551f 100644
--- a/app/code/Magento/CatalogInventory/Model/Plugin/Layer.php
+++ b/app/code/Magento/CatalogInventory/Model/Plugin/Layer.php
@@ -28,27 +28,27 @@ class Layer
/**
* Stock status instance
*
- * @var \Magento\CatalogInventory\Model\Stock\Status
+ * @var \Magento\CatalogInventory\Helper\Stock
*/
- protected $_stockStatus;
+ protected $stockHelper;
/**
* Store config instance
*
* @var \Magento\Framework\App\Config\ScopeConfigInterface
*/
- protected $_scopeConfig;
+ protected $scopeConfig;
/**
- * @param \Magento\CatalogInventory\Model\Stock\Status $stockStatus
+ * @param \Magento\CatalogInventory\Helper\Stock $stockHelper
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
*/
public function __construct(
- \Magento\CatalogInventory\Model\Stock\Status $stockStatus,
+ \Magento\CatalogInventory\Helper\Stock $stockHelper,
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
) {
- $this->_stockStatus = $stockStatus;
- $this->_scopeConfig = $scopeConfig;
+ $this->stockHelper = $stockHelper;
+ $this->scopeConfig = $scopeConfig;
}
/**
@@ -67,7 +67,7 @@ class Layer
if ($this->_isEnabledShowOutOfStock()) {
return;
}
- $this->_stockStatus->addIsInStockFilterToCollection($collection);
+ $this->stockHelper->addIsInStockFilterToCollection($collection);
}
/**
@@ -77,6 +77,9 @@ class Layer
*/
protected function _isEnabledShowOutOfStock()
{
- return $this->_scopeConfig->isSetFlag('cataloginventory/options/show_out_of_stock', \Magento\Store\Model\ScopeInterface::SCOPE_STORE);
+ return $this->scopeConfig->isSetFlag(
+ 'cataloginventory/options/show_out_of_stock',
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE
+ );
}
}
diff --git a/app/code/Magento/CatalogInventory/Model/Product/CopyConstructor/CatalogInventory.php b/app/code/Magento/CatalogInventory/Model/Product/CopyConstructor/CatalogInventory.php
index 2df401b74d666ac442b8105e67661771a7d6bf3b..24caa75b2511cdc1750223ee7e66b9d4aa81c7c2 100644
--- a/app/code/Magento/CatalogInventory/Model/Product/CopyConstructor/CatalogInventory.php
+++ b/app/code/Magento/CatalogInventory/Model/Product/CopyConstructor/CatalogInventory.php
@@ -26,17 +26,17 @@ namespace Magento\CatalogInventory\Model\Product\CopyConstructor;
class CatalogInventory implements \Magento\Catalog\Model\Product\CopyConstructorInterface
{
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
*/
public function __construct(
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
) {
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
}
/**
@@ -55,13 +55,15 @@ class CatalogInventory implements \Magento\Catalog\Model\Product\CopyConstructor
'use_config_backorders' => 1,
'use_config_notify_stock_qty' => 1
];
- /** @var \Magento\CatalogInventory\Service\V1\Data\StockItem $currentStockItemDo */
- $currentStockItemDo = $this->stockItemService->getStockItem($product->getId());
- if ($currentStockItemDo->getStockId()) {
+ $currentStockItemDo = $this->stockRegistry->getStockItem(
+ $product->getId(),
+ $product->getStore()->getWebsiteId()
+ );
+ if ($currentStockItemDo->getId()) {
$stockData += [
- 'use_config_enable_qty_inc' => $currentStockItemDo->isUseConfigEnableQtyInc(),
- 'enable_qty_increments' => $currentStockItemDo->isEnableQtyIncrements(),
- 'use_config_qty_increments' => $currentStockItemDo->isUseConfigQtyIncrements(),
+ 'use_config_enable_qty_inc' => $currentStockItemDo->getUseConfigEnableQtyInc(),
+ 'enable_qty_increments' => $currentStockItemDo->getEnableQtyIncrements(),
+ 'use_config_qty_increments' => $currentStockItemDo->getUseConfigQtyIncrements(),
'qty_increments' => $currentStockItemDo->getQtyIncrements(),
];
}
diff --git a/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator.php b/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator.php
index 5707643895888c2ab454e3552cf2a9ba5d615d96..dd997fc34bbee25bd607c7b4b6e3cab2bdc74a2a 100644
--- a/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator.php
+++ b/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator.php
@@ -25,6 +25,9 @@
*/
namespace Magento\CatalogInventory\Model\Quote\Item;
+use Magento\CatalogInventory\Api\StockRegistryInterface;
+use Magento\CatalogInventory\Api\StockStateInterface;
+
class QuantityValidator
{
/**
@@ -38,23 +41,31 @@ class QuantityValidator
protected $stockItemInitializer;
/**
- * @var \Magento\CatalogInventory\Model\Stock\ItemFactory
+ * @var StockRegistryInterface
+ */
+ protected $stockRegistry;
+
+ /**
+ * @var StockStateInterface
*/
- protected $stockItemFactory;
+ protected $stockState;
/**
* @param QuantityValidator\Initializer\Option $optionInitializer
* @param QuantityValidator\Initializer\StockItem $stockItemInitializer
- * @param \Magento\CatalogInventory\Model\Stock\ItemFactory $stockItemFactory
+ * @param StockRegistryInterface $stockRegistry
+ * @param StockStateInterface $stockState
*/
public function __construct(
QuantityValidator\Initializer\Option $optionInitializer,
QuantityValidator\Initializer\StockItem $stockItemInitializer,
- \Magento\CatalogInventory\Model\Stock\ItemFactory $stockItemFactory
+ StockRegistryInterface $stockRegistry,
+ StockStateInterface $stockState
) {
$this->optionInitializer = $optionInitializer;
$this->stockItemInitializer = $stockItemInitializer;
- $this->stockItemFactory = $stockItemFactory;
+ $this->stockRegistry = $stockRegistry;
+ $this->stockState = $stockState;
}
/**
@@ -81,7 +92,14 @@ class QuantityValidator
$qty = $quoteItem->getQty();
/** @var \Magento\CatalogInventory\Model\Stock\Item $stockItem */
- $stockItem = $this->stockItemFactory->create()->loadByProduct($quoteItem->getProduct());
+ $stockItem = $this->stockRegistry->getStockItem(
+ $quoteItem->getProduct()->getId(),
+ $quoteItem->getProduct()->getStore()->getWebsiteId()
+ );
+ /* @var $stockItem \Magento\CatalogInventory\Api\Data\StockItemInterface */
+ if (!$stockItem instanceof \Magento\CatalogInventory\Api\Data\StockItemInterface) {
+ throw new \Magento\Framework\Model\Exception(__('The stock item for Product is not valid.'));
+ }
$parentStockItem = false;
@@ -89,8 +107,11 @@ class QuantityValidator
* Check if product in stock. For composite products check base (parent) item stock status
*/
if ($quoteItem->getParentItem()) {
- $parentStockItem = $this->stockItemFactory->create()
- ->loadByProduct($quoteItem->getParentItem()->getProduct());
+ $product = $quoteItem->getParentItem()->getProduct();
+ $parentStockItem = $this->stockRegistry->getStockItem(
+ $product->getId(),
+ $product->getStore()->getWebsiteId()
+ );
}
if ($stockItem) {
@@ -119,9 +140,12 @@ class QuantityValidator
if (($options = $quoteItem->getQtyOptions()) && $qty > 0) {
$qty = $quoteItem->getProduct()->getTypeInstance()->prepareQuoteItemQty($qty, $quoteItem->getProduct());
$quoteItem->setData('qty', $qty);
-
if ($stockItem) {
- $result = $stockItem->checkQtyIncrements($qty);
+ $result = $this->stockState->checkQtyIncrements(
+ $quoteItem->getProduct()->getId(),
+ $qty,
+ $quoteItem->getProduct()->getStore()->getWebsiteId()
+ );
if ($result->getHasError()) {
$quoteItem->addErrorInfo(
'cataloginventory',
@@ -145,7 +169,6 @@ class QuantityValidator
}
foreach ($options as $option) {
-
$result = $this->optionInitializer->initialize($option, $quoteItem, $qty);
if ($result->getHasError()) {
$option->setHasError(true);
@@ -168,13 +191,7 @@ class QuantityValidator
}
}
} else {
- /* @var $stockItem \Magento\CatalogInventory\Model\Stock\Item */
- if (!$stockItem instanceof \Magento\CatalogInventory\Model\Stock\Item) {
- throw new \Magento\Framework\Model\Exception(__('The stock item for Product in option is not valid.'));
- }
-
$result = $this->stockItemInitializer->initialize($stockItem, $quoteItem, $qty);
-
if ($result->getHasError()) {
$quoteItem->addErrorInfo(
'cataloginventory',
@@ -193,6 +210,7 @@ class QuantityValidator
$this->_removeErrorsFromQuoteAndItem($quoteItem, \Magento\CatalogInventory\Helper\Data::ERROR_QTY);
}
}
+
}
/**
diff --git a/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/Option.php b/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/Option.php
index 35b9643b850ece58229b2a5b2efad5d5cfe96b4a..d7debfa486e9357cd851116ed36968f320d3c8aa 100644
--- a/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/Option.php
+++ b/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/Option.php
@@ -23,6 +23,8 @@
*/
namespace Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\Initializer;
+use Magento\CatalogInventory\Api\StockRegistryInterface;
+use Magento\CatalogInventory\Api\StockStateInterface;
use Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\QuoteItemQtyList;
class Option
@@ -33,20 +35,28 @@ class Option
protected $quoteItemQtyList;
/**
- * @var \Magento\CatalogInventory\Model\Stock\ItemRegistry
+ * @var StockRegistryInterface
*/
- protected $stockItemRegistry;
+ protected $stockRegistry;
+
+ /**
+ * @var StockStateInterface
+ */
+ protected $stockState;
/**
* @param QuoteItemQtyList $quoteItemQtyList
- * @param \Magento\CatalogInventory\Model\Stock\ItemRegistry $stockItemRegistry
+ * @param StockRegistryInterface $stockRegistry
+ * @param StockStateInterface $stockState
*/
public function __construct(
QuoteItemQtyList $quoteItemQtyList,
- \Magento\CatalogInventory\Model\Stock\ItemRegistry $stockItemRegistry
+ StockRegistryInterface $stockRegistry,
+ StockStateInterface $stockState
) {
$this->quoteItemQtyList = $quoteItemQtyList;
- $this->stockItemRegistry = $stockItemRegistry;
+ $this->stockRegistry = $stockRegistry;
+ $this->stockState = $stockState;
}
/**
@@ -57,13 +67,12 @@ class Option
*
* @return \Magento\CatalogInventory\Model\Stock\Item
* @throws \Magento\Framework\Model\Exception
- * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getStockItem(
\Magento\Sales\Model\Quote\Item\Option $option,
\Magento\Sales\Model\Quote\Item $quoteItem
) {
- $stockItem = $this->stockItemRegistry->retrieve($option->getProduct()->getId());
+ $stockItem = $this->stockRegistry->getStockItem($option->getProduct()->getId(), $quoteItem->getStore()->getWebsiteId());
if (!$stockItem->getId()) {
throw new \Magento\Framework\Model\Exception(__('The stock item for Product in option is not valid.'));
}
@@ -105,7 +114,13 @@ class Option
);
$stockItem = $this->getStockItem($option, $quoteItem);
- $result = $stockItem->checkQuoteItemQty($optionQty, $qtyForCheck, $optionValue);
+ $result = $this->stockState->checkQuoteItemQty(
+ $option->getProduct()->getId(),
+ $optionQty,
+ $qtyForCheck,
+ $optionValue,
+ $option->getProduct()->getStore()->getWebsiteId()
+ );
if (!is_null($result->getItemIsQtyDecimal())) {
$option->setIsQtyDecimal($result->getItemIsQtyDecimal());
diff --git a/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItem.php b/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItem.php
index 4a1b5a661c765f47a0615989ff146e2251984e6a..f3e3e2757f007f9794d1d331c3b13a48969c3fd1 100644
--- a/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItem.php
+++ b/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItem.php
@@ -23,37 +23,46 @@
*/
namespace Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\Initializer;
-/**
- * Class StockItem
- */
+use Magento\CatalogInventory\Api\StockStateInterface;
+use Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\QuoteItemQtyList;
+use Magento\Catalog\Model\ProductTypes\ConfigInterface;
+
class StockItem
{
/**
- * @var QtyProcessor
+ * @var QuoteItemQtyList
*/
- protected $qtyProcessor;
+ protected $quoteItemQtyList;
/**
- * @var \Magento\Catalog\Model\ProductTypes\ConfigInterface
+ * @var ConfigInterface
*/
protected $typeConfig;
/**
- * @param \Magento\Catalog\Model\ProductTypes\ConfigInterface $typeConfig
- * @param QtyProcessor $qtyProcessor
+ * @var StockStateInterface
+ */
+ protected $stockState;
+
+ /**
+ * @param ConfigInterface $typeConfig
+ * @param QuoteItemQtyList $quoteItemQtyList
+ * @param StockStateInterface $stockState
*/
public function __construct(
- \Magento\Catalog\Model\ProductTypes\ConfigInterface $typeConfig,
- QtyProcessor $qtyProcessor
+ ConfigInterface $typeConfig,
+ QuoteItemQtyList $quoteItemQtyList,
+ StockStateInterface $stockState
) {
- $this->qtyProcessor = $qtyProcessor;
+ $this->quoteItemQtyList = $quoteItemQtyList;
$this->typeConfig = $typeConfig;
+ $this->stockState = $stockState;
}
/**
* Initialize stock item
*
- * @param \Magento\CatalogInventory\Model\Stock\Item $stockItem
+ * @param \Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem
* @param \Magento\Sales\Model\Quote\Item $quoteItem
* @param int $qty
*
@@ -61,13 +70,30 @@ class StockItem
* @throws \Magento\Framework\Model\Exception
*/
public function initialize(
- \Magento\CatalogInventory\Model\Stock\Item $stockItem,
+ \Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem,
\Magento\Sales\Model\Quote\Item $quoteItem,
$qty
) {
- $this->qtyProcessor->setItem($quoteItem);
- $rowQty = $this->qtyProcessor->getRowQty($qty);
- $qtyForCheck = $this->qtyProcessor->getQtyForCheck($qty);
+ /**
+ * When we work with subitem
+ */
+ if ($quoteItem->getParentItem()) {
+ $rowQty = $quoteItem->getParentItem()->getQty() * $qty;
+ /**
+ * we are using 0 because original qty was processed
+ */
+ $qtyForCheck = $this->quoteItemQtyList
+ ->getQty($quoteItem->getProduct()->getId(), $quoteItem->getId(), $quoteItem->getQuoteId(), 0);
+ } else {
+ $increaseQty = $quoteItem->getQtyToAdd() ? $quoteItem->getQtyToAdd() : $qty;
+ $rowQty = $qty;
+ $qtyForCheck = $this->quoteItemQtyList->getQty(
+ $quoteItem->getProduct()->getId(),
+ $quoteItem->getId(),
+ $quoteItem->getQuoteId(),
+ $increaseQty
+ );
+ }
$productTypeCustomOption = $quoteItem->getProduct()->getCustomOption('product_type');
if (!is_null($productTypeCustomOption)) {
@@ -79,8 +105,13 @@ class StockItem
$stockItem->setProductName($quoteItem->getProduct()->getName());
- $stockItem->setProduct($quoteItem->getProduct());
- $result = $stockItem->checkQuoteItemQty($rowQty, $qtyForCheck, $qty);
+ $result = $this->stockState->checkQuoteItemQty(
+ $quoteItem->getProduct()->getId(),
+ $rowQty,
+ $qtyForCheck,
+ $qty,
+ $quoteItem->getProduct()->getStore()->getWebsiteId()
+ );
if ($stockItem->hasIsChildItem()) {
$stockItem->unsIsChildItem();
@@ -99,10 +130,10 @@ class StockItem
* exception for updating also managed by product type
*/
if ($result->getHasQtyOptionUpdate() && (!$quoteItem->getParentItem() ||
- $quoteItem->getParentItem()->getProduct()->getTypeInstance()->getForceChildItemQtyChanges(
- $quoteItem->getParentItem()->getProduct()
+ $quoteItem->getParentItem()->getProduct()->getTypeInstance()->getForceChildItemQtyChanges(
+ $quoteItem->getParentItem()->getProduct()
+ )
)
- )
) {
$quoteItem->setData('qty', $result->getOrigQty());
}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Indexer/Stock/DefaultStock.php b/app/code/Magento/CatalogInventory/Model/Resource/Indexer/Stock/DefaultStock.php
index 5f1a72f482574f96eb8ef3d508a2b5a31a5f7d1b..838885c14e9b833f9225c5d0a9d6ab993a48bc5b 100644
--- a/app/code/Magento/CatalogInventory/Model/Resource/Indexer/Stock/DefaultStock.php
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Indexer/Stock/DefaultStock.php
@@ -164,7 +164,7 @@ class DefaultStock extends \Magento\Catalog\Model\Resource\Product\Indexer\Abstr
protected function _isManageStock()
{
return $this->_scopeConfig->isSetFlag(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_MANAGE_STOCK,
+ \Magento\CatalogInventory\Model\Configuration::XML_PATH_MANAGE_STOCK,
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
);
}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Indexer/StockFactory.php b/app/code/Magento/CatalogInventory/Model/Resource/Indexer/StockFactory.php
index e19406900b96a7c884b2c2526f902861c7985f65..868ff0dadf8c65880db16b0067a0e5e62725174d 100644
--- a/app/code/Magento/CatalogInventory/Model/Resource/Indexer/StockFactory.php
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Indexer/StockFactory.php
@@ -30,7 +30,7 @@ namespace Magento\CatalogInventory\Model\Resource\Indexer;
class StockFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -42,9 +42,9 @@ class StockFactory
protected $_defaultIndexer = 'Magento\CatalogInventory\Model\Resource\Indexer\Stock\DefaultStock';
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock.php
index 780b01605e9c87d1450a7891624774290048a73a..e7b4ec418442bfb21036b87af84521aea52eb229 100644
--- a/app/code/Magento/CatalogInventory/Model/Resource/Stock.php
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock.php
@@ -24,11 +24,19 @@
namespace Magento\CatalogInventory\Model\Resource;
+use Magento\CatalogInventory\Api\StockConfigurationInterface;
+use Magento\Framework\StoreManagerInterface;
+
/**
* Stock resource model
*/
class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
{
+ /**
+ * @var StockConfigurationInterface
+ */
+ protected $stockConfiguration;
+
/**
* Is initialized configuration flag
*
@@ -71,18 +79,6 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
*/
protected $_configNotifyStockQty;
- /**
- * Ctalog Inventory Stock instance
- *
- * @var \Magento\CatalogInventory\Model\Stock
- */
- protected $_stock;
-
- /**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
- */
- protected $stockItemService;
-
/**
* Core store config
*
@@ -91,36 +87,34 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
protected $_scopeConfig;
/**
- * Stock model factory
- *
- * @var \Magento\CatalogInventory\Model\StockFactory
+ * @var \Magento\Framework\Stdlib\DateTime
*/
- protected $_stockFactory;
+ protected $dateTime;
/**
- * @var \Magento\Framework\Stdlib\DateTime
+ * @var StoreManagerInterface
*/
- protected $dateTime;
+ protected $storeManager;
/**
* @param \Magento\Framework\App\Resource $resource
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
- * @param \Magento\CatalogInventory\Model\StockFactory $stockFactory
* @param \Magento\Framework\Stdlib\DateTime $dateTime
+ * @param StockConfigurationInterface $stockConfiguration
+ * @param StoreManagerInterface $storeManager
*/
public function __construct(
\Magento\Framework\App\Resource $resource,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
- \Magento\CatalogInventory\Model\StockFactory $stockFactory,
- \Magento\Framework\Stdlib\DateTime $dateTime
+ \Magento\Framework\Stdlib\DateTime $dateTime,
+ StockConfigurationInterface $stockConfiguration,
+ StoreManagerInterface $storeManager
) {
parent::__construct($resource);
- $this->stockItemService = $stockItemService;
$this->_scopeConfig = $scopeConfig;
- $this->_stockFactory = $stockFactory;
$this->dateTime = $dateTime;
+ $this->stockConfiguration = $stockConfiguration;
+ $this->storeManager = $storeManager;
}
/**
@@ -134,35 +128,13 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
}
/**
- * Lock product items
- *
- * @param \Magento\CatalogInventory\Model\Stock $stock
- * @param int|int[] $productIds
- * @return $this
- */
- public function lockProductItems($stock, $productIds)
- {
- $itemTable = $this->getTable('cataloginventory_stock_item');
- $select = $this->_getWriteAdapter()->select()->from($itemTable)
- ->where('stock_id=?', $stock->getId())
- ->where('product_id IN(?)', $productIds)
- ->forUpdate(true);
- /**
- * We use write adapter for resolving problems with replication
- */
- $this->_getWriteAdapter()->query($select);
- return $this;
- }
-
- /**
- * Get stock items data for requested products
+ * Lock Stock Item records
*
- * @param \Magento\CatalogInventory\Model\Stock $stock
* @param int[] $productIds
- * @param bool $lockRows
+ * @param int $websiteId
* @return array
*/
- public function getProductsStock($stock, $productIds, $lockRows = false)
+ public function lockProductsStock($productIds, $websiteId)
{
if (empty($productIds)) {
return array();
@@ -171,36 +143,36 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
$productTable = $this->getTable('catalog_product_entity');
$select = $this->_getWriteAdapter()->select()->from(array('si' => $itemTable))
->join(array('p' => $productTable), 'p.entity_id=si.product_id', array('type_id'))
- ->where('stock_id=?', $stock->getId())
+ ->where('website_id=?', $websiteId)
->where('product_id IN(?)', $productIds)
- ->forUpdate($lockRows);
+ ->forUpdate(true);
return $this->_getWriteAdapter()->fetchAll($select);
}
/**
* Correct particular stock products qty based on operator
*
- * @param \Magento\CatalogInventory\Model\Stock $stock
- * @param array $productQtys
+ * @param array $items
+ * @param int $websiteId
* @param string $operator +/-
* @return $this
*/
- public function correctItemsQty($stock, $productQtys, $operator = '-')
+ public function correctItemsQty(array $items, $websiteId, $operator = '-')
{
- if (empty($productQtys)) {
+ if (empty($items)) {
return $this;
}
$adapter = $this->_getWriteAdapter();
$conditions = array();
- foreach ($productQtys as $productId => $qty) {
+ foreach ($items as $productId => $qty) {
$case = $adapter->quoteInto('?', $productId);
$result = $adapter->quoteInto("qty{$operator}?", $qty);
$conditions[$case] = $result;
}
$value = $adapter->getCaseSql('product_id', $conditions, 'qty');
- $where = array('product_id IN (?)' => array_keys($productQtys), 'stock_id = ?' => $stock->getId());
+ $where = array('product_id IN (?)' => array_keys($items), 'website_id = ?' => $websiteId);
$adapter->beginTransaction();
$adapter->update($this->getTable('cataloginventory_stock_item'), array('qty' => $value), $where);
@@ -209,39 +181,6 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
return $this;
}
- /**
- * Add join to select only in stock products
- *
- * @param \Magento\Catalog\Model\Resource\Product\Link\Product\Collection $collection
- * @return $this
- */
- public function setInStockFilterToCollection($collection)
- {
- $manageStock = $this->_scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_MANAGE_STOCK,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- $cond = array(
- '{{table}}.use_config_manage_stock = 0 AND {{table}}.manage_stock=1 AND {{table}}.is_in_stock=1',
- '{{table}}.use_config_manage_stock = 0 AND {{table}}.manage_stock=0'
- );
-
- if ($manageStock) {
- $cond[] = '{{table}}.use_config_manage_stock = 1 AND {{table}}.is_in_stock=1';
- } else {
- $cond[] = '{{table}}.use_config_manage_stock = 1';
- }
-
- $collection->joinField(
- 'inventory_in_stock',
- 'cataloginventory_stock_item',
- 'is_in_stock',
- 'product_id=entity_id',
- '(' . join(') OR (', $cond) . ')'
- );
- return $this;
- }
-
/**
* Load some inventory configuration settings
*
@@ -251,10 +190,10 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
{
if (!$this->_isConfig) {
$configMap = array(
- '_isConfigManageStock' => \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_MANAGE_STOCK,
- '_isConfigBackorders' => \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_BACKORDERS,
- '_configMinQty' => \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_MIN_QTY,
- '_configNotifyStockQty' => \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_NOTIFY_STOCK_QTY
+ '_isConfigManageStock' => \Magento\CatalogInventory\Model\Configuration::XML_PATH_MANAGE_STOCK,
+ '_isConfigBackorders' => \Magento\CatalogInventory\Model\Configuration::XML_PATH_BACKORDERS,
+ '_configMinQty' => \Magento\CatalogInventory\Model\Configuration::XML_PATH_MIN_QTY,
+ '_configNotifyStockQty' => \Magento\CatalogInventory\Model\Configuration::XML_PATH_NOTIFY_STOCK_QTY
);
foreach ($configMap as $field => $const) {
@@ -265,18 +204,19 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
}
$this->_isConfig = true;
- $this->_stock = $this->_stockFactory->create();
- $this->_configTypeIds = array_keys($this->stockItemService->getIsQtyTypeIds(true));
+ $this->_configTypeIds = array_keys($this->stockConfiguration->getIsQtyTypeIds(true));
}
}
/**
* Set items out of stock basing on their quantities and config settings
*
+ * @param string|int $website
* @return void
*/
- public function updateSetOutOfStock()
+ public function updateSetOutOfStock($website = null)
{
+ $websiteId = $this->storeManager->getWebsite($website)->getId();
$this->_initConfig();
$adapter = $this->_getWriteAdapter();
$values = array('is_in_stock' => 0, 'stock_status_changed_auto' => 1);
@@ -285,13 +225,13 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
->where('type_id IN(?)', $this->_configTypeIds);
$where = sprintf(
- 'stock_id = %1$d' .
+ 'website_id = %1$d' .
' AND is_in_stock = 1' .
' AND ((use_config_manage_stock = 1 AND 1 = %2$d) OR (use_config_manage_stock = 0 AND manage_stock = 1))' .
' AND ((use_config_backorders = 1 AND %3$d = %4$d) OR (use_config_backorders = 0 AND backorders = %3$d))' .
' AND ((use_config_min_qty = 1 AND qty <= %5$d) OR (use_config_min_qty = 0 AND qty <= min_qty))' .
' AND product_id IN (%6$s)',
- $this->_stock->getId(),
+ $websiteId,
$this->_isConfigManageStock,
\Magento\CatalogInventory\Model\Stock::BACKORDERS_NO,
$this->_isConfigBackorders,
@@ -305,10 +245,12 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
/**
* Set items in stock basing on their quantities and config settings
*
+ * @param int|string $website
* @return void
*/
- public function updateSetInStock()
+ public function updateSetInStock($website)
{
+ $websiteId = $this->storeManager->getWebsite($website)->getId();
$this->_initConfig();
$adapter = $this->_getWriteAdapter();
$values = array('is_in_stock' => 1);
@@ -317,13 +259,13 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
->where('type_id IN(?)', $this->_configTypeIds);
$where = sprintf(
- 'stock_id = %1$d' .
+ 'website_id = %1$d' .
' AND is_in_stock = 0' .
' AND stock_status_changed_auto = 1' .
' AND ((use_config_manage_stock = 1 AND 1 = %2$d) OR (use_config_manage_stock = 0 AND manage_stock = 1))' .
' AND ((use_config_min_qty = 1 AND qty > %3$d) OR (use_config_min_qty = 0 AND qty > min_qty))' .
' AND product_id IN (%4$s)',
- $this->_stock->getId(),
+ $websiteId,
$this->_isConfigManageStock,
$this->_configMinQty,
$select->assemble()
@@ -335,10 +277,12 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
/**
* Update items low stock date basing on their quantities and config settings
*
+ * @param int|string $website
* @return void
*/
- public function updateLowStockDate()
+ public function updateLowStockDate($website)
{
+ $websiteId = $this->storeManager->getWebsite($website)->getId();
$this->_initConfig();
$adapter = $this->_getWriteAdapter();
@@ -355,10 +299,10 @@ class Stock extends \Magento\Framework\Model\Resource\Db\AbstractDb
->where('type_id IN(?)', $this->_configTypeIds);
$where = sprintf(
- 'stock_id = %1$d' .
+ 'website_id = %1$d' .
' AND ((use_config_manage_stock = 1 AND 1 = %2$d) OR (use_config_manage_stock = 0 AND manage_stock = 1))' .
' AND product_id IN (%3$s)',
- $this->_stock->getId(),
+ $websiteId,
$this->_isConfigManageStock,
$select->assemble()
);
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Collection.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Collection.php
new file mode 100644
index 0000000000000000000000000000000000000000..a7eab270f2527a96db6a27190c42e13aa4498db8
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Collection.php
@@ -0,0 +1,43 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\CatalogInventory\Model\Resource\Stock;
+
+use Magento\CatalogInventory\Api\Data\StockCollectionInterface;
+use Magento\Framework\Data\AbstractSearchResult;
+
+/**
+ * Class Collection
+ * @package Magento\CatalogInventory\Model\Resource\Stock
+ */
+class Collection extends AbstractSearchResult implements StockCollectionInterface
+{
+ /**
+ * @inheritdoc
+ */
+ protected function init()
+ {
+ $this->setDataInterfaceName('Magento\CatalogInventory\Api\Data\StockInterface');
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item.php
index dbc92f34dc3e2fc7c72ba619dd9df46d0c1b6dc6..2a747450326e6f2b9e5d334148e00697e1f8ed1b 100644
--- a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item.php
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item.php
@@ -21,30 +21,39 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-
namespace Magento\CatalogInventory\Model\Resource\Stock;
+use Magento\CatalogInventory\Api\Data\StockItemInterface;
+use Magento\CatalogInventory\Model\Indexer\Stock\Processor;
+use Magento\Framework\Model\AbstractModel;
+use Magento\Framework\App\Resource as AppResource;
+
/**
* Stock item resource model
*/
class Item extends \Magento\Framework\Model\Resource\Db\AbstractDb
{
/**
- * Core store config
+ * Whether index events should be processed immediately
*
- * @var \Magento\Framework\App\Config\ScopeConfigInterface
+ * @var bool
+ */
+ protected $processIndexEvents = true;
+
+ /**
+ * @var Processor
*/
- protected $_scopeConfig;
+ protected $stockIndexerProcessor;
/**
- * @param \Magento\Framework\App\Resource $resource
- * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
+ * @param AppResource $resource
+ * @param Processor $processor
*/
public function __construct(
- \Magento\Framework\App\Resource $resource,
- \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
+ AppResource $resource,
+ Processor $processor
) {
- $this->_scopeConfig = $scopeConfig;
+ $this->stockIndexerProcessor = $processor;
parent::__construct($resource);
}
@@ -61,14 +70,15 @@ class Item extends \Magento\Framework\Model\Resource\Db\AbstractDb
/**
* Loading stock item data by product
*
- * @param \Magento\CatalogInventory\Model\Stock\Item $item
+ * @param \Magento\CatalogInventory\Api\Data\StockItemInterface $item
* @param int $productId
+ * @param int $websiteId
* @return $this
*/
- public function loadByProductId(\Magento\CatalogInventory\Model\Stock\Item $item, $productId)
+ public function loadByProductId(\Magento\CatalogInventory\Api\Data\StockItemInterface $item, $productId, $websiteId)
{
- $select = $this->_getLoadSelect('product_id', $productId, $item)->where('stock_id = :stock_id');
- $data = $this->_getReadAdapter()->fetchRow($select, array(':stock_id' => $item->getStockId()));
+ $select = $this->_getLoadSelect('product_id', $productId, $item)->where('website_id = :website_id');
+ $data = $this->_getReadAdapter()->fetchRow($select, array(':website_id' => $websiteId));
if ($data) {
$item->setData($data);
}
@@ -91,41 +101,6 @@ class Item extends \Magento\Framework\Model\Resource\Db\AbstractDb
return $select;
}
- /**
- * Add join for catalog in stock field to product collection
- *
- * @param \Magento\Catalog\Model\Resource\Product\Collection $productCollection
- * @param array $columns
- * @return $this
- */
- public function addCatalogInventoryToProductCollection($productCollection, $columns = null)
- {
- if ($columns === null) {
- $adapter = $this->_getReadAdapter();
- $isManageStock = (int) $this->_scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_MANAGE_STOCK,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- $stockExpr = $adapter->getCheckSql(
- 'cisi.use_config_manage_stock = 1',
- $isManageStock,
- 'cisi.manage_stock'
- );
- $stockExpr = $adapter->getCheckSql("({$stockExpr} = 1)", 'cisi.is_in_stock', '1');
-
- $columns = array('is_saleable' => new \Zend_Db_Expr($stockExpr), 'inventory_in_stock' => 'is_in_stock');
- }
-
- $productCollection->joinTable(
- array('cisi' => 'cataloginventory_stock_item'),
- 'product_id=entity_id',
- $columns,
- null,
- 'left'
- );
- return $this;
- }
-
/**
* Use qty correction for qty column update
*
@@ -148,4 +123,32 @@ class Item extends \Magento\Framework\Model\Resource\Db\AbstractDb
}
return $data;
}
+
+ /**
+ * Reindex CatalogInventory save event
+ *
+ * @param AbstractModel $object
+ * @return $this
+ */
+ protected function _afterSave(AbstractModel $object)
+ {
+ parent::_afterSave($object);
+ /** @var StockItemInterface $object */
+ if ($this->processIndexEvents) {
+ $this->stockIndexerProcessor->reindexRow($object->getProductId());
+ }
+ return $this;
+ }
+
+ /**
+ * Set whether index events should be processed immediately
+ *
+ * @param bool $process
+ * @return $this
+ */
+ public function setProcessIndexEvents($process = true)
+ {
+ $this->processIndexEvents = $process;
+ return $this;
+ }
}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/Collection.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/Collection.php
index 78aabdd765e513df0fc41e8bd6a9115ebc66fbf6..3eb8baabcc006fed85cf0f7acbd51a11ae76fb60 100644
--- a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/Collection.php
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/Collection.php
@@ -22,164 +22,22 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-/**
- * Stock item collection resource model
- */
namespace Magento\CatalogInventory\Model\Resource\Stock\Item;
-use Magento\CatalogInventory\Model\Stock;
+use Magento\CatalogInventory\Api\Data\StockItemCollectionInterface;
+use Magento\Framework\Data\AbstractSearchResult;
-class Collection extends \Magento\Framework\Model\Resource\Db\Collection\AbstractCollection
+/**
+ * Class Collection
+ * @package Magento\CatalogInventory\Model\Resource\Stock\Item
+ */
+class Collection extends AbstractSearchResult implements StockItemCollectionInterface
{
/**
- * @var \Magento\Framework\StoreManagerInterface
- */
- protected $_storeManager;
-
- /**
- * @param \Magento\Core\Model\EntityFactory $entityFactory
- * @param \Magento\Framework\Logger $logger
- * @param \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy
- * @param \Magento\Framework\Event\ManagerInterface $eventManager
- * @param \Magento\Framework\StoreManagerInterface $storeManager
- * @param \Zend_Db_Adapter_Abstract $connection
- * @param \Magento\Framework\Model\Resource\Db\AbstractDb $resource
- */
- public function __construct(
- \Magento\Core\Model\EntityFactory $entityFactory,
- \Magento\Framework\Logger $logger,
- \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy,
- \Magento\Framework\Event\ManagerInterface $eventManager,
- \Magento\Framework\StoreManagerInterface $storeManager,
- $connection = null,
- \Magento\Framework\Model\Resource\Db\AbstractDb $resource = null
- ) {
- $this->_storeManager = $storeManager;
- parent::__construct($entityFactory, $logger, $fetchStrategy, $eventManager, $connection, $resource);
- }
-
- /**
- * Initialize resource model
- *
- * @return void
- */
- protected function _construct()
- {
- $this->_init(
- 'Magento\CatalogInventory\Model\Stock\Item',
- 'Magento\CatalogInventory\Model\Resource\Stock\Item'
- );
- }
-
- /**
- * Add stock filter to collection
- *
- * @param Stock|string|array $stock
- * @return $this
- */
- public function addStockFilter($stock)
- {
- if ($stock instanceof Stock) {
- $this->addFieldToFilter('main_table.stock_id', $stock->getId());
- } else {
- $this->addFieldToFilter('main_table.stock_id', $stock);
- }
- return $this;
- }
-
- /**
- * Add product filter to collection
- *
- * @param array $products
- * @return $this
- */
- public function addProductsFilter($products)
- {
- $productIds = array();
- foreach ($products as $product) {
- if ($product instanceof \Magento\Catalog\Model\Product) {
- $productIds[] = $product->getId();
- } else {
- $productIds[] = $product;
- }
- }
- if (empty($productIds)) {
- $productIds[] = false;
- $this->_setIsLoaded(true);
- }
- $this->addFieldToFilter('main_table.product_id', array('in' => $productIds));
- return $this;
- }
-
- /**
- * Join Stock Status to collection
- *
- * @param int $storeId
- * @return $this
- */
- public function joinStockStatus($storeId = null)
- {
- $websiteId = $this->_storeManager->getStore($storeId)->getWebsiteId();
- $this->getSelect()->joinLeft(
- array('status_table' => $this->getTable('cataloginventory_stock_status')),
- 'main_table.product_id=status_table.product_id' .
- ' AND main_table.stock_id=status_table.stock_id' .
- $this->getConnection()->quoteInto(
- ' AND status_table.website_id=?',
- $websiteId
- ),
- array('stock_status')
- );
-
- return $this;
- }
-
- /**
- * Add Managed Stock products filter to collection
- *
- * @param bool $isStockManagedInConfig
- * @return $this
- */
- public function addManagedFilter($isStockManagedInConfig)
- {
- if ($isStockManagedInConfig) {
- $this->getSelect()->where('(manage_stock = 1 OR use_config_manage_stock = 1)');
- } else {
- $this->addFieldToFilter('manage_stock', 1);
- }
-
- return $this;
- }
-
- /**
- * Add filter by quantity to collection
- *
- * @param string $comparisonMethod
- * @param float $qty
- * @return $this
- * @throws \Magento\Framework\Model\Exception
- */
- public function addQtyFilter($comparisonMethod, $qty)
- {
- $methods = array('<' => 'lt', '>' => 'gt', '=' => 'eq', '<=' => 'lteq', '>=' => 'gteq', '<>' => 'neq');
- if (!isset($methods[$comparisonMethod])) {
- throw new \Magento\Framework\Model\Exception(__('%1 is not a correct comparison method.', $comparisonMethod));
- }
-
- return $this->addFieldToFilter('main_table.qty', array($methods[$comparisonMethod] => $qty));
- }
-
- /**
- * Initialize select object
- *
- * @return $this
+ * @inheritdoc
*/
- protected function _initSelect()
+ protected function init()
{
- return parent::_initSelect()->getSelect()->join(
- array('cp_table' => $this->getTable('catalog_product_entity')),
- 'main_table.product_id = cp_table.entity_id',
- array('type_id')
- );
+ $this->setDataInterfaceName('Magento\CatalogInventory\Api\Data\StockItemInterface');
}
}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/StockItemCriteria.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/StockItemCriteria.php
new file mode 100644
index 0000000000000000000000000000000000000000..dd42e90449d1be965991871b78f77f9162861234
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/StockItemCriteria.php
@@ -0,0 +1,100 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Resource\Stock\Item;
+
+use Magento\Framework\Data\AbstractCriteria;
+
+/**
+ * Class StockItemCriteria
+ */
+class StockItemCriteria extends AbstractCriteria implements \Magento\CatalogInventory\Api\StockItemCriteriaInterface
+{
+ /**
+ * @param string $mapper
+ */
+ public function __construct($mapper = '')
+ {
+ $this->mapperInterfaceName = $mapper ?: 'Magento\CatalogInventory\Model\Resource\Stock\Item\StockItemCriteriaMapper';
+ $this->data['initial_condition'] = true;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setStockStatus($storeId = null)
+ {
+ $this->data['stock_status'] = func_get_args();
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setStockFilter($stock)
+ {
+ $this->data['stock_filter'] = $stock;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setWebsiteFilter($website)
+ {
+ $this->data['website_filter'] = $website;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setProductsFilter($products)
+ {
+ $this->data['products_filter'] = $products;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setManagedFilter($isStockManagedInConfig)
+ {
+ $this->data['managed_filter'] = $isStockManagedInConfig;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setQtyFilter($comparisonMethod, $qty)
+ {
+ $this->data['qty_filter'] = [$comparisonMethod, $qty];
+ }
+
+ /**
+ * Add Criteria object
+ *
+ * @param \Magento\CatalogInventory\Api\StockItemCriteriaInterface $criteria
+ * @return void
+ */
+ public function addCriteria(\Magento\CatalogInventory\Api\StockItemCriteriaInterface $criteria)
+ {
+ $this->data[self::PART_CRITERIA_LIST]['list'][] = $criteria;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/StockItemCriteriaMapper.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/StockItemCriteriaMapper.php
new file mode 100644
index 0000000000000000000000000000000000000000..1c3a16d5cb398b37b6940783b74c261446eaa4c7
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/StockItemCriteriaMapper.php
@@ -0,0 +1,170 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\CatalogInventory\Model\Resource\Stock\Item;
+
+use Magento\Framework\DB\GenericMapper;
+use Magento\Framework\DB\MapperFactory;
+use Magento\Framework\DB\Select;
+use Magento\Framework\Data\ObjectFactory;
+use Magento\Framework\StoreManagerInterface;
+use Magento\Framework\Logger;
+use Magento\Framework\Data\Collection\Db\FetchStrategyInterface;
+
+/**
+ * Interface StockItemCriteriaMapper
+ * @package Magento\CatalogInventory\Model\Resource\Stock\Status
+ */
+class StockItemCriteriaMapper extends GenericMapper
+{
+ /**
+ * @param Logger $logger
+ * @param FetchStrategyInterface $fetchStrategy
+ * @param ObjectFactory $objectFactory
+ * @param StoreManagerInterface $storeManager
+ * @param MapperFactory $mapperFactory
+ * @param Select $select
+ */
+ public function __construct(
+ Logger $logger,
+ FetchStrategyInterface $fetchStrategy,
+ ObjectFactory $objectFactory,
+ MapperFactory $mapperFactory,
+ StoreManagerInterface $storeManager,
+ Select $select = null
+ ) {
+ $this->storeManager = $storeManager;
+ parent::__construct($logger, $fetchStrategy, $objectFactory, $mapperFactory, $select);
+ }
+
+ /**
+ * @inheritdoc
+ */
+ protected function init()
+ {
+ $this->initResource('Magento\CatalogInventory\Model\Resource\Stock\Item');
+ $this->map['qty'] = ['main_table', 'qty', 'qty'];
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function mapInitialCondition()
+ {
+ $this->getSelect()->join(
+ ['cp_table' => $this->getTable('catalog_product_entity')],
+ 'main_table.product_id = cp_table.entity_id',
+ ['type_id']
+ );
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function mapStockFilter($stock)
+ {
+ if ($stock instanceof \Magento\CatalogInventory\Api\Data\StockInterface) {
+ $stock = $stock->getId();
+ }
+ $this->addFieldToFilter('main_table.stock_id', $stock);
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function mapWebsiteFilter($website)
+ {
+ if ($website instanceof \Magento\Store\Model\Website) {
+ $website = $website->getId();
+ }
+ $this->addFieldToFilter('main_table.website_id', $website);
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function mapProductsFilter($products)
+ {
+ $productIds = [];
+ if (!is_array($products)) {
+ $products = [$products];
+ }
+ foreach ($products as $product) {
+ if ($product instanceof \Magento\Catalog\Model\Product) {
+ $productIds[] = $product->getId();
+ } else {
+ $productIds[] = $product;
+ }
+ }
+ if (empty($productIds)) {
+ $productIds[] = false;
+ }
+ $this->addFieldToFilter('main_table.product_id', ['in' => $productIds]);
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function mapStockStatus($storeId = null)
+ {
+ $websiteId = $this->storeManager->getStore($storeId)->getWebsiteId();
+ $this->getSelect()->joinLeft(
+ ['status_table' => $this->getTable('cataloginventory_stock_status')],
+ 'main_table.product_id=status_table.product_id' .
+ ' AND main_table.stock_id=status_table.stock_id' .
+ $this->getConnection()->quoteInto(
+ ' AND status_table.website_id=?',
+ $websiteId
+ ),
+ ['stock_status']
+ );
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function mapManagedFilter($isStockManagedInConfig)
+ {
+ if ($isStockManagedInConfig) {
+ $this->getSelect()->where('(manage_stock = 1 OR use_config_manage_stock = 1)');
+ } else {
+ $this->addFieldToFilter('manage_stock', 1);
+ }
+ }
+
+ /**
+ * @inheritdoc
+ * @throws \Magento\Framework\Model\Exception
+ */
+ public function mapQtyFilter($comparisonMethod, $qty)
+ {
+ $methods = ['<' => 'lt', '>' => 'gt', '=' => 'eq', '<=' => 'lteq', '>=' => 'gteq', '<>' => 'neq'];
+ if (!isset($methods[$comparisonMethod])) {
+ throw new \Magento\Framework\Model\Exception(
+ __('%1 is not a correct comparison method.', $comparisonMethod)
+ );
+ }
+ $this->addFieldToFilter('main_table.qty', [$methods[$comparisonMethod] => $qty]);
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status.php
index dad09e3d5e96fe67994d7b749d31c0e17528eb7e..4ada467d00642c4c7410765446bd0144077d606a 100644
--- a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status.php
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status.php
@@ -81,49 +81,39 @@ class Status extends \Magento\Framework\Model\Resource\Db\AbstractDb
/**
* Save Product Status per website
*
- * @param Stock\Status $object
* @param int $productId
* @param int $status
* @param float|int $qty
- * @param int $stockId
* @param int|null $websiteId
* @return $this
*/
public function saveProductStatus(
- Stock\Status $object,
$productId,
$status,
- $qty = 0,
- $stockId = 1,
- $websiteId = null
+ $qty,
+ $websiteId
) {
- $websites = array_keys($object->getWebsites($websiteId));
$adapter = $this->_getWriteAdapter();
- foreach ($websites as $websiteId) {
- $select = $adapter->select()->from($this->getMainTable())
- ->where('product_id = :product_id')
- ->where('website_id = :website_id')
- ->where('stock_id = :stock_id');
- $bind = array(':product_id' => $productId, ':website_id' => $websiteId, ':stock_id' => $stockId);
- $row = $adapter->fetchRow($select, $bind);
- if ($row) {
- $bind = array('qty' => $qty, 'stock_status' => $status);
- $where = array(
- $adapter->quoteInto('product_id=?', (int)$row['product_id']),
- $adapter->quoteInto('website_id=?', (int)$row['website_id']),
- $adapter->quoteInto('stock_id=?', (int)$row['stock_id'])
- );
- $adapter->update($this->getMainTable(), $bind, $where);
- } else {
- $bind = array(
- 'product_id' => $productId,
- 'website_id' => $websiteId,
- 'stock_id' => $stockId,
- 'qty' => $qty,
- 'stock_status' => $status
- );
- $adapter->insert($this->getMainTable(), $bind);
- }
+ $select = $adapter->select()->from($this->getMainTable())
+ ->where('product_id = :product_id')
+ ->where('website_id = :website_id');
+ $bind = array(':product_id' => $productId, ':website_id' => $websiteId);
+ $row = $adapter->fetchRow($select, $bind);
+ if ($row) {
+ $bind = array('qty' => $qty, 'stock_status' => $status);
+ $where = array(
+ $adapter->quoteInto('product_id=?', (int)$row['product_id']),
+ $adapter->quoteInto('website_id=?', (int)$row['website_id'])
+ );
+ $adapter->update($this->getMainTable(), $bind, $where);
+ } else {
+ $bind = array(
+ 'product_id' => $productId,
+ 'website_id' => $websiteId,
+ 'qty' => $qty,
+ 'stock_status' => $status
+ );
+ $adapter->insert($this->getMainTable(), $bind);
}
return $this;
@@ -135,10 +125,9 @@ class Status extends \Magento\Framework\Model\Resource\Db\AbstractDb
*
* @param int[] $productIds
* @param int $websiteId
- * @param int $stockId
* @return array
*/
- public function getProductStockStatus($productIds, $websiteId, $stockId = Stock::DEFAULT_STOCK_ID)
+ public function getProductsStockStatuses($productIds, $websiteId)
{
if (!is_array($productIds)) {
$productIds = array($productIds);
@@ -147,7 +136,6 @@ class Status extends \Magento\Framework\Model\Resource\Db\AbstractDb
$select = $this->_getReadAdapter()->select()
->from($this->getMainTable(), array('product_id', 'stock_status'))
->where('product_id IN(?)', $productIds)
- ->where('stock_id=?', (int) $stockId)
->where('website_id=?', (int) $websiteId);
return $this->_getReadAdapter()->fetchPairs($select);
}
@@ -241,8 +229,8 @@ class Status extends \Magento\Framework\Model\Resource\Db\AbstractDb
);
$joinCondition .= $this->_getReadAdapter()->quoteInto(
- ' AND stock_status_index.stock_id = ?',
- Stock::DEFAULT_STOCK_ID
+ ' AND stock_status_index.website_id = ?',
+ $websiteId
);
$collection->getSelect()->join(
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/Collection.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/Collection.php
index e893c58d0d2da9c2d7646378530747546442dd45..da880fcc7f0d2ccd87dc04c6b3617f95fb04b5ba 100644
--- a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/Collection.php
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/Collection.php
@@ -24,58 +24,20 @@
namespace Magento\CatalogInventory\Model\Resource\Stock\Status;
+use Magento\CatalogInventory\Api\Data\StockStatusCollectionInterface;
+use Magento\Framework\Data\AbstractSearchResult;
+
/**
- * Stock status collection resource model
+ * Class Collection
+ * @package Magento\CatalogInventory\Model\Resource\Stock\Status
*/
-class Collection extends \Magento\Framework\Model\Resource\Db\Collection\AbstractCollection
+class Collection extends AbstractSearchResult implements StockStatusCollectionInterface
{
/**
- * Initialize resource model
- *
- * @return void
- */
- protected function _construct()
- {
- $this->_init(
- 'Magento\CatalogInventory\Model\Stock\Status',
- 'Magento\CatalogInventory\Model\Resource\Stock\Status'
- );
- }
-
- /**
- * Filter status by website
- *
- * @param \Magento\Store\Model\Website $website
- * @return $this
- */
- public function addWebsiteFilter(\Magento\Store\Model\Website $website)
- {
- $this->addFieldToFilter('website_id', $website->getWebsiteId());
- return $this;
- }
-
- /**
- * Add filter by quantity to collection
- *
- * @param float $qty
- * @return $this
- */
- public function addQtyFilter($qty)
- {
- return $this->addFieldToFilter('main_table.qty', ['lteq' => $qty]);
- }
-
- /**
- * Initialize select object
- *
- * @return $this
+ * @inheritdoc
*/
- protected function _initSelect()
+ protected function init()
{
- return parent::_initSelect()->getSelect()->join(
- array('cp_table' => $this->getTable('catalog_product_entity')),
- 'main_table.product_id = cp_table.entity_id',
- array('sku', 'type_id')
- );
+ $this->setDataInterfaceName('Magento\CatalogInventory\Api\Data\StockStatusInterface');
}
}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/StockStatusCriteria.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/StockStatusCriteria.php
new file mode 100644
index 0000000000000000000000000000000000000000..baa16c02fa384a270fc979375f614e73a992a520
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/StockStatusCriteria.php
@@ -0,0 +1,76 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Resource\Stock\Status;
+
+use Magento\Framework\Data\AbstractCriteria;
+
+/**
+ * Class StockStatusCriteria
+ */
+class StockStatusCriteria extends AbstractCriteria implements \Magento\CatalogInventory\Api\StockStatusCriteriaInterface
+{
+ /**
+ * @param string $mapper
+ */
+ public function __construct($mapper = '')
+ {
+ $this->mapperInterfaceName = $mapper ?: 'Magento\CatalogInventory\Model\Resource\Stock\Status\StockStatusCriteriaMapper';
+ $this->data['initial_condition'] = true;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setWebsiteFilter($website)
+ {
+ $this->data['website_filter'] = $website;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setProductsFilter($products)
+ {
+ $this->data['products_filter'] = $products;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setQtyFilter($qty)
+ {
+ $this->data['qty_filter'] = $qty;
+ }
+
+ /**
+ * Add Criteria object
+ *
+ * @param \Magento\CatalogInventory\Api\StockStatusCriteriaInterface $criteria
+ * @return void
+ */
+ public function addCriteria(\Magento\CatalogInventory\Api\StockStatusCriteriaInterface $criteria)
+ {
+ $this->data[self::PART_CRITERIA_LIST]['list'][] = $criteria;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/StockStatusCriteriaMapper.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/StockStatusCriteriaMapper.php
new file mode 100644
index 0000000000000000000000000000000000000000..647b95321ee29c5642e52ab61fd15abff488961a
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/StockStatusCriteriaMapper.php
@@ -0,0 +1,106 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\CatalogInventory\Model\Resource\Stock\Status;
+
+use Magento\Framework\DB\GenericMapper;
+
+/**
+ * Class StockStatusCriteriaMapper
+ * @package Magento\CatalogInventory\Model\Resource\Stock\Status
+ */
+class StockStatusCriteriaMapper extends GenericMapper
+{
+ /**
+ * @inheritdoc
+ */
+ protected function init()
+ {
+ $this->initResource('Magento\CatalogInventory\Model\Resource\Stock\Status');
+ }
+
+ /**
+ * Apply initial query parameters
+ *
+ * @return void
+ */
+ public function mapInitialCondition()
+ {
+ $this->getSelect()->join(
+ ['cp_table' => $this->getTable('catalog_product_entity')],
+ 'main_table.product_id = cp_table.entity_id',
+ ['sku', 'type_id']
+ );
+ }
+
+ /**
+ * Apply website filter
+ *
+ * @param int|\Magento\Store\Model\Website $website
+ * @return void
+ */
+ public function mapWebsiteFilter($website)
+ {
+ if ($website instanceof \Magento\Store\Model\Website) {
+ $website = $website->getId();
+ }
+ $this->addFieldToFilter('main_table.website_id', $website);
+ }
+
+ /**
+ * Apply product(s) filter
+ *
+ * @param int|array|\Magento\Catalog\Model\Product|\Magento\Catalog\Model\Product[] $products
+ * @return void
+ */
+ public function mapProductsFilter($products)
+ {
+ $productIds = [];
+ if (!is_array($products)) {
+ $products = [$products];
+ }
+ foreach ($products as $product) {
+ if ($product instanceof \Magento\Catalog\Model\Product) {
+ $productIds[] = $product->getId();
+ } else {
+ $productIds[] = $product;
+ }
+ }
+ if (empty($productIds)) {
+ $productIds[] = false;
+ }
+ $this->addFieldToFilter('main_table.product_id', ['in' => $productIds]);
+ }
+
+ /**
+ * Apply filter by quantity
+ *
+ * @param float|int $qty
+ * @return void
+ */
+ public function mapQtyFilter($qty)
+ {
+ $this->addFieldToFilter('main_table.qty', ['lteq' => $qty]);
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/StockCriteria.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/StockCriteria.php
new file mode 100644
index 0000000000000000000000000000000000000000..91811d6ee10d2c4c79f9afa4ca0bd493e39e8196
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/StockCriteria.php
@@ -0,0 +1,60 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Resource\Stock;
+
+use Magento\Framework\Data\AbstractCriteria;
+
+/**
+ * Class StockCriteria
+ */
+class StockCriteria extends AbstractCriteria implements \Magento\CatalogInventory\Api\StockCriteriaInterface
+{
+ /**
+ * @param string $mapper
+ */
+ public function __construct($mapper = '')
+ {
+ $this->mapperInterfaceName = $mapper ?: 'Magento\CatalogInventory\Model\Resource\Stock\StockCriteriaMapper';
+ $this->data['initial_condition'] = true;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setWebsiteFilter($website)
+ {
+ $this->data['website_filter'] = $website;
+ }
+
+ /**
+ * Add Criteria object
+ *
+ * @param \Magento\CatalogInventory\Api\StockCriteriaInterface $criteria
+ * @return void
+ */
+ public function addCriteria(\Magento\CatalogInventory\Api\StockCriteriaInterface $criteria)
+ {
+ $this->data[self::PART_CRITERIA_LIST]['list'][] = $criteria;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/StockCriteriaMapper.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/StockCriteriaMapper.php
new file mode 100644
index 0000000000000000000000000000000000000000..8114195f806fc36e567be94c9c0a08498bf4177c
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/StockCriteriaMapper.php
@@ -0,0 +1,42 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\CatalogInventory\Model\Resource\Stock;
+
+use Magento\Framework\DB\GenericMapper;
+
+/**
+ * Class StockCriteriaMapper
+ * @package Magento\CatalogInventory\Model\Resource\Stock
+ */
+class StockCriteriaMapper extends GenericMapper
+{
+ /**
+ * @inheritdoc
+ */
+ protected function init()
+ {
+ $this->initResource('Magento\CatalogInventory\Model\Resource\Stock');
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Source/Stock.php b/app/code/Magento/CatalogInventory/Model/Source/Stock.php
index e91de41890d28aa855a1dad6eb890f2db8f6d1f3..db31afc5c5f12b02c68760ec2fd017391e5e985a 100644
--- a/app/code/Magento/CatalogInventory/Model/Source/Stock.php
+++ b/app/code/Magento/CatalogInventory/Model/Source/Stock.php
@@ -21,20 +21,21 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-
namespace Magento\CatalogInventory\Model\Source;
+use Magento\Eav\Model\Entity\Attribute\Source\AbstractSource;
+
/**
* CatalogInventory Stock source model
*/
-class Stock implements \Magento\Framework\Option\ArrayInterface
+class Stock extends AbstractSource
{
/**
* Retrieve option array
*
* @return array
*/
- public function toOptionArray()
+ public function getAllOptions()
{
return array(
array('value' => \Magento\CatalogInventory\Model\Stock::STOCK_IN_STOCK, 'label' => __('In Stock')),
diff --git a/app/code/Magento/CatalogInventory/Model/Spi/StockRegistryProviderInterface.php b/app/code/Magento/CatalogInventory/Model/Spi/StockRegistryProviderInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..cccc2f8d364f9d62c96c1b3d4632fb0edfa3c318
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Spi/StockRegistryProviderInterface.php
@@ -0,0 +1,52 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Spi;
+
+/**
+ * Interface StockRegistryProviderInterface
+ * @package Magento\CatalogInventory\Model\Spi
+ * @spi
+ */
+interface StockRegistryProviderInterface
+{
+ /**
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockInterface
+ */
+ public function getStock($websiteId);
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
+ */
+ public function getStockItem($productId, $websiteId);
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusInterface
+ */
+ public function getStockStatus($productId, $websiteId);
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Spi/StockStateProviderInterface.php b/app/code/Magento/CatalogInventory/Model/Spi/StockStateProviderInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..96f12b4d0b796842b5d27beb7dd9bb7408980d24
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Spi/StockStateProviderInterface.php
@@ -0,0 +1,90 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Spi;
+
+use Magento\CatalogInventory\Api\Data\StockItemInterface;
+
+/**
+ * Interface StockStateProviderInterface
+ * @package Magento\CatalogInventory\Model\Spi
+ * @spi
+ */
+interface StockStateProviderInterface
+{
+ /**
+ * @param StockItemInterface $stockItem
+ * @return bool
+ */
+ public function verifyStock(StockItemInterface $stockItem);
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @return bool
+ */
+ public function verifyNotification(StockItemInterface $stockItem);
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param int|float $itemQty
+ * @param int|float $qtyToCheck
+ * @param int|float $origQty
+ * @return int
+ */
+ public function checkQuoteItemQty(StockItemInterface $stockItem, $itemQty, $qtyToCheck, $origQty = 0);
+
+ /**
+ * Check quantity
+ *
+ * @param StockItemInterface $stockItem
+ * @param int|float $qty
+ * @exception \Magento\Framework\Model\Exception
+ * @return bool
+ */
+ public function checkQty(StockItemInterface $stockItem, $qty);
+
+ /**
+ * Returns suggested qty that satisfies qty increments and minQty/maxQty/minSaleQty/maxSaleQty conditions
+ * or original qty if such value does not exist
+ *
+ * @param StockItemInterface $stockItem
+ * @param int|float $qty
+ * @return int|float
+ */
+ public function suggestQty(StockItemInterface $stockItem, $qty);
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param int|float $qty
+ * @return \Magento\Framework\Object
+ */
+ public function checkQtyIncrements(StockItemInterface $stockItem, $qty);
+
+ /**
+ * Retrieve stock qty whether product is composite or no
+ *
+ * @param StockItemInterface $stockItem
+ * @return float
+ */
+ public function getStockQty(StockItemInterface $stockItem);
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Stock.php b/app/code/Magento/CatalogInventory/Model/Stock.php
index e4d8ae6f936ab2f814a9efe898f277d9efa4aebb..52f508d31301bb29811111eaa7ee7f099e88980d 100644
--- a/app/code/Magento/CatalogInventory/Model/Stock.php
+++ b/app/code/Magento/CatalogInventory/Model/Stock.php
@@ -23,100 +23,45 @@
*/
namespace Magento\CatalogInventory\Model;
-use Magento\CatalogInventory\Model\Stock\Item;
+use Magento\CatalogInventory\Api\Data\StockInterface;
+use Magento\Framework\Model\AbstractExtensibleModel;
/**
- * Stock model
- *
- * @method string getStockName()
- * @method \Magento\CatalogInventory\Model\Stock setStockName(string $value)
+ * Class Stock
+ * @package Magento\CatalogInventory\Model
+ * @data-api
*/
-class Stock extends \Magento\Framework\Model\AbstractModel
+class Stock extends AbstractExtensibleModel implements StockInterface
{
- const BACKORDERS_NO = 0;
-
- const BACKORDERS_YES_NONOTIFY = 1;
-
- const BACKORDERS_YES_NOTIFY = 2;
-
- const STOCK_OUT_OF_STOCK = 0;
-
- const STOCK_IN_STOCK = 1;
-
- /**
- * Default stock id
- */
- const DEFAULT_STOCK_ID = 1;
-
- /**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
- */
- protected $stockItemService;
-
/**
- * @var Stock\Status
+ * Stock entity code
*/
- protected $stockStatus;
+ const ENTITY = 'cataloginventory_stock';
/**
- * Store model manager
+ * Prefix of model events names
*
- * @var \Magento\Framework\StoreManagerInterface
+ * @var string
*/
- protected $_storeManager;
+ protected $eventPrefix = 'cataloginventory_stock';
/**
- * Stock item factory
+ * Parameter name in event
+ * In observe method you can use $observer->getEvent()->getStock() in this case
*
- * @var \Magento\CatalogInventory\Model\Stock\ItemFactory
+ * @var string
*/
- protected $_stockItemFactory;
+ protected $eventObject = 'stock';
- /**
- * @var \Magento\CatalogInventory\Model\Resource\Stock\Item\CollectionFactory
- */
- protected $_collectionFactory;
+ const BACKORDERS_NO = 0;
- /**
- * @var \Magento\Catalog\Model\ProductFactory
- */
- protected $productFactory;
+ const BACKORDERS_YES_NONOTIFY = 1;
- /**
- * @param \Magento\Framework\Model\Context $context
- * @param \Magento\Framework\Registry $registry
- * @param Resource\Stock\Item\CollectionFactory $collectionFactory
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
- * @param Stock\Status $stockStatus
- * @param \Magento\Framework\StoreManagerInterface $storeManager
- * @param Stock\ItemFactory $stockItemFactory
- * @param \Magento\Catalog\Model\ProductFactory $productFactory
- * @param \Magento\Framework\Model\Resource\AbstractResource $resource
- * @param \Magento\Framework\Data\Collection\Db $resourceCollection
- * @param array $data
- */
- public function __construct(
- \Magento\Framework\Model\Context $context,
- \Magento\Framework\Registry $registry,
- \Magento\CatalogInventory\Model\Resource\Stock\Item\CollectionFactory $collectionFactory,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
- \Magento\CatalogInventory\Model\Stock\Status $stockStatus,
- \Magento\Framework\StoreManagerInterface $storeManager,
- \Magento\CatalogInventory\Model\Stock\ItemFactory $stockItemFactory,
- \Magento\Catalog\Model\ProductFactory $productFactory,
- \Magento\Framework\Model\Resource\AbstractResource $resource = null,
- \Magento\Framework\Data\Collection\Db $resourceCollection = null,
- array $data = array()
- ) {
- parent::__construct($context, $registry, $resource, $resourceCollection, $data);
+ const BACKORDERS_YES_NOTIFY = 2;
- $this->_collectionFactory = $collectionFactory;
- $this->stockItemService = $stockItemService;
- $this->stockStatus = $stockStatus;
- $this->_storeManager = $storeManager;
- $this->_stockItemFactory = $stockItemFactory;
- $this->productFactory = $productFactory;
- }
+ const STOCK_OUT_OF_STOCK = 0;
+
+ const STOCK_IN_STOCK = 1;
/**
* @return void
@@ -129,202 +74,30 @@ class Stock extends \Magento\Framework\Model\AbstractModel
/**
* Retrieve stock identifier
*
- * @return int
+ * @return int|null
*/
public function getId()
{
- return self::DEFAULT_STOCK_ID;
- }
-
- /**
- * Add stock item objects to products
- *
- * @param array $productCollection
- * @return $this
- */
- public function addItemsToProducts($productCollection)
- {
- $items = $this->getItemCollection()->addProductsFilter($productCollection)
- ->joinStockStatus($productCollection->getStoreId())
- ->load();
- $stockItems = array();
- foreach ($items as $item) {
- $stockItems[$item->getProductId()] = $item;
- }
- foreach ($productCollection as $product) {
- if (isset($stockItems[$product->getId()])) {
- $this->stockStatus->assignProduct(
- $product,
- $stockItems[$product->getId()]->getStockId(),
- $product->getStockStatus()
- );
- }
- }
- return $this;
+ return $this->_getData(self::ID);
}
/**
- * Retrieve items collection object with stock filter
+ * Retrieve website identifier
*
- * @return \Magento\CatalogInventory\Model\Resource\Stock\Item\Collection
+ * @return int
*/
- public function getItemCollection()
+ public function getWebsiteId()
{
- return $this->_collectionFactory->create()->addStockFilter($this->getId());
+ return $this->_getData(self::WEBSITE_ID);
}
/**
- * Get Product type
+ * Retrieve Stock Name
*
- * @param int $productId
* @return string
*/
- protected function getProductType($productId)
- {
- $product = $this->productFactory->create();
- $product->load($productId);
- return $product->getTypeId();
- }
-
- /**
- * Prepare array($productId=>$qty) based on array($productId => array('qty'=>$qty, 'item'=>$stockItem))
- *
- * @param array $items
- * @return array
- */
- protected function _prepareProductQtys($items)
- {
- $qtys = array();
- foreach ($items as $productId => $item) {
- if (empty($item['item'])) {
- $stockItem = $this->_stockItemFactory->create()->loadByProduct($productId);
- } else {
- $stockItem = $item['item'];
- }
- $canSubtractQty = $stockItem->getId() && $stockItem->canSubtractQty();
- if ($canSubtractQty && $this->stockItemService->isQty($this->getProductType($productId))) {
- $qtys[$productId] = $item['qty'];
- }
- }
- return $qtys;
- }
-
- /**
- * Subtract product qtys from stock.
- * Return array of items that require full save
- *
- * @param array $items
- * @return Item[]
- * @throws \Magento\Framework\Model\Exception
- */
- public function registerProductsSale($items)
- {
- $qtys = $this->_prepareProductQtys($items);
- /** @var Item $item */
- $item = $this->_stockItemFactory->create();
- $this->_getResource()->beginTransaction();
- $stockInfo = $this->_getResource()->getProductsStock($this, array_keys($qtys), true);
- $fullSaveItems = array();
- foreach ($stockInfo as $itemInfo) {
- $item->setData($itemInfo);
- if (!$item->hasAdminArea() && !$item->checkQty($qtys[$item->getProductId()])) {
- $this->_getResource()->commit();
- throw new \Magento\Framework\Model\Exception(
- __('Not all of your products are available in the requested quantity.')
- );
- }
- $item->subtractQty($qtys[$item->getProductId()]);
- if (!$item->verifyStock() || $item->verifyNotification()) {
- $fullSaveItems[] = clone $item;
- }
- }
- $this->_getResource()->correctItemsQty($this, $qtys, '-');
- $this->_getResource()->commit();
- return $fullSaveItems;
- }
-
- /**
- * @param array $items
- * @return $this
- */
- public function revertProductsSale($items)
- {
- $qtys = $this->_prepareProductQtys($items);
- $this->_getResource()->correctItemsQty($this, $qtys, '+');
- return $this;
- }
-
- /**
- * Subtract ordered qty for product
- *
- * @param \Magento\Framework\Object $item
- * @return $this
- * @throws \Magento\Framework\Model\Exception
- */
- public function registerItemSale(\Magento\Framework\Object $item)
- {
- $productId = $item->getProductId();
- if (!$productId) {
- throw new \Magento\Framework\Model\Exception(
- __('We cannot specify a product identifier for the order item.')
- );
- }
- /** @var Item $stockItem */
- $stockItem = $this->_stockItemFactory->create()->loadByProduct($productId);
- if ($this->stockItemService->isQty($this->getProductType($productId))) {
- if ($item->getStoreId()) {
- $stockItem->setStoreId($item->getStoreId());
- }
- if ($stockItem->checkQty($item->getQtyOrdered())) {
- $stockItem->subtractQty($item->getQtyOrdered());
- $stockItem->save();
- }
- }
- return $this;
- }
-
- /**
- * Get back to stock (when order is canceled or whatever else)
- *
- * @param int $productId
- * @param int|float $qty
- * @return $this
- */
- public function backItemQty($productId, $qty)
- {
- /** @var Item $stockItem */
- $stockItem = $this->_stockItemFactory->create()->loadByProduct($productId);
- if ($stockItem->getId() && $this->stockItemService->isQty($this->getProductType($productId))) {
- $stockItem->addQty($qty);
- if ($stockItem->getCanBackInStock() && $stockItem->getQty() > $stockItem->getMinQty()) {
- $stockItem->setIsInStock(true)->setStockStatusChangedAutomaticallyFlag(true);
- }
- $stockItem->save();
- }
- return $this;
- }
-
- /**
- * Lock stock items for product ids array
- *
- * @param int|int[] $productIds
- * @return $this
- */
- public function lockProductItems($productIds)
- {
- $this->_getResource()->lockProductItems($this, $productIds);
- return $this;
- }
-
- /**
- * Adds filtering for collection to return only in stock products
- *
- * @param \Magento\Catalog\Model\Resource\Product\Link\Product\Collection $collection
- * @return $this
- */
- public function addInStockFilterToCollection($collection)
+ public function getStockName()
{
- $this->getResource()->setInStockFilterToCollection($collection);
- return $this;
+ return $this->_getData(self::STOCK_NAME);
}
}
diff --git a/app/code/Magento/CatalogInventory/Model/Stock/Item.php b/app/code/Magento/CatalogInventory/Model/Stock/Item.php
index ba4b16e14402a75ac590450951c7b1af06d96e67..7fa8d2dd1a1cec219a2dc18459164dd80d1d5181 100644
--- a/app/code/Magento/CatalogInventory/Model/Stock/Item.php
+++ b/app/code/Magento/CatalogInventory/Model/Stock/Item.php
@@ -23,135 +23,56 @@
*/
namespace Magento\CatalogInventory\Model\Stock;
+use Magento\CatalogInventory\Api\Data\StockItemInterface;
+use Magento\CatalogInventory\Api\StockConfigurationInterface as StockConfigurationInterface;
+use Magento\CatalogInventory\Api\StockItemRepositoryInterface as StockItemRepositoryInterface;
use Magento\Catalog\Model\Product;
+use Magento\CatalogInventory\Api\StockRegistryInterface;
+use Magento\Framework\Api\MetadataServiceInterface;
+use Magento\Framework\Model\AbstractExtensibleModel;
/**
- * Catalog Inventory Stock Model
+ * Catalog Inventory Stock Item Model
+ * @package Magento\CatalogInventory\Model\Stock
+ * @data-api
*
* @method \Magento\CatalogInventory\Model\Stock\Item setProductId(int $value)
* @method \Magento\CatalogInventory\Model\Stock\Item setStockId(int $value)
- * @method float getQty()
* @method \Magento\CatalogInventory\Model\Stock\Item setQty(float $value)
* @method \Magento\CatalogInventory\Model\Stock\Item setMinQty(float $value)
- * @method int getUseConfigMinQty()
* @method \Magento\CatalogInventory\Model\Stock\Item setUseConfigMinQty(int $value)
- * @method int getIsQtyDecimal()
* @method \Magento\CatalogInventory\Model\Stock\Item setIsQtyDecimal(int $value)
* @method \Magento\CatalogInventory\Model\Stock\Item setBackorders(int $value)
- * @method int getUseConfigBackorders()
* @method \Magento\CatalogInventory\Model\Stock\Item setUseConfigBackorders(int $value)
* @method \Magento\CatalogInventory\Model\Stock\Item setMinSaleQty(float $value)
- * @method int getUseConfigMinSaleQty()
* @method \Magento\CatalogInventory\Model\Stock\Item setUseConfigMinSaleQty(int $value)
* @method \Magento\CatalogInventory\Model\Stock\Item setMaxSaleQty(float $value)
- * @method int getUseConfigMaxSaleQty()
* @method \Magento\CatalogInventory\Model\Stock\Item setUseConfigMaxSaleQty(int $value)
* @method \Magento\CatalogInventory\Model\Stock\Item setIsInStock(int $value)
- * @method string getLowStockDate()
* @method \Magento\CatalogInventory\Model\Stock\Item setLowStockDate(string $value)
* @method \Magento\CatalogInventory\Model\Stock\Item setNotifyStockQty(float $value)
- * @method int getUseConfigNotifyStockQty()
* @method \Magento\CatalogInventory\Model\Stock\Item setUseConfigNotifyStockQty(int $value)
* @method \Magento\CatalogInventory\Model\Stock\Item setManageStock(int $value)
- * @method int getUseConfigManageStock()
* @method \Magento\CatalogInventory\Model\Stock\Item setUseConfigManageStock(int $value)
- * @method int getStockStatusChangedAutomatically()
* @method \Magento\CatalogInventory\Model\Stock\Item setStockStatusChangedAutomatically(int $value)
- * @method int getUseConfigQtyIncrements()
* @method \Magento\CatalogInventory\Model\Stock\Item setUseConfigQtyIncrements(int $value)
* @method \Magento\CatalogInventory\Model\Stock\Item setQtyIncrements(float $value)
- * @method int getUseConfigEnableQtyInc()
* @method \Magento\CatalogInventory\Model\Stock\Item setUseConfigEnableQtyInc(int $value)
* @method \Magento\CatalogInventory\Model\Stock\Item setEnableQtyIncrements(int $value)
*/
-class Item extends \Magento\Framework\Model\AbstractModel
+class Item extends AbstractExtensibleModel implements StockItemInterface
{
- /**
- * Inventory options config path
- */
- const XML_PATH_GLOBAL = 'cataloginventory/options/';
-
- /**
- * Subtract config path
- */
- const XML_PATH_CAN_SUBTRACT = 'cataloginventory/options/can_subtract';
-
- /**
- * Back in stock config path
- */
- const XML_PATH_CAN_BACK_IN_STOCK = 'cataloginventory/options/can_back_in_stock';
-
- /**
- * Item options config path
- */
- const XML_PATH_ITEM = 'cataloginventory/item_options/';
-
- /**
- * Max qty config path
- */
- const XML_PATH_MIN_QTY = 'cataloginventory/item_options/min_qty';
-
- /**
- * Min sale qty config path
- */
- const XML_PATH_MIN_SALE_QTY = 'cataloginventory/item_options/min_sale_qty';
-
- /**
- * Max sale qty config path
- */
- const XML_PATH_MAX_SALE_QTY = 'cataloginventory/item_options/max_sale_qty';
-
- /**
- * Back orders config path
- */
- const XML_PATH_BACKORDERS = 'cataloginventory/item_options/backorders';
-
- /**
- * Notify stock config path
- */
- const XML_PATH_NOTIFY_STOCK_QTY = 'cataloginventory/item_options/notify_stock_qty';
-
- /**
- * Manage stock config path
- */
- const XML_PATH_MANAGE_STOCK = 'cataloginventory/item_options/manage_stock';
-
- /**
- * Enable qty increments config path
- */
- const XML_PATH_ENABLE_QTY_INCREMENTS = 'cataloginventory/item_options/enable_qty_increments';
-
- /**
- * Qty increments config path
- */
- const XML_PATH_QTY_INCREMENTS = 'cataloginventory/item_options/qty_increments';
-
/**
* Stock item entity code
*/
const ENTITY = 'cataloginventory_stock_item';
- /**
- * Default stock id
- */
- const DEFAULT_STOCK_ID = 1;
-
- /**
- * @var array
- */
- private $_minSaleQtyCache = array();
-
- /**
- * @var float|false
- */
- protected $_qtyIncrements;
-
/**
* Prefix of model events names
*
* @var string
*/
- protected $_eventPrefix = 'cataloginventory_stock_item';
+ protected $eventPrefix = 'cataloginventory_stock_item';
/**
* Parameter name in event
@@ -160,103 +81,63 @@ class Item extends \Magento\Framework\Model\AbstractModel
*
* @var string
*/
- protected $_eventObject = 'item';
+ protected $eventObject = 'item';
/**
- * Customer group id
+ * Store model manager
*
- * @var int|null
+ * @var \Magento\Framework\StoreManagerInterface
*/
- protected $_customerGroupId;
+ protected $storeManager;
/**
- * Whether index events should be processed immediately
- *
- * @var bool
+ * @var StockConfigurationInterface
*/
- protected $_processIndexEvents = true;
+ protected $stockConfiguration;
/**
- * Catalog inventory min sale qty
- *
- * @var \Magento\CatalogInventory\Helper\Minsaleqty
+ * @var StockRegistryInterface
*/
- protected $_catalogInventoryMinsaleqty;
+ protected $stockRegistry;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var StockConfigurationInterface
*/
- protected $stockItemService;
+ protected $stockItemRepository;
/**
- * @var \Magento\CatalogInventory\Model\Stock\ItemRegistry
+ * @var float|false
*/
- protected $stockItemRegistry;
+ protected $qtyIncrements;
/**
- * Core store config
+ * Store id
*
- * @var \Magento\Framework\App\Config\ScopeConfigInterface
+ * @var int|null
*/
- protected $_scopeConfig;
+ protected $storeId;
/**
- * Store model manager
+ * Customer group id
*
- * @var \Magento\Framework\StoreManagerInterface
- */
- protected $_storeManager;
-
- /**
- * @var \Magento\Framework\Locale\FormatInterface
- */
- protected $_localeFormat;
-
- /**
- * @var Status
- */
- protected $_stockStatus;
-
- /**
- * @var \Magento\CatalogInventory\Model\Indexer\Stock\Processor
+ * @var int|null
*/
- protected $_stockIndexerProcessor;
+ protected $customerGroupId;
/**
* @var \Magento\Customer\Model\Session
*/
- protected $_customerSession;
-
- /**
- * @var \Magento\Framework\Math\Division
- */
- protected $mathDivision;
-
- /**
- * @var \Magento\Framework\Stdlib\DateTime\TimezoneInterface
- */
- protected $_localeDate;
-
- /**
- * @var \Magento\Catalog\Model\ProductFactory
- */
- protected $productFactory;
+ protected $customerSession;
/**
* @param \Magento\Framework\Model\Context $context
* @param \Magento\Framework\Registry $registry
+ * @param MetadataServiceInterface $metadataService
* @param \Magento\Customer\Model\Session $customerSession
- * @param \Magento\CatalogInventory\Model\Indexer\Stock\Processor $stockIndexerProcessor
- * @param Status $stockStatus
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
- * @param ItemRegistry $stockItemRegistry
- * @param \Magento\CatalogInventory\Helper\Minsaleqty $catalogInventoryMinsaleqty
- * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
* @param \Magento\Framework\StoreManagerInterface $storeManager
- * @param \Magento\Framework\Locale\FormatInterface $localeFormat
- * @param \Magento\Framework\Math\Division $mathDivision
- * @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate
- * @param \Magento\Catalog\Model\ProductFactory $productFactory
+ * @param StockConfigurationInterface $stockConfiguration
+ * @param StockRegistryInterface $stockRegistry
+ * @param StockItemRepositoryInterface $stockItemRepository
* @param \Magento\Framework\Model\Resource\AbstractResource $resource
* @param \Magento\Framework\Data\Collection\Db $resourceCollection
* @param array $data
@@ -264,36 +145,22 @@ class Item extends \Magento\Framework\Model\AbstractModel
public function __construct(
\Magento\Framework\Model\Context $context,
\Magento\Framework\Registry $registry,
+ MetadataServiceInterface $metadataService,
\Magento\Customer\Model\Session $customerSession,
- \Magento\CatalogInventory\Model\Indexer\Stock\Processor $stockIndexerProcessor,
- Status $stockStatus,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
- \Magento\CatalogInventory\Model\Stock\ItemRegistry $stockItemRegistry,
- \Magento\CatalogInventory\Helper\Minsaleqty $catalogInventoryMinsaleqty,
- \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
\Magento\Framework\StoreManagerInterface $storeManager,
- \Magento\Framework\Locale\FormatInterface $localeFormat,
- \Magento\Framework\Math\Division $mathDivision,
- \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate,
- \Magento\Catalog\Model\ProductFactory $productFactory,
+ StockConfigurationInterface $stockConfiguration,
+ StockRegistryInterface $stockRegistry,
+ StockItemRepositoryInterface $stockItemRepository,
\Magento\Framework\Model\Resource\AbstractResource $resource = null,
\Magento\Framework\Data\Collection\Db $resourceCollection = null,
- array $data = array()
+ array $data = []
) {
- parent::__construct($context, $registry, $resource, $resourceCollection, $data);
-
- $this->_customerSession = $customerSession;
- $this->_stockIndexerProcessor = $stockIndexerProcessor;
- $this->_stockStatus = $stockStatus;
- $this->stockItemService = $stockItemService;
- $this->stockItemRegistry = $stockItemRegistry;
- $this->_catalogInventoryMinsaleqty = $catalogInventoryMinsaleqty;
- $this->_scopeConfig = $scopeConfig;
- $this->_storeManager = $storeManager;
- $this->_localeFormat = $localeFormat;
- $this->mathDivision = $mathDivision;
- $this->_localeDate = $localeDate;
- $this->productFactory = $productFactory;
+ parent::__construct($context, $registry, $metadataService, $resource, $resourceCollection, $data);
+ $this->customerSession = $customerSession;
+ $this->storeManager = $storeManager;
+ $this->stockConfiguration = $stockConfiguration;
+ $this->stockRegistry = $stockRegistry;
+ $this->stockItemRepository = $stockItemRepository;
}
/**
@@ -307,784 +174,376 @@ class Item extends \Magento\Framework\Model\AbstractModel
}
/**
- * Retrieve stock identifier
- *
- * @todo multi stock
- * @return int
+ * @return int|null
*/
- public function getStockId()
+ public function getId()
{
- return self::DEFAULT_STOCK_ID;
+ return $this->_getData('item_id');
}
/**
- * Retrieve Product Id data wrapper
+ * Retrieve Website Id
*
* @return int
*/
- public function getProductId()
+ public function getWebsiteId()
{
- return $this->_getData('product_id');
+ $websiteId = $this->getData('website_id');
+ if ($websiteId === null) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ }
+ return (int) $websiteId;
}
/**
- * Load item data by product
+ * Retrieve stock identifier
*
- * @param int|Product $product
- * @return $this
+ * @return int
*/
- public function loadByProduct($product)
+ public function getStockId()
{
- if ($product instanceof Product) {
- $product = $product->getId();
+ $stockId = $this->getData('stock_id');
+ if ($stockId === null) {
+ $stockId = $this->stockRegistry->getStock($this->getWebsiteId())->getId();
}
- $this->_getResource()->loadByProductId($this, $product);
- $this->setOrigData();
- return $this;
+ return (int) $stockId;
}
/**
- * Subtract quote item quantity
+ * Retrieve Product Id
*
- * @param int|float $qty
- * @return $this
+ * @return int
*/
- public function subtractQty($qty)
+ public function getProductId()
{
- if ($this->canSubtractQty()) {
- $this->setQty($this->getQty() - $qty);
- }
- return $this;
+ return (int) $this->_getData('product_id');
}
/**
- * Check if is possible subtract value from item qty
- *
* @return bool
*/
- public function canSubtractQty()
+ public function getStockStatusChangedAuto()
{
- return $this->getManageStock() && $this->_scopeConfig->isSetFlag(
- self::XML_PATH_CAN_SUBTRACT,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
+ return (bool) $this->_getData('stock_status_changed_auto');
}
/**
- * Add quantity process
- *
- * @param float $qty
- * @return $this
+ * @return float
*/
- public function addQty($qty)
+ public function getQty()
{
- if (!$this->getManageStock()) {
- return $this;
- }
- $config = $this->_scopeConfig->isSetFlag(
- self::XML_PATH_CAN_SUBTRACT,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- if (!$config) {
- return $this;
- }
-
- $this->setQty($this->getQty() + $qty);
- return $this;
+ return null === $this->_getData('qty') ? null : floatval($this->_getData('qty'));
}
/**
- * Retrieve Store Id (product or current)
+ * Retrieve Stock Availability
*
- * @return int
+ * @return bool|int
*/
- public function getStoreId()
+ public function getIsInStock()
{
- $storeId = $this->getData('store_id');
- if (is_null($storeId)) {
- $storeId = $this->_storeManager->getStore()->getId();
- $this->setData('store_id', $storeId);
+ if (!$this->getManageStock()) {
+ return true;
}
- return $storeId;
+ return (bool) $this->_getData('is_in_stock');
}
/**
- * Retrieve minimal quantity available for item status in stock
- *
- * @return float
+ * @return bool
*/
- public function getMinQty()
+ public function getIsQtyDecimal()
{
- if ($this->getUseConfigMinQty()) {
- $minQty = (float) $this->_scopeConfig->getValue(
- self::XML_PATH_MIN_QTY,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- } else {
- $minQty = (float) $this->getData('min_qty');
- }
- return $minQty;
+ return (bool) $this->_getData('is_qty_decimal');
}
/**
- * Getter for customer group id, return current customer group if not set
- *
- * @return int
+ * @return bool
*/
- public function getCustomerGroupId()
+ public function getIsDecimalDivided()
{
- if ($this->_customerGroupId === null) {
- return $this->_customerSession->getCustomerGroupId();
- }
- return $this->_customerGroupId;
+ return (bool) $this->_getData('is_decimal_divided');
}
/**
- * Setter for customer group id
- *
- * @param int $value Value of customer group id
- * @return $this
+ * @return int Timestamp
*/
- public function setCustomerGroupId($value)
+ public function getLowStockDate()
{
- $this->_customerGroupId = $value;
- return $this;
+ return (int) $this->_getData('low_stock_date');
}
/**
- * Retrieve Minimum Qty Allowed in Shopping Cart or NULL when there is no limitation
+ * Check if notification message should be added despite of backorders notification flag
*
- * @return float|null
+ * @return bool
*/
- public function getMinSaleQty()
+ public function getShowDefaultNotificationMessage()
{
- $customerGroupId = $this->getCustomerGroupId();
- if (!isset($this->_minSaleQtyCache[$customerGroupId])) {
- if ($this->getUseConfigMinSaleQty()) {
- $minSaleQty = $this->_catalogInventoryMinsaleqty->getConfigValue($customerGroupId);
- } else {
- $minSaleQty = $this->getData('min_sale_qty');
- }
- $this->_minSaleQtyCache[$customerGroupId] = empty($minSaleQty) ? 0 : (float) $minSaleQty;
- }
-
- return $this->_minSaleQtyCache[$customerGroupId] ? $this->_minSaleQtyCache[$customerGroupId] : null;
+ return false;
}
/**
- * Retrieve Maximum Qty Allowed in Shopping Cart data wrapper
- *
- * @return float
+ * @return bool
*/
- public function getMaxSaleQty()
+ public function getUseConfigMinQty()
{
- if ($this->getUseConfigMaxSaleQty()) {
- $maxSaleQty = (float) $this->_scopeConfig->getValue(
- self::XML_PATH_MAX_SALE_QTY,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- } else {
- $maxSaleQty = (float) $this->getData('max_sale_qty');
- }
- return $maxSaleQty;
+ return (bool) $this->_getData('use_config_min_qty');
}
/**
- * Retrieve Notify for Quantity Below data wrapper
+ * Retrieve minimal quantity available for item status in stock
*
* @return float
*/
- public function getNotifyStockQty()
+ public function getMinQty()
{
- if ($this->getUseConfigNotifyStockQty()) {
- return (float) $this->_scopeConfig->getValue(
- self::XML_PATH_NOTIFY_STOCK_QTY,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
+ if ($this->getUseConfigMinQty()) {
+ $minQty = $this->stockConfiguration->getMinQty($this->getStoreId());
+ } else {
+ $minQty = (float)$this->getData('min_qty');
}
- return (float) $this->getData('notify_stock_qty');
+ return $minQty;
}
/**
- * Retrieve whether Quantity Increments is enabled
- *
* @return bool
*/
- public function getEnableQtyIncrements()
+ public function getUseConfigMinSaleQty()
{
- if ($this->getUseConfigEnableQtyInc()) {
- return $this->_scopeConfig->isSetFlag(
- self::XML_PATH_ENABLE_QTY_INCREMENTS,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- }
- return (bool) $this->getData('enable_qty_increments');
+ return (bool) $this->_getData('use_config_min_sale_qty');
}
-
/**
- * Retrieve Quantity Increments data wrapper
+ * Retrieve Minimum Qty Allowed in Shopping Cart or NULL when there is no limitation
*
- * @return float|false
+ * @return float
*/
- public function getQtyIncrements()
+ public function getMinSaleQty()
{
- if ($this->_qtyIncrements === null) {
- if ($this->getEnableQtyIncrements()) {
- if ($this->getUseConfigQtyIncrements()) {
- $this->_qtyIncrements = (float) $this->_scopeConfig->getValue(
- self::XML_PATH_QTY_INCREMENTS,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- } else {
- $this->_qtyIncrements = (float) $this->getData('qty_increments');
- }
- }
- if ($this->_qtyIncrements <= 0) {
- $this->_qtyIncrements = false;
- }
+ if ($this->getUseConfigMinSaleQty()) {
+ $customerGroupId = $this->getCustomerGroupId();
+ $minSaleQty = $this->stockConfiguration->getMinSaleQty($this->getStoreId(), $customerGroupId);
+ } else {
+ $minSaleQty = (float) $this->getData('min_sale_qty');
}
- return $this->_qtyIncrements;
+ return $minSaleQty;
}
/**
- * Retrieve Default Quantity Increments data wrapper
- *
- * @deprecated since 1.7.0.0
- * @return int|false
+ * @return bool
*/
- public function getDefaultQtyIncrements()
+ public function getUseConfigMaxSaleQty()
{
- $isEnabledQtyIncrements = $this->_scopeConfig->isSetFlag(
- self::XML_PATH_ENABLE_QTY_INCREMENTS,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
-
- $result = false;
- if ($isEnabledQtyIncrements) {
- $result = (int) $this->_scopeConfig->getValue(
- self::XML_PATH_QTY_INCREMENTS,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- }
-
- return $result;
+ return (bool) $this->_getData('use_config_max_sale_qty');
}
/**
- * Retrieve backorders status
+ * Retrieve Maximum Qty Allowed in Shopping Cart data wrapper
*
- * @return int
+ * @return float
*/
- public function getBackorders()
+ public function getMaxSaleQty()
{
- if ($this->getUseConfigBackorders()) {
- return (int) $this->_scopeConfig->getValue(
- self::XML_PATH_BACKORDERS,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
+ if ($this->getUseConfigMaxSaleQty()) {
+ $customerGroupId = $this->getCustomerGroupId();
+ $maxSaleQty = $this->stockConfiguration->getMaxSaleQty($this->getStoreId(), $customerGroupId);
+ } else {
+ $maxSaleQty = (float) $this->getData('max_sale_qty');
}
- return $this->getData('backorders');
+ return $maxSaleQty;
}
/**
- * Retrieve Manage Stock data wrapper
- *
- * @return int
+ * @return bool
*/
- public function getManageStock()
+ public function getUseConfigNotifyStockQty()
{
- if ($this->getUseConfigManageStock()) {
- return (int) $this->_scopeConfig->isSetFlag(
- self::XML_PATH_MANAGE_STOCK,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- }
- return $this->getData('manage_stock');
+ return (bool) $this->_getData('use_config_notify_stock_qty');
}
/**
- * Retrieve can Back in stock
+ * Retrieve Notify for Quantity Below data wrapper
*
- * @return bool
+ * @return float
*/
- public function getCanBackInStock()
+ public function getNotifyStockQty()
{
- return $this->_scopeConfig->isSetFlag(
- self::XML_PATH_CAN_BACK_IN_STOCK,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
+ if ($this->getUseConfigNotifyStockQty()) {
+ return $this->stockConfiguration->getNotifyStockQty($this->getStoreId());
+ }
+ return (float) $this->getData('notify_stock_qty');
}
/**
- * Check quantity
- *
- * @param int|float $qty
- * @exception \Magento\Framework\Model\Exception
* @return bool
*/
- public function checkQty($qty)
+ public function getUseConfigEnableQtyInc()
{
- if (!$this->_isQtyCheckApplicable()) {
- return true;
- }
-
- if ($this->getQty() - $this->getMinQty() - $qty < 0) {
- switch ($this->getBackorders()) {
- case \Magento\CatalogInventory\Model\Stock::BACKORDERS_YES_NONOTIFY:
- case \Magento\CatalogInventory\Model\Stock::BACKORDERS_YES_NOTIFY:
- break;
- default:
- return false;
- }
- }
- return true;
+ return (bool) $this->_getData('use_config_enable_qty_inc');
}
/**
- * Returns suggested qty that satisfies qty increments and minQty/maxQty/minSaleQty/maxSaleQty conditions
- * or original qty if such value does not exist
+ * Retrieve whether Quantity Increments is enabled
*
- * @param int|float $qty
- * @return int|float
+ * @return bool
*/
- public function suggestQty($qty)
+ public function getEnableQtyIncrements()
{
- // We do not manage stock
- if ($qty <= 0 || !$this->getManageStock()) {
- return $qty;
- }
-
- $qtyIncrements = (int)$this->getQtyIncrements();
- // Currently only integer increments supported
- if ($qtyIncrements < 2) {
- return $qty;
- }
-
- $minQty = max($this->getMinSaleQty(), $qtyIncrements);
- $divisibleMin = ceil($minQty / $qtyIncrements) * $qtyIncrements;
-
- $maxQty = min($this->getQty() - $this->getMinQty(), $this->getMaxSaleQty());
- $divisibleMax = floor($maxQty / $qtyIncrements) * $qtyIncrements;
-
- if ($qty < $minQty || $qty > $maxQty || $divisibleMin > $divisibleMax) {
- // Do not perform rounding for qty that does not satisfy min/max conditions to not confuse customer
- return $qty;
+ if ($this->getUseConfigEnableQtyInc()) {
+ return $this->stockConfiguration->getEnableQtyIncrements($this->getStoreId());
}
-
- // Suggest value closest to given qty
- $closestDivisibleLeft = floor($qty / $qtyIncrements) * $qtyIncrements;
- $closestDivisibleRight = $closestDivisibleLeft + $qtyIncrements;
- $acceptableLeft = min(max($divisibleMin, $closestDivisibleLeft), $divisibleMax);
- $acceptableRight = max(min($divisibleMax, $closestDivisibleRight), $divisibleMin);
- return abs($acceptableLeft - $qty) < abs($acceptableRight - $qty) ? $acceptableLeft : $acceptableRight;
+ return (bool) $this->getData('enable_qty_increments');
}
/**
- * Checking quote item quantity
- *
- * Second parameter of this method specifies quantity of this product in whole shopping cart
- * which should be checked for stock availability
+ * Retrieve whether config for Quantity Increments should be used
*
- * @param int|float $qty quantity of this item (item qty x parent item qty)
- * @param int|float $summaryQty quantity of this product
- * @param int|float $origQty original qty of item (not multiplied on parent item qty)
- * @return \Magento\Framework\Object
+ * @return bool
*/
- public function checkQuoteItemQty($qty, $summaryQty, $origQty = 0)
+ public function getUseConfigQtyIncrements()
{
- $result = new \Magento\Framework\Object();
- $result->setHasError(false);
-
- if (!is_numeric($qty)) {
- $qty = $this->_localeFormat->getNumber($qty);
- }
-
- /**
- * Check quantity type
- */
- $result->setItemIsQtyDecimal($this->getIsQtyDecimal());
-
- if (!$this->getIsQtyDecimal()) {
- $result->setHasQtyOptionUpdate(true);
- $qty = intval($qty);
-
- /**
- * Adding stock data to quote item
- */
- $result->setItemQty($qty);
-
- if (!is_numeric($qty)) {
- $qty = $this->_localeFormat->getNumber($qty);
- }
- $origQty = intval($origQty);
- $result->setOrigQty($origQty);
- }
-
- if ($this->getMinSaleQty() && $qty < $this->getMinSaleQty()) {
- $result->setHasError(true)
- ->setMessage(__('The fewest you may purchase is %1.', $this->getMinSaleQty() * 1))
- ->setErrorCode('qty_min')
- ->setQuoteMessage(__('Please correct the quantity for some products.'))
- ->setQuoteMessageIndex('qty');
- return $result;
- }
-
- if ($this->getMaxSaleQty() && $qty > $this->getMaxSaleQty()) {
- $result->setHasError(true)
- ->setMessage(__('The most you may purchase is %1.', $this->getMaxSaleQty() * 1))
- ->setErrorCode('qty_max')
- ->setQuoteMessage(__('Please correct the quantity for some products.'))
- ->setQuoteMessageIndex('qty');
- return $result;
- }
-
- $result->addData($this->checkQtyIncrements($qty)->getData());
- if ($result->getHasError()) {
- return $result;
- }
-
- if (!$this->getManageStock()) {
- return $result;
- }
-
- if (!$this->getIsInStock()) {
- $result->setHasError(true)
- ->setMessage(__('This product is out of stock.'))
- ->setQuoteMessage(__('Some of the products are currently out of stock.'))
- ->setQuoteMessageIndex('stock');
- $result->setItemUseOldQty(true);
- return $result;
- }
-
- if (!$this->checkQty($summaryQty) || !$this->checkQty($qty)) {
- $message = __('We don\'t have as many "%1" as you requested.', $this->getProductName());
- $result->setHasError(true)->setMessage($message)->setQuoteMessage($message)->setQuoteMessageIndex('qty');
- return $result;
- } else {
- if ($this->getQty() - $summaryQty < 0) {
- if ($this->getProductName()) {
- if ($this->getIsChildItem()) {
- $backOrderQty = $this->getQty() > 0 ? ($summaryQty - $this->getQty()) * 1 : $qty * 1;
- if ($backOrderQty > $qty) {
- $backOrderQty = $qty;
- }
-
- $result->setItemBackorders($backOrderQty);
- } else {
- $orderedItems = (int)$this->getOrderedItems();
-
- // Available item qty in stock excluding item qty in other quotes
- $qtyAvailable = ($this->getQty() - ($summaryQty - $qty))* 1;
- if ($qtyAvailable > 0) {
- $backOrderQty = $qty * 1 - $qtyAvailable;
- } else {
- $backOrderQty = $qty * 1;
- }
-
- if ($backOrderQty > 0) {
- $result->setItemBackorders($backOrderQty);
- }
- $this->setOrderedItems($orderedItems + $qty);
- }
-
- if ($this->getBackorders() == \Magento\CatalogInventory\Model\Stock::BACKORDERS_YES_NOTIFY) {
- if (!$this->getIsChildItem()) {
- $result->setMessage(
- __(
- 'We don\'t have as many "%1" as you requested, but we\'ll back order the remaining %2.',
- $this->getProductName(),
- $backOrderQty * 1
- )
- );
- } else {
- $result->setMessage(
- __(
- 'We don\'t have "%1" in the requested quantity, so we\'ll back order the remaining %2.',
- $this->getProductName(),
- $backOrderQty * 1
- )
- );
- }
- } elseif ($this->_hasDefaultNotificationMessage()) {
- $result->setMessage(
- __('We don\'t have as many "%1" as you requested.', $this->getProductName())
- );
- }
- }
- } else {
- if (!$this->getIsChildItem()) {
- $this->setOrderedItems($qty + (int) $this->getOrderedItems());
- }
- }
- }
-
- return $result;
+ return (bool) $this->_getData('use_config_qty_increments');
}
/**
- * Check qty increments
+ * Retrieve Quantity Increments
*
- * @param int|float $qty
- * @return \Magento\Framework\Object
+ * @return int|false
*/
- public function checkQtyIncrements($qty)
+ public function getQtyIncrements()
{
- $result = new \Magento\Framework\Object();
- if ($this->getSuppressCheckQtyIncrements()) {
- return $result;
- }
-
- $qtyIncrements = $this->getQtyIncrements();
-
- if ($qtyIncrements && $this->mathDivision->getExactDivision($qty, $qtyIncrements) != 0) {
- $result->setHasError(true)
- ->setQuoteMessage(__('Please correct the quantity for some products.'))
- ->setErrorCode('qty_increments')
- ->setQuoteMessageIndex('qty');
- if ($this->getIsChildItem()) {
- $result->setMessage(
- __('You can buy %1 only in increments of %2.', $this->getProductName(), $qtyIncrements * 1)
- );
- } else {
- $result->setMessage(__('You can buy this product only in increments of %1.', $qtyIncrements * 1));
+ if ($this->qtyIncrements === null) {
+ if ($this->getEnableQtyIncrements()) {
+ if ($this->getUseConfigQtyIncrements()) {
+ $this->qtyIncrements = $this->stockConfiguration->getQtyIncrements($this->getStoreId());
+ } else {
+ $this->qtyIncrements = (int) $this->getData('qty_increments');
+ }
+ }
+ if ($this->qtyIncrements <= 0) {
+ $this->qtyIncrements = false;
}
}
-
- return $result;
+ return $this->qtyIncrements;
}
/**
- * Add join for catalog in stock field to product collection
- *
- * @param \Magento\Catalog\Model\Resource\Product\Collection $productCollection
- * @return $this
+ * @return bool
*/
- public function addCatalogInventoryToProductCollection($productCollection)
+ public function getUseConfigBackorders()
{
- $this->_getResource()->addCatalogInventoryToProductCollection($productCollection);
- return $this;
+ return (bool) $this->_getData('use_config_backorders');
}
/**
- * Add error to Quote Item
- *
- * @param \Magento\Sales\Model\Quote\Item $item
- * @param string $itemError
- * @param string $quoteError
- * @param string $errorIndex
- * @return $this
- */
- protected function _addQuoteItemError(
- \Magento\Sales\Model\Quote\Item $item,
- $itemError,
- $quoteError,
- $errorIndex = 'error'
- ) {
- $item->setHasError(true);
- $item->setMessage($itemError);
- $item->setQuoteMessage($quoteError);
- $item->setQuoteMessageIndex($errorIndex);
- return $this;
- }
-
- /**
- * Before save prepare process
+ * Retrieve backorders status
*
- * @return $this
+ * @return int
*/
- protected function _beforeSave()
+ public function getBackorders()
{
- parent::_beforeSave();
- /** @var \Magento\Catalog\Model\Product $product */
- $product = $this->productFactory->create();
- $product->load($this->getProductId());
- $typeId = $product->getTypeId() ? $product->getTypeId() : $this->getTypeId();
-
- $isQty = $this->stockItemService->isQty($typeId);
-
- if ($isQty) {
- if ($this->getManageStock() && !$this->verifyStock()) {
- $this->setIsInStock(false)->setStockStatusChangedAutomaticallyFlag(true);
- }
-
- // if qty is below notify qty, update the low stock date to today date otherwise set null
- $this->setLowStockDate(null);
- if ($this->verifyNotification()) {
- $this->setLowStockDate(
- $this->_localeDate->date(null, null, null, false)
- ->toString(\Magento\Framework\Stdlib\DateTime::DATETIME_INTERNAL_FORMAT)
- );
- }
-
- $this->setStockStatusChangedAuto(0);
- if ($this->hasStockStatusChangedAutomaticallyFlag()) {
- $this->setStockStatusChangedAuto((int) $this->getStockStatusChangedAutomaticallyFlag());
- }
- } else {
- $this->setQty(0);
+ if ($this->getUseConfigBackorders()) {
+ return $this->stockConfiguration->getBackorders($this->getStoreId());
}
-
- return $this;
+ return (int) $this->getData('backorders');
}
/**
- * Check if item should be in stock or out of stock based on $qty param of existing item qty
- *
- * @param float|null $qty
- * @return bool true - item in stock | false - item out of stock
+ * @return bool
*/
- public function verifyStock($qty = null)
+ public function getUseConfigManageStock()
{
- if ($qty === null) {
- $qty = $this->getQty();
- }
- if ($qty !== null
- && $this->getBackorders() == \Magento\CatalogInventory\Model\Stock::BACKORDERS_NO
- && $qty <= $this->getMinQty()
- ) {
- return false;
- }
- return true;
+ return (bool) $this->_getData('use_config_manage_stock');
}
/**
- * Check if item qty require stock status notification
+ * Retrieve can Manage Stock
*
- * @param float|null $qty
- * @return bool (true - if require, false - if not require)
+ * @return int
*/
- public function verifyNotification($qty = null)
+ public function getManageStock()
{
- if ($qty === null) {
- $qty = $this->getQty();
+ if ($this->getUseConfigManageStock()) {
+ return $this->stockConfiguration->getManageStock($this->getStoreId());
}
- return (float) $qty < $this->getNotifyStockQty();
+ return (int) $this->getData('manage_stock');
}
/**
- * Reindex CatalogInventory save event
+ * Save object data
*
* @return $this
+ * @throws \Exception
*/
- protected function _afterSave()
+ public function save()
{
- parent::_afterSave();
-
- if ($this->_processIndexEvents) {
- $this->_stockIndexerProcessor->reindexRow($this->getProductId());
- }
+ $this->stockItemRepository->save($this);
return $this;
}
- /**
- * Retrieve Stock Availability
- *
- * @return bool|int
- */
- public function getIsInStock()
- {
- if (!$this->getManageStock()) {
- return true;
- }
- return $this->_getData('is_in_stock');
- }
-
/**
* Add product data to stock item
*
* @param Product $product
* @return $this
*/
- public function setProduct($product)
+ public function setProduct(Product $product)
{
$this->setProductId($product->getId())
- ->setProductName($product->getName())
->setStoreId($product->getStoreId())
->setProductTypeId($product->getTypeId())
+ ->setProductName($product->getName())
->setProductStatusChanged($product->dataHasChangedFor('status'))
->setProductChangedWebsites($product->getIsChangedWebsites());
-
return $this;
}
/**
- * Retrieve stock qty whether product is composite or no
+ * Setter for store id
*
- * @return float
- */
- public function getStockQty()
- {
- if (!$this->hasStockQty()) {
- $this->setStockQty(0);
-
- /** @var Product $product */
- $product = $this->productFactory->create();
- $product->load($this->getProductId());
- // prevent possible recursive loop
- if (!$product->isComposite()) {
- $stockQty = $this->getQty();
- } else {
- $stockQty = null;
- $productsByGroups = $product->getTypeInstance()->getProductsToPurchaseByReqGroups($product);
- foreach ($productsByGroups as $productsInGroup) {
- $qty = 0;
- foreach ($productsInGroup as $childProduct) {
- $qty += $this->stockItemRegistry->retrieve($childProduct->getId())->getStockQty();
- }
- if (null === $stockQty || $qty < $stockQty) {
- $stockQty = $qty;
- }
- }
- }
- $stockQty = (float) $stockQty;
- if ($stockQty < 0 || !$this->getManageStock() || !$this->getIsInStock() || !$product->isSaleable()) {
- $stockQty = 0;
- }
- $this->setStockQty($stockQty);
- }
- return (float) $this->getData('stock_qty');
- }
-
- /**
- * Set whether index events should be processed immediately
- *
- * @param bool $process
+ * @param int $value Value of store id
* @return $this
*/
- public function setProcessIndexEvents($process = true)
+ public function setStoreId($value)
{
- $this->_processIndexEvents = $process;
+ $this->storeId = $value;
return $this;
}
/**
- * Check if qty check can be skipped
+ * Retrieve Store Id (product or current)
*
- * @return bool
+ * @return int
*/
- protected function _isQtyCheckApplicable()
+ public function getStoreId()
{
- return (bool) $this->getManageStock();
+ if ($this->storeId === null) {
+ $this->storeId = $this->storeManager->getStore()->getId();
+ }
+ return $this->storeId;
}
/**
- * Check if notification message should be added despite of backorders notification flag
+ * Getter for customer group id, return current customer group if not set
*
- * @return bool
+ * @return int
*/
- protected function _hasDefaultNotificationMessage()
+ public function getCustomerGroupId()
{
- return false;
+ if ($this->customerGroupId === null) {
+ return $this->customerSession->getCustomerGroupId();
+ }
+ return $this->customerGroupId;
}
/**
- * Process data and set in_stock availability
+ * Setter for customer group id
*
+ * @param int $value Value of customer group id
* @return $this
*/
- public function processIsInStock()
+ public function setCustomerGroupId($value)
{
- $this->setData('is_in_stock', $this->verifyStock() ? Status::STATUS_IN_STOCK : Status::STATUS_OUT_OF_STOCK);
+ $this->customerGroupId = $value;
return $this;
}
}
diff --git a/app/code/Magento/CatalogInventory/Model/Stock/ItemRegistry.php b/app/code/Magento/CatalogInventory/Model/Stock/ItemRegistry.php
deleted file mode 100644
index 0ec4cd4274f79bf0912a8b9fe3689ecf861ecec8..0000000000000000000000000000000000000000
--- a/app/code/Magento/CatalogInventory/Model/Stock/ItemRegistry.php
+++ /dev/null
@@ -1,84 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Model\Stock;
-
-/**
- * Stock item registry
- */
-class ItemRegistry extends \Magento\Framework\Model\AbstractModel
-{
- /**
- * @var \Magento\CatalogInventory\Model\Stock\Item[]
- */
- protected $stockItemRegistry;
-
- /**
- * @var \Magento\CatalogInventory\Model\Stock\ItemFactory
- */
- protected $stockItemFactory;
-
- /**
- * @var \Magento\CatalogInventory\Model\Resource\Stock\Item
- */
- protected $stockItemResource;
-
- /**
- * @param ItemFactory $stockItemFactory
- * @param \Magento\CatalogInventory\Model\Resource\Stock\Item $stockItemResource
- */
- public function __construct(
- ItemFactory $stockItemFactory,
- \Magento\CatalogInventory\Model\Resource\Stock\Item $stockItemResource
- ) {
- $this->stockItemFactory = $stockItemFactory;
- $this->stockItemResource = $stockItemResource;
- }
-
- /**
- * @param int $productId
- * @return \Magento\CatalogInventory\Model\Stock\Item
- */
- public function retrieve($productId)
- {
- if (empty($this->stockItemRegistry[$productId])) {
- /** @var \Magento\CatalogInventory\Model\Stock\Item $stockItem */
- $stockItem = $this->stockItemFactory->create();
-
- $this->stockItemResource->loadByProductId($stockItem, $productId);
- $this->stockItemRegistry[$productId] = $stockItem;
- }
-
- return $this->stockItemRegistry[$productId];
- }
-
- /**
- * @param int $productId
- * @return $this
- */
- public function erase($productId)
- {
- $this->stockItemRegistry[$productId] = null;
- return $this;
- }
-}
diff --git a/app/code/Magento/CatalogInventory/Model/Stock/Status.php b/app/code/Magento/CatalogInventory/Model/Stock/Status.php
index 91ea17cbb782e773d220da4aa045ce654f77458b..f56e933d735fce389cd95add8a703e26a9190df4 100644
--- a/app/code/Magento/CatalogInventory/Model/Stock/Status.php
+++ b/app/code/Magento/CatalogInventory/Model/Stock/Status.php
@@ -23,26 +23,24 @@
*/
namespace Magento\CatalogInventory\Model\Stock;
-use Magento\CatalogInventory\Model\Stock;
-use Magento\Catalog\Model\Product\Type\AbstractType;
-use Magento\Catalog\Model\Product\Type;
-use Magento\Catalog\Model\Product\Attribute\Source\Status as ProductStatus;
+use Magento\CatalogInventory\Api\Data\StockStatusInterface;
+use Magento\CatalogInventory\Api\Data\StockItemInterface;
+use Magento\CatalogInventory\Api\StockRegistryInterface;
+use Magento\Framework\Api\MetadataServiceInterface;
+use Magento\Framework\Model\AbstractExtensibleModel;
/**
- * CatalogInventory Stock Status per website Model
+ * CatalogInventory Stock Status
+ * @package Magento\CatalogInventory\Model\Stock
+ * @data-api
*
- * @method int getProductId()
* @method Status setProductId(int $value)
- * @method int getWebsiteId()
* @method Status setWebsiteId(int $value)
- * @method int getStockId()
* @method Status setStockId(int $value)
- * @method float getQty()
* @method Status setQty(float $value)
- * @method int getStockStatus()
* @method Status setStockStatus(int $value)
*/
-class Status extends \Magento\Framework\Model\AbstractModel
+class Status extends AbstractExtensibleModel implements StockStatusInterface
{
/**#@+
* Stock Status values
@@ -52,54 +50,11 @@ class Status extends \Magento\Framework\Model\AbstractModel
const STATUS_IN_STOCK = 1;
/**#@-*/
- /**
- * Product Type Instances cache
- *
- * @var array
- */
- protected $_productTypes = array();
-
- /**
- * Websites cache
- *
- * @var array
- */
- protected $_websites;
-
- /**
- * Catalog inventory data
- *
- * @var \Magento\CatalogInventory\Helper\Data
- */
- protected $_catalogInventoryData;
-
- /**
- * @var Type
- */
- protected $_productType;
-
- /**
- * Store model manager
- *
- * @var \Magento\Framework\StoreManagerInterface
- */
- protected $_storeManager;
-
- /**
- * Stock item factory
- *
- * @var ItemFactory
- */
- protected $_stockItemFactory;
-
/**
* @param \Magento\Framework\Model\Context $context
* @param \Magento\Framework\Registry $registry
- * @param Type $productType
- * @param \Magento\Catalog\Model\Product\Website $productWebsite
- * @param \Magento\Framework\StoreManagerInterface $storeManager
- * @param ItemFactory $stockItemFactory
- * @param \Magento\CatalogInventory\Helper\Data $catalogInventoryData
+ * @param MetadataServiceInterface $metadataService
+ * @param StockRegistryInterface $stockRegistry
* @param \Magento\Framework\Model\Resource\AbstractResource $resource
* @param \Magento\Framework\Data\Collection\Db $resourceCollection
* @param array $data
@@ -107,22 +62,14 @@ class Status extends \Magento\Framework\Model\AbstractModel
public function __construct(
\Magento\Framework\Model\Context $context,
\Magento\Framework\Registry $registry,
- Type $productType,
- \Magento\Catalog\Model\Product\Website $productWebsite,
- \Magento\Framework\StoreManagerInterface $storeManager,
- ItemFactory $stockItemFactory,
- \Magento\CatalogInventory\Helper\Data $catalogInventoryData,
+ MetadataServiceInterface $metadataService,
+ StockRegistryInterface $stockRegistry,
\Magento\Framework\Model\Resource\AbstractResource $resource = null,
\Magento\Framework\Data\Collection\Db $resourceCollection = null,
- array $data = array()
+ array $data = []
) {
- parent::__construct($context, $registry, $resource, $resourceCollection, $data);
-
- $this->_catalogInventoryData = $catalogInventoryData;
- $this->_productType = $productType;
- $this->_productWebsite = $productWebsite;
- $this->_storeManager = $storeManager;
- $this->_stockItemFactory = $stockItemFactory;
+ parent::__construct($context, $registry, $metadataService, $resource, $resourceCollection, $data);
+ $this->stockRegistry = $stockRegistry;
}
/**
@@ -136,412 +83,50 @@ class Status extends \Magento\Framework\Model\AbstractModel
}
/**
- * Retrieve Product Type Instances
- * as key - type code, value - instance model
- *
- * @return array
- */
- public function getProductTypeInstances()
- {
- if (empty($this->_productTypes)) {
- $productEmulator = new \Magento\Framework\Object();
-
- foreach (array_keys($this->_productType->getTypes()) as $typeId) {
- $productEmulator->setTypeId($typeId);
- $this->_productTypes[$typeId] = $this->_productType->factory($productEmulator);
- }
- }
- return $this->_productTypes;
- }
-
- /**
- * Retrieve Product Type Instance By Product Type
- *
- * @param string $productType
- * @return AbstractType|bool
- */
- public function getProductTypeInstance($productType)
- {
- $types = $this->getProductTypeInstances();
- if (isset($types[$productType])) {
- return $types[$productType];
- }
- return false;
- }
-
- /**
- * Retrieve website models
- *
- * @param int|null $websiteId
- * @return array
- */
- public function getWebsites($websiteId = null)
- {
- if (is_null($this->_websites)) {
- /** @var \Magento\CatalogInventory\Model\Resource\Stock\Status $resource */
- $resource = $this->getResource();
- $this->_websites = $resource->getWebsiteStores();
- }
-
- $websites = $this->_websites;
- if (!is_null($websiteId) && isset($this->_websites[$websiteId])) {
- $websites = array($websiteId => $this->_websites[$websiteId]);
- }
-
- return $websites;
- }
-
- /**
- * Assign Stock Status to Product
- *
- * @param \Magento\Catalog\Model\Product $product
- * @param int $stockId
- * @param int $stockStatus
- * @return $this
- */
- public function assignProduct(
- \Magento\Catalog\Model\Product $product,
- $stockId = Stock::DEFAULT_STOCK_ID,
- $stockStatus = null
- ) {
- if (is_null($stockStatus)) {
- $websiteId = $product->getStore()->getWebsiteId();
- $status = $this->getProductStockStatus($product->getId(), $websiteId, $stockId);
- $stockStatus = isset($status[$product->getId()]) ? $status[$product->getId()] : null;
- }
-
- $product->setIsSalable($stockStatus);
-
- return $this;
- }
-
- /**
- * Rebuild stock status for all products
- *
- * @param int $websiteId
- * @return $this
- */
- public function rebuild($websiteId = null)
- {
- $lastProductId = 0;
- while (true) {
- /** @var \Magento\CatalogInventory\Model\Resource\Stock\Status $resource */
- $resource = $this->getResource();
- $productCollection = $resource->getProductCollection($lastProductId);
- if (!$productCollection) {
- break;
- }
-
- foreach ($productCollection as $productId => $productType) {
- $lastProductId = $productId;
- $this->updateStatus($productId, $productType, $websiteId);
- }
- }
-
- return $this;
- }
-
- /**
- * Update product status from stock item
- *
- * @param int $productId
- * @param string $productType
- * @param int $websiteId
- * @return $this
- */
- public function updateStatus($productId, $productType = null, $websiteId = null)
- {
- if (is_null($productType)) {
- $productType = $this->getProductType($productId);
- }
-
- /** @var Item $item */
- $item = $this->_stockItemFactory->create()->loadByProduct($productId);
-
- $status = self::STATUS_IN_STOCK;
- $qty = 0;
- if ($item->getId()) {
- $status = $item->getIsInStock();
- $qty = $item->getQty();
- }
-
- $this->_processChildren($productId, $productType, $qty, $status, $item->getStockId(), $websiteId);
- $this->_processParents($productId, $item->getStockId(), $websiteId);
-
- return $this;
- }
-
- /**
- * Process children stock status
- *
- * @param int $productId
- * @param string $productType
- * @param int $qty
- * @param int $status
- * @param int $stockId
- * @param int $websiteId
- * @return $this
- */
- protected function _processChildren(
- $productId,
- $productType,
- $qty = 0,
- $status = self::STATUS_IN_STOCK,
- $stockId = Stock::DEFAULT_STOCK_ID,
- $websiteId = null
- ) {
- if ($status == self::STATUS_OUT_OF_STOCK) {
- $this->saveProductStatus($productId, $status, $qty, $stockId, $websiteId);
- return $this;
- }
-
- $statuses = array();
- $websites = $this->getWebsites($websiteId);
-
- foreach (array_keys($websites) as $websiteId) {
- /* @var $website \Magento\Store\Model\Website */
- $statuses[$websiteId] = $status;
- }
-
- $typeInstance = $this->getProductTypeInstance($productType);
- if (!$typeInstance) {
- return $this;
- }
-
- $requiredChildrenIds = $typeInstance->getChildrenIds($productId, true);
- if ($requiredChildrenIds) {
- $childrenIds = array();
- foreach ($requiredChildrenIds as $groupedChildrenIds) {
- $childrenIds = array_merge($childrenIds, $groupedChildrenIds);
- }
- $childrenWebsites = $this->_productWebsite->getWebsites($childrenIds);
- foreach ($websites as $websiteId => $storeId) {
- $childrenStatus = $this->getProductStatus($childrenIds, $storeId);
- $childrenStock = $this->getProductStockStatus($childrenIds, $websiteId, $stockId);
- $websiteStatus = $statuses[$websiteId];
- foreach ($requiredChildrenIds as $groupedChildrenIds) {
- $optionStatus = false;
- foreach ($groupedChildrenIds as $childId) {
- if (isset($childrenStatus[$childId])
- && isset($childrenWebsites[$childId])
- && in_array($websiteId, $childrenWebsites[$childId])
- && $childrenStatus[$childId] == ProductStatus::STATUS_ENABLED
- && isset($childrenStock[$childId])
- && $childrenStock[$childId] == self::STATUS_IN_STOCK
- ) {
- $optionStatus = true;
- }
- }
- $websiteStatus = $websiteStatus && $optionStatus;
- }
- $statuses[$websiteId] = (int) $websiteStatus;
- }
- }
-
- foreach ($statuses as $websiteId => $websiteStatus) {
- $this->saveProductStatus($productId, $websiteStatus, $qty, $stockId, $websiteId);
- }
-
- return $this;
- }
-
- /**
- * Process Parents by child
- *
- * @param int $productId
- * @param int $stockId
- * @param int $websiteId
- * @return $this
- */
- protected function _processParents($productId, $stockId = Stock::DEFAULT_STOCK_ID, $websiteId = null)
- {
- $parentIds = array();
- foreach ($this->getProductTypeInstances() as $typeInstance) {
- /* @var $typeInstance AbstractType */
- $parentIds = array_merge($parentIds, $typeInstance->getParentIdsByChild($productId));
- }
-
- if (!$parentIds) {
- return $this;
- }
-
- $productTypes = $this->getProductsType($parentIds);
- /** @var Item $item */
- $item = $this->_stockItemFactory->create();
-
- foreach ($parentIds as $parentId) {
- $parentType = isset($productTypes[$parentId]) ? $productTypes[$parentId] : null;
- $item->setData(array('stock_id' => $stockId))->setOrigData()->loadByProduct($parentId);
- $status = self::STATUS_IN_STOCK;
- $qty = 0;
- if ($item->getId()) {
- $status = $item->getIsInStock();
- $qty = $item->getQty();
- }
-
- $this->_processChildren($parentId, $parentType, $qty, $status, $item->getStockId(), $websiteId);
- }
-
- return $this;
- }
-
- /**
- * Save product status per website
- * if website is null, saved for all websites
- *
- * @param int $productId
- * @param int $status
- * @param int $qty
- * @param int $stockId
- * @param int|null $websiteId
- * @return $this
- */
- public function saveProductStatus(
- $productId,
- $status,
- $qty = 0,
- $stockId = Stock::DEFAULT_STOCK_ID,
- $websiteId = null
- ) {
- /** @var \Magento\CatalogInventory\Model\Resource\Stock\Status $resource */
- $resource = $this->getResource();
- $resource->saveProductStatus($this, $productId, $status, $qty, $stockId, $websiteId);
- return $this;
- }
-
- /**
- * Retrieve Product(s) stock status
- *
- * @param int[] $productIds
- * @param int $websiteId
- * @param int $stockId
- * @return array
- */
- public function getProductStockStatus($productIds, $websiteId, $stockId = Stock::DEFAULT_STOCK_ID)
- {
- /** @var \Magento\CatalogInventory\Model\Resource\Stock\Status $resource */
- $resource = $this->getResource();
- return $resource->getProductStockStatus($productIds, $websiteId, $stockId);
- }
-
- /**
- * Retrieve Product(s) status
- *
- * @param int|int[] $productIds
- * @param int $storeId
- * @return array
+ * @return int
*/
- public function getProductStatus($productIds, $storeId = null)
+ public function getProductId()
{
- /** @var \Magento\CatalogInventory\Model\Resource\Stock\Status $resource */
- $resource = $this->getResource();
- return $resource->getProductStatus($productIds, $storeId);
+ return $this->getData('product_id');
}
/**
- * Retrieve Product Type
- *
- * @param int $productId
- * @return string|false
+ * @return int
*/
- public function getProductType($productId)
+ public function getWebsiteId()
{
- /** @var \Magento\CatalogInventory\Model\Resource\Stock\Status $resource */
- $resource = $this->getResource();
- $types = $resource->getProductsType($productId);
- if (isset($types[$productId])) {
- return $types[$productId];
- }
- return false;
+ return $this->getData('website_id');
}
/**
- * Retrieve Products Type as array
- * Return array as key product_id, value type
- *
- * @param array|int $productIds
- * @return array
+ * @return int
*/
- public function getProductsType($productIds)
+ public function getStockId()
{
- /** @var \Magento\CatalogInventory\Model\Resource\Stock\Status $resource */
- $resource = $this->getResource();
- return $resource->getProductsType($productIds);
+ return $this->getData('stock_id');
}
/**
- * Add information about stock status to product collection
- *
- * @param \Magento\Catalog\Model\Resource\Product\Collection $productCollection
- * @param int|null $websiteId
- * @param int|null $stockId
- * @return $this
+ * @return int
*/
- public function addStockStatusToProducts($productCollection, $websiteId = null, $stockId = null)
+ public function getQty()
{
- if ($stockId === null) {
- $stockId = Stock::DEFAULT_STOCK_ID;
- }
- if ($websiteId === null) {
- $websiteId = $this->_storeManager->getStore()->getWebsiteId();
- if ((int) $websiteId == 0 && $productCollection->getStoreId()) {
- $websiteId = $this->_storeManager->getStore($productCollection->getStoreId())->getWebsiteId();
- }
- }
- $productIds = array();
- foreach ($productCollection as $product) {
- $productIds[] = $product->getId();
- }
-
- if (!empty($productIds)) {
- $stockStatuses = $this->getProductStockStatus($productIds, $websiteId, $stockId);
- foreach ($stockStatuses as $productId => $status) {
- if ($product = $productCollection->getItemById($productId)) {
- $product->setIsSalable($status);
- }
- }
- }
-
- return $this;
+ return $this->getData('qty');
}
/**
- * Add stock status to prepare index select
- *
- * @param \Magento\Framework\DB\Select $select
- * @param \Magento\Store\Model\Website $website
- * @return $this
+ * @return int
*/
- public function addStockStatusToSelect(\Magento\Framework\DB\Select $select, \Magento\Store\Model\Website $website)
+ public function getStockStatus()
{
- $resource = $this->_getResource();
- $resource->addStockStatusToSelect($select, $website);
- return $this;
+ return $this->getData('stock_status');
}
/**
- * Add only is in stock products filter to product collection
- *
- * @param \Magento\Catalog\Model\Resource\Product\Collection $collection
- * @return $this
- */
- public function addIsInStockFilterToCollection($collection)
- {
- $resource = $this->_getResource();
- $resource->addIsInStockFilterToCollection($collection);
- return $this;
- }
-
- /**
- * Get options for stock attribute in product creation
- *
- * @return array
+ * @return StockItemInterface
*/
- public static function getAllOptions()
+ public function getStockItem()
{
- return array(
- array('value' => Stock::STOCK_IN_STOCK, 'label' => __('In Stock')),
- array('value' => Stock::STOCK_OUT_OF_STOCK, 'label' => __('Out of Stock'))
- );
+ return $this->stockRegistry->getStockItem($this->getProductId(), $this->getWebsiteId());
}
}
diff --git a/app/code/Magento/CatalogInventory/Model/Stock/StockItemRepository.php b/app/code/Magento/CatalogInventory/Model/Stock/StockItemRepository.php
new file mode 100644
index 0000000000000000000000000000000000000000..b67a26bcece5c882a77582b980104d72950817cf
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Stock/StockItemRepository.php
@@ -0,0 +1,234 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Stock;
+
+use Magento\Framework\DB\MapperFactory;
+use Magento\Catalog\Model\ProductFactory;
+use Magento\Framework\DB\QueryBuilderFactory;
+use Magento\Framework\Exception\CouldNotSaveException;
+use Magento\Framework\Exception\NoSuchEntityException;
+use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
+use Magento\Framework\Exception\CouldNotDeleteException;
+use Magento\CatalogInventory\Api\Data\StockItemInterface;
+use Magento\CatalogInventory\Model\Indexer\Stock\Processor;
+use Magento\CatalogInventory\Api\StockConfigurationInterface;
+use Magento\CatalogInventory\Api\Data\StockItemInterfaceFactory;
+use Magento\CatalogInventory\Model\Spi\StockStateProviderInterface;
+use Magento\CatalogInventory\Api\Data\StockItemCollectionInterfaceFactory;
+use Magento\CatalogInventory\Model\Resource\Stock\Item as StockItemResource;
+use Magento\CatalogInventory\Api\StockItemRepositoryInterface as StockItemRepositoryInterface;
+
+/**
+ * Class StockItemRepository
+ * @api
+ */
+class StockItemRepository implements StockItemRepositoryInterface
+{
+ /**
+ * @var StockConfigurationInterface
+ */
+ protected $stockConfiguration;
+
+ /**
+ * @var StockStateProviderInterface
+ */
+ protected $stockStateProvider;
+
+ /**
+ * @var StockItemResource
+ */
+ protected $resource;
+
+ /**
+ * @var StockItemInterfaceFactory
+ */
+ protected $stockItemFactory;
+
+ /**
+ * @var StockItemCollectionInterfaceFactory
+ */
+ protected $stockItemCollectionFactory;
+
+ /**
+ * @var ProductFactory
+ */
+ protected $productFactory;
+
+ /**
+ * @var QueryBuilderFactory
+ */
+ protected $queryBuilderFactory;
+
+ /**
+ * @var MapperFactory
+ */
+ protected $mapperFactory;
+
+ /**
+ * @var TimezoneInterface
+ */
+ protected $localeDate;
+
+ /**
+ * @var Processor
+ */
+ protected $indexProcessor;
+
+ /**
+ * @param StockConfigurationInterface $stockConfiguration
+ * @param StockStateProviderInterface $stockStateProvider
+ * @param StockItemResource $resource
+ * @param StockItemInterfaceFactory $stockItemFactory
+ * @param StockItemCollectionInterfaceFactory $stockItemCollectionFactory
+ * @param ProductFactory $productFactory
+ * @param QueryBuilderFactory $queryBuilderFactory
+ * @param MapperFactory $mapperFactory
+ * @param TimezoneInterface $localeDate
+ * @param Processor $indexProcessor
+ */
+ public function __construct(
+ StockConfigurationInterface $stockConfiguration,
+ StockStateProviderInterface $stockStateProvider,
+ StockItemResource $resource,
+ StockItemInterfaceFactory $stockItemFactory,
+ StockItemCollectionInterfaceFactory $stockItemCollectionFactory,
+ ProductFactory $productFactory,
+ QueryBuilderFactory $queryBuilderFactory,
+ MapperFactory $mapperFactory,
+ TimezoneInterface $localeDate,
+ Processor $indexProcessor
+ ) {
+ $this->stockConfiguration = $stockConfiguration;
+ $this->stockStateProvider = $stockStateProvider;
+ $this->resource = $resource;
+ $this->stockItemFactory = $stockItemFactory;
+ $this->stockItemCollectionFactory = $stockItemCollectionFactory;
+ $this->productFactory = $productFactory;
+ $this->queryBuilderFactory = $queryBuilderFactory;
+ $this->mapperFactory = $mapperFactory;
+ $this->mapperFactory = $mapperFactory;
+ $this->localeDate = $localeDate;
+ $this->indexProcessor = $indexProcessor;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function save(\Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem)
+ {
+ try {
+ /** @var \Magento\Catalog\Model\Product $product */
+ $product = $this->productFactory->create();
+ $product->load($stockItem->getProductId());
+ if (!$product->getId()) {
+ return $stockItem;
+ }
+ $typeId = $product->getTypeId() ?: $product->getTypeInstance()->getTypeId();
+ $isQty = $this->stockConfiguration->isQty($typeId);
+ if ($isQty) {
+ $isInStock = $this->stockStateProvider->verifyStock($stockItem);
+ if ($stockItem->getManageStock() && !$isInStock) {
+ $stockItem->setIsInStock(false)->setStockStatusChangedAutomaticallyFlag(true);
+ }
+ // if qty is below notify qty, update the low stock date to today date otherwise set null
+ $stockItem->setLowStockDate(null);
+ if ($this->stockStateProvider->verifyNotification($stockItem)) {
+ $stockItem->setLowStockDate(
+ $this->localeDate->date(null, null, null, false)
+ ->toString(\Magento\Framework\Stdlib\DateTime::DATETIME_INTERNAL_FORMAT)
+ );
+ }
+ $stockItem->setStockStatusChangedAuto(0);
+ if ($stockItem->hasStockStatusChangedAutomaticallyFlag()) {
+ $stockItem->setStockStatusChangedAuto((int)$stockItem->getStockStatusChangedAutomaticallyFlag());
+ }
+ } else {
+ $stockItem->setQty(0);
+ }
+
+ $stockItem->setWebsiteId($stockItem->getWebsiteId());
+ $stockItem->setStockId($stockItem->getStockId());
+
+ $this->resource->save($stockItem);
+
+ $this->indexProcessor->reindexRow($stockItem->getProductId());
+ } catch (\Exception $exception) {
+ throw new CouldNotSaveException($exception->getMessage());
+ }
+ return $stockItem;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function get($stockItemId)
+ {
+ $stockItem = $this->stockItemFactory->create();
+ $this->resource->load($stockItem, $stockItemId);
+ if (!$stockItem->getId()) {
+ throw new NoSuchEntityException(sprintf('Stock Item with id "%s" does not exist.', $stockItemId));
+ }
+ return $stockItem;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function getList(\Magento\CatalogInventory\Api\StockItemCriteriaInterface $criteria)
+ {
+ $queryBuilder = $this->queryBuilderFactory->create();
+ $queryBuilder->setCriteria($criteria);
+ $queryBuilder->setResource($this->resource);
+ $query = $queryBuilder->create();
+ $collection = $this->stockItemCollectionFactory->create(['query' => $query]);
+ return $collection;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function delete(StockItemInterface $stockItem)
+ {
+ try {
+ $this->resource->delete($stockItem);
+ } catch (\Exception $exception) {
+ throw new CouldNotDeleteException($exception->getMessage());
+ }
+ return true;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function deleteById($id)
+ {
+ try {
+ $stockItem = $this->get($id);
+ $this->delete($stockItem);
+ } catch (\Exception $exception) {
+ throw new CouldNotDeleteException($exception->getMessage());
+ }
+ return true;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Stock/StockRepository.php b/app/code/Magento/CatalogInventory/Model/Stock/StockRepository.php
new file mode 100644
index 0000000000000000000000000000000000000000..133b153958ee4ec467afb501f259c37a7992664e
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Stock/StockRepository.php
@@ -0,0 +1,163 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Stock;
+
+use Magento\CatalogInventory\Api\Data\StockInterface;
+use Magento\CatalogInventory\Api\StockRepositoryInterface;
+use Magento\CatalogInventory\Api\Data\StockCollectionInterfaceFactory;
+use Magento\CatalogInventory\Model\Resource\Stock as StockResource;
+use Magento\CatalogInventory\Model\StockFactory;
+use Magento\Framework\DB\QueryBuilderFactory;
+use Magento\Framework\DB\MapperFactory;
+use Magento\Framework\Exception\CouldNotSaveException;
+use Magento\Framework\Exception\NoSuchEntityException;
+use Magento\Framework\Exception\CouldNotDeleteException;
+
+/**
+ * Class StockRepository
+ * @api
+ */
+class StockRepository implements StockRepositoryInterface
+{
+ /**
+ * @var StockResource
+ */
+ protected $resource;
+
+ /**
+ * @var StockFactory
+ */
+ protected $stockFactory;
+
+ /**
+ * @var StockCollectionInterfaceFactory
+ */
+ protected $stockCollectionFactory;
+
+ /**
+ * @var QueryBuilderFactory
+ */
+ protected $queryBuilderFactory;
+
+ /**
+ * @var MapperFactory
+ */
+ protected $mapperFactory;
+
+ /**
+ * @param StockResource $resource
+ * @param StockFactory $stockFactory
+ * @param StockCollectionInterfaceFactory $collectionFactory
+ * @param QueryBuilderFactory $queryBuilderFactory
+ * @param MapperFactory $mapperFactory
+ */
+ public function __construct(
+ StockResource $resource,
+ StockFactory $stockFactory,
+ StockCollectionInterfaceFactory $collectionFactory,
+ QueryBuilderFactory $queryBuilderFactory,
+ MapperFactory $mapperFactory
+ ) {
+ $this->resource = $resource;
+ $this->stockFactory = $stockFactory;
+ $this->stockCollectionFactory = $collectionFactory;
+ $this->queryBuilderFactory = $queryBuilderFactory;
+ $this->mapperFactory = $mapperFactory;
+ }
+
+ /**
+ * @param StockInterface $stock
+ * @return StockInterface
+ * @throws CouldNotSaveException
+ */
+ public function save(StockInterface $stock)
+ {
+ try {
+ $this->resource->save($stock);
+ } catch (\Exception $exception) {
+ throw new CouldNotSaveException($exception->getMessage());
+ }
+ return $stock;
+ }
+
+ /**
+ * @param string $stockId
+ * @return StockInterface|\Magento\CatalogInventory\Model\Stock
+ * @throws NoSuchEntityException
+ */
+ public function get($stockId)
+ {
+ $stock = $this->stockFactory->create();
+ $this->resource->load($stock, $stockId);
+ if (!$stock->getId()) {
+ throw new NoSuchEntityException(sprintf('Stock with id "%s" does not exist.', $stockId));
+ }
+ return $stock;
+ }
+
+ /**
+ * @param \Magento\CatalogInventory\Api\StockCriteriaInterface $criteria
+ * @return \Magento\CatalogInventory\Api\Data\StockCollectionInterface
+ */
+ public function getList(\Magento\CatalogInventory\Api\StockCriteriaInterface $criteria)
+ {
+ $queryBuilder = $this->queryBuilderFactory->create();
+ $queryBuilder->setCriteria($criteria);
+ $queryBuilder->setResource($this->resource);
+ $query = $queryBuilder->create();
+ $collection = $this->stockCollectionFactory->create(['query' => $query]);
+ return $collection;
+ }
+
+ /**
+ * @param StockInterface $stock
+ * @return bool|true
+ * @throws CouldNotDeleteException
+ */
+ public function delete(StockInterface $stock)
+ {
+ try {
+ $this->resource->delete($stock);
+ } catch (\Exception $exception) {
+ throw new CouldNotDeleteException($exception->getMessage());
+ }
+ return true;
+ }
+
+ /**
+ * @param int $id
+ * @return bool
+ * @throws CouldNotDeleteException
+ */
+ public function deleteById($id)
+ {
+ try {
+ $stock = $this->get($id);
+ $this->delete($stock);
+ } catch (\Exception $exception) {
+ throw new CouldNotDeleteException($exception->getMessage());
+ }
+ return true;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/Stock/StockStatusRepository.php b/app/code/Magento/CatalogInventory/Model/Stock/StockStatusRepository.php
new file mode 100644
index 0000000000000000000000000000000000000000..3ab4b1c835e10754b0bb6bd2ea09e1c20bd583fe
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/Stock/StockStatusRepository.php
@@ -0,0 +1,156 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Stock;
+
+use Magento\CatalogInventory\Api\StockStatusRepositoryInterface;
+use Magento\CatalogInventory\Api\Data\StockStatusInterface;
+use Magento\CatalogInventory\Api\Data\StockStatusCollectionInterfaceFactory;
+use Magento\CatalogInventory\Model\Resource\Stock\Status as StockStatusResource;
+use Magento\Framework\DB\QueryBuilderFactory;
+use Magento\Framework\DB\MapperFactory;
+use Magento\Framework\Exception\CouldNotSaveException;
+use Magento\Framework\Exception\CouldNotDeleteException;
+
+/**
+ * Class StockStatusRepository
+ */
+class StockStatusRepository implements StockStatusRepositoryInterface
+{
+ /**
+ * @var StockStatusResource
+ */
+ protected $resource;
+
+ /**
+ * @var StatusFactory
+ */
+ protected $stockStatusFactory;
+
+ /**
+ * @var StockStatusCollectionInterfaceFactory
+ */
+ protected $stockStatusCollectionFactory;
+
+ /**
+ * @var QueryBuilderFactory
+ */
+ protected $queryBuilderFactory;
+
+ /**
+ * @var MapperFactory
+ */
+ protected $mapperFactory;
+
+ /**
+ * @param StockStatusResource $resource
+ * @param StatusFactory $stockStatusFactory
+ * @param StockStatusCollectionInterfaceFactory $collectionFactory
+ * @param QueryBuilderFactory $queryBuilderFactory
+ * @param MapperFactory $mapperFactory
+ */
+ public function __construct(
+ StockStatusResource $resource,
+ StatusFactory $stockStatusFactory,
+ StockStatusCollectionInterfaceFactory $collectionFactory,
+ QueryBuilderFactory $queryBuilderFactory,
+ MapperFactory $mapperFactory
+ ) {
+ $this->resource = $resource;
+ $this->stockStatusFactory = $stockStatusFactory;
+ $this->stockStatusCollectionFactory = $collectionFactory;
+ $this->queryBuilderFactory = $queryBuilderFactory;
+ $this->mapperFactory = $mapperFactory;
+ }
+
+ /**
+ * @param StockStatusInterface $stockStatus
+ * @return StockStatusInterface
+ * @throws CouldNotSaveException
+ */
+ public function save(StockStatusInterface $stockStatus)
+ {
+ try {
+ $this->resource->save($stockStatus);
+ } catch (\Exception $exception) {
+ throw new CouldNotSaveException($exception->getMessage());
+ }
+ return $stockStatus;
+ }
+
+ /**
+ * @param string $stockStatusId
+ * @return StockStatusInterface|Status
+ */
+ public function get($stockStatusId)
+ {
+ $stockStatus = $this->stockStatusFactory->create();
+ $this->resource->load($stockStatus, $stockStatusId);
+ return $stockStatus;
+ }
+
+ /**
+ * @param \Magento\CatalogInventory\Api\StockStatusCriteriaInterface $criteria
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusCollectionInterface
+ */
+ public function getList(\Magento\CatalogInventory\Api\StockStatusCriteriaInterface $criteria)
+ {
+ $queryBuilder = $this->queryBuilderFactory->create();
+ $queryBuilder->setCriteria($criteria);
+ $queryBuilder->setResource($this->resource);
+ $query = $queryBuilder->create();
+ $collection = $this->stockStatusCollectionFactory->create(['query' => $query]);
+ return $collection;
+ }
+
+ /**
+ * @param StockStatusInterface $stockStatus
+ * @return bool|true
+ * @throws CouldNotDeleteException
+ */
+ public function delete(StockStatusInterface $stockStatus)
+ {
+ try {
+ $this->resource->delete($stockStatus);
+ } catch (\Exception $exception) {
+ throw new CouldNotDeleteException($exception->getMessage());
+ }
+ return true;
+ }
+
+ /**
+ * @param int $id
+ * @return bool
+ * @throws CouldNotDeleteException
+ */
+ public function deleteById($id)
+ {
+ try {
+ $stockStatus = $this->get($id);
+ $this->delete($stockStatus);
+ } catch (\Exception $exception) {
+ throw new CouldNotDeleteException($exception->getMessage());
+ }
+ return true;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/StockIndex.php b/app/code/Magento/CatalogInventory/Model/StockIndex.php
new file mode 100644
index 0000000000000000000000000000000000000000..5024da6076b5b67d08f4d90f4c76e720917f8ec2
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/StockIndex.php
@@ -0,0 +1,328 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model;
+
+use Magento\CatalogInventory\Api\StockIndexInterface;
+use Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface;
+use Magento\Catalog\Model\ProductFactory;
+use Magento\Catalog\Model\Product\Website as ProductWebsite;
+use Magento\Catalog\Model\Product\Type as ProductType;
+
+/**
+ * Class StockIndex
+ * @package Magento\CatalogInventory\Model
+ * @api
+ * @spi
+ */
+class StockIndex implements StockIndexInterface
+{
+ /**
+ * @var StockRegistryProviderInterface
+ */
+ protected $stockRegistryProvider;
+
+ /**
+ * @var ProductFactory
+ */
+ protected $productFactory;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Resource\Stock\Status
+ */
+ protected $stockStatusResource;
+
+ /**
+ * @var ProductType
+ */
+ protected $productType;
+
+ /**
+ * Retrieve website models
+ *
+ * @var array
+ */
+ protected $websites;
+
+ /**
+ * Product Type Instances cache
+ *
+ * @var array
+ */
+ protected $productTypes = [];
+
+ /**
+ * @param StockRegistryProviderInterface $stockRegistryProvider
+ * @param ProductFactory $productFactory
+ * @param ProductWebsite $productWebsite
+ * @param ProductType $productType
+ */
+ public function __construct(
+ StockRegistryProviderInterface $stockRegistryProvider,
+ ProductFactory $productFactory,
+ ProductWebsite $productWebsite,
+ ProductType $productType
+ ) {
+ $this->stockRegistryProvider = $stockRegistryProvider;
+ $this->productFactory = $productFactory;
+ $this->productWebsite = $productWebsite;
+ $this->productType = $productType;
+ }
+
+ /**
+ * Rebuild stock index of the given website
+ *
+ * @param int $productId
+ * @param int $websiteId
+ * @return true
+ */
+ public function rebuild($productId = null, $websiteId = null)
+ {
+ if ($productId !== null) {
+ $this->updateProductStockStatus($productId, $websiteId);
+ } else {
+ $lastProductId = 0;
+ while (true) {
+ /** @var \Magento\CatalogInventory\Model\Resource\Stock\Status $resource */
+ $resource = $this->getStockStatusResource();
+ $productCollection = $resource->getProductCollection($lastProductId);
+ if (!$productCollection) {
+ break;
+ }
+ foreach ($productCollection as $productId => $productType) {
+ $lastProductId = $productId;
+ $this->updateProductStockStatus($productId, $websiteId);
+ }
+ }
+ }
+ return true;
+ }
+
+ /**
+ * Update product status from stock item
+ *
+ * @param int $productId
+ * @param int $websiteId
+ * @return void
+ */
+ public function updateProductStockStatus($productId, $websiteId)
+ {
+ $productType = $this->getProductType($productId);
+ $item = $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+
+ $status = \Magento\CatalogInventory\Model\Stock\Status::STATUS_IN_STOCK;
+ $qty = 0;
+ if ($item->getId()) {
+ $status = $item->getIsInStock();
+ $qty = $item->getQty();
+ }
+ $this->processChildren($productId, $productType, $websiteId, $qty, $status);
+ $this->processParents($productId, $websiteId);
+ }
+
+ /**
+ * Process children stock status
+ *
+ * @param int $productId
+ * @param string $productType
+ * @param int $websiteId
+ * @param int $qty
+ * @param int $status
+ * @return $this
+ */
+ protected function processChildren(
+ $productId,
+ $productType,
+ $websiteId,
+ $qty = 0,
+ $status = \Magento\CatalogInventory\Model\Stock\Status::STATUS_IN_STOCK
+ ) {
+ if ($status == \Magento\CatalogInventory\Model\Stock\Status::STATUS_OUT_OF_STOCK) {
+ $this->getStockStatusResource()->saveProductStatus($productId, $status, $qty, $websiteId);
+ return;
+ }
+
+ $statuses = [];
+ $websites = $this->getWebsites($websiteId);
+
+ foreach (array_keys($websites) as $websiteId) {
+ /* @var $website \Magento\Store\Model\Website */
+ $statuses[$websiteId] = $status;
+ }
+
+ $typeInstance = $this->getProductTypeInstance($productType);
+ if (!$typeInstance) {
+ return;
+ }
+
+ $requiredChildrenIds = $typeInstance->getChildrenIds($productId, true);
+ if ($requiredChildrenIds) {
+ $childrenIds = array();
+ foreach ($requiredChildrenIds as $groupedChildrenIds) {
+ $childrenIds = array_merge($childrenIds, $groupedChildrenIds);
+ }
+ $childrenWebsites = $this->productWebsite->getWebsites($childrenIds);
+ foreach ($websites as $websiteId => $storeId) {
+ $childrenStatus = $this->getStockStatusResource()->getProductStatus($childrenIds, $storeId);
+ $childrenStock = $this->getStockStatusResource()->getProductsStockStatuses($childrenIds, $websiteId);
+ $websiteStatus = $statuses[$websiteId];
+ foreach ($requiredChildrenIds as $groupedChildrenIds) {
+ $optionStatus = false;
+ foreach ($groupedChildrenIds as $childId) {
+ if (isset($childrenStatus[$childId])
+ && isset($childrenWebsites[$childId])
+ && in_array($websiteId, $childrenWebsites[$childId])
+ && $childrenStatus[$childId] == \Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_ENABLED
+ && isset($childrenStock[$childId])
+ && $childrenStock[$childId] == \Magento\CatalogInventory\Model\Stock\Status::STATUS_IN_STOCK
+ ) {
+ $optionStatus = true;
+ }
+ }
+ $websiteStatus = $websiteStatus && $optionStatus;
+ }
+ $statuses[$websiteId] = (int)$websiteStatus;
+ }
+ }
+ foreach ($statuses as $websiteId => $websiteStatus) {
+ $this->getStockStatusResource()->saveProductStatus($productId, $websiteStatus, $qty, $websiteId);
+ }
+ }
+
+ /**
+ * Retrieve website models
+ *
+ * @param int|null $websiteId
+ * @return array
+ * @deprecated
+ * TODO move to \Magento\Store\Api\WebsiteList
+ */
+ protected function getWebsites($websiteId = null)
+ {
+ if (is_null($this->websites)) {
+ /** @var \Magento\CatalogInventory\Model\Resource\Stock\Status $resource */
+ $resource = $this->getStockStatusResource();
+ $this->websites = $resource->getWebsiteStores();
+ }
+ $websites = $this->websites;
+ if (!is_null($websiteId) && isset($this->websites[$websiteId])) {
+ $websites = array($websiteId => $this->websites[$websiteId]);
+ }
+ return $websites;
+ }
+
+ /**
+ * Process Parents by child
+ *
+ * @param int $productId
+ * @param int $websiteId
+ * @return $this
+ */
+ protected function processParents($productId, $websiteId)
+ {
+ $parentIds = array();
+ foreach ($this->getProductTypeInstances() as $typeInstance) {
+ /* @var $typeInstance AbstractType */
+ $parentIds = array_merge($parentIds, $typeInstance->getParentIdsByChild($productId));
+ }
+
+ if (!$parentIds) {
+ return $this;
+ }
+
+ $productTypes = $this->getProductType($parentIds);
+ foreach ($parentIds as $parentId) {
+ $parentType = isset($productTypes[$parentId]) ? $productTypes[$parentId] : null;
+ $item = $this->stockRegistryProvider->getStockItem($parentId, $websiteId);
+ $status = \Magento\CatalogInventory\Model\Stock\Status::STATUS_IN_STOCK;
+ $qty = 0;
+ if ($item->getId()) {
+ $status = $item->getIsInStock();
+ $qty = $item->getQty();
+ }
+ $this->processChildren($parentId, $parentType, $websiteId, $qty, $status);
+ }
+ }
+
+ /**
+ * Get Product type
+ *
+ * @param int $productId
+ * @return array|string
+ * @deprecated
+ */
+ protected function getProductType($productId)
+ {
+ $product = $this->productFactory->create();
+ $product->load($productId);
+ return $product->getTypeId();
+ }
+
+ /**
+ * Retrieve Product Type Instances
+ * as key - type code, value - instance model
+ *
+ * @return array
+ * @deprecated
+ */
+ protected function getProductTypeInstances()
+ {
+ if (empty($this->productTypes)) {
+ $productEmulator = new \Magento\Framework\Object();
+ foreach (array_keys($this->productType->getTypes()) as $typeId) {
+ $productEmulator->setTypeId($typeId);
+ $this->productTypes[$typeId] = $this->productType->factory($productEmulator);
+ }
+ }
+ return $this->productTypes;
+ }
+
+ /**
+ * Retrieve Product Type Instance By Product Type
+ *
+ * @param string $productType
+ * @return ProductType\AbstractType|bool
+ * @deprecated
+ */
+ protected function getProductTypeInstance($productType)
+ {
+ $types = $this->getProductTypeInstances();
+ if (isset($types[$productType])) {
+ return $types[$productType];
+ }
+ return false;
+ }
+
+ /**
+ * @return \Magento\CatalogInventory\Model\Resource\Stock\Status
+ */
+ protected function getStockStatusResource()
+ {
+ if (empty($this->stockStatusResource)) {
+ $this->stockStatusResource = \Magento\Framework\App\ObjectManager::getInstance()->get(
+ 'Magento\CatalogInventory\Model\Resource\Stock\Status'
+ );
+ }
+ return $this->stockStatusResource;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/StockManagement.php b/app/code/Magento/CatalogInventory/Model/StockManagement.php
new file mode 100644
index 0000000000000000000000000000000000000000..7c2429bbf2ce8b16a5116fe210123df46e4aed2b
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/StockManagement.php
@@ -0,0 +1,213 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model;
+
+use Magento\CatalogInventory\Api\StockManagementInterface;
+use Magento\CatalogInventory\Api\Data\StockItemInterface;
+use Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface;
+use Magento\CatalogInventory\Api\StockConfigurationInterface;
+use Magento\Catalog\Model\ProductFactory;
+
+/**
+ * Class StockManagement
+ * @package Magento\CatalogInventory\Model
+ * @api
+ * @spi
+ */
+class StockManagement implements StockManagementInterface
+{
+ /**
+ * @var StockRegistryProviderInterface
+ */
+ protected $stockRegistryProvider;
+
+ /**
+ * @var StockState
+ */
+ protected $stockState;
+
+ /**
+ * @var StockConfigurationInterface
+ */
+ protected $stockConfiguration;
+
+ /**
+ * @var ProductFactory
+ */
+ protected $productFactory;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Resource\Stock
+ */
+ protected $resource;
+
+ /**
+ * @param StockRegistryProviderInterface $stockRegistryProvider
+ * @param StockState $stockState
+ * @param StockConfigurationInterface $stockConfiguration
+ * @param ProductFactory $productFactory
+ */
+ public function __construct(
+ StockRegistryProviderInterface $stockRegistryProvider,
+ StockState $stockState,
+ StockConfigurationInterface $stockConfiguration,
+ ProductFactory $productFactory
+ ) {
+ $this->stockRegistryProvider = $stockRegistryProvider;
+ $this->stockState = $stockState;
+ $this->stockConfiguration = $stockConfiguration;
+ $this->productFactory = $productFactory;
+ }
+
+ /**
+ * Subtract product qtys from stock.
+ * Return array of items that require full save
+ *
+ * @param array $items
+ * @param int $websiteId
+ * @return StockItemInterface[]
+ * @throws \Magento\Framework\Model\Exception
+ */
+ public function registerProductsSale($items, $websiteId = null)
+ {
+ //if (!$websiteId) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ //}
+ $this->getResource()->beginTransaction();
+ $lockedItems = $this->getResource()->lockProductsStock(array_keys($items), $websiteId);
+ $fullSaveItems = $registeredItems = [];
+ foreach ($lockedItems as $lockedItemRecord) {
+ $productId = $lockedItemRecord['product_id'];
+ /** @var StockItemInterface $stockItem */
+ $orderedQty = $items[$productId];
+ $stockItem = $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ $canSubtractQty = $stockItem->getId() && $this->canSubtractQty($stockItem);
+ if (!$canSubtractQty || !$this->stockConfiguration->isQty($this->getProductType($productId))) {
+ continue;
+ }
+ if (!$stockItem->hasAdminArea()
+ && !$this->stockState->checkQty($productId, $orderedQty, $stockItem->getWebsiteId())
+ ) {
+ $this->getResource()->commit();
+ throw new \Magento\Framework\Model\Exception(
+ __('Not all of your products are available in the requested quantity.')
+ );
+ }
+ if ($this->canSubtractQty($stockItem)) {
+ $stockItem->setQty($stockItem->getQty() - $orderedQty);
+ }
+ $registeredItems[$productId] = $orderedQty;
+ if (!$this->stockState->verifyStock($productId, $stockItem->getWebsiteId())
+ || $this->stockState->verifyNotification(
+ $productId,
+ $stockItem->getWebsiteId()
+ )
+ ) {
+ $fullSaveItems[] = $stockItem;
+ }
+ }
+ $this->getResource()->correctItemsQty($registeredItems, $websiteId, '-');
+ $this->getResource()->commit();
+ return $fullSaveItems;
+ }
+
+ /**
+ * @param array $items
+ * @param int $websiteId
+ * @return void
+ */
+ public function revertProductsSale(array $items, $websiteId = null)
+ {
+ //if (!$websiteId) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ //}
+ $this->getResource()->correctItemsQty($items, $websiteId, '+');
+ }
+
+ /**
+ * Get back to stock (when order is canceled or whatever else)
+ *
+ * @param int $productId
+ * @param int|float $qty
+ * @param int $websiteId
+ * @return void
+ */
+ public function backItemQty($productId, $qty, $websiteId = null)
+ {
+ //if (!$websiteId) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ //}
+ $stockItem = $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ if ($stockItem->getId() && $this->stockConfiguration->isQty($this->getProductType($productId))) {
+ if ($this->canSubtractQty($stockItem)) {
+ $stockItem->setQty($stockItem->getQty() + $qty);
+ }
+ if ($this->stockConfiguration->getCanBackInStock($stockItem->getStoreId()) && $stockItem->getQty()
+ > $stockItem->getMinQty()
+ ) {
+ $stockItem->setIsInStock(true);
+ $stockItem->setStockStatusChangedAutomaticallyFlag(true);
+ }
+ $stockItem->save();
+ }
+ }
+
+ /**
+ * Get Product type
+ *
+ * @param int $productId
+ * @return string
+ * @deprecated
+ */
+ protected function getProductType($productId)
+ {
+ $product = $this->productFactory->create();
+ $product->load($productId);
+ return $product->getTypeId();
+ }
+
+ /**
+ * @return \Magento\CatalogInventory\Model\Resource\Stock
+ */
+ protected function getResource()
+ {
+ if (empty($this->resource)) {
+ $this->resource = \Magento\Framework\App\ObjectManager::getInstance()->get(
+ 'Magento\CatalogInventory\Model\Resource\Stock'
+ );
+ }
+ return $this->resource;
+ }
+
+ /**
+ * Check if is possible subtract value from item qty
+ *
+ * @param StockItemInterface $stockItem
+ * @return bool
+ */
+ protected function canSubtractQty(StockItemInterface $stockItem)
+ {
+ return $stockItem->getManageStock() && $this->stockConfiguration->canSubtractQty();
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/StockRegistry.php b/app/code/Magento/CatalogInventory/Model/StockRegistry.php
new file mode 100644
index 0000000000000000000000000000000000000000..48fd273e3a2b20181121e4703f6f2aa8308b58ef
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/StockRegistry.php
@@ -0,0 +1,233 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model;
+
+use Magento\CatalogInventory\Api\StockConfigurationInterface;
+use Magento\CatalogInventory\Api\StockItemRepositoryInterface;
+use Magento\CatalogInventory\Api\StockRegistryInterface;
+use Magento\CatalogInventory\Api\StockItemCriteriaInterfaceFactory;
+use Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface;
+use Magento\CatalogInventory\Api\Data\StockItemInterface;
+use Magento\Catalog\Model\ProductFactory;
+
+/**
+ * Class StockRegistry
+ * @package Magento\CatalogInventory\Model
+ * @api
+ */
+class StockRegistry implements StockRegistryInterface
+{
+ /**
+ * @var StockConfigurationInterface
+ */
+ protected $stockConfiguration;
+
+ /**
+ * @var StockRegistryProviderInterface
+ */
+ protected $stockRegistryProvider;
+
+ /**
+ * @var ProductFactory
+ */
+ protected $productFactory;
+
+ /**
+ * @var StockItemRepositoryInterface
+ */
+ protected $stockItemRepository;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockItemCriteriaInterfaceFactory
+ */
+ protected $criteriaFactory;
+
+ /**
+ * @param StockConfigurationInterface $stockConfiguration
+ * @param StockRegistryProviderInterface $stockRegistryProvider
+ * @param StockItemRepositoryInterface $stockItemRepository
+ * @param StockItemCriteriaInterfaceFactory $criteriaFactory
+ * @param ProductFactory $productFactory
+ */
+ public function __construct(
+ StockConfigurationInterface $stockConfiguration,
+ StockRegistryProviderInterface $stockRegistryProvider,
+ StockItemRepositoryInterface $stockItemRepository,
+ StockItemCriteriaInterfaceFactory $criteriaFactory,
+ ProductFactory $productFactory
+ ) {
+ $this->stockConfiguration = $stockConfiguration;
+ $this->stockRegistryProvider = $stockRegistryProvider;
+ $this->stockItemRepository = $stockItemRepository;
+ $this->criteriaFactory = $criteriaFactory;
+ $this->productFactory = $productFactory;
+ }
+
+ /**
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockInterface
+ */
+ public function getStock($websiteId = null)
+ {
+ //if (!$websiteId) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ //}
+ return $this->stockRegistryProvider->getStock($websiteId);
+ }
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
+ */
+ public function getStockItem($productId, $websiteId = null)
+ {
+ //if (!$websiteId) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ //}
+ return $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ }
+
+ /**
+ * @param string $productSku
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
+ * @throws \Magento\Framework\Exception\NoSuchEntityException
+ */
+ public function getStockItemBySku($productSku, $websiteId = null)
+ {
+ //if (!$websiteId) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ //}
+ $productId = $this->resolveProductId($productSku);
+ return $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ }
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusInterface
+ */
+ public function getStockStatus($productId, $websiteId = null)
+ {
+ //if (!$websiteId) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ //}
+ return $this->stockRegistryProvider->getStockStatus($productId, $websiteId);
+ }
+
+ /**
+ * @param string $productSku
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusInterface
+ * @throws \Magento\Framework\Exception\NoSuchEntityException
+ */
+ public function getStockStatusBySku($productSku, $websiteId = null)
+ {
+ //if (!$websiteId) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ //}
+ $productId = $this->resolveProductId($productSku);
+ return $this->getStockStatus($productId, $websiteId);
+ }
+
+ /**
+ * Retrieve Product stock status
+ * @param int $productId
+ * @param int $websiteId
+ * @return int
+ */
+ public function getProductStockStatus($productId, $websiteId = null)
+ {
+ //if (!$websiteId) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ //}
+ $stockStatus = $this->getStockStatus($productId, $websiteId);
+ return $stockStatus->getStockStatus();
+ }
+
+ /**
+ * @param string $productSku
+ * @param null $websiteId
+ * @return int
+ * @throws \Magento\Framework\Exception\NoSuchEntityException
+ */
+ public function getProductStockStatusBySku($productSku, $websiteId = null)
+ {
+ //if (!$websiteId) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ //}
+ $productId = $this->resolveProductId($productSku);
+ return $this->getProductStockStatus($productId, $websiteId);
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function getLowStockItems($websiteId, $qty, $currentPage = 1, $pageSize = 0)
+ {
+ $criteria = $this->criteriaFactory->create();
+ $criteria->setLimit($currentPage, $pageSize);
+ $criteria->setWebsiteFilter($websiteId);
+ $criteria->setQtyFilter('>=', $qty);
+ $criteria->addField('qty');
+ return $this->stockItemRepository->getList($criteria);
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function updateStockItemBySku($productSku, \Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem)
+ {
+ $productId = $this->resolveProductId($productSku);
+ $websiteId = $stockItem->getWebsiteId() ?: null;
+ $origStockItem = $this->getStockItem($productId, $websiteId);
+ $data = $stockItem->getData();
+ if ($origStockItem->getId()) {
+ if (isset($data['item_id'])) {
+ unset($data['item_id']);
+ }
+ }
+ $origStockItem->addData($data);
+ $origStockItem->setProductId($productId);
+ return $this->stockItemRepository->save($origStockItem)->getId();
+ }
+
+ /**
+ * @param string $productSku
+ * @return int
+ * @throws \Magento\Framework\Exception\NoSuchEntityException
+ */
+ protected function resolveProductId($productSku)
+ {
+ $product = $this->productFactory->create();
+ $productId = $product->getIdBySku($productSku);
+ if (!$productId) {
+ throw new \Magento\Framework\Exception\NoSuchEntityException(
+ "Product with SKU \"{$productSku}\" does not exist"
+ );
+ }
+ return $productId;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/StockRegistryProvider.php b/app/code/Magento/CatalogInventory/Model/StockRegistryProvider.php
new file mode 100644
index 0000000000000000000000000000000000000000..53bf3401951c8ae2af93dcc343cfa5ea26c5a305
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/StockRegistryProvider.php
@@ -0,0 +1,204 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model;
+
+use Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface;
+use Magento\CatalogInventory\Api\StockRepositoryInterface;
+use Magento\CatalogInventory\Api\StockItemRepositoryInterface;
+use Magento\CatalogInventory\Api\StockStatusRepositoryInterface;
+use Magento\CatalogInventory\Api\Data\StockInterfaceFactory;
+use Magento\CatalogInventory\Api\Data\StockItemInterfaceFactory;
+use Magento\CatalogInventory\Api\Data\StockStatusInterfaceFactory;
+use Magento\CatalogInventory\Api\StockCriteriaInterfaceFactory;
+use Magento\CatalogInventory\Api\StockItemCriteriaInterfaceFactory;
+use Magento\CatalogInventory\Api\StockStatusCriteriaInterfaceFactory;
+use Magento\Framework\StoreManagerInterface;
+
+/**
+ * Class StockRegistryProvider
+ * @package Magento\CatalogInventory\Model
+ * @spi
+ */
+class StockRegistryProvider implements StockRegistryProviderInterface
+{
+ /**
+ * @var StockRepositoryInterface
+ */
+ protected $stockRepository;
+
+ /**
+ * @var StockInterfaceFactory
+ */
+ protected $stockFactory;
+
+ /**
+ * @var StockItemRepositoryInterface
+ */
+ protected $stockItemRepository;
+
+ /**
+ * @var StockItemInterfaceFactory
+ */
+ protected $stockItemFactory;
+
+ /**
+ * @var StockStatusRepositoryInterface
+ */
+ protected $stockStatusRepository;
+
+ /**
+ * @var StockStatusInterfaceFactory
+ */
+ protected $stockStatusFactory;
+
+ /**
+ * @var StockCriteriaInterfaceFactory
+ */
+ protected $stockCriteriaFactory;
+
+ /**
+ * @var StockItemCriteriaInterfaceFactory
+ */
+ protected $stockItemCriteriaFactory;
+
+ /**
+ * @var StockStatusCriteriaInterfaceFactory
+ */
+ protected $stockStatusCriteriaFactory;
+
+ /**
+ * @var array
+ */
+ protected $stocks = [];
+
+ /**
+ * @var array
+ */
+ protected $stockItems = [];
+
+ /**
+ * @var array
+ */
+ protected $stockStatuses = [];
+
+ /**
+ * @param StockRepositoryInterface $stockRepository
+ * @param StockInterfaceFactory $stockFactory
+ * @param StockItemRepositoryInterface $stockItemRepository
+ * @param StockItemInterfaceFactory $stockItemFactory
+ * @param StockStatusRepositoryInterface $stockStatusRepository
+ * @param StockStatusInterfaceFactory $stockStatusFactory
+ * @param StockCriteriaInterfaceFactory $stockCriteriaFactory
+ * @param StockItemCriteriaInterfaceFactory $stockItemCriteriaFactory
+ * @param StockStatusCriteriaInterfaceFactory $stockStatusCriteriaFactory
+ */
+ public function __construct(
+ StockRepositoryInterface $stockRepository,
+ StockInterfaceFactory $stockFactory,
+ StockItemRepositoryInterface $stockItemRepository,
+ StockItemInterfaceFactory $stockItemFactory,
+ StockStatusRepositoryInterface $stockStatusRepository,
+ StockStatusInterfaceFactory $stockStatusFactory,
+ StockCriteriaInterfaceFactory $stockCriteriaFactory,
+ StockItemCriteriaInterfaceFactory $stockItemCriteriaFactory,
+ StockStatusCriteriaInterfaceFactory $stockStatusCriteriaFactory
+ ) {
+ $this->stockRepository = $stockRepository;
+ $this->stockFactory = $stockFactory;
+ $this->stockItemRepository = $stockItemRepository;
+ $this->stockItemFactory = $stockItemFactory;
+ $this->stockStatusRepository = $stockStatusRepository;
+ $this->stockStatusFactory = $stockStatusFactory;
+
+ $this->stockCriteriaFactory = $stockCriteriaFactory;
+ $this->stockItemCriteriaFactory = $stockItemCriteriaFactory;
+ $this->stockStatusCriteriaFactory = $stockStatusCriteriaFactory;
+ }
+
+ /**
+ * @param int|null $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockInterface
+ */
+ public function getStock($websiteId)
+ {
+ if (!isset($this->stocks[$websiteId])) {
+ $criteria = $this->stockCriteriaFactory->create();
+ $criteria->setWebsiteFilter($websiteId);
+ $collection = $this->stockRepository->getList($criteria);
+ $stock = current($collection->getItems());
+ if ($stock && $stock->getId()) {
+ $this->stocks[$websiteId] = $stock;
+ } else {
+ return $this->stockFactory->create();
+ }
+ }
+ return $this->stocks[$websiteId];
+ }
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
+ */
+ public function getStockItem($productId, $websiteId)
+ {
+ $key = $websiteId . '/' . $productId;
+ if (!isset($this->stockItems[$key])) {
+ $criteria = $this->stockItemCriteriaFactory->create();
+ $criteria->setProductsFilter($productId);
+ $criteria->setWebsiteFilter($websiteId);
+ $collection = $this->stockItemRepository->getList($criteria);
+ $stockItem = current($collection->getItems());
+ if ($stockItem && $stockItem->getId()) {
+ $this->stockItems[$key] = $stockItem;
+ } else {
+ return $this->stockItemFactory->create();
+ }
+ }
+ return $this->stockItems[$key];
+ }
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return \Magento\CatalogInventory\Api\Data\StockStatusInterface
+ */
+ public function getStockStatus($productId, $websiteId)
+ {
+ $key = $websiteId . '/' . $productId;
+ if (!isset($this->stockStatuses[$key])) {
+ $criteria = $this->stockStatusCriteriaFactory->create();
+ $criteria->setProductsFilter($productId);
+ $criteria->setWebsiteFilter($websiteId);
+ $collection = $this->stockStatusRepository->getList($criteria);
+ $stockStatus = current($collection->getItems());
+ if ($stockStatus && $stockStatus->getProductId()) {
+ $this->stockStatuses[$key] = $stockStatus;
+ } else {
+ return $this->stockStatusFactory->create();
+ }
+ }
+ return $this->stockStatuses[$key];
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/StockState.php b/app/code/Magento/CatalogInventory/Model/StockState.php
new file mode 100644
index 0000000000000000000000000000000000000000..f56910ab00f19ad43b37709efee8a4c8aca698b8
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/StockState.php
@@ -0,0 +1,179 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model;
+
+use Magento\CatalogInventory\Api\StockConfigurationInterface;
+use Magento\CatalogInventory\Api\StockStateInterface;
+use Magento\CatalogInventory\Model\Spi\StockStateProviderInterface;
+use Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface;
+
+/**
+ * Interface StockState
+ * @package Magento\CatalogInventory\Model
+ * @api
+ */
+class StockState implements StockStateInterface
+{
+ /**
+ * @var StockStateProviderInterface
+ */
+ protected $stockStateProvider;
+
+ /**
+ * @var StockRegistryProviderInterface
+ */
+ protected $stockRegistryProvider;
+
+ /**
+ * @var StockConfigurationInterface
+ */
+ protected $stockConfiguration;
+
+ /**
+ * @param StockStateProviderInterface $stockStateProvider
+ * @param StockRegistryProviderInterface $stockRegistryProvider
+ * @param StockConfigurationInterface $stockConfiguration
+ */
+ public function __construct(
+ StockStateProviderInterface $stockStateProvider,
+ StockRegistryProviderInterface $stockRegistryProvider,
+ StockConfigurationInterface $stockConfiguration
+ ) {
+ $this->stockStateProvider = $stockStateProvider;
+ $this->stockRegistryProvider = $stockRegistryProvider;
+ $this->stockConfiguration = $stockConfiguration;
+ }
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return bool
+ */
+ public function verifyStock($productId, $websiteId = null)
+ {
+ if (is_null($websiteId)) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ }
+ $stockItem = $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ return $this->stockStateProvider->verifyStock($stockItem);
+ }
+
+ /**
+ * @param int $productId
+ * @param int $websiteId
+ * @return bool
+ */
+ public function verifyNotification($productId, $websiteId = null)
+ {
+ if (is_null($websiteId)) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ }
+ $stockItem = $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ return $this->stockStateProvider->verifyNotification($stockItem);
+ }
+
+ /**
+ * Check quantity
+ *
+ * @param int $productId
+ * @param int|float $qty
+ * @param int $websiteId
+ * @exception \Magento\Framework\Model\Exception
+ * @return bool
+ */
+ public function checkQty($productId, $qty, $websiteId = null)
+ {
+ if (is_null($websiteId)) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ }
+ $stockItem = $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ return $this->stockStateProvider->checkQty($stockItem, $qty);
+ }
+
+ /**
+ * Returns suggested qty that satisfies qty increments and minQty/maxQty/minSaleQty/maxSaleQty conditions
+ * or original qty if such value does not exist
+ *
+ * @param int $productId
+ * @param int|float $qty
+ * @param int $websiteId
+ * @return int|float
+ */
+ public function suggestQty($productId, $qty, $websiteId = null)
+ {
+ if (is_null($websiteId)) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ }
+ $stockItem = $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ return $this->stockStateProvider->suggestQty($stockItem, $qty);
+ }
+
+ /**
+ * Retrieve stock qty whether product is composite or no
+ *
+ * @param int $productId
+ * @param int $websiteId
+ * @return float
+ */
+ public function getStockQty($productId, $websiteId = null)
+ {
+ if (is_null($websiteId)) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ }
+ $stockItem = $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ return $this->stockStateProvider->getStockQty($stockItem);
+ }
+
+ /**
+ * @param int $productId
+ * @param int|float $qty
+ * @param int $websiteId
+ * @return \Magento\Framework\Object
+ */
+ public function checkQtyIncrements($productId, $qty, $websiteId = null)
+ {
+ if (is_null($websiteId)) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ }
+ $stockItem = $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ return $this->stockStateProvider->checkQtyIncrements($stockItem, $qty);
+ }
+
+ /**
+ * @param int $productId
+ * @param int|float $itemQty
+ * @param int|float $qtyToCheck
+ * @param int|float $origQty
+ * @param int $websiteId
+ * @return \Magento\Framework\Object
+ */
+ public function checkQuoteItemQty($productId, $itemQty, $qtyToCheck, $origQty, $websiteId = null)
+ {
+ if (is_null($websiteId)) {
+ $websiteId = $this->stockConfiguration->getDefaultWebsiteId();
+ }
+ $stockItem = $this->stockRegistryProvider->getStockItem($productId, $websiteId);
+ return $this->stockStateProvider->checkQuoteItemQty($stockItem, $itemQty, $qtyToCheck, $origQty);
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/StockStateProvider.php b/app/code/Magento/CatalogInventory/Model/StockStateProvider.php
new file mode 100644
index 0000000000000000000000000000000000000000..d30fa383a012342541bfc2567e5276858eb77839
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/Model/StockStateProvider.php
@@ -0,0 +1,390 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model;
+
+use Magento\CatalogInventory\Model\Spi\StockStateProviderInterface;
+
+use Magento\CatalogInventory\Api\Data\StockItemInterface;
+use Magento\Framework\Object\Factory as ObjectFactory;
+use Magento\Framework\Math\Division as MathDivision;
+use Magento\Framework\Locale\FormatInterface;
+use Magento\Catalog\Model\ProductFactory;
+
+/**
+ * Interface StockStateProvider
+ * @package Magento\CatalogInventory\Model
+ * @spi
+ */
+class StockStateProvider implements StockStateProviderInterface
+{
+ /**
+ * @var MathDivision
+ */
+ protected $mathDivision;
+
+ /**
+ * @var FormatInterface
+ */
+ protected $localeFormat;
+
+ /**
+ * @var ObjectFactory
+ */
+ protected $objectFactory;
+
+ /**
+ * @var ProductFactory
+ */
+ protected $productFactory;
+
+ /**
+ * @var bool
+ */
+ protected $qtyCheckApplicable;
+
+ /**
+ * @param MathDivision $mathDivision
+ * @param FormatInterface $localeFormat
+ * @param ObjectFactory $objectFactory
+ * @param ProductFactory $productFactory
+ * @param bool $qtyCheckApplicable
+ */
+ public function __construct(
+ MathDivision $mathDivision,
+ FormatInterface $localeFormat,
+ ObjectFactory $objectFactory,
+ ProductFactory $productFactory,
+ $qtyCheckApplicable = true
+ ) {
+ $this->mathDivision = $mathDivision;
+ $this->localeFormat = $localeFormat;
+ $this->objectFactory = $objectFactory;
+ $this->productFactory = $productFactory;
+ $this->qtyCheckApplicable = $qtyCheckApplicable;
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @return bool
+ */
+ public function verifyStock(StockItemInterface $stockItem)
+ {
+ if ($stockItem->getQty() !== null
+ && $stockItem->getBackorders() == StockItemInterface::BACKORDERS_NO
+ && $stockItem->getQty() <= $stockItem->getMinQty()
+ ) {
+ return false;
+ }
+ return true;
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @return bool
+ */
+ public function verifyNotification(StockItemInterface $stockItem)
+ {
+ return (float)$stockItem->getQty() < $stockItem->getNotifyStockQty();
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param int|float $qty
+ * @param int|float $summaryQty
+ * @param int|float $origQty
+ * @return \Magento\Framework\Object
+ */
+ public function checkQuoteItemQty(StockItemInterface $stockItem, $qty, $summaryQty, $origQty = 0)
+ {
+ $result = $this->objectFactory->create();
+ $result->setHasError(false);
+
+ $qty = $this->getNumber($qty);
+
+ /**
+ * Check quantity type
+ */
+ $result->setItemIsQtyDecimal($stockItem->getIsQtyDecimal());
+ if (!$stockItem->getIsQtyDecimal()) {
+ $result->setHasQtyOptionUpdate(true);
+ $qty = intval($qty);
+ /**
+ * Adding stock data to quote item
+ */
+ $result->setItemQty($qty);
+ $qty = $this->getNumber($qty);
+ $origQty = intval($origQty);
+ $result->setOrigQty($origQty);
+ }
+
+ if ($stockItem->getMinSaleQty() && $qty < $stockItem->getMinSaleQty()) {
+ $result->setHasError(true)
+ ->setMessage(__('The fewest you may purchase is %1.', $stockItem->getMinSaleQty() * 1))
+ ->setErrorCode('qty_min')
+ ->setQuoteMessage(__('Please correct the quantity for some products.'))
+ ->setQuoteMessageIndex('qty');
+ return $result;
+ }
+
+ if ($stockItem->getMaxSaleQty() && $qty > $stockItem->getMaxSaleQty()) {
+ $result->setHasError(true)
+ ->setMessage(__('The most you may purchase is %1.', $stockItem->getMaxSaleQty() * 1))
+ ->setErrorCode('qty_max')
+ ->setQuoteMessage(__('Please correct the quantity for some products.'))
+ ->setQuoteMessageIndex('qty');
+ return $result;
+ }
+
+ $result->addData($this->checkQtyIncrements($stockItem, $qty)->getData());
+ if ($result->getHasError()) {
+ return $result;
+ }
+
+ if (!$stockItem->getManageStock()) {
+ return $result;
+ }
+
+ if (!$stockItem->getIsInStock()) {
+ $result->setHasError(true)
+ ->setMessage(__('This product is out of stock.'))
+ ->setQuoteMessage(__('Some of the products are currently out of stock.'))
+ ->setQuoteMessageIndex('stock');
+ $result->setItemUseOldQty(true);
+ return $result;
+ }
+
+ if (!$this->checkQty($stockItem, $summaryQty) || !$this->checkQty($stockItem, $qty)) {
+ $message = __('We don\'t have as many "%1" as you requested.', $stockItem->getProductName());
+ $result->setHasError(true)->setMessage($message)->setQuoteMessage($message)->setQuoteMessageIndex('qty');
+ return $result;
+ } else {
+ if ($stockItem->getQty() - $summaryQty < 0) {
+ if ($stockItem->getProductName()) {
+ if ($stockItem->getIsChildItem()) {
+ $backOrderQty = $stockItem->getQty() > 0 ? ($summaryQty - $stockItem->getQty()) * 1 : $qty * 1;
+ if ($backOrderQty > $qty) {
+ $backOrderQty = $qty;
+ }
+
+ $result->setItemBackorders($backOrderQty);
+ } else {
+ $orderedItems = (int)$stockItem->getOrderedItems();
+
+ // Available item qty in stock excluding item qty in other quotes
+ $qtyAvailable = ($stockItem->getQty() - ($summaryQty - $qty)) * 1;
+ if ($qtyAvailable > 0) {
+ $backOrderQty = $qty * 1 - $qtyAvailable;
+ } else {
+ $backOrderQty = $qty * 1;
+ }
+
+ if ($backOrderQty > 0) {
+ $result->setItemBackorders($backOrderQty);
+ }
+ $stockItem->setOrderedItems($orderedItems + $qty);
+ }
+
+ if ($stockItem->getBackorders() == \Magento\CatalogInventory\Model\Stock::BACKORDERS_YES_NOTIFY) {
+ if (!$stockItem->getIsChildItem()) {
+ $result->setMessage(
+ __(
+ 'We don\'t have as many "%1" as you requested, but we\'ll back order the remaining %2.',
+ $stockItem->getProductName(),
+ $backOrderQty * 1
+ )
+ );
+ } else {
+ $result->setMessage(
+ __(
+ 'We don\'t have "%1" in the requested quantity, so we\'ll back order the remaining %2.',
+ $stockItem->getProductName(),
+ $backOrderQty * 1
+ )
+ );
+ }
+ } elseif ($stockItem->getShowDefaultNotificationMessage()) {
+ $result->setMessage(
+ __('We don\'t have as many "%1" as you requested.', $stockItem->getProductName())
+ );
+ }
+ }
+ } else {
+ if (!$stockItem->getIsChildItem()) {
+ $stockItem->setOrderedItems($qty + (int)$stockItem->getOrderedItems());
+ }
+ }
+ }
+ return $result;
+ }
+
+ /**
+ * Check quantity
+ *
+ * @param StockItemInterface $stockItem
+ * @param int|float $qty
+ * @exception \Magento\Framework\Model\Exception
+ * @return bool
+ */
+ public function checkQty(StockItemInterface $stockItem, $qty)
+ {
+ if (!$this->qtyCheckApplicable) {
+ return true;
+ }
+ if (!$stockItem->getManageStock()) {
+ return true;
+ }
+ if ($stockItem->getQty() - $stockItem->getMinQty() - $qty < 0) {
+ switch ($stockItem->getBackorders()) {
+ case \Magento\CatalogInventory\Model\Stock::BACKORDERS_YES_NONOTIFY:
+ case \Magento\CatalogInventory\Model\Stock::BACKORDERS_YES_NOTIFY:
+ break;
+ default:
+ return false;
+ }
+ }
+ return true;
+ }
+
+ /**
+ * Returns suggested qty that satisfies qty increments and minQty/maxQty/minSaleQty/maxSaleQty conditions
+ * or original qty if such value does not exist
+ *
+ * @param StockItemInterface $stockItem
+ * @param int|float $qty
+ * @return int|float
+ */
+ public function suggestQty(StockItemInterface $stockItem, $qty)
+ {
+ // We do not manage stock
+ if ($qty <= 0 || !$stockItem->getManageStock()) {
+ return $qty;
+ }
+
+ $qtyIncrements = (int)$stockItem->getQtyIncrements();
+ // Currently only integer increments supported
+ if ($qtyIncrements < 2) {
+ return $qty;
+ }
+
+ $minQty = max($stockItem->getMinSaleQty(), $qtyIncrements);
+ $divisibleMin = ceil($minQty / $qtyIncrements) * $qtyIncrements;
+
+ $maxQty = min($stockItem->getQty() - $stockItem->getMinQty(), $stockItem->getMaxSaleQty());
+ $divisibleMax = floor($maxQty / $qtyIncrements) * $qtyIncrements;
+
+ if ($qty < $minQty || $qty > $maxQty || $divisibleMin > $divisibleMax) {
+ // Do not perform rounding for qty that does not satisfy min/max conditions to not confuse customer
+ return $qty;
+ }
+
+ // Suggest value closest to given qty
+ $closestDivisibleLeft = floor($qty / $qtyIncrements) * $qtyIncrements;
+ $closestDivisibleRight = $closestDivisibleLeft + $qtyIncrements;
+ $acceptableLeft = min(max($divisibleMin, $closestDivisibleLeft), $divisibleMax);
+ $acceptableRight = max(min($divisibleMax, $closestDivisibleRight), $divisibleMin);
+ return abs($acceptableLeft - $qty) < abs($acceptableRight - $qty) ? $acceptableLeft : $acceptableRight;
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param float|int $qty
+ * @return \Magento\Framework\Object
+ */
+ public function checkQtyIncrements(StockItemInterface $stockItem, $qty)
+ {
+ $result = new \Magento\Framework\Object();
+ if ($stockItem->getSuppressCheckQtyIncrements()) {
+ return $result;
+ }
+
+ $qtyIncrements = $stockItem->getQtyIncrements();
+
+ if ($qtyIncrements && $this->mathDivision->getExactDivision($qty, $qtyIncrements) != 0) {
+ $result->setHasError(true)
+ ->setQuoteMessage(__('Please correct the quantity for some products.'))
+ ->setErrorCode('qty_increments')
+ ->setQuoteMessageIndex('qty');
+ if ($stockItem->getIsChildItem()) {
+ $result->setMessage(
+ __('You can buy %1 only in increments of %2.', $stockItem->getProductName(), $qtyIncrements * 1)
+ );
+ } else {
+ $result->setMessage(__('You can buy this product only in increments of %1.', $qtyIncrements * 1));
+ }
+ }
+ return $result;
+ }
+
+ /**
+ * Retrieve stock qty whether product is composite or no
+ *
+ * @param StockItemInterface $stockItem
+ * @return float
+ */
+ public function getStockQty(StockItemInterface $stockItem)
+ {
+ if (!$stockItem->hasStockQty()) {
+ $stockItem->setStockQty(0);
+ $product = $this->productFactory->create();
+ $product->load($stockItem->getProductId());
+ // prevent possible recursive loop
+ if (!$product->isComposite()) {
+ $stockQty = $stockItem->getQty();
+ } else {
+ $stockQty = null;
+ $productsByGroups = $product->getTypeInstance()->getProductsToPurchaseByReqGroups($product);
+ foreach ($productsByGroups as $productsInGroup) {
+ $qty = 0;
+ foreach ($productsInGroup as $childProduct) {
+ $qty += $this->getStockQty($stockItem);
+ }
+ if (null === $stockQty || $qty < $stockQty) {
+ $stockQty = $qty;
+ }
+ }
+ }
+ $stockQty = (float)$stockQty;
+ if ($stockQty < 0 || !$stockItem->getManageStock() || !$stockItem->getIsInStock()
+ || !$product->isSaleable()
+ ) {
+ $stockQty = 0;
+ }
+ $stockItem->setStockQty($stockQty);
+ }
+ return (float)$stockItem->getData('stock_qty');
+ }
+
+ /**
+ * @param string|float|int|null $qty
+ * @return float|null
+ */
+ protected function getNumber($qty)
+ {
+ if (!is_numeric($qty)) {
+ $qty = $this->localeFormat->getNumber($qty);
+ return $qty;
+ }
+ return $qty;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/Data/StockItem.php b/app/code/Magento/CatalogInventory/Service/V1/Data/StockItem.php
deleted file mode 100644
index 6cfb76d491b89a1e1dc72fcb6db71113b1387c72..0000000000000000000000000000000000000000
--- a/app/code/Magento/CatalogInventory/Service/V1/Data/StockItem.php
+++ /dev/null
@@ -1,288 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Service\V1\Data;
-
-use Magento\Framework\Api\AbstractExtensibleObject;
-
-/**
- * Stock item data object
- *
- * @codeCoverageIgnore
- */
-class StockItem extends AbstractExtensibleObject
-{
- /**#@+
- * Stock item object data keys
- */
- const ITEM_ID = 'item_id';
-
- const PRODUCT_ID = 'product_id';
-
- const STOCK_ID = 'stock_id';
-
- const QTY = 'qty';
-
- const MIN_QTY = 'min_qty';
-
- const USE_CONFIG_MIN_QTY = 'use_config_min_qty';
-
- const IS_QTY_DECIMAL = 'is_qty_decimal';
-
- const BACKORDERS = 'backorders';
-
- const USE_CONFIG_BACKORDERS = 'use_config_backorders';
-
- const MIN_SALE_QTY = 'min_sale_qty';
-
- const USE_CONFIG_MIN_SALE_QTY = 'use_config_min_sale_qty';
-
- const MAX_SALE_QTY = 'max_sale_qty';
-
- const USE_CONFIG_MAX_SALE_QTY = 'use_config_max_sale_qty';
-
- const IS_IN_STOCK = 'is_in_stock';
-
- const LOW_STOCK_DATE = 'low_stock_date';
-
- const NOTIFY_STOCK_QTY = 'notify_stock_qty';
-
- const USE_CONFIG_NOTIFY_STOCK_QTY = 'use_config_notify_stock_qty';
-
- const MANAGE_STOCK = 'manage_stock';
-
- const USE_CONFIG_MANAGE_STOCK = 'use_config_manage_stock';
-
- const STOCK_STATUS_CHANGED_AUTO = 'stock_status_changed_auto';
-
- const USE_CONFIG_QTY_INCREMENTS = 'use_config_qty_increments';
-
- const QTY_INCREMENTS = 'qty_increments';
-
- const USE_CONFIG_ENABLE_QTY_INC = 'use_config_enable_qty_inc';
-
- const ENABLE_QTY_INCREMENTS = 'enable_qty_increments';
-
- const IS_DECIMAL_DIVIDED = 'is_decimal_divided';
- /**#@-*/
-
- /**
- * @return int
- */
- public function getItemId()
- {
- return $this->_get(self::ITEM_ID);
- }
-
- /**
- * @return int
- */
- public function getProductId()
- {
- return $this->_get(self::PRODUCT_ID);
- }
-
- /**
- * @return int
- */
- public function getStockId()
- {
- return $this->_get(self::STOCK_ID);
- }
-
- /**
- * @return float
- */
- public function getQty()
- {
- return $this->_get(self::QTY);
- }
-
- /**
- * @return float
- */
- public function getMinQty()
- {
- return $this->_get(self::MIN_QTY);
- }
-
- /**
- * @return bool
- */
- public function isUseConfigMinQty()
- {
- return $this->_get(self::USE_CONFIG_MIN_QTY);
- }
-
- /**
- * @return bool
- */
- public function getIsQtyDecimal()
- {
- return $this->_get(self::IS_QTY_DECIMAL);
- }
-
- /**
- * @return bool
- */
- public function isBackorders()
- {
- return $this->_get(self::BACKORDERS);
- }
-
- /**
- * @return bool
- */
- public function isUseConfigBackorders()
- {
- return $this->_get(self::USE_CONFIG_BACKORDERS);
- }
-
- /**
- * @return float
- */
- public function getMinSaleQty()
- {
- return $this->_get(self::MIN_SALE_QTY);
- }
-
- /**
- * @return bool
- */
- public function isUseConfigMinSaleQty()
- {
- return $this->_get(self::USE_CONFIG_MIN_SALE_QTY);
- }
-
- /**
- * @return float
- */
- public function getMaxSaleQty()
- {
- return $this->_get(self::MAX_SALE_QTY);
- }
-
- /**
- * @return bool
- */
- public function isUseConfigMaxSaleQty()
- {
- return $this->_get(self::USE_CONFIG_MAX_SALE_QTY);
- }
-
- /**
- * @return bool
- */
- public function getIsInStock()
- {
- return $this->_get(self::IS_IN_STOCK);
- }
-
- /**
- * @return string
- */
- public function getLowStockDate()
- {
- return $this->_get(self::LOW_STOCK_DATE);
- }
-
- /**
- * @return float
- */
- public function getNotifyStockQty()
- {
- return $this->_get(self::NOTIFY_STOCK_QTY);
- }
-
- /**
- * @return bool
- */
- public function isUseConfigNotifyStockQty()
- {
- return $this->_get(self::USE_CONFIG_NOTIFY_STOCK_QTY);
- }
-
- /**
- * @return bool
- */
- public function isManageStock()
- {
- return $this->_get(self::MANAGE_STOCK);
- }
-
- /**
- * @return bool
- */
- public function isUseConfigManageStock()
- {
- return $this->_get(self::USE_CONFIG_MANAGE_STOCK);
- }
-
- /**
- * @return bool
- */
- public function isStockStatusChangedAuto()
- {
- return $this->_get(self::STOCK_STATUS_CHANGED_AUTO);
- }
-
- /**
- * @return bool
- */
- public function isUseConfigQtyIncrements()
- {
- return $this->_get(self::USE_CONFIG_QTY_INCREMENTS);
- }
-
- /**
- * @return float
- */
- public function getQtyIncrements()
- {
- return $this->_get(self::QTY_INCREMENTS);
- }
-
- /**
- * @return bool
- */
- public function isUseConfigEnableQtyInc()
- {
- return $this->_get(self::USE_CONFIG_ENABLE_QTY_INC);
- }
-
- /**
- * @return bool
- */
- public function isEnableQtyIncrements()
- {
- return $this->_get(self::ENABLE_QTY_INCREMENTS);
- }
-
- /**
- * @return bool
- */
- public function getIsDecimalDivided()
- {
- return $this->_get(self::IS_DECIMAL_DIVIDED);
- }
-}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/Data/StockItemDetails.php b/app/code/Magento/CatalogInventory/Service/V1/Data/StockItemDetails.php
deleted file mode 100644
index cf43022b544bb289754f4847c94ff484673faeec..0000000000000000000000000000000000000000
--- a/app/code/Magento/CatalogInventory/Service/V1/Data/StockItemDetails.php
+++ /dev/null
@@ -1,178 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Service\V1\Data;
-
-use Magento\Framework\Api\AbstractExtensibleObject;
-
-/**
- * Stock item details data object
- *
- * @codeCoverageIgnore
- */
-class StockItemDetails extends AbstractExtensibleObject
-{
- /**#@+
- * Stock item object data keys
- */
- const QTY = 'qty';
-
- const MIN_QTY = 'min_qty';
-
- const IS_QTY_DECIMAL = 'is_qty_decimal';
-
- const BACKORDERS = 'backorders';
-
- const MIN_SALE_QTY = 'min_sale_qty';
-
- const MAX_SALE_QTY = 'max_sale_qty';
-
- const IS_IN_STOCK = 'is_in_stock';
-
- const LOW_STOCK_DATE = 'low_stock_date';
-
- const NOTIFY_STOCK_QTY = 'notify_stock_qty';
-
- const MANAGE_STOCK = 'manage_stock';
-
- const STOCK_STATUS_CHANGED_AUTO = 'stock_status_changed_auto';
-
- const QTY_INCREMENTS = 'qty_increments';
-
- const ENABLE_QTY_INCREMENTS = 'enable_qty_increments';
-
- const IS_DECIMAL_DIVIDED = 'is_decimal_divided';
- /**#@-*/
-
- /**
- * @return float|null
- */
- public function getQty()
- {
- return $this->_get(self::QTY);
- }
-
- /**
- * @return float|null
- */
- public function getMinQty()
- {
- return $this->_get(self::MIN_QTY);
- }
-
- /**
- * @return bool|null
- */
- public function getIsQtyDecimal()
- {
- return $this->_get(self::IS_QTY_DECIMAL);
- }
-
- /**
- * @return bool|null
- */
- public function isBackorders()
- {
- return $this->_get(self::BACKORDERS);
- }
-
- /**
- * @return float|null
- */
- public function getMinSaleQty()
- {
- return $this->_get(self::MIN_SALE_QTY);
- }
-
- /**
- * @return float|null
- */
- public function getMaxSaleQty()
- {
- return $this->_get(self::MAX_SALE_QTY);
- }
-
- /**
- * @return bool|null
- */
- public function getIsInStock()
- {
- return $this->_get(self::IS_IN_STOCK);
- }
-
- /**
- * @return string|null
- */
- public function getLowStockDate()
- {
- return $this->_get(self::LOW_STOCK_DATE);
- }
-
- /**
- * @return float|null
- */
- public function getNotifyStockQty()
- {
- return $this->_get(self::NOTIFY_STOCK_QTY);
- }
-
- /**
- * @return bool|null
- */
- public function isManageStock()
- {
- return $this->_get(self::MANAGE_STOCK);
- }
-
- /**
- * @return bool|null
- */
- public function isStockStatusChangedAuto()
- {
- return $this->_get(self::STOCK_STATUS_CHANGED_AUTO);
- }
-
- /**
- * @return float|null
- */
- public function getQtyIncrements()
- {
- return $this->_get(self::QTY_INCREMENTS);
- }
-
- /**
- * @return bool|null
- */
- public function isEnableQtyIncrements()
- {
- return $this->_get(self::ENABLE_QTY_INCREMENTS);
- }
-
- /**
- * @return bool|null
- */
- public function getIsDecimalDivided()
- {
- return $this->_get(self::IS_DECIMAL_DIVIDED);
- }
-}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/Data/StockItemDetailsBuilder.php b/app/code/Magento/CatalogInventory/Service/V1/Data/StockItemDetailsBuilder.php
deleted file mode 100644
index e0f449637a0818218d83e0de7c6691ebb284c939..0000000000000000000000000000000000000000
--- a/app/code/Magento/CatalogInventory/Service/V1/Data/StockItemDetailsBuilder.php
+++ /dev/null
@@ -1,160 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Service\V1\Data;
-
-use Magento\Framework\Api\ExtensibleObjectBuilder;
-
-/**
- * Stock item details data builder
- *
- * @codeCoverageIgnore
- */
-class StockItemDetailsBuilder extends ExtensibleObjectBuilder
-{
- /**
- * @param int $qty
- * @return $this
- */
- public function setQty($qty)
- {
- return $this->_set(StockItemDetails::QTY, $qty);
- }
-
- /**
- * @param int $minQty
- * @return $this
- */
- public function setMinQty($minQty)
- {
- return $this->_set(StockItemDetails::MIN_QTY, $minQty);
- }
-
- /**
- * @param bool $isQtyDecimal
- * @return $this
- */
- public function setIsQtyDecimal($isQtyDecimal)
- {
- return $this->_set(StockItemDetails::IS_QTY_DECIMAL, $isQtyDecimal);
- }
-
- /**
- * @param bool $backorders
- * @return $this
- */
- public function setBackorders($backorders)
- {
- return $this->_set(StockItemDetails::BACKORDERS, $backorders);
- }
-
- /**
- * @param float $minSaleQty
- * @return $this
- */
- public function setMinSaleQty($minSaleQty)
- {
- return $this->_set(StockItemDetails::MIN_SALE_QTY, $minSaleQty);
- }
-
- /**
- * @param float $maxSaleQty
- * @return $this
- */
- public function setMaxSaleQty($maxSaleQty)
- {
- return $this->_set(StockItemDetails::MAX_SALE_QTY, $maxSaleQty);
- }
-
- /**
- * @param bool $isInStock
- * @return $this
- */
- public function setIsInStock($isInStock)
- {
- return $this->_set(StockItemDetails::IS_IN_STOCK, $isInStock);
- }
-
- /**
- * @param string $lowStockDate
- * @return $this
- */
- public function setLowStockDate($lowStockDate)
- {
- return $this->_set(StockItemDetails::LOW_STOCK_DATE, $lowStockDate);
- }
-
- /**
- * @param float $notifyStockQty
- * @return $this
- */
- public function setNotifyStockQty($notifyStockQty)
- {
- return $this->_set(StockItemDetails::NOTIFY_STOCK_QTY, $notifyStockQty);
- }
-
- /**
- * @param bool $manageStock
- * @return $this
- */
- public function setManageStock($manageStock)
- {
- return $this->_set(StockItemDetails::MANAGE_STOCK, $manageStock);
- }
-
- /**
- * @param bool $stockStatusChangedAuto
- * @return $this
- */
- public function setStockStatusChangedAuto($stockStatusChangedAuto)
- {
- return $this->_set(StockItemDetails::STOCK_STATUS_CHANGED_AUTO, $stockStatusChangedAuto);
- }
-
- /**
- * @param float $qtyIncrements
- * @return $this
- */
- public function setQtyIncrements($qtyIncrements)
- {
- return $this->_set(StockItemDetails::QTY_INCREMENTS, $qtyIncrements);
- }
-
- /**
- * @param bool $enableQtyIncrements
- * @return $this
- */
- public function setEnableQtyIncrements($enableQtyIncrements)
- {
- return $this->_set(StockItemDetails::ENABLE_QTY_INCREMENTS, $enableQtyIncrements);
- }
-
- /**
- * @param bool $isDecimalDivided
- * @return $this
- */
- public function setIsDecimalDivided($isDecimalDivided)
- {
- return $this->_set(StockItemDetails::IS_DECIMAL_DIVIDED, $isDecimalDivided);
- }
-}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/StockItemService.php b/app/code/Magento/CatalogInventory/Service/V1/StockItemService.php
deleted file mode 100644
index 33e1d8f1f6af5940e2340e0759106b05da773ef2..0000000000000000000000000000000000000000
--- a/app/code/Magento/CatalogInventory/Service/V1/StockItemService.php
+++ /dev/null
@@ -1,306 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Service\V1;
-
-use Magento\Catalog\Service\V1\Product\ProductLoader;
-use Magento\Framework\Exception\NoSuchEntityException;
-
-/**
- * Stock item service
- */
-class StockItemService implements StockItemServiceInterface
-{
- /**
- * @var \Magento\CatalogInventory\Model\Stock\ItemRegistry
- */
- protected $stockItemRegistry;
-
- /**
- * @var \Magento\Catalog\Model\ProductTypes\ConfigInterface
- */
- protected $config;
-
- /**
- * All product types registry in scope of quantity availability
- *
- * @var array
- */
- protected $isQtyTypeIds;
-
- /**
- * @var Data\StockItemBuilder
- */
- protected $stockItemBuilder;
-
- /**
- * @var ProductLoader
- */
- protected $productLoader;
-
- /**
- * @param \Magento\CatalogInventory\Model\Stock\ItemRegistry $stockItemRegistry
- * @param \Magento\Catalog\Model\ProductTypes\ConfigInterface $config
- * @param Data\StockItemBuilder $stockItemBuilder
- * @param ProductLoader $productLoader
- */
- public function __construct(
- \Magento\CatalogInventory\Model\Stock\ItemRegistry $stockItemRegistry,
- \Magento\Catalog\Model\ProductTypes\ConfigInterface $config,
- Data\StockItemBuilder $stockItemBuilder,
- ProductLoader $productLoader
- ) {
- $this->stockItemRegistry = $stockItemRegistry;
- $this->config = $config;
- $this->stockItemBuilder = $stockItemBuilder;
- $this->productLoader = $productLoader;
- }
-
- /**
- * @param int $productId
- * @return \Magento\CatalogInventory\Service\V1\Data\StockItem
- */
- public function getStockItem($productId)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- $this->stockItemBuilder->populateWithArray($stockItem->getData());
- return $this->stockItemBuilder->create();
- }
-
- /**
- * @param string $productSku
- * @return \Magento\CatalogInventory\Service\V1\Data\StockItem
- * @throws \Magento\Framework\Exception\NoSuchEntityException
- */
- public function getStockItemBySku($productSku)
- {
- $product = $this->productLoader->load($productSku);
- if (!$product->getId()) {
- throw new NoSuchEntityException("Product with SKU \"{$productSku}\" does not exist");
- }
- $stockItem = $this->stockItemRegistry->retrieve($product->getId());
- $this->stockItemBuilder->populateWithArray($stockItem->getData());
- return $this->stockItemBuilder->create();
- }
-
- /**
- * @param \Magento\CatalogInventory\Service\V1\Data\StockItem $stockItemDo
- * @return $this
- */
- public function saveStockItem($stockItemDo)
- {
- $stockItem = $this->stockItemRegistry->retrieve($stockItemDo->getProductId());
- $stockItem->setData($stockItemDo->__toArray());
- $stockItem->save();
- $this->stockItemRegistry->erase($stockItemDo->getProductId());
- return $this;
- }
-
- /**
- * @param string $productSku
- * @param \Magento\CatalogInventory\Service\V1\Data\StockItemDetails $stockItemDetailsDo
- * @return string
- * @throws \Magento\Framework\Exception\NoSuchEntityException
- */
- public function saveStockItemBySku($productSku, Data\StockItemDetails $stockItemDetailsDo)
- {
- $product = $this->productLoader->load($productSku);
- if (!$product->getId()) {
- throw new NoSuchEntityException("Product with SKU \"{$productSku}\" does not exist");
- }
-
- $stockItem = $this->stockItemRegistry->retrieve($product->getId());
- $stockItemDo = $this->stockItemBuilder->populateWithArray($stockItem->getData())->create();
- $dataToSave = $this->stockItemBuilder->mergeDataObjectWithArray(
- $stockItemDo,
- $stockItemDetailsDo->__toArray()
- )->create()->__toArray();
- return $stockItem->setData($dataToSave)->save()->getId();
- }
-
- /**
- * @param int $productId
- * @return int
- */
- public function getMinSaleQty($productId)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->getMinSaleQty();
- }
-
- /**
- * @param int $productId
- * @return int
- */
- public function getMaxSaleQty($productId)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->getMaxSaleQty();
- }
-
- /**
- * @param int $productId
- * @return bool
- */
- public function getEnableQtyIncrements($productId)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->getEnableQtyIncrements();
- }
-
- /**
- * @param int $productId
- * @return int
- */
- public function getQtyIncrements($productId)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->getQtyIncrements();
- }
-
- /**
- * @param int $productId
- * @return int
- */
- public function getManageStock($productId)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->getManageStock();
- }
-
- /**
- * @param int $productId
- * @param int $qty
- * @return bool
- */
- public function suggestQty($productId, $qty)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->suggestQty($qty);
- }
-
- /**
- * @param int $productId
- * @param int $qty
- * @param int $summaryQty
- * @param int $origQty
- * @return \Magento\Framework\Object
- */
- public function checkQuoteItemQty($productId, $qty, $summaryQty, $origQty = 0)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->checkQuoteItemQty($qty, $summaryQty, $origQty);
- }
-
- /**
- * @param int $productId
- * @param int|null $qty
- * @return bool
- */
- public function verifyStock($productId, $qty = null)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->verifyStock($qty);
- }
-
- /**
- * @param int $productId
- * @param int|null $qty
- * @return bool
- */
- public function verifyNotification($productId, $qty = null)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->verifyNotification($qty);
- }
-
- /**
- * @param int $productId
- * @return bool
- */
- public function getIsInStock($productId)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->getIsInStock();
- }
-
- /**
- * @param int $productId
- * @return int
- */
- public function getStockQty($productId)
- {
- $stockItem = $this->stockItemRegistry->retrieve($productId);
- return $stockItem->getStockQty();
- }
-
- /**
- * @param int $productTypeId
- * @return bool
- */
- public function isQty($productTypeId)
- {
- $this->getIsQtyTypeIds();
- if (!isset($this->isQtyTypeIds[$productTypeId])) {
- return false;
- }
- return $this->isQtyTypeIds[$productTypeId];
- }
-
- /**
- * @param int|null $filter
- * @return bool|array
- */
- public function getIsQtyTypeIds($filter = null)
- {
- if (null === $this->isQtyTypeIds) {
- $this->isQtyTypeIds = array();
-
- foreach ($this->config->getAll() as $typeId => $typeConfig) {
- $this->isQtyTypeIds[$typeId] = isset($typeConfig['is_qty']) ? $typeConfig['is_qty'] : false;
- }
- }
- if (null === $filter) {
- return $this->isQtyTypeIds;
- }
- $result = $this->isQtyTypeIds;
- foreach ($result as $key => $value) {
- if ($value !== $filter) {
- unset($result[$key]);
- }
- }
- return $result;
- }
-
- /**
- * @param int $stockData
- * @return array
- */
- public function processIsInStock($stockData)
- {
- $stockItem = $this->stockItemRegistry->retrieve($stockData['product_id']);
- $stockItem->setData($stockData);
- $stockItem->processIsInStock();
- return $stockItem->getData();
- }
-}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/StockItemServiceInterface.php b/app/code/Magento/CatalogInventory/Service/V1/StockItemServiceInterface.php
deleted file mode 100644
index fedd973a47b5e91f9983ac06de0b217c6798b8e2..0000000000000000000000000000000000000000
--- a/app/code/Magento/CatalogInventory/Service/V1/StockItemServiceInterface.php
+++ /dev/null
@@ -1,147 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Service\V1;
-
-/**
- * Stock item interface
- */
-interface StockItemServiceInterface
-{
- /**
- * @param int $productId
- * @return \Magento\CatalogInventory\Service\V1\Data\StockItem
- */
- public function getStockItem($productId);
-
- /**
- * @param string $productSku
- * @return \Magento\CatalogInventory\Service\V1\Data\StockItem
- * @throws \Magento\Framework\Exception\NoSuchEntityException
- */
- public function getStockItemBySku($productSku);
-
- /**
- * @param \Magento\CatalogInventory\Service\V1\Data\StockItem $stockItem
- * @return \Magento\CatalogInventory\Service\V1\Data\StockItem
- */
- public function saveStockItem($stockItem);
-
- /**
- * @param string $productSku
- * @param \Magento\CatalogInventory\Service\V1\Data\StockItemDetails $stockItemDetailsDo
- * @return string
- * @throws \Magento\Framework\Exception\NoSuchEntityException
- */
- public function saveStockItemBySku($productSku, Data\StockItemDetails $stockItemDetailsDo);
-
- /**
- * @param int $productId
- * @return int
- */
- public function getMinSaleQty($productId);
-
- /**
- * @param int $productId
- * @return int
- */
- public function getMaxSaleQty($productId);
-
- /**
- * @param int $productId
- * @return bool
- */
- public function getEnableQtyIncrements($productId);
-
- /**
- * @param int $productId
- * @return int
- */
- public function getQtyIncrements($productId);
-
- /**
- * @param int $productId
- * @return int mixed
- */
- public function getManageStock($productId);
-
- /**
- * @param int $productId
- * @param int $qty
- * @return bool
- */
- public function suggestQty($productId, $qty);
-
- /**
- * @param int $productId
- * @param int $qty
- * @param int $summaryQty
- * @param int $origQty
- * @return int
- */
- public function checkQuoteItemQty($productId, $qty, $summaryQty, $origQty = 0);
-
- /**
- * @param int $productId
- * @param int|null $qty
- * @return bool
- */
- public function verifyStock($productId, $qty = null);
-
- /**
- * @param int $productId
- * @param int|null $qty
- * @return bool
- */
- public function verifyNotification($productId, $qty = null);
-
- /**
- * @param int $productId
- * @return bool
- */
- public function getIsInStock($productId);
-
- /**
- * @param int $productId
- * @return int
- */
- public function getStockQty($productId);
-
- /**
- * @param int $productTypeId
- * @return bool
- */
- public function isQty($productTypeId);
-
- /**
- * @param int|null $filter
- * @return bool
- */
- public function getIsQtyTypeIds($filter = null);
-
- /**
- * @param int $stockData
- * @return array
- */
- public function processIsInStock($stockData);
-}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/StockStatusService.php b/app/code/Magento/CatalogInventory/Service/V1/StockStatusService.php
deleted file mode 100644
index c4fbbec8f3cf73b1fb305ccc56fe693c5126d9a1..0000000000000000000000000000000000000000
--- a/app/code/Magento/CatalogInventory/Service/V1/StockStatusService.php
+++ /dev/null
@@ -1,177 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Service\V1;
-
-use Magento\CatalogInventory\Model\Stock;
-use Magento\CatalogInventory\Model\Stock\Status;
-use Magento\Framework\Exception\NoSuchEntityException;
-
-/**
- * Service related to Product Stock Status
- */
-class StockStatusService implements StockStatusServiceInterface
-{
- /**
- * @var Status
- */
- protected $stockStatus;
-
- /**
- * @var \Magento\Store\Model\Resolver\Website
- */
- protected $scopeResolver;
-
- /**
- * @var \Magento\Catalog\Service\V1\Product\ProductLoader
- */
- protected $productLoader;
-
- /**
- * @var StockItemService
- */
- protected $stockItemService;
-
- /**
- * @var Data\StockStatusBuilder
- */
- protected $stockStatusBuilder;
-
- /**
- * @var \Magento\CatalogInventory\Model\Resource\Stock\Status\CollectionFactory
- */
- protected $itemsFactory;
-
- /**
- * @var Data\LowStockResultBuilder
- */
- protected $lowStockResultBuilder;
-
- /**
- * @param Status $stockStatus
- * @param StockItemService $stockItemService
- * @param \Magento\Catalog\Service\V1\Product\ProductLoader $productLoader
- * @param \Magento\Store\Model\Resolver\Website $scopeResolver
- * @param Data\StockStatusBuilder $stockStatusBuilder
- * @param \Magento\CatalogInventory\Model\Resource\Stock\Status\CollectionFactory $itemsFactory
- * @param Data\LowStockResultBuilder $lowStockResultBuilder
- */
- public function __construct(
- Status $stockStatus,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
- \Magento\Catalog\Service\V1\Product\ProductLoader $productLoader,
- \Magento\Store\Model\Resolver\Website $scopeResolver,
- Data\StockStatusBuilder $stockStatusBuilder,
- \Magento\CatalogInventory\Model\Resource\Stock\Status\CollectionFactory $itemsFactory,
- Data\LowStockResultBuilder $lowStockResultBuilder
- ) {
- $this->stockStatus = $stockStatus;
- $this->stockItemService = $stockItemService;
- $this->productLoader = $productLoader;
- $this->scopeResolver = $scopeResolver;
- $this->stockStatusBuilder = $stockStatusBuilder;
- $this->itemsFactory = $itemsFactory;
- $this->lowStockResultBuilder = $lowStockResultBuilder;
- }
-
- /**
- * {@inheritdoc}
- */
- public function getProductStockStatus($productId, $websiteId, $stockId = Stock::DEFAULT_STOCK_ID)
- {
- $stockStatusData = $this->stockStatus->getProductStockStatus([$productId], $websiteId, $stockId);
- $stockStatus = empty($stockStatusData[$productId]) ? null : $stockStatusData[$productId];
-
- return $stockStatus;
- }
-
- /**
- * Assign Stock Status to Product
- *
- * @param \Magento\Catalog\Model\Product $product
- * @param int $stockId
- * @param int $stockStatus
- * @return \Magento\CatalogInventory\Service\V1\StockStatusService
- */
- public function assignProduct(
- \Magento\Catalog\Model\Product $product,
- $stockId = Stock::DEFAULT_STOCK_ID,
- $stockStatus = null
- ) {
- $this->stockStatus->assignProduct($product, $stockId, $stockStatus);
- return $this;
- }
-
- /**
- * {inheritdoc}
- */
- public function getProductStockStatusBySku($sku)
- {
- $product = $this->productLoader->load($sku);
- $productId = $product->getId();
- if (!$productId) {
- throw new NoSuchEntityException("Product with SKU \"{$sku}\" does not exist");
- }
-
- $data = $this->stockStatus->getProductStockStatus(
- [$productId],
- $this->scopeResolver->getScope()->getId()
- );
- $stockStatus = (bool)$data[$productId];
-
- $result = [
- Data\StockStatus::STOCK_STATUS => $stockStatus,
- Data\StockStatus::STOCK_QTY => $this->stockItemService->getStockQty($productId)
- ];
-
- $this->stockStatusBuilder->populateWithArray($result);
-
- return $this->stockStatusBuilder->create();
- }
-
- /**
- * Retrieves a list of SKU's with low inventory qty
- *
- * {@inheritdoc}
- */
- public function getLowStockItems($lowStockCriteria)
- {
- /** @var \Magento\CatalogInventory\Model\Resource\Stock\Status\Collection $itemCollection */
- $itemCollection = $this->itemsFactory->create();
- $itemCollection->addWebsiteFilter($this->scopeResolver->getScope());
- $itemCollection->addQtyFilter($lowStockCriteria->getQty());
- $itemCollection->setCurPage($lowStockCriteria->getCurrentPage());
- $itemCollection->setPageSize($lowStockCriteria->getPageSize());
-
- $countOfItems = $itemCollection->getSize();
- $listOfSku = [];
- foreach ($itemCollection as $item) {
- $listOfSku[] = $item->getSku();
- }
-
- $this->lowStockResultBuilder->setSearchCriteria($lowStockCriteria);
- $this->lowStockResultBuilder->setTotalCount($countOfItems);
- $this->lowStockResultBuilder->setItems($listOfSku);
- return $this->lowStockResultBuilder->create();
- }
-}
diff --git a/app/code/Magento/CatalogInventory/composer.json b/app/code/Magento/CatalogInventory/composer.json
index 44c2b081b7ceb03fcd26657eb051fef45161ed5f..b62da3a8c8dfd253db7f36543f6293b32b97bb88 100644
--- a/app/code/Magento/CatalogInventory/composer.json
+++ b/app/code/Magento/CatalogInventory/composer.json
@@ -3,19 +3,18 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-indexer": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-indexer": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/CatalogInventory/data/cataloginventory_setup/data-upgrade-1.6.0.0.0-1.6.0.0.1.php b/app/code/Magento/CatalogInventory/data/cataloginventory_setup/data-upgrade-1.6.0.0.0-1.6.0.0.1.php
index fa15b4d351f6da3719d25e95324d809c5c84bc16..610985929d447dc9ba5fe27e9b1ad1c0322953f8 100644
--- a/app/code/Magento/CatalogInventory/data/cataloginventory_setup/data-upgrade-1.6.0.0.0-1.6.0.0.1.php
+++ b/app/code/Magento/CatalogInventory/data/cataloginventory_setup/data-upgrade-1.6.0.0.0-1.6.0.0.1.php
@@ -22,10 +22,13 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-/* @var $installer \Magento\Eav\Model\Entity\Setup */
-$installer = $this;
+/* @var $this \Magento\Eav\Model\Entity\Setup */
-$installer->getConnection()->insertForce(
- $installer->getTable('cataloginventory_stock'),
- array('stock_id' => 1, 'stock_name' => 'Default')
+$this->getConnection()->insertForce(
+ $this->getTable('cataloginventory_stock'),
+ array(
+ 'stock_name' => 'Default',
+ 'website_id' => \Magento\CatalogInventory\Model\Configuration::DEFAULT_WEBSITE_ID
+ // TODO iterate available websites
+ )
);
diff --git a/app/code/Magento/CatalogInventory/etc/adminhtml/di.xml b/app/code/Magento/CatalogInventory/etc/adminhtml/di.xml
index a372b8af7220de07d30e5fbdbf8cf6135653782b..6978d62c17f41ff73ab0a1a5ca365198388c4b66 100644
--- a/app/code/Magento/CatalogInventory/etc/adminhtml/di.xml
+++ b/app/code/Magento/CatalogInventory/etc/adminhtml/di.xml
@@ -32,4 +32,9 @@
</argument>
</arguments>
</type>
+ <type name="Magento\CatalogInventory\Model\Spi\StockStateProviderInterface">
+ <arguments>
+ <argument name="qtyCheckApplicable" xsi:type="boolean">false</argument>
+ </arguments>
+ </type>
</config>
diff --git a/app/code/Magento/CatalogInventory/etc/di.xml b/app/code/Magento/CatalogInventory/etc/di.xml
index 3465c991d44069aa1eaa0b3fd6e66f7415999f21..9c5e5c85834b667624e01badbc05a7fb1e8a1443 100644
--- a/app/code/Magento/CatalogInventory/etc/di.xml
+++ b/app/code/Magento/CatalogInventory/etc/di.xml
@@ -24,14 +24,34 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/ObjectManager/etc/config.xsd">
- <preference for="Magento\CatalogInventory\Service\V1\StockStatusServiceInterface" type="Magento\CatalogInventory\Service\V1\StockStatusService" />
- <preference for="Magento\CatalogInventory\Service\V1\StockItemServiceInterface" type="Magento\CatalogInventory\Service\V1\StockItemService" />
+ <preference for="Magento\CatalogInventory\Api\Data\StockInterface" type="Magento\CatalogInventory\Model\Stock" />
+ <preference for="Magento\CatalogInventory\Api\Data\StockItemInterface" type="Magento\CatalogInventory\Model\Stock\Item" />
+ <preference for="Magento\CatalogInventory\Api\Data\StockStatusInterface" type="Magento\CatalogInventory\Model\Stock\Status" />
+
+ <preference for="Magento\CatalogInventory\Api\Data\StockCollectionInterface" type="Magento\CatalogInventory\Model\Resource\Stock\Collection" />
+ <preference for="Magento\CatalogInventory\Api\Data\StockItemCollectionInterface" type="Magento\CatalogInventory\Model\Resource\Stock\Item\Collection" />
+ <preference for="Magento\CatalogInventory\Api\Data\StockStatusCollectionInterface" type="Magento\CatalogInventory\Model\Resource\Stock\Status\Collection" />
+
+ <preference for="Magento\CatalogInventory\Api\StockCriteriaInterface" type="Magento\CatalogInventory\Model\Resource\Stock\StockCriteria" />
+ <preference for="Magento\CatalogInventory\Api\StockItemCriteriaInterface" type="Magento\CatalogInventory\Model\Resource\Stock\Item\StockItemCriteria" />
+ <preference for="Magento\CatalogInventory\Api\StockStatusCriteriaInterface" type="Magento\CatalogInventory\Model\Resource\Stock\Status\StockStatusCriteria" />
+
+ <preference for="Magento\CatalogInventory\Api\StockConfigurationInterface" type="Magento\CatalogInventory\Model\Configuration" />
+ <preference for="Magento\CatalogInventory\Api\StockManagementInterface" type="Magento\CatalogInventory\Model\StockManagement" />
+ <preference for="Magento\CatalogInventory\Api\StockIndexInterface" type="Magento\CatalogInventory\Model\StockIndex" />
+ <preference for="Magento\CatalogInventory\Api\StockRegistryInterface" type="Magento\CatalogInventory\Model\StockRegistry" />
+ <preference for="Magento\CatalogInventory\Api\StockStateInterface" type="Magento\CatalogInventory\Model\StockState" />
+
+ <preference for="Magento\CatalogInventory\Api\StockRepositoryInterface" type="Magento\CatalogInventory\Model\Stock\StockRepository" />
+ <preference for="Magento\CatalogInventory\Api\StockItemRepositoryInterface" type="Magento\CatalogInventory\Model\Stock\StockItemRepository" />
+ <preference for="Magento\CatalogInventory\Api\StockStatusRepositoryInterface" type="Magento\CatalogInventory\Model\Stock\StockStatusRepository" />
+
+ <preference for="Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface" type="Magento\CatalogInventory\Model\StockRegistryProvider" />
+ <preference for="Magento\CatalogInventory\Model\Spi\StockStateProviderInterface" type="Magento\CatalogInventory\Model\StockStateProvider" />
+
<type name="Magento\CatalogInventory\Model\Observer">
<arguments>
<argument name="resourceStock" xsi:type="object">Magento\CatalogInventory\Model\Resource\Stock\Proxy</argument>
- <argument name="stock" xsi:type="object">Magento\CatalogInventory\Model\Stock\Proxy</argument>
- <argument name="stockStatus" xsi:type="object">Magento\CatalogInventory\Model\Stock\Status\Proxy</argument>
- <argument name="catalogInventoryData" xsi:type="object">Magento\CatalogInventory\Helper\Data\Proxy</argument>
</arguments>
</type>
<type name="Magento\Framework\Module\Updater\SetupFactory">
diff --git a/app/code/Magento/CatalogInventory/etc/module.xml b/app/code/Magento/CatalogInventory/etc/module.xml
index e486b82fdf9308314313b8dd6eefa437fac844ad..6c59e980d95208faff93ce9b0147671e63735b60 100644
--- a/app/code/Magento/CatalogInventory/etc/module.xml
+++ b/app/code/Magento/CatalogInventory/etc/module.xml
@@ -24,14 +24,13 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
- <module name="Magento_CatalogInventory" schema_version="1.6.0.0.5" active="true">
+ <module name="Magento_CatalogInventory" schema_version="1.6.0.0.7" active="true">
<sequence>
<module name="Magento_Catalog"/>
</sequence>
<depends>
<module name="Magento_Store"/>
<module name="Magento_Catalog"/>
- <module name="Magento_Core"/>
<module name="Magento_Customer"/>
<module name="Magento_Backend"/>
<module name="Magento_Indexer"/>
diff --git a/app/code/Magento/CatalogInventory/etc/webapi.xml b/app/code/Magento/CatalogInventory/etc/webapi.xml
index 25eef2be1b94688a1cb08bf93ef0c6807ab7d357..820351a3f6ee1537b6abfc49a352e9b66fbd9720 100644
--- a/app/code/Magento/CatalogInventory/etc/webapi.xml
+++ b/app/code/Magento/CatalogInventory/etc/webapi.xml
@@ -26,26 +26,25 @@
<routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../../../../app/code/Magento/Webapi/etc/webapi.xsd">
<route url="/V1/stockItem/:productSku" method="GET">
- <service class="Magento\CatalogInventory\Service\V1\StockItemServiceInterface" method="getStockItemBySku"/>
+ <service class="Magento\CatalogInventory\Api\StockRegistryInterface" method="getStockItemBySku"/>
<resources>
<resource ref="Magento_CatalogInventory::cataloginventory"/>
</resources>
</route>
<route url="/V1/stockItem/:productSku" method="PUT">
- <service class="Magento\CatalogInventory\Service\V1\StockItemServiceInterface" method="saveStockItemBySku"/>
+ <service class="Magento\CatalogInventory\Api\StockRegistryInterface" method="updateStockItemBySku"/>
<resources>
<resource ref="Magento_CatalogInventory::cataloginventory"/>
</resources>
</route>
- <route url="/V1/stockItem/status/:sku" method="GET">
- <service class="Magento\CatalogInventory\Service\V1\StockStatusServiceInterface"
- method="getProductStockStatusBySku"/>
+ <route url="/V1/stockItem/lowStock/" method="GET">
+ <service class="Magento\CatalogInventory\Api\StockRegistryInterface" method="getLowStockItems"/>
<resources>
<resource ref="Magento_CatalogInventory::cataloginventory"/>
</resources>
</route>
- <route url="/V1/stockItem/lowStock/" method="GET">
- <service class="Magento\CatalogInventory\Service\V1\StockStatusServiceInterface" method="getLowStockItems"/>
+ <route url="/V1/stockStatus/:productSku" method="GET">
+ <service class="Magento\CatalogInventory\Api\StockRegistryInterface" method="getStockStatusBySku"/>
<resources>
<resource ref="Magento_CatalogInventory::cataloginventory"/>
</resources>
diff --git a/app/code/Magento/CatalogInventory/sql/cataloginventory_setup/upgrade-1.6.0.0-1.6.0.0.1.php b/app/code/Magento/CatalogInventory/sql/cataloginventory_setup/upgrade-1.6.0.0-1.6.0.0.1.php
index 51ffd840a461ed51c6b60d1f30153ffa5953a80b..afe3b312d03959289aaba11c59287716d4a5aa75 100644
--- a/app/code/Magento/CatalogInventory/sql/cataloginventory_setup/upgrade-1.6.0.0-1.6.0.0.1.php
+++ b/app/code/Magento/CatalogInventory/sql/cataloginventory_setup/upgrade-1.6.0.0-1.6.0.0.1.php
@@ -22,10 +22,11 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-/** @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
-$connection = $installer->getConnection();
+/** @var $this \Magento\Eav\Model\Entity\Setup */
+
+/** @var $connection \Magento\Framework\DB\Adapter\Pdo\Mysql */
+$connection = $this->getConnection();
$connection->changeTableEngine(
- $installer->getTable('cataloginventory_stock_status_tmp'),
+ $this->getTable('cataloginventory_stock_status_tmp'),
\Magento\Framework\DB\Adapter\Pdo\Mysql::ENGINE_MEMORY
);
diff --git a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.2-1.6.0.3.php b/app/code/Magento/CatalogInventory/sql/cataloginventory_setup/upgrade-1.6.0.0.5-1.6.0.0.6.php
similarity index 54%
rename from app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.2-1.6.0.3.php
rename to app/code/Magento/CatalogInventory/sql/cataloginventory_setup/upgrade-1.6.0.0.5-1.6.0.0.6.php
index e92cfba3ba41dc670fa0c9a09051a8eadd94808f..ebf58f0a1116e9764aa8ca2ea78b16b40a1c143d 100644
--- a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.2-1.6.0.3.php
+++ b/app/code/Magento/CatalogInventory/sql/cataloginventory_setup/upgrade-1.6.0.0.5-1.6.0.0.6.php
@@ -22,20 +22,32 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-/* @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
+/** @var $this \Magento\Eav\Model\Entity\Setup */
+$this->startSetup();
/**
- * Add new field to 'sales_order_tax_item'
+ * Add new field to 'cataloginventory_stock_item'
*/
-$installer->getConnection()->addColumn(
- $installer->getTable('sales_order_tax_item'),
- 'tax_percent',
+$this->getConnection()->addColumn(
+ $this->getTable('cataloginventory_stock_item'),
+ 'website_id',
array(
- 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
- 'SCALE' => 4,
- 'PRECISION' => 12,
+ 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_SMALLINT,
+ 'LENGTH' => 5,
+ 'UNSIGNED' => true,
'NULLABLE' => false,
- 'COMMENT' => 'Real Tax Percent For Item'
+ 'DEFAULT' => 0,
+ 'COMMENT' => 'Is Divided into Multiple Boxes for Shipping'
)
);
+$this->getConnection()->addIndex(
+ $this->getTable('cataloginventory_stock_item'),
+ $this->getIdxName(
+ 'cataloginventory_stock_item',
+ array('website_id'),
+ \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_INDEX
+ ),
+ array('website_id'),
+ \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_INDEX
+);
+$this->endSetup();
diff --git a/app/code/Magento/CatalogInventory/sql/cataloginventory_setup/upgrade-1.6.0.0.6-1.6.0.0.7.php b/app/code/Magento/CatalogInventory/sql/cataloginventory_setup/upgrade-1.6.0.0.6-1.6.0.0.7.php
new file mode 100644
index 0000000000000000000000000000000000000000..ef34abbe655ce9cef7fb8620f57e49a690b145a9
--- /dev/null
+++ b/app/code/Magento/CatalogInventory/sql/cataloginventory_setup/upgrade-1.6.0.0.6-1.6.0.0.7.php
@@ -0,0 +1,72 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+/** @var $this \Magento\Eav\Model\Entity\Setup */
+
+$this->startSetup();
+/**
+ * Add new field to 'cataloginventory_stock_item'
+ */
+$this->getConnection()->addColumn(
+ $this->getTable('cataloginventory_stock'),
+ 'website_id',
+ array(
+ 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_SMALLINT,
+ 'LENGTH' => 5,
+ 'UNSIGNED' => true,
+ 'NULLABLE' => false,
+ 'COMMENT' => 'Website Id'
+ )
+);
+$this->getConnection()->addIndex(
+ $this->getTable('cataloginventory_stock'),
+ $this->getIdxName(
+ 'cataloginventory_stock',
+ array('website_id'),
+ \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE
+ ),
+ array('website_id'),
+ \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_INDEX
+);
+
+$this->getConnection()->dropIndex(
+ $this->getTable('cataloginventory_stock_item'),
+ $this->getIdxName(
+ 'cataloginventory_stock_item',
+ array('product_id', 'stock_id'),
+ \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE
+ )
+);
+
+$this->getConnection()->addIndex(
+ $this->getTable('cataloginventory_stock_item'),
+ $this->getIdxName(
+ 'cataloginventory_stock_item',
+ array('product_id', 'website_id'),
+ \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE
+ ),
+ array('product_id', 'website_id'),
+ \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE
+);
+$this->endSetup();
diff --git a/app/code/Magento/CatalogRule/composer.json b/app/code/Magento/CatalogRule/composer.json
index b27dd420171c00d5ba00745c27290f6e5eab76ad..70872f7f07ba676ae2886000e71701ed09d5a411 100644
--- a/app/code/Magento/CatalogRule/composer.json
+++ b/app/code/Magento/CatalogRule/composer.json
@@ -3,19 +3,19 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-rule": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-indexer": "0.1.0-alpha104",
- "magento/module-import-export": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-rule": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-indexer": "0.1.0-alpha105",
+ "magento/module-import-export": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/CatalogSearch/Model/Resource/EngineFactory.php b/app/code/Magento/CatalogSearch/Model/Resource/EngineFactory.php
index d4909580303b1f204809fd70d939a790c311c071..362f045ce3229cef2a30cc169ac196e05185951d 100644
--- a/app/code/Magento/CatalogSearch/Model/Resource/EngineFactory.php
+++ b/app/code/Magento/CatalogSearch/Model/Resource/EngineFactory.php
@@ -30,14 +30,14 @@ namespace Magento\CatalogSearch\Model\Resource;
class EngineFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/CatalogSearch/composer.json b/app/code/Magento/CatalogSearch/composer.json
index be48aeb8f502b4ad49e30ac072f3c1374409e654..78bd95e76d892ac978cbe1a9843970726d4a7560 100644
--- a/app/code/Magento/CatalogSearch/composer.json
+++ b/app/code/Magento/CatalogSearch/composer.json
@@ -3,21 +3,21 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-search": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-indexer": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-search": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-indexer": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/CatalogUrlRewrite/Service/V1/StoreViewService.php b/app/code/Magento/CatalogUrlRewrite/Service/V1/StoreViewService.php
index f277e681292a04b8566c739ab4fbe93ffcd3a62d..40c69045687ac7c8b7dd562d83dd8084553daa2b 100644
--- a/app/code/Magento/CatalogUrlRewrite/Service/V1/StoreViewService.php
+++ b/app/code/Magento/CatalogUrlRewrite/Service/V1/StoreViewService.php
@@ -69,9 +69,9 @@ class StoreViewService
throw new \InvalidArgumentException(sprintf('Cannot retrieve attribute for entity type "%s"', $entityType));
}
$select = $this->connection->select()
- ->from($attribute->getBackendTable(), 'store_id')
- ->where('attribute_id = ?', $attribute->getId())
- ->where('entity_id = ?', $entityId);
+ ->from($attribute->getBackendTable(), 'store_id')
+ ->where('attribute_id = ?', $attribute->getId())
+ ->where('entity_id = ?', $entityId);
return in_array($storeId, $this->connection->fetchCol($select));
}
diff --git a/app/code/Magento/CatalogUrlRewrite/composer.json b/app/code/Magento/CatalogUrlRewrite/composer.json
index 1a9acf737b475a9c8c9c2a1e458d83ac5b9a45a1..01441c0dc84ac78d058331f7b43559ff506de4dd 100644
--- a/app/code/Magento/CatalogUrlRewrite/composer.json
+++ b/app/code/Magento/CatalogUrlRewrite/composer.json
@@ -3,18 +3,18 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-catalog-import-export": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-import-export": "0.1.0-alpha104",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-url-rewrite": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-catalog-import-export": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-import-export": "0.1.0-alpha105",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-url-rewrite": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Centinel/Model/StateFactory.php b/app/code/Magento/Centinel/Model/StateFactory.php
index 0582196bd5411d9904566d05f94d47539cd62081..1a33f38969cc5f95c3b8c1386c0eade4b8e123cc 100644
--- a/app/code/Magento/Centinel/Model/StateFactory.php
+++ b/app/code/Magento/Centinel/Model/StateFactory.php
@@ -32,7 +32,7 @@ class StateFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -44,10 +44,10 @@ class StateFactory
protected $_stateClassMap;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $stateClassMap - key stands for card type, value define the validator class
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, array $stateClassMap = array())
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, array $stateClassMap = array())
{
$this->_objectManager = $objectManager;
$this->_stateClassMap = $stateClassMap;
diff --git a/app/code/Magento/Centinel/composer.json b/app/code/Magento/Centinel/composer.json
index ed2ea7642a2c3529c5e213cbb3dad32af06e8df3..2b5d2b199ff83bd61a407d1d719b48a418bbf4e7 100644
--- a/app/code/Magento/Centinel/composer.json
+++ b/app/code/Magento/Centinel/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Checkout/Block/Cart.php b/app/code/Magento/Checkout/Block/Cart.php
index c781da4bed66bc828d515ffebe3594035da07120..14684d3853e37036be2e0edc392995f151c51b5b 100644
--- a/app/code/Magento/Checkout/Block/Cart.php
+++ b/app/code/Magento/Checkout/Block/Cart.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Checkout\Block;
+use Magento\Customer\Model\Context;
+
/**
* Shopping cart block
*/
@@ -147,7 +149,7 @@ class Cart extends \Magento\Checkout\Block\Cart\AbstractCart
'wishlist/general/active',
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
) && $this->httpContext->getValue(
- \Magento\Customer\Helper\Data::CONTEXT_AUTH
+ Context::CONTEXT_AUTH
);
$this->setIsWishlistActive($isActive);
}
diff --git a/app/code/Magento/Checkout/Block/Cart/Crosssell.php b/app/code/Magento/Checkout/Block/Cart/Crosssell.php
index 17abdb7031a3dded1cc253745a0703a389a765bc..6b374dce668faa15022eaf4f9f91bd51e507c964 100644
--- a/app/code/Magento/Checkout/Block/Cart/Crosssell.php
+++ b/app/code/Magento/Checkout/Block/Cart/Crosssell.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Checkout\Block\Cart;
+use Magento\CatalogInventory\Helper\Stock as StockHelper;
+
/**
* Cart crosssell list
*
@@ -48,9 +50,9 @@ class Crosssell extends \Magento\Catalog\Block\Product\AbstractProduct
protected $_productVisibility;
/**
- * @var \Magento\CatalogInventory\Model\Stock
+ * @var StockHelper
*/
- protected $_stock;
+ protected $stockHelper;
/**
* @var \Magento\Catalog\Model\Product\LinkFactory
@@ -66,9 +68,9 @@ class Crosssell extends \Magento\Catalog\Block\Product\AbstractProduct
* @param \Magento\Catalog\Block\Product\Context $context
* @param \Magento\Checkout\Model\Session $checkoutSession
* @param \Magento\Catalog\Model\Product\Visibility $productVisibility
- * @param \Magento\CatalogInventory\Model\Stock $stock
* @param \Magento\Catalog\Model\Product\LinkFactory $productLinkFactory
* @param \Magento\Sales\Model\Quote\Item\RelatedProducts $itemRelationsList
+ * @param StockHelper $stockHelper
* @param array $data
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
@@ -77,16 +79,16 @@ class Crosssell extends \Magento\Catalog\Block\Product\AbstractProduct
\Magento\Catalog\Block\Product\Context $context,
\Magento\Checkout\Model\Session $checkoutSession,
\Magento\Catalog\Model\Product\Visibility $productVisibility,
- \Magento\CatalogInventory\Model\Stock $stock,
\Magento\Catalog\Model\Product\LinkFactory $productLinkFactory,
\Magento\Sales\Model\Quote\Item\RelatedProducts $itemRelationsList,
+ StockHelper $stockHelper,
array $data = array()
) {
$this->_checkoutSession = $checkoutSession;
$this->_productVisibility = $productVisibility;
- $this->_stock = $stock;
$this->_productLinkFactory = $productLinkFactory;
$this->_itemRelationsList = $itemRelationsList;
+ $this->stockHelper = $stockHelper;
parent::__construct(
$context,
$data
@@ -211,7 +213,7 @@ class Crosssell extends \Magento\Catalog\Block\Product\AbstractProduct
);
$this->_addProductAttributesAndPrices($collection);
- $this->_stock->addInStockFilterToCollection($collection);
+ $this->stockHelper->addInStockFilterToCollection($collection);
return $collection;
}
diff --git a/app/code/Magento/Checkout/Block/Cart/Item/Renderer.php b/app/code/Magento/Checkout/Block/Cart/Item/Renderer.php
index 670dbcb63827c04d6f1303d7590097c6224cafd1..3204724d50d352f8e8eef5cb6f6d0032bb937aa3 100644
--- a/app/code/Magento/Checkout/Block/Cart/Item/Renderer.php
+++ b/app/code/Magento/Checkout/Block/Cart/Item/Renderer.php
@@ -93,6 +93,11 @@ class Renderer extends \Magento\Framework\View\Element\Template implements \Mage
*/
protected $priceCurrency;
+ /**
+ * @var \Magento\Framework\Module\Manager
+ */
+ public $moduleManager;
+
/**
* @param \Magento\Framework\View\Element\Template\Context $context
* @param \Magento\Catalog\Helper\Product\Configuration $productConfig
@@ -101,6 +106,7 @@ class Renderer extends \Magento\Framework\View\Element\Template implements \Mage
* @param \Magento\Core\Helper\Url $urlHelper
* @param \Magento\Framework\Message\ManagerInterface $messageManager
* @param PriceCurrencyInterface $priceCurrency
+ * @param \Magento\Framework\Module\Manager $moduleManager
* @param array $data
*/
public function __construct(
@@ -111,6 +117,7 @@ class Renderer extends \Magento\Framework\View\Element\Template implements \Mage
\Magento\Core\Helper\Url $urlHelper,
\Magento\Framework\Message\ManagerInterface $messageManager,
PriceCurrencyInterface $priceCurrency,
+ \Magento\Framework\Module\Manager $moduleManager,
array $data = array()
) {
$this->priceCurrency = $priceCurrency;
@@ -121,6 +128,7 @@ class Renderer extends \Magento\Framework\View\Element\Template implements \Mage
$this->messageManager = $messageManager;
parent::__construct($context, $data);
$this->_isScopePrivate = true;
+ $this->moduleManager = $moduleManager;
}
/**
diff --git a/app/code/Magento/Checkout/Block/Onepage/AbstractOnepage.php b/app/code/Magento/Checkout/Block/Onepage/AbstractOnepage.php
index f2dd37e7f8e8c446a86a50b1cb9e2edadadb727a..ecd085428cb4c2937dad3aad45ab5d06ce8630f4 100644
--- a/app/code/Magento/Checkout/Block/Onepage/AbstractOnepage.php
+++ b/app/code/Magento/Checkout/Block/Onepage/AbstractOnepage.php
@@ -23,6 +23,7 @@
*/
namespace Magento\Checkout\Block\Onepage;
+use Magento\Customer\Model\Context;
use Magento\Customer\Service\V1\CustomerAccountServiceInterface as CustomerAccountService;
use Magento\Customer\Service\V1\CustomerAddressServiceInterface as CustomerAddressService;
use Magento\Customer\Model\Address\Config as AddressConfig;
@@ -200,7 +201,7 @@ abstract class AbstractOnepage extends \Magento\Framework\View\Element\Template
*/
public function isCustomerLoggedIn()
{
- return $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH);
+ return $this->httpContext->getValue(Context::CONTEXT_AUTH);
}
/**
diff --git a/app/code/Magento/Checkout/Block/Onepage/Login.php b/app/code/Magento/Checkout/Block/Onepage/Login.php
index fcb3263ca1b25ec7ffc530ada8af5a3d268e0394..6c438a7dc63b0d6483fb97b1860b85e33cba1dd7 100644
--- a/app/code/Magento/Checkout/Block/Onepage/Login.php
+++ b/app/code/Magento/Checkout/Block/Onepage/Login.php
@@ -45,6 +45,16 @@ class Login extends AbstractOnepage
*/
protected $messageManager;
+ /**
+ * @var \Magento\Customer\Model\Url
+ */
+ protected $customerUrl;
+
+ /**
+ * @var \Magento\Customer\Model\Registration
+ */
+ protected $registration;
+
/**
* @param \Magento\Framework\View\Element\Template\Context $context
* @param \Magento\Core\Helper\Data $coreData
@@ -59,6 +69,8 @@ class Login extends AbstractOnepage
* @param \Magento\Framework\App\Http\Context $httpContext
* @param \Magento\Checkout\Helper\Data $checkoutData
* @param \Magento\Framework\Message\ManagerInterface $messageManager
+ * @param \Magento\Customer\Model\Url $customerUrl
+ * @param \Magento\Customer\Model\Registration $registration
* @param array $data
*/
public function __construct(
@@ -75,9 +87,12 @@ class Login extends AbstractOnepage
\Magento\Framework\App\Http\Context $httpContext,
\Magento\Checkout\Helper\Data $checkoutData,
\Magento\Framework\Message\ManagerInterface $messageManager,
+ \Magento\Customer\Model\Url $customerUrl,
+ \Magento\Customer\Model\Registration $registration,
array $data = array()
) {
-
+ $this->registration = $registration;
+ $this->customerUrl = $customerUrl;
$this->_checkoutData = $checkoutData;
$this->messageManager = $messageManager;
parent::__construct(
@@ -108,6 +123,36 @@ class Login extends AbstractOnepage
parent::_construct();
}
+ /**
+ * Get customer registration
+ *
+ * @return \Magento\Customer\Model\Registration
+ */
+ public function getRegistration()
+ {
+ return $this->registration;
+ }
+
+ /**
+ * Return registration URL
+ *
+ * @return string
+ */
+ public function getRegisterUrl()
+ {
+ return $this->customerUrl->getRegisterUrl();
+ }
+
+ /**
+ * Return forgot password URL
+ *
+ * @return string
+ */
+ public function getForgotPasswordUrl()
+ {
+ return $this->customerUrl->getForgotPasswordUrl();
+ }
+
/**
* @return Collection
*/
diff --git a/app/code/Magento/Checkout/Block/Onepage/Success.php b/app/code/Magento/Checkout/Block/Onepage/Success.php
index 88191ba42ed5945dfbbeda9b51ad08d8d86274c8..0e8af39c690a0f40594abaf45dbb25c0a03b6578 100644
--- a/app/code/Magento/Checkout/Block/Onepage/Success.php
+++ b/app/code/Magento/Checkout/Block/Onepage/Success.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Checkout\Block\Onepage;
+use Magento\Customer\Model\Context;
+
/**
* One page checkout success page
*/
@@ -123,7 +125,7 @@ class Success extends \Magento\Framework\View\Element\Template
$order = $this->_orderFactory->create()->load($orderId);
if ($order->getId()) {
$isVisible = !in_array($order->getStatus(), $this->_orderConfig->getInvisibleOnFrontStatuses());
- $canView = $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH) && $isVisible;
+ $canView = $this->httpContext->getValue(Context::CONTEXT_AUTH) && $isVisible;
$this->addData(
array(
'is_order_visible' => $isVisible,
diff --git a/app/code/Magento/Checkout/Controller/Cart/CouponPost.php b/app/code/Magento/Checkout/Controller/Cart/CouponPost.php
index f1bc4812fdc4c72fe97bf930b197c0760a38cc5e..92f12b525265d44b381a3aa20d8f1361f0153a8f 100644
--- a/app/code/Magento/Checkout/Controller/Cart/CouponPost.php
+++ b/app/code/Magento/Checkout/Controller/Cart/CouponPost.php
@@ -24,8 +24,46 @@
*/
namespace Magento\Checkout\Controller\Cart;
+use Magento\Checkout\Model\Cart as CustomerCart;
+
class CouponPost extends \Magento\Checkout\Controller\Cart
{
+ /**
+ * Sales quote repository
+ *
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
+ /**
+ * @param \Magento\Framework\App\Action\Context $context
+ * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
+ * @param \Magento\Checkout\Model\Session $checkoutSession
+ * @param \Magento\Framework\StoreManagerInterface $storeManager
+ * @param \Magento\Core\App\Action\FormKeyValidator $formKeyValidator
+ * @param CustomerCart $cart
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
+ */
+ public function __construct(
+ \Magento\Framework\App\Action\Context $context,
+ \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
+ \Magento\Checkout\Model\Session $checkoutSession,
+ \Magento\Framework\StoreManagerInterface $storeManager,
+ \Magento\Core\App\Action\FormKeyValidator $formKeyValidator,
+ CustomerCart $cart,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository
+ ) {
+ parent::__construct(
+ $context,
+ $scopeConfig,
+ $checkoutSession,
+ $storeManager,
+ $formKeyValidator,
+ $cart
+ );
+ $this->quoteRepository = $quoteRepository;
+ }
+
/**
* Initialize coupon
*
@@ -58,7 +96,8 @@ class CouponPost extends \Magento\Checkout\Controller\Cart
$isCodeLengthValid = $codeLength && $codeLength <= \Magento\Checkout\Helper\Cart::COUPON_CODE_MAX_LENGTH;
$this->cart->getQuote()->getShippingAddress()->setCollectShippingRates(true);
- $this->cart->getQuote()->setCouponCode($isCodeLengthValid ? $couponCode : '')->collectTotals()->save();
+ $this->cart->getQuote()->setCouponCode($isCodeLengthValid ? $couponCode : '')->collectTotals();
+ $this->quoteRepository->save($this->cart->getQuote());
if ($codeLength) {
if ($isCodeLengthValid && $couponCode == $this->cart->getQuote()->getCouponCode()) {
diff --git a/app/code/Magento/Checkout/Controller/Cart/EstimatePost.php b/app/code/Magento/Checkout/Controller/Cart/EstimatePost.php
index 3531213b4dca86b8a9c09bbff4e570162e5bacc7..8a163bcceb36111fc364704f02554ea6dc7011ac 100644
--- a/app/code/Magento/Checkout/Controller/Cart/EstimatePost.php
+++ b/app/code/Magento/Checkout/Controller/Cart/EstimatePost.php
@@ -24,8 +24,44 @@
*/
namespace Magento\Checkout\Controller\Cart;
+use Magento\Checkout\Model\Cart as CustomerCart;
+
class EstimatePost extends \Magento\Checkout\Controller\Cart
{
+ /**
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
+ /**
+ * @param \Magento\Framework\App\Action\Context $context
+ * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
+ * @param \Magento\Checkout\Model\Session $checkoutSession
+ * @param \Magento\Framework\StoreManagerInterface $storeManager
+ * @param \Magento\Core\App\Action\FormKeyValidator $formKeyValidator
+ * @param CustomerCart $cart
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
+ */
+ public function __construct(
+ \Magento\Framework\App\Action\Context $context,
+ \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
+ \Magento\Checkout\Model\Session $checkoutSession,
+ \Magento\Framework\StoreManagerInterface $storeManager,
+ \Magento\Core\App\Action\FormKeyValidator $formKeyValidator,
+ CustomerCart $cart,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository
+ ) {
+ $this->quoteRepository = $quoteRepository;
+ parent::__construct(
+ $context,
+ $scopeConfig,
+ $checkoutSession,
+ $storeManager,
+ $formKeyValidator,
+ $cart
+ );
+ }
+
/**
* Initialize shipping information
*
@@ -52,7 +88,7 @@ class EstimatePost extends \Magento\Checkout\Controller\Cart
)->setCollectShippingRates(
true
);
- $this->cart->getQuote()->save();
+ $this->quoteRepository->save($this->cart->getQuote());
$this->_goBack();
}
}
diff --git a/app/code/Magento/Checkout/Controller/Onepage.php b/app/code/Magento/Checkout/Controller/Onepage.php
index 9e041a4403124aef898b43c6e6c4a8b66cf43b2c..01de08fa277b1411c8745eb0702a4c9459cf461f 100644
--- a/app/code/Magento/Checkout/Controller/Onepage.php
+++ b/app/code/Magento/Checkout/Controller/Onepage.php
@@ -71,6 +71,11 @@ class Onepage extends Action
*/
protected $layoutFactory;
+ /**
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
/**
* @param \Magento\Framework\App\Action\Context $context
* @param \Magento\Customer\Model\Session $customerSession
@@ -81,6 +86,7 @@ class Onepage extends Action
* @param \Magento\Core\App\Action\FormKeyValidator $formKeyValidator
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
* @param \Magento\Framework\View\LayoutFactory $layoutFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
*/
public function __construct(
\Magento\Framework\App\Action\Context $context,
@@ -91,13 +97,15 @@ class Onepage extends Action
\Magento\Framework\Translate\InlineInterface $translateInline,
\Magento\Core\App\Action\FormKeyValidator $formKeyValidator,
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
- \Magento\Framework\View\LayoutFactory $layoutFactory
+ \Magento\Framework\View\LayoutFactory $layoutFactory,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository
) {
$this->_coreRegistry = $coreRegistry;
$this->_translateInline = $translateInline;
$this->_formKeyValidator = $formKeyValidator;
$this->scopeConfig = $scopeConfig;
$this->layoutFactory = $layoutFactory;
+ $this->quoteRepository = $quoteRepository;
parent::__construct($context, $customerSession, $customerAccountService, $customerMetadataService);
}
diff --git a/app/code/Magento/Checkout/Controller/Onepage/SaveOrder.php b/app/code/Magento/Checkout/Controller/Onepage/SaveOrder.php
index 2b44744969fc68c3ecaf3b6ee4f848cf8c6fd91e..5c34237ecdbd4e182f0ff247dbeeffdbd5a47a45 100644
--- a/app/code/Magento/Checkout/Controller/Onepage/SaveOrder.php
+++ b/app/code/Magento/Checkout/Controller/Onepage/SaveOrder.php
@@ -24,6 +24,9 @@
*/
namespace Magento\Checkout\Controller\Onepage;
+use Magento\Customer\Service\V1\CustomerAccountServiceInterface as CustomerAccountService;
+use Magento\Customer\Service\V1\CustomerMetadataServiceInterface as CustomerMetadataService;
+
class SaveOrder extends \Magento\Checkout\Controller\Onepage
{
/**
@@ -121,7 +124,7 @@ class SaveOrder extends \Magento\Checkout\Controller\Onepage
$result['error'] = true;
$result['error_messages'] = __('Something went wrong processing your order. Please try again later.');
}
- $this->getOnepage()->getQuote()->save();
+ $this->quoteRepository->save($this->getOnepage()->getQuote());
/**
* when there is redirect to third party, we don't want to save order yet.
* we will save the order in return action.
diff --git a/app/code/Magento/Checkout/Controller/Onepage/SaveShippingMethod.php b/app/code/Magento/Checkout/Controller/Onepage/SaveShippingMethod.php
index 8d95e6edabe90b26ac5a7ceaac8adb4623bf729d..f26a5892a6e456834f360c9a19d0b80d19a1e748 100644
--- a/app/code/Magento/Checkout/Controller/Onepage/SaveShippingMethod.php
+++ b/app/code/Magento/Checkout/Controller/Onepage/SaveShippingMethod.php
@@ -24,6 +24,9 @@
*/
namespace Magento\Checkout\Controller\Onepage;
+use Magento\Customer\Service\V1\CustomerAccountServiceInterface as CustomerAccountService;
+use Magento\Customer\Service\V1\CustomerMetadataServiceInterface as CustomerMetadataService;
+
class SaveShippingMethod extends \Magento\Checkout\Controller\Onepage
{
/**
@@ -57,7 +60,7 @@ class SaveShippingMethod extends \Magento\Checkout\Controller\Onepage
];
$result['update_progress'] = ['html' => $this->getProgressHtml($result['goto_section'])];
}
- $this->getOnepage()->getQuote()->collectTotals()->save();
+ $this->quoteRepository->save($this->getOnepage()->getQuote()->collectTotals());
$this->getResponse()->representJson(
$this->_objectManager->get('Magento\Core\Helper\Data')->jsonEncode($result)
);
diff --git a/app/code/Magento/Checkout/Helper/ExpressRedirect.php b/app/code/Magento/Checkout/Helper/ExpressRedirect.php
index 48c8d511157dbe0d207cb615c3f4a840897bc9a3..0d7e7d8daef64a9482550ac627f6a2e5916d7133 100644
--- a/app/code/Magento/Checkout/Helper/ExpressRedirect.php
+++ b/app/code/Magento/Checkout/Helper/ExpressRedirect.php
@@ -33,7 +33,7 @@ class ExpressRedirect extends \Magento\Framework\App\Helper\AbstractHelper
protected $_actionFlag;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -46,13 +46,13 @@ class ExpressRedirect extends \Magento\Framework\App\Helper\AbstractHelper
/**
* @param \Magento\Framework\App\ActionFlag $actionFlag
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Customer\Model\Session $customerSession
* @param \Magento\Framework\App\Helper\Context $context
*/
public function __construct(
\Magento\Framework\App\ActionFlag $actionFlag,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Customer\Model\Session $customerSession,
\Magento\Framework\App\Helper\Context $context
) {
diff --git a/app/code/Magento/Checkout/Model/Cart.php b/app/code/Magento/Checkout/Model/Cart.php
index ffdfb5c0d999c64d8c9fea85fa9ad5bbcf87d128..2f0609e6054a09baa753e7e38dc235b6295a1644 100644
--- a/app/code/Magento/Checkout/Model/Cart.php
+++ b/app/code/Magento/Checkout/Model/Cart.php
@@ -24,11 +24,13 @@
namespace Magento\Checkout\Model;
use Magento\Catalog\Model\Product;
+use Magento\Framework\Object;
+use Magento\Checkout\Model\Cart\CartInterface;
/**
* Shopping cart model
*/
-class Cart extends \Magento\Framework\Object implements \Magento\Checkout\Model\Cart\CartInterface
+class Cart extends Object implements CartInterface
{
/**
* Shopping cart items summary quantity(s)
@@ -89,20 +91,32 @@ class Cart extends \Magento\Framework\Object implements \Magento\Checkout\Model\
protected $messageManager;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockStateInterface
+ */
+ protected $stockState;
+
+ /**
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
/**
* @param \Magento\Framework\Event\ManagerInterface $eventManager
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
* @param \Magento\Catalog\Model\ProductFactory $productFactory
* @param \Magento\Framework\StoreManagerInterface $storeManager
- * @param \Magento\Checkout\Model\Resource\Cart $resourceCart
+ * @param Resource\Cart $resourceCart
* @param Session $checkoutSession
* @param \Magento\Customer\Model\Session $customerSession
* @param \Magento\Framework\Message\ManagerInterface $messageManager
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockStateInterface $stockState
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param array $data
*/
public function __construct(
@@ -114,7 +128,9 @@ class Cart extends \Magento\Framework\Object implements \Magento\Checkout\Model\
Session $checkoutSession,
\Magento\Customer\Model\Session $customerSession,
\Magento\Framework\Message\ManagerInterface $messageManager,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockStateInterface $stockState,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
array $data = array()
) {
$this->_eventManager = $eventManager;
@@ -125,7 +141,9 @@ class Cart extends \Magento\Framework\Object implements \Magento\Checkout\Model\
$this->_checkoutSession = $checkoutSession;
$this->_customerSession = $customerSession;
$this->messageManager = $messageManager;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
+ $this->stockState = $stockState;
+ $this->quoteRepository = $quoteRepository;
parent::__construct($data);
}
@@ -333,7 +351,8 @@ class Cart extends \Magento\Framework\Object implements \Magento\Checkout\Model\
$productId = $product->getId();
if ($productId) {
- $minimumQty = $this->stockItemService->getMinSaleQty($productId);
+ $stockItem = $this->stockRegistry->getStockItem($productId, $product->getStore()->getWebsiteId());
+ $minimumQty = $stockItem->getMinSaleQty();
//If product was not found in cart and there is set minimal qty for it
if ($minimumQty
&& $minimumQty > 0
@@ -394,7 +413,7 @@ class Cart extends \Magento\Framework\Object implements \Magento\Checkout\Model\
if (!empty($productIds)) {
foreach ($productIds as $productId) {
- $productId = (int) $productId;
+ $productId = (int)$productId;
if (!$productId) {
continue;
}
@@ -436,7 +455,7 @@ class Cart extends \Magento\Framework\Object implements \Magento\Checkout\Model\
if (!isset($itemInfo['qty'])) {
continue;
}
- $qty = (float) $itemInfo['qty'];
+ $qty = (float)$itemInfo['qty'];
if ($qty <= 0) {
continue;
}
@@ -452,7 +471,11 @@ class Cart extends \Magento\Framework\Object implements \Magento\Checkout\Model\
}
$data[$itemId]['before_suggest_qty'] = $qty;
- $data[$itemId]['qty'] = $this->stockItemService->suggestQty($product->getId(), $qty);
+ $data[$itemId]['qty'] = $this->stockState->suggestQty(
+ $product->getId(),
+ $qty,
+ $product->getStore()->getWebsiteId()
+ );
}
return $data;
}
@@ -541,7 +564,7 @@ class Cart extends \Magento\Framework\Object implements \Magento\Checkout\Model\
$this->getQuote()->getBillingAddress();
$this->getQuote()->getShippingAddress()->setCollectShippingRates(true);
$this->getQuote()->collectTotals();
- $this->getQuote()->save();
+ $this->quoteRepository->save($this->getQuote());
$this->_checkoutSession->setQuoteId($this->getQuote()->getId());
/**
* Cart save usually called after changes with cart items.
@@ -660,7 +683,8 @@ class Cart extends \Magento\Framework\Object implements \Magento\Checkout\Model\
$request = $this->_getProductRequest($requestInfo);
if ($productId) {
- $minimumQty = $this->stockItemService->getMinSaleQty($productId);
+ $stockItem = $this->stockRegistry->getStockItem($productId, $product->getStore()->getWebsiteId());
+ $minimumQty = $stockItem->getMinSaleQty();
// If product was not found in cart and there is set minimal qty for it
if ($minimumQty
&& $minimumQty > 0
diff --git a/app/code/Magento/Checkout/Model/Session.php b/app/code/Magento/Checkout/Model/Session.php
index 07ed03d5505e5ec988de9dba9efb4eb95728f541..25ab9234a8408e49c8722447a9677981de48d77e 100644
--- a/app/code/Magento/Checkout/Model/Session.php
+++ b/app/code/Magento/Checkout/Model/Session.php
@@ -73,9 +73,9 @@ class Session extends \Magento\Framework\Session\SessionManager
protected $_customerSession;
/**
- * @var \Magento\Sales\Model\QuoteFactory
+ * @var \Magento\Sales\Model\QuoteRepository
*/
- protected $_quoteFactory;
+ protected $quoteRepository;
/**
* @var \Magento\Framework\HTTP\PhpEnvironment\RemoteAddress
@@ -99,11 +99,11 @@ class Session extends \Magento\Framework\Session\SessionManager
* @param \Magento\Framework\Session\SaveHandlerInterface $saveHandler
* @param \Magento\Framework\Session\ValidatorInterface $validator
* @param \Magento\Framework\Session\StorageInterface $storage
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
* @param \Magento\Sales\Model\OrderFactory $orderFactory
* @param \Magento\Customer\Model\Session $customerSession
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param \Magento\Framework\HTTP\PhpEnvironment\RemoteAddress $remoteAddress
* @param \Magento\Framework\Event\ManagerInterface $eventManager
* @param \Magento\Framework\StoreManagerInterface $storeManager
@@ -116,18 +116,18 @@ class Session extends \Magento\Framework\Session\SessionManager
\Magento\Framework\Session\SaveHandlerInterface $saveHandler,
\Magento\Framework\Session\ValidatorInterface $validator,
\Magento\Framework\Session\StorageInterface $storage,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory,
\Magento\Sales\Model\OrderFactory $orderFactory,
\Magento\Customer\Model\Session $customerSession,
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
\Magento\Framework\HTTP\PhpEnvironment\RemoteAddress $remoteAddress,
\Magento\Framework\Event\ManagerInterface $eventManager,
\Magento\Framework\StoreManagerInterface $storeManager
) {
$this->_orderFactory = $orderFactory;
$this->_customerSession = $customerSession;
- $this->_quoteFactory = $quoteFactory;
+ $this->quoteRepository = $quoteRepository;
$this->_remoteAddress = $remoteAddress;
$this->_eventManager = $eventManager;
$this->_storeManager = $storeManager;
@@ -188,15 +188,15 @@ class Session extends \Magento\Framework\Session\SessionManager
$this->_eventManager->dispatch('custom_quote_process', array('checkout_session' => $this));
if ($this->_quote === null) {
- /** @var $quote Quote */
- $quote = $this->_quoteFactory->create()->setStoreId($this->_storeManager->getStore()->getId());
+ $quote = $this->quoteRepository->create();
if ($this->getQuoteId()) {
- if ($this->_loadInactive) {
- $quote->load($this->getQuoteId());
- } else {
- $quote->loadActive($this->getQuoteId());
- }
- if ($quote->getId()) {
+ try {
+ if ($this->_loadInactive) {
+ $quote = $this->quoteRepository->get($this->getQuoteId());
+ } else {
+ $quote = $this->quoteRepository->getActive($this->getQuoteId());
+ }
+
/**
* If current currency code of quote is not equal current currency code of store,
* need recalculate totals of quote. It is possible if customer use currency switcher or
@@ -204,28 +204,29 @@ class Session extends \Magento\Framework\Session\SessionManager
*/
if ($quote->getQuoteCurrencyCode() != $this->_storeManager->getStore()->getCurrentCurrencyCode()) {
$quote->setStore($this->_storeManager->getStore());
- $quote->collectTotals()->save();
+ $this->quoteRepository->save($quote->collectTotals());
/*
* We mast to create new quote object, because collectTotals()
* can to create links with other objects.
*/
- $quote = $this->_quoteFactory->create()->setStoreId($this->_storeManager->getStore()->getId());
- $quote->load($this->getQuoteId());
+ $quote = $this->quoteRepository->get($this->getQuoteId());
}
- } else {
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
$this->setQuoteId(null);
}
}
if (!$this->getQuoteId()) {
if ($this->_customerSession->isLoggedIn() || $this->_customer) {
- $customerId = $this->_customer ? $this
- ->_customer
- ->getId() : $this
- ->_customerSession
- ->getCustomerId();
- $quote->loadByCustomer($customerId);
- $this->setQuoteId($quote->getId());
+ $customerId = $this->_customer
+ ? $this->_customer->getId()
+ : $this->_customerSession->getCustomerId();
+ try {
+ $quote = $this->quoteRepository->getForCustomer($customerId);
+ $this->setQuoteId($quote->getId());
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+
+ }
} else {
$quote->setIsCheckoutCart(true);
$this->_eventManager->dispatch('checkout_quote_init', array('quote' => $quote));
@@ -290,21 +291,24 @@ class Session extends \Magento\Framework\Session\SessionManager
$this->_eventManager->dispatch('load_customer_quote_before', array('checkout_session' => $this));
- $customerQuote = $this->_quoteFactory->create()->setStoreId(
- $this->_storeManager->getStore()->getId()
- )->loadByCustomer(
- $this->_customerSession->getCustomerId()
- );
+ try {
+ $customerQuote = $this->quoteRepository->getForCustomer($this->_customerSession->getCustomerId());
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+ $customerQuote = $this->quoteRepository->create();
+ }
+ $customerQuote->setStoreId($this->_storeManager->getStore()->getId());
if ($customerQuote->getId() && $this->getQuoteId() != $customerQuote->getId()) {
if ($this->getQuoteId()) {
- $customerQuote->merge($this->getQuote())->collectTotals()->save();
+ $this->quoteRepository->save(
+ $customerQuote->merge($this->getQuote())->collectTotals()
+ );
}
$this->setQuoteId($customerQuote->getId());
if ($this->_quote) {
- $this->_quote->delete();
+ $this->quoteRepository->delete($this->_quote);
}
$this->_quote = $customerQuote;
} else {
@@ -314,7 +318,8 @@ class Session extends \Magento\Framework\Session\SessionManager
$this->_customerSession->getCustomerDataObject()
)->setTotalsCollectedFlag(
false
- )->collectTotals()->save();
+ )->collectTotals();
+ $this->quoteRepository->save($this->getQuote());
}
return $this;
}
@@ -453,13 +458,15 @@ class Session extends \Magento\Framework\Session\SessionManager
/** @var \Magento\Sales\Model\Order $order */
$order = $this->getLastRealOrder();
if ($order->getId()) {
- /** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->_quoteFactory->create()->load($order->getQuoteId());
- if ($quote->getId()) {
- $quote->setIsActive(1)->setReservedOrderId(null)->save();
+ try {
+ $quote = $this->quoteRepository->get($order->getQuoteId());
+ $quote->setIsActive(1)->setReservedOrderId(null);
+ $this->quoteRepository->save($quote);
$this->replaceQuote($quote)->unsLastRealOrderId();
$this->_eventManager->dispatch('restore_quote', array('order' => $order, 'quote' => $quote));
return true;
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+
}
}
return false;
diff --git a/app/code/Magento/Checkout/Model/Type/Onepage.php b/app/code/Magento/Checkout/Model/Type/Onepage.php
index 2e0fef9d013090b4c0489cc80ae31554cfc3c67c..3d5db6567362ba64944e393af59ca7a1eb87dec7 100644
--- a/app/code/Magento/Checkout/Model/Type/Onepage.php
+++ b/app/code/Magento/Checkout/Model/Type/Onepage.php
@@ -75,11 +75,11 @@ class Onepage
protected $_logger;
/**
- * Customer data
+ * Customer url
*
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerData = null;
+ protected $_customerUrl;
/**
* Core event manager proxy
@@ -156,10 +156,15 @@ class Onepage
*/
protected $orderSender;
+ /**
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
/**
* @param \Magento\Framework\Event\ManagerInterface $eventManager
* @param \Magento\Checkout\Helper\Data $helper
- * @param \Magento\Customer\Helper\Data $customerData
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param \Magento\Framework\Logger $logger
* @param \Magento\Checkout\Model\Session $checkoutSession
* @param \Magento\Customer\Model\Session $customerSession
@@ -172,19 +177,20 @@ class Onepage
* @param \Magento\Sales\Model\OrderFactory $orderFactory
* @param \Magento\Framework\Object\Copy $objectCopyService
* @param \Magento\Framework\Message\ManagerInterface $messageManager
- * @param CustomerAccountServiceInterface $accountService
* @param \Magento\Customer\Model\Metadata\FormFactory $formFactory
* @param CustomerBuilder $customerBuilder
* @param AddressBuilder $addressBuilder
* @param \Magento\Framework\Math\Random $mathRandom
* @param \Magento\Framework\Encryption\EncryptorInterface $encryptor
* @param CustomerAddressServiceInterface $customerAddressService
+ * @param CustomerAccountServiceInterface $accountService
* @param OrderSender $orderSender
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
*/
public function __construct(
\Magento\Framework\Event\ManagerInterface $eventManager,
\Magento\Checkout\Helper\Data $helper,
- \Magento\Customer\Helper\Data $customerData,
+ \Magento\Customer\Model\Url $customerUrl,
\Magento\Framework\Logger $logger,
\Magento\Checkout\Model\Session $checkoutSession,
\Magento\Customer\Model\Session $customerSession,
@@ -204,10 +210,11 @@ class Onepage
\Magento\Framework\Encryption\EncryptorInterface $encryptor,
CustomerAddressServiceInterface $customerAddressService,
CustomerAccountServiceInterface $accountService,
- OrderSender $orderSender
+ OrderSender $orderSender,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository
) {
$this->_eventManager = $eventManager;
- $this->_customerData = $customerData;
+ $this->_customerUrl = $customerUrl;
$this->_helper = $helper;
$this->_checkoutSession = $checkoutSession;
$this->_customerSession = $customerSession;
@@ -229,6 +236,7 @@ class Onepage
$this->_customerAddressService = $customerAddressService;
$this->_customerAccountService = $accountService;
$this->orderSender = $orderSender;
+ $this->quoteRepository = $quoteRepository;
}
/**
@@ -296,7 +304,7 @@ class Onepage
$quote = $this->getQuote();
if ($quote->isMultipleShippingAddresses()) {
$quote->removeAllAddresses();
- $quote->save();
+ $this->quoteRepository->save($quote);
}
/*
@@ -342,7 +350,7 @@ class Onepage
return array('error' => -1, 'message' => __('Invalid data'));
}
- $this->getQuote()->setCheckoutMethod($method)->save();
+ $this->quoteRepository->save($this->getQuote()->setCheckoutMethod($method));
$this->getCheckout()->setStepData('billing', 'allow', true);
return array();
}
@@ -480,7 +488,7 @@ class Onepage
}
}
- $this->getQuote()->save();
+ $this->quoteRepository->save($this->getQuote());
$this->getCheckout()->setStepData(
'billing',
@@ -711,7 +719,7 @@ class Onepage
$payment = $quote->getPayment();
$payment->importData($data);
- $quote->save();
+ $this->quoteRepository->save($quote);
$this->getCheckout()->setStepData('payment', 'complete', true)->setStepData('review', 'allow', true);
@@ -871,7 +879,7 @@ class Onepage
$customer = $this->getQuote()->getCustomerData();
$confirmationStatus = $this->_customerAccountService->getConfirmationStatus($customer->getId());
if ($confirmationStatus === CustomerAccountServiceInterface::ACCOUNT_CONFIRMATION_REQUIRED) {
- $url = $this->_customerData->getEmailConfirmationUrl($customer->getEmail());
+ $url = $this->_customerUrl->getEmailConfirmationUrl($customer->getEmail());
$this->messageManager->addSuccess(
// @codingStandardsIgnoreStart
__(
diff --git a/app/code/Magento/Checkout/Service/V1/Address/Billing/ReadService.php b/app/code/Magento/Checkout/Service/V1/Address/Billing/ReadService.php
index f47d8862767e018f0961293b5bb76d15326f367e..1a2d6bf5b4c36dfaabd669a6fad436de6f07d697 100644
--- a/app/code/Magento/Checkout/Service/V1/Address/Billing/ReadService.php
+++ b/app/code/Magento/Checkout/Service/V1/Address/Billing/ReadService.php
@@ -70,7 +70,7 @@ class ReadService implements ReadServiceInterface
*
* @var \Magento\Sales\Model\Quote\Address $address
*/
- $address = $this->quoteRepository->get($cartId)->getBillingAddress();
+ $address = $this->quoteRepository->getActive($cartId)->getBillingAddress();
return $this->addressConverter->convertModelToDataObject($address);
}
}
diff --git a/app/code/Magento/Checkout/Service/V1/Address/Billing/WriteService.php b/app/code/Magento/Checkout/Service/V1/Address/Billing/WriteService.php
index 9691eec44e9f7096af182c3790603b30ddcc0c37..46b7000536ccc081f675dd27676438a13edbe526 100644
--- a/app/code/Magento/Checkout/Service/V1/Address/Billing/WriteService.php
+++ b/app/code/Magento/Checkout/Service/V1/Address/Billing/WriteService.php
@@ -107,7 +107,7 @@ class WriteService implements WriteServiceInterface
*
* @var \Magento\Sales\Model\Quote $quote
*/
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
/**
* Address.
*
@@ -122,7 +122,7 @@ class WriteService implements WriteServiceInterface
$quote->setBillingAddress($address);
$quote->setDataChanges(true);
try {
- $quote->save();
+ $this->quoteRepository->save($quote);
} catch (\Exception $e) {
$this->logger->logException($e);
throw new InputException('Unable to save address. Please, check input data.');
diff --git a/app/code/Magento/Checkout/Service/V1/Address/Shipping/ReadService.php b/app/code/Magento/Checkout/Service/V1/Address/Shipping/ReadService.php
index 47c0c465ef075f60236f8fa6b5a5b0c21b5aa719..a0a359472225828eeac2ef3c791373bfa9b1c001 100644
--- a/app/code/Magento/Checkout/Service/V1/Address/Shipping/ReadService.php
+++ b/app/code/Magento/Checkout/Service/V1/Address/Shipping/ReadService.php
@@ -71,7 +71,7 @@ class ReadService implements ReadServiceInterface
*
* @var \Magento\Sales\Model\Quote $quote
*/
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
if ($quote->isVirtual()) {
throw new NoSuchEntityException(
'Cart contains virtual product(s) only. Shipping address is not applicable'
diff --git a/app/code/Magento/Checkout/Service/V1/Address/Shipping/WriteService.php b/app/code/Magento/Checkout/Service/V1/Address/Shipping/WriteService.php
index 82ae00681ed2fcd0ca9cb9d891fa4657e306103f..dc4f3556f074a8c8c090b5f2f4f4fbca44b0ab98 100644
--- a/app/code/Magento/Checkout/Service/V1/Address/Shipping/WriteService.php
+++ b/app/code/Magento/Checkout/Service/V1/Address/Shipping/WriteService.php
@@ -100,7 +100,7 @@ class WriteService implements WriteServiceInterface
public function setAddress($cartId, $addressData)
{
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
if ($quote->isVirtual()) {
throw new NoSuchEntityException(
'Cart contains virtual product(s) only. Shipping address is not applicable'
@@ -119,7 +119,7 @@ class WriteService implements WriteServiceInterface
$quote->setShippingAddress($address);
$quote->setDataChanges(true);
try {
- $quote->save();
+ $this->quoteRepository->save($quote);
} catch (\Exception $e) {
$this->logger->logException($e);
throw new InputException('Unable to save address. Please, check input data.');
diff --git a/app/code/Magento/Checkout/Service/V1/Cart/ReadService.php b/app/code/Magento/Checkout/Service/V1/Cart/ReadService.php
index adfb0ceed57c06e695c531127e682cb11435bbf7..b39f3214938cae0ceb7391b5c5e06558527634de 100644
--- a/app/code/Magento/Checkout/Service/V1/Cart/ReadService.php
+++ b/app/code/Magento/Checkout/Service/V1/Cart/ReadService.php
@@ -117,7 +117,7 @@ class ReadService implements ReadServiceInterface
*/
public function getCart($cartId)
{
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
return $this->cartMapper->map($quote);
}
@@ -130,7 +130,7 @@ class ReadService implements ReadServiceInterface
*/
public function getCartForCustomer($customerId)
{
- $quote = $this->quoteRepository->getForCustomer($customerId);
+ $quote = $this->quoteRepository->getActiveForCustomer($customerId);
return $this->cartMapper->map($quote);
}
diff --git a/app/code/Magento/Checkout/Service/V1/Cart/TotalsService.php b/app/code/Magento/Checkout/Service/V1/Cart/TotalsService.php
index 2e44c33c8bdb2143f96a7de098c45d0585011b2b..b5d82738905ff77c3533295ff98e8b01220005b9 100644
--- a/app/code/Magento/Checkout/Service/V1/Cart/TotalsService.php
+++ b/app/code/Magento/Checkout/Service/V1/Cart/TotalsService.php
@@ -94,7 +94,7 @@ class TotalsService implements TotalsServiceInterface
*
* @var \Magento\Sales\Model\Quote $quote
*/
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
$this->totalsBuilder->populateWithArray($this->totalsMapper->map($quote));
$items = [];
diff --git a/app/code/Magento/Checkout/Service/V1/Cart/WriteService.php b/app/code/Magento/Checkout/Service/V1/Cart/WriteService.php
index 733bd5eaa79eeba7813e6d76458a8e6e1f7fc017..1f12a448593b1dbb9335fc38e6dd9685e99c1a76 100644
--- a/app/code/Magento/Checkout/Service/V1/Cart/WriteService.php
+++ b/app/code/Magento/Checkout/Service/V1/Cart/WriteService.php
@@ -33,13 +33,6 @@ use Magento\Authorization\Model\UserContextInterface;
*/
class WriteService implements WriteServiceInterface
{
- /**
- * Quote factory.
- *
- * @var \Magento\Sales\Model\QuoteFactory
- */
- protected $quoteFactory;
-
/**
* Quote repository.
*
@@ -76,9 +69,6 @@ class WriteService implements WriteServiceInterface
protected $quoteServiceFactory;
/**
- * Constructs a cart write service object.
- *
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory Quote factory.
* @param \Magento\Sales\Model\QuoteRepository $quoteRepository Quote repository.
* @param \Magento\Framework\StoreManagerInterface $storeManager Store manager.
* @param \Magento\Customer\Model\CustomerRegistry $customerRegistry Customer registry.
@@ -86,14 +76,12 @@ class WriteService implements WriteServiceInterface
* @param \Magento\Sales\Model\Service\QuoteFactory $quoteServiceFactory Quote service factory.
*/
public function __construct(
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
\Magento\Sales\Model\QuoteRepository $quoteRepository,
\Magento\Framework\StoreManagerInterface $storeManager,
\Magento\Customer\Model\CustomerRegistry $customerRegistry,
UserContextInterface $userContext,
\Magento\Sales\Model\Service\QuoteFactory $quoteServiceFactory
) {
- $this->quoteFactory = $quoteFactory;
$this->quoteRepository = $quoteRepository;
$this->storeManager = $storeManager;
$this->customerRegistry = $customerRegistry;
@@ -114,7 +102,7 @@ class WriteService implements WriteServiceInterface
: $this->createAnonymousCart();
try {
- $quote->save();
+ $this->quoteRepository->save($quote);
} catch (\Exception $e) {
throw new CouldNotSaveException('Cannot create quote');
}
@@ -130,7 +118,7 @@ class WriteService implements WriteServiceInterface
{
$storeId = $this->storeManager->getStore()->getId();
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteFactory->create();
+ $quote = $this->quoteRepository->create();
$quote->setStoreId($storeId);
return $quote;
}
@@ -146,13 +134,14 @@ class WriteService implements WriteServiceInterface
$storeId = $this->storeManager->getStore()->getId();
$customer = $this->customerRegistry->retrieve($this->userContext->getUserId());
- $currentCustomerQuote = $this->quoteFactory->create()->loadByCustomer($customer);
- if ($currentCustomerQuote->getId() && $currentCustomerQuote->getIsActive()) {
+ try {
+ $this->quoteRepository->getActiveForCustomer($this->userContext->getUserId());
throw new CouldNotSaveException('Cannot create quote');
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
}
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteFactory->create();
+ $quote = $this->quoteRepository->create();
$quote->setStoreId($storeId);
$quote->setCustomer($customer);
$quote->setCustomerIsGuest(0);
@@ -170,7 +159,7 @@ class WriteService implements WriteServiceInterface
public function assignCustomer($cartId, $customerId)
{
$storeId = $this->storeManager->getStore()->getId();
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
$customer = $this->customerRegistry->retrieve($customerId);
if (!in_array($storeId, $customer->getSharedStoreIds())) {
throw new StateException('Cannot assign customer to the given cart. The cart belongs to different store.');
@@ -178,14 +167,15 @@ class WriteService implements WriteServiceInterface
if ($quote->getCustomerId()) {
throw new StateException('Cannot assign customer to the given cart. The cart is not anonymous.');
}
- $currentCustomerQuote = $this->quoteFactory->create()->loadByCustomer($customer);
- if ($currentCustomerQuote->getId()) {
+ try {
+ $this->quoteRepository->getForCustomer($customerId);
throw new StateException('Cannot assign customer to the given cart. Customer already has active cart.');
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
}
$quote->setCustomer($customer);
$quote->setCustomerIsGuest(0);
- $quote->save();
+ $this->quoteRepository->save($quote);
return true;
}
@@ -197,7 +187,7 @@ class WriteService implements WriteServiceInterface
*/
public function order($cartId)
{
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
/** @var \Magento\Sales\Model\Service\Quote $quoteService */
$quoteService = $this->quoteServiceFactory->create(['quote' => $quote]);
$order = $quoteService->submitOrderWithDataObject();
diff --git a/app/code/Magento/Checkout/Service/V1/Coupon/ReadService.php b/app/code/Magento/Checkout/Service/V1/Coupon/ReadService.php
index 343640c2242362d4472791458933bc0d83663906..20aab20d904f81b402b88f37231bd23324f3c308 100644
--- a/app/code/Magento/Checkout/Service/V1/Coupon/ReadService.php
+++ b/app/code/Magento/Checkout/Service/V1/Coupon/ReadService.php
@@ -69,7 +69,7 @@ class ReadService implements ReadServiceInterface
public function get($cartId)
{
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
$data = [Coupon::COUPON_CODE => $quote->getCouponCode()];
$output = $this->couponBuilder->populateWithArray($data)->create();
return $output;
diff --git a/app/code/Magento/Checkout/Service/V1/Coupon/WriteService.php b/app/code/Magento/Checkout/Service/V1/Coupon/WriteService.php
index e0ac991969314b6af6a0cc3b38a0ac6e196ff355..275e88093a0db57bc5a233bb3ea12a1d59818075 100644
--- a/app/code/Magento/Checkout/Service/V1/Coupon/WriteService.php
+++ b/app/code/Magento/Checkout/Service/V1/Coupon/WriteService.php
@@ -73,7 +73,7 @@ class WriteService implements WriteServiceInterface
public function set($cartId, \Magento\Checkout\Service\V1\Data\Cart\Coupon $couponCodeData)
{
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
if (!$quote->getItemsCount()) {
throw new NoSuchEntityException("Cart $cartId doesn't contain products");
}
@@ -82,7 +82,7 @@ class WriteService implements WriteServiceInterface
try {
$quote->setCouponCode($couponCode);
- $quote->collectTotals()->save();
+ $this->quoteRepository->save($quote->collectTotals());
} catch (\Exception $e) {
throw new CouldNotSaveException('Could not apply coupon code');
}
@@ -103,14 +103,14 @@ class WriteService implements WriteServiceInterface
public function delete($cartId)
{
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
if (!$quote->getItemsCount()) {
throw new NoSuchEntityException("Cart $cartId doesn't contain products");
}
$quote->getShippingAddress()->setCollectShippingRates(true);
try {
$quote->setCouponCode('');
- $quote->collectTotals()->save();
+ $this->quoteRepository->save($quote->collectTotals());
} catch (\Exception $e) {
throw new CouldNotDeleteException('Could not delete coupon code');
}
diff --git a/app/code/Magento/Checkout/Service/V1/Item/ReadService.php b/app/code/Magento/Checkout/Service/V1/Item/ReadService.php
index 30f4b5b7887386d30639157b72c77e6469556669..a11c5113cb2916b8e333d4c4812db204b338f7e7 100644
--- a/app/code/Magento/Checkout/Service/V1/Item/ReadService.php
+++ b/app/code/Magento/Checkout/Service/V1/Item/ReadService.php
@@ -67,7 +67,7 @@ class ReadService implements ReadServiceInterface
{
$output = [];
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
/** @var \Magento\Sales\Model\Quote\Item $item */
foreach ($quote->getAllItems() as $item) {
diff --git a/app/code/Magento/Checkout/Service/V1/Item/WriteService.php b/app/code/Magento/Checkout/Service/V1/Item/WriteService.php
index 3cb79d5b15c0df39acd610b10ebf9a0b2a3bf5fd..29490d46e812f953f793b27648ed936088564e39 100644
--- a/app/code/Magento/Checkout/Service/V1/Item/WriteService.php
+++ b/app/code/Magento/Checkout/Service/V1/Item/WriteService.php
@@ -77,13 +77,13 @@ class WriteService implements WriteServiceInterface
throw InputException::invalidFieldValue('qty', $qty);
}
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
$product = $this->productLoader->load($data->getSku());
try {
$quote->addProduct($product, $qty);
- $quote->collectTotals()->save();
+ $this->quoteRepository->save($quote->collectTotals());
} catch (\Exception $e) {
throw new CouldNotSaveException('Could not add item to quote');
}
@@ -108,7 +108,7 @@ class WriteService implements WriteServiceInterface
throw InputException::invalidFieldValue('qty', $qty);
}
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
$quoteItem = $quote->getItemById($itemId);
if (!$quoteItem) {
throw new NoSuchEntityException("Cart $cartId doesn't contain item $itemId");
@@ -116,7 +116,7 @@ class WriteService implements WriteServiceInterface
$quoteItem->setData('qty', $qty);
try {
- $quote->collectTotals()->save();
+ $this->quoteRepository->save($quote->collectTotals());
} catch (\Exception $e) {
throw new CouldNotSaveException('Could not update quote item');
}
@@ -139,14 +139,14 @@ class WriteService implements WriteServiceInterface
*
* @var \Magento\Sales\Model\Quote $quote
*/
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
$quoteItem = $quote->getItemById($itemId);
if (!$quoteItem) {
throw new NoSuchEntityException("Cart $cartId doesn't contain item $itemId");
}
try {
$quote->removeItem($itemId);
- $quote->collectTotals()->save();
+ $this->quoteRepository->save($quote->collectTotals());
} catch (\Exception $e) {
throw new CouldNotSaveException('Could not remove item from quote');
}
diff --git a/app/code/Magento/Checkout/Service/V1/PaymentMethod/ReadService.php b/app/code/Magento/Checkout/Service/V1/PaymentMethod/ReadService.php
index 712a1399d94c85aa6c0385d9747681b1df2dd1d1..be1a2b66869491875ce6d43013d9d9829a27279d 100644
--- a/app/code/Magento/Checkout/Service/V1/PaymentMethod/ReadService.php
+++ b/app/code/Magento/Checkout/Service/V1/PaymentMethod/ReadService.php
@@ -92,7 +92,7 @@ class ReadService implements ReadServiceInterface
public function getPayment($cartId)
{
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
$payment = $quote->getPayment();
if (!$payment->getId()) {
return null;
@@ -111,7 +111,7 @@ class ReadService implements ReadServiceInterface
{
$output = [];
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
foreach ($this->methodList->getAvailableMethods($quote) as $method) {
$output[] = $this->paymentMethodConverter->toDataObject($method);
}
diff --git a/app/code/Magento/Checkout/Service/V1/PaymentMethod/WriteService.php b/app/code/Magento/Checkout/Service/V1/PaymentMethod/WriteService.php
index be815921f5272c1efa6929dd8ecb6a2ad1f315a8..fa808a50bb9ae3d9af220df2783b7f21abdc2cc3 100644
--- a/app/code/Magento/Checkout/Service/V1/PaymentMethod/WriteService.php
+++ b/app/code/Magento/Checkout/Service/V1/PaymentMethod/WriteService.php
@@ -81,7 +81,7 @@ class WriteService implements WriteServiceInterface
*/
public function set(\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod $method, $cartId)
{
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
$payment = $this->paymentMethodBuilder->build($method, $quote);
if ($quote->isVirtual()) {
diff --git a/app/code/Magento/Checkout/Service/V1/ShippingMethod/ReadService.php b/app/code/Magento/Checkout/Service/V1/ShippingMethod/ReadService.php
index cf914a488e724ead94b44248e6fe621c080eefd4..1fb2d5e18c2820c2a3d20a6102e6678fe93f7c7b 100644
--- a/app/code/Magento/Checkout/Service/V1/ShippingMethod/ReadService.php
+++ b/app/code/Magento/Checkout/Service/V1/ShippingMethod/ReadService.php
@@ -85,7 +85,7 @@ class ReadService implements ReadServiceInterface
public function getMethod($cartId)
{
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
/** @var \Magento\Sales\Model\Quote\Address $shippingAddress */
$shippingAddress = $quote->getShippingAddress();
@@ -143,7 +143,7 @@ class ReadService implements ReadServiceInterface
$output = [];
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
// no methods applicable for empty carts or carts with virtual products
if ($quote->isVirtual() || 0 == $quote->getItemsCount()) {
diff --git a/app/code/Magento/Checkout/Service/V1/ShippingMethod/WriteService.php b/app/code/Magento/Checkout/Service/V1/ShippingMethod/WriteService.php
index c372b11df1648851dd140c072d851048b03e6148..d9ee264e6076b00372be617dc021a48b9ebdbaf6 100644
--- a/app/code/Magento/Checkout/Service/V1/ShippingMethod/WriteService.php
+++ b/app/code/Magento/Checkout/Service/V1/ShippingMethod/WriteService.php
@@ -77,7 +77,7 @@ class WriteService implements WriteServiceInterface
public function setMethod($cartId, $carrierCode, $methodCode)
{
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
if (0 == $quote->getItemsCount()) {
throw new InputException('Shipping method is not applicable for empty cart');
}
@@ -101,7 +101,7 @@ class WriteService implements WriteServiceInterface
throw new NoSuchEntityException('Carrier with such method not found: ' . $carrierCode . ', ' . $methodCode);
}
try {
- $quote->collectTotals()->save();
+ $this->quoteRepository->save($quote->collectTotals());
} catch (\Exception $e) {
throw new CouldNotSaveException('Cannot set shipping method. ' . $e->getMessage());
}
diff --git a/app/code/Magento/Checkout/composer.json b/app/code/Magento/Checkout/composer.json
index 2473c609a809fb8abc16837231788707412bbe52..937f3f423889409960f1d90e37db08367435414b 100644
--- a/app/code/Magento/Checkout/composer.json
+++ b/app/code/Magento/Checkout/composer.json
@@ -3,27 +3,27 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-authorization": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-gift-message": "0.1.0-alpha104",
- "magento/module-wishlist": "0.1.0-alpha104",
- "magento/module-page-cache": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-msrp": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-authorization": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-gift-message": "0.1.0-alpha105",
+ "magento/module-wishlist": "0.1.0-alpha105",
+ "magento/module-page-cache": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-msrp": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/minicart.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/minicart.phtml
index a3425177d2a5a87d62e10e4c5699acbbb45cb87d..53229beb77ac308586c8b0cc585720e25812f6de 100644
--- a/app/code/Magento/Checkout/view/frontend/templates/cart/minicart.phtml
+++ b/app/code/Magento/Checkout/view/frontend/templates/cart/minicart.phtml
@@ -98,14 +98,18 @@
<?php endif ?>
<?php endif; ?>
<script type="text/javascript">
- (function($) {
+ require([
+ "jquery",
+ "mage/mage"
+ ], function($){
+ "use strict";
$('[data-block="minicart"]').mage('sidebar', {
checkoutUrl: '<?php echo $this->getCheckoutUrl();?>',
checkoutButton: '#top-cart-btn-checkout',
removeButton: '#mini-cart a.action.delete',
confirmMessage: '<?php echo __('Are you sure you would like to remove this item from the shopping cart?') ?>'
});
- })(jQuery);
+ });
</script>
<?php if ($this->getInList()): ?>
</li>
diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/login.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/login.phtml
index 5f4431eb6abb256f644fb8a4629f30cef3f8e38c..78ff615077d56a7d3b7b03ff9c82a4b44b227e1c 100644
--- a/app/code/Magento/Checkout/view/frontend/templates/onepage/login.phtml
+++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/login.phtml
@@ -61,7 +61,7 @@
<button type="submit" class="action login primary" data-action="checkout-method-login"><span><?php echo __('Login') ?></span></button>
</div>
<div class="secondary">
- <a class="action remind" href="<?php echo $this->helper('Magento\Customer\Helper\Data')->getForgotPasswordUrl()?>">
+ <a class="action remind" href="<?php echo $this->getForgotPasswordUrl()?>">
<span><?php echo __('Forgot Your Password?') ?></span>
</a>
</div>
@@ -70,13 +70,13 @@
</form>
</div>
</div>
-<?php if ( $this->isAllowedGuestCheckout() || $this->helper('Magento\Customer\Helper\Data')->isRegistrationAllowed() ): ?>
+<?php if ( $this->isAllowedGuestCheckout() || $this->getRegistration()->isAllowed() ): ?>
<div class="block guest">
<div class="title">
<strong>
- <?php if( $this->isAllowedGuestCheckout() && $this->helper('Magento\Customer\Helper\Data')->isRegistrationAllowed() ): ?>
+ <?php if( $this->isAllowedGuestCheckout() && $this->getRegistration()->isAllowed() ): ?>
<?php echo __('Checkout as a Guest or Register') ?>
- <?php elseif ( $this->isAllowedGuestCheckout() && !$this->helper('Magento\Customer\Helper\Data')->isRegistrationAllowed() ): ?>
+ <?php elseif ( $this->isAllowedGuestCheckout() && !$this->getRegistration()->isAllowed() ): ?>
<?php echo __('Checkout as a Guest') ?>
<?php else: ?>
<?php echo __('Register to Create an Account') ?>
@@ -84,14 +84,14 @@
</strong>
</div>
<div class="content">
- <?php if( !$this->isAllowedGuestCheckout() && $this->helper('Magento\Customer\Helper\Data')->isRegistrationAllowed() ): ?>
+ <?php if( !$this->isAllowedGuestCheckout() && $this->getRegistration()->isAllowed() ): ?>
<p><strong><?php echo __('Register and save time!') ?></strong><br />
<?php echo __('Register with us for future convenience:') ?></p>
<ul>
<li><?php echo __('Fast and easy check out') ?></li>
<li><?php echo __('Easy access to your order history and status') ?></li>
</ul>
- <?php elseif( $this->isAllowedGuestCheckout() && $this->helper('Magento\Customer\Helper\Data')->isRegistrationAllowed() ): ?>
+ <?php elseif( $this->isAllowedGuestCheckout() && $this->getRegistration()->isAllowed() ): ?>
<p class="note"><?php echo __('Register with us for future convenience:') ?></p>
<?php endif ?>
@@ -101,7 +101,7 @@
<input type="radio" name="checkout_method" data-role="checkout-method-guest" id="login:guest" value="guest"<?php if($this->getQuote()->getCheckoutMethod()==Magento\Checkout\Model\Type\Onepage::METHOD_GUEST): ?> checked="checked"<?php endif; ?> class="radio" />
<label class="label" for="login:guest"><span><?php echo __('Checkout as Guest') ?></span></label>
</div>
- <?php if( $this->helper('Magento\Customer\Helper\Data')->isRegistrationAllowed() ): ?>
+ <?php if( $this->getRegistration()->isAllowed() ): ?>
<div class="field choice">
<input type="radio" name="checkout_method" data-role="checkout-method-register" id="login:register" value="register"<?php if($this->getQuote()->getCheckoutMethod()==Magento\Checkout\Model\Type\Onepage::METHOD_REGISTER || !$this->isAllowedGuestCheckout()): ?> checked="checked"<?php endif ?> class="radio" />
<label class="label" for="login:register"><span><?php echo __('Register') ?></span></label>
@@ -115,7 +115,7 @@
<button data-role="opc-continue" id="onepage-guest-register-button" type="button" class="action continue primary" data-checkout='{"isGuestCheckoutAllowed":true}'><span><?php echo __('Continue') ?></span></button>
<?php elseif ($this->helper('Magento\Checkout\Helper\Data')->isCustomerMustBeLogged()): ?>
<input type="checkbox" name="checkout_method" id="login:register" value="register" checked="checked" style="display: none"/>
- <button data-role="opc-continue" id="onepage-guest-register-button" type="button" class="action register primary" data-checkout='{"isGuestCheckoutAllowed":false, "registrationUrl":"<?php echo $this->helper('Magento\Customer\Helper\Data')->getRegisterUrl();?>"}'><span><?php echo __('Register') ?></span></button>
+ <button data-role="opc-continue" id="onepage-guest-register-button" type="button" class="action register primary" data-checkout='{"isGuestCheckoutAllowed":false, "registrationUrl":"<?php echo $this->getRegisterUrl();?>"}'><span><?php echo __('Register') ?></span></button>
<?php else: ?>
<input type="checkbox" name="checkout_method" data-role="checkout-method-register" id="login:register" value="register" checked="checked" style="display: none"/>
<button data-role="opc-continue" id="onepage-guest-register-button" type="button" class="action register primary" data-checkout='{"isGuestCheckoutAllowed":true}'><span><?php echo __('Register') ?></span></button>
diff --git a/app/code/Magento/CheckoutAgreements/composer.json b/app/code/Magento/CheckoutAgreements/composer.json
index ba7889471063374dfe9cacd810b8012b9ad482a1..927f1a0eb67c1896398a403a8fe55b58508ddbd4 100644
--- a/app/code/Magento/CheckoutAgreements/composer.json
+++ b/app/code/Magento/CheckoutAgreements/composer.json
@@ -3,14 +3,14 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Cms/Api/Data/PageCollectionInterface.php b/app/code/Magento/Cms/Api/Data/PageCollectionInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..199baacb6a4c0aa915341dc856c52654a131a4c3
--- /dev/null
+++ b/app/code/Magento/Cms/Api/Data/PageCollectionInterface.php
@@ -0,0 +1,52 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+/**
+ * Page collection interface
+ */
+namespace Magento\Cms\Api\Data;
+
+use Magento\Framework\Data\SearchResultInterface;
+
+/**
+ * Interface PageCollectionInterface
+ * @package Magento\Cms\Api\Data
+ */
+interface PageCollectionInterface extends SearchResultInterface
+{
+ /**
+ * Get items
+ *
+ * @return \Magento\Cms\Api\Data\PageInterface[]
+ */
+ public function getItems();
+
+ /**
+ * Returns pairs identifier - title for unique identifiers
+ * and pairs identifier|page_id - title for non-unique after first
+ *
+ * @return array
+ */
+ public function toOptionIdArray();
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeOnProductForm.php b/app/code/Magento/Cms/Api/Data/PageInterface.php
similarity index 68%
rename from dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeOnProductForm.php
rename to app/code/Magento/Cms/Api/Data/PageInterface.php
index 74960e44340fad8f1aa98e01abee5a417712ceb0..631f3ed18cc5dcca68144b028556818ce6f7cabb 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeOnProductForm.php
+++ b/app/code/Magento/Cms/Api/Data/PageInterface.php
@@ -21,36 +21,39 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-
-namespace Magento\Catalog\Test\Constraint;
-
-use Mtf\Constraint\AbstractConstraint;
+namespace Magento\Cms\Api\Data;
/**
- * Class AssertProductAttributeOnProductForm
+ * Interface Page
+ * @package Magento\Cms\Api\Data
+ * @data-api
*/
-class AssertProductAttributeOnProductForm extends AbstractConstraint
+interface PageInterface
{
+ const PAGE_ID = 'page_id';
+
+ const IDENTIFIER = 'identifier';
+
+ const TITLE = 'title';
+
/**
- * Constraint severeness
+ * Retrieve page identifier
*
- * @var string
+ * @return int
*/
- protected $severeness = 'low';
+ public function getPageId();
/**
- * @return void
+ * Retrieve page identifier
+ *
+ * @return int
*/
- public function processAssert()
- {
- //
- }
+ public function getIdentifier();
/**
+ * Retrieve page title
+ *
* @return string
*/
- public function toString()
- {
- //
- }
+ public function getTitle();
}
diff --git a/app/code/Magento/Cms/Api/PageCriteriaInterface.php b/app/code/Magento/Cms/Api/PageCriteriaInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..5496a782f964ebf1247615844002dfdcf14c5672
--- /dev/null
+++ b/app/code/Magento/Cms/Api/PageCriteriaInterface.php
@@ -0,0 +1,55 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Cms\Api;
+
+/**
+ * Interface PageCriteriaInterface
+ */
+interface PageCriteriaInterface extends \Magento\Framework\Api\CriteriaInterface
+{
+ /**
+ * Add Criteria object
+ *
+ * @param \Magento\Cms\Api\PageCriteriaInterface $criteria
+ * @return void
+ */
+ public function addCriteria(\Magento\Cms\Api\PageCriteriaInterface $criteria);
+
+ /**
+ * Set first store flag
+ *
+ * @param bool $flag
+ * @return void
+ */
+ public function setFirstStoreFlag($flag = false);
+
+ /**
+ * Add filter by store
+ *
+ * @param int|\Magento\Store\Model\Store $store
+ * @param bool $withAdmin
+ * @return void
+ */
+ public function addStoreFilter($store, $withAdmin = true);
+}
diff --git a/app/code/Magento/Cms/Api/PageRepositoryInterface.php b/app/code/Magento/Cms/Api/PageRepositoryInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..9776d71356217ccad7e9749c5f422e85f6e3eca8
--- /dev/null
+++ b/app/code/Magento/Cms/Api/PageRepositoryInterface.php
@@ -0,0 +1,70 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Cms\Api;
+
+/**
+ * Interface PageRepositoryInterface
+ */
+interface PageRepositoryInterface
+{
+ /**
+ * Save Page data
+ *
+ * @param \Magento\Cms\Api\Data\PageInterface $page
+ * @return \Magento\Cms\Api\Data\PageInterface
+ */
+ public function save(\Magento\Cms\Api\Data\PageInterface $page);
+
+ /**
+ * Load Page data by given Page Identity
+ *
+ * @param string $pageId
+ * @return \Magento\Cms\Api\Data\PageInterface
+ */
+ public function get($pageId);
+
+ /**
+ * Load Page data collection by given search criteria
+ *
+ * @param \Magento\Cms\Api\PageCriteriaInterface $criteria
+ * @return \Magento\Cms\Api\Data\PageCollectionInterface
+ */
+ public function getList(\Magento\Cms\Api\PageCriteriaInterface $criteria);
+
+ /**
+ * Delete Page
+ *
+ * @param \Magento\Cms\Api\Data\PageInterface $page
+ * @return bool
+ */
+ public function delete(\Magento\Cms\Api\Data\PageInterface $page);
+
+ /**
+ * Delete Page by given Page Identity
+ *
+ * @param string $pageId
+ * @return bool
+ */
+ public function deleteById($pageId);
+}
diff --git a/app/code/Magento/Cms/Block/Adminhtml/Page/Grid.php b/app/code/Magento/Cms/Block/Adminhtml/Page/Grid.php
index 690c14c619635cd56422ecf56c993222d5233222..782de926e24e3ed35c7ceafcbe3999720b6b8bb8 100644
--- a/app/code/Magento/Cms/Block/Adminhtml/Page/Grid.php
+++ b/app/code/Magento/Cms/Block/Adminhtml/Page/Grid.php
@@ -29,7 +29,7 @@ namespace Magento\Cms\Block\Adminhtml\Page;
class Grid extends \Magento\Backend\Block\Widget\Grid\Extended
{
/**
- * @var \Magento\Cms\Model\Resource\Page\CollectionFactory
+ * @var \Magento\Cms\Model\Resource\Page\Grid\CollectionFactory
*/
protected $_collectionFactory;
@@ -47,7 +47,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid\Extended
* @param \Magento\Backend\Block\Template\Context $context
* @param \Magento\Backend\Helper\Data $backendHelper
* @param \Magento\Cms\Model\Page $cmsPage
- * @param \Magento\Cms\Model\Resource\Page\CollectionFactory $collectionFactory
+ * @param \Magento\Cms\Model\Resource\Page\Grid\CollectionFactory $collectionFactory
* @param \Magento\Core\Model\PageLayout\Config\Builder $pageLayoutBuilder
* @param array $data
*/
@@ -55,12 +55,12 @@ class Grid extends \Magento\Backend\Block\Widget\Grid\Extended
\Magento\Backend\Block\Template\Context $context,
\Magento\Backend\Helper\Data $backendHelper,
\Magento\Cms\Model\Page $cmsPage,
- \Magento\Cms\Model\Resource\Page\CollectionFactory $collectionFactory,
+ \Magento\Cms\Model\Resource\Page\Grid\CollectionFactory $collectionFactory,
\Magento\Core\Model\PageLayout\Config\Builder $pageLayoutBuilder,
array $data = array()
) {
$this->_collectionFactory = $collectionFactory;
- $this->_cmsPage = $cmsPage;
+ $this->_cmsPage = $cmsPage;
$this->pageLayoutBuilder = $pageLayoutBuilder;
parent::__construct($context, $backendHelper, $data);
}
@@ -84,7 +84,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid\Extended
protected function _prepareCollection()
{
$collection = $this->_collectionFactory->create();
- /* @var $collection \Magento\Cms\Model\Resource\Page\Collection */
+ /* @var $collection \Magento\Cms\Model\Resource\Page\Grid\Collection */
$collection->setFirstStoreFlag(true);
$this->setCollection($collection);
diff --git a/app/code/Magento/Cms/Model/Config/Source/Page.php b/app/code/Magento/Cms/Model/Config/Source/Page.php
index 7313037d6ddad7245fde4a34fe69a5eedaf748ec..97f3a45cd95c0bcb0b5c1158115b4206a6b6c0e9 100644
--- a/app/code/Magento/Cms/Model/Config/Source/Page.php
+++ b/app/code/Magento/Cms/Model/Config/Source/Page.php
@@ -23,24 +23,36 @@
*/
namespace Magento\Cms\Model\Config\Source;
+/**
+ * Class Page
+ */
class Page implements \Magento\Framework\Option\ArrayInterface
{
/**
* @var array
*/
- protected $_options;
+ protected $options;
/**
- * @var \Magento\Cms\Model\Resource\Page\CollectionFactory
+ * @var \Magento\Cms\Api\PageRepositoryInterface
*/
- protected $_pageCollectionFactory;
+ protected $pageRepository;
/**
- * @param \Magento\Cms\Model\Resource\Page\CollectionFactory $pageCollectionFactory
+ * @var \Magento\Cms\Api\PageCriteriaInterfaceFactory
*/
- public function __construct(\Magento\Cms\Model\Resource\Page\CollectionFactory $pageCollectionFactory)
- {
- $this->_pageCollectionFactory = $pageCollectionFactory;
+ protected $pageCriteriaFactory;
+
+ /**
+ * @param \Magento\Cms\Api\PageRepositoryInterface $pageRepository
+ * @param \Magento\Cms\Api\PageCriteriaInterfaceFactory $pageCriteriaFactory
+ */
+ public function __construct(
+ \Magento\Cms\Api\PageRepositoryInterface $pageRepository,
+ \Magento\Cms\Api\PageCriteriaInterfaceFactory $pageCriteriaFactory
+ ) {
+ $this->pageRepository = $pageRepository;
+ $this->pageCriteriaFactory = $pageCriteriaFactory;
}
/**
@@ -50,9 +62,9 @@ class Page implements \Magento\Framework\Option\ArrayInterface
*/
public function toOptionArray()
{
- if (!$this->_options) {
- $this->_options = $this->_pageCollectionFactory->create()->load()->toOptionIdArray();
+ if (!$this->options) {
+ $this->options = $this->pageRepository->getList($this->pageCriteriaFactory->create())->toOptionIdArray();
}
- return $this->_options;
+ return $this->options;
}
}
diff --git a/app/code/Magento/Cms/Model/DataSource/PageCollection.php b/app/code/Magento/Cms/Model/DataSource/PageCollection.php
new file mode 100644
index 0000000000000000000000000000000000000000..e06b524185d0320211e6c2d8051220a6448a2040
--- /dev/null
+++ b/app/code/Magento/Cms/Model/DataSource/PageCollection.php
@@ -0,0 +1,89 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Cms\Model\DataSource;
+
+use Magento\Framework\Data\AbstractCriteria;
+use Magento\Framework\Data\CollectionDataSourceInterface;
+
+/**
+ * CMS page collection data source
+ *
+ * Class PageCollection
+ */
+class PageCollection extends AbstractCriteria implements CollectionDataSourceInterface
+{
+ /**
+ * @var \Magento\Cms\Api\PageCriteriaInterface
+ */
+ protected $criteria;
+
+ /**
+ * @var \Magento\Cms\Api\PageRepositoryInterface
+ */
+ protected $repository;
+
+ /**
+ * @param \Magento\Cms\Api\PageCriteriaInterface $criteria
+ * @param \Magento\Cms\Api\PageRepositoryInterface $repository
+ */
+ public function __construct(
+ \Magento\Cms\Api\PageCriteriaInterface $criteria,
+ \Magento\Cms\Api\PageRepositoryInterface $repository
+ ) {
+ $this->criteria = $criteria;
+ $this->repository = $repository;
+ $this->criteria->setFirstStoreFlag(true);
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function addFilter($name, $field, $condition = null, $type = 'public')
+ {
+ if ($field === 'store_id') {
+ $this->criteria->addStoreFilter($condition, false);
+ } else {
+ $this->criteria->addFilter($name, $field, $condition, $type);
+ }
+ }
+
+ /**
+ * @return \Magento\Cms\Api\Data\PageCollectionInterface
+ */
+ public function getResultCollection()
+ {
+ return $this->repository->getList($this->criteria);
+ }
+
+ /**
+ * Add Criteria object
+ *
+ * @param \Magento\Cms\Api\PageCriteriaInterface $criteria
+ * @return void
+ */
+ public function addCriteria(\Magento\Cms\Api\PageCriteriaInterface $criteria)
+ {
+ $this->data[self::PART_CRITERIA_LIST]['list'][] = $criteria;
+ }
+}
diff --git a/app/code/Magento/Cms/Model/Page.php b/app/code/Magento/Cms/Model/Page.php
index 2e3b9807d0ce84c96fadcb035d494df82a3444a0..0d1e2991bee2780b8bbfe3c6d1b699de39b766e9 100644
--- a/app/code/Magento/Cms/Model/Page.php
+++ b/app/code/Magento/Cms/Model/Page.php
@@ -23,12 +23,13 @@
*/
namespace Magento\Cms\Model;
+use Magento\Cms\Api\Data\PageInterface;
+
/**
* Cms Page Model
*
* @method \Magento\Cms\Model\Resource\Page _getResource()
* @method \Magento\Cms\Model\Resource\Page getResource()
- * @method string getTitle()
* @method \Magento\Cms\Model\Page setTitle(string $value)
* @method string getPageLayout()
* @method \Magento\Cms\Model\Page setPageLayout(string $value)
@@ -36,7 +37,6 @@ namespace Magento\Cms\Model;
* @method \Magento\Cms\Model\Page setMetaKeywords(string $value)
* @method string getMetaDescription()
* @method \Magento\Cms\Model\Page setMetaDescription(string $value)
- * @method string getIdentifier()
* @method \Magento\Cms\Model\Page setIdentifier(string $value)
* @method string getContentHeading()
* @method \Magento\Cms\Model\Page setContentHeading(string $value)
@@ -64,7 +64,7 @@ namespace Magento\Cms\Model;
* @method \Magento\Cms\Model\Page setCustomThemeTo(string $value)
* @method int[] getStores()
*/
-class Page extends \Magento\Framework\Model\AbstractModel implements \Magento\Framework\Object\IdentityInterface
+class Page extends \Magento\Framework\Model\AbstractModel implements \Magento\Framework\Object\IdentityInterface, PageInterface
{
/**
* No route page id
@@ -105,6 +105,30 @@ class Page extends \Magento\Framework\Model\AbstractModel implements \Magento\Fr
$this->_init('Magento\Cms\Model\Resource\Page');
}
+ /**
+ * @return int
+ */
+ public function getPageId()
+ {
+ return (int) $this->_getData(PageInterface::PAGE_ID);
+ }
+
+ /**
+ * @return string
+ */
+ public function getIdentifier()
+ {
+ return (string) $this->_getData(PageInterface::IDENTIFIER);
+ }
+
+ /**
+ * @return string
+ */
+ public function getTitle()
+ {
+ return $this->_getData(PageInterface::TITLE);
+ }
+
/**
* Load object data
*
diff --git a/app/code/Magento/Cms/Model/PageRepository.php b/app/code/Magento/Cms/Model/PageRepository.php
new file mode 100644
index 0000000000000000000000000000000000000000..4dc5fc4acad88b2c90cb725cefce6978f139b98c
--- /dev/null
+++ b/app/code/Magento/Cms/Model/PageRepository.php
@@ -0,0 +1,162 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Cms\Model;
+
+use Magento\Cms\Api\PageRepositoryInterface;
+use Magento\Framework\Exception\CouldNotDeleteException;
+use Magento\Framework\Exception\CouldNotSaveException;
+use Magento\Framework\Exception\NoSuchEntityException;
+
+/**
+ * Class PageRepository
+ * @api
+ */
+class PageRepository implements PageRepositoryInterface
+{
+ /**
+ * @var \Magento\Cms\Model\Resource\Page
+ */
+ protected $resource;
+
+ /**
+ * @var \Magento\Cms\Api\Data\PageInterfaceFactory
+ */
+ protected $pageFactory;
+
+ /**
+ * @var \Magento\Cms\Api\Data\PageCollectionInterfaceFactory
+ */
+ protected $pageCollectionFactory;
+
+ /**
+ * @var \Magento\Framework\DB\QueryBuilderFactory
+ */
+ protected $queryBuilderFactory;
+
+ /**
+ * @var \Magento\Framework\DB\MapperFactory
+ */
+ protected $mapperFactory;
+
+ /**
+ * @param Resource\Page $resource
+ * @param \Magento\Cms\Api\Data\PageInterfaceFactory $pageFactory
+ * @param \Magento\Cms\Api\Data\PageCollectionInterfaceFactory $pageCollectionFactory
+ * @param \Magento\Framework\DB\QueryBuilderFactory $queryBuilderFactory
+ * @param \Magento\Framework\DB\MapperFactory $mapperFactory
+ */
+ public function __construct(
+ \Magento\Cms\Model\Resource\Page $resource,
+ \Magento\Cms\Api\Data\PageInterfaceFactory $pageFactory,
+ \Magento\Cms\Api\Data\PageCollectionInterfaceFactory $pageCollectionFactory,
+ \Magento\Framework\DB\QueryBuilderFactory $queryBuilderFactory,
+ \Magento\Framework\DB\MapperFactory $mapperFactory
+ ) {
+ $this->resource = $resource;
+ $this->pageFactory = $pageFactory;
+ $this->pageCollectionFactory = $pageCollectionFactory;
+ $this->queryBuilderFactory = $queryBuilderFactory;
+ $this->mapperFactory = $mapperFactory;
+ }
+
+ /**
+ * Save Page data
+ *
+ * @param \Magento\Cms\Api\Data\PageInterface $page
+ * @return \Magento\Cms\Api\Data\PageInterface
+ * @throws CouldNotSaveException
+ */
+ public function save(\Magento\Cms\Api\Data\PageInterface $page)
+ {
+ try {
+ $this->resource->save($page);
+ } catch (\Exception $exception) {
+ throw new CouldNotSaveException($exception->getMessage());
+ }
+ return $page;
+ }
+
+ /**
+ * Load Page data by given Page Identity
+ *
+ * @param string $pageId
+ * @return \Magento\Cms\Api\Data\PageInterface
+ * @throws \Magento\Framework\Exception\NoSuchEntityException
+ */
+ public function get($pageId)
+ {
+ $page = $this->pageFactory->create();
+ $this->resource->load($page, $pageId);
+ if (!$page->getPageId()) {
+ throw new NoSuchEntityException(sprintf('CMS Page with id "%s" does not exist.', $pageId));
+ }
+ return $page;
+ }
+
+ /**
+ * Load Page data collection by given search criteria
+ *
+ * @param \Magento\Cms\Api\PageCriteriaInterface $criteria
+ * @return \Magento\Cms\Api\Data\PageCollectionInterface
+ */
+ public function getList(\Magento\Cms\Api\PageCriteriaInterface $criteria)
+ {
+ $queryBuilder = $this->queryBuilderFactory->create();
+ $queryBuilder->setCriteria($criteria);
+ $queryBuilder->setResource($this->resource);
+ $query = $queryBuilder->create();
+ $collection = $this->pageCollectionFactory->create(['query' => $query]);
+ return $collection;
+ }
+
+ /**
+ * Delete Page
+ *
+ * @param \Magento\Cms\Api\Data\PageInterface $page
+ * @return bool
+ * @throws \Magento\Framework\Exception\CouldNotDeleteException
+ */
+ public function delete(\Magento\Cms\Api\Data\PageInterface $page)
+ {
+ try {
+ $this->resource->delete($page);
+ } catch (\Exception $exception) {
+ throw new CouldNotDeleteException($exception->getMessage());
+ }
+ return true;
+ }
+
+ /**
+ * Delete Page by given Page Identity
+ *
+ * @param string $pageId
+ * @return bool
+ * @throws \Magento\Framework\Exception\CouldNotDeleteException
+ * @throws \Magento\Framework\Exception\NoSuchEntityException
+ */
+ public function deleteById($pageId)
+ {
+ return $this->delete($this->get($pageId));
+ }
+}
diff --git a/app/code/Magento/Cms/Model/Resource/Page/Collection.php b/app/code/Magento/Cms/Model/Resource/Page/Collection.php
index 030486139be9a1a8d8103d7e63c1d2b7efa97b48..8cd0df89e4911fde23d959e1082abba79776011a 100644
--- a/app/code/Magento/Cms/Model/Resource/Page/Collection.php
+++ b/app/code/Magento/Cms/Model/Resource/Page/Collection.php
@@ -23,197 +23,131 @@
*/
namespace Magento\Cms\Model\Resource\Page;
+use Magento\Cms\Api\Data\PageCollectionInterface;
+use Magento\Cms\Api\Data\PageInterface;
+use Magento\Framework\Data\AbstractSearchResult;
+use Magento\Framework\Data\Collection\EntityFactoryInterface;
+use Magento\Framework\Data\SearchResultIteratorFactory;
+use Magento\Framework\DB\QueryInterface;
+use Magento\Framework\Event\ManagerInterface;
+use Magento\Framework\StoreManagerInterface;
+use Magento\Framework\Data\SearchResultProcessorFactory;
+use Magento\Framework\Data\SearchResultProcessor;
+
/**
* CMS page collection
*/
-class Collection extends \Magento\Framework\Model\Resource\Db\Collection\AbstractCollection
+class Collection extends AbstractSearchResult implements PageCollectionInterface
{
/**
- * Load data for preview flag
- *
- * @var bool
+ * @var StoreManagerInterface
*/
- protected $_previewFlag;
+ protected $storeManager;
/**
- * Store manager
- *
- * @var \Magento\Framework\StoreManagerInterface
+ * @var SearchResultProcessor
*/
- protected $_storeManager;
+ protected $searchResultProcessor;
/**
- * @param \Magento\Core\Model\EntityFactory $entityFactory
- * @param \Magento\Framework\Logger $logger
- * @param \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy
- * @param \Magento\Framework\Event\ManagerInterface $eventManager
- * @param \Magento\Framework\StoreManagerInterface $storeManager
- * @param mixed $connection
- * @param \Magento\Framework\Model\Resource\Db\AbstractDb $resource
+ * @param QueryInterface $query
+ * @param EntityFactoryInterface $entityFactory
+ * @param ManagerInterface $eventManager
+ * @param SearchResultIteratorFactory $resultIteratorFactory
+ * @param StoreManagerInterface $storeManager
+ * @param SearchResultProcessorFactory $searchResultProcessorFactory
*/
public function __construct(
- \Magento\Core\Model\EntityFactory $entityFactory,
- \Magento\Framework\Logger $logger,
- \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy,
- \Magento\Framework\Event\ManagerInterface $eventManager,
- \Magento\Framework\StoreManagerInterface $storeManager,
- $connection = null,
- \Magento\Framework\Model\Resource\Db\AbstractDb $resource = null
+ QueryInterface $query,
+ EntityFactoryInterface $entityFactory,
+ ManagerInterface $eventManager,
+ SearchResultIteratorFactory $resultIteratorFactory,
+ StoreManagerInterface $storeManager,
+ SearchResultProcessorFactory $searchResultProcessorFactory
) {
- parent::__construct($entityFactory, $logger, $fetchStrategy, $eventManager, $connection, $resource);
- $this->_storeManager = $storeManager;
+ $this->storeManager = $storeManager;
+ $this->searchResultProcessor = $searchResultProcessorFactory->create($this);
+ parent::__construct($query, $entityFactory, $eventManager, $resultIteratorFactory);
}
/**
- * Define resource model
- *
* @return void
*/
- protected function _construct()
+ protected function init()
{
- $this->_init('Magento\Cms\Model\Page', 'Magento\Cms\Model\Resource\Page');
- $this->_map['fields']['page_id'] = 'main_table.page_id';
- $this->_map['fields']['store'] = 'store_table.store_id';
+ $this->setDataInterfaceName('Magento\Cms\Api\Data\PageInterface');
+ $this->query->addCountSqlSkipPart(\Zend_Db_Select::GROUP, true);
}
/**
- * Returns pairs identifier - title for unique identifiers
- * and pairs identifier|page_id - title for non-unique after first
- *
* @return array
*/
public function toOptionIdArray()
{
- $res = array();
- $existingIdentifiers = array();
- foreach ($this as $item) {
- $identifier = $item->getData('identifier');
+ $res = [];
+ $existingIdentifiers = [];
+ foreach ($this->getItems() as $item) {
+ /** @var PageInterface $item */
+ $identifier = $item->getIdentifier();
$data['value'] = $identifier;
- $data['label'] = $item->getData('title');
+ $data['label'] = $item->getTitle();
if (in_array($identifier, $existingIdentifiers)) {
- $data['value'] .= '|' . $item->getData('page_id');
+ $data['value'] .= '|' . $item->getPageId();
} else {
$existingIdentifiers[] = $identifier;
}
-
$res[] = $data;
}
-
return $res;
}
/**
- * Set first store flag
- *
- * @param bool $flag
- * @return $this
+ * @deprecated
+ * @return void
*/
- public function setFirstStoreFlag($flag = false)
+ public function addStoreFilter()
{
- $this->_previewFlag = $flag;
- return $this;
+ //
}
/**
* Perform operations after collection load
*
- * @return $this
+ * @return void
*/
- protected function _afterLoad()
+ protected function afterLoad()
{
- if ($this->_previewFlag) {
- $items = $this->getColumnValues('page_id');
- $connection = $this->getConnection();
- if (count($items)) {
- $select = $connection->select()->from(
- array('cps' => $this->getTable('cms_page_store'))
- )->where(
- 'cps.page_id IN (?)',
- $items
- );
+ if ($this->getSearchCriteria()->getPart('first_store_flag')) {
+ $items = $this->searchResultProcessor->getColumnValues('page_id');
+ $connection = $this->getQuery()->getConnection();
+ $resource = $this->getQuery()->getResource();
+ if (count($items)) {
+ $select = $connection->select()->from(['cps' => $resource->getTable('cms_page_store')])
+ ->where('cps.page_id IN (?)', $items);
if ($result = $connection->fetchPairs($select)) {
- foreach ($this as $item) {
- if (!isset($result[$item->getData('page_id')])) {
+ foreach ($this->getItems() as $item) {
+ /** @var PageInterface $item */
+ if (!isset($result[$item->getPageId()])) {
continue;
}
- if ($result[$item->getData('page_id')] == 0) {
- $stores = $this->_storeManager->getStores(false, true);
+ if ($result[$item->getPageId()] == 0) {
+ $stores = $this->storeManager->getStores(false, true);
$storeId = current($stores)->getId();
$storeCode = key($stores);
} else {
- $storeId = $result[$item->getData('page_id')];
- $storeCode = $this->_storeManager->getStore($storeId)->getCode();
+ $storeId = $result[$item->getPageId()];
+ $storeCode = $this->storeManager->getStore($storeId)->getCode();
}
$item->setData('_first_store_id', $storeId);
$item->setData('store_code', $storeCode);
+ $item->setData('store_id', [$result[$item->getPageId()]]);
}
}
}
}
-
- return parent::_afterLoad();
- }
-
- /**
- * Add filter by store
- *
- * @param int|\Magento\Store\Model\Store $store
- * @param bool $withAdmin
- * @return $this
- */
- public function addStoreFilter($store, $withAdmin = true)
- {
- if (!$this->getFlag('store_filter_added')) {
- if ($store instanceof \Magento\Store\Model\Store) {
- $store = array($store->getId());
- }
-
- if (!is_array($store)) {
- $store = array($store);
- }
-
- if ($withAdmin) {
- $store[] = \Magento\Store\Model\Store::DEFAULT_STORE_ID;
- }
-
- $this->addFilter('store', array('in' => $store), 'public');
- }
- return $this;
- }
-
- /**
- * Join store relation table if there is store filter
- *
- * @return void
- */
- protected function _renderFiltersBefore()
- {
- if ($this->getFilter('store')) {
- $this->getSelect()->join(
- array('store_table' => $this->getTable('cms_page_store')),
- 'main_table.page_id = store_table.page_id',
- array()
- )->group(
- 'main_table.page_id'
- );
- }
- return parent::_renderFiltersBefore();
- }
-
- /**
- * Get SQL for get record count.
- * Extra GROUP BY strip added.
- *
- * @return \Magento\Framework\DB\Select
- */
- public function getSelectCountSql()
- {
- $countSelect = parent::getSelectCountSql();
- $countSelect->reset(\Zend_Db_Select::GROUP);
-
- return $countSelect;
+ parent::afterLoad();
}
}
diff --git a/app/code/Magento/Cms/Model/Resource/Page/Grid/Collection.php b/app/code/Magento/Cms/Model/Resource/Page/Grid/Collection.php
index 0d91cd6a75f634378b64b6a2a006bf56599072a6..eeb42ab18aa2055a20ab6f61fd5a0e91db6e1fec 100644
--- a/app/code/Magento/Cms/Model/Resource/Page/Grid/Collection.php
+++ b/app/code/Magento/Cms/Model/Resource/Page/Grid/Collection.php
@@ -23,15 +23,101 @@
*/
namespace Magento\Cms\Model\Resource\Page\Grid;
-use Magento\Cms\Model\Resource\Page\Collection as PageCollection;
-
/**
* CMS page collection
*
* Class Collection
*/
-class Collection extends PageCollection
+class Collection extends \Magento\Framework\Model\Resource\Db\Collection\AbstractCollection
{
+ /**
+ * Load data for preview flag
+ *
+ * @var bool
+ */
+ protected $_previewFlag;
+
+ /**
+ * Store manager
+ *
+ * @var \Magento\Framework\StoreManagerInterface
+ */
+ protected $_storeManager;
+
+ /**
+ * @param \Magento\Core\Model\EntityFactory $entityFactory
+ * @param \Magento\Framework\Logger $logger
+ * @param \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy
+ * @param \Magento\Framework\Event\ManagerInterface $eventManager
+ * @param \Magento\Framework\StoreManagerInterface $storeManager
+ * @param mixed $connection
+ * @param \Magento\Framework\Model\Resource\Db\AbstractDb $resource
+ */
+ public function __construct(
+ \Magento\Core\Model\EntityFactory $entityFactory,
+ \Magento\Framework\Logger $logger,
+ \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy,
+ \Magento\Framework\Event\ManagerInterface $eventManager,
+ \Magento\Framework\StoreManagerInterface $storeManager,
+ $connection = null,
+ \Magento\Framework\Model\Resource\Db\AbstractDb $resource = null
+ ) {
+ parent::__construct($entityFactory, $logger, $fetchStrategy, $eventManager, $connection, $resource);
+ $this->_storeManager = $storeManager;
+ }
+
+ /**
+ * Define resource model
+ *
+ * @return void
+ */
+ protected function _construct()
+ {
+ $this->_init('Magento\Cms\Model\Page', 'Magento\Cms\Model\Resource\Page');
+ $this->_map['fields']['page_id'] = 'main_table.page_id';
+ $this->_map['fields']['store'] = 'store_table.store_id';
+ }
+
+ /**
+ * Returns pairs identifier - title for unique identifiers
+ * and pairs identifier|page_id - title for non-unique after first
+ *
+ * @return array
+ */
+ public function toOptionIdArray()
+ {
+ $res = array();
+ $existingIdentifiers = array();
+ foreach ($this as $item) {
+ $identifier = $item->getData('identifier');
+
+ $data['value'] = $identifier;
+ $data['label'] = $item->getData('title');
+
+ if (in_array($identifier, $existingIdentifiers)) {
+ $data['value'] .= '|' . $item->getData('page_id');
+ } else {
+ $existingIdentifiers[] = $identifier;
+ }
+
+ $res[] = $data;
+ }
+
+ return $res;
+ }
+
+ /**
+ * Set first store flag
+ *
+ * @param bool $flag
+ * @return $this
+ */
+ public function setFirstStoreFlag($flag = false)
+ {
+ $this->_previewFlag = $flag;
+ return $this;
+ }
+
/**
* Add field filter to collection
*
@@ -48,6 +134,33 @@ class Collection extends PageCollection
return parent::addFieldToFilter($field, $condition);
}
+ /**
+ * Add filter by store
+ *
+ * @param int|\Magento\Store\Model\Store $store
+ * @param bool $withAdmin
+ * @return $this
+ */
+ public function addStoreFilter($store, $withAdmin = true)
+ {
+ if (!$this->getFlag('store_filter_added')) {
+ if ($store instanceof \Magento\Store\Model\Store) {
+ $store = array($store->getId());
+ }
+
+ if (!is_array($store)) {
+ $store = array($store);
+ }
+
+ if ($withAdmin) {
+ $store[] = \Magento\Store\Model\Store::DEFAULT_STORE_ID;
+ }
+
+ $this->addFilter('store', array('in' => $store), 'public');
+ }
+ return $this;
+ }
+
/**
* Perform operations after collection load
*
@@ -85,4 +198,37 @@ class Collection extends PageCollection
$this->_previewFlag = false;
return parent::_afterLoad();
}
+
+ /**
+ * Join store relation table if there is store filter
+ *
+ * @return void
+ */
+ protected function _renderFiltersBefore()
+ {
+ if ($this->getFilter('store')) {
+ $this->getSelect()->join(
+ array('store_table' => $this->getTable('cms_page_store')),
+ 'main_table.page_id = store_table.page_id',
+ array()
+ )->group(
+ 'main_table.page_id'
+ );
+ }
+ parent::_renderFiltersBefore();
+ }
+
+ /**
+ * Get SQL for get record count.
+ * Extra GROUP BY strip added.
+ *
+ * @return \Magento\Framework\DB\Select
+ */
+ public function getSelectCountSql()
+ {
+ $countSelect = parent::getSelectCountSql();
+ $countSelect->reset(\Zend_Db_Select::GROUP);
+
+ return $countSelect;
+ }
}
diff --git a/app/code/Magento/Cms/Model/Resource/PageCriteria.php b/app/code/Magento/Cms/Model/Resource/PageCriteria.php
new file mode 100644
index 0000000000000000000000000000000000000000..7436d315a04fe9dcd8ef4494fca4e9e0bbea009a
--- /dev/null
+++ b/app/code/Magento/Cms/Model/Resource/PageCriteria.php
@@ -0,0 +1,67 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Cms\Model\Resource;
+
+use Magento\Framework\Data\AbstractCriteria;
+
+/**
+ * Class PageCriteria
+ */
+class PageCriteria extends AbstractCriteria implements \Magento\Cms\Api\PageCriteriaInterface
+{
+ /**
+ * @param string $mapper
+ */
+ public function __construct($mapper = '')
+ {
+ $this->mapperInterfaceName = $mapper ?: 'Magento\Cms\Model\Resource\PageCriteriaMapper';
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function setFirstStoreFlag($flag = false)
+ {
+ $this->data['first_store_flag'] = $flag;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function addStoreFilter($store, $withAdmin = true)
+ {
+ $this->data['store_filter'] = [$store, $withAdmin];
+ }
+
+ /**
+ * Add Criteria object
+ *
+ * @param \Magento\Cms\Api\PageCriteriaInterface $criteria
+ * @return void
+ */
+ public function addCriteria(\Magento\Cms\Api\PageCriteriaInterface $criteria)
+ {
+ $this->data[self::PART_CRITERIA_LIST]['list'][] = $criteria;
+ }
+}
diff --git a/app/code/Magento/Cms/Model/Resource/PageCriteriaMapper.php b/app/code/Magento/Cms/Model/Resource/PageCriteriaMapper.php
new file mode 100644
index 0000000000000000000000000000000000000000..8663ca41a72f2b325fd9212ce6964b044a181650
--- /dev/null
+++ b/app/code/Magento/Cms/Model/Resource/PageCriteriaMapper.php
@@ -0,0 +1,85 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Cms\Model\Resource;
+
+use Magento\Framework\DB\GenericMapper;
+
+/**
+ * Class PageCriteriaMapper
+ */
+class PageCriteriaMapper extends GenericMapper
+{
+ /**
+ * @inheritdoc
+ */
+ protected function init()
+ {
+ $this->initResource('Magento\Cms\Model\Resource\Page');
+ $this->map['fields']['store'] = 'store_table.store_id';
+ $this->map['fields']['store_id'] = 'store_table.store_id';
+ }
+
+ /**
+ * Set first store flag
+ *
+ * @param bool $flag
+ * @return void
+ */
+ public function mapFirstStoreFlag($flag)
+ {
+ // do nothing since handled in collection afterLoad
+ }
+
+ /**
+ * Add filter by store
+ *
+ * @param int|\Magento\Store\Model\Store $store
+ * @param bool $withAdmin
+ * @return void
+ */
+ public function mapStoreFilter($store, $withAdmin)
+ {
+ $this->getSelect()->join(
+ ['store_table' => $this->getTable('cms_page_store')],
+ 'main_table.page_id = store_table.page_id',
+ []
+ )->group('main_table.page_id');
+ if (!is_array($store)) {
+ if ($store instanceof \Magento\Store\Model\Store) {
+ $store = [$store->getId()];
+ } else {
+ $store = [$store];
+ }
+ }
+ if ($withAdmin) {
+ $store[] = \Magento\Store\Model\Store::DEFAULT_STORE_ID;
+ }
+ $field = $this->getMappedField('store');
+ $this->select->where(
+ $this->getConditionSql($field, ['in' => $store]),
+ null,
+ \Magento\Framework\DB\Select::TYPE_CONDITION
+ );
+ }
+}
diff --git a/app/code/Magento/Cms/Model/Template/FilterProvider.php b/app/code/Magento/Cms/Model/Template/FilterProvider.php
index ba3dac679ead11e8526a277fd669595dada4ac59..d1c10f7cbedaf2c15e88ab4931f1e7328911b964 100644
--- a/app/code/Magento/Cms/Model/Template/FilterProvider.php
+++ b/app/code/Magento/Cms/Model/Template/FilterProvider.php
@@ -31,7 +31,7 @@ namespace Magento\Cms\Model\Template;
class FilterProvider
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -51,12 +51,12 @@ class FilterProvider
protected $_instanceList;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $pageFilter
* @param string $blockFilter
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$pageFilter = 'Magento\Cms\Model\Template\Filter',
$blockFilter = 'Magento\Cms\Model\Template\Filter'
) {
diff --git a/app/code/Magento/Cms/composer.json b/app/code/Magento/Cms/composer.json
index e6ef44c0fc64711e7ad227739577a06108151e59..971a8daa41bb8fa862ff50980b7de2a9ae4ebb38 100644
--- a/app/code/Magento/Cms/composer.json
+++ b/app/code/Magento/Cms/composer.json
@@ -3,19 +3,19 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-widget": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-email": "0.1.0-alpha104",
- "magento/module-ui": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-widget": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-email": "0.1.0-alpha105",
+ "magento/module-ui": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Cms/etc/di.xml b/app/code/Magento/Cms/etc/di.xml
index 219506351b6400175513ac871b9bfc7005cd6501..8d6156d30c36f432f95178638baf6dce1969d797 100644
--- a/app/code/Magento/Cms/etc/di.xml
+++ b/app/code/Magento/Cms/etc/di.xml
@@ -24,6 +24,11 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/ObjectManager/etc/config.xsd">
+ <preference for="Magento\Cms\Api\Data\PageInterface" type="Magento\Cms\Model\Page" />
+ <preference for="Magento\Cms\Api\Data\PageCollectionInterface" type="Magento\Cms\Model\Resource\Page\Collection" />
+ <preference for="Magento\Cms\Api\PageCriteriaInterface" type="Magento\Cms\Model\Resource\PageCriteria" />
+ <preference for="Magento\Cms\Api\PageRepositoryInterface" type="Magento\Cms\Model\PageRepository" />
+
<type name="Magento\Cms\Model\Wysiwyg\Config">
<arguments>
<argument name="windowSize" xsi:type="array">
diff --git a/app/code/Magento/Cms/view/adminhtml/layout/cms_page_listing.xml b/app/code/Magento/Cms/view/adminhtml/layout/cms_page_listing.xml
index 21b2d0cd9871e72bab2e103adc2a2f434e88d8a7..f4668aa5433134517e981d19c3c3a8e4edeec00d 100644
--- a/app/code/Magento/Cms/view/adminhtml/layout/cms_page_listing.xml
+++ b/app/code/Magento/Cms/view/adminhtml/layout/cms_page_listing.xml
@@ -27,7 +27,7 @@
<referenceBlock name="listing">
<arguments>
<argument name="name" xsi:type="string">cms_page_listing</argument>
- <argument name="dataSource" xsi:type="object">Magento\Cms\Model\Resource\Page\Grid\Collection</argument>
+ <argument name="dataSource" xsi:type="object">Magento\Cms\Model\DataSource\PageCollection</argument>
<argument name="save_parameters_in_session" xsi:type="string">1</argument>
<argument name="configuration" xsi:type="array">
<item name="page_actions" xsi:type="array">
diff --git a/app/code/Magento/CmsUrlRewrite/composer.json b/app/code/Magento/CmsUrlRewrite/composer.json
index 35b70668be015e865c47c2509f6a9df54cb9577a..839c71c9789274d861479cb2c37fce24859ffe8c 100644
--- a/app/code/Magento/CmsUrlRewrite/composer.json
+++ b/app/code/Magento/CmsUrlRewrite/composer.json
@@ -3,13 +3,13 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/module-url-rewrite": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/module-url-rewrite": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/ConfigurableImportExport/composer.json b/app/code/Magento/ConfigurableImportExport/composer.json
index 619a8ec5fc779805331f966fa7e2b90ae178fec3..3068ec8dcb044d432a622eaf05c70962ccfd661e 100644
--- a/app/code/Magento/ConfigurableImportExport/composer.json
+++ b/app/code/Magento/ConfigurableImportExport/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-catalog-import-export": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-import-export": "0.1.0-alpha104",
- "magento/module-configurable-product": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-catalog-import-export": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-import-export": "0.1.0-alpha105",
+ "magento/module-configurable-product": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/Config/Matrix.php b/app/code/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/Config/Matrix.php
index bcf30c8e1b6443d030e00c23c6bd9e1a415757e6..fa7fe9a61756d92614f435fb2edba6256a282885 100644
--- a/app/code/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/Config/Matrix.php
+++ b/app/code/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/Config/Matrix.php
@@ -62,9 +62,9 @@ class Matrix extends \Magento\Backend\Block\Template
protected $_localeCurrency;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemServiceInterface
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @var \Magento\ConfigurableProduct\Model\Product\Type\VariationMatrix
@@ -78,7 +78,7 @@ class Matrix extends \Magento\Backend\Block\Template
* @param \Magento\Catalog\Model\ProductFactory $productFactory
* @param \Magento\Framework\Registry $coreRegistry
* @param \Magento\Framework\Locale\CurrencyInterface $localeCurrency
- * @param \Magento\CatalogInventory\Service\V1\StockItemServiceInterface $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param \Magento\ConfigurableProduct\Model\Product\Type\VariationMatrix $variationMatrix
* @param array $data
*/
@@ -89,7 +89,7 @@ class Matrix extends \Magento\Backend\Block\Template
\Magento\Catalog\Model\ProductFactory $productFactory,
\Magento\Framework\Registry $coreRegistry,
\Magento\Framework\Locale\CurrencyInterface $localeCurrency,
- \Magento\CatalogInventory\Service\V1\StockItemServiceInterface $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
\Magento\ConfigurableProduct\Model\Product\Type\VariationMatrix $variationMatrix,
array $data = array()
) {
@@ -99,7 +99,7 @@ class Matrix extends \Magento\Backend\Block\Template
$this->_config = $config;
$this->_coreRegistry = $coreRegistry;
$this->_localeCurrency = $localeCurrency;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
parent::__construct($context, $data);
$this->variationMatrix = $variationMatrix;
}
@@ -258,11 +258,11 @@ class Matrix extends \Magento\Backend\Block\Template
}
/**
- * @param int $productId
+ * @param Product $product
* @return float
*/
- public function getProductStockQty($productId)
+ public function getProductStockQty(Product $product)
{
- return $this->stockItemService->getStockItem($productId)->getQty();
+ return $this->stockRegistry->getStockItem($product->getId(), $product->getStore()->getWebsiteId())->getQty();
}
}
diff --git a/app/code/Magento/ConfigurableProduct/Block/Product/View/Type/Configurable.php b/app/code/Magento/ConfigurableProduct/Block/Product/View/Type/Configurable.php
index 3338046d8f78b3b05591d4a2bb6fe931d6474c62..175f0698ec3906f1478e8235908ee99484d165b5 100644
--- a/app/code/Magento/ConfigurableProduct/Block/Product/View/Type/Configurable.php
+++ b/app/code/Magento/ConfigurableProduct/Block/Product/View/Type/Configurable.php
@@ -198,7 +198,7 @@ class Configurable extends \Magento\Catalog\Block\Product\View\AbstractView
'productId' => $currentProduct->getId(),
'chooseText' => __('Choose an Option...'),
'taxConfig' => $attributePrice->getTaxConfig($this->currentCustomer->getCustomerId()),
- 'images' => $options['images'],
+ 'images' => isset($options['images']) ? $options['images'] : [],
'baseImage' => $options['baseImage']
);
diff --git a/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php b/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php
index 80347684aef6bafc2cd46722097d844d6856771a..0bad7ae54a9030d3f2cf4f4d9dd21a45c6534af2 100644
--- a/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php
+++ b/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php
@@ -157,6 +157,11 @@ class Configurable extends \Magento\Catalog\Model\Product\Type\AbstractType
*/
protected $_typeConfigurableFactory;
+ /**
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface
+ */
+ protected $stockConfiguration;
+
/**
* @codingStandardsIgnoreStart/End
*
@@ -203,6 +208,7 @@ class Configurable extends \Magento\Catalog\Model\Product\Type\AbstractType
\Magento\ConfigurableProduct\Model\Resource\Product\Type\Configurable\Attribute\CollectionFactory $attributeCollectionFactory,
\Magento\ConfigurableProduct\Model\Resource\Product\Type\Configurable $catalogProductTypeConfigurable,
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
array $data = array()
) {
$this->_typeConfigurableFactory = $typeConfigurableFactory;
@@ -214,6 +220,7 @@ class Configurable extends \Magento\Catalog\Model\Product\Type\AbstractType
$this->_attributeCollectionFactory = $attributeCollectionFactory;
$this->_catalogProductTypeConfigurable = $catalogProductTypeConfigurable;
$this->_scopeConfig = $scopeConfig;
+ $this->stockConfiguration = $stockConfiguration;
parent::__construct(
$productFactory,
$catalogProductOption,
@@ -613,6 +620,7 @@ class Configurable extends \Magento\Catalog\Model\Product\Type\AbstractType
if (!is_null($product)) {
$this->setStoreFilter($product->getStoreId(), $product);
}
+ /** @var \Magento\Catalog\Model\Product $child */
foreach ($this->getUsedProducts($product) as $child) {
if ($child->isSalable()) {
$salable = true;
@@ -1164,10 +1172,7 @@ class Configurable extends \Magento\Catalog\Model\Product\Type\AbstractType
$stockStatus = $parentProduct->getQuantityAndStockStatus();
$postData['stock_data']['is_in_stock'] = $stockStatus['is_in_stock'];
}
- $configDefaultValue = $this->_scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_MANAGE_STOCK,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
+ $configDefaultValue = $this->stockConfiguration->getManageStock($product->getStoreId());
$postData['stock_data']['use_config_manage_stock'] = $postData['stock_data']['manage_stock'] ==
$configDefaultValue ? 1 : 0;
if (!empty($postData['image'])) {
diff --git a/app/code/Magento/ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProduct.php b/app/code/Magento/ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProduct.php
index a1a12127f1e1d4f98ee7ee0d2118c7b3726562d2..249ad757f267151cad2bbde237bf8cf594e9df26 100644
--- a/app/code/Magento/ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProduct.php
+++ b/app/code/Magento/ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProduct.php
@@ -35,7 +35,7 @@ class ConfigurableProduct
* @param \Magento\Sales\Model\Quote\Item\Option $option
* @param \Magento\Sales\Model\Quote\Item $quoteItem
*
- * @return \Magento\CatalogInventory\Model\Stock\Item
+ * @return \Magento\CatalogInventory\Api\Data\StockItemInterface
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function aroundGetStockItem(
diff --git a/app/code/Magento/ConfigurableProduct/Pricing/Price/AttributePrice.php b/app/code/Magento/ConfigurableProduct/Pricing/Price/AttributePrice.php
index ee194c2f413592ba2475ca261cb95ec39457c9ca..3812dd7893e439132dc5dd289da3fa2ef3b21c09 100644
--- a/app/code/Magento/ConfigurableProduct/Pricing/Price/AttributePrice.php
+++ b/app/code/Magento/ConfigurableProduct/Pricing/Price/AttributePrice.php
@@ -130,14 +130,17 @@ class AttributePrice extends AbstractPrice implements AttributePriceInterface
$optionValueModified = $this->getOptionValueModified($value);
$optionValueAmount = $this->getOptionValueAmount($value);
- $price = $this->convertPrice($optionValueAmount->getValue());
+ $oldPrice = $this->convertPrice($optionValueAmount->getValue());
+ $inclTaxPrice = $price = $this->convertPrice($optionValueModified->getValue());
+ $exclTaxPrice = $this->convertPrice($optionValueModified->getBaseAmount());
+
$optionPrices[] = [
'id' => $value['value_index'],
'label' => $value['label'],
- 'price' => $this->convertDot($optionValueModified->getValue()),
- 'oldPrice' => $this->convertDot($price),
- 'inclTaxPrice' => $this->convertDot($optionValueModified->getValue()),
- 'exclTaxPrice' => $this->convertDot($optionValueModified->getBaseAmount()),
+ 'price' => $this->convertDot($price),
+ 'oldPrice' => $this->convertDot($oldPrice),
+ 'inclTaxPrice' => $this->convertDot($inclTaxPrice),
+ 'exclTaxPrice' => $this->convertDot($exclTaxPrice),
'products' => $this->getProductsIndex($attributeId, $options, $value)
];
}
diff --git a/app/code/Magento/ConfigurableProduct/composer.json b/app/code/Magento/ConfigurableProduct/composer.json
index 8e10f701a525a6d265e7db80055590ed3cde36d0..427d1072353c2d1333961a5624ed1b9322627bb5 100644
--- a/app/code/Magento/ConfigurableProduct/composer.json
+++ b/app/code/Magento/ConfigurableProduct/composer.json
@@ -3,23 +3,23 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-catalog-rule": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
- "magento/module-webapi": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-catalog-rule": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
+ "magento/module-webapi": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/matrix.phtml b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/matrix.phtml
index 20c3a7d9d6c5cb38ac0b5a6c818b7b802af2ee8f..771097ff28b828a9b4f204044a474c2ada0d35fb 100644
--- a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/matrix.phtml
+++ b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/matrix.phtml
@@ -131,7 +131,7 @@ $productByUsedAttributes = $this->getAssociatedProducts();
<td class="col-price" data-column="price">
<?php echo $this->renderPrice($price);?>
</td>
- <td class="col-qty" data-column="qty"><?php echo $this->getProductStockQty($product->getId()) ?></td>
+ <td class="col-qty" data-column="qty"><?php echo $this->getProductStockQty($product) ?></td>
<td class="col-weight" data-column="weight"><?php echo $product->getWeight()?></td>
<?php
foreach ($usedProductAttributes as $attribute) {
diff --git a/app/code/Magento/Contact/composer.json b/app/code/Magento/Contact/composer.json
index 44d38f24d3afa2ccc9c89a70c6baae44de6c2765..ca4e7219bc07c20174b254a0a4f23da048016dd4 100644
--- a/app/code/Magento/Contact/composer.json
+++ b/app/code/Magento/Contact/composer.json
@@ -3,15 +3,15 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Core/App/Media.php b/app/code/Magento/Core/App/Media.php
index 1f40c727c61df0f0483a10602b8f95f3019848ce..7681850ea4ea88cc6956808620fc47d13e48fcfb 100644
--- a/app/code/Magento/Core/App/Media.php
+++ b/app/code/Magento/Core/App/Media.php
@@ -29,14 +29,14 @@ use Magento\Framework\App\Filesystem\DirectoryList;
use Magento\Framework\App\State;
use Magento\Framework\App;
use Magento\Framework\AppInterface;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Core\Model\File\Storage\Request;
use Magento\Core\Model\File\Storage\Response;
class Media implements AppInterface
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -96,7 +96,7 @@ class Media implements AppInterface
protected $directory;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param Request $request
* @param Response $response
* @param \Closure $isAllowed
@@ -107,7 +107,7 @@ class Media implements AppInterface
* @param \Magento\Framework\Filesystem $filesystem
*/
public function __construct(
- ObjectManager $objectManager,
+ ObjectManagerInterface $objectManager,
Request $request,
Response $response,
\Closure $isAllowed,
diff --git a/app/code/Magento/Core/Model/EntityFactory.php b/app/code/Magento/Core/Model/EntityFactory.php
index ec5ac6993a41d9be9efc44afece4d7a444127708..e25938e8eb0b41f82d97c4074dbbb0f7be374c67 100644
--- a/app/code/Magento/Core/Model/EntityFactory.php
+++ b/app/code/Magento/Core/Model/EntityFactory.php
@@ -28,16 +28,16 @@ class EntityFactory implements \Magento\Framework\Data\Collection\EntityFactoryI
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Core/Model/Factory.php b/app/code/Magento/Core/Model/Factory.php
index cd05856235b2b61233e09704ac999000d90dd3d1..c131cae86a97fc70ad47be1645d5275cba20977a 100644
--- a/app/code/Magento/Core/Model/Factory.php
+++ b/app/code/Magento/Core/Model/Factory.php
@@ -29,14 +29,14 @@ namespace Magento\Core\Model;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Core/Model/File/Storage/Response.php b/app/code/Magento/Core/Model/File/Storage/Response.php
index 34a9bde1a22c2e0dcd126adb951bd3de501f89ae..b48a0abf980fac6414c8e43d820982e96cdc02e3 100644
--- a/app/code/Magento/Core/Model/File/Storage/Response.php
+++ b/app/code/Magento/Core/Model/File/Storage/Response.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Core\Model\File\Storage;
-use Magento\Framework\Stdlib\CookieManager;
+use Magento\Framework\Stdlib\CookieManagerInterface;
use Magento\Framework\Stdlib\Cookie\CookieMetadataFactory;
use Magento\Framework\App\Response\Http;
@@ -44,13 +44,13 @@ class Response extends Http implements \Magento\Framework\App\Response\FileInter
/**
* Constructor
*
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
* @param \Magento\Framework\App\Http\Context $context
* @param \Magento\Framework\File\Transfer\Adapter\Http $transferAdapter
*/
public function __construct(
- CookieManager $cookieManager,
+ CookieManagerInterface $cookieManager,
CookieMetadataFactory $cookieMetadataFactory,
\Magento\Framework\App\Http\Context $context,
\Magento\Framework\File\Transfer\Adapter\Http $transferAdapter
diff --git a/app/code/Magento/Core/Model/PageLayout/Config/Builder.php b/app/code/Magento/Core/Model/PageLayout/Config/Builder.php
index 21433466d6773f5a4e0d87d9de752bbcef986252..4278f684fcb997f527516772c28a5846d337daa8 100644
--- a/app/code/Magento/Core/Model/PageLayout/Config/Builder.php
+++ b/app/code/Magento/Core/Model/PageLayout/Config/Builder.php
@@ -31,7 +31,7 @@ namespace Magento\Core\Model\PageLayout\Config;
class Builder
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -46,12 +46,12 @@ class Builder
protected $themeCollection;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\View\PageLayout\File\Collector\Aggregated $fileCollector
* @param \Magento\Core\Model\Resource\Theme\Collection $themeCollection
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\View\PageLayout\File\Collector\Aggregated $fileCollector,
\Magento\Core\Model\Resource\Theme\Collection $themeCollection
) {
diff --git a/app/code/Magento/Core/Model/TemplateEngine/Plugin/DebugHints.php b/app/code/Magento/Core/Model/TemplateEngine/Plugin/DebugHints.php
index fc1ba6a958e363aa8f7278fccc27af41e49313f2..91dab4d5f358e3e10f5cf827c6538cff8f858515 100644
--- a/app/code/Magento/Core/Model/TemplateEngine/Plugin/DebugHints.php
+++ b/app/code/Magento/Core/Model/TemplateEngine/Plugin/DebugHints.php
@@ -37,7 +37,7 @@ class DebugHints
/**#@-*/
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
@@ -52,12 +52,12 @@ class DebugHints
private $_coreData;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
* @param \Magento\Core\Helper\Data $coreData
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
\Magento\Core\Helper\Data $coreData
) {
diff --git a/app/code/Magento/Core/Model/Validator/Factory.php b/app/code/Magento/Core/Model/Validator/Factory.php
index a7d5ecbd831099b07a11e6726326ed8db57ac970..1f9bc1c3e90cf44119c5642a81d67aabd5f09d7f 100644
--- a/app/code/Magento/Core/Model/Validator/Factory.php
+++ b/app/code/Magento/Core/Model/Validator/Factory.php
@@ -28,7 +28,7 @@ namespace Magento\Core\Model\Validator;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -42,11 +42,11 @@ class Factory
/**
* Initialize dependencies
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Module\Dir\Reader $moduleReader
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Module\Dir\Reader $moduleReader
) {
$this->_objectManager = $objectManager;
diff --git a/app/code/Magento/Core/Model/View/Design.php b/app/code/Magento/Core/Model/View/Design.php
index cb304d5a885a53ac86a806c2fede3364b843d190..6003c4138e696719abae7269048ae33d5185a17a 100644
--- a/app/code/Magento/Core/Model/View/Design.php
+++ b/app/code/Magento/Core/Model/View/Design.php
@@ -79,7 +79,7 @@ class Design implements \Magento\Framework\View\DesignInterface
protected $_locale;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -93,7 +93,7 @@ class Design implements \Magento\Framework\View\DesignInterface
* @param \Magento\Framework\View\Design\Theme\FlyweightFactory $flyweightFactory
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
* @param \Magento\Core\Model\ThemeFactory $themeFactory
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\App\State $appState
* @param array $themes
*/
@@ -102,7 +102,7 @@ class Design implements \Magento\Framework\View\DesignInterface
\Magento\Framework\View\Design\Theme\FlyweightFactory $flyweightFactory,
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
\Magento\Core\Model\ThemeFactory $themeFactory,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\App\State $appState,
array $themes
) {
diff --git a/app/code/Magento/Core/composer.json b/app/code/Magento/Core/composer.json
index 9ade2b568acb818af3f05d613995d4bf0a44fc42..db195180b78e2e1ca43d1c7555c6bfcd2e6d49ec 100644
--- a/app/code/Magento/Core/composer.json
+++ b/app/code/Magento/Core/composer.json
@@ -3,18 +3,18 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-cron": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-page-cache": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-cron": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-page-cache": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"lib-libxml": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Core/etc/di.xml b/app/code/Magento/Core/etc/di.xml
index 6b0cccecec7a4f34bdbc63e4f5788fffa95b25bc..3abae93c436750a70dd539cb754d4a6d253112cf 100644
--- a/app/code/Magento/Core/etc/di.xml
+++ b/app/code/Magento/Core/etc/di.xml
@@ -29,8 +29,8 @@
<preference for="Magento\Framework\Module\Updater\SetupInterface" type="Magento\Framework\Module\Setup" />
<preference for="Magento\Framework\Module\ResourceResolverInterface" type="Magento\Framework\Module\ResourceResolver" />
<preference for="Magento\Framework\AuthorizationInterface" type="Magento\Framework\Authorization" />
- <preference for="Magento\Framework\Authorization\Policy" type="Magento\Framework\Authorization\Policy\DefaultPolicy" />
- <preference for="Magento\Framework\Authorization\RoleLocator" type="Magento\Framework\Authorization\RoleLocator\DefaultRoleLocator" />
+ <preference for="Magento\Framework\Authorization\PolicyInterface" type="Magento\Framework\Authorization\Policy\DefaultPolicy" />
+ <preference for="Magento\Framework\Authorization\RoleLocatorInterface" type="Magento\Framework\Authorization\RoleLocator\DefaultRoleLocator" />
<preference for="Magento\Framework\Session\SessionManagerInterface" type="Magento\Framework\Session\Generic" />
<preference for="Magento\Core\Model\DataService\ConfigInterface" type="Magento\Core\Model\DataService\Config" />
<preference for="Magento\Framework\App\Config\ScopeConfigInterface" type="Magento\Framework\App\Config" />
@@ -81,7 +81,7 @@
<preference for="Magento\Framework\App\Config\Resource\ConfigInterface" type="Magento\Core\Model\Resource\Config" />
<preference for="Magento\Framework\App\DesignInterface" type="Magento\Core\Model\Design" />
<preference for="Magento\Framework\Pricing\Amount\AmountInterface" type="Magento\Framework\Pricing\Amount\Base" />
- <preference for="Magento\Framework\Stdlib\CookieManager" type="Magento\Framework\Stdlib\Cookie\PhpCookieManager" />
+ <preference for="Magento\Framework\Stdlib\CookieManagerInterface" type="Magento\Framework\Stdlib\Cookie\PhpCookieManager" />
<preference for="Magento\Framework\View\Page\FaviconInterface" type="Magento\Theme\Model\Favicon\Favicon" />
<preference for="Magento\Framework\Api\SearchResultsInterface" type="Magento\Framework\Api\SearchResults" />
<preference for="Magento\Framework\Api\SearchCriteriaInterface" type="Magento\Framework\Api\SearchCriteria" />
diff --git a/app/code/Magento/Cron/Model/Observer.php b/app/code/Magento/Cron/Model/Observer.php
index aab865c8b3bedb79183a35ee3b772068b7e0f5cc..e9a8403ce4f12b892aefd172ff318f84f47ab44c 100644
--- a/app/code/Magento/Cron/Model/Observer.php
+++ b/app/code/Magento/Cron/Model/Observer.php
@@ -103,7 +103,7 @@ class Observer
protected $_shell;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param ScheduleFactory $scheduleFactory
* @param \Magento\Framework\App\CacheInterface $cache
* @param ConfigInterface $config
@@ -112,7 +112,7 @@ class Observer
* @param \Magento\Framework\ShellInterface $shell
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Cron\Model\ScheduleFactory $scheduleFactory,
\Magento\Framework\App\CacheInterface $cache,
\Magento\Cron\Model\ConfigInterface $config,
diff --git a/app/code/Magento/Cron/composer.json b/app/code/Magento/Cron/composer.json
index 48bc799790395b50e8cf3f1177852316a9d8992c..a13c666a43ca5cfa3910cc9b35b0685cfc0dc7b1 100644
--- a/app/code/Magento/Cron/composer.json
+++ b/app/code/Magento/Cron/composer.json
@@ -3,13 +3,13 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/CurrencySymbol/composer.json b/app/code/Magento/CurrencySymbol/composer.json
index 00be91ba472898779b82c2ba8fac3fdd70edd96d..b7c82bdcd5a152c8483773ce1e8afd9ea4ded293 100644
--- a/app/code/Magento/CurrencySymbol/composer.json
+++ b/app/code/Magento/CurrencySymbol/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-page-cache": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-page-cache": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Customer/Block/Account/AuthorizationLink.php b/app/code/Magento/Customer/Block/Account/AuthorizationLink.php
index 76e7b9422dcd79e8c4a4e8de6f6653be925d51d3..0629174bd3d3a0fc283c8a069e56298632edf762 100644
--- a/app/code/Magento/Customer/Block/Account/AuthorizationLink.php
+++ b/app/code/Magento/Customer/Block/Account/AuthorizationLink.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Customer\Block\Account;
+use Magento\Customer\Model\Context;
+
/**
* Customer authorization link
*/
@@ -36,9 +38,9 @@ class AuthorizationLink extends \Magento\Framework\View\Element\Html\Link
protected $httpContext;
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerHelper;
+ protected $_customerUrl;
/**
* @var \Magento\Core\Helper\PostData
@@ -48,20 +50,20 @@ class AuthorizationLink extends \Magento\Framework\View\Element\Html\Link
/**
* @param \Magento\Framework\View\Element\Template\Context $context
* @param \Magento\Framework\App\Http\Context $httpContext
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param \Magento\Core\Helper\PostData $postDataHelper
* @param array $data
*/
public function __construct(
\Magento\Framework\View\Element\Template\Context $context,
\Magento\Framework\App\Http\Context $httpContext,
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Url $customerUrl,
\Magento\Core\Helper\PostData $postDataHelper,
array $data = array()
) {
parent::__construct($context, $data);
$this->httpContext = $httpContext;
- $this->_customerHelper = $customerHelper;
+ $this->_customerUrl = $customerUrl;
$this->_postDataHelper = $postDataHelper;
}
@@ -71,8 +73,8 @@ class AuthorizationLink extends \Magento\Framework\View\Element\Html\Link
public function getHref()
{
return $this->isLoggedIn()
- ? $this->_customerHelper->getLogoutUrl()
- : $this->_customerHelper->getLoginUrl();
+ ? $this->_customerUrl->getLogoutUrl()
+ : $this->_customerUrl->getLoginUrl();
}
/**
@@ -100,6 +102,6 @@ class AuthorizationLink extends \Magento\Framework\View\Element\Html\Link
*/
public function isLoggedIn()
{
- return $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH);
+ return $this->httpContext->getValue(Context::CONTEXT_AUTH);
}
}
diff --git a/app/code/Magento/Customer/Block/Account/Customer.php b/app/code/Magento/Customer/Block/Account/Customer.php
index 591378fc07bbf0b65a6abaaf1f1f7ab9b9d324db..1cbf6685022884a9ae906d479003f6ca5cf28e7c 100644
--- a/app/code/Magento/Customer/Block/Account/Customer.php
+++ b/app/code/Magento/Customer/Block/Account/Customer.php
@@ -23,6 +23,7 @@
*/
namespace Magento\Customer\Block\Account;
+use Magento\Customer\Model\Context;
use Magento\Customer\Service\V1\CustomerAccountServiceInterface;
class Customer extends \Magento\Framework\View\Element\Template
@@ -74,7 +75,7 @@ class Customer extends \Magento\Framework\View\Element\Template
*/
public function customerLoggedIn()
{
- return (bool)$this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH);
+ return (bool)$this->httpContext->getValue(Context::CONTEXT_AUTH);
}
/**
diff --git a/app/code/Magento/Customer/Block/Account/Forgotpassword.php b/app/code/Magento/Customer/Block/Account/Forgotpassword.php
index d2c61c704cbc5e9cd4e7d973e4c0c97d90d7ae88..aeb1d3e6ffe0f026dccf7ccad36c86c848d962e2 100644
--- a/app/code/Magento/Customer/Block/Account/Forgotpassword.php
+++ b/app/code/Magento/Customer/Block/Account/Forgotpassword.php
@@ -23,9 +23,40 @@
*/
namespace Magento\Customer\Block\Account;
+use Magento\Customer\Model\Url;
+use Magento\Framework\View\Element\Template;
+
/**
* Customer account navigation sidebar
*/
class Forgotpassword extends \Magento\Framework\View\Element\Template
{
+ /**
+ * @var Url
+ */
+ protected $customerUrl;
+
+ /**
+ * @param Template\Context $context
+ * @param Url $customerUrl
+ * @param array $data
+ */
+ public function __construct(
+ Template\Context $context,
+ Url $customerUrl,
+ array $data = array()
+ ) {
+ $this->customerUrl = $customerUrl;
+ parent::__construct($context, $data);
+ }
+
+ /**
+ * Get login URL
+ *
+ * @return string
+ */
+ public function getLoginUrl()
+ {
+ return $this->customerUrl->getLoginUrl();
+ }
}
diff --git a/app/code/Magento/Customer/Block/Account/Link.php b/app/code/Magento/Customer/Block/Account/Link.php
index f775a2234874cb4e56387682b433a1f3ec2fa64c..eec1f71b62720f5494eea293f4f02deb91c984f9 100644
--- a/app/code/Magento/Customer/Block/Account/Link.php
+++ b/app/code/Magento/Customer/Block/Account/Link.php
@@ -26,21 +26,21 @@ namespace Magento\Customer\Block\Account;
class Link extends \Magento\Framework\View\Element\Html\Link
{
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerHelper;
+ protected $_customerUrl;
/**
* @param \Magento\Framework\View\Element\Template\Context $context
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param array $data
*/
public function __construct(
\Magento\Framework\View\Element\Template\Context $context,
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Url $customerUrl,
array $data = array()
) {
- $this->_customerHelper = $customerHelper;
+ $this->_customerUrl = $customerUrl;
parent::__construct($context, $data);
$this->_isScopePrivate = true;
}
@@ -50,6 +50,6 @@ class Link extends \Magento\Framework\View\Element\Html\Link
*/
public function getHref()
{
- return $this->_customerHelper->getAccountUrl();
+ return $this->_customerUrl->getAccountUrl();
}
}
diff --git a/app/code/Magento/Customer/Block/Account/RegisterLink.php b/app/code/Magento/Customer/Block/Account/RegisterLink.php
index 46af63e9467e8e871b55410a295b3a40c01311e6..2386237cd42b1ca98262a6bb54a690e6131b64b2 100644
--- a/app/code/Magento/Customer/Block/Account/RegisterLink.php
+++ b/app/code/Magento/Customer/Block/Account/RegisterLink.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Customer\Block\Account;
+use Magento\Customer\Model\Context;
+
/**
* Customer register link
*/
@@ -36,25 +38,33 @@ class RegisterLink extends \Magento\Framework\View\Element\Html\Link
protected $httpContext;
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Registration
+ */
+ protected $_registration;
+
+ /**
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerHelper;
+ protected $_customerUrl;
/**
* @param \Magento\Framework\View\Element\Template\Context $context
* @param \Magento\Framework\App\Http\Context $httpContext
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Registration $registration
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param array $data
*/
public function __construct(
\Magento\Framework\View\Element\Template\Context $context,
\Magento\Framework\App\Http\Context $httpContext,
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Registration $registration,
+ \Magento\Customer\Model\Url $customerUrl,
array $data = array()
) {
parent::__construct($context, $data);
$this->httpContext = $httpContext;
- $this->_customerHelper = $customerHelper;
+ $this->_registration = $registration;
+ $this->_customerUrl = $customerUrl;
$this->_isScopePrivate = true;
}
@@ -63,7 +73,7 @@ class RegisterLink extends \Magento\Framework\View\Element\Html\Link
*/
public function getHref()
{
- return $this->_customerHelper->getRegisterUrl();
+ return $this->_customerUrl->getRegisterUrl();
}
/**
@@ -71,8 +81,8 @@ class RegisterLink extends \Magento\Framework\View\Element\Html\Link
*/
protected function _toHtml()
{
- if (!$this->_customerHelper->isRegistrationAllowed()
- || $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)
+ if (!$this->_registration->isAllowed()
+ || $this->httpContext->getValue(Context::CONTEXT_AUTH)
) {
return '';
}
diff --git a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Account.php b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Account.php
index addab2709eb9febe76a992aee80e48e1529d6252..dc672b8c9f3062f3930f4f288ba0ffb05b09ebb1 100644
--- a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Account.php
+++ b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Account.php
@@ -55,9 +55,9 @@ class Account extends GenericMetadata
protected $_jsonEncoder;
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Options
*/
- protected $_customerHelper;
+ protected $options;
/**
* @var \Magento\Customer\Service\V1\CustomerAccountServiceInterface
@@ -91,7 +91,7 @@ class Account extends GenericMetadata
* @param \Magento\Framework\Json\EncoderInterface $jsonEncoder
* @param \Magento\Customer\Model\Metadata\FormFactory $customerFormFactory
* @param \Magento\Store\Model\System\Store $systemStore
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Options $options
* @param \Magento\Customer\Service\V1\CustomerAccountServiceInterface $customerAccountService
* @param \Magento\Customer\Service\V1\CustomerMetadataServiceInterface $customerMetadataService
* @param \Magento\Customer\Service\V1\Data\CustomerBuilder $customerBuilder
@@ -106,13 +106,13 @@ class Account extends GenericMetadata
\Magento\Framework\Json\EncoderInterface $jsonEncoder,
\Magento\Customer\Model\Metadata\FormFactory $customerFormFactory,
\Magento\Store\Model\System\Store $systemStore,
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Options $options,
\Magento\Customer\Service\V1\CustomerAccountServiceInterface $customerAccountService,
\Magento\Customer\Service\V1\CustomerMetadataServiceInterface $customerMetadataService,
\Magento\Customer\Service\V1\Data\CustomerBuilder $customerBuilder,
array $data = array()
) {
- $this->_customerHelper = $customerHelper;
+ $this->options = $options;
$this->_jsonEncoder = $jsonEncoder;
$this->_systemStore = $systemStore;
$this->_customerFormFactory = $customerFormFactory;
@@ -209,11 +209,11 @@ class Account extends GenericMetadata
$element = $fieldset->getForm()->getElement($elementName);
if ($element) {
if ($elementName == 'prefix') {
- $options = $this->_customerHelper->getNamePrefixOptions($this->_getCustomerDataObject()->getStoreId());
+ $options = $this->options->getNamePrefixOptions($this->_getCustomerDataObject()->getStoreId());
$prevSibling = $fieldset->getForm()->getElement('group_id')->getId();
}
if ($elementName == 'suffix') {
- $options = $this->_customerHelper->getNameSuffixOptions($this->_getCustomerDataObject()->getStoreId());
+ $options = $this->options->getNameSuffixOptions($this->_getCustomerDataObject()->getStoreId());
$prevSibling = $fieldset->getForm()->getElement('lastname')->getId();
}
diff --git a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Addresses.php b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Addresses.php
index b0b4ba6156ddad89fca6cb866cf14118b4d2c0c1..9a74b532bf6ed1474334d645832f1c05645d7bd0 100644
--- a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Addresses.php
+++ b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Addresses.php
@@ -56,9 +56,9 @@ class Addresses extends GenericMetadata
protected $_coreData;
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Options
*/
- protected $_customerHelper;
+ protected $options;
/**
* @var \Magento\Directory\Helper\Data
@@ -95,7 +95,7 @@ class Addresses extends GenericMetadata
* @param \Magento\Framework\Json\EncoderInterface $jsonEncoder
* @param \Magento\Customer\Model\Renderer\RegionFactory $regionFactory
* @param \Magento\Customer\Model\Metadata\FormFactory $metadataFormFactory
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Options $options
* @param \Magento\Customer\Helper\Address $addressHelper
* @param \Magento\Customer\Service\V1\CustomerAccountServiceInterface $customerAccountService
* @param AddressMetadataServiceInterface $addressMetadataService
@@ -116,7 +116,7 @@ class Addresses extends GenericMetadata
\Magento\Framework\Json\EncoderInterface $jsonEncoder,
\Magento\Customer\Model\Renderer\RegionFactory $regionFactory,
\Magento\Customer\Model\Metadata\FormFactory $metadataFormFactory,
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Options $options,
\Magento\Customer\Helper\Address $addressHelper,
CustomerAccountServiceInterface $customerAccountService,
AddressMetadataServiceInterface $addressMetadataService,
@@ -126,7 +126,7 @@ class Addresses extends GenericMetadata
\Magento\Directory\Helper\Data $directoryHelper,
array $data = array()
) {
- $this->_customerHelper = $customerHelper;
+ $this->options = $options;
$this->_addressHelper = $addressHelper;
$this->_coreData = $coreData;
$this->_jsonEncoder = $jsonEncoder;
@@ -175,7 +175,8 @@ class Addresses extends GenericMetadata
'name' => 'add_address_button',
'element_name' => 'add_address_button',
'disabled' => $this->isReadonly(),
- 'class' => 'add' . ($this->isReadonly() ? ' disabled' : '')
+ 'class' => 'add' . ($this->isReadonly() ? ' disabled' : ''),
+ 'data_attribute' => ['ui-id' => 'adminhtml-edit-tab-addresses-add-address-button']
)
);
$this->addChild(
@@ -314,7 +315,7 @@ class Addresses extends GenericMetadata
$prefixElement = $form->getElement('prefix');
if ($prefixElement) {
- $prefixOptions = $this->_customerHelper->getNamePrefixOptions($customerStoreId);
+ $prefixOptions = $this->options->getNamePrefixOptions($customerStoreId);
if (!empty($prefixOptions)) {
$fieldset->removeField($prefixElement->getId());
$prefixField = $fieldset->addField($prefixElement->getId(), 'select', $prefixElement->getData(), '^');
@@ -324,7 +325,7 @@ class Addresses extends GenericMetadata
$suffixElement = $form->getElement('suffix');
if ($suffixElement) {
- $suffixOptions = $this->_customerHelper->getNameSuffixOptions($customerStoreId);
+ $suffixOptions = $this->options->getNameSuffixOptions($customerStoreId);
if (!empty($suffixOptions)) {
$fieldset->removeField($suffixElement->getId());
$suffixField = $fieldset->addField(
diff --git a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Cart.php b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Cart.php
index 46979f93e0b1f0364c36a15e4d53e760802a533b..6724ccc34ab6c25e35e18bd7484a172322738353 100644
--- a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Cart.php
+++ b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Cart.php
@@ -45,9 +45,9 @@ class Cart extends \Magento\Backend\Block\Widget\Grid\Extended
protected $_dataCollectionFactory;
/**
- * @var \Magento\Sales\Model\QuoteFactory
+ * @var \Magento\Sales\Model\QuoteRepository
*/
- protected $_quoteFactory;
+ protected $quoteRepository;
/**
* @var \Magento\Sales\Model\Quote
@@ -62,7 +62,7 @@ class Cart extends \Magento\Backend\Block\Widget\Grid\Extended
/**
* @param \Magento\Backend\Block\Template\Context $context
* @param \Magento\Backend\Helper\Data $backendHelper
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param \Magento\Framework\Data\CollectionFactory $dataCollectionFactory
* @param \Magento\Framework\Registry $coreRegistry
* @param array $data
@@ -70,14 +70,14 @@ class Cart extends \Magento\Backend\Block\Widget\Grid\Extended
public function __construct(
\Magento\Backend\Block\Template\Context $context,
\Magento\Backend\Helper\Data $backendHelper,
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
\Magento\Framework\Data\CollectionFactory $dataCollectionFactory,
\Magento\Framework\Registry $coreRegistry,
array $data = []
) {
$this->_dataCollectionFactory = $dataCollectionFactory;
$this->_coreRegistry = $coreRegistry;
- $this->_quoteFactory = $quoteFactory;
+ $this->quoteRepository = $quoteRepository;
parent::__construct($context, $backendHelper, $data);
}
@@ -245,7 +245,11 @@ class Cart extends \Magento\Backend\Block\Widget\Grid\Extended
$customerId = $this->getCustomerId();
$storeIds = $this->_storeManager->getWebsite($this->getWebsiteId())->getStoreIds();
- $this->quote = $this->_quoteFactory->create()->setSharedStoreIds($storeIds)->loadByCustomer($customerId);
+ try {
+ $this->quote = $this->quoteRepository->getForCustomer($customerId, $storeIds);
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+ $this->quote = $this->quoteRepository->create()->setSharedStoreIds($storeIds);
+ }
}
return $this->quote;
}
diff --git a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Accordion.php b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Accordion.php
index 05a306f2e887dbb5f3798700035675b709ef5c17..466a90aa123493a6b29c83cb2fdaa6dfad26ef6a 100644
--- a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Accordion.php
+++ b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Accordion.php
@@ -41,9 +41,9 @@ class Accordion extends \Magento\Backend\Block\Widget\Accordion
protected $_coreRegistry = null;
/**
- * @var \Magento\Sales\Model\QuoteFactory
+ * @var \Magento\Sales\Model\QuoteRepository
*/
- protected $_quoteFactory;
+ protected $quoteRepository;
/**
* @var \Magento\Wishlist\Model\Resource\Item\CollectionFactory
@@ -61,7 +61,7 @@ class Accordion extends \Magento\Backend\Block\Widget\Accordion
/**
* @param \Magento\Backend\Block\Template\Context $context
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param \Magento\Wishlist\Model\Resource\Item\CollectionFactory $itemsFactory
* @param \Magento\Framework\Registry $registry
* @param \Magento\Customer\Model\Config\Share $shareConfig
@@ -71,7 +71,7 @@ class Accordion extends \Magento\Backend\Block\Widget\Accordion
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
\Magento\Wishlist\Model\Resource\Item\CollectionFactory $itemsFactory,
\Magento\Framework\Registry $registry,
\Magento\Customer\Model\Config\Share $shareConfig,
@@ -80,7 +80,7 @@ class Accordion extends \Magento\Backend\Block\Widget\Accordion
array $data = array()
) {
$this->_coreRegistry = $registry;
- $this->_quoteFactory = $quoteFactory;
+ $this->quoteRepository = $quoteRepository;
$this->_itemsFactory = $itemsFactory;
$this->_shareConfig = $shareConfig;
$this->_customerAccountService = $customerAccountService;
@@ -112,16 +112,15 @@ class Accordion extends \Magento\Backend\Block\Widget\Accordion
$website = $this->_storeManager->getWebsite($websiteId);
// count cart items
- $cartItemsCount = $this->_quoteFactory->create()->setWebsite(
- $website
- )->loadByCustomer(
- $customerId
- )->getItemsCollection(
- false
- )->addFieldToFilter(
- 'parent_item_id',
- array('null' => true)
- )->getSize();
+ try {
+ $cartItemsCount = $this->quoteRepository->getForCustomer($customerId)
+ ->setWebsite($website)
+ ->getItemsCollection(false)
+ ->addFieldToFilter('parent_item_id', array('null' => true))
+ ->getSize();
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+ $cartItemsCount = 0;
+ }
// prepare title for cart
$title = __('Shopping Cart - %1 item(s)', $cartItemsCount);
if (count($websiteIds) > 1) {
diff --git a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Cart.php b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Cart.php
index 508e396ff906357c674b50cf699afee1744a4d04..d75b18b5151b172b6fb160e1d1dbf4a4e00aece7 100644
--- a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Cart.php
+++ b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Cart.php
@@ -46,9 +46,9 @@ class Cart extends \Magento\Backend\Block\Widget\Grid\Extended
protected $_dataCollectionFactory;
/**
- * @var \Magento\Sales\Model\QuoteFactory
+ * @var \Magento\Sales\Model\QuoteRepository
*/
- protected $_quoteFactory;
+ protected $quoteRepository;
/**
* @var \Magento\Sales\Model\Quote
@@ -60,7 +60,7 @@ class Cart extends \Magento\Backend\Block\Widget\Grid\Extended
*
* @param \Magento\Backend\Block\Template\Context $context
* @param \Magento\Backend\Helper\Data $backendHelper
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param \Magento\Framework\Data\CollectionFactory $dataCollectionFactory
* @param \Magento\Framework\Registry $coreRegistry
* @param array $data
@@ -68,14 +68,14 @@ class Cart extends \Magento\Backend\Block\Widget\Grid\Extended
public function __construct(
\Magento\Backend\Block\Template\Context $context,
\Magento\Backend\Helper\Data $backendHelper,
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
\Magento\Framework\Data\CollectionFactory $dataCollectionFactory,
\Magento\Framework\Registry $coreRegistry,
array $data = []
) {
$this->_dataCollectionFactory = $dataCollectionFactory;
$this->_coreRegistry = $coreRegistry;
- $this->_quoteFactory = $quoteFactory;
+ $this->quoteRepository = $quoteRepository;
parent::__construct($context, $backendHelper, $data);
}
@@ -177,11 +177,15 @@ class Cart extends \Magento\Backend\Block\Widget\Grid\Extended
{
if (null == $this->quote) {
$storeIds = $this->_storeManager->getWebsite($this->getWebsiteId())->getStoreIds();
- $this->quote = $this->_quoteFactory->create()->setSharedStoreIds($storeIds);
+ $this->quote = $this->quoteRepository->create()->setSharedStoreIds($storeIds);
$currentCustomerId = $this->_coreRegistry->registry(RegistryConstants::CURRENT_CUSTOMER_ID);
if (!empty($currentCustomerId)) {
- $this->quote->loadByCustomer($currentCustomerId);
+ try {
+ $this->quote = $this->quoteRepository->getForCustomer($currentCustomerId, $storeIds);
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+
+ }
}
}
return $this->quote;
diff --git a/app/code/Magento/Customer/Block/Form/Login.php b/app/code/Magento/Customer/Block/Form/Login.php
index a0f41ddc52adba6e87843c28650e5a1d45392545..363e116c6fca4ff762f74c38895bd638f7ffaac5 100644
--- a/app/code/Magento/Customer/Block/Form/Login.php
+++ b/app/code/Magento/Customer/Block/Form/Login.php
@@ -41,9 +41,9 @@ class Login extends \Magento\Framework\View\Element\Template
protected $_customerSession;
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerHelper;
+ protected $_customerUrl;
/**
* Checkout data
@@ -59,23 +59,33 @@ class Login extends \Magento\Framework\View\Element\Template
*/
protected $coreUrl;
+ /**
+ * Registration
+ *
+ * @var \Magento\Customer\Model\Registration
+ */
+ protected $registration;
+
/**
* @param \Magento\Framework\View\Element\Template\Context $context
+ * @param \Magento\Customer\Model\Registration $registration
* @param \Magento\Customer\Model\Session $customerSession
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param \Magento\Checkout\Helper\Data $checkoutData
* @param \Magento\Core\Helper\Url $coreUrl
* @param array $data
*/
public function __construct(
\Magento\Framework\View\Element\Template\Context $context,
+ \Magento\Customer\Model\Registration $registration,
\Magento\Customer\Model\Session $customerSession,
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Url $customerUrl,
\Magento\Checkout\Helper\Data $checkoutData,
\Magento\Core\Helper\Url $coreUrl,
array $data = array()
) {
- $this->_customerHelper = $customerHelper;
+ $this->registration = $registration;
+ $this->_customerUrl = $customerUrl;
$this->_customerSession = $customerSession;
$this->checkoutData = $checkoutData;
$this->coreUrl = $coreUrl;
@@ -93,6 +103,16 @@ class Login extends \Magento\Framework\View\Element\Template
return parent::_prepareLayout();
}
+ /**
+ * Return registration
+ *
+ * @return \Magento\Customer\Model\Registration
+ */
+ public function getRegistration()
+ {
+ return $this->registration;
+ }
+
/**
* Retrieve form posting url
*
@@ -100,7 +120,7 @@ class Login extends \Magento\Framework\View\Element\Template
*/
public function getPostActionUrl()
{
- return $this->_customerHelper->getLoginPostUrl();
+ return $this->_customerUrl->getLoginPostUrl();
}
/**
@@ -112,7 +132,7 @@ class Login extends \Magento\Framework\View\Element\Template
{
$url = $this->getData('create_account_url');
if (is_null($url)) {
- $url = $this->_customerHelper->getRegisterUrl();
+ $url = $this->_customerUrl->getRegisterUrl();
}
if ($this->checkoutData->isContextCheckout()) {
$url = $this->coreUrl->addRequestParam($url, array('context' => 'checkout'));
@@ -127,7 +147,7 @@ class Login extends \Magento\Framework\View\Element\Template
*/
public function getForgotPasswordUrl()
{
- return $this->_customerHelper->getForgotPasswordUrl();
+ return $this->_customerUrl->getForgotPasswordUrl();
}
/**
diff --git a/app/code/Magento/Customer/Block/Form/Register.php b/app/code/Magento/Customer/Block/Form/Register.php
index f8e64473190a1a49d7b68be189b6acd77a731e5b..e9f355993b46770df27354012bab5f017cc68c8d 100644
--- a/app/code/Magento/Customer/Block/Form/Register.php
+++ b/app/code/Magento/Customer/Block/Form/Register.php
@@ -39,9 +39,9 @@ class Register extends \Magento\Directory\Block\Data
protected $_moduleManager;
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerHelper;
+ protected $_customerUrl;
/**
* @param \Magento\Framework\View\Element\Template\Context $context
@@ -52,7 +52,7 @@ class Register extends \Magento\Directory\Block\Data
* @param \Magento\Directory\Model\Resource\Country\CollectionFactory $countryCollectionFactory
* @param \Magento\Framework\Module\Manager $moduleManager
* @param \Magento\Customer\Model\Session $customerSession
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param array $data
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
@@ -66,10 +66,10 @@ class Register extends \Magento\Directory\Block\Data
\Magento\Directory\Model\Resource\Country\CollectionFactory $countryCollectionFactory,
\Magento\Framework\Module\Manager $moduleManager,
\Magento\Customer\Model\Session $customerSession,
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Url $customerUrl,
array $data = array()
) {
- $this->_customerHelper = $customerHelper;
+ $this->_customerUrl = $customerUrl;
$this->_moduleManager = $moduleManager;
$this->_customerSession = $customerSession;
parent::__construct(
@@ -111,7 +111,7 @@ class Register extends \Magento\Directory\Block\Data
*/
public function getPostActionUrl()
{
- return $this->_customerHelper->getRegisterPostUrl();
+ return $this->_customerUrl->getRegisterPostUrl();
}
/**
@@ -123,7 +123,7 @@ class Register extends \Magento\Directory\Block\Data
{
$url = $this->getData('back_url');
if (is_null($url)) {
- $url = $this->_customerHelper->getLoginUrl();
+ $url = $this->_customerUrl->getLoginUrl();
}
return $url;
}
diff --git a/app/code/Magento/Customer/Block/Widget/Name.php b/app/code/Magento/Customer/Block/Widget/Name.php
index 74940c38f6e521576d4eae659009ea27c2559ffe..f26345efe4e8b085c58ff8018936ca96ae921aa0 100644
--- a/app/code/Magento/Customer/Block/Widget/Name.php
+++ b/app/code/Magento/Customer/Block/Widget/Name.php
@@ -28,7 +28,7 @@ use Magento\Customer\Service\V1\CustomerMetadataServiceInterface;
use Magento\Customer\Service\V1\Data\Customer;
use Magento\Framework\View\Element\Template\Context;
use Magento\Customer\Helper\Address as AddressHelper;
-use Magento\Customer\Helper\Data as CustomerHelper;
+use Magento\Customer\Model\Options;
/**
* Widget for showing customer name.
@@ -44,16 +44,16 @@ class Name extends AbstractWidget
protected $_addressMetadataService;
/**
- * @var CustomerHelper
+ * @var Options
*/
- protected $_customerHelper;
+ protected $options;
/**
* @param Context $context
* @param AddressHelper $addressHelper
* @param CustomerMetadataServiceInterface $customerMetadataService
* @param AddressMetadataServiceInterface $addressMetadataService
- * @param CustomerHelper $customerHelper
+ * @param Options $options
* @param array $data
*/
public function __construct(
@@ -61,10 +61,10 @@ class Name extends AbstractWidget
AddressHelper $addressHelper,
CustomerMetadataServiceInterface $customerMetadataService,
AddressMetadataServiceInterface $addressMetadataService,
- CustomerHelper $customerHelper,
+ Options $options,
array $data = array()
) {
- $this->_customerHelper = $customerHelper;
+ $this->options = $options;
parent::__construct($context, $addressHelper, $customerMetadataService, $data);
$this->_addressMetadataService = $addressMetadataService;
$this->_isScopePrivate = true;
@@ -119,7 +119,7 @@ class Name extends AbstractWidget
*/
public function getPrefixOptions()
{
- $prefixOptions = $this->_customerHelper->getNamePrefixOptions();
+ $prefixOptions = $this->options->getNamePrefixOptions();
if ($this->getObject() && !empty($prefixOptions)) {
$oldPrefix = $this->escapeHtml(trim($this->getObject()->getPrefix()));
@@ -175,7 +175,7 @@ class Name extends AbstractWidget
*/
public function getSuffixOptions()
{
- $suffixOptions = $this->_customerHelper->getNameSuffixOptions();
+ $suffixOptions = $this->options->getNameSuffixOptions();
if ($this->getObject() && !empty($suffixOptions)) {
$oldSuffix = $this->escapeHtml(trim($this->getObject()->getSuffix()));
$suffixOptions[$oldSuffix] = $oldSuffix;
diff --git a/app/code/Magento/Customer/Controller/Account/Confirm.php b/app/code/Magento/Customer/Controller/Account/Confirm.php
index bb1eba638197f45fb09959383bb1cc1ac5422af0..4820d1a72becd53b9e468e5896e0db008580d2b3 100644
--- a/app/code/Magento/Customer/Controller/Account/Confirm.php
+++ b/app/code/Magento/Customer/Controller/Account/Confirm.php
@@ -24,6 +24,7 @@
*/
namespace Magento\Customer\Controller\Account;
+use Magento\Customer\Model\Url;
use Magento\Framework\App\Action\Context;
use Magento\Customer\Model\Session;
use Magento\Framework\App\Config\ScopeConfigInterface;
@@ -32,7 +33,6 @@ use Magento\Customer\Service\V1\CustomerAccountServiceInterface;
use Magento\Customer\Helper\Address;
use Magento\Framework\UrlFactory;
use Magento\Framework\Exception\StateException;
-use Magento\Customer\Helper\Data as CustomerData;
use Magento\Store\Model\ScopeInterface;
/**
@@ -157,7 +157,7 @@ class Confirm extends \Magento\Customer\Controller\Account
{
$backUrl = $this->getRequest()->getParam('back_url', false);
$redirectToDashboard = $this->scopeConfig->isSetFlag(
- CustomerData::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD,
+ Url::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD,
ScopeInterface::SCOPE_STORE
);
if (!$redirectToDashboard && $this->_getSession()->getBeforeAuthUrl()) {
diff --git a/app/code/Magento/Customer/Controller/Account/Create.php b/app/code/Magento/Customer/Controller/Account/Create.php
index d78b2cc4d316640664cf848654ed24dc356831c1..b4d296776efcd40b05f8fd520ff929a0caff1ee6 100644
--- a/app/code/Magento/Customer/Controller/Account/Create.php
+++ b/app/code/Magento/Customer/Controller/Account/Create.php
@@ -26,24 +26,24 @@ namespace Magento\Customer\Controller\Account;
use Magento\Framework\App\Action\Context;
use Magento\Customer\Model\Session;
-use Magento\Customer\Helper\Data as CustomerHelper;
+use Magento\Customer\Model\Registration;
class Create extends \Magento\Customer\Controller\Account
{
- /** @var CustomerHelper */
- protected $customerHelper;
+ /** @var Registration */
+ protected $registration;
/**
* @param Context $context
* @param Session $customerSession
- * @param CustomerHelper $customerHelper
+ * @param Registration $registration
*/
public function __construct(
Context $context,
Session $customerSession,
- CustomerHelper $customerHelper
+ Registration $registration
) {
- $this->customerHelper = $customerHelper;
+ $this->registration = $registration;
parent::__construct($context, $customerSession);
}
@@ -54,7 +54,7 @@ class Create extends \Magento\Customer\Controller\Account
*/
public function execute()
{
- if ($this->_getSession()->isLoggedIn() || !$this->customerHelper->isRegistrationAllowed()) {
+ if ($this->_getSession()->isLoggedIn() || !$this->registration->isAllowed()) {
$this->_redirect('*/*');
return;
}
diff --git a/app/code/Magento/Customer/Controller/Account/CreatePost.php b/app/code/Magento/Customer/Controller/Account/CreatePost.php
index 31fdf9827e2c3ded0d7a60551102d8268279c5e0..ee0c5b74a9c0f46cf8377101b374eca83a7e6a37 100644
--- a/app/code/Magento/Customer/Controller/Account/CreatePost.php
+++ b/app/code/Magento/Customer/Controller/Account/CreatePost.php
@@ -24,6 +24,7 @@
*/
namespace Magento\Customer\Controller\Account;
+use Magento\Customer\Model\Url;
use Magento\Framework\App\Action\Context;
use Magento\Customer\Model\Session;
use Magento\Framework\App\Config\ScopeConfigInterface;
@@ -36,7 +37,8 @@ use Magento\Newsletter\Model\SubscriberFactory;
use Magento\Customer\Service\V1\Data\RegionBuilder;
use Magento\Customer\Service\V1\Data\AddressBuilder;
use Magento\Customer\Service\V1\Data\CustomerDetailsBuilder;
-use Magento\Customer\Helper\Data as CustomerHelper;
+use Magento\Customer\Model\Url as CustomerUrl;
+use Magento\Customer\Model\Registration;
use Magento\Framework\Escaper;
use Magento\Customer\Model\CustomerExtractor;
use Magento\Framework\Exception\StateException;
@@ -75,8 +77,11 @@ class CreatePost extends \Magento\Customer\Controller\Account
/** @var CustomerDetailsBuilder */
protected $customerDetailsBuilder;
- /** @var CustomerHelper */
- protected $customerHelperData;
+ /** @var Registration */
+ protected $registration;
+
+ /** @var CustomerUrl */
+ protected $customerUrl;
/** @var Escaper */
protected $escaper;
@@ -100,7 +105,8 @@ class CreatePost extends \Magento\Customer\Controller\Account
* @param RegionBuilder $regionBuilder
* @param AddressBuilder $addressBuilder
* @param CustomerDetailsBuilder $customerDetailsBuilder
- * @param CustomerHelper $customerHelperData
+ * @param CustomerUrl $customerUrl
+ * @param Registration $registration
* @param Escaper $escaper
* @param CustomerExtractor $customerExtractor
*
@@ -119,7 +125,8 @@ class CreatePost extends \Magento\Customer\Controller\Account
RegionBuilder $regionBuilder,
AddressBuilder $addressBuilder,
CustomerDetailsBuilder $customerDetailsBuilder,
- CustomerHelper $customerHelperData,
+ CustomerUrl $customerUrl,
+ Registration $registration,
Escaper $escaper,
CustomerExtractor $customerExtractor
) {
@@ -132,7 +139,8 @@ class CreatePost extends \Magento\Customer\Controller\Account
$this->regionBuilder = $regionBuilder;
$this->addressBuilder = $addressBuilder;
$this->customerDetailsBuilder = $customerDetailsBuilder;
- $this->customerHelperData = $customerHelperData;
+ $this->customerUrl = $customerUrl;
+ $this->registration = $registration;
$this->escaper = $escaper;
$this->customerExtractor = $customerExtractor;
$this->urlModel = $urlFactory->create();
@@ -191,7 +199,7 @@ class CreatePost extends \Magento\Customer\Controller\Account
*/
public function execute()
{
- if ($this->_getSession()->isLoggedIn() || !$this->customerHelperData->isRegistrationAllowed()) {
+ if ($this->_getSession()->isLoggedIn() || !$this->registration->isAllowed()) {
$this->_redirect('*/*/');
return;
}
@@ -234,7 +242,7 @@ class CreatePost extends \Magento\Customer\Controller\Account
$confirmationStatus = $this->customerAccountService->getConfirmationStatus($customer->getId());
if ($confirmationStatus === CustomerAccountServiceInterface::ACCOUNT_CONFIRMATION_REQUIRED) {
- $email = $this->customerHelperData->getEmailConfirmationUrl($customer->getEmail());
+ $email = $this->customerUrl->getEmailConfirmationUrl($customer->getEmail());
// @codingStandardsIgnoreStart
$this->messageManager->addSuccess(
__(
@@ -334,7 +342,7 @@ class CreatePost extends \Magento\Customer\Controller\Account
protected function getSuccessRedirect()
{
$redirectToDashboard = $this->scopeConfig->isSetFlag(
- CustomerHelper::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD,
+ Url::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD,
ScopeInterface::SCOPE_STORE
);
if (!$redirectToDashboard && $this->_getSession()->getBeforeAuthUrl()) {
diff --git a/app/code/Magento/Customer/Controller/Account/LoginPost.php b/app/code/Magento/Customer/Controller/Account/LoginPost.php
index 53d3a7a57e49c3e834e780b473d52c742e3df509..349a59e980376998e43d417da6235fc5e6fa279c 100644
--- a/app/code/Magento/Customer/Controller/Account/LoginPost.php
+++ b/app/code/Magento/Customer/Controller/Account/LoginPost.php
@@ -30,7 +30,7 @@ use Magento\Framework\App\Config\ScopeConfigInterface;
use Magento\Framework\StoreManagerInterface;
use Magento\Customer\Service\V1\CustomerAccountServiceInterface;
use Magento\Core\Helper\Data as CoreHelper;
-use Magento\Customer\Helper\Data as CustomerHelper;
+use Magento\Customer\Model\Url as CustomerUrl;
use Magento\Framework\Exception\EmailNotConfirmedException;
use Magento\Framework\Exception\AuthenticationException;
use Magento\Core\App\Action\FormKeyValidator;
@@ -52,8 +52,8 @@ class LoginPost extends \Magento\Customer\Controller\Account
/** @var CoreHelper */
protected $coreHelperData;
- /** @var CustomerHelper */
- protected $customerHelperData;
+ /** @var CustomerUrl */
+ protected $customerUrl;
/** @var FormKeyValidator */
protected $formKeyValidator;
@@ -65,7 +65,7 @@ class LoginPost extends \Magento\Customer\Controller\Account
* @param StoreManagerInterface $storeManager
* @param CustomerAccountServiceInterface $customerAccountService
* @param CoreHelper $coreHelperData
- * @param CustomerHelper $customerHelperData
+ * @param CustomerUrl $customerHelperData
* @param FormKeyValidator $formKeyValidator
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
@@ -77,14 +77,14 @@ class LoginPost extends \Magento\Customer\Controller\Account
StoreManagerInterface $storeManager,
CustomerAccountServiceInterface $customerAccountService,
CoreHelper $coreHelperData,
- CustomerHelper $customerHelperData,
+ CustomerUrl $customerHelperData,
FormKeyValidator $formKeyValidator
) {
$this->scopeConfig = $scopeConfig;
$this->storeManager = $storeManager;
$this->customerAccountService = $customerAccountService;
$this->coreHelperData = $coreHelperData;
- $this->customerHelperData = $customerHelperData;
+ $this->customerUrl = $customerHelperData;
$this->formKeyValidator = $formKeyValidator;
parent::__construct($context, $customerSession);
}
@@ -108,15 +108,15 @@ class LoginPost extends \Magento\Customer\Controller\Account
$this->_getSession()->getBeforeAuthUrl() == $this->storeManager->getStore()->getBaseUrl()
) {
// Set default URL to redirect customer to
- $this->_getSession()->setBeforeAuthUrl($this->customerHelperData->getAccountUrl());
+ $this->_getSession()->setBeforeAuthUrl($this->customerUrl->getAccountUrl());
// Redirect customer to the last page visited after logging in
if ($this->_getSession()->isLoggedIn()) {
if (!$this->scopeConfig->isSetFlag(
- CustomerHelper::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD,
+ CustomerUrl::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD,
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
)
) {
- $referer = $this->getRequest()->getParam(CustomerHelper::REFERER_QUERY_PARAM_NAME);
+ $referer = $this->getRequest()->getParam(CustomerUrl::REFERER_QUERY_PARAM_NAME);
if ($referer) {
$referer = $this->coreHelperData->urlDecode($referer);
if ($this->_url->isOwnOriginUrl()) {
@@ -127,10 +127,10 @@ class LoginPost extends \Magento\Customer\Controller\Account
$this->_getSession()->setBeforeAuthUrl($this->_getSession()->getAfterAuthUrl(true));
}
} else {
- $this->_getSession()->setBeforeAuthUrl($this->customerHelperData->getLoginUrl());
+ $this->_getSession()->setBeforeAuthUrl($this->customerUrl->getLoginUrl());
}
- } elseif ($this->_getSession()->getBeforeAuthUrl() == $this->customerHelperData->getLogoutUrl()) {
- $this->_getSession()->setBeforeAuthUrl($this->customerHelperData->getDashboardUrl());
+ } elseif ($this->_getSession()->getBeforeAuthUrl() == $this->customerUrl->getLogoutUrl()) {
+ $this->_getSession()->setBeforeAuthUrl($this->customerUrl->getDashboardUrl());
} else {
if (!$this->_getSession()->getAfterAuthUrl()) {
$this->_getSession()->setAfterAuthUrl($this->_getSession()->getBeforeAuthUrl());
@@ -163,7 +163,7 @@ class LoginPost extends \Magento\Customer\Controller\Account
$this->_getSession()->setCustomerDataAsLoggedIn($customer);
$this->_getSession()->regenerateId();
} catch (EmailNotConfirmedException $e) {
- $value = $this->customerHelperData->getEmailConfirmationUrl($login['username']);
+ $value = $this->customerUrl->getEmailConfirmationUrl($login['username']);
$message = __(
'This account is not confirmed.' .
' <a href="%1">Click here</a> to resend confirmation email.',
diff --git a/app/code/Magento/Customer/Controller/Address.php b/app/code/Magento/Customer/Controller/Address.php
index fc8c6df73dd86d97d9ef44d349f721f681b7131d..0d9d83ca15c33768e24848fbcc8cd3eeb946a4e4 100644
--- a/app/code/Magento/Customer/Controller/Address.php
+++ b/app/code/Magento/Customer/Controller/Address.php
@@ -94,9 +94,6 @@ class Address extends \Magento\Framework\App\Action\Action
* @param \Magento\Customer\Api\Data\AddressDataBuilder $addressDataBuilder
* @param \Magento\Customer\Api\Data\RegionDataBuilder $regionDataBuilder
* @param \Magento\Framework\Reflection\DataObjectProcessor $dataProcessor
- * @internal param \Magento\Customer\Helper\Data $customerData
- * @internal param \Magento\Customer\Model\AddressFactory $addressFactory
- * @internal param \Magento\Customer\Model\Address\FormFactory $addressFormFactory
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function __construct(
diff --git a/app/code/Magento/Customer/Controller/Adminhtml/Cart/Product/Composite/Cart.php b/app/code/Magento/Customer/Controller/Adminhtml/Cart/Product/Composite/Cart.php
index 9f9e40ff164048878f2735d330c935229805533f..0f4be494149124708ebcf910c9bdf99d323c59fd 100644
--- a/app/code/Magento/Customer/Controller/Adminhtml/Cart/Product/Composite/Cart.php
+++ b/app/code/Magento/Customer/Controller/Adminhtml/Cart/Product/Composite/Cart.php
@@ -23,6 +23,7 @@
*/
namespace Magento\Customer\Controller\Adminhtml\Cart\Product\Composite;
+use Magento\Backend\App\Action;
use Magento\Framework\Model\Exception;
/**
@@ -53,6 +54,23 @@ class Cart extends \Magento\Backend\App\Action
*/
protected $_quoteItem = null;
+ /**
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
+ /**
+ * @param Action\Context $context
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
+ */
+ public function __construct(
+ Action\Context $context,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository
+ ) {
+ $this->quoteRepository = $quoteRepository;
+ parent::__construct($context);
+ }
+
/**
* Loads customer, quote and quote item by request params
*
@@ -69,12 +87,13 @@ class Cart extends \Magento\Backend\App\Action
$quoteItemId = (int)$this->getRequest()->getParam('id');
$websiteId = (int)$this->getRequest()->getParam('website_id');
- $this->_quote = $this->_objectManager->create(
- 'Magento\Sales\Model\Quote'
- )->setWebsite(
+ try {
+ $this->_quote = $this->quoteRepository->getForCustomer($this->_customerId);
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+ $this->_quote = $this->quoteRepository->create();
+ }
+ $this->_quote->setWebsite(
$this->_objectManager->get('Magento\Framework\StoreManagerInterface')->getWebsite($websiteId)
- )->loadByCustomer(
- $this->_customerId
);
$this->_quoteItem = $this->_quote->getItemById($quoteItemId);
diff --git a/app/code/Magento/Customer/Controller/Adminhtml/Cart/Product/Composite/Cart/Update.php b/app/code/Magento/Customer/Controller/Adminhtml/Cart/Product/Composite/Cart/Update.php
index 90dc3a248d971ab71be0fa7bed503c2660cfa585..0ac15ad487d8605b8bfd29fbfbcb22fee4bb4afe 100644
--- a/app/code/Magento/Customer/Controller/Adminhtml/Cart/Product/Composite/Cart/Update.php
+++ b/app/code/Magento/Customer/Controller/Adminhtml/Cart/Product/Composite/Cart/Update.php
@@ -39,7 +39,8 @@ class Update extends \Magento\Customer\Controller\Adminhtml\Cart\Product\Composi
$buyRequest = new \Magento\Framework\Object($this->getRequest()->getParams());
$this->_quote->updateItem($this->_quoteItem->getId(), $buyRequest);
- $this->_quote->collectTotals()->save();
+ $this->_quote->collectTotals();
+ $this->quoteRepository->save($this->_quote);
$updateResult->setOk(true);
} catch (\Exception $e) {
diff --git a/app/code/Magento/Customer/Controller/Adminhtml/Index.php b/app/code/Magento/Customer/Controller/Adminhtml/Index.php
index 4efc84c317e9eca7f6ea063610aeef4b974133ab..2ae4906326dacd168b10292a41344aa8e1fbc2e7 100644
--- a/app/code/Magento/Customer/Controller/Adminhtml/Index.php
+++ b/app/code/Magento/Customer/Controller/Adminhtml/Index.php
@@ -85,11 +85,6 @@ class Index extends \Magento\Backend\App\Action
/** @var \Magento\Newsletter\Model\SubscriberFactory */
protected $_subscriberFactory;
- /**
- * @var \Magento\Customer\Helper\Data
- */
- protected $_dataHelper = null;
-
/**
* @var \Magento\Customer\Model\Metadata\FormFactory
*/
@@ -125,7 +120,6 @@ class Index extends \Magento\Backend\App\Action
* @param CustomerAddressServiceInterface $addressService
* @param \Magento\Customer\Service\V1\CustomerAccountServiceInterface $accountService
* @param \Magento\Customer\Helper\View $viewHelper
- * @param \Magento\Customer\Helper\Data $helper
* @param \Magento\Framework\Math\Random $random
* @param CustomerRepositoryInterface $customerRepository
*
@@ -146,7 +140,6 @@ class Index extends \Magento\Backend\App\Action
CustomerAddressServiceInterface $addressService,
CustomerAccountServiceInterface $accountService,
\Magento\Customer\Helper\View $viewHelper,
- \Magento\Customer\Helper\Data $helper,
\Magento\Framework\Math\Random $random,
CustomerRepositoryInterface $customerRepository
) {
@@ -159,7 +152,6 @@ class Index extends \Magento\Backend\App\Action
$this->_addressDataBuilder = $addressDataBuilder;
$this->_addressFactory = $addressFactory;
$this->_subscriberFactory = $subscriberFactory;
- $this->_dataHelper = $helper;
$this->_formFactory = $formFactory;
$this->_addressService = $addressService;
$this->_customerAccountService = $accountService;
diff --git a/app/code/Magento/Customer/Controller/Adminhtml/Index/Cart.php b/app/code/Magento/Customer/Controller/Adminhtml/Index/Cart.php
index 5bc7e3e4466d40b2db9c524a614bc85c5c940e24..c30dee1b579725a3c4d3c538648efad9f3294035 100644
--- a/app/code/Magento/Customer/Controller/Adminhtml/Index/Cart.php
+++ b/app/code/Magento/Customer/Controller/Adminhtml/Index/Cart.php
@@ -41,17 +41,23 @@ class Cart extends \Magento\Customer\Controller\Adminhtml\Index
// delete an item from cart
$deleteItemId = $this->getRequest()->getPost('delete');
if ($deleteItemId) {
- $quote = $this->_objectManager->create(
- 'Magento\Sales\Model\Quote'
- )->setWebsite(
+ /** @var \Magento\Sales\Model\QuoteRepository $quoteRepository */
+ $quoteRepository = $this->_objectManager->create('Magento\Sales\Model\QuoteRepository');
+ /** @var \Magento\Sales\Model\Quote $quote */
+ try {
+ $quote = $quoteRepository->getForCustomer(
+ $this->_coreRegistry->registry(RegistryConstants::CURRENT_CUSTOMER_ID)
+ );
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+ $quote = $quoteRepository->create();
+ }
+ $quote->setWebsite(
$this->_objectManager->get('Magento\Framework\StoreManagerInterface')->getWebsite($websiteId)
- )->loadByCustomer(
- $this->_coreRegistry->registry(RegistryConstants::CURRENT_CUSTOMER_ID)
);
$item = $quote->getItemById($deleteItemId);
if ($item && $item->getId()) {
$quote->removeItem($deleteItemId);
- $quote->collectTotals()->save();
+ $quoteRepository->save($quote->collectTotals());
}
}
diff --git a/app/code/Magento/Customer/Controller/Adminhtml/Index/Save.php b/app/code/Magento/Customer/Controller/Adminhtml/Index/Save.php
index f5ba7ba0c1c493a2b825d4569910d36b1fd17620..00adcb675f9c394757850e51a26d80a703248bb5 100644
--- a/app/code/Magento/Customer/Controller/Adminhtml/Index/Save.php
+++ b/app/code/Magento/Customer/Controller/Adminhtml/Index/Save.php
@@ -29,8 +29,16 @@ use Magento\Customer\Service\V1\Data\Customer;
use Magento\Framework\Exception\LocalizedException;
use Magento\Customer\Service\V1\CustomerMetadataService as CustomerMetadata;
+/**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
class Save extends \Magento\Customer\Controller\Adminhtml\Index
{
+ /**
+ * @var \Magento\Customer\Model\Metadata\FormFactory
+ */
+ protected $_formFactory;
+
/**
* Reformat customer account data to be compatible with customer service interface
*
@@ -46,9 +54,8 @@ class Save extends \Magento\Customer\Controller\Adminhtml\Index
'confirmation',
'sendemail'
);
- /** @var \Magento\Customer\Helper\Data $customerHelper */
- $customerHelper = $this->_objectManager->get('Magento\Customer\Helper\Data');
- $customerData = $customerHelper->extractCustomerData(
+
+ $customerData = $this->_extractData(
$this->getRequest(),
'adminhtml_customer',
CustomerMetadata::ENTITY_TYPE_CUSTOMER,
@@ -64,6 +71,53 @@ class Save extends \Magento\Customer\Controller\Adminhtml\Index
return $customerData;
}
+ /**
+ * Perform customer data filtration based on form code and form object
+ *
+ * @param \Magento\Framework\App\RequestInterface $request
+ * @param string $formCode The code of EAV form to take the list of attributes from
+ * @param string $entityType entity type for the form
+ * @param string[] $additionalAttributes The list of attribute codes to skip filtration for
+ * @param string $scope scope of the request
+ * @param \Magento\Customer\Model\Metadata\Form $metadataForm to use for extraction
+ * @return array Filtered customer data
+ */
+ protected function _extractData(
+ \Magento\Framework\App\RequestInterface $request,
+ $formCode,
+ $entityType,
+ $additionalAttributes = array(),
+ $scope = null,
+ \Magento\Customer\Model\Metadata\Form $metadataForm = null
+ ) {
+ if (is_null($metadataForm)) {
+ $metadataForm = $this->_objectManager->get('Magento\Customer\Model\Metadata\FormFactory')->create(
+ $entityType,
+ $formCode,
+ array(),
+ false,
+ \Magento\Customer\Model\Metadata\Form::DONT_IGNORE_INVISIBLE
+ );
+ }
+ $filteredData = $metadataForm->extractData($request, $scope);
+ $requestData = $request->getPost($scope);
+ foreach ($additionalAttributes as $attributeCode) {
+ $filteredData[$attributeCode] = isset($requestData[$attributeCode]) ? $requestData[$attributeCode] : false;
+ }
+
+ $formAttributes = $metadataForm->getAttributes();
+ /** @var \Magento\Customer\Service\V1\Data\Eav\AttributeMetadata $attribute */
+ foreach ($formAttributes as $attribute) {
+ $attributeCode = $attribute->getAttributeCode();
+ $frontendInput = $attribute->getFrontendInput();
+ if ($frontendInput != 'boolean' && $filteredData[$attributeCode] === false) {
+ unset($filteredData[$attributeCode]);
+ }
+ }
+
+ return $filteredData;
+ }
+
/**
* Reformat customer addresses data to be compatible with customer service interface
*
@@ -80,11 +134,10 @@ class Save extends \Magento\Customer\Controller\Adminhtml\Index
}
$addressIdList = array_keys($addresses);
- /** @var \Magento\Customer\Helper\Data $customerHelper */
- $customerHelper = $this->_objectManager->get('Magento\Customer\Helper\Data');
+
foreach ($addressIdList as $addressId) {
$scope = sprintf('address/%s', $addressId);
- $addressData = $customerHelper->extractCustomerData(
+ $addressData = $this->_extractData(
$this->getRequest(),
'adminhtml_customer_address',
\Magento\Customer\Api\AddressMetadataInterface::ENTITY_TYPE_ADDRESS,
diff --git a/app/code/Magento/Customer/Controller/Adminhtml/System/Config/Validatevat.php b/app/code/Magento/Customer/Controller/Adminhtml/System/Config/Validatevat.php
index c88d6df4e401e8cfc6ed0d646916eb6f44ebbad8..f1cd0a02d84c731a81435df634c837caf5c6f9bd 100644
--- a/app/code/Magento/Customer/Controller/Adminhtml/System/Config/Validatevat.php
+++ b/app/code/Magento/Customer/Controller/Adminhtml/System/Config/Validatevat.php
@@ -38,7 +38,7 @@ class Validatevat extends \Magento\Backend\App\Action
protected function _validate()
{
return $this->_objectManager->get(
- 'Magento\Customer\Helper\Data'
+ 'Magento\Customer\Model\Vat'
)->checkVatNumber(
$this->getRequest()->getParam('country'),
$this->getRequest()->getParam('vat')
diff --git a/app/code/Magento/Customer/Controller/Adminhtml/System/Config/Validatevat/ValidateAdvanced.php b/app/code/Magento/Customer/Controller/Adminhtml/System/Config/Validatevat/ValidateAdvanced.php
index 85488191350a769e2a1964e02417634cbae897be..ddde4c0483f18959c66170400c0a0662e1c3faf0 100644
--- a/app/code/Magento/Customer/Controller/Adminhtml/System/Config/Validatevat/ValidateAdvanced.php
+++ b/app/code/Magento/Customer/Controller/Adminhtml/System/Config/Validatevat/ValidateAdvanced.php
@@ -47,7 +47,7 @@ class ValidateAdvanced extends \Magento\Customer\Controller\Adminhtml\System\Con
}
$groupId = $this->_objectManager->get(
- 'Magento\Customer\Helper\Data'
+ 'Magento\Customer\Model\Vat'
)->getCustomerGroupIdBasedOnVatNumber(
$this->getRequest()->getParam('country'),
$result,
diff --git a/app/code/Magento/Customer/Helper/Data.php b/app/code/Magento/Customer/Helper/Data.php
deleted file mode 100644
index dc6bba79213e170eb0b5aff13b0992519c2f2b0f..0000000000000000000000000000000000000000
--- a/app/code/Magento/Customer/Helper/Data.php
+++ /dev/null
@@ -1,711 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\Customer\Helper;
-
-/**
- * Customer Data Helper
- *
- * @SuppressWarnings(PHPMD.TooManyFields)
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
- */
-class Data extends \Magento\Framework\App\Helper\AbstractHelper
-{
- /**
- * Customer group cache context
- */
- const CONTEXT_GROUP = 'customer_group';
-
- /**
- * Customer authorization cache context
- */
- const CONTEXT_AUTH = 'customer_logged_in';
-
- /**
- * Query param name for last url visited
- */
- const REFERER_QUERY_PARAM_NAME = 'referer';
-
- /**
- * Route for customer account login page
- */
- const ROUTE_ACCOUNT_LOGIN = 'customer/account/login';
-
- /**
- * Config name for Redirect Customer to Account Dashboard after Logging in setting
- */
- const XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD = 'customer/startup/redirect_dashboard';
-
- /**
- * Config paths to VAT related customer groups
- */
- const XML_PATH_CUSTOMER_VIV_INTRA_UNION_GROUP = 'customer/create_account/viv_intra_union_group';
-
- const XML_PATH_CUSTOMER_VIV_DOMESTIC_GROUP = 'customer/create_account/viv_domestic_group';
-
- const XML_PATH_CUSTOMER_VIV_INVALID_GROUP = 'customer/create_account/viv_invalid_group';
-
- const XML_PATH_CUSTOMER_VIV_ERROR_GROUP = 'customer/create_account/viv_error_group';
-
- /**
- * Config path to option that enables/disables automatic group assignment based on VAT
- */
- const XML_PATH_CUSTOMER_GROUP_AUTO_ASSIGN = 'customer/create_account/auto_group_assign';
-
- /**
- * Config path to support email
- */
- const XML_PATH_SUPPORT_EMAIL = 'trans_email/ident_support/email';
-
- /**
- * WSDL of VAT validation service
- *
- */
- const VAT_VALIDATION_WSDL_URL = 'http://ec.europa.eu/taxation_customs/vies/services/checkVatService?wsdl';
-
- /**
- * Configuration path to expiration period of reset password link
- */
- const XML_PATH_CUSTOMER_RESET_PASSWORD_LINK_EXPIRATION_PERIOD = 'customer/password/reset_link_expiration_period';
-
- /**
- * Configuration path to merchant country id
- */
- const XML_PATH_MERCHANT_COUNTRY_CODE = 'general/store_information/country_id';
-
- /**
- * Config path to merchant VAT number
- */
- const XML_PATH_MERCHANT_VAT_NUMBER = 'general/store_information/merchant_vat_number';
-
- /**
- * Config path to UE country list
- */
- const XML_PATH_EU_COUNTRIES_LIST = 'general/country/eu_countries';
-
- /**
- * VAT class constants
- */
- const VAT_CLASS_DOMESTIC = 'domestic';
-
- const VAT_CLASS_INTRA_UNION = 'intra_union';
-
- const VAT_CLASS_INVALID = 'invalid';
-
- const VAT_CLASS_ERROR = 'error';
-
- /**
- * Core data
- *
- * @var \Magento\Core\Helper\Data
- */
- protected $_coreData;
-
- /**
- * Customer address
- *
- * @var Address
- */
- protected $_customerAddress = null;
-
- /**
- * @var \Magento\Framework\App\Config\ScopeConfigInterface
- */
- protected $_scopeConfig;
-
- /**
- * @var \Magento\Customer\Model\Session
- */
- protected $_customerSession;
-
- /**
- * @var \Magento\Customer\Service\V1\CustomerGroupServiceInterface
- */
- protected $_groupService;
-
- /**
- * @var \Magento\Customer\Model\Metadata\FormFactory
- */
- protected $_formFactory;
-
- /**
- * @var \Magento\Framework\Escaper
- */
- protected $_escaper;
-
- /**
- * @var \Magento\Framework\Math\Random
- */
- protected $mathRandom;
-
- /**
- * @param \Magento\Framework\App\Helper\Context $context
- * @param Address $customerAddress
- * @param \Magento\Core\Helper\Data $coreData
- * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
- * @param \Magento\Customer\Model\Session $customerSession
- * @param \Magento\Customer\Service\V1\CustomerGroupServiceInterface $groupService
- * @param \Magento\Customer\Model\Metadata\FormFactory $formFactory
- * @param \Magento\Framework\Escaper $escaper
- * @param \Magento\Framework\Math\Random $mathRandom
- *
- * @SuppressWarnings(PHPMD.ExcessiveParameterList)
- */
- public function __construct(
- \Magento\Framework\App\Helper\Context $context,
- Address $customerAddress,
- \Magento\Core\Helper\Data $coreData,
- \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
- \Magento\Customer\Model\Session $customerSession,
- \Magento\Customer\Service\V1\CustomerGroupServiceInterface $groupService,
- \Magento\Customer\Model\Metadata\FormFactory $formFactory,
- \Magento\Framework\Escaper $escaper,
- \Magento\Framework\Math\Random $mathRandom
- ) {
- $this->_customerAddress = $customerAddress;
- $this->_coreData = $coreData;
- $this->_scopeConfig = $scopeConfig;
- $this->_customerSession = $customerSession;
- $this->_groupService = $groupService;
- $this->_formFactory = $formFactory;
- $this->_escaper = $escaper;
- $this->mathRandom = $mathRandom;
- parent::__construct($context);
- }
-
- /**
- * Retrieve merchant country code
- *
- * @param \Magento\Store\Model\Store|string|int|null $store
- * @return string
- */
- public function getMerchantCountryCode($store = null)
- {
- return (string)$this->_scopeConfig->getValue(
- self::XML_PATH_MERCHANT_COUNTRY_CODE,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- $store
- );
- }
-
- /**
- * Retrieve merchant VAT number
- *
- * @param \Magento\Store\Model\Store|string|int|null $store
- * @return string
- */
- public function getMerchantVatNumber($store = null)
- {
- return (string)$this->_scopeConfig->getValue(
- self::XML_PATH_MERCHANT_VAT_NUMBER,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- $store
- );
- }
-
- /**
- * Check whether specified country is in EU countries list
- *
- * @param string $countryCode
- * @param null|int $storeId
- * @return bool
- */
- public function isCountryInEU($countryCode, $storeId = null)
- {
- $euCountries = explode(
- ',',
- $this->_scopeConfig->getValue(
- self::XML_PATH_EU_COUNTRIES_LIST,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- $storeId
- )
- );
- return in_array($countryCode, $euCountries);
- }
-
- /**
- * Check customer is logged in
- *
- * @return bool
- */
- public function isLoggedIn()
- {
- return $this->_customerSession->isLoggedIn();
- }
-
- /**************************************************************************
- * Customer urls
- */
-
- /**
- * Retrieve customer login url
- *
- * @return string
- */
- public function getLoginUrl()
- {
- return $this->_getUrl(self::ROUTE_ACCOUNT_LOGIN, $this->getLoginUrlParams());
- }
-
- /**
- * Retrieve parameters of customer login url
- *
- * @return array
- */
- public function getLoginUrlParams()
- {
- $params = array();
-
- $referer = $this->_getRequest()->getParam(self::REFERER_QUERY_PARAM_NAME);
-
- if (!$referer && !$this->_scopeConfig->isSetFlag(
- self::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- ) && !$this->_customerSession->getNoReferer()
- ) {
- $referer = $this->_getUrl('*/*/*', array('_current' => true, '_use_rewrite' => true));
- $referer = $this->_coreData->urlEncode($referer);
- }
-
- if ($referer) {
- $params = array(self::REFERER_QUERY_PARAM_NAME => $referer);
- }
-
- return $params;
- }
-
- /**
- * Retrieve customer login POST URL
- *
- * @return string
- */
- public function getLoginPostUrl()
- {
- $params = array();
- if ($this->_getRequest()->getParam(self::REFERER_QUERY_PARAM_NAME)) {
- $params = array(
- self::REFERER_QUERY_PARAM_NAME => $this->_getRequest()->getParam(self::REFERER_QUERY_PARAM_NAME)
- );
- }
- return $this->_getUrl('customer/account/loginPost', $params);
- }
-
- /**
- * Retrieve customer logout url
- *
- * @return string
- */
- public function getLogoutUrl()
- {
- return $this->_getUrl('customer/account/logout');
- }
-
- /**
- * Retrieve customer dashboard url
- *
- * @return string
- */
- public function getDashboardUrl()
- {
- return $this->_getUrl('customer/account');
- }
-
- /**
- * Retrieve customer account page url
- *
- * @return string
- */
- public function getAccountUrl()
- {
- return $this->_getUrl('customer/account');
- }
-
- /**
- * Retrieve customer register form url
- *
- * @return string
- */
- public function getRegisterUrl()
- {
- return $this->_getUrl('customer/account/create');
- }
-
- /**
- * Retrieve customer register form post url
- *
- * @return string
- */
- public function getRegisterPostUrl()
- {
- return $this->_getUrl('customer/account/createpost');
- }
-
- /**
- * Retrieve customer account edit form url
- *
- * @return string
- */
- public function getEditUrl()
- {
- return $this->_getUrl('customer/account/edit');
- }
-
- /**
- * Retrieve customer edit POST URL
- *
- * @return string
- */
- public function getEditPostUrl()
- {
- return $this->_getUrl('customer/account/editpost');
- }
-
- /**
- * Retrieve url of forgot password page
- *
- * @return string
- */
- public function getForgotPasswordUrl()
- {
- return $this->_getUrl('customer/account/forgotpassword');
- }
-
- /**
- * Retrieve confirmation URL for Email
- *
- * @param string $email
- * @return string
- */
- public function getEmailConfirmationUrl($email = null)
- {
- return $this->_getUrl('customer/account/confirmation', array('email' => $email));
- }
-
- /**
- * Check whether customers registration is allowed
- *
- * @return bool
- */
- public function isRegistrationAllowed()
- {
- return true;
- }
-
- /**
- * Retrieve name prefix dropdown options
- *
- * @param null $store
- * @return array|bool
- */
- public function getNamePrefixOptions($store = null)
- {
- return $this->_prepareNamePrefixSuffixOptions($this->_customerAddress->getConfig('prefix_options', $store));
- }
-
- /**
- * Retrieve name suffix dropdown options
- *
- * @param null $store
- * @return array|bool
- */
- public function getNameSuffixOptions($store = null)
- {
- return $this->_prepareNamePrefixSuffixOptions($this->_customerAddress->getConfig('suffix_options', $store));
- }
-
- /**
- * Unserialize and clear name prefix or suffix options
- *
- * @param string $options
- * @return array|bool
- */
- protected function _prepareNamePrefixSuffixOptions($options)
- {
- $options = trim($options);
- if (empty($options)) {
- return false;
- }
- $result = array();
- $options = explode(';', $options);
- foreach ($options as $value) {
- $value = $this->_escaper->escapeHtml(trim($value));
- $result[$value] = $value;
- }
- return $result;
- }
-
- /**
- * Generate unique token for reset password confirmation link
- *
- * @return string
- */
- public function generateResetPasswordLinkToken()
- {
- return $this->mathRandom->getUniqueHash();
- }
-
- /**
- * Retrieve customer reset password link expiration period in days
- *
- * @return int
- */
- public function getResetPasswordLinkExpirationPeriod()
- {
- return (int)$this->_scopeConfig->getValue(
- self::XML_PATH_CUSTOMER_RESET_PASSWORD_LINK_EXPIRATION_PERIOD,
- \Magento\Framework\App\ScopeInterface::SCOPE_DEFAULT
- );
- }
-
- /**
- * Get default customer group id
- *
- * @param \Magento\Store\Model\Store|string|int $store
- * @return int
- */
- public function getDefaultCustomerGroupId($store = null)
- {
- return $this->_groupService->getDefaultGroup($store)->getId();
- }
-
- /**
- * Retrieve customer group ID based on his VAT number
- *
- * @param string $customerCountryCode
- * @param \Magento\Framework\Object $vatValidationResult
- * @param \Magento\Store\Model\Store|string|int $store
- * @return null|int
- */
- public function getCustomerGroupIdBasedOnVatNumber($customerCountryCode, $vatValidationResult, $store = null)
- {
- $groupId = null;
-
- $isAutoGroupAssign = $this->_scopeConfig->isSetFlag(
- self::XML_PATH_CUSTOMER_GROUP_AUTO_ASSIGN,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- $store
- );
- if (!$isAutoGroupAssign) {
- return $groupId;
- }
-
- $vatClass = $this->getCustomerVatClass($customerCountryCode, $vatValidationResult, $store);
-
- $vatClassToGroupXmlPathMap = array(
- self::VAT_CLASS_DOMESTIC => self::XML_PATH_CUSTOMER_VIV_DOMESTIC_GROUP,
- self::VAT_CLASS_INTRA_UNION => self::XML_PATH_CUSTOMER_VIV_INTRA_UNION_GROUP,
- self::VAT_CLASS_INVALID => self::XML_PATH_CUSTOMER_VIV_INVALID_GROUP,
- self::VAT_CLASS_ERROR => self::XML_PATH_CUSTOMER_VIV_ERROR_GROUP
- );
-
- if (isset($vatClassToGroupXmlPathMap[$vatClass])) {
- $groupId = (int)$this->_scopeConfig->getValue(
- $vatClassToGroupXmlPathMap[$vatClass],
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- $store
- );
- }
-
- return $groupId;
- }
-
- /**
- * Send request to VAT validation service and return validation result
- *
- * @param string $countryCode
- * @param string $vatNumber
- * @param string $requesterCountryCode
- * @param string $requesterVatNumber
- *
- * @return \Magento\Framework\Object
- */
- public function checkVatNumber($countryCode, $vatNumber, $requesterCountryCode = '', $requesterVatNumber = '')
- {
- // Default response
- $gatewayResponse = new \Magento\Framework\Object(
- array('is_valid' => false, 'request_date' => '', 'request_identifier' => '', 'request_success' => false)
- );
-
- if (!extension_loaded('soap')) {
- $this->_logger->logException(new \Magento\Framework\Model\Exception(__('PHP SOAP extension is required.')));
- return $gatewayResponse;
- }
-
- if (!$this->canCheckVatNumber($countryCode, $vatNumber, $requesterCountryCode, $requesterVatNumber)) {
- return $gatewayResponse;
- }
-
- try {
- $soapClient = $this->_createVatNumberValidationSoapClient();
-
- $requestParams = array();
- $requestParams['countryCode'] = $countryCode;
- $requestParams['vatNumber'] = str_replace(array(' ', '-'), array('', ''), $vatNumber);
- $requestParams['requesterCountryCode'] = $requesterCountryCode;
- $requestParams['requesterVatNumber'] = str_replace(array(' ', '-'), array('', ''), $requesterVatNumber);
-
- // Send request to service
- $result = $soapClient->checkVatApprox($requestParams);
-
- $gatewayResponse->setIsValid((bool)$result->valid);
- $gatewayResponse->setRequestDate((string)$result->requestDate);
- $gatewayResponse->setRequestIdentifier((string)$result->requestIdentifier);
- $gatewayResponse->setRequestSuccess(true);
- } catch (\Exception $exception) {
- $gatewayResponse->setIsValid(false);
- $gatewayResponse->setRequestDate('');
- $gatewayResponse->setRequestIdentifier('');
- }
-
- return $gatewayResponse;
- }
-
- /**
- * Check if parameters are valid to send to VAT validation service
- *
- * @param string $countryCode
- * @param string $vatNumber
- * @param string $requesterCountryCode
- * @param string $requesterVatNumber
- *
- * @return boolean
- *
- * @SuppressWarnings(PHPMD.CyclomaticComplexity)
- */
- public function canCheckVatNumber($countryCode, $vatNumber, $requesterCountryCode, $requesterVatNumber)
- {
- $result = true;
- if (!is_string(
- $countryCode
- ) || !is_string(
- $vatNumber
- ) || !is_string(
- $requesterCountryCode
- ) || !is_string(
- $requesterVatNumber
- ) || empty($countryCode) || !$this->isCountryInEU(
- $countryCode
- ) ||
- empty($vatNumber) ||
- empty($requesterCountryCode) && !empty($requesterVatNumber) ||
- !empty($requesterCountryCode) && empty($requesterVatNumber) ||
- !empty($requesterCountryCode) && !$this->isCountryInEU($requesterCountryCode)
- ) {
- $result = false;
- }
-
- return $result;
- }
-
- /**
- * Get VAT class
- *
- * @param string $customerCountryCode
- * @param \Magento\Framework\Object $vatValidationResult
- * @param \Magento\Store\Model\Store|string|int|null $store
- * @return null|string
- */
- public function getCustomerVatClass($customerCountryCode, $vatValidationResult, $store = null)
- {
- $vatClass = null;
-
- $isVatNumberValid = $vatValidationResult->getIsValid();
-
- if (is_string(
- $customerCountryCode
- ) && !empty($customerCountryCode) && $customerCountryCode === $this->getMerchantCountryCode(
- $store
- ) && $isVatNumberValid
- ) {
- $vatClass = self::VAT_CLASS_DOMESTIC;
- } elseif ($isVatNumberValid) {
- $vatClass = self::VAT_CLASS_INTRA_UNION;
- } else {
- $vatClass = self::VAT_CLASS_INVALID;
- }
-
- if (!$vatValidationResult->getRequestSuccess()) {
- $vatClass = self::VAT_CLASS_ERROR;
- }
-
- return $vatClass;
- }
-
- /**
- * Create SOAP client based on VAT validation service WSDL
- *
- * @param boolean $trace
- * @return \SoapClient
- */
- protected function _createVatNumberValidationSoapClient($trace = false)
- {
- return new \SoapClient(self::VAT_VALIDATION_WSDL_URL, array('trace' => $trace));
- }
-
- /**
- * Perform customer data filtration based on form code and form object
- *
- * @param \Magento\Framework\App\RequestInterface $request
- * @param string $formCode The code of EAV form to take the list of attributes from
- * @param string $entityType entity type for the form
- * @param string[] $additionalAttributes The list of attribute codes to skip filtration for
- * @param string $scope scope of the request
- * @param \Magento\Customer\Model\Metadata\Form $metadataForm to use for extraction
- * @return array Filtered customer data
- */
- public function extractCustomerData(
- \Magento\Framework\App\RequestInterface $request,
- $formCode,
- $entityType,
- $additionalAttributes = array(),
- $scope = null,
- \Magento\Customer\Model\Metadata\Form $metadataForm = null
- ) {
- if (is_null($metadataForm)) {
- $metadataForm = $this->_formFactory->create(
- $entityType,
- $formCode,
- array(),
- false,
- \Magento\Customer\Model\Metadata\Form::DONT_IGNORE_INVISIBLE
- );
- }
- $filteredData = $metadataForm->extractData($request, $scope);
- $requestData = $request->getPost($scope);
- foreach ($additionalAttributes as $attributeCode) {
- $filteredData[$attributeCode] = isset($requestData[$attributeCode]) ? $requestData[$attributeCode] : false;
- }
-
- $formAttributes = $metadataForm->getAttributes();
- /** @var \Magento\Customer\Service\V1\Data\Eav\AttributeMetadata $attribute */
- foreach ($formAttributes as $attribute) {
- $attributeCode = $attribute->getAttributeCode();
- $frontendInput = $attribute->getFrontendInput();
- if ($frontendInput != 'boolean' && $filteredData[$attributeCode] === false) {
- unset($filteredData[$attributeCode]);
- }
- }
-
- return $filteredData;
- }
-}
diff --git a/app/code/Magento/Customer/Model/AccountManagement.php b/app/code/Magento/Customer/Model/AccountManagement.php
index b2d54213fa67b125c6bff388bd4ffd325477c795..38400cd8fe7c84f16e1117e9c5139173c9d92787 100644
--- a/app/code/Magento/Customer/Model/AccountManagement.php
+++ b/app/code/Magento/Customer/Model/AccountManagement.php
@@ -28,7 +28,6 @@ use Magento\Customer\Api\AccountManagementInterface;
use Magento\Customer\Api\AddressRepositoryInterface;
use Magento\Customer\Api\CustomerRepositoryInterface;
use Magento\Customer\Api\Data\CustomerInterface;
-use Magento\Customer\Helper\Data as CustomerDataHelper;
use Magento\Customer\Model\Config\Share as ConfigShare;
use Magento\Customer\Model\Customer as CustomerModel;
use Magento\Customer\Model\CustomerFactory;
@@ -220,11 +219,6 @@ class AccountManagement implements AccountManagementInterface
*/
protected $registry;
- /**
- * @var CustomerDataHelper
- */
- protected $customerDataHelper;
-
/**
* @var DateTime
*/
@@ -235,6 +229,11 @@ class AccountManagement implements AccountManagementInterface
*/
protected $objectFactory;
+ /**
+ * @var CustomerModel
+ */
+ protected $customerModel;
+
/**
* @param CustomerFactory $customerFactory
* @param ManagerInterface $eventManager
@@ -257,9 +256,9 @@ class AccountManagement implements AccountManagementInterface
* @param \Magento\Customer\Api\Data\CustomerDataBuilder $customerDataBuilder
* @param DataObjectProcessor $dataProcessor
* @param \Magento\Framework\Registry $registry
- * @param CustomerDataHelper $customerDataHelper
* @param DateTime $dateTime
* @param \Magento\Framework\ObjectFactory $objectFactory
+ * @param CustomerModel $customerModel
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
@@ -285,9 +284,9 @@ class AccountManagement implements AccountManagementInterface
\Magento\Customer\Api\Data\CustomerDataBuilder $customerDataBuilder,
DataObjectProcessor $dataProcessor,
\Magento\Framework\Registry $registry,
- CustomerDataHelper $customerDataHelper,
DateTime $dateTime,
- \Magento\Framework\ObjectFactory $objectFactory
+ \Magento\Framework\ObjectFactory $objectFactory,
+ CustomerModel $customerModel
) {
$this->customerFactory = $customerFactory;
$this->eventManager = $eventManager;
@@ -310,9 +309,9 @@ class AccountManagement implements AccountManagementInterface
$this->customerDataBuilder = $customerDataBuilder;
$this->dataProcessor = $dataProcessor;
$this->registry = $registry;
- $this->customerDataHelper = $customerDataHelper;
$this->dateTime = $dateTime;
$this->objectFactory = $objectFactory;
+ $this->customerModel = $customerModel;
}
/**
@@ -999,7 +998,7 @@ class AccountManagement implements AccountManagementInterface
return true;
}
- $expirationPeriod = $this->customerDataHelper->getResetPasswordLinkExpirationPeriod();
+ $expirationPeriod = $this->customerModel->getResetPasswordLinkExpirationPeriod();
$currentTimestamp = $this->dateTime->toTimestamp($this->dateTime->now());
$tokenTimestamp = $this->dateTime->toTimestamp($rpTokenCreatedAt);
diff --git a/app/code/Magento/Customer/Model/App/Action/ContextPlugin.php b/app/code/Magento/Customer/Model/App/Action/ContextPlugin.php
index e95689eb98fcf7dc3ba6677c0b2a2007a651a1ef..556f023cf746b39597df3b67638775f34a9a0932 100644
--- a/app/code/Magento/Customer/Model/App/Action/ContextPlugin.php
+++ b/app/code/Magento/Customer/Model/App/Action/ContextPlugin.php
@@ -24,6 +24,8 @@
namespace Magento\Customer\Model\App\Action;
+use Magento\Customer\Model\Context;
+
/**
* Class ContextPlugin
*/
@@ -63,12 +65,12 @@ class ContextPlugin
\Magento\Framework\App\RequestInterface $request
) {
$this->httpContext->setValue(
- \Magento\Customer\Helper\Data::CONTEXT_GROUP,
+ Context::CONTEXT_GROUP,
$this->customerSession->getCustomerGroupId(),
\Magento\Customer\Service\V1\CustomerGroupServiceInterface::NOT_LOGGED_IN_ID
);
$this->httpContext->setValue(
- \Magento\Customer\Helper\Data::CONTEXT_AUTH,
+ Context::CONTEXT_AUTH,
$this->customerSession->isLoggedIn(),
false
);
diff --git a/app/code/Magento/Customer/Model/Context.php b/app/code/Magento/Customer/Model/Context.php
new file mode 100644
index 0000000000000000000000000000000000000000..96d9b0a986109a4b22e2956ce648f429df296bd4
--- /dev/null
+++ b/app/code/Magento/Customer/Model/Context.php
@@ -0,0 +1,36 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Customer\Model;
+
+class Context
+{
+ /**
+ * Customer group cache context
+ */
+ const CONTEXT_GROUP = 'customer_group';
+ /**
+ * Customer authorization cache context
+ */
+ const CONTEXT_AUTH = 'customer_logged_in';
+}
diff --git a/app/code/Magento/Customer/Model/Customer.php b/app/code/Magento/Customer/Model/Customer.php
index 8f15964efddeaa4a530f4153a489c51fd3baab17..d8891fdc3e29344904ad2fe23f76ddcb7f108bbe 100644
--- a/app/code/Magento/Customer/Model/Customer.php
+++ b/app/code/Magento/Customer/Model/Customer.php
@@ -89,6 +89,11 @@ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel
const ENTITY = 'customer';
+ /**
+ * Configuration path to expiration period of reset password link
+ */
+ const XML_PATH_CUSTOMER_RESET_PASSWORD_LINK_EXPIRATION_PERIOD = 'customer/password/reset_link_expiration_period';
+
/**
* Model event prefix
*
@@ -148,13 +153,6 @@ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel
*/
protected $_config;
- /**
- * Customer data
- *
- * @var \Magento\Customer\Helper\Data
- */
- protected $_customerData = null;
-
/**
* @var \Magento\Framework\App\Config\ScopeConfigInterface
*/
@@ -219,7 +217,6 @@ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel
* @param \Magento\Framework\Model\Context $context
* @param \Magento\Framework\Registry $registry
* @param \Magento\Framework\Api\MetadataServiceInterface $metadataService
- * @param \Magento\Customer\Helper\Data $customerData
* @param \Magento\Framework\StoreManagerInterface $storeManager
* @param \Magento\Eav\Model\Config $config
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
@@ -241,7 +238,6 @@ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel
\Magento\Framework\Model\Context $context,
\Magento\Framework\Registry $registry,
\Magento\Framework\Api\MetadataServiceInterface $metadataService,
- \Magento\Customer\Helper\Data $customerData,
\Magento\Framework\StoreManagerInterface $storeManager,
\Magento\Eav\Model\Config $config,
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
@@ -259,7 +255,6 @@ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel
\Magento\Framework\Data\Collection\Db $resourceCollection = null,
array $data = array()
) {
- $this->_customerData = $customerData;
$this->_scopeConfig = $scopeConfig;
$this->_storeManager = $storeManager;
$this->_config = $config;
@@ -973,7 +968,6 @@ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel
* Retrieve shared store ids
*
* @return array
- * @deprecated Use \Magento\Customer\Helper\Data::getSharedStoreIds
*/
public function getSharedStoreIds()
{
@@ -1328,7 +1322,7 @@ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel
return true;
}
- $expirationPeriod = $this->_customerData->getResetPasswordLinkExpirationPeriod();
+ $expirationPeriod = $this->getResetPasswordLinkExpirationPeriod();
$currentTimestamp = $this->dateTime->toTimestamp($this->dateTime->now());
$tokenTimestamp = $this->dateTime->toTimestamp($linkTokenCreatedAt);
@@ -1344,6 +1338,19 @@ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel
return false;
}
+ /**
+ * Retrieve customer reset password link expiration period in days
+ *
+ * @return int
+ */
+ public function getResetPasswordLinkExpirationPeriod()
+ {
+ return (int)$this->_scopeConfig->getValue(
+ self::XML_PATH_CUSTOMER_RESET_PASSWORD_LINK_EXPIRATION_PERIOD,
+ \Magento\Framework\App\ScopeInterface::SCOPE_DEFAULT
+ );
+ }
+
/**
* @return Address
*/
diff --git a/app/code/Magento/Customer/Model/Metadata/ElementFactory.php b/app/code/Magento/Customer/Model/Metadata/ElementFactory.php
index c7da03b3bce40dcb5cc8e53605cedcd5336329c1..f64cfc5d8c1ba3a48ed05ef70c1f43a9903f741b 100644
--- a/app/code/Magento/Customer/Model/Metadata/ElementFactory.php
+++ b/app/code/Magento/Customer/Model/Metadata/ElementFactory.php
@@ -42,7 +42,7 @@ class ElementFactory
// available only for multiply attributes
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -52,10 +52,10 @@ class ElementFactory
protected $_string;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Stdlib\String $string
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, \Magento\Framework\Stdlib\String $string)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, \Magento\Framework\Stdlib\String $string)
{
$this->_objectManager = $objectManager;
$this->_string = $string;
diff --git a/app/code/Magento/Customer/Model/Metadata/FormFactory.php b/app/code/Magento/Customer/Model/Metadata/FormFactory.php
index 11696c0bd553cc68a8769e8f65f5f873d7af84dd..1914984c1a31b159b4a6154a9539f1a731d8e80a 100644
--- a/app/code/Magento/Customer/Model/Metadata/FormFactory.php
+++ b/app/code/Magento/Customer/Model/Metadata/FormFactory.php
@@ -28,14 +28,14 @@ namespace Magento\Customer\Model\Metadata;
class FormFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Customer/Model/Observer.php b/app/code/Magento/Customer/Model/Observer.php
index a2e721f5212354f7d9fc98f0ecf46849e3a255ae..c610a760a8453fb63f4d69b52485e31845f3bf62 100644
--- a/app/code/Magento/Customer/Model/Observer.php
+++ b/app/code/Magento/Customer/Model/Observer.php
@@ -55,21 +55,21 @@ class Observer
/**
* Customer data
*
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Vat
*/
- protected $_customerData;
+ protected $_customerVat;
/**
- * @param \Magento\Customer\Helper\Data $customerData
+ * @param \Magento\Customer\Model\Vat $customerVat
* @param \Magento\Customer\Helper\Address $customerAddress
* @param \Magento\Framework\Registry $coreRegistry
*/
public function __construct(
- \Magento\Customer\Helper\Data $customerData,
+ \Magento\Customer\Model\Vat $customerVat,
\Magento\Customer\Helper\Address $customerAddress,
\Magento\Framework\Registry $coreRegistry
) {
- $this->_customerData = $customerData;
+ $this->_customerVat = $customerVat;
$this->_customerAddress = $customerAddress;
$this->_coreRegistry = $coreRegistry;
}
@@ -180,26 +180,23 @@ class Observer
try {
$this->_coreRegistry->register(self::VIV_PROCESSED_FLAG, true);
- /** @var $customerHelper \Magento\Customer\Helper\Data */
- $customerHelper = $this->_customerData;
-
- if ($customerAddress->getVatId() == '' || !$this->_customerData->isCountryInEU(
+ if ($customerAddress->getVatId() == '' || !$this->_customerVat->isCountryInEU(
$customerAddress->getCountry()
)
) {
- $defaultGroupId = $customerHelper->getDefaultCustomerGroupId($customer->getStore());
+ $defaultGroupId = $this->_customerVat->getDefaultCustomerGroupId($customer->getStore());
if (!$customer->getDisableAutoGroupChange() && $customer->getGroupId() != $defaultGroupId) {
$customer->setGroupId($defaultGroupId);
$customer->save();
}
} else {
- $result = $customerHelper->checkVatNumber(
+ $result = $this->_customerVat->checkVatNumber(
$customerAddress->getCountryId(),
$customerAddress->getVatId()
);
- $newGroupId = $customerHelper->getCustomerGroupIdBasedOnVatNumber(
+ $newGroupId = $this->_customerVat->getCustomerGroupIdBasedOnVatNumber(
$customerAddress->getCountryId(),
$result,
$customer->getStore()
diff --git a/app/code/Magento/Customer/Model/Options.php b/app/code/Magento/Customer/Model/Options.php
new file mode 100644
index 0000000000000000000000000000000000000000..db0f0ba564a841dddc5b83367e97d97627489a2b
--- /dev/null
+++ b/app/code/Magento/Customer/Model/Options.php
@@ -0,0 +1,97 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Customer\Model;
+
+use Magento\Customer\Helper\Address as AddressHelper;
+use Magento\Framework\Escaper;
+
+class Options
+{
+ /**
+ * Customer address
+ *
+ * @var AddressHelper
+ */
+ protected $addressHelper;
+
+ /**
+ * @var Escaper
+ */
+ protected $escaper;
+
+ /**
+ * @param AddressHelper $addressHelper
+ * @param Escaper $escaper
+ */
+ public function __construct(
+ AddressHelper $addressHelper,
+ Escaper $escaper
+ ) {
+ $this->addressHelper = $addressHelper;
+ $this->escaper = $escaper;
+ }
+
+ /**
+ * Retrieve name prefix dropdown options
+ *
+ * @param null $store
+ * @return array|bool
+ */
+ public function getNamePrefixOptions($store = null)
+ {
+ return $this->_prepareNamePrefixSuffixOptions($this->addressHelper->getConfig('prefix_options', $store));
+ }
+
+ /**
+ * Retrieve name suffix dropdown options
+ *
+ * @param null $store
+ * @return array|bool
+ */
+ public function getNameSuffixOptions($store = null)
+ {
+ return $this->_prepareNamePrefixSuffixOptions($this->addressHelper->getConfig('suffix_options', $store));
+ }
+
+ /**
+ * Unserialize and clear name prefix or suffix options
+ *
+ * @param string $options
+ * @return array|bool
+ */
+ protected function _prepareNamePrefixSuffixOptions($options)
+ {
+ $options = trim($options);
+ if (empty($options)) {
+ return false;
+ }
+ $result = array();
+ $options = explode(';', $options);
+ foreach ($options as $value) {
+ $value = $this->escaper->escapeHtml(trim($value));
+ $result[$value] = $value;
+ }
+ return $result;
+ }
+}
diff --git a/app/code/Magento/Customer/Model/Registration.php b/app/code/Magento/Customer/Model/Registration.php
new file mode 100644
index 0000000000000000000000000000000000000000..f38d74af58bf572c10259b4a216522a80a7ddd91
--- /dev/null
+++ b/app/code/Magento/Customer/Model/Registration.php
@@ -0,0 +1,38 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Customer\Model;
+
+
+class Registration
+{
+ /**
+ * Check whether customers registration is allowed
+ *
+ * @return bool
+ */
+ public function isAllowed()
+ {
+ return true;
+ }
+}
diff --git a/app/code/Magento/Customer/Model/Resource/Group.php b/app/code/Magento/Customer/Model/Resource/Group.php
index 5ab5053280709ba28ef927088d68aaf729742eb7..f1b7e28efc88643f6db4c006008a62e33aea091d 100644
--- a/app/code/Magento/Customer/Model/Resource/Group.php
+++ b/app/code/Magento/Customer/Model/Resource/Group.php
@@ -31,11 +31,11 @@ namespace Magento\Customer\Model\Resource;
class Group extends \Magento\Framework\Model\Resource\Db\AbstractDb
{
/**
- * Customer data
+ * Customer VAT
*
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Vat
*/
- protected $_customerData = null;
+ protected $_customerVat;
/**
* @var \Magento\Customer\Model\Resource\Customer\CollectionFactory
@@ -44,15 +44,15 @@ class Group extends \Magento\Framework\Model\Resource\Db\AbstractDb
/**
* @param \Magento\Framework\App\Resource $resource
- * @param \Magento\Customer\Helper\Data $customerData
- * @param \Magento\Customer\Model\Resource\Customer\CollectionFactory $customersFactory
+ * @param \Magento\Customer\Model\Vat $customerVat
+ * @param Customer\CollectionFactory $customersFactory
*/
public function __construct(
\Magento\Framework\App\Resource $resource,
- \Magento\Customer\Helper\Data $customerData,
+ \Magento\Customer\Model\Vat $customerVat,
\Magento\Customer\Model\Resource\Customer\CollectionFactory $customersFactory
) {
- $this->_customerData = $customerData;
+ $this->_customerVat = $customerVat;
$this->_customersFactory = $customersFactory;
parent::__construct($resource);
}
@@ -109,7 +109,7 @@ class Group extends \Magento\Framework\Model\Resource\Db\AbstractDb
foreach ($customerCollection as $customer) {
/** @var $customer \Magento\Customer\Model\Customer */
$customer->load($customer->getId());
- $defaultGroupId = $this->_customerData->getDefaultCustomerGroupId($customer->getStoreId());
+ $defaultGroupId = $this->_customerVat->getDefaultCustomerGroupId($customer->getStoreId());
$customer->setGroupId($defaultGroupId);
$customer->save();
}
diff --git a/app/code/Magento/Customer/Model/Session.php b/app/code/Magento/Customer/Model/Session.php
index 6987d20357855b2315a7b71fed395aa1d4c75ab7..4264995350cddec5f32cb61904ac5ee6b3d18dba 100644
--- a/app/code/Magento/Customer/Model/Session.php
+++ b/app/code/Magento/Customer/Model/Session.php
@@ -24,12 +24,14 @@
namespace Magento\Customer\Model;
use Magento\Customer\Model\Config\Share;
+use Magento\Customer\Model\Context;
use Magento\Customer\Model\Resource\Customer as ResourceCustomer;
use Magento\Customer\Service\V1\CustomerAccountServiceInterface;
use Magento\Customer\Service\V1\Data\Customer as CustomerData;
/**
* Customer session model
+ * @method string getNoReferer()
*/
class Session extends \Magento\Framework\Session\SessionManager
{
@@ -55,11 +57,11 @@ class Session extends \Magento\Framework\Session\SessionManager
protected $_isCustomerIdChecked = null;
/**
- * Customer data
+ * Customer URL
*
- * @var \Magento\Customer\Helper\Data|null
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerData = null;
+ protected $_customerUrl;
/**
* Core url
@@ -113,11 +115,11 @@ class Session extends \Magento\Framework\Session\SessionManager
* @param \Magento\Framework\Session\SaveHandlerInterface $saveHandler
* @param \Magento\Framework\Session\ValidatorInterface $validator
* @param \Magento\Framework\Session\StorageInterface $storage
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
* @param Share $configShare
* @param \Magento\Core\Helper\Url $coreUrl
- * @param \Magento\Customer\Helper\Data $customerData
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param ResourceCustomer $customerResource
* @param CustomerFactory $customerFactory
* @param \Magento\Framework\UrlFactory $urlFactory
@@ -134,11 +136,11 @@ class Session extends \Magento\Framework\Session\SessionManager
\Magento\Framework\Session\SaveHandlerInterface $saveHandler,
\Magento\Framework\Session\ValidatorInterface $validator,
\Magento\Framework\Session\StorageInterface $storage,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory,
Config\Share $configShare,
\Magento\Core\Helper\Url $coreUrl,
- \Magento\Customer\Helper\Data $customerData,
+ \Magento\Customer\Model\Url $customerUrl,
Resource\Customer $customerResource,
CustomerFactory $customerFactory,
\Magento\Framework\UrlFactory $urlFactory,
@@ -149,7 +151,7 @@ class Session extends \Magento\Framework\Session\SessionManager
CustomerAccountServiceInterface $customerAccountService
) {
$this->_coreUrl = $coreUrl;
- $this->_customerData = $customerData;
+ $this->_customerUrl = $customerUrl;
$this->_configShare = $configShare;
$this->_customerResource = $customerResource;
$this->_customerFactory = $customerFactory;
@@ -196,7 +198,7 @@ class Session extends \Magento\Framework\Session\SessionManager
$this->setCustomerId(null);
} else {
$this->_httpContext->setValue(
- \Magento\Customer\Helper\Data::CONTEXT_GROUP,
+ Context::CONTEXT_GROUP,
$customer->getGroupId(),
\Magento\Customer\Model\Group::NOT_LOGGED_IN_ID
);
@@ -255,7 +257,7 @@ class Session extends \Magento\Framework\Session\SessionManager
{
$this->_customerModel = $customerModel;
$this->_httpContext->setValue(
- \Magento\Customer\Helper\Data::CONTEXT_GROUP,
+ Context::CONTEXT_GROUP,
$customerModel->getGroupId(),
\Magento\Customer\Model\Group::NOT_LOGGED_IN_ID
);
@@ -418,7 +420,7 @@ class Session extends \Magento\Framework\Session\SessionManager
*/
public function setCustomerDataAsLoggedIn($customer)
{
- $this->_httpContext->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, true, false);
+ $this->_httpContext->setValue(Context::CONTEXT_AUTH, true, false);
$this->setCustomerData($customer);
$customerModel = $this->_converter->createCustomerModel($customer);
@@ -457,7 +459,7 @@ class Session extends \Magento\Framework\Session\SessionManager
$this->_eventManager->dispatch('customer_logout', array('customer' => $this->getCustomer()));
$this->_logout();
}
- $this->_httpContext->unsValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH);
+ $this->_httpContext->unsValue(Context::CONTEXT_AUTH);
return $this;
}
@@ -477,7 +479,7 @@ class Session extends \Magento\Framework\Session\SessionManager
if (isset($loginUrl)) {
$action->getResponse()->setRedirect($loginUrl);
} else {
- $arguments = $this->_customerData->getLoginUrlParams();
+ $arguments = $this->_customerUrl->getLoginUrlParams();
if ($this->_session->getCookieShouldBeReceived() && $this->_createUrl()->getUseSession()) {
$arguments += array(
'_query' => array(
@@ -486,7 +488,7 @@ class Session extends \Magento\Framework\Session\SessionManager
);
}
$action->getResponse()->setRedirect(
- $this->_createUrl()->getUrl(\Magento\Customer\Helper\Data::ROUTE_ACCOUNT_LOGIN, $arguments)
+ $this->_createUrl()->getUrl(\Magento\Customer\Model\Url::ROUTE_ACCOUNT_LOGIN, $arguments)
);
}
diff --git a/app/code/Magento/Customer/Model/Url.php b/app/code/Magento/Customer/Model/Url.php
new file mode 100644
index 0000000000000000000000000000000000000000..b91f99d1f7a1b18c93fc5cdd8fb062c7756c57e7
--- /dev/null
+++ b/app/code/Magento/Customer/Model/Url.php
@@ -0,0 +1,241 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Customer\Model;
+
+use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\Framework\App\RequestInterface;
+use Magento\Framework\Url\EncoderInterface;
+use Magento\Framework\UrlInterface;
+use Magento\Store\Model\ScopeInterface;
+
+/**
+ * Customer url model
+ */
+class Url
+{
+ /**
+ * Route for customer account login page
+ */
+ const ROUTE_ACCOUNT_LOGIN = 'customer/account/login';
+
+ /**
+ * Config name for Redirect Customer to Account Dashboard after Logging in setting
+ */
+ const XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD = 'customer/startup/redirect_dashboard';
+
+ /**
+ * Query param name for last url visited
+ */
+ const REFERER_QUERY_PARAM_NAME = 'referer';
+
+ /**
+ * @var UrlInterface
+ */
+ protected $urlBuilder;
+
+ /**
+ * @var RequestInterface
+ */
+ protected $request;
+
+ /**
+ * @var ScopeConfigInterface
+ */
+ protected $scopeConfig;
+
+ /**
+ * @var Session
+ */
+ protected $customerSession;
+
+ /**
+ * @var EncoderInterface
+ */
+ protected $urlEncoder;
+
+ /**
+ * @param Session $customerSession
+ * @param ScopeConfigInterface $scopeConfig
+ * @param RequestInterface $request
+ * @param UrlInterface $urlBuilder
+ * @param EncoderInterface $urlEncoder
+ */
+ public function __construct(
+ Session $customerSession,
+ ScopeConfigInterface $scopeConfig,
+ RequestInterface $request,
+ UrlInterface $urlBuilder,
+ EncoderInterface $urlEncoder
+ ) {
+ $this->request = $request;
+ $this->urlBuilder = $urlBuilder;
+ $this->scopeConfig = $scopeConfig;
+ $this->customerSession = $customerSession;
+ $this->urlEncoder = $urlEncoder;
+ }
+
+ /**
+ * Retrieve customer login url
+ *
+ * @return string
+ */
+ public function getLoginUrl()
+ {
+ return $this->urlBuilder->getUrl(self::ROUTE_ACCOUNT_LOGIN, $this->getLoginUrlParams());
+ }
+
+ /**
+ * Retrieve parameters of customer login url
+ *
+ * @return array
+ */
+ public function getLoginUrlParams()
+ {
+ $params = array();
+ $referer = $this->request->getParam(self::REFERER_QUERY_PARAM_NAME);
+ if (!$referer
+ && !$this->scopeConfig->isSetFlag(
+ self::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD,
+ ScopeInterface::SCOPE_STORE
+ )
+ && !$this->customerSession->getNoReferer()
+ ) {
+ $referer = $this->urlBuilder->getUrl('*/*/*', array('_current' => true, '_use_rewrite' => true));
+ $referer = $this->urlEncoder->encode($referer);
+ }
+
+ if ($referer) {
+ $params = array(self::REFERER_QUERY_PARAM_NAME => $referer);
+ }
+
+ return $params;
+ }
+
+ /**
+ * Retrieve customer login POST URL
+ *
+ * @return string
+ */
+ public function getLoginPostUrl()
+ {
+ $params = array();
+ if ($this->request->getParam(self::REFERER_QUERY_PARAM_NAME)) {
+ $params = array(
+ self::REFERER_QUERY_PARAM_NAME => $this->request->getParam(self::REFERER_QUERY_PARAM_NAME)
+ );
+ }
+ return $this->urlBuilder->getUrl('customer/account/loginPost', $params);
+ }
+
+ /**
+ * Retrieve customer logout url
+ *
+ * @return string
+ */
+ public function getLogoutUrl()
+ {
+ return $this->urlBuilder->getUrl('customer/account/logout');
+ }
+
+ /**
+ * Retrieve customer dashboard url
+ *
+ * @return string
+ */
+ public function getDashboardUrl()
+ {
+ return $this->urlBuilder->getUrl('customer/account');
+ }
+
+ /**
+ * Retrieve customer account page url
+ *
+ * @return string
+ */
+ public function getAccountUrl()
+ {
+ return $this->urlBuilder->getUrl('customer/account');
+ }
+
+ /**
+ * Retrieve customer register form url
+ *
+ * @return string
+ */
+ public function getRegisterUrl()
+ {
+ return $this->urlBuilder->getUrl('customer/account/create');
+ }
+
+ /**
+ * Retrieve customer register form post url
+ *
+ * @return string
+ */
+ public function getRegisterPostUrl()
+ {
+ return $this->urlBuilder->getUrl('customer/account/createpost');
+ }
+
+ /**
+ * Retrieve customer account edit form url
+ *
+ * @return string
+ */
+ public function getEditUrl()
+ {
+ return $this->urlBuilder->getUrl('customer/account/edit');
+ }
+
+ /**
+ * Retrieve customer edit POST URL
+ *
+ * @return string
+ */
+ public function getEditPostUrl()
+ {
+ return $this->urlBuilder->getUrl('customer/account/editpost');
+ }
+
+ /**
+ * Retrieve url of forgot password page
+ *
+ * @return string
+ */
+ public function getForgotPasswordUrl()
+ {
+ return $this->urlBuilder->getUrl('customer/account/forgotpassword');
+ }
+
+ /**
+ * Retrieve confirmation URL for Email
+ *
+ * @param string $email
+ * @return string
+ */
+ public function getEmailConfirmationUrl($email = null)
+ {
+ return $this->urlBuilder->getUrl('customer/account/confirmation', array('email' => $email));
+ }
+}
diff --git a/app/code/Magento/Customer/Model/Vat.php b/app/code/Magento/Customer/Model/Vat.php
new file mode 100644
index 0000000000000000000000000000000000000000..258641a5498ec762751ddbff31f28423ebcf1395
--- /dev/null
+++ b/app/code/Magento/Customer/Model/Vat.php
@@ -0,0 +1,337 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Customer\Model;
+
+use Magento\Customer\Service\V1\CustomerGroupServiceInterface;
+use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\Framework\Logger;
+use Magento\Store\Model\ScopeInterface;
+
+/**
+ * Customer VAT model
+ */
+class Vat
+{
+ /**
+ * Config paths to VAT related customer groups
+ */
+ const XML_PATH_CUSTOMER_VIV_INTRA_UNION_GROUP = 'customer/create_account/viv_intra_union_group';
+
+ const XML_PATH_CUSTOMER_VIV_DOMESTIC_GROUP = 'customer/create_account/viv_domestic_group';
+
+ const XML_PATH_CUSTOMER_VIV_INVALID_GROUP = 'customer/create_account/viv_invalid_group';
+
+ const XML_PATH_CUSTOMER_VIV_ERROR_GROUP = 'customer/create_account/viv_error_group';
+
+ /**
+ * VAT class constants
+ */
+ const VAT_CLASS_DOMESTIC = 'domestic';
+
+ const VAT_CLASS_INTRA_UNION = 'intra_union';
+
+ const VAT_CLASS_INVALID = 'invalid';
+
+ const VAT_CLASS_ERROR = 'error';
+
+ /**
+ * WSDL of VAT validation service
+ *
+ */
+ const VAT_VALIDATION_WSDL_URL = 'http://ec.europa.eu/taxation_customs/vies/services/checkVatService?wsdl';
+
+ /**
+ * Config path to option that enables/disables automatic group assignment based on VAT
+ */
+ const XML_PATH_CUSTOMER_GROUP_AUTO_ASSIGN = 'customer/create_account/auto_group_assign';
+
+ /**
+ * Config path to UE country list
+ */
+ const XML_PATH_EU_COUNTRIES_LIST = 'general/country/eu_countries';
+
+ /**
+ * Configuration path to merchant country id
+ */
+ const XML_PATH_MERCHANT_COUNTRY_CODE = 'general/store_information/country_id';
+
+ /**
+ * Config path to merchant VAT number
+ */
+ const XML_PATH_MERCHANT_VAT_NUMBER = 'general/store_information/merchant_vat_number';
+
+ /**
+ * @var ScopeConfigInterface
+ */
+ protected $scopeConfig;
+
+ /**
+ * @var Logger
+ */
+ protected $logger;
+
+ /**
+ * @var CustomerGroupServiceInterface
+ */
+ protected $groupService;
+
+ /**
+ * @param CustomerGroupServiceInterface $groupService
+ * @param ScopeConfigInterface $scopeConfig
+ * @param Logger $logger
+ */
+ public function __construct(
+ CustomerGroupServiceInterface $groupService,
+ ScopeConfigInterface $scopeConfig,
+ Logger $logger
+ ) {
+ $this->groupService = $groupService;
+ $this->scopeConfig = $scopeConfig;
+ $this->logger = $logger;
+ }
+
+ /**
+ * Retrieve merchant country code
+ *
+ * @param \Magento\Store\Model\Store|string|int|null $store
+ * @return string
+ */
+ public function getMerchantCountryCode($store = null)
+ {
+ return (string)$this->scopeConfig->getValue(
+ self::XML_PATH_MERCHANT_COUNTRY_CODE,
+ ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * Retrieve merchant VAT number
+ *
+ * @param \Magento\Store\Model\Store|string|int|null $store
+ * @return string
+ */
+ public function getMerchantVatNumber($store = null)
+ {
+ return (string)$this->scopeConfig->getValue(
+ self::XML_PATH_MERCHANT_VAT_NUMBER,
+ ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ /**
+ * Retrieve customer group ID based on his VAT number
+ *
+ * @param string $customerCountryCode
+ * @param \Magento\Framework\Object $vatValidationResult
+ * @param \Magento\Store\Model\Store|string|int $store
+ * @return null|int
+ */
+ public function getCustomerGroupIdBasedOnVatNumber($customerCountryCode, $vatValidationResult, $store = null)
+ {
+ $groupId = null;
+
+ $isAutoGroupAssign = $this->scopeConfig->isSetFlag(
+ self::XML_PATH_CUSTOMER_GROUP_AUTO_ASSIGN,
+ ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ if (!$isAutoGroupAssign) {
+ return $groupId;
+ }
+
+ $vatClass = $this->getCustomerVatClass($customerCountryCode, $vatValidationResult, $store);
+
+ $vatClassToGroupXmlPathMap = array(
+ self::VAT_CLASS_DOMESTIC => self::XML_PATH_CUSTOMER_VIV_DOMESTIC_GROUP,
+ self::VAT_CLASS_INTRA_UNION => self::XML_PATH_CUSTOMER_VIV_INTRA_UNION_GROUP,
+ self::VAT_CLASS_INVALID => self::XML_PATH_CUSTOMER_VIV_INVALID_GROUP,
+ self::VAT_CLASS_ERROR => self::XML_PATH_CUSTOMER_VIV_ERROR_GROUP
+ );
+
+ if (isset($vatClassToGroupXmlPathMap[$vatClass])) {
+ $groupId = (int)$this->scopeConfig->getValue(
+ $vatClassToGroupXmlPathMap[$vatClass],
+ ScopeInterface::SCOPE_STORE,
+ $store
+ );
+ }
+
+ return $groupId;
+ }
+
+ /**
+ * Send request to VAT validation service and return validation result
+ *
+ * @param string $countryCode
+ * @param string $vatNumber
+ * @param string $requesterCountryCode
+ * @param string $requesterVatNumber
+ *
+ * @return \Magento\Framework\Object
+ */
+ public function checkVatNumber($countryCode, $vatNumber, $requesterCountryCode = '', $requesterVatNumber = '')
+ {
+ // Default response
+ $gatewayResponse = new \Magento\Framework\Object(
+ array('is_valid' => false, 'request_date' => '', 'request_identifier' => '', 'request_success' => false)
+ );
+
+ if (!extension_loaded('soap')) {
+ $this->logger->logException(new \Magento\Framework\Model\Exception(__('PHP SOAP extension is required.')));
+ return $gatewayResponse;
+ }
+
+ if (!$this->canCheckVatNumber($countryCode, $vatNumber, $requesterCountryCode, $requesterVatNumber)) {
+ return $gatewayResponse;
+ }
+
+ try {
+ $soapClient = $this->createVatNumberValidationSoapClient();
+
+ $requestParams = array();
+ $requestParams['countryCode'] = $countryCode;
+ $requestParams['vatNumber'] = str_replace(array(' ', '-'), array('', ''), $vatNumber);
+ $requestParams['requesterCountryCode'] = $requesterCountryCode;
+ $requestParams['requesterVatNumber'] = str_replace(array(' ', '-'), array('', ''), $requesterVatNumber);
+
+ // Send request to service
+ $result = $soapClient->checkVatApprox($requestParams);
+
+ $gatewayResponse->setIsValid((bool)$result->valid);
+ $gatewayResponse->setRequestDate((string)$result->requestDate);
+ $gatewayResponse->setRequestIdentifier((string)$result->requestIdentifier);
+ $gatewayResponse->setRequestSuccess(true);
+ } catch (\Exception $exception) {
+ $gatewayResponse->setIsValid(false);
+ $gatewayResponse->setRequestDate('');
+ $gatewayResponse->setRequestIdentifier('');
+ }
+
+ return $gatewayResponse;
+ }
+
+ /**
+ * Create SOAP client based on VAT validation service WSDL
+ *
+ * @param boolean $trace
+ * @return \SoapClient
+ */
+ protected function createVatNumberValidationSoapClient($trace = false)
+ {
+ return new \SoapClient(self::VAT_VALIDATION_WSDL_URL, array('trace' => $trace));
+ }
+
+ /**
+ * Check if parameters are valid to send to VAT validation service
+ *
+ * @param string $countryCode
+ * @param string $vatNumber
+ * @param string $requesterCountryCode
+ * @param string $requesterVatNumber
+ *
+ * @return boolean
+ *
+ * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+ */
+ public function canCheckVatNumber($countryCode, $vatNumber, $requesterCountryCode, $requesterVatNumber)
+ {
+ return !(!is_string($countryCode)
+ || !is_string($vatNumber)
+ || !is_string($requesterCountryCode)
+ || !is_string($requesterVatNumber)
+ || empty($countryCode)
+ || !$this->isCountryInEU($countryCode)
+ || empty($vatNumber)
+ || empty($requesterCountryCode) && !empty($requesterVatNumber)
+ || !empty($requesterCountryCode) && empty($requesterVatNumber)
+ || !empty($requesterCountryCode) && !$this->isCountryInEU($requesterCountryCode)
+ );
+ }
+
+ /**
+ * Get VAT class
+ *
+ * @param string $customerCountryCode
+ * @param \Magento\Framework\Object $vatValidationResult
+ * @param \Magento\Store\Model\Store|string|int|null $store
+ * @return null|string
+ */
+ public function getCustomerVatClass($customerCountryCode, $vatValidationResult, $store = null)
+ {
+ $vatClass = null;
+
+ $isVatNumberValid = $vatValidationResult->getIsValid();
+
+ if (is_string($customerCountryCode)
+ && !empty($customerCountryCode)
+ && $customerCountryCode === $this->getMerchantCountryCode($store)
+ && $isVatNumberValid
+ ) {
+ $vatClass = self::VAT_CLASS_DOMESTIC;
+ } elseif ($isVatNumberValid) {
+ $vatClass = self::VAT_CLASS_INTRA_UNION;
+ } else {
+ $vatClass = self::VAT_CLASS_INVALID;
+ }
+
+ if (!$vatValidationResult->getRequestSuccess()) {
+ $vatClass = self::VAT_CLASS_ERROR;
+ }
+
+ return $vatClass;
+ }
+
+ /**
+ * Check whether specified country is in EU countries list
+ *
+ * @param string $countryCode
+ * @param null|int $storeId
+ * @return bool
+ */
+ public function isCountryInEU($countryCode, $storeId = null)
+ {
+ $euCountries = explode(
+ ',',
+ $this->scopeConfig->getValue(
+ self::XML_PATH_EU_COUNTRIES_LIST,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $storeId
+ )
+ );
+ return in_array($countryCode, $euCountries);
+ }
+
+ /**
+ * Get default customer group id
+ *
+ * @param \Magento\Store\Model\Store|string|int $store
+ * @return int
+ */
+ public function getDefaultCustomerGroupId($store = null)
+ {
+ return $this->groupService->getDefaultGroup($store)->getId();
+ }
+}
diff --git a/app/code/Magento/Customer/composer.json b/app/code/Magento/Customer/composer.json
index 480763708111d924f27415644d1f9ed2a5a74172..3b8a13f4730743a198d2a6751bda87143f5efd45 100644
--- a/app/code/Magento/Customer/composer.json
+++ b/app/code/Magento/Customer/composer.json
@@ -3,27 +3,27 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-newsletter": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-wishlist": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-review": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-page-cache": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
- "magento/module-authorization": "0.1.0-alpha104",
- "magento/module-integration": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-newsletter": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-wishlist": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-review": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-page-cache": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
+ "magento/module-authorization": "0.1.0-alpha105",
+ "magento/module-integration": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Customer/data/customer_setup/data-install-1.6.0.0.php b/app/code/Magento/Customer/data/customer_setup/data-install-1.6.0.0.php
deleted file mode 100644
index 4e21d4d43fe24f474b3ff8459375f32781aede2e..0000000000000000000000000000000000000000
--- a/app/code/Magento/Customer/data/customer_setup/data-install-1.6.0.0.php
+++ /dev/null
@@ -1,47 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/* @var $installer \Magento\Customer\Model\Resource\Setup */
-$installer = $this;
-// insert default customer groups
-$installer->getConnection()->insertForce(
- $installer->getTable('customer_group'),
- array('customer_group_id' => 0, 'customer_group_code' => 'NOT LOGGED IN', 'tax_class_id' => 3)
-);
-$installer->getConnection()->insertForce(
- $installer->getTable('customer_group'),
- array('customer_group_id' => 1, 'customer_group_code' => 'General', 'tax_class_id' => 3)
-);
-$installer->getConnection()->insertForce(
- $installer->getTable('customer_group'),
- array('customer_group_id' => 2, 'customer_group_code' => 'Wholesale', 'tax_class_id' => 3)
-);
-$installer->getConnection()->insertForce(
- $installer->getTable('customer_group'),
- array('customer_group_id' => 3, 'customer_group_code' => 'Retailer', 'tax_class_id' => 3)
-);
-
-$installer->installEntities();
-
-$installer->installCustomerForms();
diff --git a/app/code/Magento/Customer/data/customer_setup/data-install-2.0.0.php b/app/code/Magento/Customer/data/customer_setup/data-install-2.0.0.php
new file mode 100644
index 0000000000000000000000000000000000000000..521acb236e8278984d5561e03fe5889136220927
--- /dev/null
+++ b/app/code/Magento/Customer/data/customer_setup/data-install-2.0.0.php
@@ -0,0 +1,161 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+/* @var $this \Magento\Customer\Model\Resource\Setup */
+$installer = $this;
+
+$installer->startSetup();
+
+// insert default customer groups
+$installer->getConnection()->insertForce(
+ $installer->getTable('customer_group'),
+ array('customer_group_id' => 0, 'customer_group_code' => 'NOT LOGGED IN', 'tax_class_id' => 3)
+);
+$installer->getConnection()->insertForce(
+ $installer->getTable('customer_group'),
+ array('customer_group_id' => 1, 'customer_group_code' => 'General', 'tax_class_id' => 3)
+);
+$installer->getConnection()->insertForce(
+ $installer->getTable('customer_group'),
+ array('customer_group_id' => 2, 'customer_group_code' => 'Wholesale', 'tax_class_id' => 3)
+);
+$installer->getConnection()->insertForce(
+ $installer->getTable('customer_group'),
+ array('customer_group_id' => 3, 'customer_group_code' => 'Retailer', 'tax_class_id' => 3)
+);
+
+$installer->installEntities();
+
+$installer->installCustomerForms();
+
+// Add reset password link token attribute
+$installer->addAttribute(
+ 'customer',
+ 'rp_token',
+ array('type' => 'varchar', 'input' => 'hidden', 'visible' => false, 'required' => false)
+);
+
+// Add reset password link token creation date attribute
+$installer->addAttribute(
+ 'customer',
+ 'rp_token_created_at',
+ array(
+ 'type' => 'datetime',
+ 'input' => 'date',
+ 'validate_rules' => 'a:1:{s:16:"input_validation";s:4:"date";}',
+ 'visible' => false,
+ 'required' => false
+ )
+);
+
+// Add VAT attributes to customer address
+$disableAGCAttributeCode = 'disable_auto_group_change';
+
+$installer->addAttribute(
+ 'customer',
+ $disableAGCAttributeCode,
+ array(
+ 'type' => 'static',
+ 'label' => 'Disable Automatic Group Change Based on VAT ID',
+ 'input' => 'boolean',
+ 'backend' => 'Magento\Customer\Model\Attribute\Backend\Data\Boolean',
+ 'position' => 28,
+ 'required' => false
+ )
+);
+
+$disableAGCAttribute = $installer->getEavConfig()->getAttribute('customer', $disableAGCAttributeCode);
+$disableAGCAttribute->setData('used_in_forms', array('adminhtml_customer'));
+$disableAGCAttribute->save();
+
+$attributesInfo = array(
+ 'vat_id' => array(
+ 'label' => 'VAT number',
+ 'type' => 'varchar',
+ 'input' => 'text',
+ 'position' => 140,
+ 'visible' => true,
+ 'required' => false
+ ),
+ 'vat_is_valid' => array(
+ 'label' => 'VAT number validity',
+ 'visible' => false,
+ 'required' => false,
+ 'type' => 'int'
+ ),
+ 'vat_request_id' => array(
+ 'label' => 'VAT number validation request ID',
+ 'type' => 'varchar',
+ 'visible' => false,
+ 'required' => false
+ ),
+ 'vat_request_date' => array(
+ 'label' => 'VAT number validation request date',
+ 'type' => 'varchar',
+ 'visible' => false,
+ 'required' => false
+ ),
+ 'vat_request_success' => array(
+ 'label' => 'VAT number validation request success',
+ 'visible' => false,
+ 'required' => false,
+ 'type' => 'int'
+ )
+);
+
+foreach ($attributesInfo as $attributeCode => $attributeParams) {
+ $installer->addAttribute('customer_address', $attributeCode, $attributeParams);
+}
+
+$vatIdAttribute = $installer->getEavConfig()->getAttribute('customer_address', 'vat_id');
+$vatIdAttribute->setData(
+ 'used_in_forms',
+ array('adminhtml_customer_address', 'customer_address_edit', 'customer_register_address')
+);
+$vatIdAttribute->save();
+
+$entities = $installer->getDefaultEntities();
+foreach ($entities as $entityName => $entity) {
+ $installer->addEntityType($entityName, $entity);
+}
+
+$installer->updateAttribute(
+ 'customer_address',
+ 'street',
+ 'backend_model',
+ 'Magento\Eav\Model\Entity\Attribute\Backend\DefaultBackend'
+);
+
+$installer = $this->createMigrationSetup();
+
+$installer->appendClassAliasReplace(
+ 'customer_eav_attribute',
+ 'data_model',
+ \Magento\Framework\Module\Setup\Migration::ENTITY_TYPE_MODEL,
+ \Magento\Framework\Module\Setup\Migration::FIELD_CONTENT_TYPE_PLAIN,
+ array('attribute_id')
+);
+$installer->doUpdateClassAliases();
+
+$installer->endSetup();
diff --git a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.0.0-1.6.1.0.php b/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.0.0-1.6.1.0.php
deleted file mode 100644
index 94362e8c2a680683c3ad336cbbf2490458a8e1fb..0000000000000000000000000000000000000000
--- a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.0.0-1.6.1.0.php
+++ /dev/null
@@ -1,49 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/* @var $installer \Magento\Customer\Model\Resource\Setup */
-$installer = $this;
-$installer->startSetup();
-
-// Add reset password link token attribute
-$installer->addAttribute(
- 'customer',
- 'rp_token',
- array('type' => 'varchar', 'input' => 'hidden', 'visible' => false, 'required' => false)
-);
-
-// Add reset password link token creation date attribute
-$installer->addAttribute(
- 'customer',
- 'rp_token_created_at',
- array(
- 'type' => 'datetime',
- 'input' => 'date',
- 'validate_rules' => 'a:1:{s:16:"input_validation";s:4:"date";}',
- 'visible' => false,
- 'required' => false
- )
-);
-
-$installer->endSetup();
diff --git a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.1.0-1.6.2.0.php b/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.1.0-1.6.2.0.php
deleted file mode 100644
index 9c148682dd19c3f1a63ffbad5f23a1e0799ce467..0000000000000000000000000000000000000000
--- a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.1.0-1.6.2.0.php
+++ /dev/null
@@ -1,37 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/* @var $installer \Magento\Customer\Model\Resource\Setup */
-$installer = $this;
-
-$disableAGCAttribute = $installer->getEavConfig()->getAttribute('customer', 'disable_auto_group_change');
-$disableAGCAttribute->setData('used_in_forms', array('adminhtml_customer'));
-$disableAGCAttribute->save();
-
-$vatAttribute = $installer->getEavConfig()->getAttribute('customer_address', 'vat_id');
-$vatAttribute->setData(
- 'used_in_forms',
- array('adminhtml_customer_address', 'customer_address_edit', 'customer_register_address')
-);
-$vatAttribute->save();
diff --git a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.1.0.0-1.6.1.0.1.php b/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.1.0.0-1.6.1.0.1.php
deleted file mode 100644
index 7ddb559caf3f589785cb712225012e4865cc479a..0000000000000000000000000000000000000000
--- a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.1.0.0-1.6.1.0.1.php
+++ /dev/null
@@ -1,80 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/* @var $installer \Magento\Customer\Model\Resource\Setup */
-$installer = $this;
-
-$disableAGCAttributeCode = 'disable_auto_group_change';
-
-$installer->addAttribute(
- 'customer',
- $disableAGCAttributeCode,
- array(
- 'type' => 'static',
- 'label' => 'Disable Automatic Group Change Based on VAT ID',
- 'input' => 'boolean',
- 'backend' => 'Magento\Customer\Model\Attribute\Backend\Data\Boolean',
- 'position' => 28,
- 'required' => false
- )
-);
-
-$attributesInfo = array(
- 'vat_id' => array(
- 'label' => 'VAT number',
- 'type' => 'varchar',
- 'input' => 'text',
- 'position' => 140,
- 'visible' => true,
- 'required' => false
- ),
- 'vat_is_valid' => array(
- 'label' => 'VAT number validity',
- 'visible' => false,
- 'required' => false,
- 'type' => 'int'
- ),
- 'vat_request_id' => array(
- 'label' => 'VAT number validation request ID',
- 'type' => 'varchar',
- 'visible' => false,
- 'required' => false
- ),
- 'vat_request_date' => array(
- 'label' => 'VAT number validation request date',
- 'type' => 'varchar',
- 'visible' => false,
- 'required' => false
- ),
- 'vat_request_success' => array(
- 'label' => 'VAT number validation request success',
- 'visible' => false,
- 'required' => false,
- 'type' => 'int'
- )
-);
-
-foreach ($attributesInfo as $attributeCode => $attributeParams) {
- $installer->addAttribute('customer_address', $attributeCode, $attributeParams);
-}
diff --git a/app/code/Magento/Customer/etc/di.xml b/app/code/Magento/Customer/etc/di.xml
index c9bcffc7b8967003d033a3161b9307dd6e4b81d8..0e60a7a6a15d142f4866de59b30d255c4e276fa7 100644
--- a/app/code/Magento/Customer/etc/di.xml
+++ b/app/code/Magento/Customer/etc/di.xml
@@ -69,7 +69,7 @@
<type name="Magento\Customer\Model\Session">
<arguments>
<argument name="configShare" xsi:type="object">Magento\Customer\Model\Config\Share\Proxy</argument>
- <argument name="customerData" xsi:type="object">Magento\Customer\Helper\Data\Proxy</argument>
+ <argument name="customerUrl" xsi:type="object">Magento\Customer\Model\Url\Proxy</argument>
<argument name="customerResource" xsi:type="object">Magento\Customer\Model\Resource\Customer\Proxy</argument>
<argument name="storage" xsi:type="object">Magento\Customer\Model\Session\Storage</argument>
<argument name="converter" xsi:type="object">Magento\Customer\Model\Converter\Proxy</argument>
@@ -104,12 +104,6 @@
</arguments>
</type>
<type name="Magento\Customer\Model\Customer">
- <arguments>
- <argument name="customerData" xsi:type="object">Magento\Customer\Helper\Data\Proxy</argument>
- <argument name="groupService" xsi:type="object">Magento\Customer\Service\V1\CustomerGroupServiceInterface\Proxy</argument>
- </arguments>
- </type>
- <type name="Magento\Customer\Helper\Data">
<arguments>
<argument name="groupService" xsi:type="object">Magento\Customer\Service\V1\CustomerGroupServiceInterface\Proxy</argument>
</arguments>
diff --git a/app/code/Magento/Customer/etc/module.xml b/app/code/Magento/Customer/etc/module.xml
index ae300c23a9ea969419b51cacec722d8569da4340..6c13e31866a0fee9c1ae6017a236c26eabe53c02 100644
--- a/app/code/Magento/Customer/etc/module.xml
+++ b/app/code/Magento/Customer/etc/module.xml
@@ -24,7 +24,7 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
- <module name="Magento_Customer" schema_version="1.6.2.0.5" active="true">
+ <module name="Magento_Customer" schema_version="2.0.0" active="true">
<sequence>
<module name="Magento_Eav"/>
<module name="Magento_Directory"/>
diff --git a/app/code/Magento/Customer/sql/customer_setup/install-1.6.0.0.php b/app/code/Magento/Customer/sql/customer_setup/install-2.0.0.php
similarity index 98%
rename from app/code/Magento/Customer/sql/customer_setup/install-1.6.0.0.php
rename to app/code/Magento/Customer/sql/customer_setup/install-2.0.0.php
index 5e0067035f7b314e76cf15401218f436d6206434..6ac40de0f4ecb82a6ecf9d8411ced2b94cfe1b2f 100644
--- a/app/code/Magento/Customer/sql/customer_setup/install-1.6.0.0.php
+++ b/app/code/Magento/Customer/sql/customer_setup/install-2.0.0.php
@@ -97,6 +97,12 @@ $table = $installer->getConnection()->newTable(
null,
array('unsigned' => true, 'nullable' => false, 'default' => '1'),
'Is Active'
+)->addColumn(
+ 'disable_auto_group_change',
+ \Magento\Framework\DB\Ddl\Table::TYPE_SMALLINT,
+ null,
+ array('unsigned' => true, 'nullable' => false, 'default' => '0'),
+ 'Disable automatic group change based on VAT ID'
)->addIndex(
$installer->getIdxName('customer_entity', array('store_id')),
array('store_id')
@@ -104,8 +110,13 @@ $table = $installer->getConnection()->newTable(
$installer->getIdxName('customer_entity', array('entity_type_id')),
array('entity_type_id')
)->addIndex(
- $installer->getIdxName('customer_entity', array('email', 'website_id')),
- array('email', 'website_id')
+ $installer->getIdxName(
+ 'customer_entity',
+ array('email', 'website_id'),
+ \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE
+ ),
+ array('email', 'website_id'),
+ array('type' => \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE)
)->addIndex(
$installer->getIdxName('customer_entity', array('website_id')),
array('website_id')
diff --git a/app/code/Magento/Customer/sql/customer_setup/upgrade-1.6.2.0-1.6.2.0.1.php b/app/code/Magento/Customer/sql/customer_setup/upgrade-1.6.2.0-1.6.2.0.1.php
deleted file mode 100644
index 5ad77fbde0b998f81f3c15c5b07bb3d7e00d55cd..0000000000000000000000000000000000000000
--- a/app/code/Magento/Customer/sql/customer_setup/upgrade-1.6.2.0-1.6.2.0.1.php
+++ /dev/null
@@ -1,38 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/** @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
-
-$installer->getConnection()->addColumn(
- $installer->getTable('customer_entity'),
- 'disable_auto_group_change',
- array(
- 'type' => \Magento\Framework\DB\Ddl\Table::TYPE_SMALLINT,
- 'unsigned' => true,
- 'nullable' => false,
- 'default' => '0',
- 'comment' => 'Disable automatic group change based on VAT ID'
- )
-);
diff --git a/app/code/Magento/Customer/sql/customer_setup/upgrade-1.6.2.0.4-1.6.2.0.5.php b/app/code/Magento/Customer/sql/customer_setup/upgrade-1.6.2.0.4-1.6.2.0.5.php
deleted file mode 100644
index f677719ddde5db9e266ea837d984c6031a374ce3..0000000000000000000000000000000000000000
--- a/app/code/Magento/Customer/sql/customer_setup/upgrade-1.6.2.0.4-1.6.2.0.5.php
+++ /dev/null
@@ -1,37 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/** @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
-$connection = $installer->getConnection();
-
-/**
- * Add unique index for customer_entity table
- */
-$connection->addIndex(
- $installer->getTable('customer_entity'),
- $installer->getIdxName('customer_entity', array('email', 'website_id')),
- array('email', 'website_id'),
- \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE
-);
diff --git a/app/code/Magento/Customer/view/frontend/layout/customer_account_confirmation.xml b/app/code/Magento/Customer/view/frontend/layout/customer_account_confirmation.xml
index 12e1460a659b544afcdd12585797ad635cfae25c..a574b040aab363eb992b8c6125cde07379b5b08c 100644
--- a/app/code/Magento/Customer/view/frontend/layout/customer_account_confirmation.xml
+++ b/app/code/Magento/Customer/view/frontend/layout/customer_account_confirmation.xml
@@ -29,7 +29,7 @@
</head>
<body>
<referenceContainer name="content">
- <block class="Magento\Framework\View\Element\Template" name="accountConfirmation" template="Magento_Customer::form/confirmation.phtml"/>
+ <block class="Magento\Customer\Block\Account\Forgotpassword" name="accountConfirmation" template="Magento_Customer::form/confirmation.phtml"/>
</referenceContainer>
</body>
</page>
diff --git a/app/code/Magento/Customer/view/frontend/templates/form/confirmation.phtml b/app/code/Magento/Customer/view/frontend/templates/form/confirmation.phtml
index b1e4fccaf69bc4adf114bf41936e03853060af2f..fba3b2320c43f0a39e69a50bd8f265bda3a7e208 100644
--- a/app/code/Magento/Customer/view/frontend/templates/form/confirmation.phtml
+++ b/app/code/Magento/Customer/view/frontend/templates/form/confirmation.phtml
@@ -37,7 +37,7 @@
<button type="submit" class="action send primary"><span><?php echo __('Send confirmation link') ?></span></button>
</div>
<div class="secondary">
- <a href="<?php echo $this->helper('Magento\Customer\Helper\Data')->getLoginUrl() ?>" class="action back"><span><?php echo __('Back to Login') ?></span></a>
+ <a href="<?php echo $this->getLoginUrl() ?>" class="action back"><span><?php echo __('Back to Login') ?></span></a>
</div>
</div>
</form>
diff --git a/app/code/Magento/Customer/view/frontend/templates/form/forgotpassword.phtml b/app/code/Magento/Customer/view/frontend/templates/form/forgotpassword.phtml
index d000fde0500de16ea56605458d096ff8ee96583c..a17cfaac2c5630e5df93a79d46794f890fa9c051 100644
--- a/app/code/Magento/Customer/view/frontend/templates/form/forgotpassword.phtml
+++ b/app/code/Magento/Customer/view/frontend/templates/form/forgotpassword.phtml
@@ -20,6 +20,8 @@
*
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0)
+ *
+ * @var $this \Magento\Customer\Block\Account\Forgotpassword
*/
?>
<form class="form password forget"
@@ -42,7 +44,7 @@
<button type="submit" class="action submit primary"><span><?php echo __('Submit') ?></span></button>
</div>
<div class="secondary">
- <a class="action back" href="<?php echo $this->helper('Magento\Customer\Helper\Data')->getLoginUrl() ?>"><span><?php echo __('Go back') ?></span></a>
+ <a class="action back" href="<?php echo $this->getLoginUrl() ?>"><span><?php echo __('Go back') ?></span></a>
</div>
</div>
</form>
diff --git a/app/code/Magento/Customer/view/frontend/templates/newcustomer.phtml b/app/code/Magento/Customer/view/frontend/templates/newcustomer.phtml
index e43da44ee92fc9e10d497822247547f540edfb88..170d82046e0a93cb05150b9c4d68354598d862d2 100644
--- a/app/code/Magento/Customer/view/frontend/templates/newcustomer.phtml
+++ b/app/code/Magento/Customer/view/frontend/templates/newcustomer.phtml
@@ -26,10 +26,10 @@
/**
* New Customer block template
*
- * @see \Magento\Customer\Block\Form\Login
+ * @var $this \Magento\Customer\Block\Form\Login
*/
?>
-<?php if ($this->helper('Magento\Customer\Helper\Data')->isRegistrationAllowed()): ?>
+<?php if ($this->getRegistration()->isAllowed()): ?>
<div class="block new customer">
<div class="title"><strong><?php echo __('New Customers') ?></strong></div>
<div class="content">
diff --git a/app/code/Magento/CustomerImportExport/composer.json b/app/code/Magento/CustomerImportExport/composer.json
index b107d8d9b56a9ab27aee00086a2dcd4d10da21d0..e88f1daf67a929a2bcf9df44fb890bf2cf2b63bb 100644
--- a/app/code/Magento/CustomerImportExport/composer.json
+++ b/app/code/Magento/CustomerImportExport/composer.json
@@ -3,17 +3,17 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-import-export": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-import-export": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/CustomerImportExport/etc/module.xml b/app/code/Magento/CustomerImportExport/etc/module.xml
index ad900498b030fd3da4d1dc5937549e99e49cdc5e..43648bcd1382f486c6a44fe8e339dc95b91aa3c3 100644
--- a/app/code/Magento/CustomerImportExport/etc/module.xml
+++ b/app/code/Magento/CustomerImportExport/etc/module.xml
@@ -24,7 +24,7 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
- <module name="Magento_CustomerImportExport" schema_version="1.0.0.0" active="true">
+ <module name="Magento_CustomerImportExport" schema_version="2.0.0" active="true">
<depends>
<module name="Magento_Backend"/>
<module name="Magento_Core"/>
diff --git a/app/code/Magento/DesignEditor/Model/AreaEmulator.php b/app/code/Magento/DesignEditor/Model/AreaEmulator.php
index 72debf661457b7dfe6a378c22ded94d8ad6a7377..877603acbdc951efbc47563000a83503608a4ace 100644
--- a/app/code/Magento/DesignEditor/Model/AreaEmulator.php
+++ b/app/code/Magento/DesignEditor/Model/AreaEmulator.php
@@ -26,14 +26,14 @@ namespace Magento\DesignEditor\Model;
class AreaEmulator
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/DesignEditor/Model/Editor/Tools/Controls/Factory.php b/app/code/Magento/DesignEditor/Model/Editor/Tools/Controls/Factory.php
index 02cd4d0424d49dd612435178697bb25a5c6861de..699b20ab169b91a067fd24d897fac9f854c7c666 100644
--- a/app/code/Magento/DesignEditor/Model/Editor/Tools/Controls/Factory.php
+++ b/app/code/Magento/DesignEditor/Model/Editor/Tools/Controls/Factory.php
@@ -50,7 +50,7 @@ class Factory
);
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -70,13 +70,13 @@ class Factory
protected $filesystem;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\View\Asset\Repository $assetRepo
* @param \Magento\Framework\Config\FileIteratorFactory $fileIteratorFactory
* @param \Magento\Framework\Filesystem $filesystem
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\View\Asset\Repository $assetRepo,
\Magento\Framework\Config\FileIteratorFactory $fileIteratorFactory,
\Magento\Framework\Filesystem $filesystem
diff --git a/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Form/Element/Factory.php b/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Form/Element/Factory.php
index f97260ae0a4b4f747d4aa97b46bee4dbd28b0019..d626738577912f5167692ffb87d2aa5f2254bf0c 100644
--- a/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Form/Element/Factory.php
+++ b/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Form/Element/Factory.php
@@ -23,19 +23,19 @@
*/
namespace Magento\DesignEditor\Model\Editor\Tools\QuickStyles\Form\Element;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Renderer/Factory.php b/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Renderer/Factory.php
index a35a6e8712da469266517626fc3f23120e40c769..9878dbdb94333cf6e416a8912666c7e3ecc33e6f 100644
--- a/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Renderer/Factory.php
+++ b/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Renderer/Factory.php
@@ -36,7 +36,7 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -50,9 +50,9 @@ class Factory
);
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/DesignEditor/Model/Observer.php b/app/code/Magento/DesignEditor/Model/Observer.php
index a2d8a4ca74c4681afdc8e9876eb5efcda3b0b0ae..36c1adc4625021d578fe35afe69c7a21a01118c2 100644
--- a/app/code/Magento/DesignEditor/Model/Observer.php
+++ b/app/code/Magento/DesignEditor/Model/Observer.php
@@ -31,7 +31,7 @@ use Magento\Framework\Event\Observer as EventObserver;
class Observer
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -46,12 +46,12 @@ class Observer
protected $registry;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\DesignEditor\Helper\Data $helper
* @param \Magento\Framework\Registry $registry
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\DesignEditor\Helper\Data $helper,
\Magento\Framework\Registry $registry
) {
diff --git a/app/code/Magento/DesignEditor/Model/State.php b/app/code/Magento/DesignEditor/Model/State.php
index 0f215f5f5c674fc65a72ba2cc6cc4f570a427c16..5b3762b84b6114f8ca0c7e65e5ea49b66210b18a 100644
--- a/app/code/Magento/DesignEditor/Model/State.php
+++ b/app/code/Magento/DesignEditor/Model/State.php
@@ -75,7 +75,7 @@ class State
protected $_dataHelper;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -97,7 +97,7 @@ class State
* @param Url\Factory $urlModelFactory
* @param \Magento\Framework\App\Cache\StateInterface $cacheState
* @param \Magento\DesignEditor\Helper\Data $dataHelper
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\App\Config\ScopeConfigInterface $configuration
* @param Theme\Context $themeContext
* @param \Magento\Framework\App\Config\MutableScopeConfigInterface $mutableConfig
@@ -108,7 +108,7 @@ class State
\Magento\DesignEditor\Model\Url\Factory $urlModelFactory,
\Magento\Framework\App\Cache\StateInterface $cacheState,
\Magento\DesignEditor\Helper\Data $dataHelper,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\App\Config\ScopeConfigInterface $configuration,
\Magento\DesignEditor\Model\Theme\Context $themeContext,
\Magento\Framework\App\Config\MutableScopeConfigInterface $mutableConfig
diff --git a/app/code/Magento/DesignEditor/Model/Translate/Inline.php b/app/code/Magento/DesignEditor/Model/Translate/Inline.php
index c2ba1b3095982eb2b5fbe5487e8975e0df481707..8a8ca2f64866dbab569117db9e17ab217fdaeec9 100644
--- a/app/code/Magento/DesignEditor/Model/Translate/Inline.php
+++ b/app/code/Magento/DesignEditor/Model/Translate/Inline.php
@@ -76,7 +76,7 @@ class Inline implements \Magento\Framework\Translate\InlineInterface
protected $_isScriptInserted = false;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -98,7 +98,7 @@ class Inline implements \Magento\Framework\Translate\InlineInterface
* @param \Magento\Framework\Translate\Inline\ParserFactory $parserFactory
* @param \Magento\DesignEditor\Helper\Data $helper
* @param \Magento\Framework\UrlInterface $url
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
public function __construct(
\Magento\Framework\View\DesignInterface $design,
@@ -106,7 +106,7 @@ class Inline implements \Magento\Framework\Translate\InlineInterface
\Magento\Framework\Translate\Inline\ParserFactory $parserFactory,
\Magento\DesignEditor\Helper\Data $helper,
\Magento\Framework\UrlInterface $url,
- \Magento\Framework\ObjectManager $objectManager
+ \Magento\Framework\ObjectManagerInterface $objectManager
) {
$this->_design = $design;
$this->_scopeResolver = $scopeResolver;
diff --git a/app/code/Magento/DesignEditor/Model/Url/Factory.php b/app/code/Magento/DesignEditor/Model/Url/Factory.php
index 4b6c10ac4c8cbc70b6396abe3e3af1497893a4cb..5735b898bdefdead05bc67f2076eb9050e6c4db6 100644
--- a/app/code/Magento/DesignEditor/Model/Url/Factory.php
+++ b/app/code/Magento/DesignEditor/Model/Url/Factory.php
@@ -31,14 +31,14 @@ class Factory
const CLASS_NAME = 'Magento\Framework\UrlInterface';
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/DesignEditor/composer.json b/app/code/Magento/DesignEditor/composer.json
index 6283b4dc180f91932a10ba17f0381072d6b25533..e3b4a9fc95070777d118466ed7f3b77e2d23eb9e 100644
--- a/app/code/Magento/DesignEditor/composer.json
+++ b/app/code/Magento/DesignEditor/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Dhl/Model/Carrier.php b/app/code/Magento/Dhl/Model/Carrier.php
index 74e13e17db3c4d3bde24fa292f29885f7b804f28..42a67b877fc3ff9d69aba2f2cd4d30ab7de9b050 100644
--- a/app/code/Magento/Dhl/Model/Carrier.php
+++ b/app/code/Magento/Dhl/Model/Carrier.php
@@ -200,11 +200,6 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin
*/
protected $_httpClientFactory;
- /**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
- */
- protected $stockItemService;
-
/**
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
* @param \Magento\Sales\Model\Quote\Address\RateResult\ErrorFactory $rateErrorFactory
@@ -228,7 +223,7 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin
* @param \Magento\Framework\Filesystem $filesystem
* @param \Magento\Framework\Stdlib\DateTime $dateTime
* @param \Magento\Framework\HTTP\ZendClientFactory $httpClientFactory
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param array $data
*/
public function __construct(
@@ -245,7 +240,7 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin
\Magento\Directory\Model\CountryFactory $countryFactory,
\Magento\Directory\Model\CurrencyFactory $currencyFactory,
\Magento\Directory\Helper\Data $directoryData,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
\Magento\Shipping\Helper\Carrier $carrierHelper,
\Magento\Framework\Stdlib\DateTime\DateTime $coreDate,
\Magento\Framework\Module\Dir\Reader $configReader,
@@ -266,7 +261,6 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin
$this->mathDivision = $mathDivision;
$this->_dateTime = $dateTime;
$this->_httpClientFactory = $httpClientFactory;
- $this->stockItemService = $stockItemService;
parent::__construct(
$scopeConfig,
$rateErrorFactory,
@@ -281,7 +275,7 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin
$countryFactory,
$currencyFactory,
$directoryData,
- $stockItemService,
+ $stockRegistry,
$data
);
if ($this->getConfigData('content_type') == self::DHL_CONTENT_TYPE_DOC) {
@@ -711,13 +705,13 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin
$itemWeight = $item->getWeight();
if ($item->getIsQtyDecimal() && $item->getProductType() != Type::TYPE_BUNDLE) {
$productId = $item->getProduct()->getId();
- $isDecimalDivided = $this->stockItemService->getStockItem($productId)
- ->getIsDecimalDivided();
+ $stockItemDo = $this->stockRegistry->getStockItem($productId, $item->getStore()->getWebsiteId());
+ $isDecimalDivided = $stockItemDo->getIsDecimalDivided();
if ($isDecimalDivided) {
- if ($this->stockItemService->getEnableQtyIncrements($productId)
- && $this->stockItemService->getQtyIncrements($productId)
+ if ($stockItemDo->getEnableQtyIncrements()
+ && $stockItemDo->getQtyIncrements()
) {
- $itemWeight = $itemWeight * $this->stockItemService->getQtyIncrements($productId);
+ $itemWeight = $itemWeight * $stockItemDo->getQtyIncrements();
$qty = round($item->getWeight() / $itemWeight * $qty);
$changeQty = false;
} else {
diff --git a/app/code/Magento/Dhl/composer.json b/app/code/Magento/Dhl/composer.json
index 61bec06052b839b57f8789e3b34d88f1cf24cc38..b130472f5ede5f3830368bbad9700604126b51d7 100644
--- a/app/code/Magento/Dhl/composer.json
+++ b/app/code/Magento/Dhl/composer.json
@@ -3,21 +3,21 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-shipping": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-shipping": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"lib-libxml": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Directory/Model/CountryFactory.php b/app/code/Magento/Directory/Model/CountryFactory.php
index cb90f9ad3de65cca67ba97a08339ccb4557d657b..1d71ca13d6fe9a13eae6728d31b44f13c49b1a8f 100644
--- a/app/code/Magento/Directory/Model/CountryFactory.php
+++ b/app/code/Magento/Directory/Model/CountryFactory.php
@@ -32,14 +32,14 @@ namespace Magento\Directory\Model;
class CountryFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Directory/Model/Currency/Import/Factory.php b/app/code/Magento/Directory/Model/Currency/Import/Factory.php
index 5af06387b3d4fe39688b22908d448bc366ab28f3..3c1b0d23b46554a34abf08758a3f1a72d5e1a453 100644
--- a/app/code/Magento/Directory/Model/Currency/Import/Factory.php
+++ b/app/code/Magento/Directory/Model/Currency/Import/Factory.php
@@ -26,7 +26,7 @@ namespace Magento\Directory\Model\Currency\Import;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -36,11 +36,11 @@ class Factory
protected $_serviceConfig;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Directory\Model\Currency\Import\Config $serviceConfig
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Directory\Model\Currency\Import\Config $serviceConfig
) {
$this->_objectManager = $objectManager;
diff --git a/app/code/Magento/Directory/Model/RegionFactory.php b/app/code/Magento/Directory/Model/RegionFactory.php
index 1308bf370e816b495987a659b2020a252b3ee9f5..84d42dbc66e680f72675c46da424c1be4c862b53 100644
--- a/app/code/Magento/Directory/Model/RegionFactory.php
+++ b/app/code/Magento/Directory/Model/RegionFactory.php
@@ -32,14 +32,14 @@ namespace Magento\Directory\Model;
class RegionFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Directory/composer.json b/app/code/Magento/Directory/composer.json
index 33cb21f8470e003630e2cc90a0d9f186e9cbac79..63d619268c4629e255b74a0acdef182b18cf4d21 100644
--- a/app/code/Magento/Directory/composer.json
+++ b/app/code/Magento/Directory/composer.json
@@ -3,15 +3,15 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"lib-libxml": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php b/app/code/Magento/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php
index 12a54705574945c7cc640d97c986d7f37978bee0..7c382226c69a4ee2d3319896e5fbbfef3e095d50 100644
--- a/app/code/Magento/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php
+++ b/app/code/Magento/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php
@@ -47,7 +47,8 @@ class Name extends \Magento\Sales\Block\Adminhtml\Items\Column\Name
/**
* @param \Magento\Backend\Block\Template\Context $context
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\Framework\Registry $registry
* @param \Magento\Catalog\Model\Product\OptionFactory $optionFactory
* @param \Magento\Downloadable\Model\Link\PurchasedFactory $purchasedFactory
@@ -56,7 +57,8 @@ class Name extends \Magento\Sales\Block\Adminhtml\Items\Column\Name
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\Framework\Registry $registry,
\Magento\Catalog\Model\Product\OptionFactory $optionFactory,
\Magento\Downloadable\Model\Link\PurchasedFactory $purchasedFactory,
@@ -65,7 +67,7 @@ class Name extends \Magento\Sales\Block\Adminhtml\Items\Column\Name
) {
$this->_purchasedFactory = $purchasedFactory;
$this->_itemsFactory = $itemsFactory;
- parent::__construct($context, $stockItemService, $registry, $optionFactory, $data);
+ parent::__construct($context, $stockRegistry, $stockConfiguration, $registry, $optionFactory, $data);
}
/**
diff --git a/app/code/Magento/Downloadable/Block/Checkout/Cart/Item/Renderer.php b/app/code/Magento/Downloadable/Block/Checkout/Cart/Item/Renderer.php
index 3c916e095d9c0c13a50f876c4eee712eb9eb2b2d..56cc942f32d8ab2fd06899a6d34bdabd5a5a73cd 100644
--- a/app/code/Magento/Downloadable/Block/Checkout/Cart/Item/Renderer.php
+++ b/app/code/Magento/Downloadable/Block/Checkout/Cart/Item/Renderer.php
@@ -38,7 +38,7 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer
*
* @var \Magento\Downloadable\Helper\Catalog\Product\Configuration
*/
- protected $_downloadProdConfig = null;
+ protected $_downloadableProductConfiguration = null;
/**
* @param \Magento\Framework\View\Element\Template\Context $context
@@ -48,7 +48,8 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer
* @param \Magento\Core\Helper\Url $urlHelper
* @param \Magento\Framework\Message\ManagerInterface $messageManager
* @param PriceCurrencyInterface $priceCurrency
- * @param \Magento\Downloadable\Helper\Catalog\Product\Configuration $dwnCtlgProdConfig
+ * @param \Magento\Downloadable\Helper\Catalog\Product\Configuration $downloadableProductConfiguration
+ * @param \Magento\Framework\Module\Manager $moduleManager
* @param array $data
*/
public function __construct(
@@ -59,10 +60,11 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer
\Magento\Core\Helper\Url $urlHelper,
\Magento\Framework\Message\ManagerInterface $messageManager,
PriceCurrencyInterface $priceCurrency,
- \Magento\Downloadable\Helper\Catalog\Product\Configuration $dwnCtlgProdConfig,
+ \Magento\Framework\Module\Manager $moduleManager,
+ \Magento\Downloadable\Helper\Catalog\Product\Configuration $downloadableProductConfiguration,
array $data = array()
) {
- $this->_downloadProdConfig = $dwnCtlgProdConfig;
+ $this->_downloadableProductConfiguration = $downloadableProductConfiguration;
parent::__construct(
$context,
$productConfig,
@@ -71,6 +73,7 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer
$urlHelper,
$messageManager,
$priceCurrency,
+ $moduleManager,
$data
);
}
diff --git a/app/code/Magento/Downloadable/Controller/Customer/Products.php b/app/code/Magento/Downloadable/Controller/Customer/Products.php
index f3862e933e8a67a1ed68fd25780795be34b56fe1..c02701bf01e665be9bc2fc845fc296116a2a3e42 100644
--- a/app/code/Magento/Downloadable/Controller/Customer/Products.php
+++ b/app/code/Magento/Downloadable/Controller/Customer/Products.php
@@ -51,7 +51,7 @@ class Products extends \Magento\Framework\App\Action\Action
*/
public function dispatch(RequestInterface $request)
{
- $loginUrl = $this->_objectManager->get('Magento\Customer\Helper\Data')->getLoginUrl();
+ $loginUrl = $this->_objectManager->get('Magento\Customer\Model\Url')->getLoginUrl();
if (!$this->_customerSession->authenticate($this, $loginUrl)) {
$this->_actionFlag->set('', self::FLAG_NO_DISPATCH, true);
diff --git a/app/code/Magento/Downloadable/composer.json b/app/code/Magento/Downloadable/composer.json
index 6ece1ac9540a43525b62d841eccf8f899c42f017..504945275d677d347efd1f6491e904e8d8f17862 100644
--- a/app/code/Magento/Downloadable/composer.json
+++ b/app/code/Magento/Downloadable/composer.json
@@ -3,26 +3,26 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-wishlist": "0.1.0-alpha104",
- "magento/module-gift-message": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/module-msrp": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-wishlist": "0.1.0-alpha105",
+ "magento/module-gift-message": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/module-msrp": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Eav/Model/AttributeDataFactory.php b/app/code/Magento/Eav/Model/AttributeDataFactory.php
index 6ce61728a43a0c08e111050830386b73ec8938e2..5e26565f7f7ee78ec4151d5ca59828c610136515 100644
--- a/app/code/Magento/Eav/Model/AttributeDataFactory.php
+++ b/app/code/Magento/Eav/Model/AttributeDataFactory.php
@@ -52,7 +52,7 @@ class AttributeDataFactory
protected $_dataModels = array();
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -62,10 +62,10 @@ class AttributeDataFactory
protected $string;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Stdlib\String $string
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, \Magento\Framework\Stdlib\String $string)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, \Magento\Framework\Stdlib\String $string)
{
$this->_objectManager = $objectManager;
$this->string = $string;
diff --git a/app/code/Magento/Eav/Model/AttributeFactory.php b/app/code/Magento/Eav/Model/AttributeFactory.php
index b17a2afb48e93dfe3146e1bb1d6a9c79acd89b34..0a89ef7b51c1143b3db01d63f9631868bf42a6b7 100644
--- a/app/code/Magento/Eav/Model/AttributeFactory.php
+++ b/app/code/Magento/Eav/Model/AttributeFactory.php
@@ -31,14 +31,14 @@ namespace Magento\Eav\Model;
class AttributeFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Eav/Model/Entity/Setup/PropertyMapper/Composite.php b/app/code/Magento/Eav/Model/Entity/Setup/PropertyMapper/Composite.php
index 4b42764bdd09d0187b5890415710c01425dd1e43..cdff7179d3934b95f15c7b5a9ecfaf83e56296c8 100644
--- a/app/code/Magento/Eav/Model/Entity/Setup/PropertyMapper/Composite.php
+++ b/app/code/Magento/Eav/Model/Entity/Setup/PropertyMapper/Composite.php
@@ -26,12 +26,12 @@
namespace Magento\Eav\Model\Entity\Setup\PropertyMapper;
use Magento\Eav\Model\Entity\Setup\PropertyMapperInterface;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class Composite implements PropertyMapperInterface
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -41,10 +41,10 @@ class Composite implements PropertyMapperInterface
protected $propertyMappers;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param array $propertyMappers
*/
- public function __construct(ObjectManager $objectManager, array $propertyMappers = array())
+ public function __construct(ObjectManagerInterface $objectManager, array $propertyMappers = array())
{
$this->objectManager = $objectManager;
$this->propertyMappers = $propertyMappers;
diff --git a/app/code/Magento/Eav/Model/Form/Factory.php b/app/code/Magento/Eav/Model/Form/Factory.php
index d4b16b7be28a462e77d97833b24ffbf18903b610..4e7706fde8040a7b980f9487fe87f501ceafb093 100644
--- a/app/code/Magento/Eav/Model/Form/Factory.php
+++ b/app/code/Magento/Eav/Model/Form/Factory.php
@@ -29,14 +29,14 @@ namespace Magento\Eav\Model\Form;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Eav/composer.json b/app/code/Magento/Eav/composer.json
index 8d888f993fbf5739027dbab674c245d8713f2a29..a2de4da1c191083964f8cc4b66cfa096f884be12 100644
--- a/app/code/Magento/Eav/composer.json
+++ b/app/code/Magento/Eav/composer.json
@@ -3,15 +3,15 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Email/composer.json b/app/code/Magento/Email/composer.json
index bce2ccbaab76451bf09205ebc6830b229e2e5e2e..21e081365e6f9b455a68e18f5a94e7f0b2ee8eb0 100644
--- a/app/code/Magento/Email/composer.json
+++ b/app/code/Magento/Email/composer.json
@@ -3,15 +3,15 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Fedex/Model/Carrier.php b/app/code/Magento/Fedex/Model/Carrier.php
index 0357d50e863ef77f331e64f7a60e7cb1d00c612e..3f59bf269103f06e7544bf5c4b6994076765234e 100644
--- a/app/code/Magento/Fedex/Model/Carrier.php
+++ b/app/code/Magento/Fedex/Model/Carrier.php
@@ -149,7 +149,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C
* @param \Magento\Directory\Model\CountryFactory $countryFactory
* @param \Magento\Directory\Model\CurrencyFactory $currencyFactory
* @param \Magento\Directory\Helper\Data $directoryData
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param \Magento\Framework\Logger $logger
* @param \Magento\Framework\StoreManagerInterface $storeManager
* @param \Magento\Framework\Module\Dir\Reader $configReader
@@ -172,7 +172,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C
\Magento\Directory\Model\CountryFactory $countryFactory,
\Magento\Directory\Model\CurrencyFactory $currencyFactory,
\Magento\Directory\Helper\Data $directoryData,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
\Magento\Framework\Logger $logger,
\Magento\Framework\StoreManagerInterface $storeManager,
\Magento\Framework\Module\Dir\Reader $configReader,
@@ -195,7 +195,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C
$countryFactory,
$currencyFactory,
$directoryData,
- $stockItemService,
+ $stockRegistry,
$data
);
$wsdlBasePath = $configReader->getModuleDir('etc', 'Magento_Fedex') . '/wsdl/';
diff --git a/app/code/Magento/Fedex/composer.json b/app/code/Magento/Fedex/composer.json
index 897ffa1f176a01809899b8b02dc52d7d826f6902..f2c8e3790cbc7c712327e44b20ab7140d7b1d129 100644
--- a/app/code/Magento/Fedex/composer.json
+++ b/app/code/Magento/Fedex/composer.json
@@ -3,19 +3,19 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-shipping": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-shipping": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"lib-libxml": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/GiftMessage/Block/Message/Inline.php b/app/code/Magento/GiftMessage/Block/Message/Inline.php
index 95491d42a9c670c2e173f98e69ca434b92a967e4..25406390f37123b4f92f12296d2b7d3dca0726bd 100644
--- a/app/code/Magento/GiftMessage/Block/Message/Inline.php
+++ b/app/code/Magento/GiftMessage/Block/Message/Inline.php
@@ -23,6 +23,7 @@
*/
namespace Magento\GiftMessage\Block\Message;
+use Magento\Customer\Model\Context;
use Magento\GiftMessage\Model\Message;
/**
@@ -199,7 +200,7 @@ class Inline extends \Magento\Framework\View\Element\Template
*/
public function getDefaultFrom()
{
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return $this->_customerSession->getCustomer()->getName();
} else {
return $this->getEntity()->getBillingAddress()->getName();
diff --git a/app/code/Magento/GiftMessage/Model/TypeFactory.php b/app/code/Magento/GiftMessage/Model/TypeFactory.php
index 2f81f54191ca994812ea4d2d31414788b9c39ab7..dc5e6375a38f40cb466de7d50261259a8635da20 100644
--- a/app/code/Magento/GiftMessage/Model/TypeFactory.php
+++ b/app/code/Magento/GiftMessage/Model/TypeFactory.php
@@ -46,14 +46,14 @@ class TypeFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/GiftMessage/Service/V1/ReadService.php b/app/code/Magento/GiftMessage/Service/V1/ReadService.php
index 85d3f5158608779e95cdaa78f004e13e1e86938e..7ae50fc6991bb626118c9c5d637e78afb31afa16 100644
--- a/app/code/Magento/GiftMessage/Service/V1/ReadService.php
+++ b/app/code/Magento/GiftMessage/Service/V1/ReadService.php
@@ -77,7 +77,7 @@ class ReadService implements ReadServiceInterface
public function get($cartId)
{
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
$messageId = $quote->getGiftMessageId();
if (!$messageId) {
@@ -105,7 +105,7 @@ class ReadService implements ReadServiceInterface
*
* @var \Magento\Sales\Model\Quote $quote
*/
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
if (!$item = $quote->getItemById($itemId)) {
throw new NoSuchEntityException('There is no item with provided id in the cart');
};
diff --git a/app/code/Magento/GiftMessage/Service/V1/WriteService.php b/app/code/Magento/GiftMessage/Service/V1/WriteService.php
index 8f32a889e1b5093bdabd367a320079b50708fcb0..afba1b4685edbf993e88bda068a1dbccb9ded4ac 100644
--- a/app/code/Magento/GiftMessage/Service/V1/WriteService.php
+++ b/app/code/Magento/GiftMessage/Service/V1/WriteService.php
@@ -108,7 +108,7 @@ class WriteService implements WriteServiceInterface
*
* @var \Magento\Sales\Model\Quote $quote
*/
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
if (0 == $quote->getItemsCount()) {
throw new InputException('Gift Messages is not applicable for empty cart');
@@ -136,7 +136,7 @@ class WriteService implements WriteServiceInterface
public function setForItem($cartId, \Magento\GiftMessage\Service\V1\Data\Message $giftMessage, $itemId)
{
/** @var \Magento\Sales\Model\Quote $quote */
- $quote = $this->quoteRepository->get($cartId);
+ $quote = $this->quoteRepository->getActive($cartId);
if (!$item = $quote->getItemById($itemId)) {
throw new NoSuchEntityException("There is no product with provided itemId: $itemId in the cart");
diff --git a/app/code/Magento/GiftMessage/composer.json b/app/code/Magento/GiftMessage/composer.json
index ce43c28f5cce38ffeb6f26e952d9a59751b12439..dd5651d33fadbf481b5c9681544adb716f4546ae 100644
--- a/app/code/Magento/GiftMessage/composer.json
+++ b/app/code/Magento/GiftMessage/composer.json
@@ -3,20 +3,20 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-multishipping": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-multishipping": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/GoogleAdwords/composer.json b/app/code/Magento/GoogleAdwords/composer.json
index 4d26c26e60fb9b8876b7dbcd9f5fd63a776c4f6e..9ae7f9e7283908d5daaa19d84b06a1883f494579 100644
--- a/app/code/Magento/GoogleAdwords/composer.json
+++ b/app/code/Magento/GoogleAdwords/composer.json
@@ -3,13 +3,13 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/GoogleAnalytics/composer.json b/app/code/Magento/GoogleAnalytics/composer.json
index 8618b895fcabe05f8df645e729f33e619ada373b..17742923eff2fc89d9014ed7019144ea7fdaf9d6 100644
--- a/app/code/Magento/GoogleAnalytics/composer.json
+++ b/app/code/Magento/GoogleAnalytics/composer.json
@@ -3,13 +3,13 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/GoogleOptimizer/composer.json b/app/code/Magento/GoogleOptimizer/composer.json
index 6ac73e223879540fbd60f5a9465cfff821b142c1..b0e4dc985772ed10a6471d9598478721c3c2c0dc 100644
--- a/app/code/Magento/GoogleOptimizer/composer.json
+++ b/app/code/Magento/GoogleOptimizer/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-google-analytics": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-google-analytics": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/Quantity.php b/app/code/Magento/GoogleShopping/Model/Attribute/Quantity.php
index a79d4545e28af99b88fd104c5de3b7daff9eeb79..79d6676a3f6c6dc9605877e2eb032afe474be56a 100644
--- a/app/code/Magento/GoogleShopping/Model/Attribute/Quantity.php
+++ b/app/code/Magento/GoogleShopping/Model/Attribute/Quantity.php
@@ -40,12 +40,11 @@ class Quantity extends \Magento\GoogleShopping\Model\Attribute\DefaultAttribute
*/
public function convertAttribute($product, $entry)
{
- $quantity = $product->getStockItem()->getQty();
+ $quantity = $product->getStockItem() ? $product->getStockItem()->getQty() : false;
if ($quantity) {
$value = $quantity ? max(1, (int)$quantity) : 1;
$this->_setAttribute($entry, 'quantity', self::ATTRIBUTE_TYPE_INT, $value);
}
-
return $entry;
}
}
diff --git a/app/code/Magento/GoogleShopping/Model/AttributeFactory.php b/app/code/Magento/GoogleShopping/Model/AttributeFactory.php
index 6bf5a8df2e7187a2b74a093fce6d77d3c63586a7..a5429e1c5e66225dc7557800d5d8b51aae55b8ec 100644
--- a/app/code/Magento/GoogleShopping/Model/AttributeFactory.php
+++ b/app/code/Magento/GoogleShopping/Model/AttributeFactory.php
@@ -33,7 +33,7 @@ class AttributeFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -50,12 +50,12 @@ class AttributeFactory
protected $_string;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\GoogleShopping\Helper\Data $googleShoppingHelper
* @param \Magento\Framework\Stdlib\String $string
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\GoogleShopping\Helper\Data $googleShoppingHelper,
\Magento\Framework\Stdlib\String $string
) {
diff --git a/app/code/Magento/GoogleShopping/composer.json b/app/code/Magento/GoogleShopping/composer.json
index 8bdd03fa89963707859e2712ef7153469e0a917c..cbb3f9131a1b8af7281eb5d6ae302b852e81f52a 100644
--- a/app/code/Magento/GoogleShopping/composer.json
+++ b/app/code/Magento/GoogleShopping/composer.json
@@ -3,19 +3,19 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/GroupedImportExport/composer.json b/app/code/Magento/GroupedImportExport/composer.json
index 29a32c8532142dae524ee206c382c0ff758c77f9..c9a5c95b1b1675226b45ad81d23a095ef2af9a7d 100644
--- a/app/code/Magento/GroupedImportExport/composer.json
+++ b/app/code/Magento/GroupedImportExport/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-import-export": "0.1.0-alpha104",
- "magento/module-catalog-import-export": "0.1.0-alpha104",
- "magento/module-grouped-product": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-import-export": "0.1.0-alpha105",
+ "magento/module-catalog-import-export": "0.1.0-alpha105",
+ "magento/module-grouped-product": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/GroupedProduct/Model/Product/Type/Grouped.php b/app/code/Magento/GroupedProduct/Model/Product/Type/Grouped.php
index b9db093d79e7ee698c97e58b08f213bd2ecd023e..2f5d612c724b0aa223a94af74d63347da69182e7 100644
--- a/app/code/Magento/GroupedProduct/Model/Product/Type/Grouped.php
+++ b/app/code/Magento/GroupedProduct/Model/Product/Type/Grouped.php
@@ -389,7 +389,6 @@ class Grouped extends \Magento\Catalog\Model\Product\Type\AbstractType
if ($isStrictProcessMode) {
$_result[0]->setCartQty($qty);
- $_result[0]->addCustomOption('product_type', self::TYPE_CODE, $product);
$_result[0]->addCustomOption(
'info_buyRequest',
serialize(
diff --git a/app/code/Magento/GroupedProduct/composer.json b/app/code/Magento/GroupedProduct/composer.json
index a4ea85a32ee81fbe75377231d76fdd4d5f258258..a773bd62c05df6533f570e5b092f7cb17457846f 100644
--- a/app/code/Magento/GroupedProduct/composer.json
+++ b/app/code/Magento/GroupedProduct/composer.json
@@ -3,21 +3,21 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-msrp": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-msrp": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/ImportExport/Model/Export/Adapter/Factory.php b/app/code/Magento/ImportExport/Model/Export/Adapter/Factory.php
index d95a894999d499c04abd747988cc785e9fdedef2..18e30f0a917e5b58d43375349dcd66fe03bb6014 100644
--- a/app/code/Magento/ImportExport/Model/Export/Adapter/Factory.php
+++ b/app/code/Magento/ImportExport/Model/Export/Adapter/Factory.php
@@ -32,14 +32,14 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/ImportExport/Model/Export/Entity/Factory.php b/app/code/Magento/ImportExport/Model/Export/Entity/Factory.php
index 03f5f8f69c59b4151113282735cab4d2c25beeac..2c0700df14fd5e16ee80de1791df4a3fbfc9e8d0 100644
--- a/app/code/Magento/ImportExport/Model/Export/Entity/Factory.php
+++ b/app/code/Magento/ImportExport/Model/Export/Entity/Factory.php
@@ -32,14 +32,14 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/ImportExport/Model/Export/Factory.php b/app/code/Magento/ImportExport/Model/Export/Factory.php
index 8e02109748a29df175682dbb3bc2f991f7648191..755ab3e1656809fe9ed9900f2c971ec8d114a237 100644
--- a/app/code/Magento/ImportExport/Model/Export/Factory.php
+++ b/app/code/Magento/ImportExport/Model/Export/Factory.php
@@ -32,14 +32,14 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/ImportExport/Model/Import/Entity/Factory.php b/app/code/Magento/ImportExport/Model/Import/Entity/Factory.php
index bb5774781f70804616a9fec52aa647139da05fc2..4e105282a465faaa50aab6b815566f90f4e51330 100644
--- a/app/code/Magento/ImportExport/Model/Import/Entity/Factory.php
+++ b/app/code/Magento/ImportExport/Model/Import/Entity/Factory.php
@@ -32,14 +32,14 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/ImportExport/Model/Source/Import/Behavior/Factory.php b/app/code/Magento/ImportExport/Model/Source/Import/Behavior/Factory.php
index 8ddf4776983c81540191e7d024c4402b6dd9d684..2e0aca7f9867d87a5e2aa15fe7a7fd84b2d52cfc 100644
--- a/app/code/Magento/ImportExport/Model/Source/Import/Behavior/Factory.php
+++ b/app/code/Magento/ImportExport/Model/Source/Import/Behavior/Factory.php
@@ -32,14 +32,14 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/ImportExport/composer.json b/app/code/Magento/ImportExport/composer.json
index f4c145eb45ba74843ea486378cde40c761459efe..7c2c6046f11efb83611a734c58a2148c3b823016 100644
--- a/app/code/Magento/ImportExport/composer.json
+++ b/app/code/Magento/ImportExport/composer.json
@@ -3,17 +3,17 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-indexer": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-indexer": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"ext-ctype": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Indexer/Model/ActionFactory.php b/app/code/Magento/Indexer/Model/ActionFactory.php
index 6fa4fe5928f56c93a204f021f1e84a5e9db58087..8dc8965439ff59e43d14aef11f5b80bc17d09027 100644
--- a/app/code/Magento/Indexer/Model/ActionFactory.php
+++ b/app/code/Magento/Indexer/Model/ActionFactory.php
@@ -26,14 +26,14 @@ namespace Magento\Indexer\Model;
class ActionFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Indexer/Model/IndexerRegistry.php b/app/code/Magento/Indexer/Model/IndexerRegistry.php
index 1088c3e9c91e15ec3e3dbe7920e05f7c8578a189..1fff6733c1df339ea88fd5779e4bfecc446a130f 100644
--- a/app/code/Magento/Indexer/Model/IndexerRegistry.php
+++ b/app/code/Magento/Indexer/Model/IndexerRegistry.php
@@ -26,7 +26,7 @@ namespace Magento\Indexer\Model;
class IndexerRegistry
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -36,9 +36,9 @@ class IndexerRegistry
protected $indexers = [];
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Indexer/composer.json b/app/code/Magento/Indexer/composer.json
index 02434dabfb0aa75e286a5abfbd800f7010d2668b..ca2b38d3e9f87dbcec375bf73fe04917655f84ec 100644
--- a/app/code/Magento/Indexer/composer.json
+++ b/app/code/Magento/Indexer/composer.json
@@ -3,13 +3,13 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-page-cache": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-page-cache": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Integration/Model/Integration/Factory.php b/app/code/Magento/Integration/Model/Integration/Factory.php
index 1aa2f4ca1d6f8c392ea97df3beb3c48660d5b3ce..5f794bf22b858c9c721f2dc1b4a4bbe17c2fb41d 100644
--- a/app/code/Magento/Integration/Model/Integration/Factory.php
+++ b/app/code/Magento/Integration/Model/Integration/Factory.php
@@ -28,14 +28,14 @@ namespace Magento\Integration\Model\Integration;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Integration/Model/Oauth/Consumer/Factory.php b/app/code/Magento/Integration/Model/Oauth/Consumer/Factory.php
index 8216e5db4c57aed21cc9ae51b9274c787ec57bc9..19c572ae1ef52bca73ffd9bb701b3903cf45062c 100644
--- a/app/code/Magento/Integration/Model/Oauth/Consumer/Factory.php
+++ b/app/code/Magento/Integration/Model/Oauth/Consumer/Factory.php
@@ -28,14 +28,14 @@ namespace Magento\Integration\Model\Oauth\Consumer;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Integration/Model/Oauth/Nonce/Factory.php b/app/code/Magento/Integration/Model/Oauth/Nonce/Factory.php
index ba878ba6b6cb5d731413ac30a92d53c0736e6a78..1faf5c160bccee9b202e4b22aa6e0653e5f66054 100644
--- a/app/code/Magento/Integration/Model/Oauth/Nonce/Factory.php
+++ b/app/code/Magento/Integration/Model/Oauth/Nonce/Factory.php
@@ -9,14 +9,14 @@ namespace Magento\Integration\Model\Oauth\Nonce;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Integration/Model/Oauth/Token/Factory.php b/app/code/Magento/Integration/Model/Oauth/Token/Factory.php
index 5cffcaaf718d5b1ef641a10774080302b9983e54..7fbabfef0d4dedf4b463ed41b3e9468c06e6e1cf 100644
--- a/app/code/Magento/Integration/Model/Oauth/Token/Factory.php
+++ b/app/code/Magento/Integration/Model/Oauth/Token/Factory.php
@@ -9,14 +9,14 @@ namespace Magento\Integration\Model\Oauth\Token;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Integration/composer.json b/app/code/Magento/Integration/composer.json
index 6d086ae2da008e09640b09b98b66628d9ee2dc24..858e6a13abe7878514df54f2986176d0696ec2bd 100644
--- a/app/code/Magento/Integration/composer.json
+++ b/app/code/Magento/Integration/composer.json
@@ -3,17 +3,17 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-user": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
- "magento/module-authorization": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-user": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
+ "magento/module-authorization": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/LayeredNavigation/composer.json b/app/code/Magento/LayeredNavigation/composer.json
index b019476a30bcb5d6633cbc49ce158c8bf36be4ec..b1b76924906cb4e455597162770604fbd7f66a90 100644
--- a/app/code/Magento/LayeredNavigation/composer.json
+++ b/app/code/Magento/LayeredNavigation/composer.json
@@ -3,13 +3,13 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Log/Model/Shell/Command/Factory.php b/app/code/Magento/Log/Model/Shell/Command/Factory.php
index 6406299d67d3e192063510f9e10b4a0a83654ca6..edfd08b0b05b1eef53d60a6a48bb1c30a7680ae0 100644
--- a/app/code/Magento/Log/Model/Shell/Command/Factory.php
+++ b/app/code/Magento/Log/Model/Shell/Command/Factory.php
@@ -26,14 +26,14 @@ namespace Magento\Log\Model\Shell\Command;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Log/composer.json b/app/code/Magento/Log/composer.json
index 63212cbe67965b21e0e4ee9f05f36eb4f4d1304e..19d2506b93e5d5d71ff06be54438cb14d7419b93 100644
--- a/app/code/Magento/Log/composer.json
+++ b/app/code/Magento/Log/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Msrp/composer.json b/app/code/Magento/Msrp/composer.json
index dc8eaec8526f7f0b68901329925df638125f73cb..6513ea09b270402cd4488db63f9deff887e0e814 100644
--- a/app/code/Magento/Msrp/composer.json
+++ b/app/code/Magento/Msrp/composer.json
@@ -3,21 +3,21 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-bundle": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-configurable-product": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-downloadable": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-grouped-product": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-bundle": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-configurable-product": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-downloadable": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-grouped-product": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Multishipping/Block/Checkout/Success.php b/app/code/Magento/Multishipping/Block/Checkout/Success.php
index d60594a634990c00c1532a8621228a28e206fc06..8092fd5119b0f987c65b02249479d9cfd86da023 100644
--- a/app/code/Magento/Multishipping/Block/Checkout/Success.php
+++ b/app/code/Magento/Multishipping/Block/Checkout/Success.php
@@ -53,7 +53,6 @@ class Success extends \Magento\Multishipping\Block\Checkout\AbstractMultishippin
$ids = $this->_session->getOrderIds(true);
if ($ids && is_array($ids)) {
return $ids;
- return implode(', ', $ids);
}
return false;
}
diff --git a/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping.php b/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping.php
index f8ec20a86afc84a6cad3d511e6b03abf2686cfa6..124401d490c125aac06303e2fa340356c2194f89 100644
--- a/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping.php
+++ b/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping.php
@@ -115,6 +115,11 @@ class Multishipping extends \Magento\Framework\Object
*/
protected $priceCurrency;
+ /**
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
/**
* @param \Magento\Checkout\Model\Session $checkoutSession
* @param \Magento\Customer\Model\Session $customerSession
@@ -130,6 +135,7 @@ class Multishipping extends \Magento\Framework\Object
* @param \Magento\Multishipping\Helper\Data $helper
* @param OrderSender $orderSender
* @param PriceCurrencyInterface $priceCurrency
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param array $data
*/
public function __construct(
@@ -147,6 +153,7 @@ class Multishipping extends \Magento\Framework\Object
\Magento\Multishipping\Helper\Data $helper,
OrderSender $orderSender,
PriceCurrencyInterface $priceCurrency,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
array $data = array()
) {
$this->_eventManager = $eventManager;
@@ -163,6 +170,7 @@ class Multishipping extends \Magento\Framework\Object
$this->_customerAddressService = $customerAddressService;
$this->orderSender = $orderSender;
$this->priceCurrency = $priceCurrency;
+ $this->quoteRepository = $quoteRepository;
parent::__construct($data);
$this->_init();
}
@@ -470,7 +478,7 @@ class Multishipping extends \Magento\Framework\Object
)->importCustomerAddressData(
$address
)->collectTotals();
- $this->getQuote()->save();
+ $this->quoteRepository->save($this->getQuote());
}
return $this;
}
@@ -489,7 +497,8 @@ class Multishipping extends \Magento\Framework\Object
}
if (isset($address)) {
$this->getQuote()->getBillingAddress($addressId)->importCustomerAddressData($address)->collectTotals();
- $this->getQuote()->collectTotals()->save();
+ $this->getQuote()->collectTotals();
+ $this->quoteRepository->save($this->getQuote());
}
return $this;
}
@@ -537,7 +546,7 @@ class Multishipping extends \Magento\Framework\Object
$quote->getShippingAddress()->setCollectShippingRates(true);
$quote->setTotalsCollectedFlag(false)->collectTotals();
}
- $quote->save();
+ $this->quoteRepository->save($quote);
return $this;
}
@@ -665,7 +674,8 @@ class Multishipping extends \Magento\Framework\Object
$this->_session->setOrderIds($orderIds);
$this->_checkoutSession->setLastQuoteId($this->getQuote()->getId());
- $this->getQuote()->setIsActive(false)->save();
+ $this->getQuote()->setIsActive(false);
+ $this->quoteRepository->save($this->getQuote());
$this->_eventManager->dispatch(
'checkout_submit_all_after',
@@ -686,7 +696,8 @@ class Multishipping extends \Magento\Framework\Object
*/
public function save()
{
- $this->getQuote()->collectTotals()->save();
+ $this->getQuote()->collectTotals();
+ $this->quoteRepository->save($this->getQuote());
return $this;
}
diff --git a/app/code/Magento/Multishipping/composer.json b/app/code/Magento/Multishipping/composer.json
index 0776bfff1a27c59865147bec71a215d2c8cf7462..8a5f0a205e7d2de2864ba07d350853647b04258d 100644
--- a/app/code/Magento/Multishipping/composer.json
+++ b/app/code/Magento/Multishipping/composer.json
@@ -3,19 +3,19 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Newsletter/Controller/Subscriber.php b/app/code/Magento/Newsletter/Controller/Subscriber.php
index 9001261460777c6e0d57a9ca6a682ed1ce6bc4a0..c498bfa5b23191d46420c00fe4277f379c932417 100644
--- a/app/code/Magento/Newsletter/Controller/Subscriber.php
+++ b/app/code/Magento/Newsletter/Controller/Subscriber.php
@@ -32,7 +32,7 @@ use Magento\Framework\StoreManagerInterface;
use Magento\Customer\Model\Session;
use Magento\Customer\Service\V1\CustomerAccountServiceInterface;
use Magento\Newsletter\Model\SubscriberFactory;
-use Magento\Customer\Helper\Data as CustomerHelper;
+use Magento\Customer\Model\Url as CustomerUrl;
class Subscriber extends \Magento\Framework\App\Action\Action
{
@@ -63,9 +63,9 @@ class Subscriber extends \Magento\Framework\App\Action\Action
protected $_storeManager;
/**
- * @var CustomerHelper
+ * @var CustomerUrl
*/
- protected $_customerHelper;
+ protected $_customerUrl;
/**
* @param Context $context
@@ -73,7 +73,7 @@ class Subscriber extends \Magento\Framework\App\Action\Action
* @param CustomerAccountServiceInterface $customerService
* @param Session $customerSession
* @param StoreManagerInterface $storeManager
- * @param CustomerHelper $customerHelper
+ * @param CustomerUrl $customerUrl
*/
public function __construct(
Context $context,
@@ -81,13 +81,13 @@ class Subscriber extends \Magento\Framework\App\Action\Action
CustomerAccountServiceInterface $customerService,
Session $customerSession,
StoreManagerInterface $storeManager,
- CustomerHelper $customerHelper
+ CustomerUrl $customerUrl
) {
parent::__construct($context);
$this->_storeManager = $storeManager;
$this->_subscriberFactory = $subscriberFactory;
$this->_customerService = $customerService;
$this->_customerSession = $customerSession;
- $this->_customerHelper = $customerHelper;
+ $this->_customerUrl = $customerUrl;
}
}
diff --git a/app/code/Magento/Newsletter/Controller/Subscriber/NewAction.php b/app/code/Magento/Newsletter/Controller/Subscriber/NewAction.php
index 0c854b01609c2e49ce50c272c44091f0a00ed98c..4c8312448253434a27a59371f1085a75cf0b38a9 100644
--- a/app/code/Magento/Newsletter/Controller/Subscriber/NewAction.php
+++ b/app/code/Magento/Newsletter/Controller/Subscriber/NewAction.php
@@ -62,7 +62,7 @@ class NewAction extends \Magento\Newsletter\Controller\Subscriber
__(
'Sorry, but the administrator denied subscription for guests. '
. 'Please <a href="%1">register</a>.',
- $this->_customerHelper->getRegisterUrl()
+ $this->_customerUrl->getRegisterUrl()
)
);
}
diff --git a/app/code/Magento/Newsletter/composer.json b/app/code/Magento/Newsletter/composer.json
index 45695e6b333d01d115423546564384cc4358f58b..249bf63f2a298193afc8ccbb62ce5a15787e6a02 100644
--- a/app/code/Magento/Newsletter/composer.json
+++ b/app/code/Magento/Newsletter/composer.json
@@ -3,20 +3,20 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-widget": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/module-email": "0.1.0-alpha104",
- "magento/module-cron": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-widget": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/module-email": "0.1.0-alpha105",
+ "magento/module-cron": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/OfflinePayments/composer.json b/app/code/Magento/OfflinePayments/composer.json
index 6a2a6b3a91ccf9e1907e9832719a5a0db5913a23..c98a8de3cb53edf93360fc6b67c921a428dd6d61 100644
--- a/app/code/Magento/OfflinePayments/composer.json
+++ b/app/code/Magento/OfflinePayments/composer.json
@@ -3,12 +3,12 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/OfflineShipping/composer.json b/app/code/Magento/OfflineShipping/composer.json
index 5d34d020ddec68ed43cf53f9a031a936dc877a37..b6fb44f7923c9d7fd415e22ea8eba4ad18130402 100644
--- a/app/code/Magento/OfflineShipping/composer.json
+++ b/app/code/Magento/OfflineShipping/composer.json
@@ -3,19 +3,19 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-shipping": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-sales-rule": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-shipping": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-sales-rule": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Ogone/Controller/Api/Placeform.php b/app/code/Magento/Ogone/Controller/Api/Placeform.php
index 1bb48353e9a36a4f63355eff51df0d66c0afe5a4..4a05669318bc7ed0a344c30ff28c2615ce690ad6 100644
--- a/app/code/Magento/Ogone/Controller/Api/Placeform.php
+++ b/app/code/Magento/Ogone/Controller/Api/Placeform.php
@@ -25,9 +25,38 @@
namespace Magento\Ogone\Controller\Api;
use \Magento\Sales\Model\Order;
+use Magento\Sales\Model\Order\Email\Sender\OrderSender;
class Placeform extends \Magento\Ogone\Controller\Api
{
+ /**
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
+ /**
+ * @param \Magento\Framework\App\Action\Context $context
+ * @param \Magento\Framework\DB\TransactionFactory $transactionFactory
+ * @param \Magento\Sales\Model\OrderFactory $salesOrderFactory
+ * @param OrderSender $orderSender
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
+ */
+ public function __construct(
+ \Magento\Framework\App\Action\Context $context,
+ \Magento\Framework\DB\TransactionFactory $transactionFactory,
+ \Magento\Sales\Model\OrderFactory $salesOrderFactory,
+ OrderSender $orderSender,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository
+ ) {
+ $this->quoteRepository = $quoteRepository;
+ parent::__construct(
+ $context,
+ $transactionFactory,
+ $salesOrderFactory,
+ $orderSender
+ );
+ }
+
/**
* Load place from layout to make POST on Ogone
*
@@ -50,7 +79,8 @@ class Placeform extends \Magento\Ogone\Controller\Api
}
}
- $this->_getCheckout()->getQuote()->setIsActive(false)->save();
+ $this->_getCheckout()->getQuote()->setIsActive(false);
+ $this->quoteRepository->save($this->_getCheckout()->getQuote());
$this->_getCheckout()->setOgoneQuoteId($this->_getCheckout()->getQuoteId());
$this->_getCheckout()->setOgoneLastSuccessQuoteId($this->_getCheckout()->getLastSuccessQuoteId());
$this->_getCheckout()->clearQuote();
diff --git a/app/code/Magento/Ogone/composer.json b/app/code/Magento/Ogone/composer.json
index 300d6a60503cc3f961d4ba47904c9b41d1bd4564..70160909f56e783dfeb4e3deb045d443dffe2200 100644
--- a/app/code/Magento/Ogone/composer.json
+++ b/app/code/Magento/Ogone/composer.json
@@ -3,15 +3,15 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/PageCache/Model/App/FrontController/MessageBox.php b/app/code/Magento/PageCache/Model/App/FrontController/MessageBox.php
index b3a89552f1da2068cd150aabb10f25a2ec8c80b0..44e06fab207908c3c3d52b6a2f9755a7cc43ebf9 100644
--- a/app/code/Magento/PageCache/Model/App/FrontController/MessageBox.php
+++ b/app/code/Magento/PageCache/Model/App/FrontController/MessageBox.php
@@ -25,7 +25,7 @@ namespace Magento\PageCache\Model\App\FrontController;
use Magento\Framework\App\FrontController;
use Magento\Framework\Stdlib\Cookie\CookieMetadataFactory;
-use Magento\Framework\Stdlib\CookieManager;
+use Magento\Framework\Stdlib\CookieManagerInterface;
class MessageBox
{
@@ -42,7 +42,7 @@ class MessageBox
/**
* Cookie manager
*
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $cookieManager;
@@ -75,14 +75,14 @@ class MessageBox
protected $messageManager;
/**
- * @param CookieManager $cookieManager
+ * @param CookieManagerInterface $cookieManager
* @param CookieMetadataFactory $cookieMetadataFactory
* @param \Magento\Framework\App\Request\Http $request
* @param \Magento\PageCache\Model\Config $config
* @param \Magento\Framework\Message\ManagerInterface $messageManager
*/
public function __construct(
- CookieManager $cookieManager,
+ CookieManagerInterface $cookieManager,
CookieMetadataFactory $cookieMetadataFactory,
\Magento\Framework\App\Request\Http $request,
\Magento\PageCache\Model\Config $config,
diff --git a/app/code/Magento/PageCache/composer.json b/app/code/Magento/PageCache/composer.json
index bc79d590b4e23fba1efb6207c76b50c6796cbc07..190198eba58ae6a67d0f70a1b706aabb742cc7d6 100644
--- a/app/code/Magento/PageCache/composer.json
+++ b/app/code/Magento/PageCache/composer.json
@@ -3,13 +3,13 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/PayPalRecurringPayment/composer.json b/app/code/Magento/PayPalRecurringPayment/composer.json
index f3695b3101716d5c37cdd2bd04d646faccd47253..102fd14fa74368ac1a25b3b305c7133b739466b1 100644
--- a/app/code/Magento/PayPalRecurringPayment/composer.json
+++ b/app/code/Magento/PayPalRecurringPayment/composer.json
@@ -3,17 +3,17 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/module-paypal": "0.1.0-alpha104",
- "magento/module-recurring-payment": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/module-paypal": "0.1.0-alpha105",
+ "magento/module-recurring-payment": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Payment/Model/Cart/SalesModel/Factory.php b/app/code/Magento/Payment/Model/Cart/SalesModel/Factory.php
index efdb098eb3a6a0cf0d9f0f31e2e5058525412c70..2e7a7423e7e6f70e3b5cd4534f43c763b59d0195 100644
--- a/app/code/Magento/Payment/Model/Cart/SalesModel/Factory.php
+++ b/app/code/Magento/Payment/Model/Cart/SalesModel/Factory.php
@@ -29,14 +29,14 @@ namespace Magento\Payment\Model\Cart\SalesModel;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Payment/Model/Method/Factory.php b/app/code/Magento/Payment/Model/Method/Factory.php
index 0a0f5f98b3f819ac9d2a3ba346b2f6c6f0624918..9d10fb75d5e1c0714bdc3fa51e6c59a076c0a517 100644
--- a/app/code/Magento/Payment/Model/Method/Factory.php
+++ b/app/code/Magento/Payment/Model/Method/Factory.php
@@ -31,16 +31,16 @@ class Factory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Payment/Model/Method/Specification/Factory.php b/app/code/Magento/Payment/Model/Method/Specification/Factory.php
index 69dd79aa0a9850d090ea9b0c08147134bb53034e..a553d55f40601da98dc3c3ad5f6671d7c156e68f 100644
--- a/app/code/Magento/Payment/Model/Method/Specification/Factory.php
+++ b/app/code/Magento/Payment/Model/Method/Specification/Factory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Payment\Model\Method\Specification;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Payment\Model\Method\SpecificationInterface;
/**
@@ -34,16 +34,16 @@ class Factory
/**
* Object Manager
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
* Factory constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Payment/composer.json b/app/code/Magento/Payment/composer.json
index 8b7ad14ae655066c77d9e77c3c43a9fe3b8bbded..bc6fb1f232647c996bd74bed5874e892ab073e9f 100644
--- a/app/code/Magento/Payment/composer.json
+++ b/app/code/Magento/Payment/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-centinel": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-centinel": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Paypal/Controller/Express/AbstractExpress.php b/app/code/Magento/Paypal/Controller/Express/AbstractExpress.php
index 2a3c70303b6cc279427e035009ea80da9326445c..8fc09c1510f2d8f6acd2b775605357ea9b48a826 100644
--- a/app/code/Magento/Paypal/Controller/Express/AbstractExpress.php
+++ b/app/code/Magento/Paypal/Controller/Express/AbstractExpress.php
@@ -79,11 +79,6 @@ abstract class AbstractExpress extends AppAction implements RedirectLoginInterfa
*/
protected $_customerSession;
- /**
- * @var \Magento\Sales\Model\QuoteFactory
- */
- protected $_quoteFactory;
-
/**
* @var \Magento\Checkout\Model\Session
*/
@@ -110,40 +105,37 @@ abstract class AbstractExpress extends AppAction implements RedirectLoginInterfa
protected $_urlHelper;
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerHelper;
+ protected $_customerUrl;
/**
* @param \Magento\Framework\App\Action\Context $context
* @param \Magento\Customer\Model\Session $customerSession
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
* @param \Magento\Checkout\Model\Session $checkoutSession
* @param \Magento\Sales\Model\OrderFactory $orderFactory
* @param \Magento\Paypal\Model\Express\Checkout\Factory $checkoutFactory
* @param \Magento\Framework\Session\Generic $paypalSession
* @param \Magento\Core\Helper\Url $urlHelper
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Url $customerUrl
*/
public function __construct(
\Magento\Framework\App\Action\Context $context,
\Magento\Customer\Model\Session $customerSession,
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
\Magento\Checkout\Model\Session $checkoutSession,
\Magento\Sales\Model\OrderFactory $orderFactory,
\Magento\Paypal\Model\Express\Checkout\Factory $checkoutFactory,
\Magento\Framework\Session\Generic $paypalSession,
\Magento\Core\Helper\Url $urlHelper,
- \Magento\Customer\Helper\Data $customerHelper
+ \Magento\Customer\Model\Url $customerUrl
) {
$this->_customerSession = $customerSession;
- $this->_quoteFactory = $quoteFactory;
$this->_checkoutSession = $checkoutSession;
$this->_orderFactory = $orderFactory;
$this->_checkoutFactory = $checkoutFactory;
$this->_paypalSession = $paypalSession;
$this->_urlHelper = $urlHelper;
- $this->_customerHelper = $customerHelper;
+ $this->_customerUrl = $customerUrl;
parent::__construct($context);
$parameters = array('params' => array($this->_configMethod));
$this->_config = $this->_objectManager->create($this->_configType, $parameters);
@@ -265,7 +257,7 @@ abstract class AbstractExpress extends AppAction implements RedirectLoginInterfa
*/
public function getLoginUrl()
{
- return $this->_objectManager->get('Magento\Customer\Helper\Data')->getLoginUrl();
+ return $this->_customerUrl->getLoginUrl();
}
/**
@@ -288,7 +280,7 @@ abstract class AbstractExpress extends AppAction implements RedirectLoginInterfa
$this->_actionFlag->set('', 'no-dispatch', true);
$this->_customerSession->setBeforeAuthUrl($this->_redirect->getRefererUrl());
$this->getResponse()->setRedirect(
- $this->_urlHelper->addRequestParam($this->_customerHelper->getLoginUrl(), array('context' => 'checkout'))
+ $this->_urlHelper->addRequestParam($this->_customerUrl->getLoginUrl(), array('context' => 'checkout'))
);
}
}
diff --git a/app/code/Magento/Paypal/Controller/Express/AbstractExpress/ShippingOptionsCallback.php b/app/code/Magento/Paypal/Controller/Express/AbstractExpress/ShippingOptionsCallback.php
index 6e5801402cce1533650f50fba5ee8dc887849a6d..51c42b1d7c0630dc146b9fb8e8883936d5818042 100644
--- a/app/code/Magento/Paypal/Controller/Express/AbstractExpress/ShippingOptionsCallback.php
+++ b/app/code/Magento/Paypal/Controller/Express/AbstractExpress/ShippingOptionsCallback.php
@@ -26,6 +26,46 @@ namespace Magento\Paypal\Controller\Express\AbstractExpress;
class ShippingOptionsCallback extends \Magento\Paypal\Controller\Express\AbstractExpress
{
+ /**
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
+ /**
+ * @param \Magento\Framework\App\Action\Context $context
+ * @param \Magento\Customer\Model\Session $customerSession
+ * @param \Magento\Checkout\Model\Session $checkoutSession
+ * @param \Magento\Sales\Model\OrderFactory $orderFactory
+ * @param \Magento\Paypal\Model\Express\Checkout\Factory $checkoutFactory
+ * @param \Magento\Framework\Session\Generic $paypalSession
+ * @param \Magento\Core\Helper\Url $urlHelper
+ * @param \Magento\Customer\Model\Url $customerUrl
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
+ */
+ public function __construct(
+ \Magento\Framework\App\Action\Context $context,
+ \Magento\Customer\Model\Session $customerSession,
+ \Magento\Checkout\Model\Session $checkoutSession,
+ \Magento\Sales\Model\OrderFactory $orderFactory,
+ \Magento\Paypal\Model\Express\Checkout\Factory $checkoutFactory,
+ \Magento\Framework\Session\Generic $paypalSession,
+ \Magento\Core\Helper\Url $urlHelper,
+ \Magento\Customer\Model\Url $customerUrl,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository
+ ) {
+ $this->quoteRepository = $quoteRepository;
+ parent::__construct(
+ $context,
+ $customerSession,
+ $checkoutSession,
+ $orderFactory,
+ $checkoutFactory,
+ $paypalSession,
+ $urlHelper,
+ $customerUrl
+ );
+ }
+
/**
* Return shipping options items for shipping address from request
*
@@ -35,7 +75,7 @@ class ShippingOptionsCallback extends \Magento\Paypal\Controller\Express\Abstrac
{
try {
$quoteId = $this->getRequest()->getParam('quote_id');
- $this->_quote = $this->_quoteFactory->create()->load($quoteId);
+ $this->_quote = $this->quoteRepository->get($quoteId);
$this->_initCheckout();
$response = $this->_checkout->getShippingOptionsCallbackResponse($this->getRequest()->getParams());
$this->getResponse()->setBody($response);
diff --git a/app/code/Magento/Paypal/Helper/Checkout.php b/app/code/Magento/Paypal/Helper/Checkout.php
index 474335c2d85f7209d3fdc78b803975ed9a8e4a3b..457f3b21202795c35b88477e5fcaa00838e3504c 100644
--- a/app/code/Magento/Paypal/Helper/Checkout.php
+++ b/app/code/Magento/Paypal/Helper/Checkout.php
@@ -33,21 +33,13 @@ class Checkout
*/
protected $_session;
- /**
- * @var \Magento\Sales\Model\QuoteFactory
- */
- protected $_quoteFactory;
-
/**
* @param \Magento\Checkout\Model\Session $session
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
*/
public function __construct(
- \Magento\Checkout\Model\Session $session,
- \Magento\Sales\Model\QuoteFactory $quoteFactory
+ \Magento\Checkout\Model\Session $session
) {
$this->_session = $session;
- $this->_quoteFactory = $quoteFactory;
}
/**
diff --git a/app/code/Magento/Paypal/Helper/Shortcut/Factory.php b/app/code/Magento/Paypal/Helper/Shortcut/Factory.php
index 8aa148929f07dd40a475abe936c712b55a960499..74bf5c15939578e89fefa471614bd4010c94a64f 100644
--- a/app/code/Magento/Paypal/Helper/Shortcut/Factory.php
+++ b/app/code/Magento/Paypal/Helper/Shortcut/Factory.php
@@ -37,14 +37,14 @@ class Factory
const CHECKOUT_VALIDATOR = 'Magento\Paypal\Helper\Shortcut\CheckoutValidator';
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Paypal/Model/Api/Type/Factory.php b/app/code/Magento/Paypal/Model/Api/Type/Factory.php
index 0214c5cc72a93da70059bc27e0c286c9ee8e028a..3befc082dc720ad27016e9e7f9afa4605595ea81 100644
--- a/app/code/Magento/Paypal/Model/Api/Type/Factory.php
+++ b/app/code/Magento/Paypal/Model/Api/Type/Factory.php
@@ -32,16 +32,16 @@ class Factory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Paypal/Model/Config/Factory.php b/app/code/Magento/Paypal/Model/Config/Factory.php
index d2ff15e6913afc3f98f2bf0f134d002b16e40499..2f00a4a0b183b1163746a07ff361b1585ff0586e 100644
--- a/app/code/Magento/Paypal/Model/Config/Factory.php
+++ b/app/code/Magento/Paypal/Model/Config/Factory.php
@@ -31,16 +31,16 @@ class Factory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Paypal/Model/Express/Checkout.php b/app/code/Magento/Paypal/Model/Express/Checkout.php
index 783d18c4bed4513b011fb15638243652dfc5c929..d6c433fa5abcb1879b34cd1bb8a8603cfe671bd8 100644
--- a/app/code/Magento/Paypal/Model/Express/Checkout.php
+++ b/app/code/Magento/Paypal/Model/Express/Checkout.php
@@ -182,9 +182,9 @@ class Checkout
/**
* Customer data
*
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerData;
+ protected $_customerUrl;
/**
* @var \Magento\Framework\Logger
@@ -286,11 +286,16 @@ class Checkout
*/
protected $orderSender;
+ /**
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
/**
* Set config, session and quote instances
*
* @param \Magento\Framework\Logger $logger
- * @param \Magento\Customer\Helper\Data $customerData
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param \Magento\Tax\Helper\Data $taxData
* @param \Magento\Checkout\Helper\Data $checkoutData
* @param \Magento\Customer\Model\Session $customerSession
@@ -314,12 +319,13 @@ class Checkout
* @param \Magento\Framework\Encryption\EncryptorInterface $encryptor
* @param \Magento\Framework\Message\ManagerInterface $messageManager
* @param OrderSender $orderSender
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param array $params
* @throws \Exception
*/
public function __construct(
\Magento\Framework\Logger $logger,
- \Magento\Customer\Helper\Data $customerData,
+ \Magento\Customer\Model\Url $customerUrl,
\Magento\Tax\Helper\Data $taxData,
\Magento\Checkout\Helper\Data $checkoutData,
\Magento\Customer\Model\Session $customerSession,
@@ -343,9 +349,10 @@ class Checkout
\Magento\Framework\Encryption\EncryptorInterface $encryptor,
\Magento\Framework\Message\ManagerInterface $messageManager,
OrderSender $orderSender,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
$params = array()
) {
- $this->_customerData = $customerData;
+ $this->_customerUrl = $customerUrl;
$this->_taxData = $taxData;
$this->_checkoutData = $checkoutData;
$this->_configCacheType = $configCacheType;
@@ -369,6 +376,7 @@ class Checkout
$this->_encryptor = $encryptor;
$this->_messageManager = $messageManager;
$this->orderSender = $orderSender;
+ $this->quoteRepository = $quoteRepository;
$this->_customerSession = isset($params['session'])
&& $params['session'] instanceof \Magento\Customer\Model\Session ? $params['session'] : $customerSession;
@@ -512,7 +520,8 @@ class Checkout
);
}
- $this->_quote->reserveOrderId()->save();
+ $this->_quote->reserveOrderId();
+ $this->quoteRepository->save($this->_quote);
// prepare API
$this->_getApi();
$solutionType = $this->_config->getMerchantCountry() == 'DE'
@@ -708,7 +717,8 @@ class Checkout
$this->_paypalInfo->importToPayment($this->_api, $payment);
$payment->setAdditionalInformation(self::PAYMENT_INFO_TRANSPORT_PAYER_ID, $this->_api->getPayerId())
->setAdditionalInformation(self::PAYMENT_INFO_TRANSPORT_TOKEN, $token);
- $quote->collectTotals()->save();
+ $quote->collectTotals();
+ $this->quoteRepository->save($quote);
}
/**
@@ -731,7 +741,8 @@ class Checkout
'' == $this->_quote->getPayment()->getAdditionalInformation(self::PAYMENT_INFO_TRANSPORT_SHIPPING_METHOD)
);
$this->_ignoreAddressValidation();
- $this->_quote->collectTotals()->save();
+ $this->_quote->collectTotals();
+ $this->quoteRepository->save($this->_quote);
}
/**
@@ -787,7 +798,8 @@ class Checkout
if ($methodCode != $shippingAddress->getShippingMethod()) {
$this->_ignoreAddressValidation();
$shippingAddress->setShippingMethod($methodCode)->setCollectShippingRates(true);
- $this->_quote->collectTotals()->save();
+ $this->_quote->collectTotals();
+ $this->quoteRepository->save($this->_quote);
}
}
}
@@ -824,7 +836,7 @@ class Checkout
$parameters = array('quote' => $this->_quote);
$service = $this->_serviceQuoteFactory->create($parameters);
$service->submitAllWithDataObject();
- $this->_quote->save();
+ $this->quoteRepository->save($this->_quote);
if ($isNewCustomer) {
try {
@@ -1276,7 +1288,7 @@ class Checkout
$customer = $this->_quote->getCustomerData();
$confirmationStatus = $this->_customerAccountService->getConfirmationStatus($customer->getId());
if ($confirmationStatus === CustomerAccountServiceInterface::ACCOUNT_CONFIRMATION_REQUIRED) {
- $url = $this->_customerData->getEmailConfirmationUrl($customer->getEmail());
+ $url = $this->_customerUrl->getEmailConfirmationUrl($customer->getEmail());
$this->_messageManager->addSuccess(
// @codingStandardsIgnoreStart
__('Account confirmation is required. Please, check your e-mail for confirmation link. To resend confirmation email please <a href="%1">click here</a>.', $url)
diff --git a/app/code/Magento/Paypal/Model/Express/Checkout/Factory.php b/app/code/Magento/Paypal/Model/Express/Checkout/Factory.php
index 154bf3435d7f71680a9752f5db03b2efec679ea9..5b5266b699b1820c82c141fd9e4da2dee1a40eaf 100644
--- a/app/code/Magento/Paypal/Model/Express/Checkout/Factory.php
+++ b/app/code/Magento/Paypal/Model/Express/Checkout/Factory.php
@@ -31,16 +31,16 @@ class Factory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Paypal/Model/IpnFactory.php b/app/code/Magento/Paypal/Model/IpnFactory.php
index 08c0856f8b0bd9b868f48730224f4f0b492038fb..9b63f92073d38665761fc746f07c53cd2c47ef0e 100644
--- a/app/code/Magento/Paypal/Model/IpnFactory.php
+++ b/app/code/Magento/Paypal/Model/IpnFactory.php
@@ -28,7 +28,7 @@ class IpnFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -40,10 +40,10 @@ class IpnFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $mapping
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, array $mapping = array())
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, array $mapping = array())
{
$this->_objectManager = $objectManager;
$this->mapping = $mapping;
diff --git a/app/code/Magento/Paypal/Model/PayflowExpress/Checkout.php b/app/code/Magento/Paypal/Model/PayflowExpress/Checkout.php
index 23eb14c7e8793f3e4271a131d2cd7a2d40283494..d29980d1b7c37c6b0d29c8253084ed56b1215395 100644
--- a/app/code/Magento/Paypal/Model/PayflowExpress/Checkout.php
+++ b/app/code/Magento/Paypal/Model/PayflowExpress/Checkout.php
@@ -52,6 +52,6 @@ class Checkout extends \Magento\Paypal\Model\Express\Checkout
public function updateShippingMethod($methodCode)
{
parent::updateShippingMethod($methodCode);
- $this->_quote->save();
+ $this->quoteRepository->save($this->_quote);
}
}
diff --git a/app/code/Magento/Paypal/Model/Payflowlink.php b/app/code/Magento/Paypal/Model/Payflowlink.php
index 74ef84603eb5fe95d33ff70addcf389406c92edb..a8a419f1404445f6561f335250abb1ede9c3cb3a 100644
--- a/app/code/Magento/Paypal/Model/Payflowlink.php
+++ b/app/code/Magento/Paypal/Model/Payflowlink.php
@@ -132,9 +132,9 @@ class Payflowlink extends \Magento\Paypal\Model\Payflowpro
protected $_requestFactory;
/**
- * @var \Magento\Sales\Model\QuoteFactory
+ * @var \Magento\Sales\Model\QuoteRepository
*/
- protected $_quoteFactory;
+ protected $quoteRepository;
/**
* @var \Magento\Sales\Model\OrderFactory
@@ -165,7 +165,7 @@ class Payflowlink extends \Magento\Paypal\Model\Payflowpro
* @param \Magento\Framework\Math\Random $mathRandom
* @param \Magento\Framework\HTTP\ZendClientFactory $httpClientFactory
* @param \Magento\Paypal\Model\Payflow\RequestFactory $requestFactory
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param \Magento\Sales\Model\OrderFactory $orderFactory
* @param \Magento\Framework\App\RequestInterface $requestHttp
* @param \Magento\Store\Model\WebsiteFactory $websiteFactory
@@ -188,7 +188,7 @@ class Payflowlink extends \Magento\Paypal\Model\Payflowpro
\Magento\Framework\Math\Random $mathRandom,
\Magento\Framework\HTTP\ZendClientFactory $httpClientFactory,
\Magento\Paypal\Model\Payflow\RequestFactory $requestFactory,
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
\Magento\Sales\Model\OrderFactory $orderFactory,
\Magento\Framework\App\RequestInterface $requestHttp,
\Magento\Store\Model\WebsiteFactory $websiteFactory,
@@ -196,7 +196,7 @@ class Payflowlink extends \Magento\Paypal\Model\Payflowpro
array $data = array()
) {
$this->_requestFactory = $requestFactory;
- $this->_quoteFactory = $quoteFactory;
+ $this->quoteRepository = $quoteRepository;
$this->_orderFactory = $orderFactory;
$this->_requestHttp = $requestHttp;
$this->_websiteFactory = $websiteFactory;
@@ -401,7 +401,8 @@ class Payflowlink extends \Magento\Paypal\Model\Payflowpro
if ($canSendNewOrderEmail) {
$this->orderSender->send($order);
}
- $this->_quoteFactory->create()->load($order->getQuoteId())->setIsActive(false)->save();
+ $quote = $this->quoteRepository->get($order->getQuoteId())->setIsActive(false);
+ $this->quoteRepository->save($quote);
} catch (\Exception $e) {
throw new \Magento\Framework\Model\Exception(__('We cannot send the new order email.'));
}
diff --git a/app/code/Magento/Paypal/composer.json b/app/code/Magento/Paypal/composer.json
index 4302f9947945fab9961057f11f86bb2af507759f..6296bdf7d3f5818e8ce2f88307295b41645ea55f 100644
--- a/app/code/Magento/Paypal/composer.json
+++ b/app/code/Magento/Paypal/composer.json
@@ -3,25 +3,25 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-centinel": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-centinel": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"lib-libxml": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Persistent/Model/Factory.php b/app/code/Magento/Persistent/Model/Factory.php
index b71cab63623a2147bbf9563e410ac71f4ee2e532..3c19e954270b9164b9354b4031c15660a630dac2 100644
--- a/app/code/Magento/Persistent/Model/Factory.php
+++ b/app/code/Magento/Persistent/Model/Factory.php
@@ -31,16 +31,16 @@ class Factory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Persistent/Model/QuoteManager.php b/app/code/Magento/Persistent/Model/QuoteManager.php
index 1fb194c1305c2c4c167a3c3947336ba2b0a92858..6469d41cf1b1264e367710631ef0eaa394c8ea5b 100644
--- a/app/code/Magento/Persistent/Model/QuoteManager.php
+++ b/app/code/Magento/Persistent/Model/QuoteManager.php
@@ -54,19 +54,27 @@ class QuoteManager
*/
protected $_setQuotePersistent = true;
+ /**
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
/**
* @param \Magento\Persistent\Helper\Session $persistentSession
* @param \Magento\Persistent\Helper\Data $persistentData
* @param \Magento\Checkout\Model\Session $checkoutSession
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
*/
public function __construct(
\Magento\Persistent\Helper\Session $persistentSession,
\Magento\Persistent\Helper\Data $persistentData,
- \Magento\Checkout\Model\Session $checkoutSession
+ \Magento\Checkout\Model\Session $checkoutSession,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository
) {
$this->persistentSession = $persistentSession;
$this->persistentData = $persistentData;
$this->checkoutSession = $checkoutSession;
+ $this->quoteRepository = $quoteRepository;
}
/**
@@ -106,7 +114,8 @@ class QuoteManager
//Create guest addresses
$quote->getShippingAddress();
$quote->getBillingAddress();
- $quote->collectTotals()->save();
+ $quote->collectTotals();
+ $this->quoteRepository->save($quote);
}
$this->persistentSession->getSession()->removePersistentCookie();
diff --git a/app/code/Magento/Persistent/Model/Session.php b/app/code/Magento/Persistent/Model/Session.php
index af7d6a17543aec9260429a068ed64555f8456865..0818c69fbb0c1f201c6c9e34e01d3fcc4cd207cb 100644
--- a/app/code/Magento/Persistent/Model/Session.php
+++ b/app/code/Magento/Persistent/Model/Session.php
@@ -91,7 +91,7 @@ class Session extends \Magento\Framework\Model\AbstractModel
/**
* Cookie manager
*
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $_cookieManager;
@@ -120,7 +120,7 @@ class Session extends \Magento\Framework\Model\AbstractModel
* @param \Magento\Framework\App\Config\ScopeConfigInterface $coreConfig
* @param \Magento\Core\Helper\Data $coreData
* @param \Magento\Persistent\Helper\Data $persistentData
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
* @param \Magento\Framework\StoreManagerInterface $storeManager
* @param \Magento\Framework\Math\Random $mathRandom
@@ -135,7 +135,7 @@ class Session extends \Magento\Framework\Model\AbstractModel
\Magento\Framework\App\Config\ScopeConfigInterface $coreConfig,
\Magento\Core\Helper\Data $coreData,
\Magento\Persistent\Helper\Data $persistentData,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory,
\Magento\Framework\StoreManagerInterface $storeManager,
\Magento\Framework\Math\Random $mathRandom,
diff --git a/app/code/Magento/Persistent/composer.json b/app/code/Magento/Persistent/composer.json
index ea9bb11020a84f75564d492711176aac1580289d..572b0600eb6f9fded3afa14e460fb67e89f9596d 100644
--- a/app/code/Magento/Persistent/composer.json
+++ b/app/code/Magento/Persistent/composer.json
@@ -3,17 +3,17 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-cron": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-cron": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/ProductAlert/composer.json b/app/code/Magento/ProductAlert/composer.json
index 6a98e206a3b42fb83f209a31684df7474bc8ed5a..22f24d0cabf772866f33cc71b8804b89875817e5 100644
--- a/app/code/Magento/ProductAlert/composer.json
+++ b/app/code/Magento/ProductAlert/composer.json
@@ -3,15 +3,15 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/ProductAlert/etc/module.xml b/app/code/Magento/ProductAlert/etc/module.xml
index 24262c0128cabbf023f5677b03423abaa4dd9028..e9409160301ad781b6591c8d3afaf5da2a19bcfa 100644
--- a/app/code/Magento/ProductAlert/etc/module.xml
+++ b/app/code/Magento/ProductAlert/etc/module.xml
@@ -24,7 +24,7 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
- <module name="Magento_ProductAlert" schema_version="1.6.0.0" active="true">
+ <module name="Magento_ProductAlert" schema_version="2.0.0" active="true">
<sequence>
<module name="Magento_Catalog"/>
<module name="Magento_Customer"/>
diff --git a/app/code/Magento/ProductAlert/sql/productalert_setup/install-1.6.0.0.php b/app/code/Magento/ProductAlert/sql/productalert_setup/install-2.0.0.php
similarity index 100%
rename from app/code/Magento/ProductAlert/sql/productalert_setup/install-1.6.0.0.php
rename to app/code/Magento/ProductAlert/sql/productalert_setup/install-2.0.0.php
diff --git a/app/code/Magento/RecurringPayment/Block/Adminhtml/Payment/View/Items.php b/app/code/Magento/RecurringPayment/Block/Adminhtml/Payment/View/Items.php
index c156de1c8b700216fdf18abd8f69d52d23f9fd71..9fa1a209bc3297b30d85ca63aed0a76870493c77 100644
--- a/app/code/Magento/RecurringPayment/Block/Adminhtml/Payment/View/Items.php
+++ b/app/code/Magento/RecurringPayment/Block/Adminhtml/Payment/View/Items.php
@@ -37,20 +37,22 @@ class Items extends \Magento\Sales\Block\Adminhtml\Items\AbstractItems
/**
* @param \Magento\Backend\Block\Template\Context $context
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\Framework\Registry $registry
* @param PriceCurrencyInterface $priceCurrency
* @param array $data
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\Framework\Registry $registry,
PriceCurrencyInterface $priceCurrency,
array $data = array()
) {
$this->priceCurrency = $priceCurrency;
- parent::__construct($context, $stockItemService, $registry, $data);
+ parent::__construct($context, $stockRegistry, $stockConfiguration, $registry, $data);
}
diff --git a/app/code/Magento/RecurringPayment/Model/ManagerInterfaceFactory.php b/app/code/Magento/RecurringPayment/Model/ManagerInterfaceFactory.php
index 982f4b6378394f583043d2fd456aa28bf31c3431..6d65d2bea233619caf026f8ce5e4c59495d67846 100644
--- a/app/code/Magento/RecurringPayment/Model/ManagerInterfaceFactory.php
+++ b/app/code/Magento/RecurringPayment/Model/ManagerInterfaceFactory.php
@@ -31,7 +31,7 @@ class ManagerInterfaceFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -45,11 +45,11 @@ class ManagerInterfaceFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\RecurringPayment\Model\ManagerInterface'
) {
$this->_objectManager = $objectManager;
diff --git a/app/code/Magento/RecurringPayment/composer.json b/app/code/Magento/RecurringPayment/composer.json
index 853e3e05419618cb97776d745aaa50e7aad90a96..4cb044490f02d04292311c612fc96d429e4e5c08 100644
--- a/app/code/Magento/RecurringPayment/composer.json
+++ b/app/code/Magento/RecurringPayment/composer.json
@@ -3,22 +3,22 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Reports/Model/Product/Index/Factory.php b/app/code/Magento/Reports/Model/Product/Index/Factory.php
index d9d5b9bfeb1de2ed228c4935444ff6e6b055291b..4f0e1495cb750320d6ca519d89e65d199eea9784 100644
--- a/app/code/Magento/Reports/Model/Product/Index/Factory.php
+++ b/app/code/Magento/Reports/Model/Product/Index/Factory.php
@@ -43,9 +43,9 @@ class Factory
protected $_instances;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Reports/Model/Resource/Customer/Collection.php b/app/code/Magento/Reports/Model/Resource/Customer/Collection.php
index 5c0955ec4042550650a9cf59f647d812b4a48725..a2fa2b7de6d0ba8d0d3bfd60f37260c0d6c0e588 100644
--- a/app/code/Magento/Reports/Model/Resource/Customer/Collection.php
+++ b/app/code/Magento/Reports/Model/Resource/Customer/Collection.php
@@ -76,9 +76,9 @@ class Collection extends \Magento\Customer\Model\Resource\Customer\Collection
protected $_orderEntityField;
/**
- * @var \Magento\Sales\Model\QuoteFactory
+ * @var \Magento\Sales\Model\QuoteRepository
*/
- protected $_quoteFactory;
+ protected $quoteRepository;
/**
* @var \Magento\Sales\Model\Resource\Quote\Item\CollectionFactory
@@ -96,7 +96,7 @@ class Collection extends \Magento\Customer\Model\Resource\Customer\Collection
* @param \Magento\Eav\Model\Resource\Helper $resourceHelper
* @param \Magento\Framework\Validator\UniversalFactory $universalFactory
* @param \Magento\Framework\Object\Copy\Config $fieldsetConfig
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param \Magento\Sales\Model\Resource\Quote\Item\CollectionFactory $quoteItemFactory
* @param mixed $connection
* @param string $modelName
@@ -114,7 +114,7 @@ class Collection extends \Magento\Customer\Model\Resource\Customer\Collection
\Magento\Eav\Model\Resource\Helper $resourceHelper,
\Magento\Framework\Validator\UniversalFactory $universalFactory,
\Magento\Framework\Object\Copy\Config $fieldsetConfig,
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
\Magento\Sales\Model\Resource\Quote\Item\CollectionFactory $quoteItemFactory,
$connection = null,
$modelName = self::CUSTOMER_MODEL_NAME
@@ -133,7 +133,7 @@ class Collection extends \Magento\Customer\Model\Resource\Customer\Collection
$connection,
$modelName
);
- $this->_quoteFactory = $quoteFactory;
+ $this->quoteRepository = $quoteRepository;
$this->_quoteItemFactory = $quoteItemFactory;
}
@@ -145,15 +145,15 @@ class Collection extends \Magento\Customer\Model\Resource\Customer\Collection
public function addCartInfo()
{
foreach ($this->getItems() as $item) {
- $quote = $this->_quoteFactory->create()->loadByCustomer($item->getId());
+ try {
+ $quote = $this->quoteRepository->getForCustomer($item->getId());
- if ($quote instanceof \Magento\Sales\Model\Quote) {
$totals = $quote->getTotals();
$item->setTotal($totals['subtotal']->getValue());
$quoteItems = $this->_quoteItemFactory->create()->setQuoteFilter($quote->getId());
$quoteItems->load();
$item->setItems($quoteItems->count());
- } else {
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
$item->remove();
}
}
diff --git a/app/code/Magento/Reports/Model/Resource/Product/Lowstock/Collection.php b/app/code/Magento/Reports/Model/Resource/Product/Lowstock/Collection.php
index 0085cc2ad70482a06fcb09e4a34dad5940308d03..4a78089c00ca2cc242ef470eb548b507a75b19dd 100644
--- a/app/code/Magento/Reports/Model/Resource/Product/Lowstock/Collection.php
+++ b/app/code/Magento/Reports/Model/Resource/Product/Lowstock/Collection.php
@@ -47,9 +47,14 @@ class Collection extends \Magento\Reports\Model\Resource\Product\Collection
protected $_inventoryItemTableAlias = 'lowstock_inventory_item';
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface
+ */
+ protected $stockConfiguration;
/**
* @var \Magento\CatalogInventory\Model\Resource\Stock\Item
@@ -78,7 +83,8 @@ class Collection extends \Magento\Reports\Model\Resource\Product\Collection
* @param \Magento\Catalog\Model\Resource\Product $product
* @param \Magento\Reports\Model\Event\TypeFactory $eventTypeFactory
* @param \Magento\Catalog\Model\Product\Type $productType
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\CatalogInventory\Model\Resource\Stock\Item $itemResource
* @param mixed $connection
*
@@ -106,7 +112,8 @@ class Collection extends \Magento\Reports\Model\Resource\Product\Collection
\Magento\Catalog\Model\Resource\Product $product,
\Magento\Reports\Model\Event\TypeFactory $eventTypeFactory,
\Magento\Catalog\Model\Product\Type $productType,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\CatalogInventory\Model\Resource\Stock\Item $itemResource,
$connection = null
) {
@@ -134,7 +141,8 @@ class Collection extends \Magento\Reports\Model\Resource\Product\Collection
$productType,
$connection
);
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
+ $this->stockConfiguration = $stockConfiguration;
$this->_itemResource = $itemResource;
}
@@ -263,7 +271,7 @@ class Collection extends \Magento\Reports\Model\Resource\Product\Collection
*/
public function filterByIsQtyProductTypes()
{
- $this->filterByProductType(array_keys(array_filter($this->stockItemService->getIsQtyTypeIds())));
+ $this->filterByProductType(array_keys(array_filter($this->stockConfiguration->getIsQtyTypeIds())));
return $this;
}
@@ -278,11 +286,7 @@ class Collection extends \Magento\Reports\Model\Resource\Product\Collection
$this->joinInventoryItem();
$manageStockExpr = $this->getConnection()->getCheckSql(
$this->_getInventoryItemField('use_config_manage_stock') . ' = 1',
- (int)$this->_scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_MANAGE_STOCK,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- $storeId
- ),
+ (int)$this->stockConfiguration->getManageStock($storeId),
$this->_getInventoryItemField('manage_stock')
);
$this->getSelect()->where($manageStockExpr . ' = ?', 1);
@@ -300,11 +304,7 @@ class Collection extends \Magento\Reports\Model\Resource\Product\Collection
$this->joinInventoryItem(array('qty'));
$notifyStockExpr = $this->getConnection()->getCheckSql(
$this->_getInventoryItemField('use_config_notify_stock_qty') . ' = 1',
- (int)$this->_scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_NOTIFY_STOCK_QTY,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- $storeId
- ),
+ (int)$this->stockConfiguration->getNotifyStockQty($storeId),
$this->_getInventoryItemField('notify_stock_qty')
);
$this->getSelect()->where('qty < ?', $notifyStockExpr);
diff --git a/app/code/Magento/Reports/Model/Resource/Report/Collection/Factory.php b/app/code/Magento/Reports/Model/Resource/Report/Collection/Factory.php
index 59ec4eb944aaa2c3c04982001f51c1a396c9e284..3b247404f856a25d62558aeb65e3fc367805af67 100644
--- a/app/code/Magento/Reports/Model/Resource/Report/Collection/Factory.php
+++ b/app/code/Magento/Reports/Model/Resource/Report/Collection/Factory.php
@@ -26,14 +26,14 @@ namespace Magento\Reports\Model\Resource\Report\Collection;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Reports/composer.json b/app/code/Magento/Reports/composer.json
index 8b4926bd206d043e67b48aa028a4983d965f96b3..e038b17b9793ba281f47fe3bf98aa7b4a52db4f7 100644
--- a/app/code/Magento/Reports/composer.json
+++ b/app/code/Magento/Reports/composer.json
@@ -3,27 +3,27 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-widget": "0.1.0-alpha104",
- "magento/module-log": "0.1.0-alpha104",
- "magento/module-wishlist": "0.1.0-alpha104",
- "magento/module-review": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-downloadable": "0.1.0-alpha104",
- "magento/module-sales-rule": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-widget": "0.1.0-alpha105",
+ "magento/module-log": "0.1.0-alpha105",
+ "magento/module-wishlist": "0.1.0-alpha105",
+ "magento/module-review": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-downloadable": "0.1.0-alpha105",
+ "magento/module-sales-rule": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/RequireJs/composer.json b/app/code/Magento/RequireJs/composer.json
index 8641f5e0b9cfada0b2d7d9ad01800d1964622486..b54592ebb08be64dbbc7854f36100c21005d04bf 100644
--- a/app/code/Magento/RequireJs/composer.json
+++ b/app/code/Magento/RequireJs/composer.json
@@ -3,11 +3,11 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/framework": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Review/Block/Form.php b/app/code/Magento/Review/Block/Form.php
index 25dc1cf93be8f47e6eee52eef49580613e84b60f..469cc78c75994ba6d5238367f82eaf9af0933db4 100644
--- a/app/code/Magento/Review/Block/Form.php
+++ b/app/code/Magento/Review/Block/Form.php
@@ -24,6 +24,8 @@
namespace Magento\Review\Block;
use Magento\Catalog\Model\Product;
+use Magento\Customer\Model\Context;
+use Magento\Customer\Model\Url;
use Magento\Review\Model\Resource\Rating\Collection as RatingCollection;
/**
@@ -87,6 +89,11 @@ class Form extends \Magento\Framework\View\Element\Template
*/
protected $httpContext;
+ /**
+ * @var \Magento\Customer\Model\Url
+ */
+ protected $customerUrl;
+
/**
* @param \Magento\Framework\View\Element\Template\Context $context
* @param \Magento\Core\Helper\Data $coreData
@@ -97,6 +104,7 @@ class Form extends \Magento\Framework\View\Element\Template
* @param \Magento\Review\Model\RatingFactory $ratingFactory
* @param \Magento\Framework\Message\ManagerInterface $messageManager
* @param \Magento\Framework\App\Http\Context $httpContext
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param array $data
*/
public function __construct(
@@ -109,6 +117,7 @@ class Form extends \Magento\Framework\View\Element\Template
\Magento\Review\Model\RatingFactory $ratingFactory,
\Magento\Framework\Message\ManagerInterface $messageManager,
\Magento\Framework\App\Http\Context $httpContext,
+ \Magento\Customer\Model\Url $customerUrl,
array $data = array()
) {
$this->_coreData = $coreData;
@@ -119,6 +128,7 @@ class Form extends \Magento\Framework\View\Element\Template
$this->_ratingFactory = $ratingFactory;
$this->messageManager = $messageManager;
$this->httpContext = $httpContext;
+ $this->customerUrl = $customerUrl;
parent::__construct($context, $data);
}
@@ -143,7 +153,7 @@ class Form extends \Magento\Framework\View\Element\Template
}
$this->setAllowWriteReviewFlag(
- $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)
+ $this->httpContext->getValue(Context::CONTEXT_AUTH)
|| $this->_reviewData->getIsGuestAllowToWrite()
);
if (!$this->getAllowWriteReviewFlag()) {
@@ -153,7 +163,7 @@ class Form extends \Magento\Framework\View\Element\Template
$this->setLoginLink(
$this->getUrl(
'customer/account/login/',
- array(\Magento\Customer\Helper\Data::REFERER_QUERY_PARAM_NAME => $queryParam)
+ array(Url::REFERER_QUERY_PARAM_NAME => $queryParam)
)
);
}
@@ -201,4 +211,14 @@ class Form extends \Magento\Framework\View\Element\Template
true
)->load()->addOptionToItems();
}
+
+ /**
+ * Return register URL
+ *
+ * @return string
+ */
+ public function getRegisterUrl()
+ {
+ return $this->customerUrl->getRegisterUrl();
+ }
}
diff --git a/app/code/Magento/Review/Controller/Product.php b/app/code/Magento/Review/Controller/Product.php
index 2821ef0ff38a05102f167d78982fdfd737c2f742..1a6bb12b05a9b7a2cf1b2cee3cf692ab876419d7 100644
--- a/app/code/Magento/Review/Controller/Product.php
+++ b/app/code/Magento/Review/Controller/Product.php
@@ -177,7 +177,7 @@ class Product extends \Magento\Framework\App\Action\Action
$this->_redirect->getRefererUrl()
);
$this->getResponse()->setRedirect(
- $this->_objectManager->get('Magento\Customer\Helper\Data')->getLoginUrl()
+ $this->_objectManager->get('Magento\Customer\Model\Url')->getLoginUrl()
);
}
}
diff --git a/app/code/Magento/Review/composer.json b/app/code/Magento/Review/composer.json
index 47420672b6038eb5b35d052023cfd6c3a22a6e26..07dfa3aa77fa61b861230960881992843a873de4 100644
--- a/app/code/Magento/Review/composer.json
+++ b/app/code/Magento/Review/composer.json
@@ -3,20 +3,20 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-newsletter": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-newsletter": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Review/view/frontend/templates/form.phtml b/app/code/Magento/Review/view/frontend/templates/form.phtml
index eabde99834ae08fbfa01af6fce8926fdc27e2288..120bcd03bd69f7b80a45345ddfd9e02d9d880026 100644
--- a/app/code/Magento/Review/view/frontend/templates/form.phtml
+++ b/app/code/Magento/Review/view/frontend/templates/form.phtml
@@ -21,6 +21,9 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0)
*/
+/**
+ * @var $this \Magento\Review\Block\Form
+ */
?>
<div class="block review-add">
<div class="block-title"><strong><?php echo __('Write Your Own Review') ?></strong></div>
@@ -116,7 +119,7 @@ require([
<?php else: ?>
<div class="message info notlogged" id="review-form">
<div>
- <?php echo __('Only registered users can write reviews. Please, <a href="%1">log in</a> or <a href="%2">register</a>', $this->getLoginLink(), $this->helper('Magento\Customer\Helper\Data')->getRegisterUrl()) ?>
+ <?php echo __('Only registered users can write reviews. Please, <a href="%1">log in</a> or <a href="%2">register</a>', $this->getLoginLink(), $this->getRegisterUrl()) ?>
</div>
</div>
<?php endif ?>
diff --git a/app/code/Magento/Rss/Model/RssManager.php b/app/code/Magento/Rss/Model/RssManager.php
index 860884178c7ff9cfcb81a9f9b02eab249f330ab7..0b1ccd2aacaa45510c49ddd5cae9f21c75994130 100644
--- a/app/code/Magento/Rss/Model/RssManager.php
+++ b/app/code/Magento/Rss/Model/RssManager.php
@@ -39,11 +39,13 @@ class RssManager implements RssManagerInterface
protected $providers;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $dataProviders
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, array $dataProviders = array())
- {
+ public function __construct(
+ \Magento\Framework\ObjectManagerInterface $objectManager,
+ array $dataProviders = array()
+ ) {
$this->objectManager = $objectManager;
$this->providers = $dataProviders;
}
diff --git a/app/code/Magento/Rss/composer.json b/app/code/Magento/Rss/composer.json
index beed028e0ea81b59773d2a7da32fb535733aaf5b..6cd28224c967e82d6efcb43072a0ca0c739d2066 100644
--- a/app/code/Magento/Rss/composer.json
+++ b/app/code/Magento/Rss/composer.json
@@ -3,14 +3,14 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Rule/Model/ActionFactory.php b/app/code/Magento/Rule/Model/ActionFactory.php
index f4673e5f9182da70294e724181979f442dfae9af..0062137c6ac1f875e5ce788642bd94a90ac26b1d 100644
--- a/app/code/Magento/Rule/Model/ActionFactory.php
+++ b/app/code/Magento/Rule/Model/ActionFactory.php
@@ -26,14 +26,14 @@ namespace Magento\Rule\Model;
class ActionFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Rule/Model/ConditionFactory.php b/app/code/Magento/Rule/Model/ConditionFactory.php
index 95b18789ba8fd8fc2a1fda6411b3bd0a4b054a66..12feadfb7bce68e7dc7090242624c2c99ed2fa8e 100644
--- a/app/code/Magento/Rule/Model/ConditionFactory.php
+++ b/app/code/Magento/Rule/Model/ConditionFactory.php
@@ -23,12 +23,12 @@
*/
namespace Magento\Rule\Model;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class ConditionFactory
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
@@ -40,9 +40,9 @@ class ConditionFactory
private $conditionModels = [];
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Rule/composer.json b/app/code/Magento/Rule/composer.json
index 01c7fdadc746f53498a185f21ca317fe5aafa8b3..e8a934c6a7d64bd024031f2f3a663deb689470e7 100644
--- a/app/code/Magento/Rule/composer.json
+++ b/app/code/Magento/Rule/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"lib-libxml": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Items/AbstractItems.php b/app/code/Magento/Sales/Block/Adminhtml/Items/AbstractItems.php
index eac8657379e6aa2bfce4ed8012895ba14033b9f1..bc871aeb8d238f880c13f1bc1afd7126bcd2386b 100644
--- a/app/code/Magento/Sales/Block/Adminhtml/Items/AbstractItems.php
+++ b/app/code/Magento/Sales/Block/Adminhtml/Items/AbstractItems.php
@@ -61,23 +61,31 @@ class AbstractItems extends \Magento\Backend\Block\Template
protected $_coreRegistry;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface
+ */
+ protected $stockConfiguration;
/**
* @param \Magento\Backend\Block\Template\Context $context
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\Framework\Registry $registry
* @param array $data
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\Framework\Registry $registry,
array $data = array()
) {
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
+ $this->stockConfiguration = $stockConfiguration;
$this->_coreRegistry = $registry;
parent::__construct($context, $data);
}
@@ -466,21 +474,12 @@ class AbstractItems extends \Magento\Backend\Block\Template
}
/**
- * CREDITMEMO
- *
+ * @param \Magento\Store\Model\Store $store
* @return bool
*/
- public function canReturnToStock()
+ public function canReturnToStock($store = null)
{
- $canSubtract = $this->_scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_CAN_SUBTRACT,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- if ($canSubtract) {
- return true;
- } else {
- return false;
- }
+ return $this->stockConfiguration->canSubtractQty($store);
}
/**
@@ -493,21 +492,16 @@ class AbstractItems extends \Magento\Backend\Block\Template
{
if (null !== $item) {
if (!$item->hasCanReturnToStock()) {
- $productId = $item->getOrderItem()->getProductId();
- if ($productId && $this->stockItemService->getManageStock($productId)) {
- $item->setCanReturnToStock(true);
- } else {
- $item->setCanReturnToStock(false);
- }
+ $stockItem = $this->stockRegistry->getStockItem(
+ $item->getOrderItem()->getProductId(),
+ $item->getOrderItem()->getStore()->getWebsiteId()
+ );
+ $item->setCanReturnToStock($stockItem->getManageStock());
}
- $canReturnToStock = $item->getCanReturnToStock();
- } else {
- $canReturnToStock = $this->_scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_CAN_SUBTRACT,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
+ return $item->getCanReturnToStock();
}
- return $canReturnToStock;
+
+ return $this->canReturnToStock();
}
/**
@@ -518,18 +512,14 @@ class AbstractItems extends \Magento\Backend\Block\Template
*/
public function canParentReturnToStock($item = null)
{
- $canReturnToStock = $this->_scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_CAN_SUBTRACT,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
if (!is_null($item)) {
if ($item->getCreditmemo()->getOrder()->hasCanReturnToStock()) {
- $canReturnToStock = $item->getCreditmemo()->getOrder()->getCanReturnToStock();
+ return $item->getCreditmemo()->getOrder()->getCanReturnToStock();
}
} elseif ($this->getOrder()->hasCanReturnToStock()) {
- $canReturnToStock = $this->getOrder()->getCanReturnToStock();
+ return $this->getOrder()->getCanReturnToStock();
}
- return $canReturnToStock;
+ return $this->canReturnToStock();
}
/**
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Items/Column/DefaultColumn.php b/app/code/Magento/Sales/Block/Adminhtml/Items/Column/DefaultColumn.php
index bddeee82ee00e9ffcca924e3c001c2ee5f732490..5e00d68692bd31dc93fc1633b1dff3f4480b91de 100644
--- a/app/code/Magento/Sales/Block/Adminhtml/Items/Column/DefaultColumn.php
+++ b/app/code/Magento/Sales/Block/Adminhtml/Items/Column/DefaultColumn.php
@@ -44,20 +44,22 @@ class DefaultColumn extends \Magento\Sales\Block\Adminhtml\Items\AbstractItems
/**
* @param \Magento\Backend\Block\Template\Context $context
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\Framework\Registry $registry
* @param \Magento\Catalog\Model\Product\OptionFactory $optionFactory
* @param array $data
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\Framework\Registry $registry,
\Magento\Catalog\Model\Product\OptionFactory $optionFactory,
array $data = array()
) {
$this->_optionFactory = $optionFactory;
- parent::__construct($context, $stockItemService, $registry, $data);
+ parent::__construct($context, $stockRegistry, $stockConfiguration, $registry, $data);
}
/**
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Address/Form.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Address/Form.php
index 4aa78d6149e806b406a3c9cfb6afcd849b639147..ee80e7b08fcd3f31a5649099dac7356c8646f333 100644
--- a/app/code/Magento/Sales/Block/Adminhtml/Order/Address/Form.php
+++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Address/Form.php
@@ -53,7 +53,7 @@ class Form extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\Address
* @param \Magento\Core\Helper\Data $coreData
* @param \Magento\Framework\Json\EncoderInterface $jsonEncoder
* @param \Magento\Customer\Model\Metadata\FormFactory $customerFormFactory
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Options $options
* @param \Magento\Customer\Service\V1\CustomerAddressServiceInterface $addressService
* @param \Magento\Customer\Helper\Address $addressHelper
* @param \Magento\Framework\Registry $registry
@@ -69,7 +69,7 @@ class Form extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\Address
\Magento\Core\Helper\Data $coreData,
\Magento\Framework\Json\EncoderInterface $jsonEncoder,
\Magento\Customer\Model\Metadata\FormFactory $customerFormFactory,
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Options $options,
\Magento\Customer\Service\V1\CustomerAddressServiceInterface $addressService,
\Magento\Customer\Helper\Address $addressHelper,
\Magento\Framework\Registry $registry,
@@ -85,7 +85,7 @@ class Form extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\Address
$coreData,
$jsonEncoder,
$customerFormFactory,
- $customerHelper,
+ $options,
$addressService,
$addressHelper,
$data
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Address.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Address.php
index 14b5fbbfb83b879d79efb506aae524a2e70a8e1f..e5ce67a9eb9f3fbba2b944ec98f85daf61cb349b 100644
--- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Address.php
+++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Address.php
@@ -54,11 +54,11 @@ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\AbstractF
protected $_coreData;
/**
- * Customer helper
+ * Customer options
*
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Options
*/
- protected $_customerHelper;
+ protected $options;
/**
* Address service
@@ -83,7 +83,7 @@ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\AbstractF
* @param \Magento\Core\Helper\Data $coreData
* @param \Magento\Framework\Json\EncoderInterface $jsonEncoder
* @param \Magento\Customer\Model\Metadata\FormFactory $customerFormFactory
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Options $options
* @param \Magento\Customer\Service\V1\CustomerAddressServiceInterface $addressService
* @param \Magento\Customer\Helper\Address $addressHelper
* @param array $data
@@ -99,12 +99,12 @@ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\AbstractF
\Magento\Core\Helper\Data $coreData,
\Magento\Framework\Json\EncoderInterface $jsonEncoder,
\Magento\Customer\Model\Metadata\FormFactory $customerFormFactory,
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Options $options,
\Magento\Customer\Service\V1\CustomerAddressServiceInterface $addressService,
\Magento\Customer\Helper\Address $addressHelper,
array $data = array()
) {
- $this->_customerHelper = $customerHelper;
+ $this->options = $options;
$this->_coreData = $coreData;
$this->_jsonEncoder = $jsonEncoder;
$this->_customerFormFactory = $customerFormFactory;
@@ -181,7 +181,7 @@ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\AbstractF
$prefixElement = $this->_form->getElement('prefix');
if ($prefixElement) {
- $prefixOptions = $this->_customerHelper->getNamePrefixOptions($this->getStore());
+ $prefixOptions = $this->options->getNamePrefixOptions($this->getStore());
if (!empty($prefixOptions)) {
$fieldset->removeField($prefixElement->getId());
$prefixField = $fieldset->addField($prefixElement->getId(), 'select', $prefixElement->getData(), '^');
@@ -194,7 +194,7 @@ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\AbstractF
$suffixElement = $this->_form->getElement('suffix');
if ($suffixElement) {
- $suffixOptions = $this->_customerHelper->getNameSuffixOptions($this->getStore());
+ $suffixOptions = $this->options->getNameSuffixOptions($this->getStore());
if (!empty($suffixOptions)) {
$fieldset->removeField($suffixElement->getId());
$suffixField = $fieldset->addField(
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Items/Grid.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Items/Grid.php
index 06091d60c6257fc9f0124e7ec9f8f01c8968d56c..468944f3c3d0e2b66f6f9c9dd6bdccc2811fb773 100644
--- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Items/Grid.php
+++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Items/Grid.php
@@ -24,6 +24,8 @@
namespace Magento\Sales\Block\Adminhtml\Order\Create\Items;
use Magento\Catalog\Model\Product\Attribute\Source\Status as ProductStatus;
+use Magento\CatalogInventory\Api\StockRegistryInterface;
+use Magento\CatalogInventory\Api\StockStateInterface;
use Magento\Framework\Pricing\PriceCurrencyInterface;
use Magento\Sales\Model\Quote\Item;
use Magento\Framework\Session\SessionManagerInterface;
@@ -76,9 +78,14 @@ class Grid extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
protected $_messageHelper;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
+
+ /**
+ * @var StockStateInterface
+ */
+ protected $stockState;
/**
* @param \Magento\Backend\Block\Template\Context $context
@@ -90,7 +97,8 @@ class Grid extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
* @param \Magento\Tax\Model\Config $taxConfig
* @param \Magento\Tax\Helper\Data $taxData
* @param \Magento\GiftMessage\Helper\Message $messageHelper
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param StockRegistryInterface $stockRegistry
+ * @param StockStateInterface $stockState
* @param array $data
*/
public function __construct(
@@ -103,7 +111,8 @@ class Grid extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
\Magento\Tax\Model\Config $taxConfig,
\Magento\Tax\Helper\Data $taxData,
\Magento\GiftMessage\Helper\Message $messageHelper,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ StockRegistryInterface $stockRegistry,
+ StockStateInterface $stockState,
array $data = array()
) {
$this->_messageHelper = $messageHelper;
@@ -111,7 +120,8 @@ class Grid extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
$this->_giftMessageSave = $giftMessageSave;
$this->_taxConfig = $taxConfig;
$this->_taxData = $taxData;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
+ $this->stockState = $stockState;
parent::__construct($context, $sessionQuote, $orderCreate, $priceCurrency, $data);
}
@@ -154,11 +164,12 @@ class Grid extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
}
foreach ($stockItemToCheck as $productId) {
- $check = $this->stockItemService->checkQuoteItemQty(
+ $check = $this->stockState->checkQuoteItemQty(
$productId,
$item->getQty(),
$item->getQty(),
- $item->getQty()
+ $item->getQty(),
+ $this->getQuote()->getStore()->getWebsiteId()
);
$item->setMessage($check->getMessage());
$item->setHasError($check->getHasError());
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Creditmemo/Create/Items.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Creditmemo/Create/Items.php
index 2a6765fe2e89128a9b03c3a23caa7989fef9edee..28331936b802b7ebdf372952108436417efc15a6 100644
--- a/app/code/Magento/Sales/Block/Adminhtml/Order/Creditmemo/Create/Items.php
+++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Creditmemo/Create/Items.php
@@ -42,20 +42,22 @@ class Items extends \Magento\Sales\Block\Adminhtml\Items\AbstractItems
/**
* @param \Magento\Backend\Block\Template\Context $context
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\Framework\Registry $registry
* @param \Magento\Sales\Helper\Data $salesData
* @param array $data
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\Framework\Registry $registry,
\Magento\Sales\Helper\Data $salesData,
array $data = array()
) {
$this->_salesData = $salesData;
- parent::__construct($context, $stockItemService, $registry, $data);
+ parent::__construct($context, $stockRegistry, $stockConfiguration, $registry, $data);
}
/**
@@ -205,24 +207,6 @@ class Items extends \Magento\Sales\Block\Adminhtml\Items\AbstractItems
);
}
- /**
- * Check if allow to return stock
- *
- * @return bool
- */
- public function canReturnToStock()
- {
- $canReturnToStock = $this->_scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_CAN_SUBTRACT,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
- if ($canReturnToStock) {
- return true;
- } else {
- return false;
- }
- }
-
/**
* Whether to show 'Return to stock' column in creaditmemo grid
*
@@ -231,15 +215,16 @@ class Items extends \Magento\Sales\Block\Adminhtml\Items\AbstractItems
public function canReturnItemsToStock()
{
if (is_null($this->_canReturnToStock)) {
- $this->_canReturnToStock = $this->_scopeConfig->getValue(
- \Magento\CatalogInventory\Model\Stock\Item::XML_PATH_CAN_SUBTRACT,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE
- );
+ $this->_canReturnToStock = $this->canReturnToStock();
if ($this->_canReturnToStock) {
$canReturnToStock = false;
foreach ($this->getCreditmemo()->getAllItems() as $item) {
$productId = $item->getOrderItem()->getProductId();
- if ($productId && $this->stockItemService->getManageStock($productId)) {
+ $stockItem = $this->stockRegistry->getStockItem(
+ $productId,
+ $item->getOrderItem()->getStore()->getWebsiteId()
+ );
+ if ($stockItem->getManageStock()) {
$canReturnToStock = true;
$item->setCanReturnToStock($canReturnToStock);
} else {
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/Create/Items.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/Create/Items.php
index 5cecff1a0092a00923ca8a676f9cdeb040f2050d..533bb904c72e2fac764a1caf3f770a757950d0ef 100644
--- a/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/Create/Items.php
+++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/Create/Items.php
@@ -44,20 +44,22 @@ class Items extends \Magento\Sales\Block\Adminhtml\Items\AbstractItems
/**
* @param \Magento\Backend\Block\Template\Context $context
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\Framework\Registry $registry
* @param \Magento\Sales\Helper\Data $salesData
* @param array $data
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\Framework\Registry $registry,
\Magento\Sales\Helper\Data $salesData,
array $data = array()
) {
$this->_salesData = $salesData;
- parent::__construct($context, $stockItemService, $registry, $data);
+ parent::__construct($context, $stockRegistry, $stockConfiguration, $registry, $data);
}
/**
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/View/Items/Renderer/DefaultRenderer.php b/app/code/Magento/Sales/Block/Adminhtml/Order/View/Items/Renderer/DefaultRenderer.php
index 0301d957ab05a3fc8dda1d0b58af299e7f04b4a8..d2fb3ef543fe60f83748e8851bbdb0274accb434 100644
--- a/app/code/Magento/Sales/Block/Adminhtml/Order/View/Items/Renderer/DefaultRenderer.php
+++ b/app/code/Magento/Sales/Block/Adminhtml/Order/View/Items/Renderer/DefaultRenderer.php
@@ -53,7 +53,8 @@ class DefaultRenderer extends \Magento\Sales\Block\Adminhtml\Items\Renderer\Defa
/**
* @param \Magento\Backend\Block\Template\Context $context
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\Framework\Registry $registry
* @param \Magento\GiftMessage\Helper\Message $messageHelper
* @param \Magento\Checkout\Helper\Data $checkoutHelper
@@ -61,7 +62,8 @@ class DefaultRenderer extends \Magento\Sales\Block\Adminhtml\Items\Renderer\Defa
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\Framework\Registry $registry,
\Magento\GiftMessage\Helper\Message $messageHelper,
\Magento\Checkout\Helper\Data $checkoutHelper,
@@ -69,7 +71,7 @@ class DefaultRenderer extends \Magento\Sales\Block\Adminhtml\Items\Renderer\Defa
) {
$this->_checkoutHelper = $checkoutHelper;
$this->_messageHelper = $messageHelper;
- parent::__construct($context, $stockItemService, $registry, $data);
+ parent::__construct($context, $stockRegistry, $stockConfiguration, $registry, $data);
}
/**
diff --git a/app/code/Magento/Sales/Block/Guest/Link.php b/app/code/Magento/Sales/Block/Guest/Link.php
index c2ebb4765f564d8c4d2bfd689abf5b083274e93f..185fa544ca788204ea97cae7482abdbf6cdd27d3 100644
--- a/app/code/Magento/Sales/Block/Guest/Link.php
+++ b/app/code/Magento/Sales/Block/Guest/Link.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Sales\Block\Guest;
+use Magento\Customer\Model\Context;
+
/**
* "Orders and Returns" link
*/
@@ -55,7 +57,7 @@ class Link extends \Magento\Framework\View\Element\Html\Link\Current
*/
protected function _toHtml()
{
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return '';
}
return parent::_toHtml();
diff --git a/app/code/Magento/Sales/Block/Order/Creditmemo.php b/app/code/Magento/Sales/Block/Order/Creditmemo.php
index 85520df488022e30d9d56a1c325da621bab89000..bc6adb4ae5d453fb84027014c7cf3e439893b824 100644
--- a/app/code/Magento/Sales/Block/Order/Creditmemo.php
+++ b/app/code/Magento/Sales/Block/Order/Creditmemo.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Sales\Block\Order;
+use Magento\Customer\Model\Context;
+
/**
* Sales order view block
*
@@ -100,7 +102,7 @@ class Creditmemo extends \Magento\Sales\Block\Order\Creditmemo\Items
*/
public function getBackUrl()
{
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return $this->getUrl('*/*/history');
}
return $this->getUrl('*/*/form');
@@ -113,7 +115,7 @@ class Creditmemo extends \Magento\Sales\Block\Order\Creditmemo\Items
*/
public function getBackTitle()
{
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return __('Back to My Orders');
}
return __('View Another Order');
diff --git a/app/code/Magento/Sales/Block/Order/Info/Buttons.php b/app/code/Magento/Sales/Block/Order/Info/Buttons.php
index c0d2e87ccf0a0a92480973b2584f533ca83e82b6..c3621a59199d29f21b3178e2f8411da97cb5c4cf 100644
--- a/app/code/Magento/Sales/Block/Order/Info/Buttons.php
+++ b/app/code/Magento/Sales/Block/Order/Info/Buttons.php
@@ -28,6 +28,8 @@
*/
namespace Magento\Sales\Block\Order\Info;
+use Magento\Customer\Model\Context;
+
class Buttons extends \Magento\Framework\View\Element\Template
{
/**
@@ -83,7 +85,7 @@ class Buttons extends \Magento\Framework\View\Element\Template
*/
public function getPrintUrl($order)
{
- if (!$this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if (!$this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return $this->getUrl('sales/guest/print', array('order_id' => $order->getId()));
}
return $this->getUrl('sales/order/print', array('order_id' => $order->getId()));
@@ -97,7 +99,7 @@ class Buttons extends \Magento\Framework\View\Element\Template
*/
public function getReorderUrl($order)
{
- if (!$this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if (!$this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return $this->getUrl('sales/guest/reorder', array('order_id' => $order->getId()));
}
return $this->getUrl('sales/order/reorder', array('order_id' => $order->getId()));
diff --git a/app/code/Magento/Sales/Block/Order/Invoice.php b/app/code/Magento/Sales/Block/Order/Invoice.php
index c5a59b68d051b99f8c6a2967139c687712cdc295..0c26806d6abf7a39b7dc3b4046710370392b6b3d 100644
--- a/app/code/Magento/Sales/Block/Order/Invoice.php
+++ b/app/code/Magento/Sales/Block/Order/Invoice.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Sales\Block\Order;
+use Magento\Customer\Model\Context;
+
/**
* Sales order view block
*/
@@ -98,7 +100,7 @@ class Invoice extends \Magento\Sales\Block\Order\Invoice\Items
*/
public function getBackUrl()
{
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return $this->getUrl('*/*/history');
}
return $this->getUrl('*/*/form');
@@ -111,7 +113,7 @@ class Invoice extends \Magento\Sales\Block\Order\Invoice\Items
*/
public function getBackTitle()
{
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return __('Back to My Orders');
}
return __('View Another Order');
diff --git a/app/code/Magento/Sales/Block/Order/View.php b/app/code/Magento/Sales/Block/Order/View.php
index 047b5dd3cf3d66f8f0a0fd9281dda582b7324887..69eb6c7c28ff42d822649c19b69edb0a598c313f 100644
--- a/app/code/Magento/Sales/Block/Order/View.php
+++ b/app/code/Magento/Sales/Block/Order/View.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Sales\Block\Order;
+use Magento\Customer\Model\Context;
+
/**
* Sales order view block
*/
@@ -106,7 +108,7 @@ class View extends \Magento\Framework\View\Element\Template
*/
public function getBackUrl()
{
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return $this->getUrl('*/*/history');
}
return $this->getUrl('*/*/form');
@@ -119,7 +121,7 @@ class View extends \Magento\Framework\View\Element\Template
*/
public function getBackTitle()
{
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return __('Back to My Orders');
}
return __('View Another Order');
diff --git a/app/code/Magento/Sales/Block/Reorder/Sidebar.php b/app/code/Magento/Sales/Block/Reorder/Sidebar.php
index 59f5f8f969997ba426b0a32f62e3c973281d91b5..748232b4c8dfd56640f20ca901bc9d20c40c9166 100644
--- a/app/code/Magento/Sales/Block/Reorder/Sidebar.php
+++ b/app/code/Magento/Sales/Block/Reorder/Sidebar.php
@@ -23,6 +23,7 @@
*/
namespace Magento\Sales\Block\Reorder;
+use Magento\Customer\Model\Context;
use Magento\Framework\View\Block\IdentityInterface;
/**
@@ -64,9 +65,9 @@ class Sidebar extends \Magento\Framework\View\Element\Template implements Identi
protected $httpContext;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @param \Magento\Framework\View\Element\Template\Context $context
@@ -74,7 +75,7 @@ class Sidebar extends \Magento\Framework\View\Element\Template implements Identi
* @param \Magento\Sales\Model\Order\Config $orderConfig
* @param \Magento\Customer\Model\Session $customerSession
* @param \Magento\Framework\App\Http\Context $httpContext
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param array $data
*/
public function __construct(
@@ -83,14 +84,14 @@ class Sidebar extends \Magento\Framework\View\Element\Template implements Identi
\Magento\Sales\Model\Order\Config $orderConfig,
\Magento\Customer\Model\Session $customerSession,
\Magento\Framework\App\Http\Context $httpContext,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
array $data = array()
) {
$this->_orderCollectionFactory = $orderCollectionFactory;
$this->_orderConfig = $orderConfig;
$this->_customerSession = $customerSession;
$this->httpContext = $httpContext;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
parent::__construct($context, $data);
$this->_isScopePrivate = true;
}
@@ -103,7 +104,7 @@ class Sidebar extends \Magento\Framework\View\Element\Template implements Identi
protected function _construct()
{
parent::_construct();
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
$this->initOrders();
}
}
@@ -158,7 +159,11 @@ class Sidebar extends \Magento\Framework\View\Element\Template implements Identi
public function isItemAvailableForReorder(\Magento\Sales\Model\Order\Item $orderItem)
{
if ($orderItem->getProduct()) {
- return $this->stockItemService->getIsInStock($orderItem->getProduct()->getId());
+ $stockItem = $this->stockRegistry->getStockItem(
+ $orderItem->getProduct()->getId(),
+ $orderItem->getStore()->getWebsiteId()
+ );
+ return $stockItem->getIsInStock();
}
return false;
}
@@ -196,7 +201,7 @@ class Sidebar extends \Magento\Framework\View\Element\Template implements Identi
*/
protected function _toHtml()
{
- $isValid = $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH) || $this->getCustomerId();
+ $isValid = $this->httpContext->getValue(Context::CONTEXT_AUTH) || $this->getCustomerId();
return $isValid ? parent::_toHtml() : '';
}
diff --git a/app/code/Magento/Sales/Block/Widget/Guest/Form.php b/app/code/Magento/Sales/Block/Widget/Guest/Form.php
index 2749f1f23faef4cbb0fdc5db294bd5a7aadd8831..d38c096a144871994c1af55bd6b666fbaf625da6 100644
--- a/app/code/Magento/Sales/Block/Widget/Guest/Form.php
+++ b/app/code/Magento/Sales/Block/Widget/Guest/Form.php
@@ -27,6 +27,8 @@
*/
namespace Magento\Sales\Block\Widget\Guest;
+use Magento\Customer\Model\Context;
+
class Form extends \Magento\Framework\View\Element\Template implements \Magento\Widget\Block\BlockInterface
{
/**
@@ -56,7 +58,7 @@ class Form extends \Magento\Framework\View\Element\Template implements \Magento\
*/
public function isEnable()
{
- return !($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH));
+ return !($this->httpContext->getValue(Context::CONTEXT_AUTH));
}
/**
diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoader.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoader.php
index c7a9119037736a50f4d928d2d96d58463a82564f..c35d93ff830a2136224493581253aa044e726e3e 100644
--- a/app/code/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoader.php
+++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoader.php
@@ -82,9 +82,9 @@ class CreditmemoLoader extends Object
protected $registry;
/**
- * @var \Magento\CatalogInventory\Helper\Data
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface
*/
- protected $inventoryHelper;
+ protected $stockConfiguration;
/**
* @param \Magento\Sales\Model\Order\CreditmemoFactory $creditmemoFactory
@@ -95,7 +95,7 @@ class CreditmemoLoader extends Object
* @param \Magento\Backend\Model\Session $backendSession
* @param \Magento\Framework\Message\ManagerInterface $messageManager
* @param \Magento\Framework\Registry $registry
- * @param \Magento\CatalogInventory\Helper\Data $inventoryHelper
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param array $data
*/
public function __construct(
@@ -107,7 +107,7 @@ class CreditmemoLoader extends Object
\Magento\Backend\Model\Session $backendSession,
\Magento\Framework\Message\ManagerInterface $messageManager,
\Magento\Framework\Registry $registry,
- \Magento\CatalogInventory\Helper\Data $inventoryHelper,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
array $data = []
) {
$this->creditmemoFactory = $creditmemoFactory;
@@ -118,7 +118,7 @@ class CreditmemoLoader extends Object
$this->backendSession = $backendSession;
$this->messageManager = $messageManager;
$this->registry = $registry;
- $this->inventoryHelper = $inventoryHelper;
+ $this->stockConfiguration = $stockConfiguration;
parent::__construct($data);
}
@@ -241,7 +241,7 @@ class CreditmemoLoader extends Object
$creditmemoItem->setBackToStock(true);
} elseif (empty($savedData)) {
$creditmemoItem->setBackToStock(
- $this->inventoryHelper->isAutoReturnEnabled()
+ $this->stockConfiguration->isAutoReturnEnabled()
);
} else {
$creditmemoItem->setBackToStock(false);
diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/InvoiceLoader.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/InvoiceLoader.php
index c6f60699b0a030d2c69467c6cf42fe642ad1e9e3..628f771c7a635e6c0670babd4647eec5897576f2 100644
--- a/app/code/Magento/Sales/Controller/Adminhtml/Order/InvoiceLoader.php
+++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/InvoiceLoader.php
@@ -29,7 +29,7 @@ use Magento\Framework\App\RequestInterface;
class InvoiceLoader
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -59,12 +59,12 @@ class InvoiceLoader
protected $invoiceItems;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Registry $registry
* @param \Magento\Framework\Message\ManagerInterface $messageManager
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Registry $registry,
\Magento\Framework\Message\ManagerInterface $messageManager
) {
diff --git a/app/code/Magento/Sales/Controller/Order/Plugin/Authentication.php b/app/code/Magento/Sales/Controller/Order/Plugin/Authentication.php
index ed578392db20be61b3b882df3e27897799c463fc..24927310134c83470da9aac2082e355a2b7e899e 100644
--- a/app/code/Magento/Sales/Controller/Order/Plugin/Authentication.php
+++ b/app/code/Magento/Sales/Controller/Order/Plugin/Authentication.php
@@ -29,9 +29,9 @@ use Magento\Framework\App\RequestInterface;
class Authentication
{
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $customerHelper;
+ protected $customerUrl;
/**
* @var \Magento\Customer\Model\Session
@@ -39,14 +39,14 @@ class Authentication
protected $customerSession;
/**
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Url $customerUrl
* @param \Magento\Customer\Model\Session $customerSession
*/
public function __construct(
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Url $customerUrl,
\Magento\Customer\Model\Session $customerSession
) {
- $this->customerHelper = $customerHelper;
+ $this->customerUrl = $customerUrl;
$this->customerSession = $customerSession;
}
@@ -59,7 +59,7 @@ class Authentication
*/
public function beforeDispatch(\Magento\Framework\App\ActionInterface $subject, RequestInterface $request)
{
- $loginUrl = $this->customerHelper->getLoginUrl();
+ $loginUrl = $this->customerUrl->getLoginUrl();
if (!$this->customerSession->authenticate($subject, $loginUrl)) {
$subject->getActionFlag()->set('', $subject::FLAG_NO_DISPATCH, true);
diff --git a/app/code/Magento/Sales/Helper/Guest.php b/app/code/Magento/Sales/Helper/Guest.php
index a5f3820c28bb8d2b3bcc9cd51d08ed3f5caba890..96c84f622b11de6c4115328487170ed6a518381f 100644
--- a/app/code/Magento/Sales/Helper/Guest.php
+++ b/app/code/Magento/Sales/Helper/Guest.php
@@ -44,7 +44,7 @@ class Guest extends \Magento\Core\Helper\Data
protected $customerSession;
/**
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $cookieManager;
@@ -86,7 +86,7 @@ class Guest extends \Magento\Core\Helper\Data
* @param \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency
* @param \Magento\Framework\Registry $coreRegistry
* @param \Magento\Customer\Model\Session $customerSession
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
* @param \Magento\Framework\Message\ManagerInterface $messageManager
* @param \Magento\Sales\Model\OrderFactory $orderFactory
@@ -103,7 +103,7 @@ class Guest extends \Magento\Core\Helper\Data
\Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency,
\Magento\Framework\Registry $coreRegistry,
\Magento\Customer\Model\Session $customerSession,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory,
\Magento\Framework\Message\ManagerInterface $messageManager,
\Magento\Sales\Model\OrderFactory $orderFactory,
diff --git a/app/code/Magento/Sales/Model/AdminOrder/Create.php b/app/code/Magento/Sales/Model/AdminOrder/Create.php
index 897b51f3370ed28c888cbaaa0b69cbb2b2f54194..d1579ddecc072234d7a0aef5c2b6b94df363c18c 100644
--- a/app/code/Magento/Sales/Model/AdminOrder/Create.php
+++ b/app/code/Magento/Sales/Model/AdminOrder/Create.php
@@ -128,7 +128,7 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
protected $_salesConfig;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -172,11 +172,6 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
*/
protected $_customerBuilder;
- /**
- * @var \Magento\Customer\Helper\Data
- */
- protected $_customerHelper;
-
/**
* @var CustomerGroupServiceInterface
*/
@@ -188,9 +183,9 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
protected $_scopeConfig;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @var \Magento\Sales\Model\AdminOrder\EmailSender
@@ -208,7 +203,12 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
protected $objectFactory;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @var \Magento\Sales\Model\QuoteRepository
+ */
+ protected $quoteRepository;
+
+ /**
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Event\ManagerInterface $eventManager
* @param \Magento\Framework\Registry $coreRegistry
* @param \Magento\Sales\Model\Config $salesConfig
@@ -222,17 +222,17 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
* @param CustomerAddressBuilder $customerAddressBuilder
* @param \Magento\Customer\Model\Metadata\FormFactory $metadataFormFactory
* @param CustomerBuilder $customerBuilder
- * @param \Magento\Customer\Helper\Data $customerHelper
* @param CustomerGroupServiceInterface $customerGroupService
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
* @param EmailSender $emailSender
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param Item\Updater $quoteItemUpdater
* @param \Magento\Framework\Object\Factory $objectFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
* @param array $data
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Event\ManagerInterface $eventManager,
\Magento\Framework\Registry $coreRegistry,
\Magento\Sales\Model\Config $salesConfig,
@@ -246,13 +246,13 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
CustomerAddressBuilder $customerAddressBuilder,
\Magento\Customer\Model\Metadata\FormFactory $metadataFormFactory,
CustomerBuilder $customerBuilder,
- \Magento\Customer\Helper\Data $customerHelper,
CustomerGroupServiceInterface $customerGroupService,
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
\Magento\Sales\Model\AdminOrder\EmailSender $emailSender,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
\Magento\Sales\Model\Quote\Item\Updater $quoteItemUpdater,
\Magento\Framework\Object\Factory $objectFactory,
+ \Magento\Sales\Model\QuoteRepository $quoteRepository,
array $data = array()
) {
$this->_objectManager = $objectManager;
@@ -269,13 +269,13 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
$this->_customerAddressBuilder = $customerAddressBuilder;
$this->_metadataFormFactory = $metadataFormFactory;
$this->_customerBuilder = $customerBuilder;
- $this->_customerHelper = $customerHelper;
$this->_customerGroupService = $customerGroupService;
$this->_scopeConfig = $scopeConfig;
$this->emailSender = $emailSender;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
$this->quoteItemUpdater = $quoteItemUpdater;
$this->objectFactory = $objectFactory;
+ $this->quoteRepository = $quoteRepository;
parent::__construct($data);
}
@@ -358,7 +358,8 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
public function recollectCart()
{
if ($this->_needCollectCart === true) {
- $this->getCustomerCart()->collectTotals()->save();
+ $this->getCustomerCart()->collectTotals();
+ $this->quoteRepository->save($this->getCustomerCart());
}
$this->setRecollect(true);
return $this;
@@ -379,7 +380,7 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
$this->getQuote()->collectTotals();
}
- $this->getQuote()->save();
+ $this->quoteRepository->save($this->getQuote());
return $this;
}
@@ -508,7 +509,7 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
$this->collectRates();
}
- $quote->save();
+ $this->quoteRepository->save($quote);
return $this;
}
@@ -645,15 +646,17 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
return $this->_cart;
}
- $this->_cart = $this->_objectManager->create('Magento\Sales\Model\Quote');
+ $this->_cart = $this->quoteRepository->create();
$customerId = (int)$this->getSession()->getCustomerId();
if ($customerId) {
- $this->_cart->setStore($this->getSession()->getStore())->loadByCustomer($customerId);
- if (!$this->_cart->getId()) {
+ try {
+ $this->_cart = $this->quoteRepository->getForCustomer($customerId);
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+ $this->_cart->setStore($this->getSession()->getStore());
$customerData = $this->_customerAccountService->getCustomer($customerId);
$this->_cart->assignCustomer($customerData);
- $this->_cart->save();
+ $this->quoteRepository->save($this->_cart);
}
}
@@ -871,7 +874,8 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
}
}
if (isset($data['empty_customer_cart']) && (int)$data['empty_customer_cart'] == 1) {
- $this->getCustomerCart()->removeAllItems()->collectTotals()->save();
+ $this->getCustomerCart()->removeAllItems()->collectTotals();
+ $this->quoteRepository->save($this->getCustomerCart());
}
return $this;
}
@@ -893,7 +897,8 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode
$cart = $this->getCustomerCart();
if ($cart) {
$cart->removeItem($itemId);
- $cart->collectTotals()->save();
+ $cart->collectTotals();
+ $this->quoteRepository->save($cart);
}
break;
case 'wishlist':
diff --git a/app/code/Magento/Sales/Model/AdminOrder/Product/Quote/Initializer.php b/app/code/Magento/Sales/Model/AdminOrder/Product/Quote/Initializer.php
index 47253a45fc1f1a89be30cbdae96de534cfd8fb44..0d6b77949e5f346b9bc36ba91f80b8ba07952ab5 100644
--- a/app/code/Magento/Sales/Model/AdminOrder/Product/Quote/Initializer.php
+++ b/app/code/Magento/Sales/Model/AdminOrder/Product/Quote/Initializer.php
@@ -33,17 +33,17 @@ namespace Magento\Sales\Model\AdminOrder\Product\Quote;
class Initializer
{
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
*/
public function __construct(
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
) {
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
}
/**
@@ -57,9 +57,8 @@ class Initializer
\Magento\Catalog\Model\Product $product,
\Magento\Framework\Object $config
) {
- /** @var \Magento\CatalogInventory\Service\V1\Data\StockItem $stockItemDo */
- $stockItemDo = $this->stockItemService->getStockItem($product->getId());
- if ($stockItemDo->getStockId() && $stockItemDo->getIsQtyDecimal()) {
+ $stockItem = $this->stockRegistry->getStockItem($product->getId(), $quote->getStore()->getWebsiteId());
+ if ($stockItem->getIsQtyDecimal()) {
$product->setIsQtyDecimal(1);
} else {
$config->setQty((int)$config->getQty());
diff --git a/app/code/Magento/Sales/Model/Observer/Backend/CustomerQuote.php b/app/code/Magento/Sales/Model/Observer/Backend/CustomerQuote.php
index f61e3f627b6fb496e280f3696c6595fb334ce476..6dbea5c346e6a2cb5404acf0d4d6ed6052f597ce 100644
--- a/app/code/Magento/Sales/Model/Observer/Backend/CustomerQuote.php
+++ b/app/code/Magento/Sales/Model/Observer/Backend/CustomerQuote.php
@@ -38,23 +38,23 @@ class CustomerQuote
protected $_storeManager;
/**
- * @var \Magento\Sales\Model\QuoteFactory
+ * @var \Magento\Sales\Model\QuoteRepository
*/
- protected $_quoteFactory;
+ protected $quoteRepository;
/**
* @param \Magento\Framework\StoreManagerInterface $storeManager
* @param \Magento\Customer\Model\Config\Share $config
- * @param \Magento\Sales\Model\QuoteFactory $quoteFactory
+ * @param \Magento\Sales\Model\QuoteRepository $quoteRepository
*/
public function __construct(
\Magento\Framework\StoreManagerInterface $storeManager,
\Magento\Customer\Model\Config\Share $config,
- \Magento\Sales\Model\QuoteFactory $quoteFactory
+ \Magento\Sales\Model\QuoteRepository $quoteRepository
) {
$this->_storeManager = $storeManager;
$this->_config = $config;
- $this->_quoteFactory = $quoteFactory;
+ $this->quoteRepository = $quoteRepository;
}
/**
@@ -80,13 +80,14 @@ class CustomerQuote
) : $this->_storeManager->getWebsites();
foreach ($websites as $website) {
- $quote = $this->_quoteFactory->create();
- $quote->setWebsite($website);
- $quote->loadByCustomer($customerDataObject->getId());
- if ($quote->getId()) {
+ try {
+ $quote = $this->quoteRepository->getForCustomer($customerDataObject->getId());
+ $quote->setWebsite($website);
$quote->setCustomerGroupId($customerDataObject->getGroupId());
$quote->collectTotals();
- $quote->save();
+ $this->quoteRepository->save($quote);
+ } catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
+
}
}
}
diff --git a/app/code/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotals.php b/app/code/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotals.php
index f867d7fdce95a8f3b2113fdd40bbd549e2d42a91..0d07b726226f3ed3b8e3231397ddf1a3023db767 100644
--- a/app/code/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotals.php
+++ b/app/code/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotals.php
@@ -31,9 +31,9 @@ class CollectTotals
protected $customerAddressHelper;
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Vat
*/
- protected $customerHelper;
+ protected $customerVat;
/**
* @var VatValidator
@@ -49,17 +49,17 @@ class CollectTotals
* Initialize dependencies.
*
* @param \Magento\Customer\Helper\Address $customerAddressHelper
- * @param \Magento\Customer\Helper\Data $customerHelper
+ * @param \Magento\Customer\Model\Vat $customerVat
* @param VatValidator $vatValidator
* @param \Magento\Customer\Service\V1\Data\CustomerBuilder $customerBuilder
*/
public function __construct(
\Magento\Customer\Helper\Address $customerAddressHelper,
- \Magento\Customer\Helper\Data $customerHelper,
+ \Magento\Customer\Model\Vat $customerVat,
VatValidator $vatValidator,
\Magento\Customer\Service\V1\Data\CustomerBuilder $customerBuilder
) {
- $this->customerHelper = $customerHelper;
+ $this->customerVat = $customerVat;
$this->customerAddressHelper = $customerAddressHelper;
$this->vatValidator = $vatValidator;
$this->customerBuilder = $customerBuilder;
@@ -90,13 +90,13 @@ class CollectTotals
$customerCountryCode = $quoteAddress->getCountryId();
$customerVatNumber = $quoteAddress->getVatId();
$groupId = null;
- if (empty($customerVatNumber) || false == $this->customerHelper->isCountryInEU($customerCountryCode)) {
- $groupId = $customerData->getId() ? $this->customerHelper->getDefaultCustomerGroupId(
+ if (empty($customerVatNumber) || false == $this->customerVat->isCountryInEU($customerCountryCode)) {
+ $groupId = $customerData->getId() ? $this->customerVat->getDefaultCustomerGroupId(
$storeId
) : \Magento\Customer\Service\V1\CustomerGroupServiceInterface::NOT_LOGGED_IN_ID;
} else {
// Magento always has to emulate group even if customer uses default billing/shipping address
- $groupId = $this->customerHelper->getCustomerGroupIdBasedOnVatNumber(
+ $groupId = $this->customerVat->getCustomerGroupIdBasedOnVatNumber(
$customerCountryCode,
$this->vatValidator->validate($quoteAddress, $storeId),
$storeId
diff --git a/app/code/Magento/Sales/Model/Observer/Frontend/Quote/Address/VatValidator.php b/app/code/Magento/Sales/Model/Observer/Frontend/Quote/Address/VatValidator.php
index 1253d966e40b2b1800983311da363a9b34650bb1..53616df5e23738562e675cb10a15518fd981262a 100644
--- a/app/code/Magento/Sales/Model/Observer/Frontend/Quote/Address/VatValidator.php
+++ b/app/code/Magento/Sales/Model/Observer/Frontend/Quote/Address/VatValidator.php
@@ -33,21 +33,21 @@ class VatValidator
protected $customerAddress;
/**
- * Customer data
+ * Customer VAT
*
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Vat
*/
- protected $customerData;
+ protected $customerVat;
/**
* @param \Magento\Customer\Helper\Address $customerAddress
- * @param \Magento\Customer\Helper\Data $customerData
+ * @param \Magento\Customer\Model\Vat $customerVat
*/
public function __construct(
\Magento\Customer\Helper\Address $customerAddress,
- \Magento\Customer\Helper\Data $customerData
+ \Magento\Customer\Model\Vat $customerVat
) {
- $this->customerData = $customerData;
+ $this->customerVat = $customerVat;
$this->customerAddress = $customerAddress;
}
@@ -63,8 +63,8 @@ class VatValidator
$customerCountryCode = $quoteAddress->getCountryId();
$customerVatNumber = $quoteAddress->getVatId();
- $merchantCountryCode = $this->customerData->getMerchantCountryCode();
- $merchantVatNumber = $this->customerData->getMerchantVatNumber();
+ $merchantCountryCode = $this->customerVat->getMerchantCountryCode();
+ $merchantVatNumber = $this->customerVat->getMerchantVatNumber();
$validationResult = null;
if ($this->customerAddress->hasValidateOnEachTransaction(
@@ -74,7 +74,7 @@ class VatValidator
$customerVatNumber != $quoteAddress->getValidatedVatNumber()
) {
// Send request to gateway
- $validationResult = $this->customerData->checkVatNumber(
+ $validationResult = $this->customerVat->checkVatNumber(
$customerCountryCode,
$customerVatNumber,
$merchantVatNumber !== '' ? $merchantCountryCode : '',
diff --git a/app/code/Magento/Sales/Model/Order/Customer/Builder.php b/app/code/Magento/Sales/Model/Order/Customer/Builder.php
index ce30c10987975640f0e9e7214a2ba7b1fa904d86..be845ad715f10b68876febe75e55b73c19dfeca5 100644
--- a/app/code/Magento/Sales/Model/Order/Customer/Builder.php
+++ b/app/code/Magento/Sales/Model/Order/Customer/Builder.php
@@ -30,7 +30,7 @@ namespace Magento\Sales\Model\Order\Customer;
class Builder
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -105,10 +105,10 @@ class Builder
protected $customerTaxvat;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager
+ \Magento\Framework\ObjectManagerInterface $objectManager
) {
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Sales/Model/Order/Item.php b/app/code/Magento/Sales/Model/Order/Item.php
index 5a75878feaeee2662bfd2b35116659931cb5d9d3..4127fa60882790c105a0716597df98d1855d49a8 100644
--- a/app/code/Magento/Sales/Model/Order/Item.php
+++ b/app/code/Magento/Sales/Model/Order/Item.php
@@ -259,6 +259,11 @@ class Item extends \Magento\Framework\Model\AbstractModel
*/
protected $_productFactory;
+ /**
+ * @var \Magento\Framework\StoreManagerInterface
+ */
+ protected $_storeManager;
+
/**
* @param \Magento\Framework\Model\Context $context
* @param \Magento\Framework\Registry $registry
@@ -266,6 +271,7 @@ class Item extends \Magento\Framework\Model\AbstractModel
* @param \Magento\Catalog\Model\ProductFactory $productFactory
* @param \Magento\Framework\Model\Resource\AbstractResource $resource
* @param \Magento\Framework\Data\Collection\Db $resourceCollection
+ * @param \Magento\Framework\StoreManagerInterface $storeManager
* @param array $data
*/
public function __construct(
@@ -273,12 +279,14 @@ class Item extends \Magento\Framework\Model\AbstractModel
\Magento\Framework\Registry $registry,
\Magento\Sales\Model\OrderFactory $orderFactory,
\Magento\Catalog\Model\ProductFactory $productFactory,
+ \Magento\Framework\StoreManagerInterface $storeManager,
\Magento\Framework\Model\Resource\AbstractResource $resource = null,
\Magento\Framework\Data\Collection\Db $resourceCollection = null,
array $data = array()
) {
$this->_orderFactory = $orderFactory;
$this->_productFactory = $productFactory;
+ $this->_storeManager = $storeManager;
parent::__construct($context, $registry, $resource, $resourceCollection, $data);
}
@@ -831,4 +839,18 @@ class Item extends \Magento\Framework\Model\AbstractModel
}
return $this->getData('product');
}
+
+ /**
+ * Retrieve store model instance
+ *
+ * @return \Magento\Store\Model\Store
+ */
+ public function getStore()
+ {
+ $storeId = $this->getStoreId();
+ if ($storeId) {
+ return $this->_storeManager->getStore($storeId);
+ }
+ return $this->_storeManager->getStore();
+ }
}
diff --git a/app/code/Magento/Sales/Model/Order/Pdf/ItemsFactory.php b/app/code/Magento/Sales/Model/Order/Pdf/ItemsFactory.php
index cb6072793dc4dd445a113d40545759950d70ac4a..0df5a76a89a8f17a037f0472c3aa03d47b3d3d8f 100644
--- a/app/code/Magento/Sales/Model/Order/Pdf/ItemsFactory.php
+++ b/app/code/Magento/Sales/Model/Order/Pdf/ItemsFactory.php
@@ -31,16 +31,16 @@ class ItemsFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Sales/Model/Order/Pdf/Total/Factory.php b/app/code/Magento/Sales/Model/Order/Pdf/Total/Factory.php
index 9fd1ab19e7b43fafaf374b480538940e36761cf6..56b99385e7da5bd84d7f8a56a1d06b23fb3dd21c 100644
--- a/app/code/Magento/Sales/Model/Order/Pdf/Total/Factory.php
+++ b/app/code/Magento/Sales/Model/Order/Pdf/Total/Factory.php
@@ -26,7 +26,7 @@ namespace Magento\Sales\Model\Order\Pdf\Total;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -38,9 +38,9 @@ class Factory
protected $_defaultTotalModel = 'Magento\Sales\Model\Order\Pdf\Total\DefaultTotal';
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Sales/Model/Order/TotalFactory.php b/app/code/Magento/Sales/Model/Order/TotalFactory.php
index e1917a8e89874f9b200e92dbd368c35bee396046..b88707a5c129c000fcca78df561e6c6c3e3e2385 100644
--- a/app/code/Magento/Sales/Model/Order/TotalFactory.php
+++ b/app/code/Magento/Sales/Model/Order/TotalFactory.php
@@ -31,16 +31,16 @@ class TotalFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Sales/Model/Quote.php b/app/code/Magento/Sales/Model/Quote.php
index aea40921e5fd9852bff3ee42b2286ae421c765a5..1fbc0e0ff3d92ac6d68b4144cc01b634bbb77e15 100644
--- a/app/code/Magento/Sales/Model/Quote.php
+++ b/app/code/Magento/Sales/Model/Quote.php
@@ -133,6 +133,8 @@ use Magento\Customer\Service\V1\CustomerGroupServiceInterface;
* @method Quote setGiftMessageId(int $value)
* @method bool|null getIsPersistent()
* @method Quote setIsPersistent(bool $value)
+ * @method Quote setSharedStoreIds(array $values)
+ * @method Quote setWebsite($value)
*/
class Quote extends \Magento\Framework\Model\AbstractModel
{
@@ -305,9 +307,9 @@ class Quote extends \Magento\Framework\Model\AbstractModel
protected $_addressConverter;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @var \Magento\Sales\Model\Quote\Item\Processor
@@ -341,7 +343,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel
* @param \Magento\Customer\Model\Converter $converter
* @param \Magento\Customer\Service\V1\CustomerAddressServiceInterface $addressService
* @param \Magento\Customer\Model\Address\Converter $addressConverter
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param Quote\Item\Processor $itemProcessor
* @param \Magento\Framework\Object\Factory $objectFactory
* @param \Magento\Framework\Model\Resource\AbstractResource $resource
@@ -370,7 +372,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel
\Magento\Customer\Model\Converter $converter,
\Magento\Customer\Service\V1\CustomerAddressServiceInterface $addressService,
\Magento\Customer\Model\Address\Converter $addressConverter,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
\Magento\Sales\Model\Quote\Item\Processor $itemProcessor,
\Magento\Framework\Object\Factory $objectFactory,
\Magento\Framework\Model\Resource\AbstractResource $resource = null,
@@ -396,7 +398,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel
$this->_converter = $converter;
$this->_addressService = $addressService;
$this->_addressConverter = $addressConverter;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
$this->itemProcessor = $itemProcessor;
$this->objectFactory = $objectFactory;
parent::__construct($context, $registry, $resource, $resourceCollection, $data);
@@ -1146,9 +1148,8 @@ class Quote extends \Magento\Framework\Model\AbstractModel
public function hasItemsWithDecimalQty()
{
foreach ($this->getAllItems() as $item) {
- /** @var \Magento\CatalogInventory\Service\V1\Data\StockItem $stockItemDo */
- $stockItemDo = $this->stockItemService->getStockItem($item->getProduct()->getId());
- if ($stockItemDo->getStockId() && $stockItemDo->getIsQtyDecimal()) {
+ $stockItemDo = $this->stockRegistry->getStockItem($item->getProduct()->getId(), $item->getStore()->getWebsiteId());
+ if ($stockItemDo->getId() && $stockItemDo->getIsQtyDecimal()) {
return true;
}
}
@@ -1363,7 +1364,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel
if (!$parentItem) {
$parentItem = $item;
}
- if ($parentItem && $candidate->getParentProductId()) {
+ if ($parentItem && $candidate->getParentProductId() && !$item->getParentItem()) {
$item->setParentItem($parentItem);
}
diff --git a/app/code/Magento/Sales/Model/Quote/Address/RateCollectorInterfaceFactory.php b/app/code/Magento/Sales/Model/Quote/Address/RateCollectorInterfaceFactory.php
index 055ca6f921d997fdaa88adce561d149b8a475285..a9c1737dcdc04bb9b5669ba8c85aec6bb8d6d883 100644
--- a/app/code/Magento/Sales/Model/Quote/Address/RateCollectorInterfaceFactory.php
+++ b/app/code/Magento/Sales/Model/Quote/Address/RateCollectorInterfaceFactory.php
@@ -31,7 +31,7 @@ class RateCollectorInterfaceFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -45,11 +45,11 @@ class RateCollectorInterfaceFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Sales\Model\Quote\Address\RateCollectorInterface'
) {
$this->_objectManager = $objectManager;
diff --git a/app/code/Magento/Sales/Model/Quote/Address/TotalFactory.php b/app/code/Magento/Sales/Model/Quote/Address/TotalFactory.php
index 20a1f7dac5e99dc42d13efce38383dfca7a91056..d8849bc14eacb8b7ad4e3564885ab128f17c398e 100644
--- a/app/code/Magento/Sales/Model/Quote/Address/TotalFactory.php
+++ b/app/code/Magento/Sales/Model/Quote/Address/TotalFactory.php
@@ -32,16 +32,16 @@ class TotalFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
/**
* Quote address factory constructor
*
- * @param \Magento\Framework\ObjectManager $objManager
+ * @param \Magento\Framework\ObjectManagerInterface $objManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objManager)
{
$this->_objectManager = $objManager;
}
diff --git a/app/code/Magento/Sales/Model/Quote/Item.php b/app/code/Magento/Sales/Model/Quote/Item.php
index ce0c5cc93281104c35832fbb57abdef1b06ea232..1ace70c83948a83cb8da9d383c5db79b71d0d27d 100644
--- a/app/code/Magento/Sales/Model/Quote/Item.php
+++ b/app/code/Magento/Sales/Model/Quote/Item.php
@@ -191,9 +191,9 @@ class Item extends \Magento\Sales\Model\Quote\Item\AbstractItem
protected $_compareHelper;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @param \Magento\Framework\Model\Context $context
@@ -204,7 +204,7 @@ class Item extends \Magento\Sales\Model\Quote\Item\AbstractItem
* @param \Magento\Framework\Locale\FormatInterface $localeFormat
* @param Item\OptionFactory $itemOptionFactory
* @param \Magento\Sales\Helper\Quote\Item\Compare $compareHelper
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param \Magento\Framework\Model\Resource\AbstractResource $resource
* @param \Magento\Framework\Data\Collection\Db $resourceCollection
* @param array $data
@@ -220,7 +220,7 @@ class Item extends \Magento\Sales\Model\Quote\Item\AbstractItem
\Magento\Framework\Locale\FormatInterface $localeFormat,
\Magento\Sales\Model\Quote\Item\OptionFactory $itemOptionFactory,
\Magento\Sales\Helper\Quote\Item\Compare $compareHelper,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
\Magento\Framework\Model\Resource\AbstractResource $resource = null,
\Magento\Framework\Data\Collection\Db $resourceCollection = null,
array $data = array()
@@ -229,7 +229,7 @@ class Item extends \Magento\Sales\Model\Quote\Item\AbstractItem
$this->_localeFormat = $localeFormat;
$this->_itemOptionFactory = $itemOptionFactory;
$this->_compareHelper = $compareHelper;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
parent::__construct(
$context,
$registry,
@@ -358,6 +358,7 @@ class Item extends \Magento\Sales\Model\Quote\Item\AbstractItem
if ($this->getQuote() && $this->getQuote()->getIgnoreOldQty()) {
return $this;
}
+
if ($this->getUseOldQty()) {
$this->setData('qty', $oldQty);
}
@@ -434,11 +435,8 @@ class Item extends \Magento\Sales\Model\Quote\Item\AbstractItem
->setTaxClassId($product->getTaxClassId())
->setBaseCost($product->getCost());
- /** @var \Magento\CatalogInventory\Service\V1\Data\StockItem $stockItemDo */
- $stockItemDo = $this->stockItemService->getStockItem($product->getId());
- if ($stockItemDo->getStockId()) {
- $this->setIsQtyDecimal($stockItemDo->getIsQtyDecimal());
- }
+ $stockItem = $this->stockRegistry->getStockItem($product->getId(), $product->getStore()->getWebsiteId());
+ $this->setIsQtyDecimal($stockItem->getIsQtyDecimal());
$this->_eventManager->dispatch(
'sales_quote_item_set_product',
diff --git a/app/code/Magento/Sales/Model/QuoteRepository.php b/app/code/Magento/Sales/Model/QuoteRepository.php
index 7783f27f6001d161f883b31267cde356abd11d22..e9ce5dff36c84b20ee0ad6ca916688b86e0985b4 100644
--- a/app/code/Magento/Sales/Model/QuoteRepository.php
+++ b/app/code/Magento/Sales/Model/QuoteRepository.php
@@ -24,54 +24,149 @@
namespace Magento\Sales\Model;
use \Magento\Framework\Exception\NoSuchEntityException;
+use Magento\Framework\StoreManagerInterface;
class QuoteRepository
{
/**
- * @var \Magento\Sales\Model\QuoteFactory
+ * @var Quote[]
+ */
+ protected $quotesById = [];
+
+ /**
+ * @var Quote[]
+ */
+ protected $quotesByCustomerId = [];
+
+ /**
+ * @var QuoteFactory
*/
protected $quoteFactory;
/**
- * @var \Magento\Framework\StoreManagerInterface
+ * @var StoreManagerInterface
*/
protected $storeManager;
/**
* @param QuoteFactory $quoteFactory
- * @param \Magento\Framework\StoreManagerInterface $storeManager
+ * @param StoreManagerInterface $storeManager
*/
public function __construct(
- \Magento\Sales\Model\QuoteFactory $quoteFactory,
- \Magento\Framework\StoreManagerInterface $storeManager
+ QuoteFactory $quoteFactory,
+ StoreManagerInterface $storeManager
) {
$this->quoteFactory = $quoteFactory;
$this->storeManager = $storeManager;
}
+ /**
+ * Create new quote
+ *
+ * @param array $data
+ * @return Quote
+ */
+ public function create(array $data = [])
+ {
+ return $this->quoteFactory->create($data);
+ }
+
/**
* Get quote by id
*
* @param int $cartId
+ * @param int[] $sharedStoreIds
+ * @throws NoSuchEntityException
* @return Quote
- * @throws \Magento\Framework\Exception\NoSuchEntityException
*/
- public function get($cartId)
+ public function get($cartId, array $sharedStoreIds = [])
{
- return $this->loadQuote('load', 'cartId', $cartId);
+ if (!isset($this->quotesById[$cartId])) {
+ $quote = $this->loadQuote('load', 'cartId', $cartId, $sharedStoreIds);
+ $this->quotesById[$cartId] = $quote;
+ $this->quotesByCustomerId[$quote->getCustomerId()] = $quote;
+ }
+ return $this->quotesById[$cartId];
}
-
/**
* Get quote by customer Id
*
* @param int $customerId
+ * @param int[] $sharedStoreIds
* @return Quote
- * @throws \Magento\Framework\Exception\NoSuchEntityException
+ * @throws NoSuchEntityException
*/
- public function getForCustomer($customerId)
+ public function getForCustomer($customerId, array $sharedStoreIds = [])
{
- return $this->loadQuote('loadByCustomer', 'customerId', $customerId);
+ if (!isset($this->quotesByCustomerId[$customerId])) {
+ $quote = $this->loadQuote('loadByCustomer', 'customerId', $customerId, $sharedStoreIds);
+ $this->quotesById[$quote->getId()] = $quote;
+ $this->quotesByCustomerId[$customerId] = $quote;
+ }
+ return $this->quotesByCustomerId[$customerId];
+ }
+
+ /**
+ * Get active quote by id
+ *
+ * @param int $cartId
+ * @param int[] $sharedStoreIds
+ * @return Quote
+ * @throws NoSuchEntityException
+ */
+ public function getActive($cartId, array $sharedStoreIds = [])
+ {
+ $quote = $this->get($cartId, $sharedStoreIds);
+ if (!$quote->getIsActive()) {
+ throw NoSuchEntityException::singleField('cartId', $cartId);
+ }
+ return $quote;
+ }
+
+ /**
+ * Get active quote by customer Id
+ *
+ * @param int $customerId
+ * @param int[] $sharedStoreIds
+ * @return Quote
+ * @throws NoSuchEntityException
+ */
+ public function getActiveForCustomer($customerId, array $sharedStoreIds = [])
+ {
+ $quote = $this->getForCustomer($customerId, $sharedStoreIds);
+ if (!$quote->getIsActive()) {
+ throw NoSuchEntityException::singleField('customerId', $customerId);
+ }
+ return $quote;
+ }
+
+ /**
+ * Save quote
+ *
+ * @param Quote $quote
+ * @return void
+ */
+ public function save(Quote $quote)
+ {
+ $quote->save();
+ unset($this->quotesById[$quote->getId()]);
+ unset($this->quotesByCustomerId[$quote->getCustomerId()]);
+ }
+
+ /**
+ * Delete quote
+ *
+ * @param Quote $quote
+ * @return void
+ */
+ public function delete(Quote $quote)
+ {
+ $quoteId = $quote->getId();
+ $customerId = $quote->getCustomerId();
+ $quote->delete();
+ unset($this->quotesById[$quoteId]);
+ unset($this->quotesByCustomerId[$customerId]);
}
/**
@@ -80,14 +175,19 @@ class QuoteRepository
* @param string $loadMethod
* @param string $loadField
* @param int $identifier
+ * @param int[] $sharedStoreIds
+ * @throws NoSuchEntityException
* @return Quote
- * @throws \Magento\Framework\Exception\NoSuchEntityException
*/
- protected function loadQuote($loadMethod, $loadField, $identifier)
+ protected function loadQuote($loadMethod, $loadField, $identifier, array $sharedStoreIds = [])
{
+ /** @var Quote $quote */
$quote = $this->quoteFactory->create();
+ if ($sharedStoreIds) {
+ $quote->setSharedStoreIds($sharedStoreIds);
+ }
$quote->setStoreId($this->storeManager->getStore()->getId())->$loadMethod($identifier);
- if (!$quote->getId() || !$quote->getIsActive()) {
+ if (!$quote->getId()) {
throw NoSuchEntityException::singleField($loadField, $identifier);
}
return $quote;
diff --git a/app/code/Magento/Sales/Model/QuoteRepository/Plugin/Authorization.php b/app/code/Magento/Sales/Model/QuoteRepository/Plugin/Authorization.php
index 75912f1d9cbe3297c2a4a5dea7e15532f559e461..4d0c09ccc06b79ed0211e48717b7ddeda0d0cabe 100644
--- a/app/code/Magento/Sales/Model/QuoteRepository/Plugin/Authorization.php
+++ b/app/code/Magento/Sales/Model/QuoteRepository/Plugin/Authorization.php
@@ -51,7 +51,7 @@ class Authorization
* @return \Magento\Sales\Model\Quote
* @throws \Magento\Framework\Exception\NoSuchEntityException
*/
- public function afterGet(
+ public function afterGetActive(
\Magento\Sales\Model\QuoteRepository $subject,
\Magento\Sales\Model\Quote $quote
) {
@@ -69,7 +69,7 @@ class Authorization
* @return \Magento\Sales\Model\Quote
* @throws \Magento\Framework\Exception\NoSuchEntityException
*/
- public function afterGetForCustomer(
+ public function afterGetActiveForCustomer(
\Magento\Sales\Model\QuoteRepository $subject,
\Magento\Sales\Model\Quote $quote
) {
diff --git a/app/code/Magento/Sales/Model/Resource/Order/Collection/Factory.php b/app/code/Magento/Sales/Model/Resource/Order/Collection/Factory.php
index c6133da6cc7d47496ae2a8bbad5b1300508717e2..34c76d7a68df9477f8543385acd9ab9165bcd5a1 100644
--- a/app/code/Magento/Sales/Model/Resource/Order/Collection/Factory.php
+++ b/app/code/Magento/Sales/Model/Resource/Order/Collection/Factory.php
@@ -26,14 +26,14 @@ namespace Magento\Sales\Model\Resource\Order\Collection;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Sales/Model/Rss/OrderStatus.php b/app/code/Magento/Sales/Model/Rss/OrderStatus.php
index e42181069f4a1a82525560b16e80c829c4ff4a94..1365c0e7c57804c6303d2cf4b23866cca871453b 100644
--- a/app/code/Magento/Sales/Model/Rss/OrderStatus.php
+++ b/app/code/Magento/Sales/Model/Rss/OrderStatus.php
@@ -49,7 +49,7 @@ class OrderStatus implements DataProviderInterface
protected $orderResourceFactory;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -74,7 +74,7 @@ class OrderStatus implements DataProviderInterface
protected $orderFactory;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\UrlInterface $urlBuilder
* @param \Magento\Framework\App\RequestInterface $request
* @param \Magento\Sales\Model\Resource\Order\Rss\OrderStatusFactory $orderResourceFactory
@@ -83,7 +83,7 @@ class OrderStatus implements DataProviderInterface
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\UrlInterface $urlBuilder,
\Magento\Framework\App\RequestInterface $request,
\Magento\Sales\Model\Resource\Order\Rss\OrderStatusFactory $orderResourceFactory,
diff --git a/app/code/Magento/Sales/Model/Status/ListFactory.php b/app/code/Magento/Sales/Model/Status/ListFactory.php
index 11d48292fd7de3e0754d20aed0061f33636d40e6..97e16afe462d146afbc17209e8c887980b5a88b0 100644
--- a/app/code/Magento/Sales/Model/Status/ListFactory.php
+++ b/app/code/Magento/Sales/Model/Status/ListFactory.php
@@ -26,14 +26,14 @@ namespace Magento\Sales\Model\Status;
class ListFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Sales/composer.json b/app/code/Magento/Sales/composer.json
index cd8ebd2b68baaecaa543bf1c6c0abbd6a8eb13ce..bb8b7be84d6fd72feb94fbee81fa7ea91d14b9d4 100644
--- a/app/code/Magento/Sales/composer.json
+++ b/app/code/Magento/Sales/composer.json
@@ -3,31 +3,31 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-authorization": "0.1.0-alpha104",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-sales-rule": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-widget": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-gift-message": "0.1.0-alpha104",
- "magento/module-reports": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/module-wishlist": "0.1.0-alpha104",
- "magento/module-email": "0.1.0-alpha104",
- "magento/module-shipping": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-authorization": "0.1.0-alpha105",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-sales-rule": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-widget": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-gift-message": "0.1.0-alpha105",
+ "magento/module-reports": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/module-wishlist": "0.1.0-alpha105",
+ "magento/module-email": "0.1.0-alpha105",
+ "magento/module-shipping": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/SalesRule/Block/Rss/Discounts.php b/app/code/Magento/SalesRule/Block/Rss/Discounts.php
index cd661947b4b23311aa3b5719c0d927761f1684eb..063ca2a5d153778e4e2c6d7b9af2aa728339b86b 100644
--- a/app/code/Magento/SalesRule/Block/Rss/Discounts.php
+++ b/app/code/Magento/SalesRule/Block/Rss/Discounts.php
@@ -23,6 +23,7 @@
*/
namespace Magento\SalesRule\Block\Rss;
+use Magento\Customer\Model\Context;
use Magento\Framework\App\Rss\DataProviderInterface;
/**
@@ -136,7 +137,7 @@ class Discounts extends \Magento\Framework\View\Element\AbstractBlock implements
{
$customerGroupId = (int) $this->getRequest()->getParam('cid');
if ($customerGroupId == null) {
- $customerGroupId = $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_GROUP);
+ $customerGroupId = $this->httpContext->getValue(Context::CONTEXT_GROUP);
}
return $customerGroupId;
}
diff --git a/app/code/Magento/SalesRule/Model/Rule/Action/Discount/CalculatorFactory.php b/app/code/Magento/SalesRule/Model/Rule/Action/Discount/CalculatorFactory.php
index f2e0965c32298a9f737927ab1c9ec1d89b04ed36..43bf0e1e6cd5d4a4a6c09d84a499e4e88d6a8e3a 100644
--- a/app/code/Magento/SalesRule/Model/Rule/Action/Discount/CalculatorFactory.php
+++ b/app/code/Magento/SalesRule/Model/Rule/Action/Discount/CalculatorFactory.php
@@ -28,7 +28,7 @@ class CalculatorFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
@@ -45,10 +45,10 @@ class CalculatorFactory
);
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $discountRules
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, array $discountRules = array())
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, array $discountRules = array())
{
$this->classByType = array_merge($this->classByType, $discountRules);
$this->_objectManager = $objectManager;
diff --git a/app/code/Magento/SalesRule/composer.json b/app/code/Magento/SalesRule/composer.json
index cf6eda03156a8a7ca7c53866ca0fdef7b83f3f6d..9179cf982c23cd9e1288c77c4aefbb881c83f41c 100644
--- a/app/code/Magento/SalesRule/composer.json
+++ b/app/code/Magento/SalesRule/composer.json
@@ -3,26 +3,26 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-rule": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-shipping": "0.1.0-alpha104",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/module-reports": "0.1.0-alpha104",
- "magento/module-catalog-rule": "0.1.0-alpha104",
- "magento/module-widget": "0.1.0-alpha104",
- "magento/module-cron": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-rule": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-shipping": "0.1.0-alpha105",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/module-reports": "0.1.0-alpha105",
+ "magento/module-catalog-rule": "0.1.0-alpha105",
+ "magento/module-widget": "0.1.0-alpha105",
+ "magento/module-cron": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Search/Model/AdapterFactory.php b/app/code/Magento/Search/Model/AdapterFactory.php
index 6570702ecebdba31ebb916e9f98b4d8d2d944033..77fb72bf511585baea1cca77cccd8debcc5bbb42 100644
--- a/app/code/Magento/Search/Model/AdapterFactory.php
+++ b/app/code/Magento/Search/Model/AdapterFactory.php
@@ -35,7 +35,7 @@ class AdapterFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -52,13 +52,13 @@ class AdapterFactory
protected $scope;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
* @param string $path
* @param string $scopeType
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
$path,
$scopeType
diff --git a/app/code/Magento/Search/Model/QueryFactory.php b/app/code/Magento/Search/Model/QueryFactory.php
index 0ef499cdc5740d9ca43f063eaff00efc0a633ffb..1f7005398b9a6f46ba705147358d132d577a3db0 100644
--- a/app/code/Magento/Search/Model/QueryFactory.php
+++ b/app/code/Magento/Search/Model/QueryFactory.php
@@ -25,7 +25,7 @@ namespace Magento\Search\Model;
use Magento\Framework\App\Config\ScopeConfigInterface;
use Magento\Framework\App\Helper\Context;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\Stdlib\String as StdlibString;
use Magento\Store\Model\ScopeInterface;
@@ -47,7 +47,7 @@ class QueryFactory implements QueryFactoryInterface
private $query;
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
@@ -63,13 +63,13 @@ class QueryFactory implements QueryFactoryInterface
/**
* @param Context $context
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param StdlibString $string
* @param ScopeConfigInterface $scopeConfig
*/
public function __construct(
Context $context,
- ObjectManager $objectManager,
+ ObjectManagerInterface $objectManager,
StdlibString $string,
ScopeConfigInterface $scopeConfig
) {
diff --git a/app/code/Magento/Search/Model/SearchCollectionFactory.php b/app/code/Magento/Search/Model/SearchCollectionFactory.php
index e096637c7c074a83050528789d2612d89dc8696a..7f5231ad9dbbc7dc418444d8aee6554f40ded343 100644
--- a/app/code/Magento/Search/Model/SearchCollectionFactory.php
+++ b/app/code/Magento/Search/Model/SearchCollectionFactory.php
@@ -29,7 +29,7 @@ class SearchCollectionFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -43,11 +43,11 @@ class SearchCollectionFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Search\Model\SearchCollectionInterface'
) {
$this->_objectManager = $objectManager;
diff --git a/app/code/Magento/Search/composer.json b/app/code/Magento/Search/composer.json
index 78765ded878fb240cfc8ce07ac69a9c5e20d58c2..25fbf96da9573390e8d0632e0b648bd4c979941e 100644
--- a/app/code/Magento/Search/composer.json
+++ b/app/code/Magento/Search/composer.json
@@ -3,13 +3,13 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/framework": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-store": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-store": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Sendfriend/Block/Send.php b/app/code/Magento/Sendfriend/Block/Send.php
index 6d80634b6f3d234d2c73a5130e88851c53c93e01..20073c4eeb4cdad3891a2d5a490aa64ee54882af 100644
--- a/app/code/Magento/Sendfriend/Block/Send.php
+++ b/app/code/Magento/Sendfriend/Block/Send.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Sendfriend\Block;
+use Magento\Customer\Model\Context;
+
/**
* Email to a Friend Block
*
@@ -101,7 +103,7 @@ class Send extends \Magento\Framework\View\Element\Template
/* @var $session \Magento\Customer\Model\Session */
$session = $this->_customerSession;
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return $this->_customerViewHelper->getCustomerName(
$session->getCustomerDataObject()
);
@@ -125,7 +127,7 @@ class Send extends \Magento\Framework\View\Element\Template
/* @var $session \Magento\Customer\Model\Session */
$session = $this->_customerSession;
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return $session->getCustomerDataObject()->getEmail();
}
diff --git a/app/code/Magento/Sendfriend/Model/Sendfriend.php b/app/code/Magento/Sendfriend/Model/Sendfriend.php
index 66476755feb7f3ba7e7cff8183ea759070c6b117..0a0972c3c0b5745ef7d7449ba478df7ee6c72052 100644
--- a/app/code/Magento/Sendfriend/Model/Sendfriend.php
+++ b/app/code/Magento/Sendfriend/Model/Sendfriend.php
@@ -116,7 +116,7 @@ class Sendfriend extends \Magento\Framework\Model\AbstractModel
protected $inlineTranslation;
/**
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $cookieManager;
@@ -134,7 +134,7 @@ class Sendfriend extends \Magento\Framework\Model\AbstractModel
* @param \Magento\Sendfriend\Helper\Data $sendfriendData
* @param \Magento\Framework\Escaper $escaper
* @param \Magento\Framework\HTTP\PhpEnvironment\RemoteAddress $remoteAddress
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation
* @param \Magento\Framework\Model\Resource\AbstractResource $resource
* @param \Magento\Framework\Data\Collection\Db $resourceCollection
@@ -149,7 +149,7 @@ class Sendfriend extends \Magento\Framework\Model\AbstractModel
\Magento\Sendfriend\Helper\Data $sendfriendData,
\Magento\Framework\Escaper $escaper,
\Magento\Framework\HTTP\PhpEnvironment\RemoteAddress $remoteAddress,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Translate\Inline\StateInterface $inlineTranslation,
\Magento\Framework\Model\Resource\AbstractResource $resource = null,
\Magento\Framework\Data\Collection\Db $resourceCollection = null,
diff --git a/app/code/Magento/Sendfriend/composer.json b/app/code/Magento/Sendfriend/composer.json
index 1cf385c9c84877de5fd4af6902830ee9db81a28c..ab76860b1135f5a83b53b349a8173ed4525c5f91 100644
--- a/app/code/Magento/Sendfriend/composer.json
+++ b/app/code/Magento/Sendfriend/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Sendfriend/etc/module.xml b/app/code/Magento/Sendfriend/etc/module.xml
index c2ab8496b67bb5e2f13581c86afab6e9131daaf3..2e5a88ff18a5a6f74ab203cfe797b449a2b1cca3 100644
--- a/app/code/Magento/Sendfriend/etc/module.xml
+++ b/app/code/Magento/Sendfriend/etc/module.xml
@@ -25,7 +25,7 @@
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
- <module name="Magento_Sendfriend" schema_version="1.6.0.0" active="true">
+ <module name="Magento_Sendfriend" schema_version="2.0.0" active="true">
<sequence>
<module name="Magento_Catalog"/>
</sequence>
diff --git a/app/code/Magento/Sendfriend/sql/sendfriend_setup/install-1.6.0.0.php b/app/code/Magento/Sendfriend/sql/sendfriend_setup/install-2.0.0.php
similarity index 100%
rename from app/code/Magento/Sendfriend/sql/sendfriend_setup/install-1.6.0.0.php
rename to app/code/Magento/Sendfriend/sql/sendfriend_setup/install-2.0.0.php
diff --git a/app/code/Magento/Shipping/Block/Adminhtml/Create/Items.php b/app/code/Magento/Shipping/Block/Adminhtml/Create/Items.php
index e1d2b6a60c21abeacc0a38bba1b34c471787de2b..e9d273d1950b61e060cacdf453bb57d238e2a4b3 100644
--- a/app/code/Magento/Shipping/Block/Adminhtml/Create/Items.php
+++ b/app/code/Magento/Shipping/Block/Adminhtml/Create/Items.php
@@ -42,7 +42,8 @@ class Items extends \Magento\Sales\Block\Adminhtml\Items\AbstractItems
/**
* @param \Magento\Backend\Block\Template\Context $context
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\Framework\Registry $registry
* @param \Magento\Sales\Helper\Data $salesData
* @param \Magento\Shipping\Model\CarrierFactory $carrierFactory
@@ -50,7 +51,8 @@ class Items extends \Magento\Sales\Block\Adminhtml\Items\AbstractItems
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\Framework\Registry $registry,
\Magento\Sales\Helper\Data $salesData,
\Magento\Shipping\Model\CarrierFactory $carrierFactory,
@@ -58,7 +60,7 @@ class Items extends \Magento\Sales\Block\Adminhtml\Items\AbstractItems
) {
$this->_salesData = $salesData;
$this->_carrierFactory = $carrierFactory;
- parent::__construct($context, $stockItemService, $registry, $data);
+ parent::__construct($context, $stockRegistry, $stockConfiguration, $registry, $data);
}
/**
diff --git a/app/code/Magento/Shipping/Block/Order/Shipment.php b/app/code/Magento/Shipping/Block/Order/Shipment.php
index 96fd59b63ed8f500d24f55030a8108190dafb5fe..490efced357548c0daf7e1e60c08f40c512201d8 100644
--- a/app/code/Magento/Shipping/Block/Order/Shipment.php
+++ b/app/code/Magento/Shipping/Block/Order/Shipment.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Shipping\Block\Order;
+use Magento\Customer\Model\Context;
+
/**
* Sales order view block
*/
@@ -106,7 +108,7 @@ class Shipment extends \Magento\Framework\View\Element\Template
*/
public function getBackUrl()
{
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return $this->getUrl('*/*/history');
}
return $this->getUrl('*/*/form');
@@ -119,7 +121,7 @@ class Shipment extends \Magento\Framework\View\Element\Template
*/
public function getBackTitle()
{
- if ($this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
return __('Back to My Orders');
}
return __('View Another Order');
diff --git a/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php b/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php
index 4b06f80ee66a3e3c2198dd806e2eecba41c41fc5..06efc212d2462c0d7b9ddee49377b02eb7541355 100644
--- a/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php
+++ b/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php
@@ -108,9 +108,9 @@ abstract class AbstractCarrierOnline extends AbstractCarrier
protected $_currencyFactory;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* Raw rate request data
@@ -133,7 +133,7 @@ abstract class AbstractCarrierOnline extends AbstractCarrier
* @param \Magento\Directory\Model\CountryFactory $countryFactory
* @param \Magento\Directory\Model\CurrencyFactory $currencyFactory
* @param \Magento\Directory\Helper\Data $directoryData
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param array $data
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
@@ -152,7 +152,7 @@ abstract class AbstractCarrierOnline extends AbstractCarrier
\Magento\Directory\Model\CountryFactory $countryFactory,
\Magento\Directory\Model\CurrencyFactory $currencyFactory,
\Magento\Directory\Helper\Data $directoryData,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
array $data = array()
) {
$this->_xmlElFactory = $xmlElFactory;
@@ -165,7 +165,7 @@ abstract class AbstractCarrierOnline extends AbstractCarrier
$this->_countryFactory = $countryFactory;
$this->_currencyFactory = $currencyFactory;
$this->_directoryData = $directoryData;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
parent::__construct($scopeConfig, $rateErrorFactory, $logAdapterFactory, $data);
}
@@ -316,14 +316,16 @@ abstract class AbstractCarrierOnline extends AbstractCarrier
$product = $item->getProduct();
if ($product && $product->getId()) {
$weight = $product->getWeight();
- $stockItemData = $this->stockItemService->getStockItem($product->getId());
+ $stockItemData = $this->stockRegistry->getStockItem(
+ $product->getId(),
+ $item->getStore()->getWebsiteId()
+ );
$doValidation = true;
if ($stockItemData->getIsQtyDecimal() && $stockItemData->getIsDecimalDivided()) {
- if ($this->stockItemService->getEnableQtyIncrements($product->getId())
- && $this->stockItemService->getQtyIncrements($product->getId())
+ if ($stockItemData->getEnableQtyIncrements() && $stockItemData->getQtyIncrements()
) {
- $weight = $weight * $this->stockItemService->getQtyIncrements($product->getId());
+ $weight = $weight * $stockItemData->getQtyIncrements();
} else {
$doValidation = false;
}
@@ -403,7 +405,7 @@ abstract class AbstractCarrierOnline extends AbstractCarrier
/**
* Prepare service name. Strip tags and entities from name
*
- * @param string|object $name service name or object with implemented __toString() method
+ * @param string|object $name service name or object with implemented __toString() method
* @return string prepared service name
*/
protected function _prepareServiceName($name)
diff --git a/app/code/Magento/Shipping/Model/CarrierFactory.php b/app/code/Magento/Shipping/Model/CarrierFactory.php
index b7886d174cd795da7c353b2b1af97b02a93acc53..3bf568950f7556b1818ebca2ff65eaaf1a746afa 100644
--- a/app/code/Magento/Shipping/Model/CarrierFactory.php
+++ b/app/code/Magento/Shipping/Model/CarrierFactory.php
@@ -35,17 +35,17 @@ class CarrierFactory implements CarrierFactoryInterface
protected $_scopeConfig;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
public function __construct(
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
- \Magento\Framework\ObjectManager $objectManager
+ \Magento\Framework\ObjectManagerInterface $objectManager
) {
$this->_scopeConfig = $scopeConfig;
$this->_objectManager = $objectManager;
diff --git a/app/code/Magento/Shipping/Model/Shipping.php b/app/code/Magento/Shipping/Model/Shipping.php
index 01912ab482cee39baa5a998c8388eddc0cd1b251..bbae57b28e8c44c141a56604edeff61af024152e 100644
--- a/app/code/Magento/Shipping/Model/Shipping.php
+++ b/app/code/Magento/Shipping/Model/Shipping.php
@@ -92,9 +92,9 @@ class Shipping implements RateCollectorInterface
protected $mathDivision;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
@@ -105,7 +105,7 @@ class Shipping implements RateCollectorInterface
* @param \Magento\Shipping\Model\Shipment\RequestFactory $shipmentRequestFactory
* @param \Magento\Directory\Model\RegionFactory $regionFactory
* @param \Magento\Framework\Math\Division $mathDivision
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
*/
public function __construct(
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
@@ -116,7 +116,7 @@ class Shipping implements RateCollectorInterface
\Magento\Shipping\Model\Shipment\RequestFactory $shipmentRequestFactory,
\Magento\Directory\Model\RegionFactory $regionFactory,
\Magento\Framework\Math\Division $mathDivision,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
) {
$this->_scopeConfig = $scopeConfig;
$this->_shippingConfig = $shippingConfig;
@@ -126,7 +126,7 @@ class Shipping implements RateCollectorInterface
$this->_shipmentRequestFactory = $shipmentRequestFactory;
$this->_regionFactory = $regionFactory;
$this->mathDivision = $mathDivision;
- $this->stockItemService = $stockItemService;
+ $this->stockRegistry = $stockRegistry;
}
/**
@@ -364,11 +364,10 @@ class Shipping implements RateCollectorInterface
) {
$productId = $item->getProduct()->getId();
- if ($this->stockItemService->getStockItem($productId)->getIsDecimalDivided()) {
- if ($this->stockItemService->getEnableQtyIncrements($productId)
- && $this->stockItemService->getQtyIncrements($productId)
- ) {
- $itemWeight = $itemWeight * $this->stockItemService->getQtyIncrements($productId);
+ $stockItem = $this->stockRegistry->getStockItem($productId, $item->getStore()->getWebsiteId());
+ if ($stockItem->getIsDecimalDivided()) {
+ if ($stockItem->getEnableQtyIncrements() && $stockItem->getQtyIncrements()) {
+ $itemWeight = $itemWeight * $stockItem->getQtyIncrements();
$qty = round($item->getWeight() / $itemWeight * $qty);
$changeQty = false;
} else {
diff --git a/app/code/Magento/Shipping/Model/Shipping/Labels.php b/app/code/Magento/Shipping/Model/Shipping/Labels.php
index d816363b40e8a9f582cd5c4108ca543bad02dc6a..b6c4031c04722d285f30450aea74dcf8d3d13f8a 100644
--- a/app/code/Magento/Shipping/Model/Shipping/Labels.php
+++ b/app/code/Magento/Shipping/Model/Shipping/Labels.php
@@ -49,7 +49,7 @@ class Labels extends \Magento\Shipping\Model\Shipping
* @param \Magento\Shipping\Model\Shipment\RequestFactory $shipmentRequestFactory
* @param \Magento\Directory\Model\RegionFactory $regionFactory
* @param \Magento\Framework\Math\Division $mathDivision
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param \Magento\Backend\Model\Auth\Session $authSession
* @param \Magento\Shipping\Model\Shipment\Request $request
*/
@@ -62,7 +62,7 @@ class Labels extends \Magento\Shipping\Model\Shipping
\Magento\Shipping\Model\Shipment\RequestFactory $shipmentRequestFactory,
\Magento\Directory\Model\RegionFactory $regionFactory,
\Magento\Framework\Math\Division $mathDivision,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
\Magento\Backend\Model\Auth\Session $authSession,
\Magento\Shipping\Model\Shipment\Request $request
) {
@@ -77,7 +77,7 @@ class Labels extends \Magento\Shipping\Model\Shipping
$shipmentRequestFactory,
$regionFactory,
$mathDivision,
- $stockItemService
+ $stockRegistry
);
}
diff --git a/app/code/Magento/Shipping/composer.json b/app/code/Magento/Shipping/composer.json
index d785061f50313efd584d728f7ee4523239cc027c..c3b3aff2179b3f6a61bb574b8ff53d640361d867 100644
--- a/app/code/Magento/Shipping/composer.json
+++ b/app/code/Magento/Shipping/composer.json
@@ -3,23 +3,23 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-contact": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-payment": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-contact": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-payment": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"ext-gd": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Sitemap/composer.json b/app/code/Magento/Sitemap/composer.json
index ba2752d55e434d1a56e915773ec5f5b0cae8cf9d..00c80b5608828231f3e2e03ac4d2bc4fba392acc 100644
--- a/app/code/Magento/Sitemap/composer.json
+++ b/app/code/Magento/Sitemap/composer.json
@@ -3,18 +3,18 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-catalog-url-rewrite": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-catalog-url-rewrite": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Store/Model/StorageFactory.php b/app/code/Magento/Store/Model/StorageFactory.php
index 080b830f595c5223bd74bda9ad2440caa56cc326..2b667ba551d9c16a303bbe6709c01d6131485c5b 100644
--- a/app/code/Magento/Store/Model/StorageFactory.php
+++ b/app/code/Magento/Store/Model/StorageFactory.php
@@ -28,7 +28,7 @@ use Magento\Framework\Profiler;
class StorageFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -80,7 +80,7 @@ class StorageFactory
protected $request;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Event\ManagerInterface $eventManager
* @param \Magento\Framework\Logger $logger
* @param \Magento\Framework\Session\SidResolverInterface $sidResolver
@@ -92,7 +92,7 @@ class StorageFactory
* @param string $writerModel
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Event\ManagerInterface $eventManager,
\Magento\Framework\Logger $logger,
\Magento\Framework\Session\SidResolverInterface $sidResolver,
diff --git a/app/code/Magento/Store/Model/Store.php b/app/code/Magento/Store/Model/Store.php
index 70132280dd560e6f9a41c4448abc942cdc520fb4..7cb92056e6f83fa3bb741ad7beb8bd68f28c7561 100644
--- a/app/code/Magento/Store/Model/Store.php
+++ b/app/code/Magento/Store/Model/Store.php
@@ -301,7 +301,7 @@ class Store extends AbstractModel implements
protected $_cookieMetadataFactory;
/**
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $_cookieManager;
@@ -329,7 +329,7 @@ class Store extends AbstractModel implements
* @param \Magento\Framework\StoreManagerInterface $storeManager
* @param \Magento\Framework\Session\SidResolverInterface $sidResolver
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
* @param \Magento\Framework\App\Http\Context $httpContext
* @param \Magento\Framework\Session\SessionManagerInterface $session
* @param \Magento\Directory\Model\CurrencyFactory $currencyFactory
@@ -352,7 +352,7 @@ class Store extends AbstractModel implements
\Magento\Framework\StoreManagerInterface $storeManager,
\Magento\Framework\Session\SidResolverInterface $sidResolver,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\App\Http\Context $httpContext,
\Magento\Framework\Session\SessionManagerInterface $session,
\Magento\Directory\Model\CurrencyFactory $currencyFactory,
diff --git a/app/code/Magento/Store/composer.json b/app/code/Magento/Store/composer.json
index 7cbd9a016d92e9edfc49f51a30f5c71d24878301..56621e01edf149182d3d83fb59ca9d07e786b95e 100644
--- a/app/code/Magento/Store/composer.json
+++ b/app/code/Magento/Store/composer.json
@@ -3,14 +3,14 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-ui": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-ui": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Store/etc/di.xml b/app/code/Magento/Store/etc/di.xml
index bf31fba8752ece47964cda7b5705e1cded51e1bb..6d17e98a73a58b1eaef6050349e5ae4baf0bbaa0 100644
--- a/app/code/Magento/Store/etc/di.xml
+++ b/app/code/Magento/Store/etc/di.xml
@@ -70,7 +70,7 @@
</type>
<preference for="Magento\Framework\App\Config\Scope\ReaderPoolInterface" type="Magento\Store\Model\Config\Reader\ReaderPool"/>
<preference for="Magento\Framework\App\ScopeResolverInterface" type="Magento\Store\Model\Resolver\Store" />
- <preference for="Magento\Framework\Stdlib\CookieManager" type="Magento\Framework\Stdlib\Cookie\PhpCookieManager" />
+ <preference for="Magento\Framework\Stdlib\CookieManagerInterface" type="Magento\Framework\Stdlib\Cookie\PhpCookieManager" />
<type name="Magento\Framework\App\Action\Action">
<plugin name="storeCheck" type="Magento\Store\App\Action\Plugin\StoreCheck" sortOrder="10"/>
</type>
diff --git a/app/code/Magento/Tax/Controller/Adminhtml/Rate/Delete.php b/app/code/Magento/Tax/Controller/Adminhtml/Rate/Delete.php
index 065c2cc53be91f175596665c7e4d939d5f18891c..88ec3de0ee3a92847154126a7d39b1ab5bdb11bd 100644
--- a/app/code/Magento/Tax/Controller/Adminhtml/Rate/Delete.php
+++ b/app/code/Magento/Tax/Controller/Adminhtml/Rate/Delete.php
@@ -31,7 +31,7 @@ class Delete extends \Magento\Tax\Controller\Adminhtml\Rate
/**
* Delete Rate and Data
*
- * @return bool
+ * @return void
*/
public function execute()
{
@@ -41,7 +41,7 @@ class Delete extends \Magento\Tax\Controller\Adminhtml\Rate
$this->messageManager->addSuccess(__('The tax rate has been deleted.'));
$this->getResponse()->setRedirect($this->getUrl("*/*/"));
- return true;
+ return;
} catch (NoSuchEntityException $e) {
$this->messageManager->addError(
__('Something went wrong deleting this rate because of an incorrect rate ID.')
diff --git a/app/code/Magento/Tax/Controller/Adminhtml/Rate/Save.php b/app/code/Magento/Tax/Controller/Adminhtml/Rate/Save.php
index edca03a2b3623971c60da34cf8e2ede5712cf8c4..de3eec5c6cdbccb931892ed555828728881f3201 100644
--- a/app/code/Magento/Tax/Controller/Adminhtml/Rate/Save.php
+++ b/app/code/Magento/Tax/Controller/Adminhtml/Rate/Save.php
@@ -31,7 +31,7 @@ class Save extends \Magento\Tax\Controller\Adminhtml\Rate
/**
* Save Rate and Data
*
- * @return bool
+ * @return void
*/
public function execute()
{
@@ -56,7 +56,7 @@ class Save extends \Magento\Tax\Controller\Adminhtml\Rate
$this->messageManager->addSuccess(__('The tax rate has been saved.'));
$this->getResponse()->setRedirect($this->getUrl("*/*/"));
- return true;
+ return;
} catch (\Magento\Framework\Exception\LocalizedException $e) {
$this->_objectManager->get('Magento\Backend\Model\Session')->setFormData($ratePost);
$this->messageManager->addError($e->getMessage());
diff --git a/app/code/Magento/Tax/Model/Calculation/CalculatorFactory.php b/app/code/Magento/Tax/Model/Calculation/CalculatorFactory.php
index b5308008a2f859e176cdca25bcfa1ac03ce1c819..377edfaeb6a2a6d7fd1c6aed1629fad6c537a433 100644
--- a/app/code/Magento/Tax/Model/Calculation/CalculatorFactory.php
+++ b/app/code/Magento/Tax/Model/Calculation/CalculatorFactory.php
@@ -44,16 +44,16 @@ class CalculatorFactory
const CALC_TOTAL_BASE = 'TOTAL_BASE_CALCULATION';
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Tax/Model/Calculation/RateFactory.php b/app/code/Magento/Tax/Model/Calculation/RateFactory.php
index c7582cf65f289874c40b4c298f64a81405bda56f..3a9a003f694d84809f99f0b816abd2729d568d3b 100644
--- a/app/code/Magento/Tax/Model/Calculation/RateFactory.php
+++ b/app/code/Magento/Tax/Model/Calculation/RateFactory.php
@@ -32,14 +32,14 @@ namespace Magento\Tax\Model\Calculation;
class RateFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Tax/Model/Sales/Total/Quote/Tax.php b/app/code/Magento/Tax/Model/Sales/Total/Quote/Tax.php
index 055a9ee65fcd788c2d51362348907c52ce980e22..7e63754609b8545a6cc0a5857e32003ec220010c 100644
--- a/app/code/Magento/Tax/Model/Sales/Total/Quote/Tax.php
+++ b/app/code/Magento/Tax/Model/Sales/Total/Quote/Tax.php
@@ -96,6 +96,7 @@ class Tax extends CommonTaxCollector
public function collect(Address $address)
{
parent::collect($address);
+ $this->clearValues($address);
$items = $this->_getAddressItems($address);
if (!$items) {
return $this;
@@ -131,6 +132,26 @@ class Tax extends CommonTaxCollector
return $this;
}
+ /**
+ * Clear tax related total values in address
+ *
+ * @param Address $address
+ * @return void
+ */
+ protected function clearValues(Address $address)
+ {
+ $address->setTotalAmount('subtotal', 0);
+ $address->setBaseTotalAmount('subtotal', 0);
+ $address->setTotalAmount('tax', 0);
+ $address->setBaseTotalAmount('tax', 0);
+ $address->setTotalAmount('hidden_tax', 0);
+ $address->setBaseTotalAmount('hidden_tax', 0);
+ $address->setTotalAmount('shipping_hidden_tax', 0);
+ $address->setBaseTotalAmount('shipping_hidden_tax', 0);
+ $address->setSubtotalInclTax(0);
+ $address->setBaseSubtotalInclTax(0);
+ }
+
/**
* Call tax calculation service to get tax details on the quote and items
*
diff --git a/app/code/Magento/Tax/Model/TaxClass/Factory.php b/app/code/Magento/Tax/Model/TaxClass/Factory.php
index 331d44e86dd1284ebe0dc65805b1b8ff12c8e65a..e8681d255fa6bd48089646e862bd515acaf429c7 100644
--- a/app/code/Magento/Tax/Model/TaxClass/Factory.php
+++ b/app/code/Magento/Tax/Model/TaxClass/Factory.php
@@ -30,7 +30,7 @@ namespace Magento\Tax\Model\TaxClass;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -45,9 +45,9 @@ class Factory
);
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Tax/composer.json b/app/code/Magento/Tax/composer.json
index 4bd259aaac0c1f8e0fcf82a42cd7d3955ad682b0..22a8ad03e08daa19af487b7aa1f25da0ed874427 100644
--- a/app/code/Magento/Tax/composer.json
+++ b/app/code/Magento/Tax/composer.json
@@ -3,23 +3,23 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-shipping": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-reports": "0.1.0-alpha104",
- "magento/module-configurable-product": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-shipping": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-reports": "0.1.0-alpha105",
+ "magento/module-configurable-product": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Tax/data/tax_setup/data-install-1.6.0.0.php b/app/code/Magento/Tax/data/tax_setup/data-install-2.0.0.php
similarity index 85%
rename from app/code/Magento/Tax/data/tax_setup/data-install-1.6.0.0.php
rename to app/code/Magento/Tax/data/tax_setup/data-install-2.0.0.php
index 908fad931ed6546c24df65b15b17caa22f14ac59..4fdac0f1c1ed9c02e7304025855dcb6dfcad75eb 100644
--- a/app/code/Magento/Tax/data/tax_setup/data-install-1.6.0.0.php
+++ b/app/code/Magento/Tax/data/tax_setup/data-install-2.0.0.php
@@ -22,18 +22,18 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-/** @var $installer \Magento\Tax\Model\Resource\Setup */
-$installer = $this;
+/** @var $this \Magento\Tax\Model\Resource\Setup */
/**
* Add tax_class_id attribute to the 'eav_attribute' table
*/
-$catalogInstaller = $installer->getCatalogResourceSetup(array('resourceName' => 'catalog_setup'));
+$catalogInstaller = $this->getCatalogResourceSetup(array('resourceName' => 'catalog_setup'));
$catalogInstaller->addAttribute(
\Magento\Catalog\Model\Product::ENTITY,
'tax_class_id',
array(
- 'group' => 'Prices',
+ 'group' => 'Product Details',
+ 'sort_order' => 40,
'type' => 'int',
'backend' => '',
'frontend' => '',
@@ -43,9 +43,9 @@ $catalogInstaller->addAttribute(
'source' => 'Magento\Tax\Model\TaxClass\Source\Product',
'global' => \Magento\Catalog\Model\Resource\Eav\Attribute::SCOPE_WEBSITE,
'visible' => true,
- 'required' => true,
+ 'required' => false,
'user_defined' => false,
- 'default' => '',
+ 'default' => '2',
'searchable' => true,
'filterable' => false,
'comparable' => false,
@@ -73,7 +73,7 @@ $data = array(
)
);
foreach ($data as $row) {
- $installer->getConnection()->insertForce($installer->getTable('tax_class'), $row);
+ $this->getConnection()->insertForce($this->getTable('tax_class'), $row);
}
/**
@@ -98,5 +98,5 @@ $data = array(
)
);
foreach ($data as $row) {
- $installer->getConnection()->insertForce($installer->getTable('tax_calculation_rate'), $row);
+ $this->getConnection()->insertForce($this->getTable('tax_calculation_rate'), $row);
}
diff --git a/app/code/Magento/Tax/data/tax_setup/data-upgrade-1.6.0.0-1.6.0.1.php b/app/code/Magento/Tax/data/tax_setup/data-upgrade-1.6.0.0-1.6.0.1.php
deleted file mode 100644
index 37e6e859b2db51e7faf15321f7983acd291defcb..0000000000000000000000000000000000000000
--- a/app/code/Magento/Tax/data/tax_setup/data-upgrade-1.6.0.0-1.6.0.1.php
+++ /dev/null
@@ -1,55 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/** @var $installer \Magento\Tax\Model\Resource\Setup */
-$installer = $this;
-
-// New attributes order and properties
-$properties = array('is_required', 'default_value');
-$attributesOrder = array(
- // Product Details tab
- 'tax_class_id' => array('Product Details' => 40, 'is_required' => 0, 'default_value' => 2),
-);
-
-$entityTypeId = $this->getEntityTypeId(\Magento\Catalog\Model\Product::ENTITY);
-$attributeSetId = $this->getAttributeSetId($entityTypeId, 'Default');
-
-foreach ($attributesOrder as $key => $value) {
- $attribute = $installer->getAttribute($entityTypeId, $key);
- if ($attribute) {
- foreach ($value as $propertyName => $propertyValue) {
- if (in_array($propertyName, $properties)) {
- $installer->updateAttribute($entityTypeId, $attribute['attribute_id'], $propertyName, $propertyValue);
- } else {
- $installer->addAttributeToGroup(
- $entityTypeId,
- $attributeSetId,
- $propertyName,
- $attribute['attribute_id'],
- $propertyValue
- );
- }
- }
- }
-}
diff --git a/app/code/Magento/Tax/etc/module.xml b/app/code/Magento/Tax/etc/module.xml
index ec92570a5fdca12f8ca83c788c6cd4422ca9a856..f5bf2c1048a86e0dd69f365023f49415b7f808d3 100644
--- a/app/code/Magento/Tax/etc/module.xml
+++ b/app/code/Magento/Tax/etc/module.xml
@@ -24,7 +24,7 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
- <module name="Magento_Tax" schema_version="1.6.0.7" active="true">
+ <module name="Magento_Tax" schema_version="2.0.0" active="true">
<sequence>
<module name="Magento_Catalog"/>
<module name="Magento_Customer"/>
diff --git a/app/code/Magento/Tax/sql/tax_setup/install-1.6.0.0.php b/app/code/Magento/Tax/sql/tax_setup/install-2.0.0.php
similarity index 59%
rename from app/code/Magento/Tax/sql/tax_setup/install-1.6.0.0.php
rename to app/code/Magento/Tax/sql/tax_setup/install-2.0.0.php
index 1e7077297913d1234bc641724d45348fcd9a3f57..8e080e19220fcd968180987ede3c3b59bd115256 100644
--- a/app/code/Magento/Tax/sql/tax_setup/install-1.6.0.0.php
+++ b/app/code/Magento/Tax/sql/tax_setup/install-2.0.0.php
@@ -22,15 +22,14 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-/** @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
-$installer->startSetup();
+/** @var $this \Magento\Setup\Module\SetupModule */
+$this->startSetup();
/**
- * Create table 'tax/class'
+ * Create table 'tax_class'
*/
-$table = $installer->getConnection()->newTable(
- $installer->getTable('tax_class')
+$table = $this->getConnection()->newTable(
+ $this->getTable('tax_class')
)->addColumn(
'class_id',
\Magento\Framework\DB\Ddl\Table::TYPE_SMALLINT,
@@ -52,13 +51,13 @@ $table = $installer->getConnection()->newTable(
)->setComment(
'Tax Class'
);
-$installer->getConnection()->createTable($table);
+$this->getConnection()->createTable($table);
/**
- * Create table 'tax/calculation_rule'
+ * Create table 'tax_calculation_rule'
*/
-$table = $installer->getConnection()->newTable(
- $installer->getTable('tax_calculation_rule')
+$table = $this->getConnection()->newTable(
+ $this->getTable('tax_calculation_rule')
)->addColumn(
'tax_calculation_rule_id',
\Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
@@ -83,22 +82,28 @@ $table = $installer->getConnection()->newTable(
null,
array('nullable' => false),
'Position'
+)->addColumn(
+ 'calculate_subtotal',
+ \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
+ null,
+ array('nullable' => false),
+ 'Calculate off subtotal option'
)->addIndex(
- $installer->getIdxName('tax_calculation_rule', array('priority', 'position')),
+ $this->getIdxName('tax_calculation_rule', array('priority', 'position')),
array('priority', 'position')
)->addIndex(
- $installer->getIdxName('tax_calculation_rule', array('code')),
+ $this->getIdxName('tax_calculation_rule', array('code')),
array('code')
)->setComment(
'Tax Calculation Rule'
);
-$installer->getConnection()->createTable($table);
+$this->getConnection()->createTable($table);
/**
- * Create table 'tax/calculation_rate'
+ * Create table 'tax_calculation_rate'
*/
-$table = $installer->getConnection()->newTable(
- $installer->getTable('tax_calculation_rate')
+$table = $this->getConnection()->newTable(
+ $this->getTable('tax_calculation_rate')
)->addColumn(
'tax_calculation_rate_id',
\Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
@@ -154,13 +159,13 @@ $table = $installer->getConnection()->newTable(
array('unsigned' => true),
'Zip To'
)->addIndex(
- $installer->getIdxName('tax_calculation_rate', array('tax_country_id', 'tax_region_id', 'tax_postcode')),
+ $this->getIdxName('tax_calculation_rate', array('tax_country_id', 'tax_region_id', 'tax_postcode')),
array('tax_country_id', 'tax_region_id', 'tax_postcode')
)->addIndex(
- $installer->getIdxName('tax_calculation_rate', array('code')),
+ $this->getIdxName('tax_calculation_rate', array('code')),
array('code')
)->addIndex(
- $installer->getIdxName(
+ $this->getIdxName(
'tax_calculation_rate',
array('tax_calculation_rate_id', 'tax_country_id', 'tax_region_id', 'zip_is_range', 'tax_postcode')
),
@@ -168,13 +173,13 @@ $table = $installer->getConnection()->newTable(
)->setComment(
'Tax Calculation Rate'
);
-$installer->getConnection()->createTable($table);
+$this->getConnection()->createTable($table);
/**
- * Create table 'tax/calculation'
+ * Create table 'tax_calculation'
*/
-$table = $installer->getConnection()->newTable(
- $installer->getTable('tax_calculation')
+$table = $this->getConnection()->newTable(
+ $this->getTable('tax_calculation')
)->addColumn(
'tax_calculation_id',
\Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
@@ -206,68 +211,68 @@ $table = $installer->getConnection()->newTable(
array('nullable' => false),
'Product Tax Class Id'
)->addIndex(
- $installer->getIdxName('tax_calculation', array('tax_calculation_rule_id')),
+ $this->getIdxName('tax_calculation', array('tax_calculation_rule_id')),
array('tax_calculation_rule_id')
)->addIndex(
- $installer->getIdxName('tax_calculation', array('customer_tax_class_id')),
+ $this->getIdxName('tax_calculation', array('customer_tax_class_id')),
array('customer_tax_class_id')
)->addIndex(
- $installer->getIdxName('tax_calculation', array('product_tax_class_id')),
+ $this->getIdxName('tax_calculation', array('product_tax_class_id')),
array('product_tax_class_id')
)->addIndex(
- $installer->getIdxName(
+ $this->getIdxName(
'tax_calculation',
array('tax_calculation_rate_id', 'customer_tax_class_id', 'product_tax_class_id')
),
array('tax_calculation_rate_id', 'customer_tax_class_id', 'product_tax_class_id')
)->addForeignKey(
- $installer->getFkName('tax_calculation', 'product_tax_class_id', 'tax_class', 'class_id'),
+ $this->getFkName('tax_calculation', 'product_tax_class_id', 'tax_class', 'class_id'),
'product_tax_class_id',
- $installer->getTable('tax_class'),
+ $this->getTable('tax_class'),
'class_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->addForeignKey(
- $installer->getFkName('tax_calculation', 'customer_tax_class_id', 'tax_class', 'class_id'),
+ $this->getFkName('tax_calculation', 'customer_tax_class_id', 'tax_class', 'class_id'),
'customer_tax_class_id',
- $installer->getTable('tax_class'),
+ $this->getTable('tax_class'),
'class_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->addForeignKey(
- $installer->getFkName(
+ $this->getFkName(
'tax_calculation',
'tax_calculation_rate_id',
'tax_calculation_rate',
'tax_calculation_rate_id'
),
'tax_calculation_rate_id',
- $installer->getTable('tax_calculation_rate'),
+ $this->getTable('tax_calculation_rate'),
'tax_calculation_rate_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->addForeignKey(
- $installer->getFkName(
+ $this->getFkName(
'tax_calculation',
'tax_calculation_rule_id',
'tax_calculation_rule',
'tax_calculation_rule_id'
),
'tax_calculation_rule_id',
- $installer->getTable('tax_calculation_rule'),
+ $this->getTable('tax_calculation_rule'),
'tax_calculation_rule_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->setComment(
'Tax Calculation'
);
-$installer->getConnection()->createTable($table);
+$this->getConnection()->createTable($table);
/**
- * Create table 'tax/calculation_rate_title'
+ * Create table 'tax_calculation_rate_title'
*/
-$table = $installer->getConnection()->newTable(
- $installer->getTable('tax_calculation_rate_title')
+$table = $this->getConnection()->newTable(
+ $this->getTable('tax_calculation_rate_title')
)->addColumn(
'tax_calculation_rate_title_id',
\Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
@@ -293,40 +298,40 @@ $table = $installer->getConnection()->newTable(
array('nullable' => false),
'Value'
)->addIndex(
- $installer->getIdxName('tax_calculation_rate_title', array('tax_calculation_rate_id', 'store_id')),
+ $this->getIdxName('tax_calculation_rate_title', array('tax_calculation_rate_id', 'store_id')),
array('tax_calculation_rate_id', 'store_id')
)->addIndex(
- $installer->getIdxName('tax_calculation_rate_title', array('store_id')),
+ $this->getIdxName('tax_calculation_rate_title', array('store_id')),
array('store_id')
)->addForeignKey(
- $installer->getFkName('tax_calculation_rate_title', 'store_id', 'store', 'store_id'),
+ $this->getFkName('tax_calculation_rate_title', 'store_id', 'store', 'store_id'),
'store_id',
- $installer->getTable('store'),
+ $this->getTable('store'),
'store_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->addForeignKey(
- $installer->getFkName(
+ $this->getFkName(
'tax_calculation_rate_title',
'tax_calculation_rate_id',
'tax_calculation_rate',
'tax_calculation_rate_id'
),
'tax_calculation_rate_id',
- $installer->getTable('tax_calculation_rate'),
+ $this->getTable('tax_calculation_rate'),
'tax_calculation_rate_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->setComment(
'Tax Calculation Rate Title'
);
-$installer->getConnection()->createTable($table);
+$this->getConnection()->createTable($table);
/**
- * Create table 'tax/order_aggregated_created'
+ * Create table 'tax_order_aggregated_created'
*/
-$table = $installer->getConnection()->newTable(
- $installer->getTable('tax_order_aggregated_created')
+$table = $this->getConnection()->newTable(
+ $this->getTable('tax_order_aggregated_created')
)->addColumn(
'id',
\Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
@@ -376,7 +381,7 @@ $table = $installer->getConnection()->newTable(
array(),
'Tax Base Amount Sum'
)->addIndex(
- $installer->getIdxName(
+ $this->getIdxName(
'tax_order_aggregated_created',
array('period', 'store_id', 'code', 'percent', 'order_status'),
true
@@ -384,18 +389,130 @@ $table = $installer->getConnection()->newTable(
array('period', 'store_id', 'code', 'percent', 'order_status'),
array('type' => 'unique')
)->addIndex(
- $installer->getIdxName('tax_order_aggregated_created', array('store_id')),
+ $this->getIdxName('tax_order_aggregated_created', array('store_id')),
array('store_id')
)->addForeignKey(
- $installer->getFkName('tax_order_aggregated_created', 'store_id', 'store', 'store_id'),
+ $this->getFkName('tax_order_aggregated_created', 'store_id', 'store', 'store_id'),
'store_id',
- $installer->getTable('store'),
+ $this->getTable('store'),
'store_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->setComment(
'Tax Order Aggregation'
);
-$installer->getConnection()->createTable($table);
+$this->getConnection()->createTable($table);
+
+/**
+ * Create table 'tax_order_aggregated_updated'
+ */
+$this->getConnection()->createTable(
+ $this->getConnection()->createTableByDdl(
+ $this->getTable('tax_order_aggregated_created'),
+ $this->getTable('tax_order_aggregated_updated')
+ )
+);
+
+/**
+ * Create table 'sales_order_tax_item'
+ */
+$table = $this->getConnection()->newTable(
+ $this->getTable('sales_order_tax_item')
+)->addColumn(
+ 'tax_item_id',
+ \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
+ null,
+ array('identity' => true, 'unsigned' => true, 'nullable' => false, 'primary' => true),
+ 'Tax Item Id'
+)->addColumn(
+ 'tax_id',
+ \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
+ null,
+ array('unsigned' => true, 'nullable' => false),
+ 'Tax Id'
+)->addColumn(
+ 'item_id',
+ \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
+ null,
+ array('unsigned' => true, 'nullable' => true),
+ 'Item Id'
+)->addColumn(
+ 'tax_percent',
+ \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
+ '12,4',
+ array('nullable' => false),
+ 'Real Tax Percent For Item'
+)->addColumn(
+ 'amount',
+ \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
+ '12,4',
+ array('nullable' => false),
+ 'Tax amount for the item and tax rate'
+)->addColumn(
+ 'base_amount',
+ \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
+ '12,4',
+ array('nullable' => false),
+ 'Base tax amount for the item and tax rate'
+)->addColumn(
+ 'real_amount',
+ \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
+ '12,4',
+ array('nullable' => false),
+ 'Real tax amount for the item and tax rate'
+)->addColumn(
+ 'real_base_amount',
+ \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
+ '12,4',
+ array('nullable' => false),
+ 'Real base tax amount for the item and tax rate'
+)->addColumn(
+ 'associated_item_id',
+ \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
+ null,
+ array('nullable' => true, 'unsigned' => true),
+ 'Id of the associated item'
+)->addColumn(
+ 'taxable_item_type',
+ \Magento\Framework\DB\Ddl\Table::TYPE_TEXT,
+ 32,
+ array('nullable' => false),
+ 'Type of the taxable item'
+)->addIndex(
+ $this->getIdxName('sales_order_tax_item', array('item_id')),
+ array('item_id')
+)->addIndex(
+ $this->getIdxName(
+ 'sales_order_tax_item',
+ array('tax_id', 'item_id'),
+ \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE
+ ),
+ array('tax_id', 'item_id'),
+ array('type' => \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE)
+)->addForeignKey(
+ $this->getFkName('sales_order_tax_item', 'associated_item_id', 'sales_order_item', 'item_id'),
+ 'associated_item_id',
+ $this->getTable('sales_order_item'),
+ 'item_id',
+ \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
+ \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
+)->addForeignKey(
+ $this->getFkName('sales_order_tax_item', 'tax_id', 'sales_order_tax', 'tax_id'),
+ 'tax_id',
+ $this->getTable('sales_order_tax'),
+ 'tax_id',
+ \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
+ \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
+)->addForeignKey(
+ $this->getFkName('sales_order_tax_item', 'item_id', 'sales_order_item', 'item_id'),
+ 'item_id',
+ $this->getTable('sales_order_item'),
+ 'item_id',
+ \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
+ \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
+)->setComment(
+ 'Sales Order Tax Item'
+);
+$this->getConnection()->createTable($table);
-$installer->endSetup();
+$this->endSetup();
diff --git a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.0-1.6.0.1.php b/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.0-1.6.0.1.php
deleted file mode 100644
index 4c4276f51b54c56f479280f855c404b683919c0b..0000000000000000000000000000000000000000
--- a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.0-1.6.0.1.php
+++ /dev/null
@@ -1,33 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/** @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
-$connection = $installer->getConnection();
-$connection->createTable(
- $connection->createTableByDdl(
- $installer->getTable('tax_order_aggregated_created'),
- $installer->getTable('tax_order_aggregated_updated')
- )
-);
diff --git a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.1-1.6.0.2.php b/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.1-1.6.0.2.php
deleted file mode 100644
index dc85e2b647afcf29bf6b2233ccf01de38c9f5aa4..0000000000000000000000000000000000000000
--- a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.1-1.6.0.2.php
+++ /dev/null
@@ -1,79 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/** @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
-
-/**
- * Create table 'sales_order_tax_item'
- */
-$table = $installer->getConnection()->newTable(
- $installer->getTable('sales_order_tax_item')
-)->addColumn(
- 'tax_item_id',
- \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
- null,
- array('identity' => true, 'unsigned' => true, 'nullable' => false, 'primary' => true),
- 'Tax Item Id'
-)->addColumn(
- 'tax_id',
- \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
- null,
- array('unsigned' => true, 'nullable' => false),
- 'Tax Id'
-)->addColumn(
- 'item_id',
- \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
- null,
- array('unsigned' => true, 'nullable' => false),
- 'Item Id'
-)->addIndex(
- $installer->getIdxName('sales_order_tax_item', array('item_id')),
- array('item_id')
-)->addIndex(
- $installer->getIdxName(
- 'sales_order_tax_item',
- array('tax_id', 'item_id'),
- \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE
- ),
- array('tax_id', 'item_id'),
- array('type' => \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_UNIQUE)
-)->addForeignKey(
- $installer->getFkName('sales_order_tax_item', 'tax_id', 'sales_order_tax', 'tax_id'),
- 'tax_id',
- $installer->getTable('sales_order_tax'),
- 'tax_id',
- \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
- \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
-)->addForeignKey(
- $installer->getFkName('sales_order_tax_item', 'item_id', 'sales_order_item', 'item_id'),
- 'item_id',
- $installer->getTable('sales_order_item'),
- 'item_id',
- \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
- \Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
-)->setComment(
- 'Sales Order Tax Item'
-);
-$installer->getConnection()->createTable($table);
diff --git a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.4-1.6.0.5.php b/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.4-1.6.0.5.php
deleted file mode 100644
index 6b158569525eb1090ba9df0b249cd6b75a1bcfdc..0000000000000000000000000000000000000000
--- a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.4-1.6.0.5.php
+++ /dev/null
@@ -1,47 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/** @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
-
-$connection = $installer->getConnection();
-$adminRuleTable = $installer->getTable('authorization_rule');
-$aclRulesDelete = array(
- 'Magento_Tax::classes_customer',
- 'Magento_Tax::classes_product',
- 'Magento_Tax::import_export',
- 'Magento_Tax::tax_rates',
- 'Magento_Tax::rules'
-);
-
-/**
- * Remove unneeded ACL rules
- */
-$connection->delete($adminRuleTable, $connection->quoteInto('resource_id IN (?)', $aclRulesDelete));
-
-$connection->update(
- $adminRuleTable,
- array('resource_id' => 'Magento_Tax::manage_tax'),
- array('resource_id = ?' => 'Magento_Tax::sales_tax')
-);
diff --git a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.5-1.6.0.6.php b/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.5-1.6.0.6.php
deleted file mode 100644
index badd905bc687c02ae9ac70f3940817655af7c36c..0000000000000000000000000000000000000000
--- a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.5-1.6.0.6.php
+++ /dev/null
@@ -1,62 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @category Magento
- * @package Magento_Tax
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/** @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
-
-$connection = $installer->getConnection();
-$adminRuleTable = $installer->getTable('authorization_rule');
-$aclRulesDelete = array(
- 'Magento_Tax::classes_customer',
- 'Magento_Tax::classes_product',
- 'Magento_Tax::import_export',
- 'Magento_Tax::tax_rates',
- 'Magento_Tax::rules'
-);
-
-/**
- * Remove unneeded ACL rules
- */
-$connection->delete($adminRuleTable, $connection->quoteInto('resource_id IN (?)', $aclRulesDelete));
-
-$connection->update(
- $adminRuleTable,
- array('resource_id' => 'Magento_Tax::manage_tax'),
- array('resource_id = ?' => 'Magento_Tax::sales_tax')
-);
-
-/**
- * Add new field to 'tax_calculation_rule'
- */
-$connection->addColumn(
- $this->getTable('tax_calculation_rule'),
- 'calculate_subtotal',
- [
- 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
- 'NULLABLE' => false,
- 'COMMENT' => 'Calculate off subtotal option',
- ]
-);
diff --git a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.6-1.6.0.7.php b/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.6-1.6.0.7.php
deleted file mode 100644
index 7f65a36603a466060ee89fc958f7d4bab0b7bfb5..0000000000000000000000000000000000000000
--- a/app/code/Magento/Tax/sql/tax_setup/upgrade-1.6.0.6-1.6.0.7.php
+++ /dev/null
@@ -1,113 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/** @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
-$connection = $installer->getConnection();
-
-/**
- * Add new field to 'sales_order_tax_item'
- */
-$connection->addColumn(
- $installer->getTable('sales_order_tax_item'),
- 'amount',
- [
- 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
- 'SCALE' => 4,
- 'PRECISION' => 12,
- 'NULLABLE' => false,
- 'COMMENT' => 'Tax amount for the item and tax rate.'
- ]
-);
-$connection->addColumn(
- $installer->getTable('sales_order_tax_item'),
- 'base_amount',
- [
- 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
- 'SCALE' => 4,
- 'PRECISION' => 12,
- 'NULLABLE' => false,
- 'COMMENT' => 'Base tax amount for the item and tax rate.'
- ]
-);
-$connection->addColumn(
- $installer->getTable('sales_order_tax_item'),
- 'real_amount',
- [
- 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
- 'SCALE' => 4,
- 'PRECISION' => 12,
- 'NULLABLE' => false,
- 'COMMENT' => 'Real tax amount for the item and tax rate.'
- ]
-);
-$connection->addColumn(
- $installer->getTable('sales_order_tax_item'),
- 'real_base_amount',
- [
- 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_DECIMAL,
- 'SCALE' => 4,
- 'PRECISION' => 12,
- 'NULLABLE' => false,
- 'COMMENT' => 'Real base tax amount for the item and tax rate.'
- ]
-);
-$connection->addColumn(
- $installer->getTable('sales_order_tax_item'),
- 'associated_item_id',
- [
- 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
- 'UNSIGNED' => true,
- 'NULLABLE' => true,
- 'COMMENT' => 'Id of the associated item.'
- ]
-);
-$connection->addColumn(
- $installer->getTable('sales_order_tax_item'),
- 'taxable_item_type',
- [
- 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_TEXT,
- 'length' => 32,
- 'NULLABLE' => false,
- 'COMMENT' => 'Type of the taxable item.'
- ]
-);
-$connection->changeColumn(
- $installer->getTable('sales_order_tax_item'),
- 'item_id',
- 'item_id',
- [
- 'TYPE' => \Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
- 'NULLABLE' => true,
- 'UNSIGNED' => true,
- 'COMMENT' => 'Item Id',
- ]
-);
-$connection->addForeignKey(
- $installer->getFkName('sales_order_tax_item', 'associated_item_id', 'sales_order_item', 'item_id'),
- $installer->getTable('sales_order_tax_item'),
- 'associated_item_id',
- $installer->getTable('sales_order_item'),
- 'item_id'
-);
diff --git a/app/code/Magento/TaxImportExport/composer.json b/app/code/Magento/TaxImportExport/composer.json
index 5d463084c6bdb62ec64d88ee85fc42961033f3eb..a52310209ce711777c02d3be2f023529697adb88 100644
--- a/app/code/Magento/TaxImportExport/composer.json
+++ b/app/code/Magento/TaxImportExport/composer.json
@@ -3,15 +3,15 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-store": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/AbstractTab.php b/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/AbstractTab.php
index 799ec8d3c6971065e2a2d6d7b55c0ee20afc91a1..5dda1f7bc98cd7d37c2c677ae34e647c17a4b3e0 100644
--- a/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/AbstractTab.php
+++ b/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/AbstractTab.php
@@ -33,7 +33,7 @@ abstract class AbstractTab extends \Magento\Backend\Block\Widget\Form\Generic im
\Magento\Backend\Block\Widget\Tab\TabInterface
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -48,14 +48,14 @@ abstract class AbstractTab extends \Magento\Backend\Block\Widget\Form\Generic im
* @param \Magento\Backend\Block\Template\Context $context
* @param \Magento\Framework\Registry $registry
* @param \Magento\Framework\Data\FormFactory $formFactory
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $data
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
\Magento\Framework\Registry $registry,
\Magento\Framework\Data\FormFactory $formFactory,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
array $data = array()
) {
parent::__construct($context, $registry, $formFactory, $data);
diff --git a/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/Tab/Css.php b/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/Tab/Css.php
index 98ab0c00ce8d489fb482c998e98c2e6dc6ad153a..9299d75dad397f398a90b0813fab707445f07413 100644
--- a/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/Tab/Css.php
+++ b/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/Tab/Css.php
@@ -57,7 +57,7 @@ class Css extends \Magento\Theme\Block\Adminhtml\System\Design\Theme\Edit\Abstra
* @param \Magento\Backend\Block\Template\Context $context
* @param \Magento\Framework\Registry $registry
* @param \Magento\Framework\Data\FormFactory $formFactory
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Theme\Model\Uploader\Service $uploaderService
* @param \Magento\Framework\Encryption\UrlCoder $urlCoder
* @param array $data
@@ -66,7 +66,7 @@ class Css extends \Magento\Theme\Block\Adminhtml\System\Design\Theme\Edit\Abstra
\Magento\Backend\Block\Template\Context $context,
\Magento\Framework\Registry $registry,
\Magento\Framework\Data\FormFactory $formFactory,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Theme\Model\Uploader\Service $uploaderService,
\Magento\Framework\Encryption\UrlCoder $urlCoder,
array $data = array()
diff --git a/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/Tab/General.php b/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/Tab/General.php
index 3c231f3e4fa7848ad97a9d64339e111ad31f0e6c..ac3c0b1ef35e41d2815ca8fd34ca3257f71e9ed6 100644
--- a/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/Tab/General.php
+++ b/app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/Tab/General.php
@@ -50,7 +50,7 @@ class General extends \Magento\Theme\Block\Adminhtml\System\Design\Theme\Edit\Ab
* @param \Magento\Backend\Block\Template\Context $context
* @param \Magento\Framework\Registry $registry
* @param \Magento\Framework\Data\FormFactory $formFactory
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\File\Size $fileSize
* @param array $data
*/
@@ -58,7 +58,7 @@ class General extends \Magento\Theme\Block\Adminhtml\System\Design\Theme\Edit\Ab
\Magento\Backend\Block\Template\Context $context,
\Magento\Framework\Registry $registry,
\Magento\Framework\Data\FormFactory $formFactory,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\File\Size $fileSize,
array $data = array()
) {
diff --git a/app/code/Magento/Theme/Block/Html/Footer.php b/app/code/Magento/Theme/Block/Html/Footer.php
index 311a88a1b0cc980c6ed5ca05a35865c9e7205eda..c84d392b91b5f3aad7557a7ac71ab094adf70689 100644
--- a/app/code/Magento/Theme/Block/Html/Footer.php
+++ b/app/code/Magento/Theme/Block/Html/Footer.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Theme\Block\Html;
+use Magento\Customer\Model\Context;
+
/**
* Html page footer block
*/
@@ -81,7 +83,7 @@ class Footer extends \Magento\Framework\View\Element\Template implements \Magent
$this->_storeManager->getStore()->getId(),
(int)$this->_storeManager->getStore()->isCurrentlySecure(),
$this->_design->getDesignTheme()->getId(),
- $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH),
+ $this->httpContext->getValue(Context::CONTEXT_AUTH),
);
}
diff --git a/app/code/Magento/Theme/Block/Html/Header.php b/app/code/Magento/Theme/Block/Html/Header.php
index d25d4afa7cb928cda161ad5c89985114f169a922..5158792379e72c804b8530227d83883928e8277f 100644
--- a/app/code/Magento/Theme/Block/Html/Header.php
+++ b/app/code/Magento/Theme/Block/Html/Header.php
@@ -24,9 +24,10 @@
namespace Magento\Theme\Block\Html;
-use Magento\Customer\Helper\Data;
use Magento\Customer\Helper\View as CustomerViewHelper;
+use Magento\Customer\Model\Context;
+
/**
* Html page header block
*/
@@ -83,7 +84,7 @@ class Header extends \Magento\Framework\View\Element\Template
public function getWelcome()
{
if (empty($this->_data['welcome'])) {
- if ($this->httpContext->getValue(Data::CONTEXT_AUTH)) {
+ if ($this->httpContext->getValue(Context::CONTEXT_AUTH)) {
$customerName = $this->_customerViewHelper->getCustomerName(
$this->_customerSession->getCustomerDataObject()
);
diff --git a/app/code/Magento/Theme/Model/Wysiwyg/Storage.php b/app/code/Magento/Theme/Model/Wysiwyg/Storage.php
index dbb327e2a9aa0a9abe3a979d09d738197a53c413..ff7af4850b96b28a03379a2bff8b835929b56d95 100644
--- a/app/code/Magento/Theme/Model/Wysiwyg/Storage.php
+++ b/app/code/Magento/Theme/Model/Wysiwyg/Storage.php
@@ -69,7 +69,7 @@ class Storage
protected $_helper;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -88,13 +88,13 @@ class Storage
*
* @param \Magento\Framework\Filesystem $filesystem
* @param \Magento\Theme\Helper\Storage $helper
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Image\AdapterFactory $imageFactory
*/
public function __construct(
\Magento\Framework\Filesystem $filesystem,
\Magento\Theme\Helper\Storage $helper,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Image\AdapterFactory $imageFactory
) {
$this->mediaWriteDirectory = $filesystem->getDirectoryWrite(DirectoryList::MEDIA);
diff --git a/app/code/Magento/Theme/composer.json b/app/code/Magento/Theme/composer.json
index 2e3dd1a6e2ca16a9b4f7fcdf651fbabc742e69dd..ca9bcde00a6003a65d41c810f9800214c3afa16c 100644
--- a/app/code/Magento/Theme/composer.json
+++ b/app/code/Magento/Theme/composer.json
@@ -3,17 +3,17 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/module-translation": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/module-translation": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Translation/composer.json b/app/code/Magento/Translation/composer.json
index ba56c47708d0213157bb36934652efe647fe22be..42c96aa7766ecb5987e113abd4193770ada7698d 100644
--- a/app/code/Magento/Translation/composer.json
+++ b/app/code/Magento/Translation/composer.json
@@ -3,14 +3,14 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Ui/ConfigurationStorage.php b/app/code/Magento/Ui/ConfigurationStorage.php
index 7a23aa4a9025920400fb65477526c4ff35a05150..2009f42aba4e9f9486c261669dfdb0aff4306794 100644
--- a/app/code/Magento/Ui/ConfigurationStorage.php
+++ b/app/code/Magento/Ui/ConfigurationStorage.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Ui;
-use Magento\Framework\Data\Collection as DataCollection;
+use Magento\Framework\Data\CollectionDataSourceInterface;
use Magento\Framework\View\Element\UiComponent\ConfigInterface;
use Magento\Framework\View\Element\UiComponent\ConfigStorageInterface;
@@ -56,7 +56,7 @@ class ConfigurationStorage implements ConfigStorageInterface
/**
* Data collection storage
*
- * @var DataCollection[]
+ * @var CollectionDataSourceInterface[]
*/
protected $collectionStorage = [];
@@ -68,10 +68,7 @@ class ConfigurationStorage implements ConfigStorageInterface
protected $globalDataStorage = [];
/**
- * Add components configuration
- *
- * @param ConfigInterface $configuration
- * @return void
+ * @inheritdoc
*/
public function addComponentsData(ConfigInterface $configuration)
{
@@ -81,10 +78,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Remove components configuration
- *
- * @param ConfigInterface $configuration
- * @return void
+ * @inheritdoc
*/
public function removeComponentsData(ConfigInterface $configuration)
{
@@ -92,10 +86,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Get components configuration
- *
- * @param string|null $name
- * @return ConfigInterface|null|array
+ * @inheritdoc
*/
public function getComponentsData($name = null)
{
@@ -106,11 +97,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Add data in storage
- *
- * @param string $key
- * @param array $data
- * @return void
+ * @inheritdoc
*/
public function addData($key, array $data)
{
@@ -120,10 +107,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Remove data in storage
- *
- * @param string $key
- * @return void
+ * @inheritdoc
*/
public function removeData($key)
{
@@ -131,10 +115,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Get data from storage
- *
- * @param string|null $key
- * @return array|null
+ * @inheritdoc
*/
public function getData($key = null)
{
@@ -145,11 +126,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Update data in storage
- *
- * @param string $key
- * @param array $data
- * @return void
+ * @inheritdoc
*/
public function updateData($key, array $data)
{
@@ -159,11 +136,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Add meta data
- *
- * @param string $key
- * @param array $data
- * @return mixed
+ * @inheritdoc
*/
public function addMeta($key, array $data)
{
@@ -173,10 +146,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Remove meta data
- *
- * @param string $key
- * @return array
+ * @inheritdoc
*/
public function removeMeta($key)
{
@@ -184,10 +154,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Get meta data
- *
- * @param string|null $key
- * @return array
+ * @inheritdoc
*/
public function getMeta($key = null)
{
@@ -198,11 +165,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Update meta data in storage
- *
- * @param string $key
- * @param array $data
- * @return void
+ * @inheritdoc
*/
public function updateMeta($key, array $data)
{
@@ -212,13 +175,9 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Set data collection
- *
- * @param string $key
- * @param DataCollection $dataCollection
- * @return void
+ * @inheritdoc
*/
- public function addDataCollection($key, DataCollection $dataCollection)
+ public function addDataCollection($key, CollectionDataSourceInterface $dataCollection)
{
if (!isset($this->collectionStorage[$key])) {
$this->collectionStorage[$key] = $dataCollection;
@@ -226,10 +185,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Get data collection
- *
- * @param string|null $key
- * @return DataCollection|null
+ * @inheritdoc
*/
public function getDataCollection($key = null)
{
@@ -240,13 +196,9 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Update data collection in storage
- *
- * @param string $key
- * @param DataCollection $dataCollection
- * @return mixed
+ * @inheritdoc
*/
- public function updateDataCollection($key, DataCollection $dataCollection)
+ public function updateDataCollection($key, CollectionDataSourceInterface $dataCollection)
{
if (isset($this->collectionStorage[$key])) {
$this->collectionStorage[$key] = $dataCollection;
@@ -254,11 +206,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Add cloud data in storage
- *
- * @param string $key
- * @param array $data
- * @return void
+ * @inheritdoc
*/
public function addGlobalData($key, array $data)
{
@@ -268,10 +216,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Remove cloud data in storage
- *
- * @param string $key
- * @return void
+ * @inheritdoc
*/
public function removeGlobalData($key)
{
@@ -279,10 +224,7 @@ class ConfigurationStorage implements ConfigStorageInterface
}
/**
- * Get cloud data from storage
- *
- * @param string|null $key
- * @return array|null
+ * @inheritdoc
*/
public function getGlobalData($key = null)
{
diff --git a/app/code/Magento/Ui/ContentType/ContentTypeFactory.php b/app/code/Magento/Ui/ContentType/ContentTypeFactory.php
index 66ccd9f4833a4fd691db8a305aeed47942135468..bcceee06d2d20a05585bb640a9523964211a9fcc 100644
--- a/app/code/Magento/Ui/ContentType/ContentTypeFactory.php
+++ b/app/code/Magento/Ui/ContentType/ContentTypeFactory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Ui\ContentType;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Class ContentTypeFactory
@@ -49,17 +49,17 @@ class ContentTypeFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param array $types
*/
- public function __construct(ObjectManager $objectManager, array $types = [])
+ public function __construct(ObjectManagerInterface $objectManager, array $types = [])
{
$this->types = array_merge($this->types, $types);
$this->objectManager = $objectManager;
diff --git a/app/code/Magento/Ui/Control/ActionPool.php b/app/code/Magento/Ui/Control/ActionPool.php
index 6307ffe425014688e5d3d96786296af2c3aa0797..884bb52a9123bf0e7e757ee949d9ea2c7e8d9277 100644
--- a/app/code/Magento/Ui/Control/ActionPool.php
+++ b/app/code/Magento/Ui/Control/ActionPool.php
@@ -74,7 +74,10 @@ class ActionPool implements ActionPoolInterface
{
$this->context = $context;
$this->itemFactory = $itemFactory;
- $this->toolbarBlock = $this->context->getPageLayout()->getBlock(static::ACTIONS_PAGE_TOOLBAR);
+ $pageLayout = $this->context->getPageLayout();
+ $this->toolbarBlock = $pageLayout
+ ? $this->context->getPageLayout()->getBlock(static::ACTIONS_PAGE_TOOLBAR)
+ : false;
}
diff --git a/app/code/Magento/Ui/DataProvider/OptionsFactory.php b/app/code/Magento/Ui/DataProvider/OptionsFactory.php
index 9cde93cacee62b50e6bca476d621af54e1b5ceb2..2933122c727ff6e68792b959bb2c21a8f459ec7f 100644
--- a/app/code/Magento/Ui/DataProvider/OptionsFactory.php
+++ b/app/code/Magento/Ui/DataProvider/OptionsFactory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Ui\DataProvider;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Class OptionsFactory
@@ -31,16 +31,16 @@ use Magento\Framework\ObjectManager;
class OptionsFactory
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Ui/DataProvider/RowPool.php b/app/code/Magento/Ui/DataProvider/RowPool.php
index 44060227cc724114b8aaf7421eaafdf90c8dec21..a32e6fda1ff9a24e8e5d4051e982af846c7fb66d 100644
--- a/app/code/Magento/Ui/DataProvider/RowPool.php
+++ b/app/code/Magento/Ui/DataProvider/RowPool.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Ui\DataProvider;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Class RowPool
@@ -36,16 +36,16 @@ class RowPool
protected $classPool;
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Ui/Filter/FilterPool.php b/app/code/Magento/Ui/Filter/FilterPool.php
index c134d73a4de64e0d2782c7dddbcd7ea843703370..5fd454575dd6917b395f2add2aae3a4480650705 100644
--- a/app/code/Magento/Ui/Filter/FilterPool.php
+++ b/app/code/Magento/Ui/Filter/FilterPool.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Ui\Filter;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Class FilterPool
@@ -51,16 +51,16 @@ class FilterPool
protected $filters = [];
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/app/code/Magento/Ui/FilterPool/View.php b/app/code/Magento/Ui/FilterPool/View.php
index b43e4651775cb2cb59318bd55017ac6dd3900efe..d403bf339210b20ecd6dd6ad9cbb2ac93200f8d2 100644
--- a/app/code/Magento/Ui/FilterPool/View.php
+++ b/app/code/Magento/Ui/FilterPool/View.php
@@ -130,7 +130,7 @@ class View extends AbstractView
}
$condition = $this->filterPool->getFilter($metaData[$field]['filter_type'])->getCondition($value);
if ($condition !== null) {
- $collection->addFieldToFilter($field, $condition);
+ $collection->addFilter($field, $field, $condition);
}
}
}
diff --git a/app/code/Magento/Ui/Listing/View.php b/app/code/Magento/Ui/Listing/View.php
index 9d0256f463721d2d4a5f97a94d1371c8b557e5f7..5be361cd7b6c1c8a5cd72da83f473a79fd3ace04 100644
--- a/app/code/Magento/Ui/Listing/View.php
+++ b/app/code/Magento/Ui/Listing/View.php
@@ -205,7 +205,7 @@ class View extends AbstractView
public function getCollectionItems()
{
$items = [];
- $collection = $this->renderContext->getStorage()->getDataCollection($this->getName());
+ $collection = $this->getResultCollection();
foreach ($collection->getItems() as $item) {
$actualFields = [];
$itemsData = $this->getDataFromDataProvider($item->getData());
@@ -214,10 +214,17 @@ class View extends AbstractView
}
$items[] = $actualFields;
}
-
return $items;
}
+ /**
+ * @return \Magento\Framework\Data\SearchResultInterface
+ */
+ protected function getResultCollection()
+ {
+ return $this->renderContext->getStorage()->getDataCollection($this->getName())->getResultCollection();
+ }
+
/**
* Configuration initialization
*
@@ -238,14 +245,15 @@ class View extends AbstractView
);
$this->renderContext->getStorage()->addGlobalData('dump', ['extenders' => []]);
- $countItems = $this->renderContext->getStorage()->getDataCollection($this->getName())->getSize();
+ $collection = $this->getResultCollection();
+ $totalCount = $collection->getSize();
$this->renderContext->getStorage()->addData(
$this->getName(),
[
'meta_reference' => $this->getName(),
'items' => $this->getCollectionItems(),
- 'pages' => ceil($countItems / $this->renderContext->getRequestParam('limit', 20)),
- 'totalCount' => $countItems
+ 'pages' => ceil($totalCount / $this->renderContext->getRequestParam('limit', 20)),
+ 'totalCount' => $totalCount
]
);
}
diff --git a/app/code/Magento/Ui/Paging/View.php b/app/code/Magento/Ui/Paging/View.php
index ebee775d8759999fd230e6586afe251fbbad11fa..33a27b1a78a03d73b0c7bb6f00d757afdb084d20 100644
--- a/app/code/Magento/Ui/Paging/View.php
+++ b/app/code/Magento/Ui/Paging/View.php
@@ -61,9 +61,11 @@ class View extends AbstractView
*/
protected function updateDataCollection()
{
- $this->renderContext->getStorage()->getDataCollection($this->getParentName())
- ->setCurPage($this->renderContext->getRequestParam('page', $this->configuration->getData('current')))
- ->setPageSize($this->renderContext->getRequestParam('limit', $this->configuration->getData('pageSize')));
+ $defaultPage = $this->configuration->getData('current');
+ $offset = $this->renderContext->getRequestParam('page', $defaultPage);
+ $defaultLimit = $this->configuration->getData('pageSize');
+ $size = $this->renderContext->getRequestParam('limit', $defaultLimit);
+ $this->renderContext->getStorage()->getDataCollection($this->getParentName())->setLimit($offset, $size);
}
/**
diff --git a/app/code/Magento/Ui/Sorting/View.php b/app/code/Magento/Ui/Sorting/View.php
index d218417c58eb55657e48ad6b4fa168b92e4234b9..24d074084999f9f29a2ba8ecbf2085cd1ce31f8f 100644
--- a/app/code/Magento/Ui/Sorting/View.php
+++ b/app/code/Magento/Ui/Sorting/View.php
@@ -65,7 +65,7 @@ class View extends AbstractView
$field = $this->configuration->getData('field');
$direction = $this->configuration->getData('direction');
if (!empty($field) && !empty($direction)) {
- $this->renderContext->getStorage()->getDataCollection($this->getParentName())->setOrder(
+ $this->renderContext->getStorage()->getDataCollection($this->getParentName())->addOrder(
$this->renderContext->getRequestParam('sort', $field),
strtoupper($this->renderContext->getRequestParam('dir', $direction))
);
diff --git a/app/code/Magento/Ui/composer.json b/app/code/Magento/Ui/composer.json
index 6e3c827631f0524742bc607432bcfb1906bc659e..c8d3264f44f3906221479966cefda6dfb046364a 100644
--- a/app/code/Magento/Ui/composer.json
+++ b/app/code/Magento/Ui/composer.json
@@ -3,13 +3,13 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-store": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Ups/Model/Carrier.php b/app/code/Magento/Ups/Model/Carrier.php
index 08346039f3ce3736e61ca6cd15f11706c51bcbdc..caaf9ff6a3611bf13271b3faa9d47c3d2d920ae1 100644
--- a/app/code/Magento/Ups/Model/Carrier.php
+++ b/app/code/Magento/Ups/Model/Carrier.php
@@ -147,7 +147,7 @@ class Carrier extends AbstractCarrierOnline implements CarrierInterface
* @param \Magento\Directory\Model\CountryFactory $countryFactory
* @param \Magento\Directory\Model\CurrencyFactory $currencyFactory
* @param \Magento\Directory\Helper\Data $directoryData
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param \Magento\Framework\Logger $logger
* @param \Magento\Framework\Locale\FormatInterface $localeFormat
* @param Config $configHelper
@@ -169,7 +169,7 @@ class Carrier extends AbstractCarrierOnline implements CarrierInterface
\Magento\Directory\Model\CountryFactory $countryFactory,
\Magento\Directory\Model\CurrencyFactory $currencyFactory,
\Magento\Directory\Helper\Data $directoryData,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
\Magento\Framework\Logger $logger,
\Magento\Framework\Locale\FormatInterface $localeFormat,
Config $configHelper,
@@ -192,7 +192,7 @@ class Carrier extends AbstractCarrierOnline implements CarrierInterface
$countryFactory,
$currencyFactory,
$directoryData,
- $stockItemService,
+ $stockRegistry,
$data
);
}
diff --git a/app/code/Magento/Ups/composer.json b/app/code/Magento/Ups/composer.json
index d6a7c4e76180ec988fa941aa3c475226f2d19bb7..1232dfcc0a00655798e9167283234b1141052b72 100644
--- a/app/code/Magento/Ups/composer.json
+++ b/app/code/Magento/Ups/composer.json
@@ -3,18 +3,18 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-shipping": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-shipping": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/UrlRewrite/composer.json b/app/code/Magento/UrlRewrite/composer.json
index e1b7463e28d16e6928b46407c641e69e666f9fe1..c15c193aa8ecb293813307932fa6f84e5085fe63 100644
--- a/app/code/Magento/UrlRewrite/composer.json
+++ b/app/code/Magento/UrlRewrite/composer.json
@@ -3,18 +3,18 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-store": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-catalog-url-rewrite": "0.1.0-alpha104",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/module-cms-url-rewrite": "0.1.0-alpha104",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-catalog-url-rewrite": "0.1.0-alpha105",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/module-cms-url-rewrite": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/User/composer.json b/app/code/Magento/User/composer.json
index 543ae1e6ff17bb08e8e120f5d04ea891133e7393..e0e21708cccb1009849144a6ec2895543083ea04 100644
--- a/app/code/Magento/User/composer.json
+++ b/app/code/Magento/User/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-authorization": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-integration": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-authorization": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-integration": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/User/view/adminhtml/templates/role/users_grid_js.phtml b/app/code/Magento/User/view/adminhtml/templates/role/users_grid_js.phtml
index b07fac9dcde6a612d5fb3141439d254cd471988a..13d0731a5665ce993cc6b1b3f031a50fa817467e 100644
--- a/app/code/Magento/User/view/adminhtml/templates/role/users_grid_js.phtml
+++ b/app/code/Magento/User/view/adminhtml/templates/role/users_grid_js.phtml
@@ -105,7 +105,7 @@ require([
roleUsersRowInit(<?php echo $myBlock->getJsObjectName() ?>, row);
});
}
- document.observe('dom:loaded', function(){
+ Event.observe(window, "load", function(){
<?php echo $myBlock->getJsObjectName() ?>.rowClickCallback = roleUsersRowClick;
<?php echo $myBlock->getJsObjectName() ?>.initRowCallback = roleUsersRowInit;
<?php echo $myBlock->getJsObjectName() ?>.checkboxCheckCallback = registerUserRole;
diff --git a/app/code/Magento/Usps/Model/Carrier.php b/app/code/Magento/Usps/Model/Carrier.php
index af59af66dd7fc7b296491390e9e42359cd479f42..6e8f74b8a0fe834446aecab1b3cefe219b11c0df 100644
--- a/app/code/Magento/Usps/Model/Carrier.php
+++ b/app/code/Magento/Usps/Model/Carrier.php
@@ -145,7 +145,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C
* @param \Magento\Directory\Model\CountryFactory $countryFactory
* @param \Magento\Directory\Model\CurrencyFactory $currencyFactory
* @param \Magento\Directory\Helper\Data $directoryData
- * @param \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService
+ * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry
* @param \Magento\Shipping\Helper\Carrier $carrierHelper
* @param \Magento\Catalog\Model\Resource\Product\CollectionFactory $productCollectionFactory
* @param \Magento\Framework\HTTP\ZendClientFactory $httpClientFactory
@@ -167,7 +167,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C
\Magento\Directory\Model\CountryFactory $countryFactory,
\Magento\Directory\Model\CurrencyFactory $currencyFactory,
\Magento\Directory\Helper\Data $directoryData,
- \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService,
+ \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
CarrierHelper $carrierHelper,
\Magento\Catalog\Model\Resource\Product\CollectionFactory $productCollectionFactory,
\Magento\Framework\HTTP\ZendClientFactory $httpClientFactory,
@@ -190,7 +190,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C
$countryFactory,
$currencyFactory,
$directoryData,
- $stockItemService,
+ $stockRegistry,
$data
);
}
diff --git a/app/code/Magento/Usps/composer.json b/app/code/Magento/Usps/composer.json
index bff4187f43b38f426994d4756e779231f8cc2065..84192b0801d13e4895507f19c62cb49a6cb9a10f 100644
--- a/app/code/Magento/Usps/composer.json
+++ b/app/code/Magento/Usps/composer.json
@@ -3,19 +3,19 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-shipping": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-shipping": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"lib-libxml": "*",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Webapi/Controller/Request.php b/app/code/Magento/Webapi/Controller/Request.php
index 0a53badc0c12a8458565c8fa57ae8456c315148f..aaad13016ddaf07abed33741ca4256a8a5b213bc 100644
--- a/app/code/Magento/Webapi/Controller/Request.php
+++ b/app/code/Magento/Webapi/Controller/Request.php
@@ -31,7 +31,7 @@ class Request extends \Zend_Controller_Request_Http implements \Magento\Framewor
protected $_consumerId = 0;
/**
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $_cookieManager;
@@ -40,13 +40,13 @@ class Request extends \Zend_Controller_Request_Http implements \Magento\Framewor
*
* @param \Magento\Framework\App\AreaList $areaList
* @param \Magento\Framework\Config\ScopeInterface $configScope
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param null|string|\Zend_Uri $uri
*/
public function __construct(
\Magento\Framework\App\AreaList $areaList,
\Magento\Framework\Config\ScopeInterface $configScope,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
$uri = null
) {
parent::__construct($uri);
diff --git a/app/code/Magento/Webapi/Controller/Rest.php b/app/code/Magento/Webapi/Controller/Rest.php
index 8160f5d95ed0fa5152e7e7d2062669cb493ebce7..763b6fbc470c785afab51af20244b99d6e9f69ab 100644
--- a/app/code/Magento/Webapi/Controller/Rest.php
+++ b/app/code/Magento/Webapi/Controller/Rest.php
@@ -57,7 +57,7 @@ class Rest implements \Magento\Framework\App\FrontControllerInterface
/** @var RestResponse */
protected $_response;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
protected $_objectManager;
/** @var \Magento\Framework\App\State */
@@ -106,7 +106,7 @@ class Rest implements \Magento\Framework\App\FrontControllerInterface
* @param RestRequest $request
* @param RestResponse $response
* @param Router $router
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\App\State $appState
* @param AuthorizationInterface $authorization
* @param ServiceArgsSerializer $serializer
@@ -124,7 +124,7 @@ class Rest implements \Magento\Framework\App\FrontControllerInterface
RestRequest $request,
RestResponse $response,
Router $router,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\App\State $appState,
AuthorizationInterface $authorization,
ServiceArgsSerializer $serializer,
diff --git a/app/code/Magento/Webapi/Controller/Rest/Request.php b/app/code/Magento/Webapi/Controller/Rest/Request.php
index e94c5a813389fc0e7066af9cd728e86c57ea27b7..15445e24381b167a49908be60ce6b10805d5c79f 100644
--- a/app/code/Magento/Webapi/Controller/Rest/Request.php
+++ b/app/code/Magento/Webapi/Controller/Rest/Request.php
@@ -56,14 +56,14 @@ class Request extends \Magento\Webapi\Controller\Request
*
* @param \Magento\Framework\App\AreaList $areaList
* @param \Magento\Framework\Config\ScopeInterface $configScope
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Webapi\Controller\Rest\Request\Deserializer\Factory $deserializerFactory
* @param null|string $uri
*/
public function __construct(
\Magento\Framework\App\AreaList $areaList,
\Magento\Framework\Config\ScopeInterface $configScope,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Webapi\Controller\Rest\Request\Deserializer\Factory $deserializerFactory,
$uri = null
) {
diff --git a/app/code/Magento/Webapi/Controller/Rest/Request/Deserializer/Factory.php b/app/code/Magento/Webapi/Controller/Rest/Request/Deserializer/Factory.php
index 65a2cf924fe5aa501fd0e7f42bd9f73765a411d7..2cecdd965321ec98ec8fdf4cb413945650f215ef 100644
--- a/app/code/Magento/Webapi/Controller/Rest/Request/Deserializer/Factory.php
+++ b/app/code/Magento/Webapi/Controller/Rest/Request/Deserializer/Factory.php
@@ -28,7 +28,7 @@ namespace Magento\Webapi\Controller\Rest\Request\Deserializer;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -38,11 +38,13 @@ class Factory
protected $_deserializers;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $deserializers
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, array $deserializers = array())
- {
+ public function __construct(
+ \Magento\Framework\ObjectManagerInterface $objectManager,
+ array $deserializers = array()
+ ) {
$this->_objectManager = $objectManager;
$this->_deserializers = $deserializers;
}
diff --git a/app/code/Magento/Webapi/Controller/Rest/Response/DataObjectConverter.php b/app/code/Magento/Webapi/Controller/Rest/Response/DataObjectConverter.php
index 8fb3242d983850f0a87e2b4646ade3da01223643..ff47ba8bfb35065e1c43ff300e33cf2049365dc6 100644
--- a/app/code/Magento/Webapi/Controller/Rest/Response/DataObjectConverter.php
+++ b/app/code/Magento/Webapi/Controller/Rest/Response/DataObjectConverter.php
@@ -21,7 +21,6 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-
namespace Magento\Webapi\Controller\Rest\Response;
use Magento\Framework\Api\AbstractExtensibleObject;
diff --git a/app/code/Magento/Webapi/Controller/Rest/Response/Renderer/Factory.php b/app/code/Magento/Webapi/Controller/Rest/Response/Renderer/Factory.php
index 3ec3b2bc855f8b7d80f8b3ca740274a2012420a4..315b259cb48cc57fd2bf00fa47ab6c4f9c97c124 100644
--- a/app/code/Magento/Webapi/Controller/Rest/Response/Renderer/Factory.php
+++ b/app/code/Magento/Webapi/Controller/Rest/Response/Renderer/Factory.php
@@ -28,7 +28,7 @@ namespace Magento\Webapi\Controller\Rest\Response\Renderer;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -41,12 +41,12 @@ class Factory
protected $_renders;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Webapi\Controller\Rest\Request $request
* @param array $renders
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Webapi\Controller\Rest\Request $request,
array $renders = array()
) {
diff --git a/app/code/Magento/Webapi/Controller/ServiceArgsSerializer.php b/app/code/Magento/Webapi/Controller/ServiceArgsSerializer.php
index a582647d7ddbb835efa3994e61700379a32a7291..e00cf22c644356c889cd0a7f9b67b0820cc6bc09 100644
--- a/app/code/Magento/Webapi/Controller/ServiceArgsSerializer.php
+++ b/app/code/Magento/Webapi/Controller/ServiceArgsSerializer.php
@@ -25,8 +25,8 @@
*/
namespace Magento\Webapi\Controller;
-use Magento\Framework\ObjectManager;
-use Magento\Framework\ObjectManager\Config as ObjectManagerConfig;
+use Magento\Framework\ObjectManagerInterface;
+use Magento\Framework\ObjectManager\ConfigInterface as ObjectManagerConfig;
use Magento\Framework\Api\Config\Reader as ServiceConfigReader;
use Magento\Framework\Api\AttributeValue;
use Magento\Framework\Api\AttributeDataBuilder;
diff --git a/app/code/Magento/Webapi/Controller/Soap/Request/Handler.php b/app/code/Magento/Webapi/Controller/Soap/Request/Handler.php
index aa5e525823f5dcd322b66c03f976dd1c9c3b5036..2e368a55c04e2e3954c2d1f26d8137ec53416850 100644
--- a/app/code/Magento/Webapi/Controller/Soap/Request/Handler.php
+++ b/app/code/Magento/Webapi/Controller/Soap/Request/Handler.php
@@ -48,7 +48,7 @@ class Handler
/** @var SoapRequest */
protected $_request;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
protected $_objectManager;
/** @var SoapConfig */
@@ -70,7 +70,7 @@ class Handler
* Initialize dependencies.
*
* @param SoapRequest $request
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param SoapConfig $apiConfig
* @param AuthorizationInterface $authorization
* @param SimpleDataObjectConverter $dataObjectConverter
@@ -79,7 +79,7 @@ class Handler
*/
public function __construct(
SoapRequest $request,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
SoapConfig $apiConfig,
AuthorizationInterface $authorization,
SimpleDataObjectConverter $dataObjectConverter,
@@ -168,7 +168,7 @@ class Handler
/** @var string $dataType */
$dataType = $this->_dataObjectProcessor->getMethodReturnType($serviceClassName, $serviceMethodName);
$result = null;
- if ($data instanceof ExtensibleDataInterface) {
+ if (is_object($data)) {
$result = $this->_dataObjectConverter
->convertKeysToCamelCase($this->_dataObjectProcessor->buildOutputDataArray($data, $dataType));
} elseif (is_array($data)) {
diff --git a/app/code/Magento/Webapi/Helper/Data.php b/app/code/Magento/Webapi/Helper/Data.php
index f177aac385b0b7bdec754662a1590f31c99486b8..ba11ef394aa0816334bc60614af8b0a211fcf18d 100644
--- a/app/code/Magento/Webapi/Helper/Data.php
+++ b/app/code/Magento/Webapi/Helper/Data.php
@@ -26,6 +26,10 @@ namespace Magento\Webapi\Helper;
use Magento\Integration\Controller\Adminhtml\Integration as IntegrationController;
use Magento\Framework\Api\AbstractExtensibleObject;
+/**
+ * Class Data
+ * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+ */
class Data extends \Magento\Framework\App\Helper\AbstractHelper
{
/** @var \Magento\Framework\Registry */
@@ -92,10 +96,19 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
*/
public function getServiceNameParts($className, $preserveVersion = false)
{
- if (preg_match(\Magento\Webapi\Model\Config::SERVICE_CLASS_PATTERN, $className, $matches)) {
+ if (!preg_match(\Magento\Webapi\Model\Config::SERVICE_CLASS_PATTERN, $className, $matches)) {
+ $apiClassPattern = "#^(.+?)\\\\(.+?)\\\\Api\\\\(.+?)(Interface)?$#";
+ preg_match($apiClassPattern, $className, $matches);
+ }
+
+ if (!empty($matches)) {
$moduleNamespace = $matches[1];
$moduleName = $matches[2];
$moduleNamespace = ($moduleNamespace == 'Magento') ? '' : $moduleNamespace;
+ if ($matches[4] === 'Interface') {
+ $matches[4] = $matches[3];
+ $matches[3] = 'V1';
+ }
$serviceNameParts = explode('\\', trim($matches[4], '\\'));
if ($moduleName == $serviceNameParts[0]) {
/** Avoid duplication of words in service name */
@@ -123,6 +136,7 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
$serviceNameParts[] = 'V1';
return $serviceNameParts;
}
+
throw new \InvalidArgumentException(sprintf('The service interface name "%s" is invalid.', $className));
}
}
diff --git a/app/code/Magento/Webapi/Model/Soap/Config.php b/app/code/Magento/Webapi/Model/Soap/Config.php
index f8a109e797c0992741876e76c9c3abd3c0ee5dfb..a69646860d9bb953f9f44504d115738cfde66ac0 100644
--- a/app/code/Magento/Webapi/Model/Soap/Config.php
+++ b/app/code/Magento/Webapi/Model/Soap/Config.php
@@ -55,7 +55,7 @@ class Config
/** @var \Magento\Webapi\Model\Config */
protected $_config;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
protected $_objectManager;
/**
@@ -82,14 +82,14 @@ class Config
/**
* Initialize dependencies.
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Filesystem $filesystem
* @param \Magento\Webapi\Model\Config $config
* @param \Magento\Webapi\Model\Config\ClassReflector $classReflector
* @param \Magento\Webapi\Helper\Data $helper
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Filesystem $filesystem,
\Magento\Webapi\Model\Config $config,
\Magento\Webapi\Model\Config\ClassReflector $classReflector,
diff --git a/app/code/Magento/Webapi/Model/Soap/Server/Factory.php b/app/code/Magento/Webapi/Model/Soap/Server/Factory.php
index b22d33ed258463929aed166101032a6f8104e902..c790dc2dea1117334b44eb36233d79ac3ad1c7e5 100644
--- a/app/code/Magento/Webapi/Model/Soap/Server/Factory.php
+++ b/app/code/Magento/Webapi/Model/Soap/Server/Factory.php
@@ -28,7 +28,7 @@ namespace Magento\Webapi\Model\Soap\Server;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -40,11 +40,11 @@ class Factory
/**
* Initialize the class
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Webapi\Controller\Soap\Request\Handler $soapHandler
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Webapi\Controller\Soap\Request\Handler $soapHandler
) {
$this->_objectManager = $objectManager;
diff --git a/app/code/Magento/Webapi/Model/Soap/Wsdl/Factory.php b/app/code/Magento/Webapi/Model/Soap/Wsdl/Factory.php
index 484e18d11f5be4b1e12848bbd6537e2c76cb4497..64d2506681e02368141fb3c48aa1014d3ad37082 100644
--- a/app/code/Magento/Webapi/Model/Soap/Wsdl/Factory.php
+++ b/app/code/Magento/Webapi/Model/Soap/Wsdl/Factory.php
@@ -29,14 +29,14 @@ namespace Magento\Webapi\Model\Soap\Wsdl;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Webapi/Model/WebapiRoleLocator.php b/app/code/Magento/Webapi/Model/WebapiRoleLocator.php
index 7aa122d2a03d95c3a72ef50428a92cffb272dc45..4bdb0a7b9191154bef3f79323388bcd1595786d4 100644
--- a/app/code/Magento/Webapi/Model/WebapiRoleLocator.php
+++ b/app/code/Magento/Webapi/Model/WebapiRoleLocator.php
@@ -25,11 +25,11 @@
namespace Magento\Webapi\Model;
use Magento\Authorization\Model\UserContextInterface;
-use Magento\Framework\Authorization\RoleLocator;
+use Magento\Framework\Authorization\RoleLocatorInterface;
use Magento\Authorization\Model\Role;
use Magento\Authorization\Model\Resource\Role\CollectionFactory as RoleCollectionFactory;
-class WebapiRoleLocator implements RoleLocator
+class WebapiRoleLocator implements RoleLocatorInterface
{
/**
* @var UserContextInterface
diff --git a/app/code/Magento/Webapi/composer.json b/app/code/Magento/Webapi/composer.json
index 34a208debd1e67fa50163e2c5ece21f950d51feb..5b95e96c4226acf390f85177d28929d12e09ed42 100644
--- a/app/code/Magento/Webapi/composer.json
+++ b/app/code/Magento/Webapi/composer.json
@@ -3,17 +3,17 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-authorization": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-integration": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-user": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-authorization": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-integration": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-user": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Webapi/etc/webapi_rest/di.xml b/app/code/Magento/Webapi/etc/webapi_rest/di.xml
index df47064738db5fa95528ebfb880587d63ac0e294..d9e6744933925c384e2a8ab8d137908989586622 100644
--- a/app/code/Magento/Webapi/etc/webapi_rest/di.xml
+++ b/app/code/Magento/Webapi/etc/webapi_rest/di.xml
@@ -85,7 +85,7 @@
<argument name="oauthHelper" xsi:type="object">Magento\Framework\Oauth\Helper\Request\Proxy</argument>
</arguments>
</type>
- <preference for="Magento\Framework\Authorization\RoleLocator" type="Magento\Webapi\Model\WebapiRoleLocator" />
+ <preference for="Magento\Framework\Authorization\RoleLocatorInterface" type="Magento\Webapi\Model\WebapiRoleLocator" />
<type name="Magento\Framework\Authorization">
<plugin name="guestAuthorization" type="Magento\Webapi\Model\Plugin\GuestAuthorization" />
</type>
diff --git a/app/code/Magento/Webapi/etc/webapi_soap/di.xml b/app/code/Magento/Webapi/etc/webapi_soap/di.xml
index 55ab39e818c44197abdd88a6c680f98da2b88b81..e8806b2778aa345d62f35856fa063367874c6de3 100644
--- a/app/code/Magento/Webapi/etc/webapi_soap/di.xml
+++ b/app/code/Magento/Webapi/etc/webapi_soap/di.xml
@@ -53,7 +53,7 @@
<argument name="errorProcessor" xsi:type="object">Magento\Webapi\Controller\ErrorProcessor\Proxy</argument>
</arguments>
</type>
- <preference for="Magento\Framework\Authorization\RoleLocator" type="Magento\Webapi\Model\WebapiRoleLocator" />
+ <preference for="Magento\Framework\Authorization\RoleLocatorInterface" type="Magento\Webapi\Model\WebapiRoleLocator" />
<type name="Magento\Framework\Authorization">
<plugin name="guestAuthorization" type="Magento\Webapi\Model\Plugin\GuestAuthorization" />
</type>
diff --git a/app/code/Magento/Weee/Helper/Data.php b/app/code/Magento/Weee/Helper/Data.php
index 7fb3729b99b7785fcbc1cdda456b1f2b728da8ea..86a0fd688134f13648d1d6e078affcb9d51b69bd 100644
--- a/app/code/Magento/Weee/Helper/Data.php
+++ b/app/code/Magento/Weee/Helper/Data.php
@@ -588,7 +588,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
$totalAmountInvoiced = 0;
foreach ($weeeTaxAppliedAmounts as $weeeTaxAppliedAmount) {
if (isset($weeeTaxAppliedAmount[self::KEY_WEEE_AMOUNT_INVOICED])) {
- $totalAmountInvoiced += $weeeTaxAppliedAmount[self::KEY_WEEE_AMOUNT_INVOICED];
+ $totalAmountInvoiced = $weeeTaxAppliedAmount[self::KEY_WEEE_AMOUNT_INVOICED];
+ break;
}
}
return $totalAmountInvoiced;
@@ -604,7 +605,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
$baseTotalAmountInvoiced = 0;
foreach ($weeeTaxAppliedAmounts as $weeeTaxAppliedAmount) {
if (isset($weeeTaxAppliedAmount[self::KEY_BASE_WEEE_AMOUNT_INVOICED])) {
- $baseTotalAmountInvoiced += $weeeTaxAppliedAmount[self::KEY_BASE_WEEE_AMOUNT_INVOICED];
+ $baseTotalAmountInvoiced = $weeeTaxAppliedAmount[self::KEY_BASE_WEEE_AMOUNT_INVOICED];
+ break;
}
}
return $baseTotalAmountInvoiced;
@@ -620,7 +622,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
$totalTaxInvoiced = 0;
foreach ($weeeTaxAppliedAmounts as $weeeTaxAppliedAmount) {
if (isset($weeeTaxAppliedAmount[self::KEY_WEEE_TAX_AMOUNT_INVOICED])) {
- $totalTaxInvoiced += $weeeTaxAppliedAmount[self::KEY_WEEE_TAX_AMOUNT_INVOICED];
+ $totalTaxInvoiced = $weeeTaxAppliedAmount[self::KEY_WEEE_TAX_AMOUNT_INVOICED];
+ break;
}
}
return $totalTaxInvoiced;
@@ -636,7 +639,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
$baseTotalTaxInvoiced = 0;
foreach ($weeeTaxAppliedAmounts as $weeeTaxAppliedAmount) {
if (isset($weeeTaxAppliedAmount[self::KEY_BASE_WEEE_TAX_AMOUNT_INVOICED])) {
- $baseTotalTaxInvoiced += $weeeTaxAppliedAmount[self::KEY_BASE_WEEE_TAX_AMOUNT_INVOICED];
+ $baseTotalTaxInvoiced = $weeeTaxAppliedAmount[self::KEY_BASE_WEEE_TAX_AMOUNT_INVOICED];
+ break;
}
}
return $baseTotalTaxInvoiced;
@@ -652,7 +656,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
$totalAmountRefunded = 0;
foreach ($weeeTaxAppliedAmounts as $weeeTaxAppliedAmount) {
if (isset($weeeTaxAppliedAmount[self::KEY_WEEE_AMOUNT_REFUNDED])) {
- $totalAmountRefunded += $weeeTaxAppliedAmount[self::KEY_WEEE_AMOUNT_REFUNDED];
+ $totalAmountRefunded = $weeeTaxAppliedAmount[self::KEY_WEEE_AMOUNT_REFUNDED];
+ break;
}
}
return $totalAmountRefunded;
@@ -668,7 +673,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
$baseTotalAmountRefunded = 0;
foreach ($weeeTaxAppliedAmounts as $weeeTaxAppliedAmount) {
if (isset($weeeTaxAppliedAmount[self::KEY_BASE_WEEE_AMOUNT_REFUNDED])) {
- $baseTotalAmountRefunded += $weeeTaxAppliedAmount[self::KEY_BASE_WEEE_AMOUNT_REFUNDED];
+ $baseTotalAmountRefunded = $weeeTaxAppliedAmount[self::KEY_BASE_WEEE_AMOUNT_REFUNDED];
+ break;
}
}
return $baseTotalAmountRefunded;
@@ -684,7 +690,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
$totalTaxRefunded = 0;
foreach ($weeeTaxAppliedAmounts as $weeeTaxAppliedAmount) {
if (isset($weeeTaxAppliedAmount[self::KEY_WEEE_TAX_AMOUNT_REFUNDED])) {
- $totalTaxRefunded += $weeeTaxAppliedAmount[self::KEY_WEEE_TAX_AMOUNT_REFUNDED];
+ $totalTaxRefunded = $weeeTaxAppliedAmount[self::KEY_WEEE_TAX_AMOUNT_REFUNDED];
+ break;
}
}
return $totalTaxRefunded;
@@ -700,7 +707,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper
$baseTotalTaxRefunded = 0;
foreach ($weeeTaxAppliedAmounts as $weeeTaxAppliedAmount) {
if (isset($weeeTaxAppliedAmount[self::KEY_BASE_WEEE_TAX_AMOUNT_REFUNDED])) {
- $baseTotalTaxRefunded += $weeeTaxAppliedAmount[self::KEY_BASE_WEEE_TAX_AMOUNT_REFUNDED];
+ $baseTotalTaxRefunded = $weeeTaxAppliedAmount[self::KEY_BASE_WEEE_TAX_AMOUNT_REFUNDED];
+ break;
}
}
return $baseTotalTaxRefunded;
diff --git a/app/code/Magento/Weee/Model/Total/Creditmemo/Weee.php b/app/code/Magento/Weee/Model/Total/Creditmemo/Weee.php
index 3f77edaa0a661c4e03d901945f315d8cff3d3f62..02421aa93ea83ab5c7d71715a25ed749ae4df5b1 100644
--- a/app/code/Magento/Weee/Model/Total/Creditmemo/Weee.php
+++ b/app/code/Magento/Weee/Model/Total/Creditmemo/Weee.php
@@ -144,12 +144,16 @@ class Weee extends \Magento\Sales\Model\Order\Creditmemo\Total\AbstractTotal
$baseTotalWeeeAmountInclTax += $baseWeeeAmountInclTax;
$newApplied = array();
- $applied = $this->_weeeData->getApplied($item);
+ $applied = $this->_weeeData->getApplied($orderItem);
foreach ($applied as $one) {
- $one['base_row_amount'] = $baseWeeeAmountExclTax;
- $one['row_amount'] = $weeeAmountExclTax;
- $one['base_row_amount_incl_tax'] = $baseWeeeAmountInclTax;
- $one['row_amount_incl_tax'] = $weeeAmountInclTax;
+ $title = $one['title'];
+ $one['base_row_amount'] = $creditmemo->roundPrice($one['base_row_amount'] * $ratio, $title . '_base');
+ $one['row_amount'] = $creditmemo->roundPrice($one['row_amount'] * $ratio, $title);
+ $one['base_row_amount_incl_tax'] = $creditmemo->roundPrice(
+ $one['base_row_amount_incl_tax'] * $ratio,
+ $title . '_base'
+ );
+ $one['row_amount_incl_tax'] = $creditmemo->roundPrice($one['row_amount_incl_tax'] * $ratio, $title);
$newApplied[] = $one;
}
diff --git a/app/code/Magento/Weee/Model/Total/Invoice/Weee.php b/app/code/Magento/Weee/Model/Total/Invoice/Weee.php
index 114b10d61f8f172f8390706580b97de83e33b2b7..b34c512732e77704860b30ee20d6cf63f0582be0 100644
--- a/app/code/Magento/Weee/Model/Total/Invoice/Weee.php
+++ b/app/code/Magento/Weee/Model/Total/Invoice/Weee.php
@@ -117,12 +117,16 @@ class Weee extends \Magento\Sales\Model\Order\Invoice\Total\AbstractTotal
$item->setWeeeTaxAppliedRowAmount($weeeAmount);
$item->setBaseWeeeTaxAppliedRowAmount($baseWeeeAmount);
$newApplied = array();
- $applied = $this->_weeeData->getApplied($item);
+ $applied = $this->_weeeData->getApplied($orderItem);
foreach ($applied as $one) {
- $one['base_row_amount'] = $baseWeeeAmount;
- $one['row_amount'] = $weeeAmount;
- $one['base_row_amount_incl_tax'] = $baseWeeeAmountInclTax;
- $one['row_amount_incl_tax'] = $weeeAmountInclTax;
+ $title = $one['title'];
+ $one['base_row_amount'] = $invoice->roundPrice($one['base_row_amount'] * $ratio, $title . '_base');
+ $one['row_amount'] = $invoice->roundPrice($one['row_amount'] * $ratio, $title);
+ $one['base_row_amount_incl_tax'] = $invoice->roundPrice(
+ $one['base_row_amount_incl_tax'] * $ratio,
+ $title . '_base'
+ );
+ $one['row_amount_incl_tax'] = $invoice->roundPrice($one['row_amount_incl_tax'] * $ratio, $title);
$newApplied[] = $one;
}
diff --git a/app/code/Magento/Weee/composer.json b/app/code/Magento/Weee/composer.json
index aa73fea5c9fc60713708cceb4978934fd929f560..7a45e8eab2ed62a12dce849e6cf3959773745b69 100644
--- a/app/code/Magento/Weee/composer.json
+++ b/app/code/Magento/Weee/composer.json
@@ -3,21 +3,21 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-tax": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-directory": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-eav": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-bundle": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-tax": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-directory": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-eav": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-bundle": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Weee/data/weee_setup/data-install-1.6.0.0.php b/app/code/Magento/Weee/data/weee_setup/data-install-1.6.0.0.php
deleted file mode 100644
index b5e2ce84991006151487f622efb3ac359835832e..0000000000000000000000000000000000000000
--- a/app/code/Magento/Weee/data/weee_setup/data-install-1.6.0.0.php
+++ /dev/null
@@ -1,68 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-/** @var $installer \Magento\Sales\Model\Resource\Setup */
-$installer = $this;
-
-$installer->addAttribute('order_item', 'base_weee_tax_applied_amount', array('type' => 'decimal'));
-$installer->addAttribute('order_item', 'base_weee_tax_applied_row_amnt', array('type' => 'decimal'));
-$installer->addAttribute('order_item', 'weee_tax_applied_amount', array('type' => 'decimal'));
-$installer->addAttribute('order_item', 'weee_tax_applied_row_amount', array('type' => 'decimal'));
-$installer->addAttribute('order_item', 'weee_tax_applied', array('type' => 'text'));
-
-$installer->addAttribute('quote_item', 'weee_tax_disposition', array('type' => 'decimal'));
-$installer->addAttribute('quote_item', 'weee_tax_row_disposition', array('type' => 'decimal'));
-$installer->addAttribute('quote_item', 'base_weee_tax_disposition', array('type' => 'decimal'));
-$installer->addAttribute('quote_item', 'base_weee_tax_row_disposition', array('type' => 'decimal'));
-
-$installer->addAttribute('order_item', 'weee_tax_disposition', array('type' => 'decimal'));
-$installer->addAttribute('order_item', 'weee_tax_row_disposition', array('type' => 'decimal'));
-$installer->addAttribute('order_item', 'base_weee_tax_disposition', array('type' => 'decimal'));
-$installer->addAttribute('order_item', 'base_weee_tax_row_disposition', array('type' => 'decimal'));
-
-$installer->addAttribute('invoice_item', 'base_weee_tax_applied_amount', array('type' => 'decimal'));
-$installer->addAttribute('invoice_item', 'base_weee_tax_applied_row_amnt', array('type' => 'decimal'));
-$installer->addAttribute('invoice_item', 'weee_tax_applied_amount', array('type' => 'decimal'));
-$installer->addAttribute('invoice_item', 'weee_tax_applied_row_amount', array('type' => 'decimal'));
-$installer->addAttribute('invoice_item', 'weee_tax_applied', array('type' => 'text'));
-$installer->addAttribute('invoice_item', 'weee_tax_disposition', array('type' => 'decimal'));
-$installer->addAttribute('invoice_item', 'weee_tax_row_disposition', array('type' => 'decimal'));
-$installer->addAttribute('invoice_item', 'base_weee_tax_disposition', array('type' => 'decimal'));
-$installer->addAttribute('invoice_item', 'base_weee_tax_row_disposition', array('type' => 'decimal'));
-
-$installer->addAttribute('quote_item', 'weee_tax_applied', array('type' => 'text'));
-$installer->addAttribute('quote_item', 'weee_tax_applied_amount', array('type' => 'decimal'));
-$installer->addAttribute('quote_item', 'weee_tax_applied_row_amount', array('type' => 'decimal'));
-$installer->addAttribute('quote_item', 'base_weee_tax_applied_amount', array('type' => 'decimal'));
-$installer->addAttribute('quote_item', 'base_weee_tax_applied_row_amnt', array('type' => 'decimal'));
-
-$installer->addAttribute('creditmemo_item', 'weee_tax_disposition', array('type' => 'decimal'));
-$installer->addAttribute('creditmemo_item', 'weee_tax_row_disposition', array('type' => 'decimal'));
-$installer->addAttribute('creditmemo_item', 'base_weee_tax_disposition', array('type' => 'decimal'));
-$installer->addAttribute('creditmemo_item', 'base_weee_tax_row_disposition', array('type' => 'decimal'));
-$installer->addAttribute('creditmemo_item', 'weee_tax_applied', array('type' => 'text'));
-$installer->addAttribute('creditmemo_item', 'base_weee_tax_applied_amount', array('type' => 'decimal'));
-$installer->addAttribute('creditmemo_item', 'base_weee_tax_applied_row_amnt', array('type' => 'decimal'));
-$installer->addAttribute('creditmemo_item', 'weee_tax_applied_amount', array('type' => 'decimal'));
-$installer->addAttribute('creditmemo_item', 'weee_tax_applied_row_amount', array('type' => 'decimal'));
diff --git a/app/code/Magento/Weee/data/weee_setup/data-install-2.0.0.php b/app/code/Magento/Weee/data/weee_setup/data-install-2.0.0.php
new file mode 100644
index 0000000000000000000000000000000000000000..bca5be25046e8f6b618d5830a54a273d1ff957a2
--- /dev/null
+++ b/app/code/Magento/Weee/data/weee_setup/data-install-2.0.0.php
@@ -0,0 +1,65 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+/** @var $this \Magento\Sales\Model\Resource\Setup */
+
+$this->addAttribute('quote_item', 'weee_tax_applied', array('type' => 'text'));
+$this->addAttribute('quote_item', 'weee_tax_applied_amount', array('type' => 'decimal'));
+$this->addAttribute('quote_item', 'weee_tax_applied_row_amount', array('type' => 'decimal'));
+$this->addAttribute('quote_item', 'weee_tax_disposition', array('type' => 'decimal'));
+$this->addAttribute('quote_item', 'weee_tax_row_disposition', array('type' => 'decimal'));
+$this->addAttribute('quote_item', 'base_weee_tax_applied_amount', array('type' => 'decimal'));
+$this->addAttribute('quote_item', 'base_weee_tax_applied_row_amnt', array('type' => 'decimal'));
+$this->addAttribute('quote_item', 'base_weee_tax_disposition', array('type' => 'decimal'));
+$this->addAttribute('quote_item', 'base_weee_tax_row_disposition', array('type' => 'decimal'));
+
+$this->addAttribute('order_item', 'weee_tax_applied', array('type' => 'text'));
+$this->addAttribute('order_item', 'weee_tax_applied_amount', array('type' => 'decimal'));
+$this->addAttribute('order_item', 'weee_tax_applied_row_amount', array('type' => 'decimal'));
+$this->addAttribute('order_item', 'weee_tax_disposition', array('type' => 'decimal'));
+$this->addAttribute('order_item', 'weee_tax_row_disposition', array('type' => 'decimal'));
+$this->addAttribute('order_item', 'base_weee_tax_applied_amount', array('type' => 'decimal'));
+$this->addAttribute('order_item', 'base_weee_tax_applied_row_amnt', array('type' => 'decimal'));
+$this->addAttribute('order_item', 'base_weee_tax_disposition', array('type' => 'decimal'));
+$this->addAttribute('order_item', 'base_weee_tax_row_disposition', array('type' => 'decimal'));
+
+$this->addAttribute('invoice_item', 'weee_tax_applied', array('type' => 'text'));
+$this->addAttribute('invoice_item', 'weee_tax_applied_amount', array('type' => 'decimal'));
+$this->addAttribute('invoice_item', 'weee_tax_applied_row_amount', array('type' => 'decimal'));
+$this->addAttribute('invoice_item', 'weee_tax_disposition', array('type' => 'decimal'));
+$this->addAttribute('invoice_item', 'weee_tax_row_disposition', array('type' => 'decimal'));
+$this->addAttribute('invoice_item', 'base_weee_tax_applied_amount', array('type' => 'decimal'));
+$this->addAttribute('invoice_item', 'base_weee_tax_applied_row_amnt', array('type' => 'decimal'));
+$this->addAttribute('invoice_item', 'base_weee_tax_disposition', array('type' => 'decimal'));
+$this->addAttribute('invoice_item', 'base_weee_tax_row_disposition', array('type' => 'decimal'));
+
+$this->addAttribute('creditmemo_item', 'weee_tax_applied', array('type' => 'text'));
+$this->addAttribute('creditmemo_item', 'weee_tax_applied_amount', array('type' => 'decimal'));
+$this->addAttribute('creditmemo_item', 'weee_tax_applied_row_amount', array('type' => 'decimal'));
+$this->addAttribute('creditmemo_item', 'weee_tax_disposition', array('type' => 'decimal'));
+$this->addAttribute('creditmemo_item', 'weee_tax_row_disposition', array('type' => 'decimal'));
+$this->addAttribute('creditmemo_item', 'base_weee_tax_applied_amount', array('type' => 'decimal'));
+$this->addAttribute('creditmemo_item', 'base_weee_tax_applied_row_amnt', array('type' => 'decimal'));
+$this->addAttribute('creditmemo_item', 'base_weee_tax_disposition', array('type' => 'decimal'));
+$this->addAttribute('creditmemo_item', 'base_weee_tax_row_disposition', array('type' => 'decimal'));
diff --git a/app/code/Magento/Weee/etc/module.xml b/app/code/Magento/Weee/etc/module.xml
index 7cfebef72988d1a8f5f2c98b457b5f46328782f2..2af8dedcd8df4a4003bfe91d1ab9816e661dbf49 100644
--- a/app/code/Magento/Weee/etc/module.xml
+++ b/app/code/Magento/Weee/etc/module.xml
@@ -24,7 +24,7 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
- <module name="Magento_Weee" schema_version="1.6.0.0" active="true">
+ <module name="Magento_Weee" schema_version="2.0.0" active="true">
<sequence>
<module name="Magento_Catalog"/>
<module name="Magento_Tax"/>
diff --git a/app/code/Magento/Weee/sql/weee_setup/install-1.6.0.0.php b/app/code/Magento/Weee/sql/weee_setup/install-2.0.0.php
similarity index 71%
rename from app/code/Magento/Weee/sql/weee_setup/install-1.6.0.0.php
rename to app/code/Magento/Weee/sql/weee_setup/install-2.0.0.php
index 842fc4fb4bbd5bd8026c111596d9d42837034136..77894a8f2171205eef5f286767bed74c70a2dbc6 100644
--- a/app/code/Magento/Weee/sql/weee_setup/install-1.6.0.0.php
+++ b/app/code/Magento/Weee/sql/weee_setup/install-2.0.0.php
@@ -22,14 +22,13 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-/** @var $installer \Magento\Setup\Module\SetupModule */
-$installer = $this;
-$installer->startSetup();
+/** @var $this \Magento\Setup\Module\SetupModule */
+$this->startSetup();
/**
* Create table 'weee_tax'
*/
-$table = $installer->getConnection()->newTable(
- $installer->getTable('weee_tax')
+$table = $this->getConnection()->newTable(
+ $this->getTable('weee_tax')
)->addColumn(
'value_id',
\Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
@@ -79,55 +78,55 @@ $table = $installer->getConnection()->newTable(
array('unsigned' => true, 'nullable' => false),
'Entity Type Id'
)->addIndex(
- $installer->getIdxName('weee_tax', array('website_id')),
+ $this->getIdxName('weee_tax', array('website_id')),
array('website_id')
)->addIndex(
- $installer->getIdxName('weee_tax', array('entity_id')),
+ $this->getIdxName('weee_tax', array('entity_id')),
array('entity_id')
)->addIndex(
- $installer->getIdxName('weee_tax', array('country')),
+ $this->getIdxName('weee_tax', array('country')),
array('country')
)->addIndex(
- $installer->getIdxName('weee_tax', array('attribute_id')),
+ $this->getIdxName('weee_tax', array('attribute_id')),
array('attribute_id')
)->addForeignKey(
- $installer->getFkName('weee_tax', 'country', 'directory_country', 'country_id'),
+ $this->getFkName('weee_tax', 'country', 'directory_country', 'country_id'),
'country',
- $installer->getTable('directory_country'),
+ $this->getTable('directory_country'),
'country_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->addForeignKey(
- $installer->getFkName('weee_tax', 'entity_id', 'catalog_product_entity', 'entity_id'),
+ $this->getFkName('weee_tax', 'entity_id', 'catalog_product_entity', 'entity_id'),
'entity_id',
- $installer->getTable('catalog_product_entity'),
+ $this->getTable('catalog_product_entity'),
'entity_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->addForeignKey(
- $installer->getFkName('weee_tax', 'website_id', 'store_website', 'website_id'),
+ $this->getFkName('weee_tax', 'website_id', 'store_website', 'website_id'),
'website_id',
- $installer->getTable('store_website'),
+ $this->getTable('store_website'),
'website_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->addForeignKey(
- $installer->getFkName('weee_tax', 'attribute_id', 'eav_attribute', 'attribute_id'),
+ $this->getFkName('weee_tax', 'attribute_id', 'eav_attribute', 'attribute_id'),
'attribute_id',
- $installer->getTable('eav_attribute'),
+ $this->getTable('eav_attribute'),
'attribute_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->setComment(
'Weee Tax'
);
-$installer->getConnection()->createTable($table);
+$this->getConnection()->createTable($table);
/**
* Create table 'weee_discount'
*/
-$table = $installer->getConnection()->newTable(
- $installer->getTable('weee_discount')
+$table = $this->getConnection()->newTable(
+ $this->getTable('weee_discount')
)->addColumn(
'entity_id',
\Magento\Framework\DB\Ddl\Table::TYPE_INTEGER,
@@ -153,38 +152,38 @@ $table = $installer->getConnection()->newTable(
array('nullable' => false, 'default' => '0.0000'),
'Value'
)->addIndex(
- $installer->getIdxName('weee_discount', array('website_id')),
+ $this->getIdxName('weee_discount', array('website_id')),
array('website_id')
)->addIndex(
- $installer->getIdxName('weee_discount', array('entity_id')),
+ $this->getIdxName('weee_discount', array('entity_id')),
array('entity_id')
)->addIndex(
- $installer->getIdxName('weee_discount', array('customer_group_id')),
+ $this->getIdxName('weee_discount', array('customer_group_id')),
array('customer_group_id')
)->addForeignKey(
- $installer->getFkName('weee_discount', 'customer_group_id', 'customer_group', 'customer_group_id'),
+ $this->getFkName('weee_discount', 'customer_group_id', 'customer_group', 'customer_group_id'),
'customer_group_id',
- $installer->getTable('customer_group'),
+ $this->getTable('customer_group'),
'customer_group_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->addForeignKey(
- $installer->getFkName('weee_discount', 'entity_id', 'catalog_product_entity', 'entity_id'),
+ $this->getFkName('weee_discount', 'entity_id', 'catalog_product_entity', 'entity_id'),
'entity_id',
- $installer->getTable('catalog_product_entity'),
+ $this->getTable('catalog_product_entity'),
'entity_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->addForeignKey(
- $installer->getFkName('weee_discount', 'website_id', 'store_website', 'website_id'),
+ $this->getFkName('weee_discount', 'website_id', 'store_website', 'website_id'),
'website_id',
- $installer->getTable('store_website'),
+ $this->getTable('store_website'),
'website_id',
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
)->setComment(
'Weee Discount'
);
-$installer->getConnection()->createTable($table);
+$this->getConnection()->createTable($table);
-$installer->endSetup();
+$this->endSetup();
diff --git a/app/code/Magento/Widget/Model/Widget/Instance/OptionsFactory.php b/app/code/Magento/Widget/Model/Widget/Instance/OptionsFactory.php
index 5a3f74bd9698ee740946b306de3a3782f1242f2a..092d4475f6f872d4d024201b41bd01d95de1ef5a 100644
--- a/app/code/Magento/Widget/Model/Widget/Instance/OptionsFactory.php
+++ b/app/code/Magento/Widget/Model/Widget/Instance/OptionsFactory.php
@@ -26,14 +26,14 @@ namespace Magento\Widget\Model\Widget\Instance;
class OptionsFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/app/code/Magento/Widget/composer.json b/app/code/Magento/Widget/composer.json
index 4758d09cccf2d49d1a5e8d72aaf6a0fee0b5b8f6..661670a9aa219670eb12bbd9e061d7d021253b25 100644
--- a/app/code/Magento/Widget/composer.json
+++ b/app/code/Magento/Widget/composer.json
@@ -3,16 +3,16 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-cms": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-cms": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Wishlist/Block/Customer/Sidebar.php b/app/code/Magento/Wishlist/Block/Customer/Sidebar.php
index 1c468a992d8ace692162c73c6394fe1620d47663..61878527b6add0cb91c923faf53b02841fb81d51 100644
--- a/app/code/Magento/Wishlist/Block/Customer/Sidebar.php
+++ b/app/code/Magento/Wishlist/Block/Customer/Sidebar.php
@@ -30,6 +30,8 @@
*/
namespace Magento\Wishlist\Block\Customer;
+use Magento\Customer\Model\Context;
+
class Sidebar extends \Magento\Wishlist\Block\AbstractBlock implements \Magento\Framework\View\Block\IdentityInterface
{
/**
@@ -77,7 +79,7 @@ class Sidebar extends \Magento\Wishlist\Block\AbstractBlock implements \Magento\
*/
public function getCanDisplayWishlist()
{
- return $this->httpContext->getValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH);
+ return $this->httpContext->getValue(Context::CONTEXT_AUTH);
}
/**
diff --git a/app/code/Magento/Wishlist/Controller/Index/Remove.php b/app/code/Magento/Wishlist/Controller/Index/Remove.php
index a508e995fda3947e375ca53d17f417a5b34a3ff7..01358aa49c64e1f58c10d5eb3feff45ccef8c321 100644
--- a/app/code/Magento/Wishlist/Controller/Index/Remove.php
+++ b/app/code/Magento/Wishlist/Controller/Index/Remove.php
@@ -76,8 +76,17 @@ class Remove extends Action\Action implements IndexInterface
}
$this->_objectManager->get('Magento\Wishlist\Helper\Data')->calculate();
-
- $url = $this->_redirect->getRedirectUrl($this->_url->getUrl('*/*'));
- $this->getResponse()->setRedirect($url);
+ $request = $this->getRequest();
+ $refererUrl = (string)$request->getServer('HTTP_REFERER');
+ $url = (string)$request->getParam(\Magento\Framework\App\Response\RedirectInterface::PARAM_NAME_REFERER_URL);
+ if ($url) {
+ $refererUrl = $url;
+ }
+ if ($request->getParam(\Magento\Framework\App\Action\Action::PARAM_NAME_URL_ENCODED) && $refererUrl) {
+ $redirectUrl = $refererUrl;
+ } else {
+ $redirectUrl = $this->_redirect->getRedirectUrl($this->_url->getUrl('*/*'));
+ }
+ $this->getResponse()->setRedirect($redirectUrl);
}
}
diff --git a/app/code/Magento/Wishlist/Model/Resource/Item/Collection.php b/app/code/Magento/Wishlist/Model/Resource/Item/Collection.php
index 3b4ef483802c322c39f4c0c99f2024072f9ad29e..97606ece55ab4587243c518e8bdf6c6b2819889b 100644
--- a/app/code/Magento/Wishlist/Model/Resource/Item/Collection.php
+++ b/app/code/Magento/Wishlist/Model/Resource/Item/Collection.php
@@ -94,9 +94,9 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac
/**
* Catalog inventory data
*
- * @var \Magento\CatalogInventory\Helper\Data
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface
*/
- protected $_inventoryData = null;
+ protected $stockConfiguration = null;
/**
* @var \Magento\Framework\StoreManagerInterface
@@ -153,7 +153,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac
* @param \Magento\Framework\Logger $logger
* @param \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy
* @param \Magento\Framework\Event\ManagerInterface $eventManager
- * @param \Magento\CatalogInventory\Helper\Data $catalogInventoryData
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\Sales\Helper\Admin $adminhtmlSales
* @param \Magento\Framework\StoreManagerInterface $storeManager
* @param \Magento\Framework\Stdlib\DateTime\DateTime $date
@@ -175,7 +175,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac
\Magento\Framework\Logger $logger,
\Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy,
\Magento\Framework\Event\ManagerInterface $eventManager,
- \Magento\CatalogInventory\Helper\Data $catalogInventoryData,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\Sales\Helper\Admin $adminhtmlSales,
\Magento\Framework\StoreManagerInterface $storeManager,
\Magento\Framework\Stdlib\DateTime\DateTime $date,
@@ -190,7 +190,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac
\Magento\Framework\App\State $appState,
$connection = null
) {
- $this->_inventoryData = $catalogInventoryData;
+ $this->stockConfiguration = $stockConfiguration;
$this->_adminhtmlSales = $adminhtmlSales;
$this->_storeManager = $storeManager;
$this->_date = $date;
@@ -297,7 +297,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac
array('product_collection' => $productCollection)
);
- $checkInStock = $this->_productInStock && !$this->_inventoryData->isShowOutOfStock();
+ $checkInStock = $this->_productInStock && !$this->stockConfiguration->isShowOutOfStock();
foreach ($this as $item) {
$product = $productCollection->getItemById($item->getProductId());
diff --git a/app/code/Magento/Wishlist/Model/Resource/Item/Collection/Grid.php b/app/code/Magento/Wishlist/Model/Resource/Item/Collection/Grid.php
index d3a8e1bf5616c2a433cd1a113ab1019f20451280..679d12a6a035ee3578470f24f5f6a9ea62d9491f 100644
--- a/app/code/Magento/Wishlist/Model/Resource/Item/Collection/Grid.php
+++ b/app/code/Magento/Wishlist/Model/Resource/Item/Collection/Grid.php
@@ -41,7 +41,7 @@ class Grid extends \Magento\Wishlist\Model\Resource\Item\Collection
* @param \Magento\Framework\Logger $logger
* @param \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy
* @param \Magento\Framework\Event\ManagerInterface $eventManager
- * @param \Magento\CatalogInventory\Helper\Data $catalogInventoryData
+ * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration
* @param \Magento\Sales\Helper\Admin $adminhtmlSales
* @param \Magento\Framework\StoreManagerInterface $storeManager
* @param \Magento\Framework\Stdlib\DateTime\DateTime $date
@@ -64,7 +64,7 @@ class Grid extends \Magento\Wishlist\Model\Resource\Item\Collection
\Magento\Framework\Logger $logger,
\Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy,
\Magento\Framework\Event\ManagerInterface $eventManager,
- \Magento\CatalogInventory\Helper\Data $catalogInventoryData,
+ \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration,
\Magento\Sales\Helper\Admin $adminhtmlSales,
\Magento\Framework\StoreManagerInterface $storeManager,
\Magento\Framework\Stdlib\DateTime\DateTime $date,
@@ -86,7 +86,7 @@ class Grid extends \Magento\Wishlist\Model\Resource\Item\Collection
$logger,
$fetchStrategy,
$eventManager,
- $catalogInventoryData,
+ $stockConfiguration,
$adminhtmlSales,
$storeManager,
$date,
diff --git a/app/code/Magento/Wishlist/composer.json b/app/code/Magento/Wishlist/composer.json
index 187737e677f4c0f8742088fdeabab7aa8dd6362e..7407ccc4fc1c94433ec8b4e3cb5ccfec6ed88e0b 100644
--- a/app/code/Magento/Wishlist/composer.json
+++ b/app/code/Magento/Wishlist/composer.json
@@ -3,25 +3,25 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/module-store": "0.1.0-alpha104",
- "magento/module-customer": "0.1.0-alpha104",
- "magento/module-catalog": "0.1.0-alpha104",
- "magento/module-core": "0.1.0-alpha104",
- "magento/module-checkout": "0.1.0-alpha104",
- "magento/module-theme": "0.1.0-alpha104",
- "magento/module-catalog-inventory": "0.1.0-alpha104",
- "magento/module-rss": "0.1.0-alpha104",
- "magento/module-backend": "0.1.0-alpha104",
- "magento/module-bundle": "0.1.0-alpha104",
- "magento/module-sales": "0.1.0-alpha104",
- "magento/module-grouped-product": "0.1.0-alpha104",
- "magento/module-configurable-product": "0.1.0-alpha104",
- "magento/module-downloadable": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/module-store": "0.1.0-alpha105",
+ "magento/module-customer": "0.1.0-alpha105",
+ "magento/module-catalog": "0.1.0-alpha105",
+ "magento/module-core": "0.1.0-alpha105",
+ "magento/module-checkout": "0.1.0-alpha105",
+ "magento/module-theme": "0.1.0-alpha105",
+ "magento/module-catalog-inventory": "0.1.0-alpha105",
+ "magento/module-rss": "0.1.0-alpha105",
+ "magento/module-backend": "0.1.0-alpha105",
+ "magento/module-bundle": "0.1.0-alpha105",
+ "magento/module-sales": "0.1.0-alpha105",
+ "magento/module-grouped-product": "0.1.0-alpha105",
+ "magento/module-configurable-product": "0.1.0-alpha105",
+ "magento/module-downloadable": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-module",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/code/Magento/Wishlist/etc/module.xml b/app/code/Magento/Wishlist/etc/module.xml
index 2714347a3a0f1937f3998e60342583dbd420bb8a..9cd48a72e1e75515de41a447826d8d431837a984 100644
--- a/app/code/Magento/Wishlist/etc/module.xml
+++ b/app/code/Magento/Wishlist/etc/module.xml
@@ -24,7 +24,7 @@
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
- <module name="Magento_Wishlist" schema_version="1.6.0.0" active="true">
+ <module name="Magento_Wishlist" schema_version="2.0.0" active="true">
<sequence>
<module name="Magento_Customer"/>
<module name="Magento_Catalog"/>
diff --git a/app/code/Magento/Wishlist/sql/wishlist_setup/install-1.6.0.0.php b/app/code/Magento/Wishlist/sql/wishlist_setup/install-2.0.0.php
similarity index 100%
rename from app/code/Magento/Wishlist/sql/wishlist_setup/install-1.6.0.0.php
rename to app/code/Magento/Wishlist/sql/wishlist_setup/install-2.0.0.php
diff --git a/app/design/adminhtml/Magento/backend/composer.json b/app/design/adminhtml/Magento/backend/composer.json
index c54a869c01b17f617fbdc962512d5721f60236b4..c83a8ddcc0b29e66b8451a61d00c824ffdc5bcbc 100644
--- a/app/design/adminhtml/Magento/backend/composer.json
+++ b/app/design/adminhtml/Magento/backend/composer.json
@@ -3,11 +3,11 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/framework": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-theme",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/design/adminhtml/Magento/backend/theme.xml b/app/design/adminhtml/Magento/backend/theme.xml
index d5d8a9cc4caa413e9f4df7ba4ff97dae606ac73a..c4cc7bb6b37f54d3236c558d57c32797e636c50e 100644
--- a/app/design/adminhtml/Magento/backend/theme.xml
+++ b/app/design/adminhtml/Magento/backend/theme.xml
@@ -24,5 +24,5 @@
-->
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
<title>Magento 2 backend</title>
- <version>0.1.0-alpha104</version>
+ <version>0.1.0-alpha105</version>
</theme>
diff --git a/app/design/frontend/Magento/blank/composer.json b/app/design/frontend/Magento/blank/composer.json
index 70060e31e297aa1473b5e123a01dc9948ddc5a42..6fb021f49a24ecfbc34a41ead76a5de6c3d30ace 100644
--- a/app/design/frontend/Magento/blank/composer.json
+++ b/app/design/frontend/Magento/blank/composer.json
@@ -3,11 +3,11 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/framework": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-theme",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/design/frontend/Magento/blank/theme.xml b/app/design/frontend/Magento/blank/theme.xml
index cef3f21f044549f5beb94c4987d27dacacbcab35..770ee9816c91dda7beb450373d3e2b7511816e9a 100644
--- a/app/design/frontend/Magento/blank/theme.xml
+++ b/app/design/frontend/Magento/blank/theme.xml
@@ -24,7 +24,7 @@
-->
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
<title>Magento Blank</title>
- <version>0.1.0-alpha104</version>
+ <version>0.1.0-alpha105</version>
<media>
<preview_image>media/preview.jpg</preview_image>
</media>
diff --git a/app/design/frontend/Magento/plushe/composer.json b/app/design/frontend/Magento/plushe/composer.json
index 0d2af0efb65bceb686a8c3667e3b50cc3e5874bd..0621c07d3d4d4cde11872a965795bcfbca02f9ea 100644
--- a/app/design/frontend/Magento/plushe/composer.json
+++ b/app/design/frontend/Magento/plushe/composer.json
@@ -3,12 +3,12 @@
"description": "N/A",
"require": {
"php": "~5.4.11|~5.5.0",
- "magento/theme-frontend-blank": "0.1.0-alpha104",
- "magento/framework": "0.1.0-alpha104",
+ "magento/theme-frontend-blank": "0.1.0-alpha105",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-theme",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"extra": {
"map": [
[
diff --git a/app/design/frontend/Magento/plushe/theme.xml b/app/design/frontend/Magento/plushe/theme.xml
index 812501a26b5b99fcef4ce367a368ce7fc158c67d..e3569a1fc5f92b1a22760c39e330f763b0189561 100644
--- a/app/design/frontend/Magento/plushe/theme.xml
+++ b/app/design/frontend/Magento/plushe/theme.xml
@@ -24,7 +24,7 @@
-->
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
<title>Magento Plushe</title>
- <version>0.1.0-alpha104</version>
+ <version>0.1.0-alpha105</version>
<parent>Magento/blank</parent>
<media>
<preview_image>media/preview.jpg</preview_image>
diff --git a/app/etc/di.xml b/app/etc/di.xml
index c586ec91283b3f33b6b83c052c683e62b9842c06..c7f77b6f2670b760e46e62283c942cc3e5bcc3a2 100644
--- a/app/etc/di.xml
+++ b/app/etc/di.xml
@@ -48,6 +48,8 @@
<preference for="Magento\Framework\Locale\ConfigInterface" type="Magento\Framework\Locale\Config" />
<preference for="Magento\Framework\Notification\NotifierInterface" type="Magento\Framework\Notification\NotifierPool" />
<preference for="Magento\Framework\UrlInterface" type="Magento\Framework\Url" />
+ <preference for="Magento\Framework\Url\EncoderInterface" type="Magento\Framework\Url\Encoder" />
+ <preference for="Magento\Framework\Url\DecoderInterface" type="Magento\Framework\Url\Decoder" />
<preference for="Magento\Framework\Data\Collection\Db\FetchStrategyInterface" type="Magento\Framework\Data\Collection\Db\FetchStrategy\Query" />
<preference for="Magento\Framework\Config\ScopeInterface" type="Magento\Framework\Config\Scope" />
<preference for="Magento\Framework\Config\FileResolverInterface" type="Magento\Framework\App\Config\FileResolver" />
@@ -56,7 +58,7 @@
<preference for="Magento\Framework\Module\ModuleListInterface" type="Magento\Framework\Module\ModuleList" />
<preference for="Magento\Framework\Event\ConfigInterface" type="Magento\Framework\Event\Config" />
<preference for="Magento\Framework\Event\InvokerInterface" type="Magento\Framework\Event\Invoker\InvokerDefault" />
- <preference for="Magento\Framework\Interception\PluginList" type="Magento\Framework\Interception\PluginList\PluginList" />
+ <preference for="Magento\Framework\Interception\PluginListInterface" type="Magento\Framework\Interception\PluginList\PluginList" />
<preference for="Magento\Framework\Event\ManagerInterface" type="Magento\Framework\Event\Manager\Proxy" />
<preference for="Magento\Framework\View\LayoutInterface" type="Magento\Framework\View\Layout" />
<preference for="Magento\Framework\View\Layout\ProcessorInterface" type="Magento\Core\Model\Layout\Merge" />
@@ -73,7 +75,7 @@
<preference for="Magento\Framework\Message\ManagerInterface" type="Magento\Framework\Message\Manager" />
<preference for="Magento\Framework\App\Config\ValueInterface" type="Magento\Framework\App\Config\Value" />
<preference for="Magento\Framework\Module\DependencyManagerInterface" type="Magento\Framework\Module\DependencyManager" />
- <preference for="Magento\Framework\Interception\Chain" type="Magento\Framework\Interception\Chain\Chain" />
+ <preference for="Magento\Framework\Interception\ChainInterface" type="Magento\Framework\Interception\Chain\Chain" />
<preference for="Magento\Framework\Module\Output\ConfigInterface" type="Magento\Framework\Module\Output\Config" />
<preference for="Magento\Framework\View\Design\Theme\CustomizationInterface" type="Magento\Framework\View\Design\Theme\Customization" />
<preference for="Magento\Framework\Image\Adapter\ConfigInterface" type="Magento\Framework\Image\Adapter\Config" />
@@ -81,7 +83,7 @@
<preference for="Magento\Framework\Session\Config\ConfigInterface" type="Magento\Framework\Session\Config" />
<preference for="Magento\Framework\Session\SidResolverInterface" type="Magento\Framework\Session\SidResolver\Proxy" />
<preference for="Magento\Framework\Stdlib\Cookie\CookieScopeInterface" type="\Magento\Framework\Stdlib\Cookie\CookieScope" />
- <preference for="Magento\Framework\Stdlib\CookieManager" type="Magento\Framework\Stdlib\Cookie\PhpCookieManager" />
+ <preference for="Magento\Framework\Stdlib\CookieManagerInterface" type="Magento\Framework\Stdlib\Cookie\PhpCookieManager" />
<preference for="Magento\Framework\TranslateInterface" type="Magento\Framework\Translate" />
<preference for="Magento\Framework\Config\ScopeListInterface" type="interceptionConfigScope" />
<preference for="Magento\Framework\View\Design\Theme\Label\ListInterface" type="Magento\Core\Model\Resource\Theme\Collection" />
@@ -94,7 +96,9 @@
<preference for="Magento\Framework\View\Design\FileResolution\Fallback\CacheDataInterface" type="Magento\Framework\View\Design\FileResolution\Fallback\CacheData\Flat"/>
<preference for="Magento\Framework\Api\AttributeMetadataBuilderInterface" type="Magento\Framework\Api\AttributeMetadataBuilder"/>
<preference for="Magento\Framework\Api\MetadataServiceInterface" type="Magento\Framework\Api\Config\MetadataConfig"/>
+ <preference for="Magento\Framework\Api\SearchCriteriaInterface" type="Magento\Framework\Api\SearchCriteria"/>
<preference for="Magento\Framework\App\Rss\UrlBuilderInterface" type="Magento\Framework\App\Rss\UrlBuilder"/>
+ <preference for="Magento\Framework\DB\QueryInterface" type="Magento\Framework\DB\Query"/>
<type name="Magento\Framework\Model\Context">
<arguments>
<argument name="actionValidator" xsi:type="object">Magento\Framework\Model\ActionValidator\RemoveAction\Proxy</argument>
@@ -309,7 +313,7 @@
</virtualType>
<virtualType name="layoutObjectArgumentInterpreter" type="Magento\Framework\View\Layout\Argument\Interpreter\Object">
<arguments>
- <argument name="expectedClass" xsi:type="string">Magento\Framework\Data\Collection</argument>
+ <argument name="expectedClass" xsi:type="string">Magento\Framework\Data\DataSourceInterface</argument>
</arguments>
</virtualType>
<type name="Magento\Framework\View\Layout\Argument\Interpreter\NamedParams">
diff --git a/app/i18n/magento/de_de/composer.json b/app/i18n/magento/de_de/composer.json
index 2f79ba8b3de7ce8247f70212bfb200a89804b4e2..64fc3eab0b8cf3c88c334988247b6290e5248b75 100644
--- a/app/i18n/magento/de_de/composer.json
+++ b/app/i18n/magento/de_de/composer.json
@@ -1,9 +1,9 @@
{
"name": "magento/language-de_de",
"description": "German (Germany) language",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"require": {
- "magento/framework": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-language",
diff --git a/app/i18n/magento/en_us/composer.json b/app/i18n/magento/en_us/composer.json
index 0bae8cff86b43d015943b1eb60bb9bdbb2b0f9ab..ba7bd95dfa9330aea669732a60934bff57b9e1b5 100644
--- a/app/i18n/magento/en_us/composer.json
+++ b/app/i18n/magento/en_us/composer.json
@@ -1,9 +1,9 @@
{
"name": "magento/language-en_us",
"description": "English (United States) language",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"require": {
- "magento/framework": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-language",
diff --git a/app/i18n/magento/es_es/composer.json b/app/i18n/magento/es_es/composer.json
index e8a1d9c61d9b144bd812c064f5346fbf5e910fc2..094f1822d783558711d7541849501101f41b8f1d 100644
--- a/app/i18n/magento/es_es/composer.json
+++ b/app/i18n/magento/es_es/composer.json
@@ -1,9 +1,9 @@
{
"name": "magento/language-es_es",
"description": "Spanish (Spain) language",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"require": {
- "magento/framework": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-language",
diff --git a/app/i18n/magento/fr_fr/composer.json b/app/i18n/magento/fr_fr/composer.json
index 023ce244a204001e2897e9c84a15b263b5da02a8..905d565e3b556fd825d3c0c53dd26c3da924a623 100644
--- a/app/i18n/magento/fr_fr/composer.json
+++ b/app/i18n/magento/fr_fr/composer.json
@@ -1,9 +1,9 @@
{
"name": "magento/language-fr_fr",
"description": "French (France) language",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"require": {
- "magento/framework": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-language",
diff --git a/app/i18n/magento/nl_nl/composer.json b/app/i18n/magento/nl_nl/composer.json
index 2c56e12d9099194aad2afe1cf5167876e91d794d..77e7a242a1de2a33a0077e84fe19f0592258904c 100644
--- a/app/i18n/magento/nl_nl/composer.json
+++ b/app/i18n/magento/nl_nl/composer.json
@@ -1,9 +1,9 @@
{
"name": "magento/language-nl_nl",
"description": "Dutch (Netherlands) language",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"require": {
- "magento/framework": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-language",
diff --git a/app/i18n/magento/pt_br/composer.json b/app/i18n/magento/pt_br/composer.json
index 2aec74a84a6decff20ed1c08a547935526882c7e..47ceede83833dc8630e5c2630ef9cb9df290fddb 100644
--- a/app/i18n/magento/pt_br/composer.json
+++ b/app/i18n/magento/pt_br/composer.json
@@ -1,9 +1,9 @@
{
"name": "magento/language-pt_br",
"description": "Portuguese (Brazil) language",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"require": {
- "magento/framework": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-language",
diff --git a/app/i18n/magento/zh_cn/composer.json b/app/i18n/magento/zh_cn/composer.json
index 49e9b73e80c339dd50cdc4caa882c021b779dfd0..e2a75ed66e453f23d79a9d7b04307ab565252657 100644
--- a/app/i18n/magento/zh_cn/composer.json
+++ b/app/i18n/magento/zh_cn/composer.json
@@ -1,9 +1,9 @@
{
"name": "magento/language-zh_cn",
"description": "Chinese (China) language",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"require": {
- "magento/framework": "0.1.0-alpha104",
+ "magento/framework": "0.1.0-alpha105",
"magento/magento-composer-installer": "*"
},
"type": "magento2-language",
diff --git a/composer.json b/composer.json
index 5429b05db8f921ab78b6970cd41804ce677805e2..785ce1b69a4f16ec60a8f17ea006c16eae6bbae1 100644
--- a/composer.json
+++ b/composer.json
@@ -2,13 +2,15 @@
"name": "magento/project-community-edition",
"description": "Magento project (Community Edition)",
"type": "project",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"require": {
"php": "~5.4.11|~5.5.0",
"zendframework/zend-stdlib": "2.0.3"
},
"require-dev": {
- "phpunit/phpunit": "4.1.0"
+ "phpunit/phpunit": "4.1.0",
+ "squizlabs/php_codesniffer": "1.5.3",
+ "phpmd/phpmd": "@stable"
},
"replace": {
"magento/module-admin-notification": "self.version",
@@ -178,34 +180,10 @@
"use-include-path": true
},
"autoload": {
- "psr-0": {
- "Apache_": "lib/internal/",
- "Cm_": "lib/internal/",
- "Credis_": "lib/internal/",
- "Less_": "lib/internal/",
- "Symfony\\": "lib/internal/",
- "Zend_Date": "app/code/",
- "Zend_Mime": "app/code/",
- "Zend_": "lib/internal/",
- "Zend\\": "lib/internal/"
- },
"psr-4": {
- "Magento\\Framework\\": "lib/internal/Magento/Framework/",
- "Magento\\": [
- "var/generation/Magento/",
- "app/code/Magento/"
- ],
- "Zend\\Soap\\": "app/code/Zend/Soap/",
- "Zend\\": "lib/internal/Zend/"
- },
- "classmap": [
- "app/code/"
- ]
+ "Magento\\Framework\\": "lib/internal/Magento/Framework/"
+ }
},
- "include-path": [
- "/lib/internal/",
- "/app/code/"
- ],
"autoload-dev": {
"psr-4": {
"Magento\\Sniffs\\": "dev/tests/static/framework/Magento/Sniffs/",
diff --git a/dev/tests/functional/bootstrap.php b/dev/tests/functional/bootstrap.php
index 3ce476da9b4bfeb4aa9a5e6ebe19427b1bf40930..00f310e673617df3f69f51d8e0360dc1c5b21305 100644
--- a/dev/tests/functional/bootstrap.php
+++ b/dev/tests/functional/bootstrap.php
@@ -25,7 +25,6 @@
session_start();
defined('MTF_BOOT_FILE') || define('MTF_BOOT_FILE', __FILE__);
require_once __DIR__ . '/../../../app/bootstrap.php';
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
+date_default_timezone_set('America/Los_Angeles');
restore_error_handler();
require_once __DIR__ . '/vendor/autoload.php';
diff --git a/dev/tests/functional/lib/Mtf/Client/Driver/Selenium/Element/SuggestElement.php b/dev/tests/functional/lib/Mtf/Client/Driver/Selenium/Element/SuggestElement.php
index 250347eacd0013b051073e6da1180e9db5597f4c..ae2c11a0b097e5aac07f6c3b8d14825682393d23 100755
--- a/dev/tests/functional/lib/Mtf/Client/Driver/Selenium/Element/SuggestElement.php
+++ b/dev/tests/functional/lib/Mtf/Client/Driver/Selenium/Element/SuggestElement.php
@@ -52,7 +52,7 @@ class SuggestElement extends Element
*
* @var string
*/
- protected $resultItem = './/*[contains(@class,"mage-suggest-dropdown")]/ul/li/a[text()="%s"]';
+ protected $resultItem = './/ul/li/a[text()="%s"]';
/**
* Set value
@@ -92,8 +92,8 @@ class SuggestElement extends Element
*/
public function getValue()
{
- $this->_eventManager->dispatchEvent(['get_value'], [(string) $this->_locator]);
-
+ $this->_eventManager->dispatchEvent(['get_value'], [(string)$this->_locator]);
+
return $this->find($this->suggest)->getValue();
}
diff --git a/dev/tests/functional/lib/Mtf/ObjectManagerFactory.php b/dev/tests/functional/lib/Mtf/ObjectManagerFactory.php
index 08d789294b382a066b49f2af5a82e18631dcab09..d7b065e14d1770e0223370250b672d63f019d496 100644
--- a/dev/tests/functional/lib/Mtf/ObjectManagerFactory.php
+++ b/dev/tests/functional/lib/Mtf/ObjectManagerFactory.php
@@ -29,7 +29,7 @@ use Magento\Framework\App\Filesystem\DirectoryList;
use Magento\Framework\Stdlib\BooleanUtils;
use Mtf\System\Config as SystemConfig;
use Mtf\ObjectManager\Factory;
-use Magento\Framework\ObjectManager as MagentoObjectManager;
+use Magento\Framework\ObjectManagerInterface as MagentoObjectManager;
/**
* Class ObjectManagerFactory
@@ -76,18 +76,6 @@ class ObjectManagerFactory
$systemConfig = new SystemConfig();
$configuration = $systemConfig->getConfigParam();
$diConfig->extend($configuration);
-
- $directories = isset($arguments[Bootstrap::INIT_PARAM_FILESYSTEM_DIR_PATHS])
- ? $arguments[Bootstrap::INIT_PARAM_FILESYSTEM_DIR_PATHS]
- : array();
- $directoryList = new \Magento\Framework\App\Filesystem\DirectoryList(
- realpath(MTF_BP . '../../../../'),
- $directories
- );
- (new \Magento\Framework\Autoload\IncludePath())->addIncludePath(
- array($directoryList->getPath(DirectoryList::GENERATION))
- );
-
$factory = new Factory($diConfig);
$argInterpreter = $this->createArgumentInterpreter(new BooleanUtils());
$argumentMapper = new \Magento\Framework\ObjectManager\Config\Mapper\Dom($argInterpreter);
diff --git a/dev/tests/functional/lib/Mtf/Util/Generate/Factory.php b/dev/tests/functional/lib/Mtf/Util/Generate/Factory.php
index 3ff33762419e7c6663ad6f8eed38e38a9f30190e..2c37c2f384d9de359466d13da1bac3d842dfc89f 100644
--- a/dev/tests/functional/lib/Mtf/Util/Generate/Factory.php
+++ b/dev/tests/functional/lib/Mtf/Util/Generate/Factory.php
@@ -24,7 +24,7 @@
namespace Mtf\Util\Generate;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\App;
/**
@@ -36,13 +36,13 @@ use Magento\Framework\App;
class Factory extends AbstractGenerate
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* @constructor
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param Factory\Block $block
* @param Factory\Fixture $fixture
* @param Factory\Handler $handler
@@ -50,7 +50,7 @@ class Factory extends AbstractGenerate
* @param Factory\Repository $repository
*/
public function __construct(
- ObjectManager $objectManager,
+ ObjectManagerInterface $objectManager,
Factory\Block $block,
Factory\Fixture $fixture,
Factory\Handler $handler,
diff --git a/dev/tests/functional/lib/Mtf/Util/Generate/Fixture/FieldsProvider.php b/dev/tests/functional/lib/Mtf/Util/Generate/Fixture/FieldsProvider.php
index 47708c40bf3b1c8843108b50c9121763fe9ed055..3e98ba0278e252289f3351d2da751adbf0940166 100644
--- a/dev/tests/functional/lib/Mtf/Util/Generate/Fixture/FieldsProvider.php
+++ b/dev/tests/functional/lib/Mtf/Util/Generate/Fixture/FieldsProvider.php
@@ -25,7 +25,7 @@
namespace Mtf\Util\Generate\Fixture;
use Magento\Framework\App\Resource;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Class FieldsProvider
@@ -45,9 +45,9 @@ class FieldsProvider implements FieldsProviderInterface
/**
* @constructor
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->eavConfig = $objectManager->create('Magento\Eav\Model\Config');
$this->resource = $objectManager->create('Magento\Framework\App\Resource');
diff --git a/dev/tests/functional/lib/Mtf/Util/Generate/Repository/CollectionProvider.php b/dev/tests/functional/lib/Mtf/Util/Generate/Repository/CollectionProvider.php
index b74707de0e175f2de82ee735abd350c5cc44a03d..03c9de1372d23d7f43c215ca971b08821fc23eab 100644
--- a/dev/tests/functional/lib/Mtf/Util/Generate/Repository/CollectionProvider.php
+++ b/dev/tests/functional/lib/Mtf/Util/Generate/Repository/CollectionProvider.php
@@ -24,7 +24,7 @@
namespace Mtf\Util\Generate\Repository;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Class CollectionProvider
@@ -33,15 +33,15 @@ use Magento\Framework\ObjectManager;
class CollectionProvider implements CollectionProviderInterface
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* @constructor
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/dev/tests/functional/tests/app/Magento/Backend/Test/Block/Widget/Tab.php b/dev/tests/functional/tests/app/Magento/Backend/Test/Block/Widget/Tab.php
index 5ae5f4ed6af4f7d440595306cc642aa8053dcde5..e331be5edcd91d270e007071afa4913962cd30a2 100644
--- a/dev/tests/functional/tests/app/Magento/Backend/Test/Block/Widget/Tab.php
+++ b/dev/tests/functional/tests/app/Magento/Backend/Test/Block/Widget/Tab.php
@@ -25,6 +25,7 @@
namespace Magento\Backend\Test\Block\Widget;
use Mtf\Client\Element;
+use Mtf\Client\Element\Locator;
use Mtf\Block\Form as AbstractForm;
/**
@@ -35,6 +36,27 @@ use Mtf\Block\Form as AbstractForm;
*/
class Tab extends AbstractForm
{
+ /**
+ * Field with Mage error.
+ *
+ * @var string
+ */
+ protected $mageErrorField = '//*[contains(@class,"field ")][.//*[@class="mage-error"]]';
+
+ /**
+ * Fields label with mage error.
+ *
+ * @var string
+ */
+ protected $mageErrorLabel = './label';
+
+ /**
+ * Mage error text.
+ *
+ * @var string
+ */
+ protected $mageErrorText = './/*[@class="mage-error"]';
+
/**
* Fill data to fields on tab
*
@@ -73,4 +95,23 @@ class Tab extends AbstractForm
{
$this->fillFormTab($fields, $element);
}
+
+ /**
+ * Get array of label => js error text.
+ *
+ * @return array
+ */
+ public function getJsErrors()
+ {
+ $data = [];
+ $elements = $this->_rootElement->find($this->mageErrorField, Locator::SELECTOR_XPATH)->getElements();
+ foreach ($elements as $element) {
+ $error = $element->find($this->mageErrorText, Locator::SELECTOR_XPATH);
+ if ($error->isVisible()) {
+ $label = $element->find($this->mageErrorLabel, Locator::SELECTOR_XPATH)->getText();
+ $data[$label] = $error->getText();
+ }
+ }
+ return $data;
+ }
}
diff --git a/dev/tests/functional/tests/app/Magento/Bundle/Test/Block/Adminhtml/Product/ProductForm.xml b/dev/tests/functional/tests/app/Magento/Bundle/Test/Block/Adminhtml/Product/ProductForm.xml
index c1f5383c0d572fbea438b6e9d8ef0fb7de465841..32d13f617d9777d3f40ced4bb77774dc42ee268b 100644
--- a/dev/tests/functional/tests/app/Magento/Bundle/Test/Block/Adminhtml/Product/ProductForm.xml
+++ b/dev/tests/functional/tests/app/Magento/Bundle/Test/Block/Adminhtml/Product/ProductForm.xml
@@ -25,7 +25,7 @@
-->
<tabs>
<product-details>
- <class>\Magento\Backend\Test\Block\Widget\Tab</class>
+ <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Edit\ProductTab</class>
<selector>#product_info_tabs_product-details</selector>
<strategy>css selector</strategy>
<wrapper>product</wrapper>
@@ -50,7 +50,7 @@
<strategy>css selector</strategy>
</bundle>
<advanced-pricing>
- <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Edit\AdvancedPricingTab</class>
+ <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Edit\ProductTab</class>
<selector>#product_info_tabs_advanced-pricing</selector>
<strategy>css selector</strategy>
<wrapper>product</wrapper>
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/AttributeForm.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/AttributeForm.php
new file mode 100644
index 0000000000000000000000000000000000000000..78b077778a08be70a4ec10e3edcdf5533963ea18
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/AttributeForm.php
@@ -0,0 +1,102 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\Block\Adminhtml\Product\Attribute;
+
+use Magento\Backend\Test\Block\Widget\FormTabs;
+use Mtf\Client\Element;
+use Mtf\Client\Element\Locator;
+use Mtf\Fixture\FixtureInterface;
+use Magento\Backend\Test\Block\Widget\Tab;
+
+/**
+ * Edit attribute form on catalog product edit page.
+ */
+class AttributeForm extends FormTabs
+{
+ /**
+ * Iframe locator.
+ *
+ * @var string
+ */
+ protected $iFrame = '#create_new_attribute_container';
+
+ /**
+ * Save button selector.
+ *
+ * @var string
+ */
+ protected $saveButton = '#save';
+
+ /**
+ * Fill the attribute form.
+ *
+ * @param FixtureInterface $fixture
+ * @param Element|null $element
+ * @return $this
+ */
+ public function fill(FixtureInterface $fixture, Element $element = null)
+ {
+ $this->browser->switchToFrame(new Locator($this->iFrame));
+ $browser = $this->browser;
+ $selector = $this->saveButton;
+ $this->browser->waitUntil(
+ function () use ($browser, $selector) {
+ return $browser->find($selector)->isVisible() ? true : null;
+ }
+ );
+ parent::fill($fixture, $element);
+ }
+
+ /**
+ * Open tab
+ *
+ * @param string $tabName
+ * @return Tab
+ */
+ public function openTab($tabName)
+ {
+ $selector = $this->tabs[$tabName]['selector'];
+ $strategy = isset($this->tabs[$tabName]['strategy'])
+ ? $this->tabs[$tabName]['strategy']
+ : Locator::SELECTOR_CSS;
+ $tab = $this->_rootElement->find($selector, $strategy);
+ $target = $this->browser->find('.page-footer-wrapper'); // Handle menu overlap problem
+ $this->_rootElement->dragAndDrop($target);
+ $tab->click();
+
+ return $this;
+ }
+
+ /**
+ * Click on "Save" button.
+ *
+ * @return void
+ */
+ public function saveAttributeForm()
+ {
+ $this->browser->find($this->saveButton)->click();
+ $this->browser->selectWindow();
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/AttributeForm.xml b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/AttributeForm.xml
new file mode 100644
index 0000000000000000000000000000000000000000..20a6934c84768316ec0ef5bd46ece97279575b48
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/AttributeForm.xml
@@ -0,0 +1,116 @@
+<?xml version="1.0" ?>
+<!--
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Academic Free License (AFL 3.0)
+ * that is bundled with this package in the file LICENSE_AFL.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/afl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0)
+ */
+-->
+<tabs>
+ <properties>
+ <class>\Magento\Backend\Test\Block\Widget\Tab</class>
+ <selector>#edit_form</selector>
+ <strategy>css selector</strategy>
+ <fields>
+ <frontend_label>
+ <selector>[name^='frontend_label']</selector>
+ </frontend_label>
+ <frontend_input>
+ <input>select</input>
+ </frontend_input>
+ <is_required>
+ <input>select</input>
+ </is_required>
+ <options>
+ <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit\Options</class>
+ <selector>#manage-options-panel</selector>
+ <strategy>css selector</strategy>
+ </options>
+ </fields>
+ </properties>
+ <advanced-properties>
+ <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit\Tab\Advanced</class>
+ <selector>[data-target="#advanced_fieldset-content"]</selector>
+ <strategy>css selector</strategy>
+ <fields>
+ <attribute_code>
+ </attribute_code>
+ <is_global>
+ <input>select</input>
+ </is_global>
+ <default_value>
+ <selector>[name^='default_value_']</selector>
+ </default_value>
+ <is_unique>
+ <input>select</input>
+ </is_unique>
+ <is_configurable>
+ <input>select</input>
+ </is_configurable>
+ </fields>
+ </advanced-properties>
+ <manage-labels>
+ <class>\Magento\Backend\Test\Block\Widget\Tab</class>
+ <selector>[data-target="#manage-titles-content"]</selector>
+ <strategy>css selector</strategy>
+ <fields>
+ <manage_frontend_label>
+ <selector>[name^='frontend_label']</selector>
+ </manage_frontend_label>
+ </fields>
+ </manage-labels>
+ <frontend-properties>
+ <class>\Magento\Backend\Test\Block\Widget\Tab</class>
+ <selector>[data-target="#front_fieldset-content"]</selector>
+ <strategy>css selector</strategy>
+ <fields>
+ <is_searchable>
+ <input>select</input>
+ </is_searchable>
+ <is_visible_in_advanced_search>
+ <input>select</input>
+ </is_visible_in_advanced_search>
+ <is_comparable>
+ <input>select</input>
+ </is_comparable>
+ <is_filterable>
+ <input>select</input>
+ </is_filterable>
+ <is_filterable_in_search>
+ <input>select</input>
+ </is_filterable_in_search>
+ <is_used_for_promo_rules>
+ <input>select</input>
+ </is_used_for_promo_rules>
+ <is_html_allowed_on_front>
+ <input>select</input>
+ </is_html_allowed_on_front>
+ <is_visible_on_front>
+ <input>select</input>
+ </is_visible_on_front>
+ <used_in_product_listing>
+ <input>select</input>
+ </used_in_product_listing>
+ <used_for_sort_by>
+ <input>select</input>
+ </used_for_sort_by>
+ </fields>
+ </frontend-properties>
+</tabs>
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/CustomAttribute.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/CustomAttribute.php
new file mode 100644
index 0000000000000000000000000000000000000000..fe894e50dff8e7cf7832f1e3cb7cd99dc412cdf1
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/CustomAttribute.php
@@ -0,0 +1,110 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\Block\Adminhtml\Product\Attribute;
+
+use Mtf\Client\Driver\Selenium\Element;
+use Mtf\Client\Element\Locator;
+
+/**
+ * Catalog product custom attribute element.
+ */
+class CustomAttribute extends Element
+{
+ /**
+ * Attribute input selector;
+ *
+ * @var string
+ */
+ protected $inputSelector = '.control [data-ui-id][name]';
+
+ /**
+ * Attribute class to element type reference.
+ *
+ * @var array
+ */
+ protected $classReference = [
+ 'input-text' => null,
+ 'textarea' => null,
+ 'hasDatepicker' => 'datepicker',
+ 'select' => 'select',
+ 'multiselect' => 'multiselect',
+ ];
+
+ /**
+ * Set attribute value.
+ *
+ * @param array|string $data
+ * @return void
+ */
+ public function setValue($data)
+ {
+ $this->_eventManager->dispatchEvent(['set_value'], [__METHOD__, $this->getAbsoluteSelector()]);
+ $element = $this->getElementByClass($this->getElementClass());
+ $value = is_array($data) ? $data['value'] : $data;
+ $this->find($this->inputSelector, Locator::SELECTOR_CSS, $element)->setValue($value);
+ }
+
+ /**
+ * Get custom attribute value.
+ *
+ * @return string|array
+ */
+ public function getValue()
+ {
+ $this->_eventManager->dispatchEvent(['get_value'], [__METHOD__, $this->getAbsoluteSelector()]);
+ $inputType = $this->getElementByClass($this->getElementClass());
+ return $this->find($this->inputSelector, Locator::SELECTOR_CSS, $inputType)->getValue();
+ }
+
+ /**
+ * Get element type by class.
+ *
+ * @param string $class
+ * @return string
+ */
+ protected function getElementByClass($class)
+ {
+ $element = null;
+ foreach ($this->classReference as $key => $reference) {
+ if (strpos($class, $key) !== false) {
+ $element = $reference;
+ }
+ }
+ return $element;
+ }
+
+ /**
+ * Get element class.
+ *
+ * @return string
+ */
+ protected function getElementClass()
+ {
+ $criteria = new \PHPUnit_Extensions_Selenium2TestCase_ElementCriteria('css selector');
+ $criteria->value($this->inputSelector);
+ $input = $this->_getWrappedElement()->element($criteria);
+ return $input->attribute('class');
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/AttributeForm.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/AttributeForm.php
index 246273bad21f55c1cc7f908977d566b8130a8992..7f507f982fabe666823b917048e91f55faea9fb4 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/AttributeForm.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/AttributeForm.php
@@ -25,12 +25,89 @@
namespace Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit;
use Magento\Backend\Test\Block\Widget\FormTabs;
+use Mtf\Client\Element;
+use Mtf\Client\Element\Locator;
+use Mtf\Fixture\FixtureInterface;
+use Mtf\Fixture\InjectableFixture;
+use Magento\Backend\Test\Block\Widget\Tab;
/**
- * Class AttributeForm
- * Catalog Product Attribute form
+ * Catalog Product Attribute form.
*/
class AttributeForm extends FormTabs
{
- //
+ /**
+ * Closed toggles selector.
+ *
+ * @var string
+ */
+ protected $closedToggle = '//*[contains(@class,"collapsable-wrapper") and not(contains(@class,"opened"))]//strong';
+
+ /**
+ * Get data of the tabs.
+ *
+ * @param FixtureInterface $fixture
+ * @param Element $element
+ * @return array
+ * @throws \Exception
+ *
+ * @SuppressWarnings(PHPMD.UnusedLocalVariable)
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+ */
+ public function getData(FixtureInterface $fixture = null, Element $element = null)
+ {
+ $data = [];
+ if (null === $fixture) {
+ foreach ($this->tabs as $tabName => $tab) {
+ $this->openTab($tabName);
+ $this->expandAllToggles();
+ $tabData = $this->getTabElement($tabName)->getDataFormTab();
+ $data = array_merge($data, $tabData);
+ }
+ } else {
+ $isHasData = ($fixture instanceof InjectableFixture) ? $fixture->hasData() : true;
+ $tabsFields = $isHasData ? $this->getFieldsByTabs($fixture) : [];
+ foreach ($tabsFields as $tabName => $fields) {
+ $this->openTab($tabName);
+ $this->expandAllToggles();
+ $tabData = $this->getTabElement($tabName)->getDataFormTab($fields, $this->_rootElement);
+ $data = array_merge($data, $tabData);
+ }
+ }
+
+ return $data;
+ }
+
+ /**
+ * Expand all toggles.
+ *
+ * @return void
+ */
+ protected function expandAllToggles()
+ {
+ $closedToggles = $this->_rootElement->find($this->closedToggle, Locator::SELECTOR_XPATH)->getElements();
+ foreach ($closedToggles as $toggle) {
+ $toggle->click();
+ }
+ }
+
+ /**
+ * Open tab.
+ *
+ * @param string $tabName
+ * @return Tab
+ */
+ public function openTab($tabName)
+ {
+ $selector = $this->tabs[$tabName]['selector'];
+ $strategy = isset($this->tabs[$tabName]['strategy'])
+ ? $this->tabs[$tabName]['strategy']
+ : Locator::SELECTOR_CSS;
+ $tab = $this->_rootElement->find($selector, $strategy);
+ $target = $this->browser->find('.logo');// Handle menu overlap problem
+ $this->_rootElement->dragAndDrop($target);
+ $tab->click();
+
+ return $this;
+ }
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/AttributeForm.xml b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/AttributeForm.xml
index b7634dec08044701154b9c346c6ceb6576e924fa..b5af69b43226a3db84878832a477fdd5163fe841 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/AttributeForm.xml
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/AttributeForm.xml
@@ -30,7 +30,7 @@
<strategy>css selector</strategy>
<fields>
<frontend_label>
- <selector>[name^='frontend_label']</selector>
+ <selector>[name="frontend_label[0]"]</selector>
</frontend_label>
<frontend_input>
<input>select</input>
@@ -38,13 +38,13 @@
<is_required>
<input>select</input>
</is_required>
+ <options>
+ <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit\Options</class>
+ <selector>#manage-options-panel</selector>
+ <strategy>css selector</strategy>
+ </options>
</fields>
</properties>
- <manage-options>
- <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit\Tab\Options</class>
- <selector>#product_attribute_tabs_main</selector>
- <strategy>css selector</strategy>
- </manage-options>
<advanced-properties>
<class>\Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit\Tab\Advanced</class>
<selector>#product_attribute_tabs_main</selector>
@@ -55,8 +55,14 @@
<is_global>
<input>select</input>
</is_global>
- <default_value_text>
- </default_value_text>
+ <default_value_text />
+ <default_value_textarea />
+ <default_value_date>
+ <input>datepicker</input>
+ </default_value_date>
+ <default_value_yesno>
+ <input>select</input>
+ </default_value_yesno>
<is_unique>
<input>select</input>
</is_unique>
@@ -71,7 +77,7 @@
<strategy>css selector</strategy>
<fields>
<manage_frontend_label>
- <selector>[name^='frontend_label']</selector>
+ <selector>[name="frontend_label[1]"]</selector>
</manage_frontend_label>
</fields>
</manage-labels>
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/Options.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/Options.php
new file mode 100644
index 0000000000000000000000000000000000000000..348b704e042deba1cd8d745a77b54f08faeca759
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/Options.php
@@ -0,0 +1,93 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit;
+
+use Mtf\Client\Driver\Selenium\Element;
+use Mtf\ObjectManager;
+use Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit\Tab\Options\Option;
+
+/**
+ * Options element.
+ */
+class Options extends Element
+{
+ /**
+ * 'Add Option' button.
+ *
+ * @var string
+ */
+ protected $addOption = '#add_new_option_button';
+
+ /**
+ * Option form selector.
+ *
+ * @var string
+ */
+ protected $option = '.ui-sortable tr';
+
+ /**
+ * Set value.
+ *
+ * @param array $preset
+ */
+ public function setValue($preset)
+ {
+ foreach ($preset as $option) {
+ if (isset($option['admin'])) {
+ $this->find($this->addOption)->click();
+ $this->getFormInstance()->fillOptions($option);
+ }
+ }
+ }
+
+ /**
+ * Get value.
+ *
+ * @return string
+ */
+ public function getValue()
+ {
+ $data = [];
+ $options = $this->find($this->option)->getElements();
+ foreach ($options as $option) {
+ $data[] = $this->getFormInstance($option)->getData();
+ }
+ return $data;
+ }
+
+ /**
+ * Get options form.
+ *
+ * @param Element|null $element
+ * @return Option
+ */
+ protected function getFormInstance(Element $element = null)
+ {
+ return ObjectManager::getInstance()->create(
+ 'Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit\Tab\Options\Option',
+ ['element' => $element === null ? $this->find($this->option . ':last-child') : $element]
+ );
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Set/Main.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Set/Main.php
index fec00fd3d314902169768d4f0b3d22b1d9f49fda..a31e9e1c03bbe5d319c98a388958e619b02d74cd 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Set/Main.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Set/Main.php
@@ -68,7 +68,7 @@ class Main extends Block
* @param string $attributeGroup
* @return void
*/
- public function moveAttribute(array $attributeData, $attributeGroup)
+ public function moveAttribute(array $attributeData, $attributeGroup = 'Product Details')
{
if (isset($attributeData['attribute_code'])) {
$attribute = $attributeData['attribute_code'];
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Composite/Configure.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Composite/Configure.php
index 95a4d8736fade8579aef26b56a2ef730139b9e39..ba48f43cb7bc84721b4d6b6b02b87e6603b5c9e7 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Composite/Configure.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Composite/Configure.php
@@ -52,6 +52,13 @@ class Configure extends AbstractConfigureBlock
*/
protected $okButton = '.ui-dialog-buttonset button:nth-of-type(2)';
+ /**
+ * Backend abstract block
+ *
+ * @var string
+ */
+ protected $templateBlock = './ancestor::body';
+
/**
* Set quantity
*
@@ -92,5 +99,19 @@ class Configure extends AbstractConfigureBlock
public function clickOk()
{
$this->_rootElement->find($this->okButton)->click();
+ $this->getTemplateBlock()->waitLoader();
+ }
+
+ /**
+ * Get backend abstract block
+ *
+ * @return \Magento\Backend\Test\Block\Template
+ */
+ public function getTemplateBlock()
+ {
+ return $this->blockFactory->create(
+ 'Magento\Backend\Test\Block\Template',
+ ['element' => $this->_rootElement->find($this->templateBlock, Locator::SELECTOR_XPATH)]
+ );
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/AdvancedPricingTab.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/AdvancedPricingTab.php
index c9698598a47e2fa0c6ff8006ea8152b6ac2d8689..cbbdf4527c53e6db1199a8f4080b1dcaa24cc7bd 100755
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/AdvancedPricingTab.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/AdvancedPricingTab.php
@@ -32,7 +32,7 @@ use Magento\Backend\Test\Block\Widget\Tab;
* Class AdvancedPricingTab
* Product advanced pricing tab
*/
-class AdvancedPricingTab extends Tab
+class AdvancedPricingTab extends ProductTab
{
/**
* Class name 'Subform' of the main tab form
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/ProductTab.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/ProductTab.php
new file mode 100644
index 0000000000000000000000000000000000000000..df1ad2f582384f426d5239387a75b14bcac414a5
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/ProductTab.php
@@ -0,0 +1,78 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\Block\Adminhtml\Product\Edit;
+
+use Magento\Backend\Test\Block\Widget\Tab;
+use Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Mtf\Client\Element\Locator;
+
+/**
+ * General class for tabs on product FormTabs with "Add attribute" button.
+ */
+class ProductTab extends Tab
+{
+ /**
+ * Attribute Search locator the Product page.
+ *
+ * @var string
+ */
+ protected $attributeSearch = "//div[contains(@data-role, '%s')]//*[@id='product-attribute-search-container']";
+
+ /**
+ * Selector for 'New Attribute' button.
+ *
+ * @var string
+ */
+ protected $newAttributeButton = '[id^="create_attribute"]';
+
+ /**
+ * Fixture mapping.
+ *
+ * @param array|null $fields
+ * @param string|null $parent
+ * @return array
+ */
+ protected function dataMapping(array $fields = null, $parent = null)
+ {
+ if (isset($fields['custom_attribute'])) {
+ $this->placeholders = ['attribute_code' => $fields['custom_attribute']['value']['code']];
+ $this->applyPlaceholders();
+ }
+ return parent::dataMapping($fields, $parent);
+ }
+
+ /**
+ * Click on 'New Attribute' button.
+ *
+ * @param string $tabName
+ * @return void
+ */
+ public function addNewAttribute($tabName)
+ {
+ $this->_rootElement->find(sprintf($this->attributeSearch, $tabName), Locator::SELECTOR_XPATH)->click();
+ $this->_rootElement->find($this->newAttributeButton)->click();
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/ProductForm.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/ProductForm.php
index 00671d7433cba9a5fddbeca422ddc342dafcd755..f2e5438814c8e88bea4e576c2dd489f7800d6f61 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/ProductForm.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/ProductForm.php
@@ -34,98 +34,122 @@ use Magento\Catalog\Test\Fixture\Product;
use Magento\Backend\Test\Block\Widget\Tab;
use Magento\Catalog\Test\Fixture\CatalogCategory;
use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\AttributeForm;
+use Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\CustomAttribute;
+use Magento\Catalog\Test\Block\Adminhtml\Product\Edit\ProductTab;
/**
- * Class ProductForm
- * Product form on backend product page
+ * Product form on backend product page.
*/
class ProductForm extends FormTabs
{
/**
- * Attribute on the Product page
+ * Attribute on the Product page.
*
* @var string
*/
protected $attribute = './/*[contains(@class,"label")]/span[text()="%s"]';
/**
- * Attribute Search locator the Product page
+ * Attribute Search locator the Product page.
*
* @var string
*/
protected $attributeSearch = '#product-attribute-search-container';
/**
- * Selector for trigger(show/hide) of advanced setting content
+ * Selector for trigger(show/hide) of advanced setting content.
*
* @var string
*/
protected $advancedSettingTrigger = '#product_info_tabs-advanced [data-role="trigger"]';
/**
- * Selector for advanced setting content
+ * Selector for advanced setting content.
*
* @var string
*/
-
protected $advancedSettingContent = '#product_info_tabs-advanced [data-role="content"]';
/**
- * Custom Tab locator
+ * Custom Tab locator.
*
* @var string
*/
protected $customTab = './/*/a[contains(@id,"product_info_tabs_%s")]';
/**
- * Button "New Category"
+ * Button "New Category".
*
* @var string
*/
protected $buttonNewCategory = '#add_category_button';
/**
- * Dialog box "Create Category"
+ * Dialog box "Create Category".
*
* @var string
*/
protected $createCategoryDialog = './/ancestor::body//*[contains(@class,"mage-new-category-dialog")]';
/**
- * "Parent Category" block on dialog box
+ * "Parent Category" block on dialog box.
*
* @var string
*/
protected $parentCategoryBlock = '//*[contains(@class,"field-new_category_parent")]';
/**
- * Field "Category Name" on dialog box
+ * Field "Category Name" on dialog box.
*
* @var string
*/
protected $fieldNewCategoryName = '//input[@id="new_category_name"]';
/**
- * Button "Create Category" on dialog box
+ * Button "Create Category" on dialog box.
*
* @var string
*/
protected $createCategoryButton = '//button[contains(@class,"action-create")]';
/**
- * Tabs title css selector
+ * Tabs title css selector.
*
* @var string
*/
protected $tabsTitle = '#product_info_tabs-basic [data-role="title"]';
/**
- * Fill the product form
+ * Attribute block selector.
+ *
+ * @var string
+ */
+ protected $attributeBlock = '#attribute-%s-container';
+
+ /**
+ * Magento loader.
+ *
+ * @var string
+ */
+ protected $loader = '[data-role="loader"]';
+
+ /**
+ * New attribute form selector.
+ *
+ * @var string
+ */
+ protected $newAttributeForm = '#create_new_attribute';
+
+ /**
+ * Fill the product form.
*
* @param FixtureInterface $product
* @param Element|null $element [optional]
* @param FixtureInterface|null $category [optional]
* @return FormTabs
+ *
+ * @SuppressWarnings(PHPMD.NPathComplexity)
*/
public function fill(FixtureInterface $product, Element $element = null, FixtureInterface $category = null)
{
@@ -154,13 +178,37 @@ class ProductForm extends FormTabs
$this->showAdvancedSettings();
$this->fillTabs($tabs, $element);
+
+ if ($product instanceof InjectableFixture && $product->hasData('custom_attribute')) {
+ $this->createCustomAttribute($product);
+ }
}
return $this;
}
/**
- * Get data of the tabs
+ * Create custom attribute.
+ *
+ * @param InjectableFixture $product
+ * @param string $tabName
+ * @return void
+ */
+ protected function createCustomAttribute(InjectableFixture $product, $tabName = 'product-details')
+ {
+ $attribute = $product->getDataFieldConfig('custom_attribute')['source']->getAttribute();
+ $this->openTab('product-details');
+ if (!$this->checkAttributeLabel($attribute)) {
+ /** @var \Magento\Catalog\Test\Block\Adminhtml\Product\Edit\ProductTab $tab */
+ $tab = $this->openTab($tabName);
+ $tab->addNewAttribute();
+ $this->fillAttributeForm($attribute);
+ $this->reinitRootElement();
+ }
+ }
+
+ /**
+ * Get data of the tabs.
*
* @param FixtureInterface|null $fixture
* @param Element|null $element
@@ -173,7 +221,7 @@ class ProductForm extends FormTabs
}
/**
- * Show Advanced Setting
+ * Show Advanced Setting.
*
* @return void
*/
@@ -187,7 +235,7 @@ class ProductForm extends FormTabs
}
/**
- * Open tab
+ * Open tab.
*
* @param string $tabName
* @return Tab
@@ -200,7 +248,7 @@ class ProductForm extends FormTabs
}
/**
- * Save new category
+ * Save new category.
*
* @param Product $fixture
* @return void
@@ -223,7 +271,7 @@ class ProductForm extends FormTabs
}
/**
- * Select parent category for new one
+ * Select parent category for new one.
*
* @return void
*/
@@ -237,7 +285,7 @@ class ProductForm extends FormTabs
}
/**
- * Clear category field
+ * Clear category field.
*
* @return void
*/
@@ -250,7 +298,7 @@ class ProductForm extends FormTabs
}
/**
- * Open new category dialog
+ * Open new category dialog.
*
* @return void
*/
@@ -261,7 +309,7 @@ class ProductForm extends FormTabs
}
/**
- * Check visibility of the attribute on the product page
+ * Check visibility of the attribute on the product page.
*
* @param mixed $productAttribute
* @return bool
@@ -277,7 +325,7 @@ class ProductForm extends FormTabs
}
/**
- * Call method that checking present attribute in search result
+ * Call method that checking present attribute in search result.
*
* @param CatalogProductAttribute $productAttribute
* @return bool
@@ -292,7 +340,7 @@ class ProductForm extends FormTabs
}
/**
- * Check tab visibility on Product form
+ * Check tab visibility on Product form.
*
* @param string $tabName
* @return bool
@@ -306,7 +354,7 @@ class ProductForm extends FormTabs
}
/**
- * Open custom tab on Product form
+ * Open custom tab on Product form.
*
* @param string $tabName
* @return void
@@ -316,4 +364,110 @@ class ProductForm extends FormTabs
$tabName = strtolower($tabName);
$this->_rootElement->find(sprintf($this->customTab, $tabName), Locator::SELECTOR_XPATH)->click();
}
+
+ /**
+ * Get Require Notice Attributes.
+ *
+ * @param InjectableFixture $product
+ * @return array
+ *
+ * @SuppressWarnings(PHPMD.UnusedLocalVariable)
+ */
+ public function getRequireNoticeAttributes(InjectableFixture $product)
+ {
+ $data = [];
+ $tabs = $this->getFieldsByTabs($product);
+ foreach ($tabs as $tabName => $fields) {
+ $tab = $this->getTabElement($tabName);
+ $this->openTab($tabName);
+ $errors = $tab->getJsErrors();
+ if (!empty($errors)) {
+ $data[$tabName] = $errors;
+ }
+ }
+ return $data;
+ }
+
+ /**
+ * Fill product attribute form.
+ *
+ * @param CatalogProductAttribute $productAttribute
+ * @return void
+ */
+ public function fillAttributeForm(CatalogProductAttribute $productAttribute)
+ {
+ $attributeForm = $this->getAttributeForm();
+ $attributeForm->fill($productAttribute);
+ }
+
+ /**
+ * Click "Save" button on attribute form.
+ *
+ * @return void
+ */
+ public function saveAttributeForm()
+ {
+ $this->getAttributeForm()->saveAttributeForm();
+
+ $browser = $this->browser;
+ $element = $this->newAttributeForm;
+ $loader = $this->loader;
+ $this->_rootElement->waitUntil(
+ function () use ($browser, $element) {
+ return $browser->find($element)->isVisible() == false ? true : null;
+ }
+ );
+
+ $this->_rootElement->waitUntil(
+ function () use ($browser, $loader) {
+ return $browser->find($loader)->isVisible() == false ? true : null;
+ }
+ );
+ }
+
+ /**
+ * Get Attribute Form.
+ *
+ * @return AttributeForm
+ */
+ public function getAttributeForm()
+ {
+ /** @var AttributeForm $attributeForm */
+ return $this->blockFactory->create(
+ 'Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\AttributeForm',
+ ['element' => $this->browser->find('body')]
+ );
+ }
+
+ /**
+ * Get attribute element.
+ *
+ * @param CatalogProductAttribute $attribute
+ * @return CustomAttribute
+ */
+ public function getAttributeElement(CatalogProductAttribute $attribute)
+ {
+ return $this->_rootElement->find(
+ sprintf($this->attributeBlock, $attribute->getAttributeCode()),
+ Locator::SELECTOR_CSS,
+ 'Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\CustomAttribute'
+ );
+ }
+
+ /**
+ * Click "Add Attribute" button from specific tab.
+ *
+ * @param string $tabName
+ * @throws \Exception
+ */
+ public function addNewAttribute($tabName = 'product-details')
+ {
+ $tab = $this->getTabElement($tabName);
+ if ($tab instanceof ProductTab) {
+ $this->openTab($tabName);
+ $tab->addNewAttribute($tabName);
+ } else {
+ throw new \Exception("$tabName hasn't 'Add attribute' button or is not instance of ProductTab class.");
+ }
+ }
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/ProductForm.xml b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/ProductForm.xml
index 3c5c315ec91f6b13cfb6c3b1b395bc313754d53f..d28c386d86dfe4a71fcd4d9b0b7003ddb9287002 100755
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/ProductForm.xml
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/ProductForm.xml
@@ -25,7 +25,7 @@
-->
<tabs>
<product-details>
- <class>\Magento\Backend\Test\Block\Widget\Tab</class>
+ <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Edit\ProductTab</class>
<selector>#product_info_tabs_product-details</selector>
<strategy>css selector</strategy>
<wrapper>product</wrapper>
@@ -62,10 +62,14 @@
</is_in_stock>
</quantity_and_stock_status>
<description />
+ <custom_attribute>
+ <class>Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\CustomAttribute</class>
+ <selector>#attribute-%attribute_code%-container</selector>
+ </custom_attribute>
</fields>
</product-details>
<search-engine-optimization>
- <class>\Magento\Backend\Test\Block\Widget\Tab</class>
+ <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Edit\ProductTab</class>
<selector>#product_info_tabs_search-engine-optimization</selector>
<strategy>css selector</strategy>
<wrapper>product</wrapper>
@@ -131,7 +135,7 @@
</fields>
</advanced-inventory>
<autosettings>
- <class>\Magento\Backend\Test\Block\Widget\Tab</class>
+ <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Edit\ProductTab</class>
<selector>#product_info_tabs_autosettings</selector>
<strategy>css selector</strategy>
<wrapper>product</wrapper>
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/Additional.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/Additional.php
new file mode 100644
index 0000000000000000000000000000000000000000..1ec20b4f15364da21140dc4392d44067dd5981a7
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/Additional.php
@@ -0,0 +1,128 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\Block\Product;
+
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Mtf\Client\Element;
+use Mtf\Client\Element\Locator;
+use Mtf\Block\Block;
+
+/**
+ * Product additional information block on the product page.
+ */
+class Additional extends Block
+{
+ /**
+ * Custom attribute selector.
+ *
+ * @var string
+ */
+ protected $attributeSelector = '//tr/th';
+
+ /**
+ * Custom attribute value selector.
+ *
+ * @var string
+ */
+ protected $attributeValueSelector = '/following::td[1]';
+
+ /**
+ * Get product attributes.
+ *
+ * @return Element[]
+ */
+ protected function getProductAttributes()
+ {
+ $data = [];
+ $elements = $this->_rootElement->find($this->attributeSelector, Locator::SELECTOR_XPATH)->getElements();
+ foreach ($elements as $element) {
+ $data[$element->getText()] = $this->_rootElement->find(
+ $this->attributeSelector . $this->attributeValueSelector,
+ Locator::SELECTOR_XPATH
+ );
+ }
+ return $data;
+ }
+
+ /**
+ * Check if attribute value contains tag.
+ *
+ * @param CatalogProductAttribute $attribute
+ * @return bool
+ */
+ public function hasHtmlTagInAttributeValue(CatalogProductAttribute $attribute)
+ {
+ $data = $attribute->getData();
+ $defaultValue = preg_grep('/^default_value/', array_keys($data));
+ $selector = $this->resolveHtmlStructure($data[array_shift($defaultValue)]);
+ $element = $this->getProductAttributes()[$attribute->getFrontendLabel()];
+
+ return $this->checkHtmlTagStructure($element, $selector)->isVisible();
+ }
+
+ /**
+ * Find <tag1><tag2><tagN> ... </tagN></tag2></tag1> tag structure in element.
+ *
+ * @param Element $element
+ * @param string $selector
+ * @return Element
+ */
+ protected function checkHtmlTagStructure(Element $element, $selector)
+ {
+ return $element->find($selector);
+ }
+
+ /**
+ * Get list of available attributes.
+ *
+ * @return array
+ */
+ public function getAttributeLabels()
+ {
+ return array_keys($this->getProductAttributes());
+ }
+
+ /**
+ * Resolve html structure from given string, which contains html tags.
+ *
+ * @param string $stringWithHtml
+ * @return array
+ */
+ protected function resolveHtmlStructure($stringWithHtml)
+ {
+ $selector = '';
+ $dom = new \DOMDocument();
+ $dom->loadHTML($stringWithHtml);
+ $xmlStructure = $xmlStructure = $dom->saveXML();
+ $parser = xml_parser_create();
+ xml_parse_into_struct($parser, $xmlStructure, $htmlData);
+ $htmlData = array_slice($htmlData, 2, -2); //Remove <html> and <body> tags
+ $middleElement = ceil(count($htmlData) / 2);
+ for ($index = 0; $index < $middleElement; $index++) {
+ $selector .= $htmlData[$index]['tag'] . " ";
+ }
+ return trim($selector);
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/Compare/ListCompare.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/Compare/ListCompare.php
index 4e34ab73f1692ed83fa1a83e717c322ce6e15eef..7015feda927b2f61547aa55da9613d03a0d14588 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/Compare/ListCompare.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/Compare/ListCompare.php
@@ -24,81 +24,88 @@
namespace Magento\Catalog\Test\Block\Product\Compare;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
use Mtf\Block\Block;
use Mtf\Client\Element;
use Mtf\Client\Element\Locator;
/**
- * Class ListCompare
- * Compare list product block
+ * Compare list product block.
*/
class ListCompare extends Block
{
/**
- * Selector by product info
+ * Selector by product info.
*
* @var string
*/
protected $productInfo = '//td[contains(@class, "cell product info")][%d]';
/**
- * Selector by product attribute
+ * Selector by product attribute.
*
* @var string
*/
protected $productAttribute = '//tr[th//*[normalize-space(text()) = "%s"]]';
/**
- * Selector by name product
+ * Selector by name product.
*
* @var string
*/
protected $nameSelector = './/*[contains(@class, "product-item-name")]/a';
/**
- * Selector for search product via name
+ * Selector for search product via name.
*
* @var string
*/
protected $productName = '[normalize-space(text()) = "%s"]';
/**
- * Selector by price product
+ * Selector by price product.
*
* @var string
*/
protected $priceSelector = './/div[contains(@class,"price-box")]';
/**
- * Selector by sku product
+ * Selector by sku product.
*
* @var string
*/
protected $attributeSelector = './td[%d]/div';
/**
- * Remove button selector
+ * Global attribute selector.
+ *
+ * @var string
+ */
+ protected $attribute = 'span.attribute';
+
+ /**
+ * Remove button selector.
*
* @var string
*/
protected $removeButton = './/thead//td[%d]//a[contains(@class,"action delete")]';
/**
- * Selector for empty message
+ * Selector for empty message.
*
* @var string
*/
protected $isEmpty = 'p.empty';
/**
- * Selector for message block
+ * Selector for message block.
*
* @var string
*/
protected $messageBlock = '#messages';
/**
- * Get product info
+ * Get product info.
*
* @param int $index
* @param string $attributeKey
@@ -125,7 +132,7 @@ class ListCompare extends Block
}
/**
- * Get item compare product info
+ * Get item compare product info.
*
* @param int $index
* @return Element
@@ -136,33 +143,30 @@ class ListCompare extends Block
}
/**
- * Get item compare product attribute
+ * Get list of comparable product attributes.
*
- * @param string $key
- * @return Element
+ * @return array
*/
- protected function getCompareProductAttribute($key)
+ public function getComparableAttributes()
{
- return $this->_rootElement->find(sprintf($this->productAttribute, $key), Locator::SELECTOR_XPATH);
- }
-
- /**
- * Get item attribute
- *
- * @param int $indexProduct
- * @param string $attributeKey
- * @return string
- */
- public function getProductAttribute($indexProduct, $attributeKey)
- {
- return trim(
- $this->getCompareProductAttribute($attributeKey)
- ->find(sprintf($this->attributeSelector, $indexProduct), Locator::SELECTOR_XPATH)->getText()
+ $rootElement = $this->_rootElement;
+ $element = $this->nameSelector;
+ $this->_rootElement->waitUntil(
+ function () use ($rootElement, $element) {
+ return $rootElement->find($element, Locator::SELECTOR_XPATH)->isVisible() ? true : null;
+ }
);
+
+ $data = [];
+ $attributes = $this->_rootElement->find($this->attribute)->getElements();
+ foreach ($attributes as $attribute) {
+ $data[] = $attribute->getText();
+ }
+ return $data;
}
/**
- * Remove product from compare product list
+ * Remove product from compare product list.
*
* @param int $index [optional]
* @return void
@@ -194,7 +198,7 @@ class ListCompare extends Block
}
/**
- * Visible product in compare product list
+ * Visible product in compare product list.
*
* @param int $index [optional]
* @return bool
@@ -205,7 +209,7 @@ class ListCompare extends Block
}
/**
- * Verify product is visible in compare product block
+ * Verify product is visible in compare product block.
*
* @param string $productName
* @return bool
@@ -217,8 +221,8 @@ class ListCompare extends Block
}
/**
- * Get empty message on compare product block
- * Returns message absence of compared products or false, if the message isn't visible
+ * Get empty message on compare product block.
+ * Returns message absence of compared products or false, if the message isn't visible.
*
* @return string|bool
*/
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/ListProduct.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/ListProduct.php
index 28fa631ac95be7302806fce8c5a75357010b0f89..173242e22b47c612b89c4f24d82a3615d68efb71 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/ListProduct.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/ListProduct.php
@@ -30,8 +30,7 @@ use Mtf\Factory\Factory;
use Mtf\Client\Element\Locator;
/**
- * Class SearchResultsList
- * Product list
+ * Product list.
*/
class ListProduct extends Block
{
@@ -57,47 +56,54 @@ class ListProduct extends Block
protected $productDetailsSelector = '//*[contains(@class, "product details") and .//*[@title="%s"]]';
/**
- * Product name
+ * Product name.
*
* @var string
*/
protected $productTitle = '.product.name [title="%s"]';
/**
- * Click for Price link on category page
+ * Click for Price link on category page.
*
* @var string
*/
protected $clickForPrice = "//div[contains(@class, 'product details') and ('%s')]//a[contains(@id, 'msrp-popup')]";
/**
- * Minimum Advertised Price on category page
+ * Minimum Advertised Price on category page.
*
* @var string
*/
protected $oldPrice = ".old-price .price-container";
/**
- * 'Add to Card' button
+ * 'Add to Card' button.
*
* @var string
*/
protected $addToCard = "button.action.tocart";
/**
- * Price box CSS selector
- *
+ * Price box CSS selector.
+ *
* @var string
*/
protected $priceBox = '.price-box #product-price-%s .price';
/**
- * Popup map price
+ * Popup map price.
*
* @var string
*/
protected $mapPopupPrice = '//ancestor::*[@id="map-popup-click-for-price"]';
+ /**
+ * Sorter dropdown selector.
+ *
+ * @var string
+ */
+ protected $sorter = '#sorter';
+
/**
* This method returns the price box block for the named product.
*
@@ -112,7 +118,7 @@ class ListProduct extends Block
}
/**
- * Check if product with specified name is visible
+ * Check if product with specified name is visible.
*
* @param string $productName
* @return bool
@@ -133,7 +139,7 @@ class ListProduct extends Block
}
/**
- * Open product view page by clicking on product name
+ * Open product view page by clicking on product name.
*
* @param string $productName
* @return void
@@ -169,7 +175,7 @@ class ListProduct extends Block
}
/**
- * Open MAP block on category page
+ * Open MAP block on category page.
*
* @param string $productName
* @return void
@@ -181,7 +187,7 @@ class ListProduct extends Block
}
/**
- * Get Minimum Advertised Price on Category page
+ * Get Minimum Advertised Price on Category page.
*
* @return string
*/
@@ -191,7 +197,7 @@ class ListProduct extends Block
}
/**
- * Retrieve product price by specified Id
+ * Retrieve product price by specified Id.
*
* @param int $productId
* @return string
@@ -203,7 +209,7 @@ class ListProduct extends Block
}
/**
- * Check 'Add To Card' button availability
+ * Check 'Add To Card' button availability.
*
* @return bool
*/
@@ -211,4 +217,14 @@ class ListProduct extends Block
{
return $this->_rootElement->find($this->addToCard, Locator::SELECTOR_CSS)->isVisible();
}
+
+ /**
+ * Get all terms used in sort.
+ *
+ * @return array
+ */
+ public function getSortByValues()
+ {
+ return explode("\n", $this->_rootElement->find($this->sorter)->getText());
+ }
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/View.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/View.php
index aa7f5516ee44efb22500bd5b2de583aeecd41986..85c76818f0a7dd39a8a6ef3e9c65cd27702205cf 100755
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/View.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Product/View.php
@@ -31,8 +31,7 @@ use Magento\Catalog\Test\Fixture\CatalogProductSimple;
use Magento\Catalog\Test\Block\AbstractConfigureBlock;
/**
- * Class View
- * Product view block on the product page
+ * Product view block on the product page.
*
* @SuppressWarnings(PHPMD.TooManyFields)
* @SuppressWarnings(PHPMD.ExcessivePublicCount)
@@ -41,84 +40,84 @@ use Magento\Catalog\Test\Block\AbstractConfigureBlock;
class View extends AbstractConfigureBlock
{
/**
- * XPath selector for tab
+ * XPath selector for tab.
*
* @var string
*/
protected $tabSelector = './/div[@data-role="collapsible" and a[contains(text(),"%s")]]';
/**
- * Custom options CSS selector
+ * Custom options CSS selector.
*
* @var string
*/
protected $customOptionsSelector = '.product-options-wrapper';
/**
- * 'Add to Cart' button
+ * 'Add to Cart' button.
*
* @var string
*/
protected $addToCart = '.tocart';
/**
- * Quantity input id
+ * Quantity input id.
*
* @var string
*/
protected $qty = '#qty';
/**
- * 'Check out with PayPal' button
+ * 'Check out with PayPal' button.
*
* @var string
*/
protected $paypalCheckout = '[data-action=checkout-form-submit]';
/**
- * Product name element
+ * Product name element.
*
* @var string
*/
protected $productName = '.page-title.product h1.title .base';
/**
- * Product sku element
+ * Product sku element.
*
* @var string
*/
protected $productSku = '[itemprop="sku"]';
/**
- * Product description element
+ * Product description element.
*
* @var string
*/
protected $productDescription = '.product.attibute.description';
/**
- * Product short-description element
+ * Product short-description element.
*
* @var string
*/
protected $productShortDescription = '.product.attibute.overview';
/**
- * Click for Price link on Product page
+ * Click for Price link on Product page.
*
* @var string
*/
protected $clickForPrice = '[id*=msrp-popup]';
/**
- * MAP popup on Product page
+ * MAP popup on Product page.
*
* @var string
*/
protected $mapPopup = '#map-popup-click-for-price';
/**
- * Stock Availability control
+ * Stock Availability control.
*
* @var string
*/
@@ -132,28 +131,35 @@ class View extends AbstractConfigureBlock
protected $tierPricesSelector = "//ul[contains(@class,'tier')]//*[@class='item'][%line-number%]";
/**
- * Selector for price block
+ * Selector for price block.
*
* @var string
*/
protected $priceBlock = '//*[@class="product-info-main"]//*[contains(@class,"price-box")]';
/**
- * 'Add to Compare' button
+ * 'Add to Compare' button.
*
* @var string
*/
protected $clickAddToCompare = '.action.tocompare';
/**
- * "Add to Wishlist" button
+ * "Add to Wishlist" button.
*
* @var string
*/
protected $addToWishlist = '[data-action="add-to-wishlist"]';
/**
- * Get block price
+ * Messages block locator.
+ *
+ * @var string
+ */
+ protected $messageBlock = '.page.messages';
+
+ /**
+ * Get block price.
*
* @return \Magento\Catalog\Test\Block\Product\Price
*/
@@ -166,7 +172,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Add product to shopping cart
+ * Add product to shopping cart.
*
* @param FixtureInterface $product
* @return void
@@ -187,7 +193,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Click link
+ * Click link.
*
* @return void
*/
@@ -197,7 +203,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Set quantity and click add to cart
+ * Set quantity and click add to cart.
*
* @param int $qty
* @return void
@@ -209,18 +215,20 @@ class View extends AbstractConfigureBlock
}
/**
- * Set quantity
+ * Set quantity.
*
* @param int $qty
* @return void
*/
public function setQty($qty)
{
- $this->_rootElement->find($this->qty, Locator::SELECTOR_CSS)->setValue($qty);
+ $this->browser->selectWindow();
+ $this->_rootElement->find($this->qty)->keys([$qty]);
+ $this->_rootElement->click();
}
/**
- * Find Add To Cart button
+ * Find Add To Cart button.
*
* @return bool
*/
@@ -230,7 +238,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Press 'Check out with PayPal' button
+ * Press 'Check out with PayPal' button.
*
* @return void
*/
@@ -240,7 +248,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Get product name displayed on page
+ * Get product name displayed on page.
*
* @return string
*/
@@ -250,7 +258,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Get product sku displayed on page
+ * Get product sku displayed on page.
*
* @return string
*/
@@ -260,7 +268,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Return product price excluding tax displayed on page
+ * Return product price excluding tax displayed on page.
*
* @return string
*/
@@ -270,7 +278,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Return product price including tax displayed on page
+ * Return product price including tax displayed on page.
*
* @return string
*/
@@ -280,7 +288,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Return product short description on page
+ * Return product short description on page.
*
* @return string|null
*/
@@ -293,7 +301,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Return product description on page
+ * Return product description on page.
*
* @return string|null
*/
@@ -306,7 +314,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Return product options
+ * Return product options.
*
* @param FixtureInterface $product
* @return array
@@ -323,7 +331,7 @@ class View extends AbstractConfigureBlock
}
/**
- * This method return array tier prices
+ * This method return array tier prices.
*
* @param int $lineNumber [optional]
* @return array
@@ -337,7 +345,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Click "ADD TO CART" button
+ * Click "ADD TO CART" button.
*
* @return void
*/
@@ -347,7 +355,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Open MAP block on Product View page
+ * Open MAP block on Product View page.
*
* @return void
*/
@@ -358,7 +366,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Check 'Add to card' button visible
+ * Check 'Add to card' button visible.
*
* @return bool
*/
@@ -368,7 +376,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Get text of Stock Availability control
+ * Get text of Stock Availability control.
*
* @return string
*/
@@ -378,17 +386,23 @@ class View extends AbstractConfigureBlock
}
/**
- * Click "Add to Compare" button
+ * Click "Add to Compare" button.
*
* @return void
*/
public function clickAddToCompare()
{
+ /** @var \Magento\Core\Test\Block\Messages $messageBlock */
+ $messageBlock = $this->blockFactory->create(
+ 'Magento\Core\Test\Block\Messages',
+ ['element' => $this->browser->find($this->messageBlock)]
+ );
$this->_rootElement->find($this->clickAddToCompare, Locator::SELECTOR_CSS)->click();
+ $messageBlock->waitSuccessMessage();
}
/**
- * Add product to Wishlist
+ * Add product to Wishlist.
*
* @param FixtureInterface $product
* @return void
@@ -405,7 +419,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Click "Add to Wishlist" button
+ * Click "Add to Wishlist" button.
*
* @return void
*/
@@ -415,7 +429,7 @@ class View extends AbstractConfigureBlock
}
/**
- * Select tab on the product page
+ * Select tab on the product page.
*
* @param string $name
* @return void
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertAddedProductAttributeOnProductForm.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertAddedProductAttributeOnProductForm.php
index 36c16cc0bb5d37ad0685e0c81e0fd127da3a5713..0575d136224a1669ea3cc54758113d6b8a2cd497 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertAddedProductAttributeOnProductForm.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertAddedProductAttributeOnProductForm.php
@@ -24,19 +24,14 @@
namespace Magento\Catalog\Test\Constraint;
-use Mtf\Fixture\FixtureFactory;
-use Mtf\Util\Protocol\CurlTransport;
+use Mtf\Fixture\InjectableFixture;
use Mtf\Constraint\AbstractConstraint;
-use Magento\Catalog\Test\Fixture\CatalogAttributeSet;
use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
use Magento\Catalog\Test\Page\Adminhtml\CatalogProductEdit;
use Magento\Catalog\Test\Page\Adminhtml\CatalogProductIndex;
-use Magento\Catalog\Test\Page\Adminhtml\CatalogProductSetEdit;
-use Magento\Catalog\Test\Page\Adminhtml\CatalogProductSetIndex;
/**
- * Class AssertAddedProductAttributeOnProductForm
- * Check attribute on product form
+ * Check attribute on product form.
*/
class AssertAddedProductAttributeOnProductForm extends AbstractConstraint
{
@@ -49,52 +44,23 @@ class AssertAddedProductAttributeOnProductForm extends AbstractConstraint
/**
* Add this attribute to Default attribute Template. Create product and Assert that created attribute
- * is displayed on product form (Products > Inventory > Catalog)
+ * is displayed on product form (Products > Inventory > Catalog).
*
- * @param FixtureFactory $fixtureFactory
- * @param CatalogProductSetIndex $productSet
- * @param CatalogProductSetEdit $productSetEdit
- * @param CatalogAttributeSet $productTemplate
+ * @param InjectableFixture $product
* @param CatalogProductIndex $productGrid
- * @param CatalogProductAttribute $productAttributeOriginal
* @param CatalogProductEdit $productEdit
- * @param CatalogProductAttribute|null $productAttribute
+ * @param CatalogProductAttribute $attribute
+ * @param CatalogProductAttribute $productAttributeOriginal
+ * @throws \Exception
* @return void
*/
public function processAssert(
- FixtureFactory $fixtureFactory,
- CatalogProductSetIndex $productSet,
- CatalogProductSetEdit $productSetEdit,
- CatalogAttributeSet $productTemplate,
+ InjectableFixture $product,
CatalogProductIndex $productGrid,
CatalogProductEdit $productEdit,
- CatalogProductAttribute $productAttribute,
+ CatalogProductAttribute $attribute,
CatalogProductAttribute $productAttributeOriginal = null
) {
- $filterAttribute = [
- 'set_name' => $productTemplate->getAttributeSetName(),
- ];
- $productSet->open();
- $productSet->getGrid()->searchAndOpen($filterAttribute);
-
- $attributeData = ($productAttributeOriginal !== null)
- ? array_merge($productAttribute->getData(), $productAttributeOriginal->getData())
- : $productAttribute->getData();
-
- $productSetEdit->getAttributeSetEditBlock()->moveAttribute($attributeData, 'Product Details');
- $productSetEdit->getPageActions()->save();
-
- $product = $fixtureFactory->createByCode(
- 'catalogProductSimple',
- [
- 'dataSet' => 'product_with_category',
- 'data' => [
- 'attribute_set_id' => ['attribute_set' => $productTemplate],
- ],
- ]
- );
- $product->persist();
-
$filterProduct = [
'sku' => $product->getSku(),
];
@@ -102,8 +68,8 @@ class AssertAddedProductAttributeOnProductForm extends AbstractConstraint
$productGrid->getProductGrid()->searchAndOpen($filterProduct);
$catalogProductAttribute = ($productAttributeOriginal !== null)
- ? array_merge($productAttributeOriginal->getData(), $productAttribute->getData())
- : $productAttribute->getData();
+ ? array_merge($productAttributeOriginal->getData(), $attribute->getData())
+ : $attribute->getData();
\PHPUnit_Framework_Assert::assertTrue(
$productEdit->getProductForm()->checkAttributeLabel($catalogProductAttribute),
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertAttributeForm.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertAttributeForm.php
new file mode 100644
index 0000000000000000000000000000000000000000..f64c95e86b8bd96a55e7ed17b878f0434c029a63
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertAttributeForm.php
@@ -0,0 +1,74 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\Constraint;
+
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeIndex;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeNew;
+use Mtf\Constraint\AbstractAssertForm;
+
+/**
+ * Assert that displayed attribute data on edit page equals passed from fixture.
+ */
+class AssertAttributeForm extends AbstractAssertForm
+{
+ /**
+ * Constraint severeness
+ *
+ * @var string
+ */
+ protected $severeness = 'low';
+
+ /**
+ * Assert that displayed attribute data on edit page equals passed from fixture.
+ *
+ * @param CatalogProductAttributeIndex $catalogProductAttributeIndex
+ * @param CatalogProductAttributeNew $catalogProductAttributeNew
+ * @param CatalogProductAttribute $attribute
+ * @throws \Exception
+ * @return void
+ */
+ public function processAssert(
+ CatalogProductAttributeIndex $catalogProductAttributeIndex,
+ CatalogProductAttributeNew $catalogProductAttributeNew,
+ CatalogProductAttribute $attribute
+ ) {
+ $filter = ['attribute_code' => $attribute->getAttributeCode()];
+ $catalogProductAttributeIndex->open()->getGrid()->searchAndOpen($filter);
+
+ $errors = $this->verifyData($attribute->getData(), $catalogProductAttributeNew->getAttributeForm()->getData());
+ \PHPUnit_Framework_Assert::assertEmpty($errors, $errors);
+ }
+
+ /**
+ * Returns string representation of object.
+ *
+ * @return string
+ */
+ public function toString()
+ {
+ return 'Displayed attribute data on edit page equals passed from fixture.';
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeDisplayingOnFrontend.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeDisplayingOnFrontend.php
index cc5e69c1441b17b008de2ad6dd3e245392920f5b..2b3e36577afe8cbeae37b82927d1b375a1c1004a 100755
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeDisplayingOnFrontend.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeDisplayingOnFrontend.php
@@ -24,10 +24,14 @@
namespace Magento\Catalog\Test\Constraint;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Catalog\Test\Page\Product\CatalogProductView;
+use Mtf\Client\Driver\Selenium\Browser;
use Mtf\Constraint\AbstractConstraint;
+use Mtf\Fixture\InjectableFixture;
/**
- * Class AssertProductAttributeDisplayingOnFrontend
+ * Check whether the attribute is visible on the frontend.
*/
class AssertProductAttributeDisplayingOnFrontend extends AbstractConstraint
{
@@ -39,18 +43,38 @@ class AssertProductAttributeDisplayingOnFrontend extends AbstractConstraint
protected $severeness = 'low';
/**
+ * Check whether the attribute is visible on the frontend.
+ *
+ * @param InjectableFixture $product
+ * @param CatalogProductAttribute $attribute
+ * @param CatalogProductView $catalogProductView
+ * @param Browser $browser
* @return void
*/
- public function processAssert()
- {
- //
+ public function processAssert(
+ InjectableFixture $product,
+ CatalogProductAttribute $attribute,
+ CatalogProductView $catalogProductView,
+ Browser $browser
+ ) {
+ $browser->open($_ENV['app_frontend_url'] . $product->getUrlKey() . '.html');
+
+ \PHPUnit_Framework_Assert::assertTrue(
+ in_array(
+ $attribute->getFrontendLabel(),
+ $catalogProductView->getAdditionalInformationBlock()->getAttributeLabels()
+ ),
+ 'Attribute is not visible on product page in additional info block on frontend.'
+ );
}
/**
+ * Returns string representation of object.
+ *
* @return string
*/
public function toString()
{
- //
+ return 'Attribute is visible on product page in additional info block on frontend.';
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeDisplayingOnSearchForm.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeDisplayingOnSearchForm.php
index 31015e0658da291cb09747d0a6500a1f4f2c6489..735729ae1c838ae187bc7e87bfd0e26a47d54107 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeDisplayingOnSearchForm.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeDisplayingOnSearchForm.php
@@ -24,10 +24,12 @@
namespace Magento\Catalog\Test\Constraint;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\CatalogSearch\Test\Page\AdvancedSearch;
use Mtf\Constraint\AbstractConstraint;
/**
- * Class AssertProductAttributeDisplayingOnSearchForm
+ * Check whether attribute is displayed in the advanced search form on the frontend.
*/
class AssertProductAttributeDisplayingOnSearchForm extends AbstractConstraint
{
@@ -39,18 +41,32 @@ class AssertProductAttributeDisplayingOnSearchForm extends AbstractConstraint
protected $severeness = 'low';
/**
+ * Check whether attribute is displayed in the advanced search form on the frontend.
+ *
+ * @param CatalogProductAttribute $attribute
+ * @param AdvancedSearch $advancedSearch
* @return void
*/
- public function processAssert()
+ public function processAssert(CatalogProductAttribute $attribute, AdvancedSearch $advancedSearch)
{
- //
+ $advancedSearch->open();
+ $formLabels = $advancedSearch->getForm()->getFormlabels();
+ $label = $attribute->hasData('manage_frontend_label')
+ ? $attribute->getManageFrontendLabel()
+ : $attribute->getFrontendLabel();
+ \PHPUnit_Framework_Assert::assertTrue(
+ in_array($label, $formLabels),
+ 'Attribute is absent on advanced search form.'
+ );
}
/**
+ * Returns string representation of object.
+ *
* @return string
*/
public function toString()
{
- //
+ return 'Attribute is present on advanced search form.';
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsComparable.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsComparable.php
index 816f31c66527df19d5a3cb8ce95589ca624bedd9..291dfe491091e4dd4fe19ba49a18a305a9b55fc4 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsComparable.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsComparable.php
@@ -24,10 +24,15 @@
namespace Magento\Catalog\Test\Constraint;
+use Magento\Catalog\Test\Page\Product\CatalogProductCompare;
+use Magento\Catalog\Test\Page\Product\CatalogProductView;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Mtf\Client\Driver\Selenium\Browser;
use Mtf\Constraint\AbstractConstraint;
+use Mtf\Fixture\InjectableFixture;
/**
- * Class AssertProductAttributeIsComparable
+ * Check whether there is an opportunity to compare products using given attribute.
*/
class AssertProductAttributeIsComparable extends AbstractConstraint
{
@@ -39,18 +44,41 @@ class AssertProductAttributeIsComparable extends AbstractConstraint
protected $severeness = 'low';
/**
- * @return void
+ * Check whether there is an opportunity to compare products using given attribute.
+ *
+ * @param InjectableFixture $product
+ * @param CatalogProductAttribute $attribute
+ * @param Browser $browser
+ * @param CatalogProductView $catalogProductView
+ * @param CatalogProductCompare $catalogProductCompare
*/
- public function processAssert()
- {
- //
+ public function processAssert(
+ InjectableFixture $product,
+ CatalogProductAttribute $attribute,
+ Browser $browser,
+ CatalogProductView $catalogProductView,
+ CatalogProductCompare $catalogProductCompare
+ ) {
+ $browser->open($_ENV['app_frontend_url'] . $product->getUrlKey() . '.html');
+ $catalogProductView->getViewBlock()->clickAddToCompare();
+ $catalogProductCompare->open();
+ $label = $attribute->hasData('manage_frontend_label')
+ ? $attribute->getManageFrontendLabel()
+ : $attribute->getFrontendLabel();
+
+ \PHPUnit_Framework_Assert::assertTrue(
+ in_array($label, $catalogProductCompare->getCompareProductsBlock()->getComparableAttributes()),
+ 'Attribute is absent on product compare page.'
+ );
}
/**
+ * Return string representation of object.
+ *
* @return string
*/
public function toString()
{
- //
+ return 'Attribute is present on product compare page.';
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsFilterable.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsFilterable.php
index 4d7a040b3b70a81bd2ec31de91955b0202649ba0..b898c9fae27d7cc36182563d242174f7b351a038 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsFilterable.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsFilterable.php
@@ -24,10 +24,14 @@
namespace Magento\Catalog\Test\Constraint;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Catalog\Test\Page\Category\CatalogCategoryView;
+use Magento\Cms\Test\Page\CmsIndex;
use Mtf\Constraint\AbstractConstraint;
+use Mtf\Fixture\InjectableFixture;
/**
- * Class AssertProductAttributeIsFilterable
+ * Check whether the attribute filter is displayed on the frontend in Layered navigation.
*/
class AssertProductAttributeIsFilterable extends AbstractConstraint
{
@@ -39,18 +43,37 @@ class AssertProductAttributeIsFilterable extends AbstractConstraint
protected $severeness = 'low';
/**
+ * Check whether the attribute filter is displayed on the frontend in Layered navigation.
+ *
+ * @param CatalogCategoryView $catalogCategoryView
+ * @param InjectableFixture $product
+ * @param CatalogProductAttribute $attribute
+ * @param CmsIndex $cmsIndex
* @return void
*/
- public function processAssert()
- {
- //
+ public function processAssert(
+ CatalogCategoryView $catalogCategoryView,
+ InjectableFixture $product,
+ CatalogProductAttribute $attribute,
+ CmsIndex $cmsIndex
+ ) {
+ $cmsIndex->open()->getTopmenu()->selectCategoryByName($product->getCategoryIds()[0]);
+ $label = $attribute->hasData('manage_frontend_label')
+ ? $attribute->getManageFrontendLabel()
+ : $attribute->getFrontendLabel();
+ \PHPUnit_Framework_Assert::assertTrue(
+ in_array($label, $catalogCategoryView->getLayeredNavigationBlock()->getFilters()),
+ 'Attribute is absent in layered navigation on category page.'
+ );
}
/**
+ * Return string representation of object.
+ *
* @return string
*/
public function toString()
{
- //
+ return 'Attribute is present in layered navigation on category page.';
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsFilterableInSearch.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsFilterableInSearch.php
index d1e7e97d89f64682602127023b3f7699d3daa297..e5426aa731e112b0b812e168ba27c0372e217f27 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsFilterableInSearch.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsFilterableInSearch.php
@@ -24,10 +24,14 @@
namespace Magento\Catalog\Test\Constraint;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Catalog\Test\Page\Category\CatalogCategoryView;
+use Magento\Cms\Test\Page\CmsIndex;
use Mtf\Constraint\AbstractConstraint;
+use Mtf\Fixture\InjectableFixture;
/**
- * Class AssertProductAttributeIsFilterableInSearch
+ * Check out if the attribute in the navigation bar on the search results page in Layered navigation.
*/
class AssertProductAttributeIsFilterableInSearch extends AbstractConstraint
{
@@ -39,18 +43,37 @@ class AssertProductAttributeIsFilterableInSearch extends AbstractConstraint
protected $severeness = 'low';
/**
+ * Check out if the attribute in the navigation bar on the search results page in Layered navigation.
+ *
+ * @param CmsIndex $cmsIndex
+ * @param CatalogCategoryView $catalogCategoryView
+ * @param InjectableFixture $product
+ * @param CatalogProductAttribute $attribute
* @return void
*/
- public function processAssert()
- {
- //
+ public function processAssert(
+ CmsIndex $cmsIndex,
+ CatalogCategoryView $catalogCategoryView,
+ InjectableFixture $product,
+ CatalogProductAttribute $attribute
+ ) {
+ $cmsIndex->open()->getSearchBlock()->search($product->getName());
+ $label = $attribute->hasData('manage_frontend_label')
+ ? $attribute->getManageFrontendLabel()
+ : $attribute->getFrontendLabel();
+ \PHPUnit_Framework_Assert::assertTrue(
+ in_array($label, $catalogCategoryView->getLayeredNavigationBlock()->getFilters()),
+ 'Attribute is absent in layered navigation on search page.'
+ );
}
/**
+ * Return string representation of object.
+ *
* @return string
*/
public function toString()
{
- //
+ return 'Attribute is present in layered navigation on search page.';
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsGlobal.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsGlobal.php
index 39ee8167855484bf79cb278211df935d2f7df909..8604bcc6e64a5b95f5785b9788492cd45cc5a3a7 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsGlobal.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsGlobal.php
@@ -24,10 +24,12 @@
namespace Magento\Catalog\Test\Constraint;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeIndex;
use Mtf\Constraint\AbstractConstraint;
/**
- * Class AssertProductAttributeIsGlobal
+ * Look on the scope of product attribute in the grid.
*/
class AssertProductAttributeIsGlobal extends AbstractConstraint
{
@@ -39,18 +41,31 @@ class AssertProductAttributeIsGlobal extends AbstractConstraint
protected $severeness = 'low';
/**
+ * Look on the scope of product attribute in the grid.
+ *
+ * @param CatalogProductAttributeIndex $catalogProductAttributeIndex
+ * @param CatalogProductAttribute $attribute
* @return void
*/
- public function processAssert()
- {
- //
+ public function processAssert(
+ CatalogProductAttributeIndex $catalogProductAttributeIndex,
+ CatalogProductAttribute $attribute
+ ) {
+ $filter = ['frontend_label' => $attribute->getFrontendLabel(), 'is_global' => $attribute->getIsGlobal()];
+
+ \PHPUnit_Framework_Assert::assertTrue(
+ $catalogProductAttributeIndex->open()->getGrid()->isRowVisible($filter),
+ 'Attribute is not global.'
+ );
}
/**
+ * Return string representation of object.
+ *
* @return string
*/
public function toString()
{
- //
+ return 'Attribute is global.';
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsHtmlAllowed.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsHtmlAllowed.php
index 3757dbf1f50febbd5de2949803a1b0c51d2bdb19..4230a607adc17db88a98f896c3ef84d80930e7ba 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsHtmlAllowed.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsHtmlAllowed.php
@@ -24,10 +24,14 @@
namespace Magento\Catalog\Test\Constraint;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Catalog\Test\Page\Product\CatalogProductView;
+use Mtf\Client\Driver\Selenium\Browser;
use Mtf\Constraint\AbstractConstraint;
+use Mtf\Fixture\InjectableFixture;
/**
- * Class AssertProductAttributeIsHtmlAllowed
+ * Check whether html tags are using in an attribute value.
*/
class AssertProductAttributeIsHtmlAllowed extends AbstractConstraint
{
@@ -39,18 +43,37 @@ class AssertProductAttributeIsHtmlAllowed extends AbstractConstraint
protected $severeness = 'low';
/**
+ * Check whether html tags are using in attribute value.
+ * Checked tag structure <b><i>atttribute_default_value</p></i></b>
+ *
+ * @param InjectableFixture $product
+ * @param CatalogProductAttribute $attribute
+ * @param CatalogProductView $catalogProductView
+ * @param Browser $browser
+ * @throws \Exception
* @return void
*/
- public function processAssert()
- {
- //
+ public function processAssert(
+ InjectableFixture $product,
+ CatalogProductAttribute $attribute,
+ CatalogProductView $catalogProductView,
+ Browser $browser
+ ) {
+ $browser->open($_ENV['app_frontend_url'] . $product->getUrlKey() . '.html');
+
+ \PHPUnit_Framework_Assert::assertTrue(
+ $catalogProductView->getAdditionalInformationBlock()->hasHtmlTagInAttributeValue($attribute),
+ 'Attribute is not visible with HTML tags on frontend.'
+ );
}
/**
+ * Return string representation of object.
+ *
* @return string
*/
public function toString()
{
- //
+ return 'Attribute is visible with HTML tags on frontend.';
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsRequired.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsRequired.php
index af0ae098b22a9788303701d8cebe9235d2dec290..c4ce226f6bc4527aeb7f77177cb53ce8ab6c5a91 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsRequired.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsRequired.php
@@ -24,13 +24,22 @@
namespace Magento\Catalog\Test\Constraint;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductEdit;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductIndex;
use Mtf\Constraint\AbstractConstraint;
+use Mtf\Fixture\InjectableFixture;
/**
- * Class AssertProductAttributeIsRequired
+ * Check whether the attribute is mandatory.
*/
class AssertProductAttributeIsRequired extends AbstractConstraint
{
+ /**
+ * Expected message.
+ */
+ const REQUIRE_MESSAGE = 'This is a required field.';
+
/**
* Constraint severeness
*
@@ -39,18 +48,42 @@ class AssertProductAttributeIsRequired extends AbstractConstraint
protected $severeness = 'low';
/**
+ * Check whether the attribute is mandatory.
+ *
+ * @param CatalogProductIndex $catalogProductIndex
+ * @param CatalogProductEdit $catalogProductEdit
+ * @param CatalogProductAttribute $attribute
+ * @param InjectableFixture $product
* @return void
*/
- public function processAssert()
- {
- //
+ public function processAssert(
+ CatalogProductIndex $catalogProductIndex,
+ CatalogProductEdit $catalogProductEdit,
+ CatalogProductAttribute $attribute,
+ InjectableFixture $product
+ ) {
+ $catalogProductIndex->open()->getProductGrid()->searchAndOpen(['sku' => $product->getSku()]);
+ $productForm = $catalogProductEdit->getProductForm();
+ $productForm->getAttributeElement($attribute)->setValue('');
+ $catalogProductEdit->getFormPageActions()->save();
+ $failedAttributes = $productForm->getRequireNoticeAttributes($product);
+ $actualMessage = $failedAttributes['product-details'][$attribute->getFrontendLabel()];
+
+ \PHPUnit_Framework_Assert::assertEquals(
+ self::REQUIRE_MESSAGE,
+ $actualMessage,
+ 'JS error notice on product edit page is not equal to expected.'
+ );
}
/**
+ * Return string representation of object.
+ *
* @return string
*/
public function toString()
{
- //
+ return '"This is a required field" notice is visible on product edit page after trying to save product with '
+ . 'blank required field.';
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsUnique.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsUnique.php
index 47878c25cdad4751de33320856e1162303069748..0be1b2618f9e5e188a0eaedbf6b95ca2b8b6ccf3 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsUnique.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsUnique.php
@@ -24,13 +24,23 @@
namespace Magento\Catalog\Test\Constraint;
+use Magento\Catalog\Test\Fixture\CatalogAttributeSet;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Catalog\Test\Fixture\CatalogProductSimple;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductEdit;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductIndex;
use Mtf\Constraint\AbstractConstraint;
/**
- * Class AssertProductAttributeIsUnique
+ * Check whether the attribute is unique.
*/
class AssertProductAttributeIsUnique extends AbstractConstraint
{
+ /**
+ * Expected message.
+ */
+ const UNIQUE_MESSAGE = 'The value of attribute "%s" must be unique';
+
/**
* Constraint severeness
*
@@ -39,18 +49,45 @@ class AssertProductAttributeIsUnique extends AbstractConstraint
protected $severeness = 'low';
/**
+ * Check whether the attribute is unique.
+ *
+ * @param CatalogProductIndex $catalogProductIndex
+ * @param CatalogProductEdit $catalogProductEdit
+ * @param CatalogProductSimple $product
+ * @param CatalogProductAttribute $attribute
+ * @throws \Exception
* @return void
*/
- public function processAssert()
- {
- //
+ public function processAssert(
+ CatalogProductIndex $catalogProductIndex,
+ CatalogProductEdit $catalogProductEdit,
+ CatalogProductSimple $product,
+ CatalogProductAttribute $attribute
+ ) {
+ $catalogProductIndex->open()->getGridPageActionBlock()->addProduct('simple');
+ $productForm = $catalogProductEdit->getProductForm();
+ $productForm->fill($product);
+ $catalogProductEdit->getFormPageActions()->save();
+ $failedAttributes = $productForm->getRequireNoticeAttributes($product);
+ $actualMessage = $failedAttributes['product-details'][$attribute->getFrontendLabel()];
+
+ $fixtureData = $attribute->getData();
+ $defaultValue = preg_grep('/^default_value/', array_keys($fixtureData));
+
+ \PHPUnit_Framework_Assert::assertEquals(
+ self::UNIQUE_MESSAGE,
+ sprintf($actualMessage, $fixtureData[array_shift($defaultValue)]),
+ 'JS error notice on product edit page is not equal to expected.'
+ );
}
/**
+ * Return string representation of object.
+ *
* @return string
*/
public function toString()
{
- //
+ return 'Attribute is unique.';
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsUsedInSortOnFrontend.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsUsedInSortOnFrontend.php
new file mode 100644
index 0000000000000000000000000000000000000000..2d5c47642471433e9b2f20ce93b9563a9c79c1f3
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeIsUsedInSortOnFrontend.php
@@ -0,0 +1,80 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\Constraint;
+
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\CatalogSearch\Test\Page\CatalogsearchResult;
+use Magento\Cms\Test\Page\CmsIndex;
+use Mtf\Constraint\AbstractConstraint;
+use Mtf\Fixture\InjectableFixture;
+
+/**
+ * Assert that attribute present in sort dropdown on search results page on frontend.
+ */
+class AssertProductAttributeIsUsedInSortOnFrontend extends AbstractConstraint
+{
+ /**
+ * Constraint severeness
+ *
+ * @var string
+ */
+ protected $severeness = 'low';
+
+ /**
+ * Assert that attribute present in sort dropdown on search results page on frontend.
+ *
+ * @param CmsIndex $cmsIndex
+ * @param CatalogsearchResult $catalogsearchResult
+ * @param CatalogProductAttribute $attribute
+ * @param InjectableFixture $product
+ * @return void
+ */
+ public function processAssert(
+ CmsIndex $cmsIndex,
+ CatalogsearchResult $catalogsearchResult,
+ CatalogProductAttribute $attribute,
+ InjectableFixture $product
+ ) {
+ $cmsIndex->open()->getSearchBlock()->search($product->getName());
+ $label = $attribute->hasData('manage_frontend_label')
+ ? $attribute->getManageFrontendLabel()
+ : $attribute->getFrontendLabel();
+
+ \PHPUnit_Framework_Assert::assertTrue(
+ in_array($label, $catalogsearchResult->getListProductBlock()->getSortByValues()),
+ 'Attribute is absent in sort dropdown on search results page on frontend.'
+ );
+ }
+
+ /**
+ * Return string representation of object.
+ *
+ * @return string
+ */
+ public function toString()
+ {
+ return 'Attribute is present in sort dropdown on search results page on frontend.';
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductAttribute.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductAttribute.php
index d2c743eb773f9a3d5264c3b3209fc1018011f11c..f770d753652e57b6c35e9b7835dc3bb69b26a47d 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductAttribute.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductAttribute.php
@@ -176,15 +176,6 @@ class CatalogProductAttribute extends InjectableFixture
'input' => '',
];
- protected $default_value = [
- 'attribute_code' => 'default_value',
- 'backend_type' => 'text',
- 'is_required' => '',
- 'default_value' => '',
- 'input' => '',
- 'group' => 'advanced-properties',
- ];
-
protected $is_unique = [
'attribute_code' => 'is_unique',
'backend_type' => 'smallint',
@@ -373,9 +364,53 @@ class CatalogProductAttribute extends InjectableFixture
'default_value' => '',
'input' => '',
'source' => 'Magento\Catalog\Test\Fixture\CatalogProductAttribute\Options',
- 'group' => 'manage-options'
];
+ protected $default_value_text = [
+ 'attribute_code' => 'default_value_text',
+ 'backend_type' => 'text',
+ 'group' => 'advanced-properties',
+ ];
+
+ protected $default_value_textarea = [
+ 'attribute_code' => 'default_value_textarea',
+ 'backend_type' => 'text',
+ 'group' => 'advanced-properties',
+ ];
+
+ protected $default_value_date = [
+ 'attribute_code' => 'default_value_date',
+ 'backend_type' => 'text',
+ 'group' => 'advanced-properties',
+ 'source' => 'Magento\Backend\Test\Fixture\Date',
+ ];
+
+ protected $default_value_yesno = [
+ 'attribute_code' => 'default_value_yesno',
+ 'backend_type' => 'text',
+ 'group' => 'advanced-properties',
+ ];
+
+ public function getDefaultValueText()
+ {
+ return $this->getData('default_value_text');
+ }
+
+ public function getDefaultValueTextarea()
+ {
+ return $this->getData('default_value_textarea');
+ }
+
+ public function getDefaultValueDate()
+ {
+ return $this->getData('default_value_date');
+ }
+
+ public function getDefaultValueYesno()
+ {
+ return $this->getData('default_value_yesno');
+ }
+
public function getAttributeId()
{
return $this->getData('attribute_id');
@@ -451,11 +486,6 @@ class CatalogProductAttribute extends InjectableFixture
return $this->getData('is_user_defined');
}
- public function getDefaultValue()
- {
- return $this->getData('default_value');
- }
-
public function getIsUnique()
{
return $this->getData('is_unique');
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductAttribute.xml b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductAttribute.xml
index 03fe5c0d756f30ffdc6f6a4d819838850400dfb5..661cee1468f091c3a0f54ed48de0ea670f11eac0 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductAttribute.xml
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductAttribute.xml
@@ -133,13 +133,6 @@
<default_value>0</default_value>
<input></input>
</is_user_defined>
- <default_value>
- <attribute_code>default_value</attribute_code>
- <backend_type>text</backend_type>
- <is_required></is_required>
- <default_value></default_value>
- <input></input>
- </default_value>
<is_unique>
<attribute_code>is_unique</attribute_code>
<backend_type>smallint</backend_type>
@@ -294,8 +287,23 @@
<default_value></default_value>
<input></input>
<source>Magento\Catalog\Test\Fixture\CatalogProductAttribute\Options</source>
- <group>manage-options</group>
</options>
+ <default_value_text>
+ <attribute_code>default_value_text</attribute_code>
+ <backend_type>text</backend_type>
+ </default_value_text>
+ <default_value_textarea>
+ <attribute_code>default_value_textarea</attribute_code>
+ <backend_type>text</backend_type>
+ </default_value_textarea>
+ <default_value_date>
+ <attribute_code>default_value_date</attribute_code>
+ <backend_type>text</backend_type>
+ </default_value_date>
+ <default_value_yesno>
+ <attribute_code>default_value_yesno</attribute_code>
+ <backend_type>text</backend_type>
+ </default_value_yesno>
</fields>
<repository_class>Magento\Catalog\Test\Repository\CatalogProductAttribute</repository_class>
<handler_interface>Magento\Catalog\Test\Handler\CatalogProductAttribute\CatalogAttributeEntityInterface</handler_interface>
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple.php
index 65943abe37a7c0a764cf4fa34a368a7a47a1389c..b13c7ab3507ce89d5a4d58843a7448621dffd742 100755
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple.php
@@ -542,10 +542,11 @@ class CatalogProductSimple extends InjectableFixture
'source' => 'Magento\Catalog\Test\Fixture\CatalogProductSimple\AttributeSetId',
];
- protected $attributes = [
- 'attribute_code' => 'attributes',
+ protected $custom_attribute = [
+ 'attribute_code' => 'custom_attribute',
'backend_type' => 'virtual',
'group' => 'product-details',
+ 'source' => 'Magento\Catalog\Test\Fixture\CatalogProductSimple\CustomAttribute',
];
protected $custom_options = [
@@ -895,9 +896,9 @@ class CatalogProductSimple extends InjectableFixture
return $this->getData('attribute_set_id');
}
- public function getAttribute()
+ public function getCustomAttribute()
{
- return $this->getData('attributes');
+ return $this->getData('custom_attribute');
}
public function getCustomOptions()
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple.xml b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple.xml
index 058ae44ace2997a2ec98549d6b9a597974c662a2..8ec7dabe28cabab278c10c4dfc211873a151f683 100755
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple.xml
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple.xml
@@ -425,11 +425,12 @@
<source>Magento\Catalog\Test\Fixture\CatalogProductSimple\AttributeSetId</source>
<group>product-details</group>
</attribute_set_id>
- <attributes>
+ <custom_attribute>
<attribute_code>attributes</attribute_code>
<backend_type>virtual</backend_type>
<group>product-details</group>
- </attributes>
+ <source>Magento\Catalog\Test\Fixture\CatalogProductSimple\CustomAttribute</source>
+ </custom_attribute>
<custom_options>
<attribute_code>custom_options</attribute_code>
<backend_type>virtual</backend_type>
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple/CustomAttribute.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple/CustomAttribute.php
new file mode 100644
index 0000000000000000000000000000000000000000..793ca8bdc8c8563d3bf2dc1f4c58f3fa2d2f3655
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductSimple/CustomAttribute.php
@@ -0,0 +1,152 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\Fixture\CatalogProductSimple;
+
+use Mtf\Fixture\FixtureInterface;
+use Mtf\Fixture\FixtureFactory;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+
+/**
+ * Source for attribute field.
+ */
+class CustomAttribute implements FixtureInterface
+{
+ /**
+ * Attribute name.
+ *
+ * @var string
+ */
+ protected $data;
+
+ /**
+ * Attribute fixture.
+ *
+ * @var CatalogProductAttribute
+ */
+ protected $attribute;
+
+ /**
+ * Data set configuration settings.
+ *
+ * @var array
+ */
+ protected $params;
+
+ /**
+ * @constructor
+ * @param FixtureFactory $fixtureFactory
+ * @param array $params
+ * @param mixed $data
+ */
+ public function __construct(FixtureFactory $fixtureFactory, array $params, $data)
+ {
+ $this->params = $params;
+ if (is_array($data) && isset($data['dataSet'])) {
+ /** @var CatalogProductAttribute $data */
+ $data = $fixtureFactory->createByCode('catalogProductAttribute', ['dataSet' => $data['dataSet']]);
+ }
+ $this->data['value'] = $this->getDefaultAttributeValue($data);
+ $this->data['code'] = $data->hasData('attribute_code') == false
+ ? $this->createAttributeCode($data)
+ : $data->getAttributeCode();
+ $this->attribute = $data;
+ }
+
+ /**
+ * Get default value of custom attribute considering to it's type.
+ *
+ * @param CatalogProductAttribute $attribute
+ * @return string|null
+ */
+ protected function getDefaultAttributeValue(CatalogProductAttribute $attribute)
+ {
+ $data = $attribute->getData();
+ if (isset($data['options'])) {
+ foreach ($data['options'] as $option) {
+ if ($option['is_default'] == 'Yes') {
+ return $option['admin'];
+ }
+ }
+ } else {
+ $defaultValue = preg_grep('/^default_value/', array_keys($data));
+ return !empty($defaultValue) ? $data[array_shift($defaultValue)] : null;
+ }
+ }
+
+ /**
+ * Persist attribute options.
+ *
+ * @return void
+ */
+ public function persist()
+ {
+ //
+ }
+
+ /**
+ * Return prepared data set.
+ *
+ * @param string|null $key
+ * @return mixed
+ *
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+ */
+ public function getData($key = null)
+ {
+ return $this->data;
+ }
+
+ /**
+ * Return CatalogProductAttribute fixture.
+ *
+ * @return CatalogProductAttribute
+ */
+ public function getAttribute()
+ {
+ return $this->attribute;
+ }
+
+ /**
+ * Return data set configuration settings.
+ *
+ * @return array
+ */
+ public function getDataConfig()
+ {
+ return $this->params;
+ }
+
+ /**
+ * Get default attribute code according to attribute label.
+ *
+ * @param CatalogProductAttribute $attribute
+ * @return string
+ */
+ protected function createAttributeCode(CatalogProductAttribute $attribute)
+ {
+ $label = $attribute->getFrontendLabel();
+ return strtolower(preg_replace('@[\W\s]+@', '_', $label));
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductVirtual/CheckoutData.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductVirtual/CheckoutData.php
index 2f14aef068145c298214c77a84ff2e9a298e06f1..5fe12a4a65bb67623c4d859f5ea483297ba54e60 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductVirtual/CheckoutData.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/CatalogProductVirtual/CheckoutData.php
@@ -59,7 +59,10 @@ class CheckoutData extends \Magento\Catalog\Test\Fixture\CatalogProductSimple\Ch
'use_custom_price' => "Yes",
'custom_price' => 100,
],
- ]
+ ],
+ 'order_big_qty' => [
+ 'qty' => 900
+ ],
];
return isset($presets[$name]) ? $presets[$name] : null;
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Page/Product/CatalogProductView.xml b/dev/tests/functional/tests/app/Magento/Catalog/Test/Page/Product/CatalogProductView.xml
index 3c4c81657aed0fe39aba7e35c1ba8ba306ed3913..38827d10d51491526834c44572ad8c02ad21cf46 100755
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Page/Product/CatalogProductView.xml
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Page/Product/CatalogProductView.xml
@@ -30,6 +30,11 @@
<locator>#maincontent</locator>
<strategy>css selector</strategy>
</viewBlock>
+ <additionalInformationBlock>
+ <class>Magento\Catalog\Test\Block\Product\Additional</class>
+ <locator>#additional</locator>
+ <strategy>css selector</strategy>
+ </additionalInformationBlock>
<customOptionsBlock>
<class>Magento\Catalog\Test\Block\Product\View\CustomOptions</class>
<locator>#product-options-wrapper</locator>
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Repository/CatalogProductSimple.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/Repository/CatalogProductSimple.php
index e46a8edc14b20c7506b8fafefbade29cef0a4a94..7e962fc5c3525513d36ffa770734503bd38322ff 100755
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Repository/CatalogProductSimple.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/Repository/CatalogProductSimple.php
@@ -59,6 +59,22 @@ class CatalogProductSimple extends AbstractRepository
'checkout_data' => ['preset' => 'order_default'],
];
+ $this->_data['product_with_url_key'] = [
+ 'name' => 'Simple Product %isolation%',
+ 'sku' => 'sku_simple_product_%isolation%',
+ 'is_virtual' => 'No',
+ 'weight' => 1,
+ 'quantity_and_stock_status' => [
+ 'qty' => 25.0000,
+ 'is_in_stock' => 'In Stock',
+ ],
+ 'url_key' => 'simple-product-%isolation%',
+ 'price' => ['value' => 560.00, 'preset' => '-'],
+ 'website_ids' => ['Main Website'],
+ 'visibility' => 'Catalog, Search',
+ 'checkout_data' => ['preset' => 'order_default'],
+ ];
+
$this->_data['simple_big_qty'] = [
'attribute_set_id' => ['dataSet' => 'default'],
'name' => 'Simple Product %isolation%',
@@ -557,5 +573,20 @@ class CatalogProductSimple extends AbstractRepository
'website_ids' => ['Main Website'],
'category_ids' => ['presets' => 'default_subcategory'],
];
+
+ $this->_data['product_with_category_with_anchor'] = [
+ 'sku' => 'simple_product_with_category_%isolation%',
+ 'name' => 'Simple product with category %isolation%',
+ 'quantity_and_stock_status' => [
+ 'qty' => 666.0000,
+ 'is_in_stock' => 'In Stock',
+ ],
+ 'weight' => 1,
+ 'attribute_set_id' => ['dataSet' => 'default'],
+ 'price' => ['value' => 100, 'preset' => ''],
+ 'category_ids' => ['presets' => 'default_anchor_subcategory'],
+ 'website_ids' => ['Main Website'],
+ 'mtf_dataset_name' => 'simple_with_category',
+ ];
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateAttributeSetEntityTest.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateAttributeSetEntityTest.php
index 3c37d921b0990452a69ff477401170ac2153537d..c2df3839b9b26780b8c76bac3a5cb45387935201 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateAttributeSetEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateAttributeSetEntityTest.php
@@ -104,8 +104,7 @@ class CreateAttributeSetEntityTest extends Injectable
$this->productSetAdd->getAttributeSetForm()->fill($attributeSet);
$this->productSetAdd->getPageActions()->save();
- $this->productSetEdit->getAttributeSetEditBlock()
- ->moveAttribute($productAttribute->getData(), 'Product Details');
+ $this->productSetEdit->getAttributeSetEditBlock()->moveAttribute($productAttribute->getData());
$this->productSetEdit->getPageActions()->save();
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityFromProductPageTest.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityFromProductPageTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..5e35d1ae5dfe22382306130ba3a9f8df08245a1b
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityFromProductPageTest.php
@@ -0,0 +1,102 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestCase\ProductAttribute;
+
+use Magento\Catalog\Test\Fixture\CatalogProductSimple;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Mtf\Fixture\FixtureFactory;
+use Mtf\ObjectManager;
+use Mtf\TestCase\Scenario;
+
+/**
+ * Test Flow:
+ *
+ * Preconditions:
+ * 1. Create Product.
+ *
+ * Steps:
+ * 1. Log in to Backend.
+ * 2. Navigate to Products>Catalog.
+ * 3. Open product created in preconditions.
+ * 4. Click add new attribute.
+ * 5. Fill out fields data according to data set.
+ * 6. Save Product Attribute.
+ * 7. Fill attribute value.
+ * 8. Save product.
+ * 7. Perform appropriate assertions.
+ *
+ * @group Product_Attributes_(MX)
+ * @ZephyrId MAGETWO-30528
+ */
+class CreateProductAttributeEntityFromProductPageTest extends Scenario
+{
+ /**
+ * CatalogProductAttribute fixture.
+ *
+ * @var CatalogProductAttribute
+ */
+ protected $attribute;
+
+ /**
+ * Prepare data for test.
+ *
+ * @param FixtureFactory $fixtureFactory
+ * @return array
+ */
+ public function __prepare(FixtureFactory $fixtureFactory)
+ {
+ $product = $fixtureFactory->createByCode(
+ 'catalogProductSimple',
+ ['dataSet' => 'product_with_category_with_anchor']
+ );
+ $product->persist();
+ return ['product' => $product];
+ }
+
+ /**
+ * Run CreateProductAttributeEntity from product page test.
+ *
+ * @param CatalogProductAttribute $attribute
+ * @return void
+ */
+ public function test(CatalogProductAttribute $attribute)
+ {
+ $this->attribute = $attribute;
+ $this->executeScenario();
+ }
+
+ /**
+ * Delete attribute after test.
+ *
+ * @return void
+ */
+ public function tearDown()
+ {
+ ObjectManager::getInstance()->create(
+ 'Magento\Catalog\Test\TestStep\DeleteAttributeStep',
+ ['attribute' => $this->attribute]
+ )->run();
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityFromProductPageTest/test.csv b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityFromProductPageTest/test.csv
new file mode 100644
index 0000000000000000000000000000000000000000..fee0264704c24c815a0a289495093dc23a12eb03
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityFromProductPageTest/test.csv
@@ -0,0 +1,5 @@
+"attribute/data/frontend_label";"attribute/data/frontend_input";"attribute/data/options/preset";"attribute/data/is_required";"attribute/data/attribute_code";"attribute/data/is_global";"attribute/data/default_value_text";"attribute/data/default_value_textarea";"attribute/data/is_unique";"attribute/data/is_configurable";"attribute/data/manage_frontend_label";"attribute/data/is_searchable";"attribute/data/is_visible_in_advanced_search";"attribute/data/is_comparable";"attribute/data/is_filterable";"attribute/data/is_filterable_in_search";"attribute/data/is_used_for_promo_rules";"attribute/data/is_html_allowed_on_front";"attribute/data/is_visible_on_front";"attribute/data/used_in_product_listing";"attribute/data/used_for_sort_by";"constraint";"issue"
+"Text_Field_Admin_%isolation%";"Text Field";"-";"No";"attr_text_%isolation%";"Global";"<b><i>default_value_text%isolation%</i></b>";"-";"Yes";"-";"-";"Yes";"Yes";"Yes";"-";"-";"-";"Yes";"Yes";"-";"Yes";"assertProductAttributeInGrid, assertAttributeForm, assertAddedProductAttributeOnProductForm, assertProductAttributeDisplayingOnSearchForm, assertProductAttributeIsGlobal, assertProductAttributeDisplayingOnFrontend, assertProductAttributeDisplayingOnSearchForm, assertProductAttributeIsComparable, assertProductAttributeIsHtmlAllowed, assertProductAttributeIsUsedInSortOnFrontend";""
+"Dropdown_Admin_%isolation%";"Dropdown";"default";"No";"attr_dropdown_%isolation%";"Global";"-";"-";"-";"Yes";"-";"-";"-";"-";"Filterable (with results)";"Yes";"-";"-";"-";"-";"-";"assertProductAttributeIsFilterable, assertProductAttributeIsFilterableInSearch, assertProductAttributeIsConfigurable";""
+"Text_Field_Admin_%isolation%";"Text Field";"-";"Yes";"attr_text_%isolation%";"-";"default_value_text%isolation%";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertProductAttributeIsRequired";""
+"Text_Field_Admin_%isolation%";"Text Field";"-";"No";"attr_text_%isolation%";"-";"default_value_text%isolation%";"-";"Yes";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertProductAttributeIsUnique";"BUG: MAGETWO-30474"
\ No newline at end of file
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityTest.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityTest.php
index 5608bd54009a22a93272ce0df156dacfaf94cf6c..bf2ae05604f60ac6a185f96b119368436c95c3fd 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityTest.php
@@ -24,11 +24,11 @@
namespace Magento\Catalog\Test\TestCase\ProductAttribute;
-use Mtf\TestCase\Injectable;
+use Magento\Catalog\Test\Fixture\CatalogProductSimple;
use Magento\Catalog\Test\Fixture\CatalogAttributeSet;
use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
-use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeIndex;
-use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeNew;
+use Mtf\ObjectManager;
+use Mtf\TestCase\Scenario;
/**
* Test Creation for CreateProductAttributeEntity
@@ -44,31 +44,37 @@ use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeNew;
* @group Product_Attributes_(CS)
* @ZephyrId MAGETWO-24767
*/
-class CreateProductAttributeEntityTest extends Injectable
+class CreateProductAttributeEntityTest extends Scenario
{
/**
- * Run CreateProductAttributeEntity test
+ * CatalogProductAttribute object.
+ *
+ * @var CatalogProductAttribute
+ */
+ protected $attribute;
+
+ /**
+ * Run CreateProductAttributeEntity test.
*
* @param CatalogProductAttribute $productAttribute
- * @param CatalogProductAttributeIndex $attributeIndex
- * @param CatalogProductAttributeNew $attributeNew
- * @param CatalogAttributeSet $productTemplate
* @return array
*/
- public function testCreateProductAttribute(
- CatalogProductAttribute $productAttribute,
- CatalogProductAttributeIndex $attributeIndex,
- CatalogProductAttributeNew $attributeNew,
- CatalogAttributeSet $productTemplate
- ) {
- //Precondition
- $productTemplate->persist();
+ public function testCreateProductAttribute(CatalogProductAttribute $productAttribute)
+ {
+ $this->attribute = $productAttribute;
+ $this->executeScenario();
+ }
- //Steps
- $attributeIndex->open();
- $attributeIndex->getPageActionsBlock()->addNew();
- $attributeNew->getAttributeForm()->fill($productAttribute);
- $attributeNew->getPageActions()->save();
- return ['attribute' => $productAttribute];
+ /**
+ * Delete attribute after test.
+ *
+ * @return void
+ */
+ public function tearDown()
+ {
+ ObjectManager::getInstance()->create(
+ 'Magento\Catalog\Test\TestStep\DeleteAttributeStep',
+ ['attribute' => $this->attribute]
+ )->run();
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityTest/testCreateProductAttribute.csv b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityTest/testCreateProductAttribute.csv
index 6fea0abf52f2291b8e9ea1707623288044fc99a9..217e673ba44a8b30acc80c9d05deadcc40d5e15c 100755
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityTest/testCreateProductAttribute.csv
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/CreateProductAttributeEntityTest/testCreateProductAttribute.csv
@@ -1,9 +1,10 @@
-"productTemplate/dataSet";"productAttribute/data/frontend_label";"productAttribute/data/frontend_input";"productAttribute/data/options/preset";"productAttribute/data/is_required";"productAttribute/data/attribute_code";"productAttribute/data/is_global";"productAttribute/data/default_value_text";"productAttribute/data/is_unique";"productAttribute/data/is_configurable";"productAttribute/data/manage_frontend_label";"productAttribute/data/is_searchable";"productAttribute/data/is_visible_in_advanced_search";"productAttribute/data/is_comparable";"productAttribute/data/is_filterable";"productAttribute/data/is_filterable_in_search";"productAttribute/data/is_used_for_promo_rules";"productAttribute/data/is_html_allowed_on_front";"productAttribute/data/is_visible_on_front";"productAttribute/data/used_in_product_listing";"productAttribute/data/used_for_sort_by";"constraint"
-"custom_attribute_set";"Text_Field_Admin_%isolation%";"Text Field";"-";"No";"attr_textfield_%isolation%";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertProductAttributeSaveMessage, assertProductAttributeInGrid, assertAttributeOnAttributeForm, assertAddedProductAttributeOnProductForm"
-"custom_attribute_set";"Text_Field_Admin_%isolation%";"Text Area";"-";"Yes";"attr_textarea_%isolation%";"Store View";"default_value_text%isolation%";"No";"-";"Area_Field%isolation%";"Yes";"Yes";"Yes";"-";"-";"-";"-";"-";"-";"-";"assertProductAttributeSaveMessage, assertProductAttributeInGrid, assertAttributeOnAttributeForm, assertAddedProductAttributeOnProductForm, assertProductAttributeIsRequired, assertAttributeSearchableByLabel, assertProductAttributeIsUnique, assertProductAttributeDisplayingOnSearchForm, assertProductAttributeIsComparable"
-"custom_attribute_set";"Date_Admin_%isolation%";"Date";"-";"No";"attr_date_%isolation%";"-";"%currentDate%";"No";"-";"Date_Store_View";"No";"No";"No";"-";"-";"Yes";"-";"Yes";"Yes";"Yes";"assertProductAttributeSaveMessage, assertProductAttributeInGrid, assertAttributeOnAttributeForm, assertAddedProductAttributeOnProductForm, assertProductAttributeUsedSortOnFrontend, assertProductAttributeIsUsedPromoRules "
-"custom_attribute_set";"Yes/No_Admin_%isolation%";"Yes/No";"-";"Yes";"attr_yesno_%isolation%";"Global";"No";"-";"-";"Yes/No_Global";"-";"-";"-";"-";"-";"-";"No";"No";"No";"No";"assertProductAttributeSaveMessage, assertProductAttributeInGrid, assertAttributeOnAttributeForm, assertAddedProductAttributeOnProductForm"
-"custom_attribute_set";"Multiple_Select_Admin_%isolation%";"Multiple Select";"default";"Yes";"attr_multiselect_%isolation%";"Website";"-";"Yes";"-";"-";"Yes";"Yes";"Yes";"Filterable (with results)";"Yes";"-";"Yes";"Yes";"Yes";"-";"assertProductAttributeSaveMessage, assertProductAttributeInGrid, assertAttributeOnAttributeForm, assertAddedProductAttributeOnProductForm, assertProductAttributeIsRequired, assertProductAttributeIsUnique, assertProductAttributeDisplayingOnFrontend, assertProductAttributeDisplayingOnSearchForm, assertProductAttributeIsComparable, assertProductAttributeIsHtmlAllowed, assertProductAttributeIsFilterable, assertProductAttributeIsFilterableInSearch, assertAttributeSearchableByLabel, assertAttributeOptionsOnProductForm"
-"custom_attribute_set";"Dropdown_Admin_%isolation%";"Dropdown";"default";"Yes";"attr_dropdown_%isolation%";"Global";"-";"No";"Yes";"-";"Yes";"Yes";"Yes";"Filterable (with results)";"Yes";"-";"Yes";"Yes";"Yes";"Yes";"assertProductAttributeSaveMessage, assertProductAttributeInGrid, assertAttributeOnAttributeForm, assertAddedProductAttributeOnProductForm, assertProductAttributeIsRequired, assertProductAttributeIsGlobal, assertProductAttributeDisplayingOnFrontend, assertProductAttributeDisplayingOnSearchForm, assertAttributeSearchableByLabel, assertProductAttributeIsComparable, assertProductAttributeIsHtmlAllowed, assertProductAttributeUsedSortOnFrontend, assertProductAttributeIsFilterable, assertProductAttributeIsConfigurable, assertProductAttributeIsFilterableInSearch, assertAttributeOptionsOnProductForm"
-"custom_attribute_set";"Price_Admin_%isolation%";"Price";"-";"No";"attr_price_%isolation%";"-";"-";"No";"-";"Price_StoreView";"Yes";"Yes";"No";"Filterable (with results)";"Yes";"-";"-";"-";"-";"-";"assertProductAttributeSaveMessage, assertProductAttributeInGrid, assertAttributeOnAttributeForm, assertAddedProductAttributeOnProductForm, assertAttributeSearchableByLabel, assertProductAttributeDisplayingOnSearchForm, assertProductAttributeIsFilterable, assertProductAttributeIsFilterableInSearch"
-"custom_attribute_set";"Fixed_Product_Tax_Admin_%isolation%";"Fixed Product Tax";"-";"No";"attr_fpt_code_%isolation%";"-";"-";"-";"-";"Fixed_Product_Tax_Storeview";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertProductAttributeSaveMessage, assertProductAttributeInGrid, assertAttributeOnAttributeForm, assertAddedProductAttributeOnProductForm"
+"productTemplate/dataSet";"productAttribute/data/frontend_label";"productAttribute/data/frontend_input";"productAttribute/data/options/preset";"productAttribute/data/is_required";"productAttribute/data/attribute_code";"productAttribute/data/is_global";"productAttribute/data/default_value_text";"productAttribute/data/default_value_textarea";"productAttribute/data/default_value_date/pattern";"productAttribute/data/default_value_yesno";"productAttribute/data/is_unique";"productAttribute/data/is_configurable";"productAttribute/data/manage_frontend_label";"productAttribute/data/is_searchable";"productAttribute/data/is_visible_in_advanced_search";"productAttribute/data/is_comparable";"productAttribute/data/is_filterable";"productAttribute/data/is_filterable_in_search";"productAttribute/data/is_used_for_promo_rules";"productAttribute/data/is_html_allowed_on_front";"productAttribute/data/is_visible_on_front";"productAttribute/data/used_in_product_listing";"productAttribute/data/used_for_sort_by";"constraint";"issue"
+"custom_attribute_set";"Text_Field_Admin_%isolation%";"Text Field";"-";"No";"attr_textfield_%isolation%";"-";"default_value_text%isolation%";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertProductAttributeInGrid, assertAttributeForm, assertAddedProductAttributeOnProductForm";""
+"custom_attribute_set";"Text_Field_Admin_%isolation%";"Text Area";"-";"Yes";"attr_textarea_%isolation%";"Store View";"-";"default_value_textarea%isolation%";"-";"-";"No";"-";"Area_Field%isolation%";"Yes";"Yes";"Yes";"-";"-";"-";"-";"-";"-";"-";"assertProductAttributeInGrid, assertAttributeForm, assertAddedProductAttributeOnProductForm, assertProductAttributeIsRequired, assertAttributeSearchableByLabel, assertProductAttributeDisplayingOnSearchForm, assertProductAttributeIsComparable";""
+"custom_attribute_set";"Date_Admin_%isolation%";"Date";"-";"No";"attr_date_%isolation%";"-";"-";"-";"n/j/y";"-";"No";"-";"Date_Store_View";"No";"No";"No";"-";"-";"-";"-";"Yes";"Yes";"Yes";"assertProductAttributeInGrid, assertAttributeForm, assertAddedProductAttributeOnProductForm, assertProductAttributeIsUsedInSortOnFrontend, assertProductAttributeIsUsedPromoRules";""
+"custom_attribute_set";"Yes/No_Admin_%isolation%";"Yes/No";"-";"Yes";"attr_yesno_%isolation%";"Global";"-";"-";"-";"No";"-";"-";"Yes/No_Global";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertProductAttributeInGrid, assertAttributeForm, assertAddedProductAttributeOnProductForm";""
+"custom_attribute_set";"Multiple_Select_Admin_%isolation%";"Multiple Select";"default";"No";"attr_multiselect_%isolation%";"Website";"-";"-";"-";"-";"Yes";"-";"-";"Yes";"Yes";"Yes";"Filterable (with results)";"Yes";"-";"Yes";"Yes";"Yes";"-";"assertProductAttributeInGrid, assertAttributeForm, assertAddedProductAttributeOnProductForm, assertProductAttributeDisplayingOnFrontend, assertProductAttributeDisplayingOnSearchForm, assertProductAttributeIsComparable, assertProductAttributeIsFilterable, assertProductAttributeIsFilterableInSearch, assertAttributeSearchableByLabel, assertAttributeOptionsOnProductForm";""
+"custom_attribute_set";"Dropdown_Admin_%isolation%";"Dropdown";"default";"Yes";"attr_dropdown_%isolation%";"Global";"-";"-";"-";"-";"No";"Yes";"-";"Yes";"Yes";"Yes";"Filterable (with results)";"Yes";"-";"Yes";"Yes";"Yes";"Yes";"assertProductAttributeInGrid, assertAttributeForm, assertAddedProductAttributeOnProductForm, assertProductAttributeIsRequired, assertProductAttributeIsGlobal, assertProductAttributeDisplayingOnFrontend, assertProductAttributeDisplayingOnSearchForm, assertAttributeSearchableByLabel, assertProductAttributeIsComparable, assertProductAttributeIsUsedInSortOnFrontend, assertProductAttributeIsFilterable, assertProductAttributeIsConfigurable, assertProductAttributeIsFilterableInSearch, assertAttributeOptionsOnProductForm";""
+"custom_attribute_set";"Price_Admin_%isolation%";"Price";"-";"No";"attr_price_%isolation%";"-";"1000";"-";"-";"-";"No";"-";"Price_StoreView";"Yes";"Yes";"No";"Filterable (with results)";"Yes";"-";"-";"-";"-";"-";"assertProductAttributeInGrid, assertAttributeForm, assertAddedProductAttributeOnProductForm, assertAttributeSearchableByLabel, assertProductAttributeDisplayingOnSearchForm, assertProductAttributeIsFilterable, assertProductAttributeIsFilterableInSearch";""
+"custom_attribute_set";"Fixed_Product_Tax_Admin_%isolation%";"Fixed Product Tax";"-";"-";"attr_fpt_code_%isolation%";"-";"-";"-";"-";"-";"-";"-";"Fixed_Product_Tax_Storeview";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertProductAttributeInGrid, assertAttributeForm, assertAddedProductAttributeOnProductForm";""
+"custom_attribute_set";"Text_Field_Admin_%isolation%";"Text Field";"-";"Yes";"attr_textfield_%isolation%";"Store View";"default_value_text%isolation%";"-";"-";"-";"Yes";"-";"Area_Field%isolation%";"Yes";"Yes";"Yes";"-";"-";"-";"-";"-";"-";"-";"assertProductAttributeIsUnique";"Bug: MAGETWO-30474"
\ No newline at end of file
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/UpdateProductAttributeEntityTest.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/UpdateProductAttributeEntityTest.php
index 5b449eaf42e9aef8a4b0e3812d59ae93890e7b9f..94217624e7e0b9f50e889c1dd5caae1b03b8a4da 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/UpdateProductAttributeEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/UpdateProductAttributeEntityTest.php
@@ -56,7 +56,7 @@ class UpdateProductAttributeEntityTest extends Injectable
* Run UpdateProductAttributeEntity test
*
* @param CatalogProductAttribute $productAttributeOriginal
- * @param CatalogProductAttribute $productAttribute
+ * @param CatalogProductAttribute $attribute
* @param CatalogAttributeSet $productTemplate
* @param CatalogProductAttributeIndex $attributeIndex
* @param CatalogProductAttributeNew $attributeNew
@@ -64,7 +64,7 @@ class UpdateProductAttributeEntityTest extends Injectable
*/
public function testUpdateProductAttribute(
CatalogProductAttribute $productAttributeOriginal,
- CatalogProductAttribute $productAttribute,
+ CatalogProductAttribute $attribute,
CatalogAttributeSet $productTemplate,
CatalogProductAttributeIndex $attributeIndex,
CatalogProductAttributeNew $attributeNew
@@ -80,7 +80,7 @@ class UpdateProductAttributeEntityTest extends Injectable
//Steps
$attributeIndex->open();
$attributeIndex->getGrid()->searchAndOpen($filter);
- $attributeNew->getAttributeForm()->fill($productAttribute);
+ $attributeNew->getAttributeForm()->fill($attribute);
$attributeNew->getPageActions()->save();
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/UpdateProductAttributeEntityTest/testUpdateProductAttribute.csv b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/UpdateProductAttributeEntityTest/testUpdateProductAttribute.csv
index b156600a3a133f47ec6cf8fa0ea59f71e7766600..0dfd6d9d1595e2cb5ef44eeed517d1aad49654c7 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/UpdateProductAttributeEntityTest/testUpdateProductAttribute.csv
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/ProductAttribute/UpdateProductAttributeEntityTest/testUpdateProductAttribute.csv
@@ -1,3 +1,3 @@
-"productTemplate/dataSet";"productAttributeOriginal/dataSet";"productAttribute/data/frontend_label";"productAttribute/data/frontend_input";"productAttribute/data/options/preset";"productAttribute/data/is_required";"productAttribute/data/attribute_code";"productAttribute/data/is_global";"productAttribute/data/default_value_text";"productAttribute/data/is_unique";"productAttribute/data/is_configurable";"productAttribute/data/manage_frontend_label";"productAttribute/data/is_searchable";"productAttribute/data/is_visible_in_advanced_search";"productAttribute/data/is_comparable";"productAttribute/data/is_filterable";"productAttribute/data/is_filterable_in_search";"productAttribute/data/is_used_for_promo_rules";"productAttribute/data/is_html_allowed_on_front";"productAttribute/data/is_visible_on_front";"productAttribute/data/used_in_product_listing";"productAttribute/data/used_for_sort_by";"isRequired";"constraint"
+"productTemplate/dataSet";"productAttributeOriginal/dataSet";"attribute/data/frontend_label";"attribute/data/frontend_input";"attribute/data/options/preset";"attribute/data/is_required";"attribute/data/attribute_code";"attribute/data/is_global";"attribute/data/default_value_text";"attribute/data/is_unique";attribute/data/is_configurable";"attribute/data/manage_frontend_label";"attribute/data/is_searchable";"attribute/data/is_visible_in_advanced_search";"attribute/data/is_comparable";"attribute/data/is_filterable";"attribute/data/is_filterable_in_search";"attribute/data/is_used_for_promo_rules";"attribute/data/is_html_allowed_on_front";"attribute/data/is_visible_on_front";"attribute/data/used_in_product_listing";"attribute/data/used_for_sort_by";"isRequired";"constraint"
"custom_attribute_set";"attribute_type_text_field";"Text_Field_%isolation%";"-";"-";"Yes";"-";"Global";"attribute_edited%isolation%";"Yes";"-";"-";"Yes";"Yes";"Yes";"-";"-";"Yes";"Yes";"Yes";"Yes";"Yes";"Yes";"assertProductAttributeSaveMessage, assertAddedProductAttributeOnProductForm"
"custom_attribute_set";"attribute_type_dropdown";"Dropdown_%isolation%";"-";"default";"Yes";"-";"Global";"-";"Yes";"Yes";"-";"Yes";"Yes";"Yes";"Filterable (with results)";"Yes";"No";"Yes";"Yes";"Yes";"Yes";"Yes";"assertProductAttributeSaveMessage, assertAddedProductAttributeOnProductForm"
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/AddNewAttributeFromProductPageStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/AddNewAttributeFromProductPageStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..d58bfe792168478ce4dadd34265839d160bebc1e
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/AddNewAttributeFromProductPageStep.php
@@ -0,0 +1,71 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductEdit;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Add custom attribute to product from product page.
+ */
+class AddNewAttributeFromProductPageStep implements TestStepInterface
+{
+ /**
+ * Catalog product index page.
+ *
+ * @var CatalogProductEdit
+ */
+ protected $catalogProductEdit;
+
+ /**
+ * Tab name for adding attribute.
+ *
+ * @var string
+ */
+ protected $tabName;
+
+ /**
+ * @constructor
+ * @param CatalogProductEdit $catalogProductEdit
+ * @param string $tabName
+ */
+ public function __construct(CatalogProductEdit $catalogProductEdit, $tabName)
+ {
+ $this->catalogProductEdit = $catalogProductEdit;
+ $this->tabName = $tabName;
+ }
+
+ /**
+ * Add custom attribute to product.
+ *
+ * @return void
+ */
+ public function run()
+ {
+ $productForm = $this->catalogProductEdit->getProductForm();
+ /** @var \Magento\Catalog\Test\Block\Adminhtml\Product\Edit\ProductTab $productDetailsTab */
+ $productForm->addNewAttribute($this->tabName);
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/AddNewAttributeStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/AddNewAttributeStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..2f82f7bf6fe9b6c8a471b529a436ade85eb77f7e
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/AddNewAttributeStep.php
@@ -0,0 +1,60 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeIndex;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Add New Attribute from Attribute index page.
+ */
+class AddNewAttributeStep implements TestStepInterface
+{
+ /**
+ * Catalog Product Attribute Index page.
+ *
+ * @var CatalogProductAttributeIndex
+ */
+ protected $catalogProductAttributeIndex;
+
+ /**
+ * @constructor
+ * @param CatalogProductAttributeIndex $catalogProductAttributeIndex
+ */
+ public function __construct(CatalogProductAttributeIndex $catalogProductAttributeIndex)
+ {
+ $this->catalogProductAttributeIndex = $catalogProductAttributeIndex;
+ }
+
+ /**
+ * Add New Attribute from Attribute index page step.
+ *
+ * @return void
+ */
+ public function run()
+ {
+ $this->catalogProductAttributeIndex->getPageActionsBlock()->addNew();
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/CreateProductTemplateStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/CreateProductTemplateStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..cfea849e271bed56dd93905aafbb7d479bcb8b36
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/CreateProductTemplateStep.php
@@ -0,0 +1,64 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Fixture\CatalogAttributeSet;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Create product attribute template using handler.
+ */
+class CreateProductTemplateStep implements TestStepInterface
+{
+ /**
+ * CatalogAttributeSet fixture.
+ *
+ * @var string
+ */
+ protected $productTemplate;
+
+ /**
+ * Preparing step properties.
+ *
+ * @constructor
+ * @param CatalogAttributeSet $productTemplate
+ */
+ public function __construct(CatalogAttributeSet $productTemplate)
+ {
+ $this->productTemplate = $productTemplate;
+ }
+
+ /**
+ * Create product attribute template.
+ *
+ * @return array
+ */
+ public function run()
+ {
+ $this->productTemplate->persist();
+
+ return ['productTemplate' => $this->productTemplate];
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/DeleteAttributeStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/DeleteAttributeStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..682399a1d5e69070b35228ad5090593fa595da32
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/DeleteAttributeStep.php
@@ -0,0 +1,87 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeIndex;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeNew;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Delete product attribute.
+ */
+class DeleteAttributeStep implements TestStepInterface
+{
+ /**
+ * Catalog Product Attribute Index page.
+ *
+ * @var CatalogProductAttributeIndex
+ */
+ protected $catalogProductAttributeIndex;
+
+ /**
+ * Catalog Product Attribute New page.
+ *
+ * @var CatalogProductAttributeNew
+ */
+ protected $catalogProductAttributeNew;
+
+ /**
+ * CatalogProductAttribute fixture.
+ *
+ * @var CatalogProductAttribute
+ */
+ protected $attribute;
+
+ /**
+ * @constructor
+ * @param CatalogProductAttributeIndex $catalogProductAttributeIndex
+ * @param CatalogProductAttributeNew $catalogProductAttributeNew
+ * @param CatalogProductAttribute $attribute
+ */
+ public function __construct(
+ CatalogProductAttributeIndex $catalogProductAttributeIndex,
+ CatalogProductAttributeNew $catalogProductAttributeNew,
+ CatalogProductAttribute $attribute
+ ) {
+ $this->catalogProductAttributeIndex = $catalogProductAttributeIndex;
+ $this->catalogProductAttributeNew = $catalogProductAttributeNew;
+ $this->attribute = $attribute;
+ }
+
+ /**
+ * Delete product attribute step.
+ *
+ * @return void
+ */
+ public function run()
+ {
+ $filter = ['attribute_code' => $this->attribute->getAttributeCode()];
+ if ($this->catalogProductAttributeIndex->open()->getGrid()->isRowVisible($filter)) {
+ $this->catalogProductAttributeIndex->getGrid()->searchAndOpen($filter);
+ $this->catalogProductAttributeNew->getPageActions()->delete();
+ }
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/FillAttributeFormOnProductPageStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/FillAttributeFormOnProductPageStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..b0cbdd678e2e45bf66d519c11a52dabf503fd59f
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/FillAttributeFormOnProductPageStep.php
@@ -0,0 +1,71 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductEdit;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Fill custom attribute form on product page.
+ */
+class FillAttributeFormOnProductPageStep implements TestStepInterface
+{
+ /**
+ * CatalogProductAttribute fixture.
+ *
+ * @var CatalogProductAttribute
+ */
+ protected $attribute;
+
+ /**
+ * Catalog product edit page.
+ *
+ * @var CatalogProductEdit
+ */
+ protected $catalogProductEdit;
+
+ /**
+ * @constructor
+ * @param CatalogProductAttribute $attribute
+ * @param CatalogProductEdit $catalogProductEdit
+ */
+ public function __construct(CatalogProductAttribute $attribute, CatalogProductEdit $catalogProductEdit)
+ {
+ $this->attribute = $attribute;
+ $this->catalogProductEdit = $catalogProductEdit;
+ }
+
+ /**
+ * Fill custom attribute form on product page.
+ *
+ * @return array
+ */
+ public function run()
+ {
+ $this->catalogProductEdit->getProductForm()->fillAttributeForm($this->attribute);
+ return ['attribute' => $this->attribute];
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/FillAttributeFormStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/FillAttributeFormStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..e920856a74192fa50b8c9248ed19a2e43c5060ac
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/FillAttributeFormStep.php
@@ -0,0 +1,71 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeNew;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Fill attribute form on attribute page.
+ */
+class FillAttributeFormStep implements TestStepInterface
+{
+ /**
+ * CatalogProductAttribute fixture.
+ *
+ * @var CatalogProductAttribute
+ */
+ protected $attribute;
+
+ /**
+ * Catalog product attribute edit page.
+ *
+ * @var CatalogProductAttributeNew
+ */
+ protected $attributeNew;
+
+ /**
+ * @constructor
+ * @param CatalogProductAttribute $productAttribute
+ * @param CatalogProductAttributeNew $attributeNew
+ */
+ public function __construct(CatalogProductAttribute $productAttribute, CatalogProductAttributeNew $attributeNew)
+ {
+ $this->attribute = $productAttribute;
+ $this->attributeNew = $attributeNew;
+ }
+
+ /**
+ * Fill custom attribute form on attribute page.
+ *
+ * @return array
+ */
+ public function run()
+ {
+ $this->attributeNew->getAttributeForm()->fill($this->attribute);
+ return ['attribute' => $this->attribute];
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/MoveAttributeToProductTemplateStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/MoveAttributeToProductTemplateStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..57254b87664215cf2c74ff17745db58c7fa1e3a0
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/MoveAttributeToProductTemplateStep.php
@@ -0,0 +1,115 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Fixture\CatalogAttributeSet;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductSetEdit;
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductSetIndex;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Mtf\Fixture\FixtureFactory;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Move attribute To attribute set.
+ */
+class MoveAttributeToProductTemplateStep implements TestStepInterface
+{
+ /**
+ * Catalog ProductSet Index page.
+ *
+ * @var CatalogProductSetIndex
+ */
+ protected $catalogProductSetIndex;
+
+ /**
+ * Catalog ProductSet Edit page.
+ *
+ * @var CatalogProductSetEdit
+ */
+ protected $catalogProductSetEdit;
+
+ /**
+ * Catalog Product Attribute fixture.
+ *
+ * @var CatalogProductAttribute
+ */
+ protected $attribute;
+
+ /**
+ * Catalog AttributeSet fixture.
+ *
+ * @var CatalogAttributeSet
+ */
+ protected $productTemplate;
+
+ /**
+ * @constructor
+ * @param CatalogProductSetIndex $catalogProductSetIndex
+ * @param CatalogProductSetEdit $catalogProductSetEdit
+ * @param CatalogProductAttribute $attribute
+ * @param CatalogAttributeSet $productTemplate
+ * @param FixtureFactory $fixtureFactory
+ */
+ public function __construct(
+ CatalogProductSetIndex $catalogProductSetIndex,
+ CatalogProductSetEdit $catalogProductSetEdit,
+ CatalogProductAttribute $attribute,
+ CatalogAttributeSet $productTemplate,
+ FixtureFactory $fixtureFactory
+ ) {
+ $this->catalogProductSetIndex = $catalogProductSetIndex;
+ $this->catalogProductSetEdit = $catalogProductSetEdit;
+ $this->attribute = $attribute;
+ $this->productTemplate = $productTemplate;
+ $this->fixtureFactory = $fixtureFactory;
+ }
+
+ /**
+ * Move attribute To attribute set.
+ *
+ * @return array
+ */
+ public function run()
+ {
+ $filterAttribute = ['set_name' => $this->productTemplate->getAttributeSetName()];
+ $this->catalogProductSetIndex->open()->getGrid()->searchAndOpen($filterAttribute);
+ $this->catalogProductSetEdit->getAttributeSetEditBlock()->moveAttribute($this->attribute->getData());
+
+ // Create product with attribute set mentioned above:
+ $product = $this->fixtureFactory->createByCode(
+ 'catalogProductSimple',
+ [
+ 'dataSet' => 'product_with_category_with_anchor',
+ 'data' => [
+ 'attribute_set_id' => ['attribute_set' => $this->productTemplate],
+ 'custom_attribute' => $this->attribute
+ ],
+ ]
+ );
+ $product->persist();
+
+ return ['product' => $product];
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/OpenProductAttributesPageStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/OpenProductAttributesPageStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..317912a109dc888103a266dc6410b5e84d026c09
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/OpenProductAttributesPageStep.php
@@ -0,0 +1,60 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeIndex;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Open Product Attribute Index Page.
+ */
+class OpenProductAttributesPageStep implements TestStepInterface
+{
+ /**
+ * Catalog Product Attribute Index page.
+ *
+ * @var CatalogProductAttributeIndex
+ */
+ protected $catalogProductAttributeIndex;
+
+ /**
+ * @constructor
+ * @param CatalogProductAttributeIndex $catalogProductAttributeIndex
+ */
+ public function __construct(CatalogProductAttributeIndex $catalogProductAttributeIndex)
+ {
+ $this->catalogProductAttributeIndex = $catalogProductAttributeIndex;
+ }
+
+ /**
+ * Open Catalog Product Attribute Index.
+ *
+ * @return void
+ */
+ public function run()
+ {
+ $this->catalogProductAttributeIndex->open();
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/Data/LowStockCriteria.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SaveAttributeOnProductPageStep.php
similarity index 57%
rename from app/code/Magento/CatalogInventory/Service/V1/Data/LowStockCriteria.php
rename to dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SaveAttributeOnProductPageStep.php
index 83852ba605c2c06c2938b3d553490845f5500ac0..976444e6b2dd9bafc7017baa99d5721a062e506d 100644
--- a/app/code/Magento/CatalogInventory/Service/V1/Data/LowStockCriteria.php
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SaveAttributeOnProductPageStep.php
@@ -21,50 +21,40 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\CatalogInventory\Service\V1\Data;
-use Magento\Framework\Api\AbstractExtensibleObject;
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductEdit;
+use Mtf\TestStep\TestStepInterface;
/**
- * Low stock criteria data object
- *
- * @codeCoverageIgnore
+ * Click "Save" button on attribute form on product page.
*/
-class LowStockCriteria extends AbstractExtensibleObject
+class SaveAttributeOnProductPageStep implements TestStepInterface
{
- /**#@+
- * Stock status object data keys
- */
- const QTY = 'qty';
- const PAGE_SIZE = 'page_size';
- const CURRENT_PAGE = 'current_page';
- /**#@-*/
-
/**
- * @return float
+ * Catalog product edit page.
+ *
+ * @var CatalogProductEdit
*/
- public function getQty()
- {
- return $this->_get(self::QTY);
- }
+ protected $catalogProductEdit;
/**
- * Get page size
- *
- * @return int|null
+ * @constructor
+ * @param CatalogProductEdit $catalogProductEdit
*/
- public function getPageSize()
+ public function __construct(CatalogProductEdit $catalogProductEdit)
{
- return $this->_get(self::PAGE_SIZE);
+ $this->catalogProductEdit = $catalogProductEdit;
}
/**
- * Get current page
+ * Click "Save" button on attribute form on product page.
*
- * @return int|null
+ * @return array
*/
- public function getCurrentPage()
+ public function run()
{
- return $this->_get(self::CURRENT_PAGE);
+ $this->catalogProductEdit->getProductForm()->saveAttributeForm();
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SaveAttributeStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SaveAttributeStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..3498dad0359e46fb21b02868c37dd6572d396aad
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SaveAttributeStep.php
@@ -0,0 +1,60 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductAttributeNew;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Save attribute on attribute page.
+ */
+class SaveAttributeStep implements TestStepInterface
+{
+ /**
+ * Catalog product attribute edit page.
+ *
+ * @var CatalogProductAttributeNew
+ */
+ protected $attributeNew;
+
+ /**
+ * @constructor
+ * @param CatalogProductAttributeNew $attributeNew
+ */
+ public function __construct(CatalogProductAttributeNew $attributeNew)
+ {
+ $this->attributeNew = $attributeNew;
+ }
+
+ /**
+ * Click "Save" button on attribute edit page.
+ *
+ * @return void
+ */
+ public function run()
+ {
+ $this->attributeNew->getPageActions()->save();
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SaveProductTemplateStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SaveProductTemplateStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..c60463ddbd267052b5a775c1e32cf5e8ff95e5ac
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SaveProductTemplateStep.php
@@ -0,0 +1,60 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductSetEdit;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Save attributeSet on attribute set page.
+ */
+class SaveProductTemplateStep implements TestStepInterface
+{
+ /**
+ * Catalog ProductSet Edit page.
+ *
+ * @var CatalogProductSetEdit
+ */
+ protected $catalogProductSetEdit;
+
+ /**
+ * @constructor
+ * @param CatalogProductSetEdit $catalogProductSetEdit
+ */
+ public function __construct(CatalogProductSetEdit $catalogProductSetEdit)
+ {
+ $this->catalogProductSetEdit = $catalogProductSetEdit;
+ }
+
+ /**
+ * Save attributeSet on attribute set page.
+ *
+ * @return void
+ */
+ public function run()
+ {
+ $this->catalogProductSetEdit->getPageActions()->save();
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SetDefaultAttributeValueStep.php b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SetDefaultAttributeValueStep.php
new file mode 100644
index 0000000000000000000000000000000000000000..6cbc2ea458389405d370555d12bfcb9dbcc465b9
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/TestStep/SetDefaultAttributeValueStep.php
@@ -0,0 +1,87 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Catalog\Test\TestStep;
+
+use Magento\Catalog\Test\Page\Adminhtml\CatalogProductEdit;
+use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Mtf\Fixture\FixtureFactory;
+use Mtf\TestStep\TestStepInterface;
+
+/**
+ * Set default attribute value.
+ */
+class SetDefaultAttributeValueStep implements TestStepInterface
+{
+ /**
+ * CatalogProductAttribute fixture.
+ *
+ * @var CatalogProductAttribute
+ */
+ protected $attribute;
+
+ /**
+ * FixtureFactory object.
+ *
+ * @var FixtureFactory
+ */
+ protected $fixtureFactory;
+
+ /**
+ * Catalog product index page.
+ *
+ * @var CatalogProductEdit
+ */
+ protected $catalogProductEdit;
+
+ /**
+ * @constructor
+ * @param CatalogProductAttribute $attribute
+ * @param CatalogProductEdit $catalogProductEdit
+ * @param FixtureFactory $fixtureFactory
+ */
+ public function __construct(
+ CatalogProductAttribute $attribute,
+ CatalogProductEdit $catalogProductEdit,
+ FixtureFactory $fixtureFactory
+ ) {
+ $this->attribute = $attribute;
+ $this->catalogProductEdit = $catalogProductEdit;
+ $this->fixtureFactory = $fixtureFactory;
+ }
+
+ /**
+ * Set Default Attribute Value.
+ *
+ * @return void
+ */
+ public function run()
+ {
+ $product = $this->fixtureFactory->createByCode(
+ 'catalogProductSimple',
+ ['data' => ['custom_attribute' => $this->attribute]]
+ );
+ $this->catalogProductEdit->getProductForm()->fill($product);
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/etc/constraint.xml b/dev/tests/functional/tests/app/Magento/Catalog/Test/etc/constraint.xml
index 38aee68e4eb912209350934dfdee921909c4701d..4967606a65e73f1406fe0edd0f766b21a8c4ce4f 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/etc/constraint.xml
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/etc/constraint.xml
@@ -176,9 +176,9 @@
<assertProductAttributeInGrid module="Magento_Catalog">
<severeness>low</severeness>
</assertProductAttributeInGrid>
- <assertAttributeOnAttributeForm module="Magento_Catalog">
+ <assertAttributeForm module="Magento_Catalog">
<severeness>low</severeness>
- </assertAttributeOnAttributeForm>
+ </assertAttributeForm>
<assertAddedProductAttributeOnProductForm module="Magento_Catalog">
<severeness>low</severeness>
<require>
@@ -225,9 +225,9 @@
<assertProductAttributeIsUsedPromoRules module="Magento_Catalog">
<severeness>low</severeness>
</assertProductAttributeIsUsedPromoRules>
- <assertProductAttributeUsedSortOnFrontend module="Magento_Catalog">
+ <assertProductAttributeIsUsedInSortOnFrontend module="Magento_Catalog">
<severeness>low</severeness>
- </assertProductAttributeUsedSortOnFrontend>
+ </assertProductAttributeIsUsedInSortOnFrontend>
<assertProductAttributeIsGlobal module="Magento_Catalog">
<severeness>low</severeness>
</assertProductAttributeIsGlobal>
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/etc/scenario.xml b/dev/tests/functional/tests/app/Magento/Catalog/Test/etc/scenario.xml
new file mode 100644
index 0000000000000000000000000000000000000000..36227bb2cc1eff7a3d5728eee5b357dd4c279313
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Catalog/Test/etc/scenario.xml
@@ -0,0 +1,83 @@
+<?xml version="1.0"?>
+<!--
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Academic Free License (AFL 3.0)
+ * that is bundled with this package in the file LICENSE_AFL.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/afl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0)
+ */
+-->
+<scenarios xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/Mtf/Config/etc/scenario.xsd">
+ <scenario name="CreateProductAttributeEntityFromProductPageTest" module="Magento_Catalog">
+ <methods>
+ <method name="test">
+ <steps>
+ <first>openProductOnBackend</first>
+ <step name="openProductOnBackend" module="Magento_Catalog">
+ <next>addNewAttributeFromProductPage</next>
+ </step>
+ <step name="addNewAttributeFromProductPage" module="Magento_Catalog">
+ <arguments>
+ <item name="tabName">product-details</item>
+ </arguments>
+ <next>fillAttributeFormOnProductPage</next>
+ </step>
+ <step name="fillAttributeFormOnProductPage" module="Magento_Catalog">
+ <next>saveAttributeOnProductPage</next>
+ </step>
+ <step name="saveAttributeOnProductPage" module="Magento_Catalog">
+ <next>setDefaultAttributeValue</next>
+ </step>
+ <step name="setDefaultAttributeValue" module="Magento_Catalog">
+ <next>saveProduct</next>
+ </step>
+ <step name="saveProduct" module="Magento_Catalog" />
+ </steps>
+ </method>
+ </methods>
+ </scenario>
+ <scenario name="CreateProductAttributeEntityTest" module="Magento_Catalog">
+ <methods>
+ <method name="test">
+ <steps>
+ <first>createProductTemplate</first>
+ <step name="createProductTemplate" module="Magento_Catalog">
+ <next>openProductAttributesPage</next>
+ </step>
+ <step name="openProductAttributesPage" module="Magento_Catalog">
+ <next>addNewAttribute</next>
+ </step>
+ <step name="addNewAttribute" module="Magento_Catalog">
+ <next>fillAttributeForm</next>
+ </step>
+ <step name="fillAttributeForm" module="Magento_Catalog">
+ <next>saveAttribute</next>
+ </step>
+ <step name="saveAttribute" module="Magento_Catalog">
+ <next>moveAttributeToProductTemplate</next>
+ </step>
+ <step name="moveAttributeToProductTemplate" module="Magento_Catalog">
+ <next>saveProductTemplate</next>
+ </step>
+ <step name="saveProductTemplate" module="Magento_Catalog" />
+ </steps>
+ </method>
+ </methods>
+ </scenario>
+</scenarios>
diff --git a/dev/tests/functional/tests/app/Magento/CatalogSearch/Test/Block/Advanced/Form.php b/dev/tests/functional/tests/app/Magento/CatalogSearch/Test/Block/Advanced/Form.php
index b714d39bc68a303dadea98db41a02118a2bbe4f5..ad63b569a5c576d777fd5cf4be2bad2cc9de8d9b 100644
--- a/dev/tests/functional/tests/app/Magento/CatalogSearch/Test/Block/Advanced/Form.php
+++ b/dev/tests/functional/tests/app/Magento/CatalogSearch/Test/Block/Advanced/Form.php
@@ -25,31 +25,45 @@
namespace Magento\CatalogSearch\Test\Block\Advanced;
use Mtf\Client\Element;
+use Mtf\Client\Element\Locator;
use Mtf\Fixture\FixtureInterface;
use Mtf\Block\Form as ParentForm;
/**
- * Class Form
- * Advanced search form
+ * Advanced search form.
*/
class Form extends ParentForm
{
/**
- * Search button selector
+ * Search button selector.
*
* @var string
*/
protected $searchButtonSelector = '.action.search';
/**
- * Field selector select tax class
+ * Field selector select tax class.
*
* @var string
*/
protected $taxClassSelector = '#tax_class_id';
/**
- * Submit search form
+ * Field selector.
+ *
+ * @var string
+ */
+ protected $fieldSelector = '//div[label and div]';
+
+ /**
+ * Label element selector.
+ *
+ * @var string
+ */
+ protected $labelSelector = 'label';
+
+ /**
+ * Submit search form.
*
* @return void
*/
@@ -59,7 +73,7 @@ class Form extends ParentForm
}
/**
- * Fill the root form
+ * Fill the root form.
*
* @param FixtureInterface $fixture
* @param Element|null $element
@@ -82,7 +96,7 @@ class Form extends ParentForm
}
/**
- * Fill form with custom fields
+ * Fill form with custom fields.
* (for End To End Tests)
*
* @param FixtureInterface $fixture
@@ -96,4 +110,19 @@ class Form extends ParentForm
$mapping = $this->dataMapping($dataForMapping);
$this->_fill($mapping, $element);
}
+
+ /**
+ * Get form fields.
+ *
+ * @return array
+ */
+ public function getFormLabels()
+ {
+ $labels = [];
+ $elements = $this->_rootElement->find($this->fieldSelector, Locator::SELECTOR_XPATH)->getElements();
+ foreach ($elements as $element) {
+ $labels[] = $element->find($this->labelSelector)->getText();
+ }
+ return $labels;
+ }
}
diff --git a/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/CreateTermEntityTest.php b/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/CreateTermEntityTest.php
index fc1b89572cb6950e80eb0655e7601185eb48ac8a..47a5853c5d9079dc9f3c7e8a6ed5bd5b9e8c43c8 100644
--- a/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/CreateTermEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/CreateTermEntityTest.php
@@ -24,14 +24,14 @@
namespace Magento\CheckoutAgreements\Test\TestCase;
-use Mtf\TestCase\Injectable;
use Mtf\ObjectManager;
+use Mtf\TestCase\Injectable;
use Magento\CheckoutAgreements\Test\Fixture\CheckoutAgreement;
use Magento\CheckoutAgreements\Test\Page\Adminhtml\CheckoutAgreementNew;
use Magento\CheckoutAgreements\Test\Page\Adminhtml\CheckoutAgreementIndex;
/**
- * Test creation for CreateTermEntity
+ * Test creation for CreateTermEntity.
*
* Test Flow:
*
@@ -50,12 +50,13 @@ use Magento\CheckoutAgreements\Test\Page\Adminhtml\CheckoutAgreementIndex;
*/
class CreateTermEntityTest extends Injectable
{
+ // TODO: Move set up configuration to "__prepare" method after fix bug MAGETWO-29331
/**
- * Set up configuration
+ * Set up configuration.
*
* @return void
*/
- public function __prepare()
+ public function __inject()
{
$this->objectManager->create(
'Magento\Core\Test\TestStep\SetupConfigurationStep',
@@ -64,7 +65,7 @@ class CreateTermEntityTest extends Injectable
}
/**
- * Create Term Entity test
+ * Create Term Entity test.
*
* @param CheckoutAgreementNew $agreementNew
* @param CheckoutAgreementIndex $agreementIndex
@@ -84,26 +85,18 @@ class CreateTermEntityTest extends Injectable
}
/**
- * Delete all terms on backend
+ * Clear data after test.
*
* @return void
*/
public function tearDown()
{
$this->objectManager->create('Magento\CheckoutAgreements\Test\TestStep\DeleteAllTermsEntityStep')->run();
- }
- /**
- * Set default configuration
- *
- * @return void
- */
- public static function tearDownAfterClass()
- {
- $setupConfigurationStep = ObjectManager::getInstance()->create(
+ // TODO: Move set default configuration to "tearDownAfterClass" method after fix bug MAGETWO-29331
+ ObjectManager::getInstance()->create(
'Magento\Core\Test\TestStep\SetupConfigurationStep',
['configData' => 'checkout_term_condition', 'rollback' => true]
- );
- $setupConfigurationStep->run();
+ )->run();
}
}
diff --git a/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/DeleteTermEntityTest.php b/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/DeleteTermEntityTest.php
index 586fd57b5a7231b1f2106e6d8475f2aad555eb23..360d6a0435602c918b30b5845850faacbd089a27 100644
--- a/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/DeleteTermEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/DeleteTermEntityTest.php
@@ -24,14 +24,14 @@
namespace Magento\CheckoutAgreements\Test\TestCase;
-use Mtf\TestCase\Injectable;
use Mtf\ObjectManager;
+use Mtf\TestCase\Injectable;
use Magento\CheckoutAgreements\Test\Fixture\CheckoutAgreement;
use Magento\CheckoutAgreements\Test\Page\Adminhtml\CheckoutAgreementNew;
use Magento\CheckoutAgreements\Test\Page\Adminhtml\CheckoutAgreementIndex;
/**
- * Test creation for DeleteTermEntityTest
+ * Test creation for DeleteTermEntityTest.
*
* Test Flow:
*
@@ -51,34 +51,21 @@ use Magento\CheckoutAgreements\Test\Page\Adminhtml\CheckoutAgreementIndex;
class DeleteTermEntityTest extends Injectable
{
/**
- * Checkout agreement index page
+ * Checkout agreement index page.
*
* @var CheckoutAgreementIndex
*/
protected $agreementIndex;
/**
- * Checkout agreement new page
+ * Checkout agreement new page.
*
* @var CheckoutAgreementNew
*/
protected $agreementNew;
/**
- * Set up configuration
- *
- * @return void
- */
- public function __prepare()
- {
- $this->objectManager->create(
- 'Magento\Core\Test\TestStep\SetupConfigurationStep',
- ['configData' => 'checkout_term_condition']
- )->run();
- }
-
- /**
- * Inject pages
+ * Inject data.
*
* @param CheckoutAgreementNew $agreementNew
* @param CheckoutAgreementIndex $agreementIndex
@@ -90,10 +77,16 @@ class DeleteTermEntityTest extends Injectable
) {
$this->agreementNew = $agreementNew;
$this->agreementIndex = $agreementIndex;
+
+ // TODO: Move set up configuration to "__prepare" method after fix bug MAGETWO-29331
+ $this->objectManager->create(
+ 'Magento\Core\Test\TestStep\SetupConfigurationStep',
+ ['configData' => 'checkout_term_condition']
+ )->run();
}
/**
- * Delete Term Entity test
+ * Delete Term Entity test.
*
* @param CheckoutAgreement $agreement
* @return void
@@ -108,12 +101,13 @@ class DeleteTermEntityTest extends Injectable
$this->agreementNew->getPageActionsBlock()->delete();
}
+ // TODO: Move set default configuration to "tearDownAfterClass" method after fix bug MAGETWO-29331
/**
- * Set default configuration
+ * Set default configuration.
*
* @return void
*/
- public static function tearDownAfterClass()
+ public function tearDown()
{
ObjectManager::getInstance()->create(
'Magento\Core\Test\TestStep\SetupConfigurationStep',
diff --git a/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/UpdateTermEntityTest.php b/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/UpdateTermEntityTest.php
index 6232a24f02b93353704abb564485d5b0491ef6c5..cda087d585356dbbbc282cb45002bbeb2216d7d4 100644
--- a/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/UpdateTermEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/TestCase/UpdateTermEntityTest.php
@@ -24,14 +24,14 @@
namespace Magento\CheckoutAgreements\Test\TestCase;
-use Mtf\TestCase\Injectable;
use Mtf\ObjectManager;
+use Mtf\TestCase\Injectable;
use Magento\CheckoutAgreements\Test\Fixture\CheckoutAgreement;
use Magento\CheckoutAgreements\Test\Page\Adminhtml\CheckoutAgreementNew;
use Magento\CheckoutAgreements\Test\Page\Adminhtml\CheckoutAgreementIndex;
/**
- * Test creation for UpdateTermEntityTest
+ * Test creation for UpdateTermEntityTest.
*
* Test Flow:
*
@@ -51,12 +51,13 @@ use Magento\CheckoutAgreements\Test\Page\Adminhtml\CheckoutAgreementIndex;
*/
class UpdateTermEntityTest extends Injectable
{
+ // TODO: Move set up configuration to "__prepare" method after fix bug MAGETWO-29331
/**
- * Set up configuration
+ * Set up configuration.
*
* @return void
*/
- public function __prepare()
+ public function __inject()
{
$this->objectManager->create(
'Magento\Core\Test\TestStep\SetupConfigurationStep',
@@ -65,7 +66,7 @@ class UpdateTermEntityTest extends Injectable
}
/**
- * Update Term Entity test
+ * Update Term Entity test.
*
* @param CheckoutAgreementNew $agreementNew
* @param CheckoutAgreementIndex $agreementIndex
@@ -90,22 +91,15 @@ class UpdateTermEntityTest extends Injectable
}
/**
- * Delete all terms on backend
+ * Clear data after test.
*
* @return void
*/
public function tearDown()
{
$this->objectManager->create('Magento\CheckoutAgreements\Test\TestStep\DeleteAllTermsEntityStep')->run();
- }
- /**
- * Set default configuration
- *
- * @return void
- */
- public static function tearDownAfterClass()
- {
+ // TODO: Move set default configuration to "tearDownAfterClass" method after fix bug MAGETWO-29331
ObjectManager::getInstance()->create(
'Magento\Core\Test\TestStep\SetupConfigurationStep',
['configData' => 'checkout_term_condition', 'rollback' => true]
diff --git a/dev/tests/functional/tests/app/Magento/ConfigurableProduct/Test/Constraint/AssertProductAttributeIsConfigurable.php b/dev/tests/functional/tests/app/Magento/ConfigurableProduct/Test/Constraint/AssertProductAttributeIsConfigurable.php
index 6e5074d83fa356896fb9ae93a325ec0028ddc8ec..e99c607da2977635c46e4c5361b39d7875620d85 100644
--- a/dev/tests/functional/tests/app/Magento/ConfigurableProduct/Test/Constraint/AssertProductAttributeIsConfigurable.php
+++ b/dev/tests/functional/tests/app/Magento/ConfigurableProduct/Test/Constraint/AssertProductAttributeIsConfigurable.php
@@ -24,15 +24,14 @@
namespace Magento\ConfigurableProduct\Test\Constraint;
-use Mtf\Fixture\FixtureFactory;
use Mtf\Constraint\AbstractConstraint;
use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
use Magento\Catalog\Test\Page\Adminhtml\CatalogProductIndex;
use Magento\Catalog\Test\Page\Adminhtml\CatalogProductNew;
+use Magento\ConfigurableProduct\Test\Block\Adminhtml\Product\Edit\Tab\Super\Config as TabVariation;
/**
- * Class AssertProductAttributeIsConfigurable
- * Assert check whether the attribute is used to create a configurable products
+ * Assert check whether the attribute is used to create a configurable products.
*/
class AssertProductAttributeIsConfigurable extends AbstractConstraint
{
@@ -44,58 +43,36 @@ class AssertProductAttributeIsConfigurable extends AbstractConstraint
protected $severeness = 'high';
/**
- * Attribute frontend label
- *
- * @var CatalogProductAttribute
- */
- protected $attribute;
-
- /**
- * Assert check whether the attribute is used to create a configurable products
+ * Assert check whether the attribute is used to create a configurable products.
*
* @param CatalogProductAttribute $productAttribute
* @param CatalogProductAttribute $attribute
* @param CatalogProductIndex $productGrid
- * @param FixtureFactory $fixtureFactory
* @param CatalogProductNew $newProductPage
*/
public function processAssert(
CatalogProductAttribute $attribute,
CatalogProductIndex $productGrid,
- FixtureFactory $fixtureFactory,
CatalogProductNew $newProductPage,
CatalogProductAttribute $productAttribute = null
) {
- $this->attribute = !is_null($productAttribute) ? $productAttribute : $attribute;
+ $attributeSearch = is_null($productAttribute) ? $attribute : $productAttribute;
$productGrid->open();
$productGrid->getGridPageActionBlock()->addProduct('configurable');
-
- $productConfigurable = $fixtureFactory->createByCode(
- 'configurableProductInjectable',
- [
- 'dataSet' => 'default',
- 'data' => [
- 'configurable_attributes_data' => [
- 'preset' => 'one_variation',
- 'attributes' => [
- $this->attribute
- ]
- ]
- ],
- ]
- );
-
$productBlockForm = $newProductPage->getProductForm();
- $productBlockForm->fill($productConfigurable);
$productBlockForm->openTab('variations');
+
+ /** @var TabVariation $tabVariation */
+ $tabVariation = $productBlockForm->getTabElement('variations');
+ $configurableAttributeSelector = $tabVariation->getAttributeBlock()->getAttributeSelector();
\PHPUnit_Framework_Assert::assertTrue(
- $productBlockForm->checkAttributeInSearchAttributeForm($this->attribute),
+ $configurableAttributeSelector->isExistAttributeInSearchResult($attributeSearch),
"Product attribute is absent on the product page."
);
}
/**
- * Attribute label present on the product page in variations section
+ * Attribute label present on the product page in variations section.
*
* @return string
*/
diff --git a/dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/CreateCustomerBackendEntityTest/testCreateCustomerBackendEntity.csv b/dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/CreateCustomerBackendEntityTest/testCreateCustomerBackendEntity.csv
index 47b35a7511a615f8810f922c99bd89bd59a39832..e6e356a43c2340678c3503cace1535d4c1799823 100644
--- a/dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/CreateCustomerBackendEntityTest/testCreateCustomerBackendEntity.csv
+++ b/dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/CreateCustomerBackendEntityTest/testCreateCustomerBackendEntity.csv
@@ -1,6 +1,6 @@
-"customer/data/website_id";"customer/data/group_id/dataSet";"customer/data/prefix";"customer/data/firstname";"customer/data/middlename";"customer/data/lastname";"customer/data/suffix";"customer/data/email";"customer/data/dob";"customer/data/taxvat";"customer/data/gender";"address/data/firstname";"address/data/lastname";"address/data/street";"address/data/city";"address/data/country_id";"address/data/region_id";"address/data/postcode";"address/data/telephone";"constraint"
-"Main Website";"General";"-";"John%isolation%";"-";"Doe%isolation%";"-";"JohnDoe%isolation%@example.com";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertCustomerSuccessSaveMessage, assertCustomerInGrid, assertCustomerForm"
-"Admin";"Wholesale";"M";"John%isolation%";"Jack";"Doe%isolation%";"S";"JohnDoe%isolation%@example.com";"3/16/2004";"-";"Male";"-";"-";"-";"-";"-";"-";"-";"-";"assertCustomerSuccessSaveMessage, assertCustomerInGrid, assertCustomerForm"
-"Main Website";"General";"-";"John%isolation%";"-";"Doe%isolation%";"-";"JohnDoe%isolation%@example.com";"-";"-";"-";"Joe";"Doe";"1 Main Street";"Culver City";"United States";"California";"90230";"3109450345";"assertCustomerSuccessSaveMessage, assertCustomerInGrid, assertCustomerForm"
-"Main Website";"Retailer";"-";"John%isolation%";"-";"Doe%isolation%";"-";"JohnDoe%isolation%@example.ccc";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertCustomerInvalidEmail"
-"Main Website";"General";"-";"Thomas%isolation%";"-";"Oster%isolation%";"-";"Thomas%isolation%@example.com";"-";"5250008057";"-";"Thomas";"Oster";"Chmielna 113";"Bielsko-Biala";"Poland";"-";"43-310 ";"799885616";"assertCustomerSuccessSaveMessage, assertCustomerInGrid, assertCustomerForm"
+"customer/data/website_id";"customer/data/group_id/dataSet";"customer/data/prefix";"customer/data/firstname";"customer/data/middlename";"customer/data/lastname";"customer/data/suffix";"customer/data/email";"customer/data/dob";"customer/data/taxvat";"customer/data/gender";"address/data/firstname";"address/data/lastname";"address/data/street";"address/data/city";"address/data/country_id";"address/data/region_id";"address/data/postcode";"address/data/telephone";"constraint";"issue"
+"Main Website";"General";"-";"John%isolation%";"-";"Doe%isolation%";"-";"JohnDoe%isolation%@example.com";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertCustomerSuccessSaveMessage, assertCustomerInGrid, assertCustomerForm";""
+"Admin";"Wholesale";"M";"John%isolation%";"Jack";"Doe%isolation%";"S";"JohnDoe%isolation%@example.com";"3/16/2004";"-";"Male";"-";"-";"-";"-";"-";"-";"-";"-";"assertCustomerSuccessSaveMessage, assertCustomerInGrid, assertCustomerForm";""
+"Main Website";"General";"-";"John%isolation%";"-";"Doe%isolation%";"-";"JohnDoe%isolation%@example.com";"-";"-";"-";"Joe";"Doe";"1 Main Street";"Culver City";"United States";"California";"90230";"3109450345";"assertCustomerSuccessSaveMessage, assertCustomerInGrid, assertCustomerForm";"Bug: MAGETWO-30226"
+"Main Website";"Retailer";"-";"John%isolation%";"-";"Doe%isolation%";"-";"JohnDoe%isolation%@example.ccc";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertCustomerInvalidEmail";"Bug: MAGETWO-28875"
+"Main Website";"General";"-";"Thomas%isolation%";"-";"Oster%isolation%";"-";"Thomas%isolation%@example.com";"-";"5250008057";"-";"Thomas";"Oster";"Chmielna 113";"Bielsko-Biala";"Poland";"-";"43-310 ";"799885616";"assertCustomerSuccessSaveMessage, assertCustomerInGrid, assertCustomerForm";"Bug: MAGETWO-30226"
diff --git a/dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/UpdateCustomerBackendEntityTest/testUpdateCustomerBackendEntity.csv b/dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/UpdateCustomerBackendEntityTest/testUpdateCustomerBackendEntity.csv
index 156e27d5ca943e73d113335fca07c9c32672baec..aabdfc2d31fb4656664235842db4b844204f5018 100644
--- a/dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/UpdateCustomerBackendEntityTest/testUpdateCustomerBackendEntity.csv
+++ b/dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/UpdateCustomerBackendEntityTest/testUpdateCustomerBackendEntity.csv
@@ -1,4 +1,4 @@
-"initialCustomer/dataSet";"customer/data/group_id/dataSet";"customer/data/prefix";"customer/data/firstname";"customer/data/middlename";"customer/data/lastname";"customer/data/suffix";"customer/data/email";"customer/data/dob";"customer/data/taxvat";"customer/data/gender";"address/data/prefix";"address/data/firstname";"address/data/middlename";"address/data/lastname";"address/data/suffix";"address/data/company";"address/data/street";"address/data/city";"address/data/country_id";"address/data/region_id";"address/data/region";"address/data/postcode";"address/data/telephone";"address/data/fax";"address/data/vat_id";"constraint"
-"default";"Wholesale";"%isolation%Prefix_";"John_%isolation%";"Middle Name %isolation%";"Doe%isolation%";"_Suffix%isolation%";"JohnDoe%isolation%@example.com";1/8/1986;123456789001;"Male";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertCustomerSuccessSaveMessage, assertCustomerForm, assertCustomerInGrid"
-"default";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"Prefix%isolation%_";"Doe%isolation%";"Middle Name %isolation%";"Doe%isolation%";"_Suffix%isolation%";"Company%isolation%";"3962 Horner Street";"Dothan";"United States";"Alabama";"-";36303;"334-200-4060";"555-666-777-8910";"U1234567890";"assertCustomerSuccessSaveMessage, assertCustomerForm, assertCustomerInGrid"
-"default";"Retailer";"%isolation%Prefix_";"Jane_%isolation%";"Jane Middle Name %isolation%";"Doe%isolation%";"_JaneSuffix%isolation%";"Jane%isolation%@example.com";1/12/2000;987654321;"Female";"Prefix%isolation%_";"Doe%isolation%";"Middle Name %isolation%";"Doe%isolation%";"_Suffix%isolation%";"Company%isolation%";"39 Northgate Street";"BICKTON";"United Kingdom";"-";"PINMINNOCH";"KA26 1PF ";"999-777-111-2345";"-";987654321;"assertCustomerSuccessSaveMessage, assertCustomerForm, assertCustomerInGrid"
+"initialCustomer/dataSet";"customer/data/group_id/dataSet";"customer/data/prefix";"customer/data/firstname";"customer/data/middlename";"customer/data/lastname";"customer/data/suffix";"customer/data/email";"customer/data/dob";"customer/data/taxvat";"customer/data/gender";"address/data/prefix";"address/data/firstname";"address/data/middlename";"address/data/lastname";"address/data/suffix";"address/data/company";"address/data/street";"address/data/city";"address/data/country_id";"address/data/region_id";"address/data/region";"address/data/postcode";"address/data/telephone";"address/data/fax";"address/data/vat_id";"constraint";"issue"
+"default";"Wholesale";"%isolation%Prefix_";"John_%isolation%";"Middle Name %isolation%";"Doe%isolation%";"_Suffix%isolation%";"JohnDoe%isolation%@example.com";1/8/1986;123456789001;"Male";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"assertCustomerSuccessSaveMessage, assertCustomerForm, assertCustomerInGrid";""
+"default";"-";"-";"-";"-";"-";"-";"-";"-";"-";"-";"Prefix%isolation%_";"Doe%isolation%";"Middle Name %isolation%";"Doe%isolation%";"_Suffix%isolation%";"Company%isolation%";"3962 Horner Street";"Dothan";"United States";"Alabama";"-";36303;"334-200-4060";"555-666-777-8910";"U1234567890";"assertCustomerSuccessSaveMessage, assertCustomerForm, assertCustomerInGrid";"Bug: MAGETWO-30226"
+"default";"Retailer";"%isolation%Prefix_";"Jane_%isolation%";"Jane Middle Name %isolation%";"Doe%isolation%";"_JaneSuffix%isolation%";"Jane%isolation%@example.com";1/12/2000;987654321;"Female";"Prefix%isolation%_";"Doe%isolation%";"Middle Name %isolation%";"Doe%isolation%";"_Suffix%isolation%";"Company%isolation%";"39 Northgate Street";"BICKTON";"United Kingdom";"-";"PINMINNOCH";"KA26 1PF ";"999-777-111-2345";"-";987654321;"assertCustomerSuccessSaveMessage, assertCustomerForm, assertCustomerInGrid";"Bug: MAGETWO-30226"
diff --git a/dev/tests/functional/tests/app/Magento/Customer/Test/TestStep/LogoutCustomerOnFrontendStep.php b/dev/tests/functional/tests/app/Magento/Customer/Test/TestStep/LogoutCustomerOnFrontendStep.php
index 3d0476bdd0fb48b909d4239e47e8e24e83c9c4b7..57be188f48f785fa556972e5510d920703c928c4 100644
--- a/dev/tests/functional/tests/app/Magento/Customer/Test/TestStep/LogoutCustomerOnFrontendStep.php
+++ b/dev/tests/functional/tests/app/Magento/Customer/Test/TestStep/LogoutCustomerOnFrontendStep.php
@@ -57,8 +57,9 @@ class LogoutCustomerOnFrontendStep implements TestStepInterface
public function run()
{
$this->cmsIndex->open();
- if ($this->cmsIndex->getLinksBlock()->isVisible("Log Out")) {
+ if ($this->cmsIndex->getLinksBlock()->isLinkVisible("Log Out")) {
$this->cmsIndex->getLinksBlock()->openLink("Log Out");
+ $this->cmsIndex->getCmsPageBlock()->waitUntilTextIsVisible('Home Page');
}
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Downloadable/Test/Fixture/DownloadableProductInjectable/CheckoutData.php b/dev/tests/functional/tests/app/Magento/Downloadable/Test/Fixture/DownloadableProductInjectable/CheckoutData.php
index 4852b1a13ca225e46bfdee7562684def4e3bfb11..81e981aab1746d28b5c98263a74e5c071689f836 100644
--- a/dev/tests/functional/tests/app/Magento/Downloadable/Test/Fixture/DownloadableProductInjectable/CheckoutData.php
+++ b/dev/tests/functional/tests/app/Magento/Downloadable/Test/Fixture/DownloadableProductInjectable/CheckoutData.php
@@ -56,6 +56,24 @@ class CheckoutData extends \Magento\Catalog\Test\Fixture\CatalogProductSimple\Ch
'subtotal' => 23
]
],
+ 'with_two_bought_links' => [
+ 'options' => [
+ 'links' => [
+ [
+ 'label' => 'link_1',
+ 'value' => 'Yes'
+ ],
+ [
+ 'label' => 'link_2',
+ 'value' => 'Yes'
+ ]
+ ],
+ 'cartItem' => [
+ 'price' => 23,
+ 'subtotal' => 23
+ ]
+ ],
+ ],
'forUpdateMiniShoppingCart' => [
'options' => [
'links' => [
diff --git a/dev/tests/functional/tests/app/Magento/Downloadable/Test/Repository/DownloadableProductInjectable.php b/dev/tests/functional/tests/app/Magento/Downloadable/Test/Repository/DownloadableProductInjectable.php
index 42b9cc14d7aaf6401a6c4be6df95e012bac91bb3..cffee7d20e967ec8eed18816e5c8c2595f9e38a1 100644
--- a/dev/tests/functional/tests/app/Magento/Downloadable/Test/Repository/DownloadableProductInjectable.php
+++ b/dev/tests/functional/tests/app/Magento/Downloadable/Test/Repository/DownloadableProductInjectable.php
@@ -76,5 +76,21 @@ class DownloadableProductInjectable extends AbstractRepository
'downloadable_links' => ['preset' => 'with_two_separately_links'],
'checkout_data' => ['preset' => 'with_two_separately_links']
];
+ $this->_data['with_two_bought_links'] = [
+ 'name' => 'Downloadable product %isolation%',
+ 'sku' => 'downloadable_product_%isolation%',
+ 'url_key' => 'downloadable-product-%isolation%',
+ 'price' => ['value' => '20'],
+ 'tax_class_id' => ['dataSet' => 'Taxable Goods'],
+ 'quantity_and_stock_status' => [
+ 'qty' => 1111,
+ 'is_in_stock' => 'In Stock'
+ ],
+ 'status' => 'Product online',
+ 'visibility' => 'Catalog, Search',
+ 'is_virtual' => 'Yes',
+ 'downloadable_links' => ['preset' => 'with_two_separately_links'],
+ 'checkout_data' => ['preset' => 'with_two_bought_links']
+ ];
}
}
diff --git a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Adminhtml/Order/Create/Items/ItemProduct.php b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Adminhtml/Order/Create/Items/ItemProduct.php
index 19bd44a0cd9d8dbfd8bc7aa7e3a36d22eb65dad0..6ea5363fc41a78d192d29b17665139f93c78a5d8 100644
--- a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Adminhtml/Order/Create/Items/ItemProduct.php
+++ b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Adminhtml/Order/Create/Items/ItemProduct.php
@@ -29,7 +29,6 @@ use Mtf\Client\Element;
use Mtf\Client\Element\Locator;
/**
- * Class ItemProduct
* Item product block on backend create order page.
*/
class ItemProduct extends \Magento\Sales\Test\Block\Adminhtml\Order\Create\Items\ItemProduct
@@ -46,7 +45,7 @@ class ItemProduct extends \Magento\Sales\Test\Block\Adminhtml\Order\Create\Items
*
* @var string
*/
- protected $giftMessageForm = '//*[@role="dialog"][*[@id="gift_options_configure"]]';
+ protected $giftMessageForm = './/*[@role="dialog"][*[@id="gift_options_configure"]]';
/**
* Magento varienLoader.js loader.
@@ -65,6 +64,13 @@ class ItemProduct extends \Magento\Sales\Test\Block\Adminhtml\Order\Create\Items
{
$giftOptionsLink = $this->_rootElement->find($this->giftOptionsLink);
$giftOptionsLink->click();
+ $giftMessageFormSelector = $this->giftMessageForm;
+ $browser = $this->browser;
+ $browser->waitUntil(
+ function () use ($giftMessageFormSelector, $browser) {
+ return $browser->find($giftMessageFormSelector, Locator::SELECTOR_XPATH)->isVisible() ? true : null;
+ }
+ );
/** @var \Magento\GiftMessage\Test\Block\Adminhtml\Order\Create\Form $giftMessageForm */
$giftMessageForm = $this->blockFactory->create(
'Magento\GiftMessage\Test\Block\Adminhtml\Order\Create\Form',
diff --git a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Adminhtml/Order/View/Items/ItemProduct.php b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Adminhtml/Order/View/Items/ItemProduct.php
index edbdc303a02d4440b153cc23d59ddb90bf3012bb..cfb5371957ea4e33c058aba9f9995f7c4f169462 100644
--- a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Adminhtml/Order/View/Items/ItemProduct.php
+++ b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Adminhtml/Order/View/Items/ItemProduct.php
@@ -46,7 +46,7 @@ class ItemProduct extends \Magento\Sales\Test\Block\Adminhtml\Order\Create\Items
*
* @var string
*/
- protected $giftMessageForm = '//*[@role="dialog"][*[@id="gift_options_configure"]]';
+ protected $giftMessageForm = './/*[@role="dialog"][*[@id="gift_options_configure"]]';
/**
* Get GiftMessage form data.
@@ -60,6 +60,13 @@ class ItemProduct extends \Magento\Sales\Test\Block\Adminhtml\Order\Create\Items
if ($giftOptionsLink->isVisible()) {
$giftOptionsLink->click();
}
+ $giftMessageFormSelector = $this->giftMessageForm;
+ $browser = $this->browser;
+ $browser->waitUntil(
+ function () use ($giftMessageFormSelector, $browser) {
+ return $browser->find($giftMessageFormSelector, Locator::SELECTOR_XPATH)->isVisible() ? true : null;
+ }
+ );
/** @var \Magento\GiftMessage\Test\Block\Adminhtml\Order\View\Form $giftMessageForm */
$giftMessageForm = $this->blockFactory->create(
'Magento\GiftMessage\Test\Block\Adminhtml\Order\View\Form',
diff --git a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Message/Order/Items/View.php b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Message/Order/Items/View.php
index 7abde9db146f664b9ecf0af4ba6a663812b8aafa..5258684f355644a77122455e03b6b468f4af2d1e 100644
--- a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Message/Order/Items/View.php
+++ b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Message/Order/Items/View.php
@@ -28,48 +28,47 @@ use Mtf\Block\Block;
use Mtf\Client\Element\Locator;
/**
- * Class View
- * Gift message block for order's items on order view page
+ * Gift message block for order's items on order view page.
*/
class View extends Block
{
/**
- * Gift message sender selector
+ * Gift message sender selector.
*
* @var string
*/
- protected $giftMessageSenderSelector = ".gift.sender";
+ protected $giftMessageSenderSelector = "[class*='sender']";
/**
- * Gift message recipient selector
+ * Gift message recipient selector.
*
* @var string
*/
- protected $giftMessageRecipientSelector = ".gift.recipient";
+ protected $giftMessageRecipientSelector = "[class*='recipient']";
/**
- * Gift message text selector
+ * Gift message text selector.
*
* @var string
*/
- protected $giftMessageTextSelector = ".message.text";
+ protected $giftMessageTextSelector = "[class*='message']";
/**
- * Selector for "Gift Message" button
+ * Selector for "Gift Message" button.
*
* @var string
*/
- protected $giftMessageButtonSelector = ".//td[contains(., '%s')]//a[contains(@id,'gift-message')]";
+ protected $giftMessageButtonSelector = ".//tbody[contains(., '%s')]//a[contains(@id,'gift-message')]";
/**
- * Selector for "Gift Message"
+ * Selector for "Gift Message".
*
* @var string
*/
- protected $giftMessageForItemSelector = ".//tr[contains(., '%s')]/following-sibling::tr";
+ protected $giftMessageForItemSelector = ".//tr[contains(., '%s')]/following-sibling::tr//*[@class='item-options']";
/**
- * Get gift message for item
+ * Get gift message for item.
*
* @param string $itemName
* @return array
@@ -77,22 +76,25 @@ class View extends Block
public function getGiftMessage($itemName)
{
$message = [];
+ $labelsToSkip = [];
$this->clickGiftMessageButton($itemName);
$messageElement = $this->_rootElement->find(
sprintf($this->giftMessageForItemSelector, $itemName),
Locator::SELECTOR_XPATH
);
+ $labelsToSkip[] = $messageElement->find($this->giftMessageSenderSelector . ' strong')->getText();
+ $labelsToSkip[] = $messageElement->find($this->giftMessageRecipientSelector . ' strong')->getText();
$message['sender'] = $messageElement->find($this->giftMessageSenderSelector)->getText();
$message['recipient'] = $messageElement->find($this->giftMessageRecipientSelector)->getText();
$message['message'] = $messageElement->find($this->giftMessageTextSelector)->getText();
- $message = preg_replace('@.*?:\s(.*)@', '\1', $message);
+ $message = str_replace($labelsToSkip, '', $message);
return $message;
}
/**
- * Click "Gift Message" for special item
+ * Click "Gift Message" for special item.
*
* @param string $itemName
* @return void
diff --git a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Message/Order/View.php b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Message/Order/View.php
index 9204681b9fc891c0a6866291d77e0f403845da5d..a272e629926fe765502e43917941eafdc83a8791 100644
--- a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Message/Order/View.php
+++ b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Block/Message/Order/View.php
@@ -25,45 +25,46 @@
namespace Magento\GiftMessage\Test\Block\Message\Order;
/**
- * Class View
- * Gift message block for order on order view page
+ * Gift message block for order on order view page.
*/
class View extends \Magento\Sales\Test\Block\Order\View
{
/**
- * Gift message sender selector
+ * Gift message sender selector.
*
* @var string
*/
- protected $giftMessageSenderSelector = ".gift-sender";
+ protected $giftMessageSenderSelector = "[class*='sender']";
/**
- * Gift message recipient selector
+ * Gift message recipient selector.
*
* @var string
*/
- protected $giftMessageRecipientSelector = ".gift-recipient";
+ protected $giftMessageRecipientSelector = "[class*='recipient']";
/**
- * Gift message text selector
+ * Gift message text selector.
*
* @var string
*/
- protected $giftMessageTextSelector = ".gift-message-text";
+ protected $giftMessageTextSelector = "[class*='message']";
/**
- * Get gift message for order
+ * Get gift message for order.
*
* @return array
*/
public function getGiftMessage()
{
$message = [];
-
+ $labelsToSkip = [];
+ $labelsToSkip[] = $this->_rootElement->find($this->giftMessageSenderSelector . ' strong')->getText();
+ $labelsToSkip[] = $this->_rootElement->find($this->giftMessageRecipientSelector . ' strong')->getText();
$message['sender'] = $this->_rootElement->find($this->giftMessageSenderSelector)->getText();
$message['recipient'] = $this->_rootElement->find($this->giftMessageRecipientSelector)->getText();
$message['message'] = $this->_rootElement->find($this->giftMessageTextSelector)->getText();
- $message = preg_replace('@.*?:\s(.*)@', '\1', $message);
+ $message = str_replace($labelsToSkip, '', $message);
return $message;
}
diff --git a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Page/OrderView.xml b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Page/OrderView.xml
index 38f4734ae62e17feb47788086ecfa9f734b27c9d..e067d6d22ee265a5e9d574ba6bf99ae54e05629e 100644
--- a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Page/OrderView.xml
+++ b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/Page/OrderView.xml
@@ -27,7 +27,7 @@
<blocks>
<giftMessageForOrderBlock>
<class>Magento\GiftMessage\Test\Block\Message\Order\View</class>
- <locator>.block-order-details-additional</locator>
+ <locator>.block-order-details-gift-message</locator>
<strategy>css selector</strategy>
</giftMessageForOrderBlock>
<giftMessageForItemBlock>
diff --git a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/TestCase/CheckoutWithGiftMessagesTest.php b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/TestCase/CheckoutWithGiftMessagesTest.php
index 01533bb6249d83887b0e0218474a8f03bc0c398c..45ce34596c9812efc0a07a54295a190014f82b56 100644
--- a/dev/tests/functional/tests/app/Magento/GiftMessage/Test/TestCase/CheckoutWithGiftMessagesTest.php
+++ b/dev/tests/functional/tests/app/Magento/GiftMessage/Test/TestCase/CheckoutWithGiftMessagesTest.php
@@ -55,6 +55,7 @@ class CheckoutWithGiftMessagesTest extends Scenario
*/
public function test()
{
+ $this->markTestIncomplete("Bug: MAGETWO-30593");
$this->executeScenario();
}
}
diff --git a/dev/tests/functional/tests/app/Magento/GroupedProduct/Test/Block/Catalog/Product/View/Type/Grouped.php b/dev/tests/functional/tests/app/Magento/GroupedProduct/Test/Block/Catalog/Product/View/Type/Grouped.php
index a69f2fdd5533ea65ef3e4a90e69a6ba894e49714..23e61ad57bd8acf2a147d602506731655888c956 100644
--- a/dev/tests/functional/tests/app/Magento/GroupedProduct/Test/Block/Catalog/Product/View/Type/Grouped.php
+++ b/dev/tests/functional/tests/app/Magento/GroupedProduct/Test/Block/Catalog/Product/View/Type/Grouped.php
@@ -104,11 +104,13 @@ class Grouped extends Block
// Fill
foreach ($checkoutData['options'] as $productData) {
+ $this->browser->selectWindow();
$subProduct = $this->_rootElement->find(
sprintf($this->subProductByName, $productData['name']),
Locator::SELECTOR_XPATH
);
- $subProduct->find($this->qty)->setValue($productData['qty']);
+ $subProduct->find($this->qty)->keys([$productData['qty']]);
+ $this->_rootElement->click();
}
}
}
diff --git a/dev/tests/functional/tests/app/Magento/GroupedProduct/Test/Constraint/AssertGroupedProductInItemsOrderedGrid.php b/dev/tests/functional/tests/app/Magento/GroupedProduct/Test/Constraint/AssertGroupedProductInItemsOrderedGrid.php
index 729d0c845765f4cbe13fb26b4370588fe48b8f07..852d2118f9a7ce48081164348abc2a32a2929cfa 100644
--- a/dev/tests/functional/tests/app/Magento/GroupedProduct/Test/Constraint/AssertGroupedProductInItemsOrderedGrid.php
+++ b/dev/tests/functional/tests/app/Magento/GroupedProduct/Test/Constraint/AssertGroupedProductInItemsOrderedGrid.php
@@ -91,7 +91,7 @@ class AssertGroupedProductInItemsOrderedGrid extends AbstractConstraint
$products = $product->getAssociated()['products'];
foreach ($products as $key => $value) {
$fixtureData[$key]['name'] = $value->getName();
- $fixtureData[$key]['price'] = $value->getPrice();
+ $fixtureData[$key]['price'] = number_format($value->getPrice(), 2);
}
$options = $product->getCheckoutData()['options'];
foreach ($options as $key => $option) {
diff --git a/dev/tests/functional/tests/app/Magento/LayeredNavigation/Test/Block/Navigation.php b/dev/tests/functional/tests/app/Magento/LayeredNavigation/Test/Block/Navigation.php
index ad4d80cc3adcdb3f6946638d7fc2163b2c0e0d44..7a648edd141ac63663d71007438e4c8428bbfa66 100644
--- a/dev/tests/functional/tests/app/Magento/LayeredNavigation/Test/Block/Navigation.php
+++ b/dev/tests/functional/tests/app/Magento/LayeredNavigation/Test/Block/Navigation.php
@@ -24,6 +24,7 @@
namespace Magento\LayeredNavigation\Test\Block;
use Mtf\Block\Block;
+use Mtf\Client\Element;
use Mtf\Client\Element\Locator;
/**
@@ -32,28 +33,44 @@ use Mtf\Client\Element\Locator;
class Navigation extends Block
{
/**
- * 'Clear All' link
+ * 'Clear All' link.
*
* @var string
*/
protected $clearAll = '.action.clear';
/**
- * Price range
+ * Price range.
*
* @var string
*/
protected $priceRange = "[href$='?price=%s']";
/**
- * Attribute option
+ * Attribute option.
*
* @var string
*/
protected $attributeOption = "//a[contains(text(), '%s')]";
/**
- * Click on 'Clear All' link
+ * Attribute option title selector.
+ *
+ * @var string
+ */
+ protected $optionTitle = '.filter-options-title';
+
+ /**
+ * Attribute option content selector.
+ *
+ * @var string
+ */
+ protected $optionContent = '.filter-options-content';
+
+ /**
+ * Click on 'Clear All' link.
+ *
+ * @return void
*/
public function clearAll()
{
@@ -62,9 +79,10 @@ class Navigation extends Block
}
/**
- * Select product price range
+ * Select product price range.
*
* @param string $range
+ * @return void
*/
public function selectPriceRange($range)
{
@@ -73,13 +91,29 @@ class Navigation extends Block
}
/**
- * Select attribute option
+ * Select attribute option.
*
* @param string $optionName
+ * @return void
*/
public function selectAttributeOption($optionName)
{
$this->reinitRootElement();
$this->_rootElement->find(sprintf($this->attributeOption, $optionName), Locator::SELECTOR_XPATH)->click();
}
+
+ /**
+ * Get array of available filters.
+ *
+ * @return array
+ */
+ public function getFilters()
+ {
+ $options = $this->_rootElement->find($this->optionTitle)->getElements();
+ $data = [];
+ foreach ($options as $option) {
+ $data[] = $option->getText();
+ }
+ return $data;
+ }
}
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Product/Viewed/Filter.php b/dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Product/Viewed/Filter.php
new file mode 100644
index 0000000000000000000000000000000000000000..b26d968ba220ac245d67bffc42de9bc211809666
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Product/Viewed/Filter.php
@@ -0,0 +1,36 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Reports\Test\Block\Adminhtml\Product\Viewed;
+
+use Mtf\ObjectManager;
+use Magento\Reports\Test\Block\Adminhtml\AbstractFilter;
+
+/**
+ * Filter for Product Views Report.
+ */
+class Filter extends AbstractFilter
+{
+ //
+}
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Product/Viewed/Filter.xml b/dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Product/Viewed/Filter.xml
new file mode 100644
index 0000000000000000000000000000000000000000..0d28736f7b1f15f3ac64697af2e426691df13795
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Product/Viewed/Filter.xml
@@ -0,0 +1,41 @@
+<?xml version="1.0" ?>
+<!--
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Academic Free License (AFL 3.0)
+ * that is bundled with this package in the file LICENSE_AFL.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/afl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0)
+ */
+-->
+<mapping strict="0">
+ <fields>
+ <from>
+ <input>datepicker</input>
+ </from>
+ <to>
+ <input>datepicker</input>
+ </to>
+ <period_type>
+ <input>select</input>
+ </period_type>
+ <show_empty_rows>
+ <input>select</input>
+ </show_empty_rows>
+ </fields>
+</mapping>
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Product/Viewed/ProductGrid.php b/dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Product/Viewed/ProductGrid.php
new file mode 100644
index 0000000000000000000000000000000000000000..325799516c2603d77ea25462a6a21a2bed94ea01
--- /dev/null
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Product/Viewed/ProductGrid.php
@@ -0,0 +1,53 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Reports\Test\Block\Adminhtml\Product\Viewed;
+
+use Magento\Reports\Test\Block\Adminhtml\Customer\Totals\Grid;
+
+/**
+ * Product Views Report.
+ */
+class ProductGrid extends Grid
+{
+ /**
+ * Filters array mapping
+ *
+ * @var array
+ */
+ protected $filters = [
+ 'date' => [
+ 'selector' => 'td[contains(@class,"col-period") and normalize-space(.)="%s"]',
+ ],
+ 'product' => [
+ 'selector' => 'td[contains(@class,"col-product") and normalize-space(.)="%s"]',
+ ],
+ 'price' => [
+ 'selector' => 'td[contains(@class,"col-price") and contains(.,"%s")]',
+ ],
+ 'orders' => [
+ 'selector' => 'td[contains(@class,"col-qty") and normalize-space(.)="%s"]',
+ ],
+ ];
+}
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/Constraint/AssertBestsellerReportResult.php b/dev/tests/functional/tests/app/Magento/Reports/Test/Constraint/AssertBestsellerReportResult.php
index 4be59b9b37994d6332be13ae41e8316f9a0ca9e9..3803f2b05a607930ade41bab6fa1cbc511bec9c8 100644
--- a/dev/tests/functional/tests/app/Magento/Reports/Test/Constraint/AssertBestsellerReportResult.php
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/Constraint/AssertBestsellerReportResult.php
@@ -30,20 +30,19 @@ use Magento\Reports\Test\Page\Adminhtml\Bestsellers;
use Magento\Catalog\Test\Fixture\CatalogProductSimple;
/**
- * Class AssertBestsellerReportResult
- * Assert bestseller info in report: date, product name and qty
+ * Assert bestseller info in report: date, product name and qty.
*/
class AssertBestsellerReportResult extends AbstractConstraint
{
/**
- * Constraint severeness
+ * Constraint severeness.
*
* @var string
*/
protected $severeness = 'low';
/**
- * Assert bestseller info in report: date, product name and qty
+ * Assert bestseller info in report: date, product name and qty.
*
* @param Bestsellers $bestsellers
* @param OrderInjectable $order
@@ -54,18 +53,24 @@ class AssertBestsellerReportResult extends AbstractConstraint
*/
public function processAssert(Bestsellers $bestsellers, OrderInjectable $order, $date)
{
- $products = $order->getEntityId()['products'];
- $totalQuantity = $bestsellers->getGridBlock()->getViewsResults($products, $date);
- $productQty = [];
- foreach ($products as $key => $product) {
- /** @var CatalogProductSimple $product*/
- $productQty[$key] = $product->getCheckoutData()['qty'];
- }
- \PHPUnit_Framework_Assert::assertEquals($productQty, $totalQuantity);
+ /** @var CatalogProductSimple $product */
+ $product = $order->getEntityId()['products'][0];
+
+ $filter = [
+ 'date' => date($date),
+ 'product' => $product->getName(),
+ 'price' => $product->getPrice(),
+ 'orders' => $product->getCheckoutData()['qty'],
+ ];
+
+ \PHPUnit_Framework_Assert::assertTrue(
+ $bestsellers->getGridBlock()->isRowVisible($filter),
+ 'Bestseller does not present in report grid.'
+ );
}
/**
- * Returns a string representation of the object
+ * Returns a string representation of the object.
*
* @return string
*/
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/Page/Adminhtml/Bestsellers.xml b/dev/tests/functional/tests/app/Magento/Reports/Test/Page/Adminhtml/Bestsellers.xml
index 60c537110ec2ff97388e79277fec48b3297ea5e7..0a0aef650c427abcea8739fc9ca749c07fba65be 100644
--- a/dev/tests/functional/tests/app/Magento/Reports/Test/Page/Adminhtml/Bestsellers.xml
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/Page/Adminhtml/Bestsellers.xml
@@ -31,7 +31,7 @@
<strategy>css selector</strategy>
</messagesBlock>
<actionsBlock>
- <class>Magento\Reports\Test\Block\Adminhtml\Product\Viewed\Action</class>
+ <class>Magento\Reports\Test\Block\Adminhtml\Viewed\Action</class>
<locator>.page-main-actions</locator>
<strategy>css selector</strategy>
</actionsBlock>
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/AbandonedCartsReportEntityTest.php b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/AbandonedCartsReportEntityTest.php
index 0bcee8ecb6e4be8d440610c70026b6a4554854d0..9693eb05eb03fe857a57dd13fa2b5f4ee7eb3b61 100644
--- a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/AbandonedCartsReportEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/AbandonedCartsReportEntityTest.php
@@ -27,30 +27,25 @@ namespace Magento\Reports\Test\TestCase;
use Mtf\Client\Browser;
use Mtf\TestCase\Injectable;
use Mtf\Fixture\FixtureFactory;
-use Magento\Cms\Test\Page\CmsIndex;
-use Magento\Customer\Test\Page\CustomerAccountLogin;
use Magento\Customer\Test\Fixture\CustomerInjectable;
use Magento\Catalog\Test\Fixture\CatalogProductSimple;
use Magento\Catalog\Test\Page\Product\CatalogProductView;
/**
- * Test Creation for AbandonedCartsReportEntity
- *
* Test Flow:
- *
* Preconditions:
- * 1. Create simple product
- * 2. Create customer
- * 3. Go to frontend
- * 4. Login as customer
- * 5. Add simple product to cart
- * 6. Logout
+ * 1. Create simple product.
+ * 2. Create customer.
+ * 3. Go to frontend.
+ * 4. Login as customer.
+ * 5. Add simple product to cart.
+ * 6. Logout.
*
* Steps:
- * 1. Open Backend
- * 2. Go to Reports > Abandoned Carts
- * 3. Click "Reset Filter"
- * 4. Perform all assertions
+ * 1. Open Backend.
+ * 2. Go to Reports > Abandoned Carts.
+ * 3. Click "Reset Filter".
+ * 4. Perform all assertions.
*
* @group Reports_(MX)
* @ZephyrId MAGETWO-28558
@@ -58,66 +53,46 @@ use Magento\Catalog\Test\Page\Product\CatalogProductView;
class AbandonedCartsReportEntityTest extends Injectable
{
/**
- * Cms Index page
- *
- * @var CmsIndex
- */
- protected $cmsIndex;
-
- /**
- * Customer Account Login page
- *
- * @var CustomerAccountLogin
- */
- protected $customerAccountLogin;
-
- /**
- * Catalog Product View page
+ * Catalog Product View page.
*
* @var CatalogProductView
*/
protected $catalogProductView;
/**
- * Browser interface
+ * Browser interface.
*
* @var Browser
*/
protected $browser;
/**
- * Fixture factory
+ * Fixture factory.
*
* @var FixtureFactory
*/
protected $fixtureFactory;
/**
- * Inject pages
+ * Inject pages.
*
- * @param CmsIndex $cmsIndex
- * @param CustomerAccountLogin $customerAccountLogin
* @param Browser $browser
* @param FixtureFactory $fixtureFactory
* @param CatalogProductView $catalogProductView
* @return void
*/
public function __inject(
- CmsIndex $cmsIndex,
- CustomerAccountLogin $customerAccountLogin,
Browser $browser,
FixtureFactory $fixtureFactory,
CatalogProductView $catalogProductView
) {
- $this->cmsIndex = $cmsIndex;
- $this->customerAccountLogin = $customerAccountLogin;
$this->browser = $browser;
$this->catalogProductView = $catalogProductView;
$this->fixtureFactory = $fixtureFactory;
}
/**
- * Create product and add it to cart
+ * Create product and add it to cart.
*
* @param string $products
* @param CustomerInjectable $customer
@@ -128,17 +103,21 @@ class AbandonedCartsReportEntityTest extends Injectable
// Precondition
$products = $this->createProducts($products);
$customer->persist();
- $this->cmsIndex->open();
- $this->cmsIndex->getLinksBlock()->openLink("Log In");
- $this->customerAccountLogin->getLoginBlock()->login($customer);
+ $this->objectManager->create(
+ 'Magento\Customer\Test\TestStep\LoginCustomerOnFrontendStep',
+ ['customer' => $customer]
+ )->run();
$this->addProductsToCart($products);
- $this->cmsIndex->getLinksBlock()->openLink("Log Out");
+ $this->objectManager->create(
+ 'Magento\Customer\Test\TestStep\LogoutCustomerOnFrontendStep',
+ ['customer' => $customer]
+ )->run();
return ['products' => $products];
}
/**
- * Create products
+ * Create products.
*
* @param string $products
* @return array
@@ -154,7 +133,7 @@ class AbandonedCartsReportEntityTest extends Injectable
}
/**
- * Add products to cart
+ * Add products to cart.
*
* @param array $products
* @return void
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/BestsellerProductsReportEntityTest.php b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/BestsellerProductsReportEntityTest.php
index 07d0094314248e40249408ceabad0f1053963451..9d3e3bdd4e0f3309ed5fc83ec8208ec05342d02b 100644
--- a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/BestsellerProductsReportEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/BestsellerProductsReportEntityTest.php
@@ -24,26 +24,25 @@
namespace Magento\Reports\Test\TestCase;
+use Mtf\ObjectManager;
use Mtf\TestCase\Injectable;
use Magento\Sales\Test\Fixture\OrderInjectable;
use Magento\Reports\Test\Page\Adminhtml\Bestsellers;
/**
- * Test Creation for BestsellerProductsReportEntity
- *
* Test Flow:
* Preconditions:
- * 1. Create customer
- * 2. Create product
- * 3. Place order
- * 4. Refresh statistic
+ * 1. Create customer.
+ * 2. Create product.
+ * 3. Place order.
+ * 4. Refresh statistic.
*
* Steps:
- * 1. Open Backend
- * 2. Go to Reports > Products > Bestsellers
- * 3. Select time range, report period
- * 4. Click "Show report"
- * 5. Perform all assertions
+ * 1. Open Backend.
+ * 2. Go to Reports > Products > Bestsellers.
+ * 3. Select time range, report period.
+ * 4. Click "Show report".
+ * 5. Perform all assertions.
*
* @group Reports_(MX)
* @ZephyrId MAGETWO-28222
@@ -51,14 +50,14 @@ use Magento\Reports\Test\Page\Adminhtml\Bestsellers;
class BestsellerProductsReportEntityTest extends Injectable
{
/**
- * Bestsellers page
+ * Bestsellers page.
*
* @var Bestsellers
*/
protected $bestsellers;
/**
- * Inject pages
+ * Inject pages.
*
* @param Bestsellers $bestsellers
* @return void
@@ -69,7 +68,7 @@ class BestsellerProductsReportEntityTest extends Injectable
}
/**
- * Bestseller Products Report
+ * Bestseller Products Report.
*
* @param OrderInjectable $order
* @param array $bestsellerReport
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/DownloadProductsReportEntityTest.php b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/DownloadProductsReportEntityTest.php
index 3f3d10f02cf5e177a3b852ef5dddec0f06ea9939..6d6ed8774d640dda2c91a1ea5e74a6fab7b5b34f 100644
--- a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/DownloadProductsReportEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/DownloadProductsReportEntityTest.php
@@ -31,8 +31,6 @@ use Mtf\Client\Browser;
use Magento\Sales\Test\Fixture\OrderInjectable;
/**
- * Test Creation for DownloadProductsReportEntity
- *
* Test Flow:
*
* Preconditions:
@@ -53,31 +51,32 @@ use Magento\Sales\Test\Fixture\OrderInjectable;
class DownloadProductsReportEntityTest extends Injectable
{
/**
- * Browser Interface
+ * Browser Interface.
*
* @var Browser
*/
protected $browser;
/**
- * Customer Account index page
+ * Customer Account index page.
*
* @var CustomerAccountIndex
*/
protected $customerAccount;
/**
- * Downloadable Customer Products page
+ * Downloadable Customer Products page.
*
* @var DownloadableCustomerProducts
*/
protected $customerProducts;
/**
- * Inject pages
+ * Inject pages.
*
* @param CustomerAccountIndex $customerAccount
* @param DownloadableCustomerProducts $customerProducts
+ * @param Browser $browser
* @return void
*/
public function __inject(
@@ -91,7 +90,7 @@ class DownloadProductsReportEntityTest extends Injectable
}
/**
- * Order downloadable product
+ * Order downloadable product.
*
* @param OrderInjectable $order
* @param string $downloads
@@ -99,6 +98,7 @@ class DownloadProductsReportEntityTest extends Injectable
*/
public function test(OrderInjectable $order, $downloads)
{
+ $this->markTestIncomplete('MAGETWO-30346');
// Preconditions
$order->persist();
$invoice = $this->objectManager->create('Magento\Sales\Test\TestStep\CreateInvoiceStep', ['order' => $order]);
@@ -107,7 +107,7 @@ class DownloadProductsReportEntityTest extends Injectable
}
/**
- * Open Downloadable Link
+ * Open Downloadable Link.
*
* @param OrderInjectable $order
* @param int $downloads
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/NewAccountsReportEntityTest.php b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/NewAccountsReportEntityTest.php
index 1c80e538e06f6e82f5e810598d1f18b8e837c33a..f1e648e5c1727916ba13b859347d85a27a9840e4 100644
--- a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/NewAccountsReportEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/NewAccountsReportEntityTest.php
@@ -30,19 +30,17 @@ use Magento\Customer\Test\Page\Adminhtml\CustomerIndex;
use Magento\Reports\Test\Page\Adminhtml\CustomerAccounts;
/**
- * Test Creation for NewAccountsReportEntity
- *
* Test Flow:
* Preconditions:
- * 1. Delete all existing customers
- * 2. Create customer
+ * 1. Delete all existing customers.
+ * 2. Create customer.
*
* Steps:
- * 1. Open Backend
- * 2. Go to Reports> Customers> New
- * 3. Select time range and report period
- * 4. Click "Refresh button"
- * 5. Perform all assertions
+ * 1. Open Backend.
+ * 2. Go to Reports> Customers> New.
+ * 3. Select time range and report period.
+ * 4. Click "Refresh button".
+ * 5. Perform all assertions.
*
* @group Reports_(MX)
* @ZephyrId MAGETWO-27742
@@ -50,21 +48,21 @@ use Magento\Reports\Test\Page\Adminhtml\CustomerAccounts;
class NewAccountsReportEntityTest extends Injectable
{
/**
- * Customer Accounts pages
+ * Customer Accounts pages.
*
* @var CustomerAccounts
*/
protected $customerAccounts;
/**
- * Customer index pages
+ * Customer index pages.
*
* @var CustomerIndex
*/
protected $customerIndexPage;
/**
- * Inject pages
+ * Inject pages.
*
* @param CustomerIndex $customerIndexPage
* @param CustomerAccounts $customerAccounts
@@ -77,7 +75,7 @@ class NewAccountsReportEntityTest extends Injectable
}
/**
- * New Accounts Report
+ * New Accounts Report.
*
* @param CustomerInjectable $customer
* @param array $customersReport
@@ -85,6 +83,7 @@ class NewAccountsReportEntityTest extends Injectable
*/
public function test(CustomerInjectable $customer, array $customersReport)
{
+ $this->markTestIncomplete('MAGETWO-26663');
// Preconditions
$this->customerIndexPage->open();
$this->customerIndexPage->getCustomerGridBlock()->massaction([], 'Delete', true, 'Select All');
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SalesTaxReportEntityTest.php b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SalesTaxReportEntityTest.php
index 2b00e211cc4bb88204075b830e8ae0de914ae44a..be5444512ba9067adf4566983f1abb6a5007c9db 100644
--- a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SalesTaxReportEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SalesTaxReportEntityTest.php
@@ -36,23 +36,21 @@ use Magento\Sales\Test\Page\Adminhtml\OrderInvoiceNew;
use Magento\Reports\Test\Page\Adminhtml\SalesTaxReport;
/**
- * Test Creation for SalesTaxReportEntity
- *
* Test Flow:
*
* Preconditions:
- * 1. Product is created
- * 2. Customer is created
- * 3. Tax Rule is created
- * 4. Order is placed
- * 5. Refresh statistic
+ * 1. Product is created.
+ * 2. Customer is created.
+ * 3. Tax Rule is created.
+ * 4. Order is placed.
+ * 5. Refresh statistic.
*
* Steps:
- * 1. Login to backend
- * 2. Go to Reports > Sales > Tax
- * 3. Fill data from dataSet
- * 4. Click "Show report"
- * 5. Perform all assertions
+ * 1. Login to backend.
+ * 2. Go to Reports > Sales > Tax.
+ * 3. Fill data from dataSet.
+ * 4. Click "Show report".
+ * 5. Perform all assertions.
*
* @group Reports_(MX)
* @ZephyrId MAGETWO-28515
@@ -62,63 +60,63 @@ use Magento\Reports\Test\Page\Adminhtml\SalesTaxReport;
class SalesTaxReportEntityTest extends Injectable
{
/**
- * Order index page
+ * Order index page.
*
* @var OrderIndex
*/
protected $orderIndex;
/**
- * Order invoice new page
+ * Order invoice new page.
*
* @var OrderInvoiceNew
*/
protected $orderInvoiceNew;
/**
- * Sales tax report page
+ * Sales tax report page.
*
* @var SalesTaxReport
*/
protected $salesTaxReport;
/**
- * Order view page
+ * Order view page.
*
* @var OrderView
*/
protected $orderView;
/**
- * Report statistic page
+ * Report statistic page.
*
* @var Statistics
*/
protected $reportStatistic;
/**
- * Tax Rule grid page
+ * Tax Rule grid page.
*
* @var TaxRuleIndex
*/
protected $taxRuleIndexPage;
/**
- * Tax Rule new and edit page
+ * Tax Rule new and edit page.
*
* @var TaxRuleNew
*/
protected $taxRuleNewPage;
/**
- * Tax Rule fixture
+ * Tax Rule fixture.
*
* @var TaxRule
*/
protected $taxRule;
/**
- * Delete all tax rules
+ * Delete all tax rules.
*
* @return void
*/
@@ -129,7 +127,7 @@ class SalesTaxReportEntityTest extends Injectable
}
/**
- * Injection data
+ * Injection data.
*
* @param OrderIndex $orderIndex
* @param OrderInvoiceNew $orderInvoiceNew
@@ -159,7 +157,7 @@ class SalesTaxReportEntityTest extends Injectable
}
/**
- * Create tax report entity
+ * Create tax report entity.
*
* @param OrderInjectable $order
* @param TaxRule $taxRule
@@ -183,7 +181,7 @@ class SalesTaxReportEntityTest extends Injectable
$this->orderIndex->getSalesOrderGrid()->searchAndOpen(['id' => $order->getId()]);
if ($orderStatus !== 'Pending') {
$createInvoice = $this->objectManager->create(
- 'Magento\Sales\Test\TestStep\CreateInvoice',
+ 'Magento\Sales\Test\TestStep\CreateInvoiceStep',
['order' => $order, 'data' => $invoice]
);
$createInvoice->run();
@@ -202,7 +200,7 @@ class SalesTaxReportEntityTest extends Injectable
}
/**
- * Delete all tax rules after test
+ * Delete all tax rules after test.
*
* @return void
*/
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SearchTermsReportEntityTest.php b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SearchTermsReportEntityTest.php
index 92b5ce26a8a18d66c39f826e732cc739b4eedd08..e843ae13c373b574e8ee547dd860818363bf2fc9 100644
--- a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SearchTermsReportEntityTest.php
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SearchTermsReportEntityTest.php
@@ -28,11 +28,8 @@ use Mtf\TestCase\Injectable;
use Mtf\Fixture\FixtureFactory;
use Magento\Cms\Test\Page\CmsIndex;
use Magento\Reports\Test\Page\Adminhtml\SearchIndex;
-use Magento\Catalog\Test\Fixture\CatalogProductSimple;
/**
- * Test Creation for SearchTermsReportEntity
- *
* Test Flow:
* Preconditions:
* 1. Products is created.
@@ -49,28 +46,28 @@ use Magento\Catalog\Test\Fixture\CatalogProductSimple;
class SearchTermsReportEntityTest extends Injectable
{
/**
- * Index page
+ * Index page.
*
* @var CmsIndex
*/
protected $cmsIndex;
/**
- * Search Index page
+ * Search Index page.
*
* @var SearchIndex
*/
protected $searchIndex;
/**
- * FixtureFactory
+ * FixtureFactory.
*
* @var FixtureFactory
*/
protected $fixtureFactory;
/**
- * Inject pages
+ * Inject pages.
*
* @param CmsIndex $cmsIndex
* @param SearchIndex $searchIndex
@@ -85,15 +82,16 @@ class SearchTermsReportEntityTest extends Injectable
}
/**
- * Search Terms Report
+ * Search Terms Report.
*
- * @param CatalogProductSimple $product
+ * @param string $product
* @param int $countProducts
* @param int $countSearch
* @return array
*/
- public function test(CatalogProductSimple $product, $countProducts, $countSearch)
+ public function test($product, $countProducts, $countSearch)
{
+ $this->markTestIncomplete('MAGETWO-30246');
// Preconditions
$productName = $this->createProducts($product, $countProducts);
@@ -106,22 +104,27 @@ class SearchTermsReportEntityTest extends Injectable
}
/**
- * Create products
+ * Create products.
*
- * @param CatalogProductSimple $product
+ * @param string $product
* @param int $countProduct
* @return string
*/
- protected function createProducts(CatalogProductSimple $product, $countProduct)
+ protected function createProducts($product, $countProduct)
{
+ $name = 'simpleProductName' . mt_rand();
for ($i = 0; $i < $countProduct; $i++) {
- $product->persist();
+ $productFixture = $this->fixtureFactory->createByCode(
+ 'catalogProductSimple',
+ ['dataSet' => $product, 'data' => ['name' => $name]]
+ );
+ $productFixture->persist();
}
- return $product->getName();
+ return $name;
}
/**
- * Search products
+ * Search products.
*
* @param string $productName
* @param int $countSearch
diff --git a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SearchTermsReportEntityTest/test.csv b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SearchTermsReportEntityTest/test.csv
index 20bf7a1572c5af2e11fb21433949ef99481fb248..358959eb2d8ec24874fd675c33fb217fb624bb13 100644
--- a/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SearchTermsReportEntityTest/test.csv
+++ b/dev/tests/functional/tests/app/Magento/Reports/Test/TestCase/SearchTermsReportEntityTest/test.csv
@@ -1,3 +1,3 @@
-"product/dataSet";"countProducts";"countSearch";"constraint"
-"100_dollar_product";"1";"2";"assertSearchTermsInGrid, assertSearchTermReportForm"
-"100_dollar_product";"3";"1";"assertSearchTermsInGrid, assertSearchTermReportForm"
\ No newline at end of file
+"product";"countProducts";"countSearch";"constraint"
+"product_with_url_key";"1";"2";"assertSearchTermsInGrid, assertSearchTermReportForm"
+"product_with_url_key";"3";"1";"assertSearchTermsInGrid, assertSearchTermReportForm"
\ No newline at end of file
diff --git a/dev/tests/functional/tests/app/Magento/UrlRewrite/Test/Page/Adminhtml/UrlRewriteIndex.xml b/dev/tests/functional/tests/app/Magento/UrlRewrite/Test/Page/Adminhtml/UrlRewriteIndex.xml
index 87bfa9c5d10cf23d57ad193f6eec0863323151eb..6747e249752d3494a9be1ae5dc97205ffb1f340e 100644
--- a/dev/tests/functional/tests/app/Magento/UrlRewrite/Test/Page/Adminhtml/UrlRewriteIndex.xml
+++ b/dev/tests/functional/tests/app/Magento/UrlRewrite/Test/Page/Adminhtml/UrlRewriteIndex.xml
@@ -1,6 +1,6 @@
-<?xml version="1.0" ?>
-<!--
-/**
+<?xml version="1.0" ?>
+<!--
+/**
* Magento
*
* NOTICE OF LICENSE
@@ -17,28 +17,28 @@
*
* Do not edit or add to this file if you wish to upgrade Magento to newer
* versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0)
- */
--->
-<page mca="admin/url_rewrite/index" module="Magento_UrlRewrite">
- <blocks>
- <pageActionsBlock>
- <class>Magento\Backend\Test\Block\GridPageActions</class>
- <locator>.page-main-actions</locator>
- <strategy>css selector</strategy>
- </pageActionsBlock>
- <urlRedirectGrid>
- <class>Magento\UrlRewrite\Test\Block\Adminhtml\Catalog\Category\Grid</class>
- <locator>#urlrewriteGrid</locator>
- <strategy>css selector</strategy>
- </urlRedirectGrid>
- <messagesBlock>
- <class>Magento\Core\Test\Block\Messages</class>
- <locator>.messages .messages</locator>
- <strategy>css selector</strategy>
- </messagesBlock>
- </blocks>
-</page>
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/afl-3.0.php Academic Free License (AFL 3.0)
+ */
+-->
+<page mca="admin/url_rewrite/index" module="Magento_UrlRewrite">
+ <blocks>
+ <pageActionsBlock>
+ <class>Magento\Backend\Test\Block\GridPageActions</class>
+ <locator>.page-main-actions</locator>
+ <strategy>css selector</strategy>
+ </pageActionsBlock>
+ <urlRedirectGrid>
+ <class>Magento\UrlRewrite\Test\Block\Adminhtml\Catalog\Category\Grid</class>
+ <locator>#urlrewriteGrid</locator>
+ <strategy>css selector</strategy>
+ </urlRedirectGrid>
+ <messagesBlock>
+ <class>Magento\Core\Test\Block\Messages</class>
+ <locator>.messages .messages</locator>
+ <strategy>css selector</strategy>
+ </messagesBlock>
+ </blocks>
+</page>
diff --git a/dev/tests/functional/utils/bootstrap.php b/dev/tests/functional/utils/bootstrap.php
index e750996917f9606688f84c8af858b38ba13e9311..7456972c38301f1fb7daf9aea7a5692bebb3d560 100644
--- a/dev/tests/functional/utils/bootstrap.php
+++ b/dev/tests/functional/utils/bootstrap.php
@@ -28,17 +28,9 @@ $mtfRoot = str_replace('\\', '/', $mtfRoot);
define('MTF_BP', $mtfRoot);
define('MTF_TESTS_PATH', MTF_BP . '/tests/app/');
-$path = get_include_path();
-$path = rtrim($path, PATH_SEPARATOR);
-$path .= PATH_SEPARATOR . MTF_BP . '/lib';
-$path .= PATH_SEPARATOR . MTF_BP . '/vendor/magento/mtf';
-$path .= PATH_SEPARATOR . MTF_BP . '/vendor/magento/mtf/lib';
-set_include_path($path);
-
$appRoot = dirname(dirname(dirname(dirname(__DIR__))));
require $appRoot . '/app/bootstrap.php';
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
+require __DIR__ . '/../vendor/autoload.php';
$objectManagerFactory = \Magento\Framework\App\Bootstrap::createObjectManagerFactory(BP, $_SERVER);
$objectManager = $objectManagerFactory->create($_SERVER);
diff --git a/dev/tests/functional/utils/generate/factory.php b/dev/tests/functional/utils/generate/factory.php
index 6c5801a9e53fc429397e76580f23257f0be6a69a..55d04d2901301163e92c4267a3fce9755e66968c 100644
--- a/dev/tests/functional/utils/generate/factory.php
+++ b/dev/tests/functional/utils/generate/factory.php
@@ -22,25 +22,15 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-require __DIR__ . '/../../../../../app/bootstrap.php';
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
-$bootstrap = \Magento\Framework\App\Bootstrap::create(BP, $_SERVER);
-
$mtfRoot = dirname(dirname(dirname(__FILE__)));
$mtfRoot = str_replace('\\', '/', $mtfRoot);
define('MTF_BP', $mtfRoot);
define('MTF_TESTS_PATH', MTF_BP . '/tests/app/');
-$paths = [
- MTF_BP,
- MTF_BP . '/lib',
- MTF_BP . '/tests/app',
- MTF_BP . '/generated',
- MTF_BP . '/vendor/magento/mtf',
- MTF_BP . '/vendor/phpunit/phpunit'
-];
-$includePath->addIncludePath($paths);
+require __DIR__ . '/../../../../../app/bootstrap.php';
+require MTF_BP . '/vendor/autoload.php';
+
+$bootstrap = \Magento\Framework\App\Bootstrap::create(BP, $_SERVER);
$om = $bootstrap->getObjectManager();
/** @var \Mtf\Util\Generate\Factory $generator */
diff --git a/dev/tests/functional/utils/generate/page.php b/dev/tests/functional/utils/generate/page.php
index b9f0ab521fa27227444bc387146a2092afdbb105..d76362dc642681f3e7dc9ebb8767d0432e2f9597 100644
--- a/dev/tests/functional/utils/generate/page.php
+++ b/dev/tests/functional/utils/generate/page.php
@@ -22,7 +22,5 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
require_once dirname(__DIR__) . '/' . 'bootstrap.php';
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
$objectManager->create('Mtf\Util\Generate\Page')->launch();
\Mtf\Util\Generate\GenerateResult::displayResults();
diff --git a/dev/tests/integration/framework/Magento/TestFramework/Application.php b/dev/tests/integration/framework/Magento/TestFramework/Application.php
index ee6bd6742fccde0f5a97b7e8e7b11dc3c53139dd..5bd405fcb86d48455b33638817e2d0cec5efb868 100644
--- a/dev/tests/integration/framework/Magento/TestFramework/Application.php
+++ b/dev/tests/integration/framework/Magento/TestFramework/Application.php
@@ -23,7 +23,7 @@
*/
namespace Magento\TestFramework;
-use Magento\Framework\Code\Generator\FileResolver;
+use Magento\Framework\Autoload\AutoloaderInterface;
use Magento\Framework\Filesystem;
use Magento\Framework\App\Filesystem\DirectoryList;
@@ -86,7 +86,7 @@ class Application
*
* @var string
*/
- protected $_tmpDir;
+ protected $installDir;
/**
* Installation destination directory with configuration files
@@ -139,6 +139,7 @@ class Application
* @param string $appMode
* @param string $tmpDir
* @param \Magento\Framework\Shell $shell
+ * @param AutoloaderInterface $autoloadWrapper
* @return Application
*/
public static function getInstance(
@@ -147,21 +148,22 @@ class Application
array $moduleConfigFiles,
$appMode,
$tmpDir,
- \Magento\Framework\Shell $shell
+ \Magento\Framework\Shell $shell,
+ AutoloaderInterface $autoloadWrapper
) {
if (!file_exists($installConfigFile)) {
$installConfigFile = $installConfigFile . '.dist';
}
$sandboxUniqueId = md5(sha1_file($installConfigFile));
$installDir = "{$tmpDir}/sandbox-{$sandboxUniqueId}";
- FileResolver::addIncludePath($installDir . '/var/generation/');
return new \Magento\TestFramework\Application(
$shell,
$installDir,
$installConfigFile,
$globalConfigDir,
$moduleConfigFiles,
- $appMode
+ $appMode,
+ $autoloadWrapper
);
}
@@ -169,31 +171,32 @@ class Application
* Constructor
*
* @param \Magento\Framework\Shell $shell
- * @param string $tmpDir
+ * @param string $installDir
* @param array $installConfigFile
* @param string $globalConfigDir
* @param array $moduleEtcFiles
* @param string $appMode
+ * @param AutoloaderInterface $autoloadWrapper
*/
public function __construct(
\Magento\Framework\Shell $shell,
- $tmpDir,
+ $installDir,
$installConfigFile,
$globalConfigDir,
array $moduleEtcFiles,
- $appMode
+ $appMode,
+ AutoloaderInterface $autoloadWrapper
) {
$this->_shell = $shell;
$this->installConfigFile = $installConfigFile;
$this->_globalConfigDir = realpath($globalConfigDir);
$this->_moduleEtcFiles = $moduleEtcFiles;
$this->_appMode = $appMode;
-
- $this->_tmpDir = $tmpDir;
+ $this->installDir = $installDir;
$customDirs = $this->getCustomDirs();
$dirList = new \Magento\Framework\App\Filesystem\DirectoryList(BP, $customDirs);
-
+ \Magento\Framework\Autoload\Populator::populateMappings($autoloadWrapper, $dirList);
$this->_initParams = array(
\Magento\Framework\App\Bootstrap::INIT_PARAM_FILESYSTEM_DIR_PATHS => $customDirs,
\Magento\Framework\App\State::PARAM_MODE => $appMode
@@ -268,7 +271,7 @@ class Application
*/
public function getTempDir()
{
- return $this->_tmpDir;
+ return $this->installDir;
}
/**
@@ -404,7 +407,7 @@ class Application
public function install()
{
$dirs = \Magento\Framework\App\Bootstrap::INIT_PARAM_FILESYSTEM_DIR_PATHS;
- $this->_ensureDirExists($this->_tmpDir);
+ $this->_ensureDirExists($this->installDir);
$this->_ensureDirExists($this->_configDir);
$this->_ensureDirExists($this->_initParams[$dirs][DirectoryList::MEDIA][DirectoryList::PATH]);
$this->_ensureDirExists($this->_initParams[$dirs][DirectoryList::STATIC_VIEW][DirectoryList::PATH]);
@@ -588,12 +591,12 @@ class Application
protected function getCustomDirs()
{
$path = DirectoryList::PATH;
- $var = "{$this->_tmpDir}/var";
+ $var = "{$this->installDir}/var";
$customDirs = array(
- DirectoryList::CONFIG => array($path => "{$this->_tmpDir}/etc"),
+ DirectoryList::CONFIG => array($path => "{$this->installDir}/etc"),
DirectoryList::VAR_DIR => array($path => $var),
- DirectoryList::MEDIA => array($path => "{$this->_tmpDir}/media"),
- DirectoryList::STATIC_VIEW => array($path => "{$this->_tmpDir}/pub_static"),
+ DirectoryList::MEDIA => array($path => "{$this->installDir}/media"),
+ DirectoryList::STATIC_VIEW => array($path => "{$this->installDir}/pub_static"),
DirectoryList::GENERATION => array($path => "{$var}/generation"),
DirectoryList::CACHE => array($path => "{$var}/cache"),
DirectoryList::LOG => array($path => "{$var}/log"),
diff --git a/dev/tests/integration/framework/Magento/TestFramework/Helper/Bootstrap.php b/dev/tests/integration/framework/Magento/TestFramework/Helper/Bootstrap.php
index d17e8ffd5585628e9d2606e2b15e6221ce573e7e..4fef2c4009a2dd902173b7322d13f7811fe82836 100644
--- a/dev/tests/integration/framework/Magento/TestFramework/Helper/Bootstrap.php
+++ b/dev/tests/integration/framework/Magento/TestFramework/Helper/Bootstrap.php
@@ -35,7 +35,7 @@ class Bootstrap
private static $_instance;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private static $_objectManager;
@@ -138,7 +138,7 @@ class Bootstrap
/**
* Retrieve object manager
*
- * @return \Magento\Framework\ObjectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*/
public static function getObjectManager()
{
@@ -148,9 +148,9 @@ class Bootstrap
/**
* Set object manager
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public static function setObjectManager(\Magento\Framework\ObjectManager $objectManager)
+ public static function setObjectManager(\Magento\Framework\ObjectManagerInterface $objectManager)
{
self::$_objectManager = $objectManager;
}
diff --git a/dev/tests/integration/framework/Magento/TestFramework/Interception/PluginList.php b/dev/tests/integration/framework/Magento/TestFramework/Interception/PluginList.php
index e0cd236bc592f1539d74a7834515d72fbca37d6e..64e5e41ef019d1d6a50dc11ba9600c0f6a0379b2 100644
--- a/dev/tests/integration/framework/Magento/TestFramework/Interception/PluginList.php
+++ b/dev/tests/integration/framework/Magento/TestFramework/Interception/PluginList.php
@@ -34,11 +34,11 @@ class PluginList extends \Magento\Framework\Interception\PluginList\PluginList
* @param \Magento\Framework\Config\ReaderInterface $reader
* @param \Magento\Framework\Config\ScopeInterface $configScope
* @param \Magento\Framework\Config\CacheInterface $cache
- * @param \Magento\Framework\ObjectManager\Relations $relations
- * @param \Magento\Framework\ObjectManager\Config $omConfig
- * @param \Magento\Framework\Interception\Definition $definitions
- * @param \Magento\Framework\ObjectManager $objectManager
- * @param \Magento\Framework\ObjectManager\Definition $classDefinitions
+ * @param \Magento\Framework\ObjectManager\RelationsInterface $relations
+ * @param \Magento\Framework\ObjectManager\ConfigInterface $omConfig
+ * @param \Magento\Framework\Interception\DefinitionInterface $definitions
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
+ * @param \Magento\Framework\ObjectManager\DefinitionInterface $classDefinitions
* @param array $scopePriorityScheme
* @param string $cacheId
*
@@ -48,11 +48,11 @@ class PluginList extends \Magento\Framework\Interception\PluginList\PluginList
\Magento\Framework\Config\ReaderInterface $reader,
\Magento\Framework\Config\ScopeInterface $configScope,
\Magento\Framework\Config\CacheInterface $cache,
- \Magento\Framework\ObjectManager\Relations $relations,
- \Magento\Framework\ObjectManager\Config $omConfig,
- \Magento\Framework\Interception\Definition $definitions,
- \Magento\Framework\ObjectManager $objectManager,
- \Magento\Framework\ObjectManager\Definition $classDefinitions,
+ \Magento\Framework\ObjectManager\RelationsInterface $relations,
+ \Magento\Framework\ObjectManager\ConfigInterface $omConfig,
+ \Magento\Framework\Interception\DefinitionInterface $definitions,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
+ \Magento\Framework\ObjectManager\DefinitionInterface $classDefinitions,
array $scopePriorityScheme,
$cacheId = 'plugins'
) {
diff --git a/dev/tests/integration/framework/Magento/TestFramework/ObjectManager.php b/dev/tests/integration/framework/Magento/TestFramework/ObjectManager.php
index f5d87c12b21d75cf9b01908adaf7d1aa3e2bdcba..a62ab370a52eef453d146593f0e0c2c07f6c9a5b 100644
--- a/dev/tests/integration/framework/Magento/TestFramework/ObjectManager.php
+++ b/dev/tests/integration/framework/Magento/TestFramework/ObjectManager.php
@@ -40,10 +40,10 @@ class ObjectManager extends \Magento\Framework\App\ObjectManager
protected $persistedInstances = array(
'Magento\Framework\App\Resource',
'Magento\Framework\Config\Scope',
- 'Magento\Framework\ObjectManager\Relations',
- 'Magento\Framework\ObjectManager\Config',
- 'Magento\Framework\Interception\Definition',
- 'Magento\Framework\ObjectManager\Definition',
+ 'Magento\Framework\ObjectManager\RelationsInterface',
+ 'Magento\Framework\ObjectManager\ConfigInterface',
+ 'Magento\Framework\Interception\DefinitionInterface',
+ 'Magento\Framework\ObjectManager\DefinitionInterface',
'Magento\Framework\Session\Config',
'Magento\Framework\ObjectManager\Config\Mapper\Dom'
);
@@ -63,7 +63,7 @@ class ObjectManager extends \Magento\Framework\App\ObjectManager
\Magento\Framework\App\Config\Base::destroy();
$sharedInstances = array(
- 'Magento\Framework\ObjectManager' => $this,
+ 'Magento\Framework\ObjectManagerInterface' => $this,
'Magento\Framework\App\ObjectManager' => $this
);
foreach ($this->persistedInstances as $persistedClass) {
@@ -101,16 +101,16 @@ class ObjectManager extends \Magento\Framework\App\ObjectManager
/**
* Set objectManager
*
- * @param \Magento\Framework\ObjectManager $objectManager
- * @return \Magento\Framework\ObjectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*/
- public static function setInstance(\Magento\Framework\ObjectManager $objectManager)
+ public static function setInstance(\Magento\Framework\ObjectManagerInterface $objectManager)
{
return self::$_instance = $objectManager;
}
/**
- * @return \Magento\Framework\ObjectManager\Factory|\Magento\Framework\ObjectManager\Factory\Factory
+ * @return \Magento\Framework\ObjectManager\FactoryInterface|\Magento\Framework\ObjectManager\Factory\Factory
*/
public function getFactory()
{
diff --git a/dev/tests/integration/framework/Magento/TestFramework/ObjectManager/Configurator.php b/dev/tests/integration/framework/Magento/TestFramework/ObjectManager/Configurator.php
index 7e651f27d33972b38c1c2e052856521aa8fb9129..b6a744a443f8fc7ec20e5f936c908833d87f8a50 100644
--- a/dev/tests/integration/framework/Magento/TestFramework/ObjectManager/Configurator.php
+++ b/dev/tests/integration/framework/Magento/TestFramework/ObjectManager/Configurator.php
@@ -35,7 +35,7 @@ class Configurator implements \Magento\Framework\ObjectManager\DynamicConfigInte
return [
'preferences' => [
'Magento\Framework\Stdlib\Cookie' => 'Magento\TestFramework\Cookie',
- 'Magento\Framework\Stdlib\CookieManager' => 'Magento\TestFramework\CookieManager',
+ 'Magento\Framework\Stdlib\CookieManagerInterface' => 'Magento\TestFramework\CookieManager',
]
];
}
diff --git a/dev/tests/integration/framework/Magento/TestFramework/ObjectManagerFactory.php b/dev/tests/integration/framework/Magento/TestFramework/ObjectManagerFactory.php
index ee2e73c006238ddf549b3d658cbbd825939ad1d0..bee927c691a6670dba8a7c865a9b4005a8d17929 100644
--- a/dev/tests/integration/framework/Magento/TestFramework/ObjectManagerFactory.php
+++ b/dev/tests/integration/framework/Magento/TestFramework/ObjectManagerFactory.php
@@ -101,7 +101,7 @@ class ObjectManagerFactory extends \Magento\Framework\App\ObjectManagerFactory
$this->factory->setArguments($appArguments->get());
$objectManager->addSharedInstance($appArguments, 'Magento\Framework\App\Arguments');
- $objectManager->get('Magento\Framework\Interception\PluginList')->reset();
+ $objectManager->get('Magento\Framework\Interception\PluginListInterface')->reset();
$objectManager->configure(
$objectManager->get('Magento\Framework\App\ObjectManager\ConfigLoader')->load('global')
);
@@ -130,7 +130,7 @@ class ObjectManagerFactory extends \Magento\Framework\App\ObjectManagerFactory
$this->_primaryConfigData['preferences'] = array_replace(
$this->_primaryConfigData['preferences'],
[
- 'Magento\Framework\Stdlib\CookieManager' => 'Magento\TestFramework\CookieManager',
+ 'Magento\Framework\Stdlib\CookieManagerInterface' => 'Magento\TestFramework\CookieManager',
'Magento\Framework\ObjectManager\DynamicConfigInterface' =>
'\Magento\TestFramework\ObjectManager\Configurator',
'Magento\Framework\Stdlib\Cookie' => 'Magento\TestFramework\Cookie',
@@ -138,7 +138,8 @@ class ObjectManagerFactory extends \Magento\Framework\App\ObjectManagerFactory
'Magento\Framework\App\Request\Http' => 'Magento\TestFramework\Request',
'Magento\Framework\App\ResponseInterface' => 'Magento\TestFramework\Response',
'Magento\Framework\App\Response\Http' => 'Magento\TestFramework\Response',
- 'Magento\Framework\Interception\PluginList' => 'Magento\TestFramework\Interception\PluginList',
+ 'Magento\Framework\Interception\PluginListInterface'
+ => 'Magento\TestFramework\Interception\PluginList',
'Magento\Framework\Interception\ObjectManager\Config' =>
'Magento\TestFramework\ObjectManager\Config',
'Magento\Framework\View\LayoutInterface' => 'Magento\TestFramework\View\Layout',
diff --git a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.2.0.2-1.6.2.0.3.php b/dev/tests/integration/framework/autoload.php
similarity index 71%
rename from app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.2.0.2-1.6.2.0.3.php
rename to dev/tests/integration/framework/autoload.php
index c1a1a2dc157d979ec580226b1023a3a1d0e8bef9..bdf12664e9a068019ecc2c5c4f3c7013b78eab4b 100644
--- a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.2.0.2-1.6.2.0.3.php
+++ b/dev/tests/integration/framework/autoload.php
@@ -21,13 +21,10 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
+require_once __DIR__ . '/../../../../app/autoload.php';
-/** @var $installer \Magento\Customer\Model\Resource\Setup */
-$installer = $this;
+$testsBaseDir = dirname(__DIR__);
+$autoloadWrapper = \Magento\Framework\Autoload\AutoloaderRegistry::getAutoloader();
-$installer->cleanCache();
-
-$entities = $installer->getDefaultEntities();
-foreach ($entities as $entityName => $entity) {
- $installer->addEntityType($entityName, $entity);
-}
+$autoloadWrapper->addPsr4('Magento\\TestFramework\\', "{$testsBaseDir}/framework/Magento/TestFramework/");
+$autoloadWrapper->addPsr4('Magento\\', "{$testsBaseDir}/testsuite/Magento/");
diff --git a/dev/tests/integration/framework/bootstrap.php b/dev/tests/integration/framework/bootstrap.php
index 45a5ff876434057a4f6d8892a06652c9bf2d99bd..d91a2db07d2efaa25b277b2d821509645a214f41 100644
--- a/dev/tests/integration/framework/bootstrap.php
+++ b/dev/tests/integration/framework/bootstrap.php
@@ -21,38 +21,18 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
+
+use Magento\Framework\Autoload\AutoloaderRegistry;
+
require_once __DIR__ . '/../../../../app/bootstrap.php';
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
require_once __DIR__ . '/../../static/framework/Magento/TestFramework/Utility/Classes.php';
require_once __DIR__ . '/../../static/framework/Magento/TestFramework/Utility/AggregateInvoker.php';
+require_once __DIR__ . '/autoload.php';
$testsBaseDir = dirname(__DIR__);
$testsTmpDir = "{$testsBaseDir}/tmp";
$magentoBaseDir = realpath("{$testsBaseDir}/../../../");
-$includePath->addIncludePath(
- array("{$testsBaseDir}/framework", "{$testsBaseDir}/testsuite")
-);
-
-function tool_autoloader($className)
-{
- if (strpos($className, 'Magento\\Tools\\') === false) {
- return false;
- }
-
- $filePath = str_replace('\\', '/', $className);
- $filePath = BP . '/dev/tools/' . $filePath . '.php';
-
- if (file_exists($filePath)) {
- include_once $filePath;
- } else {
- return false;
- }
-}
-
-spl_autoload_register('tool_autoloader');
-
try {
/* Bootstrap the application */
$settings = new \Magento\TestFramework\Bootstrap\Settings($testsBaseDir, get_defined_constants());
@@ -71,7 +51,8 @@ try {
$settings->getAsMatchingPaths('TESTS_MODULE_CONFIG_FILES'),
$settings->get('TESTS_MAGENTO_MODE'),
$testsTmpDir,
- $shell
+ $shell,
+ AutoloaderRegistry::getAutoloader()
);
$bootstrap = new \Magento\TestFramework\Bootstrap(
diff --git a/dev/tests/integration/framework/tests/unit/framework/bootstrap.php b/dev/tests/integration/framework/tests/unit/framework/bootstrap.php
index 5c7d9ac968d19abf6a1a96febc00fa2ffab64968..31185a85b0767ae4d5026e6a1b088bfe55cf23fe 100644
--- a/dev/tests/integration/framework/tests/unit/framework/bootstrap.php
+++ b/dev/tests/integration/framework/tests/unit/framework/bootstrap.php
@@ -23,7 +23,7 @@
*/
$rootDir = realpath(__DIR__ . '/../../../../../../../');
+$testsBaseDir = realpath(__DIR__ . '/../../../../');
+
require_once $rootDir . '/app/bootstrap.php';
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
-$includePath->addIncludePath($rootDir . '/dev/tests/integration/framework');
+require_once $testsBaseDir . '/framework/autoload.php';
diff --git a/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php b/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php
index 1a7c568e112b3ea618011bc5c4424ab26b9f23f5..f265a8c97088b4c8be359f07fd197c65c576bbc0 100644
--- a/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php
+++ b/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php
@@ -25,6 +25,7 @@ namespace Magento\Test;
use Magento\Framework\App\Bootstrap;
use Magento\Framework\App\State;
+use Magento\Framework\Autoload\AutoloaderRegistry;
class ApplicationTest extends \PHPUnit_Framework_TestCase
{
@@ -36,6 +37,8 @@ class ApplicationTest extends \PHPUnit_Framework_TestCase
public function testConstructor()
{
$shell = $this->getMock('\Magento\Framework\Shell', [], [], '', false);
+ $autoloadWrapper = $this->getMockBuilder('Magento\Framework\Autoload\ClassLoaderWrapper')
+ ->disableOriginalConstructor()->getMock();
$tempDir = '/temp/dir';
$appMode = \Magento\Framework\App\State::MODE_DEVELOPER;
@@ -45,7 +48,8 @@ class ApplicationTest extends \PHPUnit_Framework_TestCase
'local.xml',
'',
array(),
- $appMode
+ $appMode,
+ $autoloadWrapper
);
$this->assertEquals($tempDir, $object->getTempDir(), 'Temp directory is not set in Application');
diff --git a/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ObjectManagerTest.php b/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ObjectManagerTest.php
index 8b6e197723ff57c2a34d755655e6bff7fd25d68b..d3d489d383f57fc1ddef208b619dad0850e0d265 100644
--- a/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ObjectManagerTest.php
+++ b/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ObjectManagerTest.php
@@ -50,7 +50,7 @@ class ObjectManagerTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $factory = $this->getMock('\Magento\Framework\ObjectManager\Factory', array(), array(), '', false);
+ $factory = $this->getMock('Magento\Framework\ObjectManager\FactoryInterface');
$factory->expects($this->exactly(2))->method('create')->will(
$this->returnCallback(
function ($className) {
@@ -94,7 +94,7 @@ class ObjectManagerTest extends \PHPUnit_Framework_TestCase
$this->assertSame($instance1, $model->get('Magento\Framework\Object'));
$this->assertSame($model, $model->clearCache());
- $this->assertSame($model, $model->get('Magento\Framework\ObjectManager'));
+ $this->assertSame($model, $model->get('Magento\Framework\ObjectManagerInterface'));
$this->assertSame($resource, $model->get('Magento\Framework\App\Resource'));
$this->assertNotSame($instance1, $model->get('Magento\Framework\Object'));
}
diff --git a/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/RequestTest.php b/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/RequestTest.php
index 1fb504a4ca3f8462441a21f256ae5ede849493c0..99721998c31db857f325f440b9e4795f7fd5cbef 100644
--- a/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/RequestTest.php
+++ b/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/RequestTest.php
@@ -35,7 +35,7 @@ class RequestTest extends \PHPUnit_Framework_TestCase
$this->_model = new \Magento\TestFramework\Request(
$this->getMock('Magento\Framework\App\Route\ConfigInterface\Proxy', [], [], '', false),
$this->getMock('Magento\Framework\App\Request\PathInfoProcessorInterface', [], [], '', false),
- $this->getMock('Magento\Framework\Stdlib\CookieManager', [], [], '', false)
+ $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface')
);
}
diff --git a/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ResponseTest.php b/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ResponseTest.php
index 5d820c4edab77584157c4973be08385d20d8baf8..76ad7785a268e988844676213702ef9e9c7e9c16 100644
--- a/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ResponseTest.php
+++ b/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/ResponseTest.php
@@ -28,7 +28,7 @@ class ResponseTest extends \PHPUnit_Framework_TestCase
public function testCanSendHeaders()
{
$response = new \Magento\TestFramework\Response(
- $this->getMock('Magento\Framework\Stdlib\CookieManager', [], [], '', false),
+ $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface'),
$this->getMock('Magento\Framework\Stdlib\Cookie\CookieMetadataFactory', [], [], '', false),
$this->getMock('Magento\Framework\App\Http\Context', [], [], '', false)
);
diff --git a/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/TestCase/ControllerAbstractTest.php b/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/TestCase/ControllerAbstractTest.php
index 66d3f4b9fc0d13c2476444b66baa2c1fbbb21ed7..b2635ed89223aa5b1d6ee2c78b0a7e278374727a 100644
--- a/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/TestCase/ControllerAbstractTest.php
+++ b/dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/TestCase/ControllerAbstractTest.php
@@ -39,10 +39,10 @@ class ControllerAbstractTest extends \Magento\TestFramework\TestCase\AbstractCon
$request = new \Magento\TestFramework\Request(
$this->getMock('Magento\Framework\App\Route\ConfigInterface\Proxy', [], [], '', false),
$this->getMock('Magento\Framework\App\Request\PathInfoProcessorInterface', [], [], '', false),
- $this->getMock('Magento\Framework\Stdlib\CookieManager', [], [], '', false)
+ $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface')
);
$response = new \Magento\TestFramework\Response(
- $this->getMock('Magento\Framework\Stdlib\CookieManager', [], [], '', false),
+ $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface'),
$this->getMock('Magento\Framework\Stdlib\Cookie\CookieMetadataFactory', [], [], '', false),
$this->getMock('Magento\Framework\App\Http\Context', [], [], '', false)
);
diff --git a/dev/tests/integration/phpunit.xml.dist b/dev/tests/integration/phpunit.xml.dist
index 7ea0558b0a92157090f6ece324630d415a23b2b6..d90736fb6e582bd836470735db1930b09d7f524d 100644
--- a/dev/tests/integration/phpunit.xml.dist
+++ b/dev/tests/integration/phpunit.xml.dist
@@ -53,7 +53,8 @@
</filter>
<!-- PHP INI settings and constants definition -->
<php>
- <includePath>.;testsuite</includePath>
+ <includePath>.</includePath>
+ <includePath>testsuite</includePath>
<ini name="date.timezone" value="America/Los_Angeles"/>
<ini name="xdebug.max_nesting_level" value="200"/>
<!-- Local XML configuration file ('.dist' extension will be added, if the specified file doesn't exist) -->
diff --git a/dev/tests/integration/testsuite/Magento/Backend/App/RouterTest.php b/dev/tests/integration/testsuite/Magento/Backend/App/RouterTest.php
index a2e6541597256dac29b933606967f3c865bb4ae1..879687122968d62d98eb7a9ee29a2285cd8e20a3 100644
--- a/dev/tests/integration/testsuite/Magento/Backend/App/RouterTest.php
+++ b/dev/tests/integration/testsuite/Magento/Backend/App/RouterTest.php
@@ -34,7 +34,7 @@ class RouterTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Backend/Block/System/Config/FormTest.php b/dev/tests/integration/testsuite/Magento/Backend/Block/System/Config/FormTest.php
index b8a687e7d444f310b801ba903a94926a17b29a65..d6d3c3af04e90ddb30964a22b16cffb6ec4c814b 100644
--- a/dev/tests/integration/testsuite/Magento/Backend/Block/System/Config/FormTest.php
+++ b/dev/tests/integration/testsuite/Magento/Backend/Block/System/Config/FormTest.php
@@ -31,7 +31,7 @@ use Magento\Framework\App\Filesystem\DirectoryList;
class FormTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Backend/Model/Session/AdminConfigTest.php b/dev/tests/integration/testsuite/Magento/Backend/Model/Session/AdminConfigTest.php
index dc17c146e2019dc9f9fb993f5e34c0bceae98cb2..04edca2d7aba88beae5a3c4992eb8573496812f8 100644
--- a/dev/tests/integration/testsuite/Magento/Backend/Model/Session/AdminConfigTest.php
+++ b/dev/tests/integration/testsuite/Magento/Backend/Model/Session/AdminConfigTest.php
@@ -33,7 +33,7 @@ use PHPUnit_Framework_TestCase;
class AdminConfigTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Bundle/Controller/ProductTest.php b/dev/tests/integration/testsuite/Magento/Bundle/Controller/ProductTest.php
index 919f7ec9a01a72d84a87f9d88529c17ade083d7b..1e4d5e98805fe60ec8e54e90bf3bb2cfdd34f581 100644
--- a/dev/tests/integration/testsuite/Magento/Bundle/Controller/ProductTest.php
+++ b/dev/tests/integration/testsuite/Magento/Bundle/Controller/ProductTest.php
@@ -37,7 +37,11 @@ class ProductTest extends \Magento\TestFramework\TestCase\AbstractController
$this->dispatch('catalog/product/view/id/3');
$responseBody = $this->getResponse()->getBody();
$this->assertContains('Bundle Product', $responseBody);
- $this->assertContains('In stock', $responseBody);
+ $this->assertContains(
+ 'In stock',
+ $responseBody,
+ 'Bundle Product Detailed Page does not contain In Stock field'
+ );
$addToCartCount = substr_count($responseBody, '<span>Add to Cart</span>');
$this->assertEquals(1, $addToCartCount, '"Add to Cart" button should appear on the page exactly once.');
$actualLinkCount = substr_count($responseBody, '>Bundle Product Items<');
diff --git a/dev/tests/integration/testsuite/Magento/Bundle/Service/V1/Product/BundleProductSaveProcessorTest.php b/dev/tests/integration/testsuite/Magento/Bundle/Service/V1/Product/BundleProductSaveProcessorTest.php
index 44d019b7f9d713a7f0f3c0702bc66a495f5aec38..ad250123d23da3f28c2bca75a7a7709f7de32d0e 100644
--- a/dev/tests/integration/testsuite/Magento/Bundle/Service/V1/Product/BundleProductSaveProcessorTest.php
+++ b/dev/tests/integration/testsuite/Magento/Bundle/Service/V1/Product/BundleProductSaveProcessorTest.php
@@ -34,7 +34,7 @@ use Magento\Catalog\Service\V1\Data\ProductMapper;
use Magento\Catalog\Service\V1\ProductServiceInterface;
use Magento\Catalog\Service\V1\Product\ProductLoader;
use Magento\Catalog\Model\Product\Type;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\TestFramework\Helper\Bootstrap;
/**
@@ -47,7 +47,7 @@ class BundleProductSaveProcessorTest extends \PHPUnit_Framework_TestCase
/** @var ProductMapper */
protected $productMapper;
- /** @var ObjectManager */
+ /** @var ObjectManagerInterface */
private $objectManager;
/** @var ProductLoader */
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/WeightTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/WeightTest.php
index 3b5624a9236cbb26bc852cd3da0c358a06af8c02..cc4286244f19ea3a0b6f26057d175293b2c05d84 100644
--- a/dev/tests/integration/testsuite/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/WeightTest.php
+++ b/dev/tests/integration/testsuite/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/WeightTest.php
@@ -26,7 +26,7 @@ namespace Magento\Catalog\Block\Adminhtml\Product\Helper\Form;
class WeightTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Block/Product/NewTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Block/Product/NewTest.php
index 50e23a41906fbd17c6f5da952c149b30ea636dd6..b9409393a4f573a5d4de6641d2300720ec0a2797 100644
--- a/dev/tests/integration/testsuite/Magento/Catalog/Block/Product/NewTest.php
+++ b/dev/tests/integration/testsuite/Magento/Catalog/Block/Product/NewTest.php
@@ -41,7 +41,7 @@ class NewTest extends \PHPUnit_Framework_TestCase
\Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(
'Magento\Framework\App\Http\Context'
)->setValue(
- \Magento\Customer\Helper\Data::CONTEXT_GROUP,
+ \Magento\Customer\Model\Context::CONTEXT_GROUP,
\Magento\Customer\Service\V1\CustomerGroupServiceInterface::NOT_LOGGED_IN_ID,
\Magento\Customer\Service\V1\CustomerGroupServiceInterface::NOT_LOGGED_IN_ID
);
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Block/Product/ProductList/CrosssellTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Block/Product/ProductList/CrosssellTest.php
index 352db5f43ec9f2535e7b18437e32a02fe11c3517..8d6226c4381dce7d0f880c146500f1c82bc76529 100644
--- a/dev/tests/integration/testsuite/Magento/Catalog/Block/Product/ProductList/CrosssellTest.php
+++ b/dev/tests/integration/testsuite/Magento/Catalog/Block/Product/ProductList/CrosssellTest.php
@@ -52,7 +52,6 @@ class CrosssellTest extends \PHPUnit_Framework_TestCase
$block->setTemplate('Magento_Catalog::product/list/items.phtml');
$block->setType('crosssell');
$block->setItemCount(1);
-
$html = $block->toHtml();
$this->assertNotEmpty($html);
$this->assertContains('Simple Cross Sell', $html);
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Helper/DataTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Helper/DataTest.php
index c883c8c146528beda657de06cd2a2d0fc1ac24df..656a8a9c4f5480893cb70da1ed6ec473511fc410 100644
--- a/dev/tests/integration/testsuite/Magento/Catalog/Helper/DataTest.php
+++ b/dev/tests/integration/testsuite/Magento/Catalog/Helper/DataTest.php
@@ -40,7 +40,7 @@ class DataTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/CompareTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/CompareTest.php
index 3940cf21690f935ece8b4c9393d72c5ae0f0da69..61aca2e68e7ef8019b27c1b34cede3328a61c982 100644
--- a/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/CompareTest.php
+++ b/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/CompareTest.php
@@ -31,7 +31,7 @@ class CompareTest extends \PHPUnit_Framework_TestCase
protected $_helper;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/ViewTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/ViewTest.php
index a2dfecc6d864feb16b9c70166506d00f2d6ddb13..966427150d62c32f5607145ceff33adb884d5e44 100644
--- a/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/ViewTest.php
+++ b/dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/ViewTest.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Catalog\Helper\Product;
+use Magento\Customer\Model\Context;
+
/**
* @magentoAppArea frontend
*/
@@ -44,7 +46,7 @@ class ViewTest extends \PHPUnit_Framework_TestCase
protected $page;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -54,7 +56,7 @@ class ViewTest extends \PHPUnit_Framework_TestCase
$this->objectManager->get('Magento\Framework\App\State')->setAreaCode('frontend');
$this->objectManager->get('Magento\Framework\App\Http\Context')
- ->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, false, false);
+ ->setValue(Context::CONTEXT_AUTH, false, false);
$this->objectManager->get('Magento\Framework\View\DesignInterface')
->setDefaultDesignTheme();
$this->_helper = $this->objectManager->get('Magento\Catalog\Helper\Product\View');
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/_files/categories.php b/dev/tests/integration/testsuite/Magento/Catalog/_files/categories.php
index 004d1f22949c7610a2a46fc53e15ffc661946925..beb0fe725bed0c5c1f4341cf974dd79737c652c8 100644
--- a/dev/tests/integration/testsuite/Magento/Catalog/_files/categories.php
+++ b/dev/tests/integration/testsuite/Magento/Catalog/_files/categories.php
@@ -26,6 +26,7 @@ $installer = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create
'Magento\Catalog\Model\Resource\Setup',
array('resourceName' => 'catalog_setup')
);
+
/**
* After installation system has two categories: root one with ID:1 and Default category with ID:2
*/
diff --git a/dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Import/ProductTest.php b/dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Import/ProductTest.php
index 637dc75c3fbe74c4128fdb3205453ac445a655ca..d070641ab5c59f25ea1f46ad09ed2e9c1da13b17 100644
--- a/dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Import/ProductTest.php
+++ b/dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Import/ProductTest.php
@@ -146,10 +146,12 @@ class ProductTest extends \PHPUnit_Framework_TestCase
$existingProductIds = array(10, 11, 12);
$stockItems = array();
foreach ($existingProductIds as $productId) {
- $stockItem = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
- 'Magento\CatalogInventory\Model\Stock\Item'
+ /** @var $stockRegistry \Magento\CatalogInventory\Model\StockRegistry */
+ $stockRegistry = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+ 'Magento\CatalogInventory\Model\StockRegistry'
);
- $stockItem->loadByProduct($productId);
+
+ $stockItem = $stockRegistry->getStockItem($productId, 1);
$stockItems[$productId] = $stockItem;
}
@@ -171,11 +173,12 @@ class ProductTest extends \PHPUnit_Framework_TestCase
/** @var $stockItmBeforeImport \Magento\CatalogInventory\Model\Stock\Item */
foreach ($stockItems as $productId => $stockItmBeforeImport) {
- /** @var $stockItemAfterImport \Magento\CatalogInventory\Model\Stock\Item */
- $stockItemAfterImport = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
- 'Magento\CatalogInventory\Model\Stock\Item'
+ /** @var $stockRegistry \Magento\CatalogInventory\Model\StockRegistry */
+ $stockRegistry = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+ 'Magento\CatalogInventory\Model\StockRegistry'
);
- $stockItemAfterImport->loadByProduct($productId);
+
+ $stockItemAfterImport = $stockRegistry->getStockItem($productId, 1);
$this->assertEquals($stockItmBeforeImport->getQty(), $stockItemAfterImport->getQty());
$this->assertEquals(1, $stockItemAfterImport->getIsInStock());
diff --git a/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Config/Backend/ManagestockTest.php b/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Config/Backend/ManagestockTest.php
index a41797d66e52fb093ad823baa19a9dcf00b40698..a7fb46de66d4a424fd036ba2025e3c20813ee720 100644
--- a/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Config/Backend/ManagestockTest.php
+++ b/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Config/Backend/ManagestockTest.php
@@ -56,32 +56,30 @@ class ManagestockTest extends \PHPUnit_Framework_TestCase
*/
public function testSaveAndRebuildIndex($newStockValue, $callCount)
{
- /** @var \Magento\CatalogInventory\Model\Stock\Status */
- $stockStatus = $this->getMock(
- '\Magento\CatalogInventory\Model\Stock\Status',
+ /** @var \Magento\CatalogInventory\Model\StockIndex */
+ $stockManagement = $this->getMock(
+ '\Magento\CatalogInventory\Model\StockIndex',
['rebuild'],
[],
'',
false
);
- $stockStatus->expects($this->exactly($callCount))
- ->method('rebuild')
- ->will($this->returnValue($stockStatus));
+ $stockManagement->expects($this->exactly($callCount))
+ ->method('rebuild');
$manageStock = new Managestock(
Bootstrap::getObjectManager()->get('\Magento\Framework\Model\Context'),
Bootstrap::getObjectManager()->get('\Magento\Framework\Registry'),
Bootstrap::getObjectManager()->get('\Magento\Framework\App\Config\ScopeConfigInterface'),
- $stockStatus,
+ $stockManagement,
Bootstrap::getObjectManager()->get('Magento\CatalogInventory\Model\Indexer\Stock\Processor'),
Bootstrap::getObjectManager()->get('Magento\Core\Model\Resource\Config')
);
- $manageStock->setPath('cataloginventory/item_options/manage_stock')
- ->setScope('default')
- ->setScopeId(0);
-
+ $manageStock->setPath('cataloginventory/item_options/manage_stock');
+ $manageStock->setScope('default');
+ $manageStock->setScopeId(0);
$manageStock->setValue($newStockValue);
// assert
diff --git a/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Indexer/Stock/Action/RowTest.php b/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Indexer/Stock/Action/RowTest.php
index 448a031dac11f350c0124ca49655309930313a44..8aced28aa264585fbae33ad16ea8e2deb7d76260 100644
--- a/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Indexer/Stock/Action/RowTest.php
+++ b/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Indexer/Stock/Action/RowTest.php
@@ -41,8 +41,6 @@ class RowTest extends \PHPUnit_Framework_TestCase
}
/**
- * @magentoDbIsolation enabled
- * @magentoAppIsolation enabled
* @magentoDataFixture Magento/Catalog/_files/product_simple.php
*/
public function testProductUpdate()
@@ -55,17 +53,38 @@ class RowTest extends \PHPUnit_Framework_TestCase
'\Magento\Catalog\Block\Product\ListProduct'
);
- /** @var \Magento\CatalogInventory\Model\Stock\Item $stockItem */
- $stockItem = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
- '\Magento\CatalogInventory\Model\Stock\Item'
+ /** @var \Magento\CatalogInventory\Api\Data\StockItemInterfaceBuilder $stockItemBuilder */
+ $stockItemBuilder = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+ '\Magento\CatalogInventory\Api\Data\StockItemInterfaceBuilder'
+ );
+
+ /** @var \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry */
+ $stockRegistry = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+ 'Magento\CatalogInventory\Api\StockRegistryInterface'
+ );
+ /** @var \Magento\CatalogInventory\Api\StockItemRepositoryInterface $stockItemRepository */
+ $stockItemRepository = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+ '\Magento\CatalogInventory\Api\StockItemRepositoryInterface'
);
$this->_processor->getIndexer()->setScheduled(false);
$this->assertFalse($this->_processor->getIndexer()->isScheduled());
- $stockItem->loadByProduct(1);
- $stockItem->addQty(11);
- $stockItem->save();
+ $stockItem = $stockRegistry->getStockItem(1, 1);
+
+ $this->assertNotNull($stockItem->getId());
+
+ $stockItemData = [
+ 'qty' => $stockItem->getQty() + 11
+ ];
+
+ // todo fix builder
+ $id = $stockItem->getId();
+ $stockItemBuilder = $stockItemBuilder->mergeDataObjectWithArray($stockItem, $stockItemData);
+ $stockItemBuilder->setId($id);
+ $stockItemSave = $stockItemBuilder->create();
+ $stockItemSave->setItemId($id);
+ $stockItemRepository->save($stockItemSave);
$category = $categoryFactory->create()->load(2);
$layer = $listProduct->getLayer();
diff --git a/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Indexer/Stock/Action/RowsTest.php b/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Indexer/Stock/Action/RowsTest.php
index 186e2bb4558ef79255a6064e8b7a725aaee7f383..0e43af5674d93992965561fb18e1e1edb01f32b5 100644
--- a/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Indexer/Stock/Action/RowsTest.php
+++ b/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Indexer/Stock/Action/RowsTest.php
@@ -41,8 +41,6 @@ class RowsTest extends \PHPUnit_Framework_TestCase
}
/**
- * @magentoDbIsolation enabled
- * @magentoAppIsolation enabled
* @magentoDataFixture Magento/Catalog/_files/product_simple.php
*/
public function testProductUpdate()
@@ -55,15 +53,40 @@ class RowsTest extends \PHPUnit_Framework_TestCase
'\Magento\Catalog\Block\Product\ListProduct'
);
- /** @var \Magento\CatalogInventory\Model\Stock\Item $stockItem */
- $stockItem = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
- '\Magento\CatalogInventory\Model\Stock\Item'
+ /** @var \Magento\CatalogInventory\Api\Data\StockItemInterfaceBuilder $stockRegistry */
+ $stockItemBuilder = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+ '\Magento\CatalogInventory\Api\Data\StockItemInterfaceBuilder'
);
- $stockItem->loadByProduct(1);
- $stockItem->setProcessIndexEvents(false);
- $stockItem->addQty(11);
- $stockItem->save();
+ /** @var \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry */
+ $stockRegistry = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+ 'Magento\CatalogInventory\Api\StockRegistryInterface'
+ );
+ /** @var \Magento\CatalogInventory\Api\StockItemRepositoryInterface $stockItemRepository */
+ $stockItemRepository = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+ '\Magento\CatalogInventory\Api\StockItemRepositoryInterface'
+ );
+
+ /** @var \Magento\CatalogInventory\Model\Resource\Stock\Item $stockItemResource */
+ $stockItemResource = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
+ '\Magento\CatalogInventory\Model\Resource\Stock\Item'
+ );
+
+ $stockItem = $stockRegistry->getStockItem(1, 1);
+
+ $stockItemData = [
+ 'qty' => $stockItem->getQty() + 12
+ ];
+
+ // todo fix builder
+ $id = $stockItem->getId();
+ $stockItemBuilder = $stockItemBuilder->mergeDataObjectWithArray($stockItem, $stockItemData);
+ $stockItemBuilder->setId($id);
+ $stockItemSave = $stockItemBuilder->create();
+ $stockItemSave->setItemId($id);
+ $stockItemResource->setProcessIndexEvents(false);
+
+ $stockItemRepository->save($stockItemSave);
$this->_processor->reindexList(array(1));
@@ -85,7 +108,7 @@ class RowsTest extends \PHPUnit_Framework_TestCase
foreach ($productCollection as $product) {
$this->assertEquals('Simple Product', $product->getName());
$this->assertEquals('Short description', $product->getShortDescription());
- $this->assertEquals(111, $product->getQty());
+ $this->assertEquals(112, $product->getQty());
}
}
}
diff --git a/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Stock/ItemTest.php b/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Stock/ItemTest.php
index b2d3f3f420e9bf353893bd7938442a9ac378723f..36bda987693868787ac22725e7f6ab89c314f545 100644
--- a/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Stock/ItemTest.php
+++ b/dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Stock/ItemTest.php
@@ -38,64 +38,67 @@ class ItemTest extends \PHPUnit_Framework_TestCase
}
/**
- * Simple product with stock item
- */
- public static function simpleProductFixture()
- {
- /** @var $product \Magento\Catalog\Model\Product */
- $product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
- 'Magento\Catalog\Model\Product'
- );
- $product->setTypeId('simple')
- ->setId(1)
- ->setAttributeSetId(4)
- ->setName('Simple Product')
- ->setSku('simple')
- ->setPrice(10)
- ->setVisibility(\Magento\Catalog\Model\Product\Visibility::VISIBILITY_BOTH)
- ->setStatus(\Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_ENABLED)
- ->save();
- }
-
- /**
- * @magentoDataFixture simpleProductFixture
+ * @magentoDataFixture Magento/Catalog/_files/products.php
*/
public function testSaveWithNullQty()
{
- $this->_model->setProductId(1)
- ->setTypeId(\Magento\Catalog\Model\Product\Type::DEFAULT_TYPE)
- ->setStockId(\Magento\CatalogInventory\Model\Stock::DEFAULT_STOCK_ID)
- ->setQty(null);
- $this->_model->save();
-
- $this->_model->setQty(2);
- $this->_model->save();
- $this->assertEquals('2.0000', $this->_model->load(1)->getQty());
-
- $this->_model->setQty(0);
- $this->_model->save();
- $this->assertEquals('0.0000', $this->_model->load(1)->getQty());
-
- $this->_model->setQty(null);
- $this->_model->save();
- $this->assertEquals(null, $this->_model->load(1)->getQty());
+ /** @var \Magento\Catalog\Model\Product $product */
+ $product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+ ->get('Magento\Catalog\Model\Product');
+
+ $product->load(1);
+
+ /** @var \Magento\CatalogInventory\Model\Stock\StockItemRepository $stockItemRepository */
+ $stockItemRepository = $product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+ ->create('Magento\CatalogInventory\Model\Stock\StockItemRepository');
+
+ /** @var \Magento\CatalogInventory\Api\StockItemCriteriaInterface $stockItemCriteria */
+ $stockItemCriteria = $product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+ ->create('Magento\CatalogInventory\Api\StockItemCriteriaInterface');
+
+ $savedStockItem = current($stockItemRepository->getList($stockItemCriteria)->getItems());
+ $savedStockItemId = $savedStockItem->getItemId();
+
+ $savedStockItem->setQty(null);
+ $savedStockItem->save();
+
+ $savedStockItem->setQty(2);
+ $savedStockItem->save();
+ $this->assertEquals('2.0000', $savedStockItem->load($savedStockItemId)->getQty());
+
+ $savedStockItem->setQty(0);
+ $savedStockItem->save();
+ $this->assertEquals('0.0000', $savedStockItem->load($savedStockItemId)->getQty());
+
+ $savedStockItem->setQty(null);
+ $savedStockItem->save();
+
+ $this->assertEquals(null, $savedStockItem->load($savedStockItemId)->getQty());
}
/**
- * @magentoDataFixture simpleProductFixture
+ * @magentoDataFixture Magento/Catalog/_files/products.php
*/
public function testStockStatusChangedAuto()
{
- $this->_model->setProductId(1)
- ->setTypeId(\Magento\Catalog\Model\Product\Type::DEFAULT_TYPE)
- ->setStockId(\Magento\CatalogInventory\Model\Stock::DEFAULT_STOCK_ID)
- ->setQty(1);
- $this->_model->save();
- $this->assertEquals(0, $this->_model->getStockStatusChangedAuto());
-
- $this->_model->setStockStatusChangedAutomaticallyFlag(1);
- $this->_model->save();
- $this->assertEquals(1, $this->_model->getStockStatusChangedAuto());
+ /** @var \Magento\CatalogInventory\Model\Stock\StockItemRepository $stockItemRepository */
+ $stockItemRepository = $product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+ ->create('Magento\CatalogInventory\Model\Stock\StockItemRepository');
+
+ /** @var \Magento\CatalogInventory\Api\StockItemCriteriaInterface $stockItemCriteria */
+ $stockItemCriteria = $product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+ ->create('Magento\CatalogInventory\Api\StockItemCriteriaInterface');
+
+ $savedStockItem = current($stockItemRepository->getList($stockItemCriteria)->getItems());
+
+ $savedStockItem->setQty(1);
+ $savedStockItem->save();
+
+ $this->assertEquals(0, $savedStockItem->getStockStatusChangedAuto());
+
+ $savedStockItem->setStockStatusChangedAutomaticallyFlag(1);
+ $savedStockItem->save();
+ $this->assertEquals(1, $savedStockItem->getStockStatusChangedAuto());
}
/**
diff --git a/dev/tests/integration/testsuite/Magento/Checkout/Block/Onepage/BillingTest.php b/dev/tests/integration/testsuite/Magento/Checkout/Block/Onepage/BillingTest.php
index 443ca69f46c259921863df094654a392c6af8b73..9e8e1049b7538b3404863efd3e0e3524a9d6084f 100644
--- a/dev/tests/integration/testsuite/Magento/Checkout/Block/Onepage/BillingTest.php
+++ b/dev/tests/integration/testsuite/Magento/Checkout/Block/Onepage/BillingTest.php
@@ -21,6 +21,7 @@
*/
namespace Magento\Checkout\Block\Onepage;
+use Magento\Customer\Model\Context;
use Magento\TestFramework\Helper\Bootstrap;
class BillingTest extends \PHPUnit_Framework_TestCase
@@ -80,7 +81,7 @@ class BillingTest extends \PHPUnit_Framework_TestCase
$checkoutSession->setLoadInactive(true);
$objectManager->get('Magento\Framework\App\Http\Context')
- ->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, true, false);
+ ->setValue(Context::CONTEXT_AUTH, true, false);
$this->_block = $objectManager->get('Magento\Framework\View\LayoutInterface')
->createBlock(
'Magento\Checkout\Block\Onepage\Billing',
diff --git a/dev/tests/integration/testsuite/Magento/Cms/Helper/PageTest.php b/dev/tests/integration/testsuite/Magento/Cms/Helper/PageTest.php
index 255d8d7821734b11c00e1f2eb5843b50ba235261..3e8de4770386a259e3e3b20bbce077f3b64231e5 100644
--- a/dev/tests/integration/testsuite/Magento/Cms/Helper/PageTest.php
+++ b/dev/tests/integration/testsuite/Magento/Cms/Helper/PageTest.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Cms\Helper;
+use Magento\Customer\Model\Context;
+
/**
* @magentoAppArea frontend
*/
@@ -38,7 +40,7 @@ class PageTest extends \PHPUnit_Framework_TestCase
/** @var $objectManager \Magento\TestFramework\ObjectManager */
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
$httpContext = $objectManager->get('Magento\Framework\App\Http\Context');
- $httpContext->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, false, false);
+ $httpContext->setValue(Context::CONTEXT_AUTH, false, false);
$objectManager->get('Magento\Framework\App\State')->setAreaCode('frontend');
$arguments = array(
'request' => $objectManager->get('Magento\TestFramework\Request'),
diff --git a/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php b/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php
index a42f6ed3657359eed333daac8d995608b921bc86..08f908e690fa105f2c47ab672aad6e165109825c 100644
--- a/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php
+++ b/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php
@@ -461,14 +461,14 @@ class ConfigurableTest extends \PHPUnit_Framework_TestCase
public function testGenerateSimpleProductsWithPartialData($productsData)
{
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
- /** @var \Magento\CatalogInventory\Service\V1\StockItemService $stockItemService */
- $stockItemService = $objectManager->get('Magento\CatalogInventory\Service\V1\StockItemService');
+ /** @var \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry */
+ $stockRegistry = $objectManager->get('Magento\CatalogInventory\Api\StockRegistryInterface');
$this->_product->setNewVariationsAttributeSetId(4);
$generatedProducts = $this->_model->generateSimpleProducts($this->_product, $productsData);
foreach ($generatedProducts as $productId) {
- $stockItemData = $stockItemService->getStockItem($productId);
- $this->assertEquals('0', $stockItemData->isManageStock());
- $this->assertEquals('1', $stockItemData->getIsInStock());
+ $stockItem = $stockRegistry->getStockItem($productId);
+ $this->assertEquals('0', $stockItem->getManageStock());
+ $this->assertEquals('1', $stockItem->getIsInStock());
}
}
diff --git a/dev/tests/integration/testsuite/Magento/Core/_files/layout_update.php b/dev/tests/integration/testsuite/Magento/Core/_files/layout_update.php
index 3a87e66dd9bd8b3d2d6035f6cdf92a75bb064931..f50e54a884fbe97ef62aa3b72139a9006c46f623 100644
--- a/dev/tests/integration/testsuite/Magento/Core/_files/layout_update.php
+++ b/dev/tests/integration/testsuite/Magento/Core/_files/layout_update.php
@@ -22,7 +22,7 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-/** @var $objectManager \Magento\Framework\ObjectManager */
+/** @var $objectManager \Magento\Framework\ObjectManagerInterface */
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
$objectManager->get('Magento\Framework\App\AreaList')
->getArea(\Magento\Backend\App\Area\FrontNameResolver::AREA_CODE)
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Api/AddressRepositoryTest.php b/dev/tests/integration/testsuite/Magento/Customer/Api/AddressRepositoryTest.php
index 60bb396053da63f9e9737c53ba42bae1bad98d78..650b98afd400a6178502da13fd4b9d6e294ebb44 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Api/AddressRepositoryTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Api/AddressRepositoryTest.php
@@ -38,7 +38,7 @@ class AddressRepositoryTest extends \PHPUnit_Framework_TestCase
/** @var AddressRepositoryInterface */
private $repository;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $_objectManager;
/** @var \Magento\Customer\Model\Data\Address[] */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php
index bb40d7fa9ec84ebcf9ddfaed5a63c4c32988da76..1a5f7107f77b921db37a6c17ddecbc3973b0a99f 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php
@@ -36,7 +36,7 @@ class AccountTest extends \PHPUnit_Framework_TestCase
/** @var Account */
protected $accountBlock;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
protected $objectManager;
/** @var \Magento\Framework\Registry */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AddressesTest.php b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AddressesTest.php
index e90feae3e00d1b9b795d23b385a17aa631281725..4c9a6c029088af827d7bbcdc70854dc6c9530a02 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AddressesTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AddressesTest.php
@@ -51,7 +51,7 @@ class AddressesTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Backend\Model\Session */
private $_backendSession;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $_objectManager;
/** @var array */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/CartTest.php b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/CartTest.php
index 676fc88037124ea4526cc11745884f40cea3828f..c8ef9903f3222bb3592f1671c247b45d5812e199 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/CartTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/CartTest.php
@@ -46,7 +46,7 @@ class CartTest extends \PHPUnit_Framework_TestCase
/** @var Cart */
private $_block;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $_objectManager;
public function setUp()
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/CartsTest.php b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/CartsTest.php
index 41228d0b330203f6002483f5fb42df7f8f3d49d6..e7f04cb3e0fa32eedc010b1d855edbf3eb219a43 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/CartsTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/CartsTest.php
@@ -41,7 +41,7 @@ class CartsTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Backend\Block\Template\Context */
private $_context;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $_objectManager;
public function setUp()
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/View/PersonalInfoTest.php b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/View/PersonalInfoTest.php
index ce39d6ef88f3d22d8461e2cb404b85835b5406a9..2ed2a72e0a5d0ec10ca6e20185c7e12672da2b7e 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/View/PersonalInfoTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/View/PersonalInfoTest.php
@@ -55,7 +55,7 @@ class PersonalInfoTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Framework\StoreManagerInterface */
private $_storeManager;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $_objectManager;
/** @var PersonalInfo */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/ViewTest.php b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/ViewTest.php
index befb58195da3be0500ec9017e9405b4f9095f8eb..41c79b0f922004f02beb45fd6d9c85d0770f53ed 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/ViewTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/ViewTest.php
@@ -52,7 +52,7 @@ class ViewTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Framework\StoreManagerInterface */
private $_storeManager;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $_objectManager;
/** @var View */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php b/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php
index 5cccb17a7dbdfe59947dc2d83e08531c6159fdd9..9bb27e5d56b93daec74156bf24578a45c242e96a 100755
--- a/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php
@@ -87,8 +87,8 @@ class AccountTest extends \Magento\TestFramework\TestCase\AbstractController
$customer = Bootstrap::getObjectManager()
->create('Magento\Customer\Model\Customer')->load(1);
- $token = Bootstrap::getObjectManager()->get('Magento\Customer\Helper\Data')
- ->generateResetPasswordLinkToken();
+ $token = Bootstrap::getObjectManager()->get('Magento\Framework\Math\Random')
+ ->getUniqueHash();
$customer->changeResetPasswordLinkToken($token);
$this->getRequest()->setParam('token', $token);
@@ -108,8 +108,8 @@ class AccountTest extends \Magento\TestFramework\TestCase\AbstractController
$customer = Bootstrap::getObjectManager()
->create('Magento\Customer\Model\Customer')->load(1);
- $token = Bootstrap::getObjectManager()->get('Magento\Customer\Helper\Data')
- ->generateResetPasswordLinkToken();
+ $token = Bootstrap::getObjectManager()->get('Magento\Framework\Math\Random')
+ ->getUniqueHash();
$customer->changeResetPasswordLinkToken($token);
$this->getRequest()->setParam('token', 'INVALIDTOKEN');
@@ -263,8 +263,8 @@ class AccountTest extends \Magento\TestFramework\TestCase\AbstractController
$customer = Bootstrap::getObjectManager()
->create('Magento\Customer\Model\Customer')->load(1);
- $token = Bootstrap::getObjectManager()->get('Magento\Customer\Helper\Data')
- ->generateResetPasswordLinkToken();
+ $token = Bootstrap::getObjectManager()->get('Magento\Framework\Math\Random')
+ ->getUniqueHash();
$customer->changeResetPasswordLinkToken($token);
$this->getRequest()->setParam('token', $token);
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Model/AccountManagementTest.php b/dev/tests/integration/testsuite/Magento/Customer/Model/AccountManagementTest.php
index d8203c9d0a59f25cbd3595a4bfdff13a7695280d..316d42cf1741dd534e950f272d6f8c4221d27933 100755
--- a/dev/tests/integration/testsuite/Magento/Customer/Model/AccountManagementTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Model/AccountManagementTest.php
@@ -54,7 +54,7 @@ class AccountManagementTest extends \PHPUnit_Framework_TestCase
/** @var AddressRepositoryInterface needed to setup tests */
private $addressRepository;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $objectManager;
/** @var \Magento\Customer\Service\V1\Data\Address[] */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Model/GroupManagementTest.php b/dev/tests/integration/testsuite/Magento/Customer/Model/GroupManagementTest.php
index 09a0277d7a0169272dcd40099a4028b2f89543ad..d741fa1b39399190c81e7ea8b842105910ad4011 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Model/GroupManagementTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Model/GroupManagementTest.php
@@ -33,7 +33,7 @@ use Magento\Store\Model\ScopeInterface;
class GroupManagementTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/AddressRepositoryTest.php b/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/AddressRepositoryTest.php
index dc1a2d609e2131debfff48af4342ceec173db5eb..7397f933fa6bc9acef748aa9714b2dad95b45a10 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/AddressRepositoryTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/AddressRepositoryTest.php
@@ -40,7 +40,7 @@ class AddressRepositoryTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Customer\Api\AddressRepositoryInterface */
private $_service;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $_objectManager;
/** @var \Magento\Customer\Service\V1\Data\Address[] */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/CustomerRepositoryTest.php b/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/CustomerRepositoryTest.php
index ffda1219437fb63d5e15608cd839bc45417a75fd..8b7554a516920380d62bd5edee810d9d3491ad2d 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/CustomerRepositoryTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/CustomerRepositoryTest.php
@@ -32,7 +32,7 @@ class CustomerRepositoryTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Customer\Api\CustomerRepositoryInterface */
private $service;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $objectManager;
/** @var \Magento\Customer\Api\Data\CustomerDataBuilder */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/GroupRepositoryTest.php b/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/GroupRepositoryTest.php
index e74849aa59940cca8974dded893c16322c3a98f1..73b20ed5cc8ecef7e952c2e0770f9f7759d18d1f 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/GroupRepositoryTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Model/Resource/GroupRepositoryTest.php
@@ -37,7 +37,7 @@ class GroupRepositoryTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Customer\Api\GroupRepositoryInterface */
private $groupRepository;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $objectManager;
/** @var \Magento\Customer\Model\Data\GroupBuilder */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerAccountServiceTest.php b/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerAccountServiceTest.php
index b6c099e06bdf9448475c619bca1bfd5e98e938ec..2bfdeebe369b49c63bf6565f4d58784153452a47 100755
--- a/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerAccountServiceTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerAccountServiceTest.php
@@ -48,7 +48,7 @@ class CustomerAccountServiceTest extends \PHPUnit_Framework_TestCase
/** @var CustomerAddressServiceInterface needed to setup tests */
private $_customerAddressService;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $_objectManager;
/** @var \Magento\Customer\Service\V1\Data\Address[] */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerAddressServiceTest.php b/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerAddressServiceTest.php
index 767f5b0a12900d1c13c73fa38b45b505a60670bb..8e6590b6168288897dbf6a1a8b95fc616a846ada 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerAddressServiceTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerAddressServiceTest.php
@@ -40,7 +40,7 @@ class CustomerAddressServiceTest extends \PHPUnit_Framework_TestCase
/** @var CustomerAddressServiceInterface */
private $_service;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $_objectManager;
/** @var \Magento\Customer\Service\V1\Data\Address[] */
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerGroupServiceTest.php b/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerGroupServiceTest.php
index 5d83afa0a58f321708a5d9e6d7aa79b8b43b12c6..9c387f04c779671d2bf953a03a4e3f03bf380871 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerGroupServiceTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Service/V1/CustomerGroupServiceTest.php
@@ -35,7 +35,7 @@ use Magento\Customer\Model\Group;
class CustomerGroupServiceTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Service/V1/Data/CustomerDetailsBuilderTest.php b/dev/tests/integration/testsuite/Magento/Customer/Service/V1/Data/CustomerDetailsBuilderTest.php
index 40cd098a1dbb9fa5f46298733b226bafeb11d8a9..875dc00691dc922749bc5c04c38b7ce7b2ee86aa 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Service/V1/Data/CustomerDetailsBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Service/V1/Data/CustomerDetailsBuilderTest.php
@@ -31,7 +31,7 @@ class CustomerDetailsBuilderTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Customer/Service/V1/Data/Eav/AttributeMetadataBuilderTest.php b/dev/tests/integration/testsuite/Magento/Customer/Service/V1/Data/Eav/AttributeMetadataBuilderTest.php
index a528858ac62e9be096a16a42da629fedbc6de58e..f3b731dec1497a1a374cbc9c5df4425449262341 100644
--- a/dev/tests/integration/testsuite/Magento/Customer/Service/V1/Data/Eav/AttributeMetadataBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Customer/Service/V1/Data/Eav/AttributeMetadataBuilderTest.php
@@ -31,7 +31,7 @@ class AttributeMetadataBuilderTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Directory/Model/ObserverTest.php b/dev/tests/integration/testsuite/Magento/Directory/Model/ObserverTest.php
index 39fb83deec22e2f9dfb0162315a0a75f33a4e856..bc8819aecdc7d3fd24fe369a83ae3d814bcf385c 100644
--- a/dev/tests/integration/testsuite/Magento/Directory/Model/ObserverTest.php
+++ b/dev/tests/integration/testsuite/Magento/Directory/Model/ObserverTest.php
@@ -24,7 +24,7 @@
namespace Magento\Directory\Model;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Store\Model\ScopeInterface;
use Magento\TestFramework\Helper\Bootstrap;
@@ -33,7 +33,7 @@ use Magento\TestFramework\Helper\Bootstrap;
*/
class ObserverTest extends \PHPUnit_Framework_TestCase
{
- /** @var ObjectManager */
+ /** @var ObjectManagerInterface */
protected $objectManager;
/** @var Observer */
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php b/dev/tests/integration/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php
index 7580bd0cd6600b86e62527953f4d54696a62a1d2..7e70ca0320f90253aa528e63d4754bf3c67a9cbc 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php
@@ -32,14 +32,12 @@ use Magento\Framework\Api\AttributeInterface;
class DataBuilderTest extends \PHPUnit_Framework_TestCase
{
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $_objectManager;
protected function setUp()
{
- $includePath = new \Magento\Framework\Autoload\IncludePath();
- $includePath->addIncludePath([__DIR__ . '/../../_files']);
- spl_autoload_register([$includePath, 'load']);
+ \Magento\Framework\Filesystem\FileResolver::addIncludePath([__DIR__ . '/../../_files']);
$this->_objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
$this->_objectManager->configure(
[
diff --git a/dev/tests/integration/testsuite/Magento/Framework/App/FrontControllerTest.php b/dev/tests/integration/testsuite/Magento/Framework/App/FrontControllerTest.php
index 65b676798503caa1dd5d70c33fe76dd8d0194d3d..735d506e683cd427a760f12e75a080dd7ecc9243 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/App/FrontControllerTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/App/FrontControllerTest.php
@@ -30,7 +30,7 @@ namespace Magento\Framework\App;
class FrontControllerTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest.php b/dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest.php
index bfab2a33a5e895aa502b8b0876e5d826700bd724..da0d0e60f97594a66fd97b8cd86613bea3272e61 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest.php
@@ -40,11 +40,6 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
const INTERFACE_NAME_WITHOUT_NAMESPACE = 'Magento\Framework\Code\GeneratorTest\SourceInterfaceWithoutNamespace';
- /**
- * @var string
- */
- protected $_includePath;
-
/**
* @var \Magento\Framework\Code\Generator
*/
@@ -62,20 +57,14 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_includePath = get_include_path();
-
$this->varDirectory = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(
'Magento\Framework\Filesystem'
)->getDirectoryWrite(
DirectoryList::VAR_DIR
);
$generationDirectory = $this->varDirectory->getAbsolutePath('generation');
-
- (new \Magento\Framework\Autoload\IncludePath())->addIncludePath($generationDirectory);
-
$this->_ioObject = new \Magento\Framework\Code\Generator\Io(
new \Magento\Framework\Filesystem\Driver\File(),
- new \Magento\Framework\Code\Generator\FileResolver(),
$generationDirectory
);
$this->_generator = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
@@ -95,7 +84,6 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
protected function tearDown()
{
$this->varDirectory->delete('generation');
- set_include_path($this->_includePath);
unset($this->_generator);
}
@@ -109,12 +97,12 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
$factoryClassName = self::CLASS_NAME_WITH_NAMESPACE . 'Factory';
$result = false;
$generatorResult = $this->_generator->generateClass($factoryClassName);
- if (\Magento\Framework\Code\Generator::GENERATION_SUCCESS == $generatorResult) {
+ if (\Magento\Framework\Code\Generator::GENERATION_ERROR !== $generatorResult) {
$result = true;
}
- $this->assertTrue($result);
+ $this->assertTrue($result, 'Failed asserting that \'' . (string)$generatorResult . '\' equals \'success\'.');
- /** @var $factory \Magento\Framework\ObjectManager\Factory */
+ /** @var $factory \Magento\Framework\ObjectManager\FactoryInterface */
$factory = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create($factoryClassName);
$object = $factory->create();
@@ -137,10 +125,10 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
$proxyClassName = self::CLASS_NAME_WITH_NAMESPACE . '\Proxy';
$result = false;
$generatorResult = $this->_generator->generateClass($proxyClassName);
- if (\Magento\Framework\Code\Generator::GENERATION_SUCCESS == $generatorResult) {
+ if (\Magento\Framework\Code\Generator::GENERATION_ERROR !== $generatorResult) {
$result = true;
}
- $this->assertTrue($result);
+ $this->assertTrue($result, 'Failed asserting that \'' . (string)$generatorResult . '\' equals \'success\'.');
$proxy = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create($proxyClassName);
$this->assertInstanceOf(self::CLASS_NAME_WITH_NAMESPACE, $proxy);
@@ -162,10 +150,10 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
$interceptorClassName = self::CLASS_NAME_WITH_NAMESPACE . '\Interceptor';
$result = false;
$generatorResult = $this->_generator->generateClass($interceptorClassName);
- if (\Magento\Framework\Code\Generator::GENERATION_SUCCESS == $generatorResult) {
+ if (\Magento\Framework\Code\Generator::GENERATION_ERROR !== $generatorResult) {
$result = true;
}
- $this->assertTrue($result);
+ $this->assertTrue($result, 'Failed asserting that \'' . (string)$generatorResult . '\' equals \'success\'.');
if (\Magento\Framework\Code\Generator::GENERATION_SUCCESS == $generatorResult) {
$content = $this->_clearDocBlock(
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceFactory.php b/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceFactory.php
index 33715140c646bc6254c701360c2c1c506ace89be..0f71616177cb8053a8e183d44d0d33037aeb308b 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceFactory.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceFactory.php
@@ -30,7 +30,7 @@ class SourceClassWithNamespaceFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -44,10 +44,10 @@ class SourceClassWithNamespaceFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $instanceName = 'Magento\Framework\Code\GeneratorTest\SourceClassWithNamespace')
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\Framework\Code\GeneratorTest\SourceClassWithNamespace')
{
$this->_objectManager = $objectManager;
$this->_instanceName = $instanceName;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceInterceptor.php b/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceInterceptor.php
index b649edb4a6deb23da5a7cd3cec2324a647555572..0df3ee6ab76e9ad003eb4effdb016b4f409aa1e8 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceInterceptor.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceInterceptor.php
@@ -28,21 +28,21 @@ class Interceptor extends \Magento\Framework\Code\GeneratorTest\SourceClassWithN
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $pluginLocator = null;
/**
* List of plugins
*
- * @var \Magento\Framework\Interception\PluginList
+ * @var \Magento\Framework\Interception\PluginListInterface
*/
protected $pluginList = null;
/**
* Invocation chain
*
- * @var \Magento\Framework\Interception\Chain
+ * @var \Magento\Framework\Interception\ChainInterface
*/
protected $chain = null;
@@ -53,7 +53,7 @@ class Interceptor extends \Magento\Framework\Code\GeneratorTest\SourceClassWithN
*/
protected $subjectType = null;
- public function __construct(\Magento\Framework\ObjectManager $pluginLocator, \Magento\Framework\Interception\PluginList $pluginList, \Magento\Framework\Interception\Chain $chain, $param1 = '', $param2 = '\\', $param3 = '\'')
+ public function __construct(\Magento\Framework\ObjectManagerInterface $pluginLocator, \Magento\Framework\Interception\PluginListInterface $pluginList, \Magento\Framework\Interception\ChainInterface $chain, $param1 = '', $param2 = '\\', $param3 = '\'')
{
$this->pluginLocator = $pluginLocator;
$this->pluginList = $pluginList;
@@ -79,8 +79,8 @@ class Interceptor extends \Magento\Framework\Code\GeneratorTest\SourceClassWithN
public function __wakeup()
{
$this->pluginLocator = \Magento\Framework\App\ObjectManager::getInstance();
- $this->pluginList = $this->pluginLocator->get('Magento\Framework\Interception\PluginList');
- $this->chain = $this->pluginLocator->get('Magento\Framework\Interception\Chain');
+ $this->pluginList = $this->pluginLocator->get('Magento\Framework\Interception\PluginListInterface');
+ $this->chain = $this->pluginLocator->get('Magento\Framework\Interception\ChainInterface');
$this->subjectType = get_parent_class($this);
}
@@ -88,8 +88,8 @@ class Interceptor extends \Magento\Framework\Code\GeneratorTest\SourceClassWithN
{
$capMethod = ucfirst($method);
$result = null;
- if (isset($pluginInfo[\Magento\Framework\Interception\Definition::LISTENER_BEFORE])) {
- foreach ($pluginInfo[\Magento\Framework\Interception\Definition::LISTENER_BEFORE] as $code) {
+ if (isset($pluginInfo[\Magento\Framework\Interception\DefinitionInterface::LISTENER_BEFORE])) {
+ foreach ($pluginInfo[\Magento\Framework\Interception\DefinitionInterface::LISTENER_BEFORE] as $code) {
$beforeResult = call_user_func_array(
array($this->pluginList->getPlugin($this->subjectType, $code), 'before'. $capMethod), array_merge(array($this), $arguments)
);
@@ -98,11 +98,11 @@ class Interceptor extends \Magento\Framework\Code\GeneratorTest\SourceClassWithN
}
}
}
- if (isset($pluginInfo[\Magento\Framework\Interception\Definition::LISTENER_AROUND])) {
+ if (isset($pluginInfo[\Magento\Framework\Interception\DefinitionInterface::LISTENER_AROUND])) {
$chain = $this->chain;
$type = $this->subjectType;
$subject = $this;
- $code = $pluginInfo[\Magento\Framework\Interception\Definition::LISTENER_AROUND];
+ $code = $pluginInfo[\Magento\Framework\Interception\DefinitionInterface::LISTENER_AROUND];
$next = function () use ($chain, $type, $method, $subject, $code) {
return $chain->invokeNext($type, $method, $subject, func_get_args(), $code);
};
@@ -113,8 +113,8 @@ class Interceptor extends \Magento\Framework\Code\GeneratorTest\SourceClassWithN
} else {
$result = call_user_func_array(array('parent', $method), $arguments);
}
- if (isset($pluginInfo[\Magento\Framework\Interception\Definition::LISTENER_AFTER])) {
- foreach ($pluginInfo[\Magento\Framework\Interception\Definition::LISTENER_AFTER] as $code) {
+ if (isset($pluginInfo[\Magento\Framework\Interception\DefinitionInterface::LISTENER_AFTER])) {
+ foreach ($pluginInfo[\Magento\Framework\Interception\DefinitionInterface::LISTENER_AFTER] as $code) {
$result = $this->pluginList->getPlugin($this->subjectType, $code)
->{'after' . $capMethod}($this, $result);
}
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceProxy.php b/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceProxy.php
index 10975b1d175508ea4ece5e18d281047f096273e1..ffc95d87110b995aea01aab985143b1789eab4bb 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceProxy.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Code/_expected/SourceClassWithNamespaceProxy.php
@@ -30,7 +30,7 @@ class Proxy extends \Magento\Framework\Code\GeneratorTest\SourceClassWithNamespa
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -58,11 +58,11 @@ class Proxy extends \Magento\Framework\Code\GeneratorTest\SourceClassWithNamespa
/**
* Proxy constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
* @param bool $shared
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $instanceName = 'Magento\Framework\Code\GeneratorTest\SourceClassWithNamespace', $shared = true)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\Framework\Code\GeneratorTest\SourceClassWithNamespace', $shared = true)
{
$this->_objectManager = $objectManager;
$this->_instanceName = $instanceName;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Code/Generator/FileResolverTest.php b/dev/tests/integration/testsuite/Magento/Framework/Filesystem/FileResolverTest.php
similarity index 90%
rename from dev/tests/integration/testsuite/Magento/Framework/Code/Generator/FileResolverTest.php
rename to dev/tests/integration/testsuite/Magento/Framework/Filesystem/FileResolverTest.php
index b6693448211e332cd2b62c0d66ec5e8baf99d1f6..ef9961d53efb920fad4bd537fc53e3e51ca5d37c 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Code/Generator/FileResolverTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Filesystem/FileResolverTest.php
@@ -1,6 +1,6 @@
<?php
/**
- * Integration test for \Magento\Framework\Code\Generator\FileResolver
+ * Integration test for \Magento\Framework\Filesystem\FileResolver
*
* Magento
*
@@ -23,7 +23,7 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\Framework\Code\Generator;
+namespace Magento\Framework\Filesystem;
use Magento\TestFramework\Helper\Bootstrap;
@@ -41,7 +41,7 @@ class FileResolverTest extends \PHPUnit_Framework_TestCase
const SECOND_PATH = '/path/to/code/2/';
/**
- * @var \Magento\Framework\Code\Generator\FileResolver
+ * @var \Magento\Framework\Filesystem\FileResolver
*/
protected $model;
@@ -52,7 +52,7 @@ class FileResolverTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
- $this->model = Bootstrap::getObjectManager()->create('Magento\Framework\Code\Generator\FileResolver');
+ $this->model = Bootstrap::getObjectManager()->create('Magento\Framework\Filesystem\FileResolver');
$this->originalPath = get_include_path();
set_include_path('/pre/existing/paths/');
}
@@ -88,7 +88,7 @@ class FileResolverTest extends \PHPUnit_Framework_TestCase
public function testGetFile()
{
- $includePath = realpath(__DIR__ . '/../_files/');
+ $includePath = realpath(__DIR__ . '/_files/');
$className = '\ClassToFind';
$this->model->addIncludePath($includePath);
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Code/_files/ClassToFind.php b/dev/tests/integration/testsuite/Magento/Framework/Filesystem/_files/ClassToFind.php
similarity index 94%
rename from dev/tests/integration/testsuite/Magento/Framework/Code/_files/ClassToFind.php
rename to dev/tests/integration/testsuite/Magento/Framework/Filesystem/_files/ClassToFind.php
index a760065840757efc0ace624db1e18ed5c2fec802..55bdd01c2b02d89d078a87631185acce7fd58a8c 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Code/_files/ClassToFind.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Filesystem/_files/ClassToFind.php
@@ -23,5 +23,5 @@
*
* Exists for testing FileResolver.
*
- * \Magento\Framework\Code\Generator\FileResolverTest
+ * \Magento\Framework\Filesystem\FileResolverTest
*/
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/GeneralTest.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/GeneralTest.php
index eeb209322e86a77ca1da26250a40575f12f2bb41..0a58cd006e7b3b35542e4446385fbea7b9756cfe 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Interception/GeneralTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Interception/GeneralTest.php
@@ -36,7 +36,7 @@ class GeneralTest extends \PHPUnit_Framework_TestCase
protected $_configReader;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -102,10 +102,10 @@ class GeneralTest extends \PHPUnit_Framework_TestCase
'Magento\Framework\Config\CacheInterface' => $cache,
'Magento\Framework\Config\ScopeInterface' => $configScope,
'Magento\Framework\Config\ReaderInterface' => $this->_configReader,
- 'Magento\Framework\ObjectManager\Relations' => $relations,
- 'Magento\Framework\ObjectManager\Config' => $config,
- 'Magento\Framework\ObjectManager\Definition' => $definitions,
- 'Magento\Framework\Interception\Definition' => $interceptionDefinitions
+ 'Magento\Framework\ObjectManager\RelationsInterface' => $relations,
+ 'Magento\Framework\ObjectManager\ConfigInterface' => $config,
+ 'Magento\Framework\ObjectManager\DefinitionInterface' => $definitions,
+ 'Magento\Framework\Interception\DefinitionInterface' => $interceptionDefinitions
)
);
$factory->setObjectManager($this->_objectManager);
@@ -113,9 +113,9 @@ class GeneralTest extends \PHPUnit_Framework_TestCase
$config->extend(
array(
'preferences' => array(
- 'Magento\Framework\Interception\PluginList' =>
+ 'Magento\Framework\Interception\PluginListInterface' =>
'Magento\Framework\Interception\PluginList\PluginList',
- 'Magento\Framework\Interception\Chain' => 'Magento\Framework\Interception\Chain\Chain'
+ 'Magento\Framework\Interception\ChainInterface' => 'Magento\Framework\Interception\Chain\Chain'
)
)
);
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Less/File/Collector/AggregatedTest.php b/dev/tests/integration/testsuite/Magento/Framework/Less/File/Collector/AggregatedTest.php
index adbd2df7ec6c7790a63025524b77ce886b4e1196..9c7b44010bcaab8c8e7279a4e1b8a36f84fe309e 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Less/File/Collector/AggregatedTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Less/File/Collector/AggregatedTest.php
@@ -34,7 +34,7 @@ class AggregatedTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Message/CollectionFactoryTest.php b/dev/tests/integration/testsuite/Magento/Framework/Message/CollectionFactoryTest.php
index f014fff2b3f01e5f9b391997f9711d6de81c4c44..33519347184200d5c6e9fea3d044550c58fb6086 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Message/CollectionFactoryTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Message/CollectionFactoryTest.php
@@ -34,7 +34,7 @@ class CollectionFactoryTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Message/FactoryTest.php b/dev/tests/integration/testsuite/Magento/Framework/Message/FactoryTest.php
index 4043e96b4e268c31c4a18c712ad7044b2dfea8fe..fd987ff283bdcd25b171b43c6a56a518ad2a1dfe 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Message/FactoryTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Message/FactoryTest.php
@@ -34,7 +34,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Message/ManagerTest.php b/dev/tests/integration/testsuite/Magento/Framework/Message/ManagerTest.php
index 4f8a87b280b37c1dc733443f7b996cccb1bedabb..3cc034ea8f5ff7c071b082c28404868bebe7e5e4 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Message/ManagerTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Message/ManagerTest.php
@@ -34,7 +34,7 @@ class ManagerTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Mview/View/ChangelogTest.php b/dev/tests/integration/testsuite/Magento/Framework/Mview/View/ChangelogTest.php
index fa806c30b409b1fb7bf7c3f1d3ae2dccfaf7aa66..7abeb7052903f9b4a1a236463c4c8b26d03951c6 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Mview/View/ChangelogTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Mview/View/ChangelogTest.php
@@ -29,7 +29,7 @@ namespace Magento\Framework\Mview\View;
class ChangelogTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/ObjectManager/ObjectManagerTest.php b/dev/tests/integration/testsuite/Magento/Framework/ObjectManager/ObjectManagerTest.php
index 9aa87796703deb8205509ebc12d6490266ee61e6..b0fde988c73dd0e66b990192ae225aede3437078 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/ObjectManager/ObjectManagerTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/ObjectManager/ObjectManagerTest.php
@@ -46,7 +46,7 @@ class ObjectManagerTest extends \PHPUnit_Framework_TestCase
/**#@-*/
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected static $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Search/Adapter/Mysql/AdapterTest.php b/dev/tests/integration/testsuite/Magento/Framework/Search/Adapter/Mysql/AdapterTest.php
index cadca8190c33d4d64f3cc671cdb4c9396549cfac..83ef1d8e1939ff07f95ccf1df7f315ea7ff96bcb 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Search/Adapter/Mysql/AdapterTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Search/Adapter/Mysql/AdapterTest.php
@@ -39,7 +39,7 @@ class AdapterTest extends \PHPUnit_Framework_TestCase
private $requestBuilder;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Search/Adapter/Mysql/Builder/Query/MatchTest.php b/dev/tests/integration/testsuite/Magento/Framework/Search/Adapter/Mysql/Builder/Query/MatchTest.php
index 3c6c9e96e50d12e07a912db6281c0cef785e179c..e1b37438fefcc4996f0a61320c0465f2ebae9105 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Search/Adapter/Mysql/Builder/Query/MatchTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Search/Adapter/Mysql/Builder/Query/MatchTest.php
@@ -30,7 +30,7 @@ use Magento\TestFramework\Helper\Bootstrap;
class MatchTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php b/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php
index 409158bb2cde8e66fb98d6131f263c18f600a2fe..65993f65d7daf46dc3fffef0aa7229ca40d7dd09 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php
@@ -24,7 +24,7 @@
namespace Magento\Framework\Stdlib\Cookie;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\TestFramework\Helper\Bootstrap;
/**
@@ -34,7 +34,7 @@ use Magento\TestFramework\Helper\Bootstrap;
class CookieScopeTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieManagerTest.php b/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieManagerTest.php
index 703796cb68a8f86bd7d9669c572c31cf8fd08c7b..cd7d475bc875914289e9be9c19688024426ec15d 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieManagerTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieManagerTest.php
@@ -34,7 +34,7 @@ class PhpCookieManagerTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Framework/TranslateTest.php b/dev/tests/integration/testsuite/Magento/Framework/TranslateTest.php
index 14021f309ee629166013fd7c6e082b6d91818fe2..f07c60827c88378a29929777875293089d76f92d 100644
--- a/dev/tests/integration/testsuite/Magento/Framework/TranslateTest.php
+++ b/dev/tests/integration/testsuite/Magento/Framework/TranslateTest.php
@@ -86,7 +86,7 @@ class TranslateTest extends \PHPUnit_Framework_TestCase
$objectManager->get('Magento\Framework\View\Design\Theme\FlyweightFactory'),
$objectManager->get('Magento\Framework\App\Config\ScopeConfigInterface'),
$objectManager->get('Magento\Core\Model\ThemeFactory'),
- $objectManager->get('Magento\Framework\ObjectManager'),
+ $objectManager->get('Magento\Framework\ObjectManagerInterface'),
$objectManager->get('Magento\Framework\App\State'),
array('frontend' => 'test_default')
)
diff --git a/dev/tests/integration/testsuite/Magento/GoogleShopping/Model/Attribute/TaxTest.php b/dev/tests/integration/testsuite/Magento/GoogleShopping/Model/Attribute/TaxTest.php
index 4cf0b75d35d711d530e0685092ab3bd7b0675008..b8081b001b9a00762fbb9ed6b24b1d7a49ae8c8c 100644
--- a/dev/tests/integration/testsuite/Magento/GoogleShopping/Model/Attribute/TaxTest.php
+++ b/dev/tests/integration/testsuite/Magento/GoogleShopping/Model/Attribute/TaxTest.php
@@ -40,7 +40,7 @@ class TaxTest extends \PHPUnit_Framework_TestCase
protected $googleShoppingTaxAttribute;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/AddressesTest.php b/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/AddressesTest.php
index 3898e3eedf22a6413645a0b2efe62a8ddf3a7c5d..4816646252bc75213b442b5ddc28c1e0ec32e5a3 100644
--- a/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/AddressesTest.php
+++ b/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/AddressesTest.php
@@ -38,7 +38,7 @@ class AddressesTest extends \PHPUnit_Framework_TestCase
protected $_addresses;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php b/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php
index 690c52581b1675008aaecdf4cb8c8ba587be8a81..959bf9fb44a142c7c4eee108c24499e3d1f40ede 100644
--- a/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php
+++ b/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php
@@ -34,7 +34,7 @@ class OverviewTest extends \PHPUnit_Framework_TestCase
protected $_block;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/PayPalRecurringPayment/Model/IpnTest.php b/dev/tests/integration/testsuite/Magento/PayPalRecurringPayment/Model/IpnTest.php
index a99380733ff482af98a8b93513975a9e7448764d..b0995e76a736d3d2ef78452b8a62d47e24347aec 100644
--- a/dev/tests/integration/testsuite/Magento/PayPalRecurringPayment/Model/IpnTest.php
+++ b/dev/tests/integration/testsuite/Magento/PayPalRecurringPayment/Model/IpnTest.php
@@ -29,7 +29,7 @@ namespace Magento\PayPalRecurringPayment\Model;
class IpnTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Paypal/Controller/Billing/AgreementTest.php b/dev/tests/integration/testsuite/Magento/Paypal/Controller/Billing/AgreementTest.php
index 8d5ec89b9461358ee3776feb4dca0778acdebb40..7bd67b3c5deaba8130657f5eba5db878067b5f89 100644
--- a/dev/tests/integration/testsuite/Magento/Paypal/Controller/Billing/AgreementTest.php
+++ b/dev/tests/integration/testsuite/Magento/Paypal/Controller/Billing/AgreementTest.php
@@ -64,7 +64,7 @@ class AgreementTest extends \Magento\TestFramework\TestCase\AbstractController
* Disable billing agreement placement using calls to remote system
* in \Magento\Paypal\Model\Billing\Agreement::place()
*/
- $objectManagerMock = $this->getMockForAbstractClass('Magento\Framework\ObjectManager', [], '', false);
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$paymentMethodMock = $this->getMock(
'Magento\Paypal\Model\Express',
['getTitle', 'setStore', 'placeBillingAgreement'],
diff --git a/dev/tests/integration/testsuite/Magento/Paypal/Model/Express/CheckoutTest.php b/dev/tests/integration/testsuite/Magento/Paypal/Model/Express/CheckoutTest.php
index 3d9dcf86892d20d800b4ac17be8ec5d5c18165f7..ae42b4ebd720a80c40c4dccfd42ecd7daa55738f 100644
--- a/dev/tests/integration/testsuite/Magento/Paypal/Model/Express/CheckoutTest.php
+++ b/dev/tests/integration/testsuite/Magento/Paypal/Model/Express/CheckoutTest.php
@@ -31,7 +31,7 @@ use Magento\Paypal\Model\Express\Checkout;
class CheckoutTest extends \PHPUnit_Framework_TestCase
{
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
protected $_objectManager;
protected function setUp()
diff --git a/dev/tests/integration/testsuite/Magento/Paypal/Model/IpnTest.php b/dev/tests/integration/testsuite/Magento/Paypal/Model/IpnTest.php
index 74c728df6de4b09327e59f83d11e19afdbef175f..9fc7c0d9dd151f79de5d94fe0aa9959192ba5980 100644
--- a/dev/tests/integration/testsuite/Magento/Paypal/Model/IpnTest.php
+++ b/dev/tests/integration/testsuite/Magento/Paypal/Model/IpnTest.php
@@ -29,7 +29,7 @@ namespace Magento\Paypal\Model;
class IpnTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Paypal/Model/PayflowproTest.php b/dev/tests/integration/testsuite/Magento/Paypal/Model/PayflowproTest.php
index f68eefd2abe65ccaacb1b2bd333d42357cfa5aaa..0eb640e226527eab992d23d81c0b7b6ffa500f7d 100644
--- a/dev/tests/integration/testsuite/Magento/Paypal/Model/PayflowproTest.php
+++ b/dev/tests/integration/testsuite/Magento/Paypal/Model/PayflowproTest.php
@@ -27,7 +27,7 @@ namespace Magento\Paypal\Model;
class PayflowproTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Persistent/Block/Header/AdditionalTest.php b/dev/tests/integration/testsuite/Magento/Persistent/Block/Header/AdditionalTest.php
index bfb4b902b3595d362232c709226d855bed16335c..647d5776f5c952b23dac8c65eb8f544abc434e75 100644
--- a/dev/tests/integration/testsuite/Magento/Persistent/Block/Header/AdditionalTest.php
+++ b/dev/tests/integration/testsuite/Magento/Persistent/Block/Header/AdditionalTest.php
@@ -45,7 +45,7 @@ class AdditionalTest extends \PHPUnit_Framework_TestCase
protected $_customerSession;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/EmulateCustomerTest.php b/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/EmulateCustomerTest.php
index d4a7cda0711b5ebb9e37bea0ebf9da617b5f7799..d32f0ca0514ba61a7be6aff7b5630f4297e82778 100644
--- a/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/EmulateCustomerTest.php
+++ b/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/EmulateCustomerTest.php
@@ -40,7 +40,7 @@ class EmulateCustomerTest extends \PHPUnit_Framework_TestCase
protected $_persistentSessionHelper;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/EmulateQuoteTest.php b/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/EmulateQuoteTest.php
index 6564722183033720a37d0bebd80e583b1b395759..e6c97bd4625ccfb8d51f7b6aa3b37e275d2d1269 100644
--- a/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/EmulateQuoteTest.php
+++ b/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/EmulateQuoteTest.php
@@ -40,7 +40,7 @@ class EmulateQuoteTest extends \PHPUnit_Framework_TestCase
protected $_persistentSessionHelper;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/SessionTest.php b/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/SessionTest.php
index a8cc0ccb3bd6fcb147287ea1b435a371e3fac609..62a693850641bf4b24a1f08c8e8ef490090bf7aa 100644
--- a/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/SessionTest.php
+++ b/dev/tests/integration/testsuite/Magento/Persistent/Model/Observer/SessionTest.php
@@ -34,7 +34,7 @@ class SessionTest extends \PHPUnit_Framework_TestCase
protected $_model;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Persistent/Model/ObserverTest.php b/dev/tests/integration/testsuite/Magento/Persistent/Model/ObserverTest.php
index 0c72546460912e02ec7b71d47c2db11027a2934f..7be35800e42e90eb6bd10e9c2db878badc5709b6 100644
--- a/dev/tests/integration/testsuite/Magento/Persistent/Model/ObserverTest.php
+++ b/dev/tests/integration/testsuite/Magento/Persistent/Model/ObserverTest.php
@@ -24,6 +24,8 @@
namespace Magento\Persistent\Model;
+use Magento\Customer\Model\Context;
+
/**
* @magentoDataFixture Magento/Persistent/_files/persistent.php
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -51,7 +53,7 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
protected $_persistentSessionHelper;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -115,7 +117,7 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
$this->_customerSession->loginById(1);
$httpContext = new \Magento\Framework\App\Http\Context();
- $httpContext->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, 1, 1);
+ $httpContext->setValue(Context::CONTEXT_AUTH, 1, 1);
$block = $this->_objectManager->create(
'Magento\Sales\Block\Reorder\Sidebar',
[
diff --git a/dev/tests/integration/testsuite/Magento/Persistent/Model/Persistent/ConfigTest.php b/dev/tests/integration/testsuite/Magento/Persistent/Model/Persistent/ConfigTest.php
index a564c86109d8a0d21b7a30bb9c386aa692545061..9b0afbbb15f11d2b3d655280fd3e16059b12f569 100644
--- a/dev/tests/integration/testsuite/Magento/Persistent/Model/Persistent/ConfigTest.php
+++ b/dev/tests/integration/testsuite/Magento/Persistent/Model/Persistent/ConfigTest.php
@@ -34,7 +34,7 @@ class ConfigTest extends \PHPUnit_Framework_TestCase
*/
protected $_model;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
protected $_objectManager;
public function setUp()
diff --git a/dev/tests/integration/testsuite/Magento/Persistent/Model/SessionTest.php b/dev/tests/integration/testsuite/Magento/Persistent/Model/SessionTest.php
index 0446fcf542ed2caefb76bbc1d38ddf5dc1711920..65fa8cf0192a15507471190354ecde25daaeb92c 100644
--- a/dev/tests/integration/testsuite/Magento/Persistent/Model/SessionTest.php
+++ b/dev/tests/integration/testsuite/Magento/Persistent/Model/SessionTest.php
@@ -35,7 +35,7 @@ class SessionTest extends \PHPUnit_Framework_TestCase
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/ProductAlert/Model/ObserverTest.php b/dev/tests/integration/testsuite/Magento/ProductAlert/Model/ObserverTest.php
index bdaac209090968084a5e766c54d730c181a54278..638c2383f6bd8bf4e7127a5aab6a1780d4c57918 100644
--- a/dev/tests/integration/testsuite/Magento/ProductAlert/Model/ObserverTest.php
+++ b/dev/tests/integration/testsuite/Magento/ProductAlert/Model/ObserverTest.php
@@ -26,7 +26,7 @@ namespace Magento\ProductAlert\Model;
class ObserverTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Form/AddressTest.php b/dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Form/AddressTest.php
index c0bfc10e31cd2e11fd89e79243e16855137c89dc..9a7850a09d09ff58ebebb849289de1bf5b029cbb 100644
--- a/dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Form/AddressTest.php
+++ b/dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Form/AddressTest.php
@@ -30,7 +30,7 @@ namespace Magento\Sales\Block\Adminhtml\Order\Create\Form;
*/
class AddressTest extends \PHPUnit_Framework_TestCase
{
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
protected $_objectManager;
/** @var \Magento\Sales\Block\Adminhtml\Order\Create\Form\Address */
diff --git a/dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/FormTest.php b/dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/FormTest.php
index 8b395149a37f8a18e388fd6f5185d9f30fa363c2..a6a5cc608468c0fdd0fa99966093f6929756c956 100644
--- a/dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/FormTest.php
+++ b/dev/tests/integration/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/FormTest.php
@@ -35,7 +35,7 @@ class FormTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Sales\Block\Adminhtml\Order\Create\Form */
protected $_orderCreateBlock;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
protected $_objectManager;
/**
diff --git a/dev/tests/integration/testsuite/Magento/Sales/Block/Reorder/SidebarTest.php b/dev/tests/integration/testsuite/Magento/Sales/Block/Reorder/SidebarTest.php
index ef9877419cd85e3e0007017821dd9e6c17d6f2af..96fbfe7658b7371edacdc8f2de31859261a4ca6c 100644
--- a/dev/tests/integration/testsuite/Magento/Sales/Block/Reorder/SidebarTest.php
+++ b/dev/tests/integration/testsuite/Magento/Sales/Block/Reorder/SidebarTest.php
@@ -24,6 +24,8 @@
namespace Magento\Sales\Block\Reorder;
+use Magento\Customer\Model\Context;
+
class SidebarTest extends \PHPUnit_Framework_TestCase
{
/**
@@ -40,7 +42,7 @@ class SidebarTest extends \PHPUnit_Framework_TestCase
$customerSession->setCustomerId($fixtureCustomerId);
/** @var \Magento\Framework\App\Http\Context $httpContext */
$httpContext = $objectManager->get('Magento\Framework\App\Http\Context');
- $httpContext->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, true, false);
+ $httpContext->setValue(Context::CONTEXT_AUTH, true, false);
/** Execute SUT implicitly: initOrders() is called in the construct */
/** @var \Magento\Sales\Block\Reorder\Sidebar $sidebarBlock */
@@ -70,7 +72,7 @@ class SidebarTest extends \PHPUnit_Framework_TestCase
$customerSession->setCustomerId($secondCustomer->getId());
/** @var \Magento\Framework\App\Http\Context $httpContext */
$httpContext = $objectManager->get('Magento\Framework\App\Http\Context');
- $httpContext->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, true, false);
+ $httpContext->setValue(Context::CONTEXT_AUTH, true, false);
/** Execute SUT implicitly: initOrders() is called in the construct */
/** @var \Magento\Sales\Block\Reorder\Sidebar $sidebarBlock */
diff --git a/dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/CreditmemoTest.php b/dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/CreditmemoTest.php
index b1e58b0200e58b0c9c8fa9a365d6251c23876c69..b3391f03cfd25c081371a7dd90dbb67cb1c7c11a 100644
--- a/dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/CreditmemoTest.php
+++ b/dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/CreditmemoTest.php
@@ -35,33 +35,28 @@ class CreditmemoTest extends \Magento\Backend\Utility\Controller
public function testAddCommentAction()
{
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
- /** @var \Magento\CatalogInventory\Model\Stock\Status $status */
- $status = $objectManager->get('Magento\CatalogInventory\Model\Stock\Status');
- $status->updateStatus(1);
- /** @var \Magento\CatalogInventory\Model\Stock\Item $stockItem */
- $stockItem = $objectManager->create('Magento\CatalogInventory\Model\Stock\Item');
- $stockItem->loadByProduct(1);
- $this->assertEquals(95, $stockItem->getStockQty());
- $stockItem = null;
+ /** @var \Magento\CatalogInventory\Api\StockIndexInterface $stockIndex */
+ $stockIndex = $objectManager->get('Magento\CatalogInventory\Api\StockIndexInterface');
+ $stockIndex->rebuild(1, 1);
+
+ /** @var \Magento\CatalogInventory\Api\StockStateInterface $stockState */
+ $stockState = $objectManager->create('Magento\CatalogInventory\Api\StockStateInterface');
+ $this->assertEquals(95, $stockState->getStockQty(1, 1));
/** @var \Magento\Sales\Model\Order $order */
$order = $objectManager->create('Magento\Sales\Model\Order');
$order->load('100000001', 'increment_id');
-
$items = $order->getCreditmemosCollection()->getItems();
$creditmemo = array_shift($items);
$comment = 'Test Comment 02';
-
$this->getRequest()->setParam('creditmemo_id', $creditmemo->getId());
$this->getRequest()->setPost('comment', array('comment' => $comment));
$this->dispatch('backend/sales/order_creditmemo/addComment/id/' . $creditmemo->getId());
-
$html = $this->getResponse()->getBody();
-
$this->assertContains($comment, $html);
- /** @var \Magento\CatalogInventory\Model\Stock\Item $stockItem */
- $stockItem = $objectManager->create('Magento\CatalogInventory\Model\Stock\Item');
- $stockItem->loadByProduct(1);
- $this->assertEquals(95, $stockItem->getStockQty());
+
+ /** @var \Magento\CatalogInventory\Api\StockStateInterface $stockState */
+ $stockState = $objectManager->create('Magento\CatalogInventory\Api\StockStateInterface');
+ $this->assertEquals(95, $stockState->getStockQty(1, 1));
}
}
diff --git a/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php b/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
index 494242ecbe74a30ad9dde224c203f4a9e37ce298..62ace2b86289411bc7ccef880cb597bcf0724ff9 100644
--- a/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
+++ b/dev/tests/integration/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
@@ -217,7 +217,7 @@ class CreateTest extends \PHPUnit_Framework_TestCase
$addressData,
array(
'address_type' => 'billing',
- 'quote_id' => null,
+ 'quote_id' => $this->_model->getQuote()->getId(),
'street' => "Line1\nLine2",
'save_in_address_book' => 0
)
diff --git a/dev/tests/integration/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php b/dev/tests/integration/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php
index d96f8f79959f1b1f803736b2f04272003489b95d..48ae9f88d3745a78a03def28f66555811ec6cb5f 100644
--- a/dev/tests/integration/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php
+++ b/dev/tests/integration/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php
@@ -47,7 +47,7 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase
*/
public function testChangeQuoteCustomerGroupIdForCustomerWithDisabledAutomaticGroupChange()
{
- /** @var \Magento\Framework\ObjectManager $objectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface $objectManager */
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
/** @var $customer \Magento\Customer\Model\Customer */
@@ -83,7 +83,7 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase
*/
public function testChangeQuoteCustomerGroupIdForCustomerWithEnabledAutomaticGroupChange()
{
- /** @var \Magento\Framework\ObjectManager $objectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface $objectManager */
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
/** @var $customer \Magento\Customer\Model\Customer */
diff --git a/dev/tests/integration/testsuite/Magento/Store/Model/StoreTest.php b/dev/tests/integration/testsuite/Magento/Store/Model/StoreTest.php
index 409164110e1aece7e0b02dee2ef7383a0fa3ca1a..c75f99f3a9b4194f626ab56aeebc08e7edd4d72d 100644
--- a/dev/tests/integration/testsuite/Magento/Store/Model/StoreTest.php
+++ b/dev/tests/integration/testsuite/Magento/Store/Model/StoreTest.php
@@ -69,7 +69,7 @@ class StoreTest extends \PHPUnit_Framework_TestCase
'storeManager' => $objectManager->get('Magento\Store\Model\StoreManager'),
'sidResolver' => $objectManager->get('Magento\Framework\Session\SidResolverInterface'),
'cookieMetadataFactory' => $objectManager->get('Magento\Framework\Stdlib\Cookie\CookieMetadataFactory'),
- 'cookieManager' => $objectManager->get('Magento\Framework\Stdlib\CookieManager'),
+ 'cookieManager' => $objectManager->get('Magento\Framework\Stdlib\CookieManagerInterface'),
'httpContext' => $objectManager->get('Magento\Framework\App\Http\Context'),
'session' => $objectManager->get('Magento\Framework\Session\SessionManagerInterface'),
'currencyFactory' => $objectManager->get('Magento\Directory\Model\CurrencyFactory'),
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Block/Adminhtml/Rate/FormTest.php b/dev/tests/integration/testsuite/Magento/Tax/Block/Adminhtml/Rate/FormTest.php
index 3ae6719b1fea296cba8ad18bc25fe927daf5f8d2..262e176a0defadd3d3c40e210f7ef70151a65c88 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Block/Adminhtml/Rate/FormTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Block/Adminhtml/Rate/FormTest.php
@@ -28,7 +28,7 @@ use Magento\TestFramework\Helper\Bootstrap;
class FormTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Block/Adminhtml/Rule/Edit/FormTest.php b/dev/tests/integration/testsuite/Magento/Tax/Block/Adminhtml/Rule/Edit/FormTest.php
index dfe84657d0f1ec7d9a6fd4bcf4b803da270418a5..07e4b166ca4cafefa4ddafdbf4eecb9252ac7ae1 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Block/Adminhtml/Rule/Edit/FormTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Block/Adminhtml/Rule/Edit/FormTest.php
@@ -26,7 +26,7 @@ namespace Magento\Tax\Block\Adminhtml\Rule\Edit;
class FormTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Helper/DataTest.php b/dev/tests/integration/testsuite/Magento/Tax/Helper/DataTest.php
index a60008ed37d6365a141e086d26ac50dfeb34283e..771ccf58a007231a0c0319595cd0ea5d9f726c3c 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Helper/DataTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Helper/DataTest.php
@@ -35,7 +35,7 @@ class DataTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Model/Calculation/Rate/ConverterTest.php b/dev/tests/integration/testsuite/Magento/Tax/Model/Calculation/Rate/ConverterTest.php
index 57529c8258471de10df4562b1416ac4e2bd004bc..171cb57c9c36832a38e193285336856f177d017e 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Model/Calculation/Rate/ConverterTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Model/Calculation/Rate/ConverterTest.php
@@ -26,7 +26,7 @@ namespace Magento\Tax\Model\Calculation\Rate;
class ConverterTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SetupUtil.php b/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SetupUtil.php
index 968720cc7a532e97b254732a512aa2a3da6472f4..67bfd3dbd31254a7c2f8c75b9b94c61b41df12bd 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SetupUtil.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SetupUtil.php
@@ -158,12 +158,12 @@ class SetupUtil
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
var $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
public function __construct($objectManager)
{
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SubtotalTest.php b/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SubtotalTest.php
index 2fa9114c65b146de8ebe57089371bedb04251847..bd273f586ec5addf57bcb2559216320895473c89 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SubtotalTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SubtotalTest.php
@@ -36,7 +36,7 @@ class SubtotalTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php b/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php
index 478f2549796492b75965cca29bba44d9ae6e4ad3..7a914c5af42f61c012960c3dcfef1fd73024eec7 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php
@@ -264,7 +264,7 @@ class TaxTest extends \PHPUnit_Framework_TestCase
*/
public function testTaxCalculation($configData, $quoteData, $expectedResults)
{
- /** @var \Magento\Framework\ObjectManager $objectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface $objectManager */
$objectManager = Bootstrap::getObjectManager();
//Setup tax configurations
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Pricing/Price/Plugin/AttributePriceTest.php b/dev/tests/integration/testsuite/Magento/Tax/Pricing/Price/Plugin/AttributePriceTest.php
index f1ae5b55957db737217535299d9a3676b6dc7ac4..bca09ad4c0c9907683c2fffbb640fb07178e872d 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Pricing/Price/Plugin/AttributePriceTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Pricing/Price/Plugin/AttributePriceTest.php
@@ -37,7 +37,7 @@ use Magento\Tax\Model\Config;
class AttributePriceTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/QuoteDetails/ItemBuilderTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/QuoteDetails/ItemBuilderTest.php
index 90ec5364aff509a2b2ebcc5db9818e7276bd324c..8518cd80b7b3d0e94771f2b5526bc44bc5e645c9 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/QuoteDetails/ItemBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/QuoteDetails/ItemBuilderTest.php
@@ -31,7 +31,7 @@ class ItemBuilderTest extends \PHPUnit_Framework_TestCase
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/QuoteDetailsBuilderTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/QuoteDetailsBuilderTest.php
index dd69938b3cfd1bb915a4d7362142b7534a20b601..79757c8ca1ca6342e668751084496b441171601b 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/QuoteDetailsBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/QuoteDetailsBuilderTest.php
@@ -26,7 +26,7 @@ namespace Magento\Tax\Service\V1\Data;
class QuoteDetailsBuilderTest extends \PHPUnit_Framework_TestCase
{
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
private $objectManager;
/** @var QuoteDetailsBuilder */
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetails/AppliedTaxBuilderTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetails/AppliedTaxBuilderTest.php
index c77d29612928285ee385274229ef64af56c6af66..a4319a028d32af7ff591722a46b5525fce787ccc 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetails/AppliedTaxBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetails/AppliedTaxBuilderTest.php
@@ -31,7 +31,7 @@ class AppliedTaxBuilderTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetails/ItemBuilderTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetails/ItemBuilderTest.php
index eea950fd93021cdc59fc303a1ac1fb4edf04be72..e3d16950c981d660ca3bdd6295d616f47a67cd37 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetails/ItemBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetails/ItemBuilderTest.php
@@ -29,7 +29,7 @@ class ItemBuilderTest extends \PHPUnit_Framework_TestCase
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetailsBuilderTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetailsBuilderTest.php
index 654eff8488f23f9dc97f1f66f0feb6bbecf2dfbd..c3c5690ff01b9aa54bfb2883c165d72a880ed2b3 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetailsBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxDetailsBuilderTest.php
@@ -29,7 +29,7 @@ class TaxDetailsBuilderTest extends \PHPUnit_Framework_TestCase
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRateBuilderTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRateBuilderTest.php
index 4750e289ff0dba7f10fa771df94fa9b798df682f..abe9c9fa897b87a405d477e7c74040d19e6e8605 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRateBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRateBuilderTest.php
@@ -31,7 +31,7 @@ class TaxRateBuilderTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRateSearchResultsBuilderTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRateSearchResultsBuilderTest.php
index 00f707e44af33bd25b89e0c0545948fd87edf2c6..41d70eb71636721543833520bf9ef589f6719b77 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRateSearchResultsBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRateSearchResultsBuilderTest.php
@@ -33,7 +33,7 @@ class TaxRateSearchResultsBuilderTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRuleBuilderTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRuleBuilderTest.php
index a201cbd32d98f55c76fd6066ca46f116983e20a8..1f83ebb5a24a16331662b888d13deb9641b2b3da 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRuleBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRuleBuilderTest.php
@@ -31,7 +31,7 @@ class TaxRuleBuilderTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRuleSearchResultsBuilderTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRuleSearchResultsBuilderTest.php
index 34923ed3227df08b1c7de2dfb2b4e259d3e92b98..2d314a129e2c5a694f41bba9fb3f88e6de00b53c 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRuleSearchResultsBuilderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/Data/TaxRuleSearchResultsBuilderTest.php
@@ -33,7 +33,7 @@ class TaxRuleSearchResultsBuilderTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxCalculationServiceTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxCalculationServiceTest.php
index 491a0d9d3f5ac11061cd8ca574b43c8a95aecb62..927b809440544a8de65c175cd304488774ca8355 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxCalculationServiceTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxCalculationServiceTest.php
@@ -36,7 +36,7 @@ class TaxCalculationServiceTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxClassServiceTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxClassServiceTest.php
index e693a437546bef80832e120199f4deacac296094..78f99cc502ec7e9739d6dcc2141fcdca78833724 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxClassServiceTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxClassServiceTest.php
@@ -48,7 +48,7 @@ class TaxClassServiceTest extends \PHPUnit_Framework_TestCase
private $taxClassModel;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRateServiceTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRateServiceTest.php
index 5e1c2f2a1396c280a75cc37ae2d67f2c7f9f5b83..c46ea6033d0392bfc1d98e9e3a6f530af8b5315c 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRateServiceTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRateServiceTest.php
@@ -35,7 +35,7 @@ class TaxRateServiceTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRuleFixtureFactory.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRuleFixtureFactory.php
index 05bc7949f68e99591537ab4c1d3a5eb5bfb14dc6..3c0fee2680ad8c8e44fd1ab8c2949a7b3137cc35 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRuleFixtureFactory.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRuleFixtureFactory.php
@@ -33,7 +33,7 @@ class TaxRuleFixtureFactory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRuleServiceTest.php b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRuleServiceTest.php
index bda2161bd2b8f59a7879b600de1c9b0e9f6ce98d..658105e12dff7573efa07bc62031b7ab711dcdda 100644
--- a/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRuleServiceTest.php
+++ b/dev/tests/integration/testsuite/Magento/Tax/Service/V1/TaxRuleServiceTest.php
@@ -41,7 +41,7 @@ class TaxRuleServiceTest extends \PHPUnit_Framework_TestCase
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/BlockInstantiationTest.php b/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/BlockInstantiationTest.php
index 4290650afd8637d7107bc9bfb169014c964efd8b..2d0d6809576920123c2c106ee5b0a0cc947870c9 100644
--- a/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/BlockInstantiationTest.php
+++ b/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/BlockInstantiationTest.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Test\Integrity\Modular;
+use Magento\Customer\Model\Context;
+
/**
* This test ensures that all blocks have the appropriate constructor arguments that allow
* them to be instantiated via the objectManager.
@@ -46,9 +48,9 @@ class BlockInstantiationTest extends \Magento\TestFramework\TestCase\AbstractInt
$context = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(
'Magento\Framework\App\Http\Context'
);
- $context->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, false, false);
+ $context->setValue(Context::CONTEXT_AUTH, false, false);
$context->setValue(
- \Magento\Customer\Helper\Data::CONTEXT_GROUP,
+ Context::CONTEXT_GROUP,
\Magento\Customer\Service\V1\CustomerGroupServiceInterface::NOT_LOGGED_IN_ID,
\Magento\Customer\Service\V1\CustomerGroupServiceInterface::NOT_LOGGED_IN_ID
);
diff --git a/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/TemplateFilesTest.php b/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/TemplateFilesTest.php
index 0c2457f83581dcf635c208716ec32e6f3cdeae05..1f08c6b68099a77958f61b40f90523af4327a528 100644
--- a/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/TemplateFilesTest.php
+++ b/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/TemplateFilesTest.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Test\Integrity\Modular;
+use Magento\Customer\Model\Context;
+
/**
* @magentoAppIsolation
*/
@@ -116,9 +118,9 @@ class TemplateFilesTest extends \Magento\TestFramework\TestCase\AbstractIntegrit
$context = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(
'Magento\Framework\App\Http\Context'
);
- $context->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, false, false);
+ $context->setValue(Context::CONTEXT_AUTH, false, false);
$context->setValue(
- \Magento\Customer\Helper\Data::CONTEXT_GROUP,
+ Context::CONTEXT_GROUP,
\Magento\Customer\Service\V1\CustomerGroupServiceInterface::NOT_LOGGED_IN_ID,
\Magento\Customer\Service\V1\CustomerGroupServiceInterface::NOT_LOGGED_IN_ID
);
diff --git a/dev/tests/integration/testsuite/Magento/Theme/Block/Html/FooterTest.php b/dev/tests/integration/testsuite/Magento/Theme/Block/Html/FooterTest.php
index 777fdc92956cf3caea6532677bcdf03939762331..0e6ce1d36adb1330d5be8b0ef36b048b8b97a9b2 100644
--- a/dev/tests/integration/testsuite/Magento/Theme/Block/Html/FooterTest.php
+++ b/dev/tests/integration/testsuite/Magento/Theme/Block/Html/FooterTest.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Theme\Block\Html;
+use Magento\Customer\Model\Context;
+
class FooterTest extends \PHPUnit_Framework_TestCase
{
/**
@@ -44,7 +46,7 @@ class FooterTest extends \PHPUnit_Framework_TestCase
{
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
$context = $objectManager->get('Magento\Framework\App\Http\Context');
- $context->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, false, false);
+ $context->setValue(Context::CONTEXT_AUTH, false, false);
$block = $objectManager->get('Magento\Framework\View\LayoutInterface')
->createBlock('Magento\Theme\Block\Html\Footer');
$storeId = $objectManager->get('Magento\Framework\StoreManagerInterface')->getStore()->getId();
diff --git a/dev/tests/integration/testsuite/Magento/Theme/Block/Html/HeaderTest.php b/dev/tests/integration/testsuite/Magento/Theme/Block/Html/HeaderTest.php
index 5c04d103b51cf79731923f9b36925f99f445e558..19aec6c347ab5e152faee27560aa1f42925c05e9 100644
--- a/dev/tests/integration/testsuite/Magento/Theme/Block/Html/HeaderTest.php
+++ b/dev/tests/integration/testsuite/Magento/Theme/Block/Html/HeaderTest.php
@@ -24,6 +24,7 @@
namespace Magento\Theme\Block\Html;
+use Magento\Customer\Model\Context;
use Magento\TestFramework\Helper\Bootstrap;
/**
@@ -51,7 +52,7 @@ class HeaderTest extends \PHPUnit_Framework_TestCase
{
$objectManager = Bootstrap::getObjectManager();
$this->context = $objectManager->get('Magento\Framework\App\Http\Context');
- $this->context->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, false, false);
+ $this->context->setValue(Context::CONTEXT_AUTH, false, false);
//Setup customer session
$customerIdFromFixture = 1;
@@ -85,7 +86,7 @@ class HeaderTest extends \PHPUnit_Framework_TestCase
*/
public function testGetWelcomeLoggedIn()
{
- $this->context->setValue(\Magento\Customer\Helper\Data::CONTEXT_AUTH, true, false);
+ $this->context->setValue(Context::CONTEXT_AUTH, true, false);
$this->assertEquals('Welcome, Firstname Lastname!', $this->block->getWelcome());
}
diff --git a/dev/tests/integration/testsuite/Magento/ToolkitFramework/ApplicationTest.php b/dev/tests/integration/testsuite/Magento/ToolkitFramework/ApplicationTest.php
index d19c1b1c8542cb9c434b12716466b5289057bf3d..636a77ceb18b63859296bc39243d1012ae0d308d 100644
--- a/dev/tests/integration/testsuite/Magento/ToolkitFramework/ApplicationTest.php
+++ b/dev/tests/integration/testsuite/Magento/ToolkitFramework/ApplicationTest.php
@@ -35,7 +35,7 @@ class ApplicationTest extends \Magento\TestFramework\Indexer\TestCase
protected static $_generatorWorkingDir;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -43,7 +43,6 @@ class ApplicationTest extends \Magento\TestFramework\Indexer\TestCase
{
self::$_generatorWorkingDir = realpath(__DIR__ . '/../../../../../tools/performance-toolkit');
- (new \Magento\Framework\Autoload\IncludePath())->addIncludePath([self::$_generatorWorkingDir . '/framework']);
copy(
self::$_generatorWorkingDir . '/fixtures/tax_rates.csv',
self::$_generatorWorkingDir . '/fixtures/tax_rates.csv.bak'
@@ -86,7 +85,7 @@ class ApplicationTest extends \Magento\TestFramework\Indexer\TestCase
/**
* Get object manager
*
- * @return \Magento\Framework\ObjectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*/
public function getObjectManager()
{
@@ -99,7 +98,7 @@ class ApplicationTest extends \Magento\TestFramework\Indexer\TestCase
/**
* Reset object manager
*
- * @return \Magento\Framework\ObjectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*/
public function resetObjectManager()
{
diff --git a/dev/tests/integration/testsuite/Magento/UrlRewrite/Block/Catalog/Edit/FormTest.php b/dev/tests/integration/testsuite/Magento/UrlRewrite/Block/Catalog/Edit/FormTest.php
index 0f710cf5316a9598052f5211fc104a46a8ecce76..5b49c8f298c6c4eeae698e31ec4ccd01efaf2193 100644
--- a/dev/tests/integration/testsuite/Magento/UrlRewrite/Block/Catalog/Edit/FormTest.php
+++ b/dev/tests/integration/testsuite/Magento/UrlRewrite/Block/Catalog/Edit/FormTest.php
@@ -30,7 +30,7 @@ namespace Magento\UrlRewrite\Block\Catalog\Edit;
class FormTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Wishlist/Helper/DataTest.php b/dev/tests/integration/testsuite/Magento/Wishlist/Helper/DataTest.php
index 0dab87ade976ab051c1b22a67ae276d503b3e108..e3713db0c72d24f8c868f9cf9cbf751b1dde3231 100644
--- a/dev/tests/integration/testsuite/Magento/Wishlist/Helper/DataTest.php
+++ b/dev/tests/integration/testsuite/Magento/Wishlist/Helper/DataTest.php
@@ -31,7 +31,7 @@ class DataTest extends \Magento\TestFramework\TestCase\AbstractController
private $_wishlistHelper;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Wishlist/Helper/RssTest.php b/dev/tests/integration/testsuite/Magento/Wishlist/Helper/RssTest.php
index fdcfe14ab230ce079862457e7cda2b90eade7956..378a5b8f9136f458ed3ab6beed42cfc2605d0259 100644
--- a/dev/tests/integration/testsuite/Magento/Wishlist/Helper/RssTest.php
+++ b/dev/tests/integration/testsuite/Magento/Wishlist/Helper/RssTest.php
@@ -39,7 +39,7 @@ class RssTest extends \PHPUnit_Framework_TestCase
protected $_coreData;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/dev/tests/integration/testsuite/Magento/Wishlist/_files/wishlist_with_product_qty_increments.php b/dev/tests/integration/testsuite/Magento/Wishlist/_files/wishlist_with_product_qty_increments.php
index 225fd2b156814689d0d5c05ead16e32335b83a4e..2e82f9c2c5a4034ae3b9d59988cc5ab6c9d17da4 100644
--- a/dev/tests/integration/testsuite/Magento/Wishlist/_files/wishlist_with_product_qty_increments.php
+++ b/dev/tests/integration/testsuite/Magento/Wishlist/_files/wishlist_with_product_qty_increments.php
@@ -25,7 +25,7 @@
require __DIR__ . '/../../../Magento/Customer/_files/customer.php';
require __DIR__ . '/../../../Magento/Catalog/_files/product_special_price.php';
-/** @var \Magento\Framework\ObjectManager $objectManager */
+/** @var \Magento\Framework\ObjectManagerInterface $objectManager */
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
/** @var \Magento\Catalog\Model\Product $product */
diff --git a/dev/tests/performance/framework/Magento/TestFramework/Application.php b/dev/tests/performance/framework/Magento/TestFramework/Application.php
index 0892bc5c528d43a7120073eb31c605db39ff34d7..8d103822979952ac779860c94c4ff4c6db597965 100644
--- a/dev/tests/performance/framework/Magento/TestFramework/Application.php
+++ b/dev/tests/performance/framework/Magento/TestFramework/Application.php
@@ -51,7 +51,7 @@ class Application
protected $_shell;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -73,12 +73,12 @@ class Application
* Constructor
*
* @param \Magento\TestFramework\Performance\Config $config
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Shell $shell
*/
public function __construct(
\Magento\TestFramework\Performance\Config $config,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Shell $shell
) {
$shellDir = $config->getApplicationBaseDir() . '/setup';
@@ -255,7 +255,7 @@ class Application
/**
* Get object manager
*
- * @return \Magento\Framework\ObjectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*/
protected function getObjectManager()
{
diff --git a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.2.0.3-1.6.2.0.4.php b/dev/tests/performance/framework/autoload.php
similarity index 76%
rename from app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.2.0.3-1.6.2.0.4.php
rename to dev/tests/performance/framework/autoload.php
index e458fc92d98432b330e05370f51ab8f75455b5cc..937de002e2f4b7d43267dc26ce8ba5cf09ec5d43 100644
--- a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.2.0.3-1.6.2.0.4.php
+++ b/dev/tests/performance/framework/autoload.php
@@ -21,15 +21,8 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
+require_once __DIR__ . '/../../../../app/autoload.php';
-/** @var $installer \Magento\Customer\Model\Resource\Setup */
-$installer = $this;
-
-$installer->cleanCache();
-
-$installer->updateAttribute(
- 'customer_address',
- 'street',
- 'backend_model',
- 'Magento\Eav\Model\Entity\Attribute\Backend\DefaultBackend'
-);
+$testsBaseDir = dirname(__DIR__);
+$autoloadWrapper = \Magento\Framework\Autoload\AutoloaderRegistry::getAutoloader();
+$autoloadWrapper->addPsr4('Magento\\TestFramework\\', $testsBaseDir . '/framework/Magento/TestFramework/');
diff --git a/dev/tests/performance/framework/bootstrap.php b/dev/tests/performance/framework/bootstrap.php
index ea2f09adfb6ebc0e13ec560d00742c2ce3f2cf0d..489decdf5d37bed6cdf077b2547fce1786f8b0fe 100644
--- a/dev/tests/performance/framework/bootstrap.php
+++ b/dev/tests/performance/framework/bootstrap.php
@@ -24,12 +24,11 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-$testsBaseDir = dirname(__DIR__);
require __DIR__ . '/../../../../app/bootstrap.php';
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
+require_once __DIR__ . '/autoload.php';
+
+$testsBaseDir = dirname(__DIR__);
$appBootstrap = \Magento\Framework\App\Bootstrap::create(BP, $_SERVER);
-$includePath->addIncludePath($testsBaseDir . '/framework');
$bootstrap = new \Magento\TestFramework\Performance\Bootstrap($appBootstrap, $testsBaseDir);
$bootstrap->cleanupReports();
return $bootstrap;
diff --git a/dev/tests/performance/framework/tests/unit/framework/bootstrap.php b/dev/tests/performance/framework/tests/unit/framework/bootstrap.php
index da691b6eebb0fe3b4ea10ac7bbd4086ea57167bc..979371e497f0a1db1d1b027e500cc6d5ed424d4c 100644
--- a/dev/tests/performance/framework/tests/unit/framework/bootstrap.php
+++ b/dev/tests/performance/framework/tests/unit/framework/bootstrap.php
@@ -23,8 +23,6 @@
*/
$magentoBaseDir = realpath(__DIR__ . '/../../../../../../../');
-
+$testsBaseDir = realpath(__DIR__ . '/../../../../');
require_once "{$magentoBaseDir}/app/bootstrap.php";
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
-$includePath->addIncludePath("{$magentoBaseDir}/dev/tests/performance/framework");
+require_once "{$testsBaseDir}/framework/autoload.php";
diff --git a/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php b/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php
index ccfc32c58acf25bcc3df828456705c11df7afed5..110d991cf2ca94b0394de5cd1ebdec867a810aeb 100644
--- a/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php
+++ b/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/ApplicationTest.php
@@ -75,7 +75,7 @@ class ApplicationTest extends \PHPUnit_Framework_TestCase
$this->_fixtureDir . '/app_base_dir'
);
$this->_shell = $this->getMock('Magento\Framework\Shell', array('execute'), array(), '', false);
- $objectManager = $this->getMockForAbstractClass('\Magento\Framework\ObjectManager');
+ $objectManager = $this->getMock('\Magento\Framework\ObjectManagerInterface');
$this->_object = $this->getMock(
'Magento\TestFramework\Application',
diff --git a/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/Performance/BootstrapTest.php b/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/Performance/BootstrapTest.php
index 7ae65442839a24ddf4451c02b44416c4d7083b71..45214b6947b68adba29af448ec1ebb334454247f 100644
--- a/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/Performance/BootstrapTest.php
+++ b/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/Performance/BootstrapTest.php
@@ -35,7 +35,7 @@ class BootstrapTest extends \PHPUnit_Framework_TestCase
$this->appBootstrap = $this->getMock('Magento\Framework\App\Bootstrap', [], [], '', false);
$dirList = $this->getMock('Magento\Framework\App\Filesystem\DirectoryList', [], [], '', false);
$dirList->expects($this->any())->method('getRoot')->will($this->returnValue(BP));
- $objectManager = $this->getMockForAbstractClass('Magento\Framework\ObjectManager');
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->appBootstrap->expects($this->any())
->method('getObjectManager')
->will($this->returnValue($objectManager));
diff --git a/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/Performance/TestsuiteTest.php b/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/Performance/TestsuiteTest.php
index bc3b4a178f1e07e98b38cf6b33eee2e38465f070..41202437bf24e38c4c015ccf7d33d04e9165ea89 100644
--- a/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/Performance/TestsuiteTest.php
+++ b/dev/tests/performance/framework/tests/unit/testsuite/Magento/Test/Performance/TestsuiteTest.php
@@ -81,7 +81,7 @@ class TestsuiteTest extends \PHPUnit_Framework_TestCase
$this->_application = $this->getMock(
'Magento\TestFramework\Application',
array('applyFixtures'),
- array($this->_config, $this->getMockForAbstractClass('Magento\Framework\ObjectManager'), $shell)
+ array($this->_config, $this->getMock('Magento\Framework\ObjectManagerInterface'), $shell)
);
$this->_handler = $this->getMockForAbstractClass(
'Magento\TestFramework\Performance\Scenario\HandlerInterface'
diff --git a/dev/tests/performance/testsuite/fixtures/catalog_100k_products.php b/dev/tests/performance/testsuite/fixtures/catalog_100k_products.php
index abd31f42c4611e20371e5f4b74191dfe38fcda19..a2276c81e7e146770d1a5137cd43fd719907e0a3 100644
--- a/dev/tests/performance/testsuite/fixtures/catalog_100k_products.php
+++ b/dev/tests/performance/testsuite/fixtures/catalog_100k_products.php
@@ -48,8 +48,7 @@ $pattern = array(
'use_config_notify_stock_qty' => '1',
'use_config_manage_stock' => '1',
'use_config_qty_increments' => '1',
- 'use_config_enable_qty_inc' => '1',
- 'stock_id' => \Magento\CatalogInventory\Model\Stock::DEFAULT_STOCK_ID
+ 'use_config_enable_qty_inc' => '1'
);
$generator = new \Magento\TestFramework\ImportExport\Fixture\Generator($pattern, 100000);
/** @var \Magento\ImportExport\Model\Import $import */
diff --git a/dev/tests/performance/testsuite/fixtures/catalog_200_categories_80k_products.php b/dev/tests/performance/testsuite/fixtures/catalog_200_categories_80k_products.php
index e2467c58b9c314f5e4afa1fd68561e19e50af705..fed2953c876a34cd5e2003b128ff81e4e04ff59e 100644
--- a/dev/tests/performance/testsuite/fixtures/catalog_200_categories_80k_products.php
+++ b/dev/tests/performance/testsuite/fixtures/catalog_200_categories_80k_products.php
@@ -106,8 +106,7 @@ $pattern = array(
'use_config_notify_stock_qty' => '1',
'use_config_manage_stock' => '1',
'use_config_qty_increments' => '1',
- 'use_config_enable_qty_inc' => '1',
- 'stock_id' => \Magento\CatalogInventory\Model\Stock::DEFAULT_STOCK_ID
+ 'use_config_enable_qty_inc' => '1'
);
$generator = new \Magento\TestFramework\ImportExport\Fixture\Generator($pattern, $productsNumber);
/** @var \Magento\ImportExport\Model\Import $import */
diff --git a/dev/tests/performance/testsuite/fixtures/catalog_category.php b/dev/tests/performance/testsuite/fixtures/catalog_category.php
index d08fe44dfa87f2391ec521e59cd3d7356950e7a5..0383661a197e6dd9c562b71a0138a2a0995a7403 100644
--- a/dev/tests/performance/testsuite/fixtures/catalog_category.php
+++ b/dev/tests/performance/testsuite/fixtures/catalog_category.php
@@ -89,8 +89,6 @@ $stockItem->setProductId(
$product->getId()
)->setTypeId(
$product->getTypeId()
-)->setStockId(
- \Magento\CatalogInventory\Model\Stock::DEFAULT_STOCK_ID
)->setIsInStock(
1
)->setQty(
diff --git a/dev/tests/performance/testsuite/fixtures/catalog_product.php b/dev/tests/performance/testsuite/fixtures/catalog_product.php
index 18dc8dfa716e57da354e7d4b358fa262711caf6b..a3cc09aca57dfe4fa13e551e548752f8a287193e 100644
--- a/dev/tests/performance/testsuite/fixtures/catalog_product.php
+++ b/dev/tests/performance/testsuite/fixtures/catalog_product.php
@@ -75,8 +75,6 @@ $stockItem->setProductId(
$product->getId()
)->setTypeId(
$product->getTypeId()
-)->setStockId(
- \Magento\CatalogInventory\Model\Stock::DEFAULT_STOCK_ID
)->setIsInStock(
1
)->setQty(
diff --git a/dev/tests/static/framework/Magento/Sniffs/NamingConventions/InterfaceNameSniff.php b/dev/tests/static/framework/Magento/Sniffs/NamingConventions/InterfaceNameSniff.php
new file mode 100644
index 0000000000000000000000000000000000000000..f8c8d60e99bb7c487a691c284d70e93d63f50850
--- /dev/null
+++ b/dev/tests/static/framework/Magento/Sniffs/NamingConventions/InterfaceNameSniff.php
@@ -0,0 +1,60 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Sniffs\NamingConventions;
+
+use PHP_CodeSniffer_Sniff;
+use PHP_CodeSniffer_File;
+
+class InterfaceNameSniff implements PHP_CodeSniffer_Sniff
+{
+ const INTERFACE_SUFFIX = 'Interface';
+
+ /**
+ * {@inheritdoc}
+ */
+ public function register()
+ {
+ return array(T_INTERFACE);
+ }
+
+ /**
+ * {@inheritdoc}
+ */
+ public function process(PHP_CodeSniffer_File $sourceFile, $stackPtr)
+ {
+ $tokens = $sourceFile->getTokens();
+ $declarationLine = $tokens[$stackPtr]['line'];
+ $suffixLength = strlen(self::INTERFACE_SUFFIX);
+ // Find first T_STRING after 'interface' keyword in the line and verify it
+ while ($tokens[$stackPtr]['line'] == $declarationLine) {
+ if ($tokens[$stackPtr]['type'] == 'T_STRING') {
+ if (substr($tokens[$stackPtr]['content'], 0 - $suffixLength) != self::INTERFACE_SUFFIX) {
+ $sourceFile->addError('Interface should have name that ends with "Interface" suffix.', $stackPtr);
+ }
+ break;
+ }
+ $stackPtr++;
+ }
+ }
+}
diff --git a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/DependenciesCollector.php b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/DependenciesCollectorInterface.php
similarity index 96%
rename from dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/DependenciesCollector.php
rename to dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/DependenciesCollectorInterface.php
index e40896c74fb295ec23f66df5b289c7295d34737a..4514bf7a6c8bfdd7d1f7cd3770d7432845fdf0ba 100644
--- a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/DependenciesCollector.php
+++ b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/DependenciesCollectorInterface.php
@@ -27,7 +27,7 @@ namespace Magento\TestFramework\Integrity\Library\PhpParser;
* Collect dependencies
*
*/
-interface DependenciesCollector
+interface DependenciesCollectorInterface
{
/**
* Return list of dependencies
diff --git a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/ParserFactory.php b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/ParserFactory.php
index 287175b966a468d898d44e222324a827777b8fd4..2ae43077719e5061dceb3107d9a345e1fd6f932d 100644
--- a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/ParserFactory.php
+++ b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/ParserFactory.php
@@ -30,7 +30,7 @@ namespace Magento\TestFramework\Integrity\Library\PhpParser;
class ParserFactory
{
/**
- * @var Parser[]
+ * @var ParserInterface[]
*/
protected $parsers = array();
@@ -58,7 +58,7 @@ class ParserFactory
* Return all parsers
*
* @param Tokens $tokens
- * @return Parser[]
+ * @return ParserInterface[]
*/
public function createParsers(Tokens $tokens)
{
diff --git a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Parser.php b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/ParserInterface.php
similarity index 97%
rename from dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Parser.php
rename to dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/ParserInterface.php
index d4a121aa9f565c36a1543d3d368720df9f4735af..ca3e0e8de765840319704e7576c36ecab0750ae1 100644
--- a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Parser.php
+++ b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/ParserInterface.php
@@ -27,7 +27,7 @@ namespace Magento\TestFramework\Integrity\Library\PhpParser;
* Parser for each token type
*
*/
-interface Parser
+interface ParserInterface
{
/**
* Parse specific token
diff --git a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/StaticCalls.php b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/StaticCalls.php
index 365392d7dd4cf7b65060f9f23b1996a60f0365e1..d1540b405dbb60501fb4c7d2d631a66a122eb479 100644
--- a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/StaticCalls.php
+++ b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/StaticCalls.php
@@ -27,7 +27,7 @@ namespace Magento\TestFramework\Integrity\Library\PhpParser;
* Parse static calls and collect dependencies for it
*
*/
-class StaticCalls implements Parser, DependenciesCollector
+class StaticCalls implements ParserInterface, DependenciesCollectorInterface
{
/**
* @var Tokens
diff --git a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Throws.php b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Throws.php
index 7b130be9970b3298badb00378e13def8fb74c5c7..dce45d5cc92e1ae3d46a40ffa4488aece2d72de5 100644
--- a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Throws.php
+++ b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Throws.php
@@ -27,7 +27,7 @@ namespace Magento\TestFramework\Integrity\Library\PhpParser;
* Parse throws and collect dependencies for it
*
*/
-class Throws implements Parser, DependenciesCollector
+class Throws implements ParserInterface, DependenciesCollectorInterface
{
/**
* @var Tokens
diff --git a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Tokens.php b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Tokens.php
index fec6d4a059f7c61b339d587717dbd6e3787b778b..106212e1475ec80d838e2c2e8f11bada7f70b6ed 100644
--- a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Tokens.php
+++ b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Tokens.php
@@ -46,7 +46,7 @@ class Tokens
/**
* Collect all parsers
*
- * @var Parser[]
+ * @var ParserInterface[]
*/
protected $parsers = array();
@@ -82,7 +82,7 @@ class Tokens
/**
* Get all parsers
*
- * @return Parser[]
+ * @return ParserInterface[]
*/
protected function getParsers()
{
diff --git a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Uses.php b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Uses.php
index f06f6f5d933520de6801b75cf6371df63203638e..c88fb3d37d662f79de954854fe20e253e7a39e55 100644
--- a/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Uses.php
+++ b/dev/tests/static/framework/Magento/TestFramework/Integrity/Library/PhpParser/Uses.php
@@ -27,7 +27,7 @@ namespace Magento\TestFramework\Integrity\Library\PhpParser;
* Parse uses block
*
*/
-class Uses implements Parser
+class Uses implements ParserInterface
{
/**
* Flag for parse use block
diff --git a/dev/tests/static/framework/autoload.php b/dev/tests/static/framework/autoload.php
new file mode 100644
index 0000000000000000000000000000000000000000..80a76e1d27530682ffac7c5ae720185b7377afb0
--- /dev/null
+++ b/dev/tests/static/framework/autoload.php
@@ -0,0 +1,30 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+require __DIR__ . '/../../../../app/autoload.php';
+$testsBaseDir = realpath(__DIR__ . '/../');
+
+$autoloadWrapper = \Magento\Framework\Autoload\AutoloaderRegistry::getAutoloader();
+$autoloadWrapper->addPsr4('Magento\\', $testsBaseDir . '/testsuite/Magento/');
+$autoloadWrapper->addPsr4('Magento\\TestFramework\\', $testsBaseDir . '/framework/Magento/TestFramework/');
diff --git a/dev/tests/static/framework/bootstrap.php b/dev/tests/static/framework/bootstrap.php
index 5ac82785c8b9f1075097aa71100ba6ddb23463d3..e5a075e0f6ef84261c29d5cdb5721924b77f243d 100644
--- a/dev/tests/static/framework/bootstrap.php
+++ b/dev/tests/static/framework/bootstrap.php
@@ -22,26 +22,6 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-require __DIR__ . '/../../../../app/autoload.php';
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
-$includePath->addIncludePath(
- array(__DIR__, dirname(__DIR__) . '/testsuite', BP . '/lib/internal')
-);
-\Magento\TestFramework\Utility\Files::setInstance(new \Magento\TestFramework\Utility\Files(BP));
-
-function tool_autoloader($className)
-{
- if (strpos($className, 'Magento\\Tools\\') === false) {
- return false;
- }
- $filePath = str_replace('\\', '/', $className);
- $filePath = BP . '/dev/tools/' . $filePath . '.php';
+require __DIR__ . '/autoload.php';
- if (file_exists($filePath)) {
- include_once $filePath;
- } else {
- return false;
- }
-}
-spl_autoload_register('tool_autoloader');
+\Magento\TestFramework\Utility\Files::setInstance(new \Magento\TestFramework\Utility\Files(BP));
diff --git a/dev/tests/static/framework/tests/unit/testsuite/Magento/Test/Integrity/Library/PhpParser/TokensTest.php b/dev/tests/static/framework/tests/unit/testsuite/Magento/Test/Integrity/Library/PhpParser/TokensTest.php
index 81d6f25fc6572c1cb6ece8337d812c61b28159e0..3b095dd7463b6871768afa0d946010fd0bfe19ed 100644
--- a/dev/tests/static/framework/tests/unit/testsuite/Magento/Test/Integrity/Library/PhpParser/TokensTest.php
+++ b/dev/tests/static/framework/tests/unit/testsuite/Magento/Test/Integrity/Library/PhpParser/TokensTest.php
@@ -63,9 +63,7 @@ class TokensTest extends \PHPUnit_Framework_TestCase
*/
public function testParseContent()
{
- $parser = $this->getMockBuilder(
- 'Magento\TestFramework\Integrity\Library\PhpParser\Parser'
- )->getMockForAbstractClass();
+ $parser = $this->getMock('Magento\TestFramework\Integrity\Library\PhpParser\ParserInterface');
$this->parseFactory->expects($this->any())->method('createParsers')->will($this->returnValue(array($parser)));
diff --git a/dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php b/dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php
index d0cd5f25232ee021a758b02244cbf8050b2368d6..72e6a0e79e530e07f72b0ca93fa787668f6fabe9 100644
--- a/dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php
+++ b/dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php
@@ -81,15 +81,6 @@ class CompilerTest extends \PHPUnit_Framework_TestCase
$this->_tmpDir = realpath(__DIR__) . '/tmp';
$this->_generationDir = $this->_tmpDir . '/generation';
$this->_compilationDir = $this->_tmpDir . '/di';
-
- \Magento\Framework\Code\Generator\FileResolver::addIncludePath(
- [
- $basePath . '/app/code',
- $basePath . '/lib/internal',
- $this->_generationDir
- ]
- );
-
$this->_command = 'php ' . $basePath . '/dev/tools/Magento/Tools/Di/compiler.php --generation=%s --di=%s';
$booleanUtils = new \Magento\Framework\Stdlib\BooleanUtils();
@@ -323,14 +314,11 @@ class CompilerTest extends \PHPUnit_Framework_TestCase
*/
public function testConstructorIntegrity()
{
- $fileResolver = new \Magento\Framework\Code\Generator\FileResolver();
$generatorIo = new \Magento\Framework\Code\Generator\Io(
new \Magento\Framework\Filesystem\Driver\File(),
- $fileResolver,
$this->_generationDir
);
$generator = new \Magento\Framework\Code\Generator(
- $fileResolver,
$generatorIo,
array(
\Magento\Framework\Api\Code\Generator\DataBuilder::ENTITY_TYPE
@@ -351,8 +339,8 @@ class CompilerTest extends \PHPUnit_Framework_TestCase
=> 'Magento\Framework\Api\Code\Generator\SearchResults'
)
);
- $fileResolver = new \Magento\Framework\Code\Generator\Autoloader($generator, $fileResolver);
- spl_autoload_register(array($fileResolver, 'load'));
+ $generationAutoloader = new \Magento\Framework\Code\Generator\Autoloader($generator);
+ spl_autoload_register(array($generationAutoloader, 'load'));
$invoker = new \Magento\TestFramework\Utility\AggregateInvoker($this);
$invoker(
@@ -361,7 +349,7 @@ class CompilerTest extends \PHPUnit_Framework_TestCase
},
$this->_phpClassesDataProvider()
);
- spl_autoload_unregister(array($fileResolver, 'load'));
+ spl_autoload_unregister(array($generationAutoloader, 'load'));
}
/**
diff --git a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_classes.php b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_classes.php
index 4d1eb0440e0ac6bc19b21450ab2717325c111b97..a6a80ac0ba46b9b4e7ef9500a54ef42c0e3c5c22 100644
--- a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_classes.php
+++ b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_classes.php
@@ -2450,7 +2450,7 @@ return array(
['Magento\EventFactory', 'Magento\Framework\EventFactory'],
['Magento\Exception', 'Magento\Framework\Exception'],
['Magento\Filesystem', 'Magento\Framework\Filesystem'],
- ['Magento\ObjectManager', 'Magento\Framework\ObjectManager'],
+ ['Magento\ObjectManager', 'Magento\Framework\ObjectManagerInterface'],
['Magento\Translate', 'Magento\Framework\Translate'],
['Magento\TranslateInterface', 'Magento\Framework\TranslateInterface'],
['Magento\Locale', 'Magento\Framework\Locale'],
@@ -2756,7 +2756,7 @@ return array(
],
['Magento\Tax\Model\Rate\CsvImportHandler', 'Magento\TaxImportExport\Model\Rate\CsvImportHandler'],
['\Magento\Theme\Helper\Layout'],
- ['Magento\Framework\Stdlib\Cookie', 'Magento\Framework\Stdlib\CookieManager'],
+ ['Magento\Framework\Stdlib\Cookie', 'Magento\Framework\Stdlib\CookieManagerInterface'],
['Magento\Framework\View\Design\Theme\Provider'],
['Magento\Install\Controller\Index'],
['Magento\Install\Controller\Wizard'],
@@ -2845,4 +2845,18 @@ return array(
['Magento\Install\Model\Resource\Resource', 'Magento\Framework\Module\Resource'],
['Magento\Framework\App\View\Deployment\Version\Generator\Timestamp', 'Magento\Framework\Stdlib\DateTime'],
['Magento\Framework\App\View\Deployment\Version\GeneratorInterface'],
+ ['Magento\Framework\Authorization\RoleLocator', 'Magento\Framework\Authorization\RoleLocatorInterface'],
+ ['Magento\Framework\Authorization\Policy', 'Magento\Framework\Authorization\PolicyInterface'],
+ ['Magento\Framework\Stdlib\CookieManager', 'Magento\Framework\Stdlib\CookieManagerInterface'],
+ ['Magento\Framework\Interception\PluginList', 'Magento\Framework\Interception\PluginListInterface'],
+ ['Magento\Framework\Interception\Config', 'Magento\Framework\Interception\ConfigInterface'],
+ ['Magento\Framework\Interception\Chain', 'Magento\Framework\Interception\ChainInterface'],
+ ['Magento\Framework\Interception\Definition', 'Magento\Framework\Interception\DefinitionInterface'],
+ ['Magento\Framework\ObjectManager\Factory', 'Magento\Framework\ObjectManager\FactoryInterface'],
+ ['Magento\Framework\ObjectManager\Config', 'Magento\Framework\ObjectManager\ConfigInterface'],
+ ['Magento\Framework\ObjectManager\Relations', 'Magento\Framework\ObjectManager\RelationsInterface'],
+ ['Magento\Framework\ObjectManager\ConfigCache', 'Magento\Framework\ObjectManager\ConfigCacheInterface'],
+ ['Magento\Framework\ObjectManager\Definition', 'Magento\Framework\ObjectManager\DefinitionInterface'],
+ ['Magento\Framework\ObjectManager', 'Magento\Framework\ObjectManagerInterface'],
+ ['Magento\Framework\HTTP\IClient', 'Magento\Framework\HTTP\ClientInterface'],
);
diff --git a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_constants.php b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_constants.php
index fa293631ed8cbd52b987602c7f543bae34893f0c..2f596a26d1f6539cae73e18a6ea0ea1963b6b951 100644
--- a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_constants.php
+++ b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_constants.php
@@ -683,4 +683,24 @@ return array(
['SSH2', 'Magento\Framework\Filesystem'],
['HTTP', 'Magento\Framework\Filesystem', '\Magento\Framework\Filesystem\DriverPool::HTTP'],
['HTTPS', 'Magento\Framework\Filesystem', '\Magento\Framework\Filesystem\DriverPool::HTTPS'],
+ ['VAT_CLASS_ERROR', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::VAT_CLASS_ERROR'],
+ ['VAT_CLASS_INVALID', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::VAT_CLASS_INVALID'],
+ ['VAT_CLASS_INTRA_UNION', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::VAT_CLASS_INTRA_UNION'],
+ ['VAT_CLASS_DOMESTIC', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::VAT_CLASS_DOMESTIC'],
+ ['XML_PATH_CUSTOMER_VIV_INTRA_UNION_GROUP', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::XML_PATH_CUSTOMER_VIV_INTRA_UNION_GROUP'],
+ ['XML_PATH_CUSTOMER_VIV_DOMESTIC_GROUP', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::XML_PATH_CUSTOMER_VIV_DOMESTIC_GROUP'],
+ ['XML_PATH_CUSTOMER_VIV_INVALID_GROUP', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::XML_PATH_CUSTOMER_VIV_INVALID_GROUP'],
+ ['XML_PATH_CUSTOMER_VIV_ERROR_GROUP', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::XML_PATH_CUSTOMER_VIV_ERROR_GROUP'],
+ ['VAT_VALIDATION_WSDL_URL', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::VAT_VALIDATION_WSDL_URL'],
+ ['XML_PATH_CUSTOMER_GROUP_AUTO_ASSIGN', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::XML_PATH_CUSTOMER_GROUP_AUTO_ASSIGN'],
+ ['XML_PATH_EU_COUNTRIES_LIST', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::XML_PATH_EU_COUNTRIES_LIST'],
+ ['XML_PATH_MERCHANT_COUNTRY_CODE', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::XML_PATH_MERCHANT_COUNTRY_CODE'],
+ ['XML_PATH_MERCHANT_VAT_NUMBER', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::XML_PATH_MERCHANT_VAT_NUMBER'],
+ ['ROUTE_ACCOUNT_LOGIN', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::ROUTE_ACCOUNT_LOGIN'],
+ ['XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD'],
+ ['REFERER_QUERY_PARAM_NAME', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::REFERER_QUERY_PARAM_NAME'],
+ ['XML_PATH_CUSTOMER_RESET_PASSWORD_LINK_EXPIRATION_PERIOD', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Customer::XML_PATH_CUSTOMER_RESET_PASSWORD_LINK_EXPIRATION_PERIOD'],
+ ['XML_PATH_SUPPORT_EMAIL', 'Magento\Customer\Helper\Data'],
+ ['CONTEXT_GROUP', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Context::CONTEXT_GROUP'],
+ ['CONTEXT_AUTH', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Context::CONTEXT_AUTH'],
);
diff --git a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php
index 1f18ce64679383b3fb23aa2188f6270ddfeec3d7..d07db632fe37b9264396062ae11009443295f3ad 100644
--- a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php
+++ b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php
@@ -2057,6 +2057,31 @@ return array(
['_getAllowedActions', 'Magento\Customer\Controller\Account', 'Magento\Customer\Controller\Account::getAllowedActions'],
['isRegistrationAllowed', 'Magento\Customer\Controller\Account\CreatePost'],
['isRegistrationAllowed', 'Magento\Invitation\Controller\Customer\Account\CreatePost'],
+ ['getEmailConfirmationUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getEmailConfirmationUrl'],
+ ['getForgotPasswordUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getForgotPasswordUrl'],
+ ['getEditPostUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getEditPostUrl'],
+ ['getEditUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getEditUrl'],
+ ['getRegisterPostUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getRegisterPostUrl'],
+ ['getRegisterUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getRegisterUrl'],
+ ['getAccountUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getAccountUrl'],
+ ['getDashboardUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getDashboardUrl'],
+ ['getLogoutUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getLogoutUrl'],
+ ['getLoginPostUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getLoginPostUrl'],
+ ['getLoginUrl', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getLoginUrl'],
+ ['getLoginUrlParams', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Url::getLoginUrlParams'],
+ ['getMerchantCountryCode', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::getMerchantCountryCode'],
+ ['getMerchantVatNumber', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::getMerchantVatNumber'],
+ ['getCustomerGroupIdBasedOnVatNumber', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::getCustomerGroupIdBasedOnVatNumber'],
+ ['checkVatNumber', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::checkVatNumber'],
+ ['createVatNumberValidationSoapClient', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::createVatNumberValidationSoapClient'],
+ ['canCheckVatNumber', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::canCheckVatNumber'],
+ ['getCustomerVatClass', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::getCustomerVatClass'],
+ ['isCountryInEU', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::isCountryInEU'],
+ ['getDefaultCustomerGroupId', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Vat::getDefaultCustomerGroupId'],
+ ['generateResetPasswordLinkToken', 'Magento\Customer\Helper\Data'],
+ ['isLoggedIn', 'Magento\Customer\Helper\Data'],
+ ['getResetPasswordLinkExpirationPeriod', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Customer::getResetPasswordLinkExpirationPeriod'],
+ ['isRegistrationAllowed', 'Magento\Customer\Helper\Data', 'Magento\Customer\Model\Registration::isAllowed'],
['getFlatIndexer', 'Magento\Catalog\Model\Category'],
['getProductIndexer', 'Magento\Catalog\Model\Category'],
['getFlatIndexer', 'Magento\Catalog\Model\Indexer\AbstractFlatState'],
diff --git a/dev/tests/static/testsuite/Magento/Test/Php/_files/blacklist/common.txt b/dev/tests/static/testsuite/Magento/Test/Php/_files/blacklist/common.txt
index 1429d49ecde8427d106cc15e04a0ec83e836baf8..e3f96f56313024feed710d948c1c6a6e0a445d76 100644
--- a/dev/tests/static/testsuite/Magento/Test/Php/_files/blacklist/common.txt
+++ b/dev/tests/static/testsuite/Magento/Test/Php/_files/blacklist/common.txt
@@ -34,6 +34,7 @@ dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input
dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/expected
dev/tests/static/testsuite/Magento/Test/Legacy/_files
dev/tests/unit/testsuite/Magento/Core/Model/Resource/Db/AbstractTest.php
+dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files
dev/tests/unit/testsuite/Magento/Framework/Session/ConfigTest.php
dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngine/_files
lib/internal/Magento/Framework/App/Config/Element.php
@@ -105,7 +106,7 @@ lib/internal/Magento/Framework/HTTP/Adapter/Curl.php
lib/internal/Magento/Framework/HTTP/Client.php
lib/internal/Magento/Framework/HTTP/Client/Curl.php
lib/internal/Magento/Framework/HTTP/Client/Socket.php
-lib/internal/Magento/Framework/HTTP/IClient.php
+lib/internal/Magento/Framework/HTTP/ClientInterface.php
lib/internal/Magento/Framework/Image
lib/internal/Magento/Framework/Image.php
lib/internal/Magento/Framework/Io
diff --git a/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcpd/blacklist/common.txt b/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcpd/blacklist/common.txt
index 7d6f7bb0d1165ebeda20ede50154601474f97ed8..cc6df2ddad19a0e735bad3f82e4bf5c19f6e6225 100644
--- a/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcpd/blacklist/common.txt
+++ b/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcpd/blacklist/common.txt
@@ -130,3 +130,6 @@ Magento/Shipping/Controller/Adminhtml/Order/Shipment
vendor
setup/vendor
Magento/CatalogSearch/Model/Resource/Fulltext
+lib/internal/Magento/Framework/Data
+lib/internal/Magento/Framework/Service
+app/code/Magento/CatalogInventory/Api/Data
diff --git a/dev/tests/unit/filename b/dev/tests/unit/filename
new file mode 100644
index 0000000000000000000000000000000000000000..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
diff --git a/dev/tests/unit/filename.csv b/dev/tests/unit/filename.csv
new file mode 100644
index 0000000000000000000000000000000000000000..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
diff --git a/dev/tests/unit/filename.invalid_type b/dev/tests/unit/filename.invalid_type
new file mode 100644
index 0000000000000000000000000000000000000000..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
diff --git a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.2.0.1-1.6.2.0.2.php b/dev/tests/unit/framework/autoload.php
similarity index 67%
rename from app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.2.0.1-1.6.2.0.2.php
rename to dev/tests/unit/framework/autoload.php
index 39ac36804a9ff614c84d85025ff4a18c473c3bdc..d4a55a29ebe70653a46bedcf72b5039b72c89c41 100644
--- a/app/code/Magento/Customer/data/customer_setup/data-upgrade-1.6.2.0.1-1.6.2.0.2.php
+++ b/dev/tests/unit/framework/autoload.php
@@ -22,17 +22,10 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-/** @var $this \Magento\Customer\Model\Resource\Setup */
-$installer = $this->createMigrationSetup();
-$installer->startSetup();
+require_once __DIR__ . '/../../../../app/autoload.php';
+$testsBaseDir = dirname(__DIR__);
-$installer->appendClassAliasReplace(
- 'customer_eav_attribute',
- 'data_model',
- \Magento\Framework\Module\Setup\Migration::ENTITY_TYPE_MODEL,
- \Magento\Framework\Module\Setup\Migration::FIELD_CONTENT_TYPE_PLAIN,
- array('attribute_id')
-);
-$installer->doUpdateClassAliases();
-
-$installer->endSetup();
+$autoloadWrapper = \Magento\Framework\Autoload\AutoloaderRegistry::getAutoloader();
+$autoloadWrapper->addPsr4('Magento\\TestFramework\\', "{$testsBaseDir}/framework/Magento/TestFramework/");
+$autoloadWrapper->addPsr4('Magento\\Test\\', "{$testsBaseDir}/framework/Magento/Test/");
+$autoloadWrapper->addPsr4('Magento\\', "{$testsBaseDir}/testsuite/Magento/");
diff --git a/dev/tests/unit/framework/bootstrap.php b/dev/tests/unit/framework/bootstrap.php
index 7d1cb88d0c8798842f7252bc9abc6c0ec929cb73..e9a59f6a995e84b9545a8246d14a42e6ec296acc 100755
--- a/dev/tests/unit/framework/bootstrap.php
+++ b/dev/tests/unit/framework/bootstrap.php
@@ -22,24 +22,13 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
+require_once __DIR__ . '/autoload.php';
+
if (!defined('TESTS_TEMP_DIR')) {
define('TESTS_TEMP_DIR', dirname(__DIR__) . '/tmp');
}
-require __DIR__ . '/../../../../app/autoload.php';
-
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
require BP . '/app/functions.php';
-$includePath->addIncludePath(
- array(
- __DIR__,
- realpath(__DIR__ . '/../testsuite'),
- realpath(BP . '/app'),
- realpath(BP . '/app/code'),
- realpath(BP . '/lib/internal')
- )
-);
if (is_dir(TESTS_TEMP_DIR)) {
$filesystemAdapter = new \Magento\Framework\Filesystem\Driver\File();
@@ -49,20 +38,5 @@ mkdir(TESTS_TEMP_DIR);
\Magento\Framework\Phrase::setRenderer(new \Magento\Framework\Phrase\Renderer\Placeholder());
-function tool_autoloader($className)
-{
- if (strpos($className, 'Magento\\Tools\\') === false) {
- return false;
- }
- $filePath = str_replace('\\', '/', $className);
- $filePath = BP . '/dev/tools/' . $filePath . '.php';
-
- if (file_exists($filePath)) {
- include_once $filePath;
- } else {
- return false;
- }
-}
-spl_autoload_register('tool_autoloader');
error_reporting(E_ALL);
ini_set('display_errors', 1);
diff --git a/dev/tests/unit/framework/tests/unit/framework/bootstrap.php b/dev/tests/unit/framework/tests/unit/framework/bootstrap.php
index 96b12d9c554c32894b10479a0b7638b6ee45e929..0719ac4caf91915b78bea55c39a79e6c0e29d81c 100644
--- a/dev/tests/unit/framework/tests/unit/framework/bootstrap.php
+++ b/dev/tests/unit/framework/tests/unit/framework/bootstrap.php
@@ -23,14 +23,6 @@
*/
$rootDir = realpath(__DIR__ . '/../../../../../../..');
-require __DIR__ . '/../../../../../../../app/autoload.php';
-$includePath = new \Magento\Framework\Autoload\IncludePath();
-spl_autoload_register([$includePath, 'load']);
-$includePath->addIncludePath(
- array(
- $rootDir . '/lib/internal',
- $rootDir . '/dev/tests/unit/framework',
- $rootDir . '/app/code',
- $rootDir . '/app',
- )
-);
+$testsBaseDir = realpath(__DIR__ . '/../../../../');
+require_once $rootDir . '/app/autoload.php';
+require_once $testsBaseDir . '/framework/autoload.php';
diff --git a/dev/tests/unit/testsuite/Magento/Backend/Block/Widget/Grid/Column/Renderer/ConcatTest.php b/dev/tests/unit/testsuite/Magento/Backend/Block/Widget/Grid/Column/Renderer/ConcatTest.php
index 7832ec46409b6e6607370cf78f2372b31c15a93e..5543259de8ead8d85b51ceca89ccc7b111ca5ce0 100644
--- a/dev/tests/unit/testsuite/Magento/Backend/Block/Widget/Grid/Column/Renderer/ConcatTest.php
+++ b/dev/tests/unit/testsuite/Magento/Backend/Block/Widget/Grid/Column/Renderer/ConcatTest.php
@@ -63,14 +63,14 @@ class ConcatTest extends \PHPUnit_Framework_TestCase
->getMock();
$column->expects($this->any())
->method('getSeparator')
- ->willReturn('-');
+ ->will($this->returnValue('-'));
$column->expects($this->any())
->method($method)
- ->willReturn($getters);
+ ->will($this->returnValue($getters));
$column->expects($this->any())
->method('getGetter')
->willReturn(['getTest', 'getBest']);
$this->renderer->setColumn($column);
$this->assertEquals('a-b', $this->renderer->render($object));
}
-}
\ No newline at end of file
+}
diff --git a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Cache/CleanMediaTest.php b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Cache/CleanMediaTest.php
index b6ae4212aa957fcca7f7359cf7fd38b185f98d2a..14ebbcf47f9e57a6a2d55f4492df6a9c5b5b8a1e 100644
--- a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Cache/CleanMediaTest.php
+++ b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Cache/CleanMediaTest.php
@@ -31,7 +31,7 @@ class CleanMediaTest extends \PHPUnit_Framework_TestCase
$response = $this->getMock('Magento\Framework\App\Response\Http', array(), array(), '', false);
$request = $this->getMock('Magento\Framework\App\Request\Http', array(), array(), '', false);
- $objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$backendHelper = $this->getMock('Magento\Backend\Helper\Data', array(), array(), '', false);
$helper = new \Magento\TestFramework\Helper\ObjectManager($this);
diff --git a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/TunnelTest.php b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/TunnelTest.php
index 66b28e148c5ee4188e5eb45f3bb6fdaea0654c63..20c9821941ddce17a4f51aa21eab279fb32a38cc 100644
--- a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/TunnelTest.php
+++ b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/TunnelTest.php
@@ -49,7 +49,7 @@ class TunnelTest extends \PHPUnit_Framework_TestCase
{
$this->_request = $this->getMock('Magento\Framework\App\Request\Http', array(), array(), '', false);
$this->_response = $this->getMock('Magento\Framework\App\Response\Http', array(), array(), '', false);
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
}
protected function tearDown()
diff --git a/dev/tests/unit/testsuite/Magento/Backend/Model/Auth/SessionTest.php b/dev/tests/unit/testsuite/Magento/Backend/Model/Auth/SessionTest.php
index 76d49939148304a72ef1c416bce15210ad065550..baff2dddc6311e2ce8d20e53e9a2ae11e0456efe 100644
--- a/dev/tests/unit/testsuite/Magento/Backend/Model/Auth/SessionTest.php
+++ b/dev/tests/unit/testsuite/Magento/Backend/Model/Auth/SessionTest.php
@@ -41,7 +41,7 @@ class SessionTest extends \PHPUnit_Framework_TestCase
protected $sessionConfig;
/**
- * @var \Magento\Framework\Stdlib\CookieManager | \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface | \PHPUnit_Framework_MockObject_MockObject
*/
protected $cookieManager;
diff --git a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Structure/Element/FlyweightFactoryTest.php b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Structure/Element/FlyweightFactoryTest.php
index 8b0f5489558e349d26cc1af342f3fbe16064072f..da3128fd76bcd85b87944bce73d4da5265eb8b92 100644
--- a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Structure/Element/FlyweightFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Structure/Element/FlyweightFactoryTest.php
@@ -37,7 +37,7 @@ class FlyweightFactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Backend\Model\Config\Structure\Element\FlyweightFactory(
$this->_objectManagerMock
);
diff --git a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Structure/Element/Group/ProxyTest.php b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Structure/Element/Group/ProxyTest.php
index f7c897abf9a867fe165f17946b8897eeefdf3e3a..9cdfd8121b16f03a3e800451700eb34bf8c861fe 100644
--- a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Structure/Element/Group/ProxyTest.php
+++ b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Structure/Element/Group/ProxyTest.php
@@ -37,7 +37,7 @@ class ProxyTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Backend\Model\Config\Structure\Element\Group\Proxy($this->_objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Backend/Model/Session/QuoteTest.php b/dev/tests/unit/testsuite/Magento/Backend/Model/Session/QuoteTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..1e03eee694692acaeed0453b8732ce313a7cc627
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Backend/Model/Session/QuoteTest.php
@@ -0,0 +1,363 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Backend\Model\Session;
+
+/**
+ * Class QuoteTest
+ */
+class QuoteTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Framework\StoreManagerInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $storeManagerMock;
+
+ /**
+ * @var \Magento\Sales\Model\OrderFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $orderFactoryMock;
+
+ /**
+ * @var \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $cookieMetadataFactoryMock;
+
+ /**
+ * @var \Magento\Framework\Stdlib\CookieManager|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $cookieManagerMock;
+
+ /**
+ * @var \Magento\Framework\Session\StorageInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $storageMock;
+
+ /**
+ * @var \Magento\Framework\Session\ValidatorInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $validatorMock;
+
+ /**
+ * @var \Magento\Framework\Session\SaveHandlerInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $saveHandlerMock;
+
+ /**
+ * @var \Magento\Framework\Session\Config\ConfigInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $sessionConfigMock;
+
+ /**
+ * @var \Magento\Framework\Session\SidResolverInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $sidResolverMock;
+
+ /**
+ * @var \Magento\Framework\App\Request\Http|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $requestMock;
+
+ /**
+ * @var \Magento\Customer\Service\V1\CustomerAccountServiceInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $customerServiceMock;
+
+ /**
+ * @var \Magento\Framework\App\Config\ScopeConfigInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $scopeConfigMock;
+
+ /**
+ * @var \Magento\Sales\Model\QuoteFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $quoteRepositoryMock;
+
+ /**
+ * @var \Magento\Backend\Model\Session\Quote|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $quote;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $this->customerServiceMock = $this->getMockForAbstractClass(
+ 'Magento\Customer\Service\V1\CustomerAccountServiceInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getCustomer']
+ );
+ $this->scopeConfigMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\App\Config\ScopeConfigInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getValue']
+ );
+ $this->quoteRepositoryMock = $this->getMock(
+ 'Magento\Sales\Model\QuoteRepository',
+ ['create', 'save', 'get'],
+ [],
+ '',
+ false
+ );
+
+ $this->requestMock = $this->getMock(
+ 'Magento\Framework\App\Request\Http',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->sidResolverMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Session\SidResolverInterface',
+ [],
+ '',
+ false
+ );
+ $this->sessionConfigMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Session\Config\ConfigInterface',
+ [],
+ '',
+ false
+ );
+ $this->saveHandlerMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Session\SaveHandlerInterface',
+ [],
+ '',
+ false
+ );
+ $this->validatorMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Session\ValidatorInterface',
+ [],
+ '',
+ false
+ );
+ $this->storageMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Session\StorageInterface',
+ [],
+ '',
+ false
+ );
+ $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
+ $this->cookieMetadataFactoryMock = $this->getMock(
+ 'Magento\Framework\Stdlib\Cookie\CookieMetadataFactory',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->orderFactoryMock = $this->getMock(
+ 'Magento\Sales\Model\OrderFactory',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->storeManagerMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\StoreManagerInterface',
+ [],
+ '',
+ false
+ );
+
+ $this->quote = $this->getMock(
+ 'Magento\Backend\Model\Session\Quote',
+ ['getStoreId', 'getQuoteId', 'setQuoteId', 'hasCustomerId', 'getCustomerId'],
+ [
+ 'request' => $this->requestMock,
+ 'sidResolver' => $this->sidResolverMock,
+ 'sessionConfig' => $this->sessionConfigMock,
+ 'saveHandler' => $this->saveHandlerMock,
+ 'validator' => $this->validatorMock,
+ 'storage' => $this->storageMock,
+ 'cookieManager' => $this->cookieManagerMock,
+ 'cookieMetadataFactory' => $this->cookieMetadataFactoryMock,
+ 'quoteRepository' => $this->quoteRepositoryMock,
+ 'customerService' => $this->customerServiceMock,
+ 'orderFactory' => $this->orderFactoryMock,
+ 'storeManager' => $this->storeManagerMock,
+ 'scopeConfig' => $this->scopeConfigMock,
+ ],
+ '',
+ true
+ );
+ }
+
+ /**
+ * Run test getQuote method
+ *
+ * @return void
+ */
+ public function testGetQuote()
+ {
+ $storeId = 10;
+ $quoteId = 22;
+ $customerGroupId = 77;
+ $customerId = 66;
+
+ $quoteMock = $this->getMock(
+ 'Magento\Sales\Model\Quote',
+ [
+ 'setStoreId',
+ 'setCustomerGroupId',
+ 'setIsActive',
+ 'getId',
+ 'assignCustomer',
+ 'setIgnoreOldQty',
+ 'setIsSuperMode',
+ '__wakeup'
+ ],
+ [],
+ '',
+ false
+ );
+
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('create')
+ ->will($this->returnValue($quoteMock));
+ $this->quote->expects($this->any())
+ ->method('getStoreId')
+ ->will($this->returnValue($storeId));
+ $quoteMock->expects($this->once())
+ ->method('setStoreId')
+ ->with($storeId);
+ $this->quote->expects($this->any())
+ ->method('getQuoteId')
+ ->will($this->returnValue(null));
+ $this->scopeConfigMock->expects($this->once())
+ ->method('getValue')
+ ->will($this->returnValue($customerGroupId));
+ $quoteMock->expects($this->once())
+ ->method('setCustomerGroupId')
+ ->with($customerGroupId)
+ ->will($this->returnSelf());
+ $quoteMock->expects($this->once())
+ ->method('setIsActive')
+ ->with(false)
+ ->will($this->returnSelf());
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('save')
+ ->with($quoteMock);
+ $quoteMock->expects($this->once())
+ ->method('getId')
+ ->will($this->returnValue($quoteId));
+ $this->quote->expects($this->any())
+ ->method('setQuoteId')
+ ->with($quoteId);
+ $this->quote->expects($this->any())
+ ->method('getCustomerId')
+ ->will($this->returnValue($customerId));
+ $this->customerServiceMock->expects($this->once())
+ ->method('getCustomer')
+ ->with($customerId)
+ ->will($this->returnValue('customer-result'));
+ $quoteMock->expects($this->once())
+ ->method('assignCustomer')
+ ->with('customer-result');
+ $quoteMock->expects($this->once())
+ ->method('setIgnoreOldQty')
+ ->with(true);
+ $quoteMock->expects($this->once())
+ ->method('setIsSuperMode')
+ ->with(true);
+
+ $this->assertEquals($quoteMock, $this->quote->getQuote());
+ }
+
+ /**
+ * Run test getQuote method
+ *
+ * @return void
+ */
+ public function testGetQuoteGet()
+ {
+ $storeId = 10;
+ $quoteId = 22;
+ $customerId = 66;
+
+ $quoteMock = $this->getMock(
+ 'Magento\Sales\Model\Quote',
+ [
+ 'setStoreId',
+ 'setCustomerGroupId',
+ 'setIsActive',
+ 'getId',
+ 'assignCustomer',
+ 'setIgnoreOldQty',
+ 'setIsSuperMode',
+ '__wakeup'
+ ],
+ [],
+ '',
+ false
+ );
+
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('create')
+ ->will($this->returnValue($quoteMock));
+ $this->quote->expects($this->any())
+ ->method('getStoreId')
+ ->will($this->returnValue($storeId));
+ $quoteMock->expects($this->once())
+ ->method('setStoreId')
+ ->with($storeId);
+ $this->quote->expects($this->any())
+ ->method('getQuoteId')
+ ->will($this->returnValue($quoteId));
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('get')
+ ->with($quoteId)
+ ->willReturn($quoteMock);
+ $this->quote->expects($this->any())
+ ->method('setQuoteId')
+ ->with($quoteId);
+ $this->quote->expects($this->any())
+ ->method('getCustomerId')
+ ->will($this->returnValue($customerId));
+ $this->customerServiceMock->expects($this->once())
+ ->method('getCustomer')
+ ->with($customerId)
+ ->will($this->returnValue('customer-result'));
+ $quoteMock->expects($this->once())
+ ->method('assignCustomer')
+ ->with('customer-result');
+ $quoteMock->expects($this->once())
+ ->method('setIgnoreOldQty')
+ ->with(true);
+ $quoteMock->expects($this->once())
+ ->method('setIsSuperMode')
+ ->with(true);
+
+ $this->assertEquals($quoteMock, $this->quote->getQuote());
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Backup/Model/BackupFactoryTest.php b/dev/tests/unit/testsuite/Magento/Backup/Model/BackupFactoryTest.php
index 2329a3b99df9edb44048721f97e486d4de53f2a2..6cc465f551032d7ed1e0f1356cdc3b2965088f6b 100644
--- a/dev/tests/unit/testsuite/Magento/Backup/Model/BackupFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Backup/Model/BackupFactoryTest.php
@@ -31,7 +31,7 @@ class BackupFactoryTest extends \PHPUnit_Framework_TestCase
protected $_instance;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -70,7 +70,7 @@ class BackupFactoryTest extends \PHPUnit_Framework_TestCase
$this->_backupModel = $this->getMock('Magento\Backup\Model\Backup', array(), array(), '', false);
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_objectManager->expects(
$this->at(0)
)->method(
diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/BundleTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/BundleTest.php
index 863c33277bf9da1334bf2cf74ce82460d0d14545..52c4ca1b40cd23e23afbd6c633461f72788dac72 100644
--- a/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/BundleTest.php
+++ b/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/BundleTest.php
@@ -23,6 +23,9 @@
*/
namespace Magento\Bundle\Block\Catalog\Product\View\Type;
+use \Magento\Bundle\Block\Catalog\Product\View\Type\Bundle as BundleBlock;
+use \Magento\Framework\Object as MagentoObject;
+
class BundleTest extends \PHPUnit_Framework_TestCase
{
/**
@@ -79,4 +82,197 @@ class BundleTest extends \PHPUnit_Framework_TestCase
$this->assertEquals('option html', $this->_bundleBlock->getOptionHtml($option));
}
+
+ /**
+ * @param array $options
+ * @param \Magento\Framework\Pricing\PriceInfo\Base|\PHPUnit_Framework_MockObject_MockObject $priceInfo
+ * @param string $priceType
+ * @return Bundle
+ */
+ protected function setupBundleBlock($options, $priceInfo, $priceType)
+ {
+ $objectHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $optionCollection = $this->getMockBuilder('\Magento\Bundle\Model\Resource\Option\Collection')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $optionCollection->expects($this->any())
+ ->method('appendSelections')
+ ->will($this->returnValue($options));
+
+ $typeInstance = $this->getMockBuilder('\Magento\Bundle\Model\Product\Type')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $typeInstance->expects($this->any())
+ ->method('getOptionsCollection')
+ ->will($this->returnValue($optionCollection));
+ $typeInstance->expects($this->any())
+ ->method('getStoreFilter')
+ ->will($this->returnValue(true));
+
+ $product = $this->getMockBuilder('\Magento\Catalog\Model\Product')
+ ->disableOriginalConstructor()
+ ->setMethods(
+ [
+ 'getTypeInstance',
+ 'getPriceInfo',
+ 'getStoreId',
+ 'getPriceType'
+ ]
+ )
+ ->getMock();
+ $product->expects($this->any())
+ ->method('getTypeInstance')
+ ->will($this->returnValue($typeInstance));
+ $product->expects($this->any())
+ ->method('getPriceInfo')
+ ->will($this->returnValue($priceInfo));
+ $product->expects($this->any())
+ ->method('getPriceType')
+ ->will($this->returnValue($priceType));
+
+ $registry = $this->getMockBuilder('\Magento\Framework\Registry')
+ ->disableOriginalConstructor()
+ ->setMethods(['registry'])
+ ->getMock();
+ $registry->expects($this->once())
+ ->method('registry')
+ ->will($this->returnValue($product));
+
+ $taxHelperMock = $this->getMockBuilder('\Magento\Tax\Helper\Data')
+ ->disableOriginalConstructor()
+ ->getMock();
+
+ $context = $this->getMockBuilder('\Magento\Catalog\Block\Product\Context')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $context->expects($this->any())
+ ->method('getRegistry')
+ ->will($this->returnValue($registry));
+ $context->expects($this->any())
+ ->method('getTaxData')
+ ->will($this->returnValue($taxHelperMock));
+
+ $jsonEncoderMock = $this->getMockBuilder('\Magento\Framework\Json\Encoder')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $jsonEncoderMock->expects($this->any())
+ ->method('encode')
+ ->will($this->returnArgument(0));
+
+ $priceCurrencyMock = $this->getMockBuilder('Magento\Directory\Model\PriceCurrency')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $priceCurrencyMock->expects($this->any())
+ ->method('convert')
+ ->will($this->returnArgument(0));
+
+
+ /** @var $bundleBlock BundleBlock */
+ $bundleBlock = $objectHelper->getObject(
+ 'Magento\Bundle\Block\Catalog\Product\View\Type\Bundle',
+ [
+ 'context' => $context,
+ 'jsonEncoder' => $jsonEncoderMock,
+ 'priceCurrency' => $priceCurrencyMock,
+ ]
+ );
+
+ return $bundleBlock;
+ }
+
+ public function getPriceInfoMock($price)
+ {
+ $priceInfoMock = $this->getMockBuilder('\Magento\Framework\Pricing\PriceInfo\Base')
+ ->disableOriginalConstructor()
+ ->setMethods(['getPrice'])
+ ->getMock();
+
+ if (is_array($price)) {
+ $counter = 0;
+ foreach ($price as $priceType => $priceValue) {
+ $priceInfoMock->expects($this->at($counter))
+ ->method('getPrice')
+ ->with($priceType)
+ ->will($this->returnValue($priceValue));
+ $counter++;
+ }
+ } else {
+ $priceInfoMock->expects($this->any())
+ ->method('getPrice')
+ ->will($this->returnValue($price));
+ }
+ return $priceInfoMock;
+ }
+
+ public function getPriceMock($prices)
+ {
+ $methods = [];
+ foreach (array_keys($prices) as $methodName) {
+ $methods[] = $methodName;
+ }
+ $priceMock = $this->getMockBuilder('Magento\Catalog\Pricing\Price\BasePrice')
+ ->disableOriginalConstructor()
+ ->setMethods($methods)
+ ->getMock();
+ foreach ($prices as $methodName => $amount) {
+ $priceMock->expects($this->any())
+ ->method($methodName)
+ ->will($this->returnValue($amount));
+ }
+
+ return $priceMock;
+ }
+
+ public function testGetJsonConfigFixedPriceBundleNoOption()
+ {
+ $options = [];
+ $finalPriceMock = $this->getPriceMock(
+ [
+ 'getPriceWithoutOption' => new MagentoObject(
+ [
+ 'value' => 100,
+ 'base_amount' => 100,
+ ]
+ ),
+ ]
+ );
+ $regularPriceMock = $this->getPriceMock(
+ [
+ 'getAmount' => new MagentoObject(
+ [
+ 'value' => 110,
+ 'base_amount' => 110,
+ ]
+ ),
+ ]
+ );
+ $specialPriceMock = $this->getPriceMock(
+ [
+ 'getValue' => new MagentoObject(
+ [
+ 'value' => 110,
+ 'base_amount' => 110,
+ ]
+ ),
+ ]
+ );
+ $prices = [
+ \Magento\Catalog\Pricing\Price\FinalPrice::PRICE_CODE => $finalPriceMock,
+ \Magento\Catalog\Pricing\Price\RegularPrice::PRICE_CODE => $regularPriceMock,
+ \Magento\Catalog\Pricing\Price\SpecialPrice::PRICE_CODE => $specialPriceMock,
+ ];
+ $priceInfo = $this->getPriceInfoMock($prices);
+
+ $this->_bundleBlock = $this->setupBundleBlock(
+ $options,
+ $priceInfo,
+ \Magento\Bundle\Model\Product\Price::PRICE_TYPE_FIXED
+ );
+ $jsonConfig = $this->_bundleBlock->getJsonConfig();
+ $this->assertEquals(100, $jsonConfig['finalBasePriceInclTax']);
+ $this->assertEquals(100, $jsonConfig['finalBasePriceExclTax']);
+ $this->assertEquals(100, $jsonConfig['finalPrice']);
+ $this->assertEquals(110, $jsonConfig['basePrice']);
+ }
}
diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Adjustment/CalculatorTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Adjustment/CalculatorTest.php
index a70fde6243ff1ce25aad91e2116b8d3ee6e0ccfd..cc2e9f5be213c3531d0410bbb0fc2904fac4e8b2 100644
--- a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Adjustment/CalculatorTest.php
+++ b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Adjustment/CalculatorTest.php
@@ -26,6 +26,7 @@ namespace Magento\Bundle\Pricing\Adjustment;
use Magento\Bundle\Model\Product\Price as ProductPrice;
use Magento\Bundle\Pricing\Price;
use Magento\TestFramework\Helper\ObjectManager;
+use Magento\Bundle\Pricing\Adjustment\Calculator;
/**
* Test for \Magento\Bundle\Pricing\Adjustment\Calculator
@@ -512,4 +513,23 @@ class CalculatorTest extends \PHPUnit_Framework_TestCase
]
];
}
+
+ public function testGetAmountWithoutOption()
+ {
+ $amount = 1;
+ $result = 5;
+
+ /** @var $calculatorMock Calculator|PHPUnit_Framework_MockObject_MockObject */
+ $calculatorMock = $this->getMockBuilder('Magento\Bundle\Pricing\Adjustment\Calculator')
+ ->disableOriginalConstructor()
+ ->setMethods(['calculateBundleAmount'])
+ ->getMock();
+
+ $calculatorMock->expects($this->once())
+ ->method('calculateBundleAmount')
+ ->with($amount, $this->saleableItem, [])
+ ->will($this->returnValue($result));
+
+ $this->assertEquals($result, $calculatorMock->getAmountWithoutOption($amount, $this->saleableItem));
+ }
}
diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/BundleSelectionFactoryTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/BundleSelectionFactoryTest.php
index ab6a66deb7a3756decd4308231e4092e6eb24d36..fee571b076e2a43e9559bd55573e04907568e5a4 100644
--- a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/BundleSelectionFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/BundleSelectionFactoryTest.php
@@ -34,7 +34,7 @@ class BundleSelectionFactoryTest extends \PHPUnit_Framework_TestCase
/** @var ObjectManagerHelper */
protected $objectManagerHelper;
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $objectManagerMock;
/** @var \Magento\Framework\Pricing\Object\SaleableInterface|\PHPUnit_Framework_MockObject_MockObject */
@@ -48,7 +48,7 @@ class BundleSelectionFactoryTest extends \PHPUnit_Framework_TestCase
$this->bundleMock = $this->getMock('Magento\Catalog\Model\Product', [], [], '', false);
$this->selectionMock = $this->getMock('Magento\Catalog\Model\Product', [], [], '', false);
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->objectManagerHelper = new ObjectManagerHelper($this);
$this->bundleSelectionFactory = $this->objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/FinalPriceTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/FinalPriceTest.php
index 6607d80eace010c2b0077f0fb1d95c517fe38152..e0a7ed30e0834b8b79e20f06575b79d8c7a5915c 100644
--- a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/FinalPriceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/FinalPriceTest.php
@@ -124,7 +124,7 @@ class FinalPriceTest extends \PHPUnit_Framework_TestCase
*/
public function testGetMaximalPrice($baseAmount)
{
- $result = rand(1, 10);
+ $result = 3;
$this->baseAmount = $baseAmount;
$this->prepareMock();
@@ -140,7 +140,7 @@ class FinalPriceTest extends \PHPUnit_Framework_TestCase
*/
public function testGetMinimalPrice($baseAmount)
{
- $result = rand(1, 10);
+ $result = 5;
$this->baseAmount = $baseAmount;
$this->prepareMock();
@@ -150,4 +150,15 @@ class FinalPriceTest extends \PHPUnit_Framework_TestCase
->will($this->returnValue($result));
$this->assertSame($result, $this->finalPrice->getMinimalPrice());
}
+
+ public function testGetPriceWithoutOption()
+ {
+ $result = 5;
+ $this->prepareMock();
+ $this->bundleCalculatorMock->expects($this->once())
+ ->method('getAmountWithoutOption')
+ ->with($this->equalTo($this->baseAmount), $this->equalTo($this->saleableInterfaceMock))
+ ->will($this->returnValue($result));
+ $this->assertSame($result, $this->finalPrice->getPriceWithoutOption());
+ }
}
diff --git a/dev/tests/unit/testsuite/Magento/Captcha/Model/CaptchaFactoryTest.php b/dev/tests/unit/testsuite/Magento/Captcha/Model/CaptchaFactoryTest.php
index 5a45c63b5b6a8376a653afd0340e4b5f84f512f2..db7ca0d92a2d89db8fabd07bd874e472f2ce8956 100644
--- a/dev/tests/unit/testsuite/Magento/Captcha/Model/CaptchaFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Captcha/Model/CaptchaFactoryTest.php
@@ -33,7 +33,7 @@ class CaptchaFactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Captcha\Model\CaptchaFactory($this->_objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Captcha/Model/DefaultTest.php b/dev/tests/unit/testsuite/Magento/Captcha/Model/DefaultTest.php
index 0ce3edbf151826ca606694528259d0243c3affae..84a5debc11b4ceeccfedf537f88aba820e2b5d35 100644
--- a/dev/tests/unit/testsuite/Magento/Captcha/Model/DefaultTest.php
+++ b/dev/tests/unit/testsuite/Magento/Captcha/Model/DefaultTest.php
@@ -116,7 +116,7 @@ class DefaultTest extends \PHPUnit_Framework_TestCase
);
// \Magento\Customer\Model\Session
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_objectManager->expects(
$this->any()
)->method(
diff --git a/dev/tests/unit/testsuite/Magento/Captcha/Model/ObserverTest.php b/dev/tests/unit/testsuite/Magento/Captcha/Model/ObserverTest.php
index d4cd09146e1c189e3c08208d58bf2f68541c3ee2..248a8630cb8021efdcc515b7b0f746a4dace0a52 100644
--- a/dev/tests/unit/testsuite/Magento/Captcha/Model/ObserverTest.php
+++ b/dev/tests/unit/testsuite/Magento/Captcha/Model/ObserverTest.php
@@ -81,9 +81,9 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
protected $_coreData;
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $_customerData;
+ protected $_customerUrl;
/**
* @var \PHPUnit_Framework_MockObject_MockObject
@@ -116,7 +116,7 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
$this->_session = $this->getMock('Magento\Framework\Session\SessionManager', array(), array(), '', false);
$this->_typeOnepage = $this->getMock('Magento\Checkout\Model\Type\Onepage', array(), array(), '', false);
$this->_coreData = $this->getMock('Magento\Core\Helper\Data', array(), array(), '', false);
- $this->_customerData = $this->getMock('Magento\Customer\Helper\Data', array(), array(), '', false);
+ $this->_customerUrl = $this->getMock('Magento\Customer\Model\Url', array(), array(), '', false);
$this->_helper = $this->getMock('Magento\Captcha\Helper\Data', array(), array(), '', false);
$this->_urlManager = $this->getMock('Magento\Framework\Url', array(), array(), '', false);
$this->_actionFlag = $this->getMock('Magento\Framework\App\ActionFlag', array(), array(), '', false);
@@ -141,7 +141,7 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
'session' => $this->_session,
'typeOnepage' => $this->_typeOnepage,
'coreData' => $this->_coreData,
- 'customerData' => $this->_customerData,
+ 'customerUrl' => $this->_customerUrl,
'helper' => $this->_helper,
'urlManager' => $this->_urlManager,
'actionFlag' => $this->_actionFlag,
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/InventoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/InventoryTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..0f0b4e447217ff86355b67ca8b9ff957e2a936dd
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/InventoryTest.php
@@ -0,0 +1,198 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Action\Attribute\Tab;
+
+/**
+ * Class InventoryTest
+ */
+class InventoryTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\CatalogInventory\Model\Source\Backorders|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $backordersMock;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockConfigurationMock;
+
+ /**
+ * @var \Magento\Backend\Block\Template\Context|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $contextMock;
+
+ /**
+ * @var \Magento\Framework\App\RequestInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $requestMock;
+
+ /**
+ * @var \Magento\Catalog\Block\Adminhtml\Product\Edit\Action\Attribute\Tab\Inventory
+ */
+ protected $inventory;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->contextMock = $this->getMock(
+ 'Magento\Backend\Block\Template\Context',
+ ['getRequest'],
+ [],
+ '',
+ false
+ );
+ $this->backordersMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Source\Backorders',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->stockConfigurationMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockConfigurationInterface',
+ [],
+ '',
+ false
+ );
+ $this->requestMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\App\RequestInterface',
+ ['getParam'],
+ '',
+ false
+ );
+
+ $this->contextMock->expects($this->once())
+ ->method('getRequest')
+ ->will($this->returnValue($this->requestMock));
+
+ $this->inventory = $objectManager->getObject(
+ 'Magento\Catalog\Block\Adminhtml\Product\Edit\Action\Attribute\Tab\Inventory',
+ [
+ 'context' => $this->contextMock,
+ 'backorders' => $this->backordersMock,
+ 'stockConfiguration' => $this->stockConfigurationMock
+ ]
+ );
+ }
+
+ /**
+ * Run test getBackordersOption method
+ *
+ * @return void
+ */
+ public function testGetBackordersOption()
+ {
+ $this->backordersMock->expects($this->once())
+ ->method('toOptionArray')
+ ->will($this->returnValue('return-value'));
+ $this->assertEquals('return-value', $this->inventory->getBackordersOption());
+ }
+
+ /**
+ * Run test getFieldSuffix method
+ *
+ * @return void
+ */
+ public function testGetFieldSuffix()
+ {
+ $this->assertEquals('inventory', $this->inventory->getFieldSuffix());
+ }
+
+ /**
+ * Run test getStoreId method
+ *
+ * @return void
+ */
+ public function testGetStoreId()
+ {
+ $this->requestMock->expects($this->once())
+ ->method('getParam')
+ ->with('store')
+ ->will($this->returnValue('125'));
+
+ $this->assertTrue(is_integer($this->inventory->getStoreId()));
+ }
+
+ /**
+ * Run test getDefaultConfigValue method
+ *
+ * @return void
+ */
+ public function testGetDefaultConfigValue()
+ {
+ $this->stockConfigurationMock->expects($this->once())
+ ->method('getDefaultConfigValue')
+ ->with('field-name')
+ ->will($this->returnValue('return-value'));
+
+ $this->assertEquals('return-value', $this->inventory->getDefaultConfigValue('field-name'));
+ }
+
+ /**
+ * Run test getTabLabel method
+ *
+ * @return void
+ */
+ public function testGetTabLabel()
+ {
+ $this->assertEquals('Advanced Inventory', $this->inventory->getTabLabel());
+ }
+
+ /**
+ * Run test getTabTitle method
+ *
+ * @return void
+ */
+ public function testGetTabTitle()
+ {
+ $this->assertEquals('Advanced Inventory', $this->inventory->getTabLabel());
+ }
+
+ /**
+ * Run test canShowTab method
+ *
+ * @return void
+ */
+ public function testCanShowTab()
+ {
+ $this->assertTrue($this->inventory->canShowTab());
+ }
+
+ /**
+ * Run test isHidden method
+ *
+ * @return void
+ */
+ public function testIsHidden()
+ {
+ $this->assertFalse($this->inventory->isHidden());
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/InventoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/InventoryTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..57be3867cd5a1515f70fd54d25071e6db3c099f4
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/InventoryTest.php
@@ -0,0 +1,666 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab;
+
+/**
+ * Class InventoryTest
+ */
+class InventoryTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Catalog\Helper\Data|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $catalogDataMock;
+
+ /**
+ * @var \Magento\Framework\Registry|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $coreRegistryMock;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Source\Stock|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockMock;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Source\Backorders|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $backordersMock;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistryMock;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockConfigurationMock;
+
+ /**
+ * @var \Magento\Backend\Block\Template\Context|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $contextMock;
+
+ /**
+ * @var \Magento\Framework\StoreManagerInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $storeManagerMock;
+
+ /**
+ * @var \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Inventory
+ */
+ protected $inventory;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->contextMock = $this->getMock(
+ 'Magento\Backend\Block\Template\Context',
+ ['getRequest', 'getStoreManager'],
+ [],
+ '',
+ false
+ );
+ $this->stockConfigurationMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockConfigurationInterface',
+ [],
+ '',
+ false
+ );
+ $this->stockRegistryMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockRegistryInterface',
+ [],
+ '',
+ false
+ );
+ $this->backordersMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Source\Backorders',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->stockMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Source\Stock',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->coreRegistryMock = $this->getMock(
+ 'Magento\Framework\Registry',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->catalogDataMock = $this->getMock(
+ 'Magento\Catalog\Helper\Data',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->storeManagerMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\StoreManagerInterface',
+ [],
+ '',
+ false
+ );
+
+ $this->contextMock->expects($this->once())
+ ->method('getStoreManager')
+ ->will($this->returnValue($this->storeManagerMock));
+
+ $this->inventory = $objectManager->getObject(
+ 'Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Inventory',
+ [
+ 'context' => $this->contextMock,
+ 'backorders' => $this->backordersMock,
+ 'stock' => $this->stockMock,
+ 'catalogData' => $this->catalogDataMock,
+ 'coreRegistry' => $this->coreRegistryMock,
+ 'stockRegistry' => $this->stockRegistryMock,
+ 'stockConfiguration' => $this->stockConfigurationMock,
+ ]
+ );
+ }
+
+ /**
+ * Run test getBackordersOption method
+ *
+ * @param bool $moduleEnabled
+ * @return void
+ *
+ * @dataProvider dataProviderModuleEnabled
+ */
+ public function testGetBackordersOption($moduleEnabled)
+ {
+ $this->catalogDataMock->expects($this->once())
+ ->method('isModuleEnabled')
+ ->with('Magento_CatalogInventory')
+ ->will($this->returnValue($moduleEnabled));
+ if ($moduleEnabled) {
+ $this->backordersMock->expects($this->once())
+ ->method('toOptionArray')
+ ->will($this->returnValue(['test-value', 'test-value']));
+ }
+
+ $result = $this->inventory->getBackordersOption();
+ $this->assertEquals($moduleEnabled, !empty($result));
+ }
+
+ /**
+ * Run test getStockOption method
+ *
+ * @param bool $moduleEnabled
+ * @return void
+ *
+ * @dataProvider dataProviderModuleEnabled
+ */
+ public function testGetStockOption($moduleEnabled)
+ {
+ $this->catalogDataMock->expects($this->once())
+ ->method('isModuleEnabled')
+ ->with('Magento_CatalogInventory')
+ ->will($this->returnValue($moduleEnabled));
+ if ($moduleEnabled) {
+ $this->stockMock->expects($this->once())
+ ->method('toOptionArray')
+ ->will($this->returnValue(['test-value', 'test-value']));
+ }
+
+ $result = $this->inventory->getStockOption();
+ $this->assertEquals($moduleEnabled, !empty($result));
+ }
+
+ /**
+ * Run test getProduct method
+ *
+ * @return void
+ */
+ public function testGetProduct()
+ {
+ $this->coreRegistryMock->expects($this->once())
+ ->method('registry')
+ ->with('product')
+ ->will($this->returnValue('return-value'));
+
+ $result = $this->inventory->getProduct();
+ $this->assertEquals('return-value', $result);
+ }
+
+ /**
+ * Run test getStockItem method
+ *
+ * @return void
+ */
+ public function testGetStockItem()
+ {
+ $productId = 10;
+ $websiteId = 15;
+ $productMock = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getId', 'getStore'],
+ [],
+ '',
+ false
+ );
+ $storeMock = $this->getMock(
+ 'Magento\Store\Model\Store',
+ ['getWebsiteId'],
+ [],
+ '',
+ false
+ );
+ $productMock->expects($this->once())
+ ->method('getId')
+ ->will($this->returnValue($productId));
+ $productMock->expects($this->once())
+ ->method('getStore')
+ ->will($this->returnValue($storeMock));
+ $storeMock->expects($this->once())
+ ->method('getWebsiteId')
+ ->will($this->returnValue($websiteId));
+ $this->coreRegistryMock->expects($this->any())
+ ->method('registry')
+ ->with('product')
+ ->will($this->returnValue($productMock));
+ $this->stockRegistryMock->expects($this->once())
+ ->method('getStockItem')
+ ->with($productId, $websiteId)
+ ->will($this->returnValue('return-value'));
+
+ $resultItem = $this->inventory->getStockItem();
+ $this->assertEquals('return-value', $resultItem);
+ }
+
+ /**
+ * Run test getFieldValue method
+ *
+ * @param int $stockId
+ * @param array $methods
+ * @param string $result
+ * @return void
+ *
+ * @dataProvider dataProviderGetFieldValue
+ */
+ public function testGetFieldValue($stockId, $methods, $result)
+ {
+ $productId = 10;
+ $websiteId = 15;
+ $fieldName = 'field';
+
+ $stockItemMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockItemInterface',
+ [],
+ '',
+ false,
+ false,
+ false,
+ $methods
+ );
+ $productMock = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ [],
+ [],
+ '',
+ false
+ );
+ $storeMock = $this->getMock(
+ 'Magento\Store\Model\Store',
+ [],
+ [],
+ '',
+ false
+ );
+ $productMock->expects($this->once())
+ ->method('getId')
+ ->will($this->returnValue($productId));
+ $productMock->expects($this->once())
+ ->method('getStore')
+ ->will($this->returnValue($storeMock));
+ $storeMock->expects($this->once())
+ ->method('getWebsiteId')
+ ->will($this->returnValue($websiteId));
+ $this->coreRegistryMock->expects($this->any())
+ ->method('registry')
+ ->with('product')
+ ->will($this->returnValue($productMock));
+ $this->stockRegistryMock->expects($this->once())
+ ->method('getStockItem')
+ ->with($productId, $websiteId)
+ ->will($this->returnValue($stockItemMock));
+ $stockItemMock->expects($this->once())
+ ->method('getId')
+ ->will($this->returnValue($stockId));
+
+ if (!empty($methods)) {
+ $stockItemMock->expects($this->once())
+ ->method(reset($methods))
+ ->will($this->returnValue('call-method'));
+ }
+ if (empty($methods) || empty($stockId)) {
+ $this->stockConfigurationMock->expects($this->once())
+ ->method('getDefaultConfigValue')
+ ->will($this->returnValue('default-result'));
+ }
+
+ $resultValue = $this->inventory->getFieldValue($fieldName);
+ $this->assertEquals($result, $resultValue);
+ }
+
+ /**
+ * Run test getConfigFieldValue method
+ *
+ * @param int $stockId
+ * @param array $methods
+ * @param string $result
+ * @return void
+ *
+ * @dataProvider dataProviderGetConfigFieldValue
+ */
+ public function testGetConfigFieldValue($stockId, $methods, $result)
+ {
+ $productId = 10;
+ $websiteId = 15;
+ $fieldName = 'field';
+
+ $stockItemMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockItemInterface',
+ [],
+ '',
+ false,
+ false,
+ false,
+ $methods
+ );
+ $productMock = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ [],
+ [],
+ '',
+ false
+ );
+ $storeMock = $this->getMock(
+ 'Magento\Store\Model\Store',
+ [],
+ [],
+ '',
+ false
+ );
+ $productMock->expects($this->once())
+ ->method('getId')
+ ->will($this->returnValue($productId));
+ $productMock->expects($this->once())
+ ->method('getStore')
+ ->will($this->returnValue($storeMock));
+ $storeMock->expects($this->once())
+ ->method('getWebsiteId')
+ ->will($this->returnValue($websiteId));
+ $this->coreRegistryMock->expects($this->any())
+ ->method('registry')
+ ->with('product')
+ ->will($this->returnValue($productMock));
+ $this->stockRegistryMock->expects($this->once())
+ ->method('getStockItem')
+ ->with($productId, $websiteId)
+ ->will($this->returnValue($stockItemMock));
+ $stockItemMock->expects($this->once())
+ ->method('getId')
+ ->will($this->returnValue($stockId));
+
+ if (!empty($methods)) {
+ $stockItemMock->expects($this->once())
+ ->method(reset($methods))
+ ->will($this->returnValue('call-method'));
+ }
+ if (empty($methods) || empty($stockId)) {
+ $this->stockConfigurationMock->expects($this->once())
+ ->method('getDefaultConfigValue')
+ ->will($this->returnValue('default-result'));
+ }
+
+ $resultField = $this->inventory->getConfigFieldValue($fieldName);
+ $this->assertEquals($result, $resultField);
+ }
+
+ /**
+ * Run test getDefaultConfigValue method
+ *
+ * @return void
+ */
+ public function testGetDefaultConfigValue()
+ {
+ $field = 'filed-name';
+ $this->stockConfigurationMock->expects($this->once())
+ ->method('getDefaultConfigValue')
+ ->will($this->returnValue('return-value'));
+
+ $result = $this->inventory->getDefaultConfigValue($field);
+ $this->assertEquals('return-value', $result);
+ }
+
+ /**
+ * Run test isReadonly method
+ *
+ * @return void
+ */
+ public function testIsReadonly()
+ {
+ $productMock = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getInventoryReadonly'],
+ [],
+ '',
+ false
+ );
+ $this->coreRegistryMock->expects($this->once())
+ ->method('registry')
+ ->with('product')
+ ->will($this->returnValue($productMock));
+
+ $productMock->expects($this->once())
+ ->method('getInventoryReadonly')
+ ->will($this->returnValue('return-value'));
+
+ $result = $this->inventory->isReadonly();
+ $this->assertEquals('return-value', $result);
+ }
+
+ /**
+ * Run test isNew method
+ *
+ * @param int|null $id
+ * @param bool $result
+ * @return void
+ *
+ * @dataProvider dataProviderGetId
+ */
+ public function testIsNew($id, $result)
+ {
+ $productMock = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getId'],
+ [],
+ '',
+ false
+ );
+ $this->coreRegistryMock->expects($this->once())
+ ->method('registry')
+ ->with('product')
+ ->will($this->returnValue($productMock));
+ $productMock->expects($this->once())
+ ->method('getId')
+ ->will($this->returnValue($id));
+
+ $methodResult = $this->inventory->isNew();
+ $this->assertEquals($result, $methodResult);
+ }
+
+ /**
+ * Run test getFieldSuffix method
+ *
+ * @return void
+ */
+ public function testGetFieldSuffix()
+ {
+ $result = $this->inventory->getFieldSuffix();
+ $this->assertEquals('product', $result);
+ }
+
+ /**
+ * Run test canUseQtyDecimals method
+ *
+ * @return void
+ */
+ public function testCanUseQtyDecimals()
+ {
+ $productMock = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getTypeInstance'],
+ [],
+ '',
+ false
+ );
+ $typeMock = $this->getMockForAbstractClass(
+ 'Magento\Catalog\Model\Product\Type\AbstractType',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['canUseQtyDecimals']
+ );
+ $this->coreRegistryMock->expects($this->once())
+ ->method('registry')
+ ->with('product')
+ ->will($this->returnValue($productMock));
+ $productMock->expects($this->once())
+ ->method('getTypeInstance')
+ ->will($this->returnValue($typeMock));
+ $typeMock->expects($this->once())
+ ->method('canUseQtyDecimals')
+ ->will($this->returnValue('return-value'));
+
+ $result = $this->inventory->canUseQtyDecimals();
+ $this->assertEquals('return-value', $result);
+ }
+
+ /**
+ * Run test isVirtual method
+ *
+ * @return void
+ */
+ public function testIsVirtual()
+ {
+ $productMock = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getIsVirtual'],
+ [],
+ '',
+ false
+ );
+ $this->coreRegistryMock->expects($this->once())
+ ->method('registry')
+ ->with('product')
+ ->will($this->returnValue($productMock));
+ $productMock->expects($this->once())
+ ->method('getIsVirtual')
+ ->will($this->returnValue('return-value'));
+
+ $result = $this->inventory->isVirtual();
+ $this->assertEquals('return-value', $result);
+ }
+
+ /**
+ * Run test isSingleStoreMode method
+ *
+ * @return void
+ */
+ public function testIsSingleStoreMode()
+ {
+ $this->storeManagerMock->expects($this->once())
+ ->method('isSingleStoreMode')
+ ->will($this->returnValue('return-value'));
+
+ $result = $this->inventory->isSingleStoreMode();
+ $this->assertEquals('return-value', $result);
+ }
+
+ /**
+ * Data for Module Enabled
+ *
+ * @return array
+ */
+ public function dataProviderModuleEnabled()
+ {
+ return [
+ [
+ 'ModuleEnabled' => true
+ ],
+ [
+ 'ModuleEnabled' => false
+ ]
+ ];
+ }
+
+ /**
+ * Data for getFieldValue method
+ *
+ * @return array
+ */
+ public function dataProviderGetFieldValue()
+ {
+ return [
+ [
+ 'stockId' => 99,
+ 'methods' => ['getField'],
+ 'result' => 'call-method'
+ ],
+ [
+ 'stockId' => null,
+ 'methods' => [],
+ 'result' => 'default-result'
+ ],
+ [
+ 'stockId' => 99,
+ 'methods' => [],
+ 'result' => 'default-result'
+ ]
+ ];
+ }
+
+ /**
+ * Data for getConfigFieldValue and getFieldValue method
+ *
+ * @return array
+ */
+ public function dataProviderGetConfigFieldValue()
+ {
+ return [
+ [
+ 'stockId' => 99,
+ 'methods' => ['getUseConfigField'],
+ 'result' => 'call-method'
+ ],
+ [
+ 'stockId' => null,
+ 'methods' => [],
+ 'result' => 'default-result'
+ ],
+ [
+ 'stockId' => 99,
+ 'methods' => [],
+ 'result' => 'default-result'
+ ]
+ ];
+ }
+
+ /**
+ * Data for isNew method
+ *
+ * @return array
+ */
+ public function dataProviderGetId()
+ {
+ return [
+ [
+ 'id' => 99,
+ 'result' => false
+ ],
+ [
+ 'id' => null,
+ 'result' => true
+ ]
+ ];
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/AbstractProductTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/AbstractProductTest.php
index f9a99c1f22a432dff66fdfa0eabf7871a774f25c..0ff2662b6d14d822f8aab1ac5825f5b5ff979d29 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/AbstractProductTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/AbstractProductTest.php
@@ -34,15 +34,20 @@ class AbstractProductTest extends \PHPUnit_Framework_TestCase
protected $block;
/**
- * @var \Magento\Catalog\Block\Product\Context
+ * @var \Magento\Catalog\Block\Product\Context|\PHPUnit_Framework_MockObject_MockObject
*/
protected $productContextMock;
/**
- * @var \Magento\Framework\View\LayoutInterface
+ * @var \Magento\Framework\View\LayoutInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $layoutMock;
+ /**
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistryMock;
+
/**
* Set up mocks and tested class
* Child class is used as the tested class is declared abstract
@@ -51,14 +56,26 @@ class AbstractProductTest extends \PHPUnit_Framework_TestCase
{
$this->productContextMock = $this->getMock(
'Magento\Catalog\Block\Product\Context',
- ['getLayout'],
+ ['getLayout', 'getStockRegistry'],
[],
'',
false
);
$arrayUtilsMock = $this->getMock('Magento\Framework\Stdlib\ArrayUtils', [], [], '', false);
$this->layoutMock = $this->getMock('Magento\Framework\View\Layout', ['getBlock'], [], '', false);
+ $this->stockRegistryMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockRegistryInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getStockItem']
+ );
+ $this->productContextMock->expects($this->once())
+ ->method('getStockRegistry')
+ ->will($this->returnValue($this->stockRegistryMock));
$this->productContextMock->expects($this->once())
->method('getLayout')
->will($this->returnValue($this->layoutMock));
@@ -114,6 +131,83 @@ class AbstractProductTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($expectedPriceHtml, $this->block->getProductPriceHtml(
$product, 'price_code', 'zone_code'
));
+ }
+ /**
+ * Run test getMinimalQty method
+ *
+ * @param int $minSale
+ * @param int|null $result
+ * @return void
+ *
+ * @dataProvider dataProviderGetMinimalQty
+ */
+ public function testGetMinimalQty($minSale, $result)
+ {
+ $id = 10;
+ $websiteId = 99;
+
+ $productMock = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getId', 'getStore'],
+ [],
+ '',
+ false
+ );
+ $storeMock = $this->getMock(
+ 'Magento\Store\Model\Store',
+ ['getWebsiteId'],
+ [],
+ '',
+ false
+ );
+ $stockItemMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockItemInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getMinSaleQty']
+ );
+
+ $this->stockRegistryMock->expects($this->once())
+ ->method('getStockItem')
+ ->with($id, $websiteId)
+ ->will($this->returnValue($stockItemMock));
+ $productMock->expects($this->once())
+ ->method('getId')
+ ->will($this->returnValue($id));
+ $productMock->expects($this->once())
+ ->method('getStore')
+ ->will($this->returnValue($storeMock));
+ $storeMock->expects($this->once())
+ ->method('getWebsiteId')
+ ->will($this->returnValue($websiteId));
+ $stockItemMock->expects($this->once())
+ ->method('getMinSaleQty')
+ ->will($this->returnValue($minSale));
+
+ /** @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject $productMock */
+ $this->assertEquals($result, $this->block->getMinimalQty($productMock));
+ }
+
+ /**
+ * Data for getMinimalQty method
+ *
+ * @return array
+ */
+ public function dataProviderGetMinimalQty()
+ {
+ return [
+ [
+ 'minSale' => 10,
+ 'result' => 10
+ ],
+ [
+ 'minSale' => 0,
+ 'result' => null
+ ]
+ ];
}
}
\ No newline at end of file
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/ContextTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/ContextTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..f8c33bb6c57ff8c7d66697c18a52259764e18cbd
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/ContextTest.php
@@ -0,0 +1,74 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Catalog\Block\Product;
+
+/**
+ * Class ContextTest
+ */
+class ContextTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistryMock;
+
+ /**
+ * @var \Magento\Catalog\Block\Product\Context
+ */
+ protected $context;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->stockRegistryMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockRegistryInterface',
+ [],
+ '',
+ false
+ );
+
+ $this->context = $objectManager->getObject(
+ 'Magento\Catalog\Block\Product\Context',
+ [
+ 'stockRegistry' => $this->stockRegistryMock
+ ]
+ );
+ }
+
+ /**
+ * Run test getStockRegistry method
+ *
+ * @return void
+ */
+ public function testGetStockRegistry()
+ {
+ $this->assertEquals($this->stockRegistryMock, $this->context->getStockRegistry());
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/SaveTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/SaveTest.php
index 03c586d6eda56e5e93fd0e0013095e0cbca1772b..0884a9a2035c087abc7eae4f04444342dfbedb79 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/SaveTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/SaveTest.php
@@ -32,58 +32,84 @@ class SaveTest extends \PHPUnit_Framework_TestCase
{
/** @var \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribute\Save */
protected $object;
+
/** @var \Magento\Catalog\Helper\Product\Edit\Action\Attribute|\PHPUnit_Framework_MockObject_MockObject */
protected $attributeHelper;
- /** @var \Magento\CatalogInventory\Service\V1\Data\StockItemBuilder|\PHPUnit_Framework_MockObject_MockObject */
+
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
protected $stockItemBuilder;
+
/** @var \Magento\CatalogInventory\Model\Indexer\Stock\Processor|\PHPUnit_Framework_MockObject_MockObject */
protected $stockIndexerProcessor;
/** @var \Magento\Backend\App\Action\Context|\PHPUnit_Framework_MockObject_MockObject */
protected $context;
+
/** @var \Magento\Framework\App\RequestInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $request;
+
/** @var \Magento\Framework\App\Response\Http|\PHPUnit_Framework_MockObject_MockObject */
protected $response;
+
/** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
protected $objectManager;
+
/** @var \Magento\Framework\Event\ManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $eventManager;
+
/** @var \Magento\Framework\UrlInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $url;
+
/** @var \Magento\Framework\App\Response\RedirectInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $redirect;
+
/** @var \Magento\Framework\App\ActionFlag|\PHPUnit_Framework_MockObject_MockObject */
protected $actionFlag;
+
/** @var \Magento\Framework\App\ViewInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $view;
+
/** @var \Magento\Framework\Message\ManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $messageManager;
+
/** @var \Magento\Backend\Model\Session|\PHPUnit_Framework_MockObject_MockObject */
protected $session;
+
/** @var \Magento\Framework\AuthorizationInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $authorization;
+
/** @var \Magento\Backend\Model\Auth|\PHPUnit_Framework_MockObject_MockObject */
protected $auth;
+
/** @var \Magento\Backend\Helper\Data|\PHPUnit_Framework_MockObject_MockObject */
protected $helper;
+
/** @var \Magento\Backend\Model\UrlInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $backendUrl;
+
/** @var \Magento\Core\App\Action\FormKeyValidator|\PHPUnit_Framework_MockObject_MockObject */
protected $formKeyValidator;
+
/** @var \Magento\Framework\App\Action\Title|\PHPUnit_Framework_MockObject_MockObject */
protected $title;
+
/** @var \Magento\Framework\Locale\ResolverInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $localeResolver;
/** @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject */
protected $product;
- /** @var \Magento\CatalogInventory\Service\V1\StockItemService|\PHPUnit_Framework_MockObject_MockObject */
+
+ /** @var \Magento\CatalogInventory\Api\StockRegistryInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $stockItemService;
- /** @var \Magento\CatalogInventory\Service\V1\Data\StockItem|\PHPUnit_Framework_MockObject_MockObject */
+
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
protected $stockItem;
- /** @var \Magento\CatalogInventory\Helper\Data|\PHPUnit_Framework_MockObject_MockObject */
- protected $inventoryHelper;
+
+ /** @var \Magento\CatalogInventory\Api\StockConfigurationInterface|\PHPUnit_Framework_MockObject_MockObject */
+ protected $stockConfig;
+
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
+ protected $stockItemRepository;
protected function setUp()
{
@@ -91,22 +117,16 @@ class SaveTest extends \PHPUnit_Framework_TestCase
$this->attributeHelper = $this->getMock(
'Magento\Catalog\Helper\Product\Edit\Action\Attribute',
- ['getProductIds', 'getSelectedStoreId'],
+ ['getProductIds', 'getSelectedStoreId', 'getStoreWebsiteId'],
[],
'',
false
);
- $this->stockItemBuilder = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\Data\StockItemBuilder',
- ['mergeDataObjectWithArray', 'create'],
- [],
- '',
- false
- );
- $this->stockItemBuilder->expects($this->any())
- ->method('mergeDataObjectWithArray')
- ->willReturn($this->stockItemBuilder);
+ $this->stockItemBuilder = $this->getMockBuilder('Magento\CatalogInventory\Api\Data\StockItemDataBuilder')
+ ->disableOriginalConstructor()
+ ->setMethods(['mergeDataObjectWithArray'])
+ ->getMock();
$this->stockIndexerProcessor = $this->getMock(
'Magento\CatalogInventory\Model\Indexer\Stock\Processor',
@@ -146,6 +166,11 @@ class SaveTest extends \PHPUnit_Framework_TestCase
*/
protected function prepareContext()
{
+ $this->stockItemRepository = $this->getMockBuilder('Magento\CatalogInventory\Api\StockItemRepositoryInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+
+
$this->request = $this->getMock(
'Magento\Framework\App\RequestInterface',
['getParam', 'getModuleName', 'setModuleName', 'getActionName', 'setActionName', 'getCookie'],
@@ -154,13 +179,7 @@ class SaveTest extends \PHPUnit_Framework_TestCase
false
);
$this->response = $this->getMock('Magento\Framework\App\Response\Http', [], [], '', false);
- $this->objectManager = $this->getMock(
- 'Magento\Framework\ObjectManager',
- ['configure', 'create', 'get'],
- [],
- '',
- false
- );
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->eventManager = $this->getMock('Magento\Framework\Event\ManagerInterface', [], [], '', false);
$this->url = $this->getMock('Magento\Framework\UrlInterface', [], [], '', false);
$this->redirect = $this->getMock('Magento\Framework\App\Response\RedirectInterface', [], [], '', false);
@@ -231,24 +250,27 @@ class SaveTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $this->stockItemService = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
- ['getStockItem', 'saveStockItem'],
- [],
- '',
- false
- );
- $this->stockItem = $this->getMock('Magento\CatalogInventory\Service\V1\Data\StockItem', [], [], '', false);
- $this->inventoryHelper
- = $this->getMock('Magento\CatalogInventory\Helper\Data', ['getConfigItemOptions'], [], '', false);
+
+ $this->stockItemService = $this->getMockBuilder('Magento\CatalogInventory\Api\StockRegistryInterface')
+ ->disableOriginalConstructor()
+ ->setMethods(['getStockItem', 'saveStockItem'])
+ ->getMockForAbstractClass();
+ $this->stockItem = $this->getMockBuilder('Magento\CatalogInventory\Api\Data\StockItemInterface')
+ ->disableOriginalConstructor()
+ ->getMockForAbstractClass();
+
+ $this->stockConfig = $this->getMockBuilder('Magento\CatalogInventory\Api\StockConfigurationInterface')
+ ->disableOriginalConstructor()
+ ->getMockForAbstractClass();
$this->objectManager->expects($this->any())->method('create')->will($this->returnValueMap([
['Magento\Catalog\Model\Product', [], $this->product],
- ['Magento\CatalogInventory\Service\V1\StockItemService', [], $this->stockItemService],
+ ['Magento\CatalogInventory\Api\StockRegistryInterface', [], $this->stockItemService],
+ ['Magento\CatalogInventory\Api\StockItemRepositoryInterface', [], $this->stockItemRepository]
]));
$this->objectManager->expects($this->any())->method('get')->will($this->returnValueMap([
- ['Magento\CatalogInventory\Helper\Data', $this->inventoryHelper],
+ ['Magento\CatalogInventory\Api\StockConfigurationInterface', $this->stockConfig],
]));
}
@@ -256,9 +278,18 @@ class SaveTest extends \PHPUnit_Framework_TestCase
{
$this->attributeHelper->expects($this->any())->method('getProductIds')->will($this->returnValue([5]));
$this->attributeHelper->expects($this->any())->method('getSelectedStoreId')->will($this->returnValue([1]));
- $this->inventoryHelper->expects($this->any())->method('getConfigItemOptions')->will($this->returnValue([]));
+ $this->attributeHelper->expects($this->any())->method('getStoreWebsiteId')->will($this->returnValue(1));
+ $this->stockConfig->expects($this->any())->method('getConfigItemOptions')->will($this->returnValue([]));
+ $itemToSave = $this->getMockBuilder('Magento\CatalogInventory\Api\Data\StockItemInterface')
+ ->disableOriginalConstructor()
+ ->setMethods(['setItemId', 'save'])
+ ->getMockForAbstractClass();
+ $this->stockItemBuilder->expects($this->any())
+ ->method('mergeDataObjectWithArray')
+ ->withAnyParameters()
+ ->willReturn($itemToSave);
$this->product->expects($this->any())->method('isProductsHasSku')->with([5])->will($this->returnValue(true));
- $this->stockItemService->expects($this->any())->method('getStockItem')->with(5)
+ $this->stockItemService->expects($this->any())->method('getStockItem')->with(5, 1)
->will($this->returnValue($this->stockItem));
$this->stockIndexerProcessor->expects($this->any())->method('reindexList')->with([5]);
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/HandlerFactoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/HandlerFactoryTest.php
index f786f5b720f5509163ad63efc1807be4c964d0f5..9cc07f2ea60707ef0ccfa5d22b9263f5a9990910 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/HandlerFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/HandlerFactoryTest.php
@@ -37,7 +37,7 @@ class HandlerFactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('\Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('\Magento\Framework\ObjectManagerInterface');
$this->_model = new HandlerFactory($this->_objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilterTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilterTest.php
index e2e06a71db79e6363eb55e77edafb503ce3516fc..4e5d82d76aaea38bbff12b2ba7985ebb575e1764 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilterTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilterTest.php
@@ -22,7 +22,10 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
namespace Magento\Catalog\Controller\Adminhtml\Product\Initialization;
-use \Magento\Catalog\Controller\Adminhtml\Product\Initialization\StockDataFilter;
+
+/**
+ * Class StockDataFilterTest
+ */
class StockDataFilterTest extends \PHPUnit_Framework_TestCase
{
/**
@@ -40,13 +43,24 @@ class StockDataFilterTest extends \PHPUnit_Framework_TestCase
*/
protected $stockDataFilter;
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
+ protected $stockConfiguration;
+
protected function setUp()
{
$this->scopeConfigMock = $this->getMock('\Magento\Framework\App\Config\ScopeConfigInterface');
$this->scopeConfigMock->expects($this->any())->method('getValue')->will($this->returnValue(1));
- $this->stockDataFilter = new StockDataFilter($this->scopeConfigMock);
+ $this->stockConfiguration = $this->getMock(
+ 'Magento\CatalogInventory\Model\Configuration',
+ ['getManageStock'],
+ [],
+ '',
+ false
+ );
+
+ $this->stockDataFilter = new StockDataFilter($this->scopeConfigMock, $this->stockConfiguration);
}
/**
@@ -58,6 +72,13 @@ class StockDataFilterTest extends \PHPUnit_Framework_TestCase
*/
public function testFilter(array $inputStockData, array $outputStockData)
{
+ if (isset($inputStockData['use_config_manage_stock']) && $inputStockData['use_config_manage_stock'] === 1) {
+ $this->stockConfiguration->expects($this->once())
+ ->method('getManageStock')
+ ->will($this->returnValue($outputStockData['manage_stock']));
+ }
+
+
$this->assertEquals($outputStockData, $this->stockDataFilter->filter($inputStockData));
}
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/ProductTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/ProductTest.php
index 5d93e0b106fe67c8b6c91c85bd847ede8a237d5d..7c5ed45b4dd0c343f070adb18d8f1c895423c365 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/ProductTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/ProductTest.php
@@ -44,15 +44,7 @@ abstract class ProductTest extends \PHPUnit_Framework_TestCase
protected function initContext()
{
$productActionMock = $this->getMock('Magento\Catalog\Model\Product\Action', array(), array(), '', false);
- $objectManagerMock = $this->getMockForAbstractClass(
- '\Magento\Framework\ObjectManager',
- array(),
- '',
- true,
- true,
- true,
- array('get')
- );
+ $objectManagerMock = $this->getMockForAbstractClass('Magento\Framework\ObjectManagerInterface');
$objectManagerMock->expects($this->any())->method('get')->will($this->returnValue($productActionMock));
$block = $this->getMockBuilder('\Magento\Framework\View\Element\AbstractBlock')
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Category/ViewTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Category/ViewTest.php
index 0eae2310de4b0d3f33e6912fa4e827a7d566e2b1..61a7b9889c21fcb024d1468de99b5c322ed2477f 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Category/ViewTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Category/ViewTest.php
@@ -48,7 +48,7 @@ class ViewTest extends \PHPUnit_Framework_TestCase
protected $categoryHelper;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManager;
@@ -136,7 +136,7 @@ class ViewTest extends \PHPUnit_Framework_TestCase
$this->response = $this->getMock('Magento\Framework\App\ResponseInterface');
$this->categoryHelper = $this->getMock('Magento\Catalog\Helper\Category', [], [], '', false);
- $this->objectManager = $this->getMock('Magento\Framework\ObjectManager', [], [], '', false);
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->eventManager = $this->getMock('Magento\Framework\Event\ManagerInterface');
$this->update = $this->getMock('Magento\Framework\View\Layout\ProcessorInterface');
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Helper/Product/CompareTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Helper/Product/CompareTest.php
index 2cace8e26c4882e6b32dc16c6a63933522f99eb6..005ff21d99b29e81eb7d98bf2f23aadaa31dff51 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Helper/Product/CompareTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Helper/Product/CompareTest.php
@@ -54,6 +54,11 @@ class CompareTest extends \PHPUnit_Framework_TestCase
*/
protected $request;
+ /**
+ * @var \Magento\Framework\Url\EncoderInterface | \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $urlEncoder;
+
public function setUp()
{
$objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
@@ -63,17 +68,21 @@ class CompareTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Framework\App\Helper\Context $context */
$this->context = $this->getMock(
'Magento\Framework\App\Helper\Context',
- array('getUrlBuilder', 'getRequest'),
+ array('getUrlBuilder', 'getRequest', 'getUrlEncoder'),
array(),
'',
false
);
+ $this->urlEncoder = $this->getMockBuilder('Magento\Framework\Url\EncoderInterface')->getMock();
$this->context->expects($this->once())
->method('getUrlBuilder')
->will($this->returnValue($this->urlBuilder));
$this->context->expects($this->once())
->method('getRequest')
->will($this->returnValue($this->request));
+ $this->context->expects($this->once())
+ ->method('getUrlEncoder')
+ ->will($this->returnValue($this->urlEncoder));
$this->postDataHelper = $this->getMock(
'Magento\Core\Helper\PostData',
array('getPostData'),
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Helper/Product/Edit/Action/AttributeTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Helper/Product/Edit/Action/AttributeTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..99159db87557272609b0c4ec70068cb91a16ce66
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Helper/Product/Edit/Action/AttributeTest.php
@@ -0,0 +1,92 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Catalog\Helper\Product\Edit\Action;
+
+/**
+ * Class AttributeTest
+ */
+class AttributeTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Framework\StoreManagerInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $storeManagerMock;
+
+ /**
+ * @var \Magento\Catalog\Helper\Product\Edit\Action\Attribute
+ */
+ protected $attribute;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->storeManagerMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\StoreManagerInterface',
+ [],
+ '',
+ false
+ );
+
+ $this->attribute = $objectManager->getObject(
+ 'Magento\Catalog\Helper\Product\Edit\Action\Attribute',
+ [
+ 'storeManager' => $this->storeManagerMock
+ ]
+ );
+ }
+
+ /**
+ * Run test getStoreWebsiteId method
+ *
+ * @return void
+ */
+ public function testGetStoreWebsiteId()
+ {
+ $storeId = 20;
+
+ $storeMock = $this->getMock(
+ 'Magento\Store\Model\Store',
+ ['getWebsiteId'],
+ [],
+ '',
+ false
+ );
+
+ $this->storeManagerMock->expects($this->once())
+ ->method('getStore')
+ ->with($storeId)
+ ->will($this->returnValue($storeMock));
+ $storeMock->expects($this->once())
+ ->method('getWebsiteId')
+ ->will($this->returnValue('return-value'));
+
+ $this->assertEquals('return-value', $this->attribute->getStoreWebsiteId($storeId));
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Attribute/LockValidatorCompositeTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Attribute/LockValidatorCompositeTest.php
index 790d8b1166bb72e38ae5fbf93e34fa69109141ef..f00add2fccb560653d8e4e10daafe2c2bc95c48e 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Attribute/LockValidatorCompositeTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Attribute/LockValidatorCompositeTest.php
@@ -38,7 +38,7 @@ class LockValidatorCompositeTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('\Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('\Magento\Framework\ObjectManagerInterface');
}
/**
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/FactoryTest.php
index b7811b50fb551a6a924a4de2ad3e97641a0057d2..718cdc036258ec0894a2a4be5ceb2372f76f34a9 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/FactoryTest.php
@@ -26,7 +26,7 @@ namespace Magento\Catalog\Model;
class FactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -64,7 +64,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setObjectManager()
{
- $this->objectManager = $this->getMock('\Magento\Framework\ObjectManager', [], [], '', false);
+ $this->objectManager = $this->getMock('\Magento\Framework\ObjectManagerInterface');
$this->objectManager
->expects($this->any())
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/FactoryTest.php
index 2c5e0b18d60909c32581da7d5d2455946876fd47..14a75f27680177de177f7bed811f3cec567de8db 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/FactoryTest.php
@@ -26,7 +26,7 @@ namespace Magento\Catalog\Model\Layer\Filter;
class FactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManagerMock;
@@ -37,7 +37,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->_factory = $objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/FilterListTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/FilterListTest.php
index 98b8b42bf585c9911685f674ce1414cf4042d5f7..6c57de3214f27b2b65abcec5114d22d52b99ec76 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/FilterListTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/FilterListTest.php
@@ -53,7 +53,7 @@ class FilterListTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('\Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('\Magento\Framework\ObjectManagerInterface');
$this->attributeListMock = $this->getMock(
'Magento\Catalog\Model\Layer\Category\FilterableAttributeList', array(), array(), '', false
);
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Backend/GroupPriceTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Backend/GroupPriceTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..fbb072a62e8690533364bcab12327eb1266d9e80
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Backend/GroupPriceTest.php
@@ -0,0 +1,49 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Catalog\Model\Product\Attribute\Backend;
+
+class GroupPriceTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Catalog\Model\Product\Attribute\Backend\GroupPrice
+ */
+ protected $model;
+
+ /**
+ * @var \Magento\TestFramework\Helper\ObjectManager
+ */
+ protected $objectHelper;
+
+ protected function setUp()
+ {
+ $this->objectHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->model = $this->objectHelper->getObject('Magento\Catalog\Model\Product\Attribute\Backend\GroupPrice');
+ }
+
+ public function testIsScaler()
+ {
+ $this->assertFalse($this->model->isScalar(), 'Attribute GroupPrice should not be scaler');
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Backend/StockTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Backend/StockTest.php
index 11037157cb78473f5e7569b0ee4506ae60c65788..388f953672693575936d19ab752edb9ae088088d 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Backend/StockTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Backend/StockTest.php
@@ -32,26 +32,42 @@ class StockTest extends \PHPUnit_Framework_TestCase
*/
protected $model;
- /**
- * @var \Magento\CatalogInventory\Service\V1\StockItemServiceInterface
- */
- protected $stockItemService;
/**
* @var \Magento\TestFramework\Helper\ObjectManager
*/
protected $objectHelper;
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
+ protected $stockItemMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistry;
+
protected function setUp()
{
$this->objectHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->stockItemService = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\StockItemService')
+ $this->stockRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\StockRegistry')
->disableOriginalConstructor()
+ ->setMethods(['getStockItem', '__wakeup'])
->getMock();
+ $this->stockItemMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Stock\Item',
+ ['getIsInStock', 'getQty', '__wakeup'],
+ [],
+ '',
+ false
+ );
+
+ $this->stockRegistry->expects($this->any())
+ ->method('getStockItem')
+ ->will($this->returnValue($this->stockItemMock));
$this->model = $this->objectHelper->getObject(
'Magento\Catalog\Model\Product\Attribute\Backend\Stock',
- array('stockItemService' => $this->stockItemService)
+ array('stockRegistry' => $this->stockRegistry)
);
$attribute = $this->getMock('Magento\Framework\Object', array('getAttributeCode'));
$attribute->expects($this->atLeastOnce())
@@ -63,18 +79,15 @@ class StockTest extends \PHPUnit_Framework_TestCase
public function testAfterLoad()
{
$productId = 2;
- $stockItemDo = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockItem')
- ->disableOriginalConstructor()
- ->getMock();
- $this->stockItemService->expects($this->once())
- ->method('getStockItem')
- ->with($productId)
- ->will($this->returnValue($stockItemDo));
+ $this->stockItemMock->expects($this->once())->method('getIsInStock')->will($this->returnValue(1));
+ $this->stockItemMock->expects($this->once())->method('getQty')->will($this->returnValue(5));
- $stockItemDo->expects($this->once())->method('getIsInStock')->will($this->returnValue(1));
- $stockItemDo->expects($this->once())->method('getQty')->will($this->returnValue(5));
- $object = new \Magento\Framework\Object(['id' => $productId]);
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId', '__wakeup'], [], '', false);
+ $store->expects($this->once())
+ ->method('getWebsiteId')
+ ->will($this->returnValue(10));
+ $object = new \Magento\Framework\Object(['id' => $productId, 'store' => $store]);
$this->model->afterLoad($object);
$data = $object->getData();
$this->assertEquals(1, $data[self::ATTRIBUTE_NAME]['is_in_stock']);
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/CopyConstructorFactoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/CopyConstructorFactoryTest.php
index b22d0eea2b5a915128f5865ba1554dcb2d915b78..a7a248efae6449b8c0b23a47122391e2c965c5a7 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/CopyConstructorFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/CopyConstructorFactoryTest.php
@@ -37,7 +37,7 @@ class CopyConstructorFactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('\Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('\Magento\Framework\ObjectManagerInterface');
$this->_model = new CopyConstructorFactory($this->_objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Option/Type/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Option/Type/FactoryTest.php
index ebb6e64756fed1763d7259b98ef6084ea3100985..a0886e69c044f91054883d42b8bcdc37e08f047e 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Option/Type/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Option/Type/FactoryTest.php
@@ -26,7 +26,7 @@ namespace Magento\Catalog\Model\Product\Option\Type;
class FactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManagerMock;
@@ -37,7 +37,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->_factory = $objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/PriceModifier/CompositeTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/PriceModifier/CompositeTest.php
index 0665d3aabaacb4606513883248b46ea6f75649ab..b377ed25af4aa2f6cc383335ba500ece2b1a2994 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/PriceModifier/CompositeTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/PriceModifier/CompositeTest.php
@@ -47,7 +47,7 @@ class CompositeTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->productMock = $this->getMock('Magento\Catalog\Model\Product', array(), array(), '', false);
$this->priceModifierMock = $this->getMock('Magento\Catalog\Model\Product\PriceModifierInterface');
}
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/ProductList/ToolbarTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/ProductList/ToolbarTest.php
index fd746b2f5c7e6f1a73fd7e13e382a170821bf1ac..d577a5c44b44712cf7ebefc7d07e0a2aac880458 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/ProductList/ToolbarTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/ProductList/ToolbarTest.php
@@ -34,7 +34,7 @@ class ToolbarTest extends \PHPUnit_Framework_TestCase
protected $toolbarModel;
/**
- * @var \Magento\Framework\Stdlib\CookieManager |\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface |\PHPUnit_Framework_MockObject_MockObject
*/
protected $cookieManagerMock;
@@ -48,9 +48,7 @@ class ToolbarTest extends \PHPUnit_Framework_TestCase
*/
public function setUp()
{
- $this->cookieManagerMock = $this->getMockBuilder('Magento\Framework\Stdlib\CookieManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->requestMock = $this->getMockBuilder('Magento\Framework\App\Request\Http')
->disableOriginalConstructor()
->getMock();
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/ProductTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/ProductTest.php
index 30ac0a1b706e4cca75ce0e95a30b1ae6c47c5605..0ae27a015335cd3a4d7944c37e869e76c1b364ea 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/ProductTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/ProductTest.php
@@ -33,7 +33,9 @@ use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper;
*/
class ProductTest extends \PHPUnit_Framework_TestCase
{
- /** @var ObjectManagerHelper */
+ /**
+ * @var ObjectManagerHelper
+ */
protected $objectManagerHelper;
/**
@@ -41,6 +43,16 @@ class ProductTest extends \PHPUnit_Framework_TestCase
*/
protected $model;
+ /**
+ * @var \Magento\Catalog\Helper\Data|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $catalogDataMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItemBuilderMock;
+
/**
* @var \Magento\Indexer\Model\IndexerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
@@ -113,6 +125,20 @@ class ProductTest extends \PHPUnit_Framework_TestCase
{
$this->categoryIndexerMock = $this->getMockForAbstractClass('\Magento\Indexer\Model\IndexerInterface');
+ $this->catalogDataMock = $this->getMock(
+ 'Magento\Catalog\Helper\Data',
+ ['isModuleEnabled'],
+ [],
+ '',
+ false
+ );
+ $this->stockItemBuilderMock = $this->getMock(
+ 'Magento\CatalogInventory\Api\Data\StockItemDataBuilder',
+ ['populateWithArray', 'create'],
+ [],
+ '',
+ false
+ );
$this->productFlatProcessor = $this->getMock(
'Magento\Catalog\Model\Indexer\Product\Flat\Processor',
array(),
@@ -213,6 +239,8 @@ class ProductTest extends \PHPUnit_Framework_TestCase
'resource' => $this->resource,
'registry' => $this->registry,
'categoryFactory' => $this->categoryFactory,
+ 'catalogData' => $this->catalogDataMock,
+ 'stockItemBuilder' => $this->stockItemBuilderMock,
'indexerRegistry' => $this->indexerRegistryMock,
'data' => array('id' => 1)
]
@@ -474,6 +502,47 @@ class ProductTest extends \PHPUnit_Framework_TestCase
$this->model->getResource()->expects($this->any())->method('commit')->will($this->returnSelf());
}
+ /**
+ * Run test fromArray method
+ *
+ * @return void
+ */
+ public function testFromArray()
+ {
+ $data = [
+ 'stock_item' => 'stock-item-data'
+ ];
+
+ $stockItemMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Api\AbstractSimpleObject',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['setProduct']
+ );
+
+ $this->catalogDataMock->expects($this->once())
+ ->method('isModuleEnabled')
+ ->with('Magento_CatalogInventory')
+ ->will($this->returnValue(true));
+ $this->stockItemBuilderMock->expects($this->once())
+ ->method('populateWithArray')
+ ->with($data['stock_item'])
+ ->will($this->returnSelf());
+ $this->stockItemBuilderMock->expects($this->once())
+ ->method('populateWithArray')
+ ->with($data['stock_item'])
+ ->will($this->returnSelf());
+ $this->stockItemBuilderMock->expects($this->once())
+ ->method('create')
+ ->will($this->returnValue($stockItemMock));
+ $stockItemMock->expects($this->once())->method('setProduct')->with($this->model);
+
+ $this->assertEquals($this->model, $this->model->fromArray($data));
+ }
+
protected function prepareCategoryIndexer()
{
$this->indexerRegistryMock->expects($this->once())
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Category/Collection/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Category/Collection/FactoryTest.php
index fc35754588bffb63a71ee369f8c14c2ef9b36ab4..87a25c7b10bed8ea0922e7d7abb4ff421bb8037c 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Category/Collection/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Category/Collection/FactoryTest.php
@@ -37,7 +37,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Catalog\Model\Resource\Category\Collection\Factory($this->_objectManager);
}
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Template/Filter/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Template/Filter/FactoryTest.php
index 5f71aa8f74310b339cdc8fbca531561b9d729439..c6ee193df482feb4ae6ea25e084e03b5ed729ad4 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Template/Filter/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Template/Filter/FactoryTest.php
@@ -26,7 +26,7 @@ namespace Magento\Catalog\Model\Template\Filter;
class FactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManagerMock;
@@ -37,7 +37,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->_factory = $objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/TierPriceTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/TierPriceTest.php
index 6dc86b8bd4a5399165bf802ca7a85a4c7cb20f0e..3aeeb359e3105df4810c69902f0345ad47ebf799 100644
--- a/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/TierPriceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/TierPriceTest.php
@@ -184,8 +184,6 @@ class TierPriceTest extends \PHPUnit_Framework_TestCase
$price = $this->getMock('Magento\Framework\Pricing\Price\PriceInterface', [], [], '', false);
$price->expects($this->any())->method('getValue')->will($this->returnValue($basePrice));
- $this->priceInfo->expects($this->atLeastOnce())->method('getPrice')->will($this->returnValue($price));
-
$this->calculator->expects($this->atLeastOnce())->method('getAmount')
->will($this->returnArgument(0));
@@ -208,13 +206,6 @@ class TierPriceTest extends \PHPUnit_Framework_TestCase
'price_qty' => '1.3',
'cust_group' => $this->customerGroup + 1
],
- // will be ignored due to bigger price
- [
- 'price' => '50.3',
- 'website_price' => '50.3',
- 'price_qty' => '10.3',
- 'cust_group' => Group::CUST_GROUP_ALL
- ],
[
'price' => '25.4',
'website_price' => '25.4',
@@ -280,7 +271,8 @@ class TierPriceTest extends \PHPUnit_Framework_TestCase
$this->priceInfo->expects($this->atLeastOnce())
->method('getPrice')
- ->will($this->returnValue($price));
+ ->will($this->returnValue($price))
+ ->with(RegularPrice::PRICE_CODE);
$amount = $this->getMockForAbstractClass('Magento\Framework\Pricing\Amount\AmountInterface');
$amount->expects($this->atLeastOnce())
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Api/StockConfigurationTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Api/StockConfigurationTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..47c0af72f3fe6f625e05a3fc58c40061349c9279
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Api/StockConfigurationTest.php
@@ -0,0 +1,146 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\CatalogInventory\Api;
+
+use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper;
+
+/**
+ * Class StockConfigurationTest
+ */
+class StockConfigurationTest extends \PHPUnit_Framework_TestCase
+{
+ /** @var \Magento\CatalogInventory\Api\StockConfigurationInterface */
+ protected $stockConfiguration;
+
+ /** @var ObjectManagerHelper */
+ protected $objectManagerHelper;
+
+ /**
+ * @var \Magento\Catalog\Model\ProductTypes\ConfigInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $config;
+
+ /**
+ * @var \Magento\Framework\App\Config\ScopeConfigInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $scopeConfig;
+
+ /**
+ * @var \Magento\CatalogInventory\Helper\Minsaleqty|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $minsaleqtyHelper;
+
+ protected function setUp()
+ {
+ $this->config = $this->getMockForAbstractClass(
+ 'Magento\Catalog\Model\ProductTypes\ConfigInterface',
+ [],
+ '',
+ false
+ );
+ $this->scopeConfig = $this->getMockForAbstractClass(
+ 'Magento\Framework\App\Config\ScopeConfigInterface',
+ ['isSetFlag'],
+ '',
+ false
+ );
+
+ $this->minsaleqtyHelper = $this->getMock(
+ 'Magento\CatalogInventory\Helper\Minsaleqty',
+ [],
+ [],
+ '',
+ false
+ );
+
+ $this->objectManagerHelper = new ObjectManagerHelper($this);
+ $this->stockConfiguration = $this->objectManagerHelper->getObject(
+ 'Magento\CatalogInventory\Model\Configuration',
+ [
+ 'config' => $this->config,
+ 'scopeConfig' => $this->scopeConfig,
+ 'minsaleqtyHelper' => $this->minsaleqtyHelper
+ ]
+ );
+ }
+
+ public function testGetConfigItemOptions()
+ {
+ $configOptions = [
+ 'min_qty',
+ 'backorders',
+ 'min_sale_qty',
+ 'max_sale_qty',
+ 'notify_stock_qty',
+ 'manage_stock',
+ 'enable_qty_increments',
+ 'qty_increments',
+ 'is_decimal_divided'
+ ];
+ $this->assertSame($configOptions, $this->stockConfiguration->getConfigItemOptions());
+ }
+
+ public function testIsShowOutOfStock()
+ {
+ $store = 0;
+ $this->scopeConfig->expects($this->once())
+ ->method('isSetFlag')
+ ->with(
+ \Magento\CatalogInventory\Model\Configuration::XML_PATH_SHOW_OUT_OF_STOCK,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ )
+ ->will($this->returnValue(true));
+ $this->assertTrue($this->stockConfiguration->isShowOutOfStock());
+ }
+
+ public function testIsAutoReturnEnabled()
+ {
+ $store = 0;
+ $this->scopeConfig->expects($this->once())
+ ->method('isSetFlag')
+ ->with(
+ \Magento\CatalogInventory\Model\Configuration::XML_PATH_ITEM_AUTO_RETURN,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ )
+ ->will($this->returnValue(true));
+ $this->assertTrue($this->stockConfiguration->isAutoReturnEnabled());
+ }
+
+ public function testIsDisplayProductStockStatus()
+ {
+ $store = 0;
+ $this->scopeConfig->expects($this->once())
+ ->method('isSetFlag')
+ ->with(
+ \Magento\CatalogInventory\Model\Configuration::XML_PATH_DISPLAY_PRODUCT_STOCK_STATUS,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ )
+ ->will($this->returnValue(true));
+ $this->assertTrue($this->stockConfiguration->isDisplayProductStockStatus());
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Api/StockRegistryTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Api/StockRegistryTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..40f312fb274710168337144959bddca15e84d2e9
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Api/StockRegistryTest.php
@@ -0,0 +1,200 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper;
+
+/**
+ * Class StockRegistryTest
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
+class StockRegistryTest extends \PHPUnit_Framework_TestCase
+{
+ /** @var ObjectManagerHelper */
+ protected $objectManagerHelper;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface
+ */
+ protected $stockRegistry;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistryProvider;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stock;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockItemInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItem;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockStatusInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockStatus;
+
+ /**
+ * @var \Magento\Catalog\Model\ProductFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $productFactory;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockItemRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItemRepository;
+
+ /**
+ * @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $product;
+
+ protected $productId = 111;
+ protected $productSku = 'simple';
+ protected $websiteId = 111;
+
+ protected function setUp()
+ {
+ $this->objectManagerHelper = new ObjectManagerHelper($this);
+
+ $this->product = $this->getMock('Magento\Catalog\Model\Product', ['__wakeup', 'getIdBySku'], [], '', false);
+ $this->product->expects($this->any())
+ ->method('getIdBySku')
+ ->willReturn($this->productId);
+ //getIdBySku
+ $this->productFactory = $this->getMock('Magento\Catalog\Model\ProductFactory', ['create'], [], '', false);
+ $this->productFactory->expects($this->any())
+ ->method('create')
+ ->will($this->returnValue($this->product));
+
+ $this->stock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockInterface',
+ ['__wakeup'],
+ '',
+ false
+ );
+ $this->stockItem = $this->getMockBuilder('Magento\CatalogInventory\Api\Data\StockItemInterface')
+ ->setMethods(['setProductId', 'getData', 'addData', 'getItemId'])
+ ->disableOriginalConstructor()
+ ->getMockForAbstractClass();
+ $this->stockStatus = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockStatusInterface',
+ ['__wakeup'],
+ '',
+ false
+ );
+
+ $this->stockRegistryProvider = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface',
+ ['getStock', 'getStockItem', 'getStockStatus'],
+ '',
+ false
+ );
+ $this->stockRegistryProvider->expects($this->any())
+ ->method('getStock')
+ ->will($this->returnValue($this->stock));
+ $this->stockRegistryProvider->expects($this->any())
+ ->method('getStockItem')
+ ->will($this->returnValue($this->stockItem));
+ $this->stockRegistryProvider->expects($this->any())
+ ->method('getStockStatus')
+ ->will($this->returnValue($this->stockStatus));
+
+ $this->stockItemRepository = $this->getMockForAbstractClass(
+ '\Magento\CatalogInventory\Api\StockItemRepositoryInterface',
+ ['save'],
+ '',
+ false
+ );
+ $this->stockItemRepository->expects($this->any())
+ ->method('save')
+ ->will($this->returnValue($this->stockItem));
+
+ $this->stockRegistry = $this->objectManagerHelper->getObject(
+ '\Magento\CatalogInventory\Model\StockRegistry',
+ [
+ 'stockRegistryProvider' => $this->stockRegistryProvider,
+ 'productFactory' => $this->productFactory,
+ 'stockItemRepository' => $this->stockItemRepository
+ ]
+ );
+ }
+
+ protected function tearDown()
+ {
+ $this->stockRegistry = null;
+ }
+
+ public function testGetStock()
+ {
+ $this->assertEquals($this->stock, $this->stockRegistry->getStock($this->websiteId));
+ }
+
+ public function testGetStockItem()
+ {
+ $this->assertEquals($this->stockItem, $this->stockRegistry->getStockItem($this->productId, $this->websiteId));
+ }
+
+ public function testGetStockItemBySku()
+ {
+ $this->assertEquals(
+ $this->stockItem,
+ $this->stockRegistry->getStockItemBySku($this->productSku, $this->websiteId)
+ );
+ }
+
+ public function testGetStockStatus()
+ {
+ $this->assertEquals(
+ $this->stockStatus,
+ $this->stockRegistry->getStockStatus($this->productId, $this->websiteId)
+ );
+ }
+
+ public function testGetStockStatusBySku()
+ {
+ $this->assertEquals(
+ $this->stockStatus,
+ $this->stockRegistry->getStockStatus($this->productId, $this->websiteId)
+ );
+ }
+
+ public function testUpdateStockItemBySku()
+ {
+ $itemId = 1;
+ $this->stockItem->expects($this->once())->method('setProductId')->willReturnSelf();
+ $this->stockItem->expects($this->once())->method('getData')->willReturn([]);
+ $this->stockItem->expects($this->once())->method('addData')->willReturnSelf();
+ $this->stockItem->expects($this->atLeastOnce())->method('getId')->willReturn($itemId);
+ $this->assertEquals(
+ $itemId,
+ $this->stockRegistry->updateStockItemBySku($this->productSku, $this->stockItem)
+ );
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Api/StockStateTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Api/StockStateTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..8e44288674ad85c11c60694de35281c94e38c228
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Api/StockStateTest.php
@@ -0,0 +1,226 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Api;
+
+use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper;
+
+/**
+ * Class StockStateTest
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
+class StockStateTest extends \PHPUnit_Framework_TestCase
+{
+ /** @var ObjectManagerHelper */
+ protected $objectManagerHelper;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockStateInterface
+ */
+ protected $stockState;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Spi\StockStateProviderInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockStateProvider;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistryProvider;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stock;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockItemInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItem;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockStatusInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockStatus;
+
+ /**
+ * @var \Magento\Framework\Object|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $objectResult;
+
+ protected $productId = 111;
+ protected $websiteId = 111;
+ protected $qty = 111;
+
+ protected function setUp()
+ {
+ $this->objectManagerHelper = new ObjectManagerHelper($this);
+
+ $this->stock = $this->getMock(
+ '\Magento\CatalogInventory\Api\Data\StockInterface',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->stockItem = $this->getMock(
+ '\Magento\CatalogInventory\Api\Data\StockItemInterface',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->stockStatus = $this->getMock(
+ '\Magento\CatalogInventory\Api\Data\StockStatusInterface',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->objectResult = $this->getMock(
+ '\Magento\Framework\Object',
+ [],
+ [],
+ '',
+ false
+ );
+
+ $this->stockStateProvider = $this->getMock(
+ 'Magento\CatalogInventory\Model\Spi\StockStateProviderInterface',
+ [
+ 'verifyStock',
+ 'verifyNotification',
+ 'checkQty',
+ 'suggestQty',
+ 'getStockQty',
+ 'checkQtyIncrements',
+ 'checkQuoteItemQty'
+ ],
+ [],
+ '',
+ false
+ );
+ $this->stockStateProvider->expects($this->any())->method('verifyStock')->willReturn(true);
+ $this->stockStateProvider->expects($this->any())->method('verifyNotification')->willReturn(true);
+ $this->stockStateProvider->expects($this->any())->method('checkQty')->willReturn(true);
+ $this->stockStateProvider->expects($this->any())->method('suggestQty')->willReturn($this->qty);
+ $this->stockStateProvider->expects($this->any())->method('getStockQty')->willReturn($this->qty);
+ $this->stockStateProvider->expects($this->any())->method('checkQtyIncrements')->willReturn($this->objectResult);
+ $this->stockStateProvider->expects($this->any())->method('checkQuoteItemQty')->willReturn($this->objectResult);
+
+ $this->stockRegistryProvider = $this->getMock(
+ 'Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface',
+ ['getStock', 'getStockItem', 'getStockStatus'],
+ [],
+ '',
+ false
+ );
+ $this->stockRegistryProvider->expects($this->any())
+ ->method('getStock')
+ ->will($this->returnValue($this->stock));
+ $this->stockRegistryProvider->expects($this->any())
+ ->method('getStockItem')
+ ->will($this->returnValue($this->stockItem));
+ $this->stockRegistryProvider->expects($this->any())
+ ->method('getStockStatus')
+ ->will($this->returnValue($this->stockStatus));
+
+
+ $this->stockState = $this->objectManagerHelper->getObject(
+ '\Magento\CatalogInventory\Model\StockState',
+ [
+ 'stockStateProvider' => $this->stockStateProvider,
+ 'stockRegistryProvider' => $this->stockRegistryProvider
+ ]
+ );
+ }
+
+ protected function tearDown()
+ {
+ $this->stockState = null;
+ }
+
+ public function testVerifyStock()
+ {
+ $this->assertEquals(
+ true,
+ $this->stockState->verifyStock($this->productId, $this->websiteId)
+ );
+ }
+
+ public function testVerifyNotification()
+ {
+ $this->assertEquals(
+ true,
+ $this->stockState->verifyNotification($this->productId, $this->websiteId)
+ );
+ }
+
+ public function testCheckQty()
+ {
+ $this->assertEquals(
+ true,
+ $this->stockState->checkQty($this->productId, $this->qty, $this->websiteId)
+ );
+ }
+
+ public function testSuggestQty()
+ {
+ $this->assertEquals(
+ $this->qty,
+ $this->stockState->suggestQty($this->productId, $this->qty, $this->websiteId)
+ );
+ }
+
+ public function testGetStockQty()
+ {
+ $this->assertEquals(
+ $this->qty,
+ $this->stockState->getStockQty($this->productId, $this->websiteId)
+ );
+ }
+
+ public function testCheckQtyIncrements()
+ {
+ $this->assertEquals(
+ $this->objectResult,
+ $this->stockState->checkQtyIncrements($this->productId, $this->qty, $this->websiteId)
+ );
+ }
+
+ public function testCheckQuoteItemQty()
+ {
+ $this->assertEquals(
+ $this->objectResult,
+ $this->stockState->checkQuoteItemQty(
+ $this->productId,
+ $this->qty,
+ $this->qty,
+ $this->qty,
+ $this->websiteId
+ )
+ );
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Block/QtyincrementsTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Block/QtyincrementsTest.php
index a54aca81fadf059e1f32edde5075855ca293e0ef..be81b7ca41de9de56277f519e6514cfe465e2213 100644
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Block/QtyincrementsTest.php
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Block/QtyincrementsTest.php
@@ -39,27 +39,39 @@ class QtyincrementsTest extends \PHPUnit_Framework_TestCase
protected $registryMock;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Api\Data\StockItemInterface|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $stockItemService;
+ protected $stockItem;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistry;
protected function setUp()
{
$objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->registryMock = $this->getMock('Magento\Framework\Registry', [], [], '', false);
- $this->stockItemService = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
- [],
- [],
+ $this->stockItem = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockItemInterface',
+ ['getQtyIncrements'],
+ '',
+ false
+ );
+ $this->stockItem->expects($this->any())->method('getStockItem')->willReturn(1);
+ $this->stockRegistry = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockRegistryInterface',
+ ['getStockItem'],
'',
false
);
+ $this->stockRegistry->expects($this->any())->method('getStockItem')->willReturn($this->stockItem);
$this->block = $objectManager->getObject(
'Magento\CatalogInventory\Block\Qtyincrements',
[
'registry' => $this->registryMock,
- 'stockItemService' => $this->stockItemService
+ 'stockRegistry' => $this->stockRegistry
]
);
}
@@ -74,6 +86,9 @@ class QtyincrementsTest extends \PHPUnit_Framework_TestCase
$productTags = array('catalog_product_1');
$product = $this->getMock('Magento\Catalog\Model\Product', [], [], '', false);
$product->expects($this->once())->method('getIdentities')->will($this->returnValue($productTags));
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId', '__wakeup'], [], '', false);
+ $store->expects($this->any())->method('getWebsiteId')->willReturn(0);
+ $product->expects($this->any())->method('getStore')->will($this->returnValue($store));
$this->registryMock->expects($this->once())
->method('registry')
->with('current_product')
@@ -90,14 +105,16 @@ class QtyincrementsTest extends \PHPUnit_Framework_TestCase
*/
public function testGetProductQtyIncrements($productId, $qtyInc, $isSaleable, $result)
{
- $this->stockItemService->expects($this->once())
+ $this->stockItem->expects($this->once())
->method('getQtyIncrements')
- ->with($this->equalTo($productId))
->will($this->returnValue($qtyInc));
$product = $this->getMock('Magento\Catalog\Model\Product', [], [], '', false);
$product->expects($this->once())->method('getId')->will($this->returnValue($productId));
$product->expects($this->once())->method('isSaleable')->will($this->returnValue($isSaleable));
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId', '__wakeup'], [], '', false);
+ $store->expects($this->any())->method('getWebsiteId')->willReturn(0);
+ $product->expects($this->any())->method('getStore')->will($this->returnValue($store));
$this->registryMock->expects($this->any())
->method('registry')
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Block/Stockqty/DefaultStockqtyTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Block/Stockqty/DefaultStockqtyTest.php
index 3c281d7131db5e5012cb4f7f43054cd7525298b7..b10e3d476b5ffad427063279fde5e1a9b219d2c6 100644
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Block/Stockqty/DefaultStockqtyTest.php
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Block/Stockqty/DefaultStockqtyTest.php
@@ -39,25 +39,36 @@ class DefaultStockqtyTest extends \PHPUnit_Framework_TestCase
protected $registryMock;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Api\StockStateInterface|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $stockItemService;
+ protected $stockState;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistryMock;
protected function setUp()
{
$objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->registryMock = $this->getMock('Magento\Framework\Registry', array(), array(), '', false);
- $this->stockItemService = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
+ $this->stockState = $this->getMock(
+ 'Magento\CatalogInventory\Api\StockStateInterface',
[],
[],
'',
false
);
-
+ $this->stockRegistryMock = $this->getMockBuilder('Magento\CatalogInventory\Api\StockRegistryInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
$this->block = $objectManager->getObject(
'Magento\CatalogInventory\Block\Stockqty\DefaultStockqty',
- array('registry' => $this->registryMock, 'stockItemService' => $this->stockItemService)
+ [
+ 'registry' => $this->registryMock,
+ 'stockState' => $this->stockState,
+ 'stockRegistry' => $this->stockRegistryMock
+ ]
);
}
@@ -81,18 +92,28 @@ class DefaultStockqtyTest extends \PHPUnit_Framework_TestCase
/**
* @param int $productStockQty
* @param int|null $productId
+ * @param int|null $websiteId
* @param int|null $dataQty
* @param int $expectedQty
* @dataProvider getStockQtyDataProvider
*/
- public function testGetStockQty($productStockQty, $productId, $dataQty, $expectedQty)
+ public function testGetStockQty($productStockQty, $productId, $websiteId, $dataQty, $expectedQty)
{
$this->assertNull($this->block->getData('product_stock_qty'));
if ($dataQty) {
$this->setDataArrayValue('product_stock_qty', $dataQty);
} else {
- $product = $this->getMock('Magento\Catalog\Model\Product', ['getId', '__wakeup'], [], '', false);
+ $product = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getId', 'getStore', '__wakeup'],
+ [],
+ '',
+ false
+ );
$product->expects($this->any())->method('getId')->will($this->returnValue($productId));
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId', '__wakeup'], [], '', false);
+ $store->expects($this->any())->method('getWebsiteId')->willReturn($websiteId);
+ $product->expects($this->any())->method('getStore')->will($this->returnValue($store));
$this->registryMock->expects($this->any())
->method('registry')
@@ -100,9 +121,9 @@ class DefaultStockqtyTest extends \PHPUnit_Framework_TestCase
->will($this->returnValue($product));
if ($productId) {
- $this->stockItemService->expects($this->once())
+ $this->stockState->expects($this->once())
->method('getStockQty')
- ->with($this->equalTo($productId))
+ ->with($this->equalTo($productId), $this->equalTo($websiteId))
->will($this->returnValue($productStockQty));
}
}
@@ -110,48 +131,47 @@ class DefaultStockqtyTest extends \PHPUnit_Framework_TestCase
$this->assertSame($expectedQty, $this->block->getData('product_stock_qty'));
}
- public function testGetStockQtyLeft()
+ public function te1stGetStockQtyLeft()
{
- $productMinQty = 2;
- $treshold = 2;
- $productStockQty = 3;
- $productId = 4;
- $expectedQty = 1;
-
- $product = $this->getMock('Magento\Catalog\Model\Product', ['getId', '__wakeup'], [], '', false);
- $product->expects($this->any())->method('getId')->will($this->returnValue($productId));
-
- $this->setDataArrayValue('threshold_qty', $treshold);
-
- $this->registryMock->expects($this->any())
+ $productId = 1;
+ $minQty = 0;
+ $websiteId = 1;
+ $stockQty = 2;
+
+ $storeMock = $this->getMockBuilder('Magento\Store\Model\Store')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $storeMock->expects($this->once())
+ ->method('getWebsiteId')
+ ->willReturn($websiteId);
+ $product = $this->getMock('Magento\Catalog\Model\Product', [], [], '', false);
+ $product->expects($this->any())
+ ->method('getId')
+ ->willReturn($productId);
+ $product->expects($this->once())
+ ->method('getStore')
+ ->willReturn($storeMock);
+ $this->registryMock->expects($this->once())
->method('registry')
->with('current_product')
->will($this->returnValue($product));
-
- $this->stockItemService->expects($this->once())
- ->method('getStockQty')
- ->with($this->equalTo($productId))
- ->will($this->returnValue($productStockQty));
-
- $stockItem = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\Data\StockItem',
- [],
- [],
- '',
- false
- );
-
- $stockItem->expects($this->once())
+ $stockItemMock = $this->getMockBuilder('Magento\CatalogInventory\Api\Data\StockItemInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $stockItemMock->expects($this->once())
->method('getMinQty')
- ->will($this->returnValue($productMinQty));
-
- $this->stockItemService->expects($this->once())
+ ->willReturn($minQty);
+ $this->stockRegistryMock->expects($this->once())
->method('getStockItem')
- ->with($this->equalTo($productId))
- ->will($this->returnValue($stockItem));
+ ->with($productId)
+ ->willReturn($stockItemMock);
+ $this->stockState->expects($this->once())
+ ->method('getStockQty')
+ ->with($productId, $storeMock)
+ ->willReturn($stockQty);
- $this->assertSame($expectedQty, $this->block->getStockQtyLeft());
+ $this->assertEquals($stockQty, $this->block->getStockQtyLeft());
}
/**
@@ -163,18 +183,21 @@ class DefaultStockqtyTest extends \PHPUnit_Framework_TestCase
[
'product qty' => 100,
'product id' => 5,
+ 'website id' => 0,
'default qty' => null,
'expected qty' => 100
],
[
'product qty' => 100,
'product id' => null,
+ 'website id' => null,
'default qty' => null,
'expected qty' => 0
],
[
'product qty' => null,
'product id' => null,
+ 'website id' => null,
'default qty' => 50,
'expected qty' => 50
],
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Helper/DataTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Helper/DataTest.php
deleted file mode 100644
index 61568042a515225d1c06b934d05153564c1206e9..0000000000000000000000000000000000000000
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Helper/DataTest.php
+++ /dev/null
@@ -1,112 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-namespace Magento\CatalogInventory\Helper;
-
-use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper;
-
-/**
- * Class DataTest
- */
-class DataTest extends \PHPUnit_Framework_TestCase
-{
- /** @var \Magento\CatalogInventory\Helper\Data */
- protected $data;
-
- /** @var ObjectManagerHelper */
- protected $objectManagerHelper;
-
- /** @var \Magento\Framework\App\Helper\Context|\PHPUnit_Framework_MockObject_MockObject */
- protected $contextMock;
-
- /** @var \Magento\Framework\App\Config\ScopeConfigInterface|\PHPUnit_Framework_MockObject_MockObject */
- protected $scopeConfigMock;
-
- protected function setUp()
- {
- $this->contextMock = $this->getMock('Magento\Framework\App\Helper\Context', [], [], '', false);
- $this->scopeConfigMock = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface');
-
- $this->objectManagerHelper = new ObjectManagerHelper($this);
- $this->data = $this->objectManagerHelper->getObject(
- 'Magento\CatalogInventory\Helper\Data',
- [
- 'context' => $this->contextMock,
- 'scopeConfig' => $this->scopeConfigMock
- ]
- );
- }
-
- public function testGetConfigItemOptions()
- {
- $configOptions = [
- 'min_qty',
- 'backorders',
- 'min_sale_qty',
- 'max_sale_qty',
- 'notify_stock_qty',
- 'manage_stock',
- 'enable_qty_increments',
- 'qty_increments',
- 'is_decimal_divided'
- ];
- $this->assertSame($configOptions, $this->data->getConfigItemOptions());
- }
-
- public function testIsShowOutOfStock()
- {
- $this->scopeConfigMock->expects($this->once())
- ->method('isSetFlag')
- ->with(
- $this->equalTo(Data::XML_PATH_SHOW_OUT_OF_STOCK),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
- ->will($this->returnValue(true));
- $this->assertTrue($this->data->isShowOutOfStock());
- }
-
- public function testIsAutoReturnEnabled()
- {
- $this->scopeConfigMock->expects($this->once())
- ->method('isSetFlag')
- ->with(
- $this->equalTo(Data::XML_PATH_ITEM_AUTO_RETURN),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
- ->will($this->returnValue(true));
- $this->assertTrue($this->data->isAutoReturnEnabled());
- }
-
- public function testIsDisplayProductStockStatus()
- {
- $this->scopeConfigMock->expects($this->once())
- ->method('isSetFlag')
- ->with(
- $this->equalTo(Data::XML_PATH_DISPLAY_PRODUCT_STOCK_STATUS),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
- ->will($this->returnValue(true));
- $this->assertTrue($this->data->isDisplayProductStockStatus());
- }
-}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Helper/MinsaleqtyTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Helper/MinsaleqtyTest.php
index 967e1ab70d196d77c49eb940613eaee45f3a128f..3f5209b3953411fb89810c8e160cf9e230d4da9d 100644
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Helper/MinsaleqtyTest.php
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Helper/MinsaleqtyTest.php
@@ -74,7 +74,7 @@ class MinsaleqtyTest extends \PHPUnit_Framework_TestCase
$this->scopeConfigMock->expects($this->once())
->method('getValue')
->with(
- $this->equalTo(\Magento\CatalogInventory\Model\Stock\Item::XML_PATH_MIN_SALE_QTY),
+ $this->equalTo(\Magento\CatalogInventory\Model\Configuration::XML_PATH_MIN_SALE_QTY),
$this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE),
$this->equalTo($store)
)
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Helper/StockTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Helper/StockTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..844da43535649f79978a92f2d9cb7e7681d515ca
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Helper/StockTest.php
@@ -0,0 +1,236 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Helper;
+
+/**
+ * Class StockTest
+ */
+class StockTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\CatalogInventory\Helper\Stock
+ */
+ protected $stock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistryMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $storeManagerMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $scopeConfigMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $productFactoryMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $objectManagerMock;
+
+ protected function setUp()
+ {
+ $this->stockRegistryMock = $this->getMockBuilder(
+ 'Magento\CatalogInventory\Api\StockRegistryInterface'
+ )
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->storeManagerMock = $this->getMockBuilder('Magento\Framework\StoreManagerInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->scopeConfigMock = $this->getMockBuilder('Magento\Framework\App\Config\ScopeConfigInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\App\ObjectManager')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->stock = new Stock(
+ $this->stockRegistryMock,
+ $this->storeManagerMock,
+ $this->scopeConfigMock,
+ $this->objectManagerMock
+ );
+ }
+
+ public function testAssignStatusToProduct()
+ {
+ $websiteId = 1;
+ $status = 'test';
+
+ $stockStatusMock = $this->getMockBuilder('Magento\CatalogInventory\Api\Data\StockStatusInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $stockStatusMock->expects($this->any())
+ ->method('getStockStatus')
+ ->willReturn($status);
+ $this->stockRegistryMock->expects($this->any())
+ ->method('getStockStatus')
+ ->willReturn($stockStatusMock);
+ $storeMock = $this->getMockBuilder('Magento\Store\Model\Store')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $storeMock->expects($this->once())
+ ->method('getWebsiteId')
+ ->willReturn($websiteId);
+ $productMock = $this->getMockBuilder('Magento\Catalog\Model\Product')
+ ->disableOriginalConstructor()
+ ->setMethods(['setIsSalable', 'getStore', 'getId'])
+ ->getMock();
+ $productMock->expects($this->any())
+ ->method('getStore')
+ ->willReturn($storeMock);
+ $productMock->expects($this->once())
+ ->method('setIsSalable')
+ ->with($status);
+ $this->assertNull($this->stock->assignStatusToProduct($productMock));
+ }
+
+ public function testAddStockStatusToProducts()
+ {
+ $storeId = 1;
+ $productId = 2;
+ $status = 'test';
+
+ $productMock = $this->getMockBuilder('Magento\Catalog\Model\Product')
+ ->disableOriginalConstructor()
+ ->setMethods(['setIsSalable', 'getId'])
+ ->getMock();
+ $productMock->expects($this->once())
+ ->method('setIsSalable')
+ ->with($status);
+ $stockStatusMock = $this->getMockBuilder('Magento\CatalogInventory\Api\Data\StockStatusInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $stockStatusMock->expects($this->once())
+ ->method('getStockStatus')
+ ->willReturn($status);
+ $productCollectionMock = $this->getMockBuilder('Magento\Catalog\Model\Resource\Collection\AbstractCollection')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $productCollectionMock->expects($this->any())
+ ->method('getItemById')
+ ->with($productId)
+ ->willReturn($productMock);
+ $productCollectionMock->expects($this->any())
+ ->method('getStoreId')
+ ->willReturn($storeId);
+ $productMock->expects($this->any())
+ ->method('getId')
+ ->willReturn($productId);
+ $iteratorMock = new \ArrayIterator([$productMock]);
+
+ $productCollectionMock->expects($this->any())
+ ->method('getIterator')
+ ->willReturn($iteratorMock);
+ $storeMock = $this->getMockBuilder('Magento\Store\Model\Store')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->storeManagerMock->expects($this->once())
+ ->method('getStore')
+ ->willReturn($storeMock);
+ $this->stockRegistryMock->expects($this->once())
+ ->method('getStockStatus')
+ ->withAnyParameters()
+ ->willReturn($stockStatusMock);
+
+ $this->assertNull($this->stock->addStockStatusToProducts($productCollectionMock));
+ }
+
+ /**
+ * @dataProvider filterProvider
+ */
+ public function testAddInStockFilterToCollection($configMock)
+ {
+ $collectionMock = $this->getMockBuilder('Magento\Catalog\Model\Resource\Product\Link\Product\Collection')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $collectionMock->expects($this->any())
+ ->method('joinField');
+ $this->scopeConfigMock->expects($this->any())
+ ->method('getValue')
+ ->willReturn($configMock);
+ $this->assertNull($this->stock->addInStockFilterToCollection($collectionMock));
+ }
+
+ public function filterProvider()
+ {
+ $configMock = $this->getMockBuilder('Magento\Framework\App\Config')
+ ->disableOriginalConstructor()
+ ->getMock();
+ return [
+ [$configMock],
+ [null],
+ ];
+ }
+
+ public function testAddStockStatusToSelect()
+ {
+ $selectMock = $this->getMockBuilder('Magento\Framework\DB\Select')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $websiteMock = $this->getMockBuilder('Magento\Store\Model\Website')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $stockStatusMock = $this->getMockBuilder('Magento\CatalogInventory\Model\Resource\Stock\Status')
+ ->disableOriginalConstructor()
+ ->setMethods(['addStockStatusToSelect'])
+ ->getMock();
+ $stockStatusMock->expects($this->once())
+ ->method('addStockStatusToSelect')
+ ->with($selectMock, $websiteMock);
+ $this->objectManagerMock->expects($this->once())
+ ->method('get')
+ ->willReturn($stockStatusMock);
+
+ $this->assertNull($this->stock->addStockStatusToSelect($selectMock, $websiteMock));
+ }
+
+ public function testAddIsInStockFilterToCollection()
+ {
+ $collectionMock = $this->getMockBuilder('Magento\Catalog\Model\Resource\Product\Collection')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $stockStatusMock = $this->getMockBuilder('Magento\CatalogInventory\Model\Resource\Stock\Status')
+ ->disableOriginalConstructor()
+ ->setMethods(['addIsInStockFilterToCollection'])
+ ->getMock();
+ $stockStatusMock->expects($this->once())
+ ->method('addIsInStockFilterToCollection')
+ ->with($collectionMock);
+ $this->objectManagerMock->expects($this->once())
+ ->method('get')
+ ->willReturn($stockStatusMock);
+
+ $this->assertNull($this->stock->addIsInStockFilterToCollection($collectionMock));
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Adminhtml/Stock/ItemTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Adminhtml/Stock/ItemTest.php
index e2d307147270e8150505390449a3fa33c7b9c462..792e184223d28eb6e6173113b649167fcfd4f99a 100644
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Adminhtml/Stock/ItemTest.php
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Adminhtml/Stock/ItemTest.php
@@ -57,25 +57,4 @@ class ItemTest extends \PHPUnit_Framework_TestCase
$this->_model->setCustomerGroupId(2);
$this->assertEquals(2, $this->_model->getCustomerGroupId());
}
-
- public function testIsQtyCheckApplicable()
- {
- $this->_model->setData('backorders', \Magento\CatalogInventory\Model\Stock::BACKORDERS_YES_NONOTIFY);
- $this->assertTrue($this->_model->checkQty(1.0));
- }
-
- public function testCheckQuoteItemQty()
- {
- $this->_model->setData('manage_stock', 1);
- $this->_model->setData('is_in_stock', 1);
- $this->_model->setProductName('qwerty');
- $this->_model->setData('backorders', 3);
- $result = $this->_model->checkQuoteItemQty(1, 1);
- $this->assertEquals('We don\'t have as many "qwerty" as you requested.', $result->getMessage());
- }
-
- public function testHasAdminArea()
- {
- $this->assertTrue($this->_model->hasAdminArea());
- }
}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ConfigurationTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ConfigurationTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..2e04c1bf0094e00877933cc2c23bada279dcc1aa
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ConfigurationTest.php
@@ -0,0 +1,279 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model;
+
+/**
+ * Class ConfigurationTest
+ */
+class ConfigurationTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var Configuration
+ */
+ protected $model;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $configMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $scopeConfigMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $minSaleQtyHelperMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $storeManagerMock;
+
+ protected function setUp()
+ {
+ $this->configMock = $this->getMockBuilder('Magento\Catalog\Model\ProductTypes\ConfigInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->scopeConfigMock = $this->getMockBuilder('Magento\Framework\App\Config\ScopeConfigInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->minSaleQtyHelperMock = $this->getMockBuilder('Magento\CatalogInventory\Helper\Minsaleqty')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->storeManagerMock = $this->getMockBuilder('Magento\Framework\StoreManagerInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->model = new Configuration(
+ $this->configMock,
+ $this->scopeConfigMock,
+ $this->minSaleQtyHelperMock,
+ $this->storeManagerMock
+ );
+ }
+
+ public function testGetDefaultWebsiteId()
+ {
+ $id = 1;
+ $websiteMock = $this->getMockBuilder('Magento\Store\Model\Website')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $websiteMock->expects($this->once())
+ ->method('getId')
+ ->willReturn($id);
+ $this->storeManagerMock->expects($this->once())
+ ->method('getWebsite')
+ ->with(true)
+ ->willReturn($websiteMock);
+ $this->assertEquals($id, $this->model->getDefaultWebsiteId());
+ }
+
+ public function testGetIsQtyTypeIds()
+ {
+ $filter = 3;
+ $configData = [1 => ['is_qty' => 1], 2 => ['is_qty' => 2], 3 => ['is_qty' => 3]];
+
+ $this->configMock->expects($this->any())
+ ->method('getAll')
+ ->willReturn($configData);
+ $this->assertEquals([3 => '3'], $this->model->getIsQtyTypeIds($filter));
+ }
+
+ public function testIsQty()
+ {
+ $configData = [1 => ['is_qty' => 1], 2 => ['is_qty' => 2], 3 => ['is_qty' => 3]];
+ $productTypeId = 1;
+
+ $this->configMock->expects($this->any())
+ ->method('getAll')
+ ->willReturn($configData);
+ $this->assertEquals($productTypeId, $this->model->isQty($productTypeId));
+ }
+
+ public function testCanSubtractQty()
+ {
+ $this->scopeConfigMock->expects($this->once())
+ ->method('isSetFlag')
+ ->with(Configuration::XML_PATH_CAN_SUBTRACT, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, 1)
+ ->willReturn(true);
+ $this->assertTrue($this->model->canSubtractQty(1));
+ }
+
+ public function testGetMinQty()
+ {
+ $qty = 1;
+ $this->scopeConfigMock->expects($this->once())
+ ->method('getValue')
+ ->with(Configuration::XML_PATH_MIN_QTY, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, 1)
+ ->willReturn($qty);
+ $this->assertEquals($qty, $this->model->getMinQty(1));
+ }
+
+ public function testGetMinSaleQty()
+ {
+ $store = 1;
+ $customerGroupId = 2;
+
+ $this->minSaleQtyHelperMock->expects($this->once())
+ ->method('getConfigValue')
+ ->with($customerGroupId, $store)
+ ->willReturn(1);
+
+ $this->assertEquals(1.0, $this->model->getMinSaleQty($store, $customerGroupId));
+ }
+
+ public function testGetMaxSaleQty()
+ {
+ $store = 1;
+ $this->scopeConfigMock->expects($this->once())
+ ->method('getValue')
+ ->with(Configuration::XML_PATH_MAX_SALE_QTY, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, $store)
+ ->willReturn(1);
+ $this->assertEquals(1, $this->model->getMaxSaleQty($store));
+ }
+
+ public function testGetNotifyStockQty()
+ {
+ $store = 1;
+
+ $this->scopeConfigMock->expects($this->once())
+ ->method('getValue')
+ ->with(Configuration::XML_PATH_NOTIFY_STOCK_QTY, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, $store)
+ ->willReturn(1);
+ $this->assertEquals(1, $this->model->getNotifyStockQty($store));
+ }
+
+ public function testGetEnableQtyIncrements()
+ {
+ $store = 1;
+
+ $this->scopeConfigMock->expects($this->once())
+ ->method('getValue')
+ ->with(
+ Configuration::XML_PATH_ENABLE_QTY_INCREMENTS,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ )->willReturn(1);
+ $this->assertEquals(1, $this->model->getEnableQtyIncrements($store));
+ }
+
+ public function testGetQtyIncrements()
+ {
+ $store = 1;
+
+ $this->scopeConfigMock->expects($this->once())
+ ->method('getValue')
+ ->with(Configuration::XML_PATH_QTY_INCREMENTS, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, $store)
+ ->willReturn(1);
+ $this->assertEquals(1, $this->model->getQtyIncrements($store));
+ }
+
+ public function testGetBackorders()
+ {
+ $store = 1;
+ $this->scopeConfigMock->expects($this->once())
+ ->method('getValue')
+ ->with(Configuration::XML_PATH_BACKORDERS, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, $store)
+ ->willReturn(1);
+ $this->model->getBackorders($store);
+ }
+
+ public function testGetCanBackInStock()
+ {
+ $store = 1;
+ $this->scopeConfigMock->expects($this->once())
+ ->method('isSetFlag')
+ ->with(Configuration::XML_PATH_CAN_BACK_IN_STOCK, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, $store)
+ ->willReturn(1);
+ $this->assertEquals(1, $this->model->getCanBackInStock($store));
+ }
+
+ public function testIsShowOutOfStock()
+ {
+ $store = 1;
+ $this->scopeConfigMock->expects($this->once())
+ ->method('isSetFlag')
+ ->with(Configuration::XML_PATH_SHOW_OUT_OF_STOCK, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, $store)
+ ->willReturn(1);
+ $this->assertEquals(1, $this->model->isShowOutOfStock($store));
+ }
+
+ public function testIsAutoReturnEnabled()
+ {
+ $store = 1;
+ $this->scopeConfigMock->expects($this->once())
+ ->method('isSetFlag')
+ ->with(Configuration::XML_PATH_ITEM_AUTO_RETURN, \Magento\Store\Model\ScopeInterface::SCOPE_STORE, $store)
+ ->willReturn(1);
+ $this->assertEquals(1, $this->model->isAutoReturnEnabled($store));
+ }
+
+ public function testIsDisplayProductStockStatus()
+ {
+ $store = 1;
+ $this->scopeConfigMock->expects($this->once())
+ ->method('isSetFlag')
+ ->with(
+ Configuration::XML_PATH_DISPLAY_PRODUCT_STOCK_STATUS,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ )
+ ->willReturn(1);
+ $this->assertEquals(1, $this->model->isDisplayProductStockStatus($store));
+ }
+
+ public function testGetDefaultConfigValue()
+ {
+ $field = 'test_field';
+ $store = 1;
+
+ $this->scopeConfigMock->expects($this->once())
+ ->method('getValue')
+ ->with(
+ Configuration::XML_PATH_ITEM . $field,
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+ $store
+ )
+ ->willReturn(1);
+ $this->assertEquals(1, $this->model->getDefaultConfigValue($field, $store));
+ }
+
+ public function testGetConfigItemOptions()
+ {
+ $fields = [
+ 'min_qty',
+ 'backorders',
+ 'min_sale_qty',
+ 'max_sale_qty',
+ 'notify_stock_qty',
+ 'manage_stock',
+ 'enable_qty_increments',
+ 'qty_increments',
+ 'is_decimal_divided'
+ ];
+ $this->assertEquals($fields, $this->model->getConfigItemOptions());
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ObserverTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ObserverTest.php
index 1494652bbc1a599b594b857c30b97b6d50f0eee3..56b073dc70fe3e259fff0e4bc7a0b38ea7d3c833 100644
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ObserverTest.php
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ObserverTest.php
@@ -31,119 +31,200 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
/**
* @var Observer
*/
- protected $model;
+ protected $observer;
/**
- * @var \Magento\CatalogInventory\Model\Stock\ItemRegistry|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Catalog\Model\Indexer\Product\Price\Processor|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $stockItemRegistry;
+ protected $priceIndexer;
/**
- * @var \Magento\CatalogInventory\Model\Stock\Status|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Model\Indexer\Stock\Processor|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $stockStatus;
+ protected $stockIndexerProcessor;
/**
- * @var \Magento\CatalogInventory\Model\StockFactory|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Model\Resource\Stock|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $stockFactory;
+ protected $resourceStock;
/**
- * @var \Magento\Framework\Event\Observer|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $eventObserver;
+ protected $stockRegistry;
/**
- * @var \Magento\Framework\Event|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Api\StockManagementInterface|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $event;
+ protected $stockManagement;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockIndexInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockIndex;
+
+ /**
+ * @var \Magento\CatalogInventory\Helper\Stock|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockHelper;
/**
- * @var \Magento\CatalogInventory\Helper\Data |\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface|\PHPUnit_Framework_MockObject_MockObject
*/
- private $catalogInventoryData;
+ protected $stockConfiguration;
/**
- * @var \Magento\CatalogInventory\Model\Stock | \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Api\StockItemRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
*/
- private $stock;
+ protected $stockItemRepository;
/**
- * @var \Magento\CatalogInventory\Model\Indexer\Stock\Processor | \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Api\Data\StockItemInterfaceBuilder|\PHPUnit_Framework_MockObject_MockObject
*/
- private $stockIndexProcessor;
+ protected $stockItemBuilder;
/**
- * @var \Magento\Catalog\Model\Indexer\Product\Price\Processor | \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Api\Data\StockInterface|\PHPUnit_Framework_MockObject_MockObject
*/
- private $priceIndexer;
+ protected $stock;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockItemInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItem;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockStatusInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockStatus;
+
+ /**
+ * @var \Magento\Framework\Event|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $event;
+
+ /**
+ * @var \Magento\Framework\Event\Observer|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $eventObserver;
protected function setUp()
{
- $this->stockItemRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\ItemRegistry')
- ->disableOriginalConstructor()
- ->getMock();
- $this->stockStatus = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Status')
- ->disableOriginalConstructor()
- ->getMock();
- $this->stockFactory = $this->getMockBuilder('Magento\CatalogInventory\Model\StockFactory')
- ->setMethods(['create'])
- ->getMock();
-
- $this->catalogInventoryData = $this->getMock('Magento\CatalogInventory\Helper\Data', [], [], '', false);
- $this->stock = $this->getMock('Magento\CatalogInventory\Model\Stock', [], [], '', false);
- $this->stockIndexProcessor = $this->getMock(
- '\Magento\Catalog\Model\Indexer\Product\Stock\Processor',
+ $this->priceIndexer = $this->getMock(
+ '\Magento\Catalog\Model\Indexer\Product\Price\Processor',
+ ['reindexList', 'reindexRow'],
[],
+ '',
+ false
+ );
+ $this->stockIndexerProcessor = $this->getMock(
+ '\Magento\CatalogInventory\Model\Indexer\Stock\Processor',
+ ['reindexList'],
[],
'',
false
);
- $this->priceIndexer = $this->getMock(
- '\Magento\Catalog\Model\Indexer\Product\Price\Processor',
+ $this->resourceStock = $this->getMock(
+ '\Magento\CatalogInventory\Model\Resource\Stock',
+ ['updateSetOutOfStock', 'updateSetInStock', 'updateLowStockDate', '__wakeup'],
[],
+ '',
+ false
+ );
+ $this->stockRegistry = $this->getMockForAbstractClass(
+ '\Magento\CatalogInventory\Api\StockRegistryInterface',
+ ['getStockItem'],
+ '',
+ false
+ );
+ $this->stockRegistry->expects($this->any())->method('getStockItem')->willReturn($this->stockItem);
+ $this->stockManagement = $this->getMockForAbstractClass(
+ '\Magento\CatalogInventory\Api\StockManagementInterface',
+ [
+ 'updateProductStockStatus',
+ 'registerProductsSale',
+ 'revertProductsSale',
+ 'backItemQty',
+ 'updateProductStockStatus'
+ ],
+ '',
+ false
+ );
+ $this->stockIndex = $this->getMockForAbstractClass(
+ '\Magento\CatalogInventory\Api\StockIndexInterface',
+ ['rebuild'],
+ '',
+ false
+ );
+
+ $this->stockHelper = $this->getMock(
+ '\Magento\CatalogInventory\Helper\Stock',
+ [
+ 'assignStatusToProduct',
+ 'addStockStatusToProducts',
+ 'addStockStatusToSelect'
+ ],
+ [],
+ '',
+ false
+ );
+ $this->stockConfiguration = $this->getMockForAbstractClass(
+ '\Magento\CatalogInventory\Api\StockConfigurationInterface',
+ [
+ 'isAutoReturnEnabled',
+ 'isDisplayProductStockStatus'
+ ],
+ '',
+ false
+ );
+ $this->stockItemRepository = $this->getMockForAbstractClass(
+ '\Magento\CatalogInventory\Api\StockItemRepositoryInterface',
+ ['save'],
+ '',
+ false
+ );
+ $this->stockItemBuilder = $this->getMock(
+ '\Magento\CatalogInventory\Api\Data\StockItemInterfaceBuilder',
+ ['mergeDataObjectWithArray'],
[],
'',
false
);
$objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->model = $objectManagerHelper->getObject(
+ $this->observer = $objectManagerHelper->getObject(
'Magento\CatalogInventory\Model\Observer',
[
- 'stockItemRegistry' => $this->stockItemRegistry,
- 'stockStatus' => $this->stockStatus,
- 'stockFactory' => $this->stockFactory
+ 'priceIndexer' => $this->priceIndexer,
+ 'stockIndexerProcessor' => $this->stockIndexerProcessor,
+ 'resourceStock' => $this->resourceStock,
+ 'stockRegistry' => $this->stockRegistry,
+ 'stockManagement' => $this->stockManagement,
+ 'stockIndex' => $this->stockIndex,
+ 'stockHelper' => $this->stockHelper,
+ 'stockConfiguration' => $this->stockConfiguration,
+ 'stockItemRepository' => $this->stockItemRepository,
+ 'stockItemBuilder' => $this->stockItemBuilder
]
);
$this->event = $this->getMockBuilder('Magento\Framework\Event')
->disableOriginalConstructor()
- ->setMethods(['getProduct', 'getCollection', 'getCreditmemo'])
+ ->setMethods(['getProduct', 'getCollection', 'getCreditmemo', 'getQuote', 'getWebsite'])
->getMock();
-
$this->eventObserver = $this->getMockBuilder('Magento\Framework\Event\Observer')
->disableOriginalConstructor()
->setMethods(['getEvent'])
->getMock();
- $this->eventObserver->expects($this->atLeastOnce())
- ->method('getEvent')
- ->will($this->returnValue($this->event));
}
public function testAddInventoryData()
{
- $productId = 4;
- $stockId = 6;
$stockStatus = true;
-
$product = $this->getMockBuilder('Magento\Catalog\Model\Product')
->disableOriginalConstructor()
- ->setMethods(['getId', 'getStockStatus', '__wakeup'])
+ ->setMethods(['__wakeup', 'getStockStatus'])
->getMock();
- $product->expects($this->once())
- ->method('getId')
- ->will($this->returnValue($productId));
$product->expects($this->once())
->method('getStockStatus')
->will($this->returnValue($stockStatus));
@@ -151,121 +232,238 @@ class ObserverTest extends \PHPUnit_Framework_TestCase
$this->event->expects($this->once())
->method('getProduct')
->will($this->returnValue($product));
-
- $stockItem = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->disableOriginalConstructor()
- ->getMock();
- $stockItem->expects($this->once())
- ->method('getStockId')
- ->will($this->returnValue($stockId));
-
- $this->stockItemRegistry->expects($this->once())
- ->method('retrieve')
- ->with($productId)
- ->will($this->returnValue($stockItem));
-
- $this->stockStatus->expects($this->once())
- ->method('assignProduct')
- ->with($product, $stockId, $stockStatus)
+ $this->stockHelper->expects($this->once())
+ ->method('assignStatusToProduct')
+ ->with($product, $stockStatus)
->will($this->returnSelf());
- $this->assertEquals($this->model, $this->model->addInventoryData($this->eventObserver));
+ $this->eventObserver->expects($this->atLeastOnce())
+ ->method('getEvent')
+ ->will($this->returnValue($this->event));
+ $this->assertEquals($this->observer, $this->observer->addInventoryData($this->eventObserver));
}
public function testAddStockStatusToCollection()
{
- $requireStockItems = false;
-
$productCollection = $this->getMockBuilder('Magento\Catalog\Model\Resource\Product\Collection')
->disableOriginalConstructor()
- ->setMethods(['hasFlag'])
->getMock();
$this->event->expects($this->once())
->method('getCollection')
->will($this->returnValue($productCollection));
-
- $productCollection->expects($this->once())
- ->method('hasFlag')
- ->with('require_stock_items')
- ->will($this->returnValue($requireStockItems));
-
- $this->stockStatus->expects($this->once())
+ $this->stockHelper->expects($this->once())
->method('addStockStatusToProducts')
->with($productCollection)
->will($this->returnSelf());
- $this->assertEquals($this->model, $this->model->addStockStatusToCollection($this->eventObserver));
+ $this->eventObserver->expects($this->atLeastOnce())
+ ->method('getEvent')
+ ->will($this->returnValue($this->event));
+ $this->assertEquals($this->observer, $this->observer->addStockStatusToCollection($this->eventObserver));
}
- public function testAddStockStatusToCollectionRequireStockItems()
+ public function testAddInventoryDataToCollection()
{
- $requireStockItems = true;
-
$productCollection = $this->getMockBuilder('Magento\Catalog\Model\Resource\Product\Collection')
->disableOriginalConstructor()
- ->setMethods(['hasFlag'])
->getMock();
$this->event->expects($this->once())
->method('getCollection')
->will($this->returnValue($productCollection));
+ $this->stockHelper->expects($this->once())
+ ->method('addStockStatusToProducts')
+ ->with($productCollection)
+ ->will($this->returnSelf());
- $productCollection->expects($this->once())
- ->method('hasFlag')
- ->with('require_stock_items')
- ->will($this->returnValue($requireStockItems));
+ $this->eventObserver->expects($this->atLeastOnce())
+ ->method('getEvent')
+ ->will($this->returnValue($this->event));
+ $this->assertEquals($this->observer, $this->observer->addStockStatusToCollection($this->eventObserver));
+ }
- $stock = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock')
- ->disableOriginalConstructor()
- ->getMock();
+ public function testSaveInventoryData()
+ {
+ $productId = 4;
+ $websiteId = 5;
+ $stockData = null;
+ $websitesChanged = true;
+ $statusChanged = true;
+
+ $product = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getStockData', 'getIsChangedWebsites', 'dataHasChangedFor', 'getId', 'getStore', '__wakeup'],
+ [],
+ '',
+ false
+ );
+ $product->expects($this->once())->method('getStockData')->will($this->returnValue($stockData));
+ if ($stockData === null) {
+ $product->expects($this->any())->method('getIsChangedWebsites')->will($this->returnValue($websitesChanged));
+ $product->expects($this->any())->method('dataHasChangedFor')->will($this->returnValue($statusChanged));
+ if ($websitesChanged || $statusChanged) {
+ $product->expects($this->once())->method('getId')->will($this->returnValue($productId));
+ $store = $this->getMock(
+ 'Magento\Store\Model\Store',
+ ['getWebsiteId', '__wakeup'],
+ [],
+ '',
+ false
+ );
+ $store->expects($this->once())->method('getWebsiteId')->will($this->returnValue($websiteId));
+ $product->expects($this->once())->method('getStore')->will($this->returnValue($store));
+ $this->stockIndex->expects($this->once())->method('rebuild')->will(
+ $this->returnValue(true)
+ );
+ }
+ } else {
+ $stockItem = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockItem',
+ ['__wakeup'],
+ '',
+ false
+ );
+ $this->stockRegistry->expects($this->once())
+ ->method('getStockItem')
+ ->with($productId, $websiteId)
+ ->will($this->returnValue($stockItem));
+ }
- $this->stockFactory->expects($this->once())
- ->method('create')
- ->will($this->returnValue($stock));
+ $this->event->expects($this->once())
+ ->method('getProduct')
+ ->will($this->returnValue($product));
- $stock->expects($this->once())
- ->method('addItemsToProducts')
- ->with($productCollection)
- ->will($this->returnSelf());
+ $this->eventObserver->expects($this->atLeastOnce())
+ ->method('getEvent')
+ ->will($this->returnValue($this->event));
+ $this->assertEquals($this->observer, $this->observer->saveInventoryData($this->eventObserver));
+ }
- $this->assertEquals($this->model, $this->model->addStockStatusToCollection($this->eventObserver));
+ public function testCheckoutAllSubmitAfter()
+ {
+ $inventoryProcessed = false;
+ $websiteId = 0;
+ $itemsToRegister = [];
+ $itemsToReindex = [];
+
+ $quote = $this->getMock(
+ '\Magento\Sales\Model\Quote',
+ ['getInventoryProcessed', 'setInventoryProcessed', 'getAllItems', 'getStore', '__wakeup'],
+ [],
+ '',
+ false
+ );
+ $quote->expects($this->atLeastOnce())
+ ->method('getInventoryProcessed', 'setInventoryProcessed', 'getStore')
+ ->will($this->returnValue($inventoryProcessed));
+ $store = $this->getMock(
+ 'Magento\Store\Model\Store',
+ ['getWebsiteId', '__wakeup'],
+ [],
+ '',
+ false
+ );
+ $store->expects($this->once())->method('getWebsiteId')->will($this->returnValue($websiteId));
+ $quote->expects($this->once())->method('getStore')->will($this->returnValue($store));
+ $quote->expects($this->any())->method('getAllItems')->will($this->returnValue($itemsToRegister));
+
+ $this->stockManagement->expects($this->once())->method('registerProductsSale')->will(
+ $this->returnValue($itemsToReindex)
+ );
+
+ $this->event->expects($this->atLeastOnce())
+ ->method('getQuote')
+ ->will($this->returnValue($quote));
+
+ $this->eventObserver->expects($this->atLeastOnce())
+ ->method('getEvent')
+ ->will($this->returnValue($this->event));
+ $this->assertEquals($this->observer, $this->observer->checkoutAllSubmitAfter($this->eventObserver));
}
- public function refundOrderInventory()
+ public function testRefundOrderInventory()
{
+ $websiteId = 0;
$ids = ['1', '14'];
$items = [];
+ $isAutoReturnEnabled = true;
+
+ $itemsToUpdate = [];
foreach ($ids as $id) {
- $items[] = $this->getCreditMemoItem($id);
+ $item = $this->getCreditMemoItem($id);
+ $items[] = $item;
+ $itemsToUpdate[$item->getProductId()] = $item->getQty();
}
$creditMemo = $this->getMock('Magento\Sales\Model\Order\Creditmemo', [], [], '', false);
$creditMemo->expects($this->once())
->method('getAllItems')
->will($this->returnValue($items));
+ $store = $this->getMock(
+ 'Magento\Store\Model\Store',
+ ['getWebsiteId', '__wakeup'],
+ [],
+ '',
+ false
+ );
+ $store->expects($this->once())->method('getWebsiteId')->will($this->returnValue($websiteId));
+ $creditMemo->expects($this->once())->method('getStore')->will($this->returnValue($store));
- $this->event->expects($this->once())
- ->method('getCreditmemo')
- ->will($this->returnValue($creditMemo));
-
- $this->catalogInventoryData->expects($this->once())
+ $this->stockConfiguration->expects($this->any())
->method('isAutoReturnEnabled')
- ->will($this->returnValue(true));
+ ->will($this->returnValue($isAutoReturnEnabled));
- $this->stock->expects($this->once())
+ $this->stockManagement->expects($this->once())
->method('revertProductsSale')
- ->with($items);
- $this->stockIndexProcessor->expects($this->once())
- ->method('reidexList')
+ ->with($itemsToUpdate, $websiteId);
+ $this->stockIndexerProcessor->expects($this->once())
+ ->method('reindexList')
+ ->with($ids);
+ $this->priceIndexer->expects($this->once())
+ ->method('reindexList')
->with($ids);
- $this->model->refundOrderInventory($this->eventObserver);
+ $this->event->expects($this->once())
+ ->method('getCreditmemo')
+ ->will($this->returnValue($creditMemo));
+ $this->eventObserver->expects($this->atLeastOnce())
+ ->method('getEvent')
+ ->will($this->returnValue($this->event));
+ $this->observer->refundOrderInventory($this->eventObserver);
+ }
+
+ public function testUpdateItemsStockUponConfigChange()
+ {
+ $websiteId = 1;
+ $this->resourceStock->expects($this->once())->method('updateSetOutOfStock')->willReturn(null);
+ $this->resourceStock->expects($this->once())->method('updateSetInStock')->willReturn(null);
+ $this->resourceStock->expects($this->once())->method('updateLowStockDate')->willReturn(null);
+
+ $this->event->expects($this->once())
+ ->method('getWebsite')
+ ->will($this->returnValue($websiteId));
+ $this->eventObserver->expects($this->atLeastOnce())
+ ->method('getEvent')
+ ->will($this->returnValue($this->event));
+ $this->observer->updateItemsStockUponConfigChange($this->eventObserver);
}
private function getCreditMemoItem($productId)
{
- $item = $this->getMock('Magento\Sales\Model\Order\Creditmemo\Item', [], [], '', false);
- $item->expects($this->once())
- ->method('getProductId')
- ->will($this->returnValue($productId));
+ $parentItemId = false;
+ $backToStock = true;
+ $qty = 1;
+ $item = $this->getMock(
+ 'Magento\Sales\Model\Order\Creditmemo\Item',
+ ['getProductId', 'getOrderItem', 'getBackToStock', 'getQty', '__wakeup'],
+ [],
+ '',
+ false
+ );
+ $orderItem = $this->getMock('Magento\Sales\Model\Order\Item', ['getParentItemId', '__wakeup'], [], '', false);
+ $orderItem->expects($this->any())->method('getParentItemId')->willReturn($parentItemId);
+ $item->expects($this->any())->method('getOrderItem')->willReturn($orderItem);
+ $item->expects($this->any())->method('getProductId')->will($this->returnValue($productId));
+ $item->expects($this->any())->method('getBackToStock')->willReturn($backToStock);
+ $item->expects($this->any())->method('getQty')->willReturn($qty);
return $item;
}
}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Plugin/LayerTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Plugin/LayerTest.php
index 73778835ea4517200ec6e6fd1eec9988c5600fbb..32a1a0a28c94074558125d1bac0ca4426319c9ff 100644
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Plugin/LayerTest.php
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Plugin/LayerTest.php
@@ -36,15 +36,15 @@ class LayerTest extends \PHPUnit_Framework_TestCase
protected $_scopeConfigMock;
/**
- * @var \Magento\CatalogInventory\Model\Stock\Status|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Helper\Stock|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $_stockStatusMock;
+ protected $_stockHelperMock;
public function setUp()
{
$this->_scopeConfigMock = $this->getMock('\Magento\Framework\App\Config\ScopeConfigInterface');
- $this->_stockStatusMock = $this->getMock(
- '\Magento\CatalogInventory\Model\Stock\Status',
+ $this->_stockHelperMock = $this->getMock(
+ '\Magento\CatalogInventory\Helper\Stock',
array(),
array(),
'',
@@ -52,7 +52,7 @@ class LayerTest extends \PHPUnit_Framework_TestCase
);
$this->_model = new \Magento\CatalogInventory\Model\Plugin\Layer(
- $this->_stockStatusMock,
+ $this->_stockHelperMock,
$this->_scopeConfigMock
);
}
@@ -71,6 +71,7 @@ class LayerTest extends \PHPUnit_Framework_TestCase
)->will(
$this->returnValue(true)
);
+ /** @var \Magento\Catalog\Model\Resource\Product\Collection $collectionMock */
$collectionMock = $this->getMock(
'\Magento\Catalog\Model\Resource\Product\Collection',
array(),
@@ -78,7 +79,8 @@ class LayerTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $this->_stockStatusMock->expects($this->never())->method('addIsInStockFilterToCollection');
+ $this->_stockHelperMock->expects($this->never())->method('addIsInStockFilterToCollection');
+ /** @var \Magento\Catalog\Model\Layer $subjectMock */
$subjectMock = $this->getMock('\Magento\Catalog\Model\Layer', array(), array(), '', false);
$this->_model->beforePrepareProductCollection($subjectMock, $collectionMock);
}
@@ -106,7 +108,7 @@ class LayerTest extends \PHPUnit_Framework_TestCase
false
);
- $this->_stockStatusMock->expects(
+ $this->_stockHelperMock->expects(
$this->once()
)->method(
'addIsInStockFilterToCollection'
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Product/CopyConstructor/CatalogInventoryTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Product/CopyConstructor/CatalogInventoryTest.php
index 89707d8beb7d3941cffb94e1dd755adb8fde1719..bec4d09f821ffad624864ac6f16b402336c6873e 100644
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Product/CopyConstructor/CatalogInventoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Product/CopyConstructor/CatalogInventoryTest.php
@@ -41,7 +41,7 @@ class CatalogInventoryTest extends \PHPUnit_Framework_TestCase
protected $duplicateMock;
/**
- * @var \Magento\CatalogInventory\Service\V1\Data\StockItem|\PHPUnit_Framework_MockObject_MockObject
+ * @var \PHPUnit_Framework_MockObject_MockObject
*/
protected $stockItemDoMock;
@@ -51,19 +51,28 @@ class CatalogInventoryTest extends \PHPUnit_Framework_TestCase
protected $objectManager;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $stockItemServiceMock;
+ protected $stockRegistry;
protected function setUp()
{
$this->productMock = $this->getMock(
'\Magento\Catalog\Model\Product',
- array('__wakeup'),
+ array('__wakeup', 'getStore'),
+ array(),
+ '',
+ false
+ );
+ $store = $this->getMock(
+ '\Magento\Store\Model\Store',
+ array('getWebsiteId', '__wakeup'),
array(),
'',
false
);
+ $store->expects($this->any())->method('getWebsiteId')->willReturn(0);
+ $this->productMock->expects($this->any())->method('getStore')->willReturn($store);
$this->duplicateMock = $this->getMock(
'\Magento\Catalog\Model\Product',
@@ -73,32 +82,26 @@ class CatalogInventoryTest extends \PHPUnit_Framework_TestCase
false
);
- $this->stockItemDoMock = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\Data\StockItem',
+ $this->stockItemDoMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockItemInterface',
[
- 'getStockId',
- 'isUseConfigEnableQtyInc',
- 'isEnableQtyIncrements',
- 'isUseConfigQtyIncrements',
+ 'getId',
+ 'getUseConfigEnableQtyInc',
+ 'getEnableQtyIncrements',
+ 'gerUseConfigQtyIncrements',
'getQtyIncrements'
- ],
- [],
- '',
- false
+ ]
);
- $this->stockItemServiceMock = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
- ['getStockItem'],
- [],
- '',
- false
+ $this->stockRegistry = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockRegistryInterface',
+ ['getStockItem']
);
$this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->model = $this->objectManager->getObject(
'Magento\CatalogInventory\Model\Product\CopyConstructor\CatalogInventory',
- ['stockItemService' => $this->stockItemServiceMock]
+ ['stockRegistry' => $this->stockRegistry]
);
}
@@ -113,7 +116,7 @@ class CatalogInventoryTest extends \PHPUnit_Framework_TestCase
);
$this->stockItemDoMock->expects($this->any())->method('getStockId')->will($this->returnValue(false));
- $this->stockItemServiceMock->expects($this->once())
+ $this->stockRegistry->expects($this->once())
->method('getStockItem')
->will($this->returnValue($this->stockItemDoMock));
@@ -134,20 +137,19 @@ class CatalogInventoryTest extends \PHPUnit_Framework_TestCase
'use_config_qty_increments' => 'use_config_qty_increments',
'qty_increments' => 'qty_increments'
);
- $this->stockItemServiceMock->expects($this->once())
+ $this->stockRegistry->expects($this->once())
->method('getStockItem')
->will($this->returnValue($this->stockItemDoMock));
- $this->stockItemDoMock->expects($this->any())->method('getStockId')->will($this->returnValue(50));
-
+ $this->stockItemDoMock->expects($this->any())->method('getId')->will($this->returnValue(50));
$this->stockItemDoMock->expects($this->any())
- ->method('isUseConfigEnableQtyInc')
+ ->method('getUseConfigEnableQtyInc')
->will($this->returnValue('use_config_enable_qty_inc'));
$this->stockItemDoMock->expects($this->any())
- ->method('isEnableQtyIncrements')
+ ->method('getEnableQtyIncrements')
->will($this->returnValue('enable_qty_increments'));
$this->stockItemDoMock->expects($this->any())
- ->method('isUseConfigQtyIncrements')
+ ->method('getUseConfigQtyIncrements')
->will($this->returnValue('use_config_qty_increments'));
$this->stockItemDoMock->expects($this->any())
->method('getQtyIncrements')
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/OptionTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/OptionTest.php
index 149a5d8aba7014923df53db33acbd019a4b71c06..eb4d872e7068004e63c90a152a43793de6beb27e 100644
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/OptionTest.php
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/OptionTest.php
@@ -43,7 +43,7 @@ class OptionTest extends \PHPUnit_Framework_TestCase
/**
* @var \PHPUnit_Framework_MockObject_MockObject
*/
- protected $quoteMock;
+ protected $quoteItemMock;
/**
* @var \PHPUnit_Framework_MockObject_MockObject
@@ -61,15 +61,30 @@ class OptionTest extends \PHPUnit_Framework_TestCase
protected $resultMock;
/**
- * @var \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $stockItemRegistryMock;
+ protected $stockRegistry;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockStateInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockState;
/**
* @var \Magento\TestFramework\Helper\ObjectManager
*/
protected $objectManager;
+ /**
+ * @var int
+ */
+ protected $productId = 111;
+
+ /**
+ * @var int
+ */
+ protected $websiteId = 111;
+
protected function setUp()
{
$optionMethods = array(
@@ -85,29 +100,51 @@ class OptionTest extends \PHPUnit_Framework_TestCase
$this->optionMock = $this->getMock(
'Magento\Sales\Model\Quote\Item\Option',
$optionMethods,
- array(),
+ [],
'',
false
);
- $methods = array('getQtyToAdd', '__wakeup', 'getId', 'updateQtyOption', 'setData', 'getQuoteId');
- $this->quoteMock = $this->getMock('Magento\Sales\Model\Quote\Item', $methods, array(), '', false);
+
+ $store = $this->getMock(
+ '\Magento\Store\Model\Store',
+ ['getWebsiteId', '__wakeup'],
+ [],
+ '',
+ false
+ );
+ $store->expects($this->any())->method('getWebsiteId')->willReturn($this->websiteId);
+
+ $methods = array('getQtyToAdd', '__wakeup', 'getId', 'updateQtyOption', 'setData', 'getQuoteId', 'getStore');
+ $this->quoteItemMock = $this->getMock('Magento\Sales\Model\Quote\Item', $methods, [], '', false);
+ $this->quoteItemMock->expects($this->any())->method('getStore')->willReturn($store);
+
$stockItemMethods = array(
'setIsChildItem',
'setSuppressCheckQtyIncrements',
- 'checkQuoteItemQty',
'__wakeup',
'unsIsChildItem',
- 'getId',
+ 'getId'
);
+
$this->stockItemMock = $this->getMock(
- 'Magento\CatalogInventory\Model\Stock\Item',
+ 'Magento\CatalogInventory\Api\Data\StockItem',
$stockItemMethods,
- array(),
+ [],
'',
false
);
- $productMethods = array('getId', '__wakeup');
+ $productMethods = array('getId', '__wakeup', 'getStore');
$this->productMock = $this->getMock('Magento\Catalog\Model\Product', $productMethods, array(), '', false);
+ $store = $this->getMock(
+ '\Magento\Store\Model\Store',
+ ['getWebsiteId', '__wakeup'],
+ array(),
+ '',
+ false
+ );
+ $store->expects($this->any())->method('getWebsiteId')->willReturn($this->websiteId);
+ $this->productMock->expects($this->any())->method('getStore')->willReturn($store);
+
$this->qtyItemListMock = $this->getMock(
'Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\QuoteItemQtyList',
array(),
@@ -123,14 +160,16 @@ class OptionTest extends \PHPUnit_Framework_TestCase
'getItemBackorders',
'__wakeup'
);
- $this->resultMock = $this->getMock('Magento\Framework\Object', $resultMethods, array(), '', false);
+ $this->resultMock = $this->getMock('Magento\Framework\Object', $resultMethods, [], '', false);
- $this->stockItemRegistryMock = $this->getMock(
- 'Magento\CatalogInventory\Model\Stock\ItemRegistry',
- ['retrieve', '__wakeup'],
- [],
- '',
- false
+ $this->stockRegistry = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockRegistryInterface',
+ ['getStockItem']
+ );
+
+ $this->stockState = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockStateInterface',
+ ['checkQuoteItemQty']
);
$this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
@@ -138,7 +177,8 @@ class OptionTest extends \PHPUnit_Framework_TestCase
'Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\Initializer\Option',
[
'quoteItemQtyList' => $this->qtyItemListMock,
- 'stockItemRegistry' => $this->stockItemRegistryMock,
+ 'stockRegistry' => $this->stockRegistry,
+ 'stockState' => $this->stockState
]
);
}
@@ -150,41 +190,39 @@ class OptionTest extends \PHPUnit_Framework_TestCase
$qty = 10;
$qtyToAdd = 20;
$this->optionMock->expects($this->once())->method('getValue')->will($this->returnValue($optionValue));
- $this->quoteMock->expects($this->exactly(2))->method('getQtyToAdd')->will($this->returnValue($qtyToAdd));
+ $this->quoteItemMock->expects($this->exactly(2))->method('getQtyToAdd')->will($this->returnValue($qtyToAdd));
$this->optionMock->expects($this->any())->method('getProduct')->will($this->returnValue($this->productMock));
$this->stockItemMock->expects($this->once())->method('setIsChildItem')->with(true);
$this->stockItemMock->expects($this->once())->method('setSuppressCheckQtyIncrements')->with(true);
$this->stockItemMock->expects($this->once())->method('getId')->will($this->returnValue(true));
- $this->stockItemRegistryMock
+ $this->stockRegistry
->expects($this->once())
- ->method('retrieve')
+ ->method('getStockItem')
->will($this->returnValue($this->stockItemMock));
- $this->productMock->expects($this->any())->method('getId')->will($this->returnValue('product_id'));
- $this->quoteMock->expects($this->any())->method('getId')->will($this->returnValue('quote_item_id'));
- $this->quoteMock->expects($this->once())->method('getQuoteId')->will($this->returnValue('quote_id'));
+ $this->productMock->expects($this->any())->method('getId')->will($this->returnValue($this->productId));
+ $this->quoteItemMock->expects($this->any())->method('getId')->will($this->returnValue('quote_item_id'));
+ $this->quoteItemMock->expects($this->once())->method('getQuoteId')->will($this->returnValue('quote_id'));
$this->qtyItemListMock->expects(
$this->once()
)->method(
'getQty'
)->with(
- 'product_id',
+ $this->productId,
'quote_item_id',
'quote_id',
$qtyToAdd * $optionValue
)->will(
$this->returnValue($qtyForCheck)
);
- $this->stockItemMock->expects(
- $this->once()
- )->method(
- 'checkQuoteItemQty'
- )->with(
+ $this->stockState->expects($this->once())->method('checkQuoteItemQty')->with(
+ $this->productId,
$qty * $optionValue,
$qtyForCheck,
- $optionValue
+ $optionValue,
+ $this->websiteId
)->will(
$this->returnValue($this->resultMock)
);
@@ -199,9 +237,9 @@ class OptionTest extends \PHPUnit_Framework_TestCase
$this->resultMock->expects($this->once())->method('getHasQtyOptionUpdate')->will($this->returnValue(true));
$this->optionMock->expects($this->once())->method('setHasQtyOptionUpdate')->with(true);
$this->resultMock->expects($this->exactly(2))->method('getOrigQty')->will($this->returnValue('orig_qty'));
- $this->quoteMock->expects($this->once())->method('updateQtyOption')->with($this->optionMock, 'orig_qty');
+ $this->quoteItemMock->expects($this->once())->method('updateQtyOption')->with($this->optionMock, 'orig_qty');
$this->optionMock->expects($this->once())->method('setValue')->with('orig_qty');
- $this->quoteMock->expects($this->once())->method('setData')->with('qty', $qty);
+ $this->quoteItemMock->expects($this->once())->method('setData')->with('qty', $qty);
$this->resultMock->expects($this->exactly(3))->method('getMessage')->will($this->returnValue('message'));
$this->optionMock->expects($this->once())->method('setMessage')->with('message');
$this->resultMock->expects(
@@ -214,7 +252,7 @@ class OptionTest extends \PHPUnit_Framework_TestCase
$this->optionMock->expects($this->once())->method('setBackorders')->with('backorders');
$this->stockItemMock->expects($this->once())->method('unsIsChildItem');
- $this->validator->initialize($this->optionMock, $this->quoteMock, $qty);
+ $this->validator->initialize($this->optionMock, $this->quoteItemMock, $qty);
}
public function testInitializeWhenResultNotDecimalGetBackordersMessageHasOptionQtyUpdate()
@@ -223,41 +261,39 @@ class OptionTest extends \PHPUnit_Framework_TestCase
$qtyForCheck = 50;
$qty = 10;
$this->optionMock->expects($this->once())->method('getValue')->will($this->returnValue($optionValue));
- $this->quoteMock->expects($this->once())->method('getQtyToAdd')->will($this->returnValue(false));
+ $this->quoteItemMock->expects($this->once())->method('getQtyToAdd')->will($this->returnValue(false));
$this->optionMock->expects($this->any())->method('getProduct')->will($this->returnValue($this->productMock));
$this->stockItemMock->expects($this->once())->method('setIsChildItem')->with(true);
$this->stockItemMock->expects($this->once())->method('setSuppressCheckQtyIncrements')->with(true);
$this->stockItemMock->expects($this->once())->method('getId')->will($this->returnValue(true));
- $this->stockItemRegistryMock
+ $this->stockRegistry
->expects($this->once())
- ->method('retrieve')
+ ->method('getStockItem')
->will($this->returnValue($this->stockItemMock));
- $this->productMock->expects($this->any())->method('getId')->will($this->returnValue('product_id'));
- $this->quoteMock->expects($this->any())->method('getId')->will($this->returnValue('quote_item_id'));
- $this->quoteMock->expects($this->once())->method('getQuoteId')->will($this->returnValue('quote_id'));
+ $this->productMock->expects($this->any())->method('getId')->will($this->returnValue($this->productId));
+ $this->quoteItemMock->expects($this->any())->method('getId')->will($this->returnValue('quote_item_id'));
+ $this->quoteItemMock->expects($this->once())->method('getQuoteId')->will($this->returnValue('quote_id'));
$this->qtyItemListMock->expects(
$this->once()
)->method(
'getQty'
)->with(
- 'product_id',
+ $this->productId,
'quote_item_id',
'quote_id',
$qty * $optionValue
)->will(
$this->returnValue($qtyForCheck)
);
- $this->stockItemMock->expects(
- $this->once()
- )->method(
- 'checkQuoteItemQty'
- )->with(
+ $this->stockState->expects($this->once())->method('checkQuoteItemQty')->with(
+ $this->productId,
$qty * $optionValue,
$qtyForCheck,
- $optionValue
+ $optionValue,
+ $this->websiteId
)->will(
$this->returnValue($this->resultMock)
);
@@ -270,7 +306,7 @@ class OptionTest extends \PHPUnit_Framework_TestCase
$this->optionMock->expects($this->never())->method('setBackorders');
$this->stockItemMock->expects($this->once())->method('unsIsChildItem');
- $this->validator->initialize($this->optionMock, $this->quoteMock, $qty);
+ $this->validator->initialize($this->optionMock, $this->quoteItemMock, $qty);
}
/**
@@ -282,16 +318,16 @@ class OptionTest extends \PHPUnit_Framework_TestCase
$optionValue = 5;
$qty = 10;
$this->optionMock->expects($this->once())->method('getValue')->will($this->returnValue($optionValue));
- $this->quoteMock->expects($this->once())->method('getQtyToAdd')->will($this->returnValue(false));
- $this->productMock->expects($this->any())->method('getId')->will($this->returnValue('product_id'));
+ $this->quoteItemMock->expects($this->once())->method('getQtyToAdd')->will($this->returnValue(false));
+ $this->productMock->expects($this->any())->method('getId')->will($this->returnValue($this->productId));
$this->optionMock->expects($this->any())->method('getProduct')->will($this->returnValue($this->productMock));
$this->stockItemMock->expects($this->once())->method('getId')->will($this->returnValue(false));
- $this->stockItemRegistryMock
+ $this->stockRegistry
->expects($this->once())
- ->method('retrieve')
+ ->method('getStockItem')
->will($this->returnValue($this->stockItemMock));
- $this->validator->initialize($this->optionMock, $this->quoteMock, $qty);
+ $this->validator->initialize($this->optionMock, $this->quoteItemMock, $qty);
}
}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItemTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItemTest.php
index 84d72152e0bb186ec169c005fe8716db62583a28..5a0a73b4f6fa4c2f96ba27adb8679d15408aa2a1 100644
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItemTest.php
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItemTest.php
@@ -23,122 +23,256 @@
*/
namespace Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\Initializer;
+use Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\QuoteItemQtyList;
+
class StockItemTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var StockItem
+ * @var \Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\Initializer\StockItem
*/
- protected $stockItem;
+ protected $model;
/**
- * @var \PHPUnit_Framework_MockObject_MockObject
+ * @var QuoteItemQtyList| \PHPUnit_Framework_MockObject_MockObject
*/
- protected $configMock;
+ protected $quoteItemQtyList;
/**
- * @var \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Catalog\Model\ProductTypes\ConfigInterface| \PHPUnit_Framework_MockObject_MockObject
*/
- protected $qtyProcessorMock;
+ protected $typeConfig;
/**
* @var \PHPUnit_Framework_MockObject_MockObject
*/
- protected $itemMock;
+ protected $stockStateMock;
- public function setUp()
+ protected function setUp()
{
- $this->configMock = $this->getMockBuilder('Magento\Catalog\Model\ProductTypes\Config')
+ $this->quoteItemQtyList = $this
+ ->getMockBuilder('Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\QuoteItemQtyList')
->disableOriginalConstructor()
->getMock();
- $this->qtyProcessorMock = $this->getMockBuilder(
- 'Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\Initializer\QtyProcessor'
- )
+
+ $this->typeConfig = $this
+ ->getMockBuilder('Magento\Catalog\Model\ProductTypes\ConfigInterface')
->disableOriginalConstructor()
->getMock();
- $this->stockItem = new StockItem($this->configMock, $this->qtyProcessorMock);
- $this->itemMock = $this->getMockBuilder('Magento\Sales\Model\Quote\Item')
+
+ $objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
+ $this->stockStateMock = $this->getMockBuilder('Magento\CatalogInventory\Api\StockStateInterface')
->disableOriginalConstructor()
- ->setMethods(['getParentItem', 'getProduct'])
->getMock();
+ $this->model = $objectManagerHelper->getObject(
+ 'Magento\CatalogInventory\Model\Quote\Item\QuantityValidator\Initializer\StockItem',
+ [
+ 'quoteItemQtyList' => $this->quoteItemQtyList,
+ 'typeConfig' => $this->typeConfig,
+ 'stockState' => $this->stockStateMock
+ ]
+ );
}
- public function testInitialize()
+ public function testInitializeWithSubitem()
{
- $qty = 1;
- $rowQty = 2;
- $qtyForCheck = 3;
+ $qty = 2;
+ $parentItemQty = 3;
+ $websiteId = 1;
- $stockItemMock = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
+ $stockItem = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
+ ->setMethods(
+ [
+ 'checkQuoteItemQty',
+ 'setProductName',
+ 'setIsChildItem',
+ 'hasIsChildItem',
+ 'unsIsChildItem',
+ '__wakeup'
+ ]
+ )
->disableOriginalConstructor()
- ->setMethods(['hasIsChildItem', 'checkQuoteItemQty', 'setProduct'])
->getMock();
- $productMock = $this->getMockBuilder('Magento\Catalog\Model\Product')
+ $quoteItem = $this->getMockBuilder('Magento\Sales\Model\Quote\Item')
+ ->setMethods(
+ [
+ 'getParentItem',
+ 'getProduct',
+ 'getId',
+ 'getQuoteId',
+ 'setIsQtyDecimal',
+ 'setData',
+ 'setUseOldQty',
+ 'setMessage',
+ 'setBackorders',
+ '__wakeup'
+ ]
+ )
->disableOriginalConstructor()
- ->setMethods(['getTypeInstance', 'getForceChildItemQtyChanges', 'getCustomOption', 'getName'])
->getMock();
-
- $customOptionMock = $this->getMockBuilder('Magneto\Framework\Object')
+ $parentItem = $this->getMockBuilder('Magento\Sales\Model\Quote\Item')
+ ->setMethods(['getQty', 'setIsQtyDecimal', 'getProduct', '__wakeup'])
+ ->disableOriginalConstructor()
+ ->getMock();
+ $product = $this->getMockBuilder('Magento\Catalog\Model\Product')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $parentProduct = $this->getMockBuilder('Magento\Catalog\Model\Product')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $productTypeInstance = $this->getMockBuilder('Magento\Catalog\Model\Product\Type\AbstractType')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $storeMock = $this->getMockBuilder('Magento\Store\Model\Store')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $storeMock->expects($this->any())
+ ->method('getWebsiteId')
+ ->willReturn($websiteId);
+ $productTypeCustomOption = $this->getMockBuilder('Magento\Catalog\Model\Product\Configuration\Item\Option')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $result = $this->getMockBuilder('Magento\Framework\Object')
+ ->setMethods(
+ [
+ 'getItemIsQtyDecimal',
+ 'getHasQtyOptionUpdate',
+ 'getOrigQty',
+ 'getItemUseOldQty',
+ 'getMessage',
+ 'getItemBackorders',
+ ]
+ )
->disableOriginalConstructor()
- ->setMethods(['getValue'])
->getMock();
- $productMock->expects($this->any())
+ $quoteItem->expects($this->any())->method('getParentItem')->will($this->returnValue($parentItem));
+ $parentItem->expects($this->once())->method('getQty')->will($this->returnValue($parentItemQty));
+ $quoteItem->expects($this->any())->method('getProduct')->will($this->returnValue($product));
+ $product->expects($this->any())->method('getId')->will($this->returnValue('product_id'));
+ $quoteItem->expects($this->once())->method('getId')->will($this->returnValue('quote_item_id'));
+ $quoteItem->expects($this->once())->method('getQuoteId')->will($this->returnValue('quote_id'));
+ $this->quoteItemQtyList->expects($this->any())
+ ->method('getQty')
+ ->with('product_id', 'quote_item_id', 'quote_id', 0)
+ ->will($this->returnValue('summary_qty'));
+ $this->stockStateMock->expects($this->once())
+ ->method('checkQuoteItemQty')
+ ->withAnyParameters()
+ ->will($this->returnValue($result));
+ $product->expects($this->once())
->method('getCustomOption')
->with('product_type')
- ->willReturn($customOptionMock);
- $productMock->expects($this->any())
- ->method('getName')
- ->willReturn('product_name');
- $productMock->expects($this->any())
+ ->will($this->returnValue($productTypeCustomOption));
+ $productTypeCustomOption->expects($this->once())
+ ->method('getValue')
+ ->will(($this->returnValue('option_value')));
+ $this->typeConfig->expects($this->once())
+ ->method('isProductSet')
+ ->with('option_value')
+ ->will($this->returnValue(true));
+ $product->expects($this->once())->method('getName')->will($this->returnValue('product_name'));
+ $product->expects($this->any())
+ ->method('getStore')
+ ->willReturn($storeMock);
+ $stockItem->expects($this->once())->method('setProductName')->with('product_name')->will($this->returnSelf());
+ $stockItem->expects($this->once())->method('setIsChildItem')->with(true)->will($this->returnSelf());
+ $stockItem->expects($this->once())->method('hasIsChildItem')->will($this->returnValue(true));
+ $stockItem->expects($this->once())->method('unsIsChildItem');
+ $result->expects($this->exactly(3))->method('getItemIsQtyDecimal')->will($this->returnValue(true));
+ $quoteItem->expects($this->once())->method('setIsQtyDecimal')->with(true)->will($this->returnSelf());
+ $parentItem->expects($this->once())->method('setIsQtyDecimal')->with(true)->will($this->returnSelf());
+ $parentItem->expects($this->any())->method('getProduct')->will($this->returnValue($parentProduct));
+ $result->expects($this->once())->method('getHasQtyOptionUpdate')->will($this->returnValue(true));
+ $parentProduct->expects($this->once())
->method('getTypeInstance')
- ->willReturn('product_name');
+ ->will($this->returnValue($productTypeInstance));
+ $productTypeInstance->expects($this->once())
+ ->method('getForceChildItemQtyChanges')
+ ->with($product)->will($this->returnValue(true));
+ $result->expects($this->once())->method('getOrigQty')->will($this->returnValue('orig_qty'));
+ $quoteItem->expects($this->once())->method('setData')->with('qty', 'orig_qty')->will($this->returnSelf());
+ $result->expects($this->exactly(2))->method('getItemUseOldQty')->will($this->returnValue('item'));
+ $quoteItem->expects($this->once())->method('setUseOldQty')->with('item')->will($this->returnSelf());
+ $result->expects($this->exactly(2))->method('getMessage')->will($this->returnValue('message'));
+ $quoteItem->expects($this->once())->method('setMessage')->with('message')->will($this->returnSelf());
+ $result->expects($this->exactly(2))->method('getItemBackorders')->will($this->returnValue('backorders'));
+ $quoteItem->expects($this->once())->method('setBackorders')->with('backorders')->will($this->returnSelf());
- $parentItemMock = $this->getMockBuilder('Magento\Sales\Model\Quote\Item')
- ->disableOriginalConstructor()
- ->getMock();
- $parentItemMock->expects($this->any())
- ->method('getProduct')
- ->willReturn($productMock);
-
- $itemMock = $this->getMockBuilder('Magento\Sales\Model\Quote\Item')
- ->disableOriginalConstructor()
- ->getMock();
- $itemMock->expects($this->any())
- ->method('getProduct')
- ->willReturn($productMock);
- $itemMock->expects($this->any())
- ->method('getParentItem')
- ->willReturn($parentItemMock);
- $this->qtyProcessorMock->expects($this->once())
- ->method('getRowQty')
- ->with($qty)
- ->willReturn($rowQty);
- $this->qtyProcessorMock->expects($this->once())
- ->method('getQtyForCheck')
- ->with($qty)
- ->willReturn($qtyForCheck);
+ $this->model->initialize($stockItem, $quoteItem, $qty);
+ }
- $this->configMock->expects($this->any())
- ->method('isProductSet')
- ->willReturn(true);
+ public function testInitializeWithoutSubitem()
+ {
+ $qty = 3;
+ $websiteId = 1;
+ $productId = 1;
- $stockItemMock->expects($this->any())
- ->method('hasIsChildItem')
- ->willReturn(true);
- $resultMock = $this->getMockBuilder('Magento\Framework\Object')
+ $stockItem = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
+ ->setMethods(['checkQuoteItemQty', 'setProductName', 'setIsChildItem', 'hasIsChildItem', '__wakeup'])
+ ->disableOriginalConstructor()
+ ->getMock();
+ $storeMock = $this->getMockBuilder('Magento\Store\Model\Store')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $storeMock->expects($this->any())
+ ->method('getWebsiteId')
+ ->willReturn($websiteId);
+ $quoteItem = $this->getMockBuilder('Magento\Sales\Model\Quote\Item')
+ ->setMethods(['getProduct', 'getParentItem', 'getQtyToAdd', 'getId', 'getQuoteId', '__wakeup'])
->disableOriginalConstructor()
- ->setMethods(['getItemIsQtyDecimal', 'getHasQtyOptionUpdate'])
->getMock();
- $resultMock->expects($this->any())
- ->method('getItemIsQtyDecimal')
- ->willReturn(true);
- $stockItemMock->expects($this->any())
+ $product = $this->getMockBuilder('Magento\Catalog\Model\Product')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $productTypeCustomOption = $this->getMockBuilder('Magento\Catalog\Model\Product\Configuration\Item\Option')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $result = $this->getMockBuilder('Magento\Framework\Object')
+ ->setMethods(
+ ['getItemIsQtyDecimal', 'getHasQtyOptionUpdate', 'getItemUseOldQty', 'getMessage', 'getItemBackorders']
+ )
+ ->disableOriginalConstructor()
+ ->getMock();
+ $product->expects($this->any())
+ ->method('getStore')
+ ->willReturn($storeMock);
+ $product->expects($this->any())
+ ->method('getId')
+ ->willReturn($productId);
+ $quoteItem->expects($this->once())->method('getParentItem')->will($this->returnValue(false));
+ $quoteItem->expects($this->once())->method('getQtyToAdd')->will($this->returnValue(false));
+ $quoteItem->expects($this->any())->method('getProduct')->will($this->returnValue($product));
+ $quoteItem->expects($this->once())->method('getId')->will($this->returnValue('quote_item_id'));
+ $quoteItem->expects($this->once())->method('getQuoteId')->will($this->returnValue('quote_id'));
+ $this->quoteItemQtyList->expects($this->any())
+ ->method('getQty')
+ ->with($productId, 'quote_item_id', 'quote_id', $qty)
+ ->will($this->returnValue('summary_qty'));
+ $this->stockStateMock->expects($this->once())
->method('checkQuoteItemQty')
- ->willReturn($resultMock);
+ ->withAnyParameters()
+ ->will($this->returnValue($result));
+ $product->expects($this->once())
+ ->method('getCustomOption')
+ ->with('product_type')
+ ->will($this->returnValue($productTypeCustomOption));
+ $productTypeCustomOption->expects($this->once())
+ ->method('getValue')
+ ->will($this->returnValue('option_value'));
+ $this->typeConfig->expects($this->once())
+ ->method('isProductSet')
+ ->with('option_value')
+ ->will($this->returnValue(true));
+ $product->expects($this->once())->method('getName')->will($this->returnValue('product_name'));
+ $stockItem->expects($this->once())->method('setProductName')->with('product_name')->will($this->returnSelf());
+ $stockItem->expects($this->once())->method('setIsChildItem')->with(true)->will($this->returnSelf());
+ $stockItem->expects($this->once())->method('hasIsChildItem')->will($this->returnValue(false));
+ $result->expects($this->once())->method('getItemIsQtyDecimal')->will($this->returnValue(null));
+ $result->expects($this->once())->method('getHasQtyOptionUpdate')->will($this->returnValue(false));
+ $result->expects($this->once())->method('getItemUseOldQty')->will($this->returnValue(null));
+ $result->expects($this->once())->method('getMessage')->will($this->returnValue(null));
+ $result->expects($this->once())->method('getItemBackorders')->will($this->returnValue(null));
- $this->assertInstanceOf(
- 'Magento\Framework\Object',
- $this->stockItem->initialize($stockItemMock, $itemMock, $qty)
- );
+ $this->model->initialize($stockItem, $quoteItem, $qty);
}
}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Resource/Stock/Status/CollectionTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Resource/Stock/Status/CollectionTest.php
deleted file mode 100644
index 176bb0cc7eb57dc29c7e32161999e75a106ed761..0000000000000000000000000000000000000000
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Resource/Stock/Status/CollectionTest.php
+++ /dev/null
@@ -1,103 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-
-namespace Magento\CatalogInventory\Model\Resource\Stock\Status;
-
-/**
- * Test for \Magento\CatalogInventory\Model\Resource\Stock\Status\Collection
- */
-class CollectionTest extends \PHPUnit_Framework_TestCase
-{
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject
- */
- protected $resource;
-
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject
- */
- protected $connection;
-
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject
- */
- protected $select;
-
- /**
- * @var \Magento\CatalogInventory\Model\Resource\Stock\Status\Collection
- */
- protected $model;
-
- protected function setUp()
- {
- $this->select = $this->getMock('Magento\Framework\DB\Select', [], [], '', false);
- $this->connection = $this->getMock('Magento\Framework\DB\Adapter\Pdo\Mysql', [], [], '', false);
- $this->connection->expects($this->atLeastOnce())->method('select')->will($this->returnValue($this->select));
- $this->connection->expects($this->atLeastOnce())->method('quoteIdentifier')->will($this->returnArgument(0));
- $this->resource = $this->getMock('Magento\CatalogInventory\Model\Resource\Stock\Status', [], [], '', false);
- $this->resource->expects($this->any())->method('getReadConnection')
- ->will($this->returnValue($this->connection));
-
- $objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->model = $objectManagerHelper->getObject(
- 'Magento\CatalogInventory\Model\Resource\Stock\Status\Collection',
- [
- 'resource' => $this->resource,
- ]
- );
- }
-
- /**
- * @covers \Magento\CatalogInventory\Model\Resource\Stock\Status\Collection::__construct
- * @covers \Magento\CatalogInventory\Model\Resource\Stock\Status\Collection::_construct
- * @covers \Magento\CatalogInventory\Model\Resource\Stock\Status\Collection::addWebsiteFilter
- */
- public function testAddingWebsiteFilter()
- {
- $website = $this->getMock('Magento\Store\Model\Website', ['getWebsiteId', '__wakeup'], [], '', false);
- $website->expects($this->atLeastOnce())->method('getWebsiteId')->will($this->returnValue(1));
- $this->connection->expects($this->atLeastOnce())->method('prepareSqlCondition')->with('website_id', 1)
- ->will($this->returnValue('condition_string'));
- $this->select->expects($this->atLeastOnce())->method('where')
- ->with('condition_string', $this->anything(), $this->anything());
- $this->model->addWebsiteFilter($website);
- }
-
- /**
- * @covers \Magento\CatalogInventory\Model\Resource\Stock\Status\Collection::__construct
- * @covers \Magento\CatalogInventory\Model\Resource\Stock\Status\Collection::_construct
- * @covers \Magento\CatalogInventory\Model\Resource\Stock\Status\Collection::addQtyFilter
- */
- public function testAddingQtyFilter()
- {
- $qty = 3;
- $this->connection->expects($this->atLeastOnce())
- ->method('prepareSqlCondition')
- ->with('main_table.qty', ['lteq' => $qty])
- ->will($this->returnValue('condition_string'));
- $this->select->expects($this->atLeastOnce())->method('where')
- ->with('condition_string', $this->anything(), $this->anything());
- $this->model->addQtyFilter($qty);
- }
-}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Spi/StockRegistryProviderTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Spi/StockRegistryProviderTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..7326db5f7813226957750d8edb4aaf367a161dfd
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Spi/StockRegistryProviderTest.php
@@ -0,0 +1,312 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Spi;
+
+use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper;
+
+/**
+ * Class StockRegistryProviderTest
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
+class StockRegistryProviderTest extends \PHPUnit_Framework_TestCase
+{
+ /** @var ObjectManagerHelper */
+ protected $objectManagerHelper;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Spi\StockRegistryProviderInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistryProvider;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stock;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockItemInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItem;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockStatusInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockStatus;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockStatusInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockStatusFactory;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockItemInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItemFactory;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockFactory;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRepository;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockItemRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItemRepository;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockStatusRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockStatusRepository;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockCriteriaInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockCriteriaFactory;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockItemCriteriaInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItemCriteriaFactory;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockStatusCriteriaInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockStatusCriteriaFactory;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockCriteriaInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockCriteria;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockItemCriteriaInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItemCriteria;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\StockStatusCriteriaInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockStatusCriteria;
+
+ protected $productId = 111;
+ protected $productSku = 'simple';
+ protected $websiteId = 111;
+
+ protected function setUp()
+ {
+ $this->objectManagerHelper = new ObjectManagerHelper($this);
+
+ $this->stock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockInterface',
+ ['__wakeup', 'getId'],
+ '',
+ false
+ );
+ $this->stockItem = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockItemInterface',
+ ['__wakeup', 'getId'],
+ '',
+ false
+ );
+ $this->stockStatus = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockStatusInterface',
+ ['__wakeup', 'getProductId'],
+ '',
+ false
+ );
+
+
+ $this->stockFactory = $this->getMock(
+ '\Magento\CatalogInventory\Api\Data\StockInterfaceFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+ $this->stockFactory->expects($this->any())->method('create')->willReturn($this->stock);
+
+ $this->stockItemFactory = $this->getMock(
+ '\Magento\CatalogInventory\Api\Data\StockItemInterfaceFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+ $this->stockItemFactory->expects($this->any())->method('create')->willReturn($this->stockItem);
+
+ $this->stockStatusFactory = $this->getMock(
+ '\Magento\CatalogInventory\Api\Data\StockStatusInterfaceFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+ $this->stockStatusFactory->expects($this->any())->method('create')->willReturn($this->stockStatus);
+
+ $this->stockRepository = $this->getMockBuilder('\Magento\CatalogInventory\Api\StockRepositoryInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+
+ $this->stockItemRepository = $this->getMockBuilder('\Magento\CatalogInventory\Api\StockItemRepositoryInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+
+
+ $this->stockStatusRepository = $this->getMockBuilder(
+ '\Magento\CatalogInventory\Api\StockStatusRepositoryInterface'
+ )
+ ->disableOriginalConstructor()
+ ->getMock();
+
+ $this->stockCriteriaFactory = $this->getMock(
+ 'Magento\CatalogInventory\Api\StockCriteriaInterfaceFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+ $this->stockCriteria = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockCriteriaInterface',
+ ['setWebsiteFilter'],
+ '',
+ false
+ );
+
+ $this->stockItemCriteriaFactory = $this->getMock(
+ 'Magento\CatalogInventory\Api\StockItemCriteriaInterfaceFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+ $this->stockItemCriteria = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockItemCriteriaInterface',
+ ['setProductsFilter', 'setWebsiteFilter'],
+ '',
+ false
+ );
+
+ $this->stockStatusCriteriaFactory = $this->getMock(
+ 'Magento\CatalogInventory\Api\StockStatusCriteriaInterfaceFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+ $this->stockStatusCriteria = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockStatusCriteriaInterface',
+ ['setProductsFilter', 'setWebsiteFilter'],
+ '',
+ false
+ );
+
+ $this->stockRegistryProvider = $this->objectManagerHelper->getObject(
+ '\Magento\CatalogInventory\Model\StockRegistryProvider',
+ [
+ 'stockRepository' => $this->stockRepository,
+ 'stockFactory' => $this->stockFactory,
+ 'stockItemRepository' => $this->stockItemRepository,
+ 'stockItemFactory' => $this->stockItemFactory,
+ 'stockStatusRepository' => $this->stockStatusRepository,
+ 'stockStatusFactory' => $this->stockStatusFactory,
+
+ 'stockCriteriaFactory' => $this->stockCriteriaFactory,
+ 'stockItemCriteriaFactory' => $this->stockItemCriteriaFactory,
+ 'stockStatusCriteriaFactory' => $this->stockStatusCriteriaFactory
+ ]
+ );
+ }
+
+ protected function tearDown()
+ {
+ $this->stockRegistryProvider = null;
+ }
+
+ public function testGetStock()
+ {
+ $this->stockCriteriaFactory->expects($this->once())->method('create')->willReturn($this->stockCriteria);
+ $this->stockCriteria->expects($this->once())->method('setWebsiteFilter')->willReturn(null);
+ $stockCollection = $this->getMock(
+ '\Magento\CatalogInventory\Model\Resource\Stock\Collection',
+ ['getFirstItem', '__wakeup', 'getItems'],
+ [],
+ '',
+ false
+ );
+ $stockCollection->expects($this->once())->method('getItems')->willReturn([$this->stock]);
+ $this->stockRepository->expects($this->once())->method('getList')->willReturn($stockCollection);
+ $this->stock->expects($this->once())->method('getId')->willReturn(true);
+ $this->assertEquals($this->stock, $this->stockRegistryProvider->getStock($this->websiteId));
+ }
+
+ public function testGetStockItem()
+ {
+ $this->stockItemCriteriaFactory->expects($this->once())->method('create')->willReturn($this->stockItemCriteria);
+ $this->stockItemCriteria->expects($this->once())->method('setWebsiteFilter')->willReturn(null);
+ $this->stockItemCriteria->expects($this->once())->method('setProductsFilter')->willReturn(null);
+ $stockItemCollection = $this->getMock(
+ '\Magento\CatalogInventory\Model\Resource\Stock\Item\Collection',
+ ['getFirstItem', '__wakeup', 'getItems'],
+ [],
+ '',
+ false
+ );
+ $stockItemCollection->expects($this->once())->method('getItems')->willReturn([$this->stockItem]);
+ $this->stockItemRepository->expects($this->once())->method('getList')->willReturn($stockItemCollection);
+ $this->stockItem->expects($this->once())->method('getId')->willReturn(true);
+ $this->assertEquals(
+ $this->stockItem,
+ $this->stockRegistryProvider->getStockItem($this->productId, $this->websiteId)
+ );
+ }
+
+ public function testGetStockStatus()
+ {
+ $this->stockStatusCriteriaFactory->expects($this->once())
+ ->method('create')
+ ->willReturn($this->stockStatusCriteria);
+ $this->stockStatusCriteria->expects($this->once())->method('setWebsiteFilter')->willReturn(null);
+ $this->stockStatusCriteria->expects($this->once())->method('setProductsFilter')->willReturn(null);
+ $stockStatusCollection = $this->getMock(
+ '\Magento\CatalogInventory\Model\Resource\Stock\Status\Collection',
+ ['getFirstItem', '__wakeup', 'getItems'],
+ [],
+ '',
+ false
+ );
+ $stockStatusCollection->expects($this->once())->method('getItems')->willReturn([$this->stockStatus]);
+ $this->stockStatusRepository->expects($this->once())->method('getList')->willReturn($stockStatusCollection);
+ $this->stockStatus->expects($this->once())->method('getProductId')->willReturn($this->productId);
+ $this->assertEquals(
+ $this->stockStatus,
+ $this->stockRegistryProvider->getStockStatus($this->productId, $this->websiteId)
+ );
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Spi/StockStateProviderTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Spi/StockStateProviderTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..f8242549d3fca53e6a1011e334cc6c921cca7489
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Spi/StockStateProviderTest.php
@@ -0,0 +1,421 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Spi;
+
+use Magento\CatalogInventory\Api\Data\StockItemInterface;
+use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper;
+
+/**
+ * Class StockStateProviderTest
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
+class StockStateProviderTest extends \PHPUnit_Framework_TestCase
+{
+ /** @var ObjectManagerHelper */
+ protected $objectManagerHelper;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Spi\StockStateProviderInterface
+ */
+ protected $stockStateProvider;
+
+ /**
+ * @var \Magento\CatalogInventory\Api\Data\StockItemInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItem;
+
+ /**
+ * @var \Magento\Catalog\Model\ProductFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $productFactory;
+
+ /**
+ * @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $product;
+
+ /**
+ * @var \Magento\Framework\Math\Division|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $mathDivision;
+
+ /**
+ * @var \Magento\Framework\Locale\FormatInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $localeFormat;
+
+ /**
+ * @var \Magento\Framework\Object\Factory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $objectFactory;
+
+ /**
+ * @var \Magento\Framework\Object|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $object;
+
+ /**
+ * @var float
+ */
+ protected $qty = 50.5;
+
+ /**
+ * @var int
+ */
+ protected $qtyDivision = 0;
+
+ /**
+ * @var bool
+ */
+ protected $qtyCheckApplicable = true;
+
+ /**
+ * @var array
+ */
+ protected $stockItemMethods = [
+ 'getId',
+ 'getProductId',
+ 'getWebsiteId',
+ 'getStockId',
+ 'getQty',
+ 'getIsInStock',
+ 'getIsQtyDecimal',
+ 'getShowDefaultNotificationMessage',
+ 'getUseConfigMinQty',
+ 'getMinQty',
+ 'getUseConfigMinSaleQty',
+ 'getMinSaleQty',
+ 'getUseConfigMaxSaleQty',
+ 'getMaxSaleQty',
+ 'getUseConfigBackorders',
+ 'getBackorders',
+ 'getUseConfigNotifyStockQty',
+ 'getNotifyStockQty',
+ 'getUseConfigQtyIncrements',
+ 'getQtyIncrements',
+ 'getUseConfigEnableQtyInc',
+ 'getEnableQtyIncrements',
+ 'getUseConfigManageStock',
+ 'getManageStock',
+ 'getLowStockDate',
+ 'getIsDecimalDivided',
+ 'getStockStatusChangedAuto',
+ 'hasStockQty',
+ 'setStockQty',
+ 'getData',
+ 'getSuppressCheckQtyIncrements',
+ 'getIsChildItem',
+ 'getIsSaleable',
+ 'getOrderedItems',
+ 'setOrderedItems',
+ 'getProductName'
+ ];
+
+ protected function setUp()
+ {
+ $this->objectManagerHelper = new ObjectManagerHelper($this);
+
+ $this->mathDivision = $this->getMock(
+ '\Magento\Framework\Math\Division',
+ ['getExactDivision'],
+ [],
+ '',
+ false
+ );
+ $this->mathDivision->expects($this->any())
+ ->method('getExactDivision')
+ ->willReturn($this->qtyDivision);
+
+ $this->localeFormat = $this->getMockForAbstractClass(
+ '\Magento\Framework\Locale\FormatInterface',
+ ['getNumber']
+ );
+ $this->localeFormat->expects($this->any())
+ ->method('getNumber')
+ ->willReturn($this->qty);
+
+ $this->object = $this->objectManagerHelper->getObject('Magento\Framework\Object');
+ $this->objectFactory = $this->getMock('\Magento\Framework\Object\Factory', ['create'], [], '', false);
+ $this->objectFactory->expects($this->any())->method('create')->willReturn($this->object);
+
+ $this->product = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['load', 'isComposite', '__wakeup', 'isSaleable'],
+ [],
+ '',
+ false
+ );
+ $this->productFactory = $this->getMock('Magento\Catalog\Model\ProductFactory', ['create'], [], '', false);
+ $this->productFactory->expects($this->any())->method('create')->willReturn($this->product);
+
+ $this->stockStateProvider = $this->objectManagerHelper->getObject(
+ 'Magento\CatalogInventory\Model\StockStateProvider',
+ [
+ 'mathDivision' => $this->mathDivision,
+ 'localeFormat' => $this->localeFormat,
+ 'objectFactory' => $this->objectFactory,
+ 'productFactory' => $this->productFactory,
+ 'qtyCheckApplicable' => $this->qtyCheckApplicable
+ ]
+ );
+ }
+
+ protected function tearDown()
+ {
+ $this->stockStateProvider = null;
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param mixed $expectedResult
+ * @dataProvider verifyStockDataProvider
+ */
+ public function testVerifyStock(StockItemInterface $stockItem, $expectedResult)
+ {
+ $this->assertEquals(
+ $expectedResult,
+ $this->stockStateProvider->verifyStock($stockItem)
+ );
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param mixed $expectedResult
+ * @dataProvider verifyNotificationDataProvider
+ */
+ public function testVerifyNotification(StockItemInterface $stockItem, $expectedResult)
+ {
+ $this->assertEquals(
+ $expectedResult,
+ $this->stockStateProvider->verifyNotification($stockItem)
+ );
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param mixed $expectedResult
+ * @dataProvider checkQtyDataProvider
+ */
+ public function testCheckQty(StockItemInterface $stockItem, $expectedResult)
+ {
+ $this->assertEquals(
+ $expectedResult,
+ $this->stockStateProvider->checkQty($stockItem, $this->qty)
+ );
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param mixed $expectedResult
+ * @dataProvider suggestQtyDataProvider
+ */
+ public function testSuggestQty(StockItemInterface $stockItem, $expectedResult)
+ {
+ $this->assertEquals(
+ $expectedResult,
+ $this->stockStateProvider->suggestQty($stockItem, $this->qty)
+ );
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param mixed $expectedResult
+ * @dataProvider getStockQtyDataProvider
+ */
+ public function testGetStockQty(StockItemInterface $stockItem, $expectedResult)
+ {
+ $this->assertEquals(
+ $expectedResult,
+ $this->stockStateProvider->getStockQty($stockItem)
+ );
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param mixed $expectedResult
+ * @dataProvider checkQtyIncrementsDataProvider
+ */
+ public function testCheckQtyIncrements(StockItemInterface $stockItem, $expectedResult)
+ {
+ $this->assertEquals(
+ $expectedResult,
+ $this->stockStateProvider->checkQtyIncrements($stockItem, $this->qty)->getHasError()
+ );
+ }
+
+ /**
+ * @param StockItemInterface $stockItem
+ * @param mixed $expectedResult
+ * @dataProvider checkQuoteItemQtyDataProvider
+ */
+ public function testCheckQuoteItemQty(StockItemInterface $stockItem, $expectedResult)
+ {
+ $this->assertEquals(
+ $expectedResult,
+ $this->stockStateProvider->checkQuoteItemQty(
+ $stockItem,
+ $this->qty,
+ $this->qty,
+ $this->qty
+ )->getHasError()
+ );
+ }
+
+ public function verifyStockDataProvider()
+ {
+ return $this->prepareDataForMethod('verifyStock');
+ }
+
+ public function verifyNotificationDataProvider()
+ {
+ return $this->prepareDataForMethod('verifyNotification');
+ }
+
+ public function checkQtyDataProvider()
+ {
+ return $this->prepareDataForMethod('checkQty');
+ }
+
+ public function suggestQtyDataProvider()
+ {
+ return $this->prepareDataForMethod('suggestQty');
+ }
+
+ public function getStockQtyDataProvider()
+ {
+ return $this->prepareDataForMethod('getStockQty');
+ }
+
+ public function checkQtyIncrementsDataProvider()
+ {
+ return $this->prepareDataForMethod('checkQtyIncrements');
+ }
+
+ public function checkQuoteItemQtyDataProvider()
+ {
+ return $this->prepareDataForMethod('checkQuoteItemQty');
+ }
+
+ protected function prepareDataForMethod($methodName)
+ {
+ $variations = [];
+ foreach ($this->getVariations() as $variation) {
+ $stockItem = $this->getMockBuilder('Magento\CatalogInventory\Api\Data\StockItemInterface')
+ ->disableOriginalConstructor()
+ ->setMethods($this->stockItemMethods)
+ ->getMockForAbstractClass();
+ $stockItem->expects($this->any())->method('getSuppressCheckQtyIncrements')->willReturn(
+ $variation['values']['_suppress_check_qty_increments_']
+ );
+ $stockItem->expects($this->any())->method('getIsSaleable')->willReturn(
+ $variation['values']['_is_saleable_']
+ );
+ $stockItem->expects($this->any())->method('getOrderedItems')->willReturn(
+ $variation['values']['_ordered_items_']
+ );
+
+ $stockItem->expects($this->any())->method('getProductName')->willReturn($variation['values']['_product_']);
+ $stockItem->expects($this->any())->method('getIsChildItem')->willReturn(false);
+ $stockItem->expects($this->any())->method('hasStockQty')->willReturn(false);
+ $stockItem->expects($this->any())->method('setStockQty')->willReturnSelf();
+ $stockItem->expects($this->any())->method('setOrderedItems')->willReturnSelf();
+ $stockItem->expects($this->any())->method('getData')
+ ->with('stock_qty')
+ ->willReturn($variation['values']['_stock_qty_']);
+
+ foreach ($this->stockItemMethods as $method) {
+ $value = isset($variation['values'][$method]) ? $variation['values'][$method] : null;
+ $stockItem->expects($this->any())->method($method)->willReturn($value);
+ }
+ $expectedResult = isset($variation['results'][$methodName]) ? $variation['results'][$methodName] : null;
+ $variations[] = [
+ 'stockItem' => $stockItem,
+ 'expectedResult' => $expectedResult
+ ];
+ }
+ return $variations;
+ }
+
+ protected function getVariations()
+ {
+ $stockQty = 100;
+ return [
+ [
+ 'values' => [
+ 'getIsInStock' => true,
+ 'getQty' => $stockQty,
+ 'getMinQty' => 0,
+ 'getMinSaleQty' => 0,
+ 'getMaxSaleQty' => 99,
+ 'getNotifyStockQty' => 10,
+ 'getManageStock' => true,
+ 'getBackorders' => 1,
+ 'getQtyIncrements' => 3,
+ '_stock_qty_' => $stockQty,
+ '_suppress_check_qty_increments_' => false,
+ '_is_saleable_' => true,
+ '_ordered_items_' => 0,
+ '_product_' => 'Test product Name'
+ ],
+ 'results' => [
+ 'verifyStock' => true,
+ 'verifyNotification' => false,
+ 'checkQty' => true,
+ 'suggestQty' => 51,
+ 'getStockQty' => $stockQty,
+ 'checkQtyIncrements' => false,
+ 'checkQuoteItemQty' => false
+ ]
+ ],
+ [
+ 'values' => [
+ 'getIsInStock' => true,
+ 'getQty' => $stockQty,
+ 'getMinQty' => 60,
+ 'getMinSaleQty' => 0,
+ 'getMaxSaleQty' => 99,
+ 'getNotifyStockQty' => 101,
+ 'getManageStock' => true,
+ 'getBackorders' => 3,
+ 'getQtyIncrements' => 1,
+ '_stock_qty_' => $stockQty,
+ '_suppress_check_qty_increments_' => false,
+ '_is_saleable_' => true,
+ '_ordered_items_' => 0,
+ '_product_' => 'Test product Name'
+ ],
+ 'results' => [
+ 'verifyStock' => true,
+ 'verifyNotification' => true,
+ 'checkQty' => false,
+ 'suggestQty' => 50.5,
+ 'getStockQty' => $stockQty,
+ 'checkQtyIncrements' => false,
+ 'checkQuoteItemQty' => true
+ ]
+ ]
+ ];
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Stock/ItemRegistryTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Stock/ItemRegistryTest.php
deleted file mode 100644
index 08bb5d51ff5ba889702d6f20cc6ecb70e6ff1fd7..0000000000000000000000000000000000000000
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Stock/ItemRegistryTest.php
+++ /dev/null
@@ -1,121 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Model\Stock;
-
-use Magento\CatalogInventory\Model\Stock\Item;
-
-/**
- * Class ItemRegistryTest
- *
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
- */
-class ItemRegistryTest extends \PHPUnit_Framework_TestCase
-{
- /**
- * @var ItemRegistry
- */
- protected $model;
-
- /** @var Item|\PHPUnit_Framework_MockObject_MockObject */
-
- protected $stockItemRegistry;
-
- /** @var \Magento\CatalogInventory\Model\Stock\ItemFactory|\PHPUnit_Framework_MockObject_MockObject */
- protected $stockItemFactory;
-
- /** @var \Magento\CatalogInventory\Model\Resource\Stock\Item| \PHPUnit_Framework_MockObject_MockObject */
- protected $stockItemResource;
-
- protected function setUp()
- {
- $this->stockItemFactory = $this
- ->getMockBuilder('Magento\CatalogInventory\Model\Stock\ItemFactory')
- ->setMethods(['create'])
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->stockItemResource = $this
- ->getMockBuilder('Magento\CatalogInventory\Model\Resource\Stock\Item')
- ->disableOriginalConstructor()
- ->getMock();
-
- $objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
-
- $this->model = $objectManagerHelper->getObject(
- 'Magento\CatalogInventory\Model\Stock\ItemRegistry',
- [
- 'stockItemFactory' => $this->stockItemFactory,
- 'stockItemResource' => $this->stockItemResource
- ]
- );
- }
-
- public function testRetrieve()
- {
- $productId = 3;
- $times = 1;
-
- $stockItem = $this->buildStockItem($productId, $times);
-
- $this->assertEquals($stockItem, $this->model->retrieve($productId));
- $this->assertEquals($stockItem, $this->model->retrieve($productId));
- }
-
- public function testErase()
- {
- $productId = 3;
- $times = 2;
-
- $stockItem = $this->buildStockItem($productId, $times);
-
- $this->model->retrieve($productId);
- $this->assertEquals($this->model, $this->model->erase($productId));
- $this->assertEquals($stockItem, $this->model->retrieve($productId));
- }
-
- /**
- * @param $productId
- * @param $times
- * @return \PHPUnit_Framework_MockObject_MockObject|Item
- */
- private function buildStockItem($productId, $times)
- {
- $stockItem = $this->stockItemRegistry = $this
- ->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->stockItemFactory
- ->expects($this->exactly($times))
- ->method('create')
- ->will($this->returnValue($stockItem));
- $this->stockItemResource
- ->expects($this->exactly($times))
- ->method('loadByProductId')
- ->with($stockItem, $productId)
- ->will($this->returnSelf());
-
- return $stockItem;
- }
-}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Stock/ItemTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Stock/ItemTest.php
index 81bec55dad8076635b4eb9e5fb8edf0d9286bd92..5b8f73455c7325af075680ef4e6bb5e7d3327f42 100644
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Stock/ItemTest.php
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Stock/ItemTest.php
@@ -41,93 +41,97 @@ class ItemTest extends \PHPUnit_Framework_TestCase
protected $item;
/**
- * @var \Magento\CatalogInventory\Model\Resource\Stock\Item|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Model\Context|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $resource;
+ protected $context;
/**
- * @var \Magento\Framework\Event\Manager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Registry|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $eventManager;
+ protected $registry;
- /** @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject */
- protected $product;
+ /**
+ * @var \Magento\Customer\Model\Session|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $customerSession;
- /** @var \Magento\Framework\App\Config|\PHPUnit_Framework_MockObject_MockObject */
- protected $scopeConfig;
+ /**
+ * @var \Magento\Framework\StoreManagerInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $storeManager;
- /** @var \Magento\Customer\Model\Session|\PHPUnit_Framework_MockObject_MockObject */
- protected $customerSession;
+ /**
+ * @var \Magento\CatalogInventory\Api\StockConfigurationInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockConfiguration;
- /** @var \Magento\CatalogInventory\Helper\Minsaleqty|\PHPUnit_Framework_MockObject_MockObject */
- protected $catalogInventoryMinsaleqty;
+ /**
+ * @var \Magento\CatalogInventory\Api\StockItemRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItemRepository;
- /** @var \Magento\Framework\StoreManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
- protected $storeManager;
+ /**
+ * @var \Magento\CatalogInventory\Model\Resource\Stock\Item|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $resource;
- /** @var \Magento\CatalogInventory\Model\Stock\ItemRegistry|\PHPUnit_Framework_MockObject_MockObject */
- protected $stockItemRegistry;
+ /**
+ * @var \Magento\CatalogInventory\Model\Resource\Stock\Item\Collection|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $resourceCollection;
- /** @var \Magento\CatalogInventory\Service\V1\StockItemService|\PHPUnit_Framework_MockObject_MockObject */
- protected $stockItemService;
+ /**
+ * @var int
+ */
+ protected $storeId = 111;
protected function setUp()
{
- $this->resource = $this->getMock(
- 'Magento\CatalogInventory\Model\Resource\Stock\Item',
- [],
+ $this->context = $this->getMock(
+ '\Magento\Framework\Model\Context',
+ ['getEventDispatcher'],
[],
'',
false
);
- $this->eventManager = $this->getMock(
- 'Magento\Framework\Event\Manager',
- ['dispatch'],
+
+ $this->registry = $this->getMock(
+ '\Magento\Framework\Registry',
[],
- '',
- false
- );
- $context = $this->getMock(
- '\Magento\Framework\Model\Context',
- ['getEventDispatcher'],
[],
'',
false
);
+
$this->customerSession = $this->getMock('Magento\Customer\Model\Session', [], [], '', false);
- $context->expects($this->any())
- ->method('getEventDispatcher')
- ->will($this->returnValue($this->eventManager));
-
- $this->product = $this->getMock('Magento\Catalog\Model\Product', [], [], '', false);
- $productFactory = $this->getMock('Magento\Catalog\Model\ProductFactory', ['create'], [], '', false);
- $productFactory->expects($this->any())
- ->method('create')
- ->will($this->returnValue($this->product));
-
- $this->catalogInventoryMinsaleqty = $this->getMock(
- 'Magento\CatalogInventory\Helper\Minsaleqty',
+
+ $store = $this->getMock('Magento\Store\Model\Store', ['getId', '__wakeup'], [], '', false);
+ $store->expects($this->any())->method('getId')->willReturn($this->storeId);
+ $this->storeManager = $this->getMockForAbstractClass('Magento\Framework\StoreManagerInterface', ['getStore']);
+ $this->storeManager->expects($this->any())->method('getStore')->willReturn($store);
+
+ $this->stockConfiguration = $this->getMock(
+ '\Magento\CatalogInventory\Api\StockConfigurationInterface',
[],
[],
'',
false
);
- $this->scopeConfig = $this->getMockBuilder('Magento\Framework\App\Config')
- ->setMethods(['isSetFlag', 'getValue'])
- ->disableOriginalConstructor()
- ->getMock();
- $this->storeManager = $this->getMock('Magento\Framework\StoreManagerInterface', [], [], '', false);
-
- $this->stockItemRegistry = $this->getMock(
- '\Magento\CatalogInventory\Model\Stock\ItemRegistry',
- ['retrieve', '__wakeup'],
+
+ $this->stockItemRepository = $this->getMockForAbstractClass(
+ '\Magento\CatalogInventory\Api\StockItemRepositoryInterface'
+ );
+
+ $this->resource = $this->getMock(
+ 'Magento\CatalogInventory\Model\Resource\Stock\Item',
+ [],
[],
'',
false
);
- $this->stockItemService = $this->getMock(
- '\Magento\CatalogInventory\Service\V1\StockItemService',
+ $this->resourceCollection = $this->getMock(
+ 'Magento\CatalogInventory\Model\Resource\Stock\Item\Collection',
[],
[],
'',
@@ -135,18 +139,18 @@ class ItemTest extends \PHPUnit_Framework_TestCase
);
$this->objectManagerHelper = new ObjectManagerHelper($this);
+
$this->item = $this->objectManagerHelper->getObject(
'Magento\CatalogInventory\Model\Stock\Item',
[
- 'context' => $context,
+ 'context' => $this->context,
+ 'registry' => $this->registry,
'customerSession' => $this->customerSession,
- 'catalogInventoryMinsaleqty' => $this->catalogInventoryMinsaleqty,
- 'scopeConfig' => $this->scopeConfig,
'storeManager' => $this->storeManager,
- 'productFactory' => $productFactory,
+ 'stockConfiguration' => $this->stockConfiguration,
+ 'stockItemRepository' => $this->stockItemRepository,
'resource' => $this->resource,
- 'stockItemRegistry' => $this->stockItemRegistry,
- 'stockItemService' => $this->stockItemService
+ 'stockItemRegistry' => $this->resourceCollection
]
);
}
@@ -158,117 +162,12 @@ class ItemTest extends \PHPUnit_Framework_TestCase
public function testSave()
{
- $this->item->setData('key', 'value');
-
- $this->eventManager->expects($this->at(0))
- ->method('dispatch')
- ->with('model_save_before', ['object' => $this->item]);
- $this->eventManager->expects($this->at(1))
- ->method('dispatch')
- ->with('cataloginventory_stock_item_save_before', ['data_object' => $this->item, 'item' => $this->item]);
-
- $this->resource->expects($this->once())
- ->method('addCommitCallback')
- ->will($this->returnValue($this->resource));
- $this->stockItemService->expects($this->any())
- ->method('isQty')
- ->will($this->returnValue(true));
-
+ $this->stockItemRepository->expects($this->any())
+ ->method('save')
+ ->willReturn($this->item);
$this->assertEquals($this->item, $this->item->save());
}
- /**
- * @param array $productConfig
- * @param array $stockConfig
- * @param float $expectedQty
- * @dataProvider getStockQtyDataProvider
- */
- public function testGetStockQty($productConfig, $stockConfig, $expectedQty)
- {
- $productId = $productConfig['product_id'];
- $isComposite = $productConfig['is_composite'];
- $qty = $productConfig['qty'];
- $useConfigManageStock = $stockConfig['use_config_manage_stock'];
- $manageStock = $stockConfig['manage_stock'];
- $isInStock = $productConfig['is_in_stock'];
- $isSaleable = $productConfig['is_saleable'];
-
- $this->setDataArrayValue('product_id', $productId);
- $this->product->expects($this->once())
- ->method('load')
- ->with($this->equalTo($productId), $this->equalTo(null))
- ->will($this->returnSelf());
-
- $this->product->expects($this->once())
- ->method('isComposite')
- ->will($this->returnValue($isComposite));
-
- $this->setDataArrayValue('qty', $qty);
- $this->setDataArrayValue('is_in_stock', $isInStock);
-
- if ($qty > 0 || $manageStock || $isInStock) {
- $this->product->expects($this->any())
- ->method('isSaleable')
- ->will($this->returnValue($isSaleable));
-
- }
-
- if ($isComposite) {
- $this->prepareNotCompositeProductMock();
- }
-
- $this->initManageStock($useConfigManageStock, $manageStock);
- $this->assertSame($expectedQty, $this->item->getStockQty());
- }
-
- protected function prepareNotCompositeProductMock()
- {
- $productGroup = [
- [$this->getGroupProductMock(0), $this->getGroupProductMock(1), $this->getGroupProductMock(2)],
- [$this->getGroupProductMock(3), $this->getGroupProductMock(4)],
- ];
-
- $typeInstance = $this->getMock(
- 'Magento\Catalog\Model\Product\Type\Simple',
- ['getProductsToPurchaseByReqGroups'],
- [],
- '',
- false
- );
- $typeInstance->expects($this->once())
- ->method('getProductsToPurchaseByReqGroups')
- ->with($this->equalTo($this->product))
- ->will($this->returnValue($productGroup));
-
- $this->product->expects($this->once())
- ->method('getTypeInstance')
- ->will($this->returnValue($typeInstance));
- }
-
- /**
- * @param int $at
- * @return \PHPUnit_Framework_MockObject_MockObject
- */
- protected function getGroupProductMock($at)
- {
- $product = $this->getMock(
- 'Magento\Catalog\Model\Product',
- ['getStockQty', '__wakeup'],
- [],
- '',
- false
- );
- $product->expects($this->once())
- ->method('getStockQty')
- ->will($this->returnValue(2));
-
- $this->stockItemRegistry->expects($this->at($at))
- ->method('retrieve')
- ->will($this->returnValue($product));
-
- return $product;
- }
-
/**
* @param string $key
* @param string|float|int $value
@@ -282,79 +181,6 @@ class ItemTest extends \PHPUnit_Framework_TestCase
$property->setValue($this->item, $dataArray);
}
- /**
- * @param bool $useConfigManageStock
- * @param int $manageStock
- */
- protected function initManageStock($useConfigManageStock, $manageStock)
- {
- $this->setDataArrayValue('use_config_manage_stock', $useConfigManageStock);
- if ($useConfigManageStock) {
- $this->scopeConfig->expects($this->any())
- ->method('isSetFlag')
- ->with(
- $this->equalTo(Item::XML_PATH_MANAGE_STOCK),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
- ->will($this->returnValue($manageStock));
- } else {
- $this->setDataArrayValue('manage_stock', $manageStock);
- }
- }
-
- /**
- * @return array
- */
- public function getStockQtyDataProvider()
- {
- return [
- 'composite in stock' => [
- 'product config' => [
- 'product_id' => 1,
- 'is_composite' => false,
- 'qty' => 5.5,
- 'is_in_stock' => true,
- 'is_saleable' => true
- ],
- 'stock config' => ['use_config_manage_stock' => true, 'manage_stock' => true],
- 'expected qty' => 5.5
- ],
- 'composite not managed' => [
- 'product config' => [
- 'product_id' => 1,
- 'is_composite' => false,
- 'qty' => 2.5,
- 'is_in_stock' => true,
- 'is_saleable' => true
- ],
- 'stock config' => ['use_config_manage_stock' => false, 'manage_stock' => false],
- 'expected qty' => 0.
- ],
- 'not composite in stock' => [
- 'product config' => [
- 'product_id' => 1,
- 'is_composite' => true,
- 'qty' => 5.5,
- 'is_in_stock' => true,
- 'is_saleable' => true
- ],
- 'stock config' => ['use_config_manage_stock' => true, 'manage_stock' => true],
- 'expected qty' => 4.
- ],
- 'not composite not saleable' => [
- 'product config' => [
- 'product_id' => 1,
- 'is_composite' => true,
- 'qty' => 5.5,
- 'is_in_stock' => true,
- 'is_saleable' => false
- ],
- 'stock config' => ['use_config_manage_stock' => true, 'manage_stock' => true],
- 'expected qty' => 0.
- ],
- ];
- }
-
public function testSetProduct()
{
$product = $this->getMock(
@@ -389,9 +215,8 @@ class ItemTest extends \PHPUnit_Framework_TestCase
$this->assertSame(
[
'product_id' => 2,
- 'product_name' => 'Some Name',
- 'store_id' => 3,
'product_type_id' => 'simple',
+ 'product_name' => 'Some Name',
'product_status_changed' => 1,
'product_changed_websites' => false,
],
@@ -399,92 +224,6 @@ class ItemTest extends \PHPUnit_Framework_TestCase
);
}
- public function testSetProcessIndexEvents()
- {
- $property = new \ReflectionProperty($this->item, '_processIndexEvents');
- $property->setAccessible(true);
- $this->assertTrue($property->getValue($this->item));
- $this->assertSame($this->item, $this->item->setProcessIndexEvents(false));
- $this->assertFalse($property->getValue($this->item));
- $this->assertSame($this->item, $this->item->setProcessIndexEvents());
- $this->assertTrue($property->getValue($this->item));
- }
-
- /**
- * @param array $config
- * @param bool $expected
- * @dataProvider verifyNotificationDataProvider
- */
- public function testVerifyNotification($config, $expected)
- {
- $qty = $config['qty'];
- $defaultQty = $config['default_qty'];
- $useConfigNotifyStockQty = $config['use_config_notify_stock_qty'];
- $notifyStockQty = $config['notify_stock_qty'];
-
- $this->setDataArrayValue('qty', $defaultQty);
- $this->setDataArrayValue('use_config_notify_stock_qty', $useConfigNotifyStockQty);
-
- if ($useConfigNotifyStockQty) {
- $this->scopeConfig->expects($this->any())
- ->method('getValue')
- ->with(
- $this->equalTo(Item::XML_PATH_NOTIFY_STOCK_QTY),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
- ->will($this->returnValue($notifyStockQty));
- } else {
- $this->setDataArrayValue('notify_stock_qty', $notifyStockQty);
- }
-
- $this->assertSame($expected, $this->item->verifyNotification($qty));
- }
-
- /**
- * @return array
- */
- public function verifyNotificationDataProvider()
- {
- return [
- [
- [
- 'qty' => null,
- 'default_qty' => 2,
- 'use_config_notify_stock_qty' => true,
- 'notify_stock_qty' => 3,
- ],
- true
- ],
- [
- [
- 'qty' => null,
- 'default_qty' => 3,
- 'use_config_notify_stock_qty' => true,
- 'notify_stock_qty' => 3,
- ],
- false
- ],
- [
- [
- 'qty' => 3,
- 'default_qty' => 3,
- 'use_config_notify_stock_qty' => false,
- 'notify_stock_qty' => 3,
- ],
- false
- ],
- [
- [
- 'qty' => 2,
- 'default_qty' => 3,
- 'use_config_notify_stock_qty' => false,
- 'notify_stock_qty' => 3,
- ],
- true
- ],
- ];
- }
-
/**
* @param array $config
* @param float $expected
@@ -497,13 +236,9 @@ class ItemTest extends \PHPUnit_Framework_TestCase
$this->setDataArrayValue('use_config_max_sale_qty', $useConfigMaxSaleQty);
if ($useConfigMaxSaleQty) {
- $this->scopeConfig->expects($this->any())
- ->method('getValue')
- ->with(
- $this->equalTo(Item::XML_PATH_MAX_SALE_QTY),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
- ->will($this->returnValue($maxSaleQty));
+ $this->stockConfiguration->expects($this->any())
+ ->method('getMaxSaleQty')
+ ->willReturn($maxSaleQty);
} else {
$this->setDataArrayValue('max_sale_qty', $maxSaleQty);
}
@@ -542,7 +277,7 @@ class ItemTest extends \PHPUnit_Framework_TestCase
->method('getCustomerGroupId')
->will($this->returnValue($groupId));
- $property = new \ReflectionProperty($this->item, '_customerGroupId');
+ $property = new \ReflectionProperty($this->item, 'customerGroupId');
$property->setAccessible(true);
$this->assertNull($property->getValue($this->item));
@@ -570,26 +305,19 @@ class ItemTest extends \PHPUnit_Framework_TestCase
$useConfigMinSaleQty = $config['use_config_min_sale_qty'];
$minSaleQty = $config['min_sale_qty'];
- $property = new \ReflectionProperty($this->item, '_customerGroupId');
+ $property = new \ReflectionProperty($this->item, 'customerGroupId');
$property->setAccessible(true);
$property->setValue($this->item, $groupId);
- $property = new \ReflectionProperty($this->item, '_minSaleQtyCache');
- $property->setAccessible(true);
- $this->assertEmpty($property->getValue($this->item));
$this->setDataArrayValue('use_config_min_sale_qty', $useConfigMinSaleQty);
-
if ($useConfigMinSaleQty) {
- $this->catalogInventoryMinsaleqty->expects($this->once())
- ->method('getConfigValue')
- ->with($this->equalTo($groupId))
+ $this->stockConfiguration->expects($this->once())
+ ->method('getMinSaleQty')
+ ->with($this->storeId, $this->equalTo($groupId))
->will($this->returnValue($minSaleQty));
} else {
$this->setDataArrayValue('min_sale_qty', $minSaleQty);
}
-
- $this->assertSame($expected, $this->item->getMinSaleQty());
- // check lazy load
$this->assertSame($expected, $this->item->getMinSaleQty());
}
@@ -621,7 +349,7 @@ class ItemTest extends \PHPUnit_Framework_TestCase
'use_config_min_sale_qty' => false,
'min_sale_qty' => null,
],
- null
+ 0.0
],
];
}
@@ -635,12 +363,8 @@ class ItemTest extends \PHPUnit_Framework_TestCase
{
$this->setDataArrayValue('use_config_min_qty', $useConfigMinQty);
if ($useConfigMinQty) {
- $this->scopeConfig->expects($this->any())
- ->method('getValue')
- ->with(
- $this->equalTo(Item::XML_PATH_MIN_QTY),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
+ $this->stockConfiguration->expects($this->any())
+ ->method('getMinQty')
->will($this->returnValue($minQty));
} else {
$this->setDataArrayValue('min_qty', $minQty);
@@ -669,11 +393,9 @@ class ItemTest extends \PHPUnit_Framework_TestCase
public function testGetStoreId($storeId, $managerStoreId, $expected)
{
if ($storeId) {
- $this->setDataArrayValue('store_id', $storeId);
- } else {
- $storeManager = $this->getMock('Magento\Store\Model\Store', [], [], '', false);
- $storeManager->expects($this->once())->method('getId')->will($this->returnValue($managerStoreId));
- $this->storeManager->expects($this->once())->method('getStore')->will($this->returnValue($storeManager));
+ $property = new \ReflectionProperty($this->item, 'storeId');
+ $property->setAccessible(true);
+ $property->setValue($this->item, $storeId);
}
$this->assertSame($expected, $this->item->getStoreId());
}
@@ -684,99 +406,8 @@ class ItemTest extends \PHPUnit_Framework_TestCase
public function getStoreIdDataProvider()
{
return [
- [1, null, 1],
- [null, 2, 2],
+ [$this->storeId, 2, $this->storeId],
+ [0, 2, $this->storeId],
];
}
-
- public function testGetStockId()
- {
- $this->assertSame(1, $this->item->getStockId());
- }
-
- public function testProcessIsInStock()
- {
- $this->item->setData(
- [
- 'qty' => 100,
- 'is_in_stock' => \Magento\CatalogInventory\Model\Stock\Status::STATUS_IN_STOCK,
- 'manage_stock' => 1,
- 'use_config_manage_stock' => 0
- ]
- );
- $this->item->setData('qty', 0);
- $this->item->processIsInStock();
- $this->assertEquals(
- \Magento\CatalogInventory\Model\Stock\Status::STATUS_OUT_OF_STOCK,
- $this->item->getIsInStock()
- );
- }
-
- public function testAddQty()
- {
- $defaultQty = 5.5;
- $qty = 3.3;
-
- $this->setDataArrayValue('qty', $defaultQty);
- $this->setDataArrayValue('manage_stock', true);
-
- $this->scopeConfig->expects($this->once())
- ->method('isSetFlag')
- ->with(
- $this->equalTo(Item::XML_PATH_CAN_SUBTRACT),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
- ->will($this->returnValue(true));
-
- $this->item->addQty($qty);
- $this->assertEquals($defaultQty + $qty, $this->item->getQty());
- }
-
- public function testAddQtyWithManageStockFalse()
- {
- $qty = 1;
- $defaultQty = 3;
-
- $this->setDataArrayValue('qty', $defaultQty);
- $this->setDataArrayValue('manage_stock', false);
-
- $this->assertEquals($this->item, $this->item->addQty($qty));
- $this->assertEquals($defaultQty, $this->item->getQty());
- }
-
- public function testAddQtyWithCannotSubtractConfig()
- {
- $qty = 1;
- $defaultQty = 3;
-
- $this->setDataArrayValue('qty', $defaultQty);
- $this->setDataArrayValue('manage_stock', true);
- $this->scopeConfig->expects($this->once())
- ->method('isSetFlag')
- ->with(
- $this->equalTo(Item::XML_PATH_CAN_SUBTRACT),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
- ->will($this->returnValue(false));
-
- $this->assertEquals($this->item, $this->item->addQty($qty));
- $this->assertEquals($defaultQty, $this->item->getQty());
- }
-
- public function testSubtractQty()
- {
- $subtractQty = 3;
-
- $qty = 5;
-
- $this->setDataArrayValue('qty', $qty);
-
- $this->scopeConfig->expects($this->once())
- ->method('isSetFlag')
- ->with('cataloginventory/options/can_subtract', 'store')
- ->will($this->returnValue(true));
- $this->initManageStock(false, true);
- $this->item->subtractQty($subtractQty);
- $this->assertEquals($qty - $subtractQty, $this->item->getQty());
- }
}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Stock/StockItemRepositoryTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Stock/StockItemRepositoryTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..4bdb7967f51c5ee878cf1b88b650e0cfd6fe63c8
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Stock/StockItemRepositoryTest.php
@@ -0,0 +1,171 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\CatalogInventory\Model\Stock;
+
+/**
+ * Class StockItemRepositoryTest
+ */
+class StockItemRepositoryTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var StockItemRepository
+ */
+ protected $model;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockConfigurationMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $productMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockStateProviderMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItemResourceMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItemMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockItemCollectionMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $productFactoryMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $queryBuilderMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $mapperMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $localeDateMock;
+
+ /**
+ * @var \Magento\CatalogInventory\Model\Indexer\Stock\Processor|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $indexProcessorMock;
+
+ protected function setUp()
+ {
+ $this->stockConfigurationMock = $this->getMockBuilder(
+ 'Magento\CatalogInventory\Api\StockConfigurationInterface'
+ )
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->stockStateProviderMock = $this->getMockBuilder(
+ 'Magento\CatalogInventory\Model\Spi\StockStateProviderInterface'
+ )
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->stockItemResourceMock = $this->getMockBuilder('Magento\CatalogInventory\Model\Resource\Stock\Item')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->stockItemMock = $this->getMockBuilder('Magento\CatalogInventory\Api\Data\StockItemInterfaceFactory')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->stockItemCollectionMock = $this->getMockBuilder(
+ 'Magento\CatalogInventory\Api\Data\StockItemCollectionInterfaceFactory'
+ )
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->productFactoryMock = $this->getMockBuilder('Magento\Catalog\Model\ProductFactory')
+ ->disableOriginalConstructor()
+ ->setMethods(['load', 'create'])
+ ->getMock();
+ $this->productMock = $this->getMockBuilder('Magento\Catalog\Model\Product')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->productFactoryMock->expects($this->any())
+ ->method('create')
+ ->willReturn($this->productMock);
+
+ $this->queryBuilderMock = $this->getMockBuilder('Magento\Framework\DB\QueryBuilderFactory')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->mapperMock = $this->getMockBuilder('Magento\Framework\DB\MapperFactory')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->localeDateMock = $this->getMockBuilder('Magento\Framework\Stdlib\DateTime\TimezoneInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->indexProcessorMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Indexer\Stock\Processor',
+ ['reindexRow'],
+ [],
+ '',
+ false
+ );
+
+ $this->model = new StockItemRepository(
+ $this->stockConfigurationMock,
+ $this->stockStateProviderMock,
+ $this->stockItemResourceMock,
+ $this->stockItemMock,
+ $this->stockItemCollectionMock,
+ $this->productFactoryMock,
+ $this->queryBuilderMock,
+ $this->mapperMock,
+ $this->localeDateMock,
+ $this->indexProcessorMock
+ );
+ }
+
+ public function testSave()
+ {
+ $params = [];
+
+ $stockItemMock = $this->getMockBuilder('Magento\CatalogInventory\Api\Data\StockItemInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->indexProcessorMock->expects($this->any())
+ ->method('reindexRow')
+ ->withAnyParameters();
+ $this->assertInstanceOf(
+ 'Magento\CatalogInventory\Api\Data\StockItemInterface',
+ $this->model->save($stockItemMock, $params)
+ );
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/StockTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/StockTest.php
deleted file mode 100644
index 72b245309b320c8efe4f125ec02ceaaaffa371a0..0000000000000000000000000000000000000000
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/StockTest.php
+++ /dev/null
@@ -1,277 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Model;
-
-use Magento\CatalogInventory\Model\Resource\Stock\Item\CollectionFactory;
-
-/**
- * Class StockTest
- */
-class StockTest extends \PHPUnit_Framework_TestCase
-{
- /**
- * @var Stock
- */
- protected $model;
-
- /**
- * @var \Magento\CatalogInventory\Model\Stock\Status|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $stockStatus;
-
- /**
- * @var CollectionFactory|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $collectionFactory;
-
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject
- */
- protected $stockItemService;
-
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject
- */
- protected $stockItemFactory;
-
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject
- */
- protected $productFactory;
-
- protected function setUp()
- {
- $this->collectionFactory = $this
- ->getMockBuilder('Magento\CatalogInventory\Model\Resource\Stock\Item\CollectionFactory')
- ->setMethods(['create'])
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->stockStatus = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Status')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->stockItemService = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\StockItemService')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->stockItemFactory = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\ItemFactory')
- ->setMethods(['create'])
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->productFactory = $this->getMockBuilder('Magento\Catalog\Model\ProductFactory')
- ->setMethods(['create'])
- ->disableOriginalConstructor()
- ->getMock();
-
- $objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->model = $objectManagerHelper->getObject(
- 'Magento\CatalogInventory\Model\Stock',
- [
- 'stockStatus' => $this->stockStatus,
- 'collectionFactory' => $this->collectionFactory,
- 'stockItemService' => $this->stockItemService,
- 'stockItemFactory' => $this->stockItemFactory,
- 'productFactory' => $this->productFactory
- ]
- );
- }
-
- public function testAddItemsToProducts()
- {
- $storeId = 3;
- $productOneId = 1;
- $productOneStatus = \Magento\CatalogInventory\Model\Stock\Status::STATUS_IN_STOCK;
- $productTwoId = 2;
- $productThreeId = 3;
-
- $stockItemProductId = $productOneId;
- $stockItemStockId = \Magento\CatalogInventory\Model\Stock::DEFAULT_STOCK_ID;
-
- $productCollection = $this->getMockBuilder('Magento\Catalog\Model\Resource\Product\Collection')
- ->disableOriginalConstructor()
- ->setMethods(['getStoreId', 'getIterator'])
- ->getMock();
-
- $stockItem = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->disableOriginalConstructor()
- ->getMock();
- $stockItem->expects($this->atLeastOnce())
- ->method('getProductId')
- ->will($this->returnValue($stockItemProductId));
- $stockItem->expects($this->atLeastOnce())
- ->method('getStockId')
- ->will($this->returnValue($stockItemStockId));
-
- $itemCollection = $this->getMockBuilder('Magento\CatalogInventory\Model\Resource\Stock\Item\Collection')
- ->disableOriginalConstructor()
- ->getMock();
- $itemCollection->expects($this->atLeastOnce())
- ->method('addStockFilter')
- ->with(Stock::DEFAULT_STOCK_ID)
- ->will($this->returnSelf());
- $itemCollection->expects($this->atLeastOnce())
- ->method('addProductsFilter')
- ->with($productCollection)
- ->will($this->returnSelf());
- $itemCollection->expects($this->atLeastOnce())
- ->method('joinStockStatus')
- ->with($storeId)
- ->will($this->returnSelf());
- $itemCollection->expects($this->atLeastOnce())
- ->method('load')
- ->will($this->returnValue([$stockItem]));
-
- $this->collectionFactory->expects($this->atLeastOnce())
- ->method('create')
- ->will($this->returnValue($itemCollection));
-
- $productOne = $this->getMockBuilder('Magento\Catalog\Model\Product')
- ->disableOriginalConstructor()
- ->setMethods(['getId', 'getStockStatus', '__wakeup'])
- ->getMock();
- $productOne->expects($this->atLeastOnce())
- ->method('getId')
- ->will($this->returnValue($productOneId));
- $productOne->expects($this->atLeastOnce())
- ->method('getStockStatus')
- ->will($this->returnValue($productOneStatus));
- $productTwo = $this->getMockBuilder('Magento\Catalog\Model\Product')->disableOriginalConstructor()->getMock();
- $productTwo->expects($this->atLeastOnce())->method('getId')->will($this->returnValue($productTwoId));
- $productThree = $this->getMockBuilder('Magento\Catalog\Model\Product')->disableOriginalConstructor()->getMock();
- $productThree->expects($this->atLeastOnce())->method('getId')->will($this->returnValue($productThreeId));
-
- $productCollection->expects($this->atLeastOnce())->method('getStoreId')->will($this->returnValue($storeId));
- $productCollection->expects($this->any())
- ->method('getIterator')
- ->will($this->returnValue(new \ArrayIterator([$productOne, $productTwo, $productThree])));
-
- $this->stockStatus->expects($this->once())
- ->method('assignProduct')
- ->with($productOne, $stockItemStockId, $productOneStatus);
-
- $this->assertEquals($this->model, $this->model->addItemsToProducts($productCollection));
- }
-
- public function testBackItemQty()
- {
- $productId = 1;
- $qty = 1;
- $productType = 'simple';
-
- $stockItem = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->setMethods(
- [
- 'loadByProduct',
- 'getId',
- 'getCanBackInStock',
- 'getQty',
- 'getMinQty',
- 'setIsInStock',
- 'setStockStatusChangedAutomaticallyFlag',
- 'save',
- '__wakeup',
- ]
- )
- ->disableOriginalConstructor()
- ->getMock();
-
- $stockItem->expects($this->atLeastOnce())->method('loadByProduct')->with($productId)->will($this->returnSelf());
- $stockItem->expects($this->any())->method('getId')->will($this->returnValue(1));
- $this->stockItemFactory->expects($this->atLeastOnce())->method('create')->will($this->returnValue($stockItem));
- $this->getProductType($productId, $productType);
- $this->stockItemService->expects($this->once())
- ->method('isQty')
- ->with($productType)
- ->will($this->returnValue(true));
- $stockItem->expects($this->once())->method('getCanBackInStock')->will($this->returnValue(true));
- $stockItem->expects($this->once())->method('getQty')->will($this->returnValue('10'));
- $stockItem->expects($this->any())->method('getMinQty')->will($this->returnValue('3'));
- $stockItem->expects($this->once())->method('setIsInStock')->will($this->returnSelf());
- $stockItem->expects($this->once())->method('setStockStatusChangedAutomaticallyFlag')->will($this->returnSelf());
- $stockItem->expects($this->once())->method('save');
-
- $this->assertEquals($this->model, $this->model->backItemQty($productId, $qty));
- }
-
- /**
- * @expectedException \Magento\Framework\Model\Exception
- * @expectedExceptionMessage We cannot specify a product identifier for the order item.
- */
- public function testRegisterItemSaleException()
- {
- $item = $this->getMockBuilder('\Magento\Framework\Object')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->model->registerItemSale($item);
- }
-
- public function testRegisterItemSale()
- {
- $productId = 1;
- $qty = 3;
- $productType = 'simple';
- $storeId = 1;
-
- $item = $this->getMockBuilder('\Magento\Framework\Object')
- ->setMethods(['getProductId', 'getStoreId', 'getQtyOrdered'])
- ->disableOriginalConstructor()
- ->getMock();
- $stockItem = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->setMethods(['loadByProduct', 'setStoreId', 'checkQty', 'subtractQty', 'save', '__wakeup'])
- ->disableOriginalConstructor()
- ->getMock();
-
- $item->expects($this->once())->method('getProductId')->will($this->returnValue($productId));
- $stockItem->expects($this->any())->method('loadByProduct')->with($productId)->will($this->returnSelf());
- $this->stockItemFactory->expects($this->any())->method('create')->will($this->returnValue($stockItem));
- $this->getProductType($productId, $productType);
- $this->stockItemService->expects($this->once())
- ->method('isQty')
- ->with($productType)
- ->will($this->returnValue(true));
- $item->expects($this->exactly(2))->method('getStoreId')->will($this->returnValue($storeId));
- $stockItem->expects($this->once())->method('setStoreId')->with($storeId)->will($this->returnSelf());
- $item->expects($this->exactly(2))->method('getQtyOrdered')->will($this->returnValue($qty));
- $stockItem->expects($this->once())->method('checkQty')->with($qty)->will($this->returnValue(true));
- $stockItem->expects($this->once())->method('subtractQty')->with($qty)->will($this->returnSelf());
- $stockItem->expects($this->once())->method('save')->will($this->returnSelf());;
-
- $this->assertEquals($this->model, $this->model->registerItemSale($item));
- }
-
- /**
- * @param $productId
- * @param $productType
- */
- private function getProductType($productId, $productType)
- {
- $product = $this->getMock('Magento\Catalog\Model\Product', [], [], '', false);
- $product->expects($this->any())->method('load')->with($productId);
- $product->expects($this->any())->method('getTypeId')->will($this->returnValue($productType));
- $this->productFactory->expects($this->any())->method('create')->will($this->returnValue($product));
- }
-}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Service/V1/StockItemServiceTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Service/V1/StockItemServiceTest.php
deleted file mode 100644
index f99ebeee9f99e1ad2c34915e2c81018916d54167..0000000000000000000000000000000000000000
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Service/V1/StockItemServiceTest.php
+++ /dev/null
@@ -1,616 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Service\V1;
-
-use Magento\Catalog\Model\ProductTypes\ConfigInterface;
-use Magento\CatalogInventory\Model\Stock\ItemRegistry;
-use Magento\TestFramework\Helper\ObjectManager;
-
-/**
- * Class StockItemTest
- */
-class StockItemServiceTest extends \PHPUnit_Framework_TestCase
-{
- /**
- * @var StockItemService
- */
- protected $model;
-
- /**
- * @var ItemRegistry|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $stockItemRegistry;
-
- /**
- * @var ConfigInterface|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $config;
-
- /**
- * @var Data\StockItemBuilder|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $stockItemBuilder;
-
- /**
- * @var \Magento\Catalog\Service\V1\Product\ProductLoader|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $productLoader;
-
- protected function setUp()
- {
- $this->stockItemRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\ItemRegistry')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->config = $this->getMockBuilder('Magento\Catalog\Model\ProductTypes\ConfigInterface')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->stockItemBuilder = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockItemBuilder')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->productLoader = $this->getMockBuilder('Magento\Catalog\Service\V1\Product\ProductLoader')
- ->disableOriginalConstructor()
- ->getMock();
-
- $objectManagerHelper = new ObjectManager($this);
- $this->model = $objectManagerHelper->getObject(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
- [
- 'stockItemRegistry' => $this->stockItemRegistry,
- 'config' => $this->config,
- 'stockItemBuilder' => $this->stockItemBuilder,
- 'productLoader' => $this->productLoader
- ]
- );
- }
-
- public function testGetStockItem()
- {
- $productId = 123;
- $stockItemData = ['some_key' => 'someValue'];
-
- $stockItemModel = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->disableOriginalConstructor()
- ->getMock();
- $stockItemModel->expects($this->once())
- ->method('getData')
- ->will($this->returnValue($stockItemData));
-
- $this->stockItemRegistry->expects($this->once())
- ->method('retrieve')
- ->with($productId)
- ->will($this->returnValue($stockItemModel));
-
- $this->stockItemBuilder->expects($this->once())
- ->method('populateWithArray')
- ->with($stockItemData);
-
- $stockItemDo = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockItem')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->stockItemBuilder->expects($this->once())
- ->method('create')
- ->will($this->returnValue($stockItemDo));
-
- $this->assertEquals($stockItemDo, $this->model->getStockItem($productId));
- }
-
- public function testSaveStockItem()
- {
- $productId = 123;
- $stockItemData = ['some_key' => 'someValue'];
-
- $stockItemDo = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockItem')
- ->disableOriginalConstructor()
- ->getMock();
- $stockItemDo->expects($this->any())
- ->method('getProductId')
- ->will($this->returnValue($productId));
- $stockItemDo->expects($this->once())
- ->method('__toArray')
- ->will($this->returnValue($stockItemData));
-
- $stockItemModel = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->disableOriginalConstructor()
- ->getMock();
- $stockItemModel->expects($this->once())
- ->method('setData')
- ->with($stockItemData);
- $stockItemModel->expects($this->once())
- ->method('save');
-
- $this->stockItemRegistry->expects($this->once())
- ->method('retrieve')
- ->with($productId)
- ->will($this->returnValue($stockItemModel));
-
- $this->stockItemRegistry->expects($this->once())
- ->method('erase')
- ->with($productId)
- ->will($this->returnValue($stockItemModel));
-
- $this->assertEquals($this->model, $this->model->saveStockItem($stockItemDo));
- }
-
- public function testGetMinSaleQty()
- {
- $productId = 51;
- $result = 2;
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('getMinSaleQty')
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->getMinSaleQty($productId));
- }
-
- public function testGetMaxSaleQty()
- {
- $productId = 46;
- $result = 15;
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('getMaxSaleQty')
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->getMaxSaleQty($productId));
- }
-
- public function testEnableQtyIncrements()
- {
- $productId = 48;
- $result = true;
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('getEnableQtyIncrements')
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->getEnableQtyIncrements($productId));
- }
-
- public function testGetQtyIncrements()
- {
- $productId = 25;
- $result = 15;
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('getQtyIncrements')
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->getQtyIncrements($productId));
- }
-
- public function testGetManageStock()
- {
- $productId = 32;
- $result = 3;
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('getManageStock')
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->getManageStock($productId));
- }
-
- public function testSuggestQty()
- {
- $productId = 143;
- $qty = 3.5;
- $result = true;
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('suggestQty')
- ->with($qty)
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->suggestQty($productId, $qty));
- }
-
- public function testCheckQuoteItemQty()
- {
- $productId = 143;
- $qty = 3.5;
- $summaryQty = 4;
- $origQty = 1;
- $result = $this->getMock('Magento\Framework\Object');
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('checkQuoteItemQty')
- ->with($qty, $summaryQty, $origQty)
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->checkQuoteItemQty($productId, $qty, $summaryQty, $origQty));
- }
-
- public function testVerifyStock()
- {
- $productId = 143;
- $qty = 2.5;
- $result = true;
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('verifyStock')
- ->with($qty)
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->verifyStock($productId, $qty));
- }
-
- public function testVerifyNotification()
- {
- $productId = 42;
- $qty = 7.3;
- $result = true;
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('verifyNotification')
- ->with($qty)
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->verifyNotification($productId, $qty));
- }
-
- public function testGetIsInStock()
- {
- $productId = 96;
- $result = false;
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('getIsInStock')
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->getIsInStock($productId));
- }
-
- public function testGetStockQty()
- {
- $productId = 34;
- $result = 3;
-
- $stockItemModel = $this->getStockItemModel($productId);
- $stockItemModel->expects($this->once())
- ->method('getStockQty')
- ->will($this->returnValue($result));
-
- $this->assertEquals($result, $this->model->getStockQty($productId));
- }
-
- public function testIsQty()
- {
- $configAll = [
- 1 => ['is_qty' => true],
- 2 => ['is_qty' => false],
- 3 => []
- ];
- $this->config->expects($this->once())
- ->method('getAll')
- ->will($this->returnValue($configAll));
-
- $this->assertTrue($this->model->isQty(1));
- $this->assertFalse($this->model->isQty(2));
- $this->assertFalse($this->model->isQty(3));
- $this->assertFalse($this->model->isQty(4));
- }
-
- public function testGetIsQtyTypeIds()
- {
- $configAll = [
- 1 => ['is_qty' => true],
- 2 => ['is_qty' => false],
- 3 => []
- ];
- $resultAll = [1 => true, 2 => false, 3 => false];
- $resultTrue = [1 => true];
- $resultFalse = [2 => false, 3 => false];
-
- $this->config->expects($this->once())
- ->method('getAll')
- ->will($this->returnValue($configAll));
-
- $this->assertEquals($resultAll, $this->model->getIsQtyTypeIds());
- $this->assertEquals($resultTrue, $this->model->getIsQtyTypeIds(true));
- $this->assertEquals($resultFalse, $this->model->getIsQtyTypeIds(false));
- }
-
- /**
- * @param string $productSku
- * @param int $productId
- * @param [] $stockItemData
- * @dataProvider getStockItemBySkuDataProvider
- */
- public function testGetStockItemBySku($productSku, $productId, $stockItemData)
- {
- // 1. Get mocks
- /** @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject $product */
- $product = $this->getMockBuilder('Magento\Catalog\Model\Product')
- ->disableOriginalConstructor()
- ->getMock();
-
- /** @var \Magento\CatalogInventory\Model\Stock\Item|\PHPUnit_Framework_MockObject_MockObject $stockItem */
- $stockItem = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->disableOriginalConstructor()
- ->getMock();
-
- /** @var Data\StockItem|\PHPUnit_Framework_MockObject_MockObject $stockItemDataObject */
- $stockItemDataObject = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockItem')
- ->disableOriginalConstructor()
- ->getMock();
-
- // 2. Set fixtures
- $product->expects($this->any())->method('getId')->will($this->returnValue($productId));
- $stockItem->expects($this->any())->method('getData')->will($this->returnValue($stockItemData));
-
- $this->productLoader->expects($this->any())->method('load')
- ->will($this->returnValueMap([[$productSku, $product]]));
-
- $this->stockItemRegistry->expects($this->any())->method('retrieve')
- ->will($this->returnValueMap([[$productId, $stockItem]]));
-
- $this->stockItemBuilder->expects($this->any())
- ->method('create')
- ->will($this->returnValue($stockItemDataObject));
-
- // 3. Set expectations
- $this->stockItemBuilder->expects($this->any())->method('populateWithArray')->with($stockItemData);
-
- // 4. Run tested method
- $result = $this->model->getStockItemBySku($productSku);
-
- // 5. Compare actual result with expected result
- $this->assertEquals($stockItemDataObject, $result);
- }
-
- /**
- * @return array
- */
- public function getStockItemBySkuDataProvider()
- {
- return [
- ['sku1', 1, ['stock_item_id' => 123]],
- ['sku1', 1, []],
- ];
- }
-
- /**
- * @param string $productSku
- * @param int $productId
- * @dataProvider getStockItemBySkuWithExceptionDataProvider
- * @expectedException \Magento\Framework\Exception\NoSuchEntityException
- */
- public function testGetStockItemBySkuWithException($productSku, $productId)
- {
- // 1. Get mocks
- /** @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject $product */
- $product = $this->getMockBuilder('Magento\Catalog\Model\Product')
- ->disableOriginalConstructor()
- ->getMock();
-
- // 2. Set fixtures
- $this->productLoader->expects($this->any())->method('load')
- ->will($this->returnValueMap([[$productSku, $product]]));
- $product->expects($this->any())->method('getId')->will($this->returnValue($productId));
-
- // 3. Run tested method
- $this->model->getStockItemBySku($productSku);
- }
-
- /**
- * @return array
- */
- public function getStockItemBySkuWithExceptionDataProvider()
- {
- return [
- ['sku1', null],
- ['sku1', false],
- ['sku1', 0],
- ];
- }
-
- /**
- * @param string $productSku
- * @param int $productId
- * @param array $stockItemData
- * @param array $stockItemDetailsDoData
- * @param array $dataToSave
- * @param int $savedStockItemId
- * @dataProvider saveStockItemBySkuDataProvider
- */
- public function testSaveStockItemBySku(
- $productSku,
- $productId,
- $stockItemData,
- $stockItemDetailsDoData,
- $dataToSave,
- $savedStockItemId
- ) {
- // 1. Create mocks
- /** @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject $product */
- $product = $this->getMockBuilder('Magento\Catalog\Model\Product')
- ->disableOriginalConstructor()
- ->getMock();
-
- /** @var \Magento\CatalogInventory\Model\Stock\Item|\PHPUnit_Framework_MockObject_MockObject $stockItem */
- $stockItem = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->disableOriginalConstructor()
- ->getMock();
-
- /** @var Data\StockItem|\PHPUnit_Framework_MockObject_MockObject $stockItemDataObject */
- $stockItemDataObject = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockItem')
- ->disableOriginalConstructor()
- ->getMock();
-
- /** @var Data\StockItem|\PHPUnit_Framework_MockObject_MockObject $stockItemDataObjectMerged */
- $stockItemDataObjectMerged = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockItem')
- ->disableOriginalConstructor()
- ->getMock();
-
- /** @var Data\StockItemDetails|\PHPUnit_Framework_MockObject_MockObject $stockItemDetailsDo */
- $stockItemDetailsDo = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockItemDetails')
- ->disableOriginalConstructor()
- ->getMock();
-
- // 2. Set fixtures
- $product->expects($this->any())->method('getId')->will($this->returnValue($productId));
-
- $stockItem->expects($this->any())->method('getData')->will($this->returnValue($stockItemData));
- $stockItem->expects($this->any())->method('save')->will($this->returnSelf());
- $stockItem->expects($this->any())->method('getId')->will($this->returnValue($savedStockItemId));
-
- $this->productLoader->expects($this->any())->method('load')
- ->will($this->returnValueMap([[$productSku, $product]]));
-
- $this->stockItemRegistry->expects($this->any())->method('retrieve')
- ->will($this->returnValueMap([[$productId, $stockItem]]));
-
- $stockItemDetailsDo->expects($this->any())
- ->method('__toArray')
- ->will($this->returnValue($stockItemDetailsDoData));
-
- $stockItemDataObjectMerged->expects($this->any())
- ->method('__toArray')
- ->will($this->returnValue($dataToSave));
-
- // 3. Set expectations
- $stockItem->expects($this->any())->method('setData')->with($dataToSave)->will($this->returnSelf());
- $this->stockItemBuilder->expects($this->at(0))
- ->method('populateWithArray')
- ->with($stockItemData)
- ->will($this->returnSelf());
- $this->stockItemBuilder->expects($this->at(1))
- ->method('create')
- ->will($this->returnValue($stockItemDataObject));
- $this->stockItemBuilder->expects($this->at(2))
- ->method('mergeDataObjectWithArray')
- ->will($this->returnValue($this->stockItemBuilder));
- $this->stockItemBuilder->expects($this->at(3))
- ->method('create')
- ->will($this->returnValue($stockItemDataObjectMerged));
-
- // 4. Run tested method
- $result = $this->model->saveStockItemBySku($productSku, $stockItemDetailsDo);
-
- // 5. Compare actual result with expected result
- $this->assertEquals($savedStockItemId, $result);
- }
-
- /**
- * @return array
- */
- public function saveStockItemBySkuDataProvider()
- {
- return [
- ['sku1', 1, ['key1' => 'value1'], ['key2' => 'value2'], ['key3' => 'value3'], 123],
- ['sku1', 1, [], [], [], 123],
- ];
- }
-
- /**
- * @param string $productSku
- * @param int $productId
- * @dataProvider saveStockItemBySkuWithExceptionDataProvider
- * @expectedException \Magento\Framework\Exception\NoSuchEntityException
- */
- public function testSaveStockItemBySkuWithException($productSku, $productId)
- {
- // 1. Get mocks
- /** @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject $product */
- $product = $this->getMockBuilder('Magento\Catalog\Model\Product')
- ->disableOriginalConstructor()
- ->getMock();
-
- /** @var Data\StockItemDetails|\PHPUnit_Framework_MockObject_MockObject $stockItemDetailsDo */
- $stockItemDetailsDo = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockItemDetails')
- ->disableOriginalConstructor()
- ->getMock();
-
- // 2. Set fixtures
- $this->productLoader->expects($this->any())->method('load')
- ->will($this->returnValueMap([[$productSku, $product]]));
- $product->expects($this->any())->method('getId')->will($this->returnValue($productId));
-
- // 3. Run tested method
- $this->model->saveStockItemBySku($productSku, $stockItemDetailsDo);
- }
-
- public function testProcessIsInStock()
- {
- $stockData = ['product_id' => 333];
-
- $stockItemModel = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->setMethods(['getData', 'setData', 'processIsInStock', '__wakeup'])
- ->disableOriginalConstructor()
- ->getMock();
- $this->stockItemRegistry->expects($this->once())->method('retrieve')
- ->with($this->equalTo($stockData['product_id']))
- ->will($this->returnValue($stockItemModel));
-
- $stockItemModel->expects($this->once())->method('setData')->with($this->equalTo($stockData));
- $stockItemModel->expects($this->once())->method('processIsInStock');
- $stockItemModel->expects($this->once())->method('getData')->will($this->returnValue($stockData));
-
- $this->assertEquals($stockData, $this->model->processIsInStock($stockData));
- }
-
- /**
- * @return array
- */
- public function saveStockItemBySkuWithExceptionDataProvider()
- {
- return [
- ['sku1', null],
- ['sku1', false],
- ['sku1', 0],
- ];
- }
-
- /**
- * @param int $productId
- * @return \PHPUnit_Framework_MockObject_MockObject
- */
- protected function getStockItemModel($productId)
- {
- $stockItemModel = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Item')
- ->disableOriginalConstructor()
- ->getMock();
- $this->stockItemRegistry->expects($this->once())
- ->method('retrieve')
- ->with($productId)
- ->will($this->returnValue($stockItemModel));
-
- return $stockItemModel;
- }
-}
diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Service/V1/StockStatusServiceTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Service/V1/StockStatusServiceTest.php
deleted file mode 100644
index f3fc1803a1072625f367e1a91e2779bcc7aaa300..0000000000000000000000000000000000000000
--- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Service/V1/StockStatusServiceTest.php
+++ /dev/null
@@ -1,359 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\CatalogInventory\Service\V1;
-
-/**
- * Test for Magento\CatalogInventory\Service\V1\StockStatusService
- */
-class StockStatusServiceTest extends \PHPUnit_Framework_TestCase
-{
- /**
- * @var StockStatusService
- */
- protected $model;
-
- /**
- * @var \Magento\CatalogInventory\Model\Stock\Status|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $stockStatus;
-
- /**
- * @var \Magento\Catalog\Service\V1\Product\ProductLoader|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $productLoader;
-
- /**
- * @var \Magento\Store\Model\Resolver\Website|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $scopeResolver;
-
- /**
- * @var Data\StockStatusBuilder|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $stockStatusBuilder;
-
- /**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $stockItemService;
-
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject
- */
- protected $lowStockResultBuilder;
-
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject
- */
- protected $itemsFactory;
-
- protected function setUp()
- {
- $this->stockStatus = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Status')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->productLoader = $this->getMockBuilder('Magento\Catalog\Service\V1\Product\ProductLoader')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->scopeResolver = $this->getMockBuilder('Magento\Store\Model\Resolver\Website')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->stockStatusBuilder = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockStatusBuilder')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->stockItemService = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\StockItemService')
- ->disableOriginalConstructor()
- ->getMock();
-
- $this->lowStockResultBuilder = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\Data\LowStockResultBuilder',
- [],
- [],
- '',
- false
- );
- $this->itemsFactory = $this->getMock(
- 'Magento\CatalogInventory\Model\Resource\Stock\Status\CollectionFactory',
- ['create'],
- [],
- '',
- false
- );
-
- $objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->model = $objectManagerHelper->getObject(
- 'Magento\CatalogInventory\Service\V1\StockStatusService',
- [
- 'stockStatus' => $this->stockStatus,
- 'productLoader' => $this->productLoader,
- 'scopeResolver' => $this->scopeResolver,
- 'stockStatusBuilder' => $this->stockStatusBuilder,
- 'stockItemService' => $this->stockItemService,
- 'itemsFactory' => $this->itemsFactory,
- 'lowStockResultBuilder' => $this->lowStockResultBuilder
- ]
- );
- }
-
- /**
- * @param int $productId
- * @param int $websiteId
- * @param int $stockId
- * @param mixed $expectedResult
- * @dataProvider getProductStockStatusDataProvider
- */
- public function testGetProductStockStatus($productId, $websiteId, $stockId, $expectedResult)
- {
- $this->stockStatus->expects($this->once())
- ->method('getProductStockStatus')
- ->with([$productId], $websiteId, $stockId)
- ->will($this->returnValue([$productId => 'expected_result']));
-
- $result = $this->model->getProductStockStatus($productId, $websiteId, $stockId);
-
- $this->assertEquals($expectedResult, $result);
- }
-
- /**
- * @return array
- */
- public function getProductStockStatusDataProvider()
- {
- $productId = 1;
- return [
- [$productId, 3, 4, 'expected_result'],
- ];
- }
-
- public function testAssignProduct()
- {
- $product = $this->getMockBuilder('Magento\Catalog\Model\Product')->disableOriginalConstructor()->getMock();
- $stockId = 1;
- $stockStatus = false;
-
- $this->stockStatus->expects($this->once())
- ->method('assignProduct')
- ->with($product, $stockId, $stockStatus)
- ->will($this->returnSelf());
-
- $this->assertEquals($this->model, $this->model->assignProduct($product, $stockId, $stockStatus));
- }
-
- /**
- * @param string $productSku
- * @param int $productId
- * @param int $websiteId
- * @param array $productStockStatusArray
- * @param int $stockQty
- * @param array $array
- * @dataProvider getProductStockStatusBySkuDataProvider
- */
- public function testGetProductStockStatusBySku(
- $productSku,
- $productId,
- $websiteId,
- $productStockStatusArray,
- $stockQty,
- $array
- ) {
- // 1. Create mocks
- /** @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject $product */
- $product = $this->getMockBuilder('Magento\Catalog\Model\Product')
- ->disableOriginalConstructor()
- ->getMock();
-
- /** @var \Magento\Framework\App\ScopeInterface|\PHPUnit_Framework_MockObject_MockObject $scope */
- $scope = $this->getMockBuilder('Magento\Framework\App\ScopeInterface')
- ->disableOriginalConstructor()
- ->getMock();
-
- /**
- * @var \Magento\CatalogInventory\Service\V1\Data\StockStatus|\PHPUnit_Framework_MockObject_MockObject $scope
- */
- $stockStatusDataObject = $this->getMockBuilder('Magento\CatalogInventory\Service\V1\Data\StockStatus')
- ->disableOriginalConstructor()
- ->getMock();
-
- // 2. Set fixtures
- $this->productLoader->expects($this->any())->method('load')->will($this->returnValueMap([
- [$productSku, $product]
- ]));
- $product->expects($this->any())->method('getId')->will($this->returnValue($productId));
- $this->scopeResolver->expects($this->any())->method('getScope')->will($this->returnValue($scope));
- $scope->expects($this->any())->method('getId')->will($this->returnValue($websiteId));
- $this->stockStatusBuilder->expects($this->any())
- ->method('create')
- ->will($this->returnValue($stockStatusDataObject));
-
- // 3. Set expectations
- $this->stockStatus->expects($this->any())
- ->method('getProductStockStatus')
- ->with([$productId], $websiteId)
- ->will($this->returnValue($productStockStatusArray));
-
- $this->stockItemService->expects($this->any())
- ->method('getStockQty')
- ->will($this->returnValueMap([[$productId, $stockQty]]));
-
- $this->stockStatusBuilder->expects($this->any())->method('populateWithArray')->with($array);
-
- // 4. Run tested method
- $result = $this->model->getProductStockStatusBySku($productSku);
-
- // 5. Compare actual result with expected result
- $this->assertEquals($stockStatusDataObject, $result);
- }
-
- /**
- * @return array
- */
- public function getProductStockStatusBySkuDataProvider()
- {
- $productId = 123;
-
- $productStatusInStock = true;
- $fullStockQty = 456;
-
- $productStatusOutOfStock = false;
- $emptyStockQty = 0;
- return [
- [
- 'sku1',
- $productId,
- 1,
- [$productId => $productStatusInStock],
- $fullStockQty,
- [
- Data\StockStatus::STOCK_STATUS => $productStatusInStock,
- Data\StockStatus::STOCK_QTY => $fullStockQty
- ]
- ],
- [
- 'sku1',
- $productId,
- 1,
- [$productId => $productStatusOutOfStock],
- $emptyStockQty,
- [
- Data\StockStatus::STOCK_STATUS => $productStatusOutOfStock,
- Data\StockStatus::STOCK_QTY => $emptyStockQty
- ]
- ],
- ];
- }
-
- /**
- * @param string $productSku
- * @param int $productId
- * @dataProvider getProductStockWithExceptionStatusBySkuDataProvider
- * @expectedException \Magento\Framework\Exception\NoSuchEntityException
- */
- public function testGetProductStockWithExceptionStatusBySku($productSku, $productId)
- {
- // 1. Create mocks
- /** @var \Magento\Catalog\Model\Product|\PHPUnit_Framework_MockObject_MockObject $product */
- $product = $this->getMockBuilder('Magento\Catalog\Model\Product')
- ->disableOriginalConstructor()
- ->getMock();
-
- // 2. Set fixtures
- $this->productLoader->expects($this->any())->method('load')->will($this->returnValueMap([
- [$productSku, $product]
- ]));
- $product->expects($this->any())->method('getId')->will($this->returnValue($productId));
-
- // 3. Run tested method
- $this->model->getProductStockStatusBySku($productSku);
- }
-
- /**
- * @return array
- */
- public function getProductStockWithExceptionStatusBySkuDataProvider()
- {
- return [
- ['sku1', null],
- ['sku1', false],
- ['sku1', 0],
- ];
- }
-
- /**
- * @covers \Magento\CatalogInventory\Service\V1\StockStatusService::getLowStockItems
- */
- public function testGetterOfLowStockItems()
- {
- $websiteId = 1;
- $criteriaData = [
- 'qty' => 1,
- 'current_page' => 1,
- 'page_size' => 10
- ];
- $scope = $this->getMockBuilder('Magento\Store\Model\Website')
- ->disableOriginalConstructor()
- ->getMock();
- $scope->expects($this->any())->method('getId')->will($this->returnValue($websiteId));
- $this->scopeResolver->expects($this->any())->method('getScope')->will($this->returnValue($scope));
-
- $builder = $this->getMockBuilder('Magento\Framework\Api\ExtensibleObjectBuilder')
- ->disableOriginalConstructor()
- ->getMock();
- $builder->expects($this->any())->method('getData')->will($this->returnValue($criteriaData));
-
- $statusItem = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Status')
- ->setMethods(['__wakeup', 'getSku'])
- ->disableOriginalConstructor()
- ->getMock();
- $statusItem->expects($this->any())->method('getSku')->will($this->returnValue('test_sku'));
-
- $collection = $this->getMockBuilder('Magento\CatalogInventory\Model\Resource\Stock\Status\Collection')
- ->disableOriginalConstructor()
- ->getMock();
- $collection->expects($this->any())->method('getSize')->will($this->returnValue(1));
- $collection->expects($this->any())->method('getIterator')
- ->will($this->returnValue(new \ArrayIterator([$statusItem])));
- $this->itemsFactory->expects($this->once())->method('create')->will($this->returnValue($collection));
-
- /** @var \Magento\Framework\Api\ExtensibleObjectBuilder $builder */
- $lowStockCriteria = new Data\LowStockCriteria($builder);
-
- // Expected results
- $collection->expects($this->atLeastOnce())->method('addWebsiteFilter')->with($scope);
- $collection->expects($this->atLeastOnce())->method('addQtyFilter')->with($criteriaData['qty']);
- $collection->expects($this->atLeastOnce())->method('setCurPage')->with($criteriaData['current_page']);
- $collection->expects($this->atLeastOnce())->method('setPageSize')->with($criteriaData['page_size']);
-
- $this->lowStockResultBuilder->expects($this->atLeastOnce())->method('setSearchCriteria')
- ->with($lowStockCriteria);
- $this->lowStockResultBuilder->expects($this->atLeastOnce())->method('setTotalCount')->with(1);
- $this->lowStockResultBuilder->expects($this->atLeastOnce())->method('setItems')->with(['test_sku']);
-
- // Run tested method
- $this->model->getLowStockItems($lowStockCriteria);
- }
-}
diff --git a/dev/tests/unit/testsuite/Magento/Centinel/Model/StateFactoryTest.php b/dev/tests/unit/testsuite/Magento/Centinel/Model/StateFactoryTest.php
index 5829379b987d0bbadab287f5c714ffefea66e4dc..1103c89f2394bf0a6a4948000d3d05e0a66e9f84 100644
--- a/dev/tests/unit/testsuite/Magento/Centinel/Model/StateFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Centinel/Model/StateFactoryTest.php
@@ -29,7 +29,7 @@ class StateFactoryTest extends \PHPUnit_Framework_TestCase
{
public function testCreateState()
{
- $objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager->expects(
$this->at(0)
)->method(
@@ -85,7 +85,7 @@ class StateFactoryTest extends \PHPUnit_Framework_TestCase
public function testCreateStateMapIsEmpty()
{
- $objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$factory = new \Magento\Centinel\Model\StateFactory($objectManager);
$this->assertFalse($factory->createState('VI'));
$this->assertFalse($factory->createState('MC'));
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Block/Cart/Item/RendererTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Block/Cart/Item/RendererTest.php
index aa1bbe3b4e91fd3cda270f1a14a09dc7e69237bb..fca7f5fbedd773b40e3dbe3fd8b35604212f56dc 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Block/Cart/Item/RendererTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Block/Cart/Item/RendererTest.php
@@ -23,12 +23,10 @@
*/
namespace Magento\Checkout\Block\Cart\Item;
-use Magento\Checkout\Block\Cart\Item\Renderer;
-
class RendererTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Catalog\Helper\Image|\PHPUnit_Framework_MockObject_MockObject
+ * @var \PHPUnit_Framework_MockObject_MockObject
*/
protected $_imageHelper;
@@ -38,13 +36,12 @@ class RendererTest extends \PHPUnit_Framework_TestCase
protected $_renderer;
/**
- * @var \Magento\View\LayoutInterface|\PHPUnit_Framework_MockObject_MockObject
+ * @var \PHPUnit_Framework_MockObject_MockObject
*/
protected $layout;
protected function setUp()
{
- parent::setUp();
$objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->_imageHelper = $this->getMock('Magento\Catalog\Helper\Image', array(), array(), '', false);
@@ -59,7 +56,10 @@ class RendererTest extends \PHPUnit_Framework_TestCase
$this->_renderer = $objectManagerHelper->getObject(
'Magento\Checkout\Block\Cart\Item\Renderer',
- array('imageHelper' => $this->_imageHelper, 'context' => $context)
+ [
+ 'imageHelper' => $this->_imageHelper,
+ 'context' => $context
+ ]
);
}
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Controller/Onepage/IndexTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Controller/Onepage/IndexTest.php
index 556312aebae83a083b28c4c55da2b331b9bf8d29..e40688777a894db10874fdae1bd91036b9ef998d 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Controller/Onepage/IndexTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Controller/Onepage/IndexTest.php
@@ -109,7 +109,7 @@ class IndexTest extends \PHPUnit_Framework_TestCase
{
// mock objects
$this->objectManager = new ObjectManager($this);
- $this->objectManagerMock = $this->basicMock('\Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->basicMock('\Magento\Framework\ObjectManagerInterface');
$this->dataMock = $this->basicMock('Magento\Checkout\Helper\Data');
$this->quoteMock = $this->basicMock('\Magento\Sales\Model\Quote');
$this->contextMock = $this->basicMock('\Magento\Framework\App\Action\Context');
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Helper/CartTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Helper/CartTest.php
index d3e1ff07b1546cabba3e163ea40d338356a3b1dc..c06221c70d6b30f8b7359b5f0d648ea31b4804ec 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Helper/CartTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Helper/CartTest.php
@@ -64,6 +64,11 @@ class CartTest extends \PHPUnit_Framework_TestCase
*/
protected $checkoutSessionMock;
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\Url\EncoderInterface
+ */
+ protected $urlEncoder;
+
/**
* @var Cart
*/
@@ -71,7 +76,13 @@ class CartTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->urlBuilderMock = $this->getMock('\Magento\Framework\UrlInterface');
+ $this->urlBuilderMock = $this->getMock('Magento\Framework\UrlInterface');
+ $this->urlEncoder = $this->getMockBuilder('Magento\Framework\Url\EncoderInterface')->getMock();
+ $this->urlEncoder->expects($this->any())
+ ->method('encode')
+ ->willReturnCallback(function ($url) {
+ return strtr(base64_encode($url), '+/=', '-_,');
+ });
$this->requestMock = $this->getMock(
'\Magento\Framework\App\RequestInterface',
[
@@ -88,6 +99,7 @@ class CartTest extends \PHPUnit_Framework_TestCase
$contextMock = $this->getMock('\Magento\Framework\App\Helper\Context', [], [], '', false);
$contextMock->expects($this->any())->method('getUrlBuilder')->will($this->returnValue($this->urlBuilderMock));
$contextMock->expects($this->any())->method('getRequest')->will($this->returnValue($this->requestMock));
+ $contextMock->expects($this->any())->method('getUrlEncoder')->will($this->returnValue($this->urlEncoder));
$this->storeManagerMock = $this->getMock('\Magento\Framework\StoreManagerInterface');
$this->coreHelperMock = $this->getMock('\Magento\Core\Helper\Data', [], [], '', false);
$this->scopeConfigMock = $this->getMock('\Magento\Framework\App\Config\ScopeConfigInterface');
@@ -230,7 +242,9 @@ class CartTest extends \PHPUnit_Framework_TestCase
$context->expects($this->once())
->method('getUrlBuilder')
->will($this->returnValue($urlBuilder));
-
+ $context->expects($this->any())
+ ->method('getUrlEncoder')
+ ->willReturn($this->urlEncoder);
$item = $this->getMock('Magento\Sales\Model\Quote\Item', [], [], '', false);
$request = $this->getMock('\Magento\Framework\App\Request\Http', [], [], '', false);
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Helper/ExpressRedirectTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Helper/ExpressRedirectTest.php
index d5b119bc336c0368a0119bc0f5e78f1b8d162ce0..1bef83a08cba9dfe981211f06abacd052e8a9470 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Helper/ExpressRedirectTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Helper/ExpressRedirectTest.php
@@ -60,11 +60,7 @@ class ExpressRedirectTest extends \PHPUnit_Framework_TestCase
array('set')
)->getMock();
- $this->_objectManager = $this->getMockBuilder(
- 'Magento\Framework\ObjectManager'
- )->disableOriginalConstructor()->setMethods(
- array('get', 'setFactory', 'create', 'configure')
- )->getMock();
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_customerSession = $this->getMockBuilder(
'Magento\Customer\Model\Session'
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Model/CartTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Model/CartTest.php
index ee6ac8d6e75d5c3b49391c0cccf2164577e63f43..0d602f7d80ba7bc0fcc37acc74859bc54aba6592 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Model/CartTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Model/CartTest.php
@@ -45,7 +45,7 @@ class CartTest extends \PHPUnit_Framework_TestCase
*/
protected $customerSessionMock;
- /** @var \Magento\CatalogInventory\Service\V1\StockItemService|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\CatalogInventory\Api\StockItem|\PHPUnit_Framework_MockObject_MockObject */
protected $stockItemMock;
/**
@@ -63,18 +63,45 @@ class CartTest extends \PHPUnit_Framework_TestCase
*/
protected $eventManagerMock;
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistry;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockState;
+
protected function setUp()
{
$this->checkoutSessionMock = $this->getMock('Magento\Checkout\Model\Session', [], [], '', false);
$this->customerSessionMock = $this->getMock('Magento\Customer\Model\Session', [], [], '', false);
$this->scopeConfigMock = $this->getMock('\Magento\Framework\App\Config\ScopeConfigInterface');
+ $this->stockRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\StockRegistry')
+ ->disableOriginalConstructor()
+ ->setMethods(['getStockItem', '__wakeup'])
+ ->getMock();
+
$this->stockItemMock = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
+ 'Magento\CatalogInventory\Model\Stock\Item',
+ ['getMinSaleQty', '__wakeup'],
[],
+ '',
+ false
+ );
+
+ $this->stockState = $this->getMock(
+ 'Magento\CatalogInventory\Model\StockState',
+ ['suggestQty', '__wakeup'],
[],
'',
false
);
+
+ $this->stockRegistry->expects($this->any())
+ ->method('getStockItem')
+ ->will($this->returnValue($this->stockItemMock));
$this->quoteMock = $this->getMock('Magento\Sales\Model\Quote', [], [], '', false);
$this->eventManagerMock = $this->getMock('Magento\Framework\Event\ManagerInterface');
@@ -84,7 +111,8 @@ class CartTest extends \PHPUnit_Framework_TestCase
[
'scopeConfig' => $this->scopeConfigMock,
'checkoutSession' => $this->checkoutSessionMock,
- 'stockItemService' => $this->stockItemMock,
+ 'stockRegistry' => $this->stockRegistry,
+ 'stockState' => $this->stockState,
'customerSession' => $this->customerSessionMock,
'eventManager' => $this->eventManagerMock
]
@@ -93,7 +121,7 @@ class CartTest extends \PHPUnit_Framework_TestCase
public function testSuggestItemsQty()
{
- $data = [[], ['qty' => -2], ['qty' => 3], ['qty' => 3.5], ['qty' => 5], ['qty' => 4]];
+ $data = [[] , ['qty' => -2], ['qty' => 3], ['qty' => 3.5], ['qty' => 5], ['qty' => 4]];
$this->quoteMock->expects($this->any())
->method('getItemById')
->will($this->returnValueMap([
@@ -103,11 +131,14 @@ class CartTest extends \PHPUnit_Framework_TestCase
[5, $this->prepareQuoteItemMock(5)],
]));
- $this->stockItemMock->expects($this->any())
+ $this->stockState->expects($this->at(0))
->method('suggestQty')
- ->will($this->returnValueMap([[4, 3., 3.], [5, 3.5, 3.5]]));
+ ->will($this->returnValue(3.0));
+ $this->stockState->expects($this->at(1))
+ ->method('suggestQty')
+ ->will($this->returnValue(3.5));
- $this->checkoutSessionMock->expects($this->once())
+ $this->checkoutSessionMock->expects($this->any())
->method('getQuote')
->will($this->returnValue($this->quoteMock));
@@ -151,18 +182,40 @@ class CartTest extends \PHPUnit_Framework_TestCase
*/
public function prepareQuoteItemMock($itemId)
{
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId', '__wakeup'], [], '', false);
+ $store->expects($this->any())
+ ->method('getWebsiteId')
+ ->will($this->returnValue(10));
switch ($itemId) {
case 2:
- $product = $this->getMock('Magento\Catalog\Model\Product', [], [], '', false);
+ $product = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getStore', 'getId', '__wakeup'],
+ [],
+ '',
+ false
+ );
$product->expects($this->once())
->method('getId')
->will($this->returnValue(4));
+ $product->expects($this->once())
+ ->method('getStore')
+ ->will($this->returnValue($store));
break;
case 3:
- $product = $this->getMock('Magento\Catalog\Model\Product', [], [], '', false);
+ $product = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getStore', 'getId', '__wakeup'],
+ [],
+ '',
+ false
+ );
$product->expects($this->once())
->method('getId')
->will($this->returnValue(5));
+ $product->expects($this->once())
+ ->method('getStore')
+ ->will($this->returnValue($store));
break;
case 4:
$product = false;
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Model/SessionTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Model/SessionTest.php
index 147c7fe1436c1b41ffafd8ad261b1d6354eaa2c5..30f423d90bdff5b7a94f8df3290929ea37e681f6 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Model/SessionTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Model/SessionTest.php
@@ -62,8 +62,8 @@ class SessionTest extends \PHPUnit_Framework_TestCase
$messageCollectionFactory = $this->getMockBuilder(
'Magento\Framework\Message\CollectionFactory'
)->disableOriginalConstructor()->getMock();
- $quoteFactory = $this->getMockBuilder(
- 'Magento\Sales\Model\QuoteFactory'
+ $quoteRepository = $this->getMockBuilder(
+ 'Magento\Sales\Model\QuoteRepository'
)->disableOriginalConstructor()->getMock();
$appState = $this->getMock('\Magento\Framework\App\State', array(), array(), '', false);
@@ -78,7 +78,7 @@ class SessionTest extends \PHPUnit_Framework_TestCase
'request' => $request,
'orderFactory' => $orderFactory,
'messageCollectionFactory' => $messageCollectionFactory,
- 'quoteFactory' => $quoteFactory,
+ 'quoteRepository' => $quoteRepository,
'storage' => new \Magento\Framework\Session\Storage()
)
);
@@ -174,7 +174,13 @@ class SessionTest extends \PHPUnit_Framework_TestCase
$order->expects($this->once())->method('getId')->will($this->returnValue($hasOrderId ? 'order id' : null));
$orderFactory = $this->getMock('Magento\Sales\Model\OrderFactory', array('create'), array(), '', false);
$orderFactory->expects($this->once())->method('create')->will($this->returnValue($order));
- $quoteFactory = $this->getMock('Magento\Sales\Model\QuoteFactory', array('create'), array(), '', false);
+ $quoteRepository = $this->getMock(
+ 'Magento\Sales\Model\QuoteRepository',
+ array('get', 'save'),
+ array(),
+ '',
+ false
+ );
$storage = $this->getMock('Magento\Framework\Session\Storage', null);
$store = $this->getMock('Magento\Store\Model\Store', array(), array(), '', false);
$storeManager = $this->getMockForAbstractClass('Magento\Framework\StoreManagerInterface');
@@ -186,7 +192,7 @@ class SessionTest extends \PHPUnit_Framework_TestCase
'Magento\Checkout\Model\Session',
array(
'orderFactory' => $orderFactory,
- 'quoteFactory' => $quoteFactory,
+ 'quoteRepository' => $quoteRepository,
'storage' => $storage,
'storeManager' => $storeManager,
'eventManager' => $eventManager
@@ -202,29 +208,20 @@ class SessionTest extends \PHPUnit_Framework_TestCase
$order->setQuoteId($quoteId);
$quote = $this->getMock(
'Magento\Sales\Model\Quote',
- array('getId', 'save', 'setIsActive', 'setReservedOrderId', 'load', '__wakeup'),
+ array('setIsActive', 'getId', 'setReservedOrderId', '__wakeup'),
array(),
'',
false
);
- $quote->expects(
- $this->any()
- )->method(
- 'getId'
- )->will(
- $this->returnValue($hasQuoteId ? $anotherQuoteId : null)
- );
- $quote->expects(
- $this->any()
- )->method(
- 'load'
- )->with(
- $this->equalTo($quoteId)
- )->will(
- $this->returnValue($quote)
- );
- $quoteFactory->expects($this->once())->method('create')->will($this->returnValue($quote));
if ($hasQuoteId) {
+ $quoteRepository->expects($this->once())->method('get')->with($quoteId)->willReturn($quote);
+ $quote->expects(
+ $this->any()
+ )->method(
+ 'getId'
+ )->will(
+ $this->returnValue($anotherQuoteId)
+ );
$eventManager->expects(
$this->once()
)->method(
@@ -251,8 +248,14 @@ class SessionTest extends \PHPUnit_Framework_TestCase
)->will(
$this->returnSelf()
);
- $quote->expects($this->once())->method('save');
+ $quoteRepository->expects($this->once())->method('save')->with($quote);
} else {
+ $quoteRepository->expects($this->once())
+ ->method('get')
+ ->with($quoteId)
+ ->willThrowException(
+ new \Magento\Framework\Exception\NoSuchEntityException()
+ );
$quote->expects($this->never())->method('setIsActive');
$quote->expects($this->never())->method('setReservedOrderId');
$quote->expects($this->never())->method('save');
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Model/Type/OnepageTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Model/Type/OnepageTest.php
index 63644bbb2ae7c266300ef47b8b54c51d086ab3af..863592b4fc6d8dc9d7bdaff9d29b4ad0ecf1f063 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Model/Type/OnepageTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Model/Type/OnepageTest.php
@@ -44,8 +44,8 @@ class OnepageTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Checkout\Helper\Data|\PHPUnit_Framework_MockObject_MockObject */
protected $checkoutHelperMock;
- /** @var \Magento\Customer\Helper\Data|\PHPUnit_Framework_MockObject_MockObject */
- protected $customerHelperMock;
+ /** @var \Magento\Customer\Model\Url|\PHPUnit_Framework_MockObject_MockObject */
+ protected $customerUrlMock;
/** @var \Magento\Framework\Logger|\PHPUnit_Framework_MockObject_MockObject */
protected $loggerMock;
@@ -59,7 +59,7 @@ class OnepageTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Framework\StoreManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $storeManagerMock;
- /** @var \Magento\App\RequestInterface|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\App\RequestInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $requestMock;
/** @var \PHPUnit_Framework_MockObject_MockObject */
@@ -104,11 +104,14 @@ class OnepageTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Customer\Service\V1\CustomerAccountServiceInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $customerAccountServiceMock;
+ /** @var \Magento\Sales\Model\QuoteRepository|\PHPUnit_Framework_MockObject_MockObject */
+ protected $quoteRepositoryMock;
+
protected function setUp()
{
$this->eventManagerMock = $this->getMock('Magento\Framework\Event\ManagerInterface');
$this->checkoutHelperMock = $this->getMock('Magento\Checkout\Helper\Data', [], [], '', false);
- $this->customerHelperMock = $this->getMock('Magento\Customer\Helper\Data', [], [], '', false);
+ $this->customerUrlMock = $this->getMock('Magento\Customer\Model\Url', [], [], '', false);
$this->loggerMock = $this->getMock('Magento\Framework\Logger', [], [], '', false);
$this->checkoutSessionMock = $this->getMock('Magento\Checkout\Model\Session',
['getLastOrderId', 'getQuote', 'setStepData', 'getStepData'], [], '', false);
@@ -161,13 +164,21 @@ class OnepageTest extends \PHPUnit_Framework_TestCase
'Magento\Customer\Service\V1\CustomerAccountServiceInterface'
);
+ $this->quoteRepositoryMock = $this->getMock(
+ 'Magento\Sales\Model\QuoteRepository',
+ [],
+ [],
+ '',
+ false
+ );
+
$this->objectManagerHelper = new ObjectManagerHelper($this);
$this->onepage = $this->objectManagerHelper->getObject(
'Magento\Checkout\Model\Type\Onepage',
[
'eventManager' => $this->eventManagerMock,
'helper' => $this->checkoutHelperMock,
- 'customerData' => $this->customerHelperMock,
+ 'customerUrl' => $this->customerUrlMock,
'logger' => $this->loggerMock,
'checkoutSession' => $this->checkoutSessionMock,
'customerSession' => $this->customerSessionMock,
@@ -186,7 +197,8 @@ class OnepageTest extends \PHPUnit_Framework_TestCase
'mathRandom' => $this->randomMock,
'encryptor' => $this->encryptorMock,
'customerAddressService' => $this->customerAddressServiceMock,
- 'accountService' => $this->customerAccountServiceMock
+ 'accountService' => $this->customerAccountServiceMock,
+ 'quoteRepository' => $this->quoteRepositoryMock,
]
);
}
@@ -216,9 +228,10 @@ class OnepageTest extends \PHPUnit_Framework_TestCase
$quoteMock = $this->getMock('Magento\Sales\Model\Quote', [], [], '', false);
$quoteMock->expects($this->once())->method('isMultipleShippingAddresses')->will($this->returnValue(true));
$quoteMock->expects($this->once())->method('removeAllAddresses');
- $quoteMock->expects($this->once())->method('save');
$quoteMock->expects($this->once())->method('assignCustomer')->with($customer);
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock);
+
$this->customerSessionMock
->expects($this->once())
->method('getCustomerDataObject')
@@ -289,13 +302,13 @@ class OnepageTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Sales\Model\Quote|\PHPUnit_Framework_MockObject_MockObject $quoteMock */
$quoteMock = $this->getMock(
'Magento\Sales\Model\Quote',
- ['setCheckoutMethod', 'save', '__wakeup'],
+ ['setCheckoutMethod', '__wakeup'],
[],
'',
false
);
- $quoteMock->expects($this->once())->method('save');
$quoteMock->expects($this->once())->method('setCheckoutMethod')->with('someMethod')->will($this->returnSelf());
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock);
$this->checkoutSessionMock->expects($this->once())->method('setStepData')->with('billing', 'allow', true);
$this->onepage->setQuote($quoteMock);
$this->assertEquals([], $this->onepage->saveCheckoutMethod('someMethod'));
@@ -368,7 +381,6 @@ class OnepageTest extends \PHPUnit_Framework_TestCase
'getShippingAddress',
'getCustomerData',
'collectTotals',
- 'save',
],
[],
'',
@@ -399,7 +411,7 @@ class OnepageTest extends \PHPUnit_Framework_TestCase
$addressMock->expects($this->any())->method('getData')->will($this->returnValue([]));
$quoteMock->expects($this->any())->method('getBillingAddress')->will($this->returnValue($addressMock));
$quoteMock->expects($this->any())->method('getCustomerId')->will($this->returnValue($quoteCustomerId));
- $quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock);
$formMock = $this->getMock('Magento\Customer\Model\Metadata\Form', [], [], '', false);
$formMock->expects($this->atLeastOnce())->method('validateData')->will($this->returnValue($validateDataResult));
$this->requestMock
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/ReadServiceTest.php
index f442095e2ee63bc7e2a0ce4763e01aaafc20fc69..3e654150ec531e4406ab060505e45b778ca0b3b8 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/ReadServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/ReadServiceTest.php
@@ -50,10 +50,10 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
$this->service = new ReadService($this->quoteRepositoryMock, $this->converterMock);
}
- public function testGetAddress()
+ public function testGetAddress()
{
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
- $this->quoteRepositoryMock->expects($this->once())->method('get')
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')
->with('cartId')->will($this->returnValue($quoteMock));
$addressMock = $this->getMock('\Magento\Sales\Model\Quote\Address', [], [], '', false);
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/WriteServiceTest.php
index 9483e5cd147c27af3be2fe69f591f3e7787bc99b..5cf9c9b081b7bb9e779627337af4ff75549fdd6f 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/WriteServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/WriteServiceTest.php
@@ -107,7 +107,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
{
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with('cartId')
->will($this->returnValue($quoteMock));
@@ -117,11 +117,11 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->service->setAddress('cartId', null);
}
- public function testSetAddress()
+ public function testSetAddress()
{
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with('cartId')
->will($this->returnValue($quoteMock));
@@ -148,7 +148,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock->expects($this->once())->method('setBillingAddress')->with($this->quoteAddressMock);
$quoteMock->expects($this->once())->method('setDataChanges')->with(true);
- $quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock);
$addressId = 1;
$billingAddressMock = $this->getMock('\Magento\Sales\Model\Quote\Address', [], [], '', false);
$billingAddressMock->expects($this->once())->method('getId')->will($this->returnValue($addressId));
@@ -166,7 +166,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
{
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with('cartId')
->will($this->returnValue($quoteMock));
@@ -194,9 +194,12 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock->expects($this->once())->method('setBillingAddress')->with($this->quoteAddressMock);
$quoteMock->expects($this->once())->method('setDataChanges')->with(true);
- $quoteMock->expects($this->once())->method('save')->willThrowException(
- new \Exception('Some DB Error')
- );
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('save')
+ ->with($quoteMock)
+ ->willThrowException(
+ new \Exception('Some DB Error')
+ );
$this->service->setAddress('cartId', $addressData);
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceTest.php
index e211849ed9a22b12138ff7368110dcfc78c3d81f..9baebce10dd4b525fd9e4f97bb92726f7c43771d 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceTest.php
@@ -53,7 +53,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
public function testGetAddress()
{
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
- $this->quoteRepositoryMock->expects($this->once())->method('get')->with('cartId')->will(
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with('cartId')->will(
$this->returnValue($quoteMock)
);
@@ -74,7 +74,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
public function testGetAddressOfQuoteWithVirtualProducts()
{
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
- $this->quoteRepositoryMock->expects($this->once())->method('get')->with('cartId')->will(
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with('cartId')->will(
$this->returnValue($quoteMock)
);
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceTest.php
index 16738a83206416bbd37add7be323c89cf2a9b1e1..4ce760165494777a7a5008f613ed9e6b4803c2af 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceTest.php
@@ -108,7 +108,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
{
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with('cart654')
->will($this->returnValue($quoteMock));
@@ -122,7 +122,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
{
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with('cart867')
->will($this->returnValue($quoteMock));
$quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false));
@@ -150,7 +150,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock->expects($this->once())->method('setShippingAddress')->with($this->quoteAddressMock);
$quoteMock->expects($this->once())->method('setDataChanges')->with(true);
- $quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock);
$addressId = 1;
$shippingAddressMock = $this->getMock('\Magento\Sales\Model\Quote\Address', [], [], '', false);
@@ -169,7 +169,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
{
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with('cart867')
->will($this->returnValue($quoteMock));
$quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(true));
@@ -203,7 +203,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
{
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with('cart867')
->will($this->returnValue($quoteMock));
$quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false));
@@ -231,9 +231,12 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock->expects($this->once())->method('setShippingAddress')->with($this->quoteAddressMock);
$quoteMock->expects($this->once())->method('setDataChanges')->with(true);
- $quoteMock->expects($this->once())->method('save')->willThrowException(
- new \Exception('Some DB Error')
- );
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('save')
+ ->with($quoteMock)
+ ->willThrowException(
+ new \Exception('Some DB Error')
+ );
$this->service->setAddress('cart867', $addressData);
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/ReadServiceTest.php
index 2826c83b4fd32e1a4fe791773f72bacaebbe7645..cf76e89ff5d0f8fb844f4ccbac7dde4b33d37889 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/ReadServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/ReadServiceTest.php
@@ -95,7 +95,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
public function testGetCart()
{
$cartId = 12;
- $this->quoteRepositoryMock->expects($this->once())->method('get')->with($cartId)
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->cartMapperMock->expects($this->once())->method('map')->with($this->quoteMock);
@@ -106,7 +106,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
public function testGetCartForCustomer()
{
$customerId = 12;
- $this->quoteRepositoryMock->expects($this->once())->method('getForCustomer')->with($customerId)
+ $this->quoteRepositoryMock->expects($this->once())->method('getActiveForCustomer')->with($customerId)
->will($this->returnValue($this->quoteMock));
$this->cartMapperMock->expects($this->once())->method('map')->with($this->quoteMock);
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/TotalsServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/TotalsServiceTest.php
index 0bd9ceba8a7b60e5a43e736a371a3c149a2d7900..36dcd74ac4d31bd9eb0d9c3f71072af7cf1d9cea 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/TotalsServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/TotalsServiceTest.php
@@ -89,7 +89,7 @@ class TotalsServiceTest extends \PHPUnit_Framework_TestCase
public function testGetTotals()
{
$cartId = 12;
- $this->quoteRepositoryMock->expects($this->once())->method('get')->with($cartId)
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->totalsMapperMock->expects($this->once())
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php
index 67477f6f83b466387417b53ae5742a6228986b84..0ddb3c3b133452107f74a15a58d0780287b99d47 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php
@@ -40,11 +40,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
*/
protected $objectManager;
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject
- */
- protected $quoteFactoryMock;
-
/**
* @var \PHPUnit_Framework_MockObject_MockObject
*/
@@ -83,9 +78,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
$this->objectManager = new ObjectManager($this);
- $this->quoteFactoryMock = $this->getMock(
- '\Magento\Sales\Model\QuoteFactory', ['create', '__wakeup'], [], '', false
- );
$this->storeManagerMock = $this->getMock('\Magento\Framework\StoreManagerInterface');
$this->quoteRepositoryMock = $this->getMock('\Magento\Sales\Model\QuoteRepository', [], [], '', false);
$this->userContextMock = $this->getMock('\Magento\Authorization\Model\UserContextInterface');
@@ -95,8 +87,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->getMock('\Magento\Sales\Model\Quote',
[
'setStoreId',
- 'save',
- 'load',
'getId',
'getStoreId',
'getCustomerId',
@@ -118,7 +108,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->service = $this->objectManager->getObject(
'\Magento\Checkout\Service\V1\Cart\WriteService',
[
- 'quoteFactory' => $this->quoteFactoryMock,
'storeManager' => $this->storeManagerMock,
'customerRegistry' => $this->customerRegistryMock,
'quoteRepository' => $this->quoteRepositoryMock,
@@ -137,9 +126,9 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
$this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId));
- $this->quoteFactoryMock->expects($this->once())->method('create')->will($this->returnValue($this->quoteMock));
+ $this->quoteRepositoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
$this->quoteMock->expects($this->once())->method('setStoreId')->with($storeId);
- $this->quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->quoteMock->expects($this->once())->method('getId')->willReturn(100);
$this->assertEquals(100, $this->service->create());
}
@@ -159,13 +148,12 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->userContextMock->expects($this->once())->method('getUserType')
->willReturn(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_CUSTOMER);
- $this->userContextMock->expects($this->once())->method('getUserId')->willReturn($userId);
+ $this->userContextMock->expects($this->exactly(2))->method('getUserId')->willReturn($userId);
$this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
$this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId));
$customerQuoteMock = $this->getMock('\Magento\Sales\Model\Quote',
[
- 'loadByCustomer',
'getIsActive',
'getId',
'__wakeup'
@@ -174,14 +162,11 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $customerQuoteMock->expects($this->once())
- ->method('loadByCustomer')
- ->with($customerMock)
- ->will($this->returnSelf());
- $this->quoteFactoryMock->expects($this->once())->method('create')->willReturn($customerQuoteMock);
- $customerQuoteMock->expects($this->once())->method('getId')->willReturn(1);
- $customerQuoteMock->expects($this->once())->method('getIsActive')->willReturn(true);
- $this->quoteMock->expects($this->never())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('getActiveForCustomer')
+ ->with($userId)
+ ->willReturn($customerQuoteMock);
+ $this->quoteRepositoryMock->expects($this->never())->method('save')->with($this->quoteMock);
$this->service->create();
}
@@ -197,7 +182,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->userContextMock->expects($this->once())->method('getUserType')
->willReturn(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_CUSTOMER);
- $this->userContextMock->expects($this->once())->method('getUserId')->willReturn($userId);
+ $this->userContextMock->expects($this->exactly(2))->method('getUserId')->willReturn($userId);
$this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
$this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId));
@@ -212,19 +197,16 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $customerQuoteMock->expects($this->once())
- ->method('loadByCustomer')
- ->with($customerMock)
- ->will($this->returnSelf());
- $this->quoteFactoryMock->expects($this->at(0))->method('create')->willReturn($customerQuoteMock);
- $this->quoteFactoryMock->expects($this->at(1))->method('create')->willReturn($this->quoteMock);
- $customerQuoteMock->expects($this->once())->method('getId')->willReturn(1);
- $customerQuoteMock->expects($this->once())->method('getIsActive')->willReturn(false);
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('getActiveForCustomer')
+ ->with($userId)
+ ->willThrowException(new \Magento\Framework\Exception\NoSuchEntityException());
+ $this->quoteRepositoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
$this->quoteMock->expects($this->once())->method('setStoreId')->with($storeId);
$this->quoteMock->expects($this->once())->method('setCustomer')->with($customerMock);
$this->quoteMock->expects($this->once())->method('setCustomerIsGuest')->with(0);
- $this->quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->quoteMock->expects($this->once())->method('getId')->willReturn(100);
$this->assertEquals(100, $this->service->create());
}
@@ -240,10 +222,14 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
$this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId));
- $this->quoteFactoryMock->expects($this->once())->method('create')->will($this->returnValue($this->quoteMock));
+ $this->quoteRepositoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
$this->quoteMock->expects($this->once())->method('setStoreId')->with($storeId);
- $this->quoteMock->expects($this->once())->method('save')
- ->will($this->throwException(new CouldNotSaveException('Cannot create quote')));
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('save')
+ ->with($this->quoteMock)
+ ->willThrowException(
+ new CouldNotSaveException('Cannot create quote')
+ );
$this->service->create();
}
@@ -260,7 +246,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
$this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId));
- $this->quoteRepositoryMock->expects($this->once())->method('get')->with($cartId)
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)
->will($this->returnValue($this->quoteMock));
$customerMock = $this->getMock('\Magento\Customer\Model\Customer', [], [], '', false);
$this->customerRegistryMock->expects($this->once())
@@ -280,7 +266,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$customerId = 125;
$storeId = 12;
- $this->quoteRepositoryMock->expects($this->once())->method('get')->with($cartId)
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
$this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId));
@@ -307,7 +293,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
$this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$customerMock = $this->getMock('\Magento\Customer\Model\Customer', [], [], '', false);
$this->customerRegistryMock->expects($this->once())
@@ -316,10 +302,10 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->quoteMock->expects($this->once())->method('getCustomerId')->will($this->returnValue(null));
$customerQuoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
- $customerQuoteMock->expects($this->once())->method('loadByCustomer')->with($customerMock)
- ->will($this->returnSelf());
- $customerQuoteMock->expects($this->once())->method('getId')->will($this->returnValue(1));
- $this->quoteFactoryMock->expects($this->once())->method('create')->will($this->returnValue($customerQuoteMock));
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('getForCustomer')
+ ->with($customerId)
+ ->will($this->returnValue($customerQuoteMock));
$this->quoteMock->expects($this->never())->method('setCustomer');
@@ -334,16 +320,16 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
$this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId));
- $this->quoteRepositoryMock->expects($this->once())->method('get')->with($cartId)
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)
->will($this->returnValue($this->quoteMock));
$customerMock = $this->getMock('\Magento\Customer\Model\Customer', [], [], '', false);
$this->customerRegistryMock->expects($this->once())
->method('retrieve')->with($customerId)->will($this->returnValue($customerMock));
- $customerQuoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
- $customerQuoteMock->expects($this->once())->method('loadByCustomer')->with($customerMock)
- ->will($this->returnSelf());
- $this->quoteFactoryMock->expects($this->once())->method('create')->will($this->returnValue($customerQuoteMock));
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('getForCustomer')
+ ->with($customerId)
+ ->willThrowException(new \Magento\Framework\Exception\NoSuchEntityException());
$customerMock->expects($this->once())->method('getSharedStoreIds')->will($this->returnValue([$storeId]));
$this->quoteMock->expects($this->once())->method('getCustomerId')->will($this->returnValue(false));
@@ -351,7 +337,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
->method('setCustomer')->with($customerMock)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('setCustomerIsGuest')->with(0)->will($this->returnValue($this->quoteMock));
- $this->quoteMock->expects($this->once())->method('save')->will($this->returnValue($this->quoteMock));
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->assertTrue($this->service->assignCustomer($cartId, $customerId));
}
@@ -360,7 +346,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
{
$cartId = 123;
$quoteService = $this->getMock('Magento\Sales\Model\Service\Quote', [], [], '', false);
- $this->quoteRepositoryMock->expects($this->once())->method('get')->with($cartId)
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->quoteServiceFactory->expects($this->once())->method('create')->with(['quote' => $this->quoteMock])
->will($this->returnValue($quoteService));
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/ReadServiceTest.php
index 96564334b58bd10dee44cfde928547645e8ce1bb..63bf035053b300f4cd0bf2f7b79fb9f1ce4cbf62 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/ReadServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/ReadServiceTest.php
@@ -69,7 +69,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock->expects($this->any())->method('getCouponCode')->will($this->returnValue($couponCode));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($quoteMock));
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/WriteServiceTest.php
index 3052a61480bcdb79882cab3711d5c4adf97bf916..ea4f2c590c920b3b644182aab4ff0c7697fadc95 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/WriteServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/WriteServiceTest.php
@@ -113,7 +113,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 33;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(0));
$this->service->set($cartId, $this->couponCodeDataMock);
@@ -129,7 +129,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$couponCode = '153a-ABC';
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(12));
$this->quoteMock->expects($this->once())
->method('getShippingAddress')->will($this->returnValue($this->quoteAddressMock));
@@ -140,7 +140,10 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$exceptionMessage = 'Could not apply coupon code';
$exception = new \Magento\Framework\Exception\CouldNotDeleteException($exceptionMessage);
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
- $this->quoteMock->expects($this->once())->method('save')->will($this->throwException($exception));
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('save')
+ ->with($this->quoteMock)
+ ->willThrowException($exception);
$this->service->set($cartId, $this->couponCodeDataMock);
}
@@ -155,7 +158,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$couponCode = '153a-ABC';
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(12));
$this->quoteMock->expects($this->once())
->method('getShippingAddress')->will($this->returnValue($this->quoteAddressMock));
@@ -164,7 +167,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
->method('getCouponCode')->will($this->returnValue($couponCode));
$this->quoteMock->expects($this->once())->method('setCouponCode')->with($couponCode);
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
- $this->quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->quoteMock->expects($this->once())->method('getCouponCode')->will($this->returnValue('invalidCoupon'));
$this->service->set($cartId, $this->couponCodeDataMock);
@@ -176,7 +179,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$couponCode = '153a-ABC';
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(12));
$this->quoteMock->expects($this->once())
->method('getShippingAddress')->will($this->returnValue($this->quoteAddressMock));
@@ -185,7 +188,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
->method('getCouponCode')->will($this->returnValue($couponCode));
$this->quoteMock->expects($this->once())->method('setCouponCode')->with($couponCode);
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
- $this->quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->quoteMock->expects($this->once())->method('getCouponCode')->will($this->returnValue($couponCode));
$this->assertTrue($this->service->set($cartId, $this->couponCodeDataMock));
@@ -200,7 +203,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 65;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(0));
$this->quoteMock->expects($this->never())->method('getShippingAddress');
@@ -216,7 +219,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 65;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(12));
$this->quoteMock->expects($this->once())
->method('getShippingAddress')->will($this->returnValue($this->quoteAddressMock));
@@ -226,7 +229,10 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$exceptionMessage = 'Could not delete coupon code';
$exception = new \Magento\Framework\Exception\CouldNotSaveException($exceptionMessage);
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
- $this->quoteMock->expects($this->once())->method('save')->will($this->throwException($exception));
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('save')
+ ->with($this->quoteMock)
+ ->willThrowException($exception);
$this->service->delete($cartId);
}
@@ -240,7 +246,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 65;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(12));
$this->quoteMock->expects($this->once())
->method('getShippingAddress')->will($this->returnValue($this->quoteAddressMock));
@@ -248,7 +254,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->quoteMock->expects($this->once())->method('setCouponCode')->with('');
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
- $this->quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->quoteMock->expects($this->once())->method('getCouponCode')->will($this->returnValue('123_ABC'));
$this->service->delete($cartId);
@@ -259,7 +265,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 65;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(12));
$this->quoteMock->expects($this->once())
->method('getShippingAddress')->will($this->returnValue($this->quoteAddressMock));
@@ -267,7 +273,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->quoteMock->expects($this->once())->method('setCouponCode')->with('');
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
- $this->quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->quoteMock->expects($this->once())->method('getCouponCode')->will($this->returnValue(''));
$this->assertTrue($this->service->delete($cartId));
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/ReaderServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/ReaderServiceTest.php
index bd724ce2fc82a4f07aa5ec548f164d9016bde613..3b7a033db865133aa4389b728ce349c6fe81253b 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/ReaderServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/ReaderServiceTest.php
@@ -55,7 +55,7 @@ class ReaderServiceTest extends \PHPUnit_Framework_TestCase
public function testGetList()
{
$quoteMock = $this->getMock('Magento\Sales\Model\Quote', [], [], '', false);
- $this->quoteRepositoryMock->expects($this->once())->method('get')
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')
->with(33)
->will($this->returnValue($quoteMock));
$itemMock = $this->getMock('\Magento\Sales\Model\Quote\Item',
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/WriteServiceTest.php
index 5b9c3d5312478dd5cd289b95f357a3ab5d112829..bbd57bbaaa14af88a7d7e8a804e95ad2ee7b38ca 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/WriteServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/WriteServiceTest.php
@@ -112,7 +112,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
{
$cartId = 13;
$this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue(12));
- $this->quoteRepositoryMock->expects($this->once())->method('get')
+ $this->quoteRepositoryMock->expects($this->once())->method('getActive')
->with($cartId)->will($this->returnValue($this->quoteMock));
$this->dataMock->expects($this->once())->method('getSku')->will($this->returnValue('product_sku'));
$this->productLoaderMock->expects($this->once())
@@ -121,7 +121,10 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
$exceptionMessage = 'Could not add item to quote';
$exception = new \Magento\Framework\Exception\CouldNotSaveException($exceptionMessage);
- $this->quoteMock->expects($this->once())->method('save')->will($this->throwException($exception));
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('save')
+ ->with($this->quoteMock)
+ ->willThrowException($exception);
$this->service->addItem($cartId, $this->dataMock);
}
@@ -131,12 +134,12 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 13;
$this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue(12));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->productLoaderMock->expects($this->once())->method('load')->will($this->returnValue($this->productMock));
$this->dataMock->expects($this->once())->method('getSku');
$this->quoteMock->expects($this->once())->method('addProduct')->with($this->productMock, 12);
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
- $this->quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->quoteMock
->expects($this->once())
->method('getItemByProduct')
@@ -183,7 +186,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$itemId = 5;
$this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue(12));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('getItemById')->with($itemId)->will($this->returnValue(false));
$this->quoteItemMock->expects($this->never())->method('setData');
@@ -201,14 +204,17 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$itemId = 5;
$this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue(12));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('getItemById')->with($itemId)->will($this->returnValue($this->quoteItemMock));
$this->quoteItemMock->expects($this->once())->method('setData')->with('qty', 12);
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
$exceptionMessage = 'Could not update quote item';
$exception = new \Magento\Framework\Exception\CouldNotSaveException($exceptionMessage);
- $this->quoteMock->expects($this->once())->method('save')->will($this->throwException($exception));
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('save')
+ ->with($this->quoteMock)
+ ->willThrowException($exception);
$this->service->updateItem($cartId, $itemId, $this->dataMock);
}
@@ -219,12 +225,12 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$itemId = 5;
$this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue(12));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('getItemById')->with($itemId)->will($this->returnValue($this->quoteItemMock));
$this->quoteItemMock->expects($this->once())->method('setData')->with('qty', 12);
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
- $this->quoteMock->expects($this->once())->method('save')->will($this->returnValue($this->quoteMock));
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->assertTrue($this->service->updateItem($cartId, $itemId, $this->dataMock));
}
@@ -238,7 +244,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 11;
$itemId = 5;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('getItemById')->with($itemId)->will($this->returnValue(false));
$this->quoteMock->expects($this->never())->method('removeItem');
@@ -255,7 +261,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 11;
$itemId = 5;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('getItemById')->with($itemId)->will($this->returnValue($this->quoteItemMock));
$this->quoteMock->expects($this->once())
@@ -263,7 +269,10 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
$exceptionMessage = 'Could not remove item from quote';
$exception = new \Magento\Framework\Exception\CouldNotSaveException($exceptionMessage);
- $this->quoteMock->expects($this->once())->method('save')->will($this->throwException($exception));
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('save')
+ ->with($this->quoteMock)
+ ->willThrowException($exception);
$this->service->removeItem($cartId, $itemId, $this->dataMock);
}
@@ -273,12 +282,12 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 11;
$itemId = 5;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('getItemById')->with($itemId)->will($this->returnValue($this->quoteItemMock));
$this->quoteMock->expects($this->once())->method('removeItem');
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
- $this->quoteMock->expects($this->once())->method('save')->will($this->returnValue($this->quoteMock));
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->assertTrue($this->service->removeItem($cartId, $itemId, $this->dataMock));
}
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceTest.php
index a6a4935947fd88d31b13fe5f418e45f35e9781cd..daf6c660411f6df68174e7e42020531716935df6 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceTest.php
@@ -88,7 +88,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
$paymentMock->expects($this->once())->method('getId')->will($this->returnValue(null));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($quoteMock));
@@ -106,7 +106,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($quoteMock));
@@ -126,7 +126,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock = $this->getMock('\Magento\Sales\Model\Quote', [], [], '', false);
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($quoteMock));
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceTest.php
index 5c55444d16b122c461660fd12c2be9210e193f54..f9580965be01e9487c6d54c67f80c16f6f0eda9c 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceTest.php
@@ -100,7 +100,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock->expects($this->any())->method('getBillingAddress')->will($this->returnValue($billingAddressMock));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($quoteMock));
@@ -149,7 +149,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($quoteMock));
@@ -210,7 +210,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock->expects($this->never())->method('getPayment');
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($quoteMock));
@@ -251,7 +251,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
->will($this->returnValue($this->getMock('\Magento\Sales\Model\Quote\Address', [], [], '', false)));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($quoteMock));
@@ -308,7 +308,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock));
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($quoteMock));
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceTest.php
index 4ce1ee8c402b70d2eb936aa606372022fb87f705..f8ecaee7506c243aa2b8fe473a30b7ecf448801f 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceTest.php
@@ -132,7 +132,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
{
$cartId = 666;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock));
$this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(null));
@@ -148,7 +148,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
{
$cartId = 884;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock));
$this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(34));
@@ -164,7 +164,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 666;
$countryId = 1;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock));
$this->shippingAddressMock->expects($this->any())
@@ -199,7 +199,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
$countryId = 1;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock));
$this->shippingAddressMock->expects($this->any())
@@ -214,7 +214,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
{
$cartId = 834;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('isVirtual')->will($this->returnValue(true));
@@ -225,7 +225,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
{
$cartId = 834;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('isVirtual')->will($this->returnValue(false));
$this->quoteMock->expects($this->once())
@@ -242,7 +242,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
{
$cartId = 834;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('isVirtual')->will($this->returnValue(false));
$this->quoteMock->expects($this->once())
@@ -258,7 +258,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
{
$cartId = 834;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())
->method('isVirtual')->will($this->returnValue(false));
$this->quoteMock->expects($this->once())
diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceTest.php
index 910da9ef2cbb1f199c816abd8e1df164e35a8845..550aa2d79a6904596c9d248a861056236267f818 100644
--- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceTest.php
@@ -106,7 +106,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$carrierCode = 34;
$methodCode = 56;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(0));
$this->quoteMock->expects($this->never())->method('isVirtual');
@@ -124,7 +124,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$methodCode = 56;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
$this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(true));
@@ -141,7 +141,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$carrierCode = 34;
$methodCode = 56;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
$this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false));
$this->quoteMock->expects($this->once())
@@ -163,7 +163,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$countryId = 1;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
$this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false));
$this->quoteMock->expects($this->once())
@@ -195,7 +195,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$methodCode = 56;
$countryId = 1;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
$this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false));
$this->quoteMock->expects($this->once())
@@ -233,7 +233,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$countryId = 1;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
$this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false));
$this->quoteMock->expects($this->once())
@@ -259,7 +259,10 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
->method('requestShippingRates')->will($this->returnValue(true));
$exception = new \Exception('Custom Error');
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnSelf());
- $this->quoteMock->expects($this->once())->method('save')->will($this->throwException($exception));
+ $this->quoteRepositoryMock->expects($this->once())
+ ->method('save')
+ ->with($this->quoteMock)
+ ->willThrowException($exception);
$this->service->setMethod($cartId, $carrierCode, $methodCode);
}
@@ -274,7 +277,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$carrierCode = 34;
$methodCode = 56;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
$this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false));
$this->quoteMock->expects($this->once())
@@ -291,7 +294,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$methodCode = 56;
$countryId = 1;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')->with($cartId)->will($this->returnValue($this->quoteMock));
+ ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
$this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false));
$this->quoteMock->expects($this->once())
@@ -316,7 +319,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$this->shippingAddressMock->expects($this->once())
->method('requestShippingRates')->will($this->returnValue(true));
$this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnSelf());
- $this->quoteMock->expects($this->once())->method('save');
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
$this->assertTrue($this->service->setMethod($cartId, $carrierCode, $methodCode));
}
diff --git a/dev/tests/unit/testsuite/Magento/Cms/Controller/NorouteTest.php b/dev/tests/unit/testsuite/Magento/Cms/Controller/NorouteTest.php
index 0d03f7d24a032ab984bfd8a2640481602efcf9ae..a1e58b0b955f2628cfef952c0a71656d6e8b8ee4 100644
--- a/dev/tests/unit/testsuite/Magento/Cms/Controller/NorouteTest.php
+++ b/dev/tests/unit/testsuite/Magento/Cms/Controller/NorouteTest.php
@@ -43,7 +43,7 @@ class NorouteTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
$helper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$responseMock = $this->getMock('Magento\Framework\App\Response\Http', array(), array(), '', false);
$responseMock->expects(
$this->at(0)
diff --git a/dev/tests/unit/testsuite/Magento/Cms/Model/Config/Source/PageTest.php b/dev/tests/unit/testsuite/Magento/Cms/Model/Config/Source/PageTest.php
index 60b841eb6d4c497b47b9d93cf4ab853980033f22..bfc7df0266cbb9487efffb4c8c0d05a94ba73ed2 100644
--- a/dev/tests/unit/testsuite/Magento/Cms/Model/Config/Source/PageTest.php
+++ b/dev/tests/unit/testsuite/Magento/Cms/Model/Config/Source/PageTest.php
@@ -24,75 +24,96 @@
namespace Magento\Cms\Model\Config\Source;
/**
- * @covers \Magento\Cms\Model\Config\Source\Page
+ * Class PageTest
*/
class PageTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Cms\Model\Config\Source\Page
+ * @var \Magento\Cms\Api\PageRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $this;
+ protected $pageRepositoryMock;
/**
- * @var \Magento\Cms\Model\Resource\Page\CollectionFactory|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Cms\Api\PageCriteriaInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $pageCollectionFactory;
+ protected $pageCriteriaFactoryMock;
/**
- * @var \Magento\Cms\Model\Resource\Page\Collection|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Cms\Model\Config\Source\Page
*/
- protected $pageCollection;
+ protected $page;
+ /**
+ * Set up
+ *
+ * @return void
+ */
protected function setUp()
{
- $this->pageCollectionFactory = $this
- ->getMockBuilder('Magento\Cms\Model\Resource\Page\CollectionFactory')
- ->disableOriginalConstructor()
- ->setMethods(
- [
- 'create'
- ]
- )
- ->getMock();
- $this->pageCollection = $this
- ->getMockBuilder('Magento\Cms\Model\Resource\Page\Collection')
- ->disableOriginalConstructor()
- ->getMock();
-
$objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->this = $objectManager->getObject(
+
+ $this->pageRepositoryMock = $this->getMockForAbstractClass(
+ 'Magento\Cms\Api\PageRepositoryInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getList']
+ );
+ $this->pageCriteriaFactoryMock = $this->getMock(
+ 'Magento\Cms\Api\PageCriteriaInterfaceFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+
+ $this->page = $objectManager->getObject(
'Magento\Cms\Model\Config\Source\Page',
[
- 'pageCollectionFactory' => $this->pageCollectionFactory
+ 'pageRepository' => $this->pageRepositoryMock,
+ 'pageCriteriaFactory' => $this->pageCriteriaFactoryMock
]
);
-
- $reflection = new \ReflectionClass($this->this);
- $mathRandomProperty = $reflection->getProperty('_options');
- $mathRandomProperty->setAccessible(true);
- $mathRandomProperty->setValue($this->this, null);
}
/**
- * @covers \Magento\Cms\Model\Config\Source\Page::toOptionArray
+ * Run test toOptionArray method
+ *
+ * @return void
*/
public function testToOptionArray()
{
- $resultOptions = ['val1' => 'val2'];
+ $pageCollectionMock = $this->getMockForAbstractClass(
+ 'Magento\Cms\Api\Data\PageCollectionInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['toOptionIdArray']
+ );
+ $pageCriteriaMock = $this->getMockForAbstractClass(
+ 'Magento\Cms\Api\PageCriteriaInterface',
+ [],
+ '',
+ false
+ );
+
+ $this->pageRepositoryMock->expects($this->once())
+ ->method('getList')
+ ->with($pageCriteriaMock)
+ ->will($this->returnValue($pageCollectionMock));
- $this->pageCollectionFactory
- ->expects($this->atLeastOnce())
+ $this->pageCriteriaFactoryMock->expects($this->once())
->method('create')
- ->willReturn($this->pageCollection);
- $this->pageCollection
- ->expects($this->atLeastOnce())
- ->method('load')
- ->willReturnSelf();
- $this->pageCollection
- ->expects($this->atLeastOnce())
+ ->will($this->returnValue($pageCriteriaMock));
+
+ $pageCollectionMock->expects($this->once())
->method('toOptionIdArray')
- ->willReturn($resultOptions);
+ ->will($this->returnValue('return-value'));
- $this->assertEquals($resultOptions, $this->this->toOptionArray());
+ $this->assertEquals('return-value', $this->page->toOptionArray());
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Cms/Model/DataSource/PageCollectionTest.php b/dev/tests/unit/testsuite/Magento/Cms/Model/DataSource/PageCollectionTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..e3bb75856639ab864acdc72d14c2c8479f782d6e
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Cms/Model/DataSource/PageCollectionTest.php
@@ -0,0 +1,147 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Cms\Model\DataSource;
+
+/**
+ * Class PageCollectionTest
+ */
+class PageCollectionTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Cms\Api\PageCriteriaInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $criteriaMock;
+
+ /**
+ * @var \Magento\Cms\Api\PageRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $repositoryMock;
+
+ /**
+ * @var \Magento\Cms\Model\DataSource\PageCollection
+ */
+ protected $pageCollection;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->criteriaMock = $this->getMockForAbstractClass(
+ 'Magento\Cms\Api\PageCriteriaInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['addStoreFilter', 'addFilter', 'setFirstStoreFlag']
+ );
+ $this->repositoryMock = $this->getMockForAbstractClass(
+ 'Magento\Cms\Api\PageRepositoryInterface',
+ [],
+ '',
+ false
+ );
+
+ $this->criteriaMock->expects($this->once())
+ ->method('setFirstStoreFlag')
+ ->with(true);
+
+ $this->pageCollection = $objectManager->getObject(
+ 'Magento\Cms\Model\DataSource\PageCollection',
+ [
+ 'criteria' => $this->criteriaMock,
+ 'repository' => $this->repositoryMock
+ ]
+ );
+ }
+
+ /**
+ * Run test addFilter method
+ *
+ * @param string $name
+ * @param string $field
+ * @param mixed $condition
+ * @param string $type
+ * @return void
+ *
+ * @dataProvider dataProviderAddFilter
+ */
+ public function testAddFilter($name, $field, $condition, $type)
+ {
+ if ($field === 'store_id') {
+ $this->criteriaMock->expects($this->once())
+ ->method('addStoreFilter')
+ ->with($condition, false);
+ } else {
+ $this->criteriaMock->expects($this->once())
+ ->method('addFilter')
+ ->with($name, $field, $condition, $type);
+ }
+
+ $this->pageCollection->addFilter($name, $field, $condition, $type);
+ }
+
+ /**
+ * Run test getResultCollection method
+ *
+ * @return void
+ */
+ public function testGetResultCollection()
+ {
+ $this->repositoryMock->expects($this->once())
+ ->method('getList')
+ ->with($this->criteriaMock)
+ ->will($this->returnValue('return-value'));
+
+ $this->assertEquals('return-value', $this->pageCollection->getResultCollection());
+ }
+
+ /**
+ * Data provider for addFilter method
+ *
+ * @return array
+ */
+ public function dataProviderAddFilter()
+ {
+ return [
+ [
+ 'name' => 'test-name',
+ 'field' => 'store_id',
+ 'condition' => null,
+ 'type' => 'public'
+ ],
+ [
+ 'name' => 'test-name',
+ 'field' => 'any_field',
+ 'condition' => 10,
+ 'type' => 'private'
+ ]
+ ];
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Cms/Model/PageRepositoryTest.php b/dev/tests/unit/testsuite/Magento/Cms/Model/PageRepositoryTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..7a133e4f8bbeec41b40a75e3eecdd0857edf9d0d
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Cms/Model/PageRepositoryTest.php
@@ -0,0 +1,282 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Cms\Model;
+
+/**
+ * Class PageRepositoryTest
+ */
+class PageRepositoryTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Cms\Model\Resource\Page|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $resourceMock;
+
+ /**
+ * @var \Magento\Cms\Api\Data\PageInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $pageFactoryMock;
+
+ /**
+ * @var \Magento\Cms\Api\Data\PageCollectionInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $pageCollectionFactoryMock;
+
+ /**
+ * @var \Magento\Framework\DB\QueryBuilderFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $queryBuilderFactoryMock;
+
+ /**
+ * @var \Magento\Framework\DB\MapperFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $mapperFactoryMock;
+
+ /**
+ * @var \Magento\Cms\Model\PageRepository
+ */
+ protected $pageRepository;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->resourceMock = $this->getMock(
+ 'Magento\Cms\Model\Resource\Page',
+ ['save', 'load', 'delete'],
+ [],
+ '',
+ false
+ );
+ $this->pageFactoryMock = $this->getMock(
+ 'Magento\Cms\Api\Data\PageInterfaceFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+ $this->pageCollectionFactoryMock = $this->getMock(
+ 'Magento\Cms\Api\Data\PageCollectionInterfaceFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+ $this->queryBuilderFactoryMock = $this->getMock(
+ 'Magento\Framework\DB\QueryBuilderFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+ $this->mapperFactoryMock = $this->getMock(
+ 'Magento\Framework\DB\MapperFactory',
+ [],
+ [],
+ '',
+ false
+ );
+
+ $this->pageRepository = $objectManager->getObject(
+ 'Magento\Cms\Model\PageRepository',
+ [
+ 'resource' => $this->resourceMock,
+ 'pageFactory' => $this->pageFactoryMock,
+ 'pageCollectionFactory' => $this->pageCollectionFactoryMock,
+ 'queryBuilderFactory' => $this->queryBuilderFactoryMock,
+ 'mapperFactory' => $this->mapperFactoryMock
+ ]
+ );
+ }
+
+ /**
+ * Run test save method
+ *
+ * @return void
+ */
+ public function testSave()
+ {
+ $pageMock = $this->getMock(
+ 'Magento\Cms\Model\Page',
+ [],
+ [],
+ '',
+ false
+ );
+
+ $this->resourceMock->expects($this->once())
+ ->method('save')
+ ->with($pageMock);
+
+ $this->assertEquals($pageMock, $this->pageRepository->save($pageMock));
+ }
+
+ /**
+ * Run test get method
+ *
+ * @return void
+ */
+ public function testGet()
+ {
+ $id = 20;
+ $pageMock = $this->getMockForAbstractClass(
+ 'Magento\Cms\Model\Page',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getPageId']
+ );
+
+ $this->pageFactoryMock->expects($this->once())
+ ->method('create')
+ ->will($this->returnValue($pageMock));
+ $this->resourceMock->expects($this->once())
+ ->method('load')
+ ->with($pageMock, $id);
+ $pageMock->expects($this->once())
+ ->method('getPageId')
+ ->will($this->returnValue($id));
+
+ $this->assertEquals($pageMock, $this->pageRepository->get($id));
+ }
+
+ /**
+ * Run test getList method
+ *
+ * @return void
+ */
+ public function testGetList()
+ {
+ $criteriaMock = $this->getMockForAbstractClass(
+ 'Magento\Cms\Api\PageCriteriaInterface',
+ [],
+ '',
+ false
+ );
+ $queryBuilderMock = $this->getMock(
+ 'Magento\Framework\DB\QueryBuilder',
+ ['setCriteria', 'setResource', 'create'],
+ [],
+ '',
+ false
+ );
+ $queryMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\DB\QueryInterface',
+ [],
+ '',
+ false
+ );
+ $collectionMock = $this->getMock(
+ 'Magento\Cms\Api\Data\PageCollectionInterface',
+ [],
+ [],
+ '',
+ false
+ );
+
+ $this->queryBuilderFactoryMock->expects($this->once())
+ ->method('create')
+ ->will($this->returnValue($queryBuilderMock));
+ $queryBuilderMock->expects($this->once())
+ ->method('setCriteria')
+ ->with($criteriaMock);
+ $queryBuilderMock->expects($this->once())
+ ->method('setResource')
+ ->with($this->resourceMock);
+ $queryBuilderMock->expects($this->once())
+ ->method('create')
+ ->will($this->returnValue($queryMock));
+ $this->pageCollectionFactoryMock->expects($this->once())
+ ->method('create')
+ ->with(['query' => $queryMock])
+ ->will($this->returnValue($collectionMock));
+
+ $this->assertEquals($collectionMock, $this->pageRepository->getList($criteriaMock));
+ }
+
+ /**
+ * Run test delete method
+ *
+ * @return void
+ */
+ public function testDelete()
+ {
+ $pageMock = $this->getMockForAbstractClass(
+ 'Magento\Cms\Model\Page',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getPageId']
+ );
+
+ $this->resourceMock->expects($this->once())
+ ->method('delete')
+ ->with($pageMock);
+
+ $this->assertTrue($this->pageRepository->delete($pageMock));
+ }
+
+ /**
+ * Run test deleteById method
+ *
+ * @return void
+ */
+ public function testDeleteById()
+ {
+ $id = 20;
+ $pageMock = $this->getMockForAbstractClass(
+ 'Magento\Cms\Model\Page',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getPageId']
+ );
+
+ $this->pageFactoryMock->expects($this->once())
+ ->method('create')
+ ->will($this->returnValue($pageMock));
+ $this->resourceMock->expects($this->once())
+ ->method('load')
+ ->with($pageMock, $id);
+ $pageMock->expects($this->once())
+ ->method('getPageId')
+ ->will($this->returnValue($id));
+ $this->resourceMock->expects($this->once())
+ ->method('delete')
+ ->with($pageMock);
+
+ $this->assertTrue($this->pageRepository->deleteById($id));
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Cms/Model/Resource/Page/CollectionTest.php b/dev/tests/unit/testsuite/Magento/Cms/Model/Resource/Page/CollectionTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..730bc3c91b6f1b074071fbfbdb1a620de57d1a97
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Cms/Model/Resource/Page/CollectionTest.php
@@ -0,0 +1,310 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Cms\Model\Resource\Page;
+
+/**
+ * Class CollectionTest
+ */
+class CollectionTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Framework\StoreManagerInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $storeManagerMock;
+
+ /**
+ * @var \Magento\Framework\DB\QueryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $queryMock;
+
+ /**
+ * @var \Magento\Framework\Event\ManagerInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $eventManagerMock;
+
+ /**
+ * @var \Magento\Framework\Data\Collection\EntityFactoryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $entityFactoryMock;
+
+ /**
+ * @var \Magento\Framework\Data\SearchResultIteratorFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $resultIteratorFactoryMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $searchResultProcessorMock;
+
+ /**
+ * @var \Magento\Cms\Model\Resource\Page\Collection
+ */
+ protected $collection;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->queryMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\DB\QueryInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['fetchAll', 'getIdFieldName', 'getConnection', 'getResource']
+ );
+ $this->entityFactoryMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Data\Collection\EntityFactoryInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ []
+ );
+ $this->eventManagerMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Event\ManagerInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['dispatch']
+ );
+ $this->resultIteratorFactoryMock = $this->getMock(
+ 'Magento\Framework\Data\SearchResultIteratorFactory',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->searchResultProcessorMock = $this->getMock(
+ 'Magento\Framework\Data\SearchResultProcessor',
+ [],
+ [],
+ '',
+ false
+ );
+ $searchResultProcessorFactoryMock = $this->getMock(
+ 'Magento\Framework\Data\SearchResultProcessorFactory',
+ [],
+ [],
+ '',
+ false
+ );
+ $searchResultProcessorFactoryMock->expects($this->any())
+ ->method('create')
+ ->withAnyParameters()
+ ->willReturn($this->searchResultProcessorMock);
+ $this->storeManagerMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\StoreManagerInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getStore']
+ );
+
+ $this->collection = $objectManager->getObject(
+ 'Magento\Cms\Model\Resource\Page\Collection',
+ [
+ 'query' => $this->queryMock,
+ 'entityFactory' => $this->entityFactoryMock,
+ 'eventManager' => $this->eventManagerMock,
+ 'resultIteratorFactory' => $this->resultIteratorFactoryMock,
+ 'storeManager' => $this->storeManagerMock,
+ 'searchResultProcessorFactory' => $searchResultProcessorFactoryMock
+ ]
+ );
+ }
+
+ /**
+ * Run test toOptionIdArray method
+ *
+ * @return void
+ */
+ public function testToOptionIdArray()
+ {
+ $itemsByPageId = array_fill(0, 4, 123);
+ $data = [
+ 'item1' => ['test' => 'test'],
+ 'item2' => ['test' => 'test'],
+ 'item3' => ['test' => 'test'],
+ 'item4' => ['test' => 'test'],
+ ];
+
+ $objectMock = $this->getMock(
+ 'Magento\Framework\Object',
+ ['getData', 'getPageId', 'setData', 'getTitle', 'getIdentifier'],
+ [],
+ '',
+ false
+ );
+ $criteriaMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Api\CriteriaInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getPart']
+ );
+ $connectionMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\DB\Adapter\AdapterInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['fetchPairs', 'select']
+ );
+ $resourceMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Model\Resource\Db\AbstractDb',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getTable']
+ );
+ $selectMock = $this->getMock(
+ 'Magento\Framework\DB\Select',
+ ['from', 'where'],
+ [],
+ '',
+ false
+ );
+ $storeMock = $this->getMock(
+ 'Magento\Store\Model\Store',
+ ['getCode'],
+ [],
+ '',
+ false
+ );
+
+ $this->queryMock->expects($this->once())
+ ->method('fetchAll')
+ ->will($this->returnValue($data));
+
+ $this->searchResultProcessorMock->expects($this->once())
+ ->method('getColumnValues')
+ ->with('page_id')
+ ->will($this->returnValue($itemsByPageId));
+ $this->queryMock->expects($this->any())
+ ->method('getIdFieldName')
+ ->will($this->returnValue('id_field_name'));
+ $objectMock->expects($this->any())
+ ->method('getData')
+ ->will(
+ $this->returnValueMap(
+ [
+ ['id_field_name', null, null],
+ ['page_id', null, 123]
+ ]
+ )
+ );
+ $this->entityFactoryMock->expects($this->any())
+ ->method('create')
+ ->with('Magento\Cms\Api\Data\PageInterface', ['data' => ['test' => 'test']])
+ ->will($this->returnValue($objectMock));
+ $this->queryMock->expects($this->once())
+ ->method('getCriteria')
+ ->will($this->returnValue($criteriaMock));
+ $criteriaMock->expects($this->once())
+ ->method('getPart')
+ ->with('first_store_flag')
+ ->will($this->returnValue(true));
+ $this->queryMock->expects($this->once())
+ ->method('getConnection')
+ ->will($this->returnValue($connectionMock));
+ $this->queryMock->expects($this->once())
+ ->method('getResource')
+ ->will($this->returnValue($resourceMock));
+ $connectionMock->expects($this->once())
+ ->method('select')
+ ->will($this->returnValue($selectMock));
+ $selectMock->expects($this->once())
+ ->method('from')
+ ->with(['cps' => 'query_table'])
+ ->will($this->returnSelf());
+ $resourceMock->expects($this->once())
+ ->method('getTable')
+ ->with('cms_page_store')
+ ->will($this->returnValue('query_table'));
+ $selectMock->expects($this->once())
+ ->method('where')
+ ->with('cps.page_id IN (?)', array_fill(0, 4, 123))
+ ->will($this->returnSelf());
+ $connectionMock->expects($this->once())
+ ->method('fetchPairs')
+ ->with($selectMock)
+ ->will($this->returnValue([123 => 999]));
+ $objectMock->expects($this->any())
+ ->method('getPageId')
+ ->will($this->returnValue(123));
+ $this->storeManagerMock->expects($this->any())
+ ->method('getStore')
+ ->with(999)
+ ->will($this->returnValue($storeMock));
+ $storeMock->expects($this->any())
+ ->method('getCode')
+ ->will($this->returnValue('store_code'));
+ $objectMock->expects($this->any())
+ ->method('setData');
+ $objectMock->expects($this->any())
+ ->method('getTitle')
+ ->will($this->returnValue('item-value'));
+ $objectMock->expects($this->any())
+ ->method('getIdentifier')
+ ->will($this->returnValue('identifier-value'));
+
+ $expected = [
+ [
+ 'value' => 'identifier-value',
+ 'label' => 'item-value'
+ ],
+ [
+ 'value' => 'identifier-value|123',
+ 'label' => 'item-value'
+ ],
+ [
+ 'value' => 'identifier-value|123',
+ 'label' => 'item-value'
+ ],
+ [
+ 'value' => 'identifier-value|123',
+ 'label' => 'item-value'
+ ]
+ ];
+ $this->assertEquals($expected, $this->collection->toOptionIdArray());
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Cms/Model/Resource/PageCriteriaMapperTest.php b/dev/tests/unit/testsuite/Magento/Cms/Model/Resource/PageCriteriaMapperTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..0b0b2c4334256afb4bb560e4018b8c48293b625e
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Cms/Model/Resource/PageCriteriaMapperTest.php
@@ -0,0 +1,151 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Cms\Model\Resource;
+
+/**
+ * Class PageCriteriaMapperTest
+ */
+class PageCriteriaMapperTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Framework\Logger|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $loggerMock;
+
+ /**
+ * @var \Magento\Framework\Data\Collection\Db\FetchStrategyInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $fetchStrategyMock;
+
+ /**
+ * @var \Magento\Framework\Data\ObjectFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $objectFactoryMock;
+
+ /**
+ * @var \Magento\Framework\DB\MapperFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $mapperFactoryMock;
+
+ /**
+ * @var \Magento\Framework\DB\Select|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $selectMock;
+
+ /**
+ * @var \Magento\Cms\Model\Resource\PageCriteriaMapper|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $pageCriteria;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $this->loggerMock = $this->getMock(
+ 'Magento\Framework\Logger',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->fetchStrategyMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Data\Collection\Db\FetchStrategyInterface',
+ [],
+ '',
+ false
+ );
+ $this->objectFactoryMock = $this->getMock(
+ 'Magento\Framework\Data\ObjectFactory',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->mapperFactoryMock = $this->getMock(
+ 'Magento\Framework\DB\MapperFactory',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->selectMock = $this->getMock(
+ 'Magento\Framework\DB\Select',
+ ['join', 'group', 'where'],
+ [],
+ '',
+ false
+ );
+
+ $this->pageCriteria = $this->getMockBuilder('Magento\Cms\Model\Resource\PageCriteriaMapper')
+ ->setConstructorArgs(
+ [
+ 'logger' => $this->loggerMock,
+ 'fetchStrategy' => $this->fetchStrategyMock,
+ 'objectFactory' => $this->objectFactoryMock,
+ 'mapperFactory' => $this->mapperFactoryMock,
+ 'select' => $this->selectMock
+ ]
+ )->setMethods(['init', 'getTable', 'getMappedField', 'getConditionSql'])
+ ->getMock();
+ }
+
+ /**
+ * Run test mapStoreFilter method
+ *
+ * @return void
+ */
+ public function testMapStoreFilter()
+ {
+ $this->pageCriteria->expects($this->once())
+ ->method('getTable')
+ ->with('cms_page_store')
+ ->will($this->returnValue('table-name'));
+ $this->pageCriteria->expects($this->once())
+ ->method('getMappedField')
+ ->with('store')
+ ->will($this->returnValue('mapped-field-result'));
+ $this->selectMock->expects($this->once())
+ ->method('join')
+ ->with(
+ ['store_table' => 'table-name'],
+ 'main_table.page_id = store_table.page_id',
+ []
+ )->will($this->returnSelf());
+ $this->selectMock->expects($this->once())
+ ->method('group')
+ ->with('main_table.page_id');
+ $this->pageCriteria->expects($this->once())
+ ->method('getConditionSql')
+ ->with('mapped-field-result', ['in' => [1]])
+ ->will($this->returnValue('condition-sql-result'));
+ $this->selectMock->expects($this->once())
+ ->method('where')
+ ->with('condition-sql-result', null, \Magento\Framework\DB\Select::TYPE_CONDITION);
+
+ $this->pageCriteria->mapStoreFilter(1, false);
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Cms/Model/Template/FilterProviderTest.php b/dev/tests/unit/testsuite/Magento/Cms/Model/Template/FilterProviderTest.php
index 14016a2893c196147dfcea84568e3f4966c28256..5555c6e367cfc6961c7e33c5c2caed210e5c330b 100644
--- a/dev/tests/unit/testsuite/Magento/Cms/Model/Template/FilterProviderTest.php
+++ b/dev/tests/unit/testsuite/Magento/Cms/Model/Template/FilterProviderTest.php
@@ -43,7 +43,7 @@ class FilterProviderTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
$this->_filterMock = $this->getMock('Magento\Cms\Model\Template\Filter', array(), array(), '', false);
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_objectManagerMock->expects($this->any())->method('get')->will($this->returnValue($this->_filterMock));
$this->_model = new \Magento\Cms\Model\Template\FilterProvider($this->_objectManagerMock);
}
@@ -81,7 +81,7 @@ class FilterProviderTest extends \PHPUnit_Framework_TestCase
public function testGetPageWrongInstance()
{
$someClassMock = $this->getMock('SomeClass');
- $objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerMock->expects($this->once())->method('get')->will($this->returnValue($someClassMock));
$model = new \Magento\Cms\Model\Template\FilterProvider($objectManagerMock, 'SomeClass', 'SomeClass');
$model->getPageFilter();
diff --git a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/Config/MatrixTest.php b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/Config/MatrixTest.php
index 0724023b0218b30736bf899f5d9ba986f15907c8..bdac3739f8f63b2a08a16a71231bad39c2e2b2de 100644
--- a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/Config/MatrixTest.php
+++ b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/Config/MatrixTest.php
@@ -23,6 +23,9 @@
*/
namespace Magento\ConfigurableProduct\Block\Adminhtml\Product\Edit\Tab\Super\Config;
+/**
+ * Class MatrixTest
+ */
class MatrixTest extends \PHPUnit_Framework_TestCase
{
/**
@@ -38,21 +41,38 @@ class MatrixTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Framework\Locale\CurrencyInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $_locale;
+ /**
+ * @var \Magento\CatalogInventory\Api\StockRegistryInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistryMock;
+
protected function setUp()
{
$this->_appConfig = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface');
$objectHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->stockRegistryMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\StockRegistryInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getStockItem']
+ );
+
$context = $objectHelper->getObject(
'Magento\Backend\Block\Template\Context',
- array('scopeConfig' => $this->_appConfig)
+ ['scopeConfig' => $this->_appConfig]
);
- $this->_locale = $this->getMock('Magento\Framework\Locale\CurrencyInterface', array(), array(), '', false);
- $data = array(
+ $this->_locale = $this->getMock('Magento\Framework\Locale\CurrencyInterface', [], [], '', false);
+ $data = [
'context' => $context,
'localeCurrency' => $this->_locale,
- 'formFactory' => $this->getMock('Magento\Framework\Data\FormFactory', array(), array(), '', false),
- 'productFactory' => $this->getMock('Magento\Catalog\Model\ProductFactory', array(), array(), '', false)
- );
+ 'formFactory' => $this->getMock('Magento\Framework\Data\FormFactory', [], [], '', false),
+ 'productFactory' => $this->getMock('Magento\Catalog\Model\ProductFactory', [], [], '', false),
+ 'stockRegistry' => $this->stockRegistryMock
+ ];
$helper = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->_object = $helper->getObject('Magento\Backend\Block\System\Config\Form', $data);
$this->_block = $helper->getObject(
@@ -64,7 +84,7 @@ class MatrixTest extends \PHPUnit_Framework_TestCase
public function testRenderPrice()
{
$this->_appConfig->expects($this->once())->method('getValue')->will($this->returnValue('USD'));
- $currency = $this->getMock('Zend_Currency', array(), array(), '', false);
+ $currency = $this->getMock('Zend_Currency', [], [], '', false);
$currency->expects($this->once())->method('toCurrency')->with('100.0000')->will($this->returnValue('$100.00'));
$this->_locale->expects(
$this->once()
@@ -77,4 +97,59 @@ class MatrixTest extends \PHPUnit_Framework_TestCase
);
$this->assertEquals('$100.00', $this->_block->renderPrice(100));
}
+
+ /**
+ * Run test getProductStockQty method
+ *
+ * @return void
+ */
+ public function testGetProductStockQty()
+ {
+ $productId = 10;
+ $websiteId = 99;
+ $qty = 100.00;
+
+ $productMock = $this->getMock(
+ 'Magento\Catalog\Model\Product',
+ ['getId', 'getStore'],
+ [],
+ '',
+ false
+ );
+ $storeMock = $this->getMock(
+ 'Magento\Store\Model\Store',
+ ['getWebsiteId'],
+ [],
+ '',
+ false
+ );
+ $stockItemMock = $this->getMockForAbstractClass(
+ 'Magento\CatalogInventory\Api\Data\StockItemInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getQty']
+ );
+
+ $productMock->expects($this->once())
+ ->method('getId')
+ ->will($this->returnValue($productId));
+ $productMock->expects($this->once())
+ ->method('getStore')
+ ->will($this->returnValue($storeMock));
+ $storeMock->expects($this->once())
+ ->method('getWebsiteId')
+ ->will($this->returnValue($websiteId));
+ $this->stockRegistryMock->expects($this->once())
+ ->method('getStockItem')
+ ->with($productId, $websiteId)
+ ->will($this->returnValue($stockItemMock));
+ $stockItemMock->expects($this->once())
+ ->method('getQty')
+ ->will($this->returnValue($qty));
+
+ $this->assertEquals($qty, $this->_block->getProductStockQty($productMock));
+ }
}
diff --git a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Pricing/Price/AttributePriceTest.php b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Pricing/Price/AttributePriceTest.php
index 18b0466a3b6b76a8aa883eb3c59126c6c2c9d1b3..7240df071d7148ce52da555f5cf3a3ac3262de6b 100644
--- a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Pricing/Price/AttributePriceTest.php
+++ b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Pricing/Price/AttributePriceTest.php
@@ -155,6 +155,7 @@ class AttributePriceTest extends \PHPUnit_Framework_TestCase
$modifiedValue = 140;
$valueIndex = 2;
$optionId = 1;
+
$expected = [
'priceOptions' =>
[
@@ -231,9 +232,9 @@ class AttributePriceTest extends \PHPUnit_Framework_TestCase
$storeMock = $this->getMockBuilder('Magento\Store\Model\Store')
->disableOriginalConstructor()
->getMock();
- $this->priceCurrency->expects($this->once())
+ // don't do any actual conversions; just return whatever was passed in
+ $this->priceCurrency->expects($this->any())
->method('convert')
- ->with($this->equalTo($modifiedValue))
->will($this->returnArgument(0));
$this->storeManagerMock->expects($this->any())
diff --git a/dev/tests/unit/testsuite/Magento/Core/App/MediaTest.php b/dev/tests/unit/testsuite/Magento/Core/App/MediaTest.php
index c0f71fb49c49379d324a98abdec5becd7a813f47..0f08e679512575dd2446473ca8966f0fe2ba2057 100644
--- a/dev/tests/unit/testsuite/Magento/Core/App/MediaTest.php
+++ b/dev/tests/unit/testsuite/Magento/Core/App/MediaTest.php
@@ -83,7 +83,7 @@ class MediaTest extends \PHPUnit_Framework_TestCase
$this->_closure = function () {
return true;
};
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_configMock = $this->getMock('Magento\Core\Model\File\Storage\Config', array(), array(), '', false);
$this->_sync = $this->getMock('Magento\Core\Model\File\Storage\Synchronization', array(), array(), '', false);
diff --git a/dev/tests/unit/testsuite/Magento/Core/Helper/PostDataTest.php b/dev/tests/unit/testsuite/Magento/Core/Helper/PostDataTest.php
index 86a631b06caee17a04f5e5472c7dd786a3bb0c10..443c4cac15c3f46c9d46b9d7d33d862f3d2c0dd1 100644
--- a/dev/tests/unit/testsuite/Magento/Core/Helper/PostDataTest.php
+++ b/dev/tests/unit/testsuite/Magento/Core/Helper/PostDataTest.php
@@ -40,7 +40,7 @@ class PostDataTest extends \PHPUnit_Framework_TestCase
$contextMock = $this->getMock(
'Magento\Framework\App\Helper\Context',
- array('getUrlBuilder'),
+ array('getUrlBuilder', 'getUrlEncoder'),
array(),
'',
false
@@ -55,9 +55,18 @@ class PostDataTest extends \PHPUnit_Framework_TestCase
array('getCurrentUrl')
);
+ $encoder = $this->getMockBuilder('Magento\Framework\Url\EncoderInterface')->getMock();
+ $encoder->expects($this->once())
+ ->method('encode')
+ ->willReturnCallback(function ($url) {
+ return strtr(base64_encode($url), '+/=', '-_,');
+ });
$contextMock->expects($this->once())
->method('getUrlBuilder')
->will($this->returnValue($urlBuilderMock));
+ $contextMock->expects($this->once())
+ ->method('getUrlEncoder')
+ ->willReturn($encoder);
$urlBuilderMock->expects($this->once())
->method('getCurrentUrl')
->will($this->returnValue($url . 'for_uenc'));
diff --git a/dev/tests/unit/testsuite/Magento/Core/Model/NoRouteHandlerListTest.php b/dev/tests/unit/testsuite/Magento/Core/Model/NoRouteHandlerListTest.php
index 6b0107fc91c002830fbe84ecd83146b372add740..57b66b23de00a51c017b65c6e6788cece9cdb5a1 100644
--- a/dev/tests/unit/testsuite/Magento/Core/Model/NoRouteHandlerListTest.php
+++ b/dev/tests/unit/testsuite/Magento/Core/Model/NoRouteHandlerListTest.php
@@ -26,7 +26,7 @@ namespace Magento\Core\Model;
class NoRouteHandlerListTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManagerMock;
@@ -37,7 +37,7 @@ class NoRouteHandlerListTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$handlersList = array(
'default_handler' => array('class' => 'Magento\Core\App\Router\NoRouteHandler', 'sortOrder' => 100),
'backend_handler' => array('class' => 'Magento\Backend\App\Router\NoRouteHandler', 'sortOrder' => 10)
diff --git a/dev/tests/unit/testsuite/Magento/Core/Model/TemplateEngine/Plugin/DebugHintsTest.php b/dev/tests/unit/testsuite/Magento/Core/Model/TemplateEngine/Plugin/DebugHintsTest.php
index 10f0b5c3c2fb0befee5f5bd5fb40be5573638cd6..7f6732a29ba1ca7e1160f806462fca0ad2d85af9 100644
--- a/dev/tests/unit/testsuite/Magento/Core/Model/TemplateEngine/Plugin/DebugHintsTest.php
+++ b/dev/tests/unit/testsuite/Magento/Core/Model/TemplateEngine/Plugin/DebugHintsTest.php
@@ -52,7 +52,7 @@ class DebugHintsTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_scopeConfig = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface');
$this->_coreData = $this->getMock('Magento\Core\Helper\Data', array(), array(), '', false);
$this->subjectMock = $this->getMock(
diff --git a/dev/tests/unit/testsuite/Magento/Core/Model/Validator/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Core/Model/Validator/FactoryTest.php
index 7c91e8e9794d212512e455003a919eb9e9a014bc..67734b63dff8dea6d86a596ac53bef6074357dc8 100644
--- a/dev/tests/unit/testsuite/Magento/Core/Model/Validator/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Core/Model/Validator/FactoryTest.php
@@ -28,7 +28,7 @@ namespace Magento\Core\Model\Validator;
class FactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -58,7 +58,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
$this->_defaultTranslator = \Magento\Framework\Validator\AbstractValidator::getDefaultTranslator();
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_validatorConfig = $this->getMockBuilder(
'Magento\Framework\Validator\Config'
)->setMethods(
diff --git a/dev/tests/unit/testsuite/Magento/Core/Model/View/DesignTest.php b/dev/tests/unit/testsuite/Magento/Core/Model/View/DesignTest.php
index 229be7005933449aa4e54c5ffda00c39c56fad69..f298e78444efa0a37a775f70aa060deba3b2c0b9 100644
--- a/dev/tests/unit/testsuite/Magento/Core/Model/View/DesignTest.php
+++ b/dev/tests/unit/testsuite/Magento/Core/Model/View/DesignTest.php
@@ -26,7 +26,7 @@ namespace Magento\Core\Model\View;
class DesignTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
private $objectManager;
@@ -43,7 +43,7 @@ class DesignTest extends \PHPUnit_Framework_TestCase
);
$config = $this->getMockForAbstractClass('\Magento\Framework\App\Config\ScopeConfigInterface');
$themeFactory = $this->getMock('\Magento\Core\Model\ThemeFactory');
- $this->objectManager = $this->getMockForAbstractClass('\Magento\Framework\ObjectManager');
+ $this->objectManager = $this->getMockForAbstractClass('\Magento\Framework\ObjectManagerInterface');
$state = $this->getMock('\Magento\Framework\App\State', array(), array(), '', false);
$themes = array();
$this->model = new \Magento\Core\Model\View\Design(
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Account/AuthorizationLinkTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Account/AuthorizationLinkTest.php
index 198db6d5935c3b225fee82ab7e27a8563b63a807..3070315b8ff0062b7a3bf3c7d347bd5f79c36f25 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Block/Account/AuthorizationLinkTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Account/AuthorizationLinkTest.php
@@ -39,9 +39,9 @@ class AuthorizationLinkTest extends \PHPUnit_Framework_TestCase
protected $httpContext;
/**
- * @var \Magento\Customer\Helper\Data
+ * @var \Magento\Customer\Model\Url
*/
- protected $_helper;
+ protected $_customerUrl;
/**
* @var \Magento\Customer\Block\Account\AuthorizationLink
@@ -55,7 +55,7 @@ class AuthorizationLinkTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods(array('getValue'))
->getMock();
- $this->_helper = $this->getMockBuilder('Magento\Customer\Helper\Data')
+ $this->_customerUrl = $this->getMockBuilder('Magento\Customer\Model\Url')
->disableOriginalConstructor()
->setMethods(array('getLogoutUrl', 'getLoginUrl'))
->getMock();
@@ -66,7 +66,7 @@ class AuthorizationLinkTest extends \PHPUnit_Framework_TestCase
array(
'context' => $context,
'httpContext' => $this->httpContext,
- 'customerHelper' => $this->_helper,
+ 'customerUrl' => $this->_customerUrl,
)
);
}
@@ -95,7 +95,7 @@ class AuthorizationLinkTest extends \PHPUnit_Framework_TestCase
->method('getValue')
->will($this->returnValue(true));
- $this->_helper->expects($this->once())->method('getLogoutUrl')->will($this->returnValue('logout url'));
+ $this->_customerUrl->expects($this->once())->method('getLogoutUrl')->will($this->returnValue('logout url'));
$this->assertEquals('logout url', $this->_block->getHref());
}
@@ -106,7 +106,7 @@ class AuthorizationLinkTest extends \PHPUnit_Framework_TestCase
->method('getValue')
->will($this->returnValue(false));
- $this->_helper->expects($this->once())->method('getLoginUrl')->will($this->returnValue('login url'));
+ $this->_customerUrl->expects($this->once())->method('getLoginUrl')->will($this->returnValue('login url'));
$this->assertEquals('login url', $this->_block->getHref());
}
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Account/LinkTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Account/LinkTest.php
index 12cecc0d22597c44407c26fb1fe6994596d6b221..4205635ff85b77e7b59ce93e57fe85c71b80eaad 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Block/Account/LinkTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Account/LinkTest.php
@@ -29,7 +29,7 @@ class LinkTest extends \PHPUnit_Framework_TestCase
{
$objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
$helper = $this->getMockBuilder(
- 'Magento\Customer\Helper\Data'
+ 'Magento\Customer\Model\Url'
)->disableOriginalConstructor()->setMethods(
array('getAccountUrl')
)->getMock();
@@ -42,7 +42,7 @@ class LinkTest extends \PHPUnit_Framework_TestCase
$block = $objectManager->getObject(
'Magento\Customer\Block\Account\Link',
- array('layout' => $layout, 'customerHelper' => $helper)
+ array('layout' => $layout, 'customerUrl' => $helper)
);
$helper->expects($this->any())->method('getAccountUrl')->will($this->returnValue('account url'));
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Account/RegisterLinkTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Account/RegisterLinkTest.php
index 0012c9586bc69445b61a4f1b3353ba7de69e5fb8..1eebb87d4421a0ac582a488584e5469c0c784e40 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Block/Account/RegisterLinkTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Account/RegisterLinkTest.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Customer\Block\Account;
+use Magento\Customer\Model\Context;
+
/**
* Test class for \Magento\Customer\Block\Account\RegisterLink
*/
@@ -55,15 +57,15 @@ class RegisterLinkTest extends \PHPUnit_Framework_TestCase
->getMock();
$httpContext->expects($this->any())
->method('getValue')
- ->with(\Magento\Customer\Helper\Data::CONTEXT_AUTH)
+ ->with(Context::CONTEXT_AUTH)
->will($this->returnValue($isAuthenticated));
- $helperMock = $this->getMockBuilder('Magento\Customer\Helper\Data')
+ $registrationMock = $this->getMockBuilder('Magento\Customer\Model\Registration')
->disableOriginalConstructor()
- ->setMethods(array('isRegistrationAllowed', 'getRegisterUrl'))
+ ->setMethods(array('isAllowed'))
->getMock();
- $helperMock->expects($this->any())
- ->method('isRegistrationAllowed')
+ $registrationMock->expects($this->any())
+ ->method('isAllowed')
->will($this->returnValue($isRegistrationAllowed));
/** @var \Magento\Customer\Block\Account\RegisterLink $link */
@@ -72,7 +74,7 @@ class RegisterLinkTest extends \PHPUnit_Framework_TestCase
array(
'context' => $context,
'httpContext' => $httpContext,
- 'customerHelper' => $helperMock,
+ 'registration' => $registrationMock,
)
);
@@ -96,7 +98,7 @@ class RegisterLinkTest extends \PHPUnit_Framework_TestCase
{
$this->_objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
$helper = $this->getMockBuilder(
- 'Magento\Customer\Helper\Data'
+ 'Magento\Customer\Model\Url'
)->disableOriginalConstructor()->setMethods(
array('getRegisterUrl')
)->getMock();
@@ -107,7 +109,7 @@ class RegisterLinkTest extends \PHPUnit_Framework_TestCase
$block = $this->_objectManager->getObject(
'Magento\Customer\Block\Account\RegisterLink',
- array('context' => $context, 'customerHelper' => $helper)
+ array('context' => $context, 'customerUrl' => $helper)
);
$this->assertEquals('register url', $block->getHref());
}
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php
index 23113b7d5a2bcfc7481a12ac1b520f7f40e514cb..d10200e6d96a9d5fb259ff1380e075ee067b8641 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php
@@ -53,8 +53,8 @@ class AccountTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Store\Model\System\Store|\PHPUnit_Framework_MockObject_MockObject */
protected $storeMock;
- /** @var \Magento\Customer\Helper\Data|\PHPUnit_Framework_MockObject_MockObject */
- protected $customerHelperMock;
+ /** @var \Magento\Customer\Model\Options|\PHPUnit_Framework_MockObject_MockObject */
+ protected $options;
/** @var \Magento\Customer\Service\V1\CustomerAccountServiceInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $customerAccountServiceInterfaceMock;
@@ -80,7 +80,7 @@ class AccountTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->getMock();
$this->storeMock = $this->getMock('Magento\Store\Model\System\Store', [], [], '', false);
- $this->customerHelperMock = $this->getMockBuilder('Magento\Customer\Helper\Data')
+ $this->options = $this->getMockBuilder('Magento\Customer\Model\Options')
->setMethods(['getNamePrefixOptions', 'getNameSuffixOptions'])
->disableOriginalConstructor()->getMock();
$this->customerAccountServiceInterfaceMock = $this->getMock(
@@ -183,9 +183,9 @@ class AccountTest extends \PHPUnit_Framework_TestCase
->will($this->returnValue($this->customerBuilderMock));
$this->customerBuilderMock->expects($this->any())->method('create')
->will($this->returnValue($customerObject));
- $this->customerHelperMock->expects($this->any())->method('getNamePrefixOptions')
+ $this->options->expects($this->any())->method('getNamePrefixOptions')
->will($this->returnValue(['Pref1', 'Pref2']));
- $this->customerHelperMock->expects($this->any())->method('getNameSuffixOptions')
+ $this->options->expects($this->any())->method('getNameSuffixOptions')
->will($this->returnValue(['Suf1', 'Suf2']));
$this->formFactoryMock->expects($this->any())->method('create')
->will($this->returnValue($accountForm));
@@ -216,7 +216,7 @@ class AccountTest extends \PHPUnit_Framework_TestCase
'jsonEncoder' => $this->encoderInterfaceMock,
'customerFormFactory' => $this->customerFormFactoryMock,
'systemStore' => $this->storeMock,
- 'customerHelper' => $this->customerHelperMock,
+ 'options' => $this->options,
'customerAccountService' => $this->customerAccountServiceInterfaceMock,
'customerMetadataService' => $this->customerMetadataServiceInterfaceMock,
'customerBuilder' => $this->customerBuilderMock
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Form/LoginTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Form/LoginTest.php
index 158a52a64ceb8cd2d7c3ecebd7d391e09e12fb46..1f832817fff04dc8cc13705c16c8e4aa07954585 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Block/Form/LoginTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Form/LoginTest.php
@@ -36,9 +36,9 @@ class LoginTest extends \PHPUnit_Framework_TestCase
protected $block;
/**
- * @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Customer\Helper\Data
+ * @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Customer\Model\Url
*/
- protected $customerHelper;
+ protected $customerUrl;
/**
* @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Checkout\Helper\Data
@@ -52,8 +52,8 @@ class LoginTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
- $this->customerHelper = $this->getMockBuilder(
- 'Magento\Customer\Helper\Data'
+ $this->customerUrl = $this->getMockBuilder(
+ 'Magento\Customer\Model\Url'
)->disableOriginalConstructor()->setMethods(
array('getRegisterUrl')
)->getMock();
@@ -72,7 +72,7 @@ class LoginTest extends \PHPUnit_Framework_TestCase
$this->block = $this->objectManager->getObject(
'Magento\Customer\Block\Form\Login',
array(
- 'customerHelper' => $this->customerHelper,
+ 'customerUrl' => $this->customerUrl,
'checkoutData' => $this->checkoutData,
'coreUrl' => $this->coreUrl
)
@@ -101,11 +101,11 @@ class LoginTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($expectedUrl, $this->block->getCreateAccountUrl());
$this->block->unsCreateAccountUrl();
- $this->customerHelper->expects($this->any())->method('getRegisterUrl')->will($this->returnValue($expectedUrl));
+ $this->customerUrl->expects($this->any())->method('getRegisterUrl')->will($this->returnValue($expectedUrl));
$this->checkoutData->expects($this->any())->method('isContextCheckout')->will($this->returnValue(false));
$this->assertEquals($expectedUrl, $this->block->getCreateAccountUrl());
- $this->customerHelper->expects($this->any())->method('getRegisterUrl')->will($this->returnValue($expectedUrl));
+ $this->customerUrl->expects($this->any())->method('getRegisterUrl')->will($this->returnValue($expectedUrl));
$this->checkoutData->expects($this->any())->method('isContextCheckout')->will($this->returnValue(true));
$this->coreUrl->expects(
$this->any()
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Form/RegisterTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Form/RegisterTest.php
index eea415667ab4d56494267f94d7b5c2d7f586fd93..4feae945fabbf0286be2c1ba64796e86393b2745 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Block/Form/RegisterTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Form/RegisterTest.php
@@ -55,8 +55,8 @@ class RegisterTest extends \PHPUnit_Framework_TestCase
/** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Framework\Module\Manager */
private $_moduleManager;
- /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Customer\Helper\Data */
- private $_customerHelper;
+ /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Customer\Model\Url */
+ private $_customerUrl;
/** @var Register */
private $_block;
@@ -66,7 +66,7 @@ class RegisterTest extends \PHPUnit_Framework_TestCase
$this->_scopeConfig = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface');
$this->_moduleManager = $this->getMock('Magento\Framework\Module\Manager', array(), array(), '', false);
$this->_coreData = $this->getMock('Magento\Core\Helper\Data', array(), array(), '', false);
- $this->_customerHelper = $this->getMock('Magento\Customer\Helper\Data', array(), array(), '', false);
+ $this->_customerUrl = $this->getMock('Magento\Customer\Model\Url', array(), array(), '', false);
$this->_customerSession = $this->getMock(
'Magento\Customer\Model\Session',
array('getCustomerFormData'),
@@ -87,7 +87,7 @@ class RegisterTest extends \PHPUnit_Framework_TestCase
$this->getMock('Magento\Directory\Model\Resource\Country\CollectionFactory', array(), array(), '', false),
$this->_moduleManager,
$this->_customerSession,
- $this->_customerHelper
+ $this->_customerUrl
);
}
@@ -116,7 +116,7 @@ class RegisterTest extends \PHPUnit_Framework_TestCase
public function testGetPostActionUrl()
{
- $this->_customerHelper->expects(
+ $this->_customerUrl->expects(
$this->once()
)->method(
'getRegisterPostUrl'
@@ -131,7 +131,7 @@ class RegisterTest extends \PHPUnit_Framework_TestCase
*/
public function testGetBackUrlNullData()
{
- $this->_customerHelper->expects(
+ $this->_customerUrl->expects(
$this->once()
)->method(
'getLoginUrl'
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/NameTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/NameTest.php
index 7fea219611e832ca34e57021bec7a7f8fa751bf2..1bc205f5166e4e4c35383261f76cccd31942e68a 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/NameTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/NameTest.php
@@ -66,8 +66,8 @@ class NameTest extends \PHPUnit_Framework_TestCase
/** @var \PHPUnit_Framework_MockObject_MockObject | AttributeMetadata */
private $_attributeMetadata;
- /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Customer\Helper\Data */
- private $_customerHelper;
+ /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Customer\Model\Options */
+ private $_options;
/** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Framework\Escaper */
private $_escaper;
@@ -95,7 +95,7 @@ class NameTest extends \PHPUnit_Framework_TestCase
$addressHelper = $this->getMock('Magento\Customer\Helper\Address', [], [], '', false);
- $this->_customerHelper = $this->getMock('Magento\Customer\Helper\Data', [], [], '', false);
+ $this->_options = $this->getMock('Magento\Customer\Model\Options', [], [], '', false);
$this->_attributeMetadata = $this->getMock(
'Magento\Customer\Service\V1\Data\Eav\AttributeMetadata',
[],
@@ -126,7 +126,7 @@ class NameTest extends \PHPUnit_Framework_TestCase
$addressHelper,
$this->customerMetadataService,
$this->addressMetadataService,
- $this->_customerHelper
+ $this->_options
);
}
@@ -240,7 +240,7 @@ class NameTest extends \PHPUnit_Framework_TestCase
$expectedOptions = $prefixOptions;
$expectedOptions[$prefix] = $prefix;
- $this->_customerHelper->expects(
+ $this->_options->expects(
$this->once()
)->method(
'getNamePrefixOptions'
@@ -258,7 +258,7 @@ class NameTest extends \PHPUnit_Framework_TestCase
->setPrefix(self::PREFIX)->create();
$this->_block->setObject($customer);
- $this->_customerHelper->expects(
+ $this->_options->expects(
$this->once()
)->method(
'getNamePrefixOptions'
@@ -285,7 +285,7 @@ class NameTest extends \PHPUnit_Framework_TestCase
$expectedOptions = $suffixOptions;
$expectedOptions[$suffix] = $suffix;
- $this->_customerHelper->expects(
+ $this->_options->expects(
$this->once()
)->method(
'getNameSuffixOptions'
@@ -303,7 +303,7 @@ class NameTest extends \PHPUnit_Framework_TestCase
->setSuffix(' <' . self::SUFFIX . '> ')->create();
$this->_block->setObject($customer);
- $this->_customerHelper->expects(
+ $this->_options->expects(
$this->once()
)->method(
'getNameSuffixOptions'
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php
index 4cd17defe0ec57d202f047bad02a113554e91af4..52280f73bbc2c166b82948b130d7507e59ce5433 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php
@@ -25,7 +25,7 @@
namespace Magento\Customer\Controller\Account;
use Magento\Customer\Helper\Address;
-use Magento\Customer\Helper\Data as CustomerData;
+use Magento\Customer\Model\Url;
use Magento\Store\Model\ScopeInterface;
class ConfirmTest extends \PHPUnit_Framework_TestCase
@@ -366,7 +366,7 @@ class ConfirmTest extends \PHPUnit_Framework_TestCase
$this->scopeConfigMock->expects($this->once())
->method('isSetFlag')
->with(
- $this->equalTo(CustomerData::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD),
+ $this->equalTo(Url::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD),
$this->equalTo(ScopeInterface::SCOPE_STORE)
)
->will($this->returnValue($isSetFlag));
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreatePostTest.php b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreatePostTest.php
index 42744a2a59b2846e5936347d46f4e93b2348b473..c217aaddcca9de55c9c2056ce42139ad62720f4c 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreatePostTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreatePostTest.php
@@ -24,9 +24,9 @@
*/
namespace Magento\Customer\Controller\Account;
+use Magento\Customer\Model\Url;
use Magento\Customer\Service\V1\CustomerAccountServiceInterface;
use Magento\Customer\Helper\Address;
-use Magento\Customer\Helper\Data as CustomerData;
use Magento\Store\Model\ScopeInterface;
class CreatePostTest extends \PHPUnit_Framework_TestCase
@@ -42,9 +42,14 @@ class CreatePostTest extends \PHPUnit_Framework_TestCase
protected $customerSessionMock;
/**
- * @var \Magento\Customer\Helper\Data|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Customer\Model\Url|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $customerHelperMock;
+ protected $customerUrl;
+
+ /**
+ * @var \Magento\Customer\Model\Registration|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $registration;
/**
* @var \Magento\Framework\App\Response\RedirectInterface|\PHPUnit_Framework_MockObject_MockObject
@@ -208,7 +213,8 @@ class CreatePostTest extends \PHPUnit_Framework_TestCase
$this->addressBuilderMock = $this->getMock(
'Magento\Customer\Service\V1\Data\AddressBuilder', [], [], '', false
);
- $this->customerHelperMock = $this->getMock('Magento\Customer\Helper\Data', [], [], '', false);
+ $this->customerUrl = $this->getMock('Magento\Customer\Model\Url', [], [], '', false);
+ $this->registration = $this->getMock('Magento\Customer\Model\Registration', [], [], '', false);
$this->escaperMock = $this->getMock('Magento\Framework\Escaper', [], [], '', false);
$this->customerExtractorMock = $this->getMock('Magento\Customer\Model\CustomerExtractor', [], [], '', false);
@@ -244,7 +250,8 @@ class CreatePostTest extends \PHPUnit_Framework_TestCase
$this->regionBuilderMock,
$this->addressBuilderMock,
$this->customerDetailsBuilderMock,
- $this->customerHelperMock,
+ $this->customerUrl,
+ $this->registration,
$this->escaperMock,
$this->customerExtractorMock
);
@@ -259,8 +266,8 @@ class CreatePostTest extends \PHPUnit_Framework_TestCase
->method('isLoggedIn')
->will($this->returnValue(false));
- $this->customerHelperMock->expects($this->once())
- ->method('isRegistrationAllowed')
+ $this->registration->expects($this->once())
+ ->method('isAllowed')
->will($this->returnValue(false));
$this->redirectMock->expects($this->once())
@@ -282,8 +289,8 @@ class CreatePostTest extends \PHPUnit_Framework_TestCase
->method('isLoggedIn')
->will($this->returnValue(false));
- $this->customerHelperMock->expects($this->once())
- ->method('isRegistrationAllowed')
+ $this->registration->expects($this->once())
+ ->method('isAllowed')
->will($this->returnValue(true));
$this->requestMock->expects($this->once())
->method('isPost')
@@ -316,10 +323,10 @@ class CreatePostTest extends \PHPUnit_Framework_TestCase
->method('isLoggedIn')
->will($this->returnValue(false));
- $this->customerHelperMock->expects($this->once())
- ->method('isRegistrationAllowed')
+ $this->registration->expects($this->once())
+ ->method('isAllowed')
->will($this->returnValue(true));
- $this->customerHelperMock->expects($this->once())
+ $this->customerUrl->expects($this->once())
->method('getEmailConfirmationUrl')
->will($this->returnValue($customerEmail));
@@ -460,8 +467,8 @@ class CreatePostTest extends \PHPUnit_Framework_TestCase
->method('isLoggedIn')
->will($this->returnValue(false));
- $this->customerHelperMock->expects($this->once())
- ->method('isRegistrationAllowed')
+ $this->registration->expects($this->once())
+ ->method('isAllowed')
->will($this->returnValue(true));
$this->customerSessionMock->expects($this->once())
@@ -536,7 +543,7 @@ class CreatePostTest extends \PHPUnit_Framework_TestCase
$this->scopeConfigMock->expects($this->once())
->method('isSetFlag')
->with(
- $this->equalTo(CustomerData::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD),
+ $this->equalTo(Url::XML_PATH_CUSTOMER_STARTUP_REDIRECT_TO_DASHBOARD),
$this->equalTo(ScopeInterface::SCOPE_STORE)
)
->will($this->returnValue($isSetFlag));
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreateTest.php b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreateTest.php
index 9be647b7443c3da3715a4811908572ddbc362437..51c8cafe9435c7b27323f993205c0bbb3679a11d 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreateTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreateTest.php
@@ -39,7 +39,7 @@ class CreateTest extends \PHPUnit_Framework_TestCase
/**
* @var \PHPUnit_Framework_MockObject_MockObject
*/
- protected $customerHelperMock;
+ protected $registrationMock;
/**
* @var \PHPUnit_Framework_MockObject_MockObject
@@ -60,7 +60,7 @@ class CreateTest extends \PHPUnit_Framework_TestCase
{
$objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->customerSession = $this->getMock('\Magento\Customer\Model\Session', [], [], '', false);
- $this->customerHelperMock = $this->getMock('\Magento\Customer\Helper\Data', [], [], '', false);
+ $this->registrationMock = $this->getMock('\Magento\Customer\Model\Registration', [], [], '', false);
$this->redirectMock = $this->getMock('Magento\Framework\App\Response\RedirectInterface');
$this->response = $this->getMock('Magento\Framework\App\ResponseInterface');
$this->request = $this->getMock(
@@ -77,7 +77,7 @@ class CreateTest extends \PHPUnit_Framework_TestCase
'request' => $this->request,
'response' => $this->response,
'customerSession' => $this->customerSession,
- 'customerHelper' => $this->customerHelperMock,
+ 'registration' => $this->registrationMock,
'redirect' => $this->redirectMock,
]
);
@@ -92,8 +92,8 @@ class CreateTest extends \PHPUnit_Framework_TestCase
->method('isLoggedIn')
->will($this->returnValue(false));
- $this->customerHelperMock->expects($this->once())
- ->method('isRegistrationAllowed')
+ $this->registrationMock->expects($this->once())
+ ->method('isAllowed')
->will($this->returnValue(false));
$this->redirectMock->expects($this->once())
@@ -120,8 +120,8 @@ class CreateTest extends \PHPUnit_Framework_TestCase
->method('isLoggedIn')
->will($this->returnValue(false));
- $this->customerHelperMock->expects($this->once())
- ->method('isRegistrationAllowed')
+ $this->registrationMock->expects($this->once())
+ ->method('isAllowed')
->will($this->returnValue(true));
$this->redirectMock->expects($this->never())
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/LoginPostTest.php b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/LoginPostTest.php
index 45826bd7b257925dace24a7df218bba954133bc5..6cb0b1c02c7a820d7d9475bec42ea7fb156442c4 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/LoginPostTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/LoginPostTest.php
@@ -26,6 +26,7 @@
* Test customer account controller
*/
namespace Magento\Customer\Controller\Account;
+use Magento\Customer\Model\Url;
/**
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -58,14 +59,14 @@ class LoginPostTest extends \PHPUnit_Framework_TestCase
protected $url;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManager;
/**
- * @var \Magento\Customer\Helper\Data|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Customer\Model\Url|\PHPUnit_Framework_MockObject_MockObject
*/
- protected $customerHelperMock;
+ protected $customerUrl;
/**
* @var \Magento\Framework\App\Response\RedirectInterface|\PHPUnit_Framework_MockObject_MockObject
@@ -145,8 +146,8 @@ class LoginPostTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $this->customerHelperMock = $this->getMock(
- 'Magento\Customer\Helper\Data',
+ $this->customerUrl = $this->getMock(
+ 'Magento\Customer\Model\Url',
[],
[],
'',
@@ -174,7 +175,7 @@ class LoginPostTest extends \PHPUnit_Framework_TestCase
'response' => $this->response,
'objectManager' => $this->objectManager,
'formKeyValidator' => $this->_formKeyValidator,
- 'customerHelperData' => $this->customerHelperMock,
+ 'customerUrl' => $this->customerUrl,
'redirect' => $this->redirectMock,
'view' => $this->viewMock,
'customerAccountService' => $this->customerAccountServiceMock,
@@ -207,7 +208,6 @@ class LoginPostTest extends \PHPUnit_Framework_TestCase
)->will(
$this->returnValueMap(
array(
- array('Magento\Customer\Helper\Data', new \Magento\Framework\Object(array('account_url' => 1))),
array(
'Magento\Framework\App\Config\ScopeConfigInterface',
new \Magento\Framework\Object(array('config_flag' => 1))
@@ -226,7 +226,7 @@ class LoginPostTest extends \PHPUnit_Framework_TestCase
)->method(
'getParam'
)->with(
- \Magento\Customer\Helper\Data::REFERER_QUERY_PARAM_NAME
+ Url::REFERER_QUERY_PARAM_NAME
)->will(
$this->returnValue('referer')
);
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Helper/DataTest.php b/dev/tests/unit/testsuite/Magento/Customer/Helper/DataTest.php
deleted file mode 100644
index 69d065804b52033c9b141f1813e99bbecb24e7f2..0000000000000000000000000000000000000000
--- a/dev/tests/unit/testsuite/Magento/Customer/Helper/DataTest.php
+++ /dev/null
@@ -1,360 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\Customer\Helper;
-
-class DataTest extends \PHPUnit_Framework_TestCase
-{
- const FORM_CODE = 'FORM_CODE';
-
- const ENTITY = 'ENTITY';
-
- const SCOPE = 'SCOPE';
-
- protected $_expected = array(
- 'filter_key' => 'filter_value',
- 'is_in_request_data' => 'request_data_value',
- 'is_not_in_request_data' => false,
- 'attribute_is_front_end_input' => true
- );
-
- /** @var \Magento\Customer\Helper\Data|\PHPUnit_Framework_MockObject_MockObject */
- protected $_dataHelper;
-
- /** @var \Magento\Framework\App\RequestInterface|\PHPUnit_Framework_MockObject_MockObject */
- protected $_mockRequest;
-
- /** @var array */
- protected $_additionalAttributes;
-
- /** @var \Magento\Customer\Model\Metadata\Form|\PHPUnit_Framework_MockObject_MockObject */
- protected $_mockMetadataForm;
-
- /** @var \Magento\Framework\App\Config\ScopeConfigInterface|\PHPUnit_Framework_MockObject_MockObject */
- protected $scopeConfigMock;
-
- /** @var \Magento\Customer\Helper\Data */
- protected $model;
-
- public function setUp()
- {
- $this->_mockRequest = $this->getMock(
- 'Magento\Framework\App\RequestInterface',
- ['getPost', 'getModuleName', 'setModuleName', 'getActionName', 'setActionName', 'getParam', 'getCookie'],
- [],
- '',
- false
- );
- $this->_additionalAttributes = array('is_in_request_data', 'is_not_in_request_data');
- $this->_mockMetadataForm = $this->getMockBuilder(
- '\Magento\Customer\Model\Metadata\Form'
- )->disableOriginalConstructor()->getMock();
-
- $this->scopeConfigMock = $this->getMock(
- 'Magento\Framework\App\Config\ScopeConfigInterface',
- ['getValue', 'isSetFlag'],
- [],
- '',
- false
- );
- }
-
- protected function prepareExtractCustomerData()
- {
- $this->_dataHelper = $this->getMockBuilder(
- '\Magento\Customer\Helper\Data'
- )->disableOriginalConstructor()->setMethods(
- array('__construct')
- )->getMock();
-
- $filteredData = array(
- 'filter_key' => 'filter_value',
- 'attribute_is_not_front_end_input' => false,
- 'attribute_is_front_end_input' => true
- );
- $this->_mockMetadataForm->expects(
- $this->once()
- )->method(
- 'extractData'
- )->with(
- $this->_mockRequest,
- self::SCOPE
- )->will(
- $this->returnValue($filteredData)
- );
-
- $requestData = array('is_in_request_data' => 'request_data_value');
- $this->_mockRequest->expects(
- $this->once()
- )->method(
- 'getPost'
- )->with(
- self::SCOPE
- )->will(
- $this->returnValue($requestData)
- );
-
- $attributeIsFrontEndInput = $this->getMockBuilder(
- '\Magento\Customer\Service\V1\Data\Eav\AttributeMetadata'
- )->disableOriginalConstructor()->getMock();
- $attributeIsFrontEndInput->expects(
- $this->once()
- )->method(
- 'getAttributeCode'
- )->will(
- $this->returnValue('attribute_is_front_end_input')
- );
- $attributeIsFrontEndInput->expects(
- $this->once()
- )->method(
- 'getFrontendInput'
- )->will(
- $this->returnValue('boolean')
- );
-
- $attributeIsNotFrontEndInput = $this->getMockBuilder(
- '\Magento\Customer\Service\V1\Data\Eav\AttributeMetadata'
- )->disableOriginalConstructor()->getMock();
- $attributeIsNotFrontEndInput->expects(
- $this->once()
- )->method(
- 'getAttributeCode'
- )->will(
- $this->returnValue('attribute_is_not_front_end_input')
- );
- $attributeIsNotFrontEndInput->expects(
- $this->once()
- )->method(
- 'getFrontendInput'
- )->will(
- $this->returnValue(false)
- );
-
- $formAttributes = array($attributeIsFrontEndInput, $attributeIsNotFrontEndInput);
- $this->_mockMetadataForm->expects(
- $this->once()
- )->method(
- 'getAttributes'
- )->will(
- $this->returnValue($formAttributes)
- );
- }
-
- public function testExtractCustomerData()
- {
- $this->prepareExtractCustomerData();
- $this->assertEquals(
- $this->_expected,
- $this->_dataHelper->extractCustomerData(
- $this->_mockRequest,
- self::FORM_CODE,
- self::ENTITY,
- $this->_additionalAttributes,
- self::SCOPE,
- $this->_mockMetadataForm
- )
- );
- }
-
- public function testExtractCustomerDataWithFactory()
- {
- $this->prepareExtractCustomerData();
- /** @var \Magento\Customer\Model\Metadata\FormFactory|\PHPUnit_Framework_MockObject_MockObject */
- $mockFormFactory = $this->getMockBuilder(
- '\Magento\Customer\Model\Metadata\FormFactory'
- )->disableOriginalConstructor()->setMethods(
- array('create')
- )->getMock();
-
- $objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $arguments = array('formFactory' => $mockFormFactory);
- $this->_dataHelper = $objectManagerHelper->getObject('\Magento\Customer\Helper\Data', $arguments);
-
- $mockFormFactory->expects(
- $this->once()
- )->method(
- 'create'
- )->with(
- self::ENTITY,
- self::FORM_CODE,
- [],
- false,
- \Magento\Customer\Model\Metadata\Form::DONT_IGNORE_INVISIBLE
- )->will(
- $this->returnValue($this->_mockMetadataForm)
- );
-
- $this->assertEquals(
- $this->_expected,
- $this->_dataHelper->extractCustomerData(
- $this->_mockRequest,
- self::FORM_CODE,
- self::ENTITY,
- $this->_additionalAttributes,
- self::SCOPE
- )
- );
- }
-
- public function testGetCustomerGroupIdBasedOnVatNumberWithoutAutoAssign()
- {
- $objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $arguments = array(
- 'scopeConfig' => $this->scopeConfigMock
- );
- $this->model = $objectManagerHelper->getObject('Magento\Customer\Helper\Data', $arguments);
-
- $this->scopeConfigMock->expects($this->once())
- ->method('isSetFlag')
- ->with(
- \Magento\Customer\Helper\Data::XML_PATH_CUSTOMER_GROUP_AUTO_ASSIGN,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- 'store'
- )->will($this->returnValue(false));
-
- $vatResult = $this->getMock(
- 'Magento\Framework\Object',
- [],
- [],
- '',
- false
- );
-
- $this->assertNull($this->model->getCustomerGroupIdBasedOnVatNumber('GB', $vatResult, 'store'));
- }
-
- /**
- * @param string $countryCode
- * @param bool $resultValid
- * @param bool $resultSuccess
- * @param string $merchantCountryCode
- * @param int $vatDomestic
- * @param int $vatIntra
- * @param int $vatInvalid
- * @param int $vatError
- * @param int|null $groupId
- * @dataProvider dataProviderGetCustomerGroupIdBasedOnVatNumber
- */
- public function testGetCustomerGroupIdBasedOnVatNumber(
- $countryCode,
- $resultValid,
- $resultSuccess,
- $merchantCountryCode,
- $vatDomestic,
- $vatIntra,
- $vatInvalid,
- $vatError,
- $groupId
- ) {
- $objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $arguments = [
- 'scopeConfig' => $this->scopeConfigMock
- ];
- $this->model = $objectManagerHelper->getObject('Magento\Customer\Helper\Data', $arguments);
-
- $this->scopeConfigMock->expects($this->once())
- ->method('isSetFlag')
- ->with(
- \Magento\Customer\Helper\Data::XML_PATH_CUSTOMER_GROUP_AUTO_ASSIGN,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- 'store'
- )->will($this->returnValue(true));
-
- $configMap = [
- [
- \Magento\Customer\Helper\Data::XML_PATH_CUSTOMER_VIV_DOMESTIC_GROUP,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- 'store',
- $vatDomestic
- ],
- [
- \Magento\Customer\Helper\Data::XML_PATH_CUSTOMER_VIV_INTRA_UNION_GROUP,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- 'store',
- $vatIntra
- ],
- [
- \Magento\Customer\Helper\Data::XML_PATH_CUSTOMER_VIV_INVALID_GROUP,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- 'store',
- $vatInvalid
- ],
- [
- \Magento\Customer\Helper\Data::XML_PATH_CUSTOMER_VIV_ERROR_GROUP,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- 'store',
- $vatError
- ],
- [
- \Magento\Customer\Helper\Data::XML_PATH_MERCHANT_COUNTRY_CODE,
- \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
- 'store',
- $merchantCountryCode
- ],
- ];
- $this->scopeConfigMock->expects($this->any())
- ->method('getValue')
- ->will($this->returnValueMap($configMap));
-
- $vatResult = $this->getMock(
- 'Magento\Framework\Object',
- ['getIsValid', 'getRequestSuccess'],
- [],
- '',
- false
- );
- $vatResult->expects($this->any())
- ->method('getIsValid')
- ->will($this->returnValue($resultValid));
- $vatResult->expects($this->any())
- ->method('getRequestSuccess')
- ->will($this->returnValue($resultSuccess));
-
- $this->assertEquals(
- $groupId,
- $this->model->getCustomerGroupIdBasedOnVatNumber($countryCode, $vatResult, 'store')
- );
- }
-
- public function dataProviderGetCustomerGroupIdBasedOnVatNumber()
- {
- return [
- ['US', false, false, 'US', null, null, null, null, 0],
- ['US', false, false, 'GB', null, null, null, null, 0],
- ['US', true, false, 'US', null, null, null, null, 0],
- ['US', false, true, 'US', null, null, null, null, 0],
- ['GB', false, false, 'GB', 3, 4, 5, 6, 6],
- ['GB', false, false, 'DE', 3, 4, 5, 6, 6],
- ['GB', true, true, 'GB', 3, 4, 5, 6, 3],
- ['GB', true, true, 'DE', 3, 4, 5, 6, 4],
- ['GB', false, true, 'DE', 3, 4, 5, 6, 5],
- ['GB', false, true, 'GB', 3, 4, 5, 6, 5],
- ['GB', false, false, 'GB', null, null, null, null, 0],
- ['GB', false, false, 'DE', null, null, null, null, 0],
- ['GB', true, true, 'GB', null, null, null, null, 0],
- ['GB', true, true, 'DE', null, null, null, null, 0],
- ['GB', false, true, 'DE', null, null, null, null, 0],
- ['GB', false, true, 'GB', null, null, null, null, 0],
- ];
- }
-}
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Model/App/Action/ContextPluginTest.php b/dev/tests/unit/testsuite/Magento/Customer/Model/App/Action/ContextPluginTest.php
index e2a178f01261124ad27d2c209e0462e776fd2ac3..b3c121baa02f9d9038e656e2e5602937f98bd603 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Model/App/Action/ContextPluginTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Model/App/Action/ContextPluginTest.php
@@ -24,6 +24,8 @@
namespace Magento\Customer\Model\App\Action;
+use Magento\Customer\Model\Context;
+
/**
* Class ContextPluginTest
*/
@@ -105,8 +107,8 @@ class ContextPluginTest extends \PHPUnit_Framework_TestCase
->will(
$this->returnValueMap(
array(
- array(\Magento\Customer\Helper\Data::CONTEXT_GROUP, 'UAH', $this->httpContextMock),
- array(\Magento\Customer\Helper\Data::CONTEXT_AUTH, 0, $this->httpContextMock),
+ array(Context::CONTEXT_GROUP, 'UAH', $this->httpContextMock),
+ array(Context::CONTEXT_AUTH, 0, $this->httpContextMock),
)
)
);
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Model/Metadata/ElementFactoryTest.php b/dev/tests/unit/testsuite/Magento/Customer/Model/Metadata/ElementFactoryTest.php
index d9b113778d74866adfc74bfbe3a71f6e83527b0b..be79864e14b901fe5d940dcc0bea3940ad77bbab 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Model/Metadata/ElementFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Model/Metadata/ElementFactoryTest.php
@@ -25,7 +25,7 @@ namespace Magento\Customer\Model\Metadata;
class ElementFactoryTest extends \PHPUnit_Framework_TestCase
{
- /** @var \Magento\Framework\ObjectManager | \PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface | \PHPUnit_Framework_MockObject_MockObject */
private $_objectManager;
/** @var \Magento\Customer\Service\V1\Data\Eav\AttributeMetadata | \PHPUnit_Framework_MockObject_MockObject */
@@ -39,7 +39,7 @@ class ElementFactoryTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_attributeMetadata = $this->getMock(
'Magento\Customer\Service\V1\Data\Eav\AttributeMetadata',
array(),
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/GroupTest.php b/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/GroupTest.php
index 43edbaf3021ff464f02461b9a4555f62808cdc7e..2ed608c8c5f35dc01bd370400d9958fb31e01f84 100644
--- a/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/GroupTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/GroupTest.php
@@ -34,8 +34,8 @@ class GroupTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Framework\App\Resource|\PHPUnit_Framework_MockObject_MockObject */
protected $resource;
- /** @var \Magento\Customer\Helper\Data|\PHPUnit_Framework_MockObject_MockObject */
- protected $customerHelper;
+ /** @var \Magento\Customer\Model\Vat|\PHPUnit_Framework_MockObject_MockObject */
+ protected $customerVat;
/** @var \Magento\Customer\Model\Group|\PHPUnit_Framework_MockObject_MockObject */
protected $groupModel;
@@ -46,7 +46,7 @@ class GroupTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
$this->resource = $this->getMock('Magento\Framework\App\Resource', [], [], '', false);
- $this->customerHelper = $this->getMock('Magento\Customer\Helper\Data', [], [], '', false);
+ $this->customerVat = $this->getMock('Magento\Customer\Model\Vat', [], [], '', false);
$this->customersFactory = $this->getMock(
'Magento\Customer\Model\Resource\Customer\CollectionFactory',
['create'],
@@ -60,7 +60,7 @@ class GroupTest extends \PHPUnit_Framework_TestCase
'Magento\Customer\Model\Resource\Group',
[
'resource' => $this->resource,
- 'customerData' => $this->customerHelper,
+ 'customerVat' => $this->customerVat,
'customersFactory' => $this->customersFactory,
]
);
@@ -82,7 +82,7 @@ class GroupTest extends \PHPUnit_Framework_TestCase
$customer->expects($this->once())->method('getId')->will($this->returnValue($customerId));
$customer->expects($this->once())->method('load')->with($customerId)->will($this->returnSelf());
$defaultCustomerGroup = 1;
- $this->customerHelper->expects($this->once())->method('getDefaultCustomerGroupId')
+ $this->customerVat->expects($this->once())->method('getDefaultCustomerGroupId')
->will($this->returnValue($defaultCustomerGroup));
$customer->expects($this->once())->method('setGroupId')->with($defaultCustomerGroup);
$customerCollection = $this->getMock('Magento\Customer\Model\Resource\Customer\Collection', [], [], '', false);
diff --git a/dev/tests/unit/testsuite/Magento/Customer/Service/V1/CustomerAccountServiceTest.php b/dev/tests/unit/testsuite/Magento/Customer/Service/V1/CustomerAccountServiceTest.php
index 1879111bbed5f6da403b7b37d7fc86a52ff2ba9e..894282ce977c12c21127b57888d54ec35b7dbee5 100755
--- a/dev/tests/unit/testsuite/Magento/Customer/Service/V1/CustomerAccountServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Customer/Service/V1/CustomerAccountServiceTest.php
@@ -126,11 +126,6 @@ class CustomerAccountServiceTest extends \PHPUnit_Framework_TestCase
*/
private $_loggerMock;
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Customer\Helper\Data
- */
- private $_customerHelperMock;
-
/**
* @var \Magento\TestFramework\Helper\ObjectManager
*/
@@ -307,15 +302,6 @@ class CustomerAccountServiceTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->getMock();
- $this->_customerHelperMock =
- $this->getMockBuilder('Magento\Customer\Helper\Data')
- ->disableOriginalConstructor()
- ->setMethods(['isCustomerInStore'])
- ->getMock();
- $this->_customerHelperMock->expects($this->any())
- ->method('isCustomerInStore')
- ->will($this->returnValue(false));
-
$this->_urlMock = $this->getMockBuilder('Magento\Framework\UrlInterface')
->disableOriginalConstructor()
->getMock();
diff --git a/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/FirstEntranceTest.php b/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/FirstEntranceTest.php
index a6840d0e39fb18a47752ce4856e44f164ed342ae..5a948063d86fd4b5ebbe76c63a3a7218957c9cfe 100644
--- a/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/FirstEntranceTest.php
+++ b/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/FirstEntranceTest.php
@@ -41,7 +41,7 @@ class FirstEntranceTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$request = $this->getMock('Magento\Framework\App\Request\Http', array(), array(), '', false);
$request->expects($this->any())->method('setActionName')->will($this->returnSelf());
diff --git a/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/IndexTest.php b/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/IndexTest.php
index 39372f5e57276815b0a6016402ff949c36b1bfbd..f45b02ab256df7673931f500ace631681ac2cd30 100644
--- a/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/IndexTest.php
+++ b/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/IndexTest.php
@@ -41,7 +41,7 @@ class IndexTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$request = $this->getMock('Magento\Framework\App\Request\Http', array(), array(), '', false);
$request->expects($this->any())->method('setActionName')->will($this->returnSelf());
diff --git a/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Varien/Router/StandardTest.php b/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Varien/Router/StandardTest.php
index 23167c55174dcd8e029d7e0383e53b71d75a2af3..3e8f9f3be78c2486e4ee472ed8014ca94f4081e6 100644
--- a/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Varien/Router/StandardTest.php
+++ b/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Varien/Router/StandardTest.php
@@ -53,14 +53,14 @@ class StandardTest extends \PHPUnit_Framework_TestCase
protected $_model;
/**
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $_cookieManagerMock;
public function setUp()
{
- $this->_cookieManagerMock = $this->getMock('\Magento\Framework\Stdlib\CookieManager');
+ $this->_cookieManagerMock = $this->getMock('\Magento\Framework\Stdlib\CookieManagerInterface');
}
/**
@@ -93,7 +93,7 @@ class StandardTest extends \PHPUnit_Framework_TestCase
*/
public function matchDataProvider()
{
- $this->_cookieManagerMock = $this->getMock('\Magento\Framework\Stdlib\CookieManager');
+ $this->_cookieManagerMock = $this->getMock('\Magento\Framework\Stdlib\CookieManagerInterface');
$uri = self::TEST_HOST . '/' . self::VDE_FRONT_NAME . self::TEST_PATH;
$notVdeUrl = self::TEST_HOST . self::TEST_PATH;
diff --git a/dev/tests/unit/testsuite/Magento/DesignEditor/Model/AreaEmulatorTest.php b/dev/tests/unit/testsuite/Magento/DesignEditor/Model/AreaEmulatorTest.php
index 81b5ee44b99ad72b511b41f77e195e5ce59f94ae..402ef259ec7c86fddcb412cef175976641203081 100644
--- a/dev/tests/unit/testsuite/Magento/DesignEditor/Model/AreaEmulatorTest.php
+++ b/dev/tests/unit/testsuite/Magento/DesignEditor/Model/AreaEmulatorTest.php
@@ -37,7 +37,7 @@ class AreaEmulatorTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new AreaEmulator($this->_objectManager);
}
diff --git a/dev/tests/unit/testsuite/Magento/DesignEditor/Model/StateTest.php b/dev/tests/unit/testsuite/Magento/DesignEditor/Model/StateTest.php
index fe316466a3b528070e72adc69528c1839eff9863..619b1b237184d19998bf6d3d623a06029434de19 100644
--- a/dev/tests/unit/testsuite/Magento/DesignEditor/Model/StateTest.php
+++ b/dev/tests/unit/testsuite/Magento/DesignEditor/Model/StateTest.php
@@ -157,7 +157,7 @@ class StateTest extends \PHPUnit_Framework_TestCase
false
);
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$mutableConfig = $this->getMockForAbstractClass('\Magento\Framework\App\Config\MutableScopeConfigInterface');
$mutableConfig->expects(
diff --git a/dev/tests/unit/testsuite/Magento/DesignEditor/Model/Url/FactoryTest.php b/dev/tests/unit/testsuite/Magento/DesignEditor/Model/Url/FactoryTest.php
index d38fd04e22b583a24e9fd5ccb6a5ff754a0eaa46..5eeab628a0d97aba9ec99e83cbc30ec9c8638688 100644
--- a/dev/tests/unit/testsuite/Magento/DesignEditor/Model/Url/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/DesignEditor/Model/Url/FactoryTest.php
@@ -31,19 +31,19 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected $_model;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\DesignEditor\Model\Url\Factory($this->_objectManager);
}
public function testConstruct()
{
- $this->assertAttributeInstanceOf('Magento\Framework\ObjectManager', '_objectManager', $this->_model);
+ $this->assertAttributeInstanceOf('Magento\Framework\ObjectManagerInterface', '_objectManager', $this->_model);
}
public function testReplaceClassName()
diff --git a/dev/tests/unit/testsuite/Magento/Directory/Model/Currency/Import/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Directory/Model/Currency/Import/FactoryTest.php
index a2146263c799304a9d1628e4f178b2c6434df1b6..a0ae45db95d8ba24ca58be1a922d5c4fc2c67b66 100644
--- a/dev/tests/unit/testsuite/Magento/Directory/Model/Currency/Import/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Directory/Model/Currency/Import/FactoryTest.php
@@ -31,7 +31,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected $_model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManager;
@@ -42,7 +42,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_importConfig = $this->getMock(
'Magento\Directory\Model\Currency\Import\Config',
array(),
diff --git a/dev/tests/unit/testsuite/Magento/Eav/Model/AttributeFactoryTest.php b/dev/tests/unit/testsuite/Magento/Eav/Model/AttributeFactoryTest.php
index f6f9fb684b33511012fd728c4cce201fb92c881a..c722d459f7c1052255b1c837c82551bfd62abac3 100644
--- a/dev/tests/unit/testsuite/Magento/Eav/Model/AttributeFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Eav/Model/AttributeFactoryTest.php
@@ -42,8 +42,8 @@ class AttributeFactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- /** @var $objectManagerMock \Magento\Framework\ObjectManager */
- $objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ /** @var $objectManagerMock \Magento\Framework\ObjectManagerInterface */
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerMock->expects(
$this->any()
)->method(
diff --git a/dev/tests/unit/testsuite/Magento/Eav/Model/Validator/Attribute/DataTest.php b/dev/tests/unit/testsuite/Magento/Eav/Model/Validator/Attribute/DataTest.php
index 09f883e8dba2f971e3a0f69b4cf4a7080bbbc29b..cdef1319b65ced690b0960df82f8ac72bc7175f5 100644
--- a/dev/tests/unit/testsuite/Magento/Eav/Model/Validator/Attribute/DataTest.php
+++ b/dev/tests/unit/testsuite/Magento/Eav/Model/Validator/Attribute/DataTest.php
@@ -53,7 +53,7 @@ class DataTest extends \PHPUnit_Framework_TestCase
'Magento\Eav\Model\AttributeDataFactory',
array('create'),
array(
- 'objectManager' => $this->getMock('Magento\Framework\ObjectManager'),
+ 'objectManager' => $this->getMock('Magento\Framework\ObjectManagerInterface'),
'string' => $this->getMock('Magento\Framework\Stdlib\String')
)
);
@@ -172,7 +172,7 @@ class DataTest extends \PHPUnit_Framework_TestCase
'Magento\Eav\Model\AttributeDataFactory',
array('create'),
array(
- 'objectManager' => $this->getMock('Magento\Framework\ObjectManager'),
+ 'objectManager' => $this->getMock('Magento\Framework\ObjectManagerInterface'),
'string' => $this->getMock('Magento\Framework\Stdlib\String')
)
);
@@ -219,7 +219,7 @@ class DataTest extends \PHPUnit_Framework_TestCase
'Magento\Eav\Model\AttributeDataFactory',
array('create'),
array(
- 'objectManager' => $this->getMock('Magento\Framework\ObjectManager'),
+ 'objectManager' => $this->getMock('Magento\Framework\ObjectManagerInterface'),
'string' => $this->getMock('Magento\Framework\Stdlib\String')
)
);
@@ -261,7 +261,7 @@ class DataTest extends \PHPUnit_Framework_TestCase
'Magento\Eav\Model\AttributeDataFactory',
array(),
array(
- 'objectManager' => $this->getMock('Magento\Framework\ObjectManager'),
+ 'objectManager' => $this->getMock('Magento\Framework\ObjectManagerInterface'),
'string' => $this->getMock('Magento\Framework\Stdlib\String')
)
);
@@ -278,7 +278,7 @@ class DataTest extends \PHPUnit_Framework_TestCase
'Magento\Eav\Model\AttributeDataFactory',
array(),
array(
- 'objectManager' => $this->getMock('Magento\Framework\ObjectManager'),
+ 'objectManager' => $this->getMock('Magento\Framework\ObjectManagerInterface'),
'string' => $this->getMock('Magento\Framework\Stdlib\String')
)
);
@@ -312,7 +312,7 @@ class DataTest extends \PHPUnit_Framework_TestCase
'Magento\Eav\Model\AttributeDataFactory',
array('create'),
array(
- 'objectManager' => $this->getMock('Magento\Framework\ObjectManager'),
+ 'objectManager' => $this->getMock('Magento\Framework\ObjectManagerInterface'),
'string' => $this->getMock('Magento\Framework\Stdlib\String')
)
);
diff --git a/dev/tests/unit/testsuite/Magento/Fedex/Model/CarrierTest.php b/dev/tests/unit/testsuite/Magento/Fedex/Model/CarrierTest.php
index 9dcab9c90aea6902d275ba9c88ffe689958c40cd..d2e42636acdc4e7eb0d7e3628dfbc0826e341650 100644
--- a/dev/tests/unit/testsuite/Magento/Fedex/Model/CarrierTest.php
+++ b/dev/tests/unit/testsuite/Magento/Fedex/Model/CarrierTest.php
@@ -25,6 +25,11 @@ namespace Magento\Fedex\Model;
use Magento\Framework\Object;
+/**
+ * Class CarrierTest
+ * @package Magento\Fedex\Model
+ * TODO refactor me
+ */
class CarrierTest extends \PHPUnit_Framework_TestCase
{
/**
@@ -130,8 +135,8 @@ class CarrierTest extends \PHPUnit_Framework_TestCase
'countryFactory' => $countryFactory,
'currencyFactory' => $this->getMock('Magento\Directory\Model\CurrencyFactory', [], [], '', false),
'directoryData' => $this->getMock('Magento\Directory\Helper\Data', [], [], '', false),
- 'stockItemService' =>
- $this->getMock('Magento\CatalogInventory\Service\V1\StockItemService', [], [], '', false),
+ 'stockRegistry' =>
+ $this->getMock('Magento\CatalogInventory\Model\StockRegistry', [], [], '', false),
'logger' => $this->getMock('Magento\Framework\Logger', [], [], '', false),
'storeManager' => $storeManager,
'configReader' => $this->getMock('Magento\Framework\Module\Dir\Reader', [], [], '', false),
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Acl/ResourceFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Acl/ResourceFactoryTest.php
index 6c1346e4b423640bb76e520f910fa9f44e4977d6..c1d07bb4dcc3d0fb0a94e071c60d652502778ceb 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Acl/ResourceFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Acl/ResourceFactoryTest.php
@@ -33,7 +33,7 @@ class ResourceFactoryTest extends \PHPUnit_Framework_TestCase
protected $_model;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -46,15 +46,7 @@ class ResourceFactoryTest extends \PHPUnit_Framework_TestCase
{
$helper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->_objectManager = $this->getMockForAbstractClass(
- 'Magento\Framework\ObjectManager',
- array(),
- '',
- true,
- true,
- true,
- array('create')
- );
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_expectedObject = $this->getMock('Magento\Framework\Acl\Resource', array(), array(), '', false);
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php
index 2470fc9dbb4a99c7622d4a925661ec72cda99b32..6acec2336d576f0085cd82c8b9399366a7650d8f 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php
@@ -30,7 +30,7 @@ use Magento\TestFramework\Helper\ObjectManager;
/**
* Class BuilderTest
*/
-class DataBuilderTest extends \PHPUnit_Framework_TestCase
+class DataBuilderTest extends EntityChildTestAbstract
{
/*
* The test is based on assumption that the classes will be injecting "DataBuilder" as dependency which will
@@ -40,115 +40,41 @@ class DataBuilderTest extends \PHPUnit_Framework_TestCase
const RESULT_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\ExtensibleSampleDataBuilder';
const GENERATOR_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\DataBuilder';
const OUTPUT_FILE_NAME = 'ExtensibleSampleDataBuilder.php';
- /**
- * @var Io | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $ioObjectMock;
- /**
- * @var \Magento\Framework\Code\Generator\EntityAbstract
- */
- protected $generator;
+ protected function getSourceClassName()
+ {
+ return self::SOURCE_CLASS_NAME;
+ }
- /**
- * @var \Magento\Framework\Code\Generator\FileResolver | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $fileResolverMock;
+ protected function getResultClassName()
+ {
+ return self::RESULT_CLASS_NAME;
+ }
- /**
- * @var \Magento\Framework\Code\Generator\CodeGenerator\Zend | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $classGenerator;
+ protected function getGeneratorClassName()
+ {
+ return self::GENERATOR_CLASS_NAME;
+ }
- /** @var \Magento\Framework\App\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
- protected $objectManagerMock;
+ protected function getOutputFileName()
+ {
+ return self::OUTPUT_FILE_NAME;
+ }
protected function setUp()
{
+ parent::setUp();
+
require_once __DIR__ . '/_files/ExtensibleSampleInterface.php';
require_once __DIR__ . '/_files/ExtensibleSample.php';
- $this->ioObjectMock = $this->getMock(
- 'Magento\Framework\Code\Generator\Io',
- [],
- [],
- '',
- false
- );
- $this->fileResolverMock = $this->getMock(
- 'Magento\Framework\Code\Generator\FileResolver',
- [],
- [],
- '',
- false
- );
- $objectManager = new ObjectManager($this);
- $this->classGenerator = $objectManager->getObject('Magento\Framework\Code\Generator\CodeGenerator\Zend');
- $this->getMock(
- 'Magento\Framework\Code\Generator\CodeGenerator\Zend',
- [],
- [],
- '',
- false
- );
- $this->objectManagerMock = $this->getMock('Magento\Framework\App\ObjectManager', [], [], '', false);
- \Magento\Framework\App\ObjectManager::setInstance($this->objectManagerMock);
-
- $this->generator = $objectManager->getObject(
- self::GENERATOR_CLASS_NAME,
- [
- 'sourceClassName' => self::SOURCE_CLASS_NAME,
- 'resultClassName' => self::RESULT_CLASS_NAME,
- 'ioObject' => $this->ioObjectMock,
- 'classGenerator' => $this->classGenerator,
- 'fileResolver' => $this->fileResolverMock
- ]
- );
}
- /**
- * generate repository name
- */
- public function testGenerate()
+ protected function mockDefinedClassesCall()
{
- $generatedCode = file_get_contents(__DIR__ . '/_files/ExtensibleSampleDataBuilder.txt');
- $sourceFileName = 'ExtensibleSample.php';
- $resultFileName = self::OUTPUT_FILE_NAME;
-
- //Mocking _validateData call
- $this->fileResolverMock->expects($this->at(0))
- ->method('getFile')
- ->with(self::SOURCE_CLASS_NAME . "Interface")
- ->will($this->returnValue($sourceFileName));
- $this->fileResolverMock->expects($this->at(1))
- ->method('getFile')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue(false));
-
- $this->ioObjectMock->expects($this->once())
- ->method('makeGenerationDirectory')
- ->will($this->returnValue(true));
- $this->ioObjectMock->expects($this->once())
- ->method('makeResultFileDirectory')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue(true));
- $this->ioObjectMock->expects($this->once())
- ->method('fileExists')
- ->with($resultFileName)
- ->will($this->returnValue(false));
-
- //Mocking generation
- $this->ioObjectMock->expects($this->any())
- ->method('getResultFileName')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue($resultFileName));
-
- //Verify if the generated code is as expected
- $this->ioObjectMock->expects($this->once())
- ->method('writeResultFile')
- ->with($resultFileName, $generatedCode)
- ->will($this->returnValue(true));
-
- $this->assertTrue($this->generator->generate(), implode("\n", $this->generator->getErrors()));
+ $this->definedClassesMock->expects($this->at(0))
+ ->method('classLoadable')
+ ->with($this->getSourceClassName() . 'Interface')
+ ->willReturn(true);
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/EntityChildTestAbstract.php b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/EntityChildTestAbstract.php
new file mode 100644
index 0000000000000000000000000000000000000000..3943d60b4a6ae3b6d7aec0ec3e2b5e4872fef9c2
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/EntityChildTestAbstract.php
@@ -0,0 +1,158 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Api\Code\Generator;
+
+use Magento\Framework\Code\Generator\Io;
+use Magento\TestFramework\Helper\ObjectManager;
+
+/**
+ * Class BuilderTest
+ */
+abstract class EntityChildTestAbstract extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var Io | \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $ioObjectMock;
+
+ /**
+ * @var \Magento\Framework\Code\Generator\EntityAbstract
+ */
+ protected $generator;
+
+ /**
+ * @var \Magento\Framework\Code\Generator\CodeGenerator\Zend | \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $classGenerator;
+
+ /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Framework\Code\Generator\DefinedClasses */
+ protected $definedClassesMock;
+
+ protected abstract function getSourceClassName();
+
+ protected abstract function getResultClassName();
+
+ protected abstract function getGeneratorClassName();
+
+ protected abstract function getOutputFileName();
+
+ protected function setUp()
+ {
+ require_once __DIR__ . '/_files/Sample.php';
+
+ $this->ioObjectMock = $this->getMock(
+ 'Magento\Framework\Code\Generator\Io',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->classGenerator = $this->getMock(
+ 'Magento\Framework\Code\Generator\CodeGenerator\Zend',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->definedClassesMock = $this->getMockBuilder('Magento\Framework\Code\Generator\DefinedClasses')
+ ->disableOriginalConstructor()->getMock();
+
+ $objectManager = new ObjectManager($this);
+ $this->generator = $objectManager->getObject(
+ $this->getGeneratorClassName(),
+ [
+ 'sourceClassName' => $this->getSourceClassName(),
+ 'resultClassName' => $this->getResultClassName(),
+ 'ioObject' => $this->ioObjectMock,
+ 'classGenerator' => $this->classGenerator,
+ 'definedClasses' => $this->definedClassesMock,
+ ]
+ );
+ }
+
+ /**
+ * generate repository name
+ */
+ public function testGenerate()
+ {
+ $generatedCode = 'Generated code';
+ $resultFileName = $this->getOutputFileName();
+
+ //Mocking _validateData call
+ $this->mockDefinedClassesCall();
+
+ $this->ioObjectMock->expects($this->once())
+ ->method('makeGenerationDirectory')
+ ->will($this->returnValue(true));
+ $this->ioObjectMock->expects($this->once())
+ ->method('makeResultFileDirectory')
+ ->with($this->getResultClassName())
+ ->will($this->returnValue(true));
+ $this->ioObjectMock->expects($this->once())
+ ->method('fileExists')
+ ->with($resultFileName)
+ ->will($this->returnValue(false));
+
+ //Mocking _generateCode call
+ $this->classGenerator->expects($this->once())
+ ->method('setName')
+ ->with($this->getResultClassName())
+ ->will($this->returnSelf());
+ $this->classGenerator->expects($this->once())
+ ->method('addProperties')
+ ->will($this->returnSelf());
+ $this->classGenerator->expects($this->once())
+ ->method('addMethods')
+ ->will($this->returnSelf());
+ $this->classGenerator->expects($this->once())
+ ->method('setClassDocBlock')
+ ->will($this->returnSelf());
+ $this->classGenerator->expects($this->once())
+ ->method('generate')
+ ->will($this->returnValue($generatedCode));
+
+ //Mocking generation
+ $this->ioObjectMock->expects($this->any())
+ ->method('getResultFileName')
+ ->with($this->getResultClassName())
+ ->will($this->returnValue($resultFileName));
+ $this->ioObjectMock->expects($this->once())
+ ->method('writeResultFile')
+ ->with($resultFileName, $generatedCode);
+
+ $this->assertEquals(
+ $resultFileName,
+ $this->generator->generate(),
+ implode("\n", $this->generator->getErrors())
+ );
+ }
+
+ protected function mockDefinedClassesCall()
+ {
+ $this->definedClassesMock->expects($this->at(0))
+ ->method('classLoadable')
+ ->with($this->getSourceClassName())
+ ->willReturn(true);
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateMapperTest.php b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateMapperTest.php
index aaf56f6d3ef69cf40cf2ab97a3d9b2daa802af65..2ada512059a1a638d9da6e5da2eefd4da92f9715 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateMapperTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateMapperTest.php
@@ -63,7 +63,8 @@ class GenerateMapperTest extends \PHPUnit_Framework_TestCase
null,
$this->ioObjectMock,
null,
- null
+ null,
+ $this->getMock('Magento\Framework\Filesystem\FileResolver')
]
);
$sampleMapperCode = file_get_contents(__DIR__ . '/_files/SampleMapper.txt');
@@ -78,6 +79,6 @@ class GenerateMapperTest extends \PHPUnit_Framework_TestCase
$model->expects($this->once())
->method('_validateData')
->will($this->returnValue(true));
- $this->assertTrue($model->generate());
+ $this->assertEquals('SampleMapper.php', $model->generate());
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateSearchResultsBuilderTest.php b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateSearchResultsBuilderTest.php
index 3f9381ad6d8bff245c7b1faa5535ec1a17fb95f0..c1954130078ec3a0c81e76c954877fa1f94d6692 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateSearchResultsBuilderTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateSearchResultsBuilderTest.php
@@ -66,7 +66,8 @@ class GenerateSearchResultsBuilderTest extends \PHPUnit_Framework_TestCase
null,
$this->ioObjectMock,
null,
- null
+ null,
+ $this->getMock('Magento\Framework\Filesystem\FileResolver')
]
);
$sampleSearchResultBuilderCode = file_get_contents(__DIR__ . '/_files/SampleSearchResultsBuilder.txt');
@@ -81,6 +82,6 @@ class GenerateSearchResultsBuilderTest extends \PHPUnit_Framework_TestCase
$model->expects($this->once())
->method('_validateData')
->will($this->returnValue(true));
- $this->assertTrue($model->generate(), implode("\n", $model->getErrors()));
+ $this->assertEquals('SampleSearchResultsBuilder.php', $model->generate(), implode("\n", $model->getErrors()));
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateSearchResultsTest.php b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateSearchResultsTest.php
index 5f37d35f5252efc90c78ec26260cf909e30b1871..6f14d396a876bdeef618b2c0f1b75eaf92d78c63 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateSearchResultsTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/GenerateSearchResultsTest.php
@@ -65,7 +65,8 @@ class GenerateSearchResultsTest extends \PHPUnit_Framework_TestCase
null,
$this->ioObjectMock,
null,
- null
+ null,
+ $this->getMock('Magento\Framework\Filesystem\FileResolver')
]
);
$sampleSearchResultBuilderCode = file_get_contents(__DIR__ . '/_files/SampleSearchResults.txt');
@@ -80,6 +81,6 @@ class GenerateSearchResultsTest extends \PHPUnit_Framework_TestCase
$model->expects($this->once())
->method('_validateData')
->will($this->returnValue(true));
- $this->assertTrue($model->generate());
+ $this->assertEquals('SampleSearchResults.php', $model->generate());
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/MapperTest.php b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/MapperTest.php
index 3732db6efa123afb6ba4eb93c06b525dc0b942dc..51b4a0b1970136755a67495b7100cb1fa4eeee66 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/MapperTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/MapperTest.php
@@ -29,127 +29,30 @@ use Magento\TestFramework\Helper\ObjectManager;
/**
* Class MapperTest
*/
-class MapperTest extends \PHPUnit_Framework_TestCase
+class MapperTest extends EntityChildTestAbstract
{
const SOURCE_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\Sample';
const RESULT_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\SampleMapper';
const GENERATOR_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\Mapper';
const OUTPUT_FILE_NAME = 'SampleMapper.php';
- /**
- * @var Io | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $ioObjectMock;
- /**
- * @var \Magento\Framework\Code\Generator\EntityAbstract
- */
- protected $generator;
-
- /**
- * @var \Magento\Framework\Code\Generator\FileResolver | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $fileResolvererMock;
-
- /**
- * @var \Magento\Framework\Code\Generator\CodeGenerator\Zend | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $classGenerator;
-
- protected function setUp()
+ protected function getSourceClassName()
{
- $this->ioObjectMock = $this->getMock(
- 'Magento\Framework\Code\Generator\Io',
- [],
- [],
- '',
- false
- );
- $this->fileResolvererMock = $this->getMock(
- 'Magento\Framework\Code\Generator\FileResolver',
- [],
- [],
- '',
- false
- );
- $this->classGenerator = $this->getMock(
- 'Magento\Framework\Code\Generator\CodeGenerator\Zend',
- [],
- [],
- '',
- false
- );
-
- $objectManager = new ObjectManager($this);
- $this->generator = $objectManager->getObject(
- self::GENERATOR_CLASS_NAME,
- [
- 'sourceClassName' => self::SOURCE_CLASS_NAME,
- 'resultClassName' => self::RESULT_CLASS_NAME,
- 'ioObject' => $this->ioObjectMock,
- 'classGenerator' => $this->classGenerator,
- 'fileResolver' => $this->fileResolvererMock
- ]
- );
+ return self::SOURCE_CLASS_NAME;
}
- /**
- * generate repository name
- */
- public function testGenerate()
+ protected function getResultClassName()
{
- $generatedCode = 'Generated code';
- $sourceFileName = 'Sample.php';
- $resultFileName = self::OUTPUT_FILE_NAME;
-
- //Mocking _validateData call
- $this->fileResolvererMock->expects($this->at(0))
- ->method('getFile')
- ->with(self::SOURCE_CLASS_NAME)
- ->will($this->returnValue($sourceFileName));
- $this->fileResolvererMock->expects($this->at(1))
- ->method('getFile')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue(false));
-
- $this->ioObjectMock->expects($this->once())
- ->method('makeGenerationDirectory')
- ->will($this->returnValue(true));
- $this->ioObjectMock->expects($this->once())
- ->method('makeResultFileDirectory')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue(true));
- $this->ioObjectMock->expects($this->once())
- ->method('fileExists')
- ->with($resultFileName)
- ->will($this->returnValue(false));
-
- //Mocking _generateCode call
- $this->classGenerator->expects($this->once())
- ->method('setName')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnSelf());
- $this->classGenerator->expects($this->once())
- ->method('addProperties')
- ->will($this->returnSelf());
- $this->classGenerator->expects($this->once())
- ->method('addMethods')
- ->will($this->returnSelf());
- $this->classGenerator->expects($this->once())
- ->method('setClassDocBlock')
- ->will($this->returnSelf());
- $this->classGenerator->expects($this->once())
- ->method('generate')
- ->will($this->returnValue($generatedCode));
+ return self::RESULT_CLASS_NAME;
+ }
- //Mocking generation
- $this->ioObjectMock->expects($this->any())
- ->method('getResultFileName')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue($resultFileName));
- $this->ioObjectMock->expects($this->once())
- ->method('writeResultFile')
- ->with($resultFileName, $generatedCode);
+ protected function getGeneratorClassName()
+ {
+ return self::GENERATOR_CLASS_NAME;
+ }
- $this->assertTrue($this->generator->generate());
+ protected function getOutputFileName()
+ {
+ return self::OUTPUT_FILE_NAME;
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/SearchResultsBuilderTest.php b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/SearchResultsBuilderTest.php
index acdca27b25844e74586271a37c3d1fa2116cc252..09c43005159c6ef077b314e865076845d828ba76 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/SearchResultsBuilderTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/SearchResultsBuilderTest.php
@@ -29,68 +29,31 @@ use Magento\TestFramework\Helper\ObjectManager;
/**
* Class MapperTest
*/
-class SearchResultsBuilderTest extends \PHPUnit_Framework_TestCase
+class SearchResultsBuilderTest extends EntityChildTestAbstract
{
const SOURCE_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\Sample';
const RESULT_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\SampleSearchResultsBuilder';
const GENERATOR_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\SearchResultsBuilder';
const OUTPUT_FILE_NAME = 'SampleSearchResultsBuilder.php';
- /**
- * @var Io | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $ioObjectMock;
-
- /**
- * @var \Magento\Framework\Code\Generator\EntityAbstract
- */
- protected $generator;
-
- /**
- * @var \Magento\Framework\Code\Generator\FileResolver | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $fileResolverMock;
+ protected function getSourceClassName()
+ {
+ return self::SOURCE_CLASS_NAME;
+ }
- /**
- * @var \Magento\Framework\Code\Generator\CodeGenerator\Zend | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $classGenerator;
+ protected function getResultClassName()
+ {
+ return self::RESULT_CLASS_NAME;
+ }
- protected function setUp()
+ protected function getGeneratorClassName()
{
- $this->ioObjectMock = $this->getMock(
- 'Magento\Framework\Code\Generator\Io',
- [],
- [],
- '',
- false
- );
- $this->fileResolverMock = $this->getMock(
- 'Magento\Framework\Code\Generator\FileResolver',
- [],
- [],
- '',
- false
- );
- $this->classGenerator = $this->getMock(
- 'Magento\Framework\Code\Generator\CodeGenerator\Zend',
- [],
- [],
- '',
- false
- );
+ return self::GENERATOR_CLASS_NAME;
+ }
- $objectManager = new ObjectManager($this);
- $this->generator = $objectManager->getObject(
- self::GENERATOR_CLASS_NAME,
- [
- 'sourceClassName' => self::SOURCE_CLASS_NAME,
- 'resultClassName' => self::RESULT_CLASS_NAME,
- 'ioObject' => $this->ioObjectMock,
- 'classGenerator' => $this->classGenerator,
- 'fileResolver' => $this->fileResolverMock
- ]
- );
+ protected function getOutputFileName()
+ {
+ return self::OUTPUT_FILE_NAME;
}
/**
@@ -99,18 +62,9 @@ class SearchResultsBuilderTest extends \PHPUnit_Framework_TestCase
public function testGenerate()
{
$generatedCode = 'Generated code';
- $sourceFileName = 'Sample.php';
$resultFileName = self::OUTPUT_FILE_NAME;
- //Mocking _validateData call
- $this->fileResolverMock->expects($this->at(0))
- ->method('getFile')
- ->with(self::SOURCE_CLASS_NAME)
- ->will($this->returnValue($sourceFileName));
- $this->fileResolverMock->expects($this->at(1))
- ->method('getFile')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue(false));
+ $this->mockDefinedClassesCall();
$this->ioObjectMock->expects($this->once())
->method('makeGenerationDirectory')
@@ -152,6 +106,10 @@ class SearchResultsBuilderTest extends \PHPUnit_Framework_TestCase
->method('writeResultFile')
->with($resultFileName, $generatedCode);
- $this->assertTrue($this->generator->generate());
+ $this->assertEquals(
+ $resultFileName,
+ $this->generator->generate(),
+ implode("\n", $this->generator->getErrors())
+ );
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/SearchResultsTest.php b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/SearchResultsTest.php
index cdc9ccd86a01b9f68605154628b0d20c202c4818..af57d5defb500954ab46f6fbc2b6d3f91a0ac908 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/SearchResultsTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/SearchResultsTest.php
@@ -29,68 +29,31 @@ use Magento\TestFramework\Helper\ObjectManager;
/**
* Class MapperTest
*/
-class SearchResultsTest extends \PHPUnit_Framework_TestCase
+class SearchResultsTest extends EntityChildTestAbstract
{
const SOURCE_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\Sample';
const RESULT_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\SampleSearchResults';
const GENERATOR_CLASS_NAME = 'Magento\Framework\Api\Code\Generator\SearchResults';
const OUTPUT_FILE_NAME = 'SampleSearchResults.php';
- /**
- * @var Io | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $ioObjectMock;
-
- /**
- * @var \Magento\Framework\Code\Generator\EntityAbstract
- */
- protected $generator;
-
- /**
- * @var \Magento\Framework\Code\Generator\FileResolver | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $fileResolverMock;
+ protected function getSourceClassName()
+ {
+ return self::SOURCE_CLASS_NAME;
+ }
- /**
- * @var \Magento\Framework\Code\Generator\CodeGenerator\Zend | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $classGenerator;
+ protected function getResultClassName()
+ {
+ return self::RESULT_CLASS_NAME;
+ }
- protected function setUp()
+ protected function getGeneratorClassName()
{
- $this->ioObjectMock = $this->getMock(
- 'Magento\Framework\Code\Generator\Io',
- [],
- [],
- '',
- false
- );
- $this->fileResolverMock = $this->getMock(
- 'Magento\Framework\Code\Generator\FileResolver',
- [],
- [],
- '',
- false
- );
- $this->classGenerator = $this->getMock(
- 'Magento\Framework\Code\Generator\CodeGenerator\Zend',
- [],
- [],
- '',
- false
- );
+ return self::GENERATOR_CLASS_NAME;
+ }
- $objectManager = new ObjectManager($this);
- $this->generator = $objectManager->getObject(
- self::GENERATOR_CLASS_NAME,
- [
- 'sourceClassName' => self::SOURCE_CLASS_NAME,
- 'resultClassName' => self::RESULT_CLASS_NAME,
- 'ioObject' => $this->ioObjectMock,
- 'classGenerator' => $this->classGenerator,
- 'fileResolver' => $this->fileResolverMock
- ]
- );
+ protected function getOutputFileName()
+ {
+ return self::OUTPUT_FILE_NAME;
}
/**
@@ -103,14 +66,7 @@ class SearchResultsTest extends \PHPUnit_Framework_TestCase
$resultFileName = self::OUTPUT_FILE_NAME;
//Mocking _validateData call
- $this->fileResolverMock->expects($this->at(0))
- ->method('getFile')
- ->with(self::SOURCE_CLASS_NAME)
- ->will($this->returnValue($sourceFileName));
- $this->fileResolverMock->expects($this->at(1))
- ->method('getFile')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue(false));
+ $this->mockDefinedClassesCall();
$this->ioObjectMock->expects($this->once())
->method('makeGenerationDirectory')
@@ -150,6 +106,10 @@ class SearchResultsTest extends \PHPUnit_Framework_TestCase
->method('writeResultFile')
->with($resultFileName, $generatedCode);
- $this->assertTrue($this->generator->generate());
+ $this->assertEquals(
+ $resultFileName,
+ $this->generator->generate(),
+ implode("\n", $this->generator->getErrors())
+ );
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/_files/ExtensibleSampleDataBuilder.txt b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/_files/ExtensibleSampleDataBuilder.txt
index 829ed168b5deb680c4cc9f7861f3323bda46e8cf..f1150ba27db5dafe5b6e0c5ea36c9a6021df480b 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/_files/ExtensibleSampleDataBuilder.txt
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/Code/Generator/_files/ExtensibleSampleDataBuilder.txt
@@ -55,10 +55,10 @@ class ExtensibleSampleDataBuilder extends \Magento\Framework\Api\Builder
* @param \Magento\Framework\Reflection\DataObjectProcessor $objectProcessor
* @param \Magento\Framework\Reflection\TypeProcessor $typeProcessor
* @param \Magento\Framework\Serialization\DataBuilderFactory $dataBuilderFactory
- * @param \Magento\Framework\ObjectManager\Config $objectManagerConfig
+ * @param \Magento\Framework\ObjectManager\ConfigInterface $objectManagerConfig
* @param string|null $modelClassInterface
*/
- public function __construct(\Magento\Framework\Api\ObjectFactory $objectFactory, \Magento\Framework\Api\MetadataServiceInterface $metadataService, \Magento\Framework\Api\AttributeDataBuilder $attributeValueBuilder, \Magento\Framework\Reflection\DataObjectProcessor $objectProcessor, \Magento\Framework\Reflection\TypeProcessor $typeProcessor, \Magento\Framework\Serialization\DataBuilderFactory $dataBuilderFactory, \Magento\Framework\ObjectManager\Config $objectManagerConfig, $modelClassInterface = null)
+ public function __construct(\Magento\Framework\Api\ObjectFactory $objectFactory, \Magento\Framework\Api\MetadataServiceInterface $metadataService, \Magento\Framework\Api\AttributeDataBuilder $attributeValueBuilder, \Magento\Framework\Reflection\DataObjectProcessor $objectProcessor, \Magento\Framework\Reflection\TypeProcessor $typeProcessor, \Magento\Framework\Serialization\DataBuilderFactory $dataBuilderFactory, \Magento\Framework\ObjectManager\ConfigInterface $objectManagerConfig, $modelClassInterface = null)
{
parent::__construct($objectFactory, $metadataService, $attributeValueBuilder, $objectProcessor, $typeProcessor, $dataBuilderFactory, $objectManagerConfig, 'Magento\Framework\Api\Code\Generator\ExtensibleSampleInterface');
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Api/SimpleDataObjectConverterTest.php b/dev/tests/unit/testsuite/Magento/Framework/Api/SimpleDataObjectConverterTest.php
index 5bb5caaff24ebf2c52d4ab189542610ac6e98ffe..a957d555a313daff7793c71f91296db1668b5b09 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Api/SimpleDataObjectConverterTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/SimpleDataObjectConverterTest.php
@@ -25,6 +25,8 @@
namespace Magento\Framework\Api;
use Magento\Customer\Service\V1\Data\Customer;
+use Magento\Framework\Api\AbstractSimpleObject;
+use Magento\Framework\Data\AbstractDataObject;
/**
* Class implements tests for SimpleDataObjectConverter class.
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest/TestClass.php b/dev/tests/unit/testsuite/Magento/Framework/Api/StubAbstractSimpleObject.php
similarity index 85%
rename from dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest/TestClass.php
rename to dev/tests/unit/testsuite/Magento/Framework/Api/StubAbstractSimpleObject.php
index ac61164033b5aed2e90f8f8d45df282c9e16340d..18c663045ee2d833aed666af6ee7210ac05eaee2 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest/TestClass.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/StubAbstractSimpleObject.php
@@ -21,8 +21,11 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\Framework\Autoload\IncludePathTest;
+namespace Magento\Framework\Api;
-class TestClass
+/**
+ * Class Stub for testing AbstractSimpleObjectBuilder class
+ */
+class StubAbstractSimpleObject extends AbstractSimpleObject
{
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest/constant.php b/dev/tests/unit/testsuite/Magento/Framework/Api/StubAbstractSimpleObjectBuilder.php
similarity index 83%
rename from dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest/constant.php
rename to dev/tests/unit/testsuite/Magento/Framework/Api/StubAbstractSimpleObjectBuilder.php
index 3c06cc194a8cb96e31808273e3ee372f1aadb7e1..2f3d51811588249d0340ef5430136a319af4fdff 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest/constant.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Api/StubAbstractSimpleObjectBuilder.php
@@ -21,4 +21,11 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-define('TEST_FIXTURE', $class);
+namespace Magento\Framework\Api;
+
+/**
+ * Class Stub for testing AbstractSimpleObjectBuilder class
+ */
+class StubAbstractSimpleObjectBuilder extends AbstractSimpleObjectBuilder
+{
+}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Action/ForwardTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Action/ForwardTest.php
index 419f930f809d80ff29b47ed6013ef18fd3204eda..33614994522453ce02211a638b4bbd022c6ad437 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/Action/ForwardTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/Action/ForwardTest.php
@@ -53,8 +53,7 @@ class ForwardTest extends \PHPUnit_Framework_TestCase
$cookieMetadataFactoryMock = $this->getMockBuilder(
'Magento\Framework\Stdlib\Cookie\CookieMetadataFactory'
)->disableOriginalConstructor()->getMock();
- $cookieManagerMock = $this->getMockBuilder('Magento\Framework\Stdlib\CookieManager')
- ->disableOriginalConstructor()->getMock();
+ $cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$contextMock = $this->getMockBuilder('Magento\Framework\App\Http\Context')->disableOriginalConstructor()
->getMock();
$this->response = $objectManager->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/AreaListTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/AreaListTest.php
index e3a4a94ec6e48264f5cc32979c96d7b24f8864b7..5a58c5e6a7221918e91f91e71be5e8bad9ba4483 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/AreaListTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/AreaListTest.php
@@ -42,7 +42,7 @@ class AreaListTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_resolverFactory = $this
->getMock('\Magento\Framework\App\Area\FrontNameResolverFactory', array(), array(), '', false);
}
@@ -138,7 +138,7 @@ class AreaListTest extends \PHPUnit_Framework_TestCase
public function testGetArea()
{
- /** @var \Magento\Framework\ObjectManager $objectManagerMock */
+ /** @var \Magento\Framework\ObjectManagerInterface $objectManagerMock */
$objectManagerMock = $this->getObjectManagerMockGetArea();
$areas = array('area1' => ['router' => 'value1'], 'area2' => 'value2');
$this->_model = new AreaList(
@@ -153,7 +153,7 @@ class AreaListTest extends \PHPUnit_Framework_TestCase
*/
protected function getObjectManagerMockGetArea()
{
- $objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', [], [], '', false);
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerMock
->expects($this->any())
->method('create')
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/BootstrapTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/BootstrapTest.php
index 7718bf0924f5504884d25379b61f577fb90838d0..052e98371efeab9363f5177e3027b76051457ba5 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/BootstrapTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/BootstrapTest.php
@@ -71,7 +71,7 @@ class BootstrapTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
$this->objectManagerFactory = $this->getMock('\Magento\Framework\App\ObjectManagerFactory', [], [], '', false);
- $this->objectManager = $this->getMockForAbstractClass('\Magento\Framework\ObjectManager');
+ $this->objectManager = $this->getMock('\Magento\Framework\ObjectManagerInterface');
$this->dirs = $this->getMock('\Magento\Framework\App\Filesystem\DirectoryList', ['getPath'], [], '', false);
$this->maintenanceMode = $this->getMock('\Magento\Framework\App\MaintenanceMode', ['isOn'], [], '', false);
$filesystem = $this->getMock('Magento\Framework\Filesystem', [], [], '', false);
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Cache/Frontend/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Cache/Frontend/FactoryTest.php
index 2bddd1c7e7354d732687dd8d2a900bf1ec2fe8d0..bf632f182e69c4a22b26acdb69eeead61a09691e 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/Cache/Frontend/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/Cache/Frontend/FactoryTest.php
@@ -156,7 +156,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
}
};
/** @var $objectManager \PHPUnit_Framework_MockObject_MockObject */
- $objectManager = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager->expects($this->any())->method('create')->will($this->returnCallback($processFrontendFunc));
$dirMock = $this->getMockForAbstractClass('Magento\Framework\Filesystem\Directory\ReadInterface');
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Cache/Type/FrontendPoolTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Cache/Type/FrontendPoolTest.php
index 63eecc9086ea81a4db5a2d430684e316d7139d52..05b9931c3878fb7dfd51feafc65c2ba0f0f76814 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/Cache/Type/FrontendPoolTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/Cache/Type/FrontendPoolTest.php
@@ -31,7 +31,7 @@ class FrontendPoolTest extends \PHPUnit_Framework_TestCase
protected $_model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManager;
@@ -47,7 +47,7 @@ class FrontendPoolTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_arguments = $this->getMock('Magento\Framework\App\Arguments', array(), array(), '', false);
$this->_cachePool = $this->getMock('Magento\Framework\App\Cache\Frontend\Pool', array(), array(), '', false);
$this->_model = new FrontendPool(
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Config/Data/BackendModelPoolTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Config/Data/BackendModelPoolTest.php
index 30f27e772f1bfc92eb919bd03dfcad08f7dd6486..7baba2b23fe889bd7a489810e3a3020203fca091 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/Config/Data/BackendModelPoolTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/Config/Data/BackendModelPoolTest.php
@@ -36,13 +36,13 @@ class BackendModelPoolTest extends \PHPUnit_Framework_TestCase
protected $_processorMock;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Framework\App\Config\Data\ProcessorFactory($this->_objectManager);
$this->_processorMock = $this->getMockForAbstractClass('Magento\Framework\App\Config\Data\ProcessorInterface');
$this->_processorMock->expects($this->any())->method('processValue')->will($this->returnArgument(0));
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/FactoryStub.php b/dev/tests/unit/testsuite/Magento/Framework/App/FactoryStub.php
index 12c0120a65a24eb80f5d0dcee4972e3c60ea0fda..f058adfa428866acc0c6428070d0059324a1529c 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/FactoryStub.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/FactoryStub.php
@@ -26,12 +26,12 @@ namespace Magento\Framework\App;
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
-class FactoryStub implements \Magento\Framework\ObjectManager\Factory
+class FactoryStub implements \Magento\Framework\ObjectManager\FactoryInterface
{
/**
- * @param \Magento\Framework\ObjectManager\Config $config
- * @param \Magento\Framework\ObjectManager $objectManager
- * @param \Magento\Framework\ObjectManager\Definition $definitions
+ * @param \Magento\Framework\ObjectManager\ConfigInterface $config
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
+ * @param \Magento\Framework\ObjectManager\DefinitionInterface $definitions
* @param array $globalArguments
* @throws \BadMethodCallException
*/
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Helper/AbstractHelperTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Helper/AbstractHelperTest.php
index 3051905c3d70ed35a46c2ce56da3d040be57050e..505dbc6c7a6f3ebe390a0637b481ed691c99a467 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/Helper/AbstractHelperTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/Helper/AbstractHelperTest.php
@@ -94,23 +94,4 @@ class AbstractHelperTest extends \PHPUnit_Framework_TestCase
['Module\\Name', 'Module\\Name', true],
];
}
-
- /**
- * @covers \Magento\Framework\App\Helper\AbstractHelper::urlEncode
- * @covers \Magento\Framework\App\Helper\AbstractHelper::urlDecode
- */
- public function testUrlDecode()
- {
- $data = uniqid();
- $result = $this->helper->urlEncode($data);
- $this->urlBuilderMock->expects($this->once())
- ->method('sessionUrlVar')
- ->with($this->equalTo($data))
- ->will($this->returnValue($result));
- $this->assertNotContains('&', $result);
- $this->assertNotContains('%', $result);
- $this->assertNotContains('+', $result);
- $this->assertNotContains('=', $result);
- $this->assertEquals($result, $this->helper->urlDecode($result));
- }
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/HttpTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/HttpTest.php
index 790e3fa7a77df3e92afd95350114cdc022fc50b3..37771d24a92ae71b9fdc640a70e25ac5a9898842 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/HttpTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/HttpTest.php
@@ -86,10 +86,7 @@ class HttpTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods(['load'])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods(['configure', 'get', 'create'])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->responseMock = $this->getMockBuilder('Magento\Framework\App\Response\Http')
->disableOriginalConstructor()
->setMethods(['setBody', '__wakeup', 'sendHeaders', 'sendResponse', 'setRedirect'])
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/PageCache/FormKeyTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/PageCache/FormKeyTest.php
index 8c194b0e626b78315590dbcce95c5eec424d6568..cbc9c2e321b60976133cf6b026ffb8d65c4dd611 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/PageCache/FormKeyTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/PageCache/FormKeyTest.php
@@ -39,7 +39,7 @@ class FormKeyTest extends \PHPUnit_Framework_TestCase
/**
* Cookie mock
*
- * @var \Magento\Framework\Stdlib\CookieManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $cookieManagerMock;
@@ -49,8 +49,7 @@ class FormKeyTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
$objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->cookieManagerMock = $this->getMockBuilder('Magento\Framework\Stdlib\CookieManager')
- ->disableOriginalConstructor()->getMock();
+ $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->formKey = $objectManager->getObject(
'Magento\Framework\App\PageCache\FormKey',
['cookieManager' => $this->cookieManagerMock]
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/PageCache/VersionTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/PageCache/VersionTest.php
index e3e0e1de7ac81fa589c21833d1053baee65a3f80..96393dc0abbf2ed3d6e28cefb3085fa9a0523653 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/PageCache/VersionTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/PageCache/VersionTest.php
@@ -37,7 +37,7 @@ class VersionTest extends \PHPUnit_Framework_TestCase
/**
* Cookie manager mock
*
- * @var \Magento\Framework\Stdlib\CookieManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $cookieManagerMock;
@@ -61,8 +61,7 @@ class VersionTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
$objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->cookieManagerMock = $this->getMockBuilder('Magento\Framework\Stdlib\CookieManager')
- ->disableOriginalConstructor()->getMock();
+ $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->requestMock = $this->getMockBuilder('Magento\Framework\App\Request\Http')
->disableOriginalConstructor()->getMock();
$this->cookieMetadataFactoryMock = $this->getMockBuilder(
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Request/HttpTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Request/HttpTest.php
index d6709c7f3d26f828fbdfdef7a9a2575854f433d6..c759ad9d1694ebde72c81b53a54313caf74b9f72 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/Request/HttpTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/Request/HttpTest.php
@@ -44,7 +44,7 @@ class HttpTest extends \PHPUnit_Framework_TestCase
protected $_infoProcessorMock;
/**
- * @var \Magento\Framework\Stdlib\CookieManager | \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface | \PHPUnit_Framework_MockObject_MockObject
*/
protected $_cookieManagerMock;
@@ -66,7 +66,7 @@ class HttpTest extends \PHPUnit_Framework_TestCase
);
$this->_infoProcessorMock = $this->getMock('Magento\Framework\App\Request\PathInfoProcessorInterface');
$this->_infoProcessorMock->expects($this->any())->method('process')->will($this->returnArgument(1));
- $this->_cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManager');
+ $this->_cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
}
public function testGetOriginalPathInfoWithTestUri()
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/RequestFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/RequestFactoryTest.php
index cdaacceb349c264977459646c11ed8e412f8b2b1..76bd7df0d77d7a66f14c1635043529c3245dd541 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/RequestFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/RequestFactoryTest.php
@@ -31,13 +31,13 @@ class RequestFactoryTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->model = new RequestFactory($this->objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Resource/ConnectionFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Resource/ConnectionFactoryTest.php
index 0a6efa0f037cd57c3a0313c2aadc67ca5a089aca..a6358f0d34eb18cf9d76315e488a469581937619 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/Resource/ConnectionFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/Resource/ConnectionFactoryTest.php
@@ -31,7 +31,7 @@ class ConnectionFactoryTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManager;
@@ -42,13 +42,7 @@ class ConnectionFactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManager = $this->getMock(
- '\Magento\Framework\ObjectManager',
- [],
- [],
- '',
- false
- );
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->localConfig = $this->getMock(
'\Magento\Framework\App\Arguments',
[],
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Response/HttpTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Response/HttpTest.php
index 11c5c2a8c2eb6eacaf13261962206b46f48e88b3..9b04b86151266f842ea220af01f3ced47a192a6a 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/Response/HttpTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/Response/HttpTest.php
@@ -34,7 +34,7 @@ class HttpTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\Stdlib\CookieManager
+ * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $cookieManagerMock;
@@ -55,8 +55,7 @@ class HttpTest extends \PHPUnit_Framework_TestCase
$this->cookieMetadataFactoryMock = $this->getMockBuilder(
'Magento\Framework\Stdlib\Cookie\CookieMetadataFactory'
)->disableOriginalConstructor()->getMock();
- $this->cookieManagerMock = $this->getMockBuilder('Magento\Framework\Stdlib\CookieManager')
- ->disableOriginalConstructor()->getMock();
+ $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->contextMock = $this->getMockBuilder('Magento\Framework\App\Http\Context')->disableOriginalConstructor()
->getMock();
$this->model = $objectManager->getObject(
@@ -289,7 +288,7 @@ class HttpTest extends \PHPUnit_Framework_TestCase
$objectManagerMock = $this->getMock('Magento\Framework\App\ObjectManager', [], [], '', false);
$objectManagerMock->expects($this->once())
->method('create')
- ->with('Magento\Framework\Stdlib\CookieManager')
+ ->with('Magento\Framework\Stdlib\CookieManagerInterface')
->will($this->returnValue($this->cookieManagerMock));
$objectManagerMock->expects($this->once())
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/ResponseFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/ResponseFactoryTest.php
index efdcb6347bd7413feeb07bb0fe870d59a4caf933..52927d5a466f6c0936e2d9fc10d85a20541aba8f 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/ResponseFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/ResponseFactoryTest.php
@@ -42,7 +42,7 @@ class ResponseFactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Framework\App\ResponseFactory($this->_objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/RouterListTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/RouterListTest.php
index 517b3fb5e3c723c96d2edee412dfda8bf22d6136..ef3d2a5dd4ff4a1746d2341b6f7217fd5f88792b 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/RouterListTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/RouterListTest.php
@@ -33,7 +33,7 @@ class RouterListTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -52,7 +52,7 @@ class RouterListTest extends \PHPUnit_Framework_TestCase
'anotherRouter' => array('class' => 'AnotherClass', 'disable' => false, 'sortOrder' => 15),
);
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->model = new \Magento\Framework\App\RouterList($this->objectManagerMock, $this->routerList);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/StaticResourceTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/StaticResourceTest.php
index 5bf35551dd1366fe1ed304d26f51b7e9664b68f8..448cb913fc510aeecbb670bbabcf78a250c8df40 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/App/StaticResourceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/App/StaticResourceTest.php
@@ -56,7 +56,7 @@ class StaticResourceTest extends \PHPUnit_Framework_TestCase
private $moduleList;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
private $objectManager;
@@ -78,7 +78,7 @@ class StaticResourceTest extends \PHPUnit_Framework_TestCase
$this->publisher = $this->getMock('Magento\Framework\App\View\Asset\Publisher', array(), array(), '', false);
$this->assetRepo = $this->getMock('Magento\Framework\View\Asset\Repository', array(), array(), '', false);
$this->moduleList = $this->getMock('Magento\Framework\Module\ModuleList', array(), array(), '', false);
- $this->objectManager = $this->getMockForAbstractClass('Magento\Framework\ObjectManager');
+ $this->objectManager = $this->getMockForAbstractClass('Magento\Framework\ObjectManagerInterface');
$this->configLoader = $this->getMock(
'Magento\Framework\App\ObjectManager\ConfigLoader', array(), array(), '', false
);
diff --git a/dev/tests/unit/testsuite/Magento/Framework/AuthorizationTest.php b/dev/tests/unit/testsuite/Magento/Framework/AuthorizationTest.php
index 567d66c45c0d3ff60ea1242e1b38847b0f55498c..2e29bbacf6e793fe355a9dc44e954d4bf9d66bbe 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/AuthorizationTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/AuthorizationTest.php
@@ -43,8 +43,8 @@ class AuthorizationTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_policyMock = $this->getMock('Magento\Framework\Authorization\Policy', array(), array(), '', false);
- $roleLocatorMock = $this->getMock('Magento\Framework\Authorization\RoleLocator', array(), array(), '', false);
+ $this->_policyMock = $this->getMock('Magento\Framework\Authorization\PolicyInterface');
+ $roleLocatorMock = $this->getMock('Magento\Framework\Authorization\RoleLocatorInterface');
$roleLocatorMock->expects($this->any())->method('getAclRoleId')->will($this->returnValue('U1'));
$this->_model = new \Magento\Framework\Authorization($this->_policyMock, $roleLocatorMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassLoaderWrapperTest.php b/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassLoaderWrapperTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..34f666125ebedf76fc01f3dadb65d1fd14b2dda0
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassLoaderWrapperTest.php
@@ -0,0 +1,118 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Autoload;
+
+use \Composer\Autoload\ClassLoader;
+use \Magento\TestFramework\Helper\ObjectManager;
+
+class ClassLoaderWrapperTest extends \PHPUnit_Framework_TestCase
+{
+
+ const PREFIX = 'Namespace\\Prefix\\';
+
+ const DIR = '/path/to/class/';
+
+ const DEFAULT_PREPEND = false;
+
+
+ /**
+ * @var ClassLoader | \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $autoloaderMock;
+
+ /**
+ * @var \Magento\Framework\Autoload\ClassLoaderWrapper
+ */
+ protected $model;
+
+ public function setUp()
+ {
+ $this->autoloaderMock = $this->getMock('Composer\Autoload\ClassLoader');
+ $this->model = (new ObjectManager($this))->getObject('Magento\Framework\Autoload\ClassLoaderWrapper',
+ [
+ 'autoloader' => $this->autoloaderMock
+ ]
+ );
+ }
+
+ public function testAdd()
+ {
+ $prepend = true;
+
+ $this->autoloaderMock->expects($this->once())
+ ->method('add')
+ ->with(self::PREFIX, self::DIR, $prepend);
+
+ $this->model->addPsr0(self::PREFIX, self::DIR, $prepend);
+ }
+
+ public function testAddPsr4()
+ {
+ $prepend = true;
+
+ $this->autoloaderMock->expects($this->once())
+ ->method('addPsr4')
+ ->with(self::PREFIX, self::DIR, $prepend);
+
+ $this->model->addPsr4(self::PREFIX, self::DIR, $prepend);
+ }
+
+ public function testAddDefault()
+ {
+ $this->autoloaderMock->expects($this->once())
+ ->method('add')
+ ->with(self::PREFIX, self::DIR, self::DEFAULT_PREPEND);
+
+ $this->model->addPsr0(self::PREFIX, self::DIR);
+ }
+
+ public function testAddPsr4Default()
+ {
+ $this->autoloaderMock->expects($this->once())
+ ->method('addPsr4')
+ ->with(self::PREFIX, self::DIR, self::DEFAULT_PREPEND);
+
+ $this->model->addPsr4(self::PREFIX, self::DIR);
+ }
+
+ public function testSet()
+ {
+ $paths = [self::DIR];
+ $this->autoloaderMock->expects($this->once())
+ ->method('set')
+ ->with(self::PREFIX, $paths);
+
+ $this->model->setPsr0(self::PREFIX, $paths);
+ }
+
+ public function testSetPsr4()
+ {
+ $paths = [self::DIR];
+ $this->autoloaderMock->expects($this->once())
+ ->method('setPsr4')
+ ->with(self::PREFIX, $paths);
+
+ $this->model->setPsr4(self::PREFIX, $paths);
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassMapTest.php b/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassMapTest.php
deleted file mode 100644
index 9c3980a6af798882c2ec4860cc8ce091686f8bb7..0000000000000000000000000000000000000000
--- a/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassMapTest.php
+++ /dev/null
@@ -1,74 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\Framework\Autoload;
-
-class ClassMapTest extends \PHPUnit_Framework_TestCase
-{
- /**
- * @var \Magento\Framework\Autoload\ClassMap
- */
- protected $_loader = null;
-
- protected function setUp()
- {
- $this->_loader = new \Magento\Framework\Autoload\ClassMap(__DIR__ . '/ClassMapTest');
- }
-
- /**
- * @expectedException \InvalidArgumentException
- */
- public function testConstructNonExistent()
- {
- new \Magento\Framework\Autoload\ClassMap('non_existent');
- }
-
- /**
- * @expectedException \InvalidArgumentException
- */
- public function testConstructNotDir()
- {
- new \Magento\Framework\Autoload\ClassMap(__FILE__);
- }
-
- public function testGetFileAddMap()
- {
-
- $this->assertFalse($this->_loader->getFile('TestMap'));
- $this->assertFalse($this->_loader->getFile('Non_Existent_Class'));
- $this->assertSame($this->_loader, $this->_loader->addMap(array('TestMap' => 'TestMap.php')));
- $this->assertFileExists($this->_loader->getFile('TestMap'));
- $this->assertFalse($this->_loader->getFile('Non_Existent_Class'));
- }
-
- public function testLoad()
- {
- $this->_loader->addMap(array('TestMap' => 'TestMap.php', 'Unknown_Class' => 'invalid_file.php'));
- $this->assertFalse(class_exists('TestMap', false));
- $this->assertFalse(class_exists('Unknown_Class', false));
- $this->_loader->load('TestMap');
- $this->_loader->load('Unknown_Class');
- $this->assertTrue(class_exists('Magento\Framework\Autoload\ClassMapTest\TestMap', false));
- $this->assertFalse(class_exists('Unknown_Class', false));
- }
-}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest.php b/dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest.php
deleted file mode 100644
index 3e120e7efebfcc66edfdbe641de3babf3a15d267..0000000000000000000000000000000000000000
--- a/dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest.php
+++ /dev/null
@@ -1,128 +0,0 @@
-<?php
-/**
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\Framework\Autoload;
-
-class IncludePathTest extends \PHPUnit_Framework_TestCase
-{
- /**
- * @var string
- */
- protected static $_originalPath = '';
-
- public static function setUpBeforeClass()
- {
- self::$_originalPath = get_include_path();
- }
-
- protected function tearDown()
- {
- set_include_path(self::$_originalPath);
- }
-
- /**
- * @param string $class
- * @param bool string|$expectedValue
- * @dataProvider getFileDataProvider
- */
- public function testGetFile($class, $expectedValue)
- {
- $this->assertFalse((new \Magento\Framework\Autoload\IncludePath())->getFile($class));
- (new \Magento\Framework\Autoload\IncludePath())->addIncludePath(__DIR__ . '/_files');
- $this->assertEquals($expectedValue, (new \Magento\Framework\Autoload\IncludePath())->getFile($class));
- }
-
- /**
- * @return array
- */
- public function getFileDataProvider()
- {
- return array(
- array('TestClass', realpath(__DIR__ . '/_files/TestClass.php')),
- array('\Ns\TestClass', realpath(__DIR__ . '/_files/Ns/TestClass.php')),
- array('Non_Existing_Class', false)
- );
- }
-
- /**
- * @dataProvider addIncludePathDataProvider
- *
- * @param string|array $fixturePath
- * @param bool $prepend
- * @param string $expectedIncludePath
- */
- public function testAddIncludePath($fixturePath, $prepend, $expectedIncludePath)
- {
- $expectedIncludePath = str_replace('%include_path%', get_include_path(), $expectedIncludePath);
- $this->assertNotEquals($expectedIncludePath, get_include_path());
- (new \Magento\Framework\Autoload\IncludePath())->addIncludePath($fixturePath, $prepend);
- $this->assertEquals($expectedIncludePath, get_include_path());
- }
-
- public function addIncludePathDataProvider()
- {
- $pathSeparator = PATH_SEPARATOR;
- return array(
- 'prepend string' => array('fixture_path', true, "fixture_path{$pathSeparator}%include_path%"),
- 'prepend array' => array(
- array('fixture_path_one', 'fixture_path_two'),
- true,
- "fixture_path_one{$pathSeparator}fixture_path_two{$pathSeparator}%include_path%"
- ),
- 'append string' => array('fixture_path', false, "%include_path%{$pathSeparator}fixture_path"),
- 'append array' => array(
- array('fixture_path_one', 'fixture_path_two'),
- false,
- "%include_path%{$pathSeparator}fixture_path_one{$pathSeparator}fixture_path_two"
- )
- );
- }
-
- /**
- * @param string $class
- * @param string|bool $expectedValue
- * @dataProvider getFileDataProvider
- */
- public function testLoad($class, $expectedValue)
- {
- (new \Magento\Framework\Autoload\IncludePath())->addIncludePath(__DIR__ . '/_files');
- $this->assertFalse(class_exists($class, false));
- (new \Magento\Framework\Autoload\IncludePath())->load($class);
- if ($expectedValue) {
- $this->assertTrue(class_exists($class, false));
- } else {
- $this->assertFalse(class_exists($class, false));
- }
- }
-
- public function testGetFilePath()
- {
- $original = '\Magento\Framework\ObjectManager\Factory\Factory';
- $result = 'Magento/Framework/ObjectManager/Factory/Factory.php';
- $this->assertEquals((new \Magento\Framework\Autoload\IncludePath())->getFilePath($original), $result);
-
- $original = 'Zend_Acl_Role_Registry_Exception';
- $result = 'Zend/Acl/Role/Registry/Exception.php';
- $this->assertEquals((new \Magento\Framework\Autoload\IncludePath())->getFilePath($original), $result);
- }
-}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Backup/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Backup/FactoryTest.php
index 1de67ad42277d1d2dd859ddf7a2d0c0fbf31f9ad..a95bf8529a7189b16075945c1464bd4c8e685006 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Backup/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Backup/FactoryTest.php
@@ -31,13 +31,13 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected $_model;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Framework\Backup\Factory($this->_objectManager);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Code/Generator/EntityAbstractTest.php b/dev/tests/unit/testsuite/Magento/Framework/Code/Generator/EntityAbstractTest.php
index 202f82b2bee4988a19dfba4ee769d4429f3d1e56..d787e4337879ba7b20241bb11b6153673084bf40 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Code/Generator/EntityAbstractTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Code/Generator/EntityAbstractTest.php
@@ -81,8 +81,8 @@ class EntityAbstractTest extends \PHPUnit_Framework_TestCase
$this->_model
);
$this->assertAttributeInstanceOf(
- 'Magento\Framework\Code\Generator\FileResolver',
- 'fileResolver',
+ 'Magento\Framework\Code\Generator\DefinedClasses',
+ 'definedClasses',
$this->_model
);
@@ -103,16 +103,14 @@ class EntityAbstractTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $fileResolver = $this->getMock('Magento\Framework\Code\Generator\FileResolver', array(), array(), '', false);
$this->_model = $this->getMockForAbstractClass(
'Magento\Framework\Code\Generator\EntityAbstract',
- array(self::SOURCE_CLASS, self::RESULT_CLASS, $ioObject, $codeGenerator, $fileResolver)
+ array(self::SOURCE_CLASS, self::RESULT_CLASS, $ioObject, $codeGenerator)
);
$this->assertAttributeEquals(self::RESULT_CLASS, '_resultClassName', $this->_model);
$this->assertAttributeEquals($ioObject, '_ioObject', $this->_model);
$this->assertAttributeEquals($codeGenerator, '_classGenerator', $this->_model);
- $this->assertAttributeEquals($fileResolver, 'fileResolver', $this->_model);
}
/**
@@ -236,7 +234,7 @@ class EntityAbstractTest extends \PHPUnit_Framework_TestCase
$this->assertFalse($result);
$this->assertEquals($errors, $this->_model->getErrors());
} else {
- $this->assertTrue($result);
+ $this->assertEquals('MyResult/MyResult.php', $result);
$this->assertEmpty($this->_model->getErrors());
}
}
@@ -261,7 +259,7 @@ class EntityAbstractTest extends \PHPUnit_Framework_TestCase
) {
$ioObject = $this->getMock(
'Magento\Framework\Code\Generator\Io',
- array(
+ [
'getResultFileName',
'makeGenerationDirectory',
'makeResultFileDirectory',
@@ -269,13 +267,12 @@ class EntityAbstractTest extends \PHPUnit_Framework_TestCase
'getGenerationDirectory',
'getResultFileDirectory',
'writeResultFile'
- ),
- array(),
+ ],
+ [],
'',
false
);
- $fileresolver = $this->getMock('Magento\Framework\Code\Generator\FileResolver', ['getFile'], [], '', false);
-
+ $definedClassesMock = $this->getMock('Magento\Framework\Code\Generator\DefinedClasses');
$ioObject->expects(
$this->any()
)->method(
@@ -300,20 +297,20 @@ class EntityAbstractTest extends \PHPUnit_Framework_TestCase
$this->returnValue(self::RESULT_DIRECTORY)
);
- $fileresolver->expects(
+ $definedClassesMock->expects(
$this->at(0)
)->method(
- 'getFile'
+ 'classLoadable'
)->with(
self::SOURCE_CLASS
)->will(
$this->returnValue($classExistsFirst)
);
- if ($classExistsFirst) {
- $fileresolver->expects(
+ if ($classExistsSecond) {
+ $definedClassesMock->expects(
$this->at(1)
)->method(
- 'getFile'
+ 'classLoadable'
)->with(
self::RESULT_CLASS
)->will(
@@ -321,12 +318,6 @@ class EntityAbstractTest extends \PHPUnit_Framework_TestCase
);
}
- $expectedInvocations = 1;
- if ($classExistsFirst) {
- $expectedInvocations = 2;
- }
- $fileresolver->expects($this->exactly($expectedInvocations))->method('getFile');
-
$expectedInvocations = 1;
if (!$classExistsFirst || $classExistsSecond) {
$expectedInvocations = 0;
@@ -348,13 +339,13 @@ class EntityAbstractTest extends \PHPUnit_Framework_TestCase
$fileExists
);
- return array(
+ return [
'source_class' => self::SOURCE_CLASS,
'result_class' => self::RESULT_CLASS,
'io_object' => $ioObject,
'code_generator' => null,
- 'autoloader' => $fileresolver
- );
+ 'definedClasses' => $definedClassesMock,
+ ];
}
/**
@@ -447,7 +438,7 @@ class EntityAbstractTest extends \PHPUnit_Framework_TestCase
'result_class' => $mocks['result_class'],
'io_object' => $ioObject,
'code_generator' => $codeGenerator,
- 'autoloader' => $mocks['autoloader']
+ 'definedClasses' => $mocks['definedClasses'],
);
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Code/Generator/IoTest.php b/dev/tests/unit/testsuite/Magento/Framework/Code/Generator/IoTest.php
index 36c4dfee260c8d8f4ae75487c662aedf6e98fe21..aa73eac8963692eb6d827257651160ebd7c7c065 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Code/Generator/IoTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Code/Generator/IoTest.php
@@ -57,11 +57,6 @@ class IoTest extends \PHPUnit_Framework_TestCase
*/
protected $_filesystemDriverMock;
- /**
- * @var \Magento\Framework\Autoload\IncludePath|\PHPUnit_Framework_MockObject_MockObject
- */
- protected $fileResolverMock;
-
protected function setUp()
{
$this->_generationDirectory = rtrim(self::GENERATION_DIRECTORY, '/') . '/';
@@ -72,26 +67,8 @@ class IoTest extends \PHPUnit_Framework_TestCase
array()
);
- $this->fileResolverMock = $this->getMock(
- 'Magento\Framework\Code\Generator\FileResolver',
- array('getFilePath'),
- array(),
- '',
- false
- );
- $this->fileResolverMock->expects(
- $this->any()
- )->method(
- 'getFilePath'
- )->with(
- self::CLASS_NAME
- )->will(
- $this->returnValue(self::CLASS_FILE_NAME)
- );
-
$this->_object = new \Magento\Framework\Code\Generator\Io(
$this->_filesystemDriverMock,
- $this->fileResolverMock,
self::GENERATION_DIRECTORY
);
}
@@ -100,20 +77,19 @@ class IoTest extends \PHPUnit_Framework_TestCase
{
unset($this->_generationDirectory);
unset($this->_filesystemMock);
- unset($this->fileResolverMock);
unset($this->_object);
unset($this->_filesystemDriverMock);
}
public function testGetResultFileDirectory()
{
- $expectedDirectory = self::GENERATION_DIRECTORY . '/' . 'class/file/';
+ $expectedDirectory = self::GENERATION_DIRECTORY . '/' . 'class/';
$this->assertEquals($expectedDirectory, $this->_object->getResultFileDirectory(self::CLASS_NAME));
}
public function testGetResultFileName()
{
- $expectedFileName = self::GENERATION_DIRECTORY . '/' . self::CLASS_FILE_NAME;
+ $expectedFileName = self::GENERATION_DIRECTORY . '/class/name.php';
$this->assertEquals($expectedFileName, $this->_object->getResultFileName(self::CLASS_NAME));
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Code/GeneratorTest.php b/dev/tests/unit/testsuite/Magento/Framework/Code/GeneratorTest.php
index 3ee1604c0b4078ab6e4e2817fd68f156afe3ac55..520943dfd52364ef10f3a283e17d2712e2b30f77 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Code/GeneratorTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Code/GeneratorTest.php
@@ -35,11 +35,11 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
*
* @var array
*/
- protected $expectedEntities = array(
+ protected $expectedEntities = [
'factory' => \Magento\Framework\ObjectManager\Code\Generator\Factory::ENTITY_TYPE,
'proxy' => \Magento\Framework\ObjectManager\Code\Generator\Proxy::ENTITY_TYPE,
'interceptor' => \Magento\Framework\Interception\Code\Generator\Interceptor::ENTITY_TYPE
- );
+ ];
/**
* Model under test
@@ -48,30 +48,14 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
*/
protected $model;
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\Autoload\IncludePath
- */
- protected $fileResolver;
-
/**
* @var \PHPUnit_Framework_MockObject_MockObject|Generator\Io
*/
protected $ioObjectMock;
- /**
- * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\Filesystem
- */
- protected $filesystemMock;
-
protected function setUp()
{
- $this->fileResolver = $this->getMock(
- 'Magento\Framework\Code\Generator\FileResolver',
- array('getFile'),
- array(),
- '',
- false
- );
+
$this->ioObjectMock = $this->getMockBuilder('\Magento\Framework\Code\Generator\Io')
->disableOriginalConstructor()
->getMock();
@@ -80,15 +64,13 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
protected function tearDown()
{
unset($this->model);
- unset($this->fileResolver);
}
public function testGetGeneratedEntities()
{
$this->model = new \Magento\Framework\Code\Generator(
- $this->fileResolver,
$this->ioObjectMock,
- array('factory', 'proxy', 'interceptor')
+ ['factory', 'proxy', 'interceptor']
);
$this->assertEquals(array_values($this->expectedEntities), $this->model->getGeneratedEntities());
}
@@ -99,19 +81,13 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
*/
public function testGenerateClass($className, $entityType)
{
- $this->fileResolver->expects($this->any())
- ->method('getFile')
- ->with($className . $entityType)
- ->will($this->returnValue(false));
-
$this->model = new \Magento\Framework\Code\Generator(
- $this->fileResolver,
$this->ioObjectMock,
- array(
+ [
'factory' => '\Magento\Framework\ObjectManager\Code\Generator\Factory',
'proxy' => '\Magento\Framework\ObjectManager\Code\Generator\Proxy',
'interceptor' => '\Magento\Framework\Interception\Code\Generator\Interceptor'
- )
+ ]
);
$this->model->generateClass($className . $entityType);
@@ -122,19 +98,18 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
*/
public function testGenerateClassWithExistName($className, $entityType)
{
- $this->fileResolver->expects($this->once())
- ->method('getFile')
- ->with($className . $entityType)
- ->will($this->returnValue(true));
-
+ $definedClassesMock = $this->getMock('Magento\Framework\Code\Generator\DefinedClasses');
+ $definedClassesMock->expects($this->any())
+ ->method('classLoadable')
+ ->willReturn(true);
$this->model = new \Magento\Framework\Code\Generator(
- $this->fileResolver,
$this->ioObjectMock,
- array(
+ [
'factory' => '\Magento\Framework\ObjectManager\Code\Generator\Factory',
'proxy' => '\Magento\Framework\ObjectManager\Code\Generator\Proxy',
'interceptor' => '\Magento\Framework\Interception\Code\Generator\Interceptor'
- )
+ ],
+ $definedClassesMock
);
$this->assertEquals(
@@ -145,9 +120,7 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
public function testGenerateClassWithWrongName()
{
- $this->fileResolver->expects($this->never())->method('getFile');
-
- $this->model = new \Magento\Framework\Code\Generator($this->fileResolver, $this->ioObjectMock);
+ $this->model = new \Magento\Framework\Code\Generator($this->ioObjectMock);
$this->assertEquals(
\Magento\Framework\Code\Generator::GENERATION_ERROR,
@@ -160,16 +133,13 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
*/
public function testGenerateClassWithError()
{
- $this->fileResolver->expects($this->once())->method('getFile')->will($this->returnValue(false));
-
$this->model = new \Magento\Framework\Code\Generator(
- $this->fileResolver,
$this->ioObjectMock,
- array(
+ [
'factory' => '\Magento\Framework\ObjectManager\Code\Generator\Factory',
'proxy' => '\Magento\Framework\ObjectManager\Code\Generator\Proxy',
'interceptor' => '\Magento\Framework\Interception\Code\Generator\Interceptor'
- )
+ ]
);
$expectedEntities = array_values($this->expectedEntities);
@@ -185,13 +155,13 @@ class GeneratorTest extends \PHPUnit_Framework_TestCase
*/
public function generateValidClassDataProvider()
{
- $data = array();
+ $data = [];
foreach ($this->expectedEntities as $generatedEntity) {
$generatedEntity = ucfirst($generatedEntity);
- $data['test class for ' . $generatedEntity] = array(
+ $data['test class for ' . $generatedEntity] = [
'class name' => self::SOURCE_CLASS,
'entity type' => $generatedEntity
- );
+ ];
}
return $data;
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Controller/Router/Route/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Controller/Router/Route/FactoryTest.php
index 51ab0fd49716b17b055c7acd1faa06e11310200d..4ecdbfb9d9faea5989659c4c12993df2783324cf 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Controller/Router/Route/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Controller/Router/Route/FactoryTest.php
@@ -27,15 +27,13 @@ namespace Magento\Framework\Controller\Router\Route;
class FactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\ObjectManager
+ * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
public function setUp()
{
- $this->objectManager = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
}
/**
diff --git a/dev/tests/unit/testsuite/Magento/Framework/DB/AbstractMapperTest.php b/dev/tests/unit/testsuite/Magento/Framework/DB/AbstractMapperTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..8787e85489c60f7c648c6670b4e18408e5fce1af
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/DB/AbstractMapperTest.php
@@ -0,0 +1,319 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\DB;
+
+/**
+ * Class AbstractMapperTest
+ */
+class AbstractMapperTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Framework\Model\Resource\Db\AbstractDb|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $resourceMock;
+
+ /**
+ * @var \Magento\Framework\DB\Adapter\AdapterInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $connectionMock;
+
+ /**
+ * @var \Magento\Framework\DB\Select|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $selectMock;
+
+ /**
+ * @var \Magento\Framework\Logger|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $loggerMock;
+
+ /**
+ * @var \Magento\Framework\Data\Collection\Db\FetchStrategyInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $fetchStrategyMock;
+
+ /**
+ * @var \Magento\Framework\Data\ObjectFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $objectFactoryMock;
+
+ /**
+ * @var \Magento\Framework\DB\MapperFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $mapperFactoryMock;
+
+ /**
+ * @var \Magento\Framework\DB\AbstractMapper|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $mapper;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $this->resourceMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Model\Resource\Db\AbstractDb',
+ [],
+ '',
+ false,
+ true,
+ true,
+ []
+ );
+ $this->connectionMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\DB\Adapter\AdapterInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ []
+ );
+ $this->selectMock = $this->getMock(
+ 'Magento\Framework\DB\Select',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->loggerMock = $this->getMock(
+ 'Magento\Framework\Logger',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->fetchStrategyMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Data\Collection\Db\FetchStrategyInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ []
+ );
+ $this->objectFactoryMock = $this->getMock(
+ 'Magento\Framework\Data\ObjectFactory',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->mapperFactoryMock = $this->getMock(
+ 'Magento\Framework\DB\MapperFactory',
+ [],
+ [],
+ '',
+ false
+ );
+ }
+
+ /**
+ * Run test map method
+ *
+ * @param array $mapperMethods
+ * @param array $criteriaParts
+ * @return void
+ *
+ * @dataProvider dataProviderMap
+ */
+ public function testMap(array $mapperMethods, array $criteriaParts)
+ {
+ /** @var \Magento\Framework\DB\AbstractMapper|\PHPUnit_Framework_MockObject_MockObject $mapper */
+ $mapper = $this->getMockForAbstractClass(
+ 'Magento\Framework\DB\AbstractMapper',
+ [
+ 'logger' => $this->loggerMock,
+ 'fetchStrategy' => $this->fetchStrategyMock,
+ 'objectFactory' => $this->objectFactoryMock,
+ 'mapperFactory' => $this->mapperFactoryMock,
+ 'select' => $this->selectMock
+ ],
+ '',
+ true,
+ true,
+ true,
+ $mapperMethods
+ );
+ $criteriaMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Api\CriteriaInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['toArray']
+ );
+ $criteriaMock->expects($this->once())
+ ->method('toArray')
+ ->will($this->returnValue($criteriaParts));
+ foreach ($mapperMethods as $value => $method) {
+ $mapper->expects($this->once())
+ ->method($method)
+ ->with($value);
+ }
+
+ $this->assertEquals($this->selectMock, $mapper->map($criteriaMock));
+ }
+
+ /**
+ * Run test addExpressionFieldToSelect method
+ *
+ * @return void
+ */
+ public function testAddExpressionFieldToSelect()
+ {
+ $fields = [
+ 'key-attribute' => 'value-attribute'
+ ];
+ /** @var \Magento\Framework\DB\AbstractMapper|\PHPUnit_Framework_MockObject_MockObject $mapper */
+ $mapper = $this->getMockForAbstractClass(
+ 'Magento\Framework\DB\AbstractMapper',
+ [
+ 'logger' => $this->loggerMock,
+ 'fetchStrategy' => $this->fetchStrategyMock,
+ 'objectFactory' => $this->objectFactoryMock,
+ 'mapperFactory' => $this->mapperFactoryMock,
+ 'select' => $this->selectMock
+ ],
+ '',
+ true,
+ true,
+ true,
+ []
+ );
+
+ $this->selectMock->expects($this->once())
+ ->method('columns')
+ ->with(['my-alias' => "('sub_total', 'SUM(value-attribute)', 'revenue')"]);
+
+ $mapper->addExpressionFieldToSelect('my-alias', "('sub_total', 'SUM({{key-attribute}})', 'revenue')", $fields);
+ }
+
+ /**
+ * Run test addExpressionFieldToSelect method
+ *
+ * @param mixed $field
+ * @param mixed $condition
+ * @return void
+ *
+ * @dataProvider dataProviderAddFieldToFilter
+ */
+ public function testAddFieldToFilter($field, $condition)
+ {
+ $resultCondition = 'sql-condition-value';
+
+ /** @var \Magento\Framework\DB\AbstractMapper|\PHPUnit_Framework_MockObject_MockObject $mapper */
+ $mapper = $this->getMockForAbstractClass(
+ 'Magento\Framework\DB\AbstractMapper',
+ [
+ 'logger' => $this->loggerMock,
+ 'fetchStrategy' => $this->fetchStrategyMock,
+ 'objectFactory' => $this->objectFactoryMock,
+ 'mapperFactory' => $this->mapperFactoryMock,
+ 'select' => $this->selectMock
+ ],
+ '',
+ true,
+ true,
+ true,
+ ['getConnection']
+ );
+ $connectionMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\DB\Adapter\AdapterInterface',
+ [],
+ '',
+ true,
+ true,
+ true,
+ ['quoteIdentifier', 'prepareSqlCondition']
+ );
+
+ $mapper->expects($this->any())
+ ->method('getConnection')
+ ->will($this->returnValue($connectionMock));
+ $connectionMock->expects($this->any())
+ ->method('quoteIdentifier')
+ ->with('my-field')
+ ->will($this->returnValue('quote-field'));
+ $connectionMock->expects($this->any())
+ ->method('prepareSqlCondition')
+ ->with('quote-field', $condition)
+ ->will($this->returnValue($resultCondition));
+
+ if (is_array($field)) {
+ $resultCondition = '(' . implode(') ' . \Zend_Db_Select::SQL_OR
+ . ' (', array_fill(0, count($field), $resultCondition)) . ')';
+ }
+
+ $this->selectMock->expects($this->once())
+ ->method('where')
+ ->with($resultCondition, null, Select::TYPE_CONDITION);
+
+ $mapper->addFieldToFilter($field, $condition);
+ }
+
+ /**
+ * Data provider for map method
+ *
+ * @return array
+ */
+ public function dataProviderMap()
+ {
+ return [
+ [
+ 'mapperMethods' => [
+ 'my-test-value1' => 'mapMyMapperMethodOne',
+ 'my-test-value2' => 'mapMyMapperMethodTwo'
+ ],
+ 'criteriaParts' => [
+ 'my_mapper_method_one' => 'my-test-value1',
+ 'my_mapper_method_two' => 'my-test-value2'
+ ]
+ ]
+ ];
+ }
+
+ /**
+ * Data provider for addFieldToFilter method
+ *
+ * @return array
+ */
+ public function dataProviderAddFieldToFilter()
+ {
+ return [
+ [
+ 'field' => 'my-field',
+ 'condition' => ['condition']
+ ],
+ [
+ 'field' => ['my-field', 'my-field'],
+ 'condition' => null
+ ],
+ ];
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/DB/GenericMapperTest.php b/dev/tests/unit/testsuite/Magento/Framework/DB/GenericMapperTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..b0ebd169e4b49bb19d8ebbe0fe13d73a9ad36fb2
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/DB/GenericMapperTest.php
@@ -0,0 +1,239 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\DB;
+
+/**
+ * Class GenericMapperTest
+ */
+class GenericMapperTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Framework\DB\Select|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $selectMock;
+
+ /**
+ * @var \Magento\Framework\DB\MapperFactory|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $mapperFactoryMock;
+
+ /**
+ * @var \Magento\Framework\DB\GenericMapper
+ */
+ protected $geneticMapper;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->selectMock = $this->getMock(
+ 'Magento\Framework\DB\Select',
+ ['orWhere', 'where', 'setPart', 'getPart'],
+ [],
+ '',
+ false
+ );
+ $this->mapperFactoryMock = $this->getMock(
+ 'Magento\Framework\DB\MapperFactory',
+ ['create'],
+ [],
+ '',
+ false
+ );
+
+ $this->geneticMapper = $objectManager->getObject(
+ 'Magento\Framework\DB\GenericMapper',
+ [
+ 'select' => $this->selectMock,
+ 'mapperFactory' => $this->mapperFactoryMock,
+ ]
+ );
+ }
+
+ /**
+ * Run test mapCriteriaList method
+ *
+ * @return void
+ */
+ public function testMapCriteriaList()
+ {
+ $criteriaMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Api\CriteriaInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getMapperInterfaceName']
+ );
+ $mapperInstanceMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\DB\MapperInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['map']
+ );
+
+ $criteriaMock->expects($this->any())
+ ->method('getMapperInterfaceName')
+ ->will($this->returnValue('mapper-name'));
+ $this->mapperFactoryMock->expects($this->exactly(4))
+ ->method('create')
+ ->with('mapper-name', ['select' => $this->selectMock])
+ ->will($this->returnValue($mapperInstanceMock));
+ $mapperInstanceMock->expects($this->exactly(4))
+ ->method('map')
+ ->will($this->returnValue($this->selectMock));
+
+ $this->geneticMapper->mapCriteriaList(array_fill(0, 4, $criteriaMock));
+ }
+
+ /**
+ * Run test mapFilters method
+ *
+ * @return void
+ */
+ public function testMapFilters()
+ {
+ $filters = [
+ [
+ 'type' => 'or',
+ 'field' => 'test-field',
+ 'condition' => 'test-condition'
+ ],
+ [
+ 'type' => 'string',
+ 'field' => 'test-field',
+ 'condition' => 'test-condition'
+ ],
+ [
+ 'type' => 'public',
+ 'field' => 'test-field',
+ 'condition' => 'test-condition'
+ ],
+ [
+ 'type' => 'default',
+ 'field' => 'test-field',
+ 'condition' => 'test-condition'
+ ]
+ ];
+
+ $connectionMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\DB\Adapter\AdapterInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['quoteInto', 'prepareSqlCondition']
+ );
+
+ /** @var \Magento\Framework\DB\GenericMapper|\PHPUnit_Framework_MockObject_MockObject $geneticMapper */
+ $geneticMapper = $this->getMock(
+ 'Magento\Framework\DB\GenericMapper',
+ ['getConnection', 'getSelect'],
+ [],
+ '',
+ false
+ );
+
+ $geneticMapper->expects($this->any())
+ ->method('getConnection')
+ ->will($this->returnValue($connectionMock));
+ $geneticMapper->expects($this->exactly(4))
+ ->method('getSelect')
+ ->will($this->returnValue($this->selectMock));
+ $connectionMock->expects($this->exactly(2))
+ ->method('quoteInto')
+ ->with('test-field=?', 'test-condition')
+ ->will($this->returnValue('test-condition'));
+ $this->selectMock->expects($this->once())
+ ->method('orWhere')
+ ->with('test-condition');
+ $this->selectMock->expects($this->exactly(3))
+ ->method('where')
+ ->with('test-condition');
+ $connectionMock->expects($this->any())
+ ->method('prepareSqlCondition')
+ ->with('test-field', 'test-condition')
+ ->will($this->returnValue('test-condition'));
+
+ $geneticMapper->mapFilters($filters);
+ }
+
+ /**
+ * Run test mapFields method
+ *
+ * @return void
+ */
+ public function testMapFields()
+ {
+ $fields = [
+ [
+ 'test-correlation-name',
+ 'test-field',
+ 'test-alias'
+ ],
+ [
+ 'test-correlation-name',
+ 'test-field',
+ null
+ ],
+ [
+ 'test-correlation-name',
+ 'test-field',
+ 'test-alias-unique'
+ ]
+ ];
+
+ /** @var \Magento\Framework\DB\GenericMapper|\PHPUnit_Framework_MockObject_MockObject $geneticMapper */
+ $geneticMapper = $this->getMock(
+ 'Magento\Framework\DB\GenericMapper',
+ ['getSelect'],
+ [],
+ '',
+ false
+ );
+
+ $geneticMapper->expects($this->any())
+ ->method('getSelect')
+ ->will($this->returnValue($this->selectMock));
+ $this->selectMock->expects($this->once())
+ ->method('getPart')
+ ->with(\Zend_Db_Select::COLUMNS)
+ ->willReturn([]);
+ $this->selectMock->expects($this->once())
+ ->method('setPart')
+ ->with(\Zend_Db_Select::COLUMNS, $this->equalTo($fields));
+
+ $geneticMapper->mapFields($fields);
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/DB/QueryTest.php b/dev/tests/unit/testsuite/Magento/Framework/DB/QueryTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..b9468180a452de91cce3e5315c6400d73df3dd03
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/DB/QueryTest.php
@@ -0,0 +1,236 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\DB;
+
+/**
+ * Class QueryTest
+ */
+class QueryTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Framework\DB\Select|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $selectMock;
+
+ /**
+ * @var \Magento\Framework\Api\CriteriaInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $criteriaMock;
+
+ /**
+ * @var \Magento\Framework\Model\Resource\Db\AbstractDb|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $resourceMock;
+
+ /**
+ * @var \Zend_Db_Statement_Pdo|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $fetchStmtMock;
+
+ /**
+ * @var \Magento\Framework\Logger|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $loggerMock;
+
+ /**
+ * @var \Magento\Framework\Data\Collection\Db\FetchStrategyInterface|\PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $fetchStrategyMock;
+
+ /**
+ * @var \Magento\Framework\DB\Query
+ */
+ protected $query;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->selectMock = $this->getMock(
+ 'Magento\Framework\DB\Select',
+ ['reset', 'columns', 'getAdapter'],
+ [],
+ '',
+ false
+ );
+ $this->criteriaMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Api\CriteriaInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ []
+ );
+ $this->resourceMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Model\Resource\Db\AbstractDb',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['getIdFieldName']
+ );
+ $this->fetchStmtMock = $this->getMock(
+ 'Zend_Db_Statement_Pdo',
+ ['fetch'],
+ [],
+ '',
+ false
+ );
+ $this->loggerMock = $this->getMock(
+ 'Magento\Framework\Logger',
+ [],
+ [],
+ '',
+ false
+ );
+ $this->fetchStrategyMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Data\Collection\Db\FetchStrategyInterface',
+ [],
+ '',
+ false,
+ true,
+ true,
+ []
+ );
+
+ $this->query = $objectManager->getObject(
+ 'Magento\Framework\DB\Query',
+ [
+ 'select' => $this->selectMock,
+ 'criteria' => $this->criteriaMock,
+ 'resource' => $this->resourceMock,
+ 'fetchStrategy' => $this->fetchStrategyMock
+ ]
+ );
+ }
+
+ /**
+ * Run test getAllIds method
+ *
+ * @return void
+ */
+ public function testGetAllIds()
+ {
+ $adapterMock = $this->getMockForAbstractClass(
+ 'Zend_Db_Adapter_Abstract',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['fetchCol']
+ );
+ $this->resourceMock->expects($this->once())
+ ->method('getIdFieldName')
+ ->will($this->returnValue('return-value'));
+ $this->selectMock->expects($this->once())
+ ->method('getAdapter')
+ ->will($this->returnValue($adapterMock));
+ $adapterMock->expects($this->once())
+ ->method('fetchCol')
+ ->will($this->returnValue('fetch-result'));
+
+ $this->assertEquals('fetch-result', $this->query->getAllIds());
+ }
+
+ /**
+ * Run test getSize method
+ *
+ * @return void
+ */
+ public function testGetSize()
+ {
+ $adapterMock = $this->getMockForAbstractClass(
+ 'Zend_Db_Adapter_Abstract',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['fetchOne']
+ );
+
+ $this->selectMock->expects($this->once())
+ ->method('columns')
+ ->with('COUNT(*)');
+ $this->selectMock->expects($this->once())
+ ->method('getAdapter')
+ ->will($this->returnValue($adapterMock));
+ $adapterMock->expects($this->once())
+ ->method('fetchOne')
+ ->will($this->returnValue(10.689));
+
+ $this->assertEquals(10, $this->query->getSize());
+ }
+
+ /**
+ * Run test fetchAll method
+ *
+ * @return void
+ */
+ public function testFetchAll()
+ {
+ $this->fetchStrategyMock->expects($this->once())
+ ->method('fetchAll')
+ ->will($this->returnValue('return-value'));
+
+ $this->assertEquals('return-value', $this->query->fetchAll());
+ }
+
+ /**
+ * Run test fetchItem method
+ *
+ * @return void
+ */
+ public function testFetchItem()
+ {
+ $adapterMock = $this->getMockForAbstractClass(
+ 'Zend_Db_Adapter_Abstract',
+ [],
+ '',
+ false,
+ true,
+ true,
+ ['query']
+ );
+ $this->selectMock->expects($this->once())
+ ->method('getAdapter')
+ ->will($this->returnValue($adapterMock));
+ $adapterMock->expects($this->once())
+ ->method('query')
+ ->will($this->returnValue($this->fetchStmtMock));
+ $this->fetchStmtMock->expects($this->once())
+ ->method('fetch')
+ ->will($this->returnValue(null));
+
+ $this->assertEquals([], $this->query->fetchItem());
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/AbstractCriteriaTest.php b/dev/tests/unit/testsuite/Magento/Framework/Data/AbstractCriteriaTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..8f1861c7eded192634b393074d94ef1d64e4a94c
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Data/AbstractCriteriaTest.php
@@ -0,0 +1,478 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+use Magento\Framework\Api\CriteriaInterface;
+
+/**
+ * Class AbstractCriteriaTest
+ */
+class AbstractCriteriaTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Magento\Framework\Data\Criteria\Sample
+ */
+ protected $criteria;
+
+ /**
+ * Set up
+ *
+ * @return void
+ */
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+ $this->criteria = $objectManager->getObject('\Magento\Framework\Data\Criteria\Sample');
+ }
+
+ /**
+ * Run test addField method
+ *
+ * @param string|array $field
+ * @param string|null $alias
+ * @param array $result
+ * @return void
+ *
+ * @dataProvider dataProviderAddField
+ */
+ public function testAddField($field, $alias, array $result)
+ {
+ $this->criteria->addField($field, $alias);
+ $this->assertEquals($result, $this->criteria->toArray()[CriteriaInterface::PART_FIELDS]['list']);
+ }
+
+ /**
+ * Run test addFilter method
+ *
+ * @param string $name
+ * @param string|array $field
+ * @param string|int|array $condition
+ * @param string $type
+ * @param array $result
+ * @return void
+ *
+ * @dataProvider dataProviderAddFilter
+ */
+ public function testAddFilter($name, $field, $condition, $type, array $result)
+ {
+ $this->criteria->addFilter($name, $field, $condition, $type);
+ $this->assertEquals($result, $this->criteria->toArray()[CriteriaInterface::PART_FILTERS]['list']);
+ }
+
+ /**
+ * Run test addOrder method
+ *
+ * @param string $field
+ * @param string $direction
+ * @param bool $unShift
+ * @param array $result
+ * @return void
+ *
+ * @dataProvider dataProviderAddOrder
+ */
+ public function testAddOrder($field, $direction, $unShift, array $result)
+ {
+ $this->criteria->addOrder($field, $direction, $unShift);
+ $this->assertEquals($result, $this->criteria->toArray()[CriteriaInterface::PART_ORDERS]['list']);
+ }
+
+ /**
+ * Run test setLimit method
+ *
+ * @param int $offset
+ * @param int $size
+ * @param array $result
+ * @return void
+ *
+ * @dataProvider dataProviderSetLimit
+ */
+ public function testSetLimit($offset, $size, array $result)
+ {
+ $this->criteria->setLimit($offset, $size);
+ $this->assertEquals($result, $this->criteria->toArray()[CriteriaInterface::PART_LIMIT]);
+ }
+
+ /**
+ * Run test removeField method
+ *
+ * @param array $actualField
+ * @param string|null $field
+ * @param bool $isAlias Alias identifier
+ * @param array $result
+ * @return void
+ *
+ * @dataProvider dataProviderRemoveField
+ */
+ public function testRemoveField(array $actualField, $field, $isAlias, array $result)
+ {
+ list($name, $alias) = $actualField;
+ $this->criteria->addField($name, $alias);
+
+ $this->criteria->removeField($field, $isAlias);
+ $this->assertEquals($result, $this->criteria->toArray()[CriteriaInterface::PART_FIELDS]['list']);
+ }
+
+ /**
+ * Run test removeAllFields method
+ *
+ * @param array $actualField
+ * @param array $result
+ * @return void
+ *
+ * @dataProvider dataProviderRemoveAllFields
+ */
+ public function testRemoveAllFields(array $actualField, array $result)
+ {
+ list($name, $alias) = $actualField;
+ $this->criteria->addField($name, $alias);
+
+ $this->criteria->removeAllFields();
+ $this->assertEquals($result, $this->criteria->toArray()[CriteriaInterface::PART_FIELDS]['list']);
+ }
+
+ /**
+ * Run test removeFilter method
+ *
+ * @param array $actualField
+ * @param string $name
+ * @param array $result
+ * @return void
+ *
+ * @dataProvider dataProviderRemoveFilter
+ */
+ public function testRemoveFilter(array $actualField, $name, array $result)
+ {
+ list($filterName, $field, $condition, $type) = $actualField;
+ $this->criteria->addFilter($filterName, $field, $condition, $type);
+
+ $this->criteria->removeFilter($name);
+ $this->assertEquals($result, $this->criteria->toArray()[CriteriaInterface::PART_FILTERS]['list']);
+ }
+
+ /**
+ * Run test removeAllFilters method
+ *
+ * @param array $actualField
+ * @param array $result
+ * @return void
+ *
+ * @dataProvider dataProviderRemoveAllFilters
+ */
+ public function testRemoveAllFilters(array $actualField, array $result)
+ {
+ list($filterName, $field, $condition, $type) = $actualField;
+ $this->criteria->addFilter($filterName, $field, $condition, $type);
+
+ $this->criteria->removeAllFilters();
+ $this->assertEquals($result, $this->criteria->toArray()[CriteriaInterface::PART_FILTERS]['list']);
+ }
+
+ /**
+ * Run test reset method
+ *
+ * @param array $result
+ * @return void
+ *
+ * @dataProvider dataProviderReset
+ */
+ public function testReset(array $result)
+ {
+ $this->criteria->reset();
+ $this->assertEquals($result, $this->criteria->toArray());
+ }
+
+ /**
+ * Data provider for reset method
+ *
+ * @return array
+ */
+ public function dataProviderReset()
+ {
+ return [
+ [
+ 'result' => [
+ 'fields' => [
+ 'list' => []
+ ],
+ 'filters' => [
+ 'list' => []
+ ],
+ 'orders' => [
+ 'list' => []
+ ],
+ 'criteria_list' => [
+ 'list' => []
+ ],
+ 'limit' => [1, 0]
+ ]
+ ]
+ ];
+ }
+
+ /**
+ * Data provider for removeAllFilters method
+ *
+ * @return array
+ */
+ public function dataProviderRemoveAllFilters()
+ {
+ return [
+ [
+ 'actualResult' => [
+ 'test-filter-name',
+ 'test-field-name',
+ 'test-condition',
+ 'test-type'
+ ],
+ 'result' => []
+ ]
+ ];
+ }
+
+ /**
+ * Data provider for removeFilter method
+ *
+ * @return array
+ */
+ public function dataProviderRemoveFilter()
+ {
+ return [
+ [
+ 'actualResult' => [
+ 'test-filter-name',
+ 'test-field-name',
+ 'test-condition',
+ 'test-type'
+ ],
+ 'name' => 'test-filter-name',
+ 'result' => []
+ ]
+ ];
+ }
+
+ /**
+ * Data provider for removeAllFields method
+ *
+ * @return array
+ */
+ public function dataProviderRemoveAllFields()
+ {
+ return [
+ [
+ 'actualField' => [
+ 'test-field-name',
+ 'test-field-alias',
+ ],
+ 'result' => []
+ ]
+ ];
+ }
+
+ /**
+ * Data provider for removeField method
+ *
+ * @return array
+ */
+ public function dataProviderRemoveField()
+ {
+ return [
+ [
+ 'actualField' => [
+ 'test-field-name',
+ null,
+ ],
+ 'field' => 'test-field-name',
+ 'isAlias' => false,
+ 'result' => []
+ ],
+ [
+ 'actualField' => [
+ '*',
+ null,
+ ],
+ 'field' => '*',
+ 'isAlias' => false,
+ 'result' => []
+ ],
+ [
+ 'actualField' => [
+ 'test-field-name',
+ 'test-field-alias',
+ ],
+ 'field' => 'test-field-alias',
+ 'isAlias' => true,
+ 'result' => []
+ ]
+ ];
+ }
+
+ /**
+ * Data provider for setLimit method
+ *
+ * @return array
+ */
+ public function dataProviderSetLimit()
+ {
+ return [
+ [
+ 'offset' => 99,
+ 'size' => 30,
+ 'result' =>
+ [99, 30]
+ ]
+ ];
+ }
+
+ /**
+ * Data provider for addOrder method
+ *
+ * @return array
+ */
+ public function dataProviderAddOrder()
+ {
+ return [
+ [
+ 'field' => 'test-field-name',
+ 'direction' => 'desc',
+ 'unShift' => false,
+ 'result' => [
+
+ 'test-field-name' => 'DESC'
+ ]
+ ],
+ [
+ 'field' => 'test-field-name',
+ 'direction' => 'asc',
+ 'unShift' => false,
+ 'result' => [
+ 'test-field-name' => 'ASC'
+ ]
+ ],
+ [
+ 'field' => 'test-field-name',
+ 'direction' => 'fail',
+ 'unShift' => false,
+ 'result' => [
+ 'test-field-name' => 'DESC'
+ ]
+ ]
+ ];
+ }
+
+ /**
+ * Data provider for addFilter
+ *
+ * @return array
+ */
+ public function dataProviderAddFilter()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+ return [
+ [
+ 'name' => 'test-filter-name',
+ 'field' => 'test-field-name',
+ 'condition' => 'test-condition',
+ 'type' => 'test-type',
+ 'result' => [
+ 'test-filter-name' => $objectManager->getObject(
+ 'Magento\Framework\Object',
+ [
+ 'data' => [
+ 'name' => 'test-filter-name',
+ 'field' => 'test-field-name',
+ 'condition' => 'test-condition',
+ 'type' => 'test-type',
+ ]
+ ]
+ )
+ ]
+ ]
+ ];
+ }
+
+ /**
+ * Data provider for addField
+ *
+ * @return array
+ */
+ public function dataProviderAddField()
+ {
+ return [
+ [
+ 'field' => 'test-field-name',
+ 'alias' => null,
+ 'result' => [
+ 'test-field-name' => 'test-field-name'
+ ]
+ ],
+ [
+ 'field' => '*',
+ 'alias' => null,
+ 'result' => [
+ '*'
+ ],
+ ],
+ [
+ 'field' => [
+ 'test-field-name-1',
+ 'test-field-name-2',
+ 'test-field-name-3'
+ ],
+ 'alias' => null,
+ 'result' => [
+ 'test-field-name-1' => 'test-field-name-1',
+ 'test-field-name-2' => 'test-field-name-2',
+ 'test-field-name-3' => 'test-field-name-3'
+ ]
+ ],
+ [
+ 'field' => 'test-field-name',
+ 'alias' => 'alias-test',
+ 'result' => [
+ 'alias-test' => 'test-field-name'
+ ]
+ ],
+ [
+ 'field' => '*',
+ 'alias' => null,
+ 'result' => [
+ '*'
+ ]
+ ],
+ [
+ 'field' => [
+ 'alias-1' => 'test-field-name',
+ 'alias-2' => 'test-field-name',
+ 'alias-3' => 'test-field-name'
+ ],
+ 'alias' => null,
+ 'result' => [
+ 'alias-1' => 'test-field-name',
+ 'alias-2' => 'test-field-name',
+ 'alias-3' => 'test-field-name'
+ ]
+ ]
+ ];
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/AbstractDataObjectTest.php b/dev/tests/unit/testsuite/Magento/Framework/Data/AbstractDataObjectTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..0a0e76f9c787e67da716325f0c6a47b5596e5803
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Data/AbstractDataObjectTest.php
@@ -0,0 +1,66 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+class AbstractDataObjectTest extends \PHPUnit_Framework_TestCase
+{
+ public function testToArray()
+ {
+ $subObjectData = ['subKey' => 'subValue'];
+ $nestedObjectData = ['nestedKey' => 'nestedValue'];
+ $result = [
+ 'key' => 'value',
+ 'object' => $subObjectData,
+ 'nestedArray' => ['nestedObject' => $nestedObjectData]
+ ];
+
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $subObject = $objectManager->getObject('Magento\Framework\Data\Stub\DataObject');
+ $subObject->setData($subObjectData);
+
+ $nestedObject = $objectManager->getObject('Magento\Framework\Data\Stub\DataObject');
+ $nestedObject->setData($nestedObjectData);
+
+ $dataObject = $objectManager->getObject('Magento\Framework\Data\Stub\DataObject');
+ $data = ['key' => 'value', 'object' => $subObject, 'nestedArray' => ['nestedObject' => $nestedObject]];
+ $dataObject->setData($data);
+
+ $this->assertEquals($result, $dataObject->toArray());
+ }
+
+ public function testGet()
+ {
+ $key = 'key';
+ $value = 'value';
+ $data = [$key => $value];
+
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+ $dataObject = $objectManager->getObject('Magento\Framework\Data\Stub\DataObject');
+ $dataObject->setData($data);
+
+ $this->assertEquals($value, $dataObject->get($key));
+ }
+}
+
\ No newline at end of file
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/AbstractSearchResultTest.php b/dev/tests/unit/testsuite/Magento/Framework/Data/AbstractSearchResultTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..157b5193427aafe0e18e4a4565faec3f2e74c9b8
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Data/AbstractSearchResultTest.php
@@ -0,0 +1,135 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+/**
+ * Class AbstractSearchResultTest
+ */
+class AbstractSearchResultTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var AbstractSearchResult
+ */
+ protected $searchResult;
+
+ /**
+ * @var \Magento\Framework\DB\QueryInterface | \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $query;
+
+ /**
+ * @var \Magento\Framework\Data\Collection\EntityFactoryInterface | \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $entityFactory;
+
+ /**
+ * @var \Magento\Framework\Api\CriteriaInterface | \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $criteria;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $eventManagerMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $searchResultIteratorMock;
+
+ public function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->criteria = $this->getMockForAbstractClass('Magento\Framework\Api\CriteriaInterface');
+ $this->query = $this->getMockForAbstractClass('Magento\Framework\DB\QueryInterface');
+ $this->query->expects($this->any())
+ ->method('getCriteria')
+ ->willReturn($this->criteria);
+ $this->entityFactory = $this->getMockForAbstractClass(
+ 'Magento\Framework\Data\Collection\EntityFactoryInterface'
+ );
+ $this->eventManagerMock = $this->getMockBuilder('Magento\Framework\Event\ManagerInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->searchResultIteratorMock = $this->getMockBuilder('Magento\Framework\Data\SearchResultIteratorFactory')
+ ->disableOriginalConstructor()
+ ->getMock();
+ $this->searchResult = $objectManager->getObject(
+ 'Magento\Framework\Data\Stub\SearchResult',
+ [
+ 'query' => $this->query,
+ 'entityFactory' => $this->entityFactory,
+ 'eventManager' => $this->eventManagerMock,
+ 'resultIteratorFactory' => $this->searchResultIteratorMock
+ ]
+ );
+ }
+
+ public function testGetItems()
+ {
+ $itemData = ['id' => 1];
+
+ $testItem = new \Magento\Framework\Object($itemData);
+
+ $this->query->expects($this->once())
+ ->method('fetchAll')
+ ->willReturn([$itemData]);
+ $this->entityFactory->expects($this->once())
+ ->method('create')
+ ->with('Magento\Framework\Object', ['data' => $itemData])
+ ->willReturn($testItem);
+
+ $items = $this->searchResult->getItems();
+
+ $this->assertCount(1, $items);
+ $this->assertEquals($testItem, end($items));
+ }
+
+ public function testGetTotalCount()
+ {
+ $totalCount = 42;
+
+ $this->query->expects($this->once())
+ ->method('getSize')
+ ->willReturn($totalCount);
+
+ $this->assertEquals($totalCount, $this->searchResult->getTotalCount());
+ }
+
+ public function testGetSearchCriteria()
+ {
+ $this->assertEquals($this->criteria, $this->searchResult->getSearchCriteria());
+ }
+
+ public function testGetSize()
+ {
+ $size = 42;
+ $this->query->expects($this->once())
+ ->method('getSize')
+ ->willReturn($size);
+ $this->assertEquals($size, $this->searchResult->getSize());
+ }
+}
+
\ No newline at end of file
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/Argument/Interpreter/CompositeTest.php b/dev/tests/unit/testsuite/Magento/Framework/Data/Argument/Interpreter/CompositeTest.php
index f3bfb7cedf62953cf4fca1c107706e9e444eb51d..3f195e99ef0f67e573d3599f96a570726b4fc90f 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Data/Argument/Interpreter/CompositeTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Data/Argument/Interpreter/CompositeTest.php
@@ -58,7 +58,7 @@ class CompositeTest extends \PHPUnit_Framework_TestCase
{
$interpreters = array(
'correct' => $this->getMock('Magento\Framework\Data\Argument\InterpreterInterface'),
- 'wrong' => $this->getMock('Magento\Framework\ObjectManager')
+ 'wrong' => $this->getMock('Magento\Framework\ObjectManagerInterface')
);
new Composite($interpreters, 'interpreter');
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest/Ns/TestClass.php b/dev/tests/unit/testsuite/Magento/Framework/Data/Criteria/Sample.php
similarity index 85%
rename from dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest/Ns/TestClass.php
rename to dev/tests/unit/testsuite/Magento/Framework/Data/Criteria/Sample.php
index 8825e7ea2a9375ac50191efef698948b2709493d..c3c50a64225966dbc7a2e3a7114a2e5c88ccd985 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Autoload/IncludePathTest/Ns/TestClass.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Data/Criteria/Sample.php
@@ -21,8 +21,13 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\Framework\Autoload\IncludePathTest\Ns;
+namespace Magento\Framework\Data\Criteria;
-class TestClass
+use Magento\Framework\Data\AbstractCriteria;
+
+/**
+ * Class Sample
+ */
+class Sample extends AbstractCriteria
{
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/SearchCriteriaBuilderTest.php b/dev/tests/unit/testsuite/Magento/Framework/Data/SearchCriteriaBuilderTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..d8565cba9833e07d12f7d0cec444ea0c38bb1aed
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Data/SearchCriteriaBuilderTest.php
@@ -0,0 +1,45 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+class SearchCriteriaBuilderTest extends \PHPUnit_Framework_TestCase
+{
+ public function testMake()
+ {
+ $interface = 'Magento\Framework\Api\CriteriaInterface';
+
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+ $factory = $this->getMock('Magento\Framework\Data\ObjectFactory', [], [], '', false);
+ $builder = $objectManager->getObject(
+ 'Magento\Framework\Data\Stub\SearchCriteriaBuilder',
+ ['objectFactory' => $factory]
+ );
+ $factory->expects($this->once())
+ ->method('create')
+ ->with($interface, ['queryBuilder' => $builder]);
+
+ $builder->make();
+ }
+}
+
\ No newline at end of file
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/SearchResultProcessorTest.php b/dev/tests/unit/testsuite/Magento/Framework/Data/SearchResultProcessorTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..ee2c0f0b974830c5779af0ff89324d8d0015fed1
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Data/SearchResultProcessorTest.php
@@ -0,0 +1,194 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+/**
+ * Class SearchResultProcessorTest
+ */
+class SearchResultProcessorTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var SearchResultProcessor
+ */
+ protected $searchResultProcessor;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $searchResultCollectionMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $searchCriteriaMock;
+
+ public function setUp()
+ {
+ $this->searchCriteriaMock = $this->getMockBuilder('Magento\Framework\Api\CriteriaInterface')
+ ->disableOriginalConstructor()
+ ->getMock();
+
+ $this->searchResultCollectionMock = $this->getMockBuilder('Magento\Framework\Data\AbstractSearchResult')
+ ->disableOriginalConstructor()
+ ->setMethods(['getSearchCriteria', 'getItems', 'getItemId'])
+ ->getMockForAbstractClass();
+ $this->searchResultCollectionMock->expects($this->any())
+ ->method('getSearchCriteria')
+ ->willReturn($this->searchCriteriaMock);
+ $this->searchResultProcessor = new SearchResultProcessor($this->searchResultCollectionMock);
+ }
+
+ public function testGetCurrentPage()
+ {
+ $page = 42;
+ $this->searchCriteriaMock->expects($this->once())
+ ->method('getLimit')
+ ->willReturn([$page]);
+ $this->assertEquals($page, $this->searchResultProcessor->getCurrentPage());
+ }
+
+ public function testGetPageSize()
+ {
+ $size = 42;
+ $this->searchCriteriaMock->expects($this->once())
+ ->method('getLimit')
+ ->willReturn([null, $size]);
+ $this->assertEquals($size, $this->searchResultProcessor->getPageSize());
+ }
+
+ public function testGetFirstItem()
+ {
+ $itemData = ['id' => 1];
+ $itemData2 = ['id' => 2];
+
+ $testItem = new \Magento\Framework\Object($itemData);
+ $testItem2 = new \Magento\Framework\Object($itemData2);
+
+ $this->searchResultCollectionMock->expects($this->once())
+ ->method('getItems')
+ ->willReturn([$testItem, $testItem2]);
+
+ $this->assertEquals($testItem, $this->searchResultProcessor->getFirstItem());
+ }
+
+ public function testGetLastItem()
+ {
+ $itemData = ['id' => 1];
+ $itemData2 = ['id' => 2];
+
+ $testItem = new \Magento\Framework\Object($itemData);
+ $testItem2 = new \Magento\Framework\Object($itemData2);
+
+ $this->searchResultCollectionMock->expects($this->once())
+ ->method('getItems')
+ ->willReturn([$testItem, $testItem2]);
+
+ $this->assertEquals($testItem2, $this->searchResultProcessor->getLastItem());
+ }
+
+ public function testGetAllIds()
+ {
+ $itemData = ['id' => 1];
+ $ids = [1];
+
+ $testItem = new \Magento\Framework\Object($itemData);
+
+ $this->searchResultCollectionMock->expects($this->once())
+ ->method('getItems')
+ ->willReturn([$testItem]);
+ $this->searchResultCollectionMock->expects($this->once())
+ ->method('getItemId')
+ ->with($testItem)
+ ->willReturn(1);
+
+ $this->assertEquals($ids, $this->searchResultProcessor->getAllIds());
+ }
+
+ public function testGetItemById()
+ {
+ $itemData = ['id' => 1];
+ $itemData2 = ['id' => 2];
+
+ $testItem = new \Magento\Framework\Object($itemData);
+ $testItem2 = new \Magento\Framework\Object($itemData2);
+
+ $this->searchResultCollectionMock->expects($this->once())
+ ->method('getItems')
+ ->willReturn([1 => $testItem, $testItem2]);
+
+ $this->assertEquals($testItem2, $this->searchResultProcessor->getItemById(2));
+ }
+
+ public function testGetColumnValues()
+ {
+ $columnKey = 'columnKey';
+ $columnValue = 'columnValue';
+ $itemData = ['id' => 1, $columnKey => $columnValue];
+
+ $testItem = new \Magento\Framework\Object($itemData);
+
+ $this->searchResultCollectionMock->expects($this->once())
+ ->method('getItems')
+ ->willReturn([$testItem]);
+ $this->assertEquals([$columnValue], $this->searchResultProcessor->getColumnValues($columnKey));
+ }
+
+ public function testGetItemsByColumnValue()
+ {
+ $columnKey = 'columnKey';
+ $columnValue = 'columnValue';
+ $itemData = ['id' => 1, $columnKey => $columnValue];
+ $itemData2 = ['id' => 2, $columnKey => $columnValue];
+
+ $testItem = new \Magento\Framework\Object($itemData);
+ $testItem2 = new \Magento\Framework\Object($itemData2);
+
+ $this->searchResultCollectionMock->expects($this->once())
+ ->method('getItems')
+ ->willReturn([$testItem, $testItem2]);
+
+ $this->assertEquals(
+ [$testItem, $testItem2],
+ $this->searchResultProcessor->getItemsByColumnValue($columnKey, $columnValue)
+ );
+ }
+
+ public function testGetItemByColumnValue()
+ {
+ $columnKey = 'columnKey';
+ $columnValue = 'columnValue';
+ $columnValue2 = 'columnValue2';
+ $itemData = ['id' => 1, $columnKey => $columnValue];
+ $itemData2 = ['id' => 2, $columnKey => $columnValue2];
+
+ $testItem = new \Magento\Framework\Object($itemData);
+ $testItem2 = new \Magento\Framework\Object($itemData2);
+
+ $this->searchResultCollectionMock->expects($this->once())
+ ->method('getItems')
+ ->willReturn([$testItem, $testItem2]);
+
+ $this->assertEquals($testItem2, $this->searchResultProcessor->getItemByColumnValue($columnKey, $columnValue2));
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/Stub/DataObject.php b/dev/tests/unit/testsuite/Magento/Framework/Data/Stub/DataObject.php
new file mode 100644
index 0000000000000000000000000000000000000000..03f0892bba5c845439889060b1a70699f13c6c30
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Data/Stub/DataObject.php
@@ -0,0 +1,47 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data\Stub;
+
+use Magento\Framework\Data\AbstractDataObject;
+
+class DataObject extends AbstractDataObject
+{
+ /**
+ * @param array $data
+ */
+ public function setData(array $data)
+ {
+ $this->data = $data;
+ }
+
+ /**
+ * @param string $key
+ * @return mixed|null
+ */
+ public function get($key)
+ {
+ return parent::get($key);
+ }
+}
+
\ No newline at end of file
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/Stub/SearchCriteriaBuilder.php b/dev/tests/unit/testsuite/Magento/Framework/Data/Stub/SearchCriteriaBuilder.php
new file mode 100644
index 0000000000000000000000000000000000000000..fe10e01eaf15739bd1efa4c98bc05505a865eed3
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Data/Stub/SearchCriteriaBuilder.php
@@ -0,0 +1,38 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data\Stub;
+
+use Magento\Framework\Data\AbstractSearchCriteriaBuilder;
+
+class SearchCriteriaBuilder extends AbstractSearchCriteriaBuilder
+{
+ /**
+ * @return string|void
+ */
+ public function init()
+ {
+ $this->resultObjectInterface = 'Magento\Framework\Api\CriteriaInterface';
+ }
+}
+
\ No newline at end of file
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/Stub/SearchResult.php b/dev/tests/unit/testsuite/Magento/Framework/Data/Stub/SearchResult.php
new file mode 100644
index 0000000000000000000000000000000000000000..cd50a12ae70e43ffb40210604b584eb2cc989d82
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Data/Stub/SearchResult.php
@@ -0,0 +1,35 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data\Stub;
+
+use Magento\Framework\Data\AbstractSearchResult;
+
+class SearchResult extends AbstractSearchResult
+{
+ public function init()
+ {
+
+ }
+}
+
\ No newline at end of file
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Event/ObserverFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Event/ObserverFactoryTest.php
index 434cad2597807dd010bfe44446084b0a0e4aaacc..007bc883e1be6f566bcb3949af6e567cbabcd358 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Event/ObserverFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Event/ObserverFactoryTest.php
@@ -32,7 +32,7 @@ namespace Magento\Framework\Event;
class ObserverFactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Event/WrapperFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Event/WrapperFactoryTest.php
index 2149136608bf9e6d94da33f3c9b68c4c86d7d80a..44f4e53d0917a30d553d2680f793ded528b23914 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Event/WrapperFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Event/WrapperFactoryTest.php
@@ -36,7 +36,7 @@ class WrapperFactoryTest extends \PHPUnit_Framework_TestCase
public function testCreate()
{
$expectedInstance = 'Magento\Framework\Event\Observer';
- $objectManagerMock = $this->getMock('\Magento\Framework\ObjectManager', [], [], '', false, false);
+ $objectManagerMock = $this->getMock('\Magento\Framework\ObjectManagerInterface');
$wrapperFactory = new WrapperFactory($objectManagerMock);
$arguments = ['argument' => 'value', 'data' => 'data'];
diff --git a/dev/tests/unit/testsuite/Magento/Framework/EventFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/EventFactoryTest.php
index 6d1b75deaca85519d95d6ca95c98529ad00e3399..8d949c97e6f25722b7586dbf67dcf2c3b2514149 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/EventFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/EventFactoryTest.php
@@ -42,7 +42,7 @@ class EventFactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Framework\EventFactory($this->_objectManagerMock);
$this->_expectedObject = $this->getMockBuilder('Magento\Framework\Event')->getMock();
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Code/Generator/FileResolverTest.php b/dev/tests/unit/testsuite/Magento/Framework/Filesystem/FileResolverTest.php
similarity index 86%
rename from dev/tests/unit/testsuite/Magento/Framework/Code/Generator/FileResolverTest.php
rename to dev/tests/unit/testsuite/Magento/Framework/Filesystem/FileResolverTest.php
index fcbf45ac0b9b5d3a88b91a1893921e59fc926da5..45ebfe4d39c12d7981b754c1ca92710ce3daed3e 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Code/Generator/FileResolverTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Filesystem/FileResolverTest.php
@@ -1,6 +1,6 @@
<?php
/**
- * Unit test for \Magento\Framework\Code\Generator\FileResolver
+ * Unit test for \Magento\Framework\Filesystem\FileResolver
*
* Only one method is unit testable, other methods require integration testing.
*
@@ -25,7 +25,7 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\Framework\Code\Generator;
+namespace Magento\Framework\Filesystem;
use \Magento\TestFramework\Helper\ObjectManager;
@@ -33,13 +33,13 @@ class FileResolverTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\Code\Generator\FileResolver
+ * @var \Magento\Framework\Filesystem\FileResolver
*/
protected $model;
public function setUp()
{
- $this->model = (new ObjectManager($this))->getObject('Magento\Framework\Code\Generator\FileResolver');
+ $this->model = (new ObjectManager($this))->getObject('Magento\Framework\Filesystem\FileResolver');
}
public function testGetFilePath()
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Filter/AbstractFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Filter/AbstractFactoryTest.php
index 83e8239789b22b04f5db44727ad27980bc75661b..3edc3bfa6dd8f0562909eaeab35100aa2b732c79 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Filter/AbstractFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Filter/AbstractFactoryTest.php
@@ -48,21 +48,13 @@ class AbstractFactoryTest extends \PHPUnit_Framework_TestCase
);
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
public function setUp()
{
- $this->_objectManager = $this->getMockForAbstractClass(
- '\Magento\Framework\ObjectManager',
- array(),
- '',
- true,
- true,
- true,
- array('create')
- );
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_factory = $this->getMockForAbstractClass(
'Magento\Framework\Filter\AbstractFactory',
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Filter/FilterManagerTest.php b/dev/tests/unit/testsuite/Magento/Framework/Filter/FilterManagerTest.php
index bdd9b73eb1a15e16e0ef6c90d497e00099d2ee8b..7520a18f872f10de20ed288bd45f442c1f099b93 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Filter/FilterManagerTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Filter/FilterManagerTest.php
@@ -36,7 +36,7 @@ class FilterManagerTest extends \PHPUnit_Framework_TestCase
protected $_factoryMock;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -55,15 +55,7 @@ class FilterManagerTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $this->_objectManager = $this->getMockForAbstractClass(
- '\Magento\Framework\ObjectManager',
- array(),
- '',
- true,
- true,
- true,
- array('create')
- );
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_objectManager->expects(
$this->atLeastOnce()
)->method(
@@ -106,15 +98,7 @@ class FilterManagerTest extends \PHPUnit_Framework_TestCase
{
$factoryName = 'Magento\Framework\Filter\Factory';
$this->_factoryMock = new \stdClass();
- $this->_objectManager = $this->getMockForAbstractClass(
- '\Magento\Framework\ObjectManager',
- array(),
- '',
- true,
- true,
- true,
- array('create')
- );
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_objectManager->expects(
$this->atLeastOnce()
)->method(
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Filter/InputTest.php b/dev/tests/unit/testsuite/Magento/Framework/Filter/InputTest.php
index 146a717125f194da84b6a6704caf5746dde235b5..8c515ad03597f8b1b70188ac494dec26e3958142 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Filter/InputTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Filter/InputTest.php
@@ -28,7 +28,7 @@ class InputTest extends \PHPUnit_Framework_TestCase
{
public function testFilterZendFilterAsObject()
{
- $objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', [], [], '', false);
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$inputFilter = new Input($objectManagerMock);
/** @var \Zend_Filter_Interface $filterMock */
@@ -51,7 +51,7 @@ class InputTest extends \PHPUnit_Framework_TestCase
public function testFilterZendFilterAsArray()
{
- $objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', [], [], '', false);
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$inputFilter = new Input($objectManagerMock);
/** This filter should be applied to 'field1' field value only */
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/Chain/ChainTest.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/Chain/ChainTest.php
index 297b812d9e73471cbeed52e595b0a37324973cf8..d155aac25a60c88079b88f380f68b6cb040d07f4 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Interception/Chain/ChainTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/Chain/ChainTest.php
@@ -38,13 +38,7 @@ class ChainTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_pluginListMock = $this->getMock(
- '\Magento\Framework\Interception\PluginList',
- array(),
- array(),
- '',
- false
- );
+ $this->_pluginListMock = $this->getMock('Magento\Framework\Interception\PluginListInterface');
$this->_model = new \Magento\Framework\Interception\Chain\Chain($this->_pluginListMock);
}
@@ -70,7 +64,7 @@ class ChainTest extends \PHPUnit_Framework_TestCase
->with($type, $method, null)
->will(
$this->returnValue(
- array(\Magento\Framework\Interception\Definition::LISTENER_BEFORE => array('code'))
+ array(\Magento\Framework\Interception\DefinitionInterface::LISTENER_BEFORE => array('code'))
)
);
@@ -106,7 +100,9 @@ class ChainTest extends \PHPUnit_Framework_TestCase
$this->_pluginListMock->expects($this->once())
->method('getNext')
->with($type, $method, null)
- ->will($this->returnValue(array(\Magento\Framework\Interception\Definition::LISTENER_AROUND => 'code')));
+ ->will($this->returnValue(array(
+ \Magento\Framework\Interception\DefinitionInterface::LISTENER_AROUND => 'code'
+ )));
$this->_pluginListMock->expects($this->once())
->method('getPlugin')
@@ -137,7 +133,7 @@ class ChainTest extends \PHPUnit_Framework_TestCase
->with($type, $method, null)
->will(
$this->returnValue(
- array(\Magento\Framework\Interception\Definition::LISTENER_AFTER => array('code'))
+ array(\Magento\Framework\Interception\DefinitionInterface::LISTENER_AFTER => array('code'))
)
);
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/Generator/InterceptorTest.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/Generator/InterceptorTest.php
index 84ae043980f867bd78d575ec5223a16ca713b2a2..c477f227fc8b783b5f8c199168180a7c484e9f87 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/Generator/InterceptorTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/Generator/InterceptorTest.php
@@ -36,11 +36,6 @@ class InterceptorTest extends \PHPUnit_Framework_TestCase
*/
protected $classGeneratorMock;
- /**
- * @var \PHPUnit_Framework_MockObject
- */
- protected $fileResolverMock;
-
protected function setUp()
{
$this->ioObjectMock = $this->getMock('\Magento\Framework\Code\Generator\Io', [], [], '', false);
@@ -51,15 +46,19 @@ class InterceptorTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $this->fileResolverMock = $this->getMock('Magento\Framework\Code\Generator\FileResolver', [], [], '', false);
}
public function testGetDefaultResultClassName()
{
// resultClassName should be stdClass_Interceptor
$model = $this->getMock('\Magento\Framework\Interception\Code\Generator\Interceptor',
- array('_validateData'),
- array('Exception', null, $this->ioObjectMock, $this->classGeneratorMock, $this->fileResolverMock)
+ ['_validateData'],
+ [
+ 'Exception',
+ null,
+ $this->ioObjectMock,
+ $this->classGeneratorMock,
+ ]
);
$this->classGeneratorMock->expects($this->once())->method('setName')
@@ -74,6 +73,6 @@ class InterceptorTest extends \PHPUnit_Framework_TestCase
->will($this->returnValue('source code example'));
$model->expects($this->once())->method('_validateData')->will($this->returnValue(true));
$this->ioObjectMock->expects($this->any())->method('getResultFileName')->with('Exception_Interceptor');
- $this->assertTrue($model->generate());
+ $this->assertEquals('', $model->generate());
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/Config/ConfigTest.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/Config/ConfigTest.php
index e5432dacf149dafd108e366d65729d15218228a4..7d3aecb672142d213544f19e99d15681cd24ac4a 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Interception/Config/ConfigTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/Config/ConfigTest.php
@@ -70,7 +70,7 @@ class ConfigTest extends \PHPUnit_Framework_TestCase
$this->configScopeMock = $this->getMock('Magento\Framework\Config\ScopeListInterface');
$this->cacheMock = $this->getMock('Magento\Framework\Cache\FrontendInterface');
$this->omConfigMock = $this->getMock('Magento\Framework\Interception\ObjectManager\Config');
- $this->definitionMock = $this->getMock('Magento\Framework\ObjectManager\Definition');
+ $this->definitionMock = $this->getMock('Magento\Framework\ObjectManager\DefinitionInterface');
}
/**
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/ObjectManager/ConfigTest.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/ObjectManager/ConfigTest.php
index b3b63da45f3e434bcfda90ef4c42cf027011cda0..40e79d6376a304995cde279d961c7090bf5294a6 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Interception/ObjectManager/ConfigTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/ObjectManager/ConfigTest.php
@@ -38,7 +38,7 @@ class ConfigTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->interceptionConfig = $this->getMock('\Magento\Framework\Interception\Config');
+ $this->interceptionConfig = $this->getMock('\Magento\Framework\Interception\ConfigInterface');
$this->model = new Config();
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/PluginList/PluginListTest.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/PluginList/PluginListTest.php
index 66865835bded4fe398f18d9e29558bf42cf8b3c3..6edb89488bc454350a7d75788b40dcd637b758ef 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Interception/PluginList/PluginListTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/PluginList/PluginListTest.php
@@ -69,7 +69,7 @@ class PluginListTest extends \PHPUnit_Framework_TestCase
$omConfigMock = $this->getMock('Magento\Framework\Interception\ObjectManager\Config');
$omConfigMock->expects($this->any())->method('getOriginalInstanceType')->will($this->returnArgument(0));
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_objectManagerMock->expects($this->any())->method('get')->will($this->returnArgument(0));
$definitions = new \Magento\Framework\ObjectManager\Definition\Runtime();
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Mail/Template/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Mail/Template/FactoryTest.php
index 42bfca7bf2a94b49d392d496f08568026e806917..8b342f79fa34fdf18fbe2ba42b0b096df6dacfbc 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Mail/Template/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Mail/Template/FactoryTest.php
@@ -37,7 +37,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
- $this->_objectManagerMock = $this->getMock('\Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('\Magento\Framework\ObjectManagerInterface');
$this->_templateMock = $this->getMock('\Magento\Framework\Mail\TemplateInterface');
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Mail/Template/TransportBuilderTest.php b/dev/tests/unit/testsuite/Magento/Framework/Mail/Template/TransportBuilderTest.php
index d90ad92635fa854a6aa21c6377e8473d7e675291..327c2f13074d4cb533951955833ea6a1115ad53b 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Mail/Template/TransportBuilderTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Mail/Template/TransportBuilderTest.php
@@ -46,7 +46,7 @@ class TransportBuilderTest extends \PHPUnit_Framework_TestCase
protected $messageMock;
/**
- * @var \Magento\Framework\ObjectManager | \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface | \PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -65,7 +65,7 @@ class TransportBuilderTest extends \PHPUnit_Framework_TestCase
$helper = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->templateFactoryMock = $this->getMock('Magento\Framework\Mail\Template\FactoryInterface');
$this->messageMock = $this->getMock('Magento\Framework\Mail\Message');
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->senderResolverMock = $this->getMock('Magento\Framework\Mail\Template\SenderResolverInterface');
$this->_mailTransportFactoryMock = $this->getMockBuilder(
'Magento\Framework\Mail\TransportInterfaceFactory'
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Message/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Message/FactoryTest.php
index cd38a019c53ede8c0a6bcb0ffe3b7510b1e6d00b..fabc6b8c438c98a2be6ce53daa17b65777592166 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Message/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Message/FactoryTest.php
@@ -39,7 +39,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->factory = new \Magento\Framework\Message\Factory(
$this->objectManagerMock
);
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Module/Updater/SetupFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Module/Updater/SetupFactoryTest.php
index 10cb256d62a436e7f38c2402933abc4742397580..43c7cf50868ab5483239c9b80775bece457d1650 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Module/Updater/SetupFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Module/Updater/SetupFactoryTest.php
@@ -32,7 +32,7 @@ class SetupFactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
}
public function testCreateUsesDefaultSetupModelClassIfSetupModelIsNotDeclaredForGivenResource()
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Mview/ActionFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Mview/ActionFactoryTest.php
index 8410841739431629f25cd0b1fbe3256a178b7353..fe70dae7e14a6d6b608c5f6633fcbbea744a6f3a 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Mview/ActionFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Mview/ActionFactoryTest.php
@@ -31,13 +31,13 @@ class ActionFactoryTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->model = new \Magento\Framework\Mview\ActionFactory($this->objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Mview/Config/Data/ProxyTest.php b/dev/tests/unit/testsuite/Magento/Framework/Mview/Config/Data/ProxyTest.php
index 9860d0221083a466469d8456baff680883bd56b1..5b2041f0669d7461a54c1001a0a5d93b5e7810ff 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Mview/Config/Data/ProxyTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Mview/Config/Data/ProxyTest.php
@@ -31,7 +31,7 @@ class ProxyTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -42,9 +42,7 @@ class ProxyTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager', array(), array(), '', false
- );
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->dataMock = $this->getMock(
'Magento\Framework\Mview\Config\Data', array(), array(), '', false
);
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionFactoryTest.php
index 6a17897dd61f81b3a13a9f5b638394c02c8a3c29..fd6ab3f01b35323d0f780ce8a56345a718936e76 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionFactoryTest.php
@@ -31,13 +31,13 @@ class SubscriptionFactoryTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->model = new SubscriptionFactory($this->objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Notification/NotifierListTest.php b/dev/tests/unit/testsuite/Magento/Framework/Notification/NotifierListTest.php
index afbfa92a04bf1db291f57cf4492f7878512a4566..430655fc1ebca5cc1d23d9e8cde4c2b3258a5fcc 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Notification/NotifierListTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Notification/NotifierListTest.php
@@ -30,12 +30,12 @@ class NotifierListTest extends \PHPUnit_Framework_TestCase
/** @var ObjectManagerHelper */
protected $objectManagerHelper;
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $objectManager;
protected function setUp()
{
- $this->objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->objectManagerHelper = new ObjectManagerHelper($this);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/ConverterTest.php b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/ConverterTest.php
index 354b967c803f8985aca9fbb6cfaa680919cc7360..d85d9f548da9c5c51de59d5813bb0379f7c36724 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/ConverterTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/ConverterTest.php
@@ -46,14 +46,14 @@ class ConverterTest extends \PHPUnit_Framework_TestCase
protected $generator;
/**
- * @var \Magento\Framework\Code\Generator\FileResolver | \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Code\Generator\CodeGenerator\Zend | \PHPUnit_Framework_MockObject_MockObject
*/
- protected $fileResolverMock;
+ protected $classGenerator;
/**
- * @var \Magento\Framework\Code\Generator\CodeGenerator\Zend | \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Code\Generator\DefinedClasses | \PHPUnit_Framework_MockObject_MockObject
*/
- protected $classGenerator;
+ private $definedClassesMock;
protected function setUp()
{
@@ -64,13 +64,6 @@ class ConverterTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $this->fileResolverMock = $this->getMock(
- 'Magento\Framework\Code\Generator\FileResolver',
- [],
- [],
- '',
- false
- );
$this->classGenerator = $this->getMock(
'Magento\Framework\Code\Generator\CodeGenerator\Zend',
[],
@@ -79,6 +72,9 @@ class ConverterTest extends \PHPUnit_Framework_TestCase
false
);
+ $this->definedClassesMock = $this->getMockBuilder('Magento\Framework\Code\Generator\DefinedClasses')
+ ->disableOriginalConstructor()->getMock();
+
$objectManager = new ObjectManager($this);
$this->generator = $objectManager->getObject(
'Magento\Framework\ObjectManager\Code\Generator\Converter',
@@ -87,7 +83,7 @@ class ConverterTest extends \PHPUnit_Framework_TestCase
'resultClassName' => self::RESULT_CLASS_NAME,
'ioObject' => $this->ioObjectMock,
'classGenerator' => $this->classGenerator,
- 'fileResolver' => $this->fileResolverMock
+ 'definedClasses' => $this->definedClassesMock
]
);
}
@@ -95,18 +91,12 @@ class ConverterTest extends \PHPUnit_Framework_TestCase
public function testGenerate()
{
$generatedCode = 'Generated code';
- $sourceFileName = 'Sample.php';
$resultFileName = 'SampleConverter.php';
//Mocking _validateData call
- $this->fileResolverMock->expects($this->at(0))
- ->method('getFile')
- ->with(self::SOURCE_CLASS_NAME)
- ->will($this->returnValue($sourceFileName));
- $this->fileResolverMock->expects($this->at(1))
- ->method('getFile')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue(false));
+ $this->definedClassesMock->expects($this->at(0))
+ ->method('classLoadable')
+ ->will($this->returnValue(true));
$this->ioObjectMock->expects($this->once())
->method('makeGenerationDirectory')
@@ -147,6 +137,6 @@ class ConverterTest extends \PHPUnit_Framework_TestCase
->method('writeResultFile')
->with($resultFileName, $generatedCode);
- $this->assertTrue($this->generator->generate());
+ $this->assertEquals($resultFileName, $this->generator->generate());
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/FactoryTest.php
index 491cca92e5a9b2fa5379c4e774640ea781500843..5e434c47db0aeae310e975621afb07159c414ebe 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/FactoryTest.php
@@ -42,7 +42,14 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
$model = $this->getMock(
'\Magento\Framework\ObjectManager\Code\Generator\Factory',
array('_validateData'),
- array('\Magento\Framework\ObjectManager\Code\Generator\Sample', null, $this->ioObjectMock, null, null)
+ [
+ '\Magento\Framework\ObjectManager\Code\Generator\Sample',
+ null,
+ $this->ioObjectMock,
+ null,
+ null,
+ $this->getMock('Magento\Framework\Filesystem\FileResolver')
+ ]
);
$this->ioObjectMock->expects($this->once())->method('getResultFileName')
@@ -53,6 +60,6 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
->with('sample_file.php', $factoryCode);
$model->expects($this->once())->method('_validateData')->will($this->returnValue(true));
- $this->assertTrue($model->generate());
+ $this->assertEquals('sample_file.php', $model->generate());
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/GenerateRepositoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/GenerateRepositoryTest.php
index 1b8b65974411cd1773804fda5c50325378b64f1f..ead5ee3d561b23a91ee454a18c0f0fd5bb072431 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/GenerateRepositoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/GenerateRepositoryTest.php
@@ -63,7 +63,8 @@ class GenerateRepositoryTest extends \PHPUnit_Framework_TestCase
null,
$this->ioObjectMock,
null,
- null
+ null,
+ $this->getMock('Magento\Framework\Filesystem\FileResolver')
]
);
$sampleRepositoryCode = file_get_contents(__DIR__ . '/_files/SampleRepository.txt');
@@ -80,7 +81,7 @@ class GenerateRepositoryTest extends \PHPUnit_Framework_TestCase
);
$model->expects($this->once())->method('_validateData')->will($this->returnValue(true));
- $this->assertTrue($model->generate());
+ $this->assertEquals('SampleRepository.php', $model->generate());
}
/**
@@ -90,23 +91,8 @@ class GenerateRepositoryTest extends \PHPUnit_Framework_TestCase
{
$sourceClassName = 'Magento_Module_Controller_Index';
$resultClassName = 'Magento_Module_Controller';
-
- $fileResolverMock = $this->getMockBuilder('Magento\Framework\Code\Generator\FileResolver')
- ->disableOriginalConstructor()
- ->setMethods(['getFile'])
- ->getMock();
- $fileResolverMock->expects($this->at(0))
- ->method('getFile')
- ->with($sourceClassName)
- ->will($this->returnValue(true));
- $fileResolverMock->expects($this->at(1))
- ->method('getFile')
- ->with($resultClassName)
- ->will($this->returnValue(false));
-
- $repository = new Repository(
- null, null, null, null, $fileResolverMock
- );
+
+ $repository = new Repository();
$repository->init($sourceClassName, $resultClassName);
$this->assertFalse($repository->generate());
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/ProxyTest.php b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/ProxyTest.php
index 78526f6611ca99cf54878b5919cddde8f3be89b4..0afb62997776fae1dd38189672c43eb3c26affbb 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/ProxyTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/ProxyTest.php
@@ -42,7 +42,13 @@ class ProxyTest extends \PHPUnit_Framework_TestCase
$model = $this->getMock(
'\Magento\Framework\ObjectManager\Code\Generator\Proxy',
array('_validateData'),
- array('\Magento\Framework\ObjectManager\Code\Generator\Sample', null, $this->ioObjectMock, null, null)
+ ['\Magento\Framework\ObjectManager\Code\Generator\Sample',
+ null,
+ $this->ioObjectMock,
+ null,
+ null,
+ $this->getMock('Magento\Framework\Filesystem\FileResolver')
+ ]
);
$sampleProxyCode = file_get_contents(__DIR__ . '/_files/SampleProxy.txt');
@@ -53,6 +59,6 @@ class ProxyTest extends \PHPUnit_Framework_TestCase
->with('sample_file.php', $sampleProxyCode);
$model->expects($this->once())->method('_validateData')->will($this->returnValue(true));
- $this->assertTrue($model->generate());
+ $this->assertEquals('sample_file.php', $model->generate());
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/RepositoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/RepositoryTest.php
index 822f87d71db2030493e22d8ebe43293aa8a6be65..34b51f151488b35f8098eafeb29c25fd1012533d 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/RepositoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/RepositoryTest.php
@@ -23,133 +23,37 @@
*/
namespace Magento\Framework\ObjectManager\Code\Generator;
+use Magento\Framework\Api\Code\Generator\EntityChildTestAbstract;
use Magento\Framework\Code\Generator\Io;
use Magento\TestFramework\Helper\ObjectManager;
/**
* Class RepositoryTest
*/
-class RepositoryTest extends \PHPUnit_Framework_TestCase
+class RepositoryTest extends EntityChildTestAbstract
{
const SOURCE_CLASS_NAME = 'Magento\Framework\ObjectManager\Code\Generator\Sample';
const RESULT_CLASS_NAME = 'Magento\Framework\ObjectManager\Code\Generator\SampleRepository';
const GENERATOR_CLASS_NAME = 'Magento\Framework\ObjectManager\Code\Generator\Repository';
const OUTPUT_FILE_NAME = 'SampleConverter.php';
- /**
- * @var Io | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $ioObjectMock;
- /**
- * @var \Magento\Framework\Code\Generator\EntityAbstract
- */
- protected $generator;
-
- /**
- * @var \Magento\Framework\Code\Generator\FileResolver | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $fileResolverMock;
-
- /**
- * @var \Magento\Framework\Code\Generator\CodeGenerator\Zend | \PHPUnit_Framework_MockObject_MockObject
- */
- protected $classGenerator;
-
- protected function setUp()
+ protected function getSourceClassName()
{
- $this->ioObjectMock = $this->getMock(
- 'Magento\Framework\Code\Generator\Io',
- [],
- [],
- '',
- false
- );
- $this->fileResolverMock = $this->getMock(
- 'Magento\Framework\Code\Generator\FileResolver',
- [],
- [],
- '',
- false
- );
- $this->classGenerator = $this->getMock(
- 'Magento\Framework\Code\Generator\CodeGenerator\Zend',
- [],
- [],
- '',
- false
- );
-
- $objectManager = new ObjectManager($this);
- $this->generator = $objectManager->getObject(
- self::GENERATOR_CLASS_NAME,
- [
- 'sourceClassName' => self::SOURCE_CLASS_NAME,
- 'resultClassName' => self::RESULT_CLASS_NAME,
- 'ioObject' => $this->ioObjectMock,
- 'classGenerator' => $this->classGenerator,
- 'fileResolver' => $this->fileResolverMock
- ]
- );
+ return self::SOURCE_CLASS_NAME;
}
- /**
- * generate repository name
- */
- public function testGenerate()
+ protected function getResultClassName()
{
- $generatedCode = 'Generated code';
- $sourceFileName = 'Sample.php';
- $resultFileName = self::OUTPUT_FILE_NAME;
-
- //Mocking _validateData call
- $this->fileResolverMock->expects($this->at(0))
- ->method('getFile')
- ->with(self::SOURCE_CLASS_NAME)
- ->will($this->returnValue($sourceFileName));
- $this->fileResolverMock->expects($this->at(1))
- ->method('getFile')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue(false));
-
- $this->ioObjectMock->expects($this->once())
- ->method('makeGenerationDirectory')
- ->will($this->returnValue(true));
- $this->ioObjectMock->expects($this->once())
- ->method('makeResultFileDirectory')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue(true));
- $this->ioObjectMock->expects($this->once())
- ->method('fileExists')
- ->with($resultFileName)
- ->will($this->returnValue(false));
-
- //Mocking _generateCode call
- $this->classGenerator->expects($this->once())
- ->method('setName')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnSelf());
- $this->classGenerator->expects($this->once())
- ->method('addProperties')
- ->will($this->returnSelf());
- $this->classGenerator->expects($this->once())
- ->method('addMethods')
- ->will($this->returnSelf());
- $this->classGenerator->expects($this->once())
- ->method('setClassDocBlock')
- ->will($this->returnSelf());
- $this->classGenerator->expects($this->once())
- ->method('generate')
- ->will($this->returnValue($generatedCode));
+ return self::RESULT_CLASS_NAME;
+ }
- //Mocking generation
- $this->ioObjectMock->expects($this->any())
- ->method('getResultFileName')
- ->with(self::RESULT_CLASS_NAME)
- ->will($this->returnValue($resultFileName));
- $this->ioObjectMock->expects($this->once())
- ->method('writeResultFile')
- ->with($resultFileName, $generatedCode);
+ protected function getGeneratorClassName()
+ {
+ return self::GENERATOR_CLASS_NAME;
+ }
- $this->assertTrue($this->generator->generate());
+ protected function getOutputFileName()
+ {
+ return self::OUTPUT_FILE_NAME;
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/_files/SampleFactory.txt b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/_files/SampleFactory.txt
index d7732d7fd68a2ebe97eebce7c84114120e1b0998..ba65192d50b00dd8259f0fdc0f75ce9dbb42af6c 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/_files/SampleFactory.txt
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/_files/SampleFactory.txt
@@ -8,7 +8,7 @@ class SampleFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -22,10 +22,10 @@ class SampleFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $instanceName = 'Magento\Framework\ObjectManager\Code\Generator\Sample')
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\Framework\ObjectManager\Code\Generator\Sample')
{
$this->_objectManager = $objectManager;
$this->_instanceName = $instanceName;
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/_files/SampleProxy.txt b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/_files/SampleProxy.txt
index ae58f25140a134f5cdf5a5044ff555a18a65e3cf..d25e59e5ea1e6e0a9dc0485ae0f0a59dee7bcd99 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/_files/SampleProxy.txt
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Code/Generator/_files/SampleProxy.txt
@@ -8,7 +8,7 @@ class Sample_Proxy extends \Magento\Framework\ObjectManager\Code\Generator\Sampl
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -36,11 +36,11 @@ class Sample_Proxy extends \Magento\Framework\ObjectManager\Code\Generator\Sampl
/**
* Proxy constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
* @param bool $shared
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $instanceName = 'Magento\Framework\ObjectManager\Code\Generator\Sample', $shared = true)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\Framework\ObjectManager\Code\Generator\Sample', $shared = true)
{
$this->_objectManager = $objectManager;
$this->_instanceName = $instanceName;
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Config/ConfigTest.php b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Config/ConfigTest.php
index ddd8665650404ffb009065cc5ccc9dfc12342a3b..f068ae0e29d0e6b6075826d088fa5d52fbe16c3a 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Config/ConfigTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Config/ConfigTest.php
@@ -51,10 +51,10 @@ class ConfigTest extends \PHPUnit_Framework_TestCase
public function testExtendWithCacheMock()
{
- $definitions = $this->getMockForAbstractClass('\Magento\Framework\ObjectManager\Definition');
+ $definitions = $this->getMock('Magento\Framework\ObjectManager\DefinitionInterface');
$definitions->expects($this->once())->method('getClasses')->will($this->returnValue(array('FooType')));
- $cache = $this->getMockForAbstractClass('\Magento\Framework\ObjectManager\ConfigCache');
+ $cache = $this->getMock('Magento\Framework\ObjectManager\ConfigCacheInterface');
$cache->expects($this->once())->method('get')->will($this->returnValue(false));
$config = new Config(null, $definitions);
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/DefinitionFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/DefinitionFactoryTest.php
index e6254ade52e44a7f92cb3785ac5b8534c02715a5..7a3b1807f0ba17294e9c773f8d58e4749bd0fe70 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/DefinitionFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/DefinitionFactoryTest.php
@@ -67,6 +67,8 @@ class DefinitionFactoryTest extends \PHPUnit_Framework_TestCase
'\Magento\Framework\ObjectManager\Definition\Runtime',
$this->model->createClassDefinition(null, true)
);
+ $autoloadFunctions = spl_autoload_functions();
+ spl_autoload_unregister(array_pop($autoloadFunctions));
}
public function testCreateDefinitionsDoesNotReadCompiledDefinitionsIfUseCompiledIsFalse()
@@ -86,8 +88,6 @@ class DefinitionFactoryTest extends \PHPUnit_Framework_TestCase
'\Magento\Framework\ObjectManager\Definition\Compiled\Serialized',
$this->model->createClassDefinition($this->sampleContent)
);
- $autoloadFunctions = spl_autoload_functions();
- spl_autoload_unregister(array_pop($autoloadFunctions));
}
/**
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Factory/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Factory/FactoryTest.php
index ddf31470caf26f1e38c339c1735f318d1ebd5411..9e7cdf053dacdd4de974089483c0dede82bb17d2 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Factory/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Factory/FactoryTest.php
@@ -74,7 +74,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
'firstParam' => 1
)));
- $definitionsMock = $this->getMock('\Magento\Framework\ObjectManager\Definition', array(), array(), '', false);
+ $definitionsMock = $this->getMock('Magento\Framework\ObjectManager\DefinitionInterface');
$definitionsMock->expects($this->once())->method('getParameters')
->will($this->returnValue(array(array(
'firstParam', 'string', true, 'default_val'
@@ -149,7 +149,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
public function testCreateUsingReflection()
{
$type = 'Magento\Framework\ObjectManager\Factory\Fixture\Polymorphous';
- $definitions = $this->getMockForAbstractClass('\Magento\Framework\ObjectManager\Definition');
+ $definitions = $this->getMock('Magento\Framework\ObjectManager\DefinitionInterface');
// should be more than defined in "switch" of create() method
$definitions->expects($this->once())->method('getParameters')->with($type)->will($this->returnValue(array(
array('one', null, false, null), array('two', null, false, null), array('three', null, false, null),
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectTest.php b/dev/tests/unit/testsuite/Magento/Framework/ObjectTest.php
index 93faa014fe37b1b1a1ddb541bb6da21768abe18f..0bc10d613804325ac200b6f389d85e294b678cce 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ObjectTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectTest.php
@@ -113,6 +113,13 @@ class ObjectTest extends \PHPUnit_Framework_TestCase
$this->assertEquals('test', $this->_object->getId());
}
+ public function testSetGetIdFieldName()
+ {
+ $name = 'entity_id_custom';
+ $this->_object->setIdFieldName($name);
+ $this->assertEquals($name, $this->_object->getIdFieldName());
+ }
+
/**
* Tests \Magento\Framework\Object->addData()
*/
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Pricing/Price/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Pricing/Price/FactoryTest.php
index efd8c594453aa6575dbac49c705aedc367ff096c..4cf2731ee6cdc3c248ae9a4de70df4b113c8eba6 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Pricing/Price/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Pricing/Price/FactoryTest.php
@@ -35,15 +35,13 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
public function setUp()
{
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->model = $objectManager->getObject('Magento\Framework\Pricing\Price\Factory', array(
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Search/Adapter/Mysql/ResponseFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Search/Adapter/Mysql/ResponseFactoryTest.php
index d3babccbaa80b7aa18cb523403ff94ca3d197a37..ab3e6016419df5bfd723a98f671526660bd8f9ed 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Search/Adapter/Mysql/ResponseFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Search/Adapter/Mysql/ResponseFactoryTest.php
@@ -38,7 +38,7 @@ class ResponseFactoryTest extends \PHPUnit_Framework_TestCase
private $documentFactory;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
private $objectManager;
@@ -51,10 +51,7 @@ class ResponseFactoryTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->getMock();
- $this->objectManager = $this->getMockBuilder('\Magento\Framework\ObjectManager')
- ->setMethods(['create'])
- ->disableOriginalConstructor()
- ->getMockForAbstractClass();
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->factory = $helper->getObject(
'Magento\Framework\Search\Adapter\Mysql\ResponseFactory',
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Search/Request/BuilderTest.php b/dev/tests/unit/testsuite/Magento/Framework/Search/Request/BuilderTest.php
index 2671a55431c6f53c0e3286425192db7a91c05779..5d5c4eefaa0a456c69d9d936b813b1219f080fde 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Search/Request/BuilderTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Search/Request/BuilderTest.php
@@ -33,7 +33,7 @@ class BuilderTest extends \PHPUnit_Framework_TestCase
private $requestBuilder;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
private $objectManager;
@@ -71,10 +71,7 @@ class BuilderTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->getMock();
- $this->objectManager = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->setMethods(['create'])
- ->disableOriginalConstructor()
- ->getMockForAbstractClass();
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->requestMapper = $this->getMockBuilder('Magento\Framework\Search\Request\Mapper')
->setMethods(['getRootQuery', 'getBuckets'])
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Search/Request/MapperTest.php b/dev/tests/unit/testsuite/Magento/Framework/Search/Request/MapperTest.php
index be02eb065ea7f4bbc38e4e73cdedeeef81ab8d2d..63863fa7e022dafd11dbb5fd4f833e5fe4244bac 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Search/Request/MapperTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Search/Request/MapperTest.php
@@ -36,7 +36,7 @@ class MapperTest extends \PHPUnit_Framework_TestCase
private $helper;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
private $objectManager;
@@ -79,10 +79,7 @@ class MapperTest extends \PHPUnit_Framework_TestCase
{
$this->helper = new ObjectManager($this);
- $this->objectManager = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->setMethods(['create', 'get', 'configure'])
- ->disableOriginalConstructor()
- ->getMock();
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->queryMatch = $this->getMockBuilder('Magento\Framework\Search\Request\Query\Match')
->disableOriginalConstructor()
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Session/SessionManagerTest.php b/dev/tests/unit/testsuite/Magento/Framework/Session/SessionManagerTest.php
index 08ebd40d1ebe64652f4f714408495fa02438cd41..aa5d20cbcd1f9e45a33f0c4df2e6d3edf7b7684a 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Session/SessionManagerTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Session/SessionManagerTest.php
@@ -89,7 +89,7 @@ namespace Magento\Framework\Session {
private $mockSessionConfig;
/**
- * @var \Magento\Framework\Stdlib\CookieManager | \PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface | \PHPUnit_Framework_MockObject_MockObject
*/
private $mockCookieManager;
@@ -110,9 +110,7 @@ namespace Magento\Framework\Session {
$this->mockSessionConfig = $this->getMockBuilder('\Magento\Framework\Session\Config\ConfigInterface')
->disableOriginalConstructor()
->getMock();
- $this->mockCookieManager = $this->getMockBuilder('\Magento\Framework\Stdlib\CookieManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $this->mockCookieManager = $this->getMock('\Magento\Framework\Stdlib\CookieManagerInterface');
$this->mockCookieMetadataFactory = $this->getMockBuilder(
'Magento\Framework\Stdlib\Cookie\CookieMetadataFactory'
)
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Translate/Inline/ProxyTest.php b/dev/tests/unit/testsuite/Magento/Framework/Translate/Inline/ProxyTest.php
index 455da0fae647f4a8699cc7164b96330e4114fad0..81d579d0489b24adaa6491969c1355243545e009 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Translate/Inline/ProxyTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Translate/Inline/ProxyTest.php
@@ -26,7 +26,7 @@ namespace Magento\Framework\Translate\Inline;
class ProxyTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -37,13 +37,7 @@ class ProxyTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager',
- array('get', 'create', 'configure'),
- array(),
- '',
- false
- );
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->translateMock = $this->getMock('Magento\Framework\Translate\Inline', array(), array(), '', false);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Url/DecoderTest.php b/dev/tests/unit/testsuite/Magento/Framework/Url/DecoderTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..1e3b2d05d0d6d5ce9ed786094e578ace3f9f35f2
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Framework/Url/DecoderTest.php
@@ -0,0 +1,51 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Url;
+
+class DecoderTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @covers \Magento\Framework\Url\Encoder::encode
+ * @covers \Magento\Framework\Url\Decoder::decode
+ */
+ public function testDecode()
+ {
+ $urlBuilderMock = $this->getMock('Magento\Framework\UrlInterface', [], [], '', false);
+ /** @var $urlBuilderMock \Magento\Framework\UrlInterface|\PHPUnit_Framework_MockObject_MockObject */
+ $decoder = new Decoder($urlBuilderMock);
+ $encoder = new Encoder();
+
+ $data = uniqid();
+ $result = $encoder->encode($data);
+ $urlBuilderMock->expects($this->once())
+ ->method('sessionUrlVar')
+ ->with($this->equalTo($data))
+ ->will($this->returnValue($result));
+ $this->assertNotContains('&', $result);
+ $this->assertNotContains('%', $result);
+ $this->assertNotContains('+', $result);
+ $this->assertNotContains('=', $result);
+ $this->assertEquals($result, $decoder->decode($result));
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Url/RouteParamsResolverFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Url/RouteParamsResolverFactoryTest.php
index 35936b5029e84efc9281fc629c78b505b1c05ef9..49795819d39680e19b3ed5ca459f74328d06be5b 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Url/RouteParamsResolverFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/Url/RouteParamsResolverFactoryTest.php
@@ -30,12 +30,12 @@ class RouteParamsResolverFactoryTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Framework\Url\RouteParamsResolverFactory */
protected $object;
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $objectManager;
protected function setUp()
{
- $this->objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager = new ObjectManager($this);
$this->object = $objectManager->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Framework/ValidatorFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/ValidatorFactoryTest.php
index 5030c00704640735a2a0ed0d8ab782b90d10ca9e..b0072c07a2935bdf16737403c719f4ff61039767 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/ValidatorFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/ValidatorFactoryTest.php
@@ -32,15 +32,13 @@ class ValidatorFactoryTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Framework\ValidatorFactory */
private $model;
- /** @var \Magento\Framework\ObjectManager | \PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface | \PHPUnit_Framework_MockObject_MockObject */
private $objectManagerMock;
public function setUp()
{
$objectManager = new ObjectManager($this);
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->model = $objectManager->getObject('Magento\Framework\ValidatorFactory',
['objectManager' => $this->objectManagerMock]
);
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MergeServiceTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MergeServiceTest.php
index 352919491ebb59e15ada1548724ba0078563416f..e21d58f91745ba2749d4e1edb865d6ed202cd5df 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MergeServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MergeServiceTest.php
@@ -57,7 +57,7 @@ class MergeServiceTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMockForAbstractClass('Magento\Framework\ObjectManager', array('create'));
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_config = $this->getMock('Magento\Framework\View\Asset\ConfigInterface', array(), array(), '', false);
$this->_filesystem = $this->getMock('Magento\Framework\Filesystem', array(), array(), '', false);
$this->_directory = $this->getMock(
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MinifyServiceTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MinifyServiceTest.php
index 86f75e2f37ab912d6e1ae6be601f4cf87d481adc..017b5c4eb950fd952dec9516024386857535d3ce 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MinifyServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MinifyServiceTest.php
@@ -31,7 +31,7 @@ class MinifyServiceTest extends \PHPUnit_Framework_TestCase
protected $_config;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManager;
@@ -43,7 +43,7 @@ class MinifyServiceTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
$this->_config = $this->getMock('Magento\Framework\View\Asset\ConfigInterface', array(), array(), '', false);
- $this->_objectManager = $this->getMockForAbstractClass('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new MinifyService($this->_config, $this->_objectManager);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/PreProcessor/PoolTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/PreProcessor/PoolTest.php
index f85983d21d61ac3f68bd89b75f3afd6822b8cf76..be703f7aa9ab5092d8935cee4f610d7b1745f948 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/PreProcessor/PoolTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/PreProcessor/PoolTest.php
@@ -38,7 +38,7 @@ class PoolTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->factory = new Pool($this->objectManager);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Design/Theme/Domain/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Design/Theme/Domain/FactoryTest.php
index 82d8bd763580fec88929c7e9a8055bdb97d7e1e4..d9f588304ea28fb3415f204d12e8d0d9cb2fe3ab 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Design/Theme/Domain/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Design/Theme/Domain/FactoryTest.php
@@ -45,7 +45,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
$newThemeMock = $this->getMock('Magento\Core\Model\Theme', array(), array(), '', false);
- $objectManager = $this->getMock('Magento\Framework\ObjectManager', array(), array('create'), '', false);
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager->expects(
$this->once()
)->method(
@@ -70,7 +70,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
$themeMock = $this->getMock('Magento\Core\Model\Theme', array('__wakeup', 'getType'), array(), '', false);
$themeMock->expects($this->any())->method('getType')->will($this->returnValue($wrongThemeType));
- $objectManager = $this->getMock('Magento\Framework\ObjectManager', array(), array('create'), '', false);
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$themeDomainFactory = new \Magento\Framework\View\Design\Theme\Domain\Factory($objectManager);
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Element/BlockFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Element/BlockFactoryTest.php
index cd42c5994545513fb918abda0119c19e7dba11b2..eba2b211052da273e9142304821a3e867b25a996 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Element/BlockFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Element/BlockFactoryTest.php
@@ -31,7 +31,7 @@ class BlockFactoryTest extends \PHPUnit_Framework_TestCase
protected $blockFactory;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -39,9 +39,7 @@ class BlockFactoryTest extends \PHPUnit_Framework_TestCase
{
$objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->blockFactory = $objectManagerHelper->getObject('Magento\Framework\View\Element\BlockFactory', array(
'objectManager' => $this->objectManagerMock
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/BaseTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/BaseTest.php
index ba3029d1a96963524d7059883f0eadcf23e6866d..2359e8dcae6016a43879c568d89644554976dd44 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/BaseTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/BaseTest.php
@@ -53,7 +53,7 @@ class BaseTest extends \PHPUnit_Framework_TestCase
->with('*/*/view/frontend/layout/*.xml')
->will($this->returnValue($areaFiles));
$directory->expects($this->atLeastOnce())->method('getAbsolutePath')->will($this->returnArgument(0));
- $objectManager = $this->getMockForAbstractClass('Magento\Framework\ObjectManager');
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager->expects($this->atLeastOnce())
->method('create')
->with('Magento\Framework\View\File', $this->anything())
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/File/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/File/FactoryTest.php
index 6a1245a307b1555f6949f5118eb8ea02211c6918..06600e024a37abb585a4ff718aeeef4f63dc68a4 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/File/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/File/FactoryTest.php
@@ -38,7 +38,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMockForAbstractClass('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Framework\View\File\Factory($this->_objectManager);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/File/FileList/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/File/FileList/FactoryTest.php
index c9d15b51f7fd24e3a6e8c5734f115e70e8c33bc9..f9fe619cca20440b052b45b516909ed01a922dc6 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/File/FileList/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/File/FileList/FactoryTest.php
@@ -38,7 +38,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManager = $this->getMockForAbstractClass('Magento\Framework\ObjectManager');
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->model = new \Magento\Framework\View\File\FileList\Factory($this->objectManager);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/Decorator/UpdaterTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/Decorator/UpdaterTest.php
index 52b354f818bce92bfe68d38cb24bb8552765450a..93b508feb0b2e434396fac642c80fe8cd7fa3012 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/Decorator/UpdaterTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/Decorator/UpdaterTest.php
@@ -26,7 +26,7 @@ namespace Magento\Framework\View\Layout\Argument\Interpreter\Decorator;
class UpdaterTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManager;
@@ -42,7 +42,7 @@ class UpdaterTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_interpreter = $this->getMockForAbstractClass('Magento\Framework\Data\Argument\InterpreterInterface');
$this->_model = new Updater($this->_objectManager, $this->_interpreter);
}
@@ -132,7 +132,7 @@ class UpdaterTest extends \PHPUnit_Framework_TestCase
'value' => 'some text',
'updater' => array(
'Magento\Framework\View\Layout\Argument\UpdaterInterface',
- 'Magento\Framework\ObjectManager'
+ 'Magento\Framework\ObjectManagerInterface'
)
);
$self = $this;
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/HelperMethodTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/HelperMethodTest.php
index 2c92a9b9ffb9a452380210e7c43818cc8d831df6..fc730ec568f12fdd272dbc27ec024325995219b6 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/HelperMethodTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/HelperMethodTest.php
@@ -26,7 +26,7 @@ namespace Magento\Framework\View\Layout\Argument\Interpreter;
class HelperMethodTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManager;
@@ -42,7 +42,7 @@ class HelperMethodTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_interpreter = $this->getMock(
'Magento\Framework\View\Layout\Argument\Interpreter\NamedParams',
array(),
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/ObjectTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/ObjectTest.php
index 17af1034c04a26641c14244c2efefb99bc7e60c4..d897bcf42796d3da6aea5a9ffbed1987dd70f64b 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/ObjectTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/ObjectTest.php
@@ -28,7 +28,7 @@ class ObjectTest extends \PHPUnit_Framework_TestCase
const EXPECTED_CLASS = 'Magento\Framework\View\Layout\Argument\Interpreter\ObjectTest';
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManager;
@@ -44,7 +44,7 @@ class ObjectTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new Object($this->_objectManager, self::EXPECTED_CLASS);
}
@@ -88,7 +88,7 @@ class ObjectTest extends \PHPUnit_Framework_TestCase
return array(
'no class' => array(array(), '\InvalidArgumentException', 'Object class name is missing'),
'unexpected class' => array(
- array('value' => 'Magento\Framework\ObjectManager'),
+ array('value' => 'Magento\Framework\ObjectManagerInterface'),
'\UnexpectedValueException',
'Instance of ' . self::EXPECTED_CLASS . ' is expected'
)
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/OptionsTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/OptionsTest.php
index 2d4fc0ec484fafc6038b4fed686e4ee1bf2eedfb..aa428fad99036ecb87a7e7b7ffe1b87753265e32 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/OptionsTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Argument/Interpreter/OptionsTest.php
@@ -26,7 +26,7 @@ namespace Magento\Framework\View\Layout\Argument\Interpreter;
class OptionsTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManager;
@@ -42,7 +42,7 @@ class OptionsTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new Options($this->_objectManager);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/BuilderFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/BuilderFactoryTest.php
index 58ae8cd85b1ee17bbb6ad3ebbe43ba2d56bb6853..c1d26a103c5b109cd2c203f5f56f4fd7df01d540 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/BuilderFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/BuilderFactoryTest.php
@@ -34,7 +34,7 @@ class BuilderFactoryTest extends \PHPUnit_Framework_TestCase
protected $objectManagerHelper;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -47,9 +47,7 @@ class BuilderFactoryTest extends \PHPUnit_Framework_TestCase
{
$this->objectManagerHelper = new ObjectManagerHelper($this);
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->buildFactory = $this->objectManagerHelper->getObject(
'Magento\Framework\View\Layout\BuilderFactory',
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Generator/UiComponentTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Generator/UiComponentTest.php
index c896bba0e2aaf66778c7c641e8a526c663a7b76e..b9a7e37611359c259059c67b9360bd2cf2256813 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Generator/UiComponentTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Generator/UiComponentTest.php
@@ -119,11 +119,6 @@ class UiComponentTest extends \PHPUnit_Framework_TestCase
$blockMock = $this->getMockBuilder('Magento\Framework\View\Element\AbstractBlock')
->disableOriginalConstructor()->getMock();
- $blockMock->expects($this->any())
- ->method('setLayout')
- ->with($layoutMock)
- ->willReturnSelf();
-
$this->uiComponentFactoryMock->expects($this->any())
->method('createUiComponent')
->with(
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Reader/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Reader/FactoryTest.php
index 3786f460147b92d6504fc54f1067fb77b89ca607..f6af98e10711ef09476bfbfad1a2088d5b34e52c 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Reader/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Reader/FactoryTest.php
@@ -34,8 +34,8 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
$object = (new \Magento\TestFramework\Helper\ObjectManager($this))->getObject('Magento\Framework\Object');
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject $objectManager */
- $objectManager = $this->getMock('Magento\Framework\ObjectManager', [], [], '', false);
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject $objectManager */
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager->expects($this->once())->method('create')->with($className, $data)
->will($this->returnValue($object));
@@ -58,8 +58,8 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Framework\View\Layout\ReaderInterface|\PHPUnit_Framework_MockObject_MockObject $object */
$object = $this->getMock('Magento\Framework\View\Layout\ReaderInterface', [], [], '', false);
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject $objectManager */
- $objectManager = $this->getMock('Magento\Framework\ObjectManager', [], [], '', false);
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject $objectManager */
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager->expects($this->once())->method('create')->with($className, $data)
->will($this->returnValue($object));
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/LayoutFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/LayoutFactoryTest.php
index a1c699c350e0d0ce7853af7bbca06a7523f690b4..6dcc5efa1e6f3419c1977b13540bfce23fd2193f 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/LayoutFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/LayoutFactoryTest.php
@@ -34,12 +34,12 @@ class LayoutFactoryTest extends \PHPUnit_Framework_TestCase
/** @var ObjectManagerHelper */
protected $objectManagerHelper;
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $objectManagerMock;
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->objectManagerHelper = new ObjectManagerHelper($this);
$this->layoutFactory = $this->objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Render/RenderFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Render/RenderFactoryTest.php
index 06b567e5da48eeb5ba2157da0383abce2743b86b..de12ab73eb4d7dde1da84690c2e35a3f6f9e11b8 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Render/RenderFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Render/RenderFactoryTest.php
@@ -34,12 +34,12 @@ class RenderFactoryTest extends \PHPUnit_Framework_TestCase
/** @var ObjectManagerHelper */
protected $objectManagerHelper;
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $objectManagerMock;
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->objectManagerHelper = new ObjectManagerHelper($this);
$this->renderFactory = $this->objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Result/PageFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Result/PageFactoryTest.php
index 45ca1f17ab3fa8721fa2c0a9452c7fd5a0e2b6f7..f6859515235ba8ba29ca3f2a141aac37be88c586 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/Result/PageFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/Result/PageFactoryTest.php
@@ -37,12 +37,12 @@ class PageFactoryTest extends \PHPUnit_Framework_TestCase
/** @var ObjectManagerHelper */
protected $objectManagerHelper;
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $objectManagerMock;
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', [], [], '', false);
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->objectManagerHelper = new ObjectManagerHelper($this);
$this->pageFactory = $this->objectManagerHelper->getObject(
'Magento\Framework\View\Result\PageFactory',
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngine/PhpTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngine/PhpTest.php
index dead68e22fce420219ed6591b72909d6e69e4de4..93050a6d4ebf9cacbfbe0576660529da0c392f37 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngine/PhpTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngine/PhpTest.php
@@ -40,7 +40,7 @@ class PhpTest extends \PHPUnit_Framework_TestCase
*/
protected function setUp()
{
- $this->_helperFactoryMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_helperFactoryMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_phpEngine = new \Magento\Framework\View\TemplateEngine\Php($this->_helperFactoryMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngineFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngineFactoryTest.php
index 03ac4f9359da17761874247b44e98a933455e935..d3caa7922c511183dbbb0c2b747b57f23675ba6e 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngineFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngineFactoryTest.php
@@ -36,7 +36,7 @@ class TemplateEngineFactoryTest extends \PHPUnit_Framework_TestCase
*/
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_factory = new TemplateEngineFactory(
$this->_objectManagerMock,
array('test' => 'Fixture\Module\Model\TemplateEngine')
diff --git a/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/ReadServiceTest.php
index 8d7a5abfdf0625399256101b979945a00822e962..0e60a1d78802695da9dadbd6f08d0526665e78fe 100644
--- a/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/ReadServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/ReadServiceTest.php
@@ -121,7 +121,7 @@ class ReadServiceTest extends \PHPUnit_Framework_TestCase
);
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($this->cardId)
->will($this->returnValue($this->quoteMock));
}
diff --git a/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php
index b8715e4191ad375825cb49e9a87baf4a7b00bfc6..848c673d9f7bd97cc70949c18b82d4d4c628066b 100644
--- a/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php
+++ b/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php
@@ -135,7 +135,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 665;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(0));
@@ -152,7 +152,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 665;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
@@ -166,7 +166,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 665;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
@@ -211,7 +211,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$itemId = 1;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemById')->with($itemId)->will($this->returnValue(null));
@@ -229,7 +229,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$itemId = 1;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($this->quoteMock));
$quoteItem = $this->getMock('\Magento\Sales\Model\Quote\Item', ['getIsVirtual', '__wakeup'], [], '', false);
@@ -248,7 +248,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$itemId = 1;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($this->quoteMock));
$quoteItem = $this->getMock('\Magento\Sales\Model\Quote\Item', ['getIsVirtual', '__wakeup'], [], '', false);
@@ -296,7 +296,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 665;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
@@ -318,7 +318,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 665;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
@@ -344,7 +344,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 665;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
@@ -375,7 +375,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase
$cartId = 665;
$this->quoteRepositoryMock->expects($this->once())
- ->method('get')
+ ->method('getActive')
->with($cartId)
->will($this->returnValue($this->quoteMock));
$this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1));
diff --git a/dev/tests/unit/testsuite/Magento/GoogleShopping/Model/AttributeFactoryTest.php b/dev/tests/unit/testsuite/Magento/GoogleShopping/Model/AttributeFactoryTest.php
index cf02135adf11e67b09760961be56d88aa0ab856c..c2a196730433500c85d1754719ecd01ca646286b 100644
--- a/dev/tests/unit/testsuite/Magento/GoogleShopping/Model/AttributeFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/GoogleShopping/Model/AttributeFactoryTest.php
@@ -28,11 +28,11 @@ class AttributeFactoryTest extends \PHPUnit_Framework_TestCase
/**
* Get object manager mock
*
- * @return \Magento\Framework\ObjectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*/
protected function _createObjectManager()
{
- return $this->getMockBuilder('Magento\Framework\ObjectManager')
+ return $this->getMockBuilder('Magento\Framework\ObjectManagerInterface')
->setMethods(array('create'))
->getMockForAbstractClass();
}
diff --git a/dev/tests/unit/testsuite/Magento/Indexer/Model/ActionFactoryTest.php b/dev/tests/unit/testsuite/Magento/Indexer/Model/ActionFactoryTest.php
index 9a3a520ca7e98c95bc181ba9a477391af626350f..2d8f93f8481f93bfd943b94b0787ef6d97c1a014 100644
--- a/dev/tests/unit/testsuite/Magento/Indexer/Model/ActionFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Indexer/Model/ActionFactoryTest.php
@@ -31,13 +31,13 @@ class ActionFactoryTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->model = new \Magento\Indexer\Model\ActionFactory($this->objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Indexer/Model/IndexerRegistryTest.php b/dev/tests/unit/testsuite/Magento/Indexer/Model/IndexerRegistryTest.php
index 70fb6e837d7d0eaa588c9b5a299a511baf882b0b..ba390bbbd3cc2858509b48421c46528ed8dfa5bc 100644
--- a/dev/tests/unit/testsuite/Magento/Indexer/Model/IndexerRegistryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Indexer/Model/IndexerRegistryTest.php
@@ -33,7 +33,7 @@ class IndexerRegistryTest extends \PHPUnit_Framework_TestCase
$secondIndexer = $this->getMock('Magento\Indexer\Model\IndexerInterface');
$secondIndexer->expects($this->once())->method('load')->with('second-indexer')->willReturnSelf();
- $objectManager = $this->getMock('Magento\Framework\ObjectManager', [], [], '', false);
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager->expects($this->at(0))->method('create')->willReturn($firstIndexer);
$objectManager->expects($this->at(1))->method('create')->willReturn($secondIndexer);
diff --git a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/IntegrationTest.php b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/IntegrationTest.php
index cd5778e03072b81ef2e8919ae3e5a8999790e12b..7122dfa7b269e60ffcc2380ed02b26e92f50805d 100644
--- a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/IntegrationTest.php
+++ b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/IntegrationTest.php
@@ -40,7 +40,7 @@ abstract class IntegrationTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\TestFramework\Helper\ObjectManager $objectManagerHelper */
protected $_objectManagerHelper;
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $_objectManagerMock;
/** @var \Magento\Backend\Model\Layout\Filter\Acl|\PHPUnit_Framework_MockObject_MockObject */
@@ -109,9 +109,7 @@ abstract class IntegrationTest extends \PHPUnit_Framework_TestCase
{
/** @var \Magento\TestFramework\Helper\ObjectManager $objectManagerHelper */
$this->_objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->_objectManagerMock = $this->getMockBuilder(
- 'Magento\Framework\ObjectManager'
- )->disableOriginalConstructor()->getMock();
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
// Initialize mocks which are used in several test cases
$this->_configMock = $this->getMockBuilder(
'Magento\Framework\App\Config\ScopeConfigInterface'
diff --git a/dev/tests/unit/testsuite/Magento/Integration/Model/Integration/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Integration/Model/Integration/FactoryTest.php
index bf7ccf55132df87231351f8917941d8a6d3b56f7..9b29a865e66659bde01a1e6cec1fedc8dbefdfae 100644
--- a/dev/tests/unit/testsuite/Magento/Integration/Model/Integration/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Integration/Model/Integration/FactoryTest.php
@@ -30,9 +30,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
public function testCreate()
{
/** @var \PHPUnit_Framework_MockObject_MockObject */
- $mockObjectManager = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $mockObjectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$data = array(
Info::DATA_NAME => 'nameTest',
diff --git a/dev/tests/unit/testsuite/Magento/Log/Model/Shell/Command/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Log/Model/Shell/Command/FactoryTest.php
index de7033baef044b1fdb9c00538dac427373eb3ff1..4129507164947af47489d6cb1d081f87017212af 100644
--- a/dev/tests/unit/testsuite/Magento/Log/Model/Shell/Command/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Log/Model/Shell/Command/FactoryTest.php
@@ -37,7 +37,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Log\Model\Shell\Command\Factory($this->_objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..4c6dbf99a2a7ceb1263715190fd616594bb1949b
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php
@@ -0,0 +1,142 @@
+<?php
+/**
+ *
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Multishipping\Block\Checkout;
+
+use Magento\Sales\Model\Quote\Address;
+
+class OverviewTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var Overview
+ */
+ protected $model;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $priceCurrencyMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $addressMock;
+
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+
+ $this->addressMock = $this->getMock(
+ 'Magento\Sales\Model\Quote\Address',
+ [
+ 'getShippingMethod',
+ 'getShippingRateByCode',
+ 'getAllVisibleItems',
+ 'getTotals',
+ 'getAddressType',
+ '__wakeup'
+ ],
+ [],
+ '',
+ false);
+
+ $this->priceCurrencyMock =
+ $this->getMock('Magento\Framework\Pricing\PriceCurrencyInterface', [], [], '', false);
+ $this->model = $objectManager->getObject('Magento\Multishipping\Block\Checkout\Overview',
+ [
+ 'priceCurrency' => $this->priceCurrencyMock,
+ ]
+ );
+ }
+
+ public function testGetShippingRateByCode()
+ {
+ $rateMock = $this->getMock('Magento\Sales\Model\Quote\Address\Rate', [], [], '', false);
+ $this->addressMock->expects($this->once())
+ ->method('getShippingMethod')->will($this->returnValue('shipping method'));
+ $this->addressMock->expects($this->once())
+ ->method('getShippingRateByCode')
+ ->with('shipping method')
+ ->willReturn($rateMock);
+
+ $this->assertEquals($rateMock, $this->model->getShippingAddressRate($this->addressMock));
+ }
+
+ public function testGetShippingRateByCodeWithEmptyRate()
+ {
+ $this->addressMock->expects($this->once())
+ ->method('getShippingMethod')->will($this->returnValue('shipping method'));
+ $this->addressMock->expects($this->once())
+ ->method('getShippingRateByCode')
+ ->with('shipping method')
+ ->willReturn(false);
+
+ $this->assertFalse($this->model->getShippingAddressRate($this->addressMock));
+ }
+
+ public function testGetShippingAddressItems()
+ {
+ $this->addressMock->expects($this->once())->method('getAllVisibleItems')->willReturn(['expected array']);
+ $this->assertEquals(['expected array'], $this->model->getShippingAddressItems($this->addressMock));
+ }
+
+ public function testGetShippingAddressTotals()
+ {
+ $totalMock =$this->getMock('\Magento\Sales\Model\Order\Total',
+ [
+ 'getCode',
+ 'setTitle',
+ '__wakeup'
+ ],
+ [],
+ '',
+ false);
+ $this->addressMock->expects($this->once())->method('getTotals')->willReturn([$totalMock]);
+ $totalMock->expects($this->once())->method('getCode')->willReturn('grand_total');
+ $this->addressMock->expects($this->once())->method('getAddressType')->willReturn(Address::TYPE_BILLING);
+ $totalMock->expects($this->once())->method('setTitle')->with('Total');
+
+ $this->assertEquals([$totalMock], $this->model->getShippingAddressTotals($this->addressMock));
+ }
+
+ public function testGetShippingAddressTotalsWithNotBillingAddress()
+ {
+ $totalMock =$this->getMock('\Magento\Sales\Model\Order\Total',
+ [
+ 'getCode',
+ 'setTitle',
+ '__wakeup'
+ ],
+ [],
+ '',
+ false);
+ $this->addressMock->expects($this->once())->method('getTotals')->willReturn([$totalMock]);
+ $totalMock->expects($this->once())->method('getCode')->willReturn('grand_total');
+ $this->addressMock->expects($this->once())->method('getAddressType')->willReturn('not billing');
+ $totalMock->expects($this->once())->method('setTitle')->with('Total for this address');
+
+ $this->assertEquals([$totalMock], $this->model->getShippingAddressTotals($this->addressMock));
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Payment/InfoTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Payment/InfoTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..a369acc959245fc118a612c1ccd4c55e7411fae0
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Payment/InfoTest.php
@@ -0,0 +1,61 @@
+<?php
+/**
+ *
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Multishipping\Block\Checkout\Payment;
+
+class InfoTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var Info
+ */
+ protected $model;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $multiShippingMock;
+
+ protected function setUp()
+ {
+ $this->multiShippingMock =
+ $this->getMock('Magento\Multishipping\Model\Checkout\Type\Multishipping', [], [], '', false);
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+ $this->model = $objectManager->getObject('Magento\Multishipping\Block\Checkout\Payment\Info',
+ [
+ 'multishipping' => $this->multiShippingMock,
+ ]
+ );
+ }
+
+ public function testGetPaymentInfo()
+ {
+ $quoteMock = $this->getMock('Magento\Sales\Model\Quote', [], [], '', false);
+ $paymentInfoMock = $this->getMock('Magento\Payment\Model\Info', [], [], '', false);
+ $this->multiShippingMock->expects($this->once())->method('getQuote')->willReturn($quoteMock);
+ $quoteMock->expects($this->once())->method('getPayment')->willReturn($paymentInfoMock);
+
+ $this->model->getPaymentInfo();
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/ShippingTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/ShippingTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..62253689a613a47a8beea9d136f5f2e74867ede1
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/ShippingTest.php
@@ -0,0 +1,165 @@
+<?php
+/**
+ *
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Multishipping\Block\Checkout;
+
+use Magento\Framework\Pricing\PriceCurrencyInterface;
+
+class ShippingTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var Shipping
+ */
+ protected $model;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $multiShippingMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $scopeConfigMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $priceCurrencyMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $taxHelperMock;
+
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+ $this->scopeConfigMock = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface', [], [], '', false);
+ $this->multiShippingMock =
+ $this->getMock('Magento\Multishipping\Model\Checkout\Type\Multishipping', [], [], '', false);
+ $this->priceCurrencyMock =
+ $this->getMock('Magento\Framework\Pricing\PriceCurrencyInterface', [], [], '', false);
+ $this->taxHelperMock = $this->getMock('Magento\Tax\Helper\Data', [], [], '', false);
+ $this->model = $objectManager->getObject(
+ 'Magento\Multishipping\Block\Checkout\Shipping',
+ [
+ 'multishipping' => $this->multiShippingMock,
+ 'scopeConfig'=> $this->scopeConfigMock,
+ 'priceCurrency'=> $this->priceCurrencyMock,
+ 'taxHelper'=> $this->taxHelperMock
+ ]
+ );
+ }
+
+ public function testGetAddresses()
+ {
+ $quoteMock = $this->getMock('Magento\Sales\Model\Quote', [], [], '', false);
+ $this->multiShippingMock->expects($this->once())->method('getQuote')->will($this->returnValue($quoteMock));
+ $quoteMock->expects($this->once())
+ ->method('getAllShippingAddresses')->will($this->returnValue(['expected array']));
+ $this->assertEquals(['expected array'], $this->model->getAddresses());
+ }
+
+ public function testGetAddressShippingMethod()
+ {
+ $addressMock =$this->getMock(
+ 'Magento\Sales\Model\Quote\Address',
+ ['getShippingMethod', '__wakeup'],
+ [],
+ '',
+ false
+ );
+ $addressMock->expects($this->once())
+ ->method('getShippingMethod')->will($this->returnValue('expected shipping method'));
+ $this->assertEquals('expected shipping method', $this->model->getAddressShippingMethod($addressMock));
+ }
+
+ public function testGetShippingRates()
+ {
+ $addressMock =$this->getMock(
+ 'Magento\Sales\Model\Quote\Address',
+ ['getGroupedAllShippingRates', '__wakeup'],
+ [],
+ '',
+ false
+ );
+
+ $addressMock->expects($this->once())
+ ->method('getGroupedAllShippingRates')->will($this->returnValue(['expected array']));
+ $this->assertEquals(['expected array'], $this->model->getShippingRates($addressMock));
+ }
+
+ public function testGetCarrierName()
+ {
+ $carrierCode = 'some carrier code';
+ $name = 'some name';
+ $this->scopeConfigMock->expects($this->once())->method('getValue')->with('carriers/' . $carrierCode . '/title',
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE)->will($this->returnValue($name));
+
+ $this->assertEquals($name, $this->model->getCarrierName($carrierCode));
+ }
+
+ public function testGetCarrierNameWithEmptyName()
+ {
+ $carrierCode = 'some carrier code';
+ $this->scopeConfigMock->expects($this->once())->method('getValue')->with('carriers/' . $carrierCode . '/title',
+ \Magento\Store\Model\ScopeInterface::SCOPE_STORE)->will($this->returnValue(null));
+
+ $this->assertEquals($carrierCode, $this->model->getCarrierName($carrierCode));
+ }
+
+ public function testGetShippingPrice()
+ {
+ $addressMock =$this->getMock(
+ 'Magento\Sales\Model\Quote\Address',
+ ['getQuote', '__wakeup'],
+ [],
+ '',
+ false
+ );
+ $quoteMock = $this->getMock('Magento\Sales\Model\Quote', [], [], '', false);
+ $storeMock = $this->getMock('Magento\Store\Model\Store', [], [], '', false);
+ $price = 100;
+ $flag = true;
+ $shippingPrice = 11.11;
+ $this->taxHelperMock->expects($this->once())
+ ->method('getShippingPrice')->with($price, $flag, $addressMock)->will($this->returnValue($shippingPrice));
+ $addressMock->expects($this->once())->method('getQuote')->will($this->returnValue($quoteMock));
+ $quoteMock->expects($this->once())->method('getStore')->will($this->returnValue($storeMock));
+
+ $this->priceCurrencyMock->expects($this->once())
+ ->method('convertAndFormat')
+ ->with
+ (
+ $shippingPrice,
+ true,
+ PriceCurrencyInterface::DEFAULT_PRECISION,
+ $storeMock
+ );
+
+ $this->model->getShippingPrice($addressMock, $price, $flag);
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/StateTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/StateTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..14783b84a6275e35419902af1d9f5e129838d44a
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/StateTest.php
@@ -0,0 +1,59 @@
+<?php
+/**
+ *
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Multishipping\Block\Checkout;
+
+class StateTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var State
+ */
+ protected $model;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $mShippingStateMock;
+
+ protected function setUp()
+ {
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+ $this->mShippingStateMock =
+ $this->getMock('Magento\Multishipping\Model\Checkout\Type\Multishipping\State', [], [], '', false);
+ $this->model = $objectManager->getObject('Magento\Multishipping\Block\Checkout\State',
+ [
+ 'multishippingState' => $this->mShippingStateMock,
+ ]
+ );
+ }
+
+ public function testGetSteps()
+ {
+ $this->mShippingStateMock->expects($this->once())
+ ->method('getSteps')->will($this->returnValue(['expected array']));
+
+ $this->assertEquals(['expected array'], $this->model->getSteps());
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/SuccessTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/SuccessTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..435145f17d71254b1e3f072dc89d373680c619e1
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/SuccessTest.php
@@ -0,0 +1,106 @@
+<?php
+/**
+ *
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Multishipping\Block\Checkout;
+
+class SuccessTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var Success
+ */
+ protected $model;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $sessionMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $contextMock;
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $storeManagerMock;
+
+ protected function setUp()
+ {
+ $this->sessionMock = $this->getMock(
+ 'Magento\Framework\Session\SessionManagerInterface',
+ [
+ 'getOrderIds', 'start', 'writeClose', 'isSessionExists', 'getSessionId', 'getName', 'setName',
+ 'destroy', 'clearStorage', 'getCookieDomain', 'getCookiePath', 'getCookieLifetime', 'setSessionId',
+ 'regenerateId', 'expireSessionCookie', 'getSessionIdForHost', 'isValidForHost', 'isValidForPath',
+ '__wakeup'
+ ],
+ [],
+ '',
+ false
+ );
+ $this->contextMock = $this->getMock('Magento\Framework\View\Element\Template\Context', [], [], '', false);
+ $this->storeManagerMock = $this->getMock('Magento\Framework\StoreManagerInterface', [], [], '', false);
+
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
+ $this->contextMock->expects($this->once())->method('getSession')->will($this->returnValue($this->sessionMock));
+ $this->contextMock->expects($this->once())
+ ->method('getStoreManager')->will($this->returnValue($this->storeManagerMock));
+ $this->model = $objectManager->getObject('Magento\Multishipping\Block\Checkout\Success',
+ [
+ 'context' => $this->contextMock
+ ]);
+ }
+
+ public function testGetOrderIdsWithoutId()
+ {
+ $this->sessionMock->expects($this->once())->method('getOrderIds')->with(true)->will($this->returnValue(null));
+
+ $this->assertFalse($this->model->getOrderIds());
+ }
+
+ public function testGetOrderIdsWithEmptyIdsArray()
+ {
+ $this->sessionMock->expects($this->once())->method('getOrderIds')->with(true)->will($this->returnValue([]));
+
+ $this->assertFalse($this->model->getOrderIds());
+ }
+
+ public function testGetOrderIds()
+ {
+ $ids = [100, 102, 103];
+ $this->sessionMock->expects($this->once())->method('getOrderIds')->with(true)->will($this->returnValue($ids));
+
+ $this->assertEquals($ids, $this->model->getOrderIds());
+ }
+
+ public function testGetContinueUrl()
+ {
+ $storeMock = $this->getMock('Magento\Store\Model\Store', [], [], '', false);
+ $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($storeMock));
+ $storeMock->expects($this->once())->method('getBaseUrl')->will($this->returnValue('Expected Result'));
+
+ $this->assertEquals('Expected Result', $this->model->getContinueUrl());
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/PageCache/Model/App/FrontController/MessageBoxTest.php b/dev/tests/unit/testsuite/Magento/PageCache/Model/App/FrontController/MessageBoxTest.php
index af1a460790902701e809a48d37867c7296f7a0b8..137c6860bb93b7c46123f9ca93acff270a8173a8 100644
--- a/dev/tests/unit/testsuite/Magento/PageCache/Model/App/FrontController/MessageBoxTest.php
+++ b/dev/tests/unit/testsuite/Magento/PageCache/Model/App/FrontController/MessageBoxTest.php
@@ -40,7 +40,7 @@ class MessageBoxTest extends \PHPUnit_Framework_TestCase
/**
* Cookie manager mock
*
- * @var \Magento\Framework\Stdlib\CookieManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $cookieManagerMock;
@@ -82,9 +82,7 @@ class MessageBoxTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
- $this->cookieManagerMock = $this->getMockBuilder('Magento\Framework\Stdlib\CookieManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->cookieMetadataFactoryMock = $this->getMockBuilder(
'Magento\Framework\Stdlib\Cookie\CookieMetadataFactory'
)->disableOriginalConstructor()
diff --git a/dev/tests/unit/testsuite/Magento/Payment/Model/Cart/SalesModel/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Payment/Model/Cart/SalesModel/FactoryTest.php
index 6a462b55d52a0a086057a378687eb0f5d135fdd2..f8cd8964f2e43313ce92e7f165ecb899b153fa41 100644
--- a/dev/tests/unit/testsuite/Magento/Payment/Model/Cart/SalesModel/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Payment/Model/Cart/SalesModel/FactoryTest.php
@@ -28,12 +28,12 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Payment\Model\Cart\SalesModel\Factory */
protected $_model;
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $_objectManagerMock;
protected function setUp()
{
- $this->_objectManagerMock = $this->getMockForAbstractClass('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_model = new \Magento\Payment\Model\Cart\SalesModel\Factory($this->_objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Payment/Model/Method/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Payment/Model/Method/FactoryTest.php
index a085eb794312e7caab17a9cf1c8b5ed2856ebae2..73cd5229e1f74b28d904fde536644762c2a3f163 100644
--- a/dev/tests/unit/testsuite/Magento/Payment/Model/Method/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Payment/Model/Method/FactoryTest.php
@@ -26,7 +26,7 @@ namespace Magento\Payment\Model\Method;
class FactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManagerMock;
@@ -39,7 +39,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
{
$objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_factory = $objectManagerHelper->getObject(
'Magento\Payment\Model\Method\Factory',
array('objectManager' => $this->_objectManagerMock)
diff --git a/dev/tests/unit/testsuite/Magento/Payment/Model/Method/Specification/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Payment/Model/Method/Specification/FactoryTest.php
index 0a5505c2e636bedf3ee6e4083d8babf742dc95cf..1c0b7c85349572145a9ce7f4bfb8d46d0f9d4443 100644
--- a/dev/tests/unit/testsuite/Magento/Payment/Model/Method/Specification/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Payment/Model/Method/Specification/FactoryTest.php
@@ -29,7 +29,7 @@ namespace Magento\Payment\Model\Method\Specification;
class FactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -40,7 +40,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->factory = $objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Paypal/Controller/Billing/Agreement/CancelTest.php b/dev/tests/unit/testsuite/Magento/Paypal/Controller/Billing/Agreement/CancelTest.php
index 7ecb0a4e779a7c11dc9feff555213cffd863ee44..326250e6b83577459498886cc27a6c21a96eabb5 100644
--- a/dev/tests/unit/testsuite/Magento/Paypal/Controller/Billing/Agreement/CancelTest.php
+++ b/dev/tests/unit/testsuite/Magento/Paypal/Controller/Billing/Agreement/CancelTest.php
@@ -31,7 +31,7 @@ class CancelTest extends \PHPUnit_Framework_TestCase
protected $_controller;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManager;
@@ -75,7 +75,7 @@ class CancelTest extends \PHPUnit_Framework_TestCase
$this->_agreement->expects($this->once())->method('getId')->will($this->returnValue(15));
$this->_agreement->expects($this->once())->method('getCustomerId')->will($this->returnValue(871));
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_objectManager->expects(
$this->atLeastOnce()
)->method(
diff --git a/dev/tests/unit/testsuite/Magento/Paypal/Controller/ExpressTest.php b/dev/tests/unit/testsuite/Magento/Paypal/Controller/ExpressTest.php
index 7f4def65996fcda057730fcb2eefc80c364ba084..6d4d1c2d9c0cd918cba735ead106149f49497c6f 100644
--- a/dev/tests/unit/testsuite/Magento/Paypal/Controller/ExpressTest.php
+++ b/dev/tests/unit/testsuite/Magento/Paypal/Controller/ExpressTest.php
@@ -102,7 +102,7 @@ abstract class ExpressTest extends \PHPUnit_Framework_TestCase
->method('getQuote')
->will($this->returnValue($this->quote));
$this->session = $this->getMock('Magento\Framework\Session\Generic', [], [], '', false);
- $objectManager = $this->getMock('Magento\Framework\ObjectManager', [], [], '', false);
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->objectManagerCallback = function ($className) {
if ($className == 'Magento\Paypal\Model\Config') {
return $this->config;
diff --git a/dev/tests/unit/testsuite/Magento/Paypal/Helper/Shortcut/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Paypal/Helper/Shortcut/FactoryTest.php
index a857d20472e8617b8dc21f1432a217eb875b889e..93c4ebddb7ba3f629095aae351fbe4b1935b73d7 100644
--- a/dev/tests/unit/testsuite/Magento/Paypal/Helper/Shortcut/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Paypal/Helper/Shortcut/FactoryTest.php
@@ -34,12 +34,12 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
/** @var ObjectManagerHelper */
protected $objectManagerHelper;
- /** @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $objectManagerMock;
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->objectManagerHelper = new ObjectManagerHelper($this);
$this->factory = $this->objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Persistent/Model/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Persistent/Model/FactoryTest.php
index 47323077f68d35242106959158a5a9babbe32685..4a94fea7ba93509d5844a15fe9885593a2c3de42 100644
--- a/dev/tests/unit/testsuite/Magento/Persistent/Model/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Persistent/Model/FactoryTest.php
@@ -26,7 +26,7 @@ namespace Magento\Persistent\Model;
class FactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManagerMock;
@@ -39,7 +39,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
{
$helper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_factory = $helper->getObject(
'Magento\Persistent\Model\Factory',
array('objectManager' => $this->_objectManagerMock)
diff --git a/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/RemovePersistentCookieTest.php b/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/RemovePersistentCookieTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..13eb3fe2d1ed97196704e631ceece1fc931bbc64
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/RemovePersistentCookieTest.php
@@ -0,0 +1,135 @@
+<?php
+/**
+ *
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Persistent\Model\Observer;
+
+class RemovePersistentCookieTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var RemovePersistentCookie
+ */
+ protected $model;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $persistentMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $persistentDataMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $customerSessionMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $quoteManagerMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $observerMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $sessionModelMock;
+
+
+ protected function setUp()
+ {
+ $this->persistentMock = $this->getMock('Magento\Persistent\Helper\Session', [], [], '', false);
+ $this->sessionModelMock = $this->getMock('Magento\Persistent\Model\Session', [], [], '', false);
+ $this->persistentDataMock = $this->getMock('Magento\Persistent\Helper\Data', [], [], '', false);
+ $this->customerSessionMock = $this->getMock('Magento\Customer\Model\Session', [], [], '', false);
+ $this->quoteManagerMock = $this->getMock('Magento\Persistent\Model\QuoteManager', [], [], '', false);
+ $this->observerMock = $this->getMock('Magento\Framework\Event\Observer', [], [], '', false);
+
+ $this->model = new RemovePersistentCookie(
+ $this->persistentMock,
+ $this->persistentDataMock,
+ $this->customerSessionMock,
+ $this->quoteManagerMock);
+ }
+
+ public function testExecuteWithPersistentDataThatCanNotBeProcess()
+ {
+ $this->persistentDataMock->expects($this->once())
+ ->method('canProcess')->with($this->observerMock)->will($this->returnValue(false));
+ $this->persistentMock->expects($this->never())->method('getSession');
+
+ $this->model->execute($this->observerMock);
+ }
+
+ public function testExecuteWhenSessionIsNotPersistent()
+ {
+ $this->persistentDataMock->expects($this->once())
+ ->method('canProcess')->with($this->observerMock)->will($this->returnValue(true));
+ $this->persistentMock->expects($this->once())->method('isPersistent')->will($this->returnValue(false));
+
+ $this->persistentMock->expects($this->never())->method('getSession');
+
+ $this->model->execute($this->observerMock);
+ }
+
+ public function testExecuteWithNotLoggedInCustomer()
+ {
+ $this->persistentDataMock->expects($this->once())
+ ->method('canProcess')->with($this->observerMock)->will($this->returnValue(true));
+ $this->persistentMock->expects($this->once())->method('isPersistent')->will($this->returnValue(true));
+ $this->persistentMock->expects($this->once())
+ ->method('getSession')->will($this->returnValue($this->sessionModelMock));
+ $this->sessionModelMock->expects($this->once())->method('removePersistentCookie')->will($this->returnSelf());
+ $this->customerSessionMock->expects($this->once())->method('isLoggedIn')->will($this->returnValue(false));
+ $this->customerSessionMock->expects($this->once())
+ ->method('setCustomerId')->with(null)->will($this->returnSelf());
+ $this->customerSessionMock->expects($this->once())
+ ->method('setCustomerGroupId')->with(null)->will($this->returnSelf());
+ $this->quoteManagerMock->expects($this->once())->method('setGuest');
+
+ $this->model->execute($this->observerMock);
+ }
+
+ public function testExecute()
+ {
+ $this->persistentDataMock->expects($this->once())
+ ->method('canProcess')->with($this->observerMock)->will($this->returnValue(true));
+ $this->persistentMock->expects($this->once())->method('isPersistent')->will($this->returnValue(true));
+ $this->persistentMock->expects($this->once())
+ ->method('getSession')->will($this->returnValue($this->sessionModelMock));
+ $this->sessionModelMock->expects($this->once())->method('removePersistentCookie')->will($this->returnSelf());
+ $this->customerSessionMock->expects($this->once())->method('isLoggedIn')->will($this->returnValue(true));
+ $this->customerSessionMock->expects($this->never())->method('setCustomerId');
+ $this->customerSessionMock->expects($this->never())->method('setCustomerGroupId');
+ $this->quoteManagerMock->expects($this->once())->method('setGuest');
+
+ $this->model->execute($this->observerMock);
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Persistent/Model/QuoteManagerTest.php b/dev/tests/unit/testsuite/Magento/Persistent/Model/QuoteManagerTest.php
new file mode 100644
index 0000000000000000000000000000000000000000..436a3c843589c9a38233d103401398fa5a6438f5
--- /dev/null
+++ b/dev/tests/unit/testsuite/Magento/Persistent/Model/QuoteManagerTest.php
@@ -0,0 +1,265 @@
+<?php
+/**
+ *
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Persistent\Model;
+
+class QuoteManagerTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var QuoteManager
+ */
+ protected $model;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $persistentSessionMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $persistentDataMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $checkoutSessionMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $quoteMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $sessionMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $abstractCollectionMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $quoteRepositoryMock;
+
+ protected function setUp()
+ {
+ $this->persistentSessionMock = $this->getMock('Magento\Persistent\Helper\Session', [], [], '', false);
+ $this->sessionMock =
+ $this->getMock('Magento\Persistent\Model\Session',
+ [
+ 'setLoadInactive',
+ 'setCustomerData',
+ 'clearQuote',
+ 'clearStorage',
+ 'getQuote',
+ 'removePersistentCookie',
+ '__wakeup',
+ ],
+ [],
+ '',
+ false);
+ $this->persistentDataMock = $this->getMock('Magento\Persistent\Helper\Data', [], [], '', false);
+ $this->checkoutSessionMock = $this->getMock('Magento\Checkout\Model\Session', [], [], '', false);
+
+ $this->abstractCollectionMock =
+ $this->getMock('Magento\Eav\Model\Entity\Collection\AbstractCollection', [], [], '', false);
+
+ $this->quoteRepositoryMock =
+ $this->getMock('Magento\Sales\Model\QuoteRepository', [], [], '', false);
+
+ $this->quoteMock = $this->getMock('Magento\Sales\Model\Quote',
+ [
+ 'getId',
+ 'getIsPersistent',
+ 'getPaymentsCollection',
+ 'getAddressesCollection',
+ 'setIsActive',
+ 'setCustomerId',
+ 'setCustomerEmail',
+ 'setCustomerFirstname',
+ 'setCustomerLastname',
+ 'setCustomerGroupId',
+ 'setIsPersistent',
+ 'getShippingAddress',
+ 'getBillingAddress',
+ 'collectTotals',
+ 'removeAllAddresses',
+ 'getIsActive',
+ 'getCustomerId',
+ '__wakeup'
+ ],
+ [],
+ '',
+ false);
+
+ $this->model = new QuoteManager(
+ $this->persistentSessionMock,
+ $this->persistentDataMock,
+ $this->checkoutSessionMock,
+ $this->quoteRepositoryMock
+ );
+ }
+
+ public function testSetGuestWithEmptyQuote()
+ {
+ $this->checkoutSessionMock->expects($this->once())
+ ->method('getQuote')->will($this->returnValue(null));
+ $this->quoteMock->expects($this->never())->method('getId');
+
+ $this->persistentSessionMock->expects($this->once())
+ ->method('getSession')->will($this->returnValue($this->sessionMock));
+ $this->sessionMock->expects($this->once())
+ ->method('removePersistentCookie')->will($this->returnValue($this->sessionMock));
+
+ $this->model->setGuest(false);
+ }
+
+ public function testSetGuestWithEmptyQuoteId()
+ {
+ $this->checkoutSessionMock->expects($this->once())
+ ->method('getQuote')->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())->method('getId')->will($this->returnValue(null));
+ $this->persistentDataMock->expects($this->never())->method('isShoppingCartPersist');
+
+ $this->persistentSessionMock->expects($this->once())
+ ->method('getSession')->will($this->returnValue($this->sessionMock));
+ $this->sessionMock->expects($this->once())
+ ->method('removePersistentCookie')->will($this->returnValue($this->sessionMock));
+
+ $this->model->setGuest(false);
+ }
+
+ public function testSetGuestWhenShoppingCartAndQuoteAreNotPersistent()
+ {
+ $this->checkoutSessionMock->expects($this->once())
+ ->method('getQuote')->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())->method('getId')->will($this->returnValue(11));
+ $this->persistentDataMock->expects($this->once())
+ ->method('isShoppingCartPersist')->will($this->returnValue(false));
+ $this->quoteMock->expects($this->once())->method('getIsPersistent')->will($this->returnValue(false));
+ $this->checkoutSessionMock->expects($this->once())
+ ->method('clearQuote')->will($this->returnValue($this->checkoutSessionMock));
+ $this->checkoutSessionMock->expects($this->once())->method('clearStorage');
+ $this->quoteMock->expects($this->never())->method('getPaymentsCollection');
+
+ $this->model->setGuest(true);
+ }
+
+ public function testSetGuest()
+ {
+ $this->checkoutSessionMock->expects($this->once())
+ ->method('getQuote')->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())->method('getId')->will($this->returnValue(11));
+ $this->persistentDataMock->expects($this->never())->method('isShoppingCartPersist');
+ $this->quoteMock->expects($this->once())
+ ->method('getPaymentsCollection')->will($this->returnValue($this->abstractCollectionMock));
+ $this->quoteMock->expects($this->once())
+ ->method('getAddressesCollection')->will($this->returnValue($this->abstractCollectionMock));
+ $this->abstractCollectionMock->expects($this->exactly(2))->method('walk')->with('delete');
+ $this->quoteMock->expects($this->once())
+ ->method('setIsActive')->with(true)->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())
+ ->method('setCustomerId')->with(null)->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())
+ ->method('setCustomerEmail')->with(null)->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())
+ ->method('setCustomerFirstname')->with(null)->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())
+ ->method('setCustomerLastname')->with(null)->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())->method('setCustomerGroupId')
+ ->with(\Magento\Customer\Service\V1\CustomerGroupServiceInterface::NOT_LOGGED_IN_ID)
+ ->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())
+ ->method('setIsPersistent')->with(false)->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())
+ ->method('removeAllAddresses')->will($this->returnValue($this->quoteMock));
+ $quoteAddressMock = $this->getMock('Magento\Sales\Model\Quote\Address', [], [], '', false);
+ $this->quoteMock->expects($this->once())
+ ->method('getShippingAddress')->will($this->returnValue($quoteAddressMock));
+ $this->quoteMock->expects($this->once())
+ ->method('getBillingAddress')->will($this->returnValue($quoteAddressMock));
+ $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock));
+ $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock);
+ $this->persistentSessionMock->expects($this->once())
+ ->method('getSession')->will($this->returnValue($this->sessionMock));
+ $this->sessionMock->expects($this->once())
+ ->method('removePersistentCookie')->will($this->returnValue($this->sessionMock));
+
+ $this->model->setGuest(false);
+ }
+
+ public function testExpireWithActiveQuoteAndCustomerId()
+ {
+ $this->checkoutSessionMock->expects($this->once())
+ ->method('setLoadInactive')->will($this->returnValue($this->sessionMock));
+
+ $this->sessionMock->expects($this->once())->method('getQuote')->will($this->returnValue($this->quoteMock));
+
+ $this->quoteMock->expects($this->once())->method('getIsActive')->will($this->returnValue(11));
+ $this->quoteMock->expects($this->once())->method('getCustomerId')->will($this->returnValue(22));
+
+ $this->checkoutSessionMock->expects($this->once())
+ ->method('setCustomerData')->with(null)->will($this->returnValue($this->sessionMock));
+
+ $this->sessionMock->expects($this->once())
+ ->method('clearQuote')->will($this->returnValue($this->sessionMock));
+ $this->sessionMock->expects($this->once())
+ ->method('clearStorage')->will($this->returnValue($this->sessionMock));
+ $this->quoteMock->expects($this->never())->method('setIsActive');
+
+ $this->model->expire();
+ }
+
+ public function testExpire()
+ {
+ $this->checkoutSessionMock->expects($this->once())
+ ->method('setLoadInactive')->will($this->returnValue($this->sessionMock));
+ $this->sessionMock->expects($this->once())->method('getQuote')->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())->method('getIsActive')->will($this->returnValue(0));
+ $this->checkoutSessionMock->expects($this->never())->method('setCustomerData');
+ $this->quoteMock->expects($this->once())
+ ->method('setIsActive')
+ ->with(true)
+ ->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())
+ ->method('setIsPersistent')
+ ->with(false)
+ ->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())
+ ->method('setCustomerId')
+ ->with(null)
+ ->will($this->returnValue($this->quoteMock));
+ $this->quoteMock->expects($this->once())
+ ->method('setCustomerGroupId')
+ ->with(\Magento\Customer\Service\V1\CustomerGroupServiceInterface::NOT_LOGGED_IN_ID)
+ ->will($this->returnValue($this->quoteMock));
+
+ $this->model->expire();
+ }
+}
diff --git a/dev/tests/unit/testsuite/Magento/Persistent/Model/SessionTest.php b/dev/tests/unit/testsuite/Magento/Persistent/Model/SessionTest.php
index 2ae45f8ba6b092d7dd6e2d6f81f069860256cb70..fbe9b39d44dc03fa1308ddeb31ff6742ea84a6c7 100644
--- a/dev/tests/unit/testsuite/Magento/Persistent/Model/SessionTest.php
+++ b/dev/tests/unit/testsuite/Magento/Persistent/Model/SessionTest.php
@@ -36,7 +36,7 @@ class SessionTest extends \PHPUnit_Framework_TestCase
protected $configMock;
/**
- * @var \Magento\Framework\Stdlib\CookieManager |\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface |\PHPUnit_Framework_MockObject_MockObject
*/
protected $cookieManagerMock;
@@ -49,9 +49,7 @@ class SessionTest extends \PHPUnit_Framework_TestCase
{
$helper = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->configMock = $this->getMock('Magento\Framework\Session\Config\ConfigInterface');
- $this->cookieManagerMock = $this->getMockBuilder('Magento\Framework\Stdlib\CookieManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->cookieMetadataFactoryMock = $this->getMockBuilder(
'Magento\Framework\Stdlib\Cookie\CookieMetadataFactory'
)->disableOriginalConstructor()
diff --git a/dev/tests/unit/testsuite/Magento/Review/Controller/Adminhtml/Product/PostTest.php b/dev/tests/unit/testsuite/Magento/Review/Controller/Adminhtml/Product/PostTest.php
index 8ad7ed218d62580a1ca81ac924e0081170c8dfef..08492f4ddc892916251f49e87a90caee68e2aee2 100644
--- a/dev/tests/unit/testsuite/Magento/Review/Controller/Adminhtml/Product/PostTest.php
+++ b/dev/tests/unit/testsuite/Magento/Review/Controller/Adminhtml/Product/PostTest.php
@@ -149,9 +149,7 @@ class PostTest extends \PHPUnit_Framework_TestCase
$this->_responseMock = $this->getMock(
'\Magento\Framework\App\ResponseInterface', array('setRedirect', 'sendResponse')
);
- $this->_objectManagerMock = $this->getMock(
- '\Magento\Framework\ObjectManager', array('get', 'create', 'configure'), array(), '', false
- );
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_messageManagerMock = $this->getMock('\Magento\Framework\Message\Manager', array(), array(), '', false);
$this->_storeManagerInterfaceMock = $this->getMockForAbstractClass('Magento\Framework\StoreManagerInterface');
$this->_storeModelMock = $this->getMock(
diff --git a/dev/tests/unit/testsuite/Magento/Rss/Model/RssManagerTest.php b/dev/tests/unit/testsuite/Magento/Rss/Model/RssManagerTest.php
index 635ae919217d6d137b97731cd1f97602cd50e4de..a8aceac19172861edb85b94ff4b1a49f5c8ef84f 100644
--- a/dev/tests/unit/testsuite/Magento/Rss/Model/RssManagerTest.php
+++ b/dev/tests/unit/testsuite/Magento/Rss/Model/RssManagerTest.php
@@ -34,13 +34,13 @@ class RssManagerTest extends \PHPUnit_Framework_TestCase
protected $rssManager;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManager;
protected function setUp()
{
- $this->objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerHelper = new ObjectManagerHelper($this);
$this->rssManager = $objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Rule/Model/ActionFactoryTest.php b/dev/tests/unit/testsuite/Magento/Rule/Model/ActionFactoryTest.php
index 7ccc9c55de707344b7d4186b7f4cdffd461be824..760436f7a347656c396a43b320491532a0345173 100644
--- a/dev/tests/unit/testsuite/Magento/Rule/Model/ActionFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Rule/Model/ActionFactoryTest.php
@@ -39,13 +39,13 @@ class ActionFactoryTest extends \PHPUnit_Framework_TestCase
protected $objectManagerHelper;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->objectManagerHelper = new ObjectManagerHelper($this);
$this->actionFactory = $this->objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Rule/Model/ConditionFactoryTest.php b/dev/tests/unit/testsuite/Magento/Rule/Model/ConditionFactoryTest.php
index d9f6fcde1a5514c21703ad8c11727f332945e30d..40960a586d94f3b182da04b33e188562a6564609 100644
--- a/dev/tests/unit/testsuite/Magento/Rule/Model/ConditionFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Rule/Model/ConditionFactoryTest.php
@@ -39,13 +39,13 @@ class ConditionFactoryTest extends \PHPUnit_Framework_TestCase
protected $objectManagerHelper;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
protected function setUp()
{
- $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->objectManagerHelper = new ObjectManagerHelper($this);
$this->conditionFactory = $this->objectManagerHelper->getObject(
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Items/AbstractItemsTest.php b/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Items/AbstractItemsTest.php
index aa7edc862ade12ae73cd89bace59d55edadcd2c0..b1e56df85ae92416c4f3bb5d6cb7aa68d7a795cc 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Items/AbstractItemsTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Items/AbstractItemsTest.php
@@ -25,14 +25,43 @@ namespace Magento\Sales\Block\Adminhtml\Items;
use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper;
+/**
+ * Class AbstractItemsTest
+ * @package Magento\Sales\Block\Adminhtml\Items
+ * TODO refactor me PLEASE
+ */
class AbstractItemsTest extends \PHPUnit_Framework_TestCase
{
/** @var ObjectManagerHelper */
protected $objectManagerHelper;
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
+ protected $stockItemMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistry;
+
protected function setUp()
{
$this->objectManagerHelper = new ObjectManagerHelper($this);
+ $this->stockRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\StockRegistry')
+ ->disableOriginalConstructor()
+ ->setMethods(['getStockItem', '__wakeup'])
+ ->getMock();
+
+ $this->stockItemMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Stock\Item',
+ ['getManageStock', '__wakeup'],
+ [],
+ '',
+ false
+ );
+
+ $this->stockRegistry->expects($this->any())
+ ->method('getStockItem')
+ ->will($this->returnValue($this->stockItemMock));
}
public function testGetItemRenderer()
@@ -116,30 +145,22 @@ class AbstractItemsTest extends \PHPUnit_Framework_TestCase
*/
public function testCanReturnItemToStock($canReturnToStock, $itemConfig, $result)
{
- $isItem = $itemConfig['is_item'];
$productId = isset($itemConfig['product_id']) ? $itemConfig['product_id'] : null;
$manageStock = isset($itemConfig['manage_stock']) ? $itemConfig['manage_stock'] : null;
- $item = null;
-
- if ($isItem) {
- $item = $this->getMock(
- 'Magento\Sales\Model\Order\Creditmemo\Item',
- ['hasCanReturnToStock', 'getOrderItem', 'setCanReturnToStock', 'getCanReturnToStock', '__wakeup'],
- [],
- '',
- false
- );
- $dependencies = $this->prepareServiceMockDependency(
- $item,
- $canReturnToStock,
- $productId,
- $manageStock,
- $itemConfig
- );
- } else {
- $dependencies = $this->prepareScopeConfigMockDependency($canReturnToStock);
-
- }
+ $item = $this->getMock(
+ 'Magento\Sales\Model\Order\Creditmemo\Item',
+ ['hasCanReturnToStock', 'getOrderItem', 'setCanReturnToStock', 'getCanReturnToStock', '__wakeup'],
+ [],
+ '',
+ false
+ );
+ $dependencies = $this->prepareServiceMockDependency(
+ $item,
+ $canReturnToStock,
+ $productId,
+ $manageStock,
+ $itemConfig
+ );
/** @var $block \Magento\Sales\Block\Adminhtml\Items\AbstractItems */
$block = $this->objectManagerHelper->getObject(
@@ -149,29 +170,6 @@ class AbstractItemsTest extends \PHPUnit_Framework_TestCase
$this->assertSame($result, $block->canReturnItemToStock($item));
}
- /**
- * @param bool $canReturnToStock
- * @return array
- */
- protected function prepareScopeConfigMockDependency($canReturnToStock)
- {
- $dependencies = [];
- $scopeConfig = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface');
- $scopeConfig->expects($this->once())
- ->method('getValue')
- ->with(
- $this->equalTo(\Magento\CatalogInventory\Model\Stock\Item::XML_PATH_CAN_SUBTRACT),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
- ->will($this->returnValue($canReturnToStock));
-
- $dependencies['context'] = $this->objectManagerHelper->getObject(
- 'Magento\Backend\Block\Template\Context',
- array('scopeConfig' => $scopeConfig)
- );
- return $dependencies;
- }
-
/**
* @param \PHPUnit_Framework_MockObject_MockObject $item
* @param bool $canReturnToStock
@@ -183,37 +181,38 @@ class AbstractItemsTest extends \PHPUnit_Framework_TestCase
protected function prepareServiceMockDependency($item, $canReturnToStock, $productId, $manageStock, $itemConfig)
{
$dependencies = [];
+
+ $this->stockItemMock->expects($this->any())
+ ->method('getManageStock')
+ ->will($this->returnValue($manageStock));
+ $dependencies['stockRegistry'] = $this->stockRegistry;
+
$item->expects($this->once())
->method('hasCanReturnToStock')
->will($this->returnValue($itemConfig['has_can_return_to_stock']));
if (!$itemConfig['has_can_return_to_stock']) {
$orderItem = $this->getMock(
'Magento\Sales\Model\Order\Item',
- ['getProductId', '__wakeup'],
+ ['getProductId', '__wakeup', 'getStore'],
[],
'',
false
);
+
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId'], [], '', false);
+ $store->expects($this->once())
+ ->method('getWebsiteId')
+ ->will($this->returnValue(10));
+ $orderItem->expects($this->once())
+ ->method('getStore')
+ ->will($this->returnValue($store));
+
$orderItem->expects($this->once())
->method('getProductId')
->will($this->returnValue($productId));
- $item->expects($this->once())
+ $item->expects($this->any())
->method('getOrderItem')
->will($this->returnValue($orderItem));
- if ($productId) {
- $stockItemService = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
- [],
- [],
- '',
- false
- );
- $stockItemService->expects($this->once())
- ->method('getManageStock')
- ->with($this->equalTo($productId))
- ->will($this->returnValue($manageStock));
- $dependencies['stockItemService'] = $stockItemService;
- }
if ($productId && $manageStock) {
$canReturn = true;
} else {
@@ -231,50 +230,38 @@ class AbstractItemsTest extends \PHPUnit_Framework_TestCase
return $dependencies;
}
+ public function testCanReturnItemToStockEmpty()
+ {
+ $stockConfiguration = $this->getMockBuilder('Magento\CatalogInventory\Model\Configuration')
+ ->disableOriginalConstructor()
+ ->setMethods(['canSubtractQty', '__wakeup'])
+ ->getMock();
+ $stockConfiguration->expects($this->once())
+ ->method('canSubtractQty')
+ ->will($this->returnValue(true));
+
+ /** @var $block \Magento\Sales\Block\Adminhtml\Items\AbstractItems */
+ $block = $this->objectManagerHelper->getObject(
+ 'Magento\Sales\Block\Adminhtml\Items\AbstractItems',
+ [
+ 'stockConfiguration' => $stockConfiguration
+ ]
+ );
+ $result = $block->canReturnItemToStock();
+ $this->assertTrue($result);
+ }
+
+
/**
* @return array
*/
public function canReturnItemToStockDataProvider()
{
return [
- [true, ['is_item' => null], true],
- [false, ['is_item' => null], false],
- [
- true,
- [
- 'is_item' => true,
- 'has_can_return_to_stock' => true
- ],
- true
- ],
- [
- false,
- [
- 'is_item' => true,
- 'has_can_return_to_stock' => true
- ],
- false
- ],
- [
- false,
- [
- 'is_item' => true,
- 'has_can_return_to_stock' => false,
- 'product_id' => 2,
- 'manage_stock' => false
- ],
- false
- ],
- [
- true,
- [
- 'is_item' => true,
- 'has_can_return_to_stock' => false,
- 'product_id' => 2,
- 'manage_stock' => true
- ],
- true
- ],
+ [true, ['has_can_return_to_stock' => true], true],
+ [false, ['has_can_return_to_stock' => true], false],
+ [false, ['has_can_return_to_stock' => false, 'product_id' => 2, 'manage_stock' => false], false],
+ [true, ['has_can_return_to_stock' => false, 'product_id' => 2, 'manage_stock' => true], true],
];
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Items/GridTest.php b/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Items/GridTest.php
index d383b8894f24675560ee8d1aac322acd3ee74ace..8f1cf1c324d7d616ea665f908043921bcbab48f0 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Items/GridTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Items/GridTest.php
@@ -30,9 +30,6 @@ class GridTest extends \PHPUnit_Framework_TestCase
*/
protected $block;
- /** @var \PHPUnit_Framework_MockObject_MockObject|\Magento\CatalogInventory\Service\V1\StockItemService */
- protected $stockItemService;
-
/**
* @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Backend\Block\Template
*/
@@ -56,6 +53,19 @@ class GridTest extends \PHPUnit_Framework_TestCase
*/
protected $priceCurrency;
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
+ protected $stockItemMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistry;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockState;
+
/**
* Initialize required data
*/
@@ -94,14 +104,32 @@ class GridTest extends \PHPUnit_Framework_TestCase
->getMock();
$taxConfig = $this->getMockBuilder('Magento\Tax\Model\Config')->disableOriginalConstructor()->getMock();
- $this->stockItemService = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
+
+ $this->stockRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\StockRegistry')
+ ->disableOriginalConstructor()
+ ->setMethods(['getStockItem', '__wakeup'])
+ ->getMock();
+
+ $this->stockItemMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Stock\Item',
+ ['getIsInStock', '__wakeup'],
[],
+ '',
+ false
+ );
+
+ $this->stockState = $this->getMock(
+ 'Magento\CatalogInventory\Model\StockState',
+ ['checkQuoteItemQty', '__wakeup'],
[],
'',
false
);
+ $this->stockRegistry->expects($this->any())
+ ->method('getStockItem')
+ ->will($this->returnValue($this->stockItemMock));
+
$this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->block = $this->objectManager->getObject(
'Magento\Sales\Block\Adminhtml\Order\Create\Items\Grid',
@@ -114,7 +142,8 @@ class GridTest extends \PHPUnit_Framework_TestCase
'orderCreate' => $orderCreateMock,
'priceCurrency' => $this->priceCurrency,
'coreData' => $coreData,
- 'stockItemService' => $this->stockItemService
+ 'stockRegistry' => $this->stockRegistry,
+ 'stockState' => $this->stockState
)
);
@@ -249,12 +278,14 @@ class GridTest extends \PHPUnit_Framework_TestCase
$checkMock->expects($this->any())->method('getMessage')->will($this->returnValue('Message'));
$checkMock->expects($this->any())->method('getHasError')->will($this->returnValue(false));
- $this->stockItemService->expects($this->once())
+ $this->stockState->expects($this->once())
->method('checkQuoteItemQty')
->with(
- $this->equalTo($productId),
- $this->equalTo($itemQty),
- $this->equalTo($itemQty)
+ $productId,
+ $itemQty,
+ $itemQty,
+ $itemQty,
+ null
)
->will($this->returnValue($checkMock));
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Creditmemo/Create/ItemsTest.php b/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Creditmemo/Create/ItemsTest.php
index e0953afda7a866c1ed42678c9821fb81d9e4ffb9..be241b71c4805b6ae29f03ab19106c06eb20f5c1 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Creditmemo/Create/ItemsTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Creditmemo/Create/ItemsTest.php
@@ -21,7 +21,6 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-
namespace Magento\Sales\Block\Adminhtml\Order\Creditmemo\Create;
use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper;
@@ -37,7 +36,7 @@ class ItemsTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Backend\Block\Template\Context|\PHPUnit_Framework_MockObject_MockObject */
protected $contextMock;
- /** @var \Magento\CatalogInventory\Service\V1\StockItemService|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\CatalogInventory\Api\Data\StockItemInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $stockItemMock;
/** @var \Magento\Framework\Registry|\PHPUnit_Framework_MockObject_MockObject */
@@ -46,16 +45,42 @@ class ItemsTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Framework\App\Config\ScopeConfigInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $scopeConfig;
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
+ protected $stockConfiguration;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistry;
+
protected function setUp()
{
$this->contextMock = $this->getMock('Magento\Backend\Block\Template\Context', [], [], '', false);
+ $this->stockRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\StockRegistry')
+ ->disableOriginalConstructor()
+ ->setMethods(['getStockItem', '__wakeup'])
+ ->getMock();
+
$this->stockItemMock = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
+ 'Magento\CatalogInventory\Model\Stock\Item',
+ ['getManageStock', '__wakeup'],
[],
+ '',
+ false
+ );
+
+ $this->stockConfiguration = $this->getMock(
+ 'Magento\CatalogInventory\Model\Configuration',
+ ['__wakeup', 'canSubtractQty'],
[],
'',
false
);
+
+ $this->stockRegistry->expects($this->any())
+ ->method('getStockItem')
+ ->will($this->returnValue($this->stockItemMock));
+
$this->registryMock = $this->getMock('Magento\Framework\Registry');
$this->scopeConfig = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface');
$this->contextMock->expects($this->once())
@@ -67,7 +92,8 @@ class ItemsTest extends \PHPUnit_Framework_TestCase
'Magento\Sales\Block\Adminhtml\Order\Creditmemo\Create\Items',
[
'context' => $this->contextMock,
- 'stockItemService' => $this->stockItemMock,
+ 'stockRegistry' => $this->stockRegistry,
+ 'stockConfiguration' => $this->stockConfiguration,
'registry' => $this->registryMock
]
);
@@ -85,16 +111,25 @@ class ItemsTest extends \PHPUnit_Framework_TestCase
$property = new \ReflectionProperty($this->items, '_canReturnToStock');
$property->setAccessible(true);
$this->assertNull($property->getValue($this->items));
- $this->scopeConfig->expects($this->once())
- ->method('getValue')
- ->with(
- $this->equalTo(\Magento\CatalogInventory\Model\Stock\Item::XML_PATH_CAN_SUBTRACT),
- $this->equalTo(\Magento\Store\Model\ScopeInterface::SCOPE_STORE)
- )
+ $this->stockConfiguration->expects($this->once())
+ ->method('canSubtractQty')
->will($this->returnValue($canReturnToStock));
if ($canReturnToStock) {
- $orderItem = $this->getMock('Magento\Sales\Model\Order\Item', ['getProductId', '__wakeup'], [], '', false);
+ $orderItem = $this->getMock(
+ 'Magento\Sales\Model\Order\Item',
+ ['getProductId', '__wakeup', 'getStore'],
+ [],
+ '',
+ false
+ );
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId'], [], '', false);
+ $store->expects($this->once())
+ ->method('getWebsiteId')
+ ->will($this->returnValue(10));
+ $orderItem->expects($this->any())
+ ->method('getStore')
+ ->will($this->returnValue($store));
$orderItem->expects($this->once())
->method('getProductId')
->will($this->returnValue($productId));
@@ -111,13 +146,12 @@ class ItemsTest extends \PHPUnit_Framework_TestCase
$creditMemo->expects($this->once())
->method('getAllItems')
->will($this->returnValue([$creditMemoItem]));
- $creditMemoItem->expects($this->once())
+ $creditMemoItem->expects($this->any())
->method('getOrderItem')
->will($this->returnValue($orderItem));
$this->stockItemMock->expects($this->once())
->method('getManageStock')
- ->with($this->equalTo($productId))
->will($this->returnValue($manageStock));
$creditMemoItem->expects($this->once())
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Block/Reorder/SidebarTest.php b/dev/tests/unit/testsuite/Magento/Sales/Block/Reorder/SidebarTest.php
index 60644eb5717a51df87488c8945e6dd0571b858e7..dfdd0c6f709fda29f3f06b8bd61ae11c8e6d6e49 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Block/Reorder/SidebarTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Block/Reorder/SidebarTest.php
@@ -23,6 +23,8 @@
*/
namespace Magento\Sales\Block\Reorder;
+use Magento\Customer\Model\Context;
+
/**
* Class SidebarTest
*
@@ -65,14 +67,19 @@ class SidebarTest extends \PHPUnit_Framework_TestCase
*/
protected $orderCollection;
- /** @var \Magento\CatalogInventory\Service\V1\StockItemService|\PHPUnit_Framework_MockObject_MockObject */
- protected $stockItemService;
-
/**
* @var \Magento\TestFramework\Helper\ObjectManager
*/
protected $objectManagerHelper;
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
+ protected $stockItemMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistry;
+
protected function setUp()
{
$this->objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
@@ -111,13 +118,22 @@ class SidebarTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $this->stockItemService = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
- [],
+ $this->stockRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\StockRegistry')
+ ->disableOriginalConstructor()
+ ->setMethods(['getStockItem', '__wakeup'])
+ ->getMock();
+
+ $this->stockItemMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Stock\Item',
+ ['getIsInStock', '__wakeup'],
[],
'',
false
);
+
+ $this->stockRegistry->expects($this->any())
+ ->method('getStockItem')
+ ->will($this->returnValue($this->stockItemMock));
}
protected function tearDown()
@@ -135,7 +151,7 @@ class SidebarTest extends \PHPUnit_Framework_TestCase
'orderConfig' => $this->orderConfig,
'customerSession' => $this->customerSession,
'httpContext' => $this->httpContext,
- 'stockItemService' => $this->stockItemService,
+ 'stockRegistry' => $this->stockRegistry,
]
);
}
@@ -210,7 +226,7 @@ class SidebarTest extends \PHPUnit_Framework_TestCase
$this->httpContext->expects($this->once())
->method('getValue')
- ->with($this->equalTo(\Magento\Customer\Helper\Data::CONTEXT_AUTH))
+ ->with($this->equalTo(Context::CONTEXT_AUTH))
->will($this->returnValue(true));
$this->customerSession->expects($this->once())
@@ -261,17 +277,27 @@ class SidebarTest extends \PHPUnit_Framework_TestCase
$product->expects($this->once())
->method('getId')
->will($this->returnValue($productId));
- $this->stockItemService->expects($this->once())
+ $this->stockItemMock->expects($this->once())
->method('getIsInStock')
- ->with($this->equalTo($productId))
->will($this->returnValue($result));
+ $this->stockRegistry->expects($this->any())
+ ->method('getStockItem')
+ ->will($this->returnValue($this->stockItemMock));
} else {
$product = false;
}
- $orderItem = $this->getMock('Magento\Sales\Model\Order\Item', [], [], '', false);
+ $orderItem = $this->getMock('Magento\Sales\Model\Order\Item', ['getStore', 'getProduct'], [], '', false);
$orderItem->expects($this->any())
->method('getProduct')
->will($this->returnValue($product));
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId'], [], '', false);
+ $store->expects($this->any())
+ ->method('getWebsiteId')
+ ->will($this->returnValue(10));
+ $orderItem->expects($this->any())
+ ->method('getStore')
+ ->will($this->returnValue($store));
+
$this->createBlockObject();
$this->assertSame($result, $this->block->isItemAvailableForReorder($orderItem));
}
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/AddCommentTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/AddCommentTest.php
index 077fe2530211323d39e34f4e66afc2c443a89ef7..ce096941d34da22e4a1d6bd7f305aebe703041d4 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/AddCommentTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/AddCommentTest.php
@@ -82,10 +82,7 @@ class AddCommentTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->viewMock = $this->getMockBuilder('Magento\Backend\Model\View')
->disableOriginalConstructor()
->setMethods([])
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/CancelTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/CancelTest.php
index d9d2e30943d5d2c9087b4b7a693e963c931f85ba..3991685f0e4b1a1080cb733c2ea5a7eea2aaae09 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/CancelTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/CancelTest.php
@@ -106,10 +106,7 @@ class CancelTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->viewMock = $this->getMockBuilder('Magento\Backend\Model\View')
->disableOriginalConstructor()
->setMethods([])
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/NewActionTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/NewActionTest.php
index c053d17c6629d11d6974eb6e36ce6004cd25f631..03dbb490f93a87c7c98777ed1dbec0007b518995 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/NewActionTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/NewActionTest.php
@@ -69,7 +69,7 @@ class NewActionTest extends \PHPUnit_Framework_TestCase
protected $titleMock;
/**
- * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\ObjectManager
+ * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\ObjectManagerInterface
*/
protected $objectManagerMock;
@@ -127,15 +127,7 @@ class NewActionTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $this->objectManagerMock = $this->getMockForAbstractClass(
- 'Magento\Framework\ObjectManager',
- [],
- '',
- false,
- false,
- true,
- []
- );
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->requestMock = $this->getMockForAbstractClass(
'Magento\Framework\App\RequestInterface',
[],
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php
index 96e4db2f2d175cd45a45ac0a89e574d5d407dddf..d025a68b2b9d09183c3ab1f3dff62cdc733c886b 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php
@@ -111,10 +111,7 @@ class PrintActionTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->viewMock = $this->getMockBuilder('Magento\Backend\Model\View')
->disableOriginalConstructor()
->setMethods([])
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php
index b6f5262d597be49926ea76790757f2104e6222a9..de61cbaaf077e96522f710889819797a86a390bc 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php
@@ -46,7 +46,7 @@ class SaveTest extends \PHPUnit_Framework_TestCase
protected $_sessionMock;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManager;
@@ -79,7 +79,7 @@ class SaveTest extends \PHPUnit_Framework_TestCase
array('setFormData'),
$constructArguments
);
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$registryMock = $this->getMock('Magento\Framework\Registry', array(), array(), '', false, false);
$this->_objectManager->expects(
$this->any()
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/UpdateQtyTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/UpdateQtyTest.php
index 99d41c83adcdb81cefd58f05f226342b7a7d2231..823535dc4fc600cf13ad2c082a758445402a790e 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/UpdateQtyTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/UpdateQtyTest.php
@@ -106,10 +106,7 @@ class UpdateQtyTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->viewMock = $this->getMockBuilder('Magento\Backend\Model\View')
->disableOriginalConstructor()
->setMethods([])
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php
index de583046573a2e70e87ef44d466be8e92d6e48c6..6e063c71505d54d4f5d327bc8188ccc795d825b9 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php
@@ -115,10 +115,7 @@ class ViewTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->viewMock = $this->getMockBuilder('Magento\Backend\Model\View')
->disableOriginalConstructor()
->setMethods([])
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/VoidTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/VoidTest.php
index 5a2479f69b95f4f3b1d74a02c303647e474e3303..f8922297bc8e04ec454c9450e891988fa1c80e5c 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/VoidTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/VoidTest.php
@@ -111,10 +111,7 @@ class VoidTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->viewMock = $this->getMockBuilder('Magento\Backend\Model\View')
->disableOriginalConstructor()
->setMethods([])
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoaderTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoaderTest.php
index ff9459bb1130fff6ad8279c5b8bf791e3e88407b..a6255d411ee3c3df03a03246964eab2050b2632d 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoaderTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoaderTest.php
@@ -80,6 +80,11 @@ class CreditmemoLoaderTest extends \PHPUnit_Framework_TestCase
*/
protected $helperMock;
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockConfiguration;
+
public function setUp()
{
$data = [];
@@ -120,6 +125,11 @@ class CreditmemoLoaderTest extends \PHPUnit_Framework_TestCase
->setMethods([])
->getMock();
+ $this->stockConfiguration = $this->getMockBuilder('Magento\CatalogInventory\Model\Configuration')
+ ->disableOriginalConstructor()
+ ->setMethods([])
+ ->getMock();
+
$this->loader = new \Magento\Sales\Controller\Adminhtml\Order\CreditmemoLoader(
$this->creditmemoFactoryMock,
$this->orderFactoryMock,
@@ -129,7 +139,7 @@ class CreditmemoLoaderTest extends \PHPUnit_Framework_TestCase
$this->sessionMock,
$this->messageManagerMock,
$this->registryMock,
- $this->helperMock,
+ $this->stockConfiguration,
$data
);
}
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/AddCommentTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/AddCommentTest.php
index 4bf524f2f63c50293da0273668b235e93f94727b..bd51ea240763f1ef8da48ef9737c3e6b6c6a8a25 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/AddCommentTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/AddCommentTest.php
@@ -84,10 +84,7 @@ class AddCommentTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$contextMock = $this->getMockBuilder('Magento\Backend\App\Action\Context')
->disableOriginalConstructor()
->setMethods([])
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/CancelTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/CancelTest.php
index 24804a033d4af35445a307213ed63934a8cb7a13..292888307a4a0f25dc4ba5289ad3c77332161da7 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/CancelTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/CancelTest.php
@@ -87,10 +87,7 @@ class CancelTest extends \PHPUnit_Framework_TestCase
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->messageManagerMock = $this->getMockBuilder('Magento\Framework\Message\Manager')
->disableOriginalConstructor()
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/CaptureTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/CaptureTest.php
index 503d8c90e3f67c53fdf5a9d15ca38569186466db..14bf1361d7b64a936d922fce1bae554f6686a00a 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/CaptureTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/CaptureTest.php
@@ -87,10 +87,7 @@ class CaptureTest extends \PHPUnit_Framework_TestCase
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->messageManagerMock = $this->getMockBuilder('Magento\Framework\Message\Manager')
->disableOriginalConstructor()
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewActionTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewActionTest.php
index f0779b82e778482ecfdb4d83541e41d80f3e6e98..c9393aaca81e21177f2987ccac91c7148bc39158 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewActionTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewActionTest.php
@@ -85,10 +85,7 @@ class NewActionTest extends \PHPUnit_Framework_TestCase
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->actionFlagMock = $this->getMockBuilder('Magento\Framework\App\ActionFlag')
->disableOriginalConstructor()
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/UpdateQtyTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/UpdateQtyTest.php
index b398a1e8c9264ee1a062889c4cc48fad654c4fd1..789598ba4422963a5968fd5c13b1d932083392f4 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/UpdateQtyTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/UpdateQtyTest.php
@@ -87,10 +87,7 @@ class UpdateQtyTest extends \PHPUnit_Framework_TestCase
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$contextMock = $this->getMockBuilder('Magento\Backend\App\Action\Context')
->disableOriginalConstructor()
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/VoidTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/VoidTest.php
index bfe5b4ae22612482473d8bd3990169c8cd782eb4..76d5793f65e7e8514ad84572f0836b743edb6777 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/VoidTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/VoidTest.php
@@ -97,10 +97,7 @@ class VoidTest extends \PHPUnit_Framework_TestCase
->setMethods([])
->getMock();
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->messageManagerMock = $this->getMockBuilder('Magento\Framework\Message\Manager')
->disableOriginalConstructor()
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/InvoiceLoaderTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/InvoiceLoaderTest.php
index 512fd5db983e5e521233feb1777f2090b0d6b475..0aa0d14e3d2151eb9e2217b94feb7ac13bbb1698 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/InvoiceLoaderTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/InvoiceLoaderTest.php
@@ -53,10 +53,7 @@ class InvoiceLoaderTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
- $this->objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->registryMock = $this->getMockBuilder('Magento\Framework\Registry')
->disableOriginalConstructor()
->setMethods([])
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Helper/GuestTest.php b/dev/tests/unit/testsuite/Magento/Sales/Helper/GuestTest.php
index 4e58251dc9206cf39874b585bd50beafddb2e197..17f80d0c48bfd016615426882315621c6a741974 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Helper/GuestTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Helper/GuestTest.php
@@ -56,7 +56,7 @@ class GuestTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Customer\Model\Session|\PHPUnit_Framework_MockObject_MockObject */
protected $sessionMock;
- /** @var \Magento\Framework\Stdlib\CookieManager|\PHPUnit_Framework_MockObject_MockObject */
+ /** @var \Magento\Framework\Stdlib\CookieManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $cookieManagerMock;
/** @var \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory|\PHPUnit_Framework_MockObject_MockObject */
@@ -79,7 +79,7 @@ class GuestTest extends \PHPUnit_Framework_TestCase
$this->stateMock = $this->getMock('Magento\Framework\App\State', [], [], '', false);
$this->registryMock = $this->getMock('Magento\Framework\Registry');
$this->sessionMock = $this->getMock('Magento\Customer\Model\Session', [], [], '', false);
- $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManager', [], [], '', false);
+ $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->cookieMetadataFactoryMock = $this->getMock(
'Magento\Framework\Stdlib\Cookie\CookieMetadataFactory',
[],
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
index a79c683beb11fd85206e5c609baa6239975b1276..40609802609772925f08dd8bfe96e6346c4cad8b 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php
@@ -57,7 +57,7 @@ class CreateTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$eventManagerMock = $this->getMock('Magento\Framework\Event\ManagerInterface');
$registryMock = $this->getMock('Magento\Framework\Registry');
$configMock = $this->getMock('Magento\Sales\Model\Config', array(), array(), '', false);
@@ -88,7 +88,6 @@ class CreateTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $customerHelperMock = $this->getMock('Magento\Customer\Helper\Data', array(), array(), '', false);
$this->customerGroupServiceMock = $this->getMock('Magento\Customer\Service\V1\CustomerGroupServiceInterface');
$this->itemUpdater = $this->getMock('Magento\Sales\Model\Quote\Item\Updater', array(), array(), '', false);
@@ -115,7 +114,6 @@ class CreateTest extends \PHPUnit_Framework_TestCase
'customerAddressBuilder' => $addressBuilderMock,
'metadataFormFactory' => $this->formFactoryMock,
'customerBuilder' => $this->customerBuilderMock,
- 'customerHelper' => $customerHelperMock,
'customerGroupService' => $this->customerGroupServiceMock,
'quoteItemUpdater' => $this->itemUpdater,
'objectFactory' => $this->objectFactory
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/Product/Quote/InitializerTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/Product/Quote/InitializerTest.php
index 2be65785a1726651fe0c073d4261922019f367c3..3236eb3a28d9cafcaf367090bca14c1c4f83a893 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/Product/Quote/InitializerTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/Product/Quote/InitializerTest.php
@@ -50,20 +50,23 @@ class InitializerTest extends \PHPUnit_Framework_TestCase
protected $configMock;
/**
- * @var \Magento\CatalogInventory\Service\V1\StockItemService|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Sales\Model\AdminOrder\Product\Quote\Initializer
*/
- protected $stockItemServiceMock;
+ protected $model;
+
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
+ protected $stockItemMock;
/**
- * @var \Magento\Sales\Model\AdminOrder\Product\Quote\Initializer
+ * @var \PHPUnit_Framework_MockObject_MockObject
*/
- protected $model;
+ protected $stockRegistry;
protected function setUp()
{
$this->quoteMock = $this->getMock(
'Magento\Sales\Model\Quote',
- ['addProduct', '__wakeup'],
+ ['addProduct', '__wakeup', 'getStore'],
[],
'',
false
@@ -85,19 +88,36 @@ class InitializerTest extends \PHPUnit_Framework_TestCase
false
);
- $this->stockItemServiceMock = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
- ['getStockItem', '__wakeup'],
+ $this->stockRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\StockRegistry')
+ ->disableOriginalConstructor()
+ ->setMethods(['getStockItem', '__wakeup'])
+ ->getMock();
+
+ $this->stockItemMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Stock\Item',
+ ['getIsQtyDecimal', '__wakeup'],
[],
'',
false
);
+ $this->stockRegistry->expects($this->any())
+ ->method('getStockItem')
+ ->will($this->returnValue($this->stockItemMock));
+
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId'], [], '', false);
+ $store->expects($this->once())
+ ->method('getWebsiteId')
+ ->will($this->returnValue(10));
+ $this->quoteMock->expects($this->any())
+ ->method('getStore')
+ ->will($this->returnValue($store));
+
$this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->model = $this->objectManager
->getObject(
'Magento\Sales\Model\AdminOrder\Product\Quote\Initializer',
- ['stockItemService' => $this->stockItemServiceMock]
+ ['stockRegistry' => $this->stockRegistry]
);
}
@@ -111,9 +131,9 @@ class InitializerTest extends \PHPUnit_Framework_TestCase
false
);
- $this->stockItemServiceMock->expects($this->once())
- ->method('getStockItem')
- ->will($this->returnValue($this->getStockItemDo(true)));
+ $this->stockItemMock->expects($this->once())
+ ->method('getIsQtyDecimal')
+ ->will($this->returnValue(10));
$this->productMock->expects($this->once())
->method('getId')
@@ -158,10 +178,6 @@ class InitializerTest extends \PHPUnit_Framework_TestCase
false
);
- $this->stockItemServiceMock->expects($this->once())
- ->method('getStockItem')
- ->will($this->returnValue($this->getStockItemDo(false)));
-
$this->productMock->expects($this->once())
->method('getId')
->will($this->returnSelf());
@@ -195,29 +211,4 @@ class InitializerTest extends \PHPUnit_Framework_TestCase
)
);
}
-
- /**
- * @param bool $isQtyDecimal
- * @return \Magento\CatalogInventory\Service\V1\Data\StockItem|\PHPUnit_Framework_MockObject_MockObject
- */
- protected function getStockItemDo($isQtyDecimal)
- {
- $stockItemDoMock = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\Data\StockItem',
- ['getStockId', 'getIsQtyDecimal'],
- [],
- '',
- false
- );
-
- $stockItemDoMock->expects($this->once())
- ->method('getStockId')
- ->will($this->returnValue(5));
-
- $stockItemDoMock->expects($this->once())
- ->method('getIsQtyDecimal')
- ->will($this->returnValue($isQtyDecimal));
-
- return $stockItemDoMock;
- }
}
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Email/TemplateTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Email/TemplateTest.php
index e70aa1875e2760d00352b0f6000282d4a8b55df4..f71bc6f73f917fae65337990cde853cdddd7e9e1 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Email/TemplateTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Email/TemplateTest.php
@@ -50,7 +50,7 @@ class TemplateTest extends \PHPUnit_Framework_TestCase
$objectManagerHelper = new \Magento\TestFramework\Helper\ObjectManager($this);
- $objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', ['create', 'configure', 'get']);
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerMock->expects($this->once())
->method('get')
->with('Magento\Email\Model\Resource\Template')
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Backend/CustomerQuoteTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Backend/CustomerQuoteTest.php
index a95b40b74f30a50d420b7e437e79ff2bd5e54151..a2c224d96f862220fa8259d554aadc18fb89abf8 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Backend/CustomerQuoteTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Backend/CustomerQuoteTest.php
@@ -41,9 +41,9 @@ class CustomerQuoteTest extends \PHPUnit_Framework_TestCase
protected $configMock;
/**
- * @var \PHPUnit_Framework_MockObject_MockObject|\\Magento\Sales\Model\QuoteFactory
+ * @var \PHPUnit_Framework_MockObject_MockObject|\\Magento\Sales\Model\QuoteRepository
*/
- protected $quoteFactoryMock;
+ protected $quoteRepositoryMock;
/**
* @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\Event\Observer
@@ -63,9 +63,9 @@ class CustomerQuoteTest extends \PHPUnit_Framework_TestCase
$this->configMock = $this->getMockBuilder('Magento\Customer\Model\Config\Share')
->disableOriginalConstructor()
->getMock();
- $this->quoteFactoryMock = $this->getMockBuilder('\Magento\Sales\Model\QuoteFactory')
+ $this->quoteRepositoryMock = $this->getMockBuilder('\Magento\Sales\Model\QuoteRepository')
->disableOriginalConstructor()
- ->setMethods(['create'])
+ ->setMethods(['getForCustomer', 'save'])
->getMock();
$this->observerMock = $this->getMockBuilder('Magento\Framework\Event\Observer')
->disableOriginalConstructor()
@@ -81,7 +81,7 @@ class CustomerQuoteTest extends \PHPUnit_Framework_TestCase
[
'storeManager' => $this->storeManagerMock,
'config' => $this->configMock,
- 'quoteFactory' => $this->quoteFactoryMock,
+ 'quoteRepository' => $this->quoteRepositoryMock,
]
);
}
@@ -106,8 +106,8 @@ class CustomerQuoteTest extends \PHPUnit_Framework_TestCase
$this->eventMock->expects($this->any())
->method('getOrigCustomerDataObject')
->will($this->returnValue($origCustomerDataObjectMock));
- $this->quoteFactoryMock->expects($this->never())
- ->method('create');
+ $this->quoteRepositoryMock->expects($this->never())
+ ->method('getForCustomer');
$this->customerQuote->dispatch($this->observerMock);
}
@@ -118,7 +118,7 @@ class CustomerQuoteTest extends \PHPUnit_Framework_TestCase
* @param int $quoteId
* @dataProvider dispatchDataProvider
*/
- public function testDispatch($isWebsiteScope,$websites, $quoteId)
+ public function testDispatch($isWebsiteScope, $websites, $quoteId)
{
$this->configMock->expects($this->once())
->method('isWebsiteScope')
@@ -161,39 +161,37 @@ class CustomerQuoteTest extends \PHPUnit_Framework_TestCase
)->setMethods(
array(
'setWebsite',
- 'loadByCustomer',
- 'getId',
'setCustomerGroupId',
'collectTotals',
- 'save',
'__wakeup'
)
)->disableOriginalConstructor(
)->getMock();
$websiteCount = count($websites);
- $this->quoteFactoryMock->expects($this->exactly($websiteCount))
- ->method('create')
- ->will($this->returnValue($quoteMock));
- $quoteMock->expects($this->exactly($websiteCount))
- ->method('setWebsite');
- $quoteMock->expects($this->exactly($websiteCount))
- ->method('loadByCustomer');
- $quoteMock->expects($this->exactly($websiteCount))
- ->method('getId')
- ->will($this->returnValue($quoteId));
if ($quoteId) {
+ $this->quoteRepositoryMock->expects($this->exactly($websiteCount))
+ ->method('getForCustomer')
+ ->will($this->returnValue($quoteMock));
+ $quoteMock->expects($this->exactly($websiteCount))
+ ->method('setWebsite');
$quoteMock->expects($this->exactly($websiteCount))
->method('setCustomerGroupId');
$quoteMock->expects($this->exactly($websiteCount))
->method('collectTotals');
- $quoteMock->expects($this->exactly($websiteCount))
- ->method('save');
+ $this->quoteRepositoryMock->expects($this->exactly($websiteCount))
+ ->method('save')
+ ->with($quoteMock);
} else {
+ $this->quoteRepositoryMock->expects($this->exactly($websiteCount))
+ ->method('getForCustomer')
+ ->willThrowException(
+ new \Magento\Framework\Exception\NoSuchEntityException()
+ );
$quoteMock->expects($this->never())
->method('setCustomerGroupId');
$quoteMock->expects($this->never())
->method('collectTotals');
- $quoteMock->expects($this->never())
+ $this->quoteRepositoryMock->expects($this->never())
->method('save');
}
$this->customerQuote->dispatch($this->observerMock);
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php
index 1ffc4468220847a85ae744d33f7a0ceb19bd52d7..660c74e91c9a68d371efb0a7342b488d7bcbcc26 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php
@@ -38,7 +38,7 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase
/**
* @var \PHPUnit_Framework_MockObject_MockObject
*/
- protected $customerHelperMock;
+ protected $customerVatMock;
/**
* @var \PHPUnit_Framework_MockObject_MockObject
@@ -92,7 +92,7 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase
false
);
$this->customerAddressMock = $this->getMock('Magento\Customer\Helper\Address', array(), array(), '', false);
- $this->customerHelperMock = $this->getMock('Magento\Customer\Helper\Data', array(), array(), '', false);
+ $this->customerVatMock = $this->getMock('Magento\Customer\Model\Vat', array(), array(), '', false);
$this->customerBuilderMock = $this->getMock(
'Magento\Customer\Service\V1\Data\CustomerBuilder',
array('mergeDataObjectWithArray', 'create'),
@@ -156,7 +156,7 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase
'Magento\Sales\Model\Observer\Frontend\Quote\Address\CollectTotals',
array(
'customerAddressHelper' => $this->customerAddressMock,
- 'customerHelper' => $this->customerHelperMock,
+ 'customerVat' => $this->customerVatMock,
'vatValidator' => $this->vatValidatorMock,
'customerBuilder' => $this->customerBuilderMock
)
@@ -248,7 +248,7 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase
);
$this->quoteAddressMock->expects($this->once())->method('getVatId')->will($this->returnValue('vatId'));
- $this->customerHelperMock->expects(
+ $this->customerVatMock->expects(
$this->once()
)->method(
'isCountryInEU'
@@ -315,7 +315,7 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase
);
$this->customerDataMock->expects($this->once())->method('getId')->will($this->returnValue('1'));
- $this->customerHelperMock->expects(
+ $this->customerVatMock->expects(
$this->once()
)->method(
'getDefaultCustomerGroupId'
@@ -380,7 +380,7 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase
->method('getVatId')
->will($this->returnValue('vatID'));
- $this->customerHelperMock->expects($this->once())
+ $this->customerVatMock->expects($this->once())
->method('isCountryInEU')
->with('customerCountryCode')
->will($this->returnValue($attributeValueBuilder->create()));
@@ -395,7 +395,7 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase
->with($this->quoteAddressMock, $this->storeId)
->will($this->returnValue($validationResult));
- $this->customerHelperMock->expects($this->once())
+ $this->customerVatMock->expects($this->once())
->method('getCustomerGroupIdBasedOnVatNumber')
->with('customerCountryCode', $validationResult, $this->storeId)
->will($this->returnValue('customerGroupId'));
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/VatValidatorTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/VatValidatorTest.php
index 0b78b9cef8dafd2263211e9bdea9a8ab33c0d576..2cd5d5c912b6a82f73307ac6314ba642962f7aa1 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/VatValidatorTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Observer/Frontend/Quote/Address/VatValidatorTest.php
@@ -38,7 +38,7 @@ class VatValidatorTest extends \PHPUnit_Framework_TestCase
/**
* @var \PHPUnit_Framework_MockObject_MockObject
*/
- protected $customerDataMock;
+ protected $customerVatMock;
/**
* @var \PHPUnit_Framework_MockObject_MockObject
@@ -63,21 +63,13 @@ class VatValidatorTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
$this->customerAddressMock = $this->getMock('Magento\Customer\Helper\Address', array(), array(), '', false);
- $this->customerDataMock = $this->getMock('Magento\Customer\Helper\Data', array(), array(), '', false);
- $this->customerDataMock->expects(
- $this->any()
- )->method(
- 'getMerchantCountryCode'
- )->will(
- $this->returnValue('merchantCountryCode')
- );
- $this->customerDataMock->expects(
- $this->any()
- )->method(
- 'getMerchantVatNumber'
- )->will(
- $this->returnValue('merchantVatNumber')
- );
+ $this->customerVatMock = $this->getMock('Magento\Customer\Model\Vat', array(), array(), '', false);
+ $this->customerVatMock->expects($this->any())
+ ->method('getMerchantCountryCode')
+ ->willReturn('merchantCountryCode');
+ $this->customerVatMock->expects($this->any())
+ ->method('getMerchantVatNumber')
+ ->willReturn('merchantVatNumber');
$this->storeMock = $this->getMock('Magento\Store\Model\Store', array(), array(), '', false);
@@ -144,13 +136,13 @@ class VatValidatorTest extends \PHPUnit_Framework_TestCase
$this->model = new \Magento\Sales\Model\Observer\Frontend\Quote\Address\VatValidator(
$this->customerAddressMock,
- $this->customerDataMock
+ $this->customerVatMock
);
}
public function testValidateWithDisabledValidationOnEachTransaction()
{
- $this->customerDataMock->expects($this->never())->method('checkVatNumber');
+ $this->customerVatMock->expects($this->never())->method('checkVatNumber');
$this->customerAddressMock->expects(
$this->once()
@@ -188,7 +180,7 @@ class VatValidatorTest extends \PHPUnit_Framework_TestCase
public function testValidateWithEnabledValidationOnEachTransaction()
{
- $this->customerDataMock->expects(
+ $this->customerVatMock->expects(
$this->once()
)->method(
'checkVatNumber'
@@ -237,7 +229,7 @@ class VatValidatorTest extends \PHPUnit_Framework_TestCase
public function testValidateWithDifferentCountryIdAndValidatedCountryCode()
{
- $this->customerDataMock->expects(
+ $this->customerVatMock->expects(
$this->once()
)->method(
'checkVatNumber'
@@ -280,7 +272,7 @@ class VatValidatorTest extends \PHPUnit_Framework_TestCase
public function testValidateWithDifferentVatNumberAndValidatedVatNumber()
{
- $this->customerDataMock->expects(
+ $this->customerVatMock->expects(
$this->once()
)->method(
'checkVatNumber'
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/CreditmemoNotifierTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/CreditmemoNotifierTest.php
index f1047dc2ef6ec60eb29520de2fca832272d1221c..f71bef18855e6a97b6b58e499026751f3c2dc2e5 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/CreditmemoNotifierTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/CreditmemoNotifierTest.php
@@ -48,7 +48,7 @@ class CreditmemoNotifierTest extends \PHPUnit_Framework_TestCase
protected $creditmemo;
/**
- * @var \Magento\Framework\ObjectManager |\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface |\PHPUnit_Framework_MockObject_MockObject
*/
protected $loggerMock;
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Customer/BuilderTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Customer/BuilderTest.php
index 6ac81f399da6ce2a64c8ab7e92916dba582bea34..56fef64349be5dc3d9299c58eabed3ea8a27483a 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Customer/BuilderTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Customer/BuilderTest.php
@@ -29,7 +29,7 @@ namespace Magento\Sales\Model\Order\Customer;
class BuilderTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -40,13 +40,7 @@ class BuilderTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager',
- ['create', 'get', 'configure'],
- [],
- '',
- false
- );
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->builder = new \Magento\Sales\Model\Order\Customer\Builder($this->objectManagerMock);
}
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/InvoiceNotifierTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/InvoiceNotifierTest.php
index 2c1f3c2e149983dc45d033a1cc0284669e1b4f0d..f36572a8b836dc4f5e51fc5b908df6baecc951f0 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/InvoiceNotifierTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/InvoiceNotifierTest.php
@@ -48,7 +48,7 @@ class InvoiceNotifierTest extends \PHPUnit_Framework_TestCase
protected $invoice;
/**
- * @var \Magento\Framework\ObjectManager |\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface |\PHPUnit_Framework_MockObject_MockObject
*/
protected $loggerMock;
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Pdf/Total/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Pdf/Total/FactoryTest.php
index 8c5dd4613971e43e259730380fddde488700691d..8203715e23f326cf8a603e0379b36d55af7c8851 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Pdf/Total/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Pdf/Total/FactoryTest.php
@@ -26,7 +26,7 @@ namespace Magento\Sales\Model\Order\Pdf\Total;
class FactoryTest extends \PHPUnit_Framework_TestCase
{
/**
- * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\ObjectManager
+ * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -37,7 +37,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_factory = new \Magento\Sales\Model\Order\Pdf\Total\Factory($this->_objectManager);
}
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/OrderNotifierTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/OrderNotifierTest.php
index 5e0e3eb32fab6b02df1b016b8630e1601d33f19d..7b624e4dea749861ee01b8a3e0fd989f084755ef 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/OrderNotifierTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/OrderNotifierTest.php
@@ -48,7 +48,7 @@ class OrderNotifierTest extends \PHPUnit_Framework_TestCase
protected $order;
/**
- * @var \Magento\Framework\ObjectManager |\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface |\PHPUnit_Framework_MockObject_MockObject
*/
protected $loggerMock;
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Quote/Address/Total/SubtotalTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Quote/Address/Total/SubtotalTest.php
index 12fcac75dfdd4450cdf2e8b68663266a10bfc320..a9ba0e8ee6539f8c1bb7711c9aa2e1ce0b163a7e 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Quote/Address/Total/SubtotalTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Quote/Address/Total/SubtotalTest.php
@@ -23,6 +23,11 @@
*/
namespace Magento\Sales\Model\Quote\Address\Total;
+/**
+ * Class SubtotalTest
+ * @package Magento\Sales\Model\Quote\Address\Total
+ * TODO refactor me
+ */
class SubtotalTest extends \PHPUnit_Framework_TestCase
{
/**
@@ -35,6 +40,14 @@ class SubtotalTest extends \PHPUnit_Framework_TestCase
*/
protected $subtotalModel;
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
+ protected $stockItemMock;
+
+ /**
+ * @var \PHPUnit_Framework_MockObject_MockObject
+ */
+ protected $stockRegistry;
+
protected function setUp()
{
$this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
@@ -63,31 +76,22 @@ class SubtotalTest extends \PHPUnit_Framework_TestCase
*/
public function testCollect($price, $originalPrice, $itemHasParent, $expectedPrice, $expectedOriginalPrice)
{
- /** @var \Magento\CatalogInventory\Service\V1\Data\StockItem $stockItemDoMock */
- $stockItemDoMock = $this->getMock(
- '\Magento\CatalogInventory\Service\V1\Data\StockItem',
- ['getStockId'],
- [],
- '',
- false
- );
-
- $stockItemDoMock->expects($this->any())
- ->method('getStockId')
- ->will($this->returnValue(false));
+ $this->stockRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\StockRegistry')
+ ->disableOriginalConstructor()
+ ->setMethods(['getStockItem', '__wakeup'])
+ ->getMock();
- /** @var \Magento\CatalogInventory\Service\V1\StockItemService $stockItemServiceMock */
- $stockItemServiceMock = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
- ['getStockItem'],
+ $this->stockItemMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Stock\Item',
+ ['getIsInStock', '__wakeup'],
[],
'',
false
);
- $stockItemServiceMock->expects($this->any())
+ $this->stockRegistry->expects($this->any())
->method('getStockItem')
- ->will($this->returnValue($stockItemDoMock));
+ ->will($this->returnValue($this->stockItemMock));
$priceCurrency = $this->getMockBuilder('Magento\Framework\Pricing\PriceCurrencyInterface')->getMock();
$priceCurrency->expects($this->any())
@@ -99,8 +103,8 @@ class SubtotalTest extends \PHPUnit_Framework_TestCase
$quoteItem = $this->objectManager->getObject(
'Magento\Sales\Model\Quote\Item',
[
- 'stockItemService' => $stockItemServiceMock,
- 'priceCurrency' => $priceCurrency,
+ 'stockRegistry' => $this->stockRegistry,
+ 'priceCurrency' => $priceCurrency,
]
);
/** @var \Magento\Sales\Model\Quote\Address|\PHPUnit_Framework_MockObject_MockObject $address */
@@ -134,6 +138,16 @@ class SubtotalTest extends \PHPUnit_Framework_TestCase
);
$store = $this->objectManager->getObject('Magento\Store\Model\Store');
$store->setCurrentCurrency('');
+
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId'], [], '', false);
+ $store->expects($this->any())
+ ->method('getWebsiteId')
+ ->will($this->returnValue(10));
+
+ $product->expects($this->any())
+ ->method('getStore')
+ ->will($this->returnValue($store));
+
$quote->expects($this->any())->method('getStore')->will($this->returnValue($store));
$quoteItem->setProduct($product)->setQuote($quote)->setOriginalCustomPrice($price);
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Quote/ItemTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Quote/ItemTest.php
index 9a9d6f84c599d43cfc8bcb6df19a334371d148a3..b09cf3bc8c2a04c4c2f2192cc99804456a1e6654 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Quote/ItemTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Quote/ItemTest.php
@@ -65,10 +65,13 @@ class ItemTest extends \PHPUnit_Framework_TestCase
*/
protected $compareHelper;
+ /** @var \PHPUnit_Framework_MockObject_MockObject */
+ protected $stockItemMock;
+
/**
- * @var \Magento\CatalogInventory\Service\V1\Data\StockItem
+ * @var \PHPUnit_Framework_MockObject_MockObject
*/
- protected $stockItemDoMock;
+ protected $stockRegistry;
const PRODUCT_ID = 1;
const PRODUCT_TYPE = 'simple';
@@ -127,27 +130,21 @@ class ItemTest extends \PHPUnit_Framework_TestCase
false
);
- /** @var \Magento\CatalogInventory\Service\V1\Data\StockItem $stockItemDoMock */
- $this->stockItemDoMock = $this->getMock(
- '\Magento\CatalogInventory\Service\V1\Data\StockItem',
- ['getStockId', 'getIsQtyDecimal'],
- [],
- '',
- false
- );
-
- /** @var \Magento\CatalogInventory\Service\V1\StockItemService $stockItemServiceMock */
- $stockItemServiceMock = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
- ['getStockItem'],
+ $this->stockItemMock = $this->getMock(
+ 'Magento\CatalogInventory\Model\Stock\Item',
+ ['getIsQtyDecimal', '__wakeup'],
[],
'',
false
);
- $stockItemServiceMock->expects($this->any())
+ $this->stockRegistry = $this->getMockBuilder('Magento\CatalogInventory\Model\StockRegistry')
+ ->disableOriginalConstructor()
+ ->setMethods(['getStockItem', '__wakeup'])
+ ->getMock();
+ $this->stockRegistry->expects($this->any())
->method('getStockItem')
- ->will($this->returnValue($this->stockItemDoMock));
+ ->will($this->returnValue($this->stockItemMock));
$this->model = $this->objectManagerHelper->getObject(
'\Magento\Sales\Model\Quote\Item',
@@ -157,7 +154,7 @@ class ItemTest extends \PHPUnit_Framework_TestCase
'statusListFactory' => $statusListFactory,
'itemOptionFactory' => $this->itemOptionFactory,
'compareHelper' => $this->compareHelper,
- 'stockItemService' => $stockItemServiceMock
+ 'stockRegistry' => $this->stockRegistry
]
);
}
@@ -388,10 +385,10 @@ class ItemTest extends \PHPUnit_Framework_TestCase
->with('sales_quote_item_set_product', ['product' => $productMock, 'quote_item' => $this->model]);
$isQtyDecimal = true;
- $this->stockItemDoMock->expects($this->any())
+ $this->stockItemMock->expects($this->any())
->method('getStockId')
->will($this->returnValue(99));
- $this->stockItemDoMock->expects($this->once())
+ $this->stockItemMock->expects($this->once())
->method('getIsQtyDecimal')
->will($this->returnValue($isQtyDecimal));
@@ -455,12 +452,12 @@ class ItemTest extends \PHPUnit_Framework_TestCase
'getStickWithinParent',
'getCustomOptions',
'toArray',
- '__wakeup'
+ '__wakeup',
+ 'getStore'
]
)
->getMock();
-
$productMock->expects($this->any())
->method('getId')
->will($this->returnValue($productId));
@@ -482,6 +479,14 @@ class ItemTest extends \PHPUnit_Framework_TestCase
$productMock->expects($this->any())
->method('getCost')
->will($this->returnValue($productCost));
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId'], [], '', false);
+ $store->expects($this->any())
+ ->method('getWebsiteId')
+ ->will($this->returnValue(10));
+
+ $productMock->expects($this->any())
+ ->method('getStore')
+ ->will($this->returnValue($store));
return $productMock;
}
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/QuoteRepositoryTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/QuoteRepositoryTest.php
index 3950ab01ec86b47ef17744bc7c37d1bf73a97fa5..53b1b685a55a9a6972098aacf2ec50da19a59193 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/QuoteRepositoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/QuoteRepositoryTest.php
@@ -54,12 +54,18 @@ class QuoteRepositoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $objectManager =new \Magento\TestFramework\Helper\ObjectManager($this);
+ $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
$this->quoteFactoryMock = $this->getMock('\Magento\Sales\Model\QuoteFactory', ['create'], [], '', false);
$this->storeManagerMock = $this->getMock('\Magento\Framework\StoreManagerInterface');
- $this->quoteMock =
- $this->getMock('\Magento\Sales\Model\Quote', ['load', 'getIsActive', 'getId', '__wakeup'], [], '', false);
+ $this->quoteMock = $this->getMock(
+ '\Magento\Sales\Model\Quote',
+ ['load', 'loadByCustomer', 'getIsActive', 'getId', '__wakeup', 'setSharedStoreIds', 'save', 'delete',
+ 'getCustomerId'],
+ [],
+ '',
+ false
+ );
$this->storeMock = $this->getMock('\Magento\Store\Model\Store', [], [], '', false);
$this->model = $objectManager->getObject(
'Magento\Sales\Model\QuoteRepository',
@@ -70,6 +76,21 @@ class QuoteRepositoryTest extends \PHPUnit_Framework_TestCase
);
}
+ public function testCreate()
+ {
+ $this->quoteFactoryMock->expects($this->once())
+ ->method('create')
+ ->with([1, 2, 3])
+ ->willReturn($this->quoteMock);
+ $this->storeManagerMock->expects($this->never())->method('getStore');
+ $this->storeMock->expects($this->never())->method('getId');
+ $this->quoteMock->expects($this->never())->method('setSharedStoreIds');
+ $this->quoteMock->expects($this->never())->method('load');
+ $this->quoteMock->expects($this->never())->method('getId');
+
+ $this->assertEquals($this->quoteMock, $this->model->create([1, 2, 3]));
+ }
+
/**
* @expectedException \Magento\Framework\Exception\NoSuchEntityException
* @expectedExceptionMessage No such entity with cartId = 14
@@ -78,54 +99,202 @@ class QuoteRepositoryTest extends \PHPUnit_Framework_TestCase
{
$cartId = 14;
- $this->quoteFactoryMock->expects($this->once())->method('create')->will($this->returnValue($this->quoteMock));
- $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
- $this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($this->storeMock));
+ $this->quoteFactoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
+ $this->storeManagerMock->expects($this->once())->method('getStore')->willReturn($this->storeMock);
+ $this->storeMock->expects($this->once())->method('getId')->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->never())->method('setSharedStoreIds');
$this->quoteMock->expects($this->once())
->method('load')
->with($cartId)
- ->will($this->returnValue($this->storeMock));
- $this->quoteMock->expects($this->once())->method('getId')->will($this->returnValue(false));
+ ->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->once())->method('getId')->willReturn(false);
$this->model->get($cartId);
}
+ public function testGet()
+ {
+ $cartId = 15;
+
+ $this->quoteFactoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
+ $this->storeManagerMock->expects($this->once())->method('getStore')->willReturn($this->storeMock);
+ $this->storeMock->expects($this->once())->method('getId')->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->never())->method('setSharedStoreIds');
+ $this->quoteMock->expects($this->once())
+ ->method('load')
+ ->with($cartId)
+ ->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->once())->method('getId')->willReturn($cartId);
+
+ $this->assertEquals($this->quoteMock, $this->model->get($cartId));
+ $this->assertEquals($this->quoteMock, $this->model->get($cartId));
+ }
+
+ public function testGetWithSharedStoreIds()
+ {
+ $cartId = 16;
+ $sharedStoreIds = [1, 2];
+
+ $this->quoteFactoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
+ $this->storeManagerMock->expects($this->once())->method('getStore')->willReturn($this->storeMock);
+ $this->storeMock->expects($this->once())->method('getId')->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->once())
+ ->method('setSharedStoreIds')
+ ->with($sharedStoreIds)
+ ->willReturnSelf();
+ $this->quoteMock->expects($this->once())
+ ->method('load')
+ ->with($cartId)
+ ->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->once())->method('getId')->willReturn($cartId);
+
+ $this->assertEquals($this->quoteMock, $this->model->get($cartId, $sharedStoreIds));
+ $this->assertEquals($this->quoteMock, $this->model->get($cartId, $sharedStoreIds));
+ }
+
+ public function testGetForCustomer()
+ {
+ $cartId = 17;
+ $customerId = 23;
+
+ $this->quoteFactoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
+ $this->storeManagerMock->expects($this->once())->method('getStore')->willReturn($this->storeMock);
+ $this->storeMock->expects($this->once())->method('getId')->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->never())->method('setSharedStoreIds');
+ $this->quoteMock->expects($this->once())
+ ->method('loadByCustomer')
+ ->with($customerId)
+ ->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->exactly(2))->method('getId')->willReturn($cartId);
+
+ $this->assertEquals($this->quoteMock, $this->model->getForCustomer($customerId));
+ $this->assertEquals($this->quoteMock, $this->model->getForCustomer($customerId));
+ }
+
+ /**
+ * @expectedException \Magento\Framework\Exception\NoSuchEntityException
+ * @expectedExceptionMessage No such entity with cartId = 14
+ */
+ public function testGetActiveWithExceptionById()
+ {
+ $cartId = 14;
+
+ $this->quoteFactoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
+ $this->storeManagerMock->expects($this->once())->method('getStore')->willReturn($this->storeMock);
+ $this->storeMock->expects($this->once())->method('getId')->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->never())->method('setSharedStoreIds');
+ $this->quoteMock->expects($this->once())
+ ->method('load')
+ ->with($cartId)
+ ->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->once())->method('getId')->willReturn(false);
+ $this->quoteMock->expects($this->never())->method('getIsActive');
+
+ $this->model->getActive($cartId);
+ }
+
/**
* @expectedException \Magento\Framework\Exception\NoSuchEntityException
* @expectedExceptionMessage No such entity with cartId = 15
*/
- public function testGetWithExceptionByIsActive()
+ public function testGetActiveWithExceptionByIsActive()
{
$cartId = 15;
- $this->quoteFactoryMock->expects($this->once())->method('create')->will($this->returnValue($this->quoteMock));
- $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
- $this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($this->storeMock));
+ $this->quoteFactoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
+ $this->storeManagerMock->expects($this->once())->method('getStore')->willReturn($this->storeMock);
+ $this->storeMock->expects($this->once())->method('getId')->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->never())->method('setSharedStoreIds');
$this->quoteMock->expects($this->once())
->method('load')
->with($cartId)
- ->will($this->returnValue($this->storeMock));
- $this->quoteMock->expects($this->once())->method('getId')->will($this->returnValue(true));
- $this->quoteMock->expects($this->once())->method('getIsActive')->will($this->returnValue(0));
+ ->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->once())->method('getId')->willReturn($cartId);
+ $this->quoteMock->expects($this->once())->method('getIsActive')->willReturn(0);
- $this->model->get($cartId);
+ $this->model->getActive($cartId);
}
- public function testGet()
+ public function testGetActive()
{
$cartId = 15;
- $this->quoteFactoryMock->expects($this->once())->method('create')->will($this->returnValue($this->quoteMock));
- $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock));
- $this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($this->storeMock));
+ $this->quoteFactoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
+ $this->storeManagerMock->expects($this->once())->method('getStore')->willReturn($this->storeMock);
+ $this->storeMock->expects($this->once())->method('getId')->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->never())->method('setSharedStoreIds');
$this->quoteMock->expects($this->once())
->method('load')
->with($cartId)
- ->will($this->returnValue($this->storeMock));
- $this->quoteMock->expects($this->once())->method('getId')->will($this->returnValue(true));
- $this->quoteMock->expects($this->once())->method('getIsActive')->will($this->returnValue(1));
+ ->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->once())->method('getId')->willReturn($cartId);
+ $this->quoteMock->expects($this->exactly(2))->method('getIsActive')->willReturn(1);
- $this->assertEquals($this->quoteMock, $this->model->get($cartId));
+ $this->assertEquals($this->quoteMock, $this->model->getActive($cartId));
+ $this->assertEquals($this->quoteMock, $this->model->getActive($cartId));
+ }
+
+ public function testGetActiveWithSharedStoreIds()
+ {
+ $cartId = 16;
+ $sharedStoreIds = [1, 2];
+
+ $this->quoteFactoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
+ $this->storeManagerMock->expects($this->once())->method('getStore')->willReturn($this->storeMock);
+ $this->storeMock->expects($this->once())->method('getId')->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->once())
+ ->method('setSharedStoreIds')
+ ->with($sharedStoreIds)
+ ->willReturnSelf();
+ $this->quoteMock->expects($this->once())
+ ->method('load')
+ ->with($cartId)
+ ->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->once())->method('getId')->willReturn($cartId);
+ $this->quoteMock->expects($this->exactly(2))->method('getIsActive')->willReturn(1);
+
+ $this->assertEquals($this->quoteMock, $this->model->getActive($cartId, $sharedStoreIds));
+ $this->assertEquals($this->quoteMock, $this->model->getActive($cartId, $sharedStoreIds));
+ }
+
+ public function testGetActiveForCustomer()
+ {
+ $cartId = 17;
+ $customerId = 23;
+
+ $this->quoteFactoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock);
+ $this->storeManagerMock->expects($this->once())->method('getStore')->willReturn($this->storeMock);
+ $this->storeMock->expects($this->once())->method('getId')->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->never())->method('setSharedStoreIds');
+ $this->quoteMock->expects($this->once())
+ ->method('loadByCustomer')
+ ->with($customerId)
+ ->willReturn($this->storeMock);
+ $this->quoteMock->expects($this->exactly(2))->method('getId')->willReturn($cartId);
+ $this->quoteMock->expects($this->exactly(2))->method('getIsActive')->willReturn(1);
+
+ $this->assertEquals($this->quoteMock, $this->model->getActiveForCustomer($customerId));
+ $this->assertEquals($this->quoteMock, $this->model->getActiveForCustomer($customerId));
+ }
+
+ public function testSave()
+ {
+ $this->quoteMock->expects($this->once())
+ ->method('save');
+ $this->quoteMock->expects($this->exactly(1))->method('getId')->willReturn(1);
+ $this->quoteMock->expects($this->exactly(1))->method('getCustomerId')->willReturn(2);
+
+ $this->model->save($this->quoteMock);
+ }
+
+ public function testDelete()
+ {
+ $this->quoteMock->expects($this->once())
+ ->method('delete');
+ $this->quoteMock->expects($this->exactly(1))->method('getId')->willReturn(1);
+ $this->quoteMock->expects($this->exactly(1))->method('getCustomerId')->willReturn(2);
+
+ $this->model->delete($this->quoteMock);
}
}
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Rss/OrderStatusTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Rss/OrderStatusTest.php
index e2e8cabce745ce008aae3edc1b7aee48df4046e2..a94a6c34258fb7c1b5a07ae1710b9df774f3f4c3 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Rss/OrderStatusTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Rss/OrderStatusTest.php
@@ -42,7 +42,7 @@ class OrderStatusTest extends \PHPUnit_Framework_TestCase
protected $objectManagerHelper;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManager;
@@ -104,7 +104,7 @@ class OrderStatusTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->urlInterface = $this->getMock('Magento\Framework\UrlInterface');
$this->requestInterface = $this->getMock('Magento\Framework\App\RequestInterface');
$this->orderStatusFactory = $this->getMockBuilder('Magento\Sales\Model\Resource\Order\Rss\OrderStatusFactory')
diff --git a/dev/tests/unit/testsuite/Magento/Search/Model/AdapterFactoryTest.php b/dev/tests/unit/testsuite/Magento/Search/Model/AdapterFactoryTest.php
index 2cfbd972ea082d10491fef14072bb47724c4b7a3..6891bbf4fa1ae4f69b93915f2e3c4b6c1a1e8f15 100644
--- a/dev/tests/unit/testsuite/Magento/Search/Model/AdapterFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Search/Model/AdapterFactoryTest.php
@@ -33,7 +33,7 @@ class AdapterFactoryTest extends \PHPUnit_Framework_TestCase
private $adapterFactory;
/**
- * @var \Magento\Framework\ObjectManager |\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface |\PHPUnit_Framework_MockObject_MockObject
*/
private $objectManager;
@@ -49,10 +49,7 @@ class AdapterFactoryTest extends \PHPUnit_Framework_TestCase
->with($this->equalTo('some_path'), $this->equalTo('some_scopeType'))
->will($this->returnValue('ClassName'));
- $this->objectManager = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->setMethods(['create', 'get', 'configure'])
- ->disableOriginalConstructor()
- ->getMock();
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->adapterFactory = $helper->getObject(
'\Magento\Search\Model\AdapterFactory',
@@ -84,9 +81,7 @@ class AdapterFactoryTest extends \PHPUnit_Framework_TestCase
*/
public function testCreateExceptionThrown()
{
- $adapter = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->getMock();
+ $adapter = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->objectManager->expects($this->once())->method('create')
->with($this->equalTo('ClassName'), $this->equalTo(['input']))
diff --git a/dev/tests/unit/testsuite/Magento/Sendfriend/Model/SendfriendTest.php b/dev/tests/unit/testsuite/Magento/Sendfriend/Model/SendfriendTest.php
index 60c58bc33bccd7704dbe47ca7933aa67a35a35fa..c6fa0bf7a7a75f4e1a391f7ad8c9dc2e9c75b325 100644
--- a/dev/tests/unit/testsuite/Magento/Sendfriend/Model/SendfriendTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sendfriend/Model/SendfriendTest.php
@@ -38,7 +38,7 @@ class SendfriendTest extends \PHPUnit_Framework_TestCase
protected $model;
/**
- * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\Stdlib\CookieManager
+ * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $cookieManagerMock;
@@ -54,8 +54,7 @@ class SendfriendTest extends \PHPUnit_Framework_TestCase
$this->sendfriendDataMock = $this->getMockBuilder('Magento\Sendfriend\Helper\Data')
->disableOriginalConstructor()
->getMock();
- $this->cookieManagerMock = $this->getMockBuilder('Magento\Framework\Stdlib\CookieManager')
- ->disableOriginalConstructor()->getMock();
+ $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->model = $objectManager->getObject(
'Magento\Sendfriend\Model\Sendfriend',
diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/AddCommentTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/AddCommentTest.php
index 91fab6970b17625654a1bce955962a05038cb266..3a0aa4fd7ae95c104158052d950e214c792c427b 100644
--- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/AddCommentTest.php
+++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/AddCommentTest.php
@@ -64,7 +64,7 @@ class AddCommentTest extends \PHPUnit_Framework_TestCase
protected $viewMock;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -124,13 +124,7 @@ class AddCommentTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $this->objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager',
- ['create', 'get', 'configure', '__wakeup'],
- [],
- '',
- false
- );
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$contextMock = $this->getMock(
'Magento\Backend\App\Action\Context',
diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/CreateLabelTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/CreateLabelTest.php
index 0b9387bb6f7b932e6d61bf7d0b00379a16066dec..de194c976dc44dd67b7a43ddc95da202d169ed9e 100644
--- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/CreateLabelTest.php
+++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/CreateLabelTest.php
@@ -49,7 +49,7 @@ class CreateLabelTest extends \PHPUnit_Framework_TestCase
protected $responseMock;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -98,13 +98,7 @@ class CreateLabelTest extends \PHPUnit_Framework_TestCase
'',
false
);
- $this->objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager',
- ['create', 'get', 'configure', '__wakeup'],
- [],
- '',
- false
- );
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->messageManagerMock = $this->getMock(
'Magento\Framework\Message\Manager',
['addSuccess', 'addError', '__wakeup'],
diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/NewActionTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/NewActionTest.php
index 0c50b9ea9048bad53b6acd2b464f6111be6b9fd9..987661ee8c0c0e16b828f139b7fbe36c772cbf64 100644
--- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/NewActionTest.php
+++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/NewActionTest.php
@@ -113,10 +113,7 @@ class NewActionTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods([])
->getMock();
- $this->objectManager = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->context = $this->getMock(
'Magento\Backend\App\Action\Context',
[
diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/PrintLabelTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/PrintLabelTest.php
index 67213b284648347a621bfdacde8177a0bb95e9bc..605bc1c1df0b0c98b00c21ecaecc425401599d80 100644
--- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/PrintLabelTest.php
+++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/PrintLabelTest.php
@@ -66,7 +66,7 @@ class PrintLabelTest extends \PHPUnit_Framework_TestCase
protected $messageManagerMock;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -131,13 +131,7 @@ class PrintLabelTest extends \PHPUnit_Framework_TestCase
$this->responseMock = $this->getMock('Magento\Framework\App\Response\Http', [], [], '', false);
$this->sessionMock = $this->getMock('Magento\Backend\Model\Session', ['setIsUrlNotice'], [], '', false);
$this->actionFlag = $this->getMock('Magento\Framework\App\ActionFlag', ['get'], [], '', false);
- $this->objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager',
- ['create', 'get', 'configure'],
- [],
- '',
- false
- );
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->helperMock = $this->getMock(
'Magento\Backend\Helper\Data',
['getUrl'],
diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/PrintPackageTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/PrintPackageTest.php
index c78207c4d27796fa4ad440716e8730d978aa1585..d32b70cc9dba71336193aafc0a78f32b5c107624 100644
--- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/PrintPackageTest.php
+++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/PrintPackageTest.php
@@ -51,7 +51,7 @@ class PrintPackageTest extends \PHPUnit_Framework_TestCase
protected $fileFactoryMock;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -90,13 +90,7 @@ class PrintPackageTest extends \PHPUnit_Framework_TestCase
false
);
$this->requestMock = $this->getMock('Magento\Framework\App\Request\Http', ['getParam'], [], '', false);
- $this->objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager',
- ['create', 'get', 'configure'],
- [],
- '',
- false
- );
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->responseMock = $this->getMock('Magento\Framework\App\Response\Http', [], [], '', false);
$this->sessionMock = $this->getMock('Magento\Backend\Model\Session', ['setIsUrlNotice'], [], '', false);
$this->actionFlag = $this->getMock('Magento\Framework\App\ActionFlag', ['get'], [], '', false);
diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/RemoveTrackTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/RemoveTrackTest.php
index 7b922c53174986acd99eab7a97ce74fa8724bb1b..e200b1d67db3983e212988a797d873a1a642cff3 100644
--- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/RemoveTrackTest.php
+++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/RemoveTrackTest.php
@@ -39,7 +39,7 @@ class RemoveTrackTest extends \PHPUnit_Framework_TestCase
protected $requestMock;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $objectManagerMock;
@@ -76,13 +76,7 @@ class RemoveTrackTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
$this->requestMock = $this->getMock('Magento\Framework\App\Request\Http', ['getParam'], [], '', false);
- $this->objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager',
- ['create', 'get', 'configure'],
- [],
- '',
- false
- );
+ $this->objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->shipmentTrackMock = $this->getMock(
'Magento\Sales\Model\Order\Shipment\Track',
['load', 'getId', 'delete', '__wakeup'],
diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/SaveTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/SaveTest.php
index a08033176e074babf1748fde0ca5c2f59b8006b0..1a74dbf468374c4ee0fb342c71c3fd736d233836 100644
--- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/SaveTest.php
+++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/SaveTest.php
@@ -109,10 +109,7 @@ class SaveTest extends \PHPUnit_Framework_TestCase
->disableOriginalConstructor()
->setMethods([])
->getMock();
- $this->objectManager = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()
- ->setMethods([])
- ->getMock();
+ $this->objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->context = $this->getMock(
'Magento\Backend\App\Action\Context',
[
diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Model/Carrier/AbstractCarrierOnlineTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Model/Carrier/AbstractCarrierOnlineTest.php
index ac5588b9f0adc8eb760dd1285a93a81ece2f785a..fc61e618b32d3397c90b98c9143eaec51be598c9 100644
--- a/dev/tests/unit/testsuite/Magento/Shipping/Model/Carrier/AbstractCarrierOnlineTest.php
+++ b/dev/tests/unit/testsuite/Magento/Shipping/Model/Carrier/AbstractCarrierOnlineTest.php
@@ -43,7 +43,7 @@ class AbstractCarrierOnlineTest extends \PHPUnit_Framework_TestCase
/**
* @var \PHPUnit_Framework_MockObject_MockObject
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @var \PHPUnit_Framework_MockObject_MockObject
@@ -52,21 +52,23 @@ class AbstractCarrierOnlineTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->stockItemService = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
+ $this->stockRegistry = $this->getMock(
+ 'Magento\CatalogInventory\Model\StockRegistry',
[],
[],
'',
false
);
- $this->stockItemData = $this->getMock('Magento\CatalogInventory\Service\V1\Data\StockItem', [], [], '', false);
- $this->stockItemService->expects($this->any())->method('getStockItem')
+ $this->stockItemData = $this->getMock('Magento\CatalogInventory\Model\Stock\Item', [], [], '', false);
+
+ $this->stockRegistry->expects($this->any())->method('getStockItem')
+ ->with($this->productId, 10)
->will($this->returnValue($this->stockItemData));
$objectManagerHelper = new ObjectManagerHelper($this);
$carrierArgs = $objectManagerHelper->getConstructArguments(
'Magento\Shipping\Model\Carrier\AbstractCarrierOnline',
- ['stockItemService' => $this->stockItemService]
+ ['stockRegistry' => $this->stockRegistry]
);
$this->carrier = $this->getMockBuilder('Magento\Shipping\Model\Carrier\AbstractCarrierOnline')
->setConstructorArgs($carrierArgs)
@@ -92,21 +94,25 @@ class AbstractCarrierOnlineTest extends \PHPUnit_Framework_TestCase
$item = $this->getMockBuilder('\Magento\Sales\Model\Quote\Item')
->disableOriginalConstructor()
- ->setMethods(['getProduct', 'getQty', 'getWeight', '__wakeup'])
+ ->setMethods(['getProduct', 'getQty', 'getWeight', '__wakeup', 'getStore'])
->getMock();
$item->expects($this->any())->method('getProduct')->will($this->returnValue($product));
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId'], [], '', false);
+ $store->expects($this->any())
+ ->method('getWebsiteId')
+ ->will($this->returnValue(10));
+ $item->expects($this->any())->method('getStore')->will($this->returnValue($store));
+
$request = new RateRequest();
$request->setData('all_items', [$item]);
$request->setData('dest_postcode', 1);
/** Testable service calls to CatalogInventory module */
- $this->stockItemService->expects($this->atLeastOnce())->method('getStockItem')->with($this->productId);
- $this->stockItemService->expects($this->atLeastOnce())->method('getEnableQtyIncrements')
- ->with($this->productId)
+ $this->stockRegistry->expects($this->atLeastOnce())->method('getStockItem')->with($this->productId);
+ $this->stockItemData->expects($this->atLeastOnce())->method('getEnableQtyIncrements')
->will($this->returnValue(true));
- $this->stockItemService->expects($this->atLeastOnce())->method('getQtyIncrements')
- ->with($this->productId)
+ $this->stockItemData->expects($this->atLeastOnce())->method('getQtyIncrements')
->will($this->returnValue(5));
$this->stockItemData->expects($this->atLeastOnce())->method('getIsQtyDecimal')->will($this->returnValue(true));
$this->stockItemData->expects($this->atLeastOnce())->method('getIsDecimalDivided')
diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Model/ShipmentNotifierTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Model/ShipmentNotifierTest.php
index 0b7bb87996b7c431a289b31c24f6501d80339d4c..a1c0a74537a5a6b876de640982642826c47ee1ab 100644
--- a/dev/tests/unit/testsuite/Magento/Shipping/Model/ShipmentNotifierTest.php
+++ b/dev/tests/unit/testsuite/Magento/Shipping/Model/ShipmentNotifierTest.php
@@ -48,7 +48,7 @@ class ShipmentNotifierTest extends \PHPUnit_Framework_TestCase
protected $shipment;
/**
- * @var \Magento\Framework\ObjectManager |\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface |\PHPUnit_Framework_MockObject_MockObject
*/
protected $loggerMock;
diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Model/ShippingTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Model/ShippingTest.php
index 6ad7a938156e531e5f5f5c912c58888faff889d3..34ec2c85103fb10a45e2016b131dab8c0233aa3e 100644
--- a/dev/tests/unit/testsuite/Magento/Shipping/Model/ShippingTest.php
+++ b/dev/tests/unit/testsuite/Magento/Shipping/Model/ShippingTest.php
@@ -48,7 +48,7 @@ class ShippingTest extends \PHPUnit_Framework_TestCase
/**
* @var \PHPUnit_Framework_MockObject_MockObject
*/
- protected $stockItemService;
+ protected $stockRegistry;
/**
* @var \PHPUnit_Framework_MockObject_MockObject
@@ -64,20 +64,19 @@ class ShippingTest extends \PHPUnit_Framework_TestCase
];
return isset($configData[$key]) ? $configData[$key] : 0;
}));
- $this->stockItemService = $this->getMock(
- 'Magento\CatalogInventory\Service\V1\StockItemService',
+ $this->stockRegistry = $this->getMock(
+ 'Magento\CatalogInventory\Model\StockRegistry',
[],
[],
'',
false
);
- $this->stockItemData = $this->getMock('Magento\CatalogInventory\Service\V1\Data\StockItem', [], [], '', false);
- $this->stockItemService->expects($this->any())->method('getStockItem')
- ->will($this->returnValue($this->stockItemData));
+ $this->stockItemData = $this->getMock('Magento\CatalogInventory\Model\Stock\Item', [], [], '', false);
+
$objectManagerHelper = new ObjectManagerHelper($this);
$this->shipping = $objectManagerHelper->getObject('Magento\Shipping\Model\Shipping', [
- 'stockItemService' => $this->stockItemService
+ 'stockRegistry' => $this->stockRegistry
]);
}
@@ -90,7 +89,9 @@ class ShippingTest extends \PHPUnit_Framework_TestCase
/** \Magento\Catalog\Model\Product\Configuration\Item\ItemInterface */
$item = $this->getMockBuilder('\Magento\Sales\Model\Quote\Item')
->disableOriginalConstructor()
- ->setMethods(['getQty', 'getIsQtyDecimal', 'getProductType', 'getProduct', 'getWeight', '__wakeup'])
+ ->setMethods([
+ 'getQty', 'getIsQtyDecimal', 'getProductType', 'getProduct', 'getWeight', '__wakeup', 'getStore'
+ ])
->getMock();
$product = $this->getMock('Magento\Catalog\Model\Product', [], [], '', false);
@@ -100,18 +101,27 @@ class ShippingTest extends \PHPUnit_Framework_TestCase
$item->expects($this->any())->method('getProductType')
->will($this->returnValue(\Magento\Catalog\Model\Product\Type::TYPE_SIMPLE));
$item->expects($this->any())->method('getProduct')->will($this->returnValue($product));
+
+ $store = $this->getMock('Magento\Store\Model\Store', ['getWebsiteId'], [], '', false);
+ $store->expects($this->any())
+ ->method('getWebsiteId')
+ ->will($this->returnValue(10));
+ $item->expects($this->any())->method('getStore')->will($this->returnValue($store));
+
$product->expects($this->any())->method('getId')->will($this->returnValue($this->productId));
$request->setData('all_items', [$item]);
$this->stockItemData->expects($this->any())->method('getIsDecimalDivided')->will($this->returnValue(true));
/** Testable service calls to CatalogInventory module */
- $this->stockItemService->expects($this->atLeastOnce())->method('getStockItem')->with($this->productId);
- $this->stockItemService->expects($this->atLeastOnce())
+ $this->stockRegistry->expects($this->atLeastOnce())->method('getStockItem')
+ ->with($this->productId, 10)
+ ->will($this->returnValue($this->stockItemData));
+
+ $this->stockItemData->expects($this->atLeastOnce())
->method('getEnableQtyIncrements')
- ->with($this->productId)
->will($this->returnValue(true));
- $this->stockItemService->expects($this->atLeastOnce())->method('getQtyIncrements')->with($this->productId)
+ $this->stockItemData->expects($this->atLeastOnce())->method('getQtyIncrements')
->will($this->returnValue(0.5));
$this->shipping->composePackagesForCarrier($this->carrier, $request);
diff --git a/dev/tests/unit/testsuite/Magento/Store/Model/StorageFactoryTest.php b/dev/tests/unit/testsuite/Magento/Store/Model/StorageFactoryTest.php
index a16558c3a51dd7269fa956ed144feb9cf073aee7..2f135ee49e6fa1a607e2332eef2f4e3a80a8fbd1 100644
--- a/dev/tests/unit/testsuite/Magento/Store/Model/StorageFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Store/Model/StorageFactoryTest.php
@@ -130,7 +130,7 @@ class StorageFactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
$this->_arguments = ['test' => 'argument', 'scopeCode' => '', 'scopeType' => ''];
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_eventManagerMock = $this->getMock(
'Magento\Framework\Event\ManagerInterface',
[],
diff --git a/dev/tests/unit/testsuite/Magento/Store/Model/StoreTest.php b/dev/tests/unit/testsuite/Magento/Store/Model/StoreTest.php
index 8406d16184c15f18c2afaca0f3b0caea34e9d044..f4f5bd7f3a0fe3549dd2c2add8d993b46be97d67 100644
--- a/dev/tests/unit/testsuite/Magento/Store/Model/StoreTest.php
+++ b/dev/tests/unit/testsuite/Magento/Store/Model/StoreTest.php
@@ -40,7 +40,7 @@ class StoreTest extends \PHPUnit_Framework_TestCase
protected $requestMock;
/**
- * @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Framework\Stdlib\CookieManager
+ * @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $cookieManagerMock;
@@ -63,7 +63,7 @@ class StoreTest extends \PHPUnit_Framework_TestCase
'getCookie',
'getDistroBaseUrl',
], [], '', false);
- $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManager', [], [], '', false);
+ $this->cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->cookieMetadataFactoryMock = $this->getMock(
'Magento\Framework\Stdlib\Cookie\CookieMetadataFactory',
[],
diff --git a/dev/tests/unit/testsuite/Magento/Tax/Model/Calculation/CalculatorFactoryTest.php b/dev/tests/unit/testsuite/Magento/Tax/Model/Calculation/CalculatorFactoryTest.php
index 2318f8ffa6553e543a2689cd04a600733efadd12..6a6f286c6ae84f1a2b21fe6e4748b764447469fc 100644
--- a/dev/tests/unit/testsuite/Magento/Tax/Model/Calculation/CalculatorFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Tax/Model/Calculation/CalculatorFactoryTest.php
@@ -63,7 +63,7 @@ class CalculatorFactoryTest extends \PHPUnit_Framework_TestCase
$expectedInstanceType
) {
$instanceMock = $this->getMockBuilder($expectedInstanceType)->disableOriginalConstructor()->getMock();
- $objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')->getMock();
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
// Verify create() is called with correct concrete type
$objectManagerMock->expects($this->once())
diff --git a/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php b/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php
index e309fd11c408401f880ac39a9e45a6951bfcebae..5a8d5728325bdf0d575aac18f7a7ce4edc141c46 100644
--- a/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php
+++ b/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php
@@ -718,4 +718,53 @@ class TaxTest extends \PHPUnit_Framework_TestCase
$taxTotalsCalcModel = new Tax($taxConfig, $taxCalculationService, $quoteDetailsBuilder, $taxData);
$this->assertSame($taxTotalsCalcModel->getLabel(), __('Tax'));
}
+
+ /**
+ * Test the case when address does not have any items
+ * Verify that fields in address are reset
+ *
+ * @return void
+ */
+ public function testEmptyAddress()
+ {
+ /** @var $address \Magento\Sales\Model\Quote\Address|PHPUnit_Framework_MockObject_MockObject */
+ $address = $this->getMockBuilder('\Magento\Sales\Model\Quote\Address')
+ ->disableOriginalConstructor()
+ ->setMethods(
+ [
+ 'getAllNonNominalItems',
+ '__wakeup'
+ ]
+ )->getMock();
+
+ $address->setTotalAmount('subtotal', 1);
+ $address->setBaseTotalAmount('subtotal', 1);
+ $address->setTotalAmount('tax', 1);
+ $address->setBaseTotalAmount('tax', 1);
+ $address->setTotalAmount('hidden_tax', 1);
+ $address->setBaseTotalAmount('hidden_tax', 1);
+ $address->setTotalAmount('shipping_hidden_tax', 1);
+ $address->setBaseTotalAmount('shipping_hidden_tax', 1);
+ $address->setSubtotalInclTax(1);
+ $address->setBaseSubtotalInclTax(1);
+
+ $address->expects($this->once())
+ ->method('getAllNonNominalItems')
+ ->will($this->returnValue([]));
+
+ $objectManager = new ObjectManager($this);
+ $taxCollector = $objectManager->getObject('Magento\Tax\Model\Sales\Total\Quote\Tax');
+ $taxCollector->collect($address);
+
+ $this->assertEquals(0, $address->getTotalAmount('subtotal'));
+ $this->assertEquals(0, $address->getTotalAmount('tax'));
+ $this->assertEquals(0, $address->getTotalAmount('hidden_tax'));
+ $this->assertEquals(0, $address->getTotalAmount('shipping_hidden_tax'));
+ $this->assertEquals(0, $address->getBaseTotalAmount('subtotal'));
+ $this->assertEquals(0, $address->getBaseTotalAmount('tax'));
+ $this->assertEquals(0, $address->getBaseTotalAmount('hidden_tax'));
+ $this->assertEquals(0, $address->getBaseTotalAmount('shipping_hidden_tax'));
+ $this->assertEquals(0, $address->getSubtotalInclTax());
+ $this->assertEquals(0, $address->getBaseSubtotalInclTax());
+ }
}
diff --git a/dev/tests/unit/testsuite/Magento/Tax/Model/TaxClass/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Tax/Model/TaxClass/FactoryTest.php
index 035d5ed0caa497853b63b60acefbdab9bd9e14b7..2ee56952d6d474ca0092102231bd1b3b0f95a1b0 100644
--- a/dev/tests/unit/testsuite/Magento/Tax/Model/TaxClass/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Tax/Model/TaxClass/FactoryTest.php
@@ -44,7 +44,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
$classMock->expects($this->once())->method('getClassType')->will($this->returnValue($classType));
$classMock->expects($this->once())->method('getId')->will($this->returnValue(1));
- $objectManager = $this->getMock('Magento\Framework\ObjectManager', array(), array('create'), '', false);
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager->expects(
$this->once()
)->method(
@@ -90,7 +90,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
);
$classMock->expects($this->once())->method('getClassType')->will($this->returnValue($wrongClassType));
- $objectManager = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$taxClassFactory = new \Magento\Tax\Model\TaxClass\Factory($objectManager);
diff --git a/dev/tests/unit/testsuite/Magento/Test/Tools/Di/_files/app/code/Magento/SomeModule/ElementFactory.php b/dev/tests/unit/testsuite/Magento/Test/Tools/Di/_files/app/code/Magento/SomeModule/ElementFactory.php
index 457b3cc51a5265f00fe407d691e4f6638699e1c8..8a6922986405b619f0b30e7e0bb16f5053a97154 100644
--- a/dev/tests/unit/testsuite/Magento/Test/Tools/Di/_files/app/code/Magento/SomeModule/ElementFactory.php
+++ b/dev/tests/unit/testsuite/Magento/Test/Tools/Di/_files/app/code/Magento/SomeModule/ElementFactory.php
@@ -27,14 +27,14 @@ require_once __DIR__ . '/Element.php';
class ElementFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/dev/tests/unit/testsuite/Magento/Test/Tools/Migration/Acl/Db/Adapter/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Test/Tools/Migration/Acl/Db/Adapter/FactoryTest.php
index eeaf3a0a5df47bfee47658f00c65da54ed2e2562..171a2b57279ca6c5c336d574f6f3f64d1128ca1e 100644
--- a/dev/tests/unit/testsuite/Magento/Test/Tools/Migration/Acl/Db/Adapter/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Test/Tools/Migration/Acl/Db/Adapter/FactoryTest.php
@@ -55,7 +55,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
{
$adapterMock = $this->getMock('Magento\Framework\DB\Adapter\Pdo\Mysql', array(), array(), '', false);
- $objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager->expects(
$this->any()
)->method(
@@ -80,7 +80,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
$adapterType = 'Magento\Framework\Object';
$adapterMock = $this->getMock($adapterType, array(), array(), '', false);
- $objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManager->expects(
$this->once()
)->method(
diff --git a/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/CssTest.php b/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/CssTest.php
index 6e5cbd3a23bf5feb424959d244d4d369d6b3ffcd..961f65ae070b05793d2b826a298b2a0c9267e0b8 100644
--- a/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/CssTest.php
+++ b/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/CssTest.php
@@ -31,7 +31,7 @@ class CssTest extends \PHPUnit_Framework_TestCase
protected $_model;
/**
- * @var \Magento\Framework\ObjectManager|\PHPUnit_Framework_MockObject_MockObject
+ * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
*/
protected $_objectManager;
@@ -47,7 +47,7 @@ class CssTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->urlBuilder = $this->getMock('Magento\Backend\Model\Url', [], [], '', false);
$this->urlCoder = $this->getMock('Magento\Framework\Encryption\UrlCoder', [], [], '', false);
diff --git a/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/JsTest.php b/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/JsTest.php
index bb7e88037186d2f89bb5d544384158043c1387f6..de5061156b404a8f71eec307e84c9b600eef016f 100644
--- a/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/JsTest.php
+++ b/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/JsTest.php
@@ -44,7 +44,7 @@ class JsTest extends \PHPUnit_Framework_TestCase
'Magento\Theme\Block\Adminhtml\System\Design\Theme\Edit\Tab\Js',
array(
'formFactory' => $this->getMock('Magento\Framework\Data\FormFactory', array(), array(), '', false),
- 'objectManager' => $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false),
+ 'objectManager' => $this->getMock('Magento\Framework\ObjectManagerInterface'),
'urlBuilder' => $this->_urlBuilder
)
);
diff --git a/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/TabAbstractTest.php b/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/TabAbstractTest.php
index 76c6f73e6ee356c29b615ddf7d01d0dfa9f27f94..1458571fab923facc70a3efe3f29bddf98fa4a96 100644
--- a/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/TabAbstractTest.php
+++ b/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/TabAbstractTest.php
@@ -38,7 +38,7 @@ class TabAbstractTest extends \PHPUnit_Framework_TestCase
$this->getMock('Magento\Backend\Block\Template\Context', array(), array(), '', false),
$this->getMock('Magento\Framework\Registry', array(), array(), '', false),
$this->getMock('Magento\Framework\Data\FormFactory', array(), array(), '', false),
- $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false)
+ $this->getMock('Magento\Framework\ObjectManagerInterface'),
),
'',
true,
diff --git a/dev/tests/unit/testsuite/Magento/Theme/Controller/Adminhtml/System/Design/ThemeTest.php b/dev/tests/unit/testsuite/Magento/Theme/Controller/Adminhtml/System/Design/ThemeTest.php
index 150f1efe5ebe0ef647c934d8fcb7c188d7cf354f..8a15c3539c6fc4650e3767eb39bd3d484ca1f2cb 100644
--- a/dev/tests/unit/testsuite/Magento/Theme/Controller/Adminhtml/System/Design/ThemeTest.php
+++ b/dev/tests/unit/testsuite/Magento/Theme/Controller/Adminhtml/System/Design/ThemeTest.php
@@ -61,7 +61,7 @@ abstract class ThemeTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_request = $this->getMock('Magento\Framework\App\Request\Http', array(), array(), '', false);
$this->eventManager = $this->getMock('\Magento\Framework\Event\ManagerInterface', array(), array(), '', false);
diff --git a/dev/tests/unit/testsuite/Magento/Theme/Model/Wysiwyg/StorageTest.php b/dev/tests/unit/testsuite/Magento/Theme/Model/Wysiwyg/StorageTest.php
index 218f33944cebba2bf19c22531fadbfaf7c3cca1a..e41ea4ae2fdc049de69f068b96abae46ec8663ec 100644
--- a/dev/tests/unit/testsuite/Magento/Theme/Model/Wysiwyg/StorageTest.php
+++ b/dev/tests/unit/testsuite/Magento/Theme/Model/Wysiwyg/StorageTest.php
@@ -45,7 +45,7 @@ class StorageTest extends \PHPUnit_Framework_TestCase
protected $_helperStorage;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -68,7 +68,7 @@ class StorageTest extends \PHPUnit_Framework_TestCase
{
$this->_filesystem = $this->getMock('Magento\Framework\Filesystem', array(), array(), '', false);
$this->_helperStorage = $this->getMock('Magento\Theme\Helper\Storage', array(), array(), '', false);
- $this->_objectManager = $this->getMock('Magento\Framework\ObjectManager', array(), array(), '', false);
+ $this->_objectManager = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_imageFactory = $this->getMock('Magento\Framework\Image\AdapterFactory', array(), array(), '', false);
$this->directoryWrite = $this->getMock(
'Magento\Framework\Filesystem\Directory\Write',
diff --git a/dev/tests/unit/testsuite/Magento/Ui/ContentType/ContentTypeFactoryTest.php b/dev/tests/unit/testsuite/Magento/Ui/ContentType/ContentTypeFactoryTest.php
index e7f92a0a651bde666921d5b56738eee109677860..8ca661cdd91c39161766b2ae3966497cd3471733 100644
--- a/dev/tests/unit/testsuite/Magento/Ui/ContentType/ContentTypeFactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Ui/ContentType/ContentTypeFactoryTest.php
@@ -40,13 +40,7 @@ class ContentTypeFactoryTest extends \PHPUnit_Framework_TestCase
*/
public function testGet($type, $contentRender, $expected)
{
- $objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager',
- ['get', 'create', 'configure'],
- [],
- '',
- false
- );
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->contentTypeFactory = new ContentTypeFactory($objectManagerMock);
$objectManagerMock->expects($this->once())->method('get')->with($expected)->willReturn($contentRender);
$this->assertInstanceOf($expected, $this->contentTypeFactory->get($type));
@@ -57,13 +51,7 @@ class ContentTypeFactoryTest extends \PHPUnit_Framework_TestCase
*/
public function testGetTypeException()
{
- $objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager',
- ['get', 'create', 'configure'],
- [],
- '',
- false
- );
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->contentTypeFactory = new ContentTypeFactory($objectManagerMock);
$this->contentTypeFactory->get('bad_type');
}
@@ -73,13 +61,7 @@ class ContentTypeFactoryTest extends \PHPUnit_Framework_TestCase
*/
public function testGetInstanceException()
{
- $objectManagerMock = $this->getMock(
- 'Magento\Framework\ObjectManager',
- ['get', 'create', 'configure'],
- [],
- '',
- false
- );
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->contentTypeFactory = new ContentTypeFactory($objectManagerMock);
$objectManagerMock->expects($this->once())->method('get')->willReturnSelf();
$this->contentTypeFactory->get();
diff --git a/dev/tests/unit/testsuite/Magento/Ui/Paging/ViewTest.php b/dev/tests/unit/testsuite/Magento/Ui/Paging/ViewTest.php
index 24214bb8eaf86bd9886973132b24ee3a906c8a58..f40cd8286346de68e2db42b4cec764d996bd69d2 100644
--- a/dev/tests/unit/testsuite/Magento/Ui/Paging/ViewTest.php
+++ b/dev/tests/unit/testsuite/Magento/Ui/Paging/ViewTest.php
@@ -116,7 +116,10 @@ class ViewTest extends \PHPUnit_Framework_TestCase
$paramsPage = 1;
$nameSpace = 'namespace';
$configurationMock = $this->getMockForAbstractClass(
- 'Magento\Framework\View\Element\UiComponent\ConfigInterface'
+ 'Magento\Framework\View\Element\UiComponent\ConfigInterface',
+ ['getData'],
+ '',
+ false
);
$this->renderContextMock->expects($this->any())->method('getNamespace')->willReturn($nameSpace);
$this->configurationFactoryMock->expects($this->once())->method('create')->willReturn($configurationMock);
@@ -124,7 +127,12 @@ class ViewTest extends \PHPUnit_Framework_TestCase
$storageMock = $this->getMockForAbstractClass(
'Magento\Framework\View\Element\UiComponent\ConfigStorageInterface'
);
- $dataCollectionMock = $this->getMock('Magento\Framework\Data\Collection', ['setCurPage'], [], '', false);
+ $dataCollectionMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Api\CriteriaInterface',
+ ['setLimit'],
+ '',
+ false
+ );
$this->renderContextMock->expects($this->any())->method('getStorage')->willReturn($storageMock);
$storageMock->expects($this->once())
@@ -133,12 +141,17 @@ class ViewTest extends \PHPUnit_Framework_TestCase
->willReturnSelf();
$storageMock->expects($this->once())->method('getDataCollection')->willReturn($dataCollectionMock);
- $configurationMock->expects($this->at(1))->method('getData')->with('current')->willReturn($paramsSize);
- $this->renderContextMock->expects($this->any())->method('getRequestParam')->willReturn($paramsPage);
- $configurationMock->expects($this->at(2))->method('getData')->with('pageSize')->willReturn($paramsPage);
- $this->renderContextMock->expects($this->any())->method('getRequestParam')->willReturn($paramsSize);
- $dataCollectionMock->expects($this->any())->method('setCurPage')->with($paramsPage)->willReturnSelf();
- $dataCollectionMock->expects($this->any())->method('setPageSize')->with($paramsSize)->willReturnSelf();
+ $configurationMock->expects($this->at(0))->method('getData')->with('current')->willReturn($paramsPage);
+ $this->renderContextMock->expects($this->at(3))->method('getRequestParam')->with('page', $paramsPage)
+ ->willReturn($paramsPage);
+
+ $configurationMock->expects($this->at(1))->method('getData')->with('pageSize')->willReturn($paramsSize);
+ $this->renderContextMock->expects($this->at(4))->method('getRequestParam')->with('limit')
+ ->willReturn($paramsSize);
+
+ $dataCollectionMock->expects($this->any())->method('setLimit')->with($paramsPage, $paramsSize)->willReturn(
+ null
+ );
$this->assertNull($this->view->prepare());
}
diff --git a/dev/tests/unit/testsuite/Magento/Ui/Sorting/ViewTest.php b/dev/tests/unit/testsuite/Magento/Ui/Sorting/ViewTest.php
index 65cd64c2b9493b2310cd53055802d2990c929868..2a905390268f1823f7c6aa3846526be2132694fa 100644
--- a/dev/tests/unit/testsuite/Magento/Ui/Sorting/ViewTest.php
+++ b/dev/tests/unit/testsuite/Magento/Ui/Sorting/ViewTest.php
@@ -145,10 +145,9 @@ class ViewTest extends \PHPUnit_Framework_TestCase
false
);
- $dataCollectionMock = $this->getMock(
- 'Magento\Framework\Data\Collection',
- ['setOrder'],
- [],
+ $dataCollectionMock = $this->getMockForAbstractClass(
+ 'Magento\Framework\Api\CriteriaInterface',
+ ['addOrder'],
'',
false
);
@@ -190,7 +189,7 @@ class ViewTest extends \PHPUnit_Framework_TestCase
->will($this->returnValue($dataCollectionMock));
$dataCollectionMock->expects($this->once())
- ->method('setOrder')
+ ->method('addOrder')
->with('field', 'FIELD');
$this->renderContextMock->expects($this->any())
diff --git a/dev/tests/unit/testsuite/Magento/Webapi/Controller/RequestTest.php b/dev/tests/unit/testsuite/Magento/Webapi/Controller/RequestTest.php
index 8969e79cef128da2a06ffaa8b03a054dee211def..c5460948a3cd7d137774fc358e7c69f46c2e467b 100644
--- a/dev/tests/unit/testsuite/Magento/Webapi/Controller/RequestTest.php
+++ b/dev/tests/unit/testsuite/Magento/Webapi/Controller/RequestTest.php
@@ -37,7 +37,7 @@ class RequestTest extends \PHPUnit_Framework_TestCase
private $request;
/**
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
private $cookieManager;
@@ -45,7 +45,7 @@ class RequestTest extends \PHPUnit_Framework_TestCase
{
$objectManager = new ObjectManager($this);
- $this->cookieManager = $this->getMock('\Magento\Framework\Stdlib\CookieManager');
+ $this->cookieManager = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->request = $objectManager->getObject(
'\Magento\Webapi\Controller\Request',
diff --git a/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/Request/Deserializer/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/Request/Deserializer/FactoryTest.php
index fcc2fc0bad7ed7a4442e95d44a2117c2ed519b90..23510cbfc3fcc8289682e75ebb6ae3652d6f010f 100644
--- a/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/Request/Deserializer/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/Request/Deserializer/FactoryTest.php
@@ -31,7 +31,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
{
$this->setExpectedException('LogicException', 'Request deserializer adapter is not set.');
$interpreterFactory = new \Magento\Webapi\Controller\Rest\Request\Deserializer\Factory(
- $this->getMock('Magento\Framework\ObjectManager'),
+ $this->getMock('Magento\Framework\ObjectManagerInterface'),
array()
);
$interpreterFactory->get('contentType');
@@ -44,7 +44,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
'Magento\Webapi\Controller\Rest\Request\Deserializer\Xml'
)->disableOriginalConstructor()->getMock();
- $objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerMock->expects($this->once())->method('get')->will($this->returnValue($validInterpreterMock));
$interpreterFactory = new \Magento\Webapi\Controller\Rest\Request\Deserializer\Factory(
@@ -62,7 +62,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
'Server cannot understand Content-Type HTTP header media type text_xml'
);
$interpreterFactory = new \Magento\Webapi\Controller\Rest\Request\Deserializer\Factory(
- $this->getMock('Magento\Framework\ObjectManager'),
+ $this->getMock('Magento\Framework\ObjectManagerInterface'),
$expectedMetadata
);
$interpreterFactory->get('text_xml');
@@ -79,7 +79,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
'LogicException',
'The deserializer must implement "Magento\Webapi\Controller\Rest\Request\DeserializerInterface".'
);
- $objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$objectManagerMock->expects($this->once())->method('get')->will($this->returnValue($invalidInterpreter));
$interpreterFactory = new \Magento\Webapi\Controller\Rest\Request\Deserializer\Factory(
diff --git a/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/RequestTest.php b/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/RequestTest.php
index 8b9edb462b9de22b99634bcd2dcf9ee472aaf51c..6182c22d1fef0044846389b99fa83416e2334d92 100644
--- a/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/RequestTest.php
+++ b/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/RequestTest.php
@@ -35,7 +35,7 @@ class RequestTest extends \PHPUnit_Framework_TestCase
protected $_request;
/**
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $_cookieManagerMock;
@@ -55,7 +55,7 @@ class RequestTest extends \PHPUnit_Framework_TestCase
$areaListMock->expects($this->once())->method('getFrontName')->will($this->returnValue('rest'));
/** Instantiate request. */
// TODO: Get rid of SUT mocks.
- $this->_cookieManagerMock = $this->getMock('\Magento\Framework\Stdlib\CookieManager');
+ $this->_cookieManagerMock = $this->getMock('Magento\Framework\Stdlib\CookieManagerInterface');
$this->_request = $this->getMock(
'Magento\Webapi\Controller\Rest\Request',
array('getHeader', 'getMethod', 'isGet', 'isPost', 'isPut', 'isDelete', 'getRawBody'),
diff --git a/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/Response/Renderer/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/Response/Renderer/FactoryTest.php
index 6555d9d427d77f12880217901aebfb2cada48c29..282c4ff30bc862eb1667293f79ff9a0e41577205 100644
--- a/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/Response/Renderer/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Webapi/Controller/Rest/Response/Renderer/FactoryTest.php
@@ -38,7 +38,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager');
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_requestMock = $this->getMockBuilder(
'Magento\Webapi\Controller\Rest\Request'
)->disableOriginalConstructor()->getMock();
diff --git a/dev/tests/unit/testsuite/Magento/Webapi/Controller/RestTest.php b/dev/tests/unit/testsuite/Magento/Webapi/Controller/RestTest.php
index d1f49e3933e92f4aff8f034c7cec33d5269aca3d..7200b66e4dcc21a07c5b3889b39ff3d581fceb18 100644
--- a/dev/tests/unit/testsuite/Magento/Webapi/Controller/RestTest.php
+++ b/dev/tests/unit/testsuite/Magento/Webapi/Controller/RestTest.php
@@ -59,7 +59,7 @@ class RestTest extends \PHPUnit_Framework_TestCase
protected $_routeMock;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManagerMock;
@@ -118,8 +118,7 @@ class RestTest extends \PHPUnit_Framework_TestCase
$this->_routeMock = $this->getMockBuilder('Magento\Webapi\Controller\Rest\Router\Route')
->setMethods(['isSecure', 'getServiceMethod', 'getServiceClass', 'getAclResources', 'getParameters'])
->disableOriginalConstructor()->getMock();
- $this->_objectManagerMock = $this->getMockBuilder('Magento\Framework\ObjectManager')
- ->disableOriginalConstructor()->getMock();
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_serviceMock = $this->getMockBuilder(self::SERVICE_ID)->setMethods([self::SERVICE_METHOD])
->disableOriginalConstructor()->getMock();
$this->_appStateMock = $this->getMockBuilder('Magento\Framework\App\State')
diff --git a/dev/tests/unit/testsuite/Magento/Webapi/Controller/Soap/Request/HandlerTest.php b/dev/tests/unit/testsuite/Magento/Webapi/Controller/Soap/Request/HandlerTest.php
index 99cc00e7e7031ecb125fb3fb6c19f05ce783dcfc..61428b474ac08535b741872874211bd50f6a1887 100644
--- a/dev/tests/unit/testsuite/Magento/Webapi/Controller/Soap/Request/HandlerTest.php
+++ b/dev/tests/unit/testsuite/Magento/Webapi/Controller/Soap/Request/HandlerTest.php
@@ -34,7 +34,7 @@ class HandlerTest extends \PHPUnit_Framework_TestCase
/** @var \Magento\Webapi\Controller\Soap\Request\Handler */
protected $_handler;
- /** @var \Magento\Framework\ObjectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface */
protected $_objectManagerMock;
/** @var \PHPUnit_Framework_MockObject_MockObject */
@@ -64,7 +64,7 @@ class HandlerTest extends \PHPUnit_Framework_TestCase
$this->_apiConfigMock = $this->getMockBuilder('Magento\Webapi\Model\Soap\Config')
->setMethods(array('getServiceMethodInfo'))->disableOriginalConstructor()->getMock();
$this->_requestMock = $this->getMock('Magento\Webapi\Controller\Soap\Request', [], [], '', false);
- $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManager', [], [], '', false);
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_authorizationMock = $this->getMock('Magento\Framework\AuthorizationInterface', [], [], '', false);
$this->_dataObjectConverter = $this->getMock(
'Magento\Framework\Api\SimpleDataObjectConverter',
diff --git a/dev/tests/unit/testsuite/Magento/Webapi/Model/Soap/Wsdl/FactoryTest.php b/dev/tests/unit/testsuite/Magento/Webapi/Model/Soap/Wsdl/FactoryTest.php
index a7d6f2e364b3ed6326e3bc784b78a8e3dc5d013e..f0b4ce9d21e7bd707dc5a74d3e3ef61f5399e723 100644
--- a/dev/tests/unit/testsuite/Magento/Webapi/Model/Soap/Wsdl/FactoryTest.php
+++ b/dev/tests/unit/testsuite/Magento/Webapi/Model/Soap/Wsdl/FactoryTest.php
@@ -35,11 +35,7 @@ class FactoryTest extends \PHPUnit_Framework_TestCase
protected function setUp()
{
- $this->_objectManagerMock = $this->getMockBuilder(
- 'Magento\Framework\ObjectManager'
- )->disableOriginalConstructor()->setMethods(
- array('create')
- )->getMockForAbstractClass();
+ $this->_objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface');
$this->_soapWsdlFactory = new \Magento\Webapi\Model\Soap\Wsdl\Factory($this->_objectManagerMock);
parent::setUp();
}
diff --git a/dev/tests/unit/testsuite/Magento/Weee/Helper/DataTest.php b/dev/tests/unit/testsuite/Magento/Weee/Helper/DataTest.php
index 3ddeed9a4ff93ca5096ca8b0fdc238843b7750ae..ca6a85cba716960309e3910dc067487ec4c49f4e 100644
--- a/dev/tests/unit/testsuite/Magento/Weee/Helper/DataTest.php
+++ b/dev/tests/unit/testsuite/Magento/Weee/Helper/DataTest.php
@@ -90,6 +90,16 @@ class DataTest extends \PHPUnit_Framework_TestCase
WeeeHelper::KEY_WEEE_TAX_AMOUNT_REFUNDED => self::TAX_AMOUNT_REFUNDED,
WeeeHelper::KEY_BASE_WEEE_TAX_AMOUNT_REFUNDED => self::BASE_TAX_AMOUNT_REFUNDED,
],
+ [
+ WeeeHelper::KEY_WEEE_AMOUNT_INVOICED => self::ROW_AMOUNT_INVOICED,
+ WeeeHelper::KEY_BASE_WEEE_AMOUNT_INVOICED => self::BASE_ROW_AMOUNT_INVOICED,
+ WeeeHelper::KEY_WEEE_TAX_AMOUNT_INVOICED => self::TAX_AMOUNT_INVOICED,
+ WeeeHelper::KEY_BASE_WEEE_TAX_AMOUNT_INVOICED => self::BASE_TAX_AMOUNT_INVOICED,
+ WeeeHelper::KEY_WEEE_AMOUNT_REFUNDED => self::ROW_AMOUNT_REFUNDED,
+ WeeeHelper::KEY_BASE_WEEE_AMOUNT_REFUNDED => self::BASE_ROW_AMOUNT_REFUNDED,
+ WeeeHelper::KEY_WEEE_TAX_AMOUNT_REFUNDED => self::TAX_AMOUNT_REFUNDED,
+ WeeeHelper::KEY_BASE_WEEE_TAX_AMOUNT_REFUNDED => self::BASE_TAX_AMOUNT_REFUNDED,
+ ],
]
)
);
diff --git a/dev/tests/unit/testsuite/Magento/Weee/Model/Total/Creditmemo/WeeeTest.php b/dev/tests/unit/testsuite/Magento/Weee/Model/Total/Creditmemo/WeeeTest.php
index ad65d82c1176efc6435569b25a278e25e4c7eae2..f1e5d5a961da3165f21e4f0460394f821ece978f 100644
--- a/dev/tests/unit/testsuite/Magento/Weee/Model/Total/Creditmemo/WeeeTest.php
+++ b/dev/tests/unit/testsuite/Magento/Weee/Model/Total/Creditmemo/WeeeTest.php
@@ -202,7 +202,13 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'weee_tax_amount_refunded' => 0,
'base_weee_tax_amount_refunded' => 0,
'applied_weee' => [
- [],
+ [
+ 'title' => 'recycling_fee',
+ 'base_row_amount' => 30,
+ 'row_amount' => 30,
+ 'base_row_amount_incl_tax' => 32.47,
+ 'row_amount_incl_tax' => 32.47
+ ],
],
'qty_invoiced' => 3,
],
@@ -233,6 +239,7 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'item_1' => [
'applied_weee' => [
[
+ 'title' => 'recycling_fee',
'base_row_amount' => 30,
'row_amount' => 30,
'base_row_amount_incl_tax' => 32.47,
@@ -278,7 +285,13 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'weee_tax_amount_refunded' => 0,
'base_weee_tax_amount_refunded' => 0,
'applied_weee' => [
- [],
+ [
+ 'title' => 'recycling_fee',
+ 'base_row_amount' => 30,
+ 'row_amount' => 30,
+ 'base_row_amount_incl_tax' => 32.47,
+ 'row_amount_incl_tax' => 32.47
+ ],
],
'qty_invoiced' => 3,
],
@@ -309,6 +322,7 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'item_1' => [
'applied_weee' => [
[
+ 'title' => 'recycling_fee',
'base_row_amount' => 20,
'row_amount' => 20,
'base_row_amount_incl_tax' => 21.65,
@@ -354,7 +368,13 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'weee_tax_amount_refunded' => 1.64,
'base_weee_tax_amount_refunded' => 1.64,
'applied_weee' => [
- [],
+ [
+ 'title' => 'recycling_fee',
+ 'base_row_amount' => 30,
+ 'row_amount' => 30,
+ 'base_row_amount_incl_tax' => 32.47,
+ 'row_amount_incl_tax' => 32.47
+ ],
],
'qty_invoiced' => 3,
],
@@ -385,6 +405,7 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'item_1' => [
'applied_weee' => [
[
+ 'title' => 'recycling_fee',
'base_row_amount' => 10,
'row_amount' => 10,
'base_row_amount_incl_tax' => 10.82,
diff --git a/dev/tests/unit/testsuite/Magento/Weee/Model/Total/Invoice/WeeeTest.php b/dev/tests/unit/testsuite/Magento/Weee/Model/Total/Invoice/WeeeTest.php
index 1894ef078d0673eb63c224c7fd7359567097f63f..660941cae4217671e426cec710745f2638a75670 100644
--- a/dev/tests/unit/testsuite/Magento/Weee/Model/Total/Invoice/WeeeTest.php
+++ b/dev/tests/unit/testsuite/Magento/Weee/Model/Total/Invoice/WeeeTest.php
@@ -217,7 +217,13 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'weee_tax_amount_invoiced' => 0,
'base_weee_tax_amount_invoiced' => 0,
'applied_weee' => [
- [],
+ [
+ 'title' => 'recycling_fee',
+ 'base_row_amount' => 30,
+ 'row_amount' => 30,
+ 'base_row_amount_incl_tax' => 32.47,
+ 'row_amount_incl_tax' => 32.47
+ ],
],
'applied_weee_updated' => [
'base_row_amount_invoiced' => 30,
@@ -255,6 +261,7 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'item_1' => [
'applied_weee' => [
[
+ 'title' => 'recycling_fee',
'base_row_amount' => 30,
'row_amount' => 30,
'base_row_amount_incl_tax' => 32.47,
@@ -312,7 +319,13 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'weee_tax_amount_invoiced' => 0,
'base_weee_tax_amount_invoiced' => 0,
'applied_weee' => [
- [],
+ [
+ 'title' => 'recycling_fee',
+ 'base_row_amount' => 30,
+ 'row_amount' => 30,
+ 'base_row_amount_incl_tax' => 32.47,
+ 'row_amount_incl_tax' => 32.47
+ ],
],
'applied_weee_updated' => [
'base_row_amount_invoiced' => 30,
@@ -350,6 +363,7 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'item_1' => [
'applied_weee' => [
[
+ 'title' => 'recycling_fee',
'base_row_amount' => 20,
'row_amount' => 20,
'base_row_amount_incl_tax' => 21.65,
@@ -409,6 +423,11 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'base_weee_tax_amount_invoiced' => 0,
'applied_weee' => [
[
+ 'title' => 'recycling_fee',
+ 'base_row_amount' => 30,
+ 'row_amount' => 30,
+ 'base_row_amount_incl_tax' => 32.47,
+ 'row_amount_incl_tax' => 32.47
],
],
'applied_weee_updated' => [
@@ -447,6 +466,7 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'item_1' => [
'applied_weee' => [
[
+ 'title' => 'recycling_fee',
'base_row_amount' => 10,
'row_amount' => 10,
'base_row_amount_incl_tax' => 10.82,
@@ -506,6 +526,11 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'base_weee_tax_amount_invoiced' => 1.64,
'applied_weee' => [
[
+ 'title' => 'recycling_fee',
+ 'base_row_amount' => 30,
+ 'row_amount' => 30,
+ 'base_row_amount_incl_tax' => 32.47,
+ 'row_amount_incl_tax' => 32.47
],
],
'applied_weee_updated' => [
@@ -544,6 +569,7 @@ class WeeeTest extends \PHPUnit_Framework_TestCase
'item_1' => [
'applied_weee' => [
[
+ 'title' => 'recycling_fee',
'base_row_amount' => 10,
'row_amount' => 10,
'base_row_amount_incl_tax' => 10.82,
diff --git a/dev/tests/unit/testsuite/Magento/Wishlist/Block/Rss/EmailLinkTest.php b/dev/tests/unit/testsuite/Magento/Wishlist/Block/Rss/EmailLinkTest.php
index b406d8e5e9a1b43f0ec550e7946481b7d9213a89..f3e1846d3775c8c3e511ba850ba25fb6d111cb65 100644
--- a/dev/tests/unit/testsuite/Magento/Wishlist/Block/Rss/EmailLinkTest.php
+++ b/dev/tests/unit/testsuite/Magento/Wishlist/Block/Rss/EmailLinkTest.php
@@ -51,13 +51,18 @@ class EmailLinkTest extends \PHPUnit_Framework_TestCase
$this->wishlistHelper = $this->getMock(
'Magento\Wishlist\Helper\Data',
- ['getWishlist', 'getCustomer'],
+ ['getWishlist', 'getCustomer', 'urlEncode'],
[],
'',
false
);
$this->wishlistHelper->expects($this->any())->method('getWishlist')->will($this->returnValue($wishlist));
$this->wishlistHelper->expects($this->any())->method('getCustomer')->will($this->returnValue($customer));
+ $this->wishlistHelper->expects($this->any())
+ ->method('urlEncode')
+ ->willReturnCallback(function ($url) {
+ return strtr(base64_encode($url), '+/=', '-_,');
+ });
$this->urlBuilder = $this->getMock('Magento\Framework\App\Rss\UrlBuilderInterface');
$this->objectManagerHelper = new ObjectManagerHelper($this);
diff --git a/dev/tests/unit/testsuite/Magento/Wishlist/Block/Rss/LinkTest.php b/dev/tests/unit/testsuite/Magento/Wishlist/Block/Rss/LinkTest.php
index ca22c973253c2658cdaa23ca04a59d23a03fd1c2..fe88b9348d95f88168a6260e98f288db058fd40e 100644
--- a/dev/tests/unit/testsuite/Magento/Wishlist/Block/Rss/LinkTest.php
+++ b/dev/tests/unit/testsuite/Magento/Wishlist/Block/Rss/LinkTest.php
@@ -53,13 +53,16 @@ class LinkTest extends \PHPUnit_Framework_TestCase
$this->wishlistHelper = $this->getMock(
'Magento\Wishlist\Helper\Data',
- ['getWishlist', 'getCustomer'],
+ ['getWishlist', 'getCustomer', 'urlEncode'],
[],
'',
false
);
$this->wishlistHelper->expects($this->any())->method('getWishlist')->will($this->returnValue($wishlist));
$this->wishlistHelper->expects($this->any())->method('getCustomer')->will($this->returnValue($customer));
+ $this->wishlistHelper->expects($this->any())->method('urlEncode')->willReturnCallback(function ($url) {
+ return strtr(base64_encode($url), '+/=', '-_,');
+ });
$this->urlBuilder = $this->getMock('Magento\Framework\App\Rss\UrlBuilderInterface');
$this->scopeConfig = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface');
diff --git a/dev/tests/unit/testsuite/Magento/Wishlist/Model/ItemTest.php b/dev/tests/unit/testsuite/Magento/Wishlist/Model/ItemTest.php
index b3b9a875fdf3693c99bd3f57adf50042f7eeece5..93f04a8ad94e3221c66ede193ca023e5c9c45935 100644
--- a/dev/tests/unit/testsuite/Magento/Wishlist/Model/ItemTest.php
+++ b/dev/tests/unit/testsuite/Magento/Wishlist/Model/ItemTest.php
@@ -197,7 +197,7 @@ class ItemTest extends \PHPUnit_Framework_TestCase
->getMock();
$optionMock->expects($this->any())
->method('getCode')
- ->willReturn('second_key');
+ ->will($this->returnValue('second_key'));
$productMock = $this->getMockBuilder('Magento\Catalog\Model\Product')
->disableOriginalConstructor()
diff --git a/dev/tests/unit/testsuite/Magento/_files/Child/Interceptor.php b/dev/tests/unit/testsuite/Magento/_files/Child/Interceptor.php
index f9647f39e87c619edfabf1245fd51a1656d13775..7477c1a02e582a8fab95c06ccf07161f4ddfa83b 100644
--- a/dev/tests/unit/testsuite/Magento/_files/Child/Interceptor.php
+++ b/dev/tests/unit/testsuite/Magento/_files/Child/Interceptor.php
@@ -26,12 +26,12 @@ namespace Magento\Test\Di\Child;
class Interceptor extends \Magento\Test\Di\Child
{
/**
- * @var \Magento\Framework\ObjectManager\Config
+ * @var \Magento\Framework\ObjectManager\ConfigInterface
*/
protected $_config;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_factory;
@@ -61,14 +61,14 @@ class Interceptor extends \Magento\Test\Di\Child
protected $_arguments;
/**
- * @param \Magento\Framework\ObjectManager\Factory $factory
+ * @param \Magento\Framework\ObjectManager\FactoryInterface $factory
* @param \Magento\Framework\ObjectManager\ObjectManager $objectManager
* @param string $subjectType
* @param array $pluginList
* @param array $arguments
*/
public function __construct(
- \Magento\Framework\ObjectManager\Factory $factory,
+ \Magento\Framework\ObjectManager\FactoryInterface $factory,
\Magento\Framework\ObjectManager\ObjectManager $objectManager,
$subjectType,
array $pluginList,
diff --git a/dev/tools/Magento/Tools/Di/Code/Scanner/PhpScanner.php b/dev/tools/Magento/Tools/Di/Code/Scanner/PhpScanner.php
index 96569b0663dceb30fb5d72f6852e874255fdb670..3626ee098f327c522bc03fbc3883d4cb4bb4617d 100644
--- a/dev/tools/Magento/Tools/Di/Code/Scanner/PhpScanner.php
+++ b/dev/tools/Magento/Tools/Di/Code/Scanner/PhpScanner.php
@@ -62,7 +62,7 @@ class PhpScanner implements ScannerInterface
continue;
}
$entityName = rtrim(substr($factoryClassName, 0, -7), '\\');
- if (!class_exists($entityName)) {
+ if (!class_exists($entityName) && !interface_exists($entityName)) {
$this->_log->add(
Log::CONFIGURATION_ERROR,
$factoryClassName,
diff --git a/dev/tools/Magento/Tools/Di/compiler.php b/dev/tools/Magento/Tools/Di/compiler.php
index ebb368ecd9ff4d94900d462fec70ab607a4047a1..fc209172ce6ce3d7c82a23a753f9c56f0aefe336 100644
--- a/dev/tools/Magento/Tools/Di/compiler.php
+++ b/dev/tools/Magento/Tools/Di/compiler.php
@@ -38,6 +38,7 @@ use Magento\Framework\Api\Code\Generator\Mapper;
use Magento\Framework\Api\Code\Generator\SearchResults;
use Magento\Framework\Api\Code\Generator\SearchResultsBuilder;
use Magento\Framework\Api\Code\Generator\DataBuilder;
+use Magento\Framework\Autoload\AutoloaderRegistry;
$filePatterns = ['php' => '/.*\.php$/', 'di' => '/\/etc\/([a-zA-Z_]*\/di|di)\.xml$/'];
$codeScanDir = realpath($rootDir . '/app');
@@ -54,8 +55,6 @@ try {
$opt->parse();
$generationDir = $opt->getOption('generation') ? $opt->getOption('generation') : $rootDir . '/var/generation';
- \Magento\Framework\Code\Generator\FileResolver::addIncludePath($generationDir);
-
$diDir = $opt->getOption('di') ? $opt->getOption('di') : $rootDir . '/var/di';
$compiledFile = $diDir . '/definitions.php';
$relationsFile = $diDir . '/relations.php';
@@ -76,6 +75,8 @@ try {
$validator->add(new \Magento\Framework\Code\Validator\ConstructorIntegrity());
$validator->add(new \Magento\Framework\Code\Validator\ContextAggregation());
+ AutoloaderRegistry::getAutoloader()->addPsr4('Magento\\', $generationDir . '/Magento/');
+
// 1 Code generation
// 1.1 Code scan
$directoryScanner = new Scanner\DirectoryScanner();
@@ -91,16 +92,13 @@ try {
$interceptorScanner = new Scanner\XmlInterceptorScanner();
$entities['interceptors'] = $interceptorScanner->collectEntities($files['di']);
- $fileResolver = new \Magento\Framework\Code\Generator\FileResolver();
// 1.2 Generation of Factory and Additional Classes
$generatorIo = new \Magento\Framework\Code\Generator\Io(
new \Magento\Framework\Filesystem\Driver\File(),
- $fileResolver,
$generationDir
);
$generator = new \Magento\Framework\Code\Generator(
- $fileResolver,
$generatorIo,
[
DataBuilder::ENTITY_TYPE => 'Magento\Framework\Api\Code\Generator\DataBuilder',
@@ -116,18 +114,15 @@ try {
SearchResults::ENTITY_TYPE => 'Magento\Framework\Api\Code\Generator\SearchResults',
]
);
- $autoloader = new \Magento\Framework\Code\Generator\Autoloader($generator, $fileResolver);
- spl_autoload_register([$autoloader, 'load']);
+
+ $generatorAutoloader = new \Magento\Framework\Code\Generator\Autoloader($generator);
+ spl_autoload_register([$generatorAutoloader, 'load']);
foreach (['php', 'additional'] as $type) {
sort($entities[$type]);
foreach ($entities[$type] as $entityName) {
switch ($generator->generateClass($entityName)) {
case \Magento\Framework\Code\Generator::GENERATION_SUCCESS:
$log->add(Log::GENERATION_SUCCESS, $entityName);
- $file = $fileResolver->getFile($entityName);
- if ($file) {
- include_once $file;
- }
break;
case \Magento\Framework\Code\Generator::GENERATION_ERROR:
@@ -163,10 +158,6 @@ try {
switch ($generator->generateClass($entityName)) {
case \Magento\Framework\Code\Generator::GENERATION_SUCCESS:
$log->add(Log::GENERATION_SUCCESS, $entityName);
- $file = $fileResolver->getFile($entityName);
- if ($file) {
- include_once $file;
- }
break;
case \Magento\Framework\Code\Generator::GENERATION_ERROR:
diff --git a/dev/tools/Magento/Tools/Di/entity_generator.php b/dev/tools/Magento/Tools/Di/entity_generator.php
index c917c8f1de5524ca635d4100f7d93ace8a39eb8b..41c8ddfdb8f47c3d8b933e1afe781f6b3f15bfc8 100644
--- a/dev/tools/Magento/Tools/Di/entity_generator.php
+++ b/dev/tools/Magento/Tools/Di/entity_generator.php
@@ -35,12 +35,12 @@ use Magento\Framework\ObjectManager\Code\Generator\Repository;
use Magento\Framework\ObjectManager\Code\Generator\Converter;
use Magento\Framework\Api\Code\Generator\SearchResults;
use Magento\Framework\Api\Code\Generator\SearchResultsBuilder;
+use Magento\Framework\Autoload\AutoloaderRegistry;
require __DIR__ . '/../../../../../app/bootstrap.php';
// default generation dir
$generationDir = BP . '/' . Io::DEFAULT_DIRECTORY;
-
try {
$opt = new \Zend_Console_Getopt(
[
@@ -69,8 +69,10 @@ try {
if ($opt->getOption('g')) {
$generationDir = $opt->getOption('g');
}
+ AutoloaderRegistry::getAutoloader()->addPsr4('Magento\\', $generationDir . '/Magento/');
+
} catch (\Zend_Console_Getopt_Exception $e) {
- $generator = new Generator(new \Magento\Framework\Code\Generator\FileResolver());
+ $generator = new Generator();
$entities = $generator->getGeneratedEntities();
$allowedTypes = 'Allowed entity types are: ' . implode(', ', $entities) . '.';
@@ -85,12 +87,10 @@ try {
exit($example);
}
-\Magento\Framework\Code\Generator\FileResolver::addIncludePath($generationDir);
-
//reinit generator with correct generation path
-$io = new Io(new File(), null, $generationDir);
+$io = new Io(new File(), $generationDir);
$generator = new Generator(
- null,
+ $validator,
$io,
[
DataBuilder::ENTITY_TYPE => 'Magento\Framework\Api\Code\Generator\DataBuilder',
diff --git a/dev/tools/Magento/Tools/I18n/bootstrap.php b/dev/tools/Magento/Tools/I18n/bootstrap.php
index 1d2cd7c116c310f8a03995061e6664b4fe9156ef..d2bf7f326ec1f4dc09a847b757205e1e4a0c5ed9 100644
--- a/dev/tools/Magento/Tools/I18n/bootstrap.php
+++ b/dev/tools/Magento/Tools/I18n/bootstrap.php
@@ -22,9 +22,4 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
define('BP', realpath(__DIR__) . '/');
-
-$vendorDir = require BP . '../../../../../app/etc/vendor_path.php';
-$vendorAutoload = BP . "../../../../../{$vendorDir}/autoload.php";
-if (file_exists($vendorAutoload)) {
- require_once $vendorAutoload;
-}
+require realpath(BP . '/../../../../../app/autoload.php');
diff --git a/dev/tools/Magento/Tools/Migration/Acl/Db/Adapter/Factory.php b/dev/tools/Magento/Tools/Migration/Acl/Db/Adapter/Factory.php
index 2f4bdaed11d7b194c068b610c7ba78e2f6075e5b..c957fc9234b0db22850084e6c099d28fcc3e5dd2 100644
--- a/dev/tools/Magento/Tools/Migration/Acl/Db/Adapter/Factory.php
+++ b/dev/tools/Magento/Tools/Migration/Acl/Db/Adapter/Factory.php
@@ -30,9 +30,9 @@ namespace Magento\Tools\Migration\Acl\Db\Adapter;
class Factory
{
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/dev/tools/Magento/Tools/Migration/Acl/db.php b/dev/tools/Magento/Tools/Migration/Acl/db.php
index aadb20fa694171636575bcaa05ca424c137a5c58..73fb93de9ad001358384ced92d102f77e5ad67c4 100644
--- a/dev/tools/Magento/Tools/Migration/Acl/db.php
+++ b/dev/tools/Magento/Tools/Migration/Acl/db.php
@@ -24,7 +24,7 @@
$rootDir = realpath(__DIR__ . '/../../../..');
require $rootDir . '/app/autoload.php';
-\Magento\Framework\Code\Generator\FileResolver::addIncludePath([$rootDir . '/lib', $rootDir . '/dev']);
+\Magento\Framework\Filesystem\FileResolver::addIncludePath([$rootDir . '/lib', $rootDir . '/dev']);
$defaultReportFile = 'report.log';
try {
diff --git a/dev/tools/Magento/Tools/Migration/system_config.php b/dev/tools/Magento/Tools/Migration/system_config.php
index 609815b7a24fa0c14934d3bf9e9127d03b1246c9..cbf96793b070a06dc08d87c1a5ab9c8075136172 100644
--- a/dev/tools/Magento/Tools/Migration/system_config.php
+++ b/dev/tools/Magento/Tools/Migration/system_config.php
@@ -37,7 +37,7 @@ use Magento\Tools\Migration\System\Configuration\Logger as Logger;
$rootDir = realpath(__DIR__ . '../../../../../../');
require __DIR__ . '/../../../../../app/autoload.php';
-\Magento\Framework\Code\Generator\FileResolver::addIncludePath([$rootDir . '/lib', $rootDir . '/dev']);
+\Magento\Framework\Filesystem\FileResolver::addIncludePath([$rootDir . '/lib', $rootDir . '/dev']);
$defaultReportFile = 'report.log';
diff --git a/dev/tools/Magento/Tools/Migration/themes_view.php b/dev/tools/Magento/Tools/Migration/themes_view.php
index e74ee0f20078dc3708b259aec04dfa1198ba8bab..4e5eb10beffef19ee816a73f61a5987f837aeffa 100644
--- a/dev/tools/Magento/Tools/Migration/themes_view.php
+++ b/dev/tools/Magento/Tools/Migration/themes_view.php
@@ -46,7 +46,7 @@ try {
/**
* Replace {{skin url=""}} with {{view url=""}} for given table field
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $table
* @param string $col
* @return void
diff --git a/dev/tools/Magento/Tools/View/deploy.php b/dev/tools/Magento/Tools/View/deploy.php
index b0cd9635d8c5fd3f3f45feb940e4626936a675ce..e935f2fd278a04f7bc310a4bcaea4bb78efc990a 100644
--- a/dev/tools/Magento/Tools/View/deploy.php
+++ b/dev/tools/Magento/Tools/View/deploy.php
@@ -27,13 +27,16 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
+use Magento\Framework\Autoload\AutoloaderRegistry;
+
$baseName = basename(__FILE__);
$options = getopt('', array('langs::', 'dry-run', 'verbose::', 'help'));
define('USAGE', "USAGE:\n\tphp -f {$baseName} -- [--langs=en_US,de_DE,...] [--verbose=0|1] [--dry-run] [--help]\n");
require __DIR__ . '/../../../../../app/bootstrap.php';
-\Magento\Framework\Code\Generator\FileResolver::addIncludePath(
- [BP . '/dev/tests/static/framework', realpath(__DIR__ . '/../../..')]
+AutoloaderRegistry::getAutoloader()->addPsr4(
+ 'Magento\\',
+ [BP . '/dev/tests/static/framework/Magento/', realpath(__DIR__ . '/../../../Magento/')]
);
// parse all options
diff --git a/dev/tools/performance-toolkit/fixtures/simple_products.php b/dev/tools/performance-toolkit/fixtures/simple_products.php
index dd286a02f7978d37f25e3a9bae50249f593b647d..502ae6f8a167c67270a75487252824b78dc6d63a 100644
--- a/dev/tools/performance-toolkit/fixtures/simple_products.php
+++ b/dev/tools/performance-toolkit/fixtures/simple_products.php
@@ -101,8 +101,7 @@ $pattern = array(
'use_config_notify_stock_qty' => '1',
'use_config_manage_stock' => '1',
'use_config_qty_increments' => '1',
- 'use_config_enable_qty_inc' => '1',
- 'stock_id' => \Magento\CatalogInventory\Model\Stock::DEFAULT_STOCK_ID,
+ 'use_config_enable_qty_inc' => '1'
);
$generator = new \Magento\ToolkitFramework\ImportExport\Fixture\Generator($pattern, $simpleProductsCount);
/** @var \Magento\ImportExport\Model\Import $import */
diff --git a/dev/tools/performance-toolkit/framework/Magento/ToolkitFramework/Application.php b/dev/tools/performance-toolkit/framework/Magento/ToolkitFramework/Application.php
index f9f8fa97e9646a1afae322a29383a09f6d76c535..9a98cda8e3bcb1b1bd8185680db350e2eee862a1 100644
--- a/dev/tools/performance-toolkit/framework/Magento/ToolkitFramework/Application.php
+++ b/dev/tools/performance-toolkit/framework/Magento/ToolkitFramework/Application.php
@@ -49,7 +49,7 @@ class Application
protected $_shell;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -166,7 +166,7 @@ class Application
/**
* Get object manager
*
- * @return \Magento\Framework\ObjectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*/
public function getObjectManager()
{
@@ -181,7 +181,7 @@ class Application
/**
* Reset object manager
*
- * @return \Magento\Framework\ObjectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*/
public function resetObjectManager()
{
diff --git a/dev/tools/performance-toolkit/framework/tests/unit/framework/bootstrap.php b/dev/tools/performance-toolkit/framework/tests/unit/framework/bootstrap.php
index d213e5969b12d1b8705376d715b9b411605e198a..a5ca417a9666a1bf00269adf31b01d01443cde78 100644
--- a/dev/tools/performance-toolkit/framework/tests/unit/framework/bootstrap.php
+++ b/dev/tools/performance-toolkit/framework/tests/unit/framework/bootstrap.php
@@ -23,9 +23,4 @@
*/
$magentoBaseDir = realpath(__DIR__ . '/../../../../../../../');
-
require_once "$magentoBaseDir/app/bootstrap.php";
-
-\Magento\Framework\Code\Generator\FileResolver::addIncludePath(
- "$magentoBaseDir/dev/tools/performance-toolkit/framework"
-);
diff --git a/dev/tools/tests.php b/dev/tools/tests.php
index e0d4d93ac64c459f10a4256751ca52d9b1b8fd12..31abff9a2fffe116ec1f2db60b0da563f21430cd 100644
--- a/dev/tools/tests.php
+++ b/dev/tools/tests.php
@@ -24,6 +24,8 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
+$vendorDir = require '../../app/etc/vendor_path.php';
+
$commands = array(
'unit' => array('../tests/unit', ''),
'unit-performance' => array('../tests/performance/framework/tests/unit', ''),
@@ -64,7 +66,7 @@ foreach ($runCommands as $key) {
list($dir, $options) = $commands[$key];
$dirName = realpath(__DIR__ . '/' . $dir);
chdir($dirName);
- $command = 'phpunit' . $options;
+ $command = realpath(__DIR__ . '/../../') . '/' . $vendorDir . '/phpunit/phpunit/phpunit' . $options;
$message = $dirName . '> ' . $command;
echo "\n\n";
echo str_pad("---- {$message} ", 70, '-');
diff --git a/lib/internal/Magento/Framework/Acl/ResourceFactory.php b/lib/internal/Magento/Framework/Acl/ResourceFactory.php
index 5f32f3f45fd67212663497409b4bd46cb579c295..5add85b74735d2b462fd2da57797b44f4a4801c7 100644
--- a/lib/internal/Magento/Framework/Acl/ResourceFactory.php
+++ b/lib/internal/Magento/Framework/Acl/ResourceFactory.php
@@ -25,21 +25,21 @@
*/
namespace Magento\Framework\Acl;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class ResourceFactory
{
const RESOURCE_CLASS_NAME = 'Magento\Framework\Acl\Resource';
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/AclFactory.php b/lib/internal/Magento/Framework/AclFactory.php
index b354553b262c9525950baf4994b162bff723e21b..4a608428d7ae91f225ddfcf8397f5effd8492111 100644
--- a/lib/internal/Magento/Framework/AclFactory.php
+++ b/lib/internal/Magento/Framework/AclFactory.php
@@ -30,14 +30,14 @@ class AclFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Api/Builder.php b/lib/internal/Magento/Framework/Api/Builder.php
index 3d77405ca30ee62b8206ec4028fb48b46538f438..e154faafa37e11709df15c2deb55dec9b0344cc3 100644
--- a/lib/internal/Magento/Framework/Api/Builder.php
+++ b/lib/internal/Magento/Framework/Api/Builder.php
@@ -87,7 +87,7 @@ class Builder implements BuilderInterface
protected $dataBuilderFactory;
/**
- * @var \Magento\Framework\ObjectManager\Config
+ * @var \Magento\Framework\ObjectManager\ConfigInterface
*/
protected $objectManagerConfig;
@@ -98,7 +98,7 @@ class Builder implements BuilderInterface
* @param \Magento\Framework\Reflection\DataObjectProcessor $objectProcessor
* @param \Magento\Framework\Reflection\TypeProcessor $typeProcessor
* @param \Magento\Framework\Serialization\DataBuilderFactory $dataBuilderFactory
- * @param \Magento\Framework\ObjectManager\Config $objectManagerConfig
+ * @param \Magento\Framework\ObjectManager\ConfigInterface $objectManagerConfig
* @param string $modelClassInterface
*/
public function __construct(
@@ -108,7 +108,7 @@ class Builder implements BuilderInterface
\Magento\Framework\Reflection\DataObjectProcessor $objectProcessor,
\Magento\Framework\Reflection\TypeProcessor $typeProcessor,
\Magento\Framework\Serialization\DataBuilderFactory $dataBuilderFactory,
- \Magento\Framework\ObjectManager\Config $objectManagerConfig,
+ \Magento\Framework\ObjectManager\ConfigInterface $objectManagerConfig,
$modelClassInterface = null
) {
$this->objectFactory = $objectFactory;
diff --git a/lib/internal/Magento/Framework/Api/Code/Generator/DataBuilder.php b/lib/internal/Magento/Framework/Api/Code/Generator/DataBuilder.php
index 1dcb973cbd191d69f144af813f07892898f7a99f..19dbd9421331b267d3e981fc0ca69dff6bc7cd18 100644
--- a/lib/internal/Magento/Framework/Api/Code/Generator/DataBuilder.php
+++ b/lib/internal/Magento/Framework/Api/Code/Generator/DataBuilder.php
@@ -24,11 +24,10 @@
namespace Magento\Framework\Api\Code\Generator;
-use \Magento\Framework\Code\Generator\FileResolver;
use Magento\Framework\Code\Generator\CodeGenerator;
use Magento\Framework\Code\Generator\EntityAbstract;
use Magento\Framework\Code\Generator\Io;
-use Magento\Framework\ObjectManager\Config as ObjectManagerConfig;
+use Magento\Framework\ObjectManager\ConfigInterface as ObjectManagerConfig;
use Zend\Code\Reflection\ClassReflection;
/**
@@ -64,31 +63,6 @@ class DataBuilder extends EntityAbstract
/** @var string[] */
protected $extensibleInterfaceMethods;
- /**
- * Initialize dependencies.
- *
- * @param string|null $sourceClassName
- * @param string|null $resultClassName
- * @param Io|null $ioObject
- * @param CodeGenerator\CodeGeneratorInterface|null $classGenerator
- * @param FileResolver|null $fileResolver
- */
- public function __construct(
- $sourceClassName = null,
- $resultClassName = null,
- Io $ioObject = null,
- CodeGenerator\CodeGeneratorInterface $classGenerator = null,
- FileResolver $fileResolver = null
- ) {
- parent::__construct(
- $sourceClassName,
- $resultClassName,
- $ioObject,
- $classGenerator,
- $fileResolver
- );
- }
-
/**
* Retrieve class properties
*
@@ -115,7 +89,7 @@ class DataBuilder extends EntityAbstract
['name' => 'objectProcessor', 'type' => '\Magento\Framework\Reflection\DataObjectProcessor'],
['name' => 'typeProcessor', 'type' => '\Magento\Framework\Reflection\TypeProcessor'],
['name' => 'dataBuilderFactory', 'type' => '\Magento\Framework\Serialization\DataBuilderFactory'],
- ['name' => 'objectManagerConfig', 'type' => '\Magento\Framework\ObjectManager\Config'],
+ ['name' => 'objectManagerConfig', 'type' => '\Magento\Framework\ObjectManager\ConfigInterface'],
[
'name' => 'modelClassInterface',
'type' => 'string',
@@ -151,7 +125,7 @@ class DataBuilder extends EntityAbstract
],
[
'name' => 'param',
- 'description' => '\Magento\Framework\ObjectManager\Config $objectManagerConfig'
+ 'description' => '\Magento\Framework\ObjectManager\ConfigInterface $objectManagerConfig'
],
[
'name' => 'param',
diff --git a/lib/internal/Magento/Framework/Api/CriteriaInterface.php b/lib/internal/Magento/Framework/Api/CriteriaInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..b3f9096e1e1b103b18093076ae6bbc5b3dfd3f03
--- /dev/null
+++ b/lib/internal/Magento/Framework/Api/CriteriaInterface.php
@@ -0,0 +1,200 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Api;
+
+/**
+ * Interface CriteriaInterface
+ */
+interface CriteriaInterface
+{
+ const PART_FIELDS = 'fields';
+ const PART_FILTERS = 'filters';
+ const PART_ORDERS = 'orders';
+ const PART_CRITERIA_LIST = 'criteria_list';
+ const PART_LIMIT = 'limit';
+
+ const SORT_ORDER_ASC = 'ASC';
+ const SORT_ORDER_DESC = 'DESC';
+
+ /**
+ * Get associated Mapper Interface name
+ *
+ * @return string
+ */
+ public function getMapperInterfaceName();
+
+ /**
+ * Add field to select
+ *
+ * @param string|array $field
+ * @param string|null $alias
+ * @return void
+ */
+ public function addField($field, $alias = null);
+
+ /**
+ * Add field filter to collection
+ *
+ * If $condition integer or string - exact value will be filtered ('eq' condition)
+ *
+ * If $condition is array - one of the following structures is expected:
+ * <pre>
+ * - ["from" => $fromValue, "to" => $toValue]
+ * - ["eq" => $equalValue]
+ * - ["neq" => $notEqualValue]
+ * - ["like" => $likeValue]
+ * - ["in" => [$inValues]]
+ * - ["nin" => [$notInValues]]
+ * - ["notnull" => $valueIsNotNull]
+ * - ["null" => $valueIsNull]
+ * - ["moreq" => $moreOrEqualValue]
+ * - ["gt" => $greaterValue]
+ * - ["lt" => $lessValue]
+ * - ["gteq" => $greaterOrEqualValue]
+ * - ["lteq" => $lessOrEqualValue]
+ * - ["finset" => $valueInSet]
+ * </pre>
+ *
+ * If non matched - sequential parallel arrays are expected and OR conditions
+ * will be built using above mentioned structure.
+ *
+ * Example:
+ * <pre>
+ * $field = ['age', 'name'];
+ * $condition = [42, ['like' => 'Mage']];
+ * $type = 'or';
+ * </pre>
+ * The above would find where age equal to 42 OR name like %Mage%.
+ *
+ * @param string $name
+ * @param string|array $field
+ * @param string|int|array $condition
+ * @param string $type
+ * @throws \Magento\Framework\Exception if some error in the input could be detected.
+ * @return void
+ */
+ public function addFilter($name, $field, $condition = null, $type = 'and');
+
+ /**
+ * self::setOrder() alias
+ *
+ * @param string $field
+ * @param string $direction
+ * @param bool $unShift
+ * @return void
+ */
+ public function addOrder($field, $direction = self::SORT_ORDER_DESC, $unShift = false);
+
+ /**
+ * Set Query limit
+ *
+ * @param int $offset
+ * @param int $size
+ * @return void
+ */
+ public function setLimit($offset, $size);
+
+ /**
+ * Removes field from select
+ *
+ * @param string|null $field
+ * @param bool $isAlias Alias identifier
+ * @return void
+ */
+ public function removeField($field, $isAlias = false);
+
+ /**
+ * Removes all fields from select
+ *
+ * @return void
+ */
+ public function removeAllFields();
+
+ /**
+ * Removes filter by name
+ *
+ * @param string $name
+ * @return void
+ */
+ public function removeFilter($name);
+
+ /**
+ * Removes all filters
+ *
+ * @return void
+ */
+ public function removeAllFilters();
+
+ /**
+ * Get Criteria objects added to current Composite Criteria
+ *
+ * @return \Magento\Framework\Api\CriteriaInterface[]
+ */
+ public function getCriteriaList();
+
+ /**
+ * Get list of filters
+ *
+ * @return string[]
+ */
+ public function getFilters();
+
+ /**
+ * Get ordering criteria
+ *
+ * @return string[]
+ */
+ public function getOrders();
+
+ /**
+ * Get limit
+ * (['offset', 'page'])
+ *
+ * @return string[]
+ */
+ public function getLimit();
+
+ /**
+ * Retrieve criteria part
+ *
+ * @param string $name
+ * @param mixed $default
+ * @return mixed
+ */
+ public function getPart($name, $default = null);
+
+ /**
+ * Return all criteria parts as array
+ *
+ * @return array
+ */
+ public function toArray();
+
+ /**
+ * Reset criteria
+ *
+ * @return void
+ */
+ public function reset();
+}
diff --git a/lib/internal/Magento/Framework/Api/ObjectFactory.php b/lib/internal/Magento/Framework/Api/ObjectFactory.php
index 6612b333e05dcf601fb3bc3aaadb3169ba2e61e1..b5f6b7bc1cdfb0d811afa4e985a69c4920efd3c6 100644
--- a/lib/internal/Magento/Framework/Api/ObjectFactory.php
+++ b/lib/internal/Magento/Framework/Api/ObjectFactory.php
@@ -27,14 +27,14 @@ namespace Magento\Framework\Api;
class ObjectFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Api/Search/FilterGroupBuilder.php b/lib/internal/Magento/Framework/Api/Search/FilterGroupBuilder.php
index 21798355167e88bc4499cc24e73870c6d3f87629..96db8ffb124cd64d0b0dcc30734e7f445f45d864 100644
--- a/lib/internal/Magento/Framework/Api/Search/FilterGroupBuilder.php
+++ b/lib/internal/Magento/Framework/Api/Search/FilterGroupBuilder.php
@@ -47,7 +47,7 @@ class FilterGroupBuilder extends Builder
* @param \Magento\Framework\Reflection\DataObjectProcessor $objectProcessor
* @param \Magento\Framework\Reflection\TypeProcessor $typeProcessor
* @param \Magento\Framework\Serialization\DataBuilderFactory $dataBuilderFactory
- * @param \Magento\Framework\ObjectManager\Config $objectManagerConfig
+ * @param \Magento\Framework\ObjectManager\ConfigInterface $objectManagerConfig
* @param FilterBuilder $filterBuilder
* @param string|null $modelClassInterface
*/
@@ -58,7 +58,7 @@ class FilterGroupBuilder extends Builder
\Magento\Framework\Reflection\DataObjectProcessor $objectProcessor,
\Magento\Framework\Reflection\TypeProcessor $typeProcessor,
\Magento\Framework\Serialization\DataBuilderFactory $dataBuilderFactory,
- \Magento\Framework\ObjectManager\Config $objectManagerConfig,
+ \Magento\Framework\ObjectManager\ConfigInterface $objectManagerConfig,
FilterBuilder $filterBuilder,
$modelClassInterface = null
) {
diff --git a/lib/internal/Magento/Framework/Api/SearchCriteriaBuilder.php b/lib/internal/Magento/Framework/Api/SearchCriteriaBuilder.php
index 2521a8d8d0086d07a0b6a641a0c1f753b0cd596d..a009426411c462f9a069616e8b649bc7a298cfbd 100644
--- a/lib/internal/Magento/Framework/Api/SearchCriteriaBuilder.php
+++ b/lib/internal/Magento/Framework/Api/SearchCriteriaBuilder.php
@@ -43,7 +43,7 @@ class SearchCriteriaBuilder extends Builder
* @param \Magento\Framework\Reflection\DataObjectProcessor $objectProcessor
* @param \Magento\Framework\Reflection\TypeProcessor $typeProcessor
* @param \Magento\Framework\Serialization\DataBuilderFactory $dataBuilderFactory
- * @param \Magento\Framework\ObjectManager\Config $objectManagerConfig
+ * @param \Magento\Framework\ObjectManager\ConfigInterface $objectManagerConfig
* @param FilterGroupBuilder $filterGroupBuilder
* @param string|null $modelClassInterface
*/
@@ -54,7 +54,7 @@ class SearchCriteriaBuilder extends Builder
\Magento\Framework\Reflection\DataObjectProcessor $objectProcessor,
\Magento\Framework\Reflection\TypeProcessor $typeProcessor,
\Magento\Framework\Serialization\DataBuilderFactory $dataBuilderFactory,
- \Magento\Framework\ObjectManager\Config $objectManagerConfig,
+ \Magento\Framework\ObjectManager\ConfigInterface $objectManagerConfig,
FilterGroupBuilder $filterGroupBuilder,
$modelClassInterface = null
) {
diff --git a/lib/internal/Magento/Framework/App/Action/Action.php b/lib/internal/Magento/Framework/App/Action/Action.php
index 6dc3b2649dc2adb61f94961b654fdba5be0dbda7..54a641a22a774ad65d2fb30f6b6a8863bb526664 100644
--- a/lib/internal/Magento/Framework/App/Action/Action.php
+++ b/lib/internal/Magento/Framework/App/Action/Action.php
@@ -34,7 +34,7 @@ use Magento\Framework\App\ResponseInterface;
class Action extends AbstractAction
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
diff --git a/lib/internal/Magento/Framework/App/Action/Context.php b/lib/internal/Magento/Framework/App/Action/Context.php
index 23250cb337932a77aae0e14a88c860cb5fa16ed4..474b2bb4ade6c9178e47ab03a227c165eb42068b 100644
--- a/lib/internal/Magento/Framework/App/Action/Context.php
+++ b/lib/internal/Magento/Framework/App/Action/Context.php
@@ -36,7 +36,7 @@ class Context implements \Magento\Framework\ObjectManager\ContextInterface
protected $_response;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -73,7 +73,7 @@ class Context implements \Magento\Framework\ObjectManager\ContextInterface
/**
* @param \Magento\Framework\App\RequestInterface $request
* @param \Magento\Framework\App\ResponseInterface $response
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Event\ManagerInterface $eventManager
* @param \Magento\Framework\UrlInterface $url
* @param \Magento\Framework\App\Response\RedirectInterface $redirect
@@ -86,7 +86,7 @@ class Context implements \Magento\Framework\ObjectManager\ContextInterface
public function __construct(
\Magento\Framework\App\RequestInterface $request,
\Magento\Framework\App\ResponseInterface $response,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Event\ManagerInterface $eventManager,
\Magento\Framework\UrlInterface $url,
\Magento\Framework\App\Response\RedirectInterface $redirect,
@@ -130,7 +130,7 @@ class Context implements \Magento\Framework\ObjectManager\ContextInterface
}
/**
- * @return \Magento\Framework\ObjectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*/
public function getObjectManager()
{
diff --git a/lib/internal/Magento/Framework/App/ActionFactory.php b/lib/internal/Magento/Framework/App/ActionFactory.php
index 4f8ecbefd5e2c37fd0c7e8168ee9d766068cd307..6f2973c1310f70d53205ebff48eda3d6565966f9 100644
--- a/lib/internal/Magento/Framework/App/ActionFactory.php
+++ b/lib/internal/Magento/Framework/App/ActionFactory.php
@@ -28,14 +28,14 @@ namespace Magento\Framework\App;
class ActionFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/App/Area.php b/lib/internal/Magento/Framework/App/Area.php
index 3627f51ed349545ee19be9fcb330aaaeb697ae53..037c5d400767720c8f9a82e74ba2edb152532266 100644
--- a/lib/internal/Magento/Framework/App/Area.php
+++ b/lib/internal/Magento/Framework/App/Area.php
@@ -71,7 +71,7 @@ class Area implements \Magento\Framework\App\AreaInterface
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -106,7 +106,7 @@ class Area implements \Magento\Framework\App\AreaInterface
* @param \Magento\Framework\Logger $logger
* @param \Magento\Framework\Event\ManagerInterface $eventManager
* @param \Magento\Framework\TranslateInterface $translator
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\App\ObjectManager\ConfigLoader $diConfigLoader
* @param \Magento\Framework\App\DesignInterface $design
* @param \Magento\Framework\App\ScopeResolverInterface $scopeResolver
@@ -117,7 +117,7 @@ class Area implements \Magento\Framework\App\AreaInterface
\Magento\Framework\Logger $logger,
\Magento\Framework\Event\ManagerInterface $eventManager,
\Magento\Framework\TranslateInterface $translator,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\App\ObjectManager\ConfigLoader $diConfigLoader,
\Magento\Framework\App\DesignInterface $design,
\Magento\Framework\App\ScopeResolverInterface $scopeResolver,
diff --git a/lib/internal/Magento/Framework/App/Area/FrontNameResolverFactory.php b/lib/internal/Magento/Framework/App/Area/FrontNameResolverFactory.php
index 2cbd1cfdf139c9821931e4f48b71708b3bbba3e8..6b563c5968cae232c8eeeb4fd2024f7540ce4e59 100644
--- a/lib/internal/Magento/Framework/App/Area/FrontNameResolverFactory.php
+++ b/lib/internal/Magento/Framework/App/Area/FrontNameResolverFactory.php
@@ -28,14 +28,14 @@ namespace Magento\Framework\App\Area;
class FrontNameResolverFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/App/AreaList.php b/lib/internal/Magento/Framework/App/AreaList.php
index 5e719c58d35aff8c2f162196f5ea64dbdb7eae72..f1159bd4c33e8c5fbdf4a7bfb8cdd36a7f1b520b 100644
--- a/lib/internal/Magento/Framework/App/AreaList.php
+++ b/lib/internal/Magento/Framework/App/AreaList.php
@@ -50,18 +50,18 @@ class AreaList
protected $_resolverFactory;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param Area\FrontNameResolverFactory $resolverFactory
* @param array $areas
* @param string $default
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
Area\FrontNameResolverFactory $resolverFactory,
array $areas,
$default
diff --git a/lib/internal/Magento/Framework/App/AreaList/Proxy.php b/lib/internal/Magento/Framework/App/AreaList/Proxy.php
index 5f0f968da1d2b76624b1cf0c55ddfaeb958b8cdc..9deeb91ca5444c89fbebde76923f020a5c8e21cc 100644
--- a/lib/internal/Magento/Framework/App/AreaList/Proxy.php
+++ b/lib/internal/Magento/Framework/App/AreaList/Proxy.php
@@ -30,7 +30,7 @@ class Proxy extends \Magento\Framework\App\AreaList
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -58,12 +58,12 @@ class Proxy extends \Magento\Framework\App\AreaList
/**
* Proxy constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
* @param bool $shared
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\App\AreaList',
$shared = true
) {
diff --git a/lib/internal/Magento/Framework/App/Bootstrap.php b/lib/internal/Magento/Framework/App/Bootstrap.php
index 86b601cf4ed4c84d7d095afb568fb87eb9669459..dd27eae1492de23b06ab169b82d7b5e64adaf7f8 100644
--- a/lib/internal/Magento/Framework/App/Bootstrap.php
+++ b/lib/internal/Magento/Framework/App/Bootstrap.php
@@ -25,6 +25,8 @@
namespace Magento\Framework\App;
use Magento\Framework\App\Filesystem\DirectoryList;
+use Magento\Framework\Autoload\AutoloaderRegistry;
+use Magento\Framework\Autoload\Populator;
use Magento\Framework\Filesystem\DriverPool;
use Magento\Framework\Profiler;
use Magento\Framework\AppInterface;
@@ -96,7 +98,7 @@ class Bootstrap
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
@@ -138,12 +140,27 @@ class Bootstrap
*/
public static function create($rootDir, array $initParams, ObjectManagerFactory $factory = null)
{
+ self::populateAutoloader($rootDir, $initParams);
if ($factory === null) {
$factory = self::createObjectManagerFactory($rootDir, $initParams);
}
return new self($factory, $rootDir, $initParams);
}
+ /**
+ * Populates autoloader with mapping info
+ *
+ * @param string $rootDir
+ * @param array $initParams
+ * @return void
+ */
+ public static function populateAutoloader($rootDir, $initParams)
+ {
+ $dirList = self::createFilesystemDirectoryList($rootDir, $initParams);
+ $autoloadWrapper = AutoloaderRegistry::getAutoloader();
+ Populator::populateMappings($autoloadWrapper, $dirList);
+ }
+
/**
* Creates instance of object manager factory
*
@@ -346,7 +363,7 @@ class Bootstrap
/**
* Gets the object manager instance
*
- * @return \Magento\Framework\ObjectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*/
public function getObjectManager()
{
diff --git a/lib/internal/Magento/Framework/App/Cache/Frontend/Factory.php b/lib/internal/Magento/Framework/App/Cache/Frontend/Factory.php
index 38998521099c13c58884e49bfb7689aa44e4e08a..854089477715369306f4a990c6d86d6a04ada10a 100644
--- a/lib/internal/Magento/Framework/App/Cache/Frontend/Factory.php
+++ b/lib/internal/Magento/Framework/App/Cache/Frontend/Factory.php
@@ -42,7 +42,7 @@ class Factory
const PARAM_CACHE_FORCED_OPTIONS = 'cache_options';
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
@@ -95,14 +95,14 @@ class Factory
protected $_resource;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param Filesystem $filesystem
* @param \Magento\Framework\App\Resource $resource
* @param array $enforcedOptions
* @param array $decorators
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
Filesystem $filesystem,
\Magento\Framework\App\Resource $resource,
array $enforcedOptions = array(),
diff --git a/lib/internal/Magento/Framework/App/Cache/InstanceFactory.php b/lib/internal/Magento/Framework/App/Cache/InstanceFactory.php
index e15f511c45b0dc3ff80b615795d80e7a157f68fb..543eec81989c8255420c17ffe402f7c628c6731c 100644
--- a/lib/internal/Magento/Framework/App/Cache/InstanceFactory.php
+++ b/lib/internal/Magento/Framework/App/Cache/InstanceFactory.php
@@ -26,14 +26,14 @@ namespace Magento\Framework\App\Cache;
class InstanceFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/App/Cache/Proxy.php b/lib/internal/Magento/Framework/App/Cache/Proxy.php
index 490ee97144533077659c4ea94be97a1cf0ea8077..642e3bb51efe5dd18f793150beda3158afc2acd0 100644
--- a/lib/internal/Magento/Framework/App/Cache/Proxy.php
+++ b/lib/internal/Magento/Framework/App/Cache/Proxy.php
@@ -32,7 +32,7 @@ use Magento\Framework\App\CacheInterface;
class Proxy implements CacheInterface
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -42,9 +42,9 @@ class Proxy implements CacheInterface
protected $_cache;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/App/Cache/Type/FrontendPool.php b/lib/internal/Magento/Framework/App/Cache/Type/FrontendPool.php
index 6f3c313d757b2d046b560beafbf3f149daf292cd..2939324b05713cdbc4960cdb4639578f2e97284a 100644
--- a/lib/internal/Magento/Framework/App/Cache/Type/FrontendPool.php
+++ b/lib/internal/Magento/Framework/App/Cache/Type/FrontendPool.php
@@ -29,7 +29,7 @@ namespace Magento\Framework\App\Cache\Type;
class FrontendPool
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
@@ -54,13 +54,13 @@ class FrontendPool
private $_instances = array();
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\App\Arguments $arguments
* @param \Magento\Framework\App\Cache\Frontend\Pool $frontendPool
* @param array $typeFrontendMap Format: array('<cache_type_id>' => '<cache_frontend_id>', ...)
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\App\Arguments $arguments,
\Magento\Framework\App\Cache\Frontend\Pool $frontendPool,
array $typeFrontendMap = array()
diff --git a/lib/internal/Magento/Framework/App/Config/BaseFactory.php b/lib/internal/Magento/Framework/App/Config/BaseFactory.php
index 41f230b3d11a62e05b6c824a1d7e894e1a379ed2..4e8d41c164c76a674f34c87ad367ad9c243ae28a 100644
--- a/lib/internal/Magento/Framework/App/Config/BaseFactory.php
+++ b/lib/internal/Magento/Framework/App/Config/BaseFactory.php
@@ -28,14 +28,14 @@ namespace Magento\Framework\App\Config;
class BaseFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/App/Config/Data/ProcessorFactory.php b/lib/internal/Magento/Framework/App/Config/Data/ProcessorFactory.php
index 944ffed168da937e047b914974ae807a61b745d5..efc6ffa7c8ccfd33b1eaf83787d73c77d5ebf21b 100644
--- a/lib/internal/Magento/Framework/App/Config/Data/ProcessorFactory.php
+++ b/lib/internal/Magento/Framework/App/Config/Data/ProcessorFactory.php
@@ -28,7 +28,7 @@ namespace Magento\Framework\App\Config\Data;
class ProcessorFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -38,9 +38,9 @@ class ProcessorFactory
protected $_pool;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/App/Config/DataFactory.php b/lib/internal/Magento/Framework/App/Config/DataFactory.php
index 73a3de7b62790f0f4070eac2d2360658c2eab0fa..b0a4fb1f33fc75f62428da0efc8b66f47f96b99e 100644
--- a/lib/internal/Magento/Framework/App/Config/DataFactory.php
+++ b/lib/internal/Magento/Framework/App/Config/DataFactory.php
@@ -30,7 +30,7 @@ class DataFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -42,11 +42,11 @@ class DataFactory
protected $_instanceName = null;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\App\Config\Data'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/App/Config/ValueFactory.php b/lib/internal/Magento/Framework/App/Config/ValueFactory.php
index ee06cd1a7ecc1911acb971d4144fa6e7c94d4918..f6d2bad2b55468592f969c566f833dd585907c04 100644
--- a/lib/internal/Magento/Framework/App/Config/ValueFactory.php
+++ b/lib/internal/Magento/Framework/App/Config/ValueFactory.php
@@ -31,7 +31,7 @@ class ValueFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -45,11 +45,11 @@ class ValueFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\App\Config\ValueInterface'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/App/Helper/AbstractHelper.php b/lib/internal/Magento/Framework/App/Helper/AbstractHelper.php
index 1703cc1ed9e8dd5e0dad2a7e18804062864a2b59..51a703113e0fdf45a0c602eb65f7a25e6c31aa1d 100644
--- a/lib/internal/Magento/Framework/App/Helper/AbstractHelper.php
+++ b/lib/internal/Magento/Framework/App/Helper/AbstractHelper.php
@@ -81,6 +81,16 @@ abstract class AbstractHelper
*/
protected $_remoteAddress;
+ /**
+ * @var \Magento\Framework\Url\EncoderInterface
+ */
+ protected $urlEncoder;
+
+ /**
+ * @var \Magento\Framework\Url\DecoderInterface
+ */
+ protected $urlDecoder;
+
/**
* @param Context $context
*/
@@ -95,6 +105,8 @@ abstract class AbstractHelper
$this->_eventManager = $context->getEventManager();
$this->_remoteAddress = $context->getRemoteAddress();
$this->_cacheConfig = $context->getCacheConfig();
+ $this->urlEncoder = $context->getUrlEncoder();
+ $this->urlDecoder = $context->getUrlDecoder();
}
/**
@@ -166,23 +178,24 @@ abstract class AbstractHelper
/**
* base64_encode() for URLs encoding
*
+ * @deprecated use \Magento\Framework\Url\EncoderInterface
* @param string $url
* @return string
*/
public function urlEncode($url)
{
- return strtr(base64_encode($url), '+/=', '-_,');
+ return $this->urlEncoder->encode($url);
}
/**
* base64_decode() for URLs decoding
*
+ * @deprecated use \Magento\Framework\Url\DecoderInterface
* @param string $url
* @return string
*/
public function urlDecode($url)
{
- $url = base64_decode(strtr($url, '-_,', '+/='));
- return $this->_urlBuilder->sessionUrlVar($url);
+ return $this->urlDecoder->decode($url);
}
}
diff --git a/lib/internal/Magento/Framework/App/Helper/Context.php b/lib/internal/Magento/Framework/App/Helper/Context.php
index 60b9281b4d9ec11ff79d51e5926be0ba6ac2cb2d..e5c4e67d61cf5b513f93d0c0f6b95c0b344bbf2d 100644
--- a/lib/internal/Magento/Framework/App/Helper/Context.php
+++ b/lib/internal/Magento/Framework/App/Helper/Context.php
@@ -73,6 +73,18 @@ class Context implements \Magento\Framework\ObjectManager\ContextInterface
protected $_remoteAddress;
/**
+ * @var \Magento\Framework\Url\EncoderInterface
+ */
+ protected $urlEncoder;
+
+ /**
+ * @var \Magento\Framework\Url\DecoderInterface
+ */
+ protected $urlDecoder;
+
+ /**
+ * @param \Magento\Framework\Url\EncoderInterface $urlEncoder
+ * @param \Magento\Framework\Url\DecoderInterface $urlDecoder
* @param \Magento\Framework\Logger $logger
* @param \Magento\Framework\Translate\InlineInterface $translateInline
* @param \Magento\Framework\Module\Manager $moduleManager
@@ -86,6 +98,8 @@ class Context implements \Magento\Framework\ObjectManager\ContextInterface
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function __construct(
+ \Magento\Framework\Url\EncoderInterface $urlEncoder,
+ \Magento\Framework\Url\DecoderInterface $urlDecoder,
\Magento\Framework\Logger $logger,
\Magento\Framework\Translate\InlineInterface $translateInline,
\Magento\Framework\Module\Manager $moduleManager,
@@ -105,6 +119,8 @@ class Context implements \Magento\Framework\ObjectManager\ContextInterface
$this->_urlBuilder = $urlBuilder;
$this->_httpHeader = $httpHeader;
$this->_remoteAddress = $remoteAddress;
+ $this->urlEncoder = $urlEncoder;
+ $this->urlDecoder = $urlDecoder;
}
/**
@@ -178,4 +194,20 @@ class Context implements \Magento\Framework\ObjectManager\ContextInterface
{
return $this->_remoteAddress;
}
+
+ /**
+ * @return \Magento\Framework\Url\EncoderInterface
+ */
+ public function getUrlEncoder()
+ {
+ return $this->urlEncoder;
+ }
+
+ /**
+ * @return \Magento\Framework\Url\DecoderInterface
+ */
+ public function getUrlDecoder()
+ {
+ return $this->urlDecoder;
+ }
}
diff --git a/lib/internal/Magento/Framework/App/Http.php b/lib/internal/Magento/Framework/App/Http.php
index f3c04a4dd39cfcba956859de5113583bddb3559f..c9bd745b3733e4c2f9d570e159aafb38fa2c94d3 100644
--- a/lib/internal/Magento/Framework/App/Http.php
+++ b/lib/internal/Magento/Framework/App/Http.php
@@ -48,7 +48,7 @@ class Http implements \Magento\Framework\AppInterface
/**#@-*/
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -88,7 +88,7 @@ class Http implements \Magento\Framework\AppInterface
protected $_response;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param Event\Manager $eventManager
* @param AreaList $areaList
* @param RequestHttp $request
@@ -98,7 +98,7 @@ class Http implements \Magento\Framework\AppInterface
* @param Filesystem $filesystem
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
Event\Manager $eventManager,
AreaList $areaList,
RequestHttp $request,
diff --git a/lib/internal/Magento/Framework/App/Language/ConfigFactory.php b/lib/internal/Magento/Framework/App/Language/ConfigFactory.php
index ae60f01cd770539b5e895a225c9a05a915ffb5db..b10e6cc80eca983ba9ae2079b9fba2e7525aa39b 100644
--- a/lib/internal/Magento/Framework/App/Language/ConfigFactory.php
+++ b/lib/internal/Magento/Framework/App/Language/ConfigFactory.php
@@ -31,14 +31,14 @@ namespace Magento\Framework\App\Language;
class ConfigFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/App/ObjectManager.php b/lib/internal/Magento/Framework/App/ObjectManager.php
index bce5edd10c34cf228b347c0da355706dbb198495..849829522dff7f2e995331248d4fcbc6166ab65b 100644
--- a/lib/internal/Magento/Framework/App/ObjectManager.php
+++ b/lib/internal/Magento/Framework/App/ObjectManager.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\App;
-use Magento\Framework\ObjectManager\Factory;
+use Magento\Framework\ObjectManager\FactoryInterface;
/**
* A wrapper around object manager with workarounds to access it in client code
@@ -48,7 +48,7 @@ class ObjectManager extends \Magento\Framework\ObjectManager\ObjectManager
*/
public static function getInstance()
{
- if (!self::$_instance instanceof \Magento\Framework\ObjectManager) {
+ if (!self::$_instance instanceof \Magento\Framework\ObjectManagerInterface) {
throw new \RuntimeException('ObjectManager isn\'t initialized');
}
return self::$_instance;
@@ -57,23 +57,23 @@ class ObjectManager extends \Magento\Framework\ObjectManager\ObjectManager
/**
* Set object manager instance
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @throws \LogicException
* @return void
*/
- public static function setInstance(\Magento\Framework\ObjectManager $objectManager)
+ public static function setInstance(\Magento\Framework\ObjectManagerInterface $objectManager)
{
self::$_instance = $objectManager;
}
/**
- * @param Factory $factory
- * @param \Magento\Framework\ObjectManager\Config $config
+ * @param FactoryInterface $factory
+ * @param \Magento\Framework\ObjectManager\ConfigInterface $config
* @param array $sharedInstances
*/
public function __construct(
- Factory $factory,
- \Magento\Framework\ObjectManager\Config $config,
+ FactoryInterface $factory,
+ \Magento\Framework\ObjectManager\ConfigInterface $config,
array $sharedInstances = array()
) {
parent::__construct($factory, $config, $sharedInstances);
diff --git a/lib/internal/Magento/Framework/App/ObjectManager/ConfigCache.php b/lib/internal/Magento/Framework/App/ObjectManager/ConfigCache.php
index f59442e96bae3f4df72cf8587fb335b1ec339876..a8a82056b78ea215ed37632ef7393361346e9a05 100644
--- a/lib/internal/Magento/Framework/App/ObjectManager/ConfigCache.php
+++ b/lib/internal/Magento/Framework/App/ObjectManager/ConfigCache.php
@@ -25,7 +25,7 @@
*/
namespace Magento\Framework\App\ObjectManager;
-class ConfigCache implements \Magento\Framework\ObjectManager\ConfigCache
+class ConfigCache implements \Magento\Framework\ObjectManager\ConfigCacheInterface
{
/**
* @var \Magento\Framework\Cache\FrontendInterface
diff --git a/lib/internal/Magento/Framework/App/ObjectManagerFactory.php b/lib/internal/Magento/Framework/App/ObjectManagerFactory.php
index e9ed588bfcb2948b63997a91ae1f4f1c53614569..2e2baeba836843ec97ff1c07a47acfd0288ceffc 100644
--- a/lib/internal/Magento/Framework/App/ObjectManagerFactory.php
+++ b/lib/internal/Magento/Framework/App/ObjectManagerFactory.php
@@ -27,7 +27,6 @@ namespace Magento\Framework\App;
use Magento\Framework\App\Filesystem\DirectoryList;
use Magento\Framework\Profiler;
-use Magento\Framework\Code\Generator\FileResolver;
use Magento\Framework\Filesystem\DriverPool;
/**
@@ -67,7 +66,7 @@ class ObjectManagerFactory
/**
* Factory
*
- * @var \Magento\Framework\ObjectManager\Factory
+ * @var \Magento\Framework\ObjectManager\FactoryInterface
*/
protected $factory;
@@ -88,14 +87,12 @@ class ObjectManagerFactory
*
* @param array $arguments
* @param bool $useCompiled
- * @return \Magento\Framework\ObjectManager
+ * @return \Magento\Framework\ObjectManagerInterface
*
* @SuppressWarnings(PHPMD.NPathComplexity)
*/
public function create(array $arguments, $useCompiled = true)
{
- FileResolver::addIncludePath($this->directoryList->getPath(DirectoryList::GENERATION));
-
$appArguments = $this->createAppArguments($this->directoryList, $arguments);
$definitionFactory = new \Magento\Framework\ObjectManager\DefinitionFactory(
@@ -142,17 +139,17 @@ class ObjectManagerFactory
'Magento\Framework\App\Filesystem\DirectoryList' => $this->directoryList,
'Magento\Framework\Filesystem\DirectoryList' => $this->directoryList,
'Magento\Framework\Filesystem\DriverPool' => $this->driverPool,
- 'Magento\Framework\ObjectManager\Relations' => $relations,
- 'Magento\Framework\Interception\Definition' => $definitionFactory->createPluginDefinition(),
- 'Magento\Framework\ObjectManager\Config' => $diConfig,
- 'Magento\Framework\ObjectManager\Definition' => $definitions,
+ 'Magento\Framework\ObjectManager\RelationsInterface' => $relations,
+ 'Magento\Framework\Interception\DefinitionInterface' => $definitionFactory->createPluginDefinition(),
+ 'Magento\Framework\ObjectManager\ConfigInterface' => $diConfig,
+ 'Magento\Framework\ObjectManager\DefinitionInterface' => $definitions,
'Magento\Framework\Stdlib\BooleanUtils' => $booleanUtils,
'Magento\Framework\ObjectManager\Config\Mapper\Dom' => $argumentMapper,
$configClass => $diConfig
];
$className = $this->_locatorClassName;
- /** @var \Magento\Framework\ObjectManager $objectManager */
+ /** @var \Magento\Framework\ObjectManagerInterface $objectManager */
$objectManager = new $className($this->factory, $diConfig, $sharedInstances);
$this->factory->setObjectManager($objectManager);
@@ -259,19 +256,19 @@ class ObjectManagerFactory
/**
* Crete plugin list object
*
- * @param \Magento\Framework\ObjectManager $objectManager
- * @param \Magento\Framework\ObjectManager\Relations $relations
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
+ * @param \Magento\Framework\ObjectManager\RelationsInterface $relations
* @param \Magento\Framework\ObjectManager\DefinitionFactory $definitionFactory
* @param \Magento\Framework\ObjectManager\Config\Config $diConfig
- * @param \Magento\Framework\ObjectManager\Definition $definitions
+ * @param \Magento\Framework\ObjectManager\DefinitionInterface $definitions
* @return \Magento\Framework\Interception\PluginList\PluginList
*/
protected function _createPluginList(
- \Magento\Framework\ObjectManager $objectManager,
- \Magento\Framework\ObjectManager\Relations $relations,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
+ \Magento\Framework\ObjectManager\RelationsInterface $relations,
\Magento\Framework\ObjectManager\DefinitionFactory $definitionFactory,
\Magento\Framework\ObjectManager\Config\Config $diConfig,
- \Magento\Framework\ObjectManager\Definition $definitions
+ \Magento\Framework\ObjectManager\DefinitionInterface $definitions
) {
return $objectManager->create(
'Magento\Framework\Interception\PluginList\PluginList',
diff --git a/lib/internal/Magento/Framework/App/PageCache/FormKey.php b/lib/internal/Magento/Framework/App/PageCache/FormKey.php
index dfbf440fc4cdd50b0df721c2196e24e9cdfdd878..13d18afc69288b4757223777c4a08709c3615b22 100644
--- a/lib/internal/Magento/Framework/App/PageCache/FormKey.php
+++ b/lib/internal/Magento/Framework/App/PageCache/FormKey.php
@@ -37,15 +37,15 @@ class FormKey
/**
* CookieManager
*
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $cookieManager;
/**
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
*/
public function __construct(
- \Magento\Framework\Stdlib\CookieManager $cookieManager
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
) {
$this->cookieManager = $cookieManager;
}
diff --git a/lib/internal/Magento/Framework/App/PageCache/Version.php b/lib/internal/Magento/Framework/App/PageCache/Version.php
index e593e82b500cf63e6e0b0db5357a0f0bf6a0e301..77a82fcb9f3d6d8e3707cf85b50cb446049f0ad6 100644
--- a/lib/internal/Magento/Framework/App/PageCache/Version.php
+++ b/lib/internal/Magento/Framework/App/PageCache/Version.php
@@ -42,7 +42,7 @@ class Version
/**
* Cookie Manager
*
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $cookieManager;
@@ -59,12 +59,12 @@ class Version
protected $cookieMetadataFactory;
/**
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
* @param \Magento\Framework\App\Request\Http $request
*/
public function __construct(
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory,
\Magento\Framework\App\Request\Http $request
) {
diff --git a/lib/internal/Magento/Framework/App/Request/Http.php b/lib/internal/Magento/Framework/App/Request/Http.php
index 87a52f5cc7d9006134046f58e52f2f097ad2ce01..3e1ede32401fdf58b73a50971c86fcaa6f237fc8 100644
--- a/lib/internal/Magento/Framework/App/Request/Http.php
+++ b/lib/internal/Magento/Framework/App/Request/Http.php
@@ -100,21 +100,21 @@ class Http extends \Zend_Controller_Request_Http implements \Magento\Framework\A
private $_pathInfoProcessor;
/**
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $_cookieManager;
/**
* @param \Magento\Framework\App\Route\ConfigInterface\Proxy $routeConfig
* @param PathInfoProcessorInterface $pathInfoProcessor
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param string $uri
* @param array $directFrontNames
*/
public function __construct(
\Magento\Framework\App\Route\ConfigInterface\Proxy $routeConfig,
PathInfoProcessorInterface $pathInfoProcessor,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
$uri = null,
$directFrontNames = array()
) {
diff --git a/lib/internal/Magento/Framework/App/RequestFactory.php b/lib/internal/Magento/Framework/App/RequestFactory.php
index 40e8c4911864541032c21bdc2fa2f0d40942788c..cee964b770fcfc8b03f743b40e03bdba29ad860b 100644
--- a/lib/internal/Magento/Framework/App/RequestFactory.php
+++ b/lib/internal/Magento/Framework/App/RequestFactory.php
@@ -28,14 +28,14 @@ namespace Magento\Framework\App;
class RequestFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/App/Resource/ConnectionFactory.php b/lib/internal/Magento/Framework/App/Resource/ConnectionFactory.php
index a2a305e40c47f439ce1aa55ae040847c2c792cce..752a1cfa20f8919c0fcd7f3ae32c8bea1015da3d 100644
--- a/lib/internal/Magento/Framework/App/Resource/ConnectionFactory.php
+++ b/lib/internal/Magento/Framework/App/Resource/ConnectionFactory.php
@@ -28,7 +28,7 @@ namespace Magento\Framework\App\Resource;
class ConnectionFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -38,11 +38,11 @@ class ConnectionFactory
protected $_localConfig;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\App\Arguments $localConfig
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\App\Arguments $localConfig
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/App/Response/Http.php b/lib/internal/Magento/Framework/App/Response/Http.php
index 28e5a33a17a19298d253d63b8628201b89257065..d953b59757da2a898ea741a0a3bc0e01418e8e1c 100644
--- a/lib/internal/Magento/Framework/App/Response/Http.php
+++ b/lib/internal/Magento/Framework/App/Response/Http.php
@@ -26,7 +26,7 @@
namespace Magento\Framework\App\Response;
use Magento\Framework\App\ObjectManager;
-use Magento\Framework\Stdlib\CookieManager;
+use Magento\Framework\Stdlib\CookieManagerInterface;
use Magento\Framework\Stdlib\Cookie\CookieMetadataFactory;
use Magento\Framework\App\Http\Context;
@@ -38,7 +38,7 @@ class Http extends \Zend_Controller_Response_Http implements HttpInterface
const COOKIE_VARY_STRING = 'X-Magento-Vary';
/**
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $cookieManager;
@@ -53,12 +53,12 @@ class Http extends \Zend_Controller_Response_Http implements HttpInterface
protected $context;
/**
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
* @param \Magento\Framework\App\Http\Context $context
*/
public function __construct(
- CookieManager $cookieManager,
+ CookieManagerInterface $cookieManager,
CookieMetadataFactory $cookieMetadataFactory,
Context $context
) {
@@ -194,7 +194,7 @@ class Http extends \Zend_Controller_Response_Http implements HttpInterface
public function __wakeup()
{
$objectManager = ObjectManager::getInstance();
- $this->cookieManager = $objectManager->create('Magento\Framework\Stdlib\CookieManager');
+ $this->cookieManager = $objectManager->create('Magento\Framework\Stdlib\CookieManagerInterface');
$this->cookieMetadataFactory = $objectManager->get('Magento\Framework\Stdlib\Cookie\CookieMetadataFactory');
}
}
diff --git a/lib/internal/Magento/Framework/App/ResponseFactory.php b/lib/internal/Magento/Framework/App/ResponseFactory.php
index 8fd9e49936ab8d7b8a76cb2fa16b0c0f74dba6c9..ae3b5864973050fbac9fdfc8650b0a9ba91d9335 100644
--- a/lib/internal/Magento/Framework/App/ResponseFactory.php
+++ b/lib/internal/Magento/Framework/App/ResponseFactory.php
@@ -28,14 +28,14 @@ namespace Magento\Framework\App;
class ResponseFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/App/Route/ConfigInterface/Proxy.php b/lib/internal/Magento/Framework/App/Route/ConfigInterface/Proxy.php
index 0d88852e5885a6df46e7139f84a997243e4d91aa..039d451a33836d0fb7af2db48ca8939eea86f7a9 100644
--- a/lib/internal/Magento/Framework/App/Route/ConfigInterface/Proxy.php
+++ b/lib/internal/Magento/Framework/App/Route/ConfigInterface/Proxy.php
@@ -33,7 +33,7 @@ class Proxy implements \Magento\Framework\App\Route\ConfigInterface
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -61,12 +61,12 @@ class Proxy implements \Magento\Framework\App\Route\ConfigInterface
/**
* Proxy constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
* @param bool $shared
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\App\Route\ConfigInterface',
$shared = true
) {
diff --git a/lib/internal/Magento/Framework/App/Router/NoRouteHandlerList.php b/lib/internal/Magento/Framework/App/Router/NoRouteHandlerList.php
index 4fd114757a7bc04ac87f6863edb733bc564785e7..50edf8d81e092777c1977e9bfac8059e42428e59 100644
--- a/lib/internal/Magento/Framework/App/Router/NoRouteHandlerList.php
+++ b/lib/internal/Magento/Framework/App/Router/NoRouteHandlerList.php
@@ -40,15 +40,15 @@ class NoRouteHandlerList
protected $_handlerList;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $handlerClassesList
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, array $handlerClassesList)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, array $handlerClassesList)
{
$this->_handlerList = $handlerClassesList;
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/App/RouterList.php b/lib/internal/Magento/Framework/App/RouterList.php
index 3a0ff4d1ffb923304452feca2a8780c6cc672c47..afee5154bd5df5eddea699ebf4a2e9d7a412cfba 100644
--- a/lib/internal/Magento/Framework/App/RouterList.php
+++ b/lib/internal/Magento/Framework/App/RouterList.php
@@ -29,7 +29,7 @@ namespace Magento\Framework\App;
class RouterList implements RouterListInterface
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -41,10 +41,10 @@ class RouterList implements RouterListInterface
protected $routerList;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $routerList
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, array $routerList)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, array $routerList)
{
$this->objectManager = $objectManager;
$this->routerList = $routerList;
diff --git a/lib/internal/Magento/Framework/App/StaticResource.php b/lib/internal/Magento/Framework/App/StaticResource.php
index c22c0f71910114c618cca173b98b2717b001e54d..1e0844278092b660a0fa3bf49acf6558319b7c8d 100644
--- a/lib/internal/Magento/Framework/App/StaticResource.php
+++ b/lib/internal/Magento/Framework/App/StaticResource.php
@@ -66,7 +66,7 @@ class StaticResource implements \Magento\Framework\AppInterface
private $moduleList;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
@@ -82,7 +82,7 @@ class StaticResource implements \Magento\Framework\AppInterface
* @param \Magento\Framework\App\View\Asset\Publisher $publisher
* @param \Magento\Framework\View\Asset\Repository $assetRepo
* @param \Magento\Framework\Module\ModuleList $moduleList
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param ObjectManager\ConfigLoader $configLoader
*/
public function __construct(
@@ -92,7 +92,7 @@ class StaticResource implements \Magento\Framework\AppInterface
View\Asset\Publisher $publisher,
\Magento\Framework\View\Asset\Repository $assetRepo,
\Magento\Framework\Module\ModuleList $moduleList,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
ObjectManager\ConfigLoader $configLoader
) {
$this->state = $state;
diff --git a/lib/internal/Magento/Framework/AppInterface.php b/lib/internal/Magento/Framework/AppInterface.php
index 744daa8ff87313597ae9801e32095bbdec2e5fdf..2bfdcec8d93b984f4428d0ac07f52a4434d67536 100644
--- a/lib/internal/Magento/Framework/AppInterface.php
+++ b/lib/internal/Magento/Framework/AppInterface.php
@@ -35,7 +35,7 @@ interface AppInterface
/**
* Magento version
*/
- const VERSION = '0.1.0-alpha104';
+ const VERSION = '0.1.0-alpha105';
/**
* Launch application
diff --git a/lib/internal/Magento/Framework/Authorization.php b/lib/internal/Magento/Framework/Authorization.php
index d5052a59fd930065e4709d2c399d3e578f12639d..cf0e2401856366ac07a732d813c82917cf4b8033 100644
--- a/lib/internal/Magento/Framework/Authorization.php
+++ b/lib/internal/Magento/Framework/Authorization.php
@@ -30,24 +30,24 @@ class Authorization implements \Magento\Framework\AuthorizationInterface
/**
* ACL policy
*
- * @var \Magento\Framework\Authorization\Policy
+ * @var \Magento\Framework\Authorization\PolicyInterface
*/
protected $_aclPolicy;
/**
* ACL role locator
*
- * @var \Magento\Framework\Authorization\RoleLocator
+ * @var \Magento\Framework\Authorization\RoleLocatorInterface
*/
protected $_aclRoleLocator;
/**
- * @param \Magento\Framework\Authorization\Policy $aclPolicy
- * @param \Magento\Framework\Authorization\RoleLocator $roleLocator
+ * @param \Magento\Framework\Authorization\PolicyInterface $aclPolicy
+ * @param \Magento\Framework\Authorization\RoleLocatorInterface $roleLocator
*/
public function __construct(
- \Magento\Framework\Authorization\Policy $aclPolicy,
- \Magento\Framework\Authorization\RoleLocator $roleLocator
+ \Magento\Framework\Authorization\PolicyInterface $aclPolicy,
+ \Magento\Framework\Authorization\RoleLocatorInterface $roleLocator
) {
$this->_aclPolicy = $aclPolicy;
$this->_aclRoleLocator = $roleLocator;
diff --git a/lib/internal/Magento/Framework/Authorization/Factory.php b/lib/internal/Magento/Framework/Authorization/Factory.php
index df4c46ebe1259009aa7a5d0f32d6ba2c42900ffb..72bb3697b02c210a2698ca4adb3a61320d7ebc97 100644
--- a/lib/internal/Magento/Framework/Authorization/Factory.php
+++ b/lib/internal/Magento/Framework/Authorization/Factory.php
@@ -26,7 +26,7 @@
namespace Magento\Framework\Authorization;
use Magento\Framework\Authorization;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class Factory
{
@@ -38,16 +38,16 @@ class Factory
/**
* Object Manager instance
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $_objectManager = null;
/**
* Factory constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Authorization/Policy/Acl.php b/lib/internal/Magento/Framework/Authorization/Policy/Acl.php
index b8d241a604584e2bdc00134f0e730ff14ce6ca3e..2fe15688bf88b99e53f12e96b09e30bae6c38600 100644
--- a/lib/internal/Magento/Framework/Authorization/Policy/Acl.php
+++ b/lib/internal/Magento/Framework/Authorization/Policy/Acl.php
@@ -27,9 +27,9 @@
namespace Magento\Framework\Authorization\Policy;
use Magento\Framework\Acl\Builder;
-use Magento\Framework\Authorization\Policy;
+use Magento\Framework\Authorization\PolicyInterface;
-class Acl implements Policy
+class Acl implements PolicyInterface
{
/**
* @var \Magento\Framework\Acl\Builder
diff --git a/lib/internal/Magento/Framework/Authorization/Policy/DefaultPolicy.php b/lib/internal/Magento/Framework/Authorization/Policy/DefaultPolicy.php
index c36cfbc0c2ea6c7839327b2625a0c4262c49f03f..080f2454c35e5ae7e8bf7e733465f509fdec698c 100644
--- a/lib/internal/Magento/Framework/Authorization/Policy/DefaultPolicy.php
+++ b/lib/internal/Magento/Framework/Authorization/Policy/DefaultPolicy.php
@@ -27,7 +27,7 @@
*/
namespace Magento\Framework\Authorization\Policy;
-class DefaultPolicy implements \Magento\Framework\Authorization\Policy
+class DefaultPolicy implements \Magento\Framework\Authorization\PolicyInterface
{
/**
* Check whether given role has access to give id
diff --git a/lib/internal/Magento/Framework/Authorization/Policy.php b/lib/internal/Magento/Framework/Authorization/PolicyInterface.php
similarity index 98%
rename from lib/internal/Magento/Framework/Authorization/Policy.php
rename to lib/internal/Magento/Framework/Authorization/PolicyInterface.php
index 5b56b96e8197519f852867dc52edae3e2bf8f2de..31593b30bfc2b6fb22a01853feac7ff285f39a03 100644
--- a/lib/internal/Magento/Framework/Authorization/Policy.php
+++ b/lib/internal/Magento/Framework/Authorization/PolicyInterface.php
@@ -25,7 +25,7 @@
*/
namespace Magento\Framework\Authorization;
-interface Policy
+interface PolicyInterface
{
/**
* Check whether given role has access to given resource
diff --git a/lib/internal/Magento/Framework/Authorization/RoleLocator/DefaultRoleLocator.php b/lib/internal/Magento/Framework/Authorization/RoleLocator/DefaultRoleLocator.php
index d7f7c7654d2f244b0c9f1113ba76c70a3eb527dd..6a31931acde0b0e0d603219b99d2eccb04360d47 100644
--- a/lib/internal/Magento/Framework/Authorization/RoleLocator/DefaultRoleLocator.php
+++ b/lib/internal/Magento/Framework/Authorization/RoleLocator/DefaultRoleLocator.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\Authorization\RoleLocator;
-class DefaultRoleLocator implements \Magento\Framework\Authorization\RoleLocator
+class DefaultRoleLocator implements \Magento\Framework\Authorization\RoleLocatorInterface
{
/**
* Retrieve current role
diff --git a/lib/internal/Magento/Framework/Authorization/RoleLocator.php b/lib/internal/Magento/Framework/Authorization/RoleLocatorInterface.php
similarity index 97%
rename from lib/internal/Magento/Framework/Authorization/RoleLocator.php
rename to lib/internal/Magento/Framework/Authorization/RoleLocatorInterface.php
index 8fb144449ae39205333d4165184aa7228356abd3..72c0f329f484c7bcff122957ed269a927026cd4e 100644
--- a/lib/internal/Magento/Framework/Authorization/RoleLocator.php
+++ b/lib/internal/Magento/Framework/Authorization/RoleLocatorInterface.php
@@ -27,7 +27,7 @@
*/
namespace Magento\Framework\Authorization;
-interface RoleLocator
+interface RoleLocatorInterface
{
/**
* Retrieve current role
diff --git a/lib/internal/Magento/Framework/Autoload/AutoloaderInterface.php b/lib/internal/Magento/Framework/Autoload/AutoloaderInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..3db8ba077417468a23d67c2d6693ece2e08aaed7
--- /dev/null
+++ b/lib/internal/Magento/Framework/Autoload/AutoloaderInterface.php
@@ -0,0 +1,76 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Autoload;
+
+/**
+ * Interface for an autoloader class that allows the dynamic modification of PSR-0 and PSR-4 mappings
+ */
+interface AutoloaderInterface
+{
+ /**
+ * Adds a PSR-4 mapping from a namespace prefix to directories to search in for the corresponding class
+ *
+ * @param string $nsPrefix The namespace prefix of the PSR-4 mapping
+ * @param string|array $paths The path or paths to look in for the given prefix
+ * @param bool $prepend Whether to append the given path or paths to the paths already associated with the prefix
+ * @return void
+ */
+ public function addPsr4($nsPrefix, $paths, $prepend = false);
+
+ /**
+ * Adds a PSR-0 mapping from a namespace prefix to directories to search in for the corresponding class
+ *
+ * @param string $nsPrefix The namespace prefix of the PSR-0 mapping
+ * @param string|array $paths The path or paths to look in for the given prefix
+ * @param bool $prepend Whether to append the given path or paths to the paths already associated with the prefix
+ * @return void
+ */
+ public function addPsr0($nsPrefix, $paths, $prepend = false);
+
+ /**
+ * Creates new PSR-0 mappings from the given prefix to the given set of paths, eliminating previous mappings
+ *
+ * @param string $nsPrefix The namespace prefix of the PSR-0 mapping
+ * @param string|array $paths The path or paths to look in for the given prefix
+ * @return void
+ */
+ public function setPsr0($nsPrefix, $paths);
+
+ /**
+ * Creates new PSR-4 mappings from the given prefix to the given set of paths, eliminating previous mappings
+ *
+ * @param string $nsPrefix The namespace prefix of the PSR-0 mapping
+ * @param string|array $paths The path or paths to look in for the given prefix
+ * @return void
+ */
+ public function setPsr4($nsPrefix, $paths);
+
+ /**
+ * Attempts to load a class and returns true if successful.
+ *
+ * @param string $className
+ * @return bool
+ */
+ public function loadClass($className);
+}
diff --git a/lib/internal/Magento/Framework/Autoload/AutoloaderRegistry.php b/lib/internal/Magento/Framework/Autoload/AutoloaderRegistry.php
new file mode 100644
index 0000000000000000000000000000000000000000..9effc13454e78c350c740f6816128da1bd7586aa
--- /dev/null
+++ b/lib/internal/Magento/Framework/Autoload/AutoloaderRegistry.php
@@ -0,0 +1,64 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Autoload;
+
+use \Magento\Framework\Autoload\AutoloaderInterface;
+
+/**
+ * Registry to store a static member autoloader
+ */
+class AutoloaderRegistry
+{
+
+ /**
+ * @var AutoloaderInterface
+ */
+ protected static $autoloader;
+
+ /**
+ * Registers the given autoloader as a static member
+ *
+ * @param AutoloaderInterface $newAutoloader
+ * @return void
+ */
+ public static function registerAutoloader(AutoloaderInterface $newAutoloader)
+ {
+ self::$autoloader = $newAutoloader;
+ }
+
+ /**
+ * Returns the registered autoloader
+ *
+ * @throws \Exception
+ * @return AutoloaderInterface
+ */
+ public static function getAutoloader()
+ {
+ if (!is_null(self::$autoloader)) {
+ return self::$autoloader;
+ } else {
+ throw new \Exception('Autoloader is not registered, cannot be retrieved.');
+ }
+ }
+}
diff --git a/lib/internal/Magento/Framework/Autoload/ClassLoaderWrapper.php b/lib/internal/Magento/Framework/Autoload/ClassLoaderWrapper.php
new file mode 100644
index 0000000000000000000000000000000000000000..558765b1a9d6fcd244badb8020314e9ed8be4023
--- /dev/null
+++ b/lib/internal/Magento/Framework/Autoload/ClassLoaderWrapper.php
@@ -0,0 +1,109 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Autoload;
+
+use \Composer\Autoload\ClassLoader;
+use Magento\Framework\Autoload\AutoloaderInterface;
+
+/**
+ * Wrapper designed to insulate the autoloader class provided by Composer
+ */
+class ClassLoaderWrapper implements AutoloaderInterface
+{
+ /**
+ * Using the autoloader class provided by Composer
+ *
+ * @var ClassLoader
+ */
+ protected $autoloader;
+
+ /**
+ * @param ClassLoader $autoloader
+ */
+ public function __construct(ClassLoader $autoloader)
+ {
+ $this->autoloader = $autoloader;
+ }
+
+ /**
+ * Adds a PSR-4 mapping from a namespace prefix to directories to search in for the corresponding class
+ *
+ * @param string $nsPrefix The namespace prefix of the PSR-4 mapping
+ * @param string|array $paths The path or paths to look in for the given prefix
+ * @param bool $prepend Whether to append the given path or paths to the paths already associated with the prefix
+ * @return void
+ */
+ public function addPsr4($nsPrefix, $paths, $prepend = false)
+ {
+ $this->autoloader->addPsr4($nsPrefix, $paths, $prepend);
+ }
+
+ /**
+ * Adds a PSR-0 mapping from a namespace prefix to directories to search in for the corresponding class
+ *
+ * @param string $nsPrefix The namespace prefix of the PSR-0 mapping
+ * @param string|array $paths The path or paths to look in for the given prefix
+ * @param bool $prepend Whether to append the given path or paths to the paths already associated with the prefix
+ * @return void
+ */
+ public function addPsr0($nsPrefix, $paths, $prepend = false)
+ {
+ $this->autoloader->add($nsPrefix, $paths, $prepend);
+ }
+
+ /**
+ * Creates new PSR-0 mappings from the given prefix to the given set of paths, eliminating previous mappings
+ *
+ * @param string $nsPrefix The namespace prefix of the PSR-0 mapping
+ * @param string|array $paths The path or paths to look in for the given prefix
+ * @return void
+ */
+ public function setPsr0($nsPrefix, $paths)
+ {
+ $this->autoloader->set($nsPrefix, $paths);
+ }
+
+ /**
+ * Creates new PSR-4 mappings from the given prefix to the given set of paths, eliminating previous mappings
+ *
+ * @param string $nsPrefix The namespace prefix of the PSR-0 mapping
+ * @param string|array $paths The path or paths to look in for the given prefix
+ * @return void
+ */
+ public function setPsr4($nsPrefix, $paths)
+ {
+ $this->autoloader->setPsr4($nsPrefix, $paths);
+ }
+
+ /**
+ * Attempts to load a class and returns true if successful.
+ *
+ * @param string $className
+ * @return bool
+ */
+ public function loadClass($className)
+ {
+ return $this->autoloader->loadClass($className) === true;
+ }
+}
diff --git a/lib/internal/Magento/Framework/Autoload/ClassMap.php b/lib/internal/Magento/Framework/Autoload/ClassMap.php
deleted file mode 100644
index 377cfa48f83ce5d58641127203afe9864ae8c4c6..0000000000000000000000000000000000000000
--- a/lib/internal/Magento/Framework/Autoload/ClassMap.php
+++ /dev/null
@@ -1,101 +0,0 @@
-<?php
-/**
- * An autoloader that uses class map
- *
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\Framework\Autoload;
-
-class ClassMap
-{
- /**
- * Absolute path to base directory that will be prepended as prefix to the included files
- *
- * @var string
- */
- protected $_baseDir;
-
- /**
- * Map of class name to file (relative to the base directory)
- *
- * array(
- * 'Class_Name' => 'relative/path/to/Class/Name.php',
- * )
- *
- * @var array
- */
- protected $_map = array();
-
- /**
- * Set base directory absolute path
- *
- * @param string $baseDir
- * @throws \InvalidArgumentException
- */
- public function __construct($baseDir)
- {
- $this->_baseDir = realpath($baseDir);
- if (!$this->_baseDir || !is_dir($this->_baseDir)) {
- throw new \InvalidArgumentException("Specified path is not a valid directory: '{$baseDir}'");
- }
- }
-
- /**
- * Find an absolute path to a file to be included
- *
- * @param string $class
- * @return string|bool
- */
- public function getFile($class)
- {
- if (isset($this->_map[$class])) {
- return $this->_baseDir . '/' . $this->_map[$class];
- }
- return false;
- }
-
- /**
- * Add classes files declaration to the map. New map will override existing values if such was defined before.
- *
- * @param array $map
- * @return $this
- */
- public function addMap(array $map)
- {
- $this->_map = array_merge($this->_map, $map);
- return $this;
- }
-
- /**
- * Resolve a class file and include it
- *
- * @param string $class
- * @return void
- */
- public function load($class)
- {
- $file = $this->getFile($class);
- if (file_exists($file)) {
- include $file;
- }
- }
-}
diff --git a/lib/internal/Magento/Framework/Autoload/IncludePath.php b/lib/internal/Magento/Framework/Autoload/IncludePath.php
deleted file mode 100644
index 80c38299a8c48c80c80ca89bf853597ae19540cb..0000000000000000000000000000000000000000
--- a/lib/internal/Magento/Framework/Autoload/IncludePath.php
+++ /dev/null
@@ -1,92 +0,0 @@
-<?php
-/**
- * An autoloader that uses include path. Compliant with PSR-0 standard
- *
- * Magento
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.txt.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- * If you did not receive a copy of the license and are unable to
- * obtain it through the world-wide-web, please send an email
- * to license@magentocommerce.com so we can send you a copy immediately.
- *
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magentocommerce.com for more information.
- *
- * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
- * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
- */
-namespace Magento\Framework\Autoload;
-
-class IncludePath
-{
- /**
- * Namespaces separator
- */
- const NS_SEPARATOR = '\\';
-
- /**
- * Find a file in include path
- *
- * @param string $class
- * @return string|bool
- */
- public function getFile($class)
- {
- $relativePath = $this->getFilePath($class);
- return stream_resolve_include_path($relativePath);
- }
-
- /**
- * Get relative file path for specified class
- *
- * @static
- * @param string $class
- * @return string
- */
- public function getFilePath($class)
- {
- return ltrim(str_replace(array('_',self::NS_SEPARATOR), '/', $class), '/') . '.php';
- }
-
- /**
- * Add specified path(s) to the current include_path
- *
- * @param string|array $path
- * @param bool $prepend Whether to prepend paths or to append them
- * @return void
- */
- public function addIncludePath($path, $prepend = true)
- {
- $includePathExtra = implode(PATH_SEPARATOR, (array)$path);
- $includePath = get_include_path();
- $pathSeparator = $includePath && $includePathExtra ? PATH_SEPARATOR : '';
- if ($prepend) {
- $includePath = $includePathExtra . $pathSeparator . $includePath;
- } else {
- $includePath = $includePath . $pathSeparator . $includePathExtra;
- }
- set_include_path($includePath);
- }
-
- /**
- * Resolve a class file and include it
- *
- * @param string $class
- * @return void
- */
- public function load($class)
- {
- $file = $this->getFile($class);
- if ($file) {
- include $file;
- }
- }
-}
diff --git a/lib/internal/Magento/Framework/Autoload/Populator.php b/lib/internal/Magento/Framework/Autoload/Populator.php
new file mode 100644
index 0000000000000000000000000000000000000000..2dfa8bc653db1fa801f552524d1d92b71544b2d6
--- /dev/null
+++ b/lib/internal/Magento/Framework/Autoload/Populator.php
@@ -0,0 +1,68 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Autoload;
+
+use \Magento\Framework\App\Filesystem\DirectoryList;
+use \Magento\Framework\Autoload\AutoloaderInterface;
+use \Magento\Framework\Filesystem\FileResolver;
+
+/**
+ * Utility class for populating an autoloader with application-specific information for PSR-0 and PSR-4 mappings
+ * and include-path contents
+ */
+class Populator
+{
+
+ /**
+ * @param AutoloaderInterface $registry
+ * @param DirectoryList $dirList
+ * @return void
+ */
+ public static function populateMappings(AutoloaderInterface $autoloader, DirectoryList $dirList)
+ {
+ $modulesDir = $dirList->getPath(DirectoryList::MODULES);
+ $generationDir = $dirList->getPath(DirectoryList::GENERATION);
+ $frameworkDir = $dirList->getPath(DirectoryList::LIB_INTERNAL);
+
+ $autoloader->addPsr4('Magento\\', [$modulesDir . '/Magento/', $generationDir . '/Magento/'], true);
+ $autoloader->addPsr4('Zend\\Soap\\', $modulesDir . '/Zend/Soap/', true);
+ $autoloader->addPsr4('Zend\\', $frameworkDir . '/Zend/', true);
+
+ $autoloader->addPsr0('Apache_', $frameworkDir, true);
+ $autoloader->addPsr0('Cm_', $frameworkDir, true);
+ $autoloader->addPsr0('Credis_', $frameworkDir, true);
+ $autoloader->addPsr0('Less_', $frameworkDir, true);
+ $autoloader->addPsr0('Symfony\\', $frameworkDir, true);
+ $autoloader->addPsr0('Zend_Date', $modulesDir, true);
+ $autoloader->addPsr0('Zend_Mime', $modulesDir, true);
+ $autoloader->addPsr0('Zend_', $frameworkDir, true);
+ $autoloader->addPsr0('Zend\\', $frameworkDir, true);
+
+ /** Required for Zend functionality */
+ FileResolver::addIncludePath($frameworkDir);
+
+ /** Required for code generation to occur */
+ FileResolver::addIncludePath($generationDir);
+ }
+}
diff --git a/lib/internal/Magento/Framework/Autoload/README.md b/lib/internal/Magento/Framework/Autoload/README.md
index 443b184586b58b0e44a1dbfb0b0cc564d76ccff2..e149d34c42c21674797c8fa35a24b002bda99abc 100644
--- a/lib/internal/Magento/Framework/Autoload/README.md
+++ b/lib/internal/Magento/Framework/Autoload/README.md
@@ -1,3 +1,8 @@
# Autoload
-**Autoload** library implements PSR-0 standard of autoloader with capability of class mapping in addition. The key benefit of a Class Map is that it includes files matched to their absolute system paths, which can lead to performance gains.
\ No newline at end of file
+**Autoload** library contains an abstract wrapper for Composer's generated autoloader.
+
+* AutoloaderInterface provides abstract ability use and modify the autoloader class.
+* AutoloaderRegistry allows the same instance of the autoloader to put accessed across the code base.
+* ClassLoaderWrapper wraps around Composer's generated autoloader in order to insulate it.
+* Populator fills in PSR-0 and PSR-4 standard namespace-directory mappings for the autoloader.
diff --git a/lib/internal/Magento/Framework/Backup/Db/BackupFactory.php b/lib/internal/Magento/Framework/Backup/Db/BackupFactory.php
index 6b23522b09a734be5f640706a2a984ecde6c7595..f4941f736dc1fb18a22c451c0b71c430c50aebb7 100644
--- a/lib/internal/Magento/Framework/Backup/Db/BackupFactory.php
+++ b/lib/internal/Magento/Framework/Backup/Db/BackupFactory.php
@@ -28,7 +28,7 @@ class BackupFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
@@ -43,11 +43,11 @@ class BackupFactory
private $_backupDbInstanceName;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $backupInstanceName
* @param string $backupDbInstanceName
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $backupInstanceName, $backupDbInstanceName)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $backupInstanceName, $backupDbInstanceName)
{
$this->_objectManager = $objectManager;
$this->_backupInstanceName = $backupInstanceName;
diff --git a/lib/internal/Magento/Framework/Backup/Factory.php b/lib/internal/Magento/Framework/Backup/Factory.php
index 4fc2dbb1327b90bdd9efb5e1256fa8533aef4136..46b56681609310cae7e50a5ded3113fd8a24f6aa 100644
--- a/lib/internal/Magento/Framework/Backup/Factory.php
+++ b/lib/internal/Magento/Framework/Backup/Factory.php
@@ -30,7 +30,7 @@ class Factory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
@@ -67,9 +67,9 @@ class Factory
protected $_allowedTypes;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
$this->_allowedTypes = array(
diff --git a/lib/internal/Magento/Framework/Code/Generator.php b/lib/internal/Magento/Framework/Code/Generator.php
index e4b8828dfb672706e49070d43f294330e1faac81..a32c1f445045e06f8e79972c6805b127f9874288 100644
--- a/lib/internal/Magento/Framework/Code/Generator.php
+++ b/lib/internal/Magento/Framework/Code/Generator.php
@@ -23,6 +23,9 @@
*/
namespace Magento\Framework\Code;
+use Magento\Framework\Code\Generator\DefinedClasses;
+use Magento\Framework\Code\Generator\EntityAbstract;
+
class Generator
{
const GENERATION_SUCCESS = 'success';
@@ -31,36 +34,36 @@ class Generator
const GENERATION_SKIP = 'skip';
- /**
- * @var \Magento\Framework\Code\Generator\FileResolver
- */
- protected $fileResolver;
-
/**
* @var \Magento\Framework\Code\Generator\Io
*/
protected $_ioObject;
/**
- * @var string[]
+ * @var string[] of EntityAbstract classes
*/
protected $_generatedEntities;
/**
- * @param \Magento\Framework\Code\Generator\FileResolver $fileResolver
- * @param Generator\Io $ioObject
- * @param array $generatedEntities
+ * @var DefinedClasses
+ */
+ protected $definedClasses;
+
+ /**
+ * @param Generator\Io $ioObject
+ * @param array $generatedEntities
+ * @param DefinedClasses $definedClasses
*/
public function __construct(
- \Magento\Framework\Code\Generator\FileResolver $fileResolver,
\Magento\Framework\Code\Generator\Io $ioObject = null,
- array $generatedEntities = array()
+ array $generatedEntities = [],
+ DefinedClasses $definedClasses = null
) {
- $this->fileResolver = $fileResolver;
- $this->_ioObject = $ioObject ?: new \Magento\Framework\Code\Generator\Io(
- new \Magento\Framework\Filesystem\Driver\File(),
- $this->fileResolver
- );
+ $this->_ioObject = $ioObject
+ ?: new \Magento\Framework\Code\Generator\Io(
+ new \Magento\Framework\Filesystem\Driver\File()
+ );
+ $this->definedClasses = $definedClasses ?: new DefinedClasses();
$this->_generatedEntities = $generatedEntities;
}
@@ -103,8 +106,7 @@ class Generator
return self::GENERATION_ERROR;
}
- // check if file already exists
- if ($this->fileResolver->getFile($className)) {
+ if ($this->definedClasses->classLoadable($className)) {
return self::GENERATION_SKIP;
}
@@ -112,12 +114,23 @@ class Generator
throw new \InvalidArgumentException('Unknown generation entity.');
}
$generatorClass = $this->_generatedEntities[$entity];
+ /** @var EntityAbstract $generator */
$generator = new $generatorClass($entityName, $className, $this->_ioObject);
- if (!$generator->generate()) {
+
+ if (!($file = $generator->generate())) {
$errors = $generator->getErrors();
throw new \Magento\Framework\Exception(implode(' ', $errors));
}
-
+ $this->includeFile($file);
return self::GENERATION_SUCCESS;
}
+
+ /**
+ * @param string $fileName
+ * @return void
+ */
+ public function includeFile($fileName)
+ {
+ include $fileName;
+ }
}
diff --git a/lib/internal/Magento/Framework/Code/Generator/Autoloader.php b/lib/internal/Magento/Framework/Code/Generator/Autoloader.php
index ae1616d01dd540ca01b5b3a3c1dbf438153d087d..378eee4c1f2715a222cfa0c652f089b42af2a265 100644
--- a/lib/internal/Magento/Framework/Code/Generator/Autoloader.php
+++ b/lib/internal/Magento/Framework/Code/Generator/Autoloader.php
@@ -24,6 +24,8 @@
namespace Magento\Framework\Code\Generator;
use \Magento\Framework\Code\Generator;
+use \Magento\Framework\Autoload\AutoloaderRegistry;
+use \Magento\Framework\Autoload\AutoloaderInterface;
class Autoloader
{
@@ -32,20 +34,12 @@ class Autoloader
*/
protected $_generator;
- /**
- * @var \Magento\Framework\Code\Generator\FileResolver
- */
- protected $fileResolver;
-
/**
* @param \Magento\Framework\Code\Generator $generator
- * @param \Magento\Framework\Code\Generator\FileResolver $fileResolver
*/
public function __construct(
- \Magento\Framework\Code\Generator $generator,
- \Magento\Framework\Code\Generator\FileResolver $fileResolver
+ \Magento\Framework\Code\Generator $generator
) {
- $this->fileResolver = $fileResolver;
$this->_generator = $generator;
}
@@ -53,17 +47,13 @@ class Autoloader
* Load specified class name and generate it if necessary
*
* @param string $className
- * @return void
+ * @return bool True if class was loaded
*/
public function load($className)
{
if (!class_exists($className)) {
- if (Generator::GENERATION_SUCCESS === $this->_generator->generateClass($className)) {
- $file = $this->fileResolver->getFile($className);
- if ($file) {
- include $file;
- }
- }
+ return Generator::GENERATION_ERROR != $this->_generator->generateClass($className);
}
+ return true;
}
}
diff --git a/lib/internal/Magento/Framework/Code/Generator/DefinedClasses.php b/lib/internal/Magento/Framework/Code/Generator/DefinedClasses.php
new file mode 100644
index 0000000000000000000000000000000000000000..382d6f7bfc014090252cfcf6f6cc7eec26fb0442
--- /dev/null
+++ b/lib/internal/Magento/Framework/Code/Generator/DefinedClasses.php
@@ -0,0 +1,53 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Framework\Code\Generator;
+
+use Magento\Framework\Autoload\AutoloaderRegistry;
+
+/**
+ * DefinedClasses class detects if a class has been defined
+ */
+class DefinedClasses
+{
+
+ /**
+ * Determine if a class can be loaded without using the Code\Generator\Autoloader.
+ *
+ * @param string $className
+ * @return bool
+ */
+ public function classLoadable($className)
+ {
+ if (class_exists($className, false) || interface_exists($className, false)) {
+ return true;
+ }
+ try {
+ return AutoloaderRegistry::getAutoloader()->loadClass($className);
+ } catch (\Exception $e) {
+ // Couldn't get access to the autoloader so we need to allow class_exists to call autoloader chain
+ return (class_exists($className) || interface_exists($className));
+ }
+ }
+}
diff --git a/lib/internal/Magento/Framework/Code/Generator/EntityAbstract.php b/lib/internal/Magento/Framework/Code/Generator/EntityAbstract.php
index a789218b96b4f3b170c64e1973c401a49eb08702..78911e83c11c1887c4d7d571a86a074a91a441f7 100644
--- a/lib/internal/Magento/Framework/Code/Generator/EntityAbstract.php
+++ b/lib/internal/Magento/Framework/Code/Generator/EntityAbstract.php
@@ -23,8 +23,6 @@
*/
namespace Magento\Framework\Code\Generator;
-use \Magento\Framework\Code\Generator\FileResolver;
-
abstract class EntityAbstract
{
/**
@@ -56,13 +54,6 @@ abstract class EntityAbstract
*/
private $_ioObject;
- /**
- * Autoloader instance
- *
- * @var FileResolver
- */
- private $fileResolver;
-
/**
* Class generator object
*
@@ -70,35 +61,40 @@ abstract class EntityAbstract
*/
protected $_classGenerator;
+ /**
+ * @var DefinedClasses
+ */
+ private $definedClasses;
+
/**
* @param null|string $sourceClassName
* @param null|string $resultClassName
* @param Io $ioObject
* @param CodeGenerator\CodeGeneratorInterface $classGenerator
- * @param FileResolver $fileResolver
+ * @param DefinedClasses $definedClasses
*/
public function __construct(
$sourceClassName = null,
$resultClassName = null,
Io $ioObject = null,
CodeGenerator\CodeGeneratorInterface $classGenerator = null,
- FileResolver $fileResolver = null
+ DefinedClasses $definedClasses = null
) {
- if ($fileResolver) {
- $this->fileResolver = $fileResolver;
- } else {
- $this->fileResolver = new FileResolver();
- }
if ($ioObject) {
$this->_ioObject = $ioObject;
} else {
- $this->_ioObject = new Io(new \Magento\Framework\Filesystem\Driver\File(), $this->fileResolver);
+ $this->_ioObject = new Io(new \Magento\Framework\Filesystem\Driver\File());
}
if ($classGenerator) {
$this->_classGenerator = $classGenerator;
} else {
$this->_classGenerator = new CodeGenerator\Zend();
}
+ if ($definedClasses) {
+ $this->definedClasses = $definedClasses;
+ } else {
+ $this->definedClasses = new DefinedClasses();
+ }
$this->_sourceClassName = ltrim($sourceClassName, '\\');
if ($resultClassName) {
@@ -121,7 +117,7 @@ abstract class EntityAbstract
if ($sourceCode) {
$fileName = $this->_ioObject->getResultFileName($this->_getResultClassName());
$this->_ioObject->writeResultFile($fileName, $sourceCode);
- return true;
+ return $fileName;
} else {
$this->_addError('Can\'t generate source code.');
}
@@ -197,7 +193,7 @@ abstract class EntityAbstract
'visibility' => 'protected',
'docblock' => array(
'shortDescription' => 'Object Manager instance',
- 'tags' => array(array('name' => 'var', 'description' => '\Magento\Framework\ObjectManager'))
+ 'tags' => array(array('name' => 'var', 'description' => '\Magento\Framework\ObjectManagerInterface'))
)
);
@@ -284,13 +280,13 @@ abstract class EntityAbstract
$filePath = stream_resolve_include_path(str_replace('_', '/', $controllerPath) . '.php');
$isSourceClassValid = !empty($filePath);
} else {
- $isSourceClassValid = $this->fileResolver->getFile($sourceClassName);
+ $isSourceClassValid = $this->definedClasses->classLoadable($sourceClassName);
}
if (!$isSourceClassValid) {
$this->_addError('Source class ' . $sourceClassName . ' doesn\'t exist.');
return false;
- } elseif ($this->fileResolver->getFile($resultClassName)) {
+ } elseif ($this->definedClasses->classLoadable($resultClassName)) {
$this->_addError('Result class ' . $resultClassName . ' already exists.');
return false;
} elseif (!$this->_ioObject->makeGenerationDirectory()) {
diff --git a/lib/internal/Magento/Framework/Code/Generator/Io.php b/lib/internal/Magento/Framework/Code/Generator/Io.php
index 48dcdd8dc46980321a57b52da0386c93c8ae30f2..6ee484252229c1da93e0d7702ebea071bc8c0fb6 100644
--- a/lib/internal/Magento/Framework/Code/Generator/Io.php
+++ b/lib/internal/Magento/Framework/Code/Generator/Io.php
@@ -43,29 +43,19 @@ class Io
*/
private $_generationDirectory;
- /**
- * File resolver
- *
- * @var \Magento\Framework\Code\Generator\FileResolver
- */
- private $fileResolver;
-
/**
* @var \Magento\Framework\Filesystem\Driver\File
*/
private $filesystemDriver;
/**
- * @param \Magento\Framework\Filesystem\Driver\File $filesystemDriver
- * @param \Magento\Framework\Code\Generator\FileResolver $fileResolver
- * @param null $generationDirectory
+ * @param \Magento\Framework\Filesystem\Driver\File $filesystemDriver
+ * @param null|string $generationDirectory
*/
public function __construct(
\Magento\Framework\Filesystem\Driver\File $filesystemDriver,
- \Magento\Framework\Code\Generator\FileResolver $fileResolver,
$generationDirectory = null
) {
- $this->fileResolver = $fileResolver;
$this->filesystemDriver = $filesystemDriver;
$this->initGeneratorDirectory($generationDirectory);
}
@@ -104,8 +94,7 @@ class Io
*/
public function getResultFileName($className)
{
- $resultFileName = $this->fileResolver->getFilePath($className);
- return $this->_generationDirectory . $resultFileName;
+ return $this->_generationDirectory . ltrim(str_replace(['\\', '_'], '/', $className), '/') . '.php';
}
/**
diff --git a/lib/internal/Magento/Framework/Config/DomFactory.php b/lib/internal/Magento/Framework/Config/DomFactory.php
index 464ac61eecfd0ea3cf4431e21a7ffa986666ca1a..133bda65124339ce19f837d087d2bb813a5f03b9 100644
--- a/lib/internal/Magento/Framework/Config/DomFactory.php
+++ b/lib/internal/Magento/Framework/Config/DomFactory.php
@@ -33,16 +33,16 @@ class DomFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManger
+ * @param \Magento\Framework\ObjectManagerInterface $objectManger
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManger)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManger)
{
$this->_objectManager = $objectManger;
}
diff --git a/lib/internal/Magento/Framework/Controller/ResultFactory.php b/lib/internal/Magento/Framework/Controller/ResultFactory.php
index 2583a7c879f7bfb2681339607273471e47688909..5942a6a1ad5b772d1626fc1b64aeb29642e3d331 100644
--- a/lib/internal/Magento/Framework/Controller/ResultFactory.php
+++ b/lib/internal/Magento/Framework/Controller/ResultFactory.php
@@ -24,7 +24,7 @@
namespace Magento\Framework\Controller;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Result Factory
@@ -57,18 +57,18 @@ class ResultFactory
];
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param array $typeMap
*/
public function __construct(
- ObjectManager $objectManager,
+ ObjectManagerInterface $objectManager,
array $typeMap = []
) {
$this->objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/Controller/Router/Route/Factory.php b/lib/internal/Magento/Framework/Controller/Router/Route/Factory.php
index 895629aa05ce13449fcb9ac18f9c379763b1338f..2a759101a8f2c545ca084ab7c93a4ff5af7aa9e3 100644
--- a/lib/internal/Magento/Framework/Controller/Router/Route/Factory.php
+++ b/lib/internal/Magento/Framework/Controller/Router/Route/Factory.php
@@ -9,14 +9,14 @@ namespace Magento\Framework\Controller\Router\Route;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/CurrencyFactory.php b/lib/internal/Magento/Framework/CurrencyFactory.php
index 98fc040f81eed51b9030bb7ce8085f8ffa07345e..4fc319efc112595dac2cf9a953082f9d820ec97b 100644
--- a/lib/internal/Magento/Framework/CurrencyFactory.php
+++ b/lib/internal/Magento/Framework/CurrencyFactory.php
@@ -26,7 +26,7 @@ namespace Magento\Framework;
class CurrencyFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -36,10 +36,10 @@ class CurrencyFactory
protected $_instanceName = null;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $instanceName = 'Magento\Framework\CurrencyInterface')
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\Framework\CurrencyInterface')
{
$this->_objectManager = $objectManager;
$this->_instanceName = $instanceName;
diff --git a/lib/internal/Magento/Framework/DB/AbstractMapper.php b/lib/internal/Magento/Framework/DB/AbstractMapper.php
new file mode 100644
index 0000000000000000000000000000000000000000..519a6db1a2d694e57a560695afd7278a35ccf365
--- /dev/null
+++ b/lib/internal/Magento/Framework/DB/AbstractMapper.php
@@ -0,0 +1,438 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\DB;
+
+use Magento\Framework\Api\CriteriaInterface;
+use Magento\Framework\Data\Collection\Db\FetchStrategyInterface;
+use Magento\Framework\Data\ObjectFactory;
+use Magento\Framework\DB\Adapter\AdapterInterface;
+use Magento\Framework\Logger;
+use Magento\Framework\Object;
+
+/**
+ * Class AbstractMapper
+ * @package Magento\Framework\DB
+ */
+abstract class AbstractMapper implements MapperInterface
+{
+ /**
+ * Resource model name
+ *
+ * @var string
+ */
+ protected $resourceModel;
+
+ /**
+ * Resource instance
+ *
+ * @var \Magento\Framework\Model\Resource\Db\AbstractDb
+ */
+ protected $resource;
+
+ /**
+ * Store joined tables here
+ *
+ * @var array
+ */
+ protected $joinedTables = [];
+
+ /**
+ * DB connection
+ *
+ * @var AdapterInterface
+ */
+ protected $conn;
+
+ /**
+ * Select object
+ *
+ * @var Select
+ */
+ protected $select;
+
+ /**
+ * @var Logger
+ */
+ protected $logger;
+
+ /**
+ * @var FetchStrategyInterface
+ */
+ protected $fetchStrategy;
+
+ /**
+ * @var ObjectFactory
+ */
+ protected $objectFactory;
+
+ /**
+ * @var MapperFactory
+ */
+ protected $mapperFactory;
+
+ /**
+ * Fields and filters map
+ *
+ * @var array
+ */
+ protected $map = [];
+
+ /**
+ * @param Logger $logger
+ * @param FetchStrategyInterface $fetchStrategy
+ * @param ObjectFactory $objectFactory
+ * @param MapperFactory $mapperFactory
+ * @param Select $select
+ */
+ public function __construct(
+ Logger $logger,
+ FetchStrategyInterface $fetchStrategy,
+ ObjectFactory $objectFactory,
+ MapperFactory $mapperFactory,
+ Select $select = null
+ ) {
+ $this->logger = $logger;
+ $this->fetchStrategy = $fetchStrategy;
+ $this->objectFactory = $objectFactory;
+ $this->mapperFactory = $mapperFactory;
+ $this->select = $select;
+ $this->init();
+ }
+
+ /**
+ * Set initial conditions
+ *
+ * @return void
+ */
+ abstract protected function init();
+
+ /**
+ * Map criteria to Select Query Object
+ *
+ * @param CriteriaInterface $criteria
+ * @return Select
+ */
+ public function map(CriteriaInterface $criteria)
+ {
+ $criteriaParts = $criteria->toArray();
+ foreach ($criteriaParts as $key => $value) {
+ $camelCaseKey = \Magento\Framework\Api\SimpleDataObjectConverter::snakeCaseToUpperCamelCase($key);
+ $mapperMethod = 'map' . $camelCaseKey;
+ if (method_exists($this, $mapperMethod)) {
+ if (!is_array($value)) {
+ $value = [$value];
+ }
+ call_user_func_array([$this, $mapperMethod], $value);
+ }
+ }
+ return $this->select;
+ }
+
+ /**
+ * Add attribute expression (SUM, COUNT, etc)
+ * Example: ('sub_total', 'SUM({{attribute}})', 'revenue')
+ * Example: ('sub_total', 'SUM({{revenue}})', 'revenue')
+ * For some functions like SUM use groupByAttribute.
+ *
+ * @param string $alias
+ * @param string $expression
+ * @param array|string $fields
+ * @return void
+ */
+ public function addExpressionFieldToSelect($alias, $expression, $fields)
+ {
+ // validate alias
+ if (!is_array($fields)) {
+ $fields = [$fields => $fields];
+ }
+ $fullExpression = $expression;
+ foreach ($fields as $fieldKey => $fieldItem) {
+ $fullExpression = str_replace('{{' . $fieldKey . '}}', $fieldItem, $fullExpression);
+ }
+ $this->getSelect()->columns([$alias => $fullExpression]);
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function addFieldToFilter($field, $condition = null)
+ {
+ if (is_array($field)) {
+ $conditions = [];
+ foreach ($field as $key => $value) {
+ $conditions[] = $this->translateCondition($value, isset($condition[$key]) ? $condition[$key] : null);
+ }
+
+ $resultCondition = '(' . implode(') ' . \Zend_Db_Select::SQL_OR . ' (', $conditions) . ')';
+ } else {
+ $resultCondition = $this->translateCondition($field, $condition);
+ }
+ $this->select->where($resultCondition, null, Select::TYPE_CONDITION);
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function reset()
+ {
+ $this->getSelect()->reset();
+ }
+
+ /**
+ * Set resource model name
+ *
+ * @param string $model
+ * @return void
+ */
+ protected function setResourceModelName($model)
+ {
+ $this->resourceModel = $model;
+ }
+
+ /**
+ * Retrieve resource model name
+ *
+ * @return string
+ */
+ protected function getResourceModelName()
+ {
+ return $this->resourceModel;
+ }
+
+ /**
+ * Get resource instance
+ *
+ * @return \Magento\Framework\Model\Resource\Db\AbstractDb
+ */
+ public function getResource()
+ {
+ if (empty($this->resource)) {
+ $this->resource = \Magento\Framework\App\ObjectManager::getInstance()->create(
+ $this->getResourceModelName()
+ );
+ }
+ return $this->resource;
+ }
+
+
+ /**
+ * Standard query builder initialization
+ *
+ * @param string $resourceInterface
+ * @return void
+ */
+ protected function initResource($resourceInterface)
+ {
+ $this->setResourceModelName($resourceInterface);
+ $this->setConnection($this->getResource()->getReadConnection());
+ if (!$this->select) {
+ $this->select = $this->getConnection()->select();
+ $this->initSelect();
+ }
+ }
+
+ /**
+ * Init collection select
+ *
+ * @return void
+ */
+ protected function initSelect()
+ {
+ $this->getSelect()->from(['main_table' => $this->getResource()->getMainTable()]);
+ }
+
+ /**
+ * Join table to collection select
+ *
+ * @param string $table
+ * @param string $condition
+ * @param string $cols
+ * @return void
+ */
+ protected function join($table, $condition, $cols = '*')
+ {
+ if (is_array($table)) {
+ foreach ($table as $k => $v) {
+ $alias = $k;
+ $table = $v;
+ break;
+ }
+ } else {
+ $alias = $table;
+ }
+ if (!isset($this->joinedTables[$table])) {
+ $this->getSelect()->join([$alias => $this->getTable($table)], $condition, $cols);
+ $this->joinedTables[$alias] = true;
+ }
+ }
+
+ /**
+ * Retrieve connection object
+ *
+ * @return AdapterInterface
+ */
+ protected function getConnection()
+ {
+ return $this->conn;
+ }
+
+ /**
+ * Set database connection adapter
+ *
+ * @param AdapterInterface $conn
+ * @return void
+ * @throws \InvalidArgumentException
+ */
+ protected function setConnection($conn)
+ {
+ if (!$conn instanceof \Magento\Framework\DB\Adapter\AdapterInterface) {
+ throw new \InvalidArgumentException(
+ __('dbModel read resource does not implement \Magento\Framework\DB\Adapter\AdapterInterface')
+ );
+ }
+ $this->conn = $conn;
+ }
+
+ /**
+ * Build sql where condition part
+ *
+ * @param string|array $field
+ * @param null|string|array $condition
+ * @return string
+ */
+ protected function translateCondition($field, $condition)
+ {
+ $field = $this->getMappedField($field);
+ return $this->getConditionSql($this->getConnection()->quoteIdentifier($field), $condition);
+ }
+
+ /**
+ * Try to get mapped field name for filter to collection
+ *
+ * @param string $field
+ * @return string
+ */
+ protected function getMappedField($field)
+ {
+ $mapper = $this->getMapper();
+
+ if (isset($mapper['fields'][$field])) {
+ $mappedField = $mapper['fields'][$field];
+ } else {
+ $mappedField = $field;
+ }
+
+ return $mappedField;
+ }
+
+ /**
+ * Retrieve mapper data
+ *
+ * @return array|bool|null
+ */
+ protected function getMapper()
+ {
+ if (isset($this->map)) {
+ return $this->map;
+ } else {
+ return false;
+ }
+ }
+
+ /**
+ * Build SQL statement for condition
+ *
+ * If $condition integer or string - exact value will be filtered ('eq' condition)
+ *
+ * If $condition is array - one of the following structures is expected:
+ * - array("from" => $fromValue, "to" => $toValue)
+ * - array("eq" => $equalValue)
+ * - array("neq" => $notEqualValue)
+ * - array("like" => $likeValue)
+ * - array("in" => array($inValues))
+ * - array("nin" => array($notInValues))
+ * - array("notnull" => $valueIsNotNull)
+ * - array("null" => $valueIsNull)
+ * - array("moreq" => $moreOrEqualValue)
+ * - array("gt" => $greaterValue)
+ * - array("lt" => $lessValue)
+ * - array("gteq" => $greaterOrEqualValue)
+ * - array("lteq" => $lessOrEqualValue)
+ * - array("finset" => $valueInSet)
+ * - array("regexp" => $regularExpression)
+ * - array("seq" => $stringValue)
+ * - array("sneq" => $stringValue)
+ *
+ * If non matched - sequential array is expected and OR conditions
+ * will be built using above mentioned structure
+ *
+ * @param string $fieldName
+ * @param integer|string|array $condition
+ * @return string
+ */
+ protected function getConditionSql($fieldName, $condition)
+ {
+ return $this->getConnection()->prepareSqlCondition($fieldName, $condition);
+ }
+
+ /**
+ * Return the field name for the condition.
+ *
+ * @param string $fieldName
+ * @return string
+ */
+ protected function getConditionFieldName($fieldName)
+ {
+ return $fieldName;
+ }
+
+ /**
+ * Hook for operations before rendering filters
+ * @return void
+ */
+ protected function renderFiltersBefore()
+ {
+ }
+
+ /**
+ * Retrieve table name
+ *
+ * @param string $table
+ * @return string
+ */
+ protected function getTable($table)
+ {
+ return $this->getResource()->getTable($table);
+ }
+
+ /**
+ * Get \Magento\Framework\DB\Select object instance
+ *
+ * @return Select
+ */
+ protected function getSelect()
+ {
+ return $this->select;
+ }
+}
diff --git a/lib/internal/Magento/Framework/DB/Ddl/TriggerFactory.php b/lib/internal/Magento/Framework/DB/Ddl/TriggerFactory.php
index 30fa87bcc44fa7436d18d7d18b427c2e2bc30871..3646b6ca133ef1e237980b0346773854fc06dfa2 100644
--- a/lib/internal/Magento/Framework/DB/Ddl/TriggerFactory.php
+++ b/lib/internal/Magento/Framework/DB/Ddl/TriggerFactory.php
@@ -26,7 +26,7 @@ namespace Magento\Framework\DB\Ddl;
class TriggerFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -36,9 +36,9 @@ class TriggerFactory
const INSTANCE_NAME = 'Magento\Framework\DB\Ddl\Trigger';
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/DB/GenericMapper.php b/lib/internal/Magento/Framework/DB/GenericMapper.php
new file mode 100644
index 0000000000000000000000000000000000000000..65724351948bb974f75a6214a90b4893e23d5799
--- /dev/null
+++ b/lib/internal/Magento/Framework/DB/GenericMapper.php
@@ -0,0 +1,157 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\DB;
+
+use Magento\Framework\Api\CriteriaInterface;
+
+/**
+ * Class GenericMapper
+ */
+class GenericMapper extends AbstractMapper
+{
+ /**
+ * Set initial conditions
+ *
+ * @return void
+ */
+ protected function init()
+ {
+ //
+ }
+
+ /**
+ * Map criteria list
+ *
+ * @param \Magento\Framework\Api\CriteriaInterface[] $criteriaList
+ * @return void
+ */
+ public function mapCriteriaList(array $criteriaList)
+ {
+ foreach ($criteriaList as $criteria) {
+ /** @var CriteriaInterface $criteria */
+ $mapper = $criteria->getMapperInterfaceName();
+ $mapperInstance = $this->mapperFactory->create($mapper, ['select' => $this->select]);
+ $this->select = $mapperInstance->map($criteria);
+ }
+ }
+
+ /**
+ * Map filters
+ *
+ * @param array $filters
+ * @return void
+ */
+ public function mapFilters(array $filters)
+ {
+ $this->renderFiltersBefore();
+ foreach ($filters as $filter) {
+ switch ($filter['type']) {
+ case 'or':
+ $condition = $this->getConnection()->quoteInto($filter['field'] . '=?', $filter['condition']);
+ $this->getSelect()->orWhere($condition);
+ break;
+ case 'string':
+ $this->getSelect()->where($filter['condition']);
+ break;
+ case 'public':
+ $field = $this->getMappedField($filter['field']);
+ $condition = $filter['condition'];
+ $this->getSelect()->where($this->getConditionSql($field, $condition), null, Select::TYPE_CONDITION);
+ break;
+ default:
+ $condition = $this->getConnection()->quoteInto($filter['field'] . '=?', $filter['condition']);
+ $this->getSelect()->where($condition);
+ }
+ }
+ }
+
+ /**
+ * Map order
+ *
+ * @param array $orders
+ * @return void
+ */
+ public function mapOrders(array $orders)
+ {
+ foreach ($orders as $field => $direction) {
+ $this->select->order(new \Zend_Db_Expr($field . ' ' . $direction));
+ }
+ }
+
+ /**
+ * Map fields
+ *
+ * @param array $fields
+ * @throws \Zend_Db_Select_Exception
+ * @return void
+ */
+ public function mapFields(array $fields)
+ {
+ $columns = $this->getSelect()->getPart(\Zend_Db_Select::COLUMNS);
+ $selectedUniqueNames = [];
+ foreach ($fields as $fieldInfo) {
+ if (is_string($fieldInfo)) {
+ $fieldInfo = isset($this->map[$fieldInfo]) ? $this->map[$fieldInfo] : $fieldInfo;
+ }
+ list($correlationName, $field, $alias) = $fieldInfo;
+ if (!is_string($alias)) {
+ $alias = null;
+ }
+ if ($field instanceof \Zend_Db_Expr) {
+ $field = $field->__toString();
+ }
+ $selectedUniqueName = $alias ?: $field;
+ if (in_array($selectedUniqueName, $selectedUniqueNames)) {
+ // ignore field since the alias is already used by another field
+ continue;
+ }
+ $selectedUniqueNames[] = $selectedUniqueName;
+ $columns[] = [$correlationName, $field, $alias];
+ }
+ $this->getSelect()->setPart(\Zend_Db_Select::COLUMNS, $columns);
+ }
+
+ /**
+ * Map limit
+ *
+ * @param int $offset
+ * @param int $size
+ * @return void
+ */
+ public function mapLimit($offset, $size)
+ {
+ $this->select->limitPage($offset, $size);
+ }
+
+ /**
+ * Map distinct flag
+ *
+ * @param bool $flag
+ * @return void
+ */
+ public function mapDistinct($flag)
+ {
+ $this->select->distinct($flag);
+ }
+}
diff --git a/lib/internal/Magento/Framework/DB/MapperFactory.php b/lib/internal/Magento/Framework/DB/MapperFactory.php
new file mode 100644
index 0000000000000000000000000000000000000000..fb8c490d90edba2c5ec6266198ed63776fa90eb2
--- /dev/null
+++ b/lib/internal/Magento/Framework/DB/MapperFactory.php
@@ -0,0 +1,62 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Framework\DB;
+
+/**
+ * Class MapperFactory
+ * @package Magento\Framework\DB
+ */
+class MapperFactory
+{
+ /**
+ * @var \Magento\Framework\ObjectManagerInterface
+ */
+ protected $objectManager;
+
+ /**
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
+ */
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
+ {
+ $this->objectManager = $objectManager;
+ }
+
+ /**
+ * Create Mapper object
+ *
+ * @param string $className
+ * @param array $arguments
+ * @return MapperInterface
+ * @throws \Magento\Framework\Exception
+ */
+ public function create($className, array $arguments = [])
+ {
+ $mapper = $this->objectManager->create($className, $arguments);
+ if (!$mapper instanceof MapperInterface) {
+ throw new \Magento\Framework\Exception($className . ' doesn\'t implement \Magento\Framework\DB\MapperInterface');
+ }
+ return $mapper;
+ }
+}
diff --git a/lib/internal/Magento/Framework/DB/MapperInterface.php b/lib/internal/Magento/Framework/DB/MapperInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..c4afcff329a9022918f42e22bf8dfa008d980c1e
--- /dev/null
+++ b/lib/internal/Magento/Framework/DB/MapperInterface.php
@@ -0,0 +1,109 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\DB;
+
+/**
+ * Interface MapperInterface
+ */
+interface MapperInterface
+{
+ const SORT_ORDER_ASC = 'ASC';
+
+ const SORT_ORDER_DESC = 'DESC';
+
+ /**
+ * Map criteria to Select Query Object
+ *
+ * @param \Magento\Framework\Api\CriteriaInterface $criteria
+ * @return Select
+ */
+ public function map(\Magento\Framework\Api\CriteriaInterface $criteria);
+
+ /**
+ * Get resource instance
+ *
+ * @return \Magento\Framework\Model\Resource\Db\AbstractDb
+ */
+ public function getResource();
+
+ /**
+ * Add attribute expression (SUM, COUNT, etc)
+ * Example: ('sub_total', 'SUM({{attribute}})', 'revenue')
+ * Example: ('sub_total', 'SUM({{revenue}})', 'revenue')
+ * For some functions like SUM use groupByAttribute.
+ *
+ * @param string $alias
+ * @param string $expression
+ * @param array|string $fields
+ * @return $this
+ */
+ public function addExpressionFieldToSelect($alias, $expression, $fields);
+
+ /**
+ * Add field filter to collection
+ *
+ * If $condition integer or string - exact value will be filtered ('eq' condition)
+ *
+ * If $condition is array - one of the following structures is expected:
+ * <pre>
+ * - ["from" => $fromValue, "to" => $toValue]
+ * - ["eq" => $equalValue]
+ * - ["neq" => $notEqualValue]
+ * - ["like" => $likeValue]
+ * - ["in" => [$inValues]]
+ * - ["nin" => [$notInValues]]
+ * - ["notnull" => $valueIsNotNull]
+ * - ["null" => $valueIsNull]
+ * - ["moreq" => $moreOrEqualValue]
+ * - ["gt" => $greaterValue]
+ * - ["lt" => $lessValue]
+ * - ["gteq" => $greaterOrEqualValue]
+ * - ["lteq" => $lessOrEqualValue]
+ * - ["finset" => $valueInSet]
+ * </pre>
+ *
+ * If non matched - sequential parallel arrays are expected and OR conditions
+ * will be built using above mentioned structure.
+ *
+ * Example:
+ * <pre>
+ * $field = ['age', 'name'];
+ * $condition = [42, ['like' => 'Mage']];
+ * </pre>
+ * The above would find where age equal to 42 OR name like %Mage%.
+ *
+ * @param string|array $field
+ * @param string|int|array $condition
+ * @throws \Magento\Framework\Exception if some error in the input could be detected.
+ * @return void
+ */
+ public function addFieldToFilter($field, $condition = null);
+
+ /**
+ * Reset Select object state
+ *
+ * @return void
+ */
+ public function reset();
+}
diff --git a/lib/internal/Magento/Framework/DB/Query.php b/lib/internal/Magento/Framework/DB/Query.php
new file mode 100644
index 0000000000000000000000000000000000000000..d14d3ccc9f2c92fc8e5887427d6d02ef1ef1686e
--- /dev/null
+++ b/lib/internal/Magento/Framework/DB/Query.php
@@ -0,0 +1,301 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\DB;
+
+use Magento\Framework\Logger;
+
+/**
+ * Class Query
+ */
+class Query implements QueryInterface
+{
+ /**
+ * Select object
+ *
+ * @var \Magento\Framework\DB\Select
+ */
+ protected $select;
+
+ /**
+ * @var \Magento\Framework\Api\CriteriaInterface
+ */
+ protected $criteria;
+
+ /**
+ * Resource instance
+ *
+ * @var \Magento\Framework\Model\Resource\Db\AbstractDb
+ */
+ protected $resource;
+
+ /**
+ * Database's statement for fetch item one by one
+ *
+ * @var \Zend_Db_Statement_Pdo
+ */
+ protected $fetchStmt = null;
+
+ /**
+ * @var Logger
+ */
+ protected $logger;
+
+ /**
+ * @var \Magento\Framework\Data\Collection\Db\FetchStrategyInterface
+ */
+ private $fetchStrategy;
+
+ /**
+ * @var array
+ */
+ protected $bindParams = [];
+
+ /**
+ * @var int
+ */
+ protected $totalRecords;
+
+ /**
+ * @var mixed
+ */
+ protected $data;
+
+ /**
+ * Query Select Parts to be skipped when prepare query for count
+ *
+ * @var array
+ */
+ protected $countSqlSkipParts = [
+ \Zend_Db_Select::ORDER => true,
+ \Zend_Db_Select::LIMIT_COUNT => true,
+ \Zend_Db_Select::LIMIT_OFFSET => true,
+ \Zend_Db_Select::COLUMNS => true
+ ];
+
+ /**
+ * @param \Magento\Framework\DB\Select $select
+ * @param \Magento\Framework\Api\CriteriaInterface $criteria
+ * @param \Magento\Framework\Model\Resource\Db\AbstractDb $resource
+ * @param \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy
+ */
+ public function __construct(
+ \Magento\Framework\DB\Select $select,
+ \Magento\Framework\Api\CriteriaInterface $criteria,
+ \Magento\Framework\Model\Resource\Db\AbstractDb $resource,
+ \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy
+ ) {
+ $this->select = $select;
+ $this->criteria = $criteria;
+ $this->resource = $resource;
+ $this->fetchStrategy = $fetchStrategy;
+ }
+
+ /**
+ * Retrieve source Criteria object
+ *
+ * @return \Magento\Framework\Api\CriteriaInterface
+ */
+ public function getCriteria()
+ {
+ return $this->criteria;
+ }
+
+ /**
+ * Retrieve all ids for query
+ *
+ * @return array
+ */
+ public function getAllIds()
+ {
+ $idsSelect = clone $this->getSelect();
+ $idsSelect->reset(\Zend_Db_Select::ORDER);
+ $idsSelect->reset(\Zend_Db_Select::LIMIT_COUNT);
+ $idsSelect->reset(\Zend_Db_Select::LIMIT_OFFSET);
+ $idsSelect->reset(\Zend_Db_Select::COLUMNS);
+ $idsSelect->columns($this->getResource()->getIdFieldName(), 'main_table');
+ return $this->getConnection()->fetchCol($idsSelect, $this->bindParams);
+ }
+
+ /**
+ * Add variable to bind list
+ *
+ * @param string $name
+ * @param mixed $value
+ * @return void
+ */
+ public function addBindParam($name, $value)
+ {
+ $this->bindParams[$name] = $value;
+ }
+
+ /**
+ * Get collection size
+ *
+ * @return int
+ */
+ public function getSize()
+ {
+ if (is_null($this->totalRecords)) {
+ $sql = $this->getSelectCountSql();
+ $this->totalRecords = $this->getConnection()->fetchOne($sql, $this->bindParams);
+ }
+ return intval($this->totalRecords);
+ }
+
+ /**
+ * Get sql select string or object
+ *
+ * @param bool $stringMode
+ * @return string || Select
+ */
+ public function getSelectSql($stringMode = false)
+ {
+ if ($stringMode) {
+ return $this->select->__toString();
+ }
+ return $this->select;
+ }
+
+ /**
+ * Reset Statement object
+ *
+ * @return void
+ */
+ public function reset()
+ {
+ $this->fetchStmt = null;
+ $this->data = null;
+ }
+
+ /**
+ * Fetch all statement
+ *
+ * @return array
+ */
+ public function fetchAll()
+ {
+ if ($this->data === null) {
+ $select = $this->getSelect();
+ $this->data = $this->fetchStrategy->fetchAll($select, $this->bindParams);
+ }
+ return $this->data;
+ }
+
+ /**
+ * Fetch statement
+ *
+ * @return mixed
+ */
+ public function fetchItem()
+ {
+ if (null === $this->fetchStmt) {
+ $this->fetchStmt = $this->getConnection()->query($this->getSelect(), $this->bindParams);
+ }
+ $data = $this->fetchStmt->fetch();
+ if (!$data) {
+ $data = [];
+ }
+ return $data;
+ }
+
+ /**
+ * Get Identity Field Name
+ *
+ * @return string
+ */
+ public function getIdFieldName()
+ {
+ return $this->getResource()->getIdFieldName();
+ }
+
+ /**
+ * Retrieve connection object
+ *
+ * @return \Magento\Framework\DB\Adapter\AdapterInterface
+ */
+ public function getConnection()
+ {
+ return $this->getSelect()->getAdapter();
+ }
+
+ /**
+ * Get resource instance
+ *
+ * @return \Magento\Framework\Model\Resource\Db\AbstractDb
+ */
+ public function getResource()
+ {
+ return $this->resource;
+ }
+
+ /**
+ * Add Select Part to skip from count query
+ *
+ * @param string $name
+ * @param bool $toSkip
+ * @return void
+ */
+ public function addCountSqlSkipPart($name, $toSkip = true)
+ {
+ $this->countSqlSkipParts[$name] = $toSkip;
+ }
+
+ /**
+ * Get SQL for get record count
+ *
+ * @return Select
+ */
+ protected function getSelectCountSql()
+ {
+ $countSelect = clone $this->getSelect();
+ foreach ($this->getCountSqlSkipParts() as $part => $toSkip) {
+ if ($toSkip) {
+ $countSelect->reset($part);
+ }
+ }
+ $countSelect->columns('COUNT(*)');
+
+ return $countSelect;
+ }
+
+ /**
+ * Returned count SQL skip parts
+ *
+ * @return array
+ */
+ protected function getCountSqlSkipParts()
+ {
+ return $this->countSqlSkipParts;
+ }
+
+ /**
+ * Get \Magento\Framework\DB\Select object instance
+ *
+ * @return Select
+ */
+ protected function getSelect()
+ {
+ return $this->select;
+ }
+}
diff --git a/lib/internal/Magento/Framework/DB/QueryBuilder.php b/lib/internal/Magento/Framework/DB/QueryBuilder.php
new file mode 100644
index 0000000000000000000000000000000000000000..e77e7173e1b93f56354de8c50422fc73aa8ee352
--- /dev/null
+++ b/lib/internal/Magento/Framework/DB/QueryBuilder.php
@@ -0,0 +1,114 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\DB;
+
+/**
+ * Class QueryBuilder
+ */
+class QueryBuilder
+{
+ /**
+ * Select object
+ *
+ * @var \Magento\Framework\DB\Select
+ */
+ protected $select;
+
+ /**
+ * @var \Magento\Framework\Api\CriteriaInterface
+ */
+ protected $criteria;
+
+ /**
+ * Resource instance
+ *
+ * @var \Magento\Framework\Model\Resource\Db\AbstractDb
+ */
+ protected $resource;
+
+ /**
+ * @var \Magento\Framework\DB\MapperFactory
+ */
+ protected $mapperFactory;
+
+ /**
+ * @var \Magento\Framework\DB\QueryFactory
+ */
+ protected $queryFactory;
+
+ /**
+ * @param \Magento\Framework\DB\MapperFactory $mapperFactory
+ * @param \Magento\Framework\DB\QueryFactory $queryFactory
+ */
+ public function __construct(
+ \Magento\Framework\DB\MapperFactory $mapperFactory,
+ \Magento\Framework\DB\QueryFactory $queryFactory
+ ) {
+ $this->mapperFactory = $mapperFactory;
+ $this->queryFactory = $queryFactory;
+ }
+
+ /**
+ * Set source Criteria
+ *
+ * @param \Magento\Framework\Api\CriteriaInterface $criteria
+ * @return void
+ */
+ public function setCriteria(\Magento\Framework\Api\CriteriaInterface $criteria)
+ {
+ $this->criteria = $criteria;
+ }
+
+ /**
+ * Set Resource
+ *
+ * @param \Magento\Framework\Model\Resource\Db\AbstractDb $resource
+ * @return void
+ */
+ public function setResource(\Magento\Framework\Model\Resource\Db\AbstractDb $resource)
+ {
+ $this->resource = $resource;
+ }
+
+ /**
+ * @return \Magento\Framework\DB\QueryInterface
+ * @throws \Magento\Framework\Exception
+ */
+ public function create()
+ {
+ $mapper = $this->criteria->getMapperInterfaceName();
+ $mapperInstance = $this->mapperFactory->create($mapper);
+ $select = $mapperInstance->map($this->criteria);
+ $query = $this->queryFactory->create(
+ 'Magento\Framework\DB\Query',
+ [
+ 'select' => $select,
+ 'criteria' => $this->criteria,
+ 'resource' => $this->resource
+ ]
+ );
+
+ return $query;
+ }
+}
diff --git a/lib/internal/Magento/Framework/DB/QueryFactory.php b/lib/internal/Magento/Framework/DB/QueryFactory.php
new file mode 100644
index 0000000000000000000000000000000000000000..1885e0ff84c3b1473b49ca66240d095cb8c8d9a0
--- /dev/null
+++ b/lib/internal/Magento/Framework/DB/QueryFactory.php
@@ -0,0 +1,60 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\DB;
+
+/**
+ * Class QueryFactory
+ */
+class QueryFactory
+{
+ /**
+ * @var \Magento\Framework\ObjectManagerInterface
+ */
+ protected $objectManager;
+
+ /**
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
+ */
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
+ {
+ $this->objectManager = $objectManager;
+ }
+
+ /**
+ * Create Query object
+ *
+ * @param string $className
+ * @param array $arguments
+ * @return QueryInterface
+ * @throws \Magento\Framework\Exception
+ */
+ public function create($className, array $arguments = [])
+ {
+ $query = $this->objectManager->create($className, $arguments);
+ if (!$query instanceof QueryInterface) {
+ throw new \Magento\Framework\Exception($className . ' doesn\'t implement \Magento\Framework\DB\QueryInterface');
+ }
+ return $query;
+ }
+}
diff --git a/lib/internal/Magento/Framework/DB/QueryInterface.php b/lib/internal/Magento/Framework/DB/QueryInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..d8adfc572fb5868fef68d010eecac7e00c13c48c
--- /dev/null
+++ b/lib/internal/Magento/Framework/DB/QueryInterface.php
@@ -0,0 +1,119 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\DB;
+
+/**
+ * Class QueryInterface
+ */
+interface QueryInterface
+{
+ /**
+ * Retrieve source Criteria object
+ *
+ * @return \Magento\Framework\Api\CriteriaInterface
+ */
+ public function getCriteria();
+
+ /**
+ * Retrieve all ids for query
+ *
+ * @return array
+ */
+ public function getAllIds();
+
+ /**
+ * Add variable to bind list
+ *
+ * @param string $name
+ * @param mixed $value
+ * @return void
+ */
+ public function addBindParam($name, $value);
+
+ /**
+ * Get collection size
+ *
+ * @return int
+ */
+ public function getSize();
+
+ /**
+ * Get sql select string or object
+ *
+ * @param bool $stringMode
+ * @return string || Select
+ */
+ public function getSelectSql($stringMode = false);
+
+ /**
+ * Reset Statement object
+ *
+ * @return void
+ */
+ public function reset();
+
+ /**
+ * Fetch all statement
+ *
+ * @return array
+ */
+ public function fetchAll();
+
+ /**
+ * Fetch statement
+ *
+ * @return mixed
+ */
+ public function fetchItem();
+
+ /**
+ * Get Identity Field Name
+ *
+ * @return string
+ */
+ public function getIdFieldName();
+
+ /**
+ * Retrieve connection object
+ *
+ * @return \Magento\Framework\DB\Adapter\AdapterInterface
+ */
+ public function getConnection();
+
+ /**
+ * Get resource instance
+ *
+ * @return \Magento\Framework\Model\Resource\Db\AbstractDb
+ */
+ public function getResource();
+
+ /**
+ * Add Select Part to skip from count query
+ *
+ * @param string $name
+ * @param bool $toSkip
+ * @return void
+ */
+ public function addCountSqlSkipPart($name, $toSkip = true);
+}
diff --git a/lib/internal/Magento/Framework/Data/AbstractCriteria.php b/lib/internal/Magento/Framework/Data/AbstractCriteria.php
new file mode 100644
index 0000000000000000000000000000000000000000..1f0eb45f28bc2c506be8b8fb64e00f5ce4f152bc
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/AbstractCriteria.php
@@ -0,0 +1,314 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+use Magento\Framework\Object;
+
+/**
+ * Class AbstractCriteria
+ */
+abstract class AbstractCriteria implements \Magento\Framework\Api\CriteriaInterface
+{
+ /**
+ * @var array
+ */
+ protected $data = [
+ self::PART_FIELDS => ['list' => []],
+ self::PART_FILTERS => ['list' => []],
+ self::PART_ORDERS => ['list' => []],
+ self::PART_CRITERIA_LIST => ['list' => []],
+ self::PART_LIMIT => [1, 0]
+ ];
+
+ /**
+ * @var string
+ */
+ protected $mapperInterfaceName;
+
+ /**
+ * Get associated Mapper Interface name
+ *
+ * @throws \Exception
+ * @return string
+ */
+ public function getMapperInterfaceName()
+ {
+ if (!$this->mapperInterfaceName) {
+ throw new \Exception(__("Missed Mapper Interface for Criteria Interface: ") . get_class($this));
+ }
+ return $this->mapperInterfaceName;
+ }
+
+ /**
+ * Add field to select
+ *
+ * @param string|array $field
+ * @param string|null $alias
+ * @return void
+ */
+ public function addField($field, $alias = null)
+ {
+ if ($field === '*') {
+ $this->data[self::PART_FIELDS]['list'] = [$field];
+ } else {
+ if (is_array($field)) {
+ foreach ($field as $key => $value) {
+ $this->addField($value, is_string($key) ? $key : null);
+ }
+ } else {
+ if ($alias === null) {
+ $this->data[self::PART_FIELDS]['list'][$field] = $field;
+ } else {
+ $this->data[self::PART_FIELDS]['list'][$alias] = $field;
+ }
+ }
+ }
+ }
+
+ /**
+ * Add field filter to collection
+ *
+ * If $condition integer or string - exact value will be filtered ('eq' condition)
+ *
+ * If $condition is array - one of the following structures is expected:
+ * <pre>
+ * - ["from" => $fromValue, "to" => $toValue]
+ * - ["eq" => $equalValue]
+ * - ["neq" => $notEqualValue]
+ * - ["like" => $likeValue]
+ * - ["in" => [$inValues]]
+ * - ["nin" => [$notInValues]]
+ * - ["notnull" => $valueIsNotNull]
+ * - ["null" => $valueIsNull]
+ * - ["moreq" => $moreOrEqualValue]
+ * - ["gt" => $greaterValue]
+ * - ["lt" => $lessValue]
+ * - ["gteq" => $greaterOrEqualValue]
+ * - ["lteq" => $lessOrEqualValue]
+ * - ["finset" => $valueInSet]
+ * </pre>
+ *
+ * If non matched - sequential parallel arrays are expected and OR conditions
+ * will be built using above mentioned structure.
+ *
+ * Example:
+ * <pre>
+ * $field = ['age', 'name'];
+ * $condition = [42, ['like' => 'Mage']];
+ * $type = 'or';
+ * </pre>
+ * The above would find where age equal to 42 OR name like %Mage%.
+ *
+ * @param string $name
+ * @param string|array $field
+ * @param string|int|array $condition
+ * @param string $type
+ * @throws \Exception
+ * @return void
+ */
+ public function addFilter($name, $field, $condition = null, $type = 'and')
+ {
+ if (isset($this->data[self::PART_FILTERS]['list'][$name])) {
+ throw new \Exception(__("Filter already exists in Criteria object: ") . $name);
+ }
+ $filter = new Object();
+ // implements ArrayAccess
+ $filter['name'] = $name;
+ $filter['field'] = $field;
+ $filter['condition'] = $condition;
+ $filter['type'] = strtolower($type);
+ $this->data[self::PART_FILTERS]['list'][$name] = $filter;
+ }
+
+ /**
+ * self::setOrder() alias
+ *
+ * @param string $field
+ * @param string $direction
+ * @param bool $unShift
+ * @return void
+ */
+ public function addOrder($field, $direction = self::SORT_ORDER_DESC, $unShift = false)
+ {
+ $direction = strtoupper($direction) == self::SORT_ORDER_ASC ? self::SORT_ORDER_ASC : self::SORT_ORDER_DESC;
+ unset($this->data[self::PART_ORDERS]['list'][$field]);
+ // avoid ordering by the same field twice
+ if ($unShift) {
+ $orders = [$field => $direction];
+ foreach ($this->data[self::PART_ORDERS]['list'] as $key => $dir) {
+ $orders[$key] = $dir;
+ }
+ $this->data[self::PART_ORDERS]['list'] = $orders;
+ } else {
+ $this->data[self::PART_ORDERS]['list'][$field] = $direction;
+ }
+ }
+
+ /**
+ * Set Query limit
+ *
+ * @param int $offset
+ * @param int $size
+ * @return void
+ */
+ public function setLimit($offset, $size)
+ {
+ $this->data[self::PART_LIMIT] = [$offset, $size];
+ }
+
+ /**
+ * Removes field from select
+ *
+ * @param string|null $field
+ * @param bool $isAlias Alias identifier
+ * @return void
+ */
+ public function removeField($field, $isAlias = false)
+ {
+ if ($isAlias) {
+ if (isset($this->data[self::PART_FIELDS]['list'][$field])) {
+ unset($this->data[self::PART_FIELDS]['list'][$field]);
+ }
+ } else {
+ foreach ($this->data[self::PART_FIELDS]['list'] as $key => $value) {
+ if ($value === $field) {
+ unset($this->data[self::PART_FIELDS]['list'][$key]);
+ break;
+ }
+ }
+ }
+ }
+
+ /**
+ * Removes all fields from select
+ *
+ * @return void
+ */
+ public function removeAllFields()
+ {
+ $this->data[self::PART_FIELDS]['list'] = [];
+ }
+
+ /**
+ * Removes filter by name
+ *
+ * @param string $name
+ * @return void
+ */
+ public function removeFilter($name)
+ {
+ if (isset($this->data[self::PART_FILTERS]['list'][$name])) {
+ unset($this->data[self::PART_FILTERS]['list'][$name]);
+ }
+ }
+
+ /**
+ * Removes all filters
+ *
+ * @return void
+ */
+ public function removeAllFilters()
+ {
+ $this->data[self::PART_FILTERS]['list'] = [];
+ }
+
+ /**
+ * Get Criteria objects added to current Composite Criteria
+ *
+ * @return array
+ */
+ public function getCriteriaList()
+ {
+ return $this->data[self::PART_CRITERIA_LIST]['list'];
+ }
+
+ /**
+ * Get list of filters
+ *
+ * @return array
+ */
+ public function getFilters()
+ {
+ return $this->data[self::PART_FILTERS]['list'];
+ }
+
+ /**
+ * Get ordering criteria
+ *
+ * @return array
+ */
+ public function getOrders()
+ {
+ return $this->data[self::PART_ORDERS]['list'];
+ }
+
+ /**
+ * Get limit
+ * (['offset', 'page'])
+ *
+ * @return array
+ */
+ public function getLimit()
+ {
+ return $this->data[self::PART_LIMIT];
+ }
+
+ /**
+ * Retrieve criteria part
+ *
+ * @param string $name
+ * @param mixed $default
+ * @return mixed
+ */
+ public function getPart($name, $default = null)
+ {
+ return isset($this->data[$name]) ? $this->data[$name] : $default;
+ }
+
+ /**
+ * Return all criteria parts as array
+ *
+ * @return array
+ */
+ public function toArray()
+ {
+ return $this->data;
+ }
+
+ /**
+ * Reset criteria
+ *
+ * @return void
+ */
+ public function reset()
+ {
+ $this->data = [
+ self::PART_FIELDS => ['list' => []],
+ self::PART_FILTERS => ['list' => []],
+ self::PART_ORDERS => ['list' => []],
+ self::PART_CRITERIA_LIST => ['list' => []],
+ self::PART_LIMIT => [1, 0]
+ ];
+ }
+}
diff --git a/lib/internal/Magento/Framework/Data/AbstractDataObject.php b/lib/internal/Magento/Framework/Data/AbstractDataObject.php
new file mode 100644
index 0000000000000000000000000000000000000000..b001ec12fa068243c8036ce71fe7f6b7d262fa32
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/AbstractDataObject.php
@@ -0,0 +1,73 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+/**
+ * Base Class for simple data Objects
+ * @SuppressWarnings(PHPMD.NumberOfChildren)
+ */
+abstract class AbstractDataObject
+{
+ /**
+ * @var array
+ */
+ protected $data;
+
+ /**
+ * Return Data Object data in array format.
+ *
+ * @return array
+ */
+ public function toArray()
+ {
+ $data = $this->data;
+ $hasToArray = function ($model) {
+ return is_object($model) && method_exists($model, 'toArray') && is_callable([$model, 'toArray']);
+ };
+ foreach ($data as $key => $value) {
+ if ($hasToArray($value)) {
+ $data[$key] = $value->toArray();
+ } elseif (is_array($value)) {
+ foreach ($value as $nestedKey => $nestedValue) {
+ if ($hasToArray($nestedValue)) {
+ $value[$nestedKey] = $nestedValue->toArray();
+ }
+ }
+ $data[$key] = $value;
+ }
+ }
+ return $data;
+ }
+
+ /**
+ * Retrieves a value from the data array if set, or null otherwise.
+ *
+ * @param string $key
+ * @return mixed|null
+ */
+ protected function get($key)
+ {
+ return isset($this->data[$key]) ? $this->data[$key] : null;
+ }
+}
diff --git a/lib/internal/Magento/Framework/Data/AbstractSearchCriteriaBuilder.php b/lib/internal/Magento/Framework/Data/AbstractSearchCriteriaBuilder.php
new file mode 100644
index 0000000000000000000000000000000000000000..3dd30791172130487a3f8a1fc1316e04fbc30e1d
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/AbstractSearchCriteriaBuilder.php
@@ -0,0 +1,77 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+use Magento\Framework\Logger;
+
+/**
+ * Class AbstractSearchCriteriaBuilder
+ * @package Magento\Framework\Data
+ */
+abstract class AbstractSearchCriteriaBuilder
+{
+ /**
+ * @var ObjectFactory
+ */
+ protected $objectFactory;
+
+ /**
+ * @var string
+ */
+ protected $resultObjectInterface;
+
+ /**
+ * @param Logger $logger
+ * @param ObjectFactory $objectFactory,
+ */
+ public function __construct(
+ Logger $logger,
+ ObjectFactory $objectFactory
+ ) {
+ $this->objectFactory = $objectFactory;
+ $this->logger = $logger;
+ $this->init();
+ }
+
+ /**
+ * @return string
+ */
+ abstract protected function init();
+
+ /**
+ * @return string
+ */
+ protected function getResultObjectInterface()
+ {
+ return $this->resultObjectInterface;
+ }
+
+ /**
+ * @return SearchResultInterface
+ */
+ public function make()
+ {
+ return $this->objectFactory->create($this->getResultObjectInterface(), ['queryBuilder' => $this]);
+ }
+}
diff --git a/lib/internal/Magento/Framework/Data/AbstractSearchResult.php b/lib/internal/Magento/Framework/Data/AbstractSearchResult.php
new file mode 100644
index 0000000000000000000000000000000000000000..52739c6fac608602d408f2a25812f296ee7492e7
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/AbstractSearchResult.php
@@ -0,0 +1,319 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+use Magento\Framework\Logger;
+
+/**
+ * Class AbstractSearchResult
+ */
+abstract class AbstractSearchResult extends AbstractDataObject implements SearchResultInterface
+{
+ /**
+ * Data Interface name
+ *
+ * @var string
+ */
+ protected $dataInterface = 'Magento\Framework\Object';
+
+ /**
+ * Name prefix of events that are dispatched by model
+ *
+ * @var string
+ */
+ protected $eventPrefix = '';
+
+ /**
+ * Name of event parameter
+ *
+ * @var string
+ */
+ protected $eventObject = '';
+
+ /**
+ * Event manager proxy
+ *
+ * @var \Magento\Framework\Event\ManagerInterface
+ */
+ protected $eventManager = null;
+
+ /**
+ * Total items number
+ *
+ * @var int
+ */
+ protected $totalRecords;
+
+ /**
+ * Loading state flag
+ *
+ * @var bool
+ */
+ protected $isLoaded;
+
+ /**
+ * @var \Magento\Framework\Data\Collection\EntityFactoryInterface
+ */
+ protected $entityFactory;
+
+ /**
+ * @var \Magento\Framework\DB\Select
+ */
+ protected $select;
+
+ /**
+ * @var \Magento\Framework\Data\SearchResultIteratorFactory
+ */
+ protected $resultIteratorFactory;
+
+ /**
+ * @param \Magento\Framework\DB\QueryInterface $query
+ * @param \Magento\Framework\Data\Collection\EntityFactoryInterface $entityFactory
+ * @param \Magento\Framework\Event\ManagerInterface $eventManager
+ * @param \Magento\Framework\Data\SearchResultIteratorFactory $resultIteratorFactory
+ */
+ public function __construct(
+ \Magento\Framework\DB\QueryInterface $query,
+ \Magento\Framework\Data\Collection\EntityFactoryInterface $entityFactory,
+ \Magento\Framework\Event\ManagerInterface $eventManager,
+ \Magento\Framework\Data\SearchResultIteratorFactory $resultIteratorFactory
+ ) {
+ $this->query = $query;
+ $this->eventManager = $eventManager;
+ $this->entityFactory = $entityFactory;
+ $this->resultIteratorFactory = $resultIteratorFactory;
+ $this->init();
+ }
+
+ /**
+ * Standard query builder initialization
+ *
+ * @return void
+ */
+ abstract protected function init();
+
+ /**
+ * @return \Magento\Framework\Object[]
+ */
+ public function getItems()
+ {
+ $this->load();
+ return $this->data['items'];
+ }
+
+ /**
+ * @return int
+ */
+ public function getTotalCount()
+ {
+ if (!isset($this->data['total_count'])) {
+ $this->data['total_count'] = $this->query->getSize();
+ }
+ return $this->data['total_count'];
+ }
+
+ /**
+ * @return \Magento\Framework\Api\CriteriaInterface
+ */
+ public function getSearchCriteria()
+ {
+ if (!isset($this->data['search_criteria'])) {
+ $this->data['search_criteria'] = $this->query->getCriteria();
+ }
+ return $this->data['search_criteria'];
+ }
+
+ /**
+ * @return \Magento\Framework\Data\SearchResultIterator
+ */
+ public function createIterator()
+ {
+ return $this->resultIteratorFactory->create(
+ [
+ 'searchResult' => $this,
+ 'query' => $this->query
+ ]
+ );
+ }
+
+ /**
+ * @param array $arguments
+ * @return \Magento\Framework\Object|mixed
+ */
+ public function createDataObject(array $arguments = [])
+ {
+ return $this->entityFactory->create($this->getDataInterfaceName(), $arguments);
+ }
+
+ /**
+ * @return string
+ */
+ public function getIdFieldName()
+ {
+ return $this->query->getIdFieldName();
+ }
+
+ /**
+ * @return int
+ */
+ public function getSize()
+ {
+ return $this->query->getSize();
+ }
+
+ /**
+ * Get collection item identifier
+ *
+ * @param \Magento\Framework\Object $item
+ * @return mixed
+ */
+ public function getItemId(\Magento\Framework\Object $item)
+ {
+ $field = $this->query->getIdFieldName();
+ if ($field) {
+ return $item->getData($field);
+ }
+ return $item->getId();
+ }
+
+ /**
+ * @return bool
+ */
+ protected function isLoaded()
+ {
+ return $this->isLoaded;
+ }
+
+ /**
+ * Load data
+ *
+ * @return void
+ */
+ protected function load()
+ {
+ if (!$this->isLoaded()) {
+ $this->beforeLoad();
+ $data = $this->query->fetchAll();
+ $this->data['items'] = [];
+ if (is_array($data)) {
+ foreach ($data as $row) {
+ $item = $this->createDataObject(['data' => $row]);
+ $this->addItem($item);
+ }
+ }
+ $this->setIsLoaded(true);
+ $this->afterLoad();
+ }
+ }
+
+ /**
+ * Set loading status flag
+ *
+ * @param bool $flag
+ * @return void
+ */
+ protected function setIsLoaded($flag = true)
+ {
+ $this->isLoaded = $flag;
+ }
+
+ /**
+ * Adding item to item array
+ *
+ * @param \Magento\Framework\Object $item
+ * @return void
+ * @throws \Exception
+ */
+ protected function addItem(\Magento\Framework\Object $item)
+ {
+ $itemId = $this->getItemId($item);
+ if (!is_null($itemId)) {
+ if (isset($this->data['items'][$itemId])) {
+ throw new \Exception(
+ 'Item (' . get_class($item) . ') with the same id "' . $item->getId() . '" already exist'
+ );
+ }
+ $this->data['items'][$itemId] = $item;
+ } else {
+ $this->data['items'][] = $item;
+ }
+ }
+
+ /**
+ * Dispatch "before" load method events
+ *
+ * @return void
+ */
+ protected function beforeLoad()
+ {
+ $this->eventManager->dispatch('abstract_search_result_load_before', ['collection' => $this]);
+ if ($this->eventPrefix && $this->eventObject) {
+ $this->eventManager->dispatch($this->eventPrefix . '_load_before', [$this->eventObject => $this]);
+ }
+ }
+
+ /**
+ * Dispatch "after" load method events
+ *
+ * @return void
+ */
+ protected function afterLoad()
+ {
+ $this->eventManager->dispatch('abstract_search_result_load_after', ['collection' => $this]);
+ if ($this->eventPrefix && $this->eventObject) {
+ $this->eventManager->dispatch($this->eventPrefix . '_load_after', [$this->eventObject => $this]);
+ }
+ }
+
+ /**
+ * Set Data Interface name for collection items
+ *
+ * @param string $dataInterface
+ * @return void
+ */
+ protected function setDataInterfaceName($dataInterface)
+ {
+ if (is_string($dataInterface)) {
+ $this->dataInterface = $dataInterface;
+ }
+ }
+
+ /**
+ * Get Data Interface name for collection items
+ *
+ * @return string
+ */
+ protected function getDataInterfaceName()
+ {
+ return $this->dataInterface;
+ }
+
+ /**
+ * @return \Magento\Framework\DB\QueryInterface
+ */
+ protected function getQuery()
+ {
+ return $this->query;
+ }
+}
diff --git a/lib/internal/Magento/Framework/Data/Argument/Interpreter/Composite.php b/lib/internal/Magento/Framework/Data/Argument/Interpreter/Composite.php
index 5749e4598b3170acfaf316f13d92e2353372a6d6..91b2bb52c5a2f195d21cc243d7cb256979443ffd 100644
--- a/lib/internal/Magento/Framework/Data/Argument/Interpreter/Composite.php
+++ b/lib/internal/Magento/Framework/Data/Argument/Interpreter/Composite.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\Data\Argument\Interpreter;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\Data\Argument\InterpreterInterface;
/**
diff --git a/lib/internal/Magento/Framework/Data/Collection.php b/lib/internal/Magento/Framework/Data/Collection.php
index b472896d44e5a7485c91bb26112ea5b14c6189d2..f4b275154e3dd9c4ef9b13865a44ca3ef18d5970 100644
--- a/lib/internal/Magento/Framework/Data/Collection.php
+++ b/lib/internal/Magento/Framework/Data/Collection.php
@@ -24,6 +24,7 @@
namespace Magento\Framework\Data;
use Magento\Framework\Data\Collection\EntityFactoryInterface;
+use Magento\Framework\Option\ArrayInterface;
/**
* Data collection
@@ -35,7 +36,7 @@ use Magento\Framework\Data\Collection\EntityFactoryInterface;
* TODO: Refactor use of \Magento\Framework\Option\ArrayInterface in library. Probably will be refactored while
* moving \Magento\Core to library
*/
-class Collection implements \IteratorAggregate, \Countable, \Magento\Framework\Option\ArrayInterface
+class Collection implements \IteratorAggregate, \Countable, ArrayInterface, DataSourceInterface
{
const SORT_ORDER_ASC = 'ASC';
diff --git a/lib/internal/Magento/Framework/Data/CollectionBuilder/Field.php b/lib/internal/Magento/Framework/Data/CollectionBuilder/Field.php
new file mode 100644
index 0000000000000000000000000000000000000000..ccc4ae7de6713c870c6d5bbf02ffb16940eab419
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/CollectionBuilder/Field.php
@@ -0,0 +1,86 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Framework\Data\CollectionBuilder;
+
+use Magento\Framework\Api\AbstractExtensibleObject;
+
+class Field extends AbstractExtensibleObject
+{
+ const NAME = 'name';
+ const ALIAS = 'alias';
+ const TABLE_NAME = 'table_name';
+ const TABLE_ALIAS = 'table_alias';
+ const TABLE_JOIN_TYPE = 'table_join_type';
+
+ /**
+ * Returns a name of a field
+ *
+ * @return string
+ */
+ public function getName()
+ {
+ return $this->_get(self::NAME);
+ }
+
+ /**
+ * Returns an alias of a field
+ *
+ * @return string
+ */
+ public function getAlias()
+ {
+ return $this->_get(self::ALIAS);
+ }
+
+ /**
+ * Returns a name of a field's source table
+ *
+ * @return string
+ */
+ public function getTableName()
+ {
+ return $this->_get(self::TABLE_NAME);
+ }
+
+ /**
+ * Returns an alias of a name of a field's source table
+ *
+ * @return string
+ */
+ public function getTableAlias()
+ {
+ return $this->_get(self::TABLE_ALIAS);
+ }
+
+ /**
+ * Returns a field's source table join type
+ *
+ * @return string
+ */
+ public function getTableJoinType()
+ {
+ return $this->_get(self::TABLE_JOIN_TYPE);
+ }
+}
diff --git a/lib/internal/Magento/Framework/Data/CollectionBuilder/Filter.php b/lib/internal/Magento/Framework/Data/CollectionBuilder/Filter.php
new file mode 100644
index 0000000000000000000000000000000000000000..a27ce98a6a821e6f7525613aaf6054b88c334a2f
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/CollectionBuilder/Filter.php
@@ -0,0 +1,61 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Framework\Data\CollectionBuilder;
+
+/**
+ * Filter which can be used by any methods from service layer.
+ */
+class Filter extends \Magento\Framework\Api\AbstractExtensibleObject
+{
+ /**
+ * Get field
+ *
+ * @return string
+ */
+ public function getField()
+ {
+ return $this->_get('field');
+ }
+
+ /**
+ * Get value
+ *
+ * @return string
+ */
+ public function getValue()
+ {
+ return $this->_get('value');
+ }
+
+ /**
+ * Get condition type
+ *
+ * @return string|null
+ */
+ public function getConditionType()
+ {
+ return $this->_get('condition_type');
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/Data/LowStockCriteriaBuilder.php b/lib/internal/Magento/Framework/Data/CollectionBuilder/FilterBuilder.php
similarity index 61%
rename from app/code/Magento/CatalogInventory/Service/V1/Data/LowStockCriteriaBuilder.php
rename to lib/internal/Magento/Framework/Data/CollectionBuilder/FilterBuilder.php
index a8ce76f69e1835f72294bcd8e95b66041f0f4268..f6458d37ba2a2dbde2d6ee595530d881dd35c997 100644
--- a/app/code/Magento/CatalogInventory/Service/V1/Data/LowStockCriteriaBuilder.php
+++ b/lib/internal/Magento/Framework/Data/CollectionBuilder/FilterBuilder.php
@@ -21,45 +21,50 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\CatalogInventory\Service\V1\Data;
+namespace Magento\Framework\Data\CollectionBuilder;
+
+use Magento\Framework\Api\ExtensibleObjectBuilder;
/**
- * Low stock criteria builder
+ * Builder for Filter Service Data Object.
*
- * @codeCoverageIgnore
+ * @method Filter create()
*/
-class LowStockCriteriaBuilder extends \Magento\Framework\Api\ExtensibleObjectBuilder
+class FilterBuilder extends ExtensibleObjectBuilder
{
/**
- * Set page size
+ * Set field
*
- * @param float $qty
+ * @param string $field
* @return $this
*/
- public function setQty($qty)
+ public function setField($field)
{
- return $this->_set(LowStockCriteria::QTY, $qty);
+ $this->data['field'] = $field;
+ return $this;
}
/**
- * Set page size
+ * Set value
*
- * @param int $pageSize
+ * @param string $value
* @return $this
*/
- public function setPageSize($pageSize)
+ public function setValue($value)
{
- return $this->_set(LowStockCriteria::PAGE_SIZE, $pageSize);
+ $this->data['value'] = $value;
+ return $this;
}
/**
- * Set current page
+ * Set condition type
*
- * @param int $currentPage
+ * @param string $conditionType
* @return $this
*/
- public function setCurrentPage($currentPage)
+ public function setConditionType($conditionType)
{
- return $this->_set(LowStockCriteria::CURRENT_PAGE, $currentPage);
+ $this->data['condition_type'] = $conditionType;
+ return $this;
}
}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeUsedSortOnFrontend.php b/lib/internal/Magento/Framework/Data/CollectionBuilder/FilterGroup.php
similarity index 67%
rename from dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeUsedSortOnFrontend.php
rename to lib/internal/Magento/Framework/Data/CollectionBuilder/FilterGroup.php
index 806412f97d7f28ceb3d26bfe44c368e4d2c11b32..6d1932ad319123381c337ebad7fc88e956abb12b 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductAttributeUsedSortOnFrontend.php
+++ b/lib/internal/Magento/Framework/Data/CollectionBuilder/FilterGroup.php
@@ -22,35 +22,25 @@
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\Catalog\Test\Constraint;
+namespace Magento\Framework\Data\CollectionBuilder;
-use Mtf\Constraint\AbstractConstraint;
+use Magento\Framework\Model\AbstractExtensibleModel;
/**
- * Class AssertProductAttributeUsedSortOnFrontend
+ * Groups two or more filters together using a logical OR
*/
-class AssertProductAttributeUsedSortOnFrontend extends AbstractConstraint
+class FilterGroup extends AbstractExtensibleModel
{
- /**
- * Constraint severeness
- *
- * @var string
- */
- protected $severeness = 'low';
+ const FILTERS = 'filters';
/**
- * @return void
- */
- public function processAssert()
- {
- //
- }
-
- /**
- * @return string
+ * Returns a list of filters in this group
+ *
+ * @return Filter[]|null
*/
- public function toString()
+ public function getFilters()
{
- //
+ $filters = $this->_getData(self::FILTERS);
+ return is_null($filters) ? [] : $filters;
}
}
diff --git a/lib/internal/Magento/Framework/Data/CollectionBuilder/FilterGroupBuilder.php b/lib/internal/Magento/Framework/Data/CollectionBuilder/FilterGroupBuilder.php
new file mode 100644
index 0000000000000000000000000000000000000000..ea29d5850cff4efa529dc0a0a974c2a34569c47c
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/CollectionBuilder/FilterGroupBuilder.php
@@ -0,0 +1,95 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data\CollectionBuilder;
+
+use Magento\Framework\Api\AttributeDataBuilder;
+use Magento\Framework\Api\ExtensibleObjectBuilder;
+use Magento\Framework\Api\MetadataServiceInterface;
+
+/**
+ * Builder for FilterGroup Data.
+ */
+class FilterGroupBuilder extends ExtensibleObjectBuilder
+{
+ /**
+ * @var FilterBuilder
+ */
+ protected $_filterBuilder;
+
+ /**
+ * @param \Magento\Framework\Api\ObjectFactory $objectFactory
+ * @param AttributeDataBuilder $valueBuilder
+ * @param MetadataServiceInterface $metadataService
+ * @param FilterBuilder $filterBuilder
+ * @param null $modelClassInterface
+ */
+ public function __construct(
+ \Magento\Framework\Api\ObjectFactory $objectFactory,
+ AttributeDataBuilder $valueBuilder,
+ MetadataServiceInterface $metadataService,
+ FilterBuilder $filterBuilder,
+ $modelClassInterface = null
+ ) {
+ parent::__construct($objectFactory, $valueBuilder, $metadataService, $modelClassInterface);
+ $this->_filterBuilder = $filterBuilder;
+ }
+
+ /**
+ * Add filter
+ *
+ * @param \Magento\Framework\Api\Filter $filter
+ * @return $this
+ */
+ public function addFilter(\Magento\Framework\Api\Filter $filter)
+ {
+ $this->data[FilterGroup::FILTERS][] = $filter;
+ return $this;
+ }
+
+ /**
+ * Set filters
+ *
+ * @param \Magento\Framework\Api\Filter[] $filters
+ * @return $this
+ */
+ public function setFilters($filters)
+ {
+ return $this->_set(FilterGroup::FILTERS, $filters);
+ }
+
+ /**
+ * {@inheritdoc}
+ */
+ protected function _setDataValues(array $data)
+ {
+ if (isset($data[FilterGroup::FILTERS])) {
+ $filters = [];
+ foreach ($data[FilterGroup::FILTERS] as $filter) {
+ $filters[] = $this->_filterBuilder->populateWithArray($filter)->create();
+ }
+ $data[FilterGroup::FILTERS] = $filters;
+ }
+ return parent::_setDataValues($data);
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/Data/StockStatus.php b/lib/internal/Magento/Framework/Data/CollectionBuilder/SortOrder.php
similarity index 67%
rename from app/code/Magento/CatalogInventory/Service/V1/Data/StockStatus.php
rename to lib/internal/Magento/Framework/Data/CollectionBuilder/SortOrder.php
index b09c83f292bc46760498aea0331e7b2cbc04a5a7..40a415a80b6708569da37bdbd0ca603c506cc14e 100644
--- a/app/code/Magento/CatalogInventory/Service/V1/Data/StockStatus.php
+++ b/lib/internal/Magento/Framework/Data/CollectionBuilder/SortOrder.php
@@ -21,39 +21,36 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\CatalogInventory\Service\V1\Data;
+
+namespace Magento\Framework\Data\CollectionBuilder;
use Magento\Framework\Api\AbstractExtensibleObject;
/**
- * Stock status data object
- *
- * @codeCoverageIgnore
+ * Data object for sort order.
*/
-class StockStatus extends AbstractExtensibleObject
+class SortOrder extends AbstractExtensibleObject
{
- /**#@+
- * Stock status object data keys
- */
- const STOCK_STATUS = 'is_in_stock';
-
- const STOCK_QTY = 'qty';
-
- /**#@-*/
+ const FIELD = 'field';
+ const DIRECTION = 'direction';
/**
- * @return bool
+ * Get sorting field.
+ *
+ * @return string
*/
- public function getIsInStock()
+ public function getField()
{
- return $this->_get(self::STOCK_STATUS);
+ return $this->_get(SortOrder::FIELD);
}
/**
- * @return int
+ * Get sorting direction.
+ *
+ * @return string
*/
- public function getQty()
+ public function getDirection()
{
- return $this->_get(self::STOCK_QTY);
+ return $this->_get(SortOrder::DIRECTION);
}
}
diff --git a/lib/internal/Magento/Framework/Data/CollectionBuilder/SortOrderBuilder.php b/lib/internal/Magento/Framework/Data/CollectionBuilder/SortOrderBuilder.php
new file mode 100644
index 0000000000000000000000000000000000000000..70dfd0cdf1161c039a8f4c3d6fec9b97dc22094c
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/CollectionBuilder/SortOrderBuilder.php
@@ -0,0 +1,59 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Framework\Data\CollectionBuilder;
+
+use Magento\Framework\Api\ExtensibleObjectBuilder;
+
+/**
+ * Builder for sort order data object.
+ *
+ * @method SortOrder create()
+ */
+class SortOrderBuilder extends ExtensibleObjectBuilder
+{
+ /**
+ * Set sorting field.
+ *
+ * @param string $field
+ * @return $this
+ */
+ public function setField($field)
+ {
+ $this->_set(SortOrder::FIELD, $field);
+ return $this;
+ }
+
+ /**
+ * Set sorting direction.
+ *
+ * @param string $direction
+ * @return $this
+ */
+ public function setDirection($direction)
+ {
+ $this->_set(SortOrder::DIRECTION, $direction);
+ return $this;
+ }
+}
diff --git a/lib/internal/Magento/Framework/Data/CollectionDataSourceInterface.php b/lib/internal/Magento/Framework/Data/CollectionDataSourceInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..1c00a96f0bae2e93ba1d0615ac9b5e56e9c86070
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/CollectionDataSourceInterface.php
@@ -0,0 +1,35 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+/**
+ * Interface CollectionDataSourceInterface
+ */
+interface CollectionDataSourceInterface extends DataSourceInterface
+{
+ /**
+ * @return SearchResultInterface
+ */
+ public function getResultCollection();
+}
diff --git a/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassMapTest/TestMap.php b/lib/internal/Magento/Framework/Data/DataSourceInterface.php
similarity index 89%
rename from dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassMapTest/TestMap.php
rename to lib/internal/Magento/Framework/Data/DataSourceInterface.php
index 85bbd86e3e2a09c93c815fde08d1df222733e06d..2d2a7f9c707c5dcdb5d51ece1b016dd118962362 100644
--- a/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassMapTest/TestMap.php
+++ b/lib/internal/Magento/Framework/Data/DataSourceInterface.php
@@ -21,8 +21,12 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\Framework\Autoload\ClassMapTest;
+namespace Magento\Framework\Data;
-class TestMap
+/**
+ * Interface DataSourceInterface
+ */
+interface DataSourceInterface
{
+ //
}
diff --git a/lib/internal/Magento/Framework/Data/Form/Element/CollectionFactory.php b/lib/internal/Magento/Framework/Data/Form/Element/CollectionFactory.php
index d83919dccb7e306aed7cac746ca2c55473f877f3..c8bc0979df7875bcb01fc6e660618ff58fc1739a 100644
--- a/lib/internal/Magento/Framework/Data/Form/Element/CollectionFactory.php
+++ b/lib/internal/Magento/Framework/Data/Form/Element/CollectionFactory.php
@@ -23,19 +23,19 @@
*/
namespace Magento\Framework\Data\Form\Element;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class CollectionFactory
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Data/Form/Element/Factory.php b/lib/internal/Magento/Framework/Data/Form/Element/Factory.php
index 6d270eb3fe5edfdf993c717f5ef4b3e3708dd217..fcb333f9211a59173fa863923be287c59be8ba8a 100644
--- a/lib/internal/Magento/Framework/Data/Form/Element/Factory.php
+++ b/lib/internal/Magento/Framework/Data/Form/Element/Factory.php
@@ -28,12 +28,12 @@
*/
namespace Magento\Framework\Data\Form\Element;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class Factory
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $_objectManager;
@@ -74,9 +74,9 @@ class Factory
);
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Data/Form/ElementFactory.php b/lib/internal/Magento/Framework/Data/Form/ElementFactory.php
index f665a8af6b07e6ae5b2b6504b7764fe712c7ab57..5e789866f1d31ad807e7dde5973d3e54c10a42c6 100644
--- a/lib/internal/Magento/Framework/Data/Form/ElementFactory.php
+++ b/lib/internal/Magento/Framework/Data/Form/ElementFactory.php
@@ -26,14 +26,14 @@ namespace Magento\Framework\Data\Form;
class ElementFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Data/FormFactory.php b/lib/internal/Magento/Framework/Data/FormFactory.php
index 3d98d00fe27028551b8301b3e6117817c87522a9..bd3e57aa6b8cf6c944949fc2ec0995d8a1b0529b 100644
--- a/lib/internal/Magento/Framework/Data/FormFactory.php
+++ b/lib/internal/Magento/Framework/Data/FormFactory.php
@@ -31,7 +31,7 @@ class FormFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -45,10 +45,10 @@ class FormFactory
/**
* Factory construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $instanceName = 'Magento\Framework\Data\Form')
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\Framework\Data\Form')
{
$this->_objectManager = $objectManager;
$this->_instanceName = $instanceName;
diff --git a/lib/internal/Magento/Framework/Data/ObjectFactory.php b/lib/internal/Magento/Framework/Data/ObjectFactory.php
new file mode 100644
index 0000000000000000000000000000000000000000..b73a7d889a811d0af50c43a092b9faea8fcf71ff
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/ObjectFactory.php
@@ -0,0 +1,57 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+
+namespace Magento\Framework\Data;
+
+/**
+ * Class ObjectFactory
+ * @package Magento\Framework\Data
+ */
+class ObjectFactory
+{
+ /**
+ * @var \Magento\Framework\ObjectManagerInterface
+ */
+ protected $objectManager;
+
+ /**
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
+ */
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
+ {
+ $this->objectManager = $objectManager;
+ }
+
+ /**
+ * Create data object
+ *
+ * @param string $className
+ * @param array $arguments
+ * @return \Magento\Framework\Object
+ */
+ public function create($className, array $arguments)
+ {
+ return $this->objectManager->create($className, $arguments);
+ }
+}
diff --git a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertAttributeOnAttributeForm.php b/lib/internal/Magento/Framework/Data/SearchResultInterface.php
similarity index 69%
rename from dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertAttributeOnAttributeForm.php
rename to lib/internal/Magento/Framework/Data/SearchResultInterface.php
index 89b4ead34a78168941eae0f77f84f0a5170e7fcf..fadcf85ec461e168934e93b1db7101c66f6e8f0d 100644
--- a/dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertAttributeOnAttributeForm.php
+++ b/lib/internal/Magento/Framework/Data/SearchResultInterface.php
@@ -21,36 +21,29 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-
-namespace Magento\Catalog\Test\Constraint;
-
-use Mtf\Constraint\AbstractConstraint;
+namespace Magento\Framework\Data;
/**
- * Class AssertAttributeOnAttributeForm
+ * Class SearchResultInterface
*/
-class AssertAttributeOnAttributeForm extends AbstractConstraint
+interface SearchResultInterface
{
/**
- * Constraint severeness
+ * Retrieve collection items
*
- * @var string
+ * @return \Magento\Framework\Object[]
*/
- protected $severeness = 'low';
+ public function getItems();
/**
- * @return void
+ * Retrieve count of currently loaded items
+ *
+ * @return int
*/
- public function processAssert()
- {
- //
- }
+ public function getTotalCount();
/**
- * @return string
+ * @return \Magento\Framework\Api\CriteriaInterface
*/
- public function toString()
- {
- //
- }
+ public function getSearchCriteria();
}
diff --git a/lib/internal/Magento/Framework/Data/SearchResultIterator.php b/lib/internal/Magento/Framework/Data/SearchResultIterator.php
new file mode 100644
index 0000000000000000000000000000000000000000..c6165f5d10d9fb0bda9cce74fce3b914968835fd
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/SearchResultIterator.php
@@ -0,0 +1,107 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+use Magento\Framework\DB\QueryInterface;
+use Magento\Framework\Data\AbstractSearchResult;
+
+/**
+ * Class SearchResultIterator
+ */
+class SearchResultIterator implements \Iterator
+{
+ /**
+ * @var SearchResultInterface
+ */
+ protected $searchResult;
+
+ /**
+ * @var QueryInterface
+ */
+ protected $query;
+
+ /**
+ * @var array
+ */
+ protected $current;
+
+ /**
+ * @var int
+ */
+ protected $key = 0;
+
+ /**
+ * @param AbstractSearchResult $searchResult
+ * @param QueryInterface $query
+ */
+ public function __construct(AbstractSearchResult $searchResult, QueryInterface $query)
+ {
+ $this->searchResult = $searchResult;
+ $this->query = $query;
+ }
+
+ /**
+ * @return array|mixed
+ */
+ public function current()
+ {
+ return $this->current;
+ }
+
+ /**
+ * @return void
+ */
+ public function next()
+ {
+ ++$this->key;
+ $this->current = $this->searchResult->createDataObject($this->query->fetchItem());
+ }
+
+ /**
+ * @return int|mixed
+ */
+ public function key()
+ {
+ return $this->key;
+ }
+
+ /**
+ * @return bool
+ */
+ public function valid()
+ {
+ return !empty($this->current);
+ }
+
+ /**
+ * @return void
+ */
+ public function rewind()
+ {
+ $this->current = null;
+ $this->key = 0;
+ $this->query->reset();
+ $this->next();
+ }
+}
diff --git a/lib/internal/Magento/Framework/Data/SearchResultIteratorFactory.php b/lib/internal/Magento/Framework/Data/SearchResultIteratorFactory.php
new file mode 100644
index 0000000000000000000000000000000000000000..7669600aee19a5e976b95bc63d09afff07dab9d7
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/SearchResultIteratorFactory.php
@@ -0,0 +1,62 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+/**
+ * Class SearchResultIteratorFactory
+ */
+class SearchResultIteratorFactory
+{
+ /**
+ * @var \Magento\Framework\ObjectManagerInterface
+ */
+ protected $objectManager;
+
+ /**
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
+ */
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
+ {
+ $this->objectManager = $objectManager;
+ }
+
+ /**
+ * Create SearchResultIterator object
+ *
+ * @param string $className
+ * @param array $arguments
+ * @return SearchResultIterator
+ * @throws \Magento\Framework\Exception
+ */
+ public function create($className, array $arguments = [])
+ {
+ $resultIterator = $this->objectManager->create($className, $arguments);
+ if (!$resultIterator instanceof \Traversable) {
+ throw new \Magento\Framework\Exception(
+ $className . ' should be an iterator'
+ );
+ }
+ return $resultIterator;
+ }
+}
diff --git a/lib/internal/Magento/Framework/Data/SearchResultProcessor.php b/lib/internal/Magento/Framework/Data/SearchResultProcessor.php
new file mode 100644
index 0000000000000000000000000000000000000000..cc321a53a7969b0d3e7fe3ccc85d0c841a1b23e4
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/SearchResultProcessor.php
@@ -0,0 +1,256 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+/**
+ * Class SearchResultProcessor
+ */
+class SearchResultProcessor extends AbstractDataObject implements SearchResultProcessorInterface
+{
+ /**
+ * Data Interface name
+ *
+ * @var string
+ */
+ protected $dataInterface = 'Magento\Framework\Object';
+
+ /**
+ * @var AbstractSearchResult
+ */
+ protected $searchResult;
+
+ /**
+ * @param AbstractSearchResult $searchResult
+ */
+ public function __construct(AbstractSearchResult $searchResult)
+ {
+ $this->searchResult = $searchResult;
+ }
+
+ /**
+ * @return int
+ */
+ public function getCurrentPage()
+ {
+ return $this->searchResult->getSearchCriteria()->getLimit()[0];
+ }
+
+ /**
+ * @return int
+ */
+ public function getPageSize()
+ {
+ return $this->searchResult->getSearchCriteria()->getLimit()[1];
+ }
+
+ /**
+ * @return \Magento\Framework\Object|mixed
+ */
+ public function getFirstItem()
+ {
+ return current($this->searchResult->getItems());
+ }
+
+ /**
+ * @return \Magento\Framework\Object|mixed
+ */
+ public function getLastItem()
+ {
+ $items = $this->searchResult->getItems();
+ return end($items);
+ }
+
+ /**
+ * @return array
+ */
+ public function getAllIds()
+ {
+ $ids = [];
+ foreach ($this->searchResult->getItems() as $item) {
+ $ids[] = $this->searchResult->getItemId($item);
+ }
+ return $ids;
+ }
+
+ /**
+ * @param int $id
+ * @return \Magento\Framework\Object|null
+ */
+ public function getItemById($id)
+ {
+ $items = $this->searchResult->getItems();
+ if (isset($items[$id])) {
+ return $items[$id];
+ }
+ return null;
+ }
+
+ /**
+ * @param string $colName
+ * @return array
+ */
+ public function getColumnValues($colName)
+ {
+ $col = [];
+ foreach ($this->searchResult->getItems() as $item) {
+ $col[] = $item->getData($colName);
+ }
+ return $col;
+ }
+
+ /**
+ * @param string $column
+ * @param mixed $value
+ * @return array
+ */
+ public function getItemsByColumnValue($column, $value)
+ {
+ $res = [];
+ foreach ($this->searchResult->getItems() as $item) {
+ if ($item->getData($column) == $value) {
+ $res[] = $item;
+ }
+ }
+ return $res;
+ }
+
+ /**
+ * @param string $column
+ * @param mixed $value
+ * @return \Magento\Framework\Object|null
+ */
+ public function getItemByColumnValue($column, $value)
+ {
+ foreach ($this->searchResult->getItems() as $item) {
+ if ($item->getData($column) == $value) {
+ return $item;
+ }
+ }
+ return null;
+ }
+
+ /**
+ * @param string $callback
+ * @param array $args
+ * @return array
+ */
+ public function walk($callback, array $args = [])
+ {
+ $results = [];
+ $useItemCallback = is_string($callback) && strpos($callback, '::') === false;
+ foreach ($this->searchResult->getItems() as $id => $item) {
+ if ($useItemCallback) {
+ $cb = [$item, $callback];
+ } else {
+ $cb = $callback;
+ array_unshift($args, $item);
+ }
+ $results[$id] = call_user_func_array($cb, $args);
+ }
+ return $results;
+ }
+
+ /**
+ * @return string
+ */
+ public function toXml()
+ {
+ $xml = '<?xml version="1.0" encoding="UTF-8"?>
+ <collection>
+ <totalRecords>' .
+ $this->searchResult->getSize() .
+ '</totalRecords>
+ <items>';
+ foreach ($this->searchResult->getItems() as $item) {
+ $xml .= $item->toXml();
+ }
+ $xml .= '</items>
+ </collection>';
+ return $xml;
+ }
+
+ /**
+ * @param array $arrRequiredFields
+ * @return array
+ */
+ public function toArray($arrRequiredFields = [])
+ {
+ $array = [];
+ $array['search_criteria'] = $this->searchResult->getSearchCriteria();
+ $array['total_count'] = $this->searchResult->getTotalCount();
+ foreach ($this->searchResult->getItems() as $item) {
+ $array['items'][] = $item->toArray($arrRequiredFields);
+ }
+ return $array;
+ }
+
+ /**
+ * @param null $valueField
+ * @param null $labelField
+ * @param array $additional
+ * @return array
+ */
+ public function toOptionArray($valueField = null, $labelField = null, $additional = [])
+ {
+ if ($valueField === null) {
+ $valueField = $this->searchResult->getIdFieldName();
+ }
+ if ($labelField === null) {
+ $labelField = 'name';
+ }
+ $result = [];
+ $additional['value'] = $valueField;
+ $additional['label'] = $labelField;
+ foreach ($this->searchResult->getItems() as $item) {
+ $data = [];
+ foreach ($additional as $code => $field) {
+ $data[$code] = $item->getData($field);
+ }
+ $result[] = $data;
+ }
+ return $result;
+ }
+
+ /**
+ * @param string $valueField
+ * @param string $labelField
+ * @return array
+ */
+ public function toOptionHash($valueField, $labelField)
+ {
+ $res = [];
+ foreach ($this->searchResult->getItems() as $item) {
+ $res[$item->getData($valueField)] = $item->getData($labelField);
+ }
+ return $res;
+ }
+
+ /**
+ * @return string
+ */
+ protected function getDataInterfaceName()
+ {
+ return $this->dataInterface;
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/Data/LowStockResultBuilder.php b/lib/internal/Magento/Framework/Data/SearchResultProcessorFactory.php
similarity index 54%
rename from app/code/Magento/CatalogInventory/Service/V1/Data/LowStockResultBuilder.php
rename to lib/internal/Magento/Framework/Data/SearchResultProcessorFactory.php
index 4009d8c11804c2d6c1ed630fc28a297e436a8955..8c047be55948cc68fb0558b47b02d43f3f2e938d 100644
--- a/app/code/Magento/CatalogInventory/Service/V1/Data/LowStockResultBuilder.php
+++ b/lib/internal/Magento/Framework/Data/SearchResultProcessorFactory.php
@@ -21,45 +21,41 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\CatalogInventory\Service\V1\Data;
+namespace Magento\Framework\Data;
/**
- * Low stock search result builder object
- *
- * @codeCoverageIgnore
+ * Class SearchResultProcessorFactory
*/
-class LowStockResultBuilder extends \Magento\Framework\Api\ExtensibleObjectBuilder
+class SearchResultProcessorFactory
{
+ const DEFAULT_INSTANCE_NAME = 'Magento\Framework\Data\SearchResultProcessor';
+
/**
- * Set search criteria
+ * Object Manager instance
*
- * @param LowStockCriteria $searchCriteria
- * @return $this
+ * @var \Magento\Framework\ObjectManagerInterface
*/
- public function setSearchCriteria(LowStockCriteria $searchCriteria)
- {
- return $this->_set(LowStockResult::SEARCH_CRITERIA, $searchCriteria);
- }
+ protected $objectManager;
/**
- * Set total count
+ * Factory constructor
*
- * @param int $totalCount
- * @return $this
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function setTotalCount($totalCount)
- {
- return $this->_set(LowStockResult::TOTAL_COUNT, $totalCount);
+ public function __construct(
+ \Magento\Framework\ObjectManagerInterface $objectManager
+ ) {
+ $this->objectManager = $objectManager;
}
/**
- * Set items
+ * Create class instance with specified parameters
*
- * @param array $items
- * @return $this
+ * @param AbstractSearchResult $collection
+ * @return SearchResultProcessor
*/
- public function setItems($items)
+ public function create(AbstractSearchResult $collection)
{
- return $this->_set(LowStockResult::PRODUCT_SKU_LIST, $items);
+ return $this->objectManager->create(static::DEFAULT_INSTANCE_NAME, ['searchResult' => $collection]);
}
}
diff --git a/lib/internal/Magento/Framework/Data/SearchResultProcessorInterface.php b/lib/internal/Magento/Framework/Data/SearchResultProcessorInterface.php
new file mode 100644
index 0000000000000000000000000000000000000000..e13bebaa19f95c4431d376ae79a29b54cb64f54d
--- /dev/null
+++ b/lib/internal/Magento/Framework/Data/SearchResultProcessorInterface.php
@@ -0,0 +1,156 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Data;
+
+/**
+ * Interface SearchResultProcessorInterface
+ */
+interface SearchResultProcessorInterface
+{
+ /**
+ * Retrieve all ids for collection
+ *
+ * @return array
+ */
+ public function getAllIds();
+
+ /**
+ * Get current collection page
+ *
+ * @return int
+ */
+ public function getCurrentPage();
+
+ /**
+ * Retrieve collection page size
+ *
+ * @return int
+ */
+ public function getPageSize();
+
+ /**
+ * Retrieve collection first item
+ *
+ * @return \Magento\Framework\Object
+ */
+ public function getFirstItem();
+
+ /**
+ * Retrieve collection last item
+ *
+ * @return \Magento\Framework\Object
+ */
+ public function getLastItem();
+
+ /**
+ * Retrieve field values from all items
+ *
+ * @param string $colName
+ * @return array
+ */
+ public function getColumnValues($colName);
+
+ /**
+ * Search all items by field value
+ *
+ * @param string $column
+ * @param mixed $value
+ * @return array
+ */
+ public function getItemsByColumnValue($column, $value);
+
+ /**
+ * Search first item by field value
+ *
+ * @param string $column
+ * @param mixed $value
+ * @return \Magento\Framework\Object || null
+ */
+ public function getItemByColumnValue($column, $value);
+
+ /**
+ * Retrieve item by id
+ *
+ * @param mixed $idValue
+ * @return \Magento\Framework\Object
+ */
+ public function getItemById($idValue);
+
+ /**
+ * Walk through the collection and run model method or external callback
+ * with optional arguments
+ *
+ * Returns array with results of callback for each item
+ *
+ * @param string $callback
+ * @param array $arguments
+ * @return array
+ */
+ public function walk($callback, array $arguments = []);
+
+ /**
+ * Convert collection to XML
+ *
+ * @return string
+ */
+ public function toXml();
+
+ /**
+ * Convert collection to array
+ *
+ * @param array $arrRequiredFields
+ * @return array
+ */
+ public function toArray($arrRequiredFields = []);
+
+ /**
+ * Convert items array to array for select options
+ *
+ * return items array
+ * array(
+ * $index => array(
+ * 'value' => mixed
+ * 'label' => mixed
+ * )
+ * )
+ *
+ * @param string $valueField
+ * @param string $labelField
+ * @param array $additional
+ * @return array
+ */
+ public function toOptionArray($valueField = null, $labelField = null, $additional = []);
+
+ /**
+ * Convert items array to hash for select options
+ *
+ * return items hash
+ * array($value => $label)
+ *
+ * @param string $valueField
+ * @param string $labelField
+ * @return array
+ */
+ public function toOptionHash($valueField, $labelField);
+}
diff --git a/lib/internal/Magento/Framework/DomDocument/Factory.php b/lib/internal/Magento/Framework/DomDocument/Factory.php
index 4687adb5e9326a9bf78d1ac2735477871ab1c102..b990eff2b67308cd47a02bf783827c28de8f2e36 100644
--- a/lib/internal/Magento/Framework/DomDocument/Factory.php
+++ b/lib/internal/Magento/Framework/DomDocument/Factory.php
@@ -9,14 +9,14 @@ namespace Magento\Framework\DomDocument;
class Factory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Encryption/CryptFactory.php b/lib/internal/Magento/Framework/Encryption/CryptFactory.php
index 9c7791de6e005b96ad199be8e302c7a7834ce756..7612b0c17d3ab4f3a8629da78933264a10c23666 100644
--- a/lib/internal/Magento/Framework/Encryption/CryptFactory.php
+++ b/lib/internal/Magento/Framework/Encryption/CryptFactory.php
@@ -33,14 +33,14 @@ class CryptFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Event/ObserverFactory.php b/lib/internal/Magento/Framework/Event/ObserverFactory.php
index 4d5e2a6f4e1a64d6711f5d91d8ad699116752244..9fb423fd24b827468c5c816c52007a9c04c54142 100644
--- a/lib/internal/Magento/Framework/Event/ObserverFactory.php
+++ b/lib/internal/Magento/Framework/Event/ObserverFactory.php
@@ -28,14 +28,14 @@ namespace Magento\Framework\Event;
class ObserverFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Event/WrapperFactory.php b/lib/internal/Magento/Framework/Event/WrapperFactory.php
index 114967418e15385d8943b117c40ec6e9ce4f6ab2..93be6ce94b9e568381af1f14de2f1e4f80950760 100644
--- a/lib/internal/Magento/Framework/Event/WrapperFactory.php
+++ b/lib/internal/Magento/Framework/Event/WrapperFactory.php
@@ -28,14 +28,14 @@ namespace Magento\Framework\Event;
class WrapperFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/EventFactory.php b/lib/internal/Magento/Framework/EventFactory.php
index 90b36aff1830f38e2a824b502c3aa420b16d7321..f3a615012d5ce2ed395ff1d2372a382c514745b9 100644
--- a/lib/internal/Magento/Framework/EventFactory.php
+++ b/lib/internal/Magento/Framework/EventFactory.php
@@ -26,14 +26,14 @@ namespace Magento\Framework;
class EventFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/File/UploaderFactory.php b/lib/internal/Magento/Framework/File/UploaderFactory.php
index c802d611572544711525256824ea49666ae79abf..7ee372bd2fec3df3ae9330c3d121e2717f0d34bd 100644
--- a/lib/internal/Magento/Framework/File/UploaderFactory.php
+++ b/lib/internal/Magento/Framework/File/UploaderFactory.php
@@ -28,14 +28,14 @@ class UploaderFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Code/Generator/FileResolver.php b/lib/internal/Magento/Framework/Filesystem/FileResolver.php
similarity index 94%
rename from lib/internal/Magento/Framework/Code/Generator/FileResolver.php
rename to lib/internal/Magento/Framework/Filesystem/FileResolver.php
index a9774cf273bdc2a6cb731436e9186765835c82d5..1af85dc1991c1704956938db0fea7e4c873c2f32 100644
--- a/lib/internal/Magento/Framework/Code/Generator/FileResolver.php
+++ b/lib/internal/Magento/Framework/Filesystem/FileResolver.php
@@ -1,7 +1,5 @@
<?php
/**
- * Contains logic for finding class filepaths.
- *
* Magento
*
* NOTICE OF LICENSE
@@ -23,8 +21,11 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\Framework\Code\Generator;
+namespace Magento\Framework\Filesystem;
+/**
+ * Contains logic for finding class filepaths based on include_path configuration.
+ */
class FileResolver
{
/**
@@ -42,7 +43,6 @@ class FileResolver
/**
* Get relative file path for specified class
*
- * @static
* @param string $class
* @return string
*/
diff --git a/lib/internal/Magento/Framework/Filter/AbstractFactory.php b/lib/internal/Magento/Framework/Filter/AbstractFactory.php
index 9ce1a4dbf9163803f72e1199d3821e0b7d2fe040..8dc23fd38065d21c1d03369f26abbe54824bd5c6 100644
--- a/lib/internal/Magento/Framework/Filter/AbstractFactory.php
+++ b/lib/internal/Magento/Framework/Filter/AbstractFactory.php
@@ -50,7 +50,7 @@ abstract class AbstractFactory implements FactoryInterface
protected $shared = array();
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -60,9 +60,9 @@ abstract class AbstractFactory implements FactoryInterface
protected $sharedInstances = array();
/**
- * @param \Magento\Framework\ObjectManager $objectManger
+ * @param \Magento\Framework\ObjectManagerInterface $objectManger
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManger)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManger)
{
$this->objectManager = $objectManger;
}
diff --git a/lib/internal/Magento/Framework/Filter/FilterManager.php b/lib/internal/Magento/Framework/Filter/FilterManager.php
index 02133d2138af496a9d3e378794a2f3a4cf335bcc..2f46be92540e0736a2b4a52058cb878389b50ff7 100644
--- a/lib/internal/Magento/Framework/Filter/FilterManager.php
+++ b/lib/internal/Magento/Framework/Filter/FilterManager.php
@@ -46,7 +46,7 @@ namespace Magento\Framework\Filter;
class FilterManager
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -61,10 +61,10 @@ class FilterManager
protected $factoryInstances;
/**
- * @param \Magento\Framework\ObjectManager $objectManger
+ * @param \Magento\Framework\ObjectManagerInterface $objectManger
* @param FilterManager\Config $config
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManger, FilterManager\Config $config)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManger, FilterManager\Config $config)
{
$this->objectManager = $objectManger;
$this->config = $config;
diff --git a/lib/internal/Magento/Framework/Filter/Input.php b/lib/internal/Magento/Framework/Filter/Input.php
index 6145878ade3a017d6a2f31fd0931d1efc0f62bb5..34a755c4c8703404f9e26aa97bae568a4a3df2c5 100644
--- a/lib/internal/Magento/Framework/Filter/Input.php
+++ b/lib/internal/Magento/Framework/Filter/Input.php
@@ -100,14 +100,14 @@ namespace Magento\Framework\Filter;
class Input implements \Zend_Filter_Interface
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/FlagFactory.php b/lib/internal/Magento/Framework/FlagFactory.php
index 4fabcddb1a34fc6a54a7da4585287bb086b1c1c7..2cc49f7cc883b6232326d71aded67367e77e156b 100644
--- a/lib/internal/Magento/Framework/FlagFactory.php
+++ b/lib/internal/Magento/Framework/FlagFactory.php
@@ -31,7 +31,7 @@ class FlagFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -45,11 +45,11 @@ class FlagFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\Flag'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/HTTP/Client.php b/lib/internal/Magento/Framework/HTTP/Client.php
index dd4216dda4ce6667a81fda9b0668e0e683fd4f9a..319c3c00f38006f051f172a3dd49b2720dccf29a 100644
--- a/lib/internal/Magento/Framework/HTTP/Client.php
+++ b/lib/internal/Magento/Framework/HTTP/Client.php
@@ -41,7 +41,7 @@ class Client
/**
* Factory for HTTP client
* @param string/false $frontend 'curl'/'socket' or false for auto-detect
- * @return \Magento\Framework\HTTP\IClient
+ * @return \Magento\Framework\HTTP\ClientInterface
*/
public static function getInstance($frontend = false)
{
diff --git a/lib/internal/Magento/Framework/HTTP/Client/Curl.php b/lib/internal/Magento/Framework/HTTP/Client/Curl.php
index 1effadb0d5e688a6b81e119186268ffd523dd732..a7652ccc2ac97cda0f397823cc48266e93210161 100644
--- a/lib/internal/Magento/Framework/HTTP/Client/Curl.php
+++ b/lib/internal/Magento/Framework/HTTP/Client/Curl.php
@@ -28,7 +28,7 @@ namespace Magento\Framework\HTTP\Client;
*
* @author Magento Core Team <core@magentocommerce.com>
*/
-class Curl implements \Magento\Framework\HTTP\IClient
+class Curl implements \Magento\Framework\HTTP\ClientInterface
{
/**
* Hostname
diff --git a/lib/internal/Magento/Framework/HTTP/Client/Socket.php b/lib/internal/Magento/Framework/HTTP/Client/Socket.php
index b6b3135716af103deb836d55d90865b7f67c78de..dd55dcc890c850e71b21f737da8fc556147a4c11 100644
--- a/lib/internal/Magento/Framework/HTTP/Client/Socket.php
+++ b/lib/internal/Magento/Framework/HTTP/Client/Socket.php
@@ -29,7 +29,7 @@
*/
namespace Magento\Framework\HTTP\Client;
-class Socket implements \Magento\Framework\HTTP\IClient
+class Socket implements \Magento\Framework\HTTP\ClientInterface
{
/**
* Hostname
diff --git a/lib/internal/Magento/Framework/HTTP/IClient.php b/lib/internal/Magento/Framework/HTTP/ClientInterface.php
similarity index 97%
rename from lib/internal/Magento/Framework/HTTP/IClient.php
rename to lib/internal/Magento/Framework/HTTP/ClientInterface.php
index 219677fa7f309123b939a87e9dc47e0f463c0cd0..72a00c30fc793a62352151d7aaff27077c4c8fdf 100644
--- a/lib/internal/Magento/Framework/HTTP/IClient.php
+++ b/lib/internal/Magento/Framework/HTTP/ClientInterface.php
@@ -29,7 +29,7 @@
*/
namespace Magento\Framework\HTTP;
-interface IClient
+interface ClientInterface
{
/**
* Set request timeout
@@ -70,7 +70,7 @@ interface IClient
public function setCredentials($login, $pass);
/**
- * Add cookie to request
+ * Add cookie to request
* @param string $name
* @param string $value
* @return void
@@ -132,7 +132,7 @@ interface IClient
public function getStatus();
/**
- * Get response cookies (k=>v)
+ * Get response cookies (k=>v)
* @return array
*/
public function getCookies();
diff --git a/lib/internal/Magento/Framework/Image/AdapterFactory.php b/lib/internal/Magento/Framework/Image/AdapterFactory.php
index e5f3041d481b5f11e95fc6ab13ddf0db389f4eb3..c40061e3b6239c76ed806c430a6627f23322fddc 100644
--- a/lib/internal/Magento/Framework/Image/AdapterFactory.php
+++ b/lib/internal/Magento/Framework/Image/AdapterFactory.php
@@ -31,7 +31,7 @@ class AdapterFactory
protected $config;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -41,12 +41,12 @@ class AdapterFactory
protected $adapterMap;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param Adapter\ConfigInterface $config
* @param array $adapterMap
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Image\Adapter\ConfigInterface $config,
array $adapterMap = array()
) {
diff --git a/lib/internal/Magento/Framework/Image/Factory.php b/lib/internal/Magento/Framework/Image/Factory.php
index f7f00e6e57f8333c861b05a63422cfdc01a69360..accf2760cb9a422abc9078af040d0624d458dc2a 100644
--- a/lib/internal/Magento/Framework/Image/Factory.php
+++ b/lib/internal/Magento/Framework/Image/Factory.php
@@ -23,12 +23,12 @@
*/
namespace Magento\Framework\Image;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class Factory
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
@@ -38,10 +38,10 @@ class Factory
protected $adapterFactory;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param AdapterFactory $adapterFactory
*/
- public function __construct(ObjectManager $objectManager, AdapterFactory $adapterFactory)
+ public function __construct(ObjectManagerInterface $objectManager, AdapterFactory $adapterFactory)
{
$this->objectManager = $objectManager;
$this->adapterFactory = $adapterFactory;
diff --git a/lib/internal/Magento/Framework/Interception/Chain/Chain.php b/lib/internal/Magento/Framework/Interception/Chain/Chain.php
index a35e92dd439d7febe7b5761d132e392e91ec4934..8d18668e847afa2dbd22eab0083028c477dc6230 100644
--- a/lib/internal/Magento/Framework/Interception/Chain/Chain.php
+++ b/lib/internal/Magento/Framework/Interception/Chain/Chain.php
@@ -25,20 +25,20 @@
namespace Magento\Framework\Interception\Chain;
use Magento\Framework\Code\GeneratorTest\SourceClassWithNamespace\Interceptor;
-use Magento\Framework\Interception\Definition;
-use Magento\Framework\Interception\PluginList;
+use Magento\Framework\Interception\DefinitionInterface;
+use Magento\Framework\Interception\PluginListInterface;
-class Chain implements \Magento\Framework\Interception\Chain
+class Chain implements \Magento\Framework\Interception\ChainInterface
{
/**
- * @var \Magento\Framework\Interception\PluginList
+ * @var \Magento\Framework\Interception\PluginListInterface
*/
protected $pluginList;
/**
- * @param PluginList $pluginList
+ * @param PluginListInterface $pluginList
*/
- public function __construct(PluginList $pluginList)
+ public function __construct(PluginListInterface $pluginList)
{
$this->pluginList = $pluginList;
}
@@ -58,8 +58,8 @@ class Chain implements \Magento\Framework\Interception\Chain
$pluginInfo = $this->pluginList->getNext($type, $method, $previousPluginCode);
$capMethod = ucfirst($method);
$result = null;
- if (isset($pluginInfo[Definition::LISTENER_BEFORE])) {
- foreach ($pluginInfo[Definition::LISTENER_BEFORE] as $code) {
+ if (isset($pluginInfo[DefinitionInterface::LISTENER_BEFORE])) {
+ foreach ($pluginInfo[DefinitionInterface::LISTENER_BEFORE] as $code) {
$beforeResult = call_user_func_array(
array($this->pluginList->getPlugin($type, $code), 'before' . $capMethod),
array_merge(array($subject), $arguments)
@@ -69,9 +69,9 @@ class Chain implements \Magento\Framework\Interception\Chain
}
}
}
- if (isset($pluginInfo[Definition::LISTENER_AROUND])) {
+ if (isset($pluginInfo[DefinitionInterface::LISTENER_AROUND])) {
$chain = $this;
- $code = $pluginInfo[Definition::LISTENER_AROUND];
+ $code = $pluginInfo[DefinitionInterface::LISTENER_AROUND];
$next = function () use ($chain, $type, $method, $subject, $code) {
return $chain->invokeNext($type, $method, $subject, func_get_args(), $code);
};
@@ -82,8 +82,8 @@ class Chain implements \Magento\Framework\Interception\Chain
} else {
$result = $subject->___callParent($method, $arguments);
}
- if (isset($pluginInfo[Definition::LISTENER_AFTER])) {
- foreach ($pluginInfo[Definition::LISTENER_AFTER] as $code) {
+ if (isset($pluginInfo[DefinitionInterface::LISTENER_AFTER])) {
+ foreach ($pluginInfo[DefinitionInterface::LISTENER_AFTER] as $code) {
$result = $this->pluginList->getPlugin($type, $code)->{'after' . $capMethod}($subject, $result);
}
}
diff --git a/lib/internal/Magento/Framework/Interception/Chain.php b/lib/internal/Magento/Framework/Interception/ChainInterface.php
similarity index 98%
rename from lib/internal/Magento/Framework/Interception/Chain.php
rename to lib/internal/Magento/Framework/Interception/ChainInterface.php
index 32f5ab917f3f8166fd1f0723fb78c2e8416dd450..182cc53d165ceffe7f83d0bc58efb96f4f25333a 100644
--- a/lib/internal/Magento/Framework/Interception/Chain.php
+++ b/lib/internal/Magento/Framework/Interception/ChainInterface.php
@@ -24,7 +24,7 @@
*/
namespace Magento\Framework\Interception;
-interface Chain
+interface ChainInterface
{
/**
* @param string $type
diff --git a/lib/internal/Magento/Framework/Interception/Code/Generator/Interceptor.php b/lib/internal/Magento/Framework/Interception/Code/Generator/Interceptor.php
index 11809449cbf32671fdbba625bfaa3ffb97291e5a..08c066bd77d66c9a26718f1a61a6def53add1a3d 100644
--- a/lib/internal/Magento/Framework/Interception/Code/Generator/Interceptor.php
+++ b/lib/internal/Magento/Framework/Interception/Code/Generator/Interceptor.php
@@ -52,7 +52,10 @@ class Interceptor extends \Magento\Framework\Code\Generator\EntityAbstract
'visibility' => 'protected',
'docblock' => array(
'shortDescription' => 'Object Manager instance',
- 'tags' => array(array('name' => 'var', 'description' => '\Magento\Framework\ObjectManager'))
+ 'tags' => array(array(
+ 'name' => 'var',
+ 'description' => '\Magento\Framework\ObjectManagerInterface',
+ ))
)
),
array(
@@ -60,7 +63,10 @@ class Interceptor extends \Magento\Framework\Code\Generator\EntityAbstract
'visibility' => 'protected',
'docblock' => array(
'shortDescription' => 'List of plugins',
- 'tags' => array(array('name' => 'var', 'description' => '\Magento\Framework\Interception\PluginList'))
+ 'tags' => array(array(
+ 'name' => 'var',
+ 'description' => '\Magento\Framework\Interception\PluginListInterface',
+ ))
)
),
array(
@@ -68,7 +74,10 @@ class Interceptor extends \Magento\Framework\Code\Generator\EntityAbstract
'visibility' => 'protected',
'docblock' => array(
'shortDescription' => 'Invocation chain',
- 'tags' => array(array('name' => 'var', 'description' => '\Magento\Framework\Interception\Chain'))
+ 'tags' => array(array(
+ 'name' => 'var',
+ 'description' => '\Magento\Framework\Interception\ChainInterface',
+ ))
)
),
array(
@@ -102,9 +111,9 @@ class Interceptor extends \Magento\Framework\Code\Generator\EntityAbstract
'name' => '__construct',
'parameters' => array_merge(
array(
- array('name' => 'pluginLocator', 'type' => '\Magento\Framework\ObjectManager'),
- array('name' => 'pluginList', 'type' => '\Magento\Framework\Interception\PluginList'),
- array('name' => 'chain', 'type' => '\Magento\Framework\Interception\Chain')
+ array('name' => 'pluginLocator', 'type' => '\Magento\Framework\ObjectManagerInterface'),
+ array('name' => 'pluginList', 'type' => '\Magento\Framework\Interception\PluginListInterface'),
+ array('name' => 'chain', 'type' => '\Magento\Framework\Interception\ChainInterface')
),
$parameters
),
@@ -150,8 +159,8 @@ class Interceptor extends \Magento\Framework\Code\Generator\EntityAbstract
$methods[] = array(
'name' => '__wakeup',
'body' => "\$this->pluginLocator = \\Magento\\Framework\\App\\ObjectManager::getInstance();\n" .
- "\$this->pluginList = \$this->pluginLocator->get('Magento\\Framework\\Interception\\PluginList');\n" .
- "\$this->chain = \$this->pluginLocator->get('Magento\\Framework\\Interception\\Chain');\n" .
+ "\$this->pluginList = \$this->pluginLocator->get('Magento\\Framework\\Interception\\PluginListInterface');\n" .
+ "\$this->chain = \$this->pluginLocator->get('Magento\\Framework\\Interception\\ChainInterface');\n" .
"\$this->subjectType = get_parent_class(\$this);\n"
);
@@ -165,8 +174,8 @@ class Interceptor extends \Magento\Framework\Code\Generator\EntityAbstract
),
'body' => "\$capMethod = ucfirst(\$method);\n" .
"\$result = null;\n" .
- "if (isset(\$pluginInfo[\\Magento\\Framework\\Interception\\Definition::LISTENER_BEFORE])) {\n" .
- " foreach (\$pluginInfo[\\Magento\\Framework\\Interception\\Definition::LISTENER_BEFORE] as \$code) {\n" .
+ "if (isset(\$pluginInfo[\\Magento\\Framework\\Interception\\DefinitionInterface::LISTENER_BEFORE])) {\n" .
+ " foreach (\$pluginInfo[\\Magento\\Framework\\Interception\\DefinitionInterface::LISTENER_BEFORE] as \$code) {\n" .
" \$beforeResult = call_user_func_array(\n" .
" array(\$this->pluginList->getPlugin(\$this->subjectType, \$code), 'before'" .
". \$capMethod), array_merge(array(\$this), \$arguments)\n" .
@@ -176,11 +185,11 @@ class Interceptor extends \Magento\Framework\Code\Generator\EntityAbstract
" }\n" .
" }\n" .
"}\n" .
- "if (isset(\$pluginInfo[\\Magento\\Framework\\Interception\\Definition::LISTENER_AROUND])) {\n" .
+ "if (isset(\$pluginInfo[\\Magento\\Framework\\Interception\\DefinitionInterface::LISTENER_AROUND])) {\n" .
" \$chain = \$this->chain;\n" .
" \$type = \$this->subjectType;\n" .
" \$subject = \$this;\n" .
- " \$code = \$pluginInfo[\\Magento\\Framework\\Interception\\Definition::LISTENER_AROUND];\n" .
+ " \$code = \$pluginInfo[\\Magento\\Framework\\Interception\\DefinitionInterface::LISTENER_AROUND];\n" .
" \$next = function () use (\$chain, \$type, \$method, \$subject, \$code) {\n" .
" return \$chain->invokeNext(\$type, \$method, \$subject, func_get_args(), \$code);\n" .
" };\n" .
@@ -191,8 +200,8 @@ class Interceptor extends \Magento\Framework\Code\Generator\EntityAbstract
"} else {\n" .
" \$result = call_user_func_array(array('parent', \$method), \$arguments);\n" .
"}\n" .
- "if (isset(\$pluginInfo[\\Magento\\Framework\\Interception\\Definition::LISTENER_AFTER])) {\n" .
- " foreach (\$pluginInfo[\\Magento\\Framework\\Interception\\Definition::LISTENER_AFTER] as \$code) {\n" .
+ "if (isset(\$pluginInfo[\\Magento\\Framework\\Interception\\DefinitionInterface::LISTENER_AFTER])) {\n" .
+ " foreach (\$pluginInfo[\\Magento\\Framework\\Interception\\DefinitionInterface::LISTENER_AFTER] as \$code) {\n" .
" \$result = \$this->pluginList->getPlugin(\$this->subjectType, \$code)\n" .
" ->{'after' . \$capMethod}(\$this, \$result);\n" .
" }\n" .
diff --git a/lib/internal/Magento/Framework/Interception/Config/Config.php b/lib/internal/Magento/Framework/Interception/Config/Config.php
index 7f4a02c42b32bdc5387724a253eac9947b7d19af..cde870701f3a38ab15c1cac14798105fe65fedf9 100644
--- a/lib/internal/Magento/Framework/Interception/Config/Config.php
+++ b/lib/internal/Magento/Framework/Interception/Config/Config.php
@@ -25,26 +25,26 @@
*/
namespace Magento\Framework\Interception\Config;
-class Config implements \Magento\Framework\Interception\Config
+class Config implements \Magento\Framework\Interception\ConfigInterface
{
/**
* Type configuration
*
- * @var \Magento\Framework\ObjectManager\Config
+ * @var \Magento\Framework\ObjectManager\ConfigInterface
*/
protected $_omConfig;
/**
* Class relations info
*
- * @var \Magento\Framework\ObjectManager\Relations
+ * @var \Magento\Framework\ObjectManager\RelationsInterface
*/
protected $_relations;
/**
* List of interceptable classes
*
- * @var \Magento\Framework\ObjectManager\Definition
+ * @var \Magento\Framework\ObjectManager\DefinitionInterface
*/
protected $_classDefinitions;
@@ -87,18 +87,18 @@ class Config implements \Magento\Framework\Interception\Config
* @param \Magento\Framework\Config\ReaderInterface $reader
* @param \Magento\Framework\Config\ScopeListInterface $scopeList
* @param \Magento\Framework\Cache\FrontendInterface $cache
- * @param \Magento\Framework\ObjectManager\Relations $relations
+ * @param \Magento\Framework\ObjectManager\RelationsInterface $relations
* @param \Magento\Framework\Interception\ObjectManager\Config $omConfig
- * @param \Magento\Framework\ObjectManager\Definition $classDefinitions
+ * @param \Magento\Framework\ObjectManager\DefinitionInterface $classDefinitions
* @param string $cacheId
*/
public function __construct(
\Magento\Framework\Config\ReaderInterface $reader,
\Magento\Framework\Config\ScopeListInterface $scopeList,
\Magento\Framework\Cache\FrontendInterface $cache,
- \Magento\Framework\ObjectManager\Relations $relations,
+ \Magento\Framework\ObjectManager\RelationsInterface $relations,
\Magento\Framework\Interception\ObjectManager\Config $omConfig,
- \Magento\Framework\ObjectManager\Definition $classDefinitions,
+ \Magento\Framework\ObjectManager\DefinitionInterface $classDefinitions,
$cacheId = 'interception'
) {
$this->_omConfig = $omConfig;
diff --git a/lib/internal/Magento/Framework/Interception/Config.php b/lib/internal/Magento/Framework/Interception/ConfigInterface.php
similarity index 97%
rename from lib/internal/Magento/Framework/Interception/Config.php
rename to lib/internal/Magento/Framework/Interception/ConfigInterface.php
index cdf59101e1444568fdf2e632940c390da7d7c4db..5fefd1a082599a273df4017f41b40ba2a40598e9 100644
--- a/lib/internal/Magento/Framework/Interception/Config.php
+++ b/lib/internal/Magento/Framework/Interception/ConfigInterface.php
@@ -19,13 +19,13 @@
* Do not edit or add to this file if you wish to upgrade Magento to newer
* versions in the future. If you wish to customize Magento for your
* needs please refer to http://www.magentocommerce.com for more information.
- *
+ *
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
namespace Magento\Framework\Interception;
-interface Config
+interface ConfigInterface
{
/**
* Check whether type has configured plugins
diff --git a/lib/internal/Magento/Framework/Interception/Definition/Compiled.php b/lib/internal/Magento/Framework/Interception/Definition/Compiled.php
index 3a07a54d80a4fac0db8842bc651a829d0fcd01ab..f42553bfbde0b1a225d3406388059d986267423b 100644
--- a/lib/internal/Magento/Framework/Interception/Definition/Compiled.php
+++ b/lib/internal/Magento/Framework/Interception/Definition/Compiled.php
@@ -25,9 +25,9 @@
*/
namespace Magento\Framework\Interception\Definition;
-use Magento\Framework\Interception\Definition;
+use Magento\Framework\Interception\DefinitionInterface;
-class Compiled implements Definition
+class Compiled implements DefinitionInterface
{
/**
* List of plugin definitions
diff --git a/lib/internal/Magento/Framework/Interception/Definition/Runtime.php b/lib/internal/Magento/Framework/Interception/Definition/Runtime.php
index c755ef95097ad8fc2a63ef864a8de17f1c7cc96c..f1eefd215c94af6ad6ad77cd9c72e68017215f7f 100644
--- a/lib/internal/Magento/Framework/Interception/Definition/Runtime.php
+++ b/lib/internal/Magento/Framework/Interception/Definition/Runtime.php
@@ -26,9 +26,9 @@
*/
namespace Magento\Framework\Interception\Definition;
-use Magento\Framework\Interception\Definition;
+use Magento\Framework\Interception\DefinitionInterface;
-class Runtime implements Definition
+class Runtime implements DefinitionInterface
{
/**
* @var array
diff --git a/lib/internal/Magento/Framework/Interception/Definition.php b/lib/internal/Magento/Framework/Interception/DefinitionInterface.php
similarity index 97%
rename from lib/internal/Magento/Framework/Interception/Definition.php
rename to lib/internal/Magento/Framework/Interception/DefinitionInterface.php
index a0a1b5a3742b13b2ad65892957ace2205f7823f8..b4ffa7a856e9e8679f3b2814cc1fc372b500f750 100644
--- a/lib/internal/Magento/Framework/Interception/Definition.php
+++ b/lib/internal/Magento/Framework/Interception/DefinitionInterface.php
@@ -25,7 +25,7 @@
*/
namespace Magento\Framework\Interception;
-interface Definition
+interface DefinitionInterface
{
const LISTENER_BEFORE = 1;
diff --git a/lib/internal/Magento/Framework/Interception/ObjectManager/Config.php b/lib/internal/Magento/Framework/Interception/ObjectManager/Config.php
index ba1aa3708868cb5ac315251fce0c36437c685e1c..cfe3322a3b0eec8f39a1b1d13ae261577244e2d0 100644
--- a/lib/internal/Magento/Framework/Interception/ObjectManager/Config.php
+++ b/lib/internal/Magento/Framework/Interception/ObjectManager/Config.php
@@ -28,17 +28,17 @@ namespace Magento\Framework\Interception\ObjectManager;
class Config extends \Magento\Framework\ObjectManager\Config\Config
{
/**
- * @var \Magento\Framework\Interception\Config
+ * @var \Magento\Framework\Interception\ConfigInterface
*/
protected $interceptionConfig;
/**
* Set Interception config
*
- * @param \Magento\Framework\Interception\Config $interceptionConfig
+ * @param \Magento\Framework\Interception\ConfigInterface $interceptionConfig
* @return void
*/
- public function setInterceptionConfig(\Magento\Framework\Interception\Config $interceptionConfig)
+ public function setInterceptionConfig(\Magento\Framework\Interception\ConfigInterface $interceptionConfig)
{
$this->interceptionConfig = $interceptionConfig;
}
diff --git a/lib/internal/Magento/Framework/Interception/PluginList/PluginList.php b/lib/internal/Magento/Framework/Interception/PluginList/PluginList.php
index e978ee2350f1c58b5a01587053c8b9981f0b8c8a..311a94581cf5dbc050d785859606c1db3fc66844 100644
--- a/lib/internal/Magento/Framework/Interception/PluginList/PluginList.php
+++ b/lib/internal/Magento/Framework/Interception/PluginList/PluginList.php
@@ -29,12 +29,12 @@ use Magento\Framework\Config\ReaderInterface;
use Magento\Framework\Config\ScopeInterface;
use Magento\Framework\Config\CacheInterface;
use Magento\Framework\Config\Data\Scoped;
-use Magento\Framework\Interception\Definition;
-use Magento\Framework\Interception\PluginList as InterceptionPluginList;
+use Magento\Framework\Interception\DefinitionInterface;
+use Magento\Framework\Interception\PluginListInterface as InterceptionPluginList;
use Magento\Framework\Interception\ObjectManager\Config;
-use Magento\Framework\ObjectManager\Relations;
-use Magento\Framework\ObjectManager\Definition as ClassDefinitions;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManager\RelationsInterface;
+use Magento\Framework\ObjectManager\DefinitionInterface as ClassDefinitions;
+use Magento\Framework\ObjectManagerInterface;
use Zend\Soap\Exception\InvalidArgumentException;
class PluginList extends Scoped implements InterceptionPluginList
@@ -63,14 +63,14 @@ class PluginList extends Scoped implements InterceptionPluginList
/**
* Class relations information provider
*
- * @var Relations
+ * @var RelationsInterface
*/
protected $_relations;
/**
* List of interception methods per plugin
*
- * @var Definition
+ * @var DefinitionInterface
*/
protected $_definitions;
@@ -82,7 +82,7 @@ class PluginList extends Scoped implements InterceptionPluginList
protected $_classDefinitions;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -95,10 +95,10 @@ class PluginList extends Scoped implements InterceptionPluginList
* @param ReaderInterface $reader
* @param ScopeInterface $configScope
* @param CacheInterface $cache
- * @param Relations $relations
+ * @param RelationsInterface $relations
* @param Config $omConfig
- * @param Definition $definitions
- * @param ObjectManager $objectManager
+ * @param DefinitionInterface $definitions
+ * @param ObjectManagerInterface $objectManager
* @param ClassDefinitions $classDefinitions
* @param array $scopePriorityScheme
* @param string $cacheId
@@ -107,10 +107,10 @@ class PluginList extends Scoped implements InterceptionPluginList
ReaderInterface $reader,
ScopeInterface $configScope,
CacheInterface $cache,
- Relations $relations,
+ RelationsInterface $relations,
Config $omConfig,
- Definition $definitions,
- ObjectManager $objectManager,
+ DefinitionInterface $definitions,
+ ObjectManagerInterface $objectManager,
ClassDefinitions $classDefinitions,
array $scopePriorityScheme = array('global'),
$cacheId = 'plugins'
@@ -178,15 +178,15 @@ class PluginList extends Scoped implements InterceptionPluginList
foreach ($this->_definitions->getMethodList($pluginType) as $pluginMethod => $methodTypes) {
$current = isset($lastPerMethod[$pluginMethod]) ? $lastPerMethod[$pluginMethod] : '__self';
$currentKey = $type . '_' . $pluginMethod . '_' . $current;
- if ($methodTypes & Definition::LISTENER_AROUND) {
- $this->_processed[$currentKey][Definition::LISTENER_AROUND] = $key;
+ if ($methodTypes & DefinitionInterface::LISTENER_AROUND) {
+ $this->_processed[$currentKey][DefinitionInterface::LISTENER_AROUND] = $key;
$lastPerMethod[$pluginMethod] = $key;
}
- if ($methodTypes & Definition::LISTENER_BEFORE) {
- $this->_processed[$currentKey][Definition::LISTENER_BEFORE][] = $key;
+ if ($methodTypes & DefinitionInterface::LISTENER_BEFORE) {
+ $this->_processed[$currentKey][DefinitionInterface::LISTENER_BEFORE][] = $key;
}
- if ($methodTypes & Definition::LISTENER_AFTER) {
- $this->_processed[$currentKey][Definition::LISTENER_AFTER][] = $key;
+ if ($methodTypes & DefinitionInterface::LISTENER_AFTER) {
+ $this->_processed[$currentKey][DefinitionInterface::LISTENER_AFTER][] = $key;
}
}
}
diff --git a/lib/internal/Magento/Framework/Interception/PluginList.php b/lib/internal/Magento/Framework/Interception/PluginListInterface.php
similarity index 97%
rename from lib/internal/Magento/Framework/Interception/PluginList.php
rename to lib/internal/Magento/Framework/Interception/PluginListInterface.php
index 148cd21f1d071de77cfcc816fbfb702a0c33f465..c1d5c12ebafbe6832adc2f874f70358246e9373c 100644
--- a/lib/internal/Magento/Framework/Interception/PluginList.php
+++ b/lib/internal/Magento/Framework/Interception/PluginListInterface.php
@@ -19,13 +19,13 @@
* Do not edit or add to this file if you wish to upgrade Magento to newer
* versions in the future. If you wish to customize Magento for your
* needs please refer to http://www.magentocommerce.com for more information.
- *
+ *
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
namespace Magento\Framework\Interception;
-interface PluginList
+interface PluginListInterface
{
/**
* Retrieve next plugins in chain
diff --git a/lib/internal/Magento/Framework/LocaleFactory.php b/lib/internal/Magento/Framework/LocaleFactory.php
index 10d9623c6957d5891e7ca0fad2d3565f4084b497..936784e6998a2ae57c285f5e68d13b84dc353420 100644
--- a/lib/internal/Magento/Framework/LocaleFactory.php
+++ b/lib/internal/Magento/Framework/LocaleFactory.php
@@ -26,7 +26,7 @@ namespace Magento\Framework;
class LocaleFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -36,11 +36,11 @@ class LocaleFactory
protected $_instanceName = null;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\LocaleInterface'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/Mail/Template/Factory.php b/lib/internal/Magento/Framework/Mail/Template/Factory.php
index 6b64694aa99a6901590bea9810a5b77e12f7b6fc..1e25b98e0779ad93c3093a1a6b5f0cef5c85f825 100644
--- a/lib/internal/Magento/Framework/Mail/Template/Factory.php
+++ b/lib/internal/Magento/Framework/Mail/Template/Factory.php
@@ -28,7 +28,7 @@ namespace Magento\Framework\Mail\Template;
class Factory implements \Magento\Framework\Mail\Template\FactoryInterface
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -38,11 +38,11 @@ class Factory implements \Magento\Framework\Mail\Template\FactoryInterface
protected $_instanceName = null;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\Mail\TemplateInterface'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php b/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php
index c69d4793d3add5ae8ad777a0be3a4ce918907faf..91c29aa6c59a25155363071eb7b90416bdd8a592 100644
--- a/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php
+++ b/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php
@@ -65,7 +65,7 @@ class TransportBuilder
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -92,14 +92,14 @@ class TransportBuilder
* @param FactoryInterface $templateFactory
* @param \Magento\Framework\Mail\Message $message
* @param \Magento\Framework\Mail\Template\SenderResolverInterface $senderResolver
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Mail\TransportInterfaceFactory $mailTransportFactory
*/
public function __construct(
\Magento\Framework\Mail\Template\FactoryInterface $templateFactory,
\Magento\Framework\Mail\Message $message,
\Magento\Framework\Mail\Template\SenderResolverInterface $senderResolver,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Mail\TransportInterfaceFactory $mailTransportFactory
) {
$this->templateFactory = $templateFactory;
diff --git a/lib/internal/Magento/Framework/Mail/TransportInterfaceFactory.php b/lib/internal/Magento/Framework/Mail/TransportInterfaceFactory.php
index ae6b0cb4cd4350064417d2e2909583b19adabfd7..d070884e8a241572e518eadf1dacc4619c5a70e1 100644
--- a/lib/internal/Magento/Framework/Mail/TransportInterfaceFactory.php
+++ b/lib/internal/Magento/Framework/Mail/TransportInterfaceFactory.php
@@ -32,7 +32,7 @@ class TransportInterfaceFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -46,11 +46,11 @@ class TransportInterfaceFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\Mail\TransportInterface'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/Message/CollectionFactory.php b/lib/internal/Magento/Framework/Message/CollectionFactory.php
index a260394e897d6d7a1571c7e27730475aa4ffa28a..6fad1365e7556fa5b097c89af4257988e1b05456 100644
--- a/lib/internal/Magento/Framework/Message/CollectionFactory.php
+++ b/lib/internal/Magento/Framework/Message/CollectionFactory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\Message;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Message collection factory
@@ -33,14 +33,14 @@ class CollectionFactory
/**
* Object Manager instance
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Message/Factory.php b/lib/internal/Magento/Framework/Message/Factory.php
index e7cc6dbbd08ae838ccb73a68941c964873a24fc1..21b849993aa69374debd1b3c9f6f667200212154 100644
--- a/lib/internal/Magento/Framework/Message/Factory.php
+++ b/lib/internal/Magento/Framework/Message/Factory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\Message;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Message model factory
@@ -45,16 +45,16 @@ class Factory
/**
* Object Manager instance
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
* Factory constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Model/AbstractExtensibleModel.php b/lib/internal/Magento/Framework/Model/AbstractExtensibleModel.php
index db4e2d18c1959d6edaac759e30a62841109423d7..b1e390f571f1d89bff2a6b11767f5cc42835c394 100644
--- a/lib/internal/Magento/Framework/Model/AbstractExtensibleModel.php
+++ b/lib/internal/Magento/Framework/Model/AbstractExtensibleModel.php
@@ -123,7 +123,7 @@ abstract class AbstractExtensibleModel extends AbstractModel implements Extensib
*/
public function setData($key, $value = null)
{
- if ($key == self::CUSTOM_ATTRIBUTES) {
+ if ($key === self::CUSTOM_ATTRIBUTES) {
throw new \LogicException("Custom attributes must be set only using setCustomAttribute() method.");
}
return parent::setData($key, $value);
diff --git a/lib/internal/Magento/Framework/Module/Setup/MigrationFactory.php b/lib/internal/Magento/Framework/Module/Setup/MigrationFactory.php
index 4e1930d8b842b2eeddad310426ad2fd74cbc3fc2..c99e238848faaf3fd793a8fb18078878feddd43c 100644
--- a/lib/internal/Magento/Framework/Module/Setup/MigrationFactory.php
+++ b/lib/internal/Magento/Framework/Module/Setup/MigrationFactory.php
@@ -31,7 +31,7 @@ class MigrationFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -45,10 +45,10 @@ class MigrationFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $instanceName = 'Magento\Framework\Module\Setup\Migration')
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\Framework\Module\Setup\Migration')
{
$this->_objectManager = $objectManager;
$this->_instanceName = $instanceName;
diff --git a/lib/internal/Magento/Framework/Module/Updater/SetupFactory.php b/lib/internal/Magento/Framework/Module/Updater/SetupFactory.php
index d717d52443d6be29540c2c0899679ca9752a8e75..09cb221fce98320d3f09ec30747410a00d9ff4b0 100644
--- a/lib/internal/Magento/Framework/Module/Updater/SetupFactory.php
+++ b/lib/internal/Magento/Framework/Module/Updater/SetupFactory.php
@@ -25,14 +25,14 @@
*/
namespace Magento\Framework\Module\Updater;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class SetupFactory
{
const INSTANCE_TYPE = 'Magento\Framework\Module\Updater\SetupInterface';
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $_objectManager;
@@ -42,10 +42,10 @@ class SetupFactory
protected $_resourceTypes;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param array $resourceTypes
*/
- public function __construct(ObjectManager $objectManager, array $resourceTypes)
+ public function __construct(ObjectManagerInterface $objectManager, array $resourceTypes)
{
$this->_objectManager = $objectManager;
$this->_resourceTypes = $resourceTypes;
diff --git a/lib/internal/Magento/Framework/Mview/ActionFactory.php b/lib/internal/Magento/Framework/Mview/ActionFactory.php
index d622f72a99f55fc45a8304ab6842a38b90d4825d..cccedb2b257835a6d045a0daa7e7d28425220cf2 100644
--- a/lib/internal/Magento/Framework/Mview/ActionFactory.php
+++ b/lib/internal/Magento/Framework/Mview/ActionFactory.php
@@ -26,14 +26,14 @@ namespace Magento\Framework\Mview;
class ActionFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Mview/Config/Data/Proxy.php b/lib/internal/Magento/Framework/Mview/Config/Data/Proxy.php
index 27568e170658761fe2870f75d073d96623131723..bc30d928142e5a719a435c7c7081ac30e8542017 100644
--- a/lib/internal/Magento/Framework/Mview/Config/Data/Proxy.php
+++ b/lib/internal/Magento/Framework/Mview/Config/Data/Proxy.php
@@ -31,7 +31,7 @@ class Proxy extends \Magento\Framework\Mview\Config\Data
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -57,12 +57,12 @@ class Proxy extends \Magento\Framework\Mview\Config\Data
protected $isShared = null;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
* @param bool $shared
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\Mview\Config\Data',
$shared = true
) {
diff --git a/lib/internal/Magento/Framework/Mview/View/AbstractFactory.php b/lib/internal/Magento/Framework/Mview/View/AbstractFactory.php
index 5440d7038afe035660b17dac39aa2af7f2c9e566..4d227df06e5b83c9eb41b107c0148ed8f7391c0c 100644
--- a/lib/internal/Magento/Framework/Mview/View/AbstractFactory.php
+++ b/lib/internal/Magento/Framework/Mview/View/AbstractFactory.php
@@ -26,7 +26,7 @@ namespace Magento\Framework\Mview\View;
abstract class AbstractFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -36,9 +36,9 @@ abstract class AbstractFactory
const INSTANCE_NAME = '';
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Notification/MessageList.php b/lib/internal/Magento/Framework/Notification/MessageList.php
index ac75c22fdfefd250f6852fac7861b3762cca3521..47a49eb0fd58ac8002375a7c15b2ce96d92b76f7 100644
--- a/lib/internal/Magento/Framework/Notification/MessageList.php
+++ b/lib/internal/Magento/Framework/Notification/MessageList.php
@@ -46,10 +46,10 @@ class MessageList
protected $_messages;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $messages
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $messages = array())
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $messages = array())
{
$this->_objectManager = $objectManager;
$this->_messageClasses = $messages;
diff --git a/lib/internal/Magento/Framework/Notification/NotifierList.php b/lib/internal/Magento/Framework/Notification/NotifierList.php
index 404cf7481472b19ed3f0f0f2a6247930afe95298..a389848427b09d0e7de130dca94af422c6310dd6 100644
--- a/lib/internal/Magento/Framework/Notification/NotifierList.php
+++ b/lib/internal/Magento/Framework/Notification/NotifierList.php
@@ -32,7 +32,7 @@ class NotifierList
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -51,10 +51,10 @@ class NotifierList
protected $isNotifiersVerified;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param NotifierInterface[]|string[] $notifiers
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $notifiers = array())
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $notifiers = array())
{
$this->objectManager = $objectManager;
$this->notifiers = $notifiers;
diff --git a/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Factory.php b/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Factory.php
index 6cb0a0e990e52db6dedf7151842f11f5f199daea..9491d7c60baf80d682fdfabbe1a113ab3bee10fc 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Factory.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Factory.php
@@ -61,14 +61,17 @@ class Factory extends \Magento\Framework\Code\Generator\EntityAbstract
return array(
'name' => '__construct',
'parameters' => array(
- array('name' => 'objectManager', 'type' => '\Magento\Framework\ObjectManager'),
+ array('name' => 'objectManager', 'type' => '\Magento\Framework\ObjectManagerInterface'),
array('name' => 'instanceName', 'defaultValue' => $this->_getSourceClassName())
),
'body' => "\$this->_objectManager = \$objectManager;\n\$this->_instanceName = \$instanceName;",
'docblock' => array(
'shortDescription' => ucfirst(static::ENTITY_TYPE) . ' constructor',
'tags' => array(
- array('name' => 'param', 'description' => '\Magento\Framework\ObjectManager $objectManager'),
+ array(
+ 'name' => 'param',
+ 'description' => '\Magento\Framework\ObjectManagerInterface $objectManager'
+ ),
array('name' => 'param', 'description' => 'string $instanceName')
)
)
diff --git a/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Proxy.php b/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Proxy.php
index ebc607db01466ed48631443e9dad0bd7f9679892..361b41abbc6cecfcb7acba95a6899c1296c80e06 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Proxy.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Proxy.php
@@ -188,11 +188,17 @@ class Proxy extends \Magento\Framework\Code\Generator\EntityAbstract
*/
protected function _getDefaultConstructorDefinition()
{
- // public function __construct(\Magento\Framework\ObjectManager $objectManager, $instanceName, $shared = false)
+ /*
+ * public function __construct(
+ * \Magento\Framework\ObjectManagerInterface $objectManager,
+ * $instanceName,
+ * $shared = false
+ * )
+ */
return array(
'name' => '__construct',
'parameters' => array(
- array('name' => 'objectManager', 'type' => '\Magento\Framework\ObjectManager'),
+ array('name' => 'objectManager', 'type' => '\Magento\Framework\ObjectManagerInterface'),
array('name' => 'instanceName', 'defaultValue' => $this->_getSourceClassName()),
array('name' => 'shared', 'defaultValue' => true)
),
@@ -202,7 +208,10 @@ class Proxy extends \Magento\Framework\Code\Generator\EntityAbstract
'docblock' => array(
'shortDescription' => ucfirst(static::ENTITY_TYPE) . ' constructor',
'tags' => array(
- array('name' => 'param', 'description' => '\Magento\Framework\ObjectManager $objectManager'),
+ array(
+ 'name' => 'param',
+ 'description' => '\Magento\Framework\ObjectManagerInterface $objectManager'
+ ),
array('name' => 'param', 'description' => 'string $instanceName'),
array('name' => 'param', 'description' => 'bool $shared')
)
diff --git a/lib/internal/Magento/Framework/ObjectManager/Config/Config.php b/lib/internal/Magento/Framework/ObjectManager/Config/Config.php
index 52038808607d864f550ca9b9ca53f39e8db2319e..75d4e2ef551d4417eac99a03031681504a25546c 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Config/Config.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Config/Config.php
@@ -23,23 +23,23 @@
*/
namespace Magento\Framework\ObjectManager\Config;
-use Magento\Framework\ObjectManager\ConfigCache;
-use Magento\Framework\ObjectManager\Definition;
-use Magento\Framework\ObjectManager\Relations;
+use Magento\Framework\ObjectManager\ConfigCacheInterface;
+use Magento\Framework\ObjectManager\DefinitionInterface;
+use Magento\Framework\ObjectManager\RelationsInterface;
-class Config implements \Magento\Framework\ObjectManager\Config
+class Config implements \Magento\Framework\ObjectManager\ConfigInterface
{
/**
* Config cache
*
- * @var ConfigCache
+ * @var ConfigCacheInterface
*/
protected $_cache;
/**
* Class definitions
*
- * @var \Magento\Framework\ObjectManager\Definition
+ * @var \Magento\Framework\ObjectManager\DefinitionInterface
*/
protected $_definitions;
@@ -81,7 +81,7 @@ class Config implements \Magento\Framework\ObjectManager\Config
/**
* List of relations
*
- * @var Relations
+ * @var RelationsInterface
*/
protected $_relations;
@@ -93,10 +93,10 @@ class Config implements \Magento\Framework\ObjectManager\Config
protected $_mergedArguments;
/**
- * @param Relations $relations
- * @param Definition $definitions
+ * @param RelationsInterface $relations
+ * @param DefinitionInterface $definitions
*/
- public function __construct(Relations $relations = null, Definition $definitions = null)
+ public function __construct(RelationsInterface $relations = null, DefinitionInterface $definitions = null)
{
$this->_relations = $relations ?: new \Magento\Framework\ObjectManager\Relations\Runtime();
$this->_definitions = $definitions ?: new \Magento\Framework\ObjectManager\Definition\Runtime();
@@ -105,10 +105,10 @@ class Config implements \Magento\Framework\ObjectManager\Config
/**
* Set class relations
*
- * @param Relations $relations
+ * @param RelationsInterface $relations
* @return void
*/
- public function setRelations(Relations $relations)
+ public function setRelations(RelationsInterface $relations)
{
$this->_relations = $relations;
}
@@ -116,10 +116,10 @@ class Config implements \Magento\Framework\ObjectManager\Config
/**
* Set cache instance
*
- * @param ConfigCache $cache
+ * @param ConfigCacheInterface $cache
* @return void
*/
- public function setCache(ConfigCache $cache)
+ public function setCache(ConfigCacheInterface $cache)
{
$this->_cache = $cache;
}
diff --git a/lib/internal/Magento/Framework/ObjectManager/Config/Reader/DomFactory.php b/lib/internal/Magento/Framework/ObjectManager/Config/Reader/DomFactory.php
index ce7bd28cfbc4810dd790825d6cf6ff318114d56a..72663c07ea131d4ae17890ba1e57d17889215d58 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Config/Reader/DomFactory.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Config/Reader/DomFactory.php
@@ -33,7 +33,7 @@ class DomFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -47,11 +47,11 @@ class DomFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\ObjectManager\Config\Reader\Dom'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/ObjectManager/ConfigCache.php b/lib/internal/Magento/Framework/ObjectManager/ConfigCacheInterface.php
similarity index 97%
rename from lib/internal/Magento/Framework/ObjectManager/ConfigCache.php
rename to lib/internal/Magento/Framework/ObjectManager/ConfigCacheInterface.php
index 0b49ebdd259893eae3d104933d0bdff35c360274..0e550b72594e922de83f89a97b662742c5dc6388 100644
--- a/lib/internal/Magento/Framework/ObjectManager/ConfigCache.php
+++ b/lib/internal/Magento/Framework/ObjectManager/ConfigCacheInterface.php
@@ -17,13 +17,13 @@
* Do not edit or add to this file if you wish to upgrade Magento to newer
* versions in the future. If you wish to customize Magento for your
* needs please refer to http://www.magentocommerce.com for more information.
- *
+ *
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
namespace Magento\Framework\ObjectManager;
-interface ConfigCache
+interface ConfigCacheInterface
{
/**
* Retrieve configuration from cache
diff --git a/lib/internal/Magento/Framework/ObjectManager/Config.php b/lib/internal/Magento/Framework/ObjectManager/ConfigInterface.php
similarity index 88%
rename from lib/internal/Magento/Framework/ObjectManager/Config.php
rename to lib/internal/Magento/Framework/ObjectManager/ConfigInterface.php
index 3b24e0f3f8e3228abc0a0307ebd7b57a2417e359..c687dc91d66e175d5aed8e453df9a2bdce9b3942 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Config.php
+++ b/lib/internal/Magento/Framework/ObjectManager/ConfigInterface.php
@@ -17,31 +17,31 @@
* Do not edit or add to this file if you wish to upgrade Magento to newer
* versions in the future. If you wish to customize Magento for your
* needs please refer to http://www.magentocommerce.com for more information.
- *
+ *
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
namespace Magento\Framework\ObjectManager;
-interface Config
+interface ConfigInterface
{
/**
* Set class relations
*
- * @param Relations $relations
+ * @param RelationsInterface $relations
*
* @return void
*/
- public function setRelations(Relations $relations);
+ public function setRelations(RelationsInterface $relations);
/**
* Set configuration cache instance
*
- * @param ConfigCache $cache
+ * @param ConfigCacheInterface $cache
*
* @return void
*/
- public function setCache(ConfigCache $cache);
+ public function setCache(ConfigCacheInterface $cache);
/**
* Retrieve list of arguments per type
diff --git a/lib/internal/Magento/Framework/ObjectManager/Definition/Compiled.php b/lib/internal/Magento/Framework/ObjectManager/Definition/Compiled.php
index ab2f32af8e0aa8ea4fa8306c2514204a9460fe68..6735e776910f2b001858a79bdf2e7fcdbb2e9624 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Definition/Compiled.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Definition/Compiled.php
@@ -25,7 +25,7 @@
*/
namespace Magento\Framework\ObjectManager\Definition;
-abstract class Compiled implements \Magento\Framework\ObjectManager\Definition
+abstract class Compiled implements \Magento\Framework\ObjectManager\DefinitionInterface
{
/**
* Class definitions
diff --git a/lib/internal/Magento/Framework/ObjectManager/Definition/Runtime.php b/lib/internal/Magento/Framework/ObjectManager/Definition/Runtime.php
index 670ac9f388bbdaa36de873f64224705eeb8c99ea..ef19bbf798bba90f05fd845df722355d3a55d267 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Definition/Runtime.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Definition/Runtime.php
@@ -25,7 +25,7 @@
*/
namespace Magento\Framework\ObjectManager\Definition;
-class Runtime implements \Magento\Framework\ObjectManager\Definition
+class Runtime implements \Magento\Framework\ObjectManager\DefinitionInterface
{
/**
* @var array
diff --git a/lib/internal/Magento/Framework/ObjectManager/DefinitionFactory.php b/lib/internal/Magento/Framework/ObjectManager/DefinitionFactory.php
index db2e5ca7a379f8f68612b825959c6ace179bc8e2..d6422798cf9b083cb9b7a0899a3e593055f32c17 100644
--- a/lib/internal/Magento/Framework/ObjectManager/DefinitionFactory.php
+++ b/lib/internal/Magento/Framework/ObjectManager/DefinitionFactory.php
@@ -28,7 +28,7 @@ namespace Magento\Framework\ObjectManager;
use Magento\Framework\Filesystem\DriverInterface;
use Magento\Framework\ObjectManager\Definition\Runtime;
-use Magento\Framework\ObjectManager\Relations;
+use Magento\Framework\ObjectManager\RelationsInterface;
use Magento\Framework\ObjectManager\Code\Generator;
use Magento\Framework\Interception\Code\Generator as InterceptionGenerator;
use Magento\Framework\Api\Code\Generator\DataBuilder as DataBuilderGenerator;
@@ -117,14 +117,11 @@ class DefinitionFactory
$definitionModel = $this->_definitionClasses[$this->_definitionFormat];
$result = new $definitionModel($definitions);
} else {
- $fileResolver = new \Magento\Framework\Code\Generator\FileResolver();
$generatorIo = new \Magento\Framework\Code\Generator\Io(
$this->_filesystemDriver,
- $fileResolver,
$this->_generationDir
);
$generator = new \Magento\Framework\Code\Generator(
- $fileResolver,
$generatorIo,
array(
SearchResultsBuilder::ENTITY_TYPE
@@ -150,7 +147,7 @@ class DefinitionFactory
=> '\Magento\Framework\ObjectManager\Profiler\Code\Generator\Logger'
)
);
- $autoloader = new \Magento\Framework\Code\Generator\Autoloader($generator, $fileResolver);
+ $autoloader = new \Magento\Framework\Code\Generator\Autoloader($generator);
spl_autoload_register(array($autoloader, 'load'));
$result = new Runtime();
@@ -161,7 +158,7 @@ class DefinitionFactory
/**
* Create plugin definitions
*
- * @return \Magento\Framework\Interception\Definition
+ * @return \Magento\Framework\Interception\DefinitionInterface
*/
public function createPluginDefinition()
{
@@ -178,7 +175,7 @@ class DefinitionFactory
/**
* Create relations
*
- * @return Relations
+ * @return RelationsInterface
*/
public function createRelations()
{
diff --git a/lib/internal/Magento/Framework/ObjectManager/Definition.php b/lib/internal/Magento/Framework/ObjectManager/DefinitionInterface.php
similarity index 98%
rename from lib/internal/Magento/Framework/ObjectManager/Definition.php
rename to lib/internal/Magento/Framework/ObjectManager/DefinitionInterface.php
index e6e8688e333cb7e8e11e9b351475b80aa6dc1a71..3193e8319b6f9f99bf89a3e807ec84f3af1c38b8 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Definition.php
+++ b/lib/internal/Magento/Framework/ObjectManager/DefinitionInterface.php
@@ -25,7 +25,7 @@
*/
namespace Magento\Framework\ObjectManager;
-interface Definition
+interface DefinitionInterface
{
/**
* Get list of method parameters
diff --git a/lib/internal/Magento/Framework/ObjectManager/Factory/Factory.php b/lib/internal/Magento/Framework/ObjectManager/Factory/Factory.php
index f0119ed86e1d17bf6b50081923a6e9fb820d99cf..c6bf1e288aadb50094ee52eb2c033f5094580cb8 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Factory/Factory.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Factory/Factory.php
@@ -23,26 +23,26 @@
*/
namespace Magento\Framework\ObjectManager\Factory;
-class Factory implements \Magento\Framework\ObjectManager\Factory
+class Factory implements \Magento\Framework\ObjectManager\FactoryInterface
{
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* Object manager config
*
- * @var \Magento\Framework\ObjectManager\Config
+ * @var \Magento\Framework\ObjectManager\ConfigInterface
*/
protected $config;
/**
* Definition list
*
- * @var \Magento\Framework\ObjectManager\Definition
+ * @var \Magento\Framework\ObjectManager\DefinitionInterface
*/
protected $definitions;
@@ -54,15 +54,15 @@ class Factory implements \Magento\Framework\ObjectManager\Factory
protected $creationStack = array();
/**
- * @param \Magento\Framework\ObjectManager\Config $config
- * @param \Magento\Framework\ObjectManager $objectManager
- * @param \Magento\Framework\ObjectManager\Definition $definitions
+ * @param \Magento\Framework\ObjectManager\ConfigInterface $config
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
+ * @param \Magento\Framework\ObjectManager\DefinitionInterface $definitions
* @param array $globalArguments
*/
public function __construct(
- \Magento\Framework\ObjectManager\Config $config,
- \Magento\Framework\ObjectManager $objectManager = null,
- \Magento\Framework\ObjectManager\Definition $definitions = null,
+ \Magento\Framework\ObjectManager\ConfigInterface $config,
+ \Magento\Framework\ObjectManagerInterface $objectManager = null,
+ \Magento\Framework\ObjectManager\DefinitionInterface $definitions = null,
$globalArguments = array()
) {
$this->config = $config;
@@ -74,10 +74,10 @@ class Factory implements \Magento\Framework\ObjectManager\Factory
/**
* Set object manager
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @return void
*/
- public function setObjectManager(\Magento\Framework\ObjectManager $objectManager)
+ public function setObjectManager(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/ObjectManager/Factory.php b/lib/internal/Magento/Framework/ObjectManager/FactoryInterface.php
similarity index 97%
rename from lib/internal/Magento/Framework/ObjectManager/Factory.php
rename to lib/internal/Magento/Framework/ObjectManager/FactoryInterface.php
index a340bc65409f169f6963a55f3d9a0db8747b50bd..7fff7a953794e45d75d6488a43622bfedf6af1ee 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Factory.php
+++ b/lib/internal/Magento/Framework/ObjectManager/FactoryInterface.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\ObjectManager;
-interface Factory
+interface FactoryInterface
{
/**
* Create instance with call time arguments
diff --git a/lib/internal/Magento/Framework/ObjectManager/ObjectManager.php b/lib/internal/Magento/Framework/ObjectManager/ObjectManager.php
index 3c99c0d700639d3a454c7a96c0c1ba1fc6803f73..64c12f288ebf4390a1faeadcdde4020283b67a56 100644
--- a/lib/internal/Magento/Framework/ObjectManager/ObjectManager.php
+++ b/lib/internal/Magento/Framework/ObjectManager/ObjectManager.php
@@ -30,10 +30,10 @@
*/
namespace Magento\Framework\ObjectManager;
-class ObjectManager implements \Magento\Framework\ObjectManager
+class ObjectManager implements \Magento\Framework\ObjectManagerInterface
{
/**
- * @var \Magento\Framework\ObjectManager\Factory
+ * @var \Magento\Framework\ObjectManager\FactoryInterface
*/
protected $_factory;
@@ -50,16 +50,16 @@ class ObjectManager implements \Magento\Framework\ObjectManager
protected $_config;
/**
- * @param Factory $factory
- * @param Config $config
+ * @param FactoryInterface $factory
+ * @param ConfigInterface $config
* @param array $sharedInstances
*/
- public function __construct(Factory $factory, Config $config, array $sharedInstances = array())
+ public function __construct(FactoryInterface $factory, ConfigInterface $config, array $sharedInstances = array())
{
$this->_config = $config;
$this->_factory = $factory;
$this->_sharedInstances = $sharedInstances;
- $this->_sharedInstances['Magento\Framework\ObjectManager'] = $this;
+ $this->_sharedInstances['Magento\Framework\ObjectManagerInterface'] = $this;
}
/**
diff --git a/lib/internal/Magento/Framework/ObjectManager/Profiler/Code/Generator/Logger.php b/lib/internal/Magento/Framework/ObjectManager/Profiler/Code/Generator/Logger.php
index a106bd4762edfd9d8eb1c3b6330eb9a45a9e4600..eef2bcacb7e23389f86904c85450613e170b6c27 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Profiler/Code/Generator/Logger.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Profiler/Code/Generator/Logger.php
@@ -64,7 +64,7 @@ class Logger extends \Magento\Framework\Code\Generator\EntityAbstract
'docblock' => array(
'shortDescription' => 'Object Manager instance',
'tags' => array(
- array('name' => 'var', 'description' => '\Magento\Framework\ObjectManager')
+ array('name' => 'var', 'description' => '\Magento\Framework\ObjectManagerInterface')
)
),
),
diff --git a/lib/internal/Magento/Framework/ObjectManager/Profiler/FactoryDecorator.php b/lib/internal/Magento/Framework/ObjectManager/Profiler/FactoryDecorator.php
index f53f160cfb95fadf8412a3fcd0dc49ff174ad552..463e80e649e73cb52ac1cb58e9279c36055daceb 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Profiler/FactoryDecorator.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Profiler/FactoryDecorator.php
@@ -24,10 +24,10 @@
*/
namespace Magento\Framework\ObjectManager\Profiler;
-class FactoryDecorator implements \Magento\Framework\ObjectManager\Factory
+class FactoryDecorator implements \Magento\Framework\ObjectManager\FactoryInterface
{
/**
- * @var \Magento\Framework\ObjectManager\Factory
+ * @var \Magento\Framework\ObjectManager\FactoryInterface
*/
protected $subject;
@@ -37,21 +37,21 @@ class FactoryDecorator implements \Magento\Framework\ObjectManager\Factory
protected $log;
/**
- * @param \Magento\Framework\ObjectManager\Factory $subject
+ * @param \Magento\Framework\ObjectManager\FactoryInterface $subject
* @param Log $log
*/
- public function __construct(\Magento\Framework\ObjectManager\Factory $subject, Log $log)
+ public function __construct(\Magento\Framework\ObjectManager\FactoryInterface $subject, Log $log)
{
$this->subject = $subject;
$this->log = $log;
}
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*
* @return void
*/
- public function setObjectManager(\Magento\Framework\ObjectManager $objectManager)
+ public function setObjectManager(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->subject->setObjectManager($objectManager);
}
diff --git a/lib/internal/Magento/Framework/ObjectManager/Relations/Compiled.php b/lib/internal/Magento/Framework/ObjectManager/Relations/Compiled.php
index 22435dbde5032f9e88b587de4d8735d4036c6a05..985463d4f779f6eaf1bfce76a7a76a5d9dc2bf05 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Relations/Compiled.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Relations/Compiled.php
@@ -25,7 +25,7 @@
*/
namespace Magento\Framework\ObjectManager\Relations;
-class Compiled implements \Magento\Framework\ObjectManager\Relations
+class Compiled implements \Magento\Framework\ObjectManager\RelationsInterface
{
/**
* List of class relations
diff --git a/lib/internal/Magento/Framework/ObjectManager/Relations/Runtime.php b/lib/internal/Magento/Framework/ObjectManager/Relations/Runtime.php
index 6c5828ad60e2681b9ce843411f8be7cb6678ccfe..5e9ff0202c2809887ada66fc2f1e7962ff765cfc 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Relations/Runtime.php
+++ b/lib/internal/Magento/Framework/ObjectManager/Relations/Runtime.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\ObjectManager\Relations;
-class Runtime implements \Magento\Framework\ObjectManager\Relations
+class Runtime implements \Magento\Framework\ObjectManager\RelationsInterface
{
/**
* @var \Magento\Framework\Code\Reader\ClassReader
diff --git a/lib/internal/Magento/Framework/ObjectManager/Relations.php b/lib/internal/Magento/Framework/ObjectManager/RelationsInterface.php
similarity index 97%
rename from lib/internal/Magento/Framework/ObjectManager/Relations.php
rename to lib/internal/Magento/Framework/ObjectManager/RelationsInterface.php
index 3e92fa045c3a4f772522afb7237620ef49207838..b72dd773f8492833650925fbeab9f77c310ff09d 100644
--- a/lib/internal/Magento/Framework/ObjectManager/Relations.php
+++ b/lib/internal/Magento/Framework/ObjectManager/RelationsInterface.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\ObjectManager;
-interface Relations
+interface RelationsInterface
{
/**
* Check whether requested type is available for read
diff --git a/lib/internal/Magento/Framework/ObjectManager.php b/lib/internal/Magento/Framework/ObjectManagerInterface.php
similarity index 97%
rename from lib/internal/Magento/Framework/ObjectManager.php
rename to lib/internal/Magento/Framework/ObjectManagerInterface.php
index ba9046281cc9cdf1356e21b0d3081abed817506c..163d55458cf181cddd1448cfb1713bc9b12ec586 100644
--- a/lib/internal/Magento/Framework/ObjectManager.php
+++ b/lib/internal/Magento/Framework/ObjectManagerInterface.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework;
-interface ObjectManager
+interface ObjectManagerInterface
{
/**
* Create new object instance
diff --git a/lib/internal/Magento/Framework/Option/ArrayPool.php b/lib/internal/Magento/Framework/Option/ArrayPool.php
index 0996614c2e97278218c5dcea35b891d66d8459d8..856a72ceab42af315b8af941e7b6b4e85840cbb4 100644
--- a/lib/internal/Magento/Framework/Option/ArrayPool.php
+++ b/lib/internal/Magento/Framework/Option/ArrayPool.php
@@ -29,14 +29,14 @@ namespace Magento\Framework\Option;
class ArrayPool
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Pricing/Adjustment/Factory.php b/lib/internal/Magento/Framework/Pricing/Adjustment/Factory.php
index 8192001c7d4119fe7602f8736fb28731ac3443a3..cea7a493c1a91ee4b52be18edcc870a5f73e0843 100644
--- a/lib/internal/Magento/Framework/Pricing/Adjustment/Factory.php
+++ b/lib/internal/Magento/Framework/Pricing/Adjustment/Factory.php
@@ -32,16 +32,16 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Pricing/Amount/AmountFactory.php b/lib/internal/Magento/Framework/Pricing/Amount/AmountFactory.php
index 0676554f3c377d71fb4e7bd163eb2d9480e451ed..d1197ecd388c8d99e864fc09dcf07a5a953f1de0 100644
--- a/lib/internal/Magento/Framework/Pricing/Amount/AmountFactory.php
+++ b/lib/internal/Magento/Framework/Pricing/Amount/AmountFactory.php
@@ -35,16 +35,16 @@ class AmountFactory
const DEFAULT_PRICE_AMOUNT_CLASS = 'Magento\Framework\Pricing\Amount\AmountInterface';
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Pricing/Object/SaleableInterface.php b/lib/internal/Magento/Framework/Pricing/Object/SaleableInterface.php
index e89b7d8a795961d021e436efbbb67061ab4c465b..a40fda411a7ce1acc3bb66f9837ec7f80b5293b4 100644
--- a/lib/internal/Magento/Framework/Pricing/Object/SaleableInterface.php
+++ b/lib/internal/Magento/Framework/Pricing/Object/SaleableInterface.php
@@ -39,7 +39,7 @@ interface SaleableInterface
/**
* Returns type identifier of saleable item
*
- * @return string
+ * @return array|string
*/
public function getTypeId();
diff --git a/lib/internal/Magento/Framework/Pricing/Price/Collection.php b/lib/internal/Magento/Framework/Pricing/Price/Collection.php
index ba2cb3af39eefd7f574f12ef91dbb003d415bc69..3686d07f12362b6ed74eaec6fc5c08f4a668f441 100644
--- a/lib/internal/Magento/Framework/Pricing/Price/Collection.php
+++ b/lib/internal/Magento/Framework/Pricing/Price/Collection.php
@@ -24,7 +24,7 @@
namespace Magento\Framework\Pricing\Price;
-use \Magento\Framework\ObjectManager;
+use \Magento\Framework\ObjectManagerInterface;
use \Magento\Framework\Pricing\Object\SaleableInterface;
/**
diff --git a/lib/internal/Magento/Framework/Pricing/Price/Factory.php b/lib/internal/Magento/Framework/Pricing/Price/Factory.php
index 22897b2d173daa148b874411dc4f8ff9d56f963d..fa88b71fc22dd25d2aa8e6fccec1837891af7f30 100644
--- a/lib/internal/Magento/Framework/Pricing/Price/Factory.php
+++ b/lib/internal/Magento/Framework/Pricing/Price/Factory.php
@@ -34,16 +34,16 @@ class Factory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* Construct
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Pricing/PriceInfo/Factory.php b/lib/internal/Magento/Framework/Pricing/PriceInfo/Factory.php
index 753af9fb19a3b2bd2db3ed1d1ad5e31d5757b13f..db6c6a2087a0b71e4de3dbd0db0f1afc9a2147d4 100644
--- a/lib/internal/Magento/Framework/Pricing/PriceInfo/Factory.php
+++ b/lib/internal/Magento/Framework/Pricing/PriceInfo/Factory.php
@@ -27,7 +27,7 @@
*/
namespace Magento\Framework\Pricing\PriceInfo;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\Pricing\Object\SaleableInterface;
/**
@@ -45,7 +45,7 @@ class Factory
/**
* Object Manager
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
@@ -53,11 +53,11 @@ class Factory
* Construct
*
* @param array $types
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
public function __construct(
array $types,
- ObjectManager $objectManager
+ ObjectManagerInterface $objectManager
) {
$this->types = $types;
$this->objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/Reflection/DataObjectProcessor.php b/lib/internal/Magento/Framework/Reflection/DataObjectProcessor.php
index 4b27b18f1f4cc7cb326681fcbb45a5d4553779fa..26bd5f6dfc2000b2204116c74d4fbc39679152a4 100644
--- a/lib/internal/Magento/Framework/Reflection/DataObjectProcessor.php
+++ b/lib/internal/Magento/Framework/Reflection/DataObjectProcessor.php
@@ -29,7 +29,7 @@ use Zend\Code\Reflection\MethodReflection;
use Magento\Framework\Api\SimpleDataObjectConverter;
use Magento\Framework\Api\AttributeValue;
use Magento\Framework\Api\ExtensibleDataInterface;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Data object processor for de-serialization using class reflection
diff --git a/lib/internal/Magento/Framework/Search/Adapter/Mysql/AggregationFactory.php b/lib/internal/Magento/Framework/Search/Adapter/Mysql/AggregationFactory.php
index 314060f2d756ecc14356f425425baa9bee24bf2a..48e7b14d25d68cc1ba039e547407ad5e97ac4b5f 100644
--- a/lib/internal/Magento/Framework/Search/Adapter/Mysql/AggregationFactory.php
+++ b/lib/internal/Magento/Framework/Search/Adapter/Mysql/AggregationFactory.php
@@ -31,14 +31,14 @@ class AggregationFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Search/Adapter/Mysql/DocumentFactory.php b/lib/internal/Magento/Framework/Search/Adapter/Mysql/DocumentFactory.php
index 5106b706053c60ffbd3e4a84b4578e86c7d73f51..0690d3005c3fb9e0ce0e53be107ffb264fe09bcd 100644
--- a/lib/internal/Magento/Framework/Search/Adapter/Mysql/DocumentFactory.php
+++ b/lib/internal/Magento/Framework/Search/Adapter/Mysql/DocumentFactory.php
@@ -31,7 +31,7 @@ class DocumentFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -41,11 +41,11 @@ class DocumentFactory
private $entityMetadata;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param \Magento\Framework\Search\EntityMetadata $entityMetadata
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
\Magento\Framework\Search\EntityMetadata $entityMetadata
) {
$this->objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/Search/Adapter/Mysql/ResponseFactory.php b/lib/internal/Magento/Framework/Search/Adapter/Mysql/ResponseFactory.php
index 28f013cdbc675570e46335e38e3ebed9d4a1a545..b9c2c6bb79a6baf26471a09f468b28e3da72787e 100644
--- a/lib/internal/Magento/Framework/Search/Adapter/Mysql/ResponseFactory.php
+++ b/lib/internal/Magento/Framework/Search/Adapter/Mysql/ResponseFactory.php
@@ -31,7 +31,7 @@ class ResponseFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -50,12 +50,12 @@ class ResponseFactory
protected $aggregationFactory;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param DocumentFactory $documentFactory
* @param AggregationFactory $aggregationFactory
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
DocumentFactory $documentFactory,
AggregationFactory $aggregationFactory
) {
diff --git a/lib/internal/Magento/Framework/Search/Adapter/Mysql/ScoreBuilderFactory.php b/lib/internal/Magento/Framework/Search/Adapter/Mysql/ScoreBuilderFactory.php
index fc6ea871c61cafeb9e08591a437407a1e2b274ba..1ec3abdf04a9062e9d3c8d6d12e542cee3ae9e87 100644
--- a/lib/internal/Magento/Framework/Search/Adapter/Mysql/ScoreBuilderFactory.php
+++ b/lib/internal/Magento/Framework/Search/Adapter/Mysql/ScoreBuilderFactory.php
@@ -31,7 +31,7 @@ class ScoreBuilderFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -45,11 +45,11 @@ class ScoreBuilderFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\Search\Adapter\Mysql\ScoreBuilder'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/Search/Dynamic/IntervalFactory.php b/lib/internal/Magento/Framework/Search/Dynamic/IntervalFactory.php
index 350fbf584f605a10abc7a5e548561b64dd4e6017..b880343542078a8f15817e372eef0eef9251c2ae 100644
--- a/lib/internal/Magento/Framework/Search/Dynamic/IntervalFactory.php
+++ b/lib/internal/Magento/Framework/Search/Dynamic/IntervalFactory.php
@@ -25,7 +25,7 @@ namespace Magento\Framework\Search\Dynamic;
use Magento\Framework\App\Config\ScopeConfigInterface;
use Magento\Framework\App\ScopeInterface;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class IntervalFactory
{
@@ -35,19 +35,19 @@ class IntervalFactory
private $interval;
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param ScopeConfigInterface $scopeConfig
* @param string $configPath
* @param string[] $intervals
* @param string $scope
*/
public function __construct(
- ObjectManager $objectManager,
+ ObjectManagerInterface $objectManager,
ScopeConfigInterface $scopeConfig,
$configPath,
$intervals,
diff --git a/lib/internal/Magento/Framework/Search/Request/Builder.php b/lib/internal/Magento/Framework/Search/Request/Builder.php
index edb5ed2d532716771a7158f0edac83764a0e5829..664f84474297bd73a44a8b0780fa862e402cda57 100644
--- a/lib/internal/Magento/Framework/Search/Request/Builder.php
+++ b/lib/internal/Magento/Framework/Search/Request/Builder.php
@@ -25,13 +25,13 @@
namespace Magento\Framework\Search\Request;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\Search\RequestInterface;
class Builder
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
@@ -60,12 +60,12 @@ class Builder
/**
* Request Builder constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param Config $config
* @param Binder $binder
* @param Cleaner $cleaner
*/
- public function __construct(ObjectManager $objectManager, Config $config, Binder $binder, Cleaner $cleaner)
+ public function __construct(ObjectManagerInterface $objectManager, Config $config, Binder $binder, Cleaner $cleaner)
{
$this->objectManager = $objectManager;
$this->config = $config;
diff --git a/lib/internal/Magento/Framework/Search/Request/Mapper.php b/lib/internal/Magento/Framework/Search/Request/Mapper.php
index 1fa47063b6c69f640e95909cc39c823a7b1b3e22..8211e7dfece50d091bfecfc97749f2bd417110be 100644
--- a/lib/internal/Magento/Framework/Search/Request/Mapper.php
+++ b/lib/internal/Magento/Framework/Search/Request/Mapper.php
@@ -54,7 +54,7 @@ class Mapper
private $aggregations;
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
@@ -64,7 +64,7 @@ class Mapper
private $rootQuery = null;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param array $queries
* @param string $rootQueryName
* @param array $aggregations
@@ -74,7 +74,7 @@ class Mapper
* @throws StateException
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
array $queries,
$rootQueryName,
array $aggregations = [],
diff --git a/lib/internal/Magento/Framework/Serialization/DataBuilderFactory.php b/lib/internal/Magento/Framework/Serialization/DataBuilderFactory.php
index 2ef905716aac1b817f8abc6fcce1a8b69fde1090..c702fb3fbf4c1e9e4c6fec1e04d6f2ca75f5533e 100644
--- a/lib/internal/Magento/Framework/Serialization/DataBuilderFactory.php
+++ b/lib/internal/Magento/Framework/Serialization/DataBuilderFactory.php
@@ -24,7 +24,7 @@
namespace Magento\Framework\Serialization;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Factory used to construct Data Builder based on interface name
@@ -32,14 +32,14 @@ use Magento\Framework\ObjectManager;
class DataBuilderFactory
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Session/Generic.php b/lib/internal/Magento/Framework/Session/Generic.php
index db8344c12ee3cbe520a416d928ec4217a1427b95..210179cc187c8ac763fac9411f508a7dff21c715 100644
--- a/lib/internal/Magento/Framework/Session/Generic.php
+++ b/lib/internal/Magento/Framework/Session/Generic.php
@@ -34,7 +34,7 @@ class Generic extends SessionManager
* @param SaveHandlerInterface $saveHandler
* @param ValidatorInterface $validator
* @param StorageInterface $storage
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
*/
public function __construct(
@@ -44,7 +44,7 @@ class Generic extends SessionManager
SaveHandlerInterface $saveHandler,
ValidatorInterface $validator,
StorageInterface $storage,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
) {
parent::__construct(
diff --git a/lib/internal/Magento/Framework/Session/SaveHandlerFactory.php b/lib/internal/Magento/Framework/Session/SaveHandlerFactory.php
index f1c787a2d3e7b7c340be0bd037a4204c8a27c267..70fb5fb9af40333ae431dc39739400abef442318 100644
--- a/lib/internal/Magento/Framework/Session/SaveHandlerFactory.php
+++ b/lib/internal/Magento/Framework/Session/SaveHandlerFactory.php
@@ -36,7 +36,7 @@ class SaveHandlerFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -50,10 +50,10 @@ class SaveHandlerFactory
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManger
+ * @param \Magento\Framework\ObjectManagerInterface $objectManger
* @param array $handlers
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManger, array $handlers = array())
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManger, array $handlers = array())
{
$this->objectManager = $objectManger;
if (!empty($handlers)) {
diff --git a/lib/internal/Magento/Framework/Session/SessionManager.php b/lib/internal/Magento/Framework/Session/SessionManager.php
index 9127258446acf1687bc5b231da803bbf8337a3e1..5f07b2b9f4944f3dbf096782deacdfb92fa035ed 100644
--- a/lib/internal/Magento/Framework/Session/SessionManager.php
+++ b/lib/internal/Magento/Framework/Session/SessionManager.php
@@ -95,7 +95,7 @@ class SessionManager implements SessionManagerInterface
/**
* Cookie Manager
*
- * @var \Magento\Framework\Stdlib\CookieManager
+ * @var \Magento\Framework\Stdlib\CookieManagerInterface
*/
protected $cookieManager;
@@ -113,7 +113,7 @@ class SessionManager implements SessionManagerInterface
* @param SaveHandlerInterface $saveHandler
* @param ValidatorInterface $validator
* @param StorageInterface $storage
- * @param \Magento\Framework\Stdlib\CookieManager $cookieManager
+ * @param \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager
* @param \Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
*/
public function __construct(
@@ -123,7 +123,7 @@ class SessionManager implements SessionManagerInterface
SaveHandlerInterface $saveHandler,
ValidatorInterface $validator,
StorageInterface $storage,
- \Magento\Framework\Stdlib\CookieManager $cookieManager,
+ \Magento\Framework\Stdlib\CookieManagerInterface $cookieManager,
\Magento\Framework\Stdlib\Cookie\CookieMetadataFactory $cookieMetadataFactory
) {
$this->request = $request;
diff --git a/lib/internal/Magento/Framework/Stdlib/Cookie/CookieMetadataFactory.php b/lib/internal/Magento/Framework/Stdlib/Cookie/CookieMetadataFactory.php
index 7b733c3cf1d9db95382cb4643e6eb0309efe9402..dd80bd1037c33b0b0869ac44ff90145e86b06d0e 100644
--- a/lib/internal/Magento/Framework/Stdlib/Cookie/CookieMetadataFactory.php
+++ b/lib/internal/Magento/Framework/Stdlib/Cookie/CookieMetadataFactory.php
@@ -24,7 +24,7 @@
namespace Magento\Framework\Stdlib\Cookie;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* CookieMetadataFactory is used to construct SensitiveCookieMetadata and PublicCookieMetadata objects.
@@ -32,14 +32,14 @@ use Magento\Framework\ObjectManager;
class CookieMetadataFactory
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Stdlib/Cookie/PhpCookieManager.php b/lib/internal/Magento/Framework/Stdlib/Cookie/PhpCookieManager.php
index 68d1e07ec4b472445e12820b562aa5eadc52a0f4..a69a14eff4791a7f0b5683a6933ff276539d5e05 100644
--- a/lib/internal/Magento/Framework/Stdlib/Cookie/PhpCookieManager.php
+++ b/lib/internal/Magento/Framework/Stdlib/Cookie/PhpCookieManager.php
@@ -25,7 +25,7 @@
namespace Magento\Framework\Stdlib\Cookie;
use Magento\Framework\Exception\InputException;
-use Magento\Framework\Stdlib\CookieManager as CookieManager;
+use Magento\Framework\Stdlib\CookieManagerInterface;
/**
* CookieManager helps manage the setting, retrieving and deleting of cookies.
@@ -34,7 +34,7 @@ use Magento\Framework\Stdlib\CookieManager as CookieManager;
* sensitive data so that extra protection can be added to the contents of the cookie as well as how the browser
* stores the cookie.
*/
-class PhpCookieManager implements CookieManager
+class PhpCookieManager implements CookieManagerInterface
{
/**#@+
* Constants for Cookie manager.
diff --git a/lib/internal/Magento/Framework/Stdlib/CookieManager.php b/lib/internal/Magento/Framework/Stdlib/CookieManagerInterface.php
similarity index 99%
rename from lib/internal/Magento/Framework/Stdlib/CookieManager.php
rename to lib/internal/Magento/Framework/Stdlib/CookieManagerInterface.php
index a54c34b3157c39a4ff3ba80bc4dcca16bb6347d4..0ba6c1616d5adbdd67e875e376b98117126d42e2 100644
--- a/lib/internal/Magento/Framework/Stdlib/CookieManager.php
+++ b/lib/internal/Magento/Framework/Stdlib/CookieManagerInterface.php
@@ -38,7 +38,7 @@ use Magento\Framework\Exception\InputException;
* this will allow extra protection to be added to the contents of the cookie as well sending directives to the browser
* about how the cookie should be stored and whether JavaScript can access the cookie.
*/
-interface CookieManager
+interface CookieManagerInterface
{
/**
* Set a value in a private cookie with the given $name $value pairing.
diff --git a/lib/internal/Magento/Framework/Stdlib/DateTime/DateFactory.php b/lib/internal/Magento/Framework/Stdlib/DateTime/DateFactory.php
index 83ea939988e9e7ab426f53257d7ab3bad73fc6fe..50bb38bc34f3aedb9bb55110325cc5576d4b5867 100644
--- a/lib/internal/Magento/Framework/Stdlib/DateTime/DateFactory.php
+++ b/lib/internal/Magento/Framework/Stdlib/DateTime/DateFactory.php
@@ -26,7 +26,7 @@ namespace Magento\Framework\Stdlib\DateTime;
class DateFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -36,11 +36,11 @@ class DateFactory
protected $_instanceName = null;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\Stdlib\DateTime\DateInterface'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/Translate/Inline/ParserFactory.php b/lib/internal/Magento/Framework/Translate/Inline/ParserFactory.php
index 1bcd98981c164bca1904bce88a3ce2045e2f0fa3..71453b998b41e3fb7ea4058887e854320f90458f 100644
--- a/lib/internal/Magento/Framework/Translate/Inline/ParserFactory.php
+++ b/lib/internal/Magento/Framework/Translate/Inline/ParserFactory.php
@@ -35,15 +35,15 @@ class ParserFactory
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Object constructor
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/Translate/Inline/Proxy.php b/lib/internal/Magento/Framework/Translate/Inline/Proxy.php
index 3051869886f10cb37c421b15a6fffa16b12c571b..4931f46896d7d9f309d7adbfc94d400db1fc66cf 100644
--- a/lib/internal/Magento/Framework/Translate/Inline/Proxy.php
+++ b/lib/internal/Magento/Framework/Translate/Inline/Proxy.php
@@ -32,7 +32,7 @@ class Proxy extends \Magento\Framework\Translate\Inline
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -58,12 +58,12 @@ class Proxy extends \Magento\Framework\Translate\Inline
protected $isShared;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
* @param bool $shared
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\Translate\Inline',
$shared = true
) {
diff --git a/lib/internal/Magento/Framework/Url/Decoder.php b/lib/internal/Magento/Framework/Url/Decoder.php
new file mode 100644
index 0000000000000000000000000000000000000000..abb2af7139583aab5cbd2dab4f790a5cade8604f
--- /dev/null
+++ b/lib/internal/Magento/Framework/Url/Decoder.php
@@ -0,0 +1,55 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Url;
+
+use Magento\Framework\UrlInterface;
+
+class Decoder implements DecoderInterface
+{
+ /**
+ * @var UrlInterface
+ */
+ protected $urlBuilder;
+
+ /**
+ * @param UrlInterface $urlBuilder
+ */
+ public function __construct(
+ UrlInterface $urlBuilder
+ ) {
+ $this->urlBuilder = $urlBuilder;
+ }
+
+ /**
+ * base64_decode() for URLs decoding
+ *
+ * @param string $url
+ * @return string
+ */
+ public function decode($url)
+ {
+ $url = base64_decode(strtr($url, '-_,', '+/='));
+ return $this->urlBuilder->sessionUrlVar($url);
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/Data/StockItemBuilder.php b/lib/internal/Magento/Framework/Url/DecoderInterface.php
similarity index 81%
rename from app/code/Magento/CatalogInventory/Service/V1/Data/StockItemBuilder.php
rename to lib/internal/Magento/Framework/Url/DecoderInterface.php
index 2e96602d3c431d7c52770694e1314657bee9077c..cd7d73ee18e329cf14723614042e5f790d4813f3 100644
--- a/app/code/Magento/CatalogInventory/Service/V1/Data/StockItemBuilder.php
+++ b/lib/internal/Magento/Framework/Url/DecoderInterface.php
@@ -21,13 +21,15 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\CatalogInventory\Service\V1\Data;
+namespace Magento\Framework\Url;
-use Magento\Framework\Api\ExtensibleObjectBuilder;
-
-/**
- * Stock item data builder
- */
-class StockItemBuilder extends ExtensibleObjectBuilder
+interface DecoderInterface
{
+ /**
+ * base64_decode() for URLs decoding
+ *
+ * @param string $url
+ * @return string
+ */
+ public function decode($url);
}
diff --git a/lib/internal/Magento/Framework/Url/Encoder.php b/lib/internal/Magento/Framework/Url/Encoder.php
new file mode 100644
index 0000000000000000000000000000000000000000..64e78160efbdca8717c3d8c1d021ac3a4147daae
--- /dev/null
+++ b/lib/internal/Magento/Framework/Url/Encoder.php
@@ -0,0 +1,38 @@
+<?php
+/**
+ * Magento
+ *
+ * NOTICE OF LICENSE
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available through the world-wide-web at this URL:
+ * http://opensource.org/licenses/osl-3.0.php
+ * If you did not receive a copy of the license and are unable to
+ * obtain it through the world-wide-web, please send an email
+ * to license@magentocommerce.com so we can send you a copy immediately.
+ *
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Magento to newer
+ * versions in the future. If you wish to customize Magento for your
+ * needs please refer to http://www.magentocommerce.com for more information.
+ *
+ * @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
+ */
+namespace Magento\Framework\Url;
+
+class Encoder implements EncoderInterface
+{
+ /**
+ * base64_encode() for URLs encoding
+ *
+ * @param string $url
+ * @return string
+ */
+ public function encode($url)
+ {
+ return strtr(base64_encode($url), '+/=', '-_,');
+ }
+}
diff --git a/app/code/Magento/CatalogInventory/Service/V1/Data/StockStatusBuilder.php b/lib/internal/Magento/Framework/Url/EncoderInterface.php
similarity index 81%
rename from app/code/Magento/CatalogInventory/Service/V1/Data/StockStatusBuilder.php
rename to lib/internal/Magento/Framework/Url/EncoderInterface.php
index 24e5fd4b65f0c603a33a291236e9d6d5aff57eb6..f010b95c698a44a4def20b30a9abc8401108d306 100644
--- a/app/code/Magento/CatalogInventory/Service/V1/Data/StockStatusBuilder.php
+++ b/lib/internal/Magento/Framework/Url/EncoderInterface.php
@@ -21,13 +21,15 @@
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
-namespace Magento\CatalogInventory\Service\V1\Data;
+namespace Magento\Framework\Url;
-use Magento\Framework\Api\ExtensibleObjectBuilder;
-
-/**
- * Stock status data builder
- */
-class StockStatusBuilder extends ExtensibleObjectBuilder
+interface EncoderInterface
{
+ /**
+ * base64_encode() for URLs encoding
+ *
+ * @param string $url
+ * @return string
+ */
+ public function encode($url);
}
diff --git a/lib/internal/Magento/Framework/Url/RouteParamsResolverFactory.php b/lib/internal/Magento/Framework/Url/RouteParamsResolverFactory.php
index 3404f3b65f2b651f57f9161e66da58892f48cc23..d4a4f8070268f7bb79662bce55c42f31d15b8c56 100644
--- a/lib/internal/Magento/Framework/Url/RouteParamsResolverFactory.php
+++ b/lib/internal/Magento/Framework/Url/RouteParamsResolverFactory.php
@@ -26,7 +26,7 @@ namespace Magento\Framework\Url;
class RouteParamsResolverFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -36,11 +36,11 @@ class RouteParamsResolverFactory
protected $_instanceName;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\Url\RouteParamsResolverInterface'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/UrlFactory.php b/lib/internal/Magento/Framework/UrlFactory.php
index 8ac9a501a3bc80ab8eb982e147f6611f49f91b42..5f51e7f538c02d1988cecb5eb30a2c28870dca38 100644
--- a/lib/internal/Magento/Framework/UrlFactory.php
+++ b/lib/internal/Magento/Framework/UrlFactory.php
@@ -26,7 +26,7 @@ namespace Magento\Framework;
class UrlFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -36,10 +36,10 @@ class UrlFactory
protected $_instanceName = null;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $instanceName = 'Magento\Framework\UrlInterface')
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\Framework\UrlInterface')
{
$this->_objectManager = $objectManager;
$this->_instanceName = $instanceName;
diff --git a/lib/internal/Magento/Framework/Validator/Config.php b/lib/internal/Magento/Framework/Validator/Config.php
index 6ab89bd50cea118ff970de4b1ae53aa8b319472f..28eb80bbdddb9250352bc0c9b2c518e86a46ed0f 100644
--- a/lib/internal/Magento/Framework/Validator/Config.php
+++ b/lib/internal/Magento/Framework/Validator/Config.php
@@ -253,7 +253,7 @@ class Config extends \Magento\Framework\Config\AbstractXml
* Read constraint configurator callback
*
* <constraint class="Constraint">
- * <callback class="Magento\Customer\Helper\Data" method="configureValidator"/>
+ * <callback class="Magento\Core\Helper\Data" method="configureValidator"/>
* </constraint>
*/
$callback = $this->_readCallback($children);
diff --git a/lib/internal/Magento/Framework/Validator/ConstraintFactory.php b/lib/internal/Magento/Framework/Validator/ConstraintFactory.php
index 1a5e891b2b6b4ba65b4326d462f3df87982a4984..5c3532c733a4e6e199663e6a8bc09a2a4c6b33c8 100644
--- a/lib/internal/Magento/Framework/Validator/ConstraintFactory.php
+++ b/lib/internal/Magento/Framework/Validator/ConstraintFactory.php
@@ -32,7 +32,7 @@ class ConstraintFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -46,10 +46,10 @@ class ConstraintFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, $instanceName = 'Magento\Framework\Validator\Constraint')
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, $instanceName = 'Magento\Framework\Validator\Constraint')
{
$this->_objectManager = $objectManager;
$this->_instanceName = $instanceName;
diff --git a/lib/internal/Magento/Framework/Validator/UniversalFactory.php b/lib/internal/Magento/Framework/Validator/UniversalFactory.php
index 7705fa16fdb51032754cbc027f367471a6b71d58..a0ffc3a8fd814618d0d8c5e82828b409f6808cbc 100644
--- a/lib/internal/Magento/Framework/Validator/UniversalFactory.php
+++ b/lib/internal/Magento/Framework/Validator/UniversalFactory.php
@@ -32,14 +32,14 @@ namespace Magento\Framework\Validator;
class UniversalFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/ValidatorFactory.php b/lib/internal/Magento/Framework/ValidatorFactory.php
index b32a8316a8841d55ec9039630b1e65d904d5ede4..339c6a1fb2d618362285fe9fd8667e6486851cd2 100644
--- a/lib/internal/Magento/Framework/ValidatorFactory.php
+++ b/lib/internal/Magento/Framework/ValidatorFactory.php
@@ -33,7 +33,7 @@ class ValidatorFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -47,11 +47,11 @@ class ValidatorFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = self::DEFAULT_INSTANCE_NAME
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/View/Asset/MergeService.php b/lib/internal/Magento/Framework/View/Asset/MergeService.php
index 8f5c233f09f0c23f0154c93bd0abdc65c3ccef7e..58aa4f35fc4c7b83453f334b062e3ae0b13986e3 100644
--- a/lib/internal/Magento/Framework/View/Asset/MergeService.php
+++ b/lib/internal/Magento/Framework/View/Asset/MergeService.php
@@ -33,7 +33,7 @@ class MergeService
/**
* Object Manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -61,13 +61,13 @@ class MergeService
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param ConfigInterface $config
* @param \Magento\Framework\Filesystem $filesystem
* @param \Magento\Framework\App\State $state
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
ConfigInterface $config,
\Magento\Framework\Filesystem $filesystem,
\Magento\Framework\App\State $state
diff --git a/lib/internal/Magento/Framework/View/Asset/MinifyService.php b/lib/internal/Magento/Framework/View/Asset/MinifyService.php
index b0fc58cdc6eba9e1ed2cb3e6a1a2883026501e50..efe9c3ca47d825da3d9e7db5499a7db29eda2fb2 100644
--- a/lib/internal/Magento/Framework/View/Asset/MinifyService.php
+++ b/lib/internal/Magento/Framework/View/Asset/MinifyService.php
@@ -38,7 +38,7 @@ class MinifyService
/**
* ObjectManager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -63,12 +63,12 @@ class MinifyService
* Constructor
*
* @param ConfigInterface $config
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $appMode
*/
public function __construct(
ConfigInterface $config,
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$appMode = \Magento\Framework\App\State::MODE_DEFAULT
) {
$this->config = $config;
diff --git a/lib/internal/Magento/Framework/View/Asset/PreProcessor/Pool.php b/lib/internal/Magento/Framework/View/Asset/PreProcessor/Pool.php
index f8e101e0ffea23b769a7418588835f5ec695b7ad..019ebe20a02533a798f6d0a5b9187b80555a7b58 100644
--- a/lib/internal/Magento/Framework/View/Asset/PreProcessor/Pool.php
+++ b/lib/internal/Magento/Framework/View/Asset/PreProcessor/Pool.php
@@ -24,7 +24,7 @@
namespace Magento\Framework\View\Asset\PreProcessor;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* A registry of asset preprocessors (not to confuse with the "Registry" pattern)
@@ -32,14 +32,14 @@ use Magento\Framework\ObjectManager;
class Pool
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
private $objectManager;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/Asset/PreProcessorFactory.php b/lib/internal/Magento/Framework/View/Asset/PreProcessorFactory.php
index e6ead32ed80b2ff68bc41cbac7ceffcf9dff5b4f..ac0e5d1b9efda7c62870e124ff1f315b89999f10 100644
--- a/lib/internal/Magento/Framework/View/Asset/PreProcessorFactory.php
+++ b/lib/internal/Magento/Framework/View/Asset/PreProcessorFactory.php
@@ -31,16 +31,16 @@ class PreProcessorFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* Object manager
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/Asset/PropertyGroupFactory.php b/lib/internal/Magento/Framework/View/Asset/PropertyGroupFactory.php
index cd3386cfbcfbb4a5d6466d57b6b9065fb4d2e178..906f8ae7b2b9c145d78c12292ec4861e142da544 100644
--- a/lib/internal/Magento/Framework/View/Asset/PropertyGroupFactory.php
+++ b/lib/internal/Magento/Framework/View/Asset/PropertyGroupFactory.php
@@ -31,16 +31,16 @@ class PropertyGroupFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/BlockPool.php b/lib/internal/Magento/Framework/View/BlockPool.php
index 836d6a6cd7bb249c46011176ff9fb56921300e4a..79d16b7cd9061e21c4c60a9bd825f63161b1c93b 100644
--- a/lib/internal/Magento/Framework/View/BlockPool.php
+++ b/lib/internal/Magento/Framework/View/BlockPool.php
@@ -26,7 +26,7 @@ namespace Magento\Framework\View;
use Magento\Framework\View\Layout;
use Magento\Framework\View\Element\BlockInterface;
use Magento\Framework\View\Element\BlockFactory;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Class BlockPool
diff --git a/lib/internal/Magento/Framework/View/Design/Theme/Customization/FileServiceFactory.php b/lib/internal/Magento/Framework/View/Design/Theme/Customization/FileServiceFactory.php
index 295a4f234eeb653508bddec2578065baffa7c180..4250ca5d1fc3fd6e2b8a3f1672fdd404a3065398 100644
--- a/lib/internal/Magento/Framework/View/Design/Theme/Customization/FileServiceFactory.php
+++ b/lib/internal/Magento/Framework/View/Design/Theme/Customization/FileServiceFactory.php
@@ -31,17 +31,17 @@ class FileServiceFactory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param ConfigInterface $config
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager, ConfigInterface $config)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager, ConfigInterface $config)
{
$this->_objectManager = $objectManager;
$this->_types = $config->getFileTypes();
diff --git a/lib/internal/Magento/Framework/View/Design/Theme/Domain/Factory.php b/lib/internal/Magento/Framework/View/Design/Theme/Domain/Factory.php
index 99d4f57e12a8084372b478cb54eb4460245213d5..054c3b87c28b12e08771afa8e353c26cee81d708 100644
--- a/lib/internal/Magento/Framework/View/Design/Theme/Domain/Factory.php
+++ b/lib/internal/Magento/Framework/View/Design/Theme/Domain/Factory.php
@@ -33,7 +33,7 @@ class Factory
/**
* Object manager
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -51,9 +51,9 @@ class Factory
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/Design/Theme/FileFactory.php b/lib/internal/Magento/Framework/View/Design/Theme/FileFactory.php
index 4190e31fe58908aca58124154981bf63174bce30..a88c6ab71616bb2e0b929e0e3e41924f298fd6ad 100644
--- a/lib/internal/Magento/Framework/View/Design/Theme/FileFactory.php
+++ b/lib/internal/Magento/Framework/View/Design/Theme/FileFactory.php
@@ -31,16 +31,16 @@ class FileFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
/**
* Object manager
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->_objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/Design/Theme/ImageFactory.php b/lib/internal/Magento/Framework/View/Design/Theme/ImageFactory.php
index 49bfdaf9c90d64ae6b8701a26dcf79c68c483ae8..d6e932425f0c1df180040d1382bb8b35cf833036 100644
--- a/lib/internal/Magento/Framework/View/Design/Theme/ImageFactory.php
+++ b/lib/internal/Magento/Framework/View/Design/Theme/ImageFactory.php
@@ -31,7 +31,7 @@ class ImageFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -45,11 +45,11 @@ class ImageFactory
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\View\Design\Theme\Image'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/View/Design/Theme/LabelFactory.php b/lib/internal/Magento/Framework/View/Design/Theme/LabelFactory.php
index 55849f4ad6ccdf7a75cf1db42da1548485d75cb2..8d455b8a262db577cefe4111e1f26c7c50f7916e 100644
--- a/lib/internal/Magento/Framework/View/Design/Theme/LabelFactory.php
+++ b/lib/internal/Magento/Framework/View/Design/Theme/LabelFactory.php
@@ -32,7 +32,7 @@ class LabelFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager = null;
@@ -46,11 +46,11 @@ class LabelFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\View\Design\Theme\Label'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/View/Design/ThemeFactory.php b/lib/internal/Magento/Framework/View/Design/ThemeFactory.php
index 167381837806dddc316cc1e49ac617f53074120d..4430e6135a4294187b7de914b01226e7c7db1df8 100644
--- a/lib/internal/Magento/Framework/View/Design/ThemeFactory.php
+++ b/lib/internal/Magento/Framework/View/Design/ThemeFactory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\View\Design;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Class ThemeFactory
@@ -35,16 +35,16 @@ class ThemeFactory
/**
* Object manager
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/Element/BlockFactory.php b/lib/internal/Magento/Framework/View/Element/BlockFactory.php
index 5851e755ee6b6cc829dc90282c055065ca1d5b69..8ffbdd436aba406f52cec111f326da28b084c315 100644
--- a/lib/internal/Magento/Framework/View/Element/BlockFactory.php
+++ b/lib/internal/Magento/Framework/View/Element/BlockFactory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\View\Element;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Class BlockFactory
@@ -33,16 +33,16 @@ class BlockFactory
/**
* Object manager
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/Element/UiComponent/ConfigFactory.php b/lib/internal/Magento/Framework/View/Element/UiComponent/ConfigFactory.php
index b738e9798b9d95747ec8cd5d30b94bfe72a5433e..d5b5238a81c7e7100a6e103d698b4517d6eda30f 100644
--- a/lib/internal/Magento/Framework/View/Element/UiComponent/ConfigFactory.php
+++ b/lib/internal/Magento/Framework/View/Element/UiComponent/ConfigFactory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\View\Element\UiComponent;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Class ConfigFactory
@@ -33,7 +33,7 @@ class ConfigFactory
/**
* Object Manager instance
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager = null;
@@ -47,11 +47,11 @@ class ConfigFactory
/**
* Factory constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- ObjectManager $objectManager,
+ ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\View\Element\UiComponent\ConfigInterface'
) {
$this->objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/View/Element/UiComponent/ConfigStorageInterface.php b/lib/internal/Magento/Framework/View/Element/UiComponent/ConfigStorageInterface.php
index 44e577a07c11c023c58249a3ef09c27b61db4c34..4a047ca9338aa81c6956e3138177d3d8fbe5f82d 100644
--- a/lib/internal/Magento/Framework/View/Element/UiComponent/ConfigStorageInterface.php
+++ b/lib/internal/Magento/Framework/View/Element/UiComponent/ConfigStorageInterface.php
@@ -23,7 +23,8 @@
*/
namespace Magento\Framework\View\Element\UiComponent;
-use Magento\Framework\Data\Collection as DataCollection;
+use Magento\Framework\Data\CollectionDataSourceInterface;
+use Magento\Framework\Api\CriteriaInterface;
/**
* Class ConfigurationStorageInterface
@@ -126,16 +127,16 @@ interface ConfigStorageInterface
* Set data collection
*
* @param string $key
- * @param DataCollection $dataCollection
+ * @param CollectionDataSourceInterface|CriteriaInterface $dataCollection
* @return void
*/
- public function addDataCollection($key, DataCollection $dataCollection);
+ public function addDataCollection($key, CollectionDataSourceInterface $dataCollection);
/**
* Get data collection
*
* @param string|null $key
- * @return DataCollection
+ * @return CollectionDataSourceInterface|CriteriaInterface
*/
public function getDataCollection($key = null);
@@ -143,10 +144,10 @@ interface ConfigStorageInterface
* Update data collection in storage
*
* @param string $key
- * @param DataCollection $dataCollection
+ * @param CollectionDataSourceInterface|CriteriaInterface $dataCollection
* @return mixed
*/
- public function updateDataCollection($key, DataCollection $dataCollection);
+ public function updateDataCollection($key, CollectionDataSourceInterface $dataCollection);
/**
* Add cloud data in storage
diff --git a/lib/internal/Magento/Framework/View/File/Factory.php b/lib/internal/Magento/Framework/View/File/Factory.php
index 75d8e4dc1a96ec42b9b119e93597770dd0be7ef6..803460a0ce998f8e35e8f4b7761b2a4d8b69ac8f 100644
--- a/lib/internal/Magento/Framework/View/File/Factory.php
+++ b/lib/internal/Magento/Framework/View/File/Factory.php
@@ -24,7 +24,7 @@
namespace Magento\Framework\View\File;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\View\Design\ThemeInterface;
/**
@@ -35,16 +35,16 @@ class Factory
/**
* Object manager
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/File/FileList/Factory.php b/lib/internal/Magento/Framework/View/File/FileList/Factory.php
index 1db4a4a67a65be00a6bc38c096588391675beb19..4fede8b22ba70b9df51fda0d05ccd9bce54c5dcd 100644
--- a/lib/internal/Magento/Framework/View/File/FileList/Factory.php
+++ b/lib/internal/Magento/Framework/View/File/FileList/Factory.php
@@ -24,7 +24,7 @@
namespace Magento\Framework\View\File\FileList;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Factory that produces view file list instances
@@ -39,16 +39,16 @@ class Factory
/**
* Object manager
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Decorator/Updater.php b/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Decorator/Updater.php
index 4b002feebd242fed96c1c9e928c9107e08dfa092..07b2f50b5e0de1dc2e6b2bd66a9412e79331f9e5 100644
--- a/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Decorator/Updater.php
+++ b/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Decorator/Updater.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\View\Layout\Argument\Interpreter\Decorator;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\Data\Argument\InterpreterInterface;
/**
@@ -32,7 +32,7 @@ use Magento\Framework\Data\Argument\InterpreterInterface;
class Updater implements InterpreterInterface
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
@@ -42,10 +42,10 @@ class Updater implements InterpreterInterface
private $subject;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param InterpreterInterface $subject
*/
- public function __construct(ObjectManager $objectManager, InterpreterInterface $subject)
+ public function __construct(ObjectManagerInterface $objectManager, InterpreterInterface $subject)
{
$this->objectManager = $objectManager;
$this->subject = $subject;
diff --git a/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/HelperMethod.php b/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/HelperMethod.php
index 7b9d0d4940ce74f876b28dc5e3a7052c99656c5b..bde1c001d52bddfac0bd1af5783eeacbf03bc8e3 100644
--- a/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/HelperMethod.php
+++ b/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/HelperMethod.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\View\Layout\Argument\Interpreter;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\Data\Argument\InterpreterInterface;
/**
@@ -32,7 +32,7 @@ use Magento\Framework\Data\Argument\InterpreterInterface;
class HelperMethod implements InterpreterInterface
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
@@ -42,10 +42,10 @@ class HelperMethod implements InterpreterInterface
private $paramsInterpreter;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param NamedParams $paramsInterpreter
*/
- public function __construct(ObjectManager $objectManager, NamedParams $paramsInterpreter)
+ public function __construct(ObjectManagerInterface $objectManager, NamedParams $paramsInterpreter)
{
$this->objectManager = $objectManager;
$this->paramsInterpreter = $paramsInterpreter;
diff --git a/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Object.php b/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Object.php
index cf2c904cae9f2ecded1ed4bf09acf8e7a7bb48b7..d1b62095741c26e6201afe89ff2002c65e12cc5e 100644
--- a/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Object.php
+++ b/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Object.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\View\Layout\Argument\Interpreter;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\Data\Argument\InterpreterInterface;
/**
@@ -32,7 +32,7 @@ use Magento\Framework\Data\Argument\InterpreterInterface;
class Object implements InterpreterInterface
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
@@ -42,10 +42,10 @@ class Object implements InterpreterInterface
private $expectedClass;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param string|null $expectedClass
*/
- public function __construct(ObjectManager $objectManager, $expectedClass = null)
+ public function __construct(ObjectManagerInterface $objectManager, $expectedClass = null)
{
$this->objectManager = $objectManager;
$this->expectedClass = $expectedClass;
diff --git a/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Options.php b/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Options.php
index 253f95e790251446289e6f96d743fb60b9e56124..35dea1161c08383be672bf48ffea4bd3fcb99cf6 100644
--- a/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Options.php
+++ b/lib/internal/Magento/Framework/View/Layout/Argument/Interpreter/Options.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\View\Layout\Argument\Interpreter;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\Data\Argument\InterpreterInterface;
/**
@@ -32,14 +32,14 @@ use Magento\Framework\Data\Argument\InterpreterInterface;
class Options implements InterpreterInterface
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/Layout/BuilderFactory.php b/lib/internal/Magento/Framework/View/Layout/BuilderFactory.php
index 1be7e95b0f188147cbbbfd44de0e764fac749a41..ecd398ba85c340167400671b506b0624435209a5 100644
--- a/lib/internal/Magento/Framework/View/Layout/BuilderFactory.php
+++ b/lib/internal/Magento/Framework/View/Layout/BuilderFactory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\View\Layout;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\View;
/**
@@ -49,18 +49,18 @@ class BuilderFactory
];
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param array $typeMap
*/
public function __construct(
- ObjectManager $objectManager,
+ ObjectManagerInterface $objectManager,
array $typeMap = []
) {
$this->objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/View/Layout/Generator/UiComponent.php b/lib/internal/Magento/Framework/View/Layout/Generator/UiComponent.php
index 5a2cfbcfafde78986ce58ec6bf8165670f9b34f5..292a1228ce3c6396d67a7cf2ed38c3b649c8c7fe 100644
--- a/lib/internal/Magento/Framework/View/Layout/Generator/UiComponent.php
+++ b/lib/internal/Magento/Framework/View/Layout/Generator/UiComponent.php
@@ -97,9 +97,7 @@ class UiComponent implements Layout\GeneratorInterface
$scheduledStructure->unsetElement($elementName);
}
}
- foreach ($blocks as $block) {
- $block->setLayout($layout);
- }
+
return $this;
}
diff --git a/lib/internal/Magento/Framework/View/Layout/ProcessorFactory.php b/lib/internal/Magento/Framework/View/Layout/ProcessorFactory.php
index cb2e10860da821efa75b33d7e34439ac52592559..e50eaf6c54aa727eab04a5f2e469b8f2e93ea508 100644
--- a/lib/internal/Magento/Framework/View/Layout/ProcessorFactory.php
+++ b/lib/internal/Magento/Framework/View/Layout/ProcessorFactory.php
@@ -31,7 +31,7 @@ class ProcessorFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -45,11 +45,11 @@ class ProcessorFactory
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\View\Layout\ProcessorInterface'
) {
$this->objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/View/Layout/Proxy.php b/lib/internal/Magento/Framework/View/Layout/Proxy.php
index 900277d7c04a28e89ef9c599be0b1bf7bdd45502..6041d67dbaa302edcb8c1c06943b83d282191052 100644
--- a/lib/internal/Magento/Framework/View/Layout/Proxy.php
+++ b/lib/internal/Magento/Framework/View/Layout/Proxy.php
@@ -33,7 +33,7 @@ class Proxy extends \Magento\Framework\View\Layout
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
@@ -59,12 +59,12 @@ class Proxy extends \Magento\Framework\View\Layout
protected $isShared;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
* @param bool $shared
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\View\Layout',
$shared = true
) {
diff --git a/lib/internal/Magento/Framework/View/Layout/ReaderFactory.php b/lib/internal/Magento/Framework/View/Layout/ReaderFactory.php
index 131a7e3cb20d4e9ce709c5cb117abb28f2aa6635..2c0fdd8ba3674a3521701cb0ebb0f879771d434c 100644
--- a/lib/internal/Magento/Framework/View/Layout/ReaderFactory.php
+++ b/lib/internal/Magento/Framework/View/Layout/ReaderFactory.php
@@ -29,14 +29,14 @@ namespace Magento\Framework\View\Layout;
class ReaderFactory
{
/**
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager;
/**
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
*/
- public function __construct(\Magento\Framework\ObjectManager $objectManager)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/LayoutFactory.php b/lib/internal/Magento/Framework/View/LayoutFactory.php
index d06d3fe114ccf241ec7c8cc64690073168cdeef5..0050deb5c211ac029ecfb917f55f32d1232bd95c 100644
--- a/lib/internal/Magento/Framework/View/LayoutFactory.php
+++ b/lib/internal/Magento/Framework/View/LayoutFactory.php
@@ -31,7 +31,7 @@ class LayoutFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_objectManager;
@@ -45,11 +45,11 @@ class LayoutFactory
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\View\LayoutInterface'
) {
$this->_objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/View/Page/Config/RendererFactory.php b/lib/internal/Magento/Framework/View/Page/Config/RendererFactory.php
index e705d842af0455e21b35acf75616807183312c06..2bb4430421197890ea6c5e1ea9de14310dd16b23 100644
--- a/lib/internal/Magento/Framework/View/Page/Config/RendererFactory.php
+++ b/lib/internal/Magento/Framework/View/Page/Config/RendererFactory.php
@@ -32,7 +32,7 @@ class RendererFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager = null;
@@ -46,11 +46,11 @@ class RendererFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\View\Page\Config\Renderer'
) {
$this->objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/View/Page/ConfigFactory.php b/lib/internal/Magento/Framework/View/Page/ConfigFactory.php
index 55e3bc0d3bab21454a3118fae1af145d49ccfc64..0da0cf628e0097565a18733c37b5681171b3f387 100644
--- a/lib/internal/Magento/Framework/View/Page/ConfigFactory.php
+++ b/lib/internal/Magento/Framework/View/Page/ConfigFactory.php
@@ -32,7 +32,7 @@ class ConfigFactory
/**
* Object Manager instance
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $objectManager = null;
@@ -46,11 +46,11 @@ class ConfigFactory
/**
* Factory constructor
*
- * @param \Magento\Framework\ObjectManager $objectManager
+ * @param \Magento\Framework\ObjectManagerInterface $objectManager
* @param string $instanceName
*/
public function __construct(
- \Magento\Framework\ObjectManager $objectManager,
+ \Magento\Framework\ObjectManagerInterface $objectManager,
$instanceName = 'Magento\Framework\View\Page\Config'
) {
$this->objectManager = $objectManager;
diff --git a/lib/internal/Magento/Framework/View/Render/RenderFactory.php b/lib/internal/Magento/Framework/View/Render/RenderFactory.php
index 67dcb382fc069ee784a21c58ee498ce9e11864e1..254d0d1a0ef9e4ca4350a897793f9ecdd11780bb 100644
--- a/lib/internal/Magento/Framework/View/Render/RenderFactory.php
+++ b/lib/internal/Magento/Framework/View/Render/RenderFactory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\View\Render;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
use Magento\Framework\View\RenderInterface;
/**
@@ -34,16 +34,16 @@ class RenderFactory
/**
* Object manager
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
*/
- public function __construct(ObjectManager $objectManager)
+ public function __construct(ObjectManagerInterface $objectManager)
{
$this->objectManager = $objectManager;
}
diff --git a/lib/internal/Magento/Framework/View/Result/LayoutFactory.php b/lib/internal/Magento/Framework/View/Result/LayoutFactory.php
index caac4ddefb61889b689ddb11e657ed9a72e5f9e4..86ffa8fcc3c118646cb592b60bb20172f22d8865 100644
--- a/lib/internal/Magento/Framework/View/Result/LayoutFactory.php
+++ b/lib/internal/Magento/Framework/View/Result/LayoutFactory.php
@@ -24,12 +24,12 @@
namespace Magento\Framework\View\Result;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
class LayoutFactory
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
@@ -39,11 +39,13 @@ class LayoutFactory
protected $instanceName;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param string $instanceName
*/
- public function __construct(ObjectManager $objectManager, $instanceName = 'Magento\Framework\View\Result\Layout')
- {
+ public function __construct(
+ ObjectManagerInterface $objectManager,
+ $instanceName = 'Magento\Framework\View\Result\Layout'
+ ) {
$this->objectManager = $objectManager;
$this->instanceName = $instanceName;
}
diff --git a/lib/internal/Magento/Framework/View/Result/PageFactory.php b/lib/internal/Magento/Framework/View/Result/PageFactory.php
index d66590d1543ebe517cf76d4b395be592f0a15e45..0c4956e591cb0cab918d9dff56f1b2df3658b13e 100644
--- a/lib/internal/Magento/Framework/View/Result/PageFactory.php
+++ b/lib/internal/Magento/Framework/View/Result/PageFactory.php
@@ -24,7 +24,7 @@
namespace Magento\Framework\View\Result;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* A factory that knows how to create a "page" result
@@ -34,7 +34,7 @@ use Magento\Framework\ObjectManager;
class PageFactory
{
/**
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
private $objectManager;
@@ -44,11 +44,13 @@ class PageFactory
protected $instanceName;
/**
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param string $instanceName
*/
- public function __construct(ObjectManager $objectManager, $instanceName = 'Magento\Framework\View\Result\Page')
- {
+ public function __construct(
+ ObjectManagerInterface $objectManager,
+ $instanceName = 'Magento\Framework\View\Result\Page'
+ ) {
$this->objectManager = $objectManager;
$this->instanceName = $instanceName;
}
diff --git a/lib/internal/Magento/Framework/View/TemplateEngine/Php.php b/lib/internal/Magento/Framework/View/TemplateEngine/Php.php
index 6415307e18cfe022b590904d0a60e974f933b3b1..9d74b7b09c9544cb2f79e1076cb60503661b0a78 100644
--- a/lib/internal/Magento/Framework/View/TemplateEngine/Php.php
+++ b/lib/internal/Magento/Framework/View/TemplateEngine/Php.php
@@ -41,16 +41,16 @@ class Php implements TemplateEngineInterface
/**
* Helper factory
*
- * @var \Magento\Framework\ObjectManager
+ * @var \Magento\Framework\ObjectManagerInterface
*/
protected $_helperFactory;
/**
* Constructor
*
- * @param \Magento\Framework\ObjectManager $helperFactory
+ * @param \Magento\Framework\ObjectManagerInterface $helperFactory
*/
- public function __construct(\Magento\Framework\ObjectManager $helperFactory)
+ public function __construct(\Magento\Framework\ObjectManagerInterface $helperFactory)
{
$this->_helperFactory = $helperFactory;
}
diff --git a/lib/internal/Magento/Framework/View/TemplateEngineFactory.php b/lib/internal/Magento/Framework/View/TemplateEngineFactory.php
index e5bde0a6d8bd9521c738b7c171b4a8b89ebcf62c..5809cb03b7a1829e139f8efaf8e5277b67f6e6c8 100644
--- a/lib/internal/Magento/Framework/View/TemplateEngineFactory.php
+++ b/lib/internal/Magento/Framework/View/TemplateEngineFactory.php
@@ -23,7 +23,7 @@
*/
namespace Magento\Framework\View;
-use Magento\Framework\ObjectManager;
+use Magento\Framework\ObjectManagerInterface;
/**
* Factory class for Template Engine
@@ -33,7 +33,7 @@ class TemplateEngineFactory
/**
* Object manager
*
- * @var ObjectManager
+ * @var ObjectManagerInterface
*/
protected $objectManager;
@@ -47,10 +47,10 @@ class TemplateEngineFactory
/**
* Constructor
*
- * @param ObjectManager $objectManager
+ * @param ObjectManagerInterface $objectManager
* @param array $engines Format: array('<name>' => 'TemplateEngine\Class', ...)
*/
- public function __construct(ObjectManager $objectManager, array $engines)
+ public function __construct(ObjectManagerInterface $objectManager, array $engines)
{
$this->objectManager = $objectManager;
$this->engines = $engines;
diff --git a/lib/internal/Magento/Framework/composer.json b/lib/internal/Magento/Framework/composer.json
index 493b906ecf30c4f4a10bdcd79baa1dc4d44dcf28..58ec006ae9a52abd2d3beafd95aa8414a7507086 100644
--- a/lib/internal/Magento/Framework/composer.json
+++ b/lib/internal/Magento/Framework/composer.json
@@ -2,7 +2,7 @@
"name": "magento/framework",
"description": "N/A",
"type": "magento2-library",
- "version": "0.1.0-alpha104",
+ "version": "0.1.0-alpha105",
"require": {
"php": "~5.4.11|~5.5.0",
"ext-spl": "*",