diff --git a/app/code/Magento/Catalog/Model/CategoryLinkManagement.php b/app/code/Magento/Catalog/Model/CategoryLinkManagement.php index f0405be462161bcdddc4a7ee86fe5ac1de96f641..4ff351dc3d735b79ad3ee2adf3d9275ceb54c0c3 100644 --- a/app/code/Magento/Catalog/Model/CategoryLinkManagement.php +++ b/app/code/Magento/Catalog/Model/CategoryLinkManagement.php @@ -45,7 +45,7 @@ class CategoryLinkManagement implements \Magento\Catalog\Api\CategoryLinkManagem $links = []; /** @var \Magento\Catalog\Model\Product $product */ - foreach ($products->getItems() as $productId => $product) { + foreach ($products->getItems() as $product) { /** @var \Magento\Catalog\Api\Data\CategoryProductLinkInterface $link */ $link = $this->productLinkFactory->create(); $link->setSku($product->getSku()) diff --git a/app/code/Magento/Catalog/Test/Unit/Model/Config/Source/Product/Options/TypeTest.php b/app/code/Magento/Catalog/Test/Unit/Model/Config/Source/Product/Options/TypeTest.php index aa686d39ce8d9e1bcc08a00a1bcc6ab1bbb997c7..3b3adabdfbc2b9009ae6a54f6476084f7e3a806f 100644 --- a/app/code/Magento/Catalog/Test/Unit/Model/Config/Source/Product/Options/TypeTest.php +++ b/app/code/Magento/Catalog/Test/Unit/Model/Config/Source/Product/Options/TypeTest.php @@ -51,7 +51,7 @@ class TypeTest extends \PHPUnit_Framework_TestCase ]; $expect = [ ['value' => '', 'label' => __('-- Please select --')], - ['label' => 'optionLabel', 'value' => [['label' => 'typeLabel', 'value' => 'typeName']]], + ['label' => 'optionLabel', 'optgroup-name' => 'optionLabel', 'value' => [['label' => 'typeLabel', 'value' => 'typeName']]], ]; $this->productOptionConfig->expects($this->any())->method('getAll')->will($this->returnValue($allOptions)); diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit.phtml index d21c1ee5ad82b2e9bae745e2cf2fa9d1c3cdb996..30048cce246460ab521b5d608865acea320ea488 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit.phtml @@ -21,7 +21,7 @@ </button> <ul class="dropdown-menu"> <li><input type="text" id="product-template-suggest" class="search" - placeholder="<?php echo __('start typing to search template'); ?>"/></li> + placeholder="<?php /* @noEscape */ echo __('start typing to search template'); ?>"/></li> </ul> </div> </div> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/attribute/search.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/attribute/search.phtml index 4536143416ccef7303da63b7537726af37ff402b..8d2cca19f20cae71303e2da1d50f12569dfd41fe 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/attribute/search.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/attribute/search.phtml @@ -17,7 +17,7 @@ <input data-role="product-attribute-search" data-group="<?php echo $block->escapeHtml($block->getGroupCode()); ?>" class="search" type="text" - placeholder="<?php echo __('start typing to search attribute'); ?>" /> + placeholder="<?php /* @noEscape */ echo __('start typing to search attribute'); ?>" /> </div> </div> diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Model/Product/Option/Type/File/ValidatorFileTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Model/Product/Option/Type/File/ValidatorFileTest.php index a22645bf6b7342bda2fa10e780a6c76a93713de7..b005c52813a7b987df53f64d5083c8a43f1434d9 100644 --- a/dev/tests/integration/testsuite/Magento/Catalog/Model/Product/Option/Type/File/ValidatorFileTest.php +++ b/dev/tests/integration/testsuite/Magento/Catalog/Model/Product/Option/Type/File/ValidatorFileTest.php @@ -16,7 +16,7 @@ class ValidatorFileTest extends \PHPUnit_Framework_TestCase protected $model; /** - * @var \Magento\Framework\ObjectManager + * @var \Magento\Framework\ObjectManagerInterface */ protected $objectManager; diff --git a/lib/internal/Magento/Framework/View/Element/Html/Select.php b/lib/internal/Magento/Framework/View/Element/Html/Select.php index 1bdbd099cc7cdd7072391b5c388130d14921bd16..884c11fe91950eca05b450eb1a8ea6b12114a23a 100644 --- a/lib/internal/Magento/Framework/View/Element/Html/Select.php +++ b/lib/internal/Magento/Framework/View/Element/Html/Select.php @@ -125,6 +125,7 @@ class Select extends \Magento\Framework\View\Element\AbstractBlock * @return string * * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _toHtml() { diff --git a/lib/internal/Magento/Framework/View/Test/Unit/Element/Html/SelectTest.php b/lib/internal/Magento/Framework/View/Test/Unit/Element/Html/SelectTest.php index d3660f32178ac024283b682bc5d93f93f00a5e39..3321d1eeaf8b6d1b1c1136faceaf08239c8413db 100644 --- a/lib/internal/Magento/Framework/View/Test/Unit/Element/Html/SelectTest.php +++ b/lib/internal/Magento/Framework/View/Test/Unit/Element/Html/SelectTest.php @@ -127,7 +127,7 @@ class SelectTest extends \PHPUnit_Framework_TestCase . '<option value="testValue" paramKey="paramValue" >testLabel</option>' . '<option value="selectedValue" selected="selected" paramKey="paramValue" ' . ' paramKey2="paramValue2" >selectedLabel</option>' - . '<optgroup label="groupLabel">' + . '<optgroup label="groupLabel" data-optgroup-name="groupLabel">' . '<option value="groupElementValue" >GroupElementLabel</option>' . '<option value="selectedGroupElementValue" selected="selected" >SelectedGroupElementLabel</option>' . '</optgroup>'