diff --git a/app/code/Magento/AdminNotification/Block/Grid/Renderer/Actions.php b/app/code/Magento/AdminNotification/Block/Grid/Renderer/Actions.php index 06eaf466068f04d004f52629d611f9a0c537f327..d53da043e61ad9bb1c2f9f2f353da7fad9aad2c2 100644 --- a/app/code/Magento/AdminNotification/Block/Grid/Renderer/Actions.php +++ b/app/code/Magento/AdminNotification/Block/Grid/Renderer/Actions.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\AdminNotification\Block\Grid\Renderer; class Actions extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer diff --git a/app/code/Magento/AdminNotification/Block/ToolbarEntry.php b/app/code/Magento/AdminNotification/Block/ToolbarEntry.php index a505245c4e9bb01819212b47c7700923de9e599d..0f301a162280b8de18da5568a042b349a3e12749 100644 --- a/app/code/Magento/AdminNotification/Block/ToolbarEntry.php +++ b/app/code/Magento/AdminNotification/Block/ToolbarEntry.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\AdminNotification\Block; /** diff --git a/app/code/Magento/AdminNotification/Model/Observer.php b/app/code/Magento/AdminNotification/Model/Observer.php index e00218dd2dc26c2c3bfe003b9011d62c1a33991c..d25d89503b66c7009106c24dba7cfc03392e75ad 100644 --- a/app/code/Magento/AdminNotification/Model/Observer.php +++ b/app/code/Magento/AdminNotification/Model/Observer.php @@ -39,6 +39,7 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function preDispatch(\Magento\Framework\Event\Observer $observer) { diff --git a/app/code/Magento/AdminNotification/Model/Resource/Grid/Collection.php b/app/code/Magento/AdminNotification/Model/Resource/Grid/Collection.php index 85a46440ef05f7320dabd91622cfbe47f85c3113..b8b70ad479bbcf2f26ac52096ae192942d23caf9 100644 --- a/app/code/Magento/AdminNotification/Model/Resource/Grid/Collection.php +++ b/app/code/Magento/AdminNotification/Model/Resource/Grid/Collection.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * AdminNotification Inbox model * diff --git a/app/code/Magento/AdminNotification/Model/Resource/Inbox.php b/app/code/Magento/AdminNotification/Model/Resource/Inbox.php index 6134ef9b9d1bc57f9acd700f55443f7f34074b6c..5799cb9211b5f321d85151c2da8947e668fb0aa9 100644 --- a/app/code/Magento/AdminNotification/Model/Resource/Inbox.php +++ b/app/code/Magento/AdminNotification/Model/Resource/Inbox.php @@ -58,6 +58,7 @@ class Inbox extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param \Magento\AdminNotification\Model\Inbox $object * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getNoticeStatus(\Magento\AdminNotification\Model\Inbox $object) { @@ -87,6 +88,7 @@ class Inbox extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param \Magento\AdminNotification\Model\Inbox $object * @param array $data * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function parse(\Magento\AdminNotification\Model\Inbox $object, array $data) { diff --git a/app/code/Magento/AdminNotification/Model/System/Message/Baseurl.php b/app/code/Magento/AdminNotification/Model/System/Message/Baseurl.php index ef627597c4f0e0d9debac32ec4edaf1505250d62..ddab16bc6d71bd8986b1855f329a08945f1eefa2 100644 --- a/app/code/Magento/AdminNotification/Model/System/Message/Baseurl.php +++ b/app/code/Magento/AdminNotification/Model/System/Message/Baseurl.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\AdminNotification\Model\System\Message; class Baseurl implements \Magento\Framework\Notification\MessageInterface diff --git a/app/code/Magento/AdminNotification/Model/System/Message/Media/Synchronization/Error.php b/app/code/Magento/AdminNotification/Model/System/Message/Media/Synchronization/Error.php index 8e20bd027d16cdd938648baf956e7c1832d5b3ca..f14413eb82833cc24cf9b5c659f10a8bde98b0c1 100644 --- a/app/code/Magento/AdminNotification/Model/System/Message/Media/Synchronization/Error.php +++ b/app/code/Magento/AdminNotification/Model/System/Message/Media/Synchronization/Error.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\AdminNotification\Model\System\Message\Media\Synchronization; class Error extends \Magento\AdminNotification\Model\System\Message\Media\AbstractSynchronization diff --git a/app/code/Magento/AdminNotification/Model/System/Message/Security.php b/app/code/Magento/AdminNotification/Model/System/Message/Security.php index fc274d250d9c1dbc83c7b5c59876f22d1187ebdf..72465b8fdfc3f1c57137881ce5bd921a3a63a571 100644 --- a/app/code/Magento/AdminNotification/Model/System/Message/Security.php +++ b/app/code/Magento/AdminNotification/Model/System/Message/Security.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\AdminNotification\Model\System\Message; class Security implements \Magento\Framework\Notification\MessageInterface diff --git a/app/code/Magento/AdminNotification/view/adminhtml/templates/notification/window.phtml b/app/code/Magento/AdminNotification/view/adminhtml/templates/notification/window.phtml index 5fa52b0a6f91b50c4d7782af848fd229c961c9f4..dc2481ae7b569c6b8a3de42901fc2128eea81f9f 100644 --- a/app/code/Magento/AdminNotification/view/adminhtml/templates/notification/window.phtml +++ b/app/code/Magento/AdminNotification/view/adminhtml/templates/notification/window.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/AdminNotification/view/adminhtml/templates/system/messages.phtml b/app/code/Magento/AdminNotification/view/adminhtml/templates/system/messages.phtml index 35c967093cf3aece4615bd49396c1371d07ea4d5..6932b44b60abc92ba8fc4391d95c0b7a3d6908ff 100644 --- a/app/code/Magento/AdminNotification/view/adminhtml/templates/system/messages.phtml +++ b/app/code/Magento/AdminNotification/view/adminhtml/templates/system/messages.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\AdminNotification\Block\System\Messages */ ?> diff --git a/app/code/Magento/AdminNotification/view/adminhtml/templates/system/messages/popup.phtml b/app/code/Magento/AdminNotification/view/adminhtml/templates/system/messages/popup.phtml index 6f11f46ea8d007ee38dfdc849d987969a34e7213..df849f7ddef563aa6713c19ed5e2f134d3aa101d 100644 --- a/app/code/Magento/AdminNotification/view/adminhtml/templates/system/messages/popup.phtml +++ b/app/code/Magento/AdminNotification/view/adminhtml/templates/system/messages/popup.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\AdminNotification\Block\System\Messages\UnreadMessagePopup */ ?> <div id="system_messages_list" title="<?php echo $this->escapeHtml($this->getPopupTitle()); ?>"> diff --git a/app/code/Magento/AdminNotification/view/adminhtml/templates/toolbar_entry.phtml b/app/code/Magento/AdminNotification/view/adminhtml/templates/toolbar_entry.phtml index fe314086d2968c233670805f0aa7a603c733e836..9c0fdf546b19a6bfc08058764ec2e118f71635b8 100644 --- a/app/code/Magento/AdminNotification/view/adminhtml/templates/toolbar_entry.phtml +++ b/app/code/Magento/AdminNotification/view/adminhtml/templates/toolbar_entry.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\AdminNotification\Block\ToolbarEntry */ ?> <?php $notificationCount = $this->getUnreadNotificationCount(); ?> diff --git a/app/code/Magento/Authorization/Model/Acl/AclRetriever.php b/app/code/Magento/Authorization/Model/Acl/AclRetriever.php index d572f94904d6a23823544f06573ebfc6218a8725..77fd1bb99186da3a4eea59a293c4a310f36dbac6 100644 --- a/app/code/Magento/Authorization/Model/Acl/AclRetriever.php +++ b/app/code/Magento/Authorization/Model/Acl/AclRetriever.php @@ -17,6 +17,7 @@ use Psr\Log\LoggerInterface as Logger; /** * Permission tree retriever + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class AclRetriever { diff --git a/app/code/Magento/Authorization/Model/Resource/Rules.php b/app/code/Magento/Authorization/Model/Resource/Rules.php index 79ecf007b8fd61153b7a1927f8d628b173b3df5a..5e08f0a6cac10ed4631f330a453b778d4bd4653d 100644 --- a/app/code/Magento/Authorization/Model/Resource/Rules.php +++ b/app/code/Magento/Authorization/Model/Resource/Rules.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Authorization\Model\Resource; /** diff --git a/app/code/Magento/Backend/App/Action.php b/app/code/Magento/Backend/App/Action.php index f2d04fba8bf37f4407fd513f054f093411933cb3..784ea97a090f74e93b5ec238e4626c1edb650165 100644 --- a/app/code/Magento/Backend/App/Action.php +++ b/app/code/Magento/Backend/App/Action.php @@ -9,6 +9,9 @@ */ namespace Magento\Backend\App; +/** + * @SuppressWarnings(PHPMD.NumberOfChildren) + */ class Action extends \Magento\Backend\App\AbstractAction { } diff --git a/app/code/Magento/Backend/App/Action/Context.php b/app/code/Magento/Backend/App/Action/Context.php index 51408474cdc0f8d481d9781852fab1092941343a..ceae4ef4bf04e4d98c9545d8fb72cd479a200875 100644 --- a/app/code/Magento/Backend/App/Action/Context.php +++ b/app/code/Magento/Backend/App/Action/Context.php @@ -7,6 +7,7 @@ namespace Magento\Backend\App\Action; /** * Backend Controller context + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Context extends \Magento\Framework\App\Action\Context { @@ -68,6 +69,7 @@ class Context extends \Magento\Framework\App\Action\Context * @param \Magento\Core\App\Action\FormKeyValidator $formKeyValidator * @param \Magento\Framework\Locale\ResolverInterface $localeResolver * @param bool $canUseBaseUrl + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\RequestInterface $request, @@ -136,6 +138,7 @@ class Context extends \Magento\Framework\App\Action\Context /** * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCanUseBaseUrl() { diff --git a/app/code/Magento/Backend/App/Config.php b/app/code/Magento/Backend/App/Config.php index d6344c1bf758689d581eec00fdf367aa309b254e..d8eaa7af14254bd16dd3c8f7ae3cc9a549e75cde 100644 --- a/app/code/Magento/Backend/App/Config.php +++ b/app/code/Magento/Backend/App/Config.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\App; /** diff --git a/app/code/Magento/Backend/App/DefaultPath.php b/app/code/Magento/Backend/App/DefaultPath.php index 91c1a1ab8d546a9ec2299ca562222f5d9842a32b..3298770157922e665207371779367225bbc018c6 100644 --- a/app/code/Magento/Backend/App/DefaultPath.php +++ b/app/code/Magento/Backend/App/DefaultPath.php @@ -16,6 +16,7 @@ class DefaultPath implements \Magento\Framework\App\DefaultPathInterface /** * @param \Magento\Backend\App\ConfigInterface $config + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function __construct(\Magento\Backend\App\ConfigInterface $config) { diff --git a/app/code/Magento/Backend/Block/Dashboard.php b/app/code/Magento/Backend/Block/Dashboard.php index 36e268e5492423fc205bb971565f650814e674f6..6433c0a0514b7e127299077aa81a14f6ca8aa1af 100644 --- a/app/code/Magento/Backend/Block/Dashboard.php +++ b/app/code/Magento/Backend/Block/Dashboard.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block; class Dashboard extends \Magento\Backend\Block\Template diff --git a/app/code/Magento/Backend/Block/Dashboard/AbstractDashboard.php b/app/code/Magento/Backend/Block/Dashboard/AbstractDashboard.php index 88b134a5d227c8a839b0b12997a2115f46088f94..d4572d0e3c0cf9dd82154e4c7bfbc873d443bdf8 100644 --- a/app/code/Magento/Backend/Block/Dashboard/AbstractDashboard.php +++ b/app/code/Magento/Backend/Block/Dashboard/AbstractDashboard.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Dashboard; /** diff --git a/app/code/Magento/Backend/Block/Dashboard/Graph.php b/app/code/Magento/Backend/Block/Dashboard/Graph.php index a005066c96a3c0cac22dbbe7737776b0053b64d6..91c4d619072bac7d99c3e452ff28da690468faf0 100644 --- a/app/code/Magento/Backend/Block/Dashboard/Graph.php +++ b/app/code/Magento/Backend/Block/Dashboard/Graph.php @@ -186,6 +186,10 @@ class Graph extends \Magento\Backend\Block\Dashboard\AbstractDashboard * * @param bool $directUrl * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getChartUrl($directUrl = true) { diff --git a/app/code/Magento/Backend/Block/Dashboard/Orders/Grid.php b/app/code/Magento/Backend/Block/Dashboard/Orders/Grid.php index 969f69109639eaba652f13c021c4d6602e96acf4..8ecf07022340e93948602f9ad50c03f53b27ea72 100644 --- a/app/code/Magento/Backend/Block/Dashboard/Orders/Grid.php +++ b/app/code/Magento/Backend/Block/Dashboard/Orders/Grid.php @@ -9,6 +9,7 @@ namespace Magento\Backend\Block\Dashboard\Orders; * Adminhtml dashboard recent orders grid * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Backend\Block\Dashboard\Grid { diff --git a/app/code/Magento/Backend/Block/Dashboard/Tab/Customers/Most.php b/app/code/Magento/Backend/Block/Dashboard/Tab/Customers/Most.php index 6ab4dd301d8b87aab4e8fcd379a0361beab9d146..69a835e1ca043dd48a3b5d2110b38316e4d72767 100644 --- a/app/code/Magento/Backend/Block/Dashboard/Tab/Customers/Most.php +++ b/app/code/Magento/Backend/Block/Dashboard/Tab/Customers/Most.php @@ -9,6 +9,7 @@ namespace Magento\Backend\Block\Dashboard\Tab\Customers; * Adminhtml dashboard most active buyers * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Most extends \Magento\Backend\Block\Dashboard\Grid { diff --git a/app/code/Magento/Backend/Block/Dashboard/Tab/Customers/Newest.php b/app/code/Magento/Backend/Block/Dashboard/Tab/Customers/Newest.php index 6fa8e88aca1bd184ed516a6100d02a5daf87605d..ce7b2ac229701b1698b6c22b6d0fc449965e1a8c 100644 --- a/app/code/Magento/Backend/Block/Dashboard/Tab/Customers/Newest.php +++ b/app/code/Magento/Backend/Block/Dashboard/Tab/Customers/Newest.php @@ -9,6 +9,7 @@ namespace Magento\Backend\Block\Dashboard\Tab\Customers; * Adminhtml dashboard most recent customers grid * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Newest extends \Magento\Backend\Block\Dashboard\Grid { diff --git a/app/code/Magento/Backend/Block/Dashboard/Tab/Products/Ordered.php b/app/code/Magento/Backend/Block/Dashboard/Tab/Products/Ordered.php index 756f0574f535725d6e3feceaf2eaff520258308b..a211d5d26b87da0c468fa988facc4cc45c75cbf3 100644 --- a/app/code/Magento/Backend/Block/Dashboard/Tab/Products/Ordered.php +++ b/app/code/Magento/Backend/Block/Dashboard/Tab/Products/Ordered.php @@ -9,6 +9,7 @@ namespace Magento\Backend\Block\Dashboard\Tab\Products; * Adminhtml dashboard most ordered products grid * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Ordered extends \Magento\Backend\Block\Dashboard\Grid { diff --git a/app/code/Magento/Backend/Block/Dashboard/Tab/Products/Viewed.php b/app/code/Magento/Backend/Block/Dashboard/Tab/Products/Viewed.php index 33c91166768959d9131fb2f139d3d72922ba44e2..42c7cbb9115f99b8da761f0f1fb2d4fa94ea2737 100644 --- a/app/code/Magento/Backend/Block/Dashboard/Tab/Products/Viewed.php +++ b/app/code/Magento/Backend/Block/Dashboard/Tab/Products/Viewed.php @@ -9,6 +9,7 @@ namespace Magento\Backend\Block\Dashboard\Tab\Products; * Adminhtml dashboard most viewed products grid * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Viewed extends \Magento\Backend\Block\Dashboard\Grid { diff --git a/app/code/Magento/Backend/Block/Menu.php b/app/code/Magento/Backend/Block/Menu.php index c6d269e464131319be0187389969d87e22a5a0b9..83f63bf04e03ecbc4b15a152c36ade4e6d7783bb 100644 --- a/app/code/Magento/Backend/Block/Menu.php +++ b/app/code/Magento/Backend/Block/Menu.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block; /** diff --git a/app/code/Magento/Backend/Block/Page/Header.php b/app/code/Magento/Backend/Block/Page/Header.php index 72b7397a75c9bce2a0e2d84837bb561f2e26376a..f4b8eb0b23ed3660b45255b366c75c2771afb73d 100644 --- a/app/code/Magento/Backend/Block/Page/Header.php +++ b/app/code/Magento/Backend/Block/Page/Header.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Page; /** diff --git a/app/code/Magento/Backend/Block/Page/Notices.php b/app/code/Magento/Backend/Block/Page/Notices.php index 4096807e8017ed1182a77a4964cd9662a28b4312..231d51c9919ddb093d476d93f90d54bcd8268294 100644 --- a/app/code/Magento/Backend/Block/Page/Notices.php +++ b/app/code/Magento/Backend/Block/Page/Notices.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Adminhtml header notices block * diff --git a/app/code/Magento/Backend/Block/Page/System/Config/Robots/Reset.php b/app/code/Magento/Backend/Block/Page/System/Config/Robots/Reset.php index efe6e9c50acc37e60446569a053da137b72a8d1e..a02603a372e860b76e2038fbaaa7c1ff85f2953a 100644 --- a/app/code/Magento/Backend/Block/Page/System/Config/Robots/Reset.php +++ b/app/code/Magento/Backend/Block/Page/System/Config/Robots/Reset.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Page\System\Config\Robots; /** diff --git a/app/code/Magento/Backend/Block/Store/Switcher/Form/Renderer/Fieldset.php b/app/code/Magento/Backend/Block/Store/Switcher/Form/Renderer/Fieldset.php index fef4b45c6c0ca9880b5a0b10da93af21a77e7b1e..dc4478cca4f6a9fe714453fb2fef8d121c367333 100644 --- a/app/code/Magento/Backend/Block/Store/Switcher/Form/Renderer/Fieldset.php +++ b/app/code/Magento/Backend/Block/Store/Switcher/Form/Renderer/Fieldset.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Store\Switcher\Form\Renderer; /** diff --git a/app/code/Magento/Backend/Block/System/Config/Form/Field.php b/app/code/Magento/Backend/Block/System/Config/Form/Field.php index cdb08a29c2c2829b716d6c428db2815d4587af40..39ea89b31ca6cacba917185784643949ae390038 100644 --- a/app/code/Magento/Backend/Block/System/Config/Form/Field.php +++ b/app/code/Magento/Backend/Block/System/Config/Form/Field.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Abstract config form element renderer * @@ -14,6 +16,7 @@ namespace Magento\Backend\Block\System\Config\Form; /** * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Field extends \Magento\Backend\Block\Template implements \Magento\Framework\Data\Form\Element\Renderer\RendererInterface { diff --git a/app/code/Magento/Backend/Block/System/Config/Form/Field/FieldArray/AbstractFieldArray.php b/app/code/Magento/Backend/Block/System/Config/Form/Field/FieldArray/AbstractFieldArray.php index 38154796f34b4c0cfffa824aae12761ab062c66c..1d6ae66117b0dd9545df01976ccb54bec978a4bc 100644 --- a/app/code/Magento/Backend/Block/System/Config/Form/Field/FieldArray/AbstractFieldArray.php +++ b/app/code/Magento/Backend/Block/System/Config/Form/Field/FieldArray/AbstractFieldArray.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\System\Config\Form\Field\FieldArray; /** diff --git a/app/code/Magento/Backend/Block/System/Config/Form/Field/Select/Allowspecific.php b/app/code/Magento/Backend/Block/System/Config/Form/Field/Select/Allowspecific.php index 9864a56503df687665715b6e3ea23946b844c3b0..1137804348217b52d38150f4a23e32ee357ccb8c 100644 --- a/app/code/Magento/Backend/Block/System/Config/Form/Field/Select/Allowspecific.php +++ b/app/code/Magento/Backend/Block/System/Config/Form/Field/Select/Allowspecific.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * System configuration shipping methods allow all countries select * diff --git a/app/code/Magento/Backend/Block/System/Design/Edit/Tab/General.php b/app/code/Magento/Backend/Block/System/Design/Edit/Tab/General.php index cf875ddf67c0f934134d612b0967e3cd9e0f90dd..acf12f85721bb866dbe8f5d4fd875ef2f4b0b324 100644 --- a/app/code/Magento/Backend/Block/System/Design/Edit/Tab/General.php +++ b/app/code/Magento/Backend/Block/System/Design/Edit/Tab/General.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\System\Design\Edit\Tab; class General extends \Magento\Backend\Block\Widget\Form\Generic diff --git a/app/code/Magento/Backend/Block/Widget/Button/ButtonList.php b/app/code/Magento/Backend/Block/Widget/Button/ButtonList.php index cbc23d665e6e80f8de0a06971c2ef415907abbfa..2ff7df01256ccf732b9adf73f3cd781c65353b54 100644 --- a/app/code/Magento/Backend/Block/Widget/Button/ButtonList.php +++ b/app/code/Magento/Backend/Block/Widget/Button/ButtonList.php @@ -35,6 +35,7 @@ class ButtonList * @param integer $sortOrder * @param string|null $region That button should be displayed in ('toolbar', 'header', 'footer', null) * @return void + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function add($buttonId, $data, $level = 0, $sortOrder = 0, $region = 'toolbar') { diff --git a/app/code/Magento/Backend/Block/Widget/Form/Container.php b/app/code/Magento/Backend/Block/Widget/Form/Container.php index 9c599bdc8ac987f7cce7ca7d762fe1f746ad995b..73e18d3c7c1dadaf11a134f2e70dc1babdb7d5b6 100644 --- a/app/code/Magento/Backend/Block/Widget/Form/Container.php +++ b/app/code/Magento/Backend/Block/Widget/Form/Container.php @@ -9,6 +9,7 @@ namespace Magento\Backend\Block\Widget\Form; * Backend form container block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Container extends \Magento\Backend\Block\Widget\Container { diff --git a/app/code/Magento/Backend/Block/Widget/Form/Element/Gallery.php b/app/code/Magento/Backend/Block/Widget/Form/Element/Gallery.php index a8c7b2dcb6dc8495775f6c203bfa51674e3d230a..86f4f7fa68874560b81636dd68aabf4dc15ab4f2 100644 --- a/app/code/Magento/Backend/Block/Widget/Form/Element/Gallery.php +++ b/app/code/Magento/Backend/Block/Widget/Form/Element/Gallery.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Form\Element; use Magento\Framework\Data\Form\Element\AbstractElement; diff --git a/app/code/Magento/Backend/Block/Widget/Form/Renderer/Element.php b/app/code/Magento/Backend/Block/Widget/Form/Renderer/Element.php index f7b561175392ebf047d534e8198219fae2063bbb..939a0100ac4ca0cbcbce20fef2ef42ec7167cc97 100644 --- a/app/code/Magento/Backend/Block/Widget/Form/Renderer/Element.php +++ b/app/code/Magento/Backend/Block/Widget/Form/Renderer/Element.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Form\Renderer; use Magento\Framework\Data\Form\Element\AbstractElement; diff --git a/app/code/Magento/Backend/Block/Widget/Form/Renderer/Fieldset.php b/app/code/Magento/Backend/Block/Widget/Form/Renderer/Fieldset.php index 68eda4b964a1de664f1f6556cc52824e8a5352e8..b2b9b7f480efaeec44d6f87bafe8b45aed1fdd2e 100644 --- a/app/code/Magento/Backend/Block/Widget/Form/Renderer/Fieldset.php +++ b/app/code/Magento/Backend/Block/Widget/Form/Renderer/Fieldset.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Form\Renderer; use Magento\Framework\Data\Form\Element\AbstractElement; diff --git a/app/code/Magento/Backend/Block/Widget/Form/Renderer/Fieldset/Element.php b/app/code/Magento/Backend/Block/Widget/Form/Renderer/Fieldset/Element.php index 07036c4b89ef1df83af79f1bb6a5a6c9c0a07e8e..bef68253a1c848bfe9e98aec1cce5b47aac33ec3 100644 --- a/app/code/Magento/Backend/Block/Widget/Form/Renderer/Fieldset/Element.php +++ b/app/code/Magento/Backend/Block/Widget/Form/Renderer/Fieldset/Element.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Form\Renderer\Fieldset; use Magento\Framework\Data\Form\Element\AbstractElement; diff --git a/app/code/Magento/Backend/Block/Widget/Grid.php b/app/code/Magento/Backend/Block/Widget/Grid.php index 8ebfcef792d1c66238f21295a2cf48b820757e3b..b98ddc117f4d319b49ec126aa2a62487f0342744 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid.php +++ b/app/code/Magento/Backend/Block/Widget/Grid.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget; /** @@ -10,6 +13,7 @@ namespace Magento\Backend\Block\Widget; * * @method string getRowClickCallback() getRowClickCallback() * @method \Magento\Backend\Block\Widget\Grid setRowClickCallback() setRowClickCallback(string $value) + * @SuppressWarnings(PHPMD.TooManyFields) */ class Grid extends \Magento\Backend\Block\Widget { @@ -146,6 +150,7 @@ class Grid extends \Magento\Backend\Block\Widget /** * @return void + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _construct() { @@ -331,6 +336,7 @@ class Grid extends \Magento\Backend\Block\Widget * Apply sorting and filtering to collection * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _prepareCollection() { @@ -578,6 +584,7 @@ class Grid extends \Magento\Backend\Block\Widget * Return visibility of pager * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getPagerVisibility() { @@ -599,6 +606,7 @@ class Grid extends \Magento\Backend\Block\Widget * Return visibility of message blocks * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getMessageBlockVisibility() { @@ -761,6 +769,7 @@ class Grid extends \Magento\Backend\Block\Widget * Return count totals * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCountTotals() { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Column.php b/app/code/Magento/Backend/Block/Widget/Grid/Column.php index c1f28c40cd9be0c02c92933aa6d4c7813fee76fb..f5af4bf45fc6fb37a4651d5f50950c2dd1c3bca4 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Column.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Column.php @@ -232,6 +232,7 @@ class Column extends \Magento\Backend\Block\Widget /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getSortable() { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Date.php b/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Date.php index 1a136de81c4b952fae6cc714ec86b63b669b0219..9510e30b9b165df44b72fae1f453da6657940964 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Date.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Date.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Grid\Column\Filter; /** diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Datetime.php b/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Datetime.php index da779e2fa200079a786f930e9669f8291d61058e..0505ff14caa823bbef143e59c17dc8f3ed0788ca 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Datetime.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Datetime.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Grid\Column\Filter; /** diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Store.php b/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Store.php index 44f7ad083f899e2c9984ab540f6e40adac051803..c589c58e9cfe864830d54c05520b54f9b4a41f89 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Store.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Column/Filter/Store.php @@ -37,6 +37,8 @@ class Store extends \Magento\Backend\Block\Widget\Grid\Column\Filter\AbstractFil * Render HTML of the element * * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getHtml() { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/AbstractRenderer.php b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/AbstractRenderer.php index 7871caac761531a3aafd92a1cc2b05f3cce5b67c..3e58f4104f66e56b77d946fbaa506e84d81e7268 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/AbstractRenderer.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/AbstractRenderer.php @@ -10,6 +10,7 @@ use Magento\Framework\Object; /** * Backend grid item abstract renderer + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractRenderer extends \Magento\Backend\Block\AbstractBlock implements RendererInterface { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Action.php b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Action.php index 098e9010eb971de0177dac1636e5e27968a2d2dd..2da717929a0ecb67b15e1676c14d65c450c00efc 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Action.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Action.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Grid\Column\Renderer; /** @@ -116,6 +119,8 @@ class Action extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\Text * @param string &$actionCaption * @param \Magento\Framework\Object $row * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _transformActionData(&$action, &$actionCaption, \Magento\Framework\Object $row) { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Checkbox.php b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Checkbox.php index dd3f371962d76c897476d31c015bf25bf1a0b3d0..a0a9a97fc45dc24756cfaf11bb91304109a8827d 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Checkbox.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Checkbox.php @@ -70,6 +70,8 @@ class Checkbox extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\Abstra * * @param \Magento\Framework\Object $row * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function render(\Magento\Framework\Object $row) { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Currency.php b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Currency.php index 727cd51239617b73a627f491ddf8f991ba7afb2b..f0454dd37a9ec1e60fd5e232c06e60635bf37d00 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Currency.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Currency.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Grid\Column\Renderer; /** diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Options.php b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Options.php index 6dddb99c95e2a28e6467edb21b25a9ba1ba790a9..2ed159642da23198a7aca2b9f3f967ab42b41787 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Options.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Options.php @@ -27,6 +27,7 @@ class Options extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\Text * * @param \Magento\Framework\Object $row * @return string|void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function render(\Magento\Framework\Object $row) { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Store.php b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Store.php index d5c5f1152e1f56002207166fa9ae15067168a202..628d68b0fbccd0c69f2b7b698a499f1575d6d693 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Store.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Store.php @@ -53,6 +53,7 @@ class Store extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractR * Retrieve 'show all stores label' flag * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ protected function _getShowAllStoresLabelFlag() { @@ -67,6 +68,7 @@ class Store extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractR * Retrieve 'show empty stores label' flag * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ protected function _getShowEmptyStoresLabelFlag() { @@ -82,6 +84,8 @@ class Store extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractR * * @param \Magento\Framework\Object $row * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function render(\Magento\Framework\Object $row) { @@ -132,6 +136,7 @@ class Store extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractR * * @param \Magento\Framework\Object $row * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function renderExport(\Magento\Framework\Object $row) { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/ColumnSet.php b/app/code/Magento/Backend/Block/Widget/Grid/ColumnSet.php index e8eba5853fd4b28ba1d3c641577b2494765ece71..6078fff1bcbb6da5c87dbf28eeb3a730919569d4 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/ColumnSet.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/ColumnSet.php @@ -101,6 +101,7 @@ class ColumnSet extends \Magento\Framework\View\Element\Template * @param \Magento\Backend\Model\Widget\Grid\SubTotals $subtotals * @param \Magento\Backend\Model\Widget\Grid\Totals $totals * @param array $data + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, @@ -486,6 +487,7 @@ class ColumnSet extends \Magento\Framework\View\Element\Template * Retrieve flag is collapsed * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsCollapsed() { @@ -528,6 +530,7 @@ class ColumnSet extends \Magento\Framework\View\Element\Template * Return count subtotals * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCountSubTotals() { @@ -550,6 +553,7 @@ class ColumnSet extends \Magento\Framework\View\Element\Template * Return count totals * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCountTotals() { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Container.php b/app/code/Magento/Backend/Block/Widget/Grid/Container.php index 091ddbfebe50c007d2f97ab7ba6d86733cf19a50..875158fc2170c47e8eeb04d0250efc7c4fee8f22 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Container.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Container.php @@ -9,6 +9,7 @@ namespace Magento\Backend\Block\Widget\Grid; * Backend grid container block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Container extends \Magento\Backend\Block\Widget\Container { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Export.php b/app/code/Magento/Backend/Block/Widget/Grid/Export.php index 6adeb90d57ddd22f70f58f53ebb1e08c84236af6..04a21fe7734109060210f04873753c80dd952144 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Export.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Export.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Grid; use Magento\Framework\App\Filesystem\DirectoryList; @@ -106,6 +109,7 @@ class Export extends \Magento\Backend\Block\Widget implements \Magento\Backend\B * Return count totals * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCountTotals() { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Extended.php b/app/code/Magento/Backend/Block/Widget/Grid/Extended.php index eb54ce41d1d822c32c1633201665dba343eadaae..fe01cec33c9c1f51bc3c9ed88703ddcb541f15fa 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Extended.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Extended.php @@ -7,6 +7,12 @@ namespace Magento\Backend\Block\Widget\Grid; use Magento\Framework\App\Filesystem\DirectoryList; +/** + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.NumberOfChildren) + */ class Extended extends \Magento\Backend\Block\Widget\Grid implements \Magento\Backend\Block\Widget\Grid\ExportInterface { /** @@ -778,6 +784,7 @@ class Extended extends \Magento\Backend\Block\Widget\Grid implements \Magento\Ba * Return visibility of column headers * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getHeadersVisibility() { @@ -799,6 +806,7 @@ class Extended extends \Magento\Backend\Block\Widget\Grid implements \Magento\Ba * Return visibility of filter * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getFilterVisibility() { @@ -865,6 +873,7 @@ class Extended extends \Magento\Backend\Block\Widget\Grid implements \Magento\Ba * Retrieve flag is collapsed * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsCollapsed() { @@ -1243,6 +1252,7 @@ class Extended extends \Magento\Backend\Block\Widget\Grid implements \Magento\Ba * Return count subtotals * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCountSubTotals() { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Massaction/AbstractMassaction.php b/app/code/Magento/Backend/Block/Widget/Grid/Massaction/AbstractMassaction.php index 0adeb658a2277037aefab6ec2da3809c582b3c04..91c8d876eafca6549c4a0bf410dcc44ee90727d2 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Massaction/AbstractMassaction.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Massaction/AbstractMassaction.php @@ -295,6 +295,7 @@ abstract class AbstractMassaction extends \Magento\Backend\Block\Widget * Retrieve select all functionality flag check * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseSelectAll() { diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Massaction/Extended.php b/app/code/Magento/Backend/Block/Widget/Grid/Massaction/Extended.php index 335e1a30d2a1752daf698c4e0e7d4201cfe75c82..5f55cb9c98dead6b17dbc72b4b6338aade336ee0 100644 --- a/app/code/Magento/Backend/Block/Widget/Grid/Massaction/Extended.php +++ b/app/code/Magento/Backend/Block/Widget/Grid/Massaction/Extended.php @@ -306,6 +306,7 @@ class Extended extends \Magento\Backend\Block\Widget * Retrieve select all functionality flag check * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseSelectAll() { diff --git a/app/code/Magento/Backend/Block/Widget/Tabs.php b/app/code/Magento/Backend/Block/Widget/Tabs.php index f87419051797e477a4c53496da6571623d1121d9..5f18982736998b966443a427feb8e003137e6122 100644 --- a/app/code/Magento/Backend/Block/Widget/Tabs.php +++ b/app/code/Magento/Backend/Block/Widget/Tabs.php @@ -9,6 +9,7 @@ use Magento\Backend\Block\Widget\Tab\TabInterface; /** * Tabs block + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Tabs extends \Magento\Backend\Block\Widget { @@ -106,6 +107,7 @@ class Tabs extends \Magento\Backend\Block\Widget * @param array|\Magento\Framework\Object|string $tab * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function addTab($tabId, $tab) { @@ -302,6 +304,7 @@ class Tabs extends \Magento\Backend\Block\Widget /** * @param \Magento\Framework\Object|TabInterface $tab * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getTabIsHidden($tab) { @@ -390,6 +393,7 @@ class Tabs extends \Magento\Backend\Block\Widget * @param string $tabOneId * @param string $tabTwoId * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function bindShadowTabs($tabOneId, $tabTwoId) { diff --git a/app/code/Magento/Backend/Controller/Adminhtml/System/Account/Save.php b/app/code/Magento/Backend/Controller/Adminhtml/System/Account/Save.php index 0bbf7b3e73c931fee11676ad3cd1cb8c7baf252f..bbffca9f8eb00426c5866dc211f70849ca2030b0 100644 --- a/app/code/Magento/Backend/Controller/Adminhtml/System/Account/Save.php +++ b/app/code/Magento/Backend/Controller/Adminhtml/System/Account/Save.php @@ -29,6 +29,7 @@ class Save extends \Magento\Backend\Controller\Adminhtml\System\Account * Saving edited user information * * @return \Magento\Backend\Model\View\Result\Redirect + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Backend/Controller/Adminhtml/System/Config/System/Storage/Status.php b/app/code/Magento/Backend/Controller/Adminhtml/System/Config/System/Storage/Status.php index 493b016cd052d62162bf0c75278d2d43204ac729..e52f25a801e4af881ea9eec3be3d2fa6dfe0e288 100644 --- a/app/code/Magento/Backend/Controller/Adminhtml/System/Config/System/Storage/Status.php +++ b/app/code/Magento/Backend/Controller/Adminhtml/System/Config/System/Storage/Status.php @@ -29,6 +29,7 @@ class Status extends \Magento\Backend\Controller\Adminhtml\System\Config\System\ * Retrieve synchronize process state and it's parameters in json format * * @return \Magento\Framework\Controller\Result\JSON + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Backend/Controller/Adminhtml/System/Store.php b/app/code/Magento/Backend/Controller/Adminhtml/System/Store.php index a7e3d8694bffdce7072960187e4021cd865a3d49..9a9d2a4a6d620e056667cc5a44f95cef77decec1 100644 --- a/app/code/Magento/Backend/Controller/Adminhtml/System/Store.php +++ b/app/code/Magento/Backend/Controller/Adminhtml/System/Store.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Controller\Adminhtml\System; use Magento\Backend\App\Action; diff --git a/app/code/Magento/Backend/Controller/Adminhtml/System/Store/EditStore.php b/app/code/Magento/Backend/Controller/Adminhtml/System/Store/EditStore.php index b7952590b8f1c6169d5491aff2fe7d13772d4c2c..23a5e5c0fd95b5ed5376ca5fa20774846f5a44e7 100644 --- a/app/code/Magento/Backend/Controller/Adminhtml/System/Store/EditStore.php +++ b/app/code/Magento/Backend/Controller/Adminhtml/System/Store/EditStore.php @@ -10,6 +10,8 @@ class EditStore extends \Magento\Backend\Controller\Adminhtml\System\Store { /** * @return \Magento\Framework\Controller\ResultInterface + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Backend/Controller/Adminhtml/System/Store/Save.php b/app/code/Magento/Backend/Controller/Adminhtml/System/Store/Save.php index fc11594dc3a24efd953347077fc98d8463161c04..039f53da5bd051472c4988a8546ddeb0c7e52fa4 100644 --- a/app/code/Magento/Backend/Controller/Adminhtml/System/Store/Save.php +++ b/app/code/Magento/Backend/Controller/Adminhtml/System/Store/Save.php @@ -11,6 +11,7 @@ class Save extends \Magento\Backend\Controller\Adminhtml\System\Store { /** * @return \Magento\Backend\Model\View\Result\Redirect + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Backend/Model/Auth/Session.php b/app/code/Magento/Backend/Model/Auth/Session.php index aa49fb7104f19c75818e2e3b113ecbb1bbd95211..f9e5e549c732f836aa8c1de9fcebe1016b82aa20 100644 --- a/app/code/Magento/Backend/Model/Auth/Session.php +++ b/app/code/Magento/Backend/Model/Auth/Session.php @@ -64,6 +64,7 @@ class Session extends \Magento\Framework\Session\SessionManager implements \Mage * @param \Magento\Framework\Acl\Builder $aclBuilder * @param \Magento\Backend\Model\UrlInterface $backendUrl * @param \Magento\Backend\App\ConfigInterface $config + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Request\Http $request, diff --git a/app/code/Magento/Backend/Model/Config.php b/app/code/Magento/Backend/Model/Config.php index 99744a7d3f0ab407112e985d037065b134615e42..b5b099997e3275dcb46cb5b671a96648f3978861 100644 --- a/app/code/Magento/Backend/Model/Config.php +++ b/app/code/Magento/Backend/Model/Config.php @@ -10,6 +10,7 @@ namespace Magento\Backend\Model; * Used to save configuration * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Config extends \Magento\Framework\Object { @@ -179,6 +180,9 @@ class Config extends \Magento\Framework\Object * @param \Magento\Framework\DB\Transaction $saveTransaction * @param \Magento\Framework\DB\Transaction $deleteTransaction * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _processGroup( $groupId, diff --git a/app/code/Magento/Backend/Model/Config/Backend/Currency/Base.php b/app/code/Magento/Backend/Model/Config/Backend/Currency/Base.php index 7b86cfa1840b2bc3bdb12a1357d11927f43546d1..dfb95cc8ce2472686c070a688540c93ec958e44f 100644 --- a/app/code/Magento/Backend/Model/Config/Backend/Currency/Base.php +++ b/app/code/Magento/Backend/Model/Config/Backend/Currency/Base.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Backend Directory currency backend model * Allows dispatching before and after events for each controller action diff --git a/app/code/Magento/Backend/Model/Config/Backend/Email/Sender.php b/app/code/Magento/Backend/Model/Config/Backend/Email/Sender.php index ad1b31b26e9fb40a914845ad92de5ffc7f95926c..cf5d40e4be496929480e8105f005178bbe7b9117 100644 --- a/app/code/Magento/Backend/Model/Config/Backend/Email/Sender.php +++ b/app/code/Magento/Backend/Model/Config/Backend/Email/Sender.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * System config email sender field backend model */ diff --git a/app/code/Magento/Backend/Model/Config/Backend/Encrypted.php b/app/code/Magento/Backend/Model/Config/Backend/Encrypted.php index 042e41b51f2957ea19a6c0b6f7a951c928fa7401..bf1fcd071432048e747324cc3163ccc90149e9b4 100644 --- a/app/code/Magento/Backend/Model/Config/Backend/Encrypted.php +++ b/app/code/Magento/Backend/Model/Config/Backend/Encrypted.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Model\Config\Backend; class Encrypted extends \Magento\Framework\App\Config\Value implements \Magento\Framework\App\Config\Data\ProcessorInterface diff --git a/app/code/Magento/Backend/Model/Config/Source/Dev/Dbautoup.php b/app/code/Magento/Backend/Model/Config/Source/Dev/Dbautoup.php index 473463f39e0dccbcabb11e1490143528f3944382..d29625e33b0c4f5cadb769766fe59359907f982c 100644 --- a/app/code/Magento/Backend/Model/Config/Source/Dev/Dbautoup.php +++ b/app/code/Magento/Backend/Model/Config/Source/Dev/Dbautoup.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Model\Config\Source\Dev; class Dbautoup implements \Magento\Framework\Option\ArrayInterface diff --git a/app/code/Magento/Backend/Model/Config/Structure/Converter.php b/app/code/Magento/Backend/Model/Config/Structure/Converter.php index 994a1006bdbb6771b50fd51cd26dd515385d43c7..a85c03025c958bada88a325965e8298a5f7476c5 100644 --- a/app/code/Magento/Backend/Model/Config/Structure/Converter.php +++ b/app/code/Magento/Backend/Model/Config/Structure/Converter.php @@ -72,6 +72,8 @@ class Converter implements \Magento\Framework\Config\ConverterInterface * * @param \DOMNode $root * @return array|null + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _convertDOMDocument(\DOMNode $root) { diff --git a/app/code/Magento/Backend/Model/Config/Structure/Element/Group.php b/app/code/Magento/Backend/Model/Config/Structure/Element/Group.php index 7ecfc1c78d099cb357c3a6f86dbd1678fdbff830..251fa37a319d1bbc6c1d26374c508a40897c7290 100644 --- a/app/code/Magento/Backend/Model/Config/Structure/Element/Group.php +++ b/app/code/Magento/Backend/Model/Config/Structure/Element/Group.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Model\Config\Structure\Element; class Group extends AbstractComposite diff --git a/app/code/Magento/Backend/Model/Locale/Resolver.php b/app/code/Magento/Backend/Model/Locale/Resolver.php index 2b305ef80c191554937413ba42a85c75d03b2cb9..767f3d71041b7c2a823a126777f2825010949223 100644 --- a/app/code/Magento/Backend/Model/Locale/Resolver.php +++ b/app/code/Magento/Backend/Model/Locale/Resolver.php @@ -41,6 +41,7 @@ class Resolver extends \Magento\Framework\Locale\Resolver * @param \Magento\Framework\App\RequestInterface $request * @param \Magento\Framework\Locale\Validator $localeValidator * @param null $locale + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, diff --git a/app/code/Magento/Backend/Model/Menu/Config.php b/app/code/Magento/Backend/Model/Menu/Config.php index fec3a03ad4be6d4961191f1791176439ccd35d6b..b02a7aca7dc65eddf7b6f79388e48a72e1eb28b4 100644 --- a/app/code/Magento/Backend/Model/Menu/Config.php +++ b/app/code/Magento/Backend/Model/Menu/Config.php @@ -5,6 +5,9 @@ */ namespace Magento\Backend\Model\Menu; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Config { const CACHE_ID = 'backend_menu_config'; diff --git a/app/code/Magento/Backend/Model/Menu/Director/Director.php b/app/code/Magento/Backend/Model/Menu/Director/Director.php index 8d09c08a652e0946c08d59f80d294dc059d38d99..b5f30db5d84edeccd8801c732098d2bea25b9456 100644 --- a/app/code/Magento/Backend/Model/Menu/Director/Director.php +++ b/app/code/Magento/Backend/Model/Menu/Director/Director.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Model\Menu\Director; class Director extends \Magento\Backend\Model\Menu\AbstractDirector diff --git a/app/code/Magento/Backend/Model/Menu/Item.php b/app/code/Magento/Backend/Model/Menu/Item.php index 2013b5969443b3b15133d0e70decca2853c6ed94..c52c96fe555ab66caf9ba17a68ba4aed3150174e 100644 --- a/app/code/Magento/Backend/Model/Menu/Item.php +++ b/app/code/Magento/Backend/Model/Menu/Item.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Model\Menu; /** diff --git a/app/code/Magento/Backend/Model/Session/Quote.php b/app/code/Magento/Backend/Model/Session/Quote.php index 2de789c053fab4ce09663990408c84ecbb0c1299..96141a383c6909794113c967076579ed1f698ae8 100644 --- a/app/code/Magento/Backend/Model/Session/Quote.php +++ b/app/code/Magento/Backend/Model/Session/Quote.php @@ -22,6 +22,7 @@ use Magento\Customer\Api\GroupManagementInterface; * @method int getCurrencyId() * @method Quote setOrderId($orderId) * @method int getOrderId() + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Quote extends \Magento\Framework\Session\SessionManager { @@ -87,6 +88,7 @@ class Quote extends \Magento\Framework\Session\SessionManager * @param \Magento\Sales\Model\OrderFactory $orderFactory * @param \Magento\Store\Model\StoreManagerInterface $storeManager * @param GroupManagementInterface $groupManagement + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Request\Http $request, diff --git a/app/code/Magento/Backend/Model/Widget/Grid/AbstractTotals.php b/app/code/Magento/Backend/Model/Widget/Grid/AbstractTotals.php index af1bac309a554a00ed071d9ac974d41c8736a95b..3022ef696507edfbf73c0d7cad0a9d42a14389d8 100644 --- a/app/code/Magento/Backend/Model/Widget/Grid/AbstractTotals.php +++ b/app/code/Magento/Backend/Model/Widget/Grid/AbstractTotals.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Model\Widget\Grid; abstract class AbstractTotals implements \Magento\Backend\Model\Widget\Grid\TotalsInterface diff --git a/app/code/Magento/Backend/view/adminhtml/templates/admin/access_denied.phtml b/app/code/Magento/Backend/view/adminhtml/templates/admin/access_denied.phtml index 3a92e9f8f9034b8f86e0e3ddcc9215b83f1a0cc9..20bbd091ff935265bd451d16858f071a22185945 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/admin/access_denied.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/admin/access_denied.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Backend/view/adminhtml/templates/admin/login.phtml b/app/code/Magento/Backend/view/adminhtml/templates/admin/login.phtml index d75e37b380f911efd098a51bd4f34ffe6831280e..aaaa8e0dae823660166d287b9daec04757307178 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/admin/login.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/admin/login.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div id="page-login" class="page-login"> <div class="wrapper"> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/admin/overlay_popup.phtml b/app/code/Magento/Backend/view/adminhtml/templates/admin/overlay_popup.phtml index 6ffe241c93bb299c23a5e7c46eb257212369607c..8f9fd4eb82ddd079f877ed80b8a5bf2a7e969e27 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/admin/overlay_popup.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/admin/overlay_popup.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="wrapper-popup"> <div class="middle" id="anchor-content"> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/admin/page.phtml b/app/code/Magento/Backend/view/adminhtml/templates/admin/page.phtml index fa4fb1c651c20ce807cf22e7e9028e28271b8cda..6b87d5fd1636b94d813eaedf0d404c9ee13dddba 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/admin/page.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/admin/page.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Backend\Block\Page */ ?> <!doctype html> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/graph.phtml b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/graph.phtml index 5d6dc42114cbf8ae7910f2fad5ea133570a8817d..60307c043ac1eb4caadfa8610e7a6c0ab5dae8bd 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/graph.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/graph.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="dashboard-diagram"> <div class="dashboard-diagram-switcher"> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/grid.phtml b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/grid.phtml index 34291c010c86ca24fb9b038e021fd543331d6ceb..b302c2d03e43d3c1a5c8720ad9a6ee30a9534dce 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/grid.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/grid.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/index.phtml b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/index.phtml index 600b1f8c15cac33b49a5f88afce403bb0aeada80..d14649e5e2407249075f989cbbe4346b6573ee47 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/index.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/index.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (is_array($this->getChildBlock('diagrams')->getTabsIds())) : ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/salebar.phtml b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/salebar.phtml index bffe1bd96936f0ef6125fe29947a39208dc18998..35e55da07426bfba69951e988a3abc3c42c732a2 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/salebar.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/salebar.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (sizeof($this->getTotals()) > 0): ?> <?php foreach ($this->getTotals() as $_total): ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/searches.phtml b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/searches.phtml index 2ad225e0a5ffb39d128b87e5ea7ffcb226669da5..d0e11ba8c0a6bbcb0c034d0fa4df9e5f26507888 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/searches.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/searches.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div style="padding:5px;"> <?php if (count($this->getCollection()->getItems()) > 0): ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/store/switcher.phtml b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/store/switcher.phtml index a08e2faf7947f4c2f27a9c4b7e28786837ee3494..abb41eaff14ab269532fd6b7fd410045137c3263 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/store/switcher.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/store/switcher.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <p class="switcher"><label for="store_switcher"><?php echo __('View Statistics For:') ?></label> <?php echo $this->getHintHtml() ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/totalbar.phtml b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/totalbar.phtml index 222842a2d6109b0f14166abbd72a6967b10687d1..8a837773be68149ed36b8cc2ee3d7029f01c6f2c 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/dashboard/totalbar.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/dashboard/totalbar.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (sizeof($this->getTotals()) > 0): ?> <div class="dashboard-totals" id="dashboard_diagram_totals"> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/menu.phtml b/app/code/Magento/Backend/view/adminhtml/templates/menu.phtml index 1ee117f9558a946ce40cfd3fd555c32f4fe66841..b7f4a6af41df98e1fa5307faa9376f98a0ffb4ee 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/menu.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/menu.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <nav class="navigation"> <?php echo $this->renderNavigation($this->getMenuModel(), 0, 12); ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/page/copyright.phtml b/app/code/Magento/Backend/view/adminhtml/templates/page/copyright.phtml index dc10ea6e35da8acdcc65ca193c9e86bcf583f5ed..d32b9b4f5c4ab7558209c2712384758d2e3c45b4 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/page/copyright.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/page/copyright.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <small class="copyright"> <?php echo __('Magento is an eBay Inc. company. Copyright© %1 Magento, Inc. All rights reserved.', date('Y')) ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/page/footer.phtml b/app/code/Magento/Backend/view/adminhtml/templates/page/footer.phtml index 4ad3c029f28b2a7a8a02de175e1e723d35c3f664..4f1fb03406d4463050567bca627a6ffba0fdf1a9 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/page/footer.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/page/footer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <small class="magento-version"><?php echo __('Magento ver. %1', \Magento\Framework\AppInterface::VERSION) ?></small> <?php if ($this->getBugreportUrl()): ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/page/header.phtml b/app/code/Magento/Backend/view/adminhtml/templates/page/header.phtml index a2fd0aff3c6f66ef25b3a511a8aee96f93bfe7a8..5c8db117c4e73e47dad3dab2d4637b75a294329f 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/page/header.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/page/header.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Backend\Block\Page\Header */ ?> <?php switch ($this->getShowPart()): diff --git a/app/code/Magento/Backend/view/adminhtml/templates/page/js/components.phtml b/app/code/Magento/Backend/view/adminhtml/templates/page/js/components.phtml index 478e18e57b0112afae4e77d1b3e19a7bd86dc54d..fdeaf01cd1882d7e7d6f9178c4e92d70519962b1 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/page/js/components.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/page/js/components.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Backend/view/adminhtml/templates/page/js/translate.phtml b/app/code/Magento/Backend/view/adminhtml/templates/page/js/translate.phtml index 6181341332471324fe6c139fe5acb0b91f8f9f5b..4daf9993d72b0e0b72d1e4db2b7b6d195b5ff6e1 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/page/js/translate.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/page/js/translate.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Backend/view/adminhtml/templates/page/locale.phtml b/app/code/Magento/Backend/view/adminhtml/templates/page/locale.phtml index 5fde4390a8435fdbdbdbd666f99d5c219fbe1316..3db04de8d5e373461551bfdf9818c6e99e57a21a 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/page/locale.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/page/locale.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="locale-switcher-field field"> <label class="label" for="locale-switcher"><span><?php echo __('Interface Locale'); ?></span></label> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/page/notices.phtml b/app/code/Magento/Backend/view/adminhtml/templates/page/notices.phtml index 973581456ee53cf6f144cebf448526d40d48502d..76a9fe120c4b9dfe30871de7b45437d3cd107c7b 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/page/notices.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/page/notices.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Backend/view/adminhtml/templates/page/system/config/robots/reset.phtml b/app/code/Magento/Backend/view/adminhtml/templates/page/system/config/robots/reset.phtml index a523e6d06a2ef311f0adf5c303afdafc5589366d..84fe5da528eb03f466c43a1c43541442376104bc 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/page/system/config/robots/reset.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/page/system/config/robots/reset.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Backend\Block\Page\System\Config\Robots\Reset * @var $coreHelper \Magento\Core\Helper\Data diff --git a/app/code/Magento/Backend/view/adminhtml/templates/pageactions.phtml b/app/code/Magento/Backend/view/adminhtml/templates/pageactions.phtml index 8bc07aba86ec4e3434beb111a81fff007aa8c23e..5a988cfb65c77e2ddb9137b5b7a03bc72bb48e70 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/pageactions.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/pageactions.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getChildHtml()):?> <div class="page-actions" <?php echo $this->getUiId('content-header') ?>> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/store/switcher.phtml b/app/code/Magento/Backend/view/adminhtml/templates/store/switcher.phtml index 86b81d54a82cb2959703de6622df6b87475b6ce9..641df75fc0d522ab1e24c8b127bb2343baf5433e 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/store/switcher.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/store/switcher.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Backend\Block\Store\Switcher */ ?> <?php if ($websites = $this->getWebsites()): ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/store/switcher/form/renderer/fieldset.phtml b/app/code/Magento/Backend/view/adminhtml/templates/store/switcher/form/renderer/fieldset.phtml index 484cc43f6682b33e72640f9d54eda5898537f76b..94fbd082b8bbcba8f0dc2f3ce3e1e23706c896bd 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/store/switcher/form/renderer/fieldset.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/store/switcher/form/renderer/fieldset.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_element = $this->getElement() ?> <?php if ($_element->getFieldsetContainerId()): ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/store/switcher/form/renderer/fieldset/element.phtml b/app/code/Magento/Backend/view/adminhtml/templates/store/switcher/form/renderer/fieldset/element.phtml index c795f32811b1f8d893fafdbcad7870991ad8a9e4..a6a8a3a59b90c2126fa00820a811826541958ada 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/store/switcher/form/renderer/fieldset/element.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/store/switcher/form/renderer/fieldset/element.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Backend\Block\Widget\Form\Renderer\Fieldset\Element */ diff --git a/app/code/Magento/Backend/view/adminhtml/templates/system/autocomplete.phtml b/app/code/Magento/Backend/view/adminhtml/templates/system/autocomplete.phtml index a19fc0d02c172fe3db0f63ffd84dffa20f3232ed..2cd37a6a5ae5e27991c1611d9265b658dbda6d0a 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/system/autocomplete.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/system/autocomplete.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <ul class="dropdown-menu"> <?php foreach ($items as $item): ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/system/cache/edit.phtml b/app/code/Magento/Backend/view/adminhtml/templates/system/cache/edit.phtml index b99df5f7d180a3098d922a007a0c63fdd599f494..603aff5f66626e4f492c59b43b6bf55f1989ca3e 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/system/cache/edit.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/system/cache/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Backend/view/adminhtml/templates/system/config/edit.phtml b/app/code/Magento/Backend/view/adminhtml/templates/system/config/edit.phtml index 2869af6a0ee53785bbc0e1bbe9afc1aaca5d1fa6..4b22ca0a2ace46b37dc21206fa1e2ebff0db4d9c 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/system/config/edit.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/system/config/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Backend/view/adminhtml/templates/system/config/form/field/array.phtml b/app/code/Magento/Backend/view/adminhtml/templates/system/config/form/field/array.phtml index 6c1d3f0406b4b39ce133f57da74d60f9e96d973a..978f1806df767088feea206938412a00432c9b10 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/system/config/form/field/array.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/system/config/form/field/array.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Backend/view/adminhtml/templates/system/config/js.phtml b/app/code/Magento/Backend/view/adminhtml/templates/system/config/js.phtml index a564f9d466c1962ef8c13adfdc84081b8d73bf67..dac09723f71f4ff21cd905a3c48d5484ff57c33b 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/system/config/js.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/system/config/js.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <script> //<![CDATA[ diff --git a/app/code/Magento/Backend/view/adminhtml/templates/system/config/switcher.phtml b/app/code/Magento/Backend/view/adminhtml/templates/system/config/switcher.phtml index 6fb13048ea34e405d71e66d37cd6522caf72cbb3..57146e4f1279dbb33dd435580413c6d2426a411f 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/system/config/switcher.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/system/config/switcher.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Backend\Block\Template */ ?> <div class="field field-store-switcher"> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/system/config/system/storage/media/synchronize.phtml b/app/code/Magento/Backend/view/adminhtml/templates/system/config/system/storage/media/synchronize.phtml index 99b7cf75b59f6a720a097eed361d8042a872aac6..98742b19a718730d1ddabac7dff8c78965114012 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/system/config/system/storage/media/synchronize.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/system/config/system/storage/media/synchronize.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Backend\Block\System\Config\System\Storage\Media\Synchronize */ ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/system/config/tabs.phtml b/app/code/Magento/Backend/view/adminhtml/templates/system/config/tabs.phtml index bf03d65e22e67a8e5afb6394646556c12cafd8ea..1a8810fb437f48d4eb6462b426bea8d612cbfd95 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/system/config/tabs.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/system/config/tabs.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Backend\Block\System\Config\Tabs */ ?> <?php if ($this->getTitle()): ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/system/design/index.phtml b/app/code/Magento/Backend/view/adminhtml/templates/system/design/index.phtml index 9228aa320afa5a3a1b7e14c79d3773991984487f..1d27f92b1d57cdd4045ec77cdb17e900c03c669d 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/system/design/index.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/system/design/index.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml('grid') ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/system/search.phtml b/app/code/Magento/Backend/view/adminhtml/templates/system/search.phtml index b123a9fff17c93e0f6f04dc0b3a3112e7826b410..f023180974b5c7ef3d32bfcc00bb43c6c81fcf01 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/system/search.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/system/search.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Backend\Block\GlobalSearch */ ?> <div class="search-global miniform"> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/accordion.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/accordion.phtml index f6b7d7efa8576328b49c9578d31e3088990da86d..11282d76f56e71325f03366abde38fe61221b2ff 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/accordion.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/accordion.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/breadcrumbs.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/breadcrumbs.phtml index 835df288963c225715539b16effa8a936eb30791..68ba27df9f5ffc295b1b9548d2649a16678abd01 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/breadcrumbs.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/breadcrumbs.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (!empty($links)): ?> <ul class="breadcrumbs"> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/button.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/button.phtml index 4166c496e11b5884a5ffa9b0570dab25e3b60297..6a1f5e4a28e3221cf0d7d7ba0e47f24e2319ab7a 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/button.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/button.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/button/split.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/button/split.phtml index 9bacbdb873cf3a50523bf8d93c0b982fa1a5fb08..566e51e79c9204a3d63589135332325e9453ace9 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/button/split.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/button/split.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Backend\Block\Widget\Button\SplitButton */ diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/form.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/form.phtml index 6c5100e32c17206e9bd67d46696460af10117d9b..92f380112003e365aa299448cfe871ba0d748f91 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/form.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Backend\Block\Widget\Form */ ?> <?php /* @todo replace .form-inline with better class name */?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/container.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/container.phtml index be4a094380d8b139fa2731978afbeaecea5ef6de..d82ef9836caf686dbc86703a94276040ab76b352 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/container.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/container.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Backend\Block\Widget\Form\Container */ ?> <?php echo $this->getFormInitScripts() ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/element.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/element.phtml index 030bd206b20743f3cb5a667f94debb1b247714ce..8fcf631f014a883c39b6a1e4bf8558dd5b7e26ac 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/element.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/element.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php switch ($element->getType()) { case 'fieldset': ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/element/gallery.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/element/gallery.phtml index 95c7c229bb678423c1be3554a16d02d94bcc0178..74a7c81782bd2fbf22b0e02f7b3d7eca10c3476f 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/element/gallery.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/element/gallery.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <tr> <td colspan="2"> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/element.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/element.phtml index 058e239fca867cbd2bb2b621eb78ab9ff8f0f459..edebad68f4ae477b0b0d821689005a1792ec736b 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/element.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/element.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_element = $this->getElement() ?> <?php if ($_element->getNoSpan() !== true): ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/fieldset.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/fieldset.phtml index 45c07f7f63e63f609c88c1decf2705bf9398e8e9..af96e0bb2cf72b88d24d57de2f3593712bd3e139 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/fieldset.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/fieldset.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $element \Magento\Framework\Data\Form\Element\Fieldset */ diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/fieldset/element.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/fieldset/element.phtml index ea7c0e8df4d643303d3197e4cb21cd1fe617dec0..b74a8456a2a844069d00fec21d51b2052eec29af 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/fieldset/element.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/form/renderer/fieldset/element.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Backend\Block\Widget\Form\Renderer\Fieldset\Element */ diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid.phtml index d5b12d21404c6b4153950cb57f7f11c125a6649e..ea59605873cbef28b3d8d56dbe77fef9b0bb33f2 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/column_set.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/column_set.phtml index 0da5cded6680c296f01bd306931febf4883d7a33..04eba07e620e4c71e32001c9dcbcd203c973469d 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/column_set.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/column_set.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/container.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/container.phtml index dca0392fced9edf6771f829b3e83307e7589f4c2..914fc4d80329cec2dd46b6a6c46ad1f67d05ab72 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/container.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/container.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getButtonsHtml()): ?> <div class="page-actions"><?php echo $this->getButtonsHtml() ?></div> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/container/empty.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/container/empty.phtml index 744288619d63e421920bfec06db925d47b47ac93..16509b08f23f23cf2b4c70086e6cac75bc50074b 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/container/empty.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/container/empty.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getGridHtml() ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/export.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/export.phtml index 80c2de13bf2e7d41eccf449b55514bb92c71626d..25cfbd6766b4a5a03ac68581bd04a6347a777c9e 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/export.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/export.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <label for="<?php echo $this->getId() ?>_export" class="label"> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/extended.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/extended.phtml index 240eaa8ea4e83830d3f862256d756a5cb20cbda1..2b5b77c258ba91d291f7ef47a92686fffddd6008 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/extended.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/extended.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/massaction.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/massaction.phtml index 5513a10097654bc6424b1f50d02d16e13f89adcb..ede9400f6dd11b092ada9ddcf02169809eb7ad30 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/massaction.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/massaction.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div id="<?php echo $this->getHtmlId() ?>"> <div class="massaction"> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/massaction_extended.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/massaction_extended.phtml index 13f405a4326a6ccfc154801cbbce946c3bcb16ad..e14fbe74f569c4d951fe6140c543652acfe2865f 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/massaction_extended.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/massaction_extended.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @deprecated support Magento 1.x grid massaction implementation */ diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/serializer.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/serializer.phtml index 69196f4725181a9d60d458b283ed6b4e34c60e32..fae5424a2fb995cc65dbfbf7ca2fd137d99a3fb1 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/serializer.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/grid/serializer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/tabs.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/tabs.phtml index 7a63da88d825a0dac63556dfd94ae52ae36b787a..e2546a5fe5ded16ea760ea585bd6b7afe3dfeffd 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/tabs.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/tabs.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Backend\Block\Widget\Tabs */ ?> <?php if (!empty($tabs)): ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/tabshoriz.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/tabshoriz.phtml index 796cbb2d5e744b170aa0564c38c71673d96fada9..44cefcf35f24bce9a672c0f71c0485790835da18 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/tabshoriz.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/tabshoriz.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <!-- <?php if ($this->getTitle()): ?> <h3><?php echo $this->getTitle() ?></h3> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/tabsleft.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/tabsleft.phtml index 9a4a39f8f086458c67d407cf038b0a7276c512ae..3ed92243ce35b5caab231b9d47d6a3c27e5ff780 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/tabsleft.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/tabsleft.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <dl id="dl-<?php echo $id ?>" class="accordion"> <?php foreach ($sections as $sectionId => $section): ?> diff --git a/app/code/Magento/Backend/view/adminhtml/templates/widget/view/container.phtml b/app/code/Magento/Backend/view/adminhtml/templates/widget/view/container.phtml index 2ec0c32cae218a05b432820975f838cc64be62be..7454f10a81d475c8575077c58386aed2ccddf202 100644 --- a/app/code/Magento/Backend/view/adminhtml/templates/widget/view/container.phtml +++ b/app/code/Magento/Backend/view/adminhtml/templates/widget/view/container.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="page-actions"><?php echo $this->getButtonsHtml() ?></div> <?php echo $this->getViewHtml() ?> diff --git a/app/code/Magento/Backend/view/install/templates/page/copyright.phtml b/app/code/Magento/Backend/view/install/templates/page/copyright.phtml index 3a77746625ad345302fcce6bda1ba7f28e1e11fd..14a3b77f918bac8e16077ec716f437db12e2735b 100644 --- a/app/code/Magento/Backend/view/install/templates/page/copyright.phtml +++ b/app/code/Magento/Backend/view/install/templates/page/copyright.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo __('Magento is an eBay Inc. company. Copyright© %1 Magento, Inc. All rights reserved.', date('Y')) ?> diff --git a/app/code/Magento/Backup/Controller/Adminhtml/Index/Create.php b/app/code/Magento/Backup/Controller/Adminhtml/Index/Create.php index 02504e35cf8c4d3b7a2f7b24a1feec3eba4cffab..3597571146444fc2d43d330908913623dcbb1500 100644 --- a/app/code/Magento/Backup/Controller/Adminhtml/Index/Create.php +++ b/app/code/Magento/Backup/Controller/Adminhtml/Index/Create.php @@ -15,6 +15,7 @@ class Create extends \Magento\Backup\Controller\Adminhtml\Index * Create backup action * * @return void|\Magento\Backend\App\Action + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Backup/Controller/Adminhtml/Index/Download.php b/app/code/Magento/Backup/Controller/Adminhtml/Index/Download.php index fa15004829eca6dfd6d214e79e439d9913da9607..a2647f428ccf17fcf4c11f618de97498eb43abad 100644 --- a/app/code/Magento/Backup/Controller/Adminhtml/Index/Download.php +++ b/app/code/Magento/Backup/Controller/Adminhtml/Index/Download.php @@ -14,6 +14,7 @@ class Download extends \Magento\Backup\Controller\Adminhtml\Index * Download backup action * * @return void|\Magento\Backend\App\Action + * @SuppressWarnings(PHPMD.ExitExpression) */ public function execute() { diff --git a/app/code/Magento/Backup/Controller/Adminhtml/Index/Rollback.php b/app/code/Magento/Backup/Controller/Adminhtml/Index/Rollback.php index 7be45cbcb4c02e590495ee7537f2167fbd11840b..ef03c35226aef73091e954a9e38aac1f0d16ef3a 100644 --- a/app/code/Magento/Backup/Controller/Adminhtml/Index/Rollback.php +++ b/app/code/Magento/Backup/Controller/Adminhtml/Index/Rollback.php @@ -15,6 +15,9 @@ class Rollback extends \Magento\Backup\Controller\Adminhtml\Index * Rollback Action * * @return void|\Magento\Backend\App\Action + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function execute() { diff --git a/app/code/Magento/Backup/Model/Backup.php b/app/code/Magento/Backup/Model/Backup.php index 52f720fea228bcaa3ebfaf6cac8da5f7f5d81fbe..71eec41eadb101c2520b6cfe84db6504fc2d45a1 100644 --- a/app/code/Magento/Backup/Model/Backup.php +++ b/app/code/Magento/Backup/Model/Backup.php @@ -14,6 +14,7 @@ use Magento\Framework\Filesystem\DriverPool; * @method string getPath() * @method string getName() * @method string getTime() + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Backup extends \Magento\Framework\Object implements \Magento\Framework\Backup\Db\BackupInterface { diff --git a/app/code/Magento/Backup/Model/Resource/Db.php b/app/code/Magento/Backup/Model/Resource/Db.php index 2ec3d7c75ca67eb73d854a813970f86d5151051a..78c2b95445f3dd47f921d32ef75c8fc5563ba6be 100644 --- a/app/code/Magento/Backup/Model/Resource/Db.php +++ b/app/code/Magento/Backup/Model/Resource/Db.php @@ -181,6 +181,7 @@ class Db * @param string $tableName * @param bool $step * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getTableDataDump($tableName, $step = false) { diff --git a/app/code/Magento/Backup/Model/Resource/Helper.php b/app/code/Magento/Backup/Model/Resource/Helper.php index f6454f1f2591e58c44467f4dc6f29dc44d4afa6b..1ac7b4366810b5463fe9b358f80771e05d6c70d4 100644 --- a/app/code/Magento/Backup/Model/Resource/Helper.php +++ b/app/code/Magento/Backup/Model/Resource/Helper.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backup\Model\Resource; class Helper extends \Magento\Framework\DB\Helper @@ -120,6 +123,7 @@ class Helper extends \Magento\Framework\DB\Helper * @param string $tableName * @param bool $withForeignKeys * @return string + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getTableCreateSql($tableName, $withForeignKeys = false) { diff --git a/app/code/Magento/Backup/view/adminhtml/templates/backup/dialogs.phtml b/app/code/Magento/Backup/view/adminhtml/templates/backup/dialogs.phtml index 14f77c2580b42e0a5703e9a7a36fba9990dc1013..0c5ceb2637abf0bff303dcb81bc9f2943051c674 100644 --- a/app/code/Magento/Backup/view/adminhtml/templates/backup/dialogs.phtml +++ b/app/code/Magento/Backup/view/adminhtml/templates/backup/dialogs.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <!-- TODO: refactor form styles and js --> <div class="fade backup-dialog" id="rollback-warning" style="display: none;"> diff --git a/app/code/Magento/Backup/view/adminhtml/templates/backup/list.phtml b/app/code/Magento/Backup/view/adminhtml/templates/backup/list.phtml index 9ae31398fdee4b5ba6d0c9c845e8be6e1d4355e7..ac6c6d48320a469c6aaede692ca081e04f999168 100644 --- a/app/code/Magento/Backup/view/adminhtml/templates/backup/list.phtml +++ b/app/code/Magento/Backup/view/adminhtml/templates/backup/list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml('grid') ?> <?php echo $this->getGridHtml() ?> diff --git a/app/code/Magento/Bundle/Api/Data/LinkInterface.php b/app/code/Magento/Bundle/Api/Data/LinkInterface.php index 50e8f27ec3de28fc488d33ac57e6880c2b25e707..78a595f4da271d24dd864c911ddce954e16b3962 100644 --- a/app/code/Magento/Bundle/Api/Data/LinkInterface.php +++ b/app/code/Magento/Bundle/Api/Data/LinkInterface.php @@ -48,6 +48,7 @@ interface LinkInterface extends \Magento\Framework\Api\ExtensibleDataInterface * Get is default * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsDefault(); diff --git a/app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes.php b/app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes.php index ac139e758fc1395788ea0abf7af450a724201c06..10439a8fb192ffc6f578bcdde5271fd125d71dae 100644 --- a/app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes.php +++ b/app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes.php @@ -3,10 +3,14 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Bundle\Block\Adminhtml\Catalog\Product\Edit\Tab; /** * Bundle product attributes tab + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Attributes extends \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Attributes { @@ -14,6 +18,8 @@ class Attributes extends \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Attri * Prepare attributes form of bundle product * * @return void + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes/Extend.php b/app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes/Extend.php index c8136f9ae32feb20aa1369d5a54a5f94e3099d14..c3bc776692e922326c706da4af6e381f5d0aa005 100644 --- a/app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes/Extend.php +++ b/app/code/Magento/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tab/Attributes/Extend.php @@ -54,6 +54,9 @@ class Extend extends \Magento\Catalog\Block\Adminhtml\Form\Renderer\Fieldset\Ele * Get Element Html * * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getElementHtml() { diff --git a/app/code/Magento/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php b/app/code/Magento/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php index 461f74ed1aebe77b10b84c927c0847c064b44bcb..d348945a052bc154831fd92c1a5dd4c5db930edc 100644 --- a/app/code/Magento/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php +++ b/app/code/Magento/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php @@ -70,6 +70,7 @@ class Renderer extends \Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRend /** * @param mixed $item * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isShipmentSeparately($item = null) { @@ -105,6 +106,7 @@ class Renderer extends \Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRend /** * @param mixed $item * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isChildCalculated($item = null) { diff --git a/app/code/Magento/Bundle/Block/Adminhtml/Sales/Order/View/Items/Renderer.php b/app/code/Magento/Bundle/Block/Adminhtml/Sales/Order/View/Items/Renderer.php index 652a322f2a62e2fc79b5a5f49feecc282c9d5a5f..0c0a97e7ebef34bfdeabdbbfc85577e57391d2fd 100644 --- a/app/code/Magento/Bundle/Block/Adminhtml/Sales/Order/View/Items/Renderer.php +++ b/app/code/Magento/Bundle/Block/Adminhtml/Sales/Order/View/Items/Renderer.php @@ -33,6 +33,7 @@ class Renderer extends \Magento\Sales\Block\Adminhtml\Order\View\Items\Renderer\ /** * @param null|object $item * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isShipmentSeparately($item = null) { @@ -65,6 +66,7 @@ class Renderer extends \Magento\Sales\Block\Adminhtml\Order\View\Items\Renderer\ /** * @param null|object $item * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isChildCalculated($item = null) { diff --git a/app/code/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php b/app/code/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php index 54b7bf1a3181e6194556b3cfa867f0a829f4b699..3fbebc9a79a4d0b9fd0832d9eeb8cce267b3ec6f 100644 --- a/app/code/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php +++ b/app/code/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Bundle\Block\Catalog\Product\View\Type\Bundle; use Magento\Bundle\Model\Product\Price; @@ -272,6 +275,7 @@ class Option extends \Magento\Bundle\Block\Catalog\Product\Price * @param int $elementId * @param int $containerId * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setValidationContainer($elementId, $containerId) { diff --git a/app/code/Magento/Bundle/Block/Checkout/Cart/Item/Renderer.php b/app/code/Magento/Bundle/Block/Checkout/Cart/Item/Renderer.php index 6ca6a1c3bd906c2e268cc2fee101d05e9aa03b4a..02f8b96dffdf8296456236433cb2ab8f38865d9e 100644 --- a/app/code/Magento/Bundle/Block/Checkout/Cart/Item/Renderer.php +++ b/app/code/Magento/Bundle/Block/Checkout/Cart/Item/Renderer.php @@ -38,6 +38,7 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer * @param Configuration $bundleProductConfiguration * @param \Magento\Framework\Module\Manager $moduleManager * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, @@ -83,6 +84,7 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer * * @param bool $useCache * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _getBundleOptions($useCache = true) { diff --git a/app/code/Magento/Bundle/Block/Sales/Order/Items/Renderer.php b/app/code/Magento/Bundle/Block/Sales/Order/Items/Renderer.php index 710b16638209c1449983da94904f4d5cc92fa1db..44df68a474e22e05fd759c7bcddf76e3802e3b94 100644 --- a/app/code/Magento/Bundle/Block/Sales/Order/Items/Renderer.php +++ b/app/code/Magento/Bundle/Block/Sales/Order/Items/Renderer.php @@ -17,6 +17,7 @@ class Renderer extends \Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer /** * @param mixed $item * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isShipmentSeparately($item = null) { @@ -52,6 +53,7 @@ class Renderer extends \Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer /** * @param mixed $item * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isChildCalculated($item = null) { diff --git a/app/code/Magento/Bundle/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php b/app/code/Magento/Bundle/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php index c363fecf0b978bb111e6c6ebaa4f79bdaeeab2b3..71577e116144405009a34cd1ed576fa60e624879 100644 --- a/app/code/Magento/Bundle/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php +++ b/app/code/Magento/Bundle/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Bundle.php @@ -28,6 +28,7 @@ class Bundle * * @return \Magento\Catalog\Model\Product * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function afterInitialize( \Magento\Catalog\Controller\Adminhtml\Product\Initialization\Helper $subject, diff --git a/app/code/Magento/Bundle/Model/LinkManagement.php b/app/code/Magento/Bundle/Model/LinkManagement.php index 1f9f1f507e8a7e10793927a984cb0642e8344b53..35bda8aafe5bbc699ad722f1074276b0bbafa7d8 100644 --- a/app/code/Magento/Bundle/Model/LinkManagement.php +++ b/app/code/Magento/Bundle/Model/LinkManagement.php @@ -10,6 +10,9 @@ use Magento\Catalog\Api\ProductRepositoryInterface; use Magento\Framework\Exception\CouldNotSaveException; use Magento\Framework\Exception\InputException; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class LinkManagement implements \Magento\Bundle\Api\ProductLinkManagementInterface { /** @@ -96,6 +99,8 @@ class LinkManagement implements \Magento\Bundle\Api\ProductLinkManagementInterfa /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function addChild( \Magento\Catalog\Api\Data\ProductInterface $product, diff --git a/app/code/Magento/Bundle/Model/Observer.php b/app/code/Magento/Bundle/Model/Observer.php index 1f907283cd0cbf0f19dd2795664752436b65eaf9..c334969ade488b9463b77477a4586142d9359886 100644 --- a/app/code/Magento/Bundle/Model/Observer.php +++ b/app/code/Magento/Bundle/Model/Observer.php @@ -67,6 +67,8 @@ class Observer * * @param \Magento\Framework\Object $observer * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function appendUpsellProducts($observer) { diff --git a/app/code/Magento/Bundle/Model/OptionRepository.php b/app/code/Magento/Bundle/Model/OptionRepository.php index c62eaaaa3db2545d113a95ac046f8036fb06ff9b..438a229021721800c5359053ddf0e31937c2e0f5 100644 --- a/app/code/Magento/Bundle/Model/OptionRepository.php +++ b/app/code/Magento/Bundle/Model/OptionRepository.php @@ -10,6 +10,9 @@ use Magento\Framework\Exception\CouldNotSaveException; use Magento\Framework\Exception\NoSuchEntityException; use Magento\Webapi\Exception; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class OptionRepository implements \Magento\Bundle\Api\ProductOptionRepositoryInterface { /** @@ -145,6 +148,7 @@ class OptionRepository implements \Magento\Bundle\Api\ProductOptionRepositoryInt /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function save( \Magento\Catalog\Api\Data\ProductInterface $product, @@ -218,6 +222,7 @@ class OptionRepository implements \Magento\Bundle\Api\ProductOptionRepositoryInt * @param \Magento\Bundle\Api\Data\LinkInterface $firstLink * @param \Magento\Bundle\Api\Data\LinkInterface $secondLink * @return int + * @SuppressWarnings(PHPMD.UnusedPrivateMethod) */ private function compareLinks( \Magento\Bundle\Api\Data\LinkInterface $firstLink, diff --git a/app/code/Magento/Bundle/Model/Plugin/QuoteItem.php b/app/code/Magento/Bundle/Model/Plugin/QuoteItem.php index 0ed1f9390ce3db6548fd52874fd16254023d17bd..2b75f6081ea37c968f74866dadf1021ca7058b5e 100644 --- a/app/code/Magento/Bundle/Model/Plugin/QuoteItem.php +++ b/app/code/Magento/Bundle/Model/Plugin/QuoteItem.php @@ -23,7 +23,7 @@ class QuoteItem \Magento\Quote\Model\Quote\Item\ToOrderItem $subject, Closure $proceed, \Magento\Quote\Model\Quote\Item\AbstractItem $item, - $additional + $additional = [] ) { /** @var $orderItem \Magento\Sales\Model\Order\Item */ $orderItem = $proceed($item, $additional); diff --git a/app/code/Magento/Bundle/Model/Product/Price.php b/app/code/Magento/Bundle/Model/Product/Price.php index 4d745118181c23ed54858ef913cd2524a4dc274a..af198bf0b1b72d3c2a79d11dc9f0e7be37d2aa89 100644 --- a/app/code/Magento/Bundle/Model/Product/Price.php +++ b/app/code/Magento/Bundle/Model/Product/Price.php @@ -11,6 +11,7 @@ use Magento\Framework\Pricing\PriceCurrencyInterface; /** * Bundle Price Model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Price extends \Magento\Catalog\Model\Product\Type\Price { @@ -74,6 +75,7 @@ class Price extends \Magento\Catalog\Model\Product\Type\Price * Is min/max prices have been calculated by index * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsPricesCalculatedByIndex() { @@ -181,6 +183,9 @@ class Price extends \Magento\Catalog\Model\Product\Type\Price * @param bool|null $includeTax * @param bool $takeTierPrice * @return float|array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getTotalPrices($product, $which = null, $includeTax = null, $takeTierPrice = true) { @@ -523,6 +528,8 @@ class Price extends \Magento\Catalog\Model\Product\Type\Price * @param float $qty * @param \Magento\Catalog\Model\Product $product * @return float|array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getTierPrice($qty, $product) { diff --git a/app/code/Magento/Bundle/Model/Product/Type.php b/app/code/Magento/Bundle/Model/Product/Type.php index 633f74881157f6f693536748735516f59e20b165..1ad99a75752791f039fac4572fc8c81800a22f7b 100644 --- a/app/code/Magento/Bundle/Model/Product/Type.php +++ b/app/code/Magento/Bundle/Model/Product/Type.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Bundle\Model\Product; use Magento\Catalog\Api\ProductRepositoryInterface; @@ -10,6 +13,9 @@ use Magento\Framework\Pricing\PriceCurrencyInterface; /** * Bundle Type Model + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Type extends \Magento\Catalog\Model\Product\Type\AbstractType { @@ -341,6 +347,7 @@ class Type extends \Magento\Catalog\Model\Product\Type\AbstractType * * @param \Magento\Catalog\Model\Product $product * @return $this|void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function beforeSave($product) { @@ -385,6 +392,7 @@ class Type extends \Magento\Catalog\Model\Product\Type\AbstractType * * @param \Magento\Catalog\Model\Product $product * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function save($product) { @@ -591,6 +599,8 @@ class Type extends \Magento\Catalog\Model\Product\Type\AbstractType * * @param \Magento\Catalog\Model\Product $product * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function isSalable($product) { @@ -649,6 +659,9 @@ class Type extends \Magento\Catalog\Model\Product\Type\AbstractType * @param \Magento\Catalog\Model\Product $product * @param string $processMode * @return array|string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareProduct(\Magento\Framework\Object $buyRequest, $product, $processMode) { @@ -1014,6 +1027,7 @@ class Type extends \Magento\Catalog\Model\Product\Type\AbstractType * * @param \Magento\Catalog\Model\Product $product * @return boolean true + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getForceChildItemQtyChanges($product) { diff --git a/app/code/Magento/Bundle/Model/Resource/Indexer/Price.php b/app/code/Magento/Bundle/Model/Resource/Indexer/Price.php index 5e8bdd6410c95a3dc07ce8da68900cff122a2df6..68a304f10dc78fb23011c4ccd41175a29a05be5a 100644 --- a/app/code/Magento/Bundle/Model/Resource/Indexer/Price.php +++ b/app/code/Magento/Bundle/Model/Resource/Indexer/Price.php @@ -125,6 +125,7 @@ class Price extends \Magento\Catalog\Model\Resource\Product\Indexer\Price\Defaul * @param int $priceType * @param int|array $entityIds the entity ids limitation * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareBundlePriceByType($priceType, $entityIds = null) { @@ -373,6 +374,7 @@ class Price extends \Magento\Catalog\Model\Resource\Product\Indexer\Price\Defaul * * @param int $priceType * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _calculateBundleSelectionPrice($priceType) { diff --git a/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/AbstractItems.php b/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/AbstractItems.php index edf0e0dfa594a033f4aa0ed92f718efff42bc225..f5971bdb578de9b60cacaede66d9a0a8c9e397ec 100644 --- a/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/AbstractItems.php +++ b/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/AbstractItems.php @@ -54,6 +54,7 @@ abstract class AbstractItems extends \Magento\Sales\Model\Order\Pdf\Items\Abstra * * @param \Magento\Framework\Object $item * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isShipmentSeparately($item = null) { @@ -91,6 +92,7 @@ abstract class AbstractItems extends \Magento\Sales\Model\Order\Pdf\Items\Abstra * * @param \Magento\Framework\Object $item * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isChildCalculated($item = null) { @@ -130,6 +132,7 @@ abstract class AbstractItems extends \Magento\Sales\Model\Order\Pdf\Items\Abstra * * @param \Magento\Framework\Object $item * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getBundleOptions($item = null) { @@ -164,6 +167,7 @@ abstract class AbstractItems extends \Magento\Sales\Model\Order\Pdf\Items\Abstra * * @param \Magento\Framework\Object $item * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getOrderOptions($item = null) { diff --git a/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Creditmemo.php b/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Creditmemo.php index 222cc6a4ca3d435a7acc77e2317f78963c8652c0..9c912505ae25f325e093d9e5f47544830990ba74 100644 --- a/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Creditmemo.php +++ b/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Creditmemo.php @@ -56,6 +56,9 @@ class Creditmemo extends AbstractItems * Draw item line * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function draw() { diff --git a/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Invoice.php b/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Invoice.php index 6f3ff1901751a90b6bf4a00fd1545b6cc8098620..797529dacf45d44c048db9bf178e9fdfb71d2508 100644 --- a/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Invoice.php +++ b/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Invoice.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Bundle\Model\Sales\Order\Pdf\Items; /** @@ -54,6 +57,9 @@ class Invoice extends AbstractItems * Draw item line * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function draw() { diff --git a/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Shipment.php b/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Shipment.php index 5087f874b86f6c7e9845bd2f5bfe4116bbac65ef..19358878b50889a691df408aab58019f7964fd9a 100644 --- a/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Shipment.php +++ b/app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Shipment.php @@ -54,6 +54,9 @@ class Shipment extends AbstractItems * Draw item line * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function draw() { diff --git a/app/code/Magento/Bundle/Pricing/Adjustment/Calculator.php b/app/code/Magento/Bundle/Pricing/Adjustment/Calculator.php index f59d63b4a5353adc68226b586c35b94e7ed6d43a..f3f59155be87ea4ecd4ffec0992b39eac5279b9c 100644 --- a/app/code/Magento/Bundle/Pricing/Adjustment/Calculator.php +++ b/app/code/Magento/Bundle/Pricing/Adjustment/Calculator.php @@ -20,6 +20,7 @@ use Magento\Tax\Helper\Data as TaxHelper; /** * Bundle price calculator + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Calculator implements BundleCalculatorInterface { @@ -79,6 +80,7 @@ class Calculator implements BundleCalculatorInterface * @param null|string $exclude * @param null|array $context * @return \Magento\Framework\Pricing\Amount\AmountInterface + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getAmount($amount, SaleableInterface $saleableItem, $exclude = null, $context = []) { @@ -172,6 +174,8 @@ class Calculator implements BundleCalculatorInterface * @param bool $searchMin * @param bool $useRegularPrice * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function getSelectionAmounts(Product $bundleProduct, $searchMin, $useRegularPrice = false) { @@ -295,6 +299,7 @@ class Calculator implements BundleCalculatorInterface * @param \Magento\Bundle\Pricing\Price\BundleSelectionPrice[] $selectionPriceList * @param null|string $exclude * @return \Magento\Framework\Pricing\Amount\AmountInterface + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function calculateDynamicBundleAmount($basePriceValue, $bundleProduct, $selectionPriceList, $exclude) { @@ -382,6 +387,7 @@ class Calculator implements BundleCalculatorInterface * @param \Magento\Bundle\Pricing\Price\BundleSelectionPrice[] $selectionPriceList * @param bool $searchMin * @return \Magento\Bundle\Pricing\Price\BundleSelectionPrice[] + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function processOptions($option, $selectionPriceList, $searchMin = true) { diff --git a/app/code/Magento/Bundle/Pricing/Price/BundleSelectionPrice.php b/app/code/Magento/Bundle/Pricing/Price/BundleSelectionPrice.php index 78db911af98e85c7cefa9cccd0313feced598e36..6b5ede60719f51ca23d563444196f7cbc6f44177 100644 --- a/app/code/Magento/Bundle/Pricing/Price/BundleSelectionPrice.php +++ b/app/code/Magento/Bundle/Pricing/Price/BundleSelectionPrice.php @@ -16,6 +16,7 @@ use Magento\Framework\Pricing\Price\AbstractPrice; /** * Bundle option price + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class BundleSelectionPrice extends AbstractPrice { diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/bundle.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/bundle.phtml index 27778d35ad5e5d7e40cdba3952d18a686d74b2ea..b6acc0f9033d7308a7b4420ea82fe81842f2b901 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/bundle.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/bundle.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Bundle\Block\Adminhtml\Catalog\Product\Composite\Fieldset\Bundle */ ?> diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/checkbox.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/checkbox.phtml index e40fb4aa06b6e386dbd374e36024b2ebf6426189..b886a87eef049beb41f2bee38473546f953f86a9 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/checkbox.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/checkbox.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Bundle\Block\Adminhtml\Catalog\Product\Composite\Fieldset\Options\Type\Checkbox */ ?> <?php $_option = $this->getOption(); ?> diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/multi.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/multi.phtml index 7fb4da26a3efc3cadca939ada628da4ef059f65a..c1212d74dfdc6980a398481891156588b2e2801e 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/multi.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/multi.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Bundle\Block\Adminhtml\Catalog\Product\Composite\Fieldset\Options\Type\Multi */ ?> <?php $_option = $this->getOption(); ?> diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/radio.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/radio.phtml index 3d35168920bae61c8641f4394b4533447d07e544..fdae49d174eab84f0dae11e88b4bdf8bc2c0ad15 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/radio.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/radio.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Bundle\Block\Adminhtml\Catalog\Product\Composite\Fieldset\Options\Type\Radio */ ?> <?php $_option = $this->getOption(); ?> diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/select.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/select.phtml index c9cc6d68ea045ac22d31b3aabaf06883b1023d2c..a73b8f2486e9700c2e9a25f3c9711562d2ff4f49 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/select.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/product/composite/fieldset/options/type/select.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Bundle\Block\Adminhtml\Catalog\Product\Composite\Fieldset\Options\Type\Select */ ?> <?php $_option = $this->getOption(); ?> diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle.phtml index 30df525b0984ecb3f5e8d74cfa73e1b3d88e8ab8..16e6c5e5c30bda0c43a285cf1af579abcba01e9d 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Bundle\Block\Adminhtml\Catalog\Product\Edit\Tab\Bundle */ ?> <script> diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle/option.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle/option.phtml index 908ed29d232bb7dc085b862beedefb109ea221ca..2d68f15534eb43cf1b7213c52a6c6ac6456fc32d 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle/option.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle/option.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Bundle\Block\Adminhtml\Catalog\Product\Edit\Tab\Bundle\Option */ ?> <script id="bundle-option-template" type="text/x-jquery-tmpl"> diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle/option/selection.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle/option/selection.phtml index 96ea4f2aad9a3758ddede3ab382c0b9faa3e61f7..3e0fca0b440b4dbcfc46ffba09c5c62d185ecc5c 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle/option/selection.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/product/edit/bundle/option/selection.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Bundle\Block\Adminhtml\Catalog\Product\Edit\Tab\Bundle\Option\Selection */ ?> <script id="bundle-option-selection-box-template" type="text/x-jquery-tmpl"> diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/sales/creditmemo/create/items/renderer.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/sales/creditmemo/create/items/renderer.phtml index f8b0769935a136eb9f6d80c0776ef4fd8e97586c..26383fb52dca16a446b4023af7b555e364ebed89 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/sales/creditmemo/create/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/sales/creditmemo/create/items/renderer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/sales/creditmemo/view/items/renderer.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/sales/creditmemo/view/items/renderer.phtml index 2bebcba33636ac79185bf0ada65631bd3344915e..d4fe089d9bdb0816d6e5407d31568d39a08189b5 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/sales/creditmemo/view/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/sales/creditmemo/view/items/renderer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/sales/invoice/create/items/renderer.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/sales/invoice/create/items/renderer.phtml index 7bc68f648651386790e7de544453e4fa6112fa18..8bc1bb7194d2bb779cb29f3cf51787d21372e52d 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/sales/invoice/create/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/sales/invoice/create/items/renderer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/sales/invoice/view/items/renderer.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/sales/invoice/view/items/renderer.phtml index a0bf842d09fafe41096d1aa9b0d48960b4cc2ee4..9fb053cde59fe9801c96923c3e77c9d07ddbbb7e 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/sales/invoice/view/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/sales/invoice/view/items/renderer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/sales/order/view/items/renderer.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/sales/order/view/items/renderer.phtml index f279adb441c2edd4f21ac8130945a8222c8ad18d..c4e91067b0d5b73ffe8c81f119035445b8c13730 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/sales/order/view/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/sales/order/view/items/renderer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/sales/shipment/create/items/renderer.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/sales/shipment/create/items/renderer.phtml index 499dc145b1d3abeb2e9ba677a06ca374e3ad59b7..8cee9aa2e52c9996243b2351293d62669e028dfa 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/sales/shipment/create/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/sales/shipment/create/items/renderer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Bundle/view/adminhtml/templates/sales/shipment/view/items/renderer.phtml b/app/code/Magento/Bundle/view/adminhtml/templates/sales/shipment/view/items/renderer.phtml index 4e2a08aa7bac89946cbae90ed496f226ca3e70bd..160f8aa6ebcc729cb68bc26510b4fb42d01bad5f 100644 --- a/app/code/Magento/Bundle/view/adminhtml/templates/sales/shipment/view/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/adminhtml/templates/sales/shipment/view/items/renderer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Bundle/view/base/templates/product/price/final_price.phtml b/app/code/Magento/Bundle/view/base/templates/product/price/final_price.phtml index 5fdd473281974c3c451a4bd05926cb00ea1c0ffa..bc76e6a2c44c44c56f89758a333e9b51e0b3f604 100644 --- a/app/code/Magento/Bundle/view/base/templates/product/price/final_price.phtml +++ b/app/code/Magento/Bundle/view/base/templates/product/price/final_price.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Bundle/view/base/templates/product/price/selection/amount.phtml b/app/code/Magento/Bundle/view/base/templates/product/price/selection/amount.phtml index 8c6597dccfa6bfc074df6c43a02e4d8a3a7955af..96853648aa2e923fca2bbe26df1f7f46ac3f6407 100644 --- a/app/code/Magento/Bundle/view/base/templates/product/price/selection/amount.phtml +++ b/app/code/Magento/Bundle/view/base/templates/product/price/selection/amount.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Framework\Pricing\Render\Amount $this */ ?> diff --git a/app/code/Magento/Bundle/view/base/templates/product/price/tier_prices.phtml b/app/code/Magento/Bundle/view/base/templates/product/price/tier_prices.phtml index 3bfb345d89dcf7fff149539cd1cce8778e98baee..5e187539667973657a355c20a4b7c0ba8cd2591b 100644 --- a/app/code/Magento/Bundle/view/base/templates/product/price/tier_prices.phtml +++ b/app/code/Magento/Bundle/view/base/templates/product/price/tier_prices.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/customize.phtml b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/customize.phtml index 54cbd6e4aad235a6a1f4343ecabd0447c29d2af8..6b68956b6518862653d2d4017def82fdc5ff23d0 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/customize.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/customize.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_product = $this->getProduct() ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/summary.phtml b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/summary.phtml index 5d461fc315822a3fafdcc592cdb117b33620e27a..b7124fdbef421e2e246f92cd7cca09b8334fec06 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/summary.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/summary.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle.phtml b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle.phtml index 8880a2c9f297bcadb5f216505676761982f44674..6d524636e5ceb84b54cf519b6bb9c810e5cdedac 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /* @var $this \Magento\Bundle\Block\Catalog\Product\View\Type\Bundle */ ?> <?php $_product = $this->getProduct() ?> @@ -18,4 +20,4 @@ </p> <?php endif; ?> <?php endif; ?> -<?php echo $this->getChildHtml('bundle_prices') ?> \ No newline at end of file +<?php echo $this->getChildHtml('bundle_prices') ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/checkbox.phtml b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/checkbox.phtml index 5408596fc68c69c162806027fa4b144df8b6d696..5aa595f37d9c49cda51cd5de38f2c05db9aeec34 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/checkbox.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/checkbox.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Bundle\Block\Catalog\Product\View\Type\Bundle\Option\Checkbox */ ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/multi.phtml b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/multi.phtml index 225c3b170b962b3738a6bad86d90c9b9bd5ae413..482d3fc80c85b3ccc660990cc4dc50c981bdde77 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/multi.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/multi.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Bundle\Block\Catalog\Product\View\Type\Bundle\Option\Multi */ ?> <?php $_option = $this->getOption() ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/radio.phtml b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/radio.phtml index 05b284411dcbd3387d538bb8d8de9125c41f1126..bbbd774f7ee50039465541ca39f22e52ea322c88 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/radio.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/radio.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Bundle\Block\Catalog\Product\View\Type\Bundle\Option\Radio */ ?> <?php $_option = $this->getOption(); ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/select.phtml b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/select.phtml index c525d53399111376627a27abd35695c25d53beca..cfbe57449ef7d8b3c31946fa082cf7e4b38edb38 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/select.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/option/select.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Bundle\Block\Catalog\Product\View\Type\Bundle\Option\Select */ ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/options.phtml b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/options.phtml index b3f7e2212864adc3f20fd5980880ebce5bf9e2a9..cab5b39bc7d5a50c2633e52404313b913874995c 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/options.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/catalog/product/view/type/bundle/options.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this Magento\Bundle\Block\Catalog\Product\View\Type\Bundle */ ?> <?php diff --git a/app/code/Magento/Bundle/view/frontend/templates/email/order/items/creditmemo/default.phtml b/app/code/Magento/Bundle/view/frontend/templates/email/order/items/creditmemo/default.phtml index 1b08fe6f350e753513c957dd721a15913bd1bd4a..28c2466f059672bbcc2c7929734e223bef78f7bf 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/email/order/items/creditmemo/default.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/email/order/items/creditmemo/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Bundle\Block\Sales\Order\Items\Renderer */ ?> <?php $parentItem = $this->getItem() ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/email/order/items/invoice/default.phtml b/app/code/Magento/Bundle/view/frontend/templates/email/order/items/invoice/default.phtml index 227b6e93e347cd94e6f005b8b2fc7d1eef3ce7f9..7b37cc48507500ef318f40e997a189cbef2544bb 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/email/order/items/invoice/default.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/email/order/items/invoice/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Bundle\Block\Sales\Order\Items\Renderer */ ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/email/order/items/order/default.phtml b/app/code/Magento/Bundle/view/frontend/templates/email/order/items/order/default.phtml index 8e33b500f35de2333b319e8456f2b24a1e2265e5..d61a831e34f8bbdf7e6871cdf9aef54d2604bcf6 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/email/order/items/order/default.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/email/order/items/order/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Bundle\Block\Sales\Order\Items\Renderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/email/order/items/shipment/default.phtml b/app/code/Magento/Bundle/view/frontend/templates/email/order/items/shipment/default.phtml index ce49dcdcd7f01bb54e587306548580dc5bc0ff63..4bbfff568370460063db461a9ec1ade486a5cb7c 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/email/order/items/shipment/default.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/email/order/items/shipment/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $parentItem = $this->getItem() ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/js/components.phtml b/app/code/Magento/Bundle/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/sales/order/creditmemo/items/renderer.phtml b/app/code/Magento/Bundle/view/frontend/templates/sales/order/creditmemo/items/renderer.phtml index b81f491429f3b2e4c49cb2b870d4eee9feae4a60..f2a1a774128b5273dca1d34decf92c69840ae509 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/sales/order/creditmemo/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/sales/order/creditmemo/items/renderer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Bundle\Block\Sales\Order\Items\Renderer */ ?> <?php $parentItem = $this->getItem() ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/sales/order/invoice/items/renderer.phtml b/app/code/Magento/Bundle/view/frontend/templates/sales/order/invoice/items/renderer.phtml index 4eb202e6c2f412673d28e6aefbff30ee8cf91877..56ad8b54ee07c6261bc185f878451af50e4839ff 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/sales/order/invoice/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/sales/order/invoice/items/renderer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Bundle\Block\Sales\Order\Items\Renderer */ ?> <?php $parentItem = $this->getItem() ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/sales/order/items/renderer.phtml b/app/code/Magento/Bundle/view/frontend/templates/sales/order/items/renderer.phtml index 4b6a05eb442e11811e7ab0f83b1661072e4ac321..0471828ba77213c619e7097316b1765e9325bcc7 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/sales/order/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/sales/order/items/renderer.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Bundle\Block\Sales\Order\Items\Renderer */ ?> <?php $parentItem = $this->getItem() ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/sales/order/shipment/items/renderer.phtml b/app/code/Magento/Bundle/view/frontend/templates/sales/order/shipment/items/renderer.phtml index 0d29f6412b52848c1491bc960f01f43873d70851..5ca9f9dc07ea0b69a89a1e902de5d2e355f0e8a1 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/sales/order/shipment/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/sales/order/shipment/items/renderer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $parentItem = $this->getItem() ?> <?php $items = array_merge([$parentItem->getOrderItem()], $parentItem->getOrderItem()->getChildrenItems()) ?> diff --git a/app/code/Magento/Captcha/Model/Config/Form/AbstractForm.php b/app/code/Magento/Captcha/Model/Config/Form/AbstractForm.php index a006766e8c90e6bd5f50becccb791c4eeb70cffe..dfd0456226d5c4ba4aef401d5db41c99e768fbd9 100644 --- a/app/code/Magento/Captcha/Model/Config/Form/AbstractForm.php +++ b/app/code/Magento/Captcha/Model/Config/Form/AbstractForm.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Data source to fill "Forms" field * diff --git a/app/code/Magento/Captcha/Model/Observer.php b/app/code/Magento/Captcha/Model/Observer.php index 340822047bbdfab6445d6faa503ebc21437de4a6..14ffd09fa49412ac7473669a879a734a0d27d9c7 100644 --- a/app/code/Magento/Captcha/Model/Observer.php +++ b/app/code/Magento/Captcha/Model/Observer.php @@ -9,6 +9,7 @@ namespace Magento\Captcha\Model; * Captcha Observer * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Observer { diff --git a/app/code/Magento/Captcha/view/adminhtml/templates/default.phtml b/app/code/Magento/Captcha/view/adminhtml/templates/default.phtml index e44d995772e1a775ce38b041e1a4ea314ca70dff..cbff9a3d01a1277e3f694efb8dd830ae33c2a67c 100644 --- a/app/code/Magento/Captcha/view/adminhtml/templates/default.phtml +++ b/app/code/Magento/Captcha/view/adminhtml/templates/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $captcha \Magento\Captcha\Model\DefaultModel */ ?> <?php /* @var $this \Magento\Captcha\Block\Captcha\DefaultCaptcha */ ?> diff --git a/app/code/Magento/Captcha/view/frontend/templates/default.phtml b/app/code/Magento/Captcha/view/frontend/templates/default.phtml index 31d59245224562db8e7b7f48fd6c354a8d4a3daa..90ded45d0d918c616c9b3dd4c53fb157fba3de55 100644 --- a/app/code/Magento/Captcha/view/frontend/templates/default.phtml +++ b/app/code/Magento/Captcha/view/frontend/templates/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $captcha \Magento\Captcha\Model\DefaultModel */ ?> <?php /* @var $this \Magento\Captcha\Block\Captcha\DefaultCaptcha */ ?> diff --git a/app/code/Magento/Captcha/view/frontend/templates/js/components.phtml b/app/code/Magento/Captcha/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Captcha/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Captcha/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Catalog/Api/Data/CategoryTreeInterface.php b/app/code/Magento/Catalog/Api/Data/CategoryTreeInterface.php index cd7bb21dd3cea692325fa59a8fe1df854a9020a2..ede64fcf762a488377d94efad9d86fae289d5080 100644 --- a/app/code/Magento/Catalog/Api/Data/CategoryTreeInterface.php +++ b/app/code/Magento/Catalog/Api/Data/CategoryTreeInterface.php @@ -32,6 +32,7 @@ interface CategoryTreeInterface extends \Magento\Framework\Api\ExtensibleDataInt * Check whether category is active * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsActive(); diff --git a/app/code/Magento/Catalog/Api/Data/ProductAttributeMediaGalleryEntryInterface.php b/app/code/Magento/Catalog/Api/Data/ProductAttributeMediaGalleryEntryInterface.php index 2443f11f966dc595b6ce7e09d538d81ac9c37a93..108979ba5d09eea35d3bf7ce21abb6d53cd929f1 100644 --- a/app/code/Magento/Catalog/Api/Data/ProductAttributeMediaGalleryEntryInterface.php +++ b/app/code/Magento/Catalog/Api/Data/ProductAttributeMediaGalleryEntryInterface.php @@ -41,6 +41,7 @@ interface ProductAttributeMediaGalleryEntryInterface * Check if gallery entry is hidden from product page * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsDisabled(); diff --git a/app/code/Magento/Catalog/Api/Data/ProductCustomOptionInterface.php b/app/code/Magento/Catalog/Api/Data/ProductCustomOptionInterface.php index 50641489f89992c4853f20729faef9894c897494..8d2c1af2dabb77b13c608a4ce425692f4c22cd3b 100644 --- a/app/code/Magento/Catalog/Api/Data/ProductCustomOptionInterface.php +++ b/app/code/Magento/Catalog/Api/Data/ProductCustomOptionInterface.php @@ -47,6 +47,7 @@ interface ProductCustomOptionInterface * Get is require * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsRequire(); diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Category/AbstractCategory.php b/app/code/Magento/Catalog/Block/Adminhtml/Category/AbstractCategory.php index 00ec33315e9d8490a5a0458786e327e08250a1d5..03b52c6ac341ce065bf2c1920e859c2e4da29a2f 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Category/AbstractCategory.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Category/AbstractCategory.php @@ -121,6 +121,7 @@ class AbstractCategory extends \Magento\Backend\Block\Template * @param mixed|null $parentNodeCategory * @param int $recursionLevel * @return Node|array|null + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getRoot($parentNodeCategory = null, $recursionLevel = 3) { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Category/Checkboxes/Tree.php b/app/code/Magento/Catalog/Block/Adminhtml/Category/Checkboxes/Tree.php index 9a18675340c5dfa58776f9627122b7531a34ca64..25cd867302dfd63ae6898b1f7d4e4de0d19f87ef 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Category/Checkboxes/Tree.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Category/Checkboxes/Tree.php @@ -78,6 +78,7 @@ class Tree extends \Magento\Catalog\Block\Adminhtml\Category\Tree * @param array|Node $node * @param int $level * @return array + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getNodeJson($node, $level = 1) { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Category/Tab/Attributes.php b/app/code/Magento/Catalog/Block/Adminhtml/Category/Tab/Attributes.php index 96dd3e5a5da39b7bb790e9a5791e981ea7ed8074..06a77c8af6023a4add0a375633ec0009e97ab7c0 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Category/Tab/Attributes.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Category/Tab/Attributes.php @@ -38,6 +38,8 @@ class Attributes extends \Magento\Backend\Block\Widget\Form\Generic * Prepare form before rendering HTML * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _prepareForm() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Category/Tab/Design.php b/app/code/Magento/Catalog/Block/Adminhtml/Category/Tab/Design.php index 60052fc8bb2c18a839176468b2b2f204480ff9fc..2bdf2ebf95be469c96277382b1bc6c00adab9a36 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Category/Tab/Design.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Category/Tab/Design.php @@ -5,6 +5,9 @@ */ namespace Magento\Catalog\Block\Adminhtml\Category\Tab; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Design extends \Magento\Catalog\Block\Adminhtml\Form { /** diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Category/Tabs.php b/app/code/Magento/Catalog/Block/Adminhtml/Category/Tabs.php index 19322d4b7d801494b65527fa706363f8313c1eec..0f7bfb9042f735acff82ce5ecb91a7f37e5cc644 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Category/Tabs.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Category/Tabs.php @@ -106,6 +106,7 @@ class Tabs extends \Magento\Backend\Block\Widget\Tabs * Prepare Layout Content * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _prepareLayout() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Category/Tree.php b/app/code/Magento/Catalog/Block/Adminhtml/Category/Tree.php index 84cbd06e86b9d28be6e0caaa9b58cb772a8a15ef..6db0db075824da391371c6ac752d79b5fa6cda58 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Category/Tree.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Category/Tree.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Categories tree block */ @@ -244,6 +246,7 @@ class Tree extends \Magento\Catalog\Block\Adminhtml\Category\AbstractCategory /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsWasExpanded() { @@ -314,6 +317,8 @@ class Tree extends \Magento\Catalog\Block\Adminhtml\Category\AbstractCategory * @param Node|array $node * @param int $level * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getNodeJson($node, $level = 0) { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Form/Renderer/Config/DateFieldsOrder.php b/app/code/Magento/Catalog/Block/Adminhtml/Form/Renderer/Config/DateFieldsOrder.php index b841cf0ede6a1dfb16ed6a46f6720bb32b8462a4..e9a129df7c06191ff95981ddcde098eb040db4b3 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Form/Renderer/Config/DateFieldsOrder.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Form/Renderer/Config/DateFieldsOrder.php @@ -19,6 +19,7 @@ class DateFieldsOrder extends Field /** * @param AbstractElement $element * @return string + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getElementHtml(AbstractElement $element) { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Helper/Form/Wysiwyg.php b/app/code/Magento/Catalog/Block/Adminhtml/Helper/Form/Wysiwyg.php index 775f529570ede2e66e621b46bc428025af03e9a6..4e8693474e09bd0bc8c751ec0789a7ffe904ac2e 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Helper/Form/Wysiwyg.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Helper/Form/Wysiwyg.php @@ -138,6 +138,7 @@ HTML; * Check whether wysiwyg enabled or not * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsWysiwygEnabled() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Advanced.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Advanced.php index b2c928f6bcbbccb623caeadd9380c8d525734262..a3e16b89f1dbce7e825ff862087cff7bc379c62d 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Advanced.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Advanced.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Product attribute add/edit form main tab * @@ -54,6 +56,7 @@ class Advanced extends Generic * Adding product form elements for editing attribute * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Front.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Front.php index 14c2b030991467593a6f7cd35e849da202cf72ec..6a4b55e2194c876502a46341471b2676812e152f 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Front.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Front.php @@ -44,6 +44,7 @@ class Front extends Generic /** * {@inheritdoc} * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Main.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Main.php index 05c49c39a9fd629cbdc228622db6c0ae0e01f2ed..35155d15e785a1a2be59598673020c419f7ed60d 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Main.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Main.php @@ -13,12 +13,16 @@ namespace Magento\Catalog\Block\Adminhtml\Product\Attribute\Edit\Tab; use Magento\Eav\Block\Adminhtml\Attribute\Edit\Main\AbstractMain; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Main extends AbstractMain { /** * Adding product form elements for editing attribute * * @return $this + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _prepareForm() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Grid.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Grid.php index 59433983c4b11d3c92942d9f549489d72cb0da49..8ca6195788ac8fa4cb4b9c8e090fac7d6d505012 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Grid.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Grid.php @@ -13,6 +13,9 @@ namespace Magento\Catalog\Block\Adminhtml\Product\Attribute; use Magento\Eav\Block\Adminhtml\Attribute\Grid\AbstractGrid; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Grid extends AbstractGrid { /** diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/NewAttribute/Product/Attributes.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/NewAttribute/Product/Attributes.php index c365667768150d845c4d3c9f92b6edfcc1878cf0..a5d7eba7fc4ff9e42e7b3cf0a086226e117e8dc0 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/NewAttribute/Product/Attributes.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/NewAttribute/Product/Attributes.php @@ -13,6 +13,9 @@ namespace Magento\Catalog\Block\Adminhtml\Product\Attribute\NewAttribute\Product use Magento\Backend\Block\Widget\Form; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Attributes extends \Magento\Catalog\Block\Adminhtml\Form { /** diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Main.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Main.php index 60b7325fe8acee9b01cce0fcf7bca96b72a20681..2f184f4bc916a124c2959e03a9931a25aab6792a 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Main.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Main.php @@ -345,6 +345,7 @@ class Main extends \Magento\Backend\Block\Template * Check Current Attribute Set is a default * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsCurrentSetDefault() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Attributes.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Attributes.php index 7ac536f9995816dd3e0c5a433fa5fd5f69d941b9..00fa7838673786656affb1c69206a4ca81de9e18 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Attributes.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Attributes.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Adminhtml catalog product edit action attributes update tab block * @@ -13,6 +15,9 @@ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Action\Attribute\Tab; use Magento\Framework\Data\Form\Element\AbstractElement; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Attributes extends \Magento\Catalog\Block\Adminhtml\Form implements \Magento\Backend\Block\Widget\Tab\TabInterface { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php index 399de16c7df3517352dca38d5e4b38a37a597f4b..f757d4f3e99c133f275f93fb453ab80c633e120a 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Product alerts tab * diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes.php index cf6d2a6e6bb6e53c7318796a4cdbcd6d46f1a45e..d72539539a1b9e1126f9cd1d752db2b3fec3f55e 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes.php @@ -11,12 +11,18 @@ */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Attributes extends \Magento\Catalog\Block\Adminhtml\Form { /** * Prepare attributes form * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Crosssell.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Crosssell.php index cf8c975d516cfdc6aab6e1feb383576247ac2555..9f6229afbb32bee847f6fdcc591e92ee16174375 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Crosssell.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Crosssell.php @@ -15,6 +15,9 @@ use Magento\Backend\Block\Widget\Grid\Column; use Magento\Backend\Block\Widget\Grid\Extended; use Magento\Catalog\Model\Product; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Crosssell extends Extended { /** @@ -187,6 +190,7 @@ class Crosssell extends Extended * Add columns to grid * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareColumns() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Option.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Option.php index 9e5cbf16174610935e07e471dacf950676e32ecc..3a86850d5f87c6a8abdcc4c68480d6b7e4eac86a 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Option.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Option.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Customers defined options */ @@ -269,6 +271,9 @@ class Option extends Widget /** * @return \Magento\Framework\Object[] + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getOptionValues() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php index cc93e83fae357fb2bc5d82ef915ee7267f1ee1f5..ab0acdbf63b4f8d379fc5d84a79165f0f4067a25 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php @@ -13,6 +13,9 @@ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Popup; use Magento\Catalog\Model\Product; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Grid extends \Magento\Catalog\Block\Adminhtml\Product\Grid { /** diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Price/Tier.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Price/Tier.php index efd4344b6e231415646372ec52726d8b40d00c9e..d2c9e742545cd88859eb5e04d81ed80c5e1d1804 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Price/Tier.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Price/Tier.php @@ -43,6 +43,7 @@ class Tier extends Group\AbstractGroup * @param array $a * @param array $b * @return int + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _sortTierPrices($a, $b) { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Related.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Related.php index 930ab7102fd56facc07a8748f3d5b3aa5b53c735..685aa481fe9fa9c335987aae68ce1f7f0bb3056f 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Related.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Related.php @@ -184,6 +184,7 @@ class Related extends Extended * Add columns to grid * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareColumns() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Upsell.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Upsell.php index 4e2fd72745b34d99cc4542080811a4c5df64863f..ca442c0b98b3e9fe3f9dbaf56a3e0bd2c76e2471 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Upsell.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Upsell.php @@ -181,6 +181,7 @@ class Upsell extends \Magento\Backend\Block\Widget\Grid\Extended * Add columns to grid * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareColumns() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tabs.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tabs.php index 78aec16eee179ecc71a3ff3ca11cc584753e876b..c059866c2ae8f4c6bcaf7876783003f7c52cf351 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tabs.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tabs.php @@ -72,6 +72,7 @@ class Tabs extends \Magento\Backend\Block\Widget\Tabs * @param \Magento\Framework\Registry $registry * @param \Magento\Framework\Translate\InlineInterface $translateInline * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Backend\Block\Template\Context $context, @@ -118,6 +119,9 @@ class Tabs extends \Magento\Backend\Block\Widget\Tabs /** * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareLayout() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Frontend/Product/Watermark.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Frontend/Product/Watermark.php index f82a78689e81f78e9abb70a1b7da3ced7822919c..51e82133640303da9a9a719bc25ec96fb3f2f03d 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Frontend/Product/Watermark.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Frontend/Product/Watermark.php @@ -126,6 +126,7 @@ class Watermark extends \Magento\Backend\Block\AbstractBlock implements /** * @param AbstractElement $element * @return string + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _getHeaderHtml($element) { @@ -149,6 +150,7 @@ class Watermark extends \Magento\Backend\Block\AbstractBlock implements /** * @param AbstractElement $element * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _getFooterHtml($element) { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Grid.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Grid.php index fe290eacf76e04e563dcd7caef391f70deae9e9f..f053cfff68c30a45b9b39f8b3da88d0c29e4159c 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Grid.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Grid.php @@ -209,6 +209,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid\Extended /** * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareColumns() { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Category.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Category.php index 2f017a34926b5b57638d96259b33f697bec1a975..5dc08c3d96431071f24985754594fd26dac30ede 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Category.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Category.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Block\Adminhtml\Product\Helper\Form; use Magento\Catalog\Model\Resource\Category\Collection; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery.php index 33c4824d8f93d85275fc421e12bc9d804d55561e..d8ad9281699487ced8601782e1131745e6f1e6c3 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Catalog product gallery attribute @@ -176,6 +178,7 @@ class Gallery extends AbstractElement * * @param Attribute|string $attribute * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getAttributeReadonly($attribute) { diff --git a/app/code/Magento/Catalog/Block/Breadcrumbs.php b/app/code/Magento/Catalog/Block/Breadcrumbs.php index e8f4a3f3bac100b430f871ae6fdf550eb2c7ef0b..5b6769b296d1ac7d233c104fd770085b159ed91e 100644 --- a/app/code/Magento/Catalog/Block/Breadcrumbs.php +++ b/app/code/Magento/Catalog/Block/Breadcrumbs.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Catalog breadcrumbs */ diff --git a/app/code/Magento/Catalog/Block/Navigation.php b/app/code/Magento/Catalog/Block/Navigation.php index 8f62231591389defe0b362ed03bffb281ea080ca..3dc3f7a4d7bb8bfda94490b751e85637d100285c 100644 --- a/app/code/Magento/Catalog/Block/Navigation.php +++ b/app/code/Magento/Catalog/Block/Navigation.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Block; use Magento\Catalog\Model\Category; @@ -12,6 +15,7 @@ use Magento\Customer\Model\Context; * Catalog navigation * * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Navigation extends \Magento\Framework\View\Element\Template implements \Magento\Framework\View\Block\IdentityInterface { diff --git a/app/code/Magento/Catalog/Block/Product/AbstractProduct.php b/app/code/Magento/Catalog/Block/Product/AbstractProduct.php index 2199e3057104ef7189547d915266ea88505a012e..ea891535c263d82cfdab6d3d5025bddbdc1d4b79 100644 --- a/app/code/Magento/Catalog/Block/Product/AbstractProduct.php +++ b/app/code/Magento/Catalog/Block/Product/AbstractProduct.php @@ -7,6 +7,8 @@ namespace Magento\Catalog\Block\Product; /** * Class AbstractProduct + * @SuppressWarnings(PHPMD.NumberOfChildren) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class AbstractProduct extends \Magento\Framework\View\Element\Template { @@ -377,6 +379,7 @@ class AbstractProduct extends \Magento\Framework\View\Element\Template * * @param \Magento\Catalog\Model\Product $product * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCanShowProductPrice($product) { diff --git a/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php b/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php index 80e59304f4460def155d7ba0a52f5a36df7938df..861a0cbfffa6bbb2231b4be702e32f3bd4af9754 100644 --- a/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php +++ b/app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php @@ -12,6 +12,7 @@ use Magento\Framework\App\Action\Action; /** * Catalog products compare block + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class ListCompare extends \Magento\Catalog\Block\Product\Compare\AbstractCompare { diff --git a/app/code/Magento/Catalog/Block/Product/Context.php b/app/code/Magento/Catalog/Block/Product/Context.php index 9402df7bcb22768b45804922711310b227de7063..7244352e262863747eebdc0e4ba1c53bab71378d 100644 --- a/app/code/Magento/Catalog/Block/Product/Context.php +++ b/app/code/Magento/Catalog/Block/Product/Context.php @@ -7,6 +7,7 @@ namespace Magento\Catalog\Block\Product; /** * Abstract product block context + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Context extends \Magento\Framework\View\Element\Template\Context { diff --git a/app/code/Magento/Catalog/Block/Product/ListProduct.php b/app/code/Magento/Catalog/Block/Product/ListProduct.php index 17bdf803742ebb4b504c74705feaa9b32e5153b4..bc007d7e3f47995774c44ea93b9a7e94fac3edbd 100644 --- a/app/code/Magento/Catalog/Block/Product/ListProduct.php +++ b/app/code/Magento/Catalog/Block/Product/ListProduct.php @@ -15,6 +15,7 @@ use Magento\Framework\View\Block\IdentityInterface; /** * Product list + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class ListProduct extends AbstractProduct implements IdentityInterface { diff --git a/app/code/Magento/Catalog/Block/Product/ProductList/Related.php b/app/code/Magento/Catalog/Block/Product/ProductList/Related.php index 05b10f8fe49dbff11ccc587a3078f03d3df716c9..f92b7b91b6911fca9621de872f1dd24fea1b6fcf 100644 --- a/app/code/Magento/Catalog/Block/Product/ProductList/Related.php +++ b/app/code/Magento/Catalog/Block/Product/ProductList/Related.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Block\Product\ProductList; use Magento\Catalog\Model\Resource\Product\Collection; diff --git a/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php b/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php index 1526ed7afc49a5b86e6984f759854b570593a818..b2f02218b1d7ed604c72e6961e9bbef826e6ee9c 100644 --- a/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php +++ b/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php @@ -12,6 +12,8 @@ use Magento\Catalog\Model\Product\ProductList\Toolbar as ToolbarModel; * Product list toolbar * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Toolbar extends \Magento\Framework\View\Element\Template { diff --git a/app/code/Magento/Catalog/Block/Product/ProductList/Upsell.php b/app/code/Magento/Catalog/Block/Product/ProductList/Upsell.php index 47246f8f3a84dc665d88f19c820eb41630d6c197..55aceddbe44e740185dc26966fb8282ebd70a4f8 100644 --- a/app/code/Magento/Catalog/Block/Product/ProductList/Upsell.php +++ b/app/code/Magento/Catalog/Block/Product/ProductList/Upsell.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Block\Product\ProductList; use Magento\Catalog\Model\Resource\Product\Collection; diff --git a/app/code/Magento/Catalog/Block/Product/View.php b/app/code/Magento/Catalog/Block/Product/View.php index 09108d7c2a840bd0b7986aa0f5635ea897552382..2a5238075e225a2a10e5701938ef5348c41f0862 100644 --- a/app/code/Magento/Catalog/Block/Product/View.php +++ b/app/code/Magento/Catalog/Block/Product/View.php @@ -10,6 +10,7 @@ use Magento\Catalog\Model\Product; /** * Product View block + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class View extends AbstractProduct implements \Magento\Framework\View\Block\IdentityInterface { @@ -73,6 +74,7 @@ class View extends AbstractProduct implements \Magento\Framework\View\Block\Iden * @param \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency * @param array $data * @codingStandardsIgnoreStart + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Catalog\Block\Product\Context $context, diff --git a/app/code/Magento/Catalog/Block/Product/View/Attributes.php b/app/code/Magento/Catalog/Block/Product/View/Attributes.php index 040a1c916d1b56ef06f960aca0975bde1e3e0388..4cf183e49951943b3c324a735fb18489eca66254 100644 --- a/app/code/Magento/Catalog/Block/Product/View/Attributes.php +++ b/app/code/Magento/Catalog/Block/Product/View/Attributes.php @@ -67,6 +67,7 @@ class Attributes extends \Magento\Framework\View\Element\Template * * @param array $excludeAttr * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getAdditionalData(array $excludeAttr = []) { diff --git a/app/code/Magento/Catalog/Block/Product/View/Options/Type/Select.php b/app/code/Magento/Catalog/Block/Product/View/Options/Type/Select.php index 0efffe87ced5ae15ccdb5d1f3ce1fba8c76753cb..d2c8f141aefab185f94c06cf9d9a0b10d6dcb8fb 100644 --- a/app/code/Magento/Catalog/Block/Product/View/Options/Type/Select.php +++ b/app/code/Magento/Catalog/Block/Product/View/Options/Type/Select.php @@ -38,6 +38,9 @@ class Select extends \Magento\Catalog\Block\Product\View\Options\AbstractOptions * Return html for control element * * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getValuesHtml() { diff --git a/app/code/Magento/Catalog/Block/Product/Widget/Html/Pager.php b/app/code/Magento/Catalog/Block/Product/Widget/Html/Pager.php index 18943c0e202ec4bf435d4668e92b6278ae3dc204..7585d4e39f7b781d1aac6e5d4069980c94e52b01 100644 --- a/app/code/Magento/Catalog/Block/Product/Widget/Html/Pager.php +++ b/app/code/Magento/Catalog/Block/Product/Widget/Html/Pager.php @@ -152,6 +152,7 @@ class Pager extends \Magento\Theme\Block\Html\Pager * Return number of last page * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getLastPageNum() { diff --git a/app/code/Magento/Catalog/Block/Product/Widget/NewWidget.php b/app/code/Magento/Catalog/Block/Product/Widget/NewWidget.php index e5367387aac85bb2ccb19ef7a66ffe6e46cf9b89..e1eabc8745699639b3bb351d31c71a00d5df3176 100644 --- a/app/code/Magento/Catalog/Block/Product/Widget/NewWidget.php +++ b/app/code/Magento/Catalog/Block/Product/Widget/NewWidget.php @@ -197,6 +197,7 @@ class NewWidget extends \Magento\Catalog\Block\Product\NewProduct implements \Ma * @param string $renderZone * @param array $arguments * @return string + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getProductPriceHtml( \Magento\Catalog\Model\Product $product, diff --git a/app/code/Magento/Catalog/Block/Rss/Category.php b/app/code/Magento/Catalog/Block/Rss/Category.php index bb3e7e9817001eeebf2909cf60c1efd784e1e78e..aa9048ae51fe0a0828cc388abc9eb26b7feba00b 100644 --- a/app/code/Magento/Catalog/Block/Rss/Category.php +++ b/app/code/Magento/Catalog/Block/Rss/Category.php @@ -12,6 +12,7 @@ use Magento\Framework\Exception\NoSuchEntityException; /** * Class Category * @package Magento\Catalog\Block\Rss + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Category extends \Magento\Framework\View\Element\AbstractBlock implements DataProviderInterface { @@ -61,6 +62,7 @@ class Category extends \Magento\Framework\View\Element\AbstractBlock implements * @param \Magento\Customer\Model\Session $customerSession * @param CategoryRepositoryInterface $categoryRepository * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, diff --git a/app/code/Magento/Catalog/Block/Rss/Product/Special.php b/app/code/Magento/Catalog/Block/Rss/Product/Special.php index fccd37da489770f0f9e237b3414df283253c650d..d5da4e503b8bc47df61286ae29e4c8b548043b85 100644 --- a/app/code/Magento/Catalog/Block/Rss/Product/Special.php +++ b/app/code/Magento/Catalog/Block/Rss/Product/Special.php @@ -11,6 +11,7 @@ use Magento\Framework\App\Rss\DataProviderInterface; /** * Class Special * @package Magento\Catalog\Block\Rss\Product + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Special extends \Magento\Framework\View\Element\AbstractBlock implements DataProviderInterface { @@ -76,6 +77,7 @@ class Special extends \Magento\Framework\View\Element\AbstractBlock implements D * @param \Magento\Framework\Stdlib\DateTime\DateFactory $dateFactory * @param \Magento\Framework\Locale\ResolverInterface $localeResolver * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, diff --git a/app/code/Magento/Catalog/Block/Widget/Link.php b/app/code/Magento/Catalog/Block/Widget/Link.php index 96423e495eb4e2006a32b40173486b0fa3ee4b19..b9910e70b769a029f53dbe3bb709ab1f14d61c56 100644 --- a/app/code/Magento/Catalog/Block/Widget/Link.php +++ b/app/code/Magento/Catalog/Block/Widget/Link.php @@ -67,6 +67,7 @@ class Link extends \Magento\Framework\View\Element\Html\Link implements \Magento * * @throws \RuntimeException * @return string|false + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getHref() { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Category/Edit.php b/app/code/Magento/Catalog/Controller/Adminhtml/Category/Edit.php index ade075d0bca684666e85ec34153f737a5728d7f9..f6b54278aa3eabc0a117ebf45ad491337a5fe39a 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Category/Edit.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Category/Edit.php @@ -39,6 +39,8 @@ class Edit extends \Magento\Catalog\Controller\Adminhtml\Category * Edit category page * * @return \Magento\Framework\Controller\ResultInterface + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Category/Save.php b/app/code/Magento/Catalog/Controller/Adminhtml/Category/Save.php index 923403a05d4c57d71b6888489eae76b5473a6494..4599a379adbc9bace4e4f1dbc2ca7277f4861994 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Category/Save.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Category/Save.php @@ -68,6 +68,9 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Category * Category save * * @return \Magento\Framework\Controller\ResultInterface + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function execute() { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product.php index 9dd74c1cf7b37daacc2e60a6b8b13c22dc1b4147..d80a02f02aa9844fddfaed047bbfdb84e3feab61 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product.php @@ -9,6 +9,7 @@ use Magento\Backend\App\Action; /** * Catalog product controller + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Product extends \Magento\Backend\App\Action { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute.php index 5f781b6f4055495ab9c645f8895839f028c9cfa9..5a1ebddaee421d4d4cdc42646e75d286a8d68940 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Controller\Adminhtml\Product\Action; use Magento\Backend\App\Action; diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/Save.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/Save.php index 676ca502bb9bd451dcb1c94bcadfab03db5554bb..ccff305f5280df1da130b00d5ce6af38332baa95 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/Save.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Action/Attribute/Save.php @@ -10,6 +10,7 @@ use Magento\Backend\App\Action; /** * Class Save + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribute { @@ -80,6 +81,9 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Action\Attribut * Update product attributes * * @return \Magento\Backend\Model\View\Result\Redirect + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function execute() { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Edit.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Edit.php index de363a251e4e7e61dce6ece55cec3443e8a6eeb2..7eee03d9f842eef0d0b3c1c3475644509c13c008 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Edit.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Edit.php @@ -39,6 +39,7 @@ class Edit extends \Magento\Catalog\Controller\Adminhtml\Product\Attribute /** * @return \Magento\Framework\Controller\ResultInterface + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Save.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Save.php index ac8b97d19e061f68dc4cfe4685b1e2e31b30c3b5..1de519b9b25b75006bef3b00bf752d2d1a65b8d9 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Save.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Save.php @@ -4,10 +4,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Controller\Adminhtml\Product\Attribute; use Magento\Catalog\Model\Product\AttributeSet\AlreadyExistsException; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Attribute { /** @@ -57,6 +63,7 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Attribute * @param \Magento\Catalog\Helper\Product $productHelper * @param \Magento\Framework\View\Result\PageFactory $resultPageFactory * @param \Magento\Backend\Model\View\Result\RedirectFactory $resultRedirectFactory + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Backend\App\Action\Context $context, @@ -83,6 +90,9 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Attribute /** * @return \Magento\Backend\Model\View\Result\Redirect + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function execute() { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php index c3f764248861ce012aa0e6f77c25cc842eecdbe0..9dbbddcee68f828b225304bea6dad7050d74c275 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php @@ -58,6 +58,8 @@ class Helper * * @param \Magento\Catalog\Model\Product $product * @return \Magento\Catalog\Model\Product + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function initialize(\Magento\Catalog\Model\Product $product) { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilter.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilter.php index 7893a9914ffd5d35764918feb474da10727c87d4..3de39b7dfb8c244db5d0abc3e05f62a9c9faa831 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilter.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilter.php @@ -45,6 +45,7 @@ class StockDataFilter * * @param array $stockData * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function filter(array $stockData) { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Save.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Save.php index ee63fba1852bb4489103c162557ba5d3a4eaccdd..a325c816d6d2fb647f4501ca3e58881a2d2f9d27 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Save.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Save.php @@ -58,6 +58,7 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product * Save product action * * @return \Magento\Backend\Model\View\Result\Redirect + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Set/Save.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Set/Save.php index b6c6fcd1940ead117294d2ecb4832f6650c45fa5..5f2aec23a62a538148673696ff7dd9339398a589 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Set/Save.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Set/Save.php @@ -63,6 +63,7 @@ class Save extends \Magento\Catalog\Controller\Adminhtml\Product\Set * [AJAX] Save attribute set data * * @return \Magento\Framework\Controller\ResultInterface + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Validate.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Validate.php index ff08a8cf3c3cb5d74fea312b28683e0087a85d37..b459ab001458a934c8eb4f6901131eb56ce62b1f 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Validate.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Validate.php @@ -58,6 +58,8 @@ class Validate extends \Magento\Catalog\Controller\Adminhtml\Product * Validate product * * @return \Magento\Framework\Controller\Result\JSON + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Catalog/Controller/Category/View.php b/app/code/Magento/Catalog/Controller/Category/View.php index 54234861d1559144cda8e166f6ecc71977ffa1ea..82f6992c1e8bbb5cdc1f0f79108a2ec35817838b 100644 --- a/app/code/Magento/Catalog/Controller/Category/View.php +++ b/app/code/Magento/Catalog/Controller/Category/View.php @@ -11,6 +11,9 @@ use Magento\Catalog\Model\Layer\Resolver; use Magento\Framework\Exception\NoSuchEntityException; use Magento\Framework\View\Result\PageFactory; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class View extends \Magento\Framework\App\Action\Action { /** @@ -135,6 +138,8 @@ class View extends \Magento\Framework\App\Action\Action * Category view action * * @return \Magento\Framework\View\Result\Page + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Catalog/Controller/Product/Compare.php b/app/code/Magento/Catalog/Controller/Product/Compare.php index 45aaaa22de207f9187356b59015ac12a6f6ac971..4e934b0685e698f5e1f179935e8ee9d2a746025a 100644 --- a/app/code/Magento/Catalog/Controller/Product/Compare.php +++ b/app/code/Magento/Catalog/Controller/Product/Compare.php @@ -14,6 +14,7 @@ use Magento\Framework\View\Result\PageFactory; * Catalog compare controller * * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Compare extends \Magento\Framework\App\Action\Action { @@ -106,6 +107,7 @@ class Compare extends \Magento\Framework\App\Action\Action * @param \Magento\Framework\Controller\Result\RedirectFactory $resultRedirectFactory * @param \Magento\Framework\View\Result\PageFactory $resultPageFactory * @param ProductRepositoryInterface $productRepository + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Action\Context $context, diff --git a/app/code/Magento/Catalog/Controller/Product/Compare/Index.php b/app/code/Magento/Catalog/Controller/Product/Compare/Index.php index 78da553d5a9bb5e244ec2663d27a6afb32b00e79..aa311afa1c33047eeed43400001bf7096242e366 100644 --- a/app/code/Magento/Catalog/Controller/Product/Compare/Index.php +++ b/app/code/Magento/Catalog/Controller/Product/Compare/Index.php @@ -11,6 +11,9 @@ use Magento\Core\App\Action\FormKeyValidator; use Magento\Framework\Controller\Result; use Magento\Framework\View\Result\PageFactory; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Index extends \Magento\Catalog\Controller\Product\Compare { /** diff --git a/app/code/Magento/Catalog/Helper/Data.php b/app/code/Magento/Catalog/Helper/Data.php index 99027a495d868fa29a1a300a7fff8ce303a70fe1..4609524bd509b1d0e3f7823bae87d56190b94f93 100644 --- a/app/code/Magento/Catalog/Helper/Data.php +++ b/app/code/Magento/Catalog/Helper/Data.php @@ -15,6 +15,8 @@ use Magento\Tax\Model\Config; /** * Catalog data helper + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Data extends \Magento\Framework\App\Helper\AbstractHelper { @@ -184,6 +186,7 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * @param PriceCurrencyInterface $priceCurrency * @param ProductRepositoryInterface $productRepository * @param CategoryRepositoryInterface $categoryRepository + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Helper\Context $context, @@ -464,6 +467,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * @param bool $priceIncludesTax flag what price parameter contain tax * @param bool $roundPrice * @return float + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getTaxPrice( $product, diff --git a/app/code/Magento/Catalog/Helper/Image.php b/app/code/Magento/Catalog/Helper/Image.php index d8ab47819fec6f8f10d950349e7ca15758a6ba02..add8bd324ce9582fca7e33bbd480f9c6fdf24200 100644 --- a/app/code/Magento/Catalog/Helper/Image.php +++ b/app/code/Magento/Catalog/Helper/Image.php @@ -249,6 +249,7 @@ class Image extends AbstractHelper * @param bool $flag * @param string[] $position * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function keepFrame($flag, $position = ['center', 'middle']) { @@ -267,6 +268,7 @@ class Image extends AbstractHelper * @param bool $flag * @param int $alphaOpacity * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function keepTransparency($flag, $alphaOpacity = null) { diff --git a/app/code/Magento/Catalog/Helper/Output.php b/app/code/Magento/Catalog/Helper/Output.php index 990604192b14dffc4346d325083f7e1a29831a2f..c509c1d752e5fb22830546e1256a23ed363b63d6 100644 --- a/app/code/Magento/Catalog/Helper/Output.php +++ b/app/code/Magento/Catalog/Helper/Output.php @@ -133,6 +133,7 @@ class Output extends \Magento\Framework\App\Helper\AbstractHelper * @param string $attributeHtml * @param string $attributeName * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function productAttribute($product, $attributeHtml, $attributeName) { diff --git a/app/code/Magento/Catalog/Helper/Product.php b/app/code/Magento/Catalog/Helper/Product.php index e622df9bf617d21bbfd9bb29619065ebf629bd56..5adf09c4ce778090bee50b4bb65bc1351a14a355 100644 --- a/app/code/Magento/Catalog/Helper/Product.php +++ b/app/code/Magento/Catalog/Helper/Product.php @@ -13,6 +13,7 @@ use Magento\Store\Model\Store; /** * Catalog category helper + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Product extends \Magento\Core\Helper\Url { @@ -110,6 +111,7 @@ class Product extends \Magento\Core\Helper\Url * @param array $reindexPriceIndexerData * @param ProductRepositoryInterface $productRepository * @param CategoryRepositoryInterface $categoryRepository + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Helper\Context $context, @@ -246,6 +248,7 @@ class Product extends \Magento\Core\Helper\Url * * @param ModelProduct|\Magento\Framework\Object $product * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getThumbnailUrl($product) { @@ -284,6 +287,7 @@ class Product extends \Magento\Core\Helper\Url * @param ModelProduct|int $product * @param string $where * @return boolean + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function canShow($product, $where = 'catalog') { @@ -385,6 +389,8 @@ class Product extends \Magento\Core\Helper\Url * @param \Magento\Framework\Object $params * * @return false|ModelProduct + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function initProduct($productId, $controller, $params = null) { @@ -538,6 +544,7 @@ class Product extends \Magento\Core\Helper\Url * Get flag that shows if Magento has to check product to be saleable (enabled and/or inStock) * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getSkipSaleableCheck() { diff --git a/app/code/Magento/Catalog/Helper/Product/Compare.php b/app/code/Magento/Catalog/Helper/Product/Compare.php index 62fbee193ce0f18d39630f50691fcb7de1985f06..469c47e77d539d84ed4bf04ceed27f4539fbf877 100644 --- a/app/code/Magento/Catalog/Helper/Product/Compare.php +++ b/app/code/Magento/Catalog/Helper/Product/Compare.php @@ -12,6 +12,7 @@ use Magento\Catalog\Model\Resource\Product\Compare\Item\Collection; * Catalog Product Compare Helper * * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Compare extends \Magento\Core\Helper\Url { @@ -104,6 +105,7 @@ class Compare extends \Magento\Core\Helper\Url * @param \Magento\Framework\Data\Form\FormKey $formKey * @param \Magento\Wishlist\Helper\Data $wishlistHelper * @param \Magento\Core\Helper\PostData $coreHelper + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Helper\Context $context, @@ -357,6 +359,7 @@ class Compare extends \Magento\Core\Helper\Url * Retrieve is allow used flat (for collection) * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getAllowUsedFlat() { diff --git a/app/code/Magento/Catalog/Helper/Product/Composite.php b/app/code/Magento/Catalog/Helper/Product/Composite.php index fb7b67d24fed5627580b8d62011a79ce956ef702..cb29ce5f7e883e06476a3695359540eae2f65090 100644 --- a/app/code/Magento/Catalog/Helper/Product/Composite.php +++ b/app/code/Magento/Catalog/Helper/Product/Composite.php @@ -19,6 +19,7 @@ use Magento\Framework\Registry; * Adminhtml catalog product composite helper * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Composite extends \Magento\Framework\App\Helper\AbstractHelper { diff --git a/app/code/Magento/Catalog/Helper/Product/Configuration.php b/app/code/Magento/Catalog/Helper/Product/Configuration.php index c356d77c5e54bb87efde664ca0111020272fa939..2018d7d2f8ec9885463842f442f88d6f1072d2c3 100644 --- a/app/code/Magento/Catalog/Helper/Product/Configuration.php +++ b/app/code/Magento/Catalog/Helper/Product/Configuration.php @@ -145,6 +145,8 @@ class Configuration extends AbstractHelper implements ConfigurationInterface * - 'cutReplacer': replacer for cut off value part when option value exceeds maxLength * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getFormattedOptionValue($optionValue, $params = null) { diff --git a/app/code/Magento/Catalog/Helper/Product/Edit/Action/Attribute.php b/app/code/Magento/Catalog/Helper/Product/Edit/Action/Attribute.php index 9448849b95aa260672072dcbd3b5a98a336ded4b..add782fd4d41e654d853cf0cf47037d094ffd395 100644 --- a/app/code/Magento/Catalog/Helper/Product/Edit/Action/Attribute.php +++ b/app/code/Magento/Catalog/Helper/Product/Edit/Action/Attribute.php @@ -11,6 +11,7 @@ namespace Magento\Catalog\Helper\Product\Edit\Action; /** * Class Attribute + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Attribute extends \Magento\Backend\Helper\Data { @@ -67,6 +68,7 @@ class Attribute extends \Magento\Backend\Helper\Data * @param \Magento\Backend\Model\Session $session * @param \Magento\Catalog\Model\Resource\Product\CollectionFactory $productsFactory * @param \Magento\Store\Model\StoreManagerInterface $storeManager + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Helper\Context $context, diff --git a/app/code/Magento/Catalog/Helper/Product/Flat/Indexer.php b/app/code/Magento/Catalog/Helper/Product/Flat/Indexer.php index 6ea99cb96b1af11ba9374391aa331708e342abf8..27d3d25fa89dc22eb08245e7a9dcdd227d99b94d 100644 --- a/app/code/Magento/Catalog/Helper/Product/Flat/Indexer.php +++ b/app/code/Magento/Catalog/Helper/Product/Flat/Indexer.php @@ -8,6 +8,8 @@ namespace Magento\Catalog\Helper\Product\Flat; /** * Catalog Product Flat Indexer Helper * + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Indexer extends \Magento\Framework\App\Helper\AbstractHelper { @@ -130,6 +132,7 @@ class Indexer extends \Magento\Framework\App\Helper\AbstractHelper * @param bool $addFilterableAttrs * @param bool $addChildData * @param array $flatAttributeGroups + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Helper\Context $context, diff --git a/app/code/Magento/Catalog/Helper/Product/ProductList.php b/app/code/Magento/Catalog/Helper/Product/ProductList.php index 5161aaa717c236862eb7ac77f7296580a44b629d..f298f7b940f79e14800711da955b83c3071eb3c6 100644 --- a/app/code/Magento/Catalog/Helper/Product/ProductList.php +++ b/app/code/Magento/Catalog/Helper/Product/ProductList.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Helper\Product; /** diff --git a/app/code/Magento/Catalog/Helper/Product/View.php b/app/code/Magento/Catalog/Helper/Product/View.php index 6360c56c71fb748fb5fcec2c1de0539889b570f8..18f48f0521c9cee617daea82d8a2fe79a09ef7fe 100644 --- a/app/code/Magento/Catalog/Helper/Product/View.php +++ b/app/code/Magento/Catalog/Helper/Product/View.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Helper\Product; use Magento\Framework\View\Result\Page as ResultPage; @@ -102,6 +104,8 @@ class View extends \Magento\Framework\App\Helper\AbstractHelper * @param \Magento\Catalog\Model\Product $product * @param null|\Magento\Framework\Object $params * @return \Magento\Catalog\Helper\Product\View + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function initProductLayout(ResultPage $resultPage, $product, $params = null) { diff --git a/app/code/Magento/Catalog/Model/AbstractModel.php b/app/code/Magento/Catalog/Model/AbstractModel.php index 2559e15926b376d257c4a65e3db773d38a4ac5e4..5694254c627ca971b8d27e7e39ab3d324e4afea6 100644 --- a/app/code/Magento/Catalog/Model/AbstractModel.php +++ b/app/code/Magento/Catalog/Model/AbstractModel.php @@ -313,6 +313,7 @@ abstract class AbstractModel extends \Magento\Framework\Model\AbstractExtensible * * @param string $attributeCode * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getExistsStoreValueFlag($attributeCode) { diff --git a/app/code/Magento/Catalog/Model/App/Action/ContextPlugin.php b/app/code/Magento/Catalog/Model/App/Action/ContextPlugin.php index 797528fe53a8eeebaf1e6f21bf499a52eee6aac5..5006b8fdb84bba61b70cff5cd0079f11e6462bd5 100644 --- a/app/code/Magento/Catalog/Model/App/Action/ContextPlugin.php +++ b/app/code/Magento/Catalog/Model/App/Action/ContextPlugin.php @@ -48,6 +48,7 @@ class ContextPlugin * @param callable $proceed * @param \Magento\Framework\App\RequestInterface $request * @return mixed + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aroundDispatch( \Magento\Framework\App\Action\Action $subject, diff --git a/app/code/Magento/Catalog/Model/Category.php b/app/code/Magento/Catalog/Model/Category.php index de16d5850c0a95702afaa1ff59c94a531cd6e5f1..214cb33195bcbdba9fb4c5b302e38918d5b1f96c 100644 --- a/app/code/Magento/Catalog/Model/Category.php +++ b/app/code/Magento/Catalog/Model/Category.php @@ -27,6 +27,10 @@ use Magento\UrlRewrite\Service\V1\Data\UrlRewrite; * @method Category setUrlPath(string $urlPath) * * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Category extends \Magento\Catalog\Model\AbstractModel implements \Magento\Framework\Object\IdentityInterface, @@ -190,6 +194,7 @@ class Category extends \Magento\Catalog\Model\AbstractModel implements * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -257,6 +262,7 @@ class Category extends \Magento\Catalog\Model\AbstractModel implements * Get flat resource model flag * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseFlatResource() { @@ -408,6 +414,7 @@ class Category extends \Magento\Catalog\Model\AbstractModel implements * @param bool $noDesignAttributes * @return array * @todo Use with Flat Resource + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getAttributes($noDesignAttributes = false) { @@ -1093,6 +1100,7 @@ class Category extends \Magento\Catalog\Model\AbstractModel implements /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsActive() { diff --git a/app/code/Magento/Catalog/Model/Category/Attribute/Backend/Sortby.php b/app/code/Magento/Catalog/Model/Category/Attribute/Backend/Sortby.php index 8b0d73753f71e4ebd0ef72c959a4f99706205cc7..c1d07fc693ab29467a3765b2d30f9d5fb9b50a22 100644 --- a/app/code/Magento/Catalog/Model/Category/Attribute/Backend/Sortby.php +++ b/app/code/Magento/Catalog/Model/Category/Attribute/Backend/Sortby.php @@ -35,6 +35,8 @@ class Sortby extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend * @param \Magento\Framework\Object $object * @return bool * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validate($object) { diff --git a/app/code/Magento/Catalog/Model/Config.php b/app/code/Magento/Catalog/Model/Config.php index a2015639d17a8ace900e588cf990ff9c34427226..8cbdb43ad337b980023575b93070cdcb929ca8a0 100644 --- a/app/code/Magento/Catalog/Model/Config.php +++ b/app/code/Magento/Catalog/Model/Config.php @@ -3,10 +3,15 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model; /** * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Config extends \Magento\Eav\Model\Config { diff --git a/app/code/Magento/Catalog/Model/Entity/Attribute.php b/app/code/Magento/Catalog/Model/Entity/Attribute.php index e5fc53eee22cb751b7a422b9db44d74c7fecd835..fa8019fc6298c1d2f4d9a546f983e3eee6a05e6e 100644 --- a/app/code/Magento/Catalog/Model/Entity/Attribute.php +++ b/app/code/Magento/Catalog/Model/Entity/Attribute.php @@ -43,6 +43,7 @@ use Magento\Framework\Api\AttributeDataBuilder; * @method \Magento\Catalog\Model\Entity\Attribute setIsWysiwygEnabled(int $value) * @method int getIsUsedForPromoRules() * @method \Magento\Catalog\Model\Entity\Attribute setIsUsedForPromoRules(int $value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Attribute extends \Magento\Eav\Model\Entity\Attribute { @@ -86,6 +87,7 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Catalog/Model/Factory.php b/app/code/Magento/Catalog/Model/Factory.php index 4140789849772016f9439c1d34fb6bed4b4506fa..55add909d9f8542506d3afeb6edbca40eb779134 100644 --- a/app/code/Magento/Catalog/Model/Factory.php +++ b/app/code/Magento/Catalog/Model/Factory.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Model factory */ diff --git a/app/code/Magento/Catalog/Model/Indexer/Category/AffectCache.php b/app/code/Magento/Catalog/Model/Indexer/Category/AffectCache.php index 63c5da5aeafb46b7e1821f991a7384f15baaf742..124424648050de9216a216c51ed877de2a96bd16 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Category/AffectCache.php +++ b/app/code/Magento/Catalog/Model/Indexer/Category/AffectCache.php @@ -29,6 +29,7 @@ class AffectCache * @param \Magento\Indexer\Model\ActionInterface $subject * @param array $ids * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function beforeExecute(\Magento\Indexer\Model\ActionInterface $subject, $ids) { diff --git a/app/code/Magento/Catalog/Model/Indexer/Category/Flat/AbstractAction.php b/app/code/Magento/Catalog/Model/Indexer/Category/Flat/AbstractAction.php index 0ad27cfd659d0fddc229a555e7e0763e2beffa05..9fba6a8ae96707b844aac77f2f95a1eea1394cec 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Category/Flat/AbstractAction.php +++ b/app/code/Magento/Catalog/Model/Indexer/Category/Flat/AbstractAction.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Category\Flat; class AbstractAction @@ -186,6 +189,7 @@ class AbstractAction * Return array of static columns * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function getStaticColumns() { diff --git a/app/code/Magento/Catalog/Model/Indexer/Category/Product/AbstractAction.php b/app/code/Magento/Catalog/Model/Indexer/Category/Product/AbstractAction.php index 0b6478356257c094c5628db819d1b698d36efeb8..fc76af0a7552bf05631cf973bf868445252b0ef6 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Category/Product/AbstractAction.php +++ b/app/code/Magento/Catalog/Model/Indexer/Category/Product/AbstractAction.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Category\Product; abstract class AbstractAction diff --git a/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/IndexerState.php b/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/IndexerState.php index 0e45e6680e3487c5f5bfddfd07a24d438d1cb7f3..019d27e4bead31f68793f7ea11851889afe45787 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/IndexerState.php +++ b/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/IndexerState.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Category\Product\Plugin; class IndexerState diff --git a/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/MviewState.php b/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/MviewState.php index f2cbf9b29888b2ce2b7945f397c1f82467354206..ccfde503a9d9099be57de7c539ad50ada96582ba 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/MviewState.php +++ b/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/MviewState.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Category\Product\Plugin; class MviewState diff --git a/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/StoreGroup.php b/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/StoreGroup.php index 684e815cf31cb41ac8c7110f641006dbafb68752..ef9def13549270f2eb72db01f47d370be1cc574f 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/StoreGroup.php +++ b/app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/StoreGroup.php @@ -23,6 +23,7 @@ class StoreGroup * @param callable $proceed * @param \Magento\Framework\Model\AbstractModel $group * @return mixed + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aroundSave( \Magento\Framework\Model\Resource\Db\AbstractDb $subject, diff --git a/app/code/Magento/Catalog/Model/Indexer/Product/AffectCache.php b/app/code/Magento/Catalog/Model/Indexer/Product/AffectCache.php index 35e4d36b8caab2e70f3f33132d08c17f2fedaff7..5e997400ec23e0725b745c0f0b359d92e9ccdfe4 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Product/AffectCache.php +++ b/app/code/Magento/Catalog/Model/Indexer/Product/AffectCache.php @@ -29,6 +29,7 @@ class AffectCache * @param \Magento\Indexer\Model\ActionInterface $subject * @param array $ids * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function beforeExecute(\Magento\Indexer\Model\ActionInterface $subject, $ids) { diff --git a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/AbstractAction.php b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/AbstractAction.php index 181a5901b8abdda155f53e9626f8b4f62faf583d..c160e95db9b1f1836852dee34755e80b93bb6ea0 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/AbstractAction.php +++ b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/AbstractAction.php @@ -118,6 +118,7 @@ abstract class AbstractAction * @param array $tablesList * @param int|string $storeId * @return void + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _cleanOnFailure(array $tablesList, $storeId) { @@ -183,6 +184,7 @@ abstract class AbstractAction * @param int $storeId * @param int|array $productIds Update child product(s) only * @return \Magento\Catalog\Model\Indexer\Product\Flat\AbstractAction + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _updateRelationProducts($storeId, $productIds = null) { diff --git a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Indexer.php b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Indexer.php index 6da2dceeeb1462a9c47cab8bb3d50330c6eba0b5..383fab299e86f0d43b425b873baa8a4317b5ebe3 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Indexer.php +++ b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Indexer.php @@ -41,6 +41,8 @@ class Indexer * @param int $productId * @param string $valueFieldSuffix * @return \Magento\Catalog\Model\Indexer\Product\Flat + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function write($storeId, $productId, $valueFieldSuffix = '') { diff --git a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/FlatTableBuilder.php b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/FlatTableBuilder.php index c0253fb24a80c8cbe4f9196e157c21fb3cc989f2..3c5fd37274111d25ad407d87d5b42528f811ee71 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/FlatTableBuilder.php +++ b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/FlatTableBuilder.php @@ -98,6 +98,8 @@ class FlatTableBuilder * @param int|string $storeId * @return void * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _createTemporaryFlatTable($storeId) { diff --git a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Plugin/Store.php b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Plugin/Store.php index e4b3ea3eb0b9b36fae8bc6fe2845879ea3160a38..781cb92d83a77702211b7e62d79a04ef230f8634 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Plugin/Store.php +++ b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Plugin/Store.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Product\Flat\Plugin; class Store diff --git a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Plugin/StoreGroup.php b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Plugin/StoreGroup.php index eba0f5ade8c9f55fee1e7ff9f558e47b3aaf23b1..7e59098153d5213d986643437a0f53de66e72458 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Plugin/StoreGroup.php +++ b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Plugin/StoreGroup.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Product\Flat\Plugin; class StoreGroup diff --git a/app/code/Magento/Catalog/Model/Indexer/Product/Price/AbstractAction.php b/app/code/Magento/Catalog/Model/Indexer/Product/Price/AbstractAction.php index 3a52723a9a29e26eb61ba23b6d4a2c189d77d25c..52861a1d42adae0dc6159754e99eb1ac3f5516c9 100644 --- a/app/code/Magento/Catalog/Model/Indexer/Product/Price/AbstractAction.php +++ b/app/code/Magento/Catalog/Model/Indexer/Product/Price/AbstractAction.php @@ -8,6 +8,7 @@ namespace Magento\Catalog\Model\Indexer\Product\Price; /** * Abstract action reindex class * + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractAction { @@ -444,6 +445,7 @@ abstract class AbstractAction * * @param array $changedIds * @return array Affected ids + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _reindexRows($changedIds = []) { diff --git a/app/code/Magento/Catalog/Model/Layer.php b/app/code/Magento/Catalog/Model/Layer.php index a113728fb032347d5cddbb8de7d03f7392791873..74bcbfdf7cc843adc5172d6a3f31a0b8cf43799b 100644 --- a/app/code/Magento/Catalog/Model/Layer.php +++ b/app/code/Magento/Catalog/Model/Layer.php @@ -12,6 +12,7 @@ use Magento\Framework\Exception\NoSuchEntityException; * Catalog view layer model * * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Layer extends \Magento\Framework\Object { diff --git a/app/code/Magento/Catalog/Model/Layer/Filter/Dynamic/AlgorithmFactory.php b/app/code/Magento/Catalog/Model/Layer/Filter/Dynamic/AlgorithmFactory.php index 200f73de1b49a94384a7f05a9199012697cab68d..d86b8220296bf9842d1d601426bb4516ecb8c2e1 100644 --- a/app/code/Magento/Catalog/Model/Layer/Filter/Dynamic/AlgorithmFactory.php +++ b/app/code/Magento/Catalog/Model/Layer/Filter/Dynamic/AlgorithmFactory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Layer\Filter\Dynamic; use Magento\Framework\App\Config\ScopeConfigInterface; diff --git a/app/code/Magento/Catalog/Model/Layer/Filter/Dynamic/Auto.php b/app/code/Magento/Catalog/Model/Layer/Filter/Dynamic/Auto.php index 1f62c1c6de6103a437f27de185a3c55f722306ad..627c5dabb80bdb0e4b8c3ed1dd249306c7473ac8 100644 --- a/app/code/Magento/Catalog/Model/Layer/Filter/Dynamic/Auto.php +++ b/app/code/Magento/Catalog/Model/Layer/Filter/Dynamic/Auto.php @@ -13,6 +13,9 @@ use Magento\Framework\App\Config\ScopeConfigInterface; use Magento\Framework\Registry; use Magento\Framework\Search\Dynamic\Algorithm; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Auto implements AlgorithmInterface { const MIN_RANGE_POWER = 10; diff --git a/app/code/Magento/Catalog/Model/Layer/Filter/Item.php b/app/code/Magento/Catalog/Model/Layer/Filter/Item.php index 3fac2f8d64387585a75a18f14762964e4bad2f8a..367f58f8ba501c536e9037e84ead680dcfad2d73 100644 --- a/app/code/Magento/Catalog/Model/Layer/Filter/Item.php +++ b/app/code/Magento/Catalog/Model/Layer/Filter/Item.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Filter item model * diff --git a/app/code/Magento/Catalog/Model/Layer/Filter/Price.php b/app/code/Magento/Catalog/Model/Layer/Filter/Price.php index 7183b9287b539d4e2e4eada8c66d88fe011e769c..8db29096c2852391fd4176473d167bed41eaae7a 100644 --- a/app/code/Magento/Catalog/Model/Layer/Filter/Price.php +++ b/app/code/Magento/Catalog/Model/Layer/Filter/Price.php @@ -3,12 +3,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Layer\Filter; /** * Layer price filter * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Price extends \Magento\Catalog\Model\Layer\Filter\AbstractFilter { @@ -70,6 +74,7 @@ class Price extends \Magento\Catalog\Model\Layer\Filter\AbstractFilter * @param Dynamic\AlgorithmFactory $algorithmFactory * @param DataProvider\PriceFactory $dataProviderFactory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Catalog\Model\Layer\Filter\ItemFactory $filterItemFactory, diff --git a/app/code/Magento/Catalog/Model/Product.php b/app/code/Magento/Catalog/Model/Product.php index 40a973f14949d90c38d2ba800f15cfdb507db7b9..8d7b4d3c726614631c10a4f2893ad99317995e4e 100644 --- a/app/code/Magento/Catalog/Model/Product.php +++ b/app/code/Magento/Catalog/Model/Product.php @@ -29,6 +29,10 @@ use Magento\Framework\Pricing\Object\SaleableInterface; * @method Product setRequestPath(string $requestPath) * * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Product extends \Magento\Catalog\Model\AbstractModel implements IdentityInterface, @@ -640,6 +644,7 @@ class Product extends \Magento\Catalog\Model\AbstractModel implements * @param int $groupId Retrieve attributes of the specified group * @param bool $skipSuper Not used * @return \Magento\Eav\Model\Entity\Attribute\AbstractAttribute[] + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getAttributes($groupId = null, $skipSuper = false) { @@ -662,6 +667,7 @@ class Product extends \Magento\Catalog\Model\AbstractModel implements * Check product options and type options and save them, too * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function beforeSave() { @@ -1395,6 +1401,7 @@ class Product extends \Magento\Catalog\Model\AbstractModel implements * Is product salable detecting by product type * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsSalable() { @@ -1681,6 +1688,7 @@ class Product extends \Magento\Catalog\Model\AbstractModel implements * Retrieve is a virtual product * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsVirtual() { diff --git a/app/code/Magento/Catalog/Model/Product/Action.php b/app/code/Magento/Catalog/Model/Product/Action.php index d2447816e1d8c4561a55f2b097a29a95ca028bb6..5f86ef87a78997cb0d928c24782aae85380f5799 100644 --- a/app/code/Magento/Catalog/Model/Product/Action.php +++ b/app/code/Magento/Catalog/Model/Product/Action.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product; /** @@ -117,6 +120,7 @@ class Action extends \Magento\Framework\Model\AbstractModel * * @param array $attributesData * @return bool + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _hasIndexableAttributes($attributesData) { diff --git a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/GroupPrice/AbstractGroupPrice.php b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/GroupPrice/AbstractGroupPrice.php index fd074e4485b926c53c2ef096a3379f49c2899c5e..6aeacc7c2cd91303fe0b10414ba7e63a4b7e4a19 100644 --- a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/GroupPrice/AbstractGroupPrice.php +++ b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/GroupPrice/AbstractGroupPrice.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product\Attribute\Backend\GroupPrice; use Magento\Catalog\Model\Product\Attribute\Backend\Price; @@ -109,6 +112,7 @@ abstract class AbstractGroupPrice extends Price * * @param array $objectArray * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _getAdditionalUniqueFields($objectArray) { @@ -132,6 +136,8 @@ abstract class AbstractGroupPrice extends Price * @param \Magento\Catalog\Model\Product $object * @throws \Magento\Framework\Model\Exception * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validate($object) { @@ -284,6 +290,9 @@ abstract class AbstractGroupPrice extends Price * * @param \Magento\Catalog\Model\Product $object * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function afterSave($object) { diff --git a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Media.php b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Media.php index 19333586273f2b6a0d5d20f23c055ae5a1e95672..f8d053035fe87cec28091745d85cfb05a39d9bfc 100644 --- a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Media.php +++ b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Media.php @@ -14,6 +14,10 @@ namespace Magento\Catalog\Model\Product\Attribute\Backend; use Magento\Framework\App\Filesystem\DirectoryList; use Magento\Framework\Model\Exception; +/** + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Media extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend { /** @@ -164,6 +168,8 @@ class Media extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend /** * @param \Magento\Framework\Object $object * @return $this|void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function beforeSave($object) { @@ -254,6 +260,8 @@ class Media extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend /** * @param \Magento\Framework\Object $object * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function afterSave($object) { @@ -347,6 +355,8 @@ class Media extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend * @param boolean $exclude mark image as disabled in product page view * @return string * @throws Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function addImage( \Magento\Catalog\Model\Product $product, diff --git a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Price.php b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Price.php index 45e9dac9eba4b624b8a9f0e54ad04136d6d45520..79b2b1b752ad9a6cd367e5eeba0df8e06cea13f5 100644 --- a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Price.php +++ b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Price.php @@ -96,6 +96,7 @@ class Price extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBackend * * @param \Magento\Catalog\Model\Product $object * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function afterSave($object) { diff --git a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Sku.php b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Sku.php index a0afc031fbf24c1b9909e7ae48dc2ab6fb967b0d..728cd250923fee5d7616e9958052d654a219f9f1 100644 --- a/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Sku.php +++ b/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Sku.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Catalog product SKU backend attribute model * diff --git a/app/code/Magento/Catalog/Model/Product/Attribute/Repository.php b/app/code/Magento/Catalog/Model/Product/Attribute/Repository.php index faaf5645680ae0e5c6fde4e07a2524cfc183bddd..86548f86dd1a2a812f4e2ec5e45fc4dea4af5924 100644 --- a/app/code/Magento/Catalog/Model/Product/Attribute/Repository.php +++ b/app/code/Magento/Catalog/Model/Product/Attribute/Repository.php @@ -9,6 +9,9 @@ namespace Magento\Catalog\Model\Product\Attribute; use Magento\Framework\Exception\InputException; use Magento\Framework\Exception\NoSuchEntityException; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Repository implements \Magento\Catalog\Api\ProductAttributeRepositoryInterface { /** @@ -72,6 +75,7 @@ class Repository implements \Magento\Catalog\Api\ProductAttributeRepositoryInter * @param \Magento\Framework\Api\Config\MetadataConfig $metadataConfig * @param \Magento\Framework\Api\SearchCriteriaDataBuilder $searchCriteriaBuilder * @param \Magento\Framework\Api\FilterBuilder $filterBuilder + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Catalog\Model\Resource\Attribute $attributeResource, @@ -121,6 +125,8 @@ class Repository implements \Magento\Catalog\Api\ProductAttributeRepositoryInter /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function save(\Magento\Catalog\Api\Data\ProductAttributeInterface $attribute) { diff --git a/app/code/Magento/Catalog/Model/Product/Attribute/Source/Inputtype.php b/app/code/Magento/Catalog/Model/Product/Attribute/Source/Inputtype.php index aec2983c06c1858f16d091ed194b55672031134a..769a2aeb5a832cd27ffacffbaa6d4512468e5c1b 100644 --- a/app/code/Magento/Catalog/Model/Product/Attribute/Source/Inputtype.php +++ b/app/code/Magento/Catalog/Model/Product/Attribute/Source/Inputtype.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Product attribute source input types */ @@ -39,6 +41,7 @@ class Inputtype extends \Magento\Eav\Model\Adminhtml\System\Config\Source\Inputt * Get product input types as option array * * @return array + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function toOptionArray() { diff --git a/app/code/Magento/Catalog/Model/Product/Compare/Item.php b/app/code/Magento/Catalog/Model/Product/Compare/Item.php index 5f52479c57cb635801dc9cfb8dc5d6114e1762f0..b488f1d02e0bdba0c9530c720e48737e1d1c6775 100644 --- a/app/code/Magento/Catalog/Model/Product/Compare/Item.php +++ b/app/code/Magento/Catalog/Model/Product/Compare/Item.php @@ -207,6 +207,7 @@ class Item extends \Magento\Framework\Model\AbstractModel implements \Magento\Fr * * @param \Magento\Framework\Event\Observer $observer * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function bindCustomerLogout(\Magento\Framework\Event\Observer $observer = null) { diff --git a/app/code/Magento/Catalog/Model/Product/Gallery/Entry.php b/app/code/Magento/Catalog/Model/Product/Gallery/Entry.php index 8b1fa1b3cab4c0e7a75986f55911ca5187f16cba..31a9d3963e2a47ec5e88704721929127f3e3cb78 100644 --- a/app/code/Magento/Catalog/Model/Product/Gallery/Entry.php +++ b/app/code/Magento/Catalog/Model/Product/Gallery/Entry.php @@ -46,6 +46,7 @@ class Entry extends \Magento\Framework\Model\AbstractExtensibleModel implements * Check if gallery entry is hidden from product page * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsDisabled() { diff --git a/app/code/Magento/Catalog/Model/Product/Gallery/GalleryManagement.php b/app/code/Magento/Catalog/Model/Product/Gallery/GalleryManagement.php index 89d0257b95967bf5c0b954fcfa333118b1124f01..bedbdec0d88602a8f4952b918d718ba7b7dab307 100644 --- a/app/code/Magento/Catalog/Model/Product/Gallery/GalleryManagement.php +++ b/app/code/Magento/Catalog/Model/Product/Gallery/GalleryManagement.php @@ -15,6 +15,9 @@ use Magento\Framework\Exception\NoSuchEntityException; use Magento\Framework\Exception\StateException; use Magento\Framework\App\Filesystem\DirectoryList; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class GalleryManagement implements \Magento\Catalog\Api\ProductAttributeMediaGalleryManagementInterface { /** diff --git a/app/code/Magento/Catalog/Model/Product/GroupPriceManagement.php b/app/code/Magento/Catalog/Model/Product/GroupPriceManagement.php index 41625fdb8c68980fdbb2e4f4647580dfd065c339..63b9a377bf952399c38fca3a93a25363eb73d8f5 100644 --- a/app/code/Magento/Catalog/Model/Product/GroupPriceManagement.php +++ b/app/code/Magento/Catalog/Model/Product/GroupPriceManagement.php @@ -69,6 +69,8 @@ class GroupPriceManagement implements \Magento\Catalog\Api\ProductGroupPriceMana /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function add($productSku, $customerGroupId, $price) { diff --git a/app/code/Magento/Catalog/Model/Product/Image.php b/app/code/Magento/Catalog/Model/Product/Image.php index 59f34349b8dd2ee4a945b2ef34cd3b727a6f3004..d133d26599e35211382ef682503cb6efd0d1307c 100644 --- a/app/code/Magento/Catalog/Model/Product/Image.php +++ b/app/code/Magento/Catalog/Model/Product/Image.php @@ -15,6 +15,11 @@ use Magento\Framework\App\Filesystem\DirectoryList; use Magento\Framework\Image as MagentoImage; use Magento\Store\Model\Store; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Image extends \Magento\Framework\Model\AbstractModel { /** @@ -174,6 +179,8 @@ class Image extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -381,6 +388,7 @@ class Image extends \Magento\Framework\Model\AbstractModel /** * @param string|null $file * @return float|int + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getNeedMemoryForFile($file = null) { @@ -436,6 +444,8 @@ class Image extends \Magento\Framework\Model\AbstractModel * @param string $file * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function setBaseFile($file) { @@ -611,6 +621,7 @@ class Image extends \Magento\Framework\Model\AbstractModel * @param int $height * @param int $opacity * @return $this + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function setWatermark( $file, diff --git a/app/code/Magento/Catalog/Model/Product/Media/Config.php b/app/code/Magento/Catalog/Model/Product/Media/Config.php index 067313d3f64ca250caeceb0a6b95849bc7d66847..55b22c509a9450c8296e4851d5797c1b64cf803b 100644 --- a/app/code/Magento/Catalog/Model/Product/Media/Config.php +++ b/app/code/Magento/Catalog/Model/Product/Media/Config.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product\Media; /** diff --git a/app/code/Magento/Catalog/Model/Product/Option.php b/app/code/Magento/Catalog/Model/Product/Option.php index 7582f0c38f7bb87c17d9c631036d88ed9311e275..cb57df12918acfa84ce21b88a467b349a14edf0b 100644 --- a/app/code/Magento/Catalog/Model/Product/Option.php +++ b/app/code/Magento/Catalog/Model/Product/Option.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product; use Magento\Catalog\Api\Data\ProductCustomOptionValuesInterface; @@ -22,6 +25,7 @@ use Magento\Framework\Model\Exception; * @method \Magento\Catalog\Model\Product\Option setProductId(int $value) * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Option extends AbstractExtensibleModel implements \Magento\Catalog\Api\Data\ProductCustomOptionInterface { @@ -104,6 +108,7 @@ class Option extends AbstractExtensibleModel implements \Magento\Catalog\Api\Dat * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -313,6 +318,7 @@ class Option extends AbstractExtensibleModel implements \Magento\Catalog\Api\Dat * Save options. * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function saveOptions() { @@ -626,6 +632,7 @@ class Option extends AbstractExtensibleModel implements \Magento\Catalog\Api\Dat * Get is require * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsRequire() { diff --git a/app/code/Magento/Catalog/Model/Product/Option/Type/Date.php b/app/code/Magento/Catalog/Model/Product/Option/Type/Date.php index 2765bdce22a707cda01338a7ca6f73da12b18d60..16f2ce870043191bc47bf124e8352caeac082041 100644 --- a/app/code/Magento/Catalog/Model/Product/Option/Type/Date.php +++ b/app/code/Magento/Catalog/Model/Product/Option/Type/Date.php @@ -44,6 +44,8 @@ class Date extends \Magento\Catalog\Model\Product\Option\Type\DefaultType * @param array $values All product option values, i.e. array (option_id => mixed, option_id => mixed...) * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validateUserValue($values) { @@ -117,6 +119,8 @@ class Date extends \Magento\Catalog\Model\Product\Option\Type\DefaultType * * @return string|null Prepared option value * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function prepareForCart() { @@ -175,6 +179,7 @@ class Date extends \Magento\Catalog\Model\Product\Option\Type\DefaultType * * @param string $optionValue Prepared for cart option value * @return string + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getFormattedOptionValue($optionValue) { diff --git a/app/code/Magento/Catalog/Model/Product/Option/Type/DefaultType.php b/app/code/Magento/Catalog/Model/Product/Option/Type/DefaultType.php index 6ec50cc610f9a27fdc017637e3861db01d058d76..b573c37ee059e5bed70f7b232686dbfcdc5fe891 100644 --- a/app/code/Magento/Catalog/Model/Product/Option/Type/DefaultType.php +++ b/app/code/Magento/Catalog/Model/Product/Option/Type/DefaultType.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product\Option\Type; use Magento\Framework\Model\Exception; @@ -11,6 +14,7 @@ use Magento\Framework\Model\Exception; * Catalog product option default type * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class DefaultType extends \Magento\Framework\Object { @@ -216,6 +220,7 @@ class DefaultType extends \Magento\Framework\Object * Check skip required option validation * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getSkipCheckRequiredOption() { @@ -298,6 +303,7 @@ class DefaultType extends \Magento\Framework\Object * @param string $optionValue * @param array $productOptionValues Values for product option * @return string|null + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function parseOptionValue($optionValue, $productOptionValues) { @@ -321,6 +327,7 @@ class DefaultType extends \Magento\Framework\Object * @param string $optionValue Prepared for cart option value * @param float $basePrice For percent price type * @return float + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getOptionPrice($optionValue, $basePrice) { @@ -335,6 +342,7 @@ class DefaultType extends \Magento\Framework\Object * @param string $optionValue Prepared for cart option value * @param string $skuDelimiter Delimiter for Sku parts * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getOptionSku($optionValue, $skuDelimiter) { diff --git a/app/code/Magento/Catalog/Model/Product/Option/Type/File.php b/app/code/Magento/Catalog/Model/Product/Option/Type/File.php index fdb25cdc8a5894eb800751dda71cce4c9b0c669d..2cf121a3aa25f113190302cc38b061240c10c939 100644 --- a/app/code/Magento/Catalog/Model/Product/Option/Type/File.php +++ b/app/code/Magento/Catalog/Model/Product/Option/Type/File.php @@ -12,6 +12,7 @@ use Magento\Framework\Model\Exception; * Catalog product option file type * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class File extends \Magento\Catalog\Model\Product\Option\Type\DefaultType { @@ -179,6 +180,7 @@ class File extends \Magento\Catalog\Model\Product\Option\Type\DefaultType * @param array $values All product option values, i.e. array (option_id => mixed, option_id => mixed...) * @return $this * @throws Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function validateUserValue($values) { diff --git a/app/code/Magento/Catalog/Model/Product/Option/Type/File/ValidatorFile.php b/app/code/Magento/Catalog/Model/Product/Option/Type/File/ValidatorFile.php index 36b44f9dd09a7cbc85b8d6a784e16980f1e14ce4..e53f8fd846215788c6877b17390799f527150290 100644 --- a/app/code/Magento/Catalog/Model/Product/Option/Type/File/ValidatorFile.php +++ b/app/code/Magento/Catalog/Model/Product/Option/Type/File/ValidatorFile.php @@ -9,6 +9,9 @@ namespace Magento\Catalog\Model\Product\Option\Type\File; use Magento\Catalog\Model\Product; use Magento\Framework\App\Filesystem\DirectoryList; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class ValidatorFile extends Validator { /** @@ -87,6 +90,7 @@ class ValidatorFile extends Validator * @return array * @throws \Magento\Framework\Model\Exception * @throws \Zend_File_Transfer_Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function validate($processingParams, $option) { diff --git a/app/code/Magento/Catalog/Model/Product/Option/Validator/Select.php b/app/code/Magento/Catalog/Model/Product/Option/Validator/Select.php index 62d311a008e01f71f4901a5f8e34c0c162c9f0cc..cc86a79f92b9b5cec917cceec493f9b7cb2a8a02 100644 --- a/app/code/Magento/Catalog/Model/Product/Option/Validator/Select.php +++ b/app/code/Magento/Catalog/Model/Product/Option/Validator/Select.php @@ -31,6 +31,8 @@ class Select extends DefaultValidator * * @param Option $option * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function validateOptionValue(Option $option) { diff --git a/app/code/Magento/Catalog/Model/Product/Option/Value.php b/app/code/Magento/Catalog/Model/Product/Option/Value.php index 62a8ec0be92927e20074a4ffc1c4f2c69be8e64b..c4d59f564dbdb95034a15c11bc1fcb155dbb8f13 100644 --- a/app/code/Magento/Catalog/Model/Product/Option/Value.php +++ b/app/code/Magento/Catalog/Model/Product/Option/Value.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product\Option; use Magento\Framework\Model\AbstractExtensibleModel; diff --git a/app/code/Magento/Catalog/Model/Product/PriceModifier.php b/app/code/Magento/Catalog/Model/Product/PriceModifier.php index a4b2cd7a6fca363f01e51bba6b7bebfe648f47df..56db5467cbe53959b691c05befeac43498e598c2 100644 --- a/app/code/Magento/Catalog/Model/Product/PriceModifier.php +++ b/app/code/Magento/Catalog/Model/Product/PriceModifier.php @@ -70,6 +70,7 @@ class PriceModifier * @throws \Magento\Framework\Exception\NoSuchEntityException * @throws \Magento\Framework\Exception\CouldNotSaveException * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function removeTierPrice(\Magento\Catalog\Model\Product $product, $customerGroupId, $qty, $websiteId) { diff --git a/app/code/Magento/Catalog/Model/Product/TierPriceManagement.php b/app/code/Magento/Catalog/Model/Product/TierPriceManagement.php index 6c39c1911ea2739b6e0ea4dd347f10fc6fac999f..acc29e26adb59125e24b31eac90fc5d5726f44c9 100644 --- a/app/code/Magento/Catalog/Model/Product/TierPriceManagement.php +++ b/app/code/Magento/Catalog/Model/Product/TierPriceManagement.php @@ -13,6 +13,9 @@ use Magento\Customer\Api\GroupRepositoryInterface; use Magento\Framework\Exception\CouldNotSaveException; use Magento\Framework\Exception\InputException; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class TierPriceManagement implements \Magento\Catalog\Api\ProductTierPriceManagementInterface { /** diff --git a/app/code/Magento/Catalog/Model/Product/Type/AbstractType.php b/app/code/Magento/Catalog/Model/Product/Type/AbstractType.php index 456a51e9062492b639a0d6d52cdd5982cba6aa25..a3e7fcfc6c642ff13558e1a6d73d73627f88aa02 100644 --- a/app/code/Magento/Catalog/Model/Product/Type/AbstractType.php +++ b/app/code/Magento/Catalog/Model/Product/Type/AbstractType.php @@ -10,6 +10,10 @@ use Magento\Framework\App\Filesystem\DirectoryList; /** * Abstract model for product type implementation + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractType { @@ -167,6 +171,7 @@ abstract class AbstractType * @param \Magento\Framework\Registry $coreRegistry * @param \Psr\Log\LoggerInterface $logger * @param ProductRepositoryInterface $productRepository + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Catalog\Model\Product\Option $catalogProductOption, @@ -225,6 +230,7 @@ abstract class AbstractType * @param int $parentId * @param bool $required * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getChildrenIds($parentId, $required = true) { @@ -236,6 +242,7 @@ abstract class AbstractType * * @param int|array $childId * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getParentIdsByChild($childId) { @@ -319,6 +326,7 @@ abstract class AbstractType * * @param \Magento\Catalog\Model\Product $product * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function isVirtual($product) { @@ -349,6 +357,7 @@ abstract class AbstractType * @param \Magento\Catalog\Model\Product $product * @param string $processMode * @return array|string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _prepareProduct(\Magento\Framework\Object $buyRequest, $product, $processMode) { @@ -462,6 +471,8 @@ abstract class AbstractType * * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function processFileQueue() { @@ -714,6 +725,7 @@ abstract class AbstractType * * @param \Magento\Catalog\Model\Product $product * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function isComposite($product) { @@ -725,6 +737,7 @@ abstract class AbstractType * * @param \Magento\Catalog\Model\Product $product * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function canConfigure($product) { @@ -828,6 +841,7 @@ abstract class AbstractType * @param \Magento\Catalog\Model\Product $product * * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function updateQtyOption($options, \Magento\Framework\Object $option, $value, $product) { @@ -880,6 +894,8 @@ abstract class AbstractType * * @param \Magento\Catalog\Model\Product $product * @return boolean false + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getForceChildItemQtyChanges($product) { @@ -892,6 +908,7 @@ abstract class AbstractType * @param int|float $qty * @param \Magento\Catalog\Model\Product $product * @return float + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function prepareQuoteItemQty($qty, $product) { @@ -975,6 +992,7 @@ abstract class AbstractType * @param \Magento\Catalog\Model\Product $product * @param \Magento\Framework\Object $buyRequest * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function processBuyRequest($product, $buyRequest) { @@ -1028,6 +1046,7 @@ abstract class AbstractType * * @param \Magento\Catalog\Model\Product $product * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setImageFromChildProduct(\Magento\Catalog\Model\Product $product) { @@ -1039,6 +1058,7 @@ abstract class AbstractType * * @param \Magento\Catalog\Model\Product $product * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getIdentities(\Magento\Catalog\Model\Product $product) { @@ -1048,6 +1068,7 @@ abstract class AbstractType /** * @param \Magento\Catalog\Model\Product\Type\AbstractType $product * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getAssociatedProducts($product) { diff --git a/app/code/Magento/Catalog/Model/Product/Type/Price.php b/app/code/Magento/Catalog/Model/Product/Type/Price.php index 0e16080c1fe0c25a6c98c564e7ba48d84b16eb8e..43d0e981d6e45e2b0cda05c4ee5d91b2b82cc79e 100644 --- a/app/code/Magento/Catalog/Model/Product/Type/Price.php +++ b/app/code/Magento/Catalog/Model/Product/Type/Price.php @@ -157,6 +157,7 @@ class Price * @param Product $childProduct * @param float $childProductQty * @return float + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getChildFinalPrice($product, $productQty, $childProduct, $childProductQty) { @@ -243,6 +244,8 @@ class Price * @param Product $product * @return float|array * @deprecated (MAGETWO-31465) + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getTierPrice($qty, $product) { @@ -410,6 +413,7 @@ class Price * @param float $finalPrice * @return float * @deprecated (MAGETWO-31469) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _applyOptionsPrice($product, $qty, $finalPrice) { diff --git a/app/code/Magento/Catalog/Model/Product/TypeTransitionManager.php b/app/code/Magento/Catalog/Model/Product/TypeTransitionManager.php index f20d51159554ec9249c35fd18368d02a2a3fb93c..99dd6a233fa65cb5ef2e531d09d8bb742ec938d9 100644 --- a/app/code/Magento/Catalog/Model/Product/TypeTransitionManager.php +++ b/app/code/Magento/Catalog/Model/Product/TypeTransitionManager.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product; use Magento\Catalog\Model\Product; diff --git a/app/code/Magento/Catalog/Model/Product/Url.php b/app/code/Magento/Catalog/Model/Product/Url.php index 2a3daf72a1dea2d9f3accad25bdfab598970f01a..819232c0725978042acbfc97257a5708a49f81cd 100644 --- a/app/code/Magento/Catalog/Model/Product/Url.php +++ b/app/code/Magento/Catalog/Model/Product/Url.php @@ -158,6 +158,8 @@ class Url extends \Magento\Framework\Object * @param \Magento\Catalog\Model\Product $product * @param array $params * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getUrl(\Magento\Catalog\Model\Product $product, $params = []) { diff --git a/app/code/Magento/Catalog/Model/Product/Validator.php b/app/code/Magento/Catalog/Model/Product/Validator.php index 0682a820cfd0c33efe69c1a26f2d48039ee2f44f..00bd85a34d45d272fb687704862b09b94fec650b 100644 --- a/app/code/Magento/Catalog/Model/Product/Validator.php +++ b/app/code/Magento/Catalog/Model/Product/Validator.php @@ -18,6 +18,7 @@ class Validator * @param RequestInterface $request * @param \Magento\Framework\Object $response * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function validate(Product $product, RequestInterface $request, \Magento\Framework\Object $response) { diff --git a/app/code/Magento/Catalog/Model/Product/Website.php b/app/code/Magento/Catalog/Model/Product/Website.php index a4e4f460f3bee5a04b448d23923ee3ff349d011a..a375c114f96af62cb812068c18e8950eb874aafe 100644 --- a/app/code/Magento/Catalog/Model/Product/Website.php +++ b/app/code/Magento/Catalog/Model/Product/Website.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Catalog Product Website Model * diff --git a/app/code/Magento/Catalog/Model/ProductRepository.php b/app/code/Magento/Catalog/Model/ProductRepository.php index e455e62d77cf2bc1f4b658197af171a6a5a21de7..4a205ae8920f5a00fb1e0a3aad9de3dc09ff5151 100644 --- a/app/code/Magento/Catalog/Model/ProductRepository.php +++ b/app/code/Magento/Catalog/Model/ProductRepository.php @@ -11,6 +11,9 @@ use Magento\Framework\Api\SearchCriteriaInterface; use Magento\Framework\Api\SortOrder; use Magento\Framework\Exception\NoSuchEntityException; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class ProductRepository implements \Magento\Catalog\Api\ProductRepositoryInterface { /** diff --git a/app/code/Magento/Catalog/Model/Resource/AbstractResource.php b/app/code/Magento/Catalog/Model/Resource/AbstractResource.php index dc9b6a252c3fa64ab863c774870c0fe5a0c2b950..4a62d1cfc8f2a2d3f106bd8502c6ec94553d9046 100644 --- a/app/code/Magento/Catalog/Model/Resource/AbstractResource.php +++ b/app/code/Magento/Catalog/Model/Resource/AbstractResource.php @@ -3,12 +3,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Resource; use Magento\Eav\Model\Entity\Attribute\AbstractAttribute; /** * Catalog entity abstract model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractResource extends \Magento\Eav\Model\Entity\AbstractEntity { @@ -525,6 +529,9 @@ abstract class AbstractResource extends \Magento\Eav\Model\Entity\AbstractEntity * @param int|string|array $attribute atrribute's ids or codes * @param int|\Magento\Store\Model\Store $store * @return bool|string|array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getAttributeRawValue($entityId, $attribute, $store) { diff --git a/app/code/Magento/Catalog/Model/Resource/Category.php b/app/code/Magento/Catalog/Model/Resource/Category.php index d572d172925984f1d71cf1913eaf9d6826af71a8..d5c541c7cca51ddc17dfef8945b6eedafdefd327 100644 --- a/app/code/Magento/Catalog/Model/Resource/Category.php +++ b/app/code/Magento/Catalog/Model/Resource/Category.php @@ -11,6 +11,9 @@ */ namespace Magento\Catalog\Model\Resource; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Category extends AbstractResource { /** @@ -326,6 +329,8 @@ class Category extends AbstractResource * * @param \Magento\Catalog\Model\Category $category * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _saveCategoryProducts($category) { diff --git a/app/code/Magento/Catalog/Model/Resource/Category/Collection.php b/app/code/Magento/Catalog/Model/Resource/Category/Collection.php index a0841974d95abb7951f3ffa7a23f723bbd06f327..75efc53ebe0a71c8c58f3a2889eb4ad90ab28bb8 100644 --- a/app/code/Magento/Catalog/Model/Resource/Category/Collection.php +++ b/app/code/Magento/Catalog/Model/Resource/Category/Collection.php @@ -201,6 +201,8 @@ class Collection extends \Magento\Catalog\Model\Resource\Collection\AbstractColl * @param boolean $countRegular get product count for regular (non-anchor) categories * @param boolean $countAnchor get product count for anchor categories * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function loadProductCount($items, $countRegular = true, $countAnchor = true) { diff --git a/app/code/Magento/Catalog/Model/Resource/Category/Tree.php b/app/code/Magento/Catalog/Model/Resource/Category/Tree.php index 9022084a49f316e7df93798f2caf13e5d66a52ca..bbd46711f99c340cfe661a48c372c837f96266cd 100644 --- a/app/code/Magento/Catalog/Model/Resource/Category/Tree.php +++ b/app/code/Magento/Catalog/Model/Resource/Category/Tree.php @@ -5,6 +5,9 @@ */ namespace Magento\Catalog\Model\Resource\Category; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Tree extends \Magento\Framework\Data\Tree\Dbp { const ID_FIELD = 'id'; @@ -157,6 +160,8 @@ class Tree extends \Magento\Framework\Data\Tree\Dbp * @param boolean $toLoad * @param boolean $onlyActive * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function addCollectionData( $collection = null, @@ -324,6 +329,7 @@ class Tree extends \Magento\Framework\Data\Tree\Dbp * * @param int $id * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ protected function _getItemIsActive($id) { @@ -437,6 +443,8 @@ class Tree extends \Magento\Framework\Data\Tree\Dbp * @param bool $addCollectionData * @param bool $updateAnchorProductCount * @return $this|bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function loadByIds($ids, $addCollectionData = true, $updateAnchorProductCount = true) { diff --git a/app/code/Magento/Catalog/Model/Resource/Eav/Attribute.php b/app/code/Magento/Catalog/Model/Resource/Eav/Attribute.php index 4ac7d33d68c4258b83b454bd0a8efeb38fbea21d..9c60527a4a71e1f54c347a057dd9a8baab80a79b 100644 --- a/app/code/Magento/Catalog/Model/Resource/Eav/Attribute.php +++ b/app/code/Magento/Catalog/Model/Resource/Eav/Attribute.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Resource\Eav; use Magento\Catalog\Model\Attribute\LockValidatorInterface; @@ -36,6 +39,7 @@ use Magento\Framework\Api\AttributeDataBuilder; * @method int setIsUsedForPromoRules(int $value) * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Attribute extends \Magento\Eav\Model\Entity\Attribute implements \Magento\Catalog\Api\Data\ProductAttributeInterface @@ -113,6 +117,7 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute implements * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -175,6 +180,7 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute implements * * @return \Magento\Framework\Model\AbstractModel * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function beforeSave() { @@ -412,6 +418,7 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute implements * Check is an attribute used in EAV index * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isIndexable() { @@ -442,6 +449,7 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute implements * Is original attribute config indexable * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _isOriginalIndexable() { diff --git a/app/code/Magento/Catalog/Model/Resource/Product.php b/app/code/Magento/Catalog/Model/Resource/Product.php index eeec4222eca33fd6deceedc26bb6edf26c7bec2c..814f9e6ec81e9c7607fe2057d0f3f9b0d3dc598b 100644 --- a/app/code/Magento/Catalog/Model/Resource/Product.php +++ b/app/code/Magento/Catalog/Model/Resource/Product.php @@ -9,6 +9,7 @@ namespace Magento\Catalog\Model\Resource; * Product entity resource model * * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Product extends AbstractResource { @@ -311,6 +312,7 @@ class Product extends AbstractResource * * @param \Magento\Framework\Object $object * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _saveCategories(\Magento\Framework\Object $object) { diff --git a/app/code/Magento/Catalog/Model/Resource/Product/Attribute/Backend/Media.php b/app/code/Magento/Catalog/Model/Resource/Product/Attribute/Backend/Media.php index 624fabad0eeb968842ee7f9500d08c98affc8420..6fde77a376fbed7e911eee4128e6094860ee201e 100644 --- a/app/code/Magento/Catalog/Model/Resource/Product/Attribute/Backend/Media.php +++ b/app/code/Magento/Catalog/Model/Resource/Product/Attribute/Backend/Media.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Resource\Product\Attribute\Backend; /** diff --git a/app/code/Magento/Catalog/Model/Resource/Product/Collection.php b/app/code/Magento/Catalog/Model/Resource/Product/Collection.php index 178f39f62623b90023ee022273182b750afc6b5e..2d7139d4981841baf3bfb878ed08e0c63ba06ded 100644 --- a/app/code/Magento/Catalog/Model/Resource/Product/Collection.php +++ b/app/code/Magento/Catalog/Model/Resource/Product/Collection.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Resource\Product; use Magento\Catalog\Model\Product\Attribute\Source\Status as ProductStatus; @@ -13,6 +16,11 @@ use Magento\Store\Model\Store; /** * Product collection + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.NumberOfChildren) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Collection extends \Magento\Catalog\Model\Resource\Collection\AbstractCollection { @@ -1390,6 +1398,7 @@ class Collection extends \Magento\Catalog\Model\Resource\Collection\AbstractColl * @param array $condition * @param string $joinType * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function addAttributeToFilter($attribute, $condition = null, $joinType = 'inner') { @@ -1529,6 +1538,8 @@ class Collection extends \Magento\Catalog\Model\Resource\Collection\AbstractColl * @param string $attribute * @param string $dir * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function addAttributeToSort($attribute, $dir = self::SORT_ORDER_ASC) { @@ -1626,6 +1637,7 @@ class Collection extends \Magento\Catalog\Model\Resource\Collection\AbstractColl * Join website product limitation * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _productLimitationJoinWebsite() { @@ -1678,6 +1690,8 @@ class Collection extends \Magento\Catalog\Model\Resource\Collection\AbstractColl * Join additional (alternative) store visibility filter * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _productLimitationJoinStore() { @@ -1977,6 +1991,8 @@ class Collection extends \Magento\Catalog\Model\Resource\Collection\AbstractColl * Add tier price data to loaded items * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function addTierPriceData() { diff --git a/app/code/Magento/Catalog/Model/Resource/Product/Compare/Item/Collection.php b/app/code/Magento/Catalog/Model/Resource/Product/Compare/Item/Collection.php index 6906d82753e4c30eb9a9fe6d78b7e92b957f1c81..c9a4fd6abfe36c20f307d0b76e56540d58542d22 100644 --- a/app/code/Magento/Catalog/Model/Resource/Product/Compare/Item/Collection.php +++ b/app/code/Magento/Catalog/Model/Resource/Product/Compare/Item/Collection.php @@ -10,6 +10,7 @@ namespace Magento\Catalog\Model\Resource\Product\Compare\Item; * * @author Magento Core Team <core@magentocommerce.com> * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Collection extends \Magento\Catalog\Model\Resource\Product\Collection { diff --git a/app/code/Magento/Catalog/Model/Resource/Product/Indexer/Price/DefaultPrice.php b/app/code/Magento/Catalog/Model/Resource/Product/Indexer/Price/DefaultPrice.php index 3e6cf3db6816fc7b6570905dce98482bd0c49f1f..bc256d7ee3426b152a0babc4fa3258e1882fb9a8 100644 --- a/app/code/Magento/Catalog/Model/Resource/Product/Indexer/Price/DefaultPrice.php +++ b/app/code/Magento/Catalog/Model/Resource/Product/Indexer/Price/DefaultPrice.php @@ -110,6 +110,7 @@ class DefaultPrice extends \Magento\Catalog\Model\Resource\Product\Indexer\Abstr * Check product type is composite * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsComposite() { @@ -203,6 +204,7 @@ class DefaultPrice extends \Magento\Catalog\Model\Resource\Product\Indexer\Abstr * * @param int|array $entityIds the entity ids limitation * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareFinalPriceData($entityIds = null) { @@ -391,6 +393,7 @@ class DefaultPrice extends \Magento\Catalog\Model\Resource\Product\Indexer\Abstr * Apply custom option minimal and maximal price to temporary final price index table * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _applyCustomOption() { @@ -641,6 +644,7 @@ class DefaultPrice extends \Magento\Catalog\Model\Resource\Product\Indexer\Abstr * * @param string $table * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getIdxTable($table = null) { diff --git a/app/code/Magento/Catalog/Model/Resource/Product/Link.php b/app/code/Magento/Catalog/Model/Resource/Product/Link.php index be29863658c1925405a973c6ee2a2d1be400b31c..cb70baff0420b403b7dc18e0cbf992512120f86f 100644 --- a/app/code/Magento/Catalog/Model/Resource/Product/Link.php +++ b/app/code/Magento/Catalog/Model/Resource/Product/Link.php @@ -54,6 +54,7 @@ class Link extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param array $data * @param int $typeId * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function saveProductLinks($product, $data, $typeId) { diff --git a/app/code/Magento/Catalog/Model/Resource/Product/Option.php b/app/code/Magento/Catalog/Model/Resource/Product/Option.php index 9f619df100c98db894bda545dfcc06553a4eb736..0150acf9b0e767b2f8ea551e8588538170290669 100644 --- a/app/code/Magento/Catalog/Model/Resource/Product/Option.php +++ b/app/code/Magento/Catalog/Model/Resource/Product/Option.php @@ -82,6 +82,8 @@ class Option extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param \Magento\Framework\Model\AbstractModel $object * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _saveValuePrices(\Magento\Framework\Model\AbstractModel $object) { @@ -230,6 +232,7 @@ class Option extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param \Magento\Framework\Model\AbstractModel $object * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _saveValueTitles(\Magento\Framework\Model\AbstractModel $object) { diff --git a/app/code/Magento/Catalog/Model/Resource/Product/Option/Value.php b/app/code/Magento/Catalog/Model/Resource/Product/Option/Value.php index 8fda510c49d0246696644ce6ac3b9fd164cf03b3..89ecd99e7b368f5b467f9b3ad4a802ba2097449a 100644 --- a/app/code/Magento/Catalog/Model/Resource/Product/Option/Value.php +++ b/app/code/Magento/Catalog/Model/Resource/Product/Option/Value.php @@ -83,6 +83,8 @@ class Value extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param \Magento\Framework\Model\AbstractModel $object * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _saveValuePrices(\Magento\Framework\Model\AbstractModel $object) { @@ -209,6 +211,7 @@ class Value extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param \Magento\Framework\Model\AbstractModel $object * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _saveValueTitles(\Magento\Framework\Model\AbstractModel $object) { diff --git a/app/code/Magento/Catalog/Model/Resource/Product/Option/Value/Collection.php b/app/code/Magento/Catalog/Model/Resource/Product/Option/Value/Collection.php index b1d0149833626678022a95effc0335a742351d33..8f2b9c316a478b01beea39f6fb9297321a8cd6ca 100644 --- a/app/code/Magento/Catalog/Model/Resource/Product/Option/Value/Collection.php +++ b/app/code/Magento/Catalog/Model/Resource/Product/Option/Value/Collection.php @@ -188,6 +188,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac * @param array $optionIds * @param int $storeId * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getValuesByOption($optionIds, $storeId = null) { diff --git a/app/code/Magento/Catalog/Model/Resource/Setup.php b/app/code/Magento/Catalog/Model/Resource/Setup.php index 85b813ff7ae71c406be9e0f4fabe860cbcbacdce..1b9a020792dc1af4942749ae1357ccda747cbcb9 100644 --- a/app/code/Magento/Catalog/Model/Resource/Setup.php +++ b/app/code/Magento/Catalog/Model/Resource/Setup.php @@ -71,6 +71,7 @@ class Setup extends \Magento\Eav\Model\Entity\Setup * Default entites and attributes * * @return array + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getDefaultEntities() { diff --git a/app/code/Magento/Catalog/Model/Resource/Url.php b/app/code/Magento/Catalog/Model/Resource/Url.php index e8465ef90f37b291b02f3fcaef8e6f8bc2daaa96..b41e752056677d3461ae5f2778555779fd9faebf 100644 --- a/app/code/Magento/Catalog/Model/Resource/Url.php +++ b/app/code/Magento/Catalog/Model/Resource/Url.php @@ -363,6 +363,8 @@ class Url extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param int $storeId * @param string $path * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getCategories($categoryIds, $storeId = null, $path = null) { diff --git a/app/code/Magento/Catalog/Model/System/Config/Backend/Catalog/Url/Rewrite/Suffix.php b/app/code/Magento/Catalog/Model/System/Config/Backend/Catalog/Url/Rewrite/Suffix.php index e01e5172c2d57c9b48a6af829b0d0e9d9d48e9f4..c9054ef4160d0d8d2f7f0f91af0982ccf6e2fa19 100644 --- a/app/code/Magento/Catalog/Model/System/Config/Backend/Catalog/Url/Rewrite/Suffix.php +++ b/app/code/Magento/Catalog/Model/System/Config/Backend/Catalog/Url/Rewrite/Suffix.php @@ -18,6 +18,9 @@ use Magento\Store\Model\ScopeInterface; use Magento\UrlRewrite\Model\Storage\DbStorage; use Magento\UrlRewrite\Service\V1\Data\UrlRewrite; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Suffix extends \Magento\Framework\App\Config\Value { /** @var \Magento\UrlRewrite\Helper\UrlRewrite */ @@ -43,6 +46,7 @@ class Suffix extends \Magento\Framework\App\Config\Value * @param \Magento\Framework\App\Resource $appResource * @param \Magento\UrlRewrite\Model\UrlFinderInterface $urlFinder * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Catalog/Model/Template/Filter.php b/app/code/Magento/Catalog/Model/Template/Filter.php index 624ff99b3a6033b8dcc2f72840ba94b9b816895f..93376946e09d1c98bbae3268581904817b4903ad 100644 --- a/app/code/Magento/Catalog/Model/Template/Filter.php +++ b/app/code/Magento/Catalog/Model/Template/Filter.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Catalog Template Filter Model * diff --git a/app/code/Magento/Catalog/Model/Template/Filter/Factory.php b/app/code/Magento/Catalog/Model/Template/Filter/Factory.php index f8b43b2baedecb2578098019712979af1f15713f..2ec6eee9de6699f1a4071f073da06c0ac691ea6b 100644 --- a/app/code/Magento/Catalog/Model/Template/Filter/Factory.php +++ b/app/code/Magento/Catalog/Model/Template/Filter/Factory.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Template filter factory */ diff --git a/app/code/Magento/Catalog/Pricing/Price/TierPrice.php b/app/code/Magento/Catalog/Pricing/Price/TierPrice.php index b20a1e2cc9ea4eff3c9769c5a924a4ce06a6253c..726d3d05e60f1bd5219b37f1b92cf031bb8da121 100644 --- a/app/code/Magento/Catalog/Pricing/Price/TierPrice.php +++ b/app/code/Magento/Catalog/Pricing/Price/TierPrice.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Pricing\Price; use Magento\Catalog\Model\Product; @@ -250,6 +252,7 @@ class TierPrice extends AbstractPrice implements TierPriceInterface, BasePricePr * Get clear tier price list stored in DB * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function getStoredTierPrices() { diff --git a/app/code/Magento/Catalog/Pricing/Render/PriceBox.php b/app/code/Magento/Catalog/Pricing/Render/PriceBox.php index 69d24581c647db1d75c5b9fbe736285ecd797d04..5f0dfcba1714934b988b2713f6874feb17469cfe 100644 --- a/app/code/Magento/Catalog/Pricing/Render/PriceBox.php +++ b/app/code/Magento/Catalog/Pricing/Render/PriceBox.php @@ -39,6 +39,7 @@ class PriceBox extends PriceBoxRender * @param Data $coreDataHelper * @param Random $mathRandom * @param array $data + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function __construct( Context $context, @@ -84,6 +85,7 @@ class PriceBox extends PriceBoxRender * * @param Product $product * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCanDisplayQty(Product $product) { diff --git a/app/code/Magento/Catalog/data/catalog_setup/data-install-2.0.0.php b/app/code/Magento/Catalog/data/catalog_setup/data-install-2.0.0.php index 853bb4224961ae11f45a9cc8d2a19f4c5b57e049..1472110e5fd24e38ba625348f88e0bf4dbd011b2 100644 --- a/app/code/Magento/Catalog/data/catalog_setup/data-install-2.0.0.php +++ b/app/code/Magento/Catalog/data/catalog_setup/data-install-2.0.0.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $installer \Magento\Catalog\Model\Resource\Setup */ $installer = $this; $installer->installEntities(); diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/checkboxes/tree.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/checkboxes/tree.phtml index 1a9b64f32582d631f2e5aefe1067e57eefc5a0ad..78f0314f37e1de62a26e5b3666e5bd9ef6a54901 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/checkboxes/tree.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/checkboxes/tree.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_divId = 'tree-div_' . time() ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/edit.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/edit.phtml index d5be664dabbc569e15620d64e9e5fa91faa11e2d..330375f2bbd380a80b7ad97ac0378bb01a2d54d6 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/edit.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/edit/form.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/edit/form.phtml index f777553e7a66e174c26806dd60bb3fe7aac2c5be..6b3e96b3019fbca83d313b27f27d679cf043d1ed 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/edit/form.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/edit/form.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Catalog\Block\Adminhtml\Category\Edit\Form $this */ $parentId = $this->getParentCategoryId(); $categoryId = $this->getCategoryId(); diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/tree.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/tree.phtml index a6e70b7e8e1a682715228a93c1a04e7a8fbdd0fc..ab241f4cf2526362021d4fa0d51278367eaf8c65 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/tree.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/tree.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="categories-side-col"> <div class="sidebar-actions"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/widget/tree.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/widget/tree.phtml index 613d28de9c8b8170a2c6a6926a337da5b18fa96a..b40ac67e83969387dbadd4d8a2dbf784a44be429 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/widget/tree.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/category/widget/tree.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_divId = 'tree' . $this->getId() ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/form/renderer/fieldset/element.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/form/renderer/fieldset/element.phtml index a4475fb7e4f0d9a057142a18b2982f375a051626..a3b0a37fefa88d5297d1f8a04d19f915113b932d 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/form/renderer/fieldset/element.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/form/renderer/fieldset/element.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product.phtml index 888f68c0aa42ef3463bc163e748c567870d51e2c..e2c7b64715567b39c5f789b3eea8ba3ead79569f 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/form.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/form.phtml index 847219fab39e94acc516581b975930c021059240..49733c945841ac98f9bb5bd6b4bb24615f97ddd4 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/form.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/js.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/js.phtml index 16fbc6e24808925de4fd6d30f7fd1e9d8a20ad3d..46f2599f4f4298d4a358cef9aea7afe539890919 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/js.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/js.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <script> require(["jquery", "js/theme", "prototype"], function(jQuery){ diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/labels.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/labels.phtml index 19e1868ecf51f8554a588b560f123d930b1a106f..6d4eba95168d8ed4fbac08e89687de24d667f975 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/labels.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/labels.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Eav\Block\Adminhtml\Attribute\Edit\Options\Labels */ ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml index e25e9d417993509deb62b48688aa250186af4c7f..6b62ffe820f1d4d1cb46d79e78564ab6fffdfb79 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Eav\Block\Adminhtml\Attribute\Edit\Options\Options */ ?> <fieldset class="fieldset"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/set/main.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/set/main.phtml index 1d54c2626cea0c288bbc3c2ec73da1e4d3b0c72b..b5fb8f89ebc6c80e7ef7a146ded5c532bbdd4ef6 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/set/main.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/set/main.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="attribute-set"> <div class="edit-attribute-set attribute-set-col"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/set/toolbar/main.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/set/toolbar/main.phtml index 9228aa320afa5a3a1b7e14c79d3773991984487f..1d27f92b1d57cdd4045ec77cdb17e900c03c669d 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/set/toolbar/main.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/set/toolbar/main.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml('grid') ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/configure.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/configure.phtml index 97af22f635ee902bd62ee5b1c3fab7072acc229b..551e7b420c8c1492ba4a6ec09bf9c6df81c498f5 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/configure.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/configure.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div id="product_composite_configure" class="product-configure-popup" style="display:none;"> <iframe name="product_composite_configure_iframe" id="product_composite_configure_iframe" style="width:0; height:0; border:0px solid #fff; position:absolute; top:-1000px; left:-1000px" onload="window.productConfigure && productConfigure.onLoadIFrame()"></iframe> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options.phtml index 6f5092f4d71783aa8ded2a52133efd7f7a9fc42f..af3a4af7341170bc2517ffc9a70df0c22a30e124 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Catalog\Block\Adminhtml\Product\Composite\Fieldset\Options */ ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/date.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/date.phtml index d921293b86e4f3e05c435bdd42218a43102638a7..d569edd981107bf88748453fe2a607ea1e0d672a 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/date.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/date.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Catalog\Block\Product\View\Options\Type\Date */ ?> <?php $_option = $this->getOption(); ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/file.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/file.phtml index ed3512348f982c624cee350785a402a2eefc2458..40e578f3df31f963ddb00959748434f7d62d957a 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/file.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/file.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_option = $this->getOption(); ?> <?php $_fileInfo = $this->getFileInfo(); ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/select.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/select.phtml index f7cd5944109cc85b475d59d872068cd1262232dd..c7fc9264685a676a9ba79f7a98d3070c160545cd 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/select.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/select.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Catalog\Block\Product\View\Options\Type\Select */ ?> <?php $_option = $this->getOption(); ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/text.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/text.phtml index ef269053ec96091cf896aa9cd8f892727f611386..de6953ff44f80dc08c7286f9922d35019068ab64 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/text.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/options/type/text.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Catalog\Block\Product\View\Options\Type\Text */ ?> <?php $_option = $this->getOption(); ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/qty.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/qty.phtml index af8c05eff31e171876e71b43732d81ef36362f42..ab9098ab074d71df61a7da62ff1ed96f279613ce 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/qty.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/fieldset/qty.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Catalog\Block\Adminhtml\Product\Composite\Fieldset\Qty */ ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit.phtml index f24a6ab021b5f506e451e75d1ffa93db3b517fe2..42200afb58c0088f9096bbd8426f689ffecc0a83 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/attribute.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/attribute.phtml index 5904d4ec4a0c05d5a306afafbcbac74e42bfaedd..210f805d8a5a5be13108956da65c1f5f37cc3367 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/attribute.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/attribute.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <form action="<?php echo $this->getSaveUrl() ?>" method="post" id="attributes-edit-form" class="attributes-edit-form" enctype="multipart/form-data"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/inventory.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/inventory.phtml index 25b98f6245d1b4c5e08e19eeec2a7e5a140c2d66..f9c8e7ae3d9399e786f2a13f5202732f92996445 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/inventory.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/inventory.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <script> require(['jquery'], function($){ diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/websites.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/websites.phtml index cb2387ae562deb6c92d87965122d572dfdba2d6f..a771230a7091c55ce745c7d80af9082baffbe500 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/websites.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/websites.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="fieldset-wrapper" id="add-products-to-website-wrapper"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/attribute_set.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/attribute_set.phtml index 1033ad3e4a34a1fe565919725bd1f8db1b30ff22..2a010001630b0a36cd12ede15b554c581f2612f8 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/attribute_set.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/attribute_set.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\AttributeSet */ ?> <script id="product-template-selector-template" type="text/x-jquery-tmpl"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options.phtml index 3e5af8fa065e160e3726209f7d28e02c2cbe9a62..e5079a0d1768f00726aaf64cffdace7ea34a564b 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options */ ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/option.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/option.phtml index 3c382dbad06637bf02d84e333f7b2df26e9fbe3d..5d159e46435decd0299e4b72c9595678772b10f9 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/option.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/option.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Option */ ?> <?php echo $this->getTemplatesHtml() ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/date.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/date.phtml index 9bc1cd008b3b6d48243a259c032461e6998d10be..4e2f2f9e8c1b19ed50b13baf4857738166ec95d7 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/date.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/date.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type\Date */ ?> <script id="custom-option-date-type-template" type="text/x-jquery-tmpl"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/file.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/file.phtml index 974bdfbed6b7338a7c2c7588ff6e6d65d872279d..d120de6bd696d518dcf83e5e8c77d8f43e68f363 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/file.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/file.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type\File */ ?> <script id="custom-option-file-type-template" type="text/x-jquery-tmpl"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/select.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/select.phtml index 2a88c3009c09afa3f1d446271f12a39d51dee36b..4de96e3259293ee7c42eaf2c7b4c4c80dd045586 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/select.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/select.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type\Select */ ?> <script id="custom-option-select-type-template" type="text/x-jquery-tmpl"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/text.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/text.phtml index 53026fd396af06eefda3cd3f2b672588ad36e184..5dbd088dcbc61cc8cd1d46a8aa85786aeb656719 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/text.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/options/type/text.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type\Text */ ?> <script id="custom-option-text-type-template" type="text/x-jquery-tmpl"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/price/group.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/price/group.phtml index ac75338c15749f8197b0d8b973210b7fccc7647c..d486a300155b208396b9b8faad0855e273ce9fa6 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/price/group.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/price/group.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Price\Group */ diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/price/tier.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/price/tier.phtml index e3d9b46ec4c6f525d1ea072a3e14f15b2363f796..afa6d5cb57e872bfc9003d184e44cad7f36b58bb 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/price/tier.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/price/tier.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Price\Tier */ $element = $this->getElement(); ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/serializer.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/serializer.phtml index 9abbec255c5105094831896552580ce9aa350f2e..c51ca7f6aa9e5f8bb21d1e1d3a2a67ea0152e7be 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/serializer.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/serializer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_id = 'id_' . md5(microtime()) ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/websites.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/websites.phtml index 3ae73372f4ec1e0a71b4c360c4f1f43437783ccc..2dcd3cc07a5c189f0ecdab1c922f3ee2500457e3 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/websites.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/websites.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <fieldset id="grop_fields" class="fieldset"> <legend class="legend"><span><?php echo __('Product In Websites') ?></span></legend> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/helper/gallery.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/helper/gallery.phtml index 4062dfd9bc6575e6752abe19472d09e982d73462..69eb4fdbcae41f31904d3ee2a63eaf9cb479ba78 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/helper/gallery.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/helper/gallery.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Helper\Form\Gallery\Content */ $elementName = $this->getElement()->getName() . '[images]'; ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/js.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/js.phtml index bf21c4ab6d63a5a09cc9b30575397231eea9df8f..d7fb7cb3a2ce591a072ea2bd688414d55824bd8a 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/js.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/js.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Catalog\Block\Adminhtml\Product\Edit\Js $this */ ?> <script> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/tab/alert.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/tab/alert.phtml index 3d4710937046c3c603fc4cdb6072df44069699f2..fcedc9d106ccdd727e9c69952ca4c82c3845e9a0 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/tab/alert.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/tab/alert.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/tab/inventory.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/tab/inventory.phtml index be203cb6c31c4d39e040ff82d79d3378856ed0d0..fbdc4f2d9e4192c6a9726599a0b49bd0e5580ddf 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/tab/inventory.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/tab/inventory.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Inventory */ ?> <?php if ($this->isReadonly()): ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/wysiwyg/js.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/wysiwyg/js.phtml index 2ba5ae20a405296be23d182cce406abd11b1615f..cb5e7d11f6f382e8de4c6aeafb75fff7f3d3ecf6 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/wysiwyg/js.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/wysiwyg/js.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <script> require([ diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/attribute/search.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/attribute/search.phtml index b96311cbabe05220cd2772f8c67e0066f6691a71..07dfbadb716e468a50d182d22a9c8800ef988f25 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/attribute/search.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/attribute/search.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Attributes\Search */ ?> <div id="product-attribute-search-container" class="suggest-expandable attribute-selector"> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/tabs.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/tabs.phtml index 0c2a267f803219989634ee6951cfe4c4dad007d6..6b649604853308536bf83bb6b4dca541613b002e 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/tabs.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/product/edit/tabs.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Catalog\Block\Adminhtml\Product\Edit\Tabs */ ?> <?php if (!empty($tabs)): ?> diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/product/grid/massaction_extended.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/product/grid/massaction_extended.phtml index 3fa1e452402a5a16205fa032090e7eae1edfc1cb..ba1bf3a1a538cce1643b4ac3a9f43de64622ef86 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/product/grid/massaction_extended.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/product/grid/massaction_extended.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @deprecated support Magento 1.x grid massaction implementation (MAGETWO-11122) */ diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/rss/grid/link.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/rss/grid/link.phtml index bc0c5193493570a35f9629c3bde497f8cc8c5c7c..c481ee1b9b37eb32fd4eb339e965f48fde9da35f 100644 --- a/app/code/Magento/Catalog/view/adminhtml/templates/rss/grid/link.phtml +++ b/app/code/Magento/Catalog/view/adminhtml/templates/rss/grid/link.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Catalog\Block\Adminhtml\Rss\Grid\Link */ ?> <?php if ($this->isRssAllowed() && $this->getLink()): ?> diff --git a/app/code/Magento/Catalog/view/base/templates/product/price/amount/default.phtml b/app/code/Magento/Catalog/view/base/templates/product/price/amount/default.phtml index b3482f3df77d03259ba735d4fced86c066c6195f..f7f2853e35710a42a40ada8c576fc228c2239d00 100644 --- a/app/code/Magento/Catalog/view/base/templates/product/price/amount/default.phtml +++ b/app/code/Magento/Catalog/view/base/templates/product/price/amount/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Framework\Pricing\Render\Amount $this */ ?> diff --git a/app/code/Magento/Catalog/view/base/templates/product/price/amount/option.phtml b/app/code/Magento/Catalog/view/base/templates/product/price/amount/option.phtml index 041f9ba8afb2ffafa18713d1b0d71db31978cdc5..8c509c4d454fcf0009414aa94dc9eb5b20027ccc 100644 --- a/app/code/Magento/Catalog/view/base/templates/product/price/amount/option.phtml +++ b/app/code/Magento/Catalog/view/base/templates/product/price/amount/option.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Framework\Pricing\Render\Amount $this */ diff --git a/app/code/Magento/Catalog/view/base/templates/product/price/default.phtml b/app/code/Magento/Catalog/view/base/templates/product/price/default.phtml index 088d6b80bd274e3bee17d4f24a34e483b6551c8b..2a5e7c87bfe93778adcb78188b34638ee11c7230 100644 --- a/app/code/Magento/Catalog/view/base/templates/product/price/default.phtml +++ b/app/code/Magento/Catalog/view/base/templates/product/price/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Catalog/view/base/templates/product/price/final_price.phtml b/app/code/Magento/Catalog/view/base/templates/product/price/final_price.phtml index 5529085b233e52d9823aa336b2df72014eebb409..833e4fe93c0166fa914c2cd6911882b5a6871119 100644 --- a/app/code/Magento/Catalog/view/base/templates/product/price/final_price.phtml +++ b/app/code/Magento/Catalog/view/base/templates/product/price/final_price.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Catalog/view/base/templates/product/price/tier_prices.phtml b/app/code/Magento/Catalog/view/base/templates/product/price/tier_prices.phtml index 7e64dab1aef2e5ba55ce65766036e2a7a6ab12dc..4a8a8c3e57d7dcaaf37773cbc06e46a947cc5eb3 100644 --- a/app/code/Magento/Catalog/view/base/templates/product/price/tier_prices.phtml +++ b/app/code/Magento/Catalog/view/base/templates/product/price/tier_prices.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Catalog/view/frontend/templates/category/cms.phtml b/app/code/Magento/Catalog/view/frontend/templates/category/cms.phtml index 0cac6a56853ea30428f87b8634181e1e6da62bcb..f9b9985913776e8704fc708bf4cde0b8feb40916 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/category/cms.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/category/cms.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/category/description.phtml b/app/code/Magento/Catalog/view/frontend/templates/category/description.phtml index 0dad008a4590b6b71e8876d6e45cee192b6ad293..256152bfcacd294368cff88893c92866ecbbf38f 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/category/description.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/category/description.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/category/image.phtml b/app/code/Magento/Catalog/view/frontend/templates/category/image.phtml index 2df51bf5bc1381a64a12af9429070fa4c5310f09..c029eb807290cdc34a48bd3f30ae18ae690ed013 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/category/image.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/category/image.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/category/products.phtml b/app/code/Magento/Catalog/view/frontend/templates/category/products.phtml index e1cc98bc5fda57a130af65cda225dde05f7a58b8..8bf10b626e34b29f743f314f4f9ebcc354f331c3 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/category/products.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/category/products.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/category/rss.phtml b/app/code/Magento/Catalog/view/frontend/templates/category/rss.phtml index 9a3879880526a619f0aadc0d540dfc3916113937..badbca5adf28335046975e9e9fd656ac144b76bd 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/category/rss.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/category/rss.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->isRssAllowed() && $this->getLink() && $this->isTopCategory()): ?> <a href="<?php echo $this->getLink() ?>" class="action link rss"><span><?php echo $this->getLabel() ?></span></a> diff --git a/app/code/Magento/Catalog/view/frontend/templates/category/view.phtml b/app/code/Magento/Catalog/view/frontend/templates/category/view.phtml index e9304b73264425dd7fa369454791b365458da2eb..5dfd1a5e49045a21099fa12b882768fb2f5e1bae 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/category/view.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/category/view.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/js/components.phtml b/app/code/Magento/Catalog/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/navigation/left.phtml b/app/code/Magento/Catalog/view/frontend/templates/navigation/left.phtml index 38aae93415f55d5c0273c713608ab7eb0bbbeec8..d5a48a87654b9db0f080a4c003148409a184371a 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/navigation/left.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/navigation/left.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Category left navigation * diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/compare/link.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/compare/link.phtml index d9409740110031b8f7e34aec6e46c7a67736b5d8..1ff2d438f29d6eb79457d005baed9f746950c278 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/compare/link.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/compare/link.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Catalog\Block\Product\Compare\Sidebar */ ?> <?php diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/compare/list.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/compare/list.phtml index a4a5beb5f3c6cf0ed53aab9a819031356a791216..c5dec7a2cb076077d54b52be47551c2cd1737f84 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/compare/list.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/compare/list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Catalog\Block\Product\Compare\ListCompare */ ?> <?php $_total = $this->getItems()->getSize() ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/compare/sidebar.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/compare/sidebar.phtml index e52fbf5ee1726cf6b6c35095d620ac4600cd7ea0..7a28c80facac7cb2b3c3c7a57a4f6891f919cae4 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/compare/sidebar.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/compare/sidebar.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Catalog\Block\Product\Compare\Sidebar */ ?> <?php diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/gallery.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/gallery.phtml index 03d5f644a9b218c909130cb236c610af0d7ed671..e1fa094fbe735eb6c337396e9f68689796210bb2 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/gallery.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/gallery.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_width = $this->getImageWidth(); ?> <div class="product-image-popup" style="width:<?php echo $_width; ?>px;"> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/list.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/list.phtml index 3e5ba55c32dfd575a8088c29e1a67ec9d68a2d40..224631a20f29efa6eee73130b36bfd8e6cea789a 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/list.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/list/items.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/list/items.phtml index c3a1b0a7e0c941bad6486e05bfff93880dec4c70..7cfb02aae3ba5835f4fe2a82163f388920dca8ae 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/list/items.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/list/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Catalog\Block\Product\AbstractProduct */ ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar.phtml index 73b69a68947ef3e11daf0a68c741660cbe917716..d805e221cd9299ed944a08ea8287f1b735dbf4d0 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/amount.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/amount.phtml index 7f078a5b29cf0260f56cf02d0f8fa89dde426da8..696ed2586b3ecbaf79ed5e45484097152b393abc 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/amount.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/amount.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/limiter.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/limiter.phtml index 7b3c5f75b5f6549886cdfa22cd862bc7b49ea9ee..b5246811e8ee890280c4e82e3fef6b7449861575 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/limiter.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/limiter.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/sorter.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/sorter.phtml index fb967647360e0b863e0de2b73c43bc0566ae4202..1553857c6513d151b27f07d499019c41ff63273a 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/sorter.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/sorter.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/viewmode.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/viewmode.phtml index 9a12250d270d2b52266298422fde390c78c5d932..85ffaec51d7b0dcca393cd6b7f56a5cc8c664b51 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/viewmode.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/list/toolbar/viewmode.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/listing.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/listing.phtml index 5a8691fd3950598e14dff434fc07058fe669a4dd..0118f002833a7d5d8c07e25d8babd5e159ebad22 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/listing.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/listing.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/additional.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/additional.phtml index 6e5011258cdeaf2e9724b4cf92583a7a360758ed..c7d848e17489a079a6021cc124a1ca76364e7095 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/additional.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/additional.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php foreach ($this->getChildHtmlList() as $_html): ?> <?php echo $_html ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/addto.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/addto.phtml index f4fdf56877d0d6dcf25cde8526ded8917146d0b7..81c9e6b827c4d6f400e1eab9d60c60bbaff94d26 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/addto.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/addto.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Catalog\Block\Product\View*/ ?> <?php diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/addtocart.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/addtocart.phtml index d886aa4075423e5db4d1d22bb3eb70936cedb56f..e876bb781caaf6cb809b0e4863c2f33122e94aba 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/addtocart.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/addtocart.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Catalog\Block\Product\View */ ?> <?php $_product = $this->getProduct(); ?> @@ -45,7 +47,8 @@ <script> require([ "jquery", - "mage/mage" + "mage/mage", + "Magento_Catalog/product/view/validation" ], function($){ $('#product_addtocart_form').mage('validation', { radioCheckboxClosest: '.nested' diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml index 4f0d36a9236e9da7f1f8de20be90592a26bcdae5..e73437f173a79077fa5b0c9cfc55c1c6dd7cbb56 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Product view template * diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/attributes.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/attributes.phtml index 3b855b2ee677d4f4c69334559adae5d396e35faf..9922012a2ab10c392bd2edea80979df022e6cda1 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/attributes.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/attributes.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Product additional attributes template * diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/base-image.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/base-image.phtml index 71878a37107b65e5ed23a8b8fcee47b688e6f290..30dd92080a5d0c1ceb3e36c8a96fe574385bc47e 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/base-image.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/base-image.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Product media data template * diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/description.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/description.phtml index a9551cfd7f33ceb7b39ce50c6d94d1e1d95e7ac6..07c0914ae9b9174afbf89d7c1b26f5aa4afeebab 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/description.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/description.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Product description template * diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml index ac0297f0017791e131bf059731a1082a60971a14..f5f6f766cdb629ddbeddbeb95db61b7b2f584b5d 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($detailedInfoGroup = $this->getGroupChildNames('detailed_info', 'getChildHtml')):?> <div class="product info detailed"> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/form.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/form.phtml index c427f21e33fff8799b6d69701dddf18ebda12b3c..cf0e3ee6d59ec9eb30b1e2292302604a93162e22 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/form.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/form.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Product view template * diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/mailto.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/mailto.phtml index 0f4dae08440f14c729454ec18bdc7a2df6fca913..6105eb5ba0a39cd3687cde11289ebfafc0d93520 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/mailto.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/mailto.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_product = $this->getProduct() ?> <?php if ($this->canEmailToFriend()): ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/opengraph/general.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/opengraph/general.phtml index 977708a69e4a449f7b30cae8db477add2be02dc0..8d2451d22f1a43f14d919d4c451f60d83e5493e6 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/opengraph/general.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/opengraph/general.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Catalog\Block\Product\View */ ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/options.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/options.phtml index afd6124620a13de6931504d14fd63847647fcf6e..a8377bd7096ff473d6223c0ece98c83ae8b4eda1 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/options.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/options.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Catalog\Block\Product\View\Options */ ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/date.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/date.phtml index 8395c1939c6c8a5d854e159c0b0f401e02b6f411..965dba919e604ef9a7703e4ae6ddfb20cc58f6cd 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/date.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/date.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_option = $this->getOption() ?> <?php $_optionId = $_option->getId() ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/default.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/default.phtml index 75c18e5f7bd72f05654419655cb84019512144f8..39575520822e3e6c782c92213008223f18651220 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/default.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_option = $this->getOption() ?> <div class="field"> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/file.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/file.phtml index 57bdd806d829170ca0ede52f8bc9e68f56674d33..348e97ac91d0283847445735742296cfa5063ce6 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/file.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/file.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_option = $this->getOption(); ?> <?php $_fileInfo = $this->getFileInfo(); ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/select.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/select.phtml index 908751bf439c677a2d7c5a3cd5ad571165046f4d..a861d27a70c8c277e4955b4dcc04d8fc443aa556 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/select.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/select.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Catalog\Block\Product\View\Options\Type\Select */ ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/text.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/text.phtml index e27ad1a9cb82ad7705808281474e223e83c9028d..1b34e2f11a4a210bd6d5dc7986b7f7f4f6109fbd 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/text.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/options/type/text.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_option = $this->getOption(); diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/price_clone.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/price_clone.phtml index 4b5b0d1d52a8dae062ac16088b1be4a29fd36e89..5dc5ea489295d22ed4bfe131f15e44f9dd2eb818 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/price_clone.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/price_clone.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Catalog\Block\Product\AbstractProduct $this */ ?> <?php $_product = $this->getProduct() ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/review.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/review.phtml index 734c87fdddabd707bc99d238f20c1d7a1e82b54e..fcd3f06e6c522b0e05fe537ac48d73f5d8878ded 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/review.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/review.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Catalog\Block\Product\AbstractProduct */ ?> <?php echo $this->getReviewsSummaryHtml($this->getProduct(), false, true)?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/view/type/default.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/view/type/default.phtml index 98803d333d59441d0a94bdfc25de713d285f9597..ddcdaf2e86c177ea5be197fc6330c858ce7057a4 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/view/type/default.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/view/type/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Catalog\Block\Product\View\AbstractView */?> <?php $_product = $this->getProduct() ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_default_list.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_default_list.phtml index edaeccde7faa1b6507f9f7ebfa39b8d61abe3f45..220ed8a4724804b2288aad7411051e762c17eb9c 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_default_list.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_default_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (($_products = $this->getProductCollection()) && $_products->getSize()): ?> <?php $imageBlock = $this->getLayout()->createBlock('Magento\Catalog\Block\Product\Image');?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_images_list.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_images_list.phtml index 8bdda5c87d9c5db652963201ee4a6a37b320baf8..bc6c4fa55ce385d6e3064b80abb73b4c5257ba5f 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_images_list.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_images_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (($_products = $this->getProductCollection()) && $_products->getSize()): ?> <?php $imageBlock = $this->getLayout()->createBlock('Magento\Catalog\Block\Product\Image'); ?> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_names_list.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_names_list.phtml index 771ad1ef45c7f6c64da6df141e9a6db272458695..51fb3a3fd8580c2c409a51ce90a353d2bfb9ad77 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_names_list.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/column/new_names_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (($_products = $this->getProductCollection()) && $_products->getSize()): ?> <div class="block widget block-new-products-names"> diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/content/new_grid.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/content/new_grid.phtml index 3d129802ce419cfd8f14258189421bf5a13b0b20..c806f16ca1b78077baf27d526b5fef883e39852a 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/content/new_grid.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/content/new_grid.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/content/new_list.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/content/new_list.phtml index 72215d25438f10d39565613d39a68b33183bd194..1c29c88ac1482747ea99f77bc93d381339db1d06 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/content/new_list.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/widget/new/content/new_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Catalog/view/frontend/web/product/view/validation.js b/app/code/Magento/Catalog/view/frontend/web/product/view/validation.js index 703137b01af9a668c896b1bc8c41abf80b035c50..a19ab628f91dbc17c322ddd30aa5bd30bdd7326a 100644 --- a/app/code/Magento/Catalog/view/frontend/web/product/view/validation.js +++ b/app/code/Magento/Catalog/view/frontend/web/product/view/validation.js @@ -17,7 +17,7 @@ $.widget("mage.validation", $.mage.validation, { options: { - radioCheckboxClosest: 'ul', + radioCheckboxClosest: 'ul, ol', errorPlacement: function (error, element) { if (element.attr('data-validate-message-box')) { var messageBox = $(element.attr('data-validate-message-box')); diff --git a/app/code/Magento/CatalogImportExport/Model/Export/Product.php b/app/code/Magento/CatalogImportExport/Model/Export/Product.php index e4a7f205361bc08cb001ee0c7d2b24e662a52c43..923f303f798ce3a9588ce08d27a86e05baba9c28 100644 --- a/app/code/Magento/CatalogImportExport/Model/Export/Product.php +++ b/app/code/Magento/CatalogImportExport/Model/Export/Product.php @@ -9,6 +9,9 @@ namespace Magento\CatalogImportExport\Model\Export; * Export entity product model * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Product extends \Magento\ImportExport\Model\Export\Entity\AbstractEntity { @@ -213,6 +216,7 @@ class Product extends \Magento\ImportExport\Model\Export\Entity\AbstractEntity * @param Product\Type\Factory $_typeFactory * @param \Magento\Catalog\Model\Product\LinkTypeProvider $linkTypeProvider * @param \Magento\CatalogImportExport\Model\Export\RowCustomizerInterface $rowCustomizer + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate, @@ -759,6 +763,10 @@ class Product extends \Magento\ImportExport\Model\Export\Entity\AbstractEntity * Get export data for collection * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _getExportData() { diff --git a/app/code/Magento/CatalogImportExport/Model/Import/Product.php b/app/code/Magento/CatalogImportExport/Model/Import/Product.php index dc3c48636420112015560a9029ed2517af657ccc..40abe3cd9757d5d53605cccb6f84291cb42c3dfc 100644 --- a/app/code/Magento/CatalogImportExport/Model/Import/Product.php +++ b/app/code/Magento/CatalogImportExport/Model/Import/Product.php @@ -3,12 +3,18 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogImportExport\Model\Import; use Magento\Framework\App\Filesystem\DirectoryList; /** * Import entity product model + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity { @@ -525,6 +531,7 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity * @param \Magento\Indexer\Model\IndexerRegistry $indexerRegistry * @param array $data * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Core\Helper\Data $coreData, @@ -825,6 +832,8 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity * @param array $rowData * @param int $rowNum * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _isProductCategoryValid(array $rowData, $rowNum) { @@ -893,6 +902,7 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity * @param array $rowData * @param int $rowNum * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _isTierPriceValid(array $rowData, $rowNum) { @@ -960,6 +970,7 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity * @param array $rowData * @param int $rowNum * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _isGroupPriceValid(array $rowData, $rowNum) { @@ -1050,6 +1061,9 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity * Must be called after ALL products saving done. * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _saveLinks() { @@ -1279,6 +1293,9 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity * Gather and save information about product entities. * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _saveProducts() { @@ -1632,6 +1649,7 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity * * @param array $mediaGalleryData * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _saveMediaGallery(array $mediaGalleryData) { @@ -1916,6 +1934,9 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity * @param array $rowData * @param int $rowNum * @return boolean + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function validateRow(array $rowData, $rowNum) { diff --git a/app/code/Magento/CatalogImportExport/Model/Import/Product/Option.php b/app/code/Magento/CatalogImportExport/Model/Import/Product/Option.php index 3beb252bf658241c2f03e6420170d34c4cb5cd83..f0e7b75f25d90035d6af10548010708e3a7b7488 100644 --- a/app/code/Magento/CatalogImportExport/Model/Import/Product/Option.php +++ b/app/code/Magento/CatalogImportExport/Model/Import/Product/Option.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogImportExport\Model\Import\Product; /** @@ -1169,6 +1172,7 @@ class Option extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity * @param array &$parentCount * @param array &$childCount * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _collectOptionTypeData( array $rowData, @@ -1438,6 +1442,7 @@ class Option extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity * @param int $optionTypeId * @param bool $defaultStore * @return array|false + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _getSpecificTypeData(array $rowData, $optionTypeId, $defaultStore = true) { diff --git a/app/code/Magento/CatalogImportExport/Model/Import/Product/Type/AbstractType.php b/app/code/Magento/CatalogImportExport/Model/Import/Product/Type/AbstractType.php index 8ab80ea553092d7c499d07f432190e924a5f4bc3..c6b445b8ce480da9ae7b29787e81e1570d0baf8d 100644 --- a/app/code/Magento/CatalogImportExport/Model/Import/Product/Type/AbstractType.php +++ b/app/code/Magento/CatalogImportExport/Model/Import/Product/Type/AbstractType.php @@ -123,6 +123,7 @@ abstract class AbstractType * @param array $attrParams Refined attribute parameters. * @param mixed $attribute * @return \Magento\CatalogImportExport\Model\Import\Product\Type\AbstractType + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _addAttributeParams($attrSetName, array $attrParams, $attribute) { @@ -201,6 +202,7 @@ abstract class AbstractType * * @param string $attrCode * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _isAttributeRequiredCheckNeeded($attrCode) { @@ -213,6 +215,7 @@ abstract class AbstractType * @param array $rowData * @param int $rowNum * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _isParticularAttributesValid(array $rowData, $rowNum) { @@ -247,6 +250,7 @@ abstract class AbstractType * @param int $rowNum * @param bool $isNewProduct Optional * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isRowValid(array $rowData, $rowNum, $isNewProduct = true) { @@ -301,6 +305,7 @@ abstract class AbstractType * @param bool $withDefaultValue * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function prepareAttributesWithDefaultValueForSave(array $rowData, $withDefaultValue = true) { diff --git a/app/code/Magento/CatalogImportExport/Model/Indexer/Category/Product/Plugin/Import.php b/app/code/Magento/CatalogImportExport/Model/Indexer/Category/Product/Plugin/Import.php index 3d188c1bde86d1f482026e75241c5b09c037b877..a0e7c5a578a87d4dae9c52f884337934f690ebb5 100644 --- a/app/code/Magento/CatalogImportExport/Model/Indexer/Category/Product/Plugin/Import.php +++ b/app/code/Magento/CatalogImportExport/Model/Indexer/Category/Product/Plugin/Import.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogImportExport\Model\Indexer\Category\Product\Plugin; class Import diff --git a/app/code/Magento/CatalogImportExport/Model/Indexer/Product/Category/Plugin/Import.php b/app/code/Magento/CatalogImportExport/Model/Indexer/Product/Category/Plugin/Import.php index 32cc1b827fa195dc45ccc8d16fc10baff11cd897..4033c84be63e539b85b345ef13aec3107d4cd074 100644 --- a/app/code/Magento/CatalogImportExport/Model/Indexer/Product/Category/Plugin/Import.php +++ b/app/code/Magento/CatalogImportExport/Model/Indexer/Product/Category/Plugin/Import.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogImportExport\Model\Indexer\Product\Category\Plugin; class Import diff --git a/app/code/Magento/CatalogInventory/Api/Data/StockItemInterface.php b/app/code/Magento/CatalogInventory/Api/Data/StockItemInterface.php index f2555d146f71199f6cfb03addfce4a392317874a..72759511123b125c28201447968cb6671367ae4d 100644 --- a/app/code/Magento/CatalogInventory/Api/Data/StockItemInterface.php +++ b/app/code/Magento/CatalogInventory/Api/Data/StockItemInterface.php @@ -92,16 +92,19 @@ interface StockItemInterface extends ExtensibleDataInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsQtyDecimal(); /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getShowDefaultNotificationMessage(); /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigMinQty(); @@ -126,6 +129,7 @@ interface StockItemInterface extends ExtensibleDataInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigMaxSaleQty(); @@ -138,6 +142,7 @@ interface StockItemInterface extends ExtensibleDataInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigBackorders(); @@ -150,6 +155,7 @@ interface StockItemInterface extends ExtensibleDataInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigNotifyStockQty(); @@ -162,6 +168,7 @@ interface StockItemInterface extends ExtensibleDataInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigQtyIncrements(); @@ -174,6 +181,7 @@ interface StockItemInterface extends ExtensibleDataInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigEnableQtyInc(); @@ -181,11 +189,13 @@ interface StockItemInterface extends ExtensibleDataInterface * Retrieve whether Quantity Increments is enabled * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getEnableQtyIncrements(); /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigManageStock(); @@ -193,6 +203,7 @@ interface StockItemInterface extends ExtensibleDataInterface * Retrieve can Manage Stock * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getManageStock(); @@ -203,6 +214,7 @@ interface StockItemInterface extends ExtensibleDataInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsDecimalDivided(); diff --git a/app/code/Magento/CatalogInventory/Api/StockConfigurationInterface.php b/app/code/Magento/CatalogInventory/Api/StockConfigurationInterface.php index 879b438cc0f4100ec6d0ddc7f5962a8d870682f0..5052ea004b256113e1af1bb01a7c4a43b4ca83b0 100644 --- a/app/code/Magento/CatalogInventory/Api/StockConfigurationInterface.php +++ b/app/code/Magento/CatalogInventory/Api/StockConfigurationInterface.php @@ -69,6 +69,7 @@ interface StockConfigurationInterface * * @param int $storeId * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getEnableQtyIncrements($storeId = null); @@ -99,6 +100,7 @@ interface StockConfigurationInterface * * @param int $storeId * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCanBackInStock($storeId = null); diff --git a/app/code/Magento/CatalogInventory/Helper/Stock.php b/app/code/Magento/CatalogInventory/Helper/Stock.php index e6921ac68ae4b4ae43a073604730c79a9573bb80..e8d111dfa1f352ab469f627cc5c86cd6fbbfb1b7 100644 --- a/app/code/Magento/CatalogInventory/Helper/Stock.php +++ b/app/code/Magento/CatalogInventory/Helper/Stock.php @@ -84,6 +84,7 @@ class Stock * * @param \Magento\Catalog\Model\Resource\Collection\AbstractCollection $productCollection * @return void + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function addStockStatusToProducts( \Magento\Catalog\Model\Resource\Collection\AbstractCollection $productCollection diff --git a/app/code/Magento/CatalogInventory/Model/Adminhtml/Stock/Item.php b/app/code/Magento/CatalogInventory/Model/Adminhtml/Stock/Item.php index b72d5e9319e996b0a8c58252b098be3330b97bbb..d4612c3e2e32cac758fc8943d144ba16d89e5b25 100644 --- a/app/code/Magento/CatalogInventory/Model/Adminhtml/Stock/Item.php +++ b/app/code/Magento/CatalogInventory/Model/Adminhtml/Stock/Item.php @@ -36,6 +36,7 @@ class Item extends \Magento\CatalogInventory\Model\Stock\Item * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -113,6 +114,7 @@ class Item extends \Magento\CatalogInventory\Model\Stock\Item /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getShowDefaultNotificationMessage() { diff --git a/app/code/Magento/CatalogInventory/Model/Configuration.php b/app/code/Magento/CatalogInventory/Model/Configuration.php index 990c5db1a2f492ed53b5109286eb3c287dad2983..2d4d0189a63c565b9bca8f97fb3b016e328220b6 100644 --- a/app/code/Magento/CatalogInventory/Model/Configuration.php +++ b/app/code/Magento/CatalogInventory/Model/Configuration.php @@ -255,6 +255,7 @@ class Configuration implements StockConfigurationInterface * * @param null|string|bool|int|\Magento\Store\Model\Store $store * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getEnableQtyIncrements($store = null) { @@ -313,6 +314,7 @@ class Configuration implements StockConfigurationInterface * * @param null|string|bool|int|\Magento\Store\Model\Store $store * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCanBackInStock($store = null) { diff --git a/app/code/Magento/CatalogInventory/Model/Observer.php b/app/code/Magento/CatalogInventory/Model/Observer.php index 190ac3fa04b5619a858a7f25a26e8063c0b4a3ab..eb23b47a11b9ddae9e56f70708e5d26857f83016 100644 --- a/app/code/Magento/CatalogInventory/Model/Observer.php +++ b/app/code/Magento/CatalogInventory/Model/Observer.php @@ -16,6 +16,7 @@ use Magento\Quote\Model\Quote\Item as QuoteItem; /** * Catalog inventory module observer + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Observer { diff --git a/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator.php b/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator.php index e05293b32374ab927bc51a401b0215b1f824b6a4..1af08b5f1a1f4bd665caa1ddf7d3fd896d29aca0 100644 --- a/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator.php +++ b/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator.php @@ -57,6 +57,9 @@ class QuantityValidator * * @return void * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function validate(\Magento\Framework\Event\Observer $observer) { diff --git a/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItem.php b/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItem.php index 3503260a1b0ee2802abc1514ecdcbb6352de59e0..a4f21f6336a6d7520bfd39836eb39da46255a3dd 100644 --- a/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItem.php +++ b/app/code/Magento/CatalogInventory/Model/Quote/Item/QuantityValidator/Initializer/StockItem.php @@ -50,6 +50,8 @@ class StockItem * * @return \Magento\Framework\Object * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function initialize( \Magento\CatalogInventory\Api\Data\StockItemInterface $stockItem, diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Indexer/Stock/DefaultStock.php b/app/code/Magento/CatalogInventory/Model/Resource/Indexer/Stock/DefaultStock.php index a7396a044f43b1089c23314a92007167c2fcf98a..6be23ba43302afed63fa6a4b9f5744b811af9602 100644 --- a/app/code/Magento/CatalogInventory/Model/Resource/Indexer/Stock/DefaultStock.php +++ b/app/code/Magento/CatalogInventory/Model/Resource/Indexer/Stock/DefaultStock.php @@ -132,6 +132,7 @@ class DefaultStock extends \Magento\Catalog\Model\Resource\Product\Indexer\Abstr * Check product type is composite * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsComposite() { @@ -157,6 +158,7 @@ class DefaultStock extends \Magento\Catalog\Model\Resource\Product\Indexer\Abstr * @param int|array $entityIds * @param bool $usePrimaryTable use primary or temporary index table * @return \Magento\Framework\DB\Select + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _getStockStatusSelect($entityIds = null, $usePrimaryTable = false) { @@ -279,6 +281,7 @@ class DefaultStock extends \Magento\Catalog\Model\Resource\Product\Indexer\Abstr * * @param string $table * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getIdxTable($table = null) { diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/StockItemCriteria.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/StockItemCriteria.php index afa169fbd1d8655485329e04ea7654bff8e69239..ac004fe8581e9bd556698280073b10d3ab7a3366 100644 --- a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/StockItemCriteria.php +++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Item/StockItemCriteria.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogInventory\Model\Resource\Stock\Item; use Magento\Framework\Data\AbstractCriteria; diff --git a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/StockStatusCriteria.php b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/StockStatusCriteria.php index c8b0b7a673ab6361d0331ca8f85c7a2e9240ef4a..4edc96f803ef3a4148c8d6d1b5655c723c899858 100644 --- a/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/StockStatusCriteria.php +++ b/app/code/Magento/CatalogInventory/Model/Resource/Stock/Status/StockStatusCriteria.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogInventory\Model\Resource\Stock\Status; use Magento\Framework\Data\AbstractCriteria; diff --git a/app/code/Magento/CatalogInventory/Model/Stock/Item.php b/app/code/Magento/CatalogInventory/Model/Stock/Item.php index f5ab4a65e038a355be3f10f615c3ce7136e7ad45..51a72cdf1d364e30ec16e3930ecd1f607a3bce08 100644 --- a/app/code/Magento/CatalogInventory/Model/Stock/Item.php +++ b/app/code/Magento/CatalogInventory/Model/Stock/Item.php @@ -40,6 +40,7 @@ use Magento\Framework\Model\AbstractExtensibleModel; * @method \Magento\CatalogInventory\Model\Stock\Item setQtyIncrements(float $value) * @method \Magento\CatalogInventory\Model\Stock\Item setUseConfigEnableQtyInc(int $value) * @method \Magento\CatalogInventory\Model\Stock\Item setEnableQtyIncrements(int $value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Item extends AbstractExtensibleModel implements StockItemInterface { @@ -123,6 +124,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -212,6 +214,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getStockStatusChangedAuto() { @@ -241,6 +244,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsQtyDecimal() { @@ -249,6 +253,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsDecimalDivided() { @@ -267,6 +272,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface * Check if notification message should be added despite of backorders notification flag * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getShowDefaultNotificationMessage() { @@ -275,6 +281,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigMinQty() { @@ -298,6 +305,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigMinSaleQty() { @@ -321,6 +329,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigMaxSaleQty() { @@ -345,6 +354,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigNotifyStockQty() { @@ -366,6 +376,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigEnableQtyInc() { @@ -376,6 +387,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface * Retrieve whether Quantity Increments is enabled * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getEnableQtyIncrements() { @@ -389,6 +401,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface * Retrieve whether config for Quantity Increments should be used * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigQtyIncrements() { @@ -419,6 +432,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigBackorders() { @@ -440,6 +454,7 @@ class Item extends AbstractExtensibleModel implements StockItemInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseConfigManageStock() { diff --git a/app/code/Magento/CatalogInventory/Model/Stock/StockItemRepository.php b/app/code/Magento/CatalogInventory/Model/Stock/StockItemRepository.php index 3d6427be091102e84c1d631fa6e3ca7040d3c520..10c1debd7335d941e1ad30af64fc0f047d8a1d3e 100644 --- a/app/code/Magento/CatalogInventory/Model/Stock/StockItemRepository.php +++ b/app/code/Magento/CatalogInventory/Model/Stock/StockItemRepository.php @@ -23,6 +23,7 @@ use Magento\Framework\Stdlib\DateTime\TimezoneInterface; /** * Class StockItemRepository + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class StockItemRepository implements StockItemRepositoryInterface { @@ -87,6 +88,7 @@ class StockItemRepository implements StockItemRepositoryInterface * @param MapperFactory $mapperFactory * @param TimezoneInterface $localeDate * @param Processor $indexProcessor + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( StockConfigurationInterface $stockConfiguration, diff --git a/app/code/Magento/CatalogInventory/Model/Stock/StockRepository.php b/app/code/Magento/CatalogInventory/Model/Stock/StockRepository.php index 98a9d3b2117d67a1f558ab8ae4ae2f7a7268d46c..bc3f7774e874cf186638f0f71f0d4ae7afd0cc60 100644 --- a/app/code/Magento/CatalogInventory/Model/Stock/StockRepository.php +++ b/app/code/Magento/CatalogInventory/Model/Stock/StockRepository.php @@ -18,6 +18,7 @@ use Magento\Framework\Exception\NoSuchEntityException; /** * Class StockRepository + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class StockRepository implements StockRepositoryInterface { diff --git a/app/code/Magento/CatalogInventory/Model/Stock/StockStatusRepository.php b/app/code/Magento/CatalogInventory/Model/Stock/StockStatusRepository.php index ce73c99e09e742245f90ddc72ecfc687fdac88f4..2c1e24a42c024e1f2512b2e89951be3c69d0673c 100644 --- a/app/code/Magento/CatalogInventory/Model/Stock/StockStatusRepository.php +++ b/app/code/Magento/CatalogInventory/Model/Stock/StockStatusRepository.php @@ -16,6 +16,7 @@ use Magento\Framework\Exception\CouldNotSaveException; /** * Class StockStatusRepository + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class StockStatusRepository implements StockStatusRepositoryInterface { diff --git a/app/code/Magento/CatalogInventory/Model/StockIndex.php b/app/code/Magento/CatalogInventory/Model/StockIndex.php index b62116b5da040c37bf9d9317617b101afc81d5ed..2eaf9a9bac6c981e023100ed510e9ac9d1d8400d 100644 --- a/app/code/Magento/CatalogInventory/Model/StockIndex.php +++ b/app/code/Magento/CatalogInventory/Model/StockIndex.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogInventory\Model; use Magento\Catalog\Model\Product\Type as ProductType; @@ -75,6 +78,7 @@ class StockIndex implements StockIndexInterface * @param int $productId * @param int $websiteId * @return true + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function rebuild($productId = null, $websiteId = null) { @@ -127,6 +131,7 @@ class StockIndex implements StockIndexInterface * @param int $qty * @param int $status * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function processChildren( $productId, diff --git a/app/code/Magento/CatalogInventory/Model/StockManagement.php b/app/code/Magento/CatalogInventory/Model/StockManagement.php index cb2894d11c4e971699602a19dc31dc969a9e2730..c70c610ae68791f18d189d526807a1252320c67a 100644 --- a/app/code/Magento/CatalogInventory/Model/StockManagement.php +++ b/app/code/Magento/CatalogInventory/Model/StockManagement.php @@ -68,6 +68,7 @@ class StockManagement implements StockManagementInterface * @param int $websiteId * @return StockItemInterface[] * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function registerProductsSale($items, $websiteId = null) { diff --git a/app/code/Magento/CatalogInventory/Model/StockRegistryProvider.php b/app/code/Magento/CatalogInventory/Model/StockRegistryProvider.php index e1f900a3325305e862396ef697aa08960108b0aa..0a9f1f04d013281a4d64a76a1f364422e14ee603 100644 --- a/app/code/Magento/CatalogInventory/Model/StockRegistryProvider.php +++ b/app/code/Magento/CatalogInventory/Model/StockRegistryProvider.php @@ -19,6 +19,7 @@ use Magento\Store\Model\StoreManagerInterface; /** * Class StockRegistryProvider + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class StockRegistryProvider implements StockRegistryProviderInterface { diff --git a/app/code/Magento/CatalogInventory/Model/StockStateProvider.php b/app/code/Magento/CatalogInventory/Model/StockStateProvider.php index 38a0f7e4670f8db56f36444c9f3d8caaa6631d44..f5dea5479c4409caf13a442f2d6b534a40aabcc9 100644 --- a/app/code/Magento/CatalogInventory/Model/StockStateProvider.php +++ b/app/code/Magento/CatalogInventory/Model/StockStateProvider.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogInventory\Model; use Magento\Catalog\Model\ProductFactory; @@ -93,6 +96,9 @@ class StockStateProvider implements StockStateProviderInterface * @param int|float $summaryQty * @param int|float $origQty * @return \Magento\Framework\Object + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function checkQuoteItemQty(StockItemInterface $stockItem, $qty, $summaryQty, $origQty = 0) { @@ -320,6 +326,8 @@ class StockStateProvider implements StockStateProviderInterface * * @param StockItemInterface $stockItem * @return float + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getStockQty(StockItemInterface $stockItem) { diff --git a/app/code/Magento/CatalogInventory/view/frontend/templates/qtyincrements.phtml b/app/code/Magento/CatalogInventory/view/frontend/templates/qtyincrements.phtml index 9aee089bb0063971fcd09ba5c409e7554ad45adf..5788b0c735b27881c869d1ef13d5e99b3e1f9ecc 100644 --- a/app/code/Magento/CatalogInventory/view/frontend/templates/qtyincrements.phtml +++ b/app/code/Magento/CatalogInventory/view/frontend/templates/qtyincrements.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @var $this \Magento\CatalogInventory\Block\Qtyincrements */ diff --git a/app/code/Magento/CatalogInventory/view/frontend/templates/stockqty/composite.phtml b/app/code/Magento/CatalogInventory/view/frontend/templates/stockqty/composite.phtml index 3de72c1c0a5438968fd289800d260f92f0d8653a..5b0ba2cde07ca723aabc06dec18dc9b324608f79 100644 --- a/app/code/Magento/CatalogInventory/view/frontend/templates/stockqty/composite.phtml +++ b/app/code/Magento/CatalogInventory/view/frontend/templates/stockqty/composite.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @var $this \Magento\CatalogInventory\Block\Stockqty\Composite */ diff --git a/app/code/Magento/CatalogInventory/view/frontend/templates/stockqty/default.phtml b/app/code/Magento/CatalogInventory/view/frontend/templates/stockqty/default.phtml index 4adf062f48740ffea4a2aae3df05bfed83bc4bfe..8fa8f59626bb5b34f8e2b1cb440261eca275c3aa 100644 --- a/app/code/Magento/CatalogInventory/view/frontend/templates/stockqty/default.phtml +++ b/app/code/Magento/CatalogInventory/view/frontend/templates/stockqty/default.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @var $this \Magento\CatalogInventory\Block\Stockqty\DefaultStockqty */ diff --git a/app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab/Actions.php b/app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab/Actions.php index d27a0b4127f609275df97aa7ef0fbb139fdc82d4..b29dffb9b1779b6ad89c5b01d45dba2221a32eb3 100644 --- a/app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab/Actions.php +++ b/app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab/Actions.php @@ -53,6 +53,7 @@ class Actions extends Generic implements TabInterface /** * @return Form + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab/Main.php b/app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab/Main.php index 0109c1690e2f6e7c96d6e3601f299cec1bb643a6..b22840b7f547f4e49ccb6ad96549a442f9933516 100644 --- a/app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab/Main.php +++ b/app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab/Main.php @@ -106,6 +106,7 @@ class Main extends Generic implements TabInterface /** * @return Form + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog.php b/app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog.php index 0a59763eabf4c8c1308ef61e4dc9e4105a238163..3b20dec460b319b8386ec39fde6ce99298870cfc 100644 --- a/app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog.php +++ b/app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Backend Catalog Price Rules controller * diff --git a/app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog/Save.php b/app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog/Save.php index 7c3637a402105980ce45a94e39efd2c9c4b90e2f..1a7ae10ca4f35cbce4754ef3a215f41f11c300b2 100644 --- a/app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog/Save.php +++ b/app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog/Save.php @@ -12,6 +12,7 @@ class Save extends \Magento\CatalogRule\Controller\Adminhtml\Promo\Catalog { /** * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/CatalogRule/Model/Indexer/IndexBuilder.php b/app/code/Magento/CatalogRule/Model/Indexer/IndexBuilder.php index 9309727f7eb7bb0ecf7b740908cb0cfe616c9b45..5812b16b0832d1b03d53041e0442d4dc28076b68 100644 --- a/app/code/Magento/CatalogRule/Model/Indexer/IndexBuilder.php +++ b/app/code/Magento/CatalogRule/Model/Indexer/IndexBuilder.php @@ -12,6 +12,9 @@ use Magento\CatalogRule\Model\Resource\Rule\CollectionFactory as RuleCollectionF use Magento\CatalogRule\Model\Rule; use Magento\Framework\Pricing\PriceCurrencyInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class IndexBuilder { const SECONDS_IN_DAY = 86400; @@ -82,6 +85,7 @@ class IndexBuilder * @param \Magento\Framework\Stdlib\DateTime\DateTime $dateTime * @param \Magento\Catalog\Model\ProductFactory $productFactory * @param int $batchCount + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( RuleCollectionFactory $ruleCollectionFactory, @@ -210,6 +214,7 @@ class IndexBuilder * @param Product $product * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function applyRule(Rule $rule, $product) { @@ -318,6 +323,8 @@ class IndexBuilder /** * @param Rule $rule * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function updateRuleProductData(Rule $rule) { @@ -400,6 +407,9 @@ class IndexBuilder * @param Product|null $product * @throws \Exception * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function applyAllRules(Product $product = null) { diff --git a/app/code/Magento/CatalogRule/Model/Observer.php b/app/code/Magento/CatalogRule/Model/Observer.php index 9f4913d23527ea2486ec029c8983d5945487eac6..887b60b9c8a2e5426eee596422197fb29c027dff 100644 --- a/app/code/Magento/CatalogRule/Model/Observer.php +++ b/app/code/Magento/CatalogRule/Model/Observer.php @@ -22,6 +22,9 @@ use Magento\Customer\Model\Session as CustomerModelSession; use Magento\Framework\Event\Observer as EventObserver; use Magento\Framework\Stdlib\DateTime; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Observer { /** diff --git a/app/code/Magento/CatalogRule/Model/Resource/Rule.php b/app/code/Magento/CatalogRule/Model/Resource/Rule.php index e3b9617bdfe4a09b20449029bd3ce240986e741e..330c01f9680b2f1ba912b556e863563ecd0204e3 100644 --- a/app/code/Magento/CatalogRule/Model/Resource/Rule.php +++ b/app/code/Magento/CatalogRule/Model/Resource/Rule.php @@ -15,6 +15,9 @@ use Magento\Catalog\Model\Product; use Magento\Framework\Model\AbstractModel; use Magento\Framework\Pricing\PriceCurrencyInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Rule extends \Magento\Rule\Model\Resource\AbstractResource { /** @@ -100,6 +103,7 @@ class Rule extends \Magento\Rule\Model\Resource\AbstractResource * @param \Psr\Log\LoggerInterface $logger * @param \Magento\Framework\Stdlib\DateTime $dateTime * @param PriceCurrencyInterface $priceCurrency + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Resource $resource, diff --git a/app/code/Magento/CatalogRule/Model/Rule.php b/app/code/Magento/CatalogRule/Model/Rule.php index 77cd01db84d77960b5c2eb8193280461b8ca06a5..1228ac74d24cb34975ecd832a25d2f714b1af202 100644 --- a/app/code/Magento/CatalogRule/Model/Rule.php +++ b/app/code/Magento/CatalogRule/Model/Rule.php @@ -37,6 +37,8 @@ use Magento\Catalog\Model\Product; * @method \Magento\CatalogRule\Model\Rule setDiscountAmount(float $value) * @method string getWebsiteIds() * @method \Magento\CatalogRule\Model\Rule setWebsiteIds(string $value) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Rule extends \Magento\Rule\Model\AbstractModel { @@ -160,6 +162,7 @@ class Rule extends \Magento\Rule\Model\AbstractModel * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $relatedCacheTypes * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -341,6 +344,7 @@ class Rule extends \Magento\Rule\Model\AbstractModel * @param Product $product * @param float $price * @return float|null + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function calcProductPriceRule(Product $product, $price) { diff --git a/app/code/Magento/CatalogRule/Plugin/Model/Product/Action.php b/app/code/Magento/CatalogRule/Plugin/Model/Product/Action.php index 8824a7be8323431c0d2f40fe196f5823338cafac..115255dcc9a2867411ede46a94d78016d9efc47e 100644 --- a/app/code/Magento/CatalogRule/Plugin/Model/Product/Action.php +++ b/app/code/Magento/CatalogRule/Plugin/Model/Product/Action.php @@ -30,6 +30,7 @@ class Action * @return ProductAction * * @SuppressWarnings(PHPMD.UnusedFormatParameter) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterUpdateAttributes(ProductAction $object, ProductAction $result) { diff --git a/app/code/Magento/CatalogRule/view/adminhtml/templates/promo/fieldset.phtml b/app/code/Magento/CatalogRule/view/adminhtml/templates/promo/fieldset.phtml index 5da1c6a5147144abb5373c7f043330ff9dabc314..7b0afb2d79f427bb841d9b2c7a048bdd41448a6c 100644 --- a/app/code/Magento/CatalogRule/view/adminhtml/templates/promo/fieldset.phtml +++ b/app/code/Magento/CatalogRule/view/adminhtml/templates/promo/fieldset.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_element = $this->getElement() ?> <div class="rule-tree"> diff --git a/app/code/Magento/CatalogRule/view/adminhtml/templates/promo/form.phtml b/app/code/Magento/CatalogRule/view/adminhtml/templates/promo/form.phtml index 80a5f45c6d3d34b022e2778b94bf4950ce7d9ab0..ea0eb2cbfacb83b331d9f4f2131151efa7adaa59 100644 --- a/app/code/Magento/CatalogRule/view/adminhtml/templates/promo/form.phtml +++ b/app/code/Magento/CatalogRule/view/adminhtml/templates/promo/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="entry-edit rule-tree"> <?php echo $this->getFormHtml() ?> diff --git a/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Aggregation/DataProvider.php b/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Aggregation/DataProvider.php index 7fa83928ab995936e482379fae8efe44086e6035..8d528613e7951585390c2c374291d1441af41508 100644 --- a/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Aggregation/DataProvider.php +++ b/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Aggregation/DataProvider.php @@ -16,6 +16,9 @@ use Magento\Framework\Search\Adapter\Mysql\Aggregation\DataProviderInterface; use Magento\Framework\Search\Request\BucketInterface; use Magento\Store\Model\Store; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class DataProvider implements DataProviderInterface { /** diff --git a/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Dynamic/DataProvider.php b/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Dynamic/DataProvider.php index c56bde7b55e211abea8bdf12b68dcf0f12ba514d..341783fa0dcd6b1a71ec600f8edd392e0ccccc6b 100644 --- a/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Dynamic/DataProvider.php +++ b/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Dynamic/DataProvider.php @@ -17,6 +17,9 @@ use Magento\Framework\Search\Dynamic\IntervalFactory; use Magento\Framework\Search\Request\BucketInterface; use Magento\Store\Model\ScopeInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class DataProvider implements DataProviderInterface { const XML_PATH_INTERVAL_DIVISION_LIMIT = 'catalog/layered_navigation/interval_division_limit'; diff --git a/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Filter/Preprocessor.php b/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Filter/Preprocessor.php index 14384ca630fe5e7f4aa3cce6c0dcf829f41a7abd..16fea125bdaf16b3f41197c88b812345414a5f40 100644 --- a/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Filter/Preprocessor.php +++ b/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Filter/Preprocessor.php @@ -63,6 +63,7 @@ class Preprocessor implements PreprocessorInterface /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function process(FilterInterface $filter, $isNegation, $query) { diff --git a/app/code/Magento/CatalogSearch/Model/Advanced.php b/app/code/Magento/CatalogSearch/Model/Advanced.php index 7d9f0c6f69c9202277ab4af53783c490f7c52d35..61db41611533312086057ebd886403237c14123f 100644 --- a/app/code/Magento/CatalogSearch/Model/Advanced.php +++ b/app/code/Magento/CatalogSearch/Model/Advanced.php @@ -42,6 +42,7 @@ use Magento\Store\Model\StoreManagerInterface; * @method \Magento\CatalogSearch\Model\Advanced setUpdatedAt(string $value) * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Advanced extends \Magento\Framework\Model\AbstractModel { @@ -121,6 +122,7 @@ class Advanced extends \Magento\Framework\Model\AbstractModel * @param ProductFactory $productFactory * @param \Magento\Store\Model\StoreManagerInterface $storeManager * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( Context $context, @@ -156,6 +158,8 @@ class Advanced extends \Magento\Framework\Model\AbstractModel * @param array $values * @return $this * @throws Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function addFilters($values) { @@ -284,6 +288,8 @@ class Advanced extends \Magento\Framework\Model\AbstractModel * @param EntityAttribute $attribute * @param mixed $value * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _addSearchCriteria($attribute, $value) { diff --git a/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/Full.php b/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/Full.php index a4acccc995e2fe87e8b94aa74c32f1d940569314..e4f6fea57b08b1ef8befff137a864eca3aa6cebd 100644 --- a/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/Full.php +++ b/app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/Full.php @@ -7,6 +7,10 @@ namespace Magento\CatalogSearch\Model\Indexer\Fulltext\Action; use Magento\Framework\Pricing\PriceCurrencyInterface; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Full { /** @@ -155,6 +159,7 @@ class Full * @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate * @param \Magento\CatalogSearch\Model\Resource\Fulltext $fulltextResource * @param PriceCurrencyInterface $priceCurrency + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Resource $resource, @@ -259,6 +264,8 @@ class Full * @param int $storeId Store View Id * @param int|array $productIds Product Entity Id * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function rebuildStoreIndex($storeId, $productIds = null) { @@ -637,6 +644,8 @@ class Full * @param array $productData * @param int $storeId * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function prepareProductIndex($indexData, $productData, $storeId) { diff --git a/app/code/Magento/CatalogSearch/Model/Layer/Filter/Decimal.php b/app/code/Magento/CatalogSearch/Model/Layer/Filter/Decimal.php index c489fccae2c895c899bb1566d3fa005b46c440cf..9061a5755b2dfecc1f3e1bcde92291acf6f097a8 100644 --- a/app/code/Magento/CatalogSearch/Model/Layer/Filter/Decimal.php +++ b/app/code/Magento/CatalogSearch/Model/Layer/Filter/Decimal.php @@ -89,6 +89,7 @@ class Decimal extends AbstractFilter * * @return array * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getItemsData() { diff --git a/app/code/Magento/CatalogSearch/Model/Layer/Filter/Price.php b/app/code/Magento/CatalogSearch/Model/Layer/Filter/Price.php index 44f01e3f491d5f1c2e8d6134b27fc472a40e0dc9..e3a419bbe47de61b5a7e3bce999dfe57df4df931 100644 --- a/app/code/Magento/CatalogSearch/Model/Layer/Filter/Price.php +++ b/app/code/Magento/CatalogSearch/Model/Layer/Filter/Price.php @@ -54,6 +54,8 @@ class Price extends AbstractFilter * @param \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency * @param \Magento\Catalog\Model\Layer\Filter\Dynamic\AlgorithmFactory $algorithmFactory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function __construct( \Magento\Catalog\Model\Layer\Filter\ItemFactory $filterItemFactory, @@ -107,6 +109,7 @@ class Price extends AbstractFilter * * @param \Magento\Framework\App\RequestInterface $request * @return $this + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function apply(\Magento\Framework\App\RequestInterface $request) { diff --git a/app/code/Magento/CatalogSearch/Model/Resource/Advanced.php b/app/code/Magento/CatalogSearch/Model/Resource/Advanced.php index bd841d931afe201c7e962ab30ca71aa2ac49edc3..2cbb9e51f972ca4665d6e177701054306b6c07a4 100644 --- a/app/code/Magento/CatalogSearch/Model/Resource/Advanced.php +++ b/app/code/Magento/CatalogSearch/Model/Resource/Advanced.php @@ -85,6 +85,7 @@ class Advanced extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param \Magento\Catalog\Model\Resource\Eav\Attribute $attribute * @param string|array $value * @return string|array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function prepareCondition($attribute, $value) { @@ -122,6 +123,7 @@ class Advanced extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param string|array $value * @param int $rate * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function addRatedPriceFilter($collection, $attribute, $value, $rate = 1) { @@ -166,6 +168,7 @@ class Advanced extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param \Magento\Catalog\Model\Resource\Eav\Attribute $attribute * @param string|array $value * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function addIndexableAttributeModifiedFilter($collection, $attribute, $value) { diff --git a/app/code/Magento/CatalogSearch/Model/Resource/Advanced/Collection.php b/app/code/Magento/CatalogSearch/Model/Resource/Advanced/Collection.php index 16a6f822c818489698f4b9ee08c019fcfa6402c7..32c9cc320860266a2cc60650ba42fc4fd54052bc 100644 --- a/app/code/Magento/CatalogSearch/Model/Resource/Advanced/Collection.php +++ b/app/code/Magento/CatalogSearch/Model/Resource/Advanced/Collection.php @@ -11,6 +11,7 @@ use Magento\Catalog\Model\Product; * Collection Advanced * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Collection extends \Magento\Catalog\Model\Resource\Product\Collection { @@ -122,6 +123,7 @@ class Collection extends \Magento\Catalog\Model\Resource\Product\Collection /** * @inheritdoc + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _renderFiltersBefore() { diff --git a/app/code/Magento/CatalogSearch/Model/Resource/Fulltext/Collection.php b/app/code/Magento/CatalogSearch/Model/Resource/Fulltext/Collection.php index 1eeed0d3ee58618325e8632bb398c7ada76ba087..31c0545235348970d43939d2b15e1cd1b8db46d7 100644 --- a/app/code/Magento/CatalogSearch/Model/Resource/Fulltext/Collection.php +++ b/app/code/Magento/CatalogSearch/Model/Resource/Fulltext/Collection.php @@ -11,6 +11,7 @@ use Magento\Framework\Search\Response\QueryResponse; /** * Fulltext Collection + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Collection extends \Magento\Catalog\Model\Resource\Product\Collection { diff --git a/app/code/Magento/CatalogSearch/Model/Resource/Search/Collection.php b/app/code/Magento/CatalogSearch/Model/Resource/Search/Collection.php index 04c481e9994038142f3748cfa8d9c47fc7d061e0..331a441f066ea520de824bfb4eebad101978b1be 100644 --- a/app/code/Magento/CatalogSearch/Model/Resource/Search/Collection.php +++ b/app/code/Magento/CatalogSearch/Model/Resource/Search/Collection.php @@ -3,12 +3,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogSearch\Model\Resource\Search; /** * Search collection * * @deprecated + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Collection extends \Magento\Catalog\Model\Resource\Product\Collection implements \Magento\Search\Model\SearchCollectionInterface { @@ -271,6 +275,8 @@ class Collection extends \Magento\Catalog\Model\Resource\Product\Collection impl * * @param mixed $query * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _getSearchInOptionSql($query) { diff --git a/app/code/Magento/CatalogSearch/Model/Search/RequestGenerator.php b/app/code/Magento/CatalogSearch/Model/Search/RequestGenerator.php index 5d29b15faeeaaf31ffb7b0ba2aa765d74cc02b65..f29fd216af3e0fbf9921511fd7f7df6aaadc3197 100644 --- a/app/code/Magento/CatalogSearch/Model/Search/RequestGenerator.php +++ b/app/code/Magento/CatalogSearch/Model/Search/RequestGenerator.php @@ -136,6 +136,7 @@ class RequestGenerator * Generate advanced search request * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ private function generateAdvancedSearchRequest() { diff --git a/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/form.phtml b/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/form.phtml index 225c4eb492bbafc291f12e9b4dff3e10096aa400..6de92ac5cc8382274531082e3fdc863e54e9b68e 100644 --- a/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/form.phtml +++ b/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/link.phtml b/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/link.phtml index c43f81778491217d51fc1598771cf69a87352646..d360f98e153a37a0753eaa126bc1a272a5d83402 100644 --- a/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/link.phtml +++ b/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/link.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var \Magento\CatalogSearch\Helper\Data $helper */ $helper = $this->helper('Magento\CatalogSearch\Helper\Data'); ?> diff --git a/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/result.phtml b/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/result.phtml index d2aea7416e14ca1f1e9d2130de905700ce5d2c4a..2341f5bd6d7a8370723df3e4f96ca5aeb3cc8efa 100644 --- a/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/result.phtml +++ b/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/result.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/CatalogSearch/view/frontend/templates/result.phtml b/app/code/Magento/CatalogSearch/view/frontend/templates/result.phtml index 5a090e8e3ee9e8541f35085885e8d5895e824e9c..880d62d27da246913736a9ab188cec8fec538b57 100644 --- a/app/code/Magento/CatalogSearch/view/frontend/templates/result.phtml +++ b/app/code/Magento/CatalogSearch/view/frontend/templates/result.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getResultCount()): ?> <?php echo $this->getChildHtml('tagged_product_list_rss_link'); ?> diff --git a/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php b/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php index 20dad46dbf40dfeeadc9bfe951903450e90efa37..cc89420d21afb1d570004658abc9f4bd88504fa3 100644 --- a/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php +++ b/app/code/Magento/CatalogWidget/Block/Product/ProductsList.php @@ -3,11 +3,15 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogWidget\Block\Product; /** * Catalog Products List widget block * Class ProductsList + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class ProductsList extends \Magento\Catalog\Block\Product\AbstractProduct implements \Magento\Widget\Block\BlockInterface { @@ -147,6 +151,7 @@ class ProductsList extends \Magento\Catalog\Block\Product\AbstractProduct implem /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getProductPriceHtml( \Magento\Catalog\Model\Product $product, diff --git a/app/code/Magento/CatalogWidget/Model/Rule/Condition/Product.php b/app/code/Magento/CatalogWidget/Model/Rule/Condition/Product.php index b6912210f11b6fe11f4fead78cff84ab27cbdea3..19da2e1702c3f1147df2fbc5b9a0c8872887b073 100644 --- a/app/code/Magento/CatalogWidget/Model/Rule/Condition/Product.php +++ b/app/code/Magento/CatalogWidget/Model/Rule/Condition/Product.php @@ -43,6 +43,7 @@ class Product extends \Magento\Rule\Model\Condition\Product\AbstractProduct * @param \Magento\Framework\Locale\FormatInterface $localeFormat * @param \Magento\Store\Model\StoreManagerInterface $storeManager * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Rule\Model\Condition\Context $context, diff --git a/app/code/Magento/CatalogWidget/view/adminhtml/templates/product/widget/conditions.phtml b/app/code/Magento/CatalogWidget/view/adminhtml/templates/product/widget/conditions.phtml index b55316c71000d128b9efd096053b91ecd35f9990..d3581d73080401d964b1519aea5a2767d9d680f8 100644 --- a/app/code/Magento/CatalogWidget/view/adminhtml/templates/product/widget/conditions.phtml +++ b/app/code/Magento/CatalogWidget/view/adminhtml/templates/product/widget/conditions.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $element = $this->getElement(); diff --git a/app/code/Magento/CatalogWidget/view/frontend/templates/product/widget/content/grid.phtml b/app/code/Magento/CatalogWidget/view/frontend/templates/product/widget/content/grid.phtml index f081e7916356f1f5cbb868ec7f79545df53ecc2f..cf61d31a1ac0043fada9aaca4da132f0766990b9 100644 --- a/app/code/Magento/CatalogWidget/view/frontend/templates/product/widget/content/grid.phtml +++ b/app/code/Magento/CatalogWidget/view/frontend/templates/product/widget/content/grid.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Centinel/Model/Config.php b/app/code/Magento/Centinel/Model/Config.php index c252afeec2d66cacf8147bb582ba94f8b352c4db..81d187f3ed2ed1abd52e349b4bf9c00fd5ffe19d 100644 --- a/app/code/Magento/Centinel/Model/Config.php +++ b/app/code/Magento/Centinel/Model/Config.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Config centinel model */ @@ -117,6 +119,7 @@ class Config * Return flag - is centinel mode test * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsTestMode() { @@ -138,6 +141,7 @@ class Config * Define if debugging is enabled * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDebugFlag() { diff --git a/app/code/Magento/Centinel/Model/Service.php b/app/code/Magento/Centinel/Model/Service.php index ad0a82a0ef69cb2c169802124492541b9113e0aa..5973fc76b5d7512fe77d4d002dcba53d7b52ee84 100644 --- a/app/code/Magento/Centinel/Model/Service.php +++ b/app/code/Magento/Centinel/Model/Service.php @@ -142,6 +142,7 @@ class Service extends \Magento\Framework\Object * @param float $amount * @param string $currencyCode * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _generateChecksum( $paymentMethodCode, diff --git a/app/code/Magento/Centinel/Model/State/Mastercard.php b/app/code/Magento/Centinel/Model/State/Mastercard.php index b0e4f25a357277d40fe27ded4512b4b70bc89579..f42a2f8c0535a5fa4d93de70627478fe98beafff 100644 --- a/app/code/Magento/Centinel/Model/State/Mastercard.php +++ b/app/code/Magento/Centinel/Model/State/Mastercard.php @@ -26,6 +26,8 @@ class Mastercard extends \Magento\Centinel\Model\AbstractState * Result depends from flag self::getIsModeStrict() * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function isAuthenticateSuccessful() { @@ -133,6 +135,7 @@ class Mastercard extends \Magento\Centinel\Model\AbstractState * Analyse lookup`s results. If lookup is soft successful return true * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _isLookupSoftSuccessful() { diff --git a/app/code/Magento/Centinel/Model/State/Visa.php b/app/code/Magento/Centinel/Model/State/Visa.php index 6d0d181642488ee48b8161f6fcecae25249c45b3..6c1436780913eecf823849a63e6bf2d31f027501 100644 --- a/app/code/Magento/Centinel/Model/State/Visa.php +++ b/app/code/Magento/Centinel/Model/State/Visa.php @@ -26,6 +26,9 @@ class Visa extends \Magento\Centinel\Model\AbstractState * Result depends from flag self::getIsModeStrict() * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function isAuthenticateSuccessful() { @@ -152,6 +155,7 @@ class Visa extends \Magento\Centinel\Model\AbstractState * Analyse lookup`s results. If lookup is soft successful return true * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _isLookupSoftSuccessful() { diff --git a/app/code/Magento/Centinel/view/adminhtml/templates/authentication/complete.phtml b/app/code/Magento/Centinel/view/adminhtml/templates/authentication/complete.phtml index bebcb7a8fcd6dc2b18b657af53cf7fa0e9d05d0d..b572ff3ef4f86ada8e67cf316e35c6849535ac12 100644 --- a/app/code/Magento/Centinel/view/adminhtml/templates/authentication/complete.phtml +++ b/app/code/Magento/Centinel/view/adminhtml/templates/authentication/complete.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getIsProcessed()):?> <?php if ($this->getIsSuccess()):?> diff --git a/app/code/Magento/Centinel/view/adminhtml/templates/validation/form.phtml b/app/code/Magento/Centinel/view/adminhtml/templates/validation/form.phtml index 1c38f1b50cda79847e741bb585623e678a1d5bc7..7d9d4a660c263b442a15c82c997a819af88d7df2 100644 --- a/app/code/Magento/Centinel/view/adminhtml/templates/validation/form.phtml +++ b/app/code/Magento/Centinel/view/adminhtml/templates/validation/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="centinel"> diff --git a/app/code/Magento/Centinel/view/frontend/templates/authentication.phtml b/app/code/Magento/Centinel/view/frontend/templates/authentication.phtml index f9d7d2435cc4d07b6d0581c755368476d66276d9..73e180528def43ef10d7d3ad4b75b98795a37902 100644 --- a/app/code/Magento/Centinel/view/frontend/templates/authentication.phtml +++ b/app/code/Magento/Centinel/view/frontend/templates/authentication.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getAuthenticationStart()):?> <div class="centinel" id="centinel-authenticate-block" data-mage-init='{"centinelAuthenticate": {"frameUrl": "<?php echo $this->getFrameUrl() ?>"}}'> diff --git a/app/code/Magento/Centinel/view/frontend/templates/authentication/complete.phtml b/app/code/Magento/Centinel/view/frontend/templates/authentication/complete.phtml index b340a88ba1aa4be09cbf17ae31016edc30a37e16..3134ce45fc339a52719f06f961add246dab256a9 100644 --- a/app/code/Magento/Centinel/view/frontend/templates/authentication/complete.phtml +++ b/app/code/Magento/Centinel/view/frontend/templates/authentication/complete.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getIsProcessed()):?> <?php if ($this->getIsSuccess()):?> diff --git a/app/code/Magento/Centinel/view/frontend/templates/logo.phtml b/app/code/Magento/Centinel/view/frontend/templates/logo.phtml index 524f227731d75878b9882e4ec803987eb47f35c3..da30f623ad03056b4d822eda3cb35bfe20c5b3c5 100644 --- a/app/code/Magento/Centinel/view/frontend/templates/logo.phtml +++ b/app/code/Magento/Centinel/view/frontend/templates/logo.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="field note <?php echo $this->getCode() ?> logos" id="<?php echo $this->getCode() ?>_centinel_logo"> <label class="label"><span><?php echo __('To ensure the security of your transactions') ?></span></label> diff --git a/app/code/Magento/Checkout/Block/Cart.php b/app/code/Magento/Checkout/Block/Cart.php index 264a3e9cbee2c8dc8500a1fd0d8229815b4d3c9c..6e406dae410fc3f9ce9153bc892039d8b39c77bc 100644 --- a/app/code/Magento/Checkout/Block/Cart.php +++ b/app/code/Magento/Checkout/Block/Cart.php @@ -67,6 +67,7 @@ class Cart extends \Magento\Checkout\Block\Cart\AbstractCart * prepare cart items URLs * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function prepareItemUrls() { @@ -164,6 +165,7 @@ class Cart extends \Magento\Checkout\Block\Cart\AbstractCart /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsVirtual() { diff --git a/app/code/Magento/Checkout/Block/Cart/Item/Renderer.php b/app/code/Magento/Checkout/Block/Cart/Item/Renderer.php index 52470577554de2070fa485b6f9f1f08f3bfb1114..eef597d4fb1dcbfd234c9c929a1e5cf75c892bd7 100644 --- a/app/code/Magento/Checkout/Block/Cart/Item/Renderer.php +++ b/app/code/Magento/Checkout/Block/Cart/Item/Renderer.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Block\Cart\Item; use Magento\Framework\Pricing\PriceCurrencyInterface; @@ -16,6 +19,7 @@ use Magento\Catalog\Pricing\Price\ConfiguredPriceInterface; * * @method \Magento\Checkout\Block\Cart\Item\Renderer setProductName(string) * @method \Magento\Checkout\Block\Cart\Item\Renderer setDeleteUrl(string) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Renderer extends \Magento\Framework\View\Element\Template implements \Magento\Framework\View\Block\IdentityInterface { diff --git a/app/code/Magento/Checkout/Block/Cart/Shipping.php b/app/code/Magento/Checkout/Block/Cart/Shipping.php index 001ddc248292eae0cac92e0b4ee5c2d5e06a6ccc..27f72fb347f391cd41e74da27eb83713e46abd1a 100644 --- a/app/code/Magento/Checkout/Block/Cart/Shipping.php +++ b/app/code/Magento/Checkout/Block/Cart/Shipping.php @@ -196,6 +196,7 @@ class Shipping extends \Magento\Checkout\Block\Cart\AbstractCart * Show City in Shipping Estimation * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCityActive() { @@ -206,6 +207,7 @@ class Shipping extends \Magento\Checkout\Block\Cart\AbstractCart * Show State in Shipping Estimation. Result updated using plugins * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getStateActive() { diff --git a/app/code/Magento/Checkout/Block/Cart/Sidebar.php b/app/code/Magento/Checkout/Block/Cart/Sidebar.php index 32e88ac84006876ef7645cdc56dab462d957903b..a811d6069b6ffe4a1f7469064bb79a7581fe8f87 100644 --- a/app/code/Magento/Checkout/Block/Cart/Sidebar.php +++ b/app/code/Magento/Checkout/Block/Cart/Sidebar.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Block\Cart; use Magento\Framework\View\Block\IdentityInterface; @@ -159,6 +162,7 @@ class Sidebar extends AbstractCart implements IdentityInterface * Get one page checkout page url * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCheckoutUrl() { @@ -169,6 +173,7 @@ class Sidebar extends AbstractCart implements IdentityInterface * Define if Mini Shopping Cart Pop-Up Menu enabled * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsNeedToDisplaySideBar() { diff --git a/app/code/Magento/Checkout/Block/Cart/Sidebar/Totals.php b/app/code/Magento/Checkout/Block/Cart/Sidebar/Totals.php index 90535c979f0b8cb6789fee8c293703a9b9086494..7e3325d7dc9de6b2af54bf31c7e4ccdc877586a7 100644 --- a/app/code/Magento/Checkout/Block/Cart/Sidebar/Totals.php +++ b/app/code/Magento/Checkout/Block/Cart/Sidebar/Totals.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Block\Cart\Sidebar; use Magento\Checkout\Block\Cart\AbstractCart; diff --git a/app/code/Magento/Checkout/Block/Onepage.php b/app/code/Magento/Checkout/Block/Onepage.php index 56adf62ef16d076c65df831d3ad26f0e8abe247f..04aaf4b495b313fef5c9502b82adeede8c7281d2 100644 --- a/app/code/Magento/Checkout/Block/Onepage.php +++ b/app/code/Magento/Checkout/Block/Onepage.php @@ -26,6 +26,7 @@ class Onepage extends \Magento\Checkout\Block\Onepage\AbstractOnepage * @param \Magento\Framework\App\Http\Context $httpContext * @param \Magento\Customer\Model\Address\Mapper $addressMapper * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, diff --git a/app/code/Magento/Checkout/Block/Onepage/AbstractOnepage.php b/app/code/Magento/Checkout/Block/Onepage/AbstractOnepage.php index 9fd1608922ec640ec0e63887aba2f54db59d2efb..941b0425c66f41988d20bd0161fd6706968a2ff6 100644 --- a/app/code/Magento/Checkout/Block/Onepage/AbstractOnepage.php +++ b/app/code/Magento/Checkout/Block/Onepage/AbstractOnepage.php @@ -14,6 +14,7 @@ use Magento\Quote\Model\Quote; /** * One page common functionality block + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractOnepage extends \Magento\Framework\View\Element\Template { @@ -100,6 +101,7 @@ abstract class AbstractOnepage extends \Magento\Framework\View\Element\Template * @param \Magento\Framework\App\Http\Context $httpContext * @param \Magento\Customer\Model\Address\Mapper $addressMapper * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, diff --git a/app/code/Magento/Checkout/Block/Onepage/Billing.php b/app/code/Magento/Checkout/Block/Onepage/Billing.php index fbbbb36a2d16d7bf5b99a3e17b5c657fbcad9b19..13730ef9d302e178f64e8932785230af6897b3a0 100644 --- a/app/code/Magento/Checkout/Block/Onepage/Billing.php +++ b/app/code/Magento/Checkout/Block/Onepage/Billing.php @@ -10,6 +10,7 @@ use Magento\Customer\Model\Address\Config as AddressConfig; /** * One page checkout status + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Billing extends \Magento\Checkout\Block\Onepage\AbstractOnepage { @@ -46,6 +47,7 @@ class Billing extends \Magento\Checkout\Block\Onepage\AbstractOnepage * @param \Magento\Customer\Model\Address\Mapper $addressMapper * @param \Magento\Quote\Model\Quote\AddressFactory $addressFactory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, diff --git a/app/code/Magento/Checkout/Block/Onepage/Failure.php b/app/code/Magento/Checkout/Block/Onepage/Failure.php index a1dd3b59f7be89f2cc87de134ded04b76fc36b25..9d9b37b668bc052b71eb4059a76b4274a4452769 100644 --- a/app/code/Magento/Checkout/Block/Onepage/Failure.php +++ b/app/code/Magento/Checkout/Block/Onepage/Failure.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Block\Onepage; class Failure extends \Magento\Framework\View\Element\Template diff --git a/app/code/Magento/Checkout/Block/Onepage/Login.php b/app/code/Magento/Checkout/Block/Onepage/Login.php index 7dbcee2cbecc502a33726874369a2116249afe28..1d37f5d8b7d095ad516f6539ca47d112bf87fe6a 100644 --- a/app/code/Magento/Checkout/Block/Onepage/Login.php +++ b/app/code/Magento/Checkout/Block/Onepage/Login.php @@ -11,6 +11,7 @@ use Magento\Framework\Message\Collection; /** * One page checkout status + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Login extends AbstractOnepage { @@ -54,6 +55,7 @@ class Login extends AbstractOnepage * @param \Magento\Customer\Model\Registration $registration * @param \Magento\Customer\Model\Address\Mapper $dataObjectConverter * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, diff --git a/app/code/Magento/Checkout/Block/Onepage/Progress.php b/app/code/Magento/Checkout/Block/Onepage/Progress.php index c4500610d03d34e2ec6bf75cd422faf2e69fb78d..81426da154a8ddaec3bd35546653bed4d502b36f 100644 --- a/app/code/Magento/Checkout/Block/Onepage/Progress.php +++ b/app/code/Magento/Checkout/Block/Onepage/Progress.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Block\Onepage; use Magento\Quote\Model\Quote\Address; diff --git a/app/code/Magento/Checkout/Block/Onepage/Shipping.php b/app/code/Magento/Checkout/Block/Onepage/Shipping.php index 24e47b6c0af92a01e13fac0c4f69d88d39fc949b..b17503ac8ab40b8771829681f0c0836e983755cc 100644 --- a/app/code/Magento/Checkout/Block/Onepage/Shipping.php +++ b/app/code/Magento/Checkout/Block/Onepage/Shipping.php @@ -10,6 +10,7 @@ use Magento\Customer\Model\Address\Config as AddressConfig; /** * One page checkout status + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Shipping extends \Magento\Checkout\Block\Onepage\AbstractOnepage { @@ -39,6 +40,7 @@ class Shipping extends \Magento\Checkout\Block\Onepage\AbstractOnepage * @param \Magento\Customer\Model\Address\Mapper $addressMapper * @param \Magento\Quote\Model\Quote\AddressFactory $addressFactory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, diff --git a/app/code/Magento/Checkout/Block/Onepage/Shipping/Method/Available.php b/app/code/Magento/Checkout/Block/Onepage/Shipping/Method/Available.php index ddf87217ce3277140a24b420ca3eb5ed8f63c35d..679f00970c0e2cef87cbfb4004372d6103ec6cc3 100644 --- a/app/code/Magento/Checkout/Block/Onepage/Shipping/Method/Available.php +++ b/app/code/Magento/Checkout/Block/Onepage/Shipping/Method/Available.php @@ -11,6 +11,7 @@ use Magento\Quote\Model\Quote\Address; /** * One page checkout status + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Available extends \Magento\Checkout\Block\Onepage\AbstractOnepage { @@ -37,6 +38,7 @@ class Available extends \Magento\Checkout\Block\Onepage\AbstractOnepage * @param \Magento\Framework\App\Http\Context $httpContext * @param \Magento\Customer\Model\Address\Mapper $addressMapper * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, diff --git a/app/code/Magento/Checkout/Controller/Cart/Add.php b/app/code/Magento/Checkout/Controller/Cart/Add.php index 1bbf5935c112480bc56a9aec82e9b58d2893644d..dc61e5350b9d5e8d3d9d8f18a0ef40a3993a490f 100644 --- a/app/code/Magento/Checkout/Controller/Cart/Add.php +++ b/app/code/Magento/Checkout/Controller/Cart/Add.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Controller\Cart; use Magento\Catalog\Api\ProductRepositoryInterface; @@ -62,6 +65,7 @@ class Add extends \Magento\Checkout\Controller\Cart * Add product to shopping cart action * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Checkout/Controller/Cart/CouponPost.php b/app/code/Magento/Checkout/Controller/Cart/CouponPost.php index 5650f0cfbf62dcde583c5aa8752e325f5f56857b..0cf8613f7b2ea9bb98558dbfa3a10f4a14314a42 100644 --- a/app/code/Magento/Checkout/Controller/Cart/CouponPost.php +++ b/app/code/Magento/Checkout/Controller/Cart/CouponPost.php @@ -50,6 +50,8 @@ class CouponPost extends \Magento\Checkout\Controller\Cart * Initialize coupon * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Checkout/Controller/Cart/Index.php b/app/code/Magento/Checkout/Controller/Cart/Index.php index 456cb28e563e3c7cc8ba49188b9873f5a864838a..144ae3fdeaa81fd34a88381df3a21974b3d7527e 100644 --- a/app/code/Magento/Checkout/Controller/Cart/Index.php +++ b/app/code/Magento/Checkout/Controller/Cart/Index.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Controller\Cart; class Index extends \Magento\Checkout\Controller\Cart diff --git a/app/code/Magento/Checkout/Controller/Cart/UpdateItemOptions.php b/app/code/Magento/Checkout/Controller/Cart/UpdateItemOptions.php index 87d618c17e353a6db23a6b5e9c13785f88131dd3..433300a78fda6cf8b71a95137f4b9b4756e9faa9 100644 --- a/app/code/Magento/Checkout/Controller/Cart/UpdateItemOptions.php +++ b/app/code/Magento/Checkout/Controller/Cart/UpdateItemOptions.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Controller\Cart; class UpdateItemOptions extends \Magento\Checkout\Controller\Cart @@ -12,6 +15,8 @@ class UpdateItemOptions extends \Magento\Checkout\Controller\Cart * Update product configuration for a cart item * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Checkout/Controller/Cart/UpdatePost.php b/app/code/Magento/Checkout/Controller/Cart/UpdatePost.php index 7acd228d0f973ad444eaaf70d708716c4f98511f..094541435b0c20f1bc48585b497dbcf408c21d40 100644 --- a/app/code/Magento/Checkout/Controller/Cart/UpdatePost.php +++ b/app/code/Magento/Checkout/Controller/Cart/UpdatePost.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Controller\Cart; class UpdatePost extends \Magento\Checkout\Controller\Cart diff --git a/app/code/Magento/Checkout/Controller/Onepage.php b/app/code/Magento/Checkout/Controller/Onepage.php index 80dd6750cfe45a62dec44ea023e5a1cd654767e4..0cd64fb99023f9e27bcfc0a36de69364d20b7dc7 100644 --- a/app/code/Magento/Checkout/Controller/Onepage.php +++ b/app/code/Magento/Checkout/Controller/Onepage.php @@ -10,6 +10,9 @@ use Magento\Customer\Api\CustomerRepositoryInterface; use Magento\Framework\App\Action\NotFoundException; use Magento\Framework\App\RequestInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Onepage extends Action { /** @@ -69,6 +72,7 @@ class Onepage extends Action * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig * @param \Magento\Framework\View\LayoutFactory $layoutFactory * @param \Magento\Quote\Model\QuoteRepository $quoteRepository + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Action\Context $context, diff --git a/app/code/Magento/Checkout/Controller/Onepage/SaveOrder.php b/app/code/Magento/Checkout/Controller/Onepage/SaveOrder.php index bb7f400730195cdad1e6c79d8fb8ae74f1efbe3d..6bb7a5e450882e6e51e435e74e9e92a783743019 100644 --- a/app/code/Magento/Checkout/Controller/Onepage/SaveOrder.php +++ b/app/code/Magento/Checkout/Controller/Onepage/SaveOrder.php @@ -12,6 +12,8 @@ class SaveOrder extends \Magento\Checkout\Controller\Onepage * Create order action * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function execute() { @@ -104,7 +106,6 @@ class SaveOrder extends \Magento\Checkout\Controller\Onepage $result['error'] = true; $result['error_messages'] = __('Something went wrong processing your order. Please try again later.'); } - $this->quoteRepository->save($this->getOnepage()->getQuote()); /** * when there is redirect to third party, we don't want to save order yet. * we will save the order in return action. diff --git a/app/code/Magento/Checkout/Controller/Onepage/SavePayment.php b/app/code/Magento/Checkout/Controller/Onepage/SavePayment.php index cda4c37a74be25cda70dedef86c7d15a7bf877e2..d401a79fb575f41952a1be60f3182f2e0d6015ac 100644 --- a/app/code/Magento/Checkout/Controller/Onepage/SavePayment.php +++ b/app/code/Magento/Checkout/Controller/Onepage/SavePayment.php @@ -24,6 +24,7 @@ class SavePayment extends \Magento\Checkout\Controller\Onepage * Sets either redirect or a JSON response * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Checkout/Helper/Cart.php b/app/code/Magento/Checkout/Helper/Cart.php index f6579584e8b3e15104baa37a73f88b7677b9fd10..54705d9d4d1dadf3d3a0359e9c3a88d698d8eeab 100644 --- a/app/code/Magento/Checkout/Helper/Cart.php +++ b/app/code/Magento/Checkout/Helper/Cart.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Helper; /** @@ -191,6 +194,7 @@ class Cart extends \Magento\Core\Helper\Url * Check quote for virtual products only * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsVirtualQuote() { @@ -202,6 +206,7 @@ class Cart extends \Magento\Core\Helper\Url * * @param int|string|\Magento\Store\Model\Store $store * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getShouldRedirectToCart($store = null) { diff --git a/app/code/Magento/Checkout/Helper/Data.php b/app/code/Magento/Checkout/Helper/Data.php index a19e334b56a0e2b2df8a811ecc4468880ada2fdb..145bf276e9c7bd8a976022fd414a0634146d1980 100644 --- a/app/code/Magento/Checkout/Helper/Data.php +++ b/app/code/Magento/Checkout/Helper/Data.php @@ -13,6 +13,7 @@ use Magento\Store\Model\Store; * Checkout default helper * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Data extends \Magento\Framework\App\Helper\AbstractHelper { @@ -207,6 +208,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * @param string $message * @param string $checkoutType * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function sendPaymentFailedEmail($checkout, $message, $checkoutType = 'onepage') { diff --git a/app/code/Magento/Checkout/Model/Cart.php b/app/code/Magento/Checkout/Model/Cart.php index 4b24de9095d46f425b4408976aca9d43fec2c93f..bc7bbb9af1298229279e1a9f45ccc58106fc2ec2 100644 --- a/app/code/Magento/Checkout/Model/Cart.php +++ b/app/code/Magento/Checkout/Model/Cart.php @@ -13,6 +13,7 @@ use Magento\Framework\Object; /** * Shopping cart model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Cart extends Object implements CartInterface { @@ -102,6 +103,7 @@ class Cart extends Object implements CartInterface * @param \Magento\Quote\Model\QuoteRepository $quoteRepository * @param ProductRepositoryInterface $productRepository * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Event\ManagerInterface $eventManager, @@ -330,6 +332,7 @@ class Cart extends Object implements CartInterface * @param \Magento\Framework\Object|int|array $requestInfo * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function addProduct($productInfo, $requestInfo = null) { @@ -473,6 +476,8 @@ class Cart extends Object implements CartInterface * @param array $data * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function updateItems($data) { @@ -657,6 +662,7 @@ class Cart extends Object implements CartInterface * @throws \Magento\Framework\Model\Exception * * @see \Magento\Quote\Model\Quote::updateItem() + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function updateItem($itemId, $requestInfo = null, $updatingParams = null) { diff --git a/app/code/Magento/Checkout/Model/Session.php b/app/code/Magento/Checkout/Model/Session.php index 0081c22fecbebe257705975bd51c5267897c17ad..d647592240822cdf1f22f59fdbfee95e3108f905 100644 --- a/app/code/Magento/Checkout/Model/Session.php +++ b/app/code/Magento/Checkout/Model/Session.php @@ -8,6 +8,9 @@ namespace Magento\Checkout\Model; use Magento\Customer\Api\Data\CustomerInterface; use Magento\Quote\Model\Quote; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Session extends \Magento\Framework\Session\SessionManager { /** @@ -94,6 +97,7 @@ class Session extends \Magento\Framework\Session\SessionManager * @param \Magento\Framework\Event\ManagerInterface $eventManager * @param \Magento\Store\Model\StoreManagerInterface $storeManager * @param \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Request\Http $request, @@ -170,6 +174,8 @@ class Session extends \Magento\Framework\Session\SessionManager * Get checkout quote instance by current session * * @return Quote + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getQuote() { diff --git a/app/code/Magento/Checkout/Model/Type/Onepage.php b/app/code/Magento/Checkout/Model/Type/Onepage.php index 93f7e97ee7acda7bbf509005da525e56ff57122b..c5ee84a6a2e75ab8162f3869c23a92250002b9e6 100644 --- a/app/code/Magento/Checkout/Model/Type/Onepage.php +++ b/app/code/Magento/Checkout/Model/Type/Onepage.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * One page checkout processing model */ @@ -20,6 +22,11 @@ use Magento\Customer\Model\Metadata\Form; use Magento\Framework\Exception\NoSuchEntityException; use Magento\Sales\Model\Order\Email\Sender\OrderSender; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Onepage { /** @@ -192,6 +199,8 @@ class Onepage * @param \Magento\Quote\Model\QuoteRepository $quoteRepository * @param \Magento\Framework\Api\ExtensibleDataObjectConverter $extensibleDataObjectConverter * @param \Magento\Quote\Model\QuoteManagement $quoteManagement + * @SuppressWarnings(PHPMD.ExcessiveParameterList) + * */ public function __construct( \Magento\Framework\Event\ManagerInterface $eventManager, @@ -298,6 +307,7 @@ class Onepage * Initialize quote state to be valid for one page checkout * * @return $this + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function initCheckout() { @@ -372,6 +382,9 @@ class Onepage * @param array $data * @param int $customerAddressId * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function saveBilling($data, $customerAddressId) { @@ -623,6 +636,8 @@ class Onepage * @param array $data * @param int $customerAddressId * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function saveShipping($data, $customerAddressId) { @@ -843,6 +858,7 @@ class Onepage * Prepare quote for customer order submit * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _prepareCustomerQuote() { diff --git a/app/code/Magento/Checkout/Service/V1/Address/Billing/ReadService.php b/app/code/Magento/Checkout/Service/V1/Address/Billing/ReadService.php deleted file mode 100644 index 8b6a70d41742f8d668d3460be9ab046d9de99d0c..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Address/Billing/ReadService.php +++ /dev/null @@ -1,58 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Address\Billing; - -use Magento\Checkout\Service\V1\Address\Converter as AddressConverter; - -/** Quote billing address read service object. */ -class ReadService implements ReadServiceInterface -{ - /** - * Quote repository. - * - * @var \Magento\Quote\Model\QuoteRepository - */ - protected $quoteRepository; - - /** - * Address converter. - * - * @var AddressConverter - */ - protected $addressConverter; - - /** - * Constructs a quote billing address object. - * - * @param \Magento\Quote\Model\QuoteRepository $quoteRepository Quote repository. - * @param AddressConverter $addressConverter Address converter. - */ - public function __construct( - \Magento\Quote\Model\QuoteRepository $quoteRepository, - AddressConverter $addressConverter - ) { - $this->quoteRepository = $quoteRepository; - $this->addressConverter = $addressConverter; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\Address Quote billing address object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getAddress($cartId) - { - /** - * Address. - * - * @var \Magento\Quote\Model\Quote\Address $address - */ - $address = $this->quoteRepository->getActive($cartId)->getBillingAddress(); - return $this->addressConverter->convertModelToDataObject($address); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Address/Billing/ReadServiceInterface.php b/app/code/Magento/Checkout/Service/V1/Address/Billing/ReadServiceInterface.php deleted file mode 100644 index 0aa26f48fa5d1477ba5b31b40e41c2b9eb5a6d97..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Address/Billing/ReadServiceInterface.php +++ /dev/null @@ -1,19 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Address\Billing; - -/** Quote billing address read service interface. */ -interface ReadServiceInterface -{ - /** - * Returns the billing address for a specified quote. - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\Address Quote billing address object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getAddress($cartId); -} diff --git a/app/code/Magento/Checkout/Service/V1/Address/Billing/WriteService.php b/app/code/Magento/Checkout/Service/V1/Address/Billing/WriteService.php deleted file mode 100644 index 52ae8d39ebae405cc45395b1891e2ae764e95ff5..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Address/Billing/WriteService.php +++ /dev/null @@ -1,114 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Address\Billing; - -use Magento\Checkout\Service\V1\Address\Converter; -use Magento\Checkout\Service\V1\Address\Validator; -use Magento\Quote\Model\Quote\AddressFactory; -use Magento\Quote\Model\QuoteRepository; -use Magento\Framework\Exception\InputException; -use Psr\Log\LoggerInterface as Logger; - -/** Quote billing address write service object. */ -class WriteService implements WriteServiceInterface -{ - /** - * Validator. - * - * @var Validator - */ - protected $addressValidator; - - /** - * Logger. - * - * @var Logger - */ - protected $logger; - - /** - * Address factory. - * - * @var AddressFactory - */ - protected $quoteAddressFactory; - - /** - * Converter. - * - * @var Converter - */ - protected $addressConverter; - - /** - * Quote repository. - * - * @var QuoteRepository - */ - protected $quoteRepository; - - /** - * Constructs a quote billing address service object. - * - * @param QuoteRepository $quoteRepository Quote repository. - * @param Converter $addressConverter Address converter. - * @param Validator $addressValidator Address validator. - * @param AddressFactory $quoteAddressFactory Quote address factory. - * @param Logger $logger Logger. - */ - public function __construct( - QuoteRepository $quoteRepository, - Converter $addressConverter, - Validator $addressValidator, - AddressFactory $quoteAddressFactory, - Logger $logger - ) { - $this->addressValidator = $addressValidator; - $this->logger = $logger; - $this->quoteRepository = $quoteRepository; - $this->quoteAddressFactory = $quoteAddressFactory; - $this->addressConverter = $addressConverter; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @param \Magento\Checkout\Service\V1\Data\Cart\Address $addressData Billing address data. - * @return int Address ID. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - * @throws \Magento\Framework\Exception\InputException The specified cart ID or address data is not valid. - */ - public function setAddress($cartId, $addressData) - { - /** - * Quote. - * - * @var \Magento\Quote\Model\Quote $quote - */ - $quote = $this->quoteRepository->getActive($cartId); - /** - * Address. - * - * @var \Magento\Quote\Model\Quote\Address $address - */ - $address = $this->quoteAddressFactory->create(); - $this->addressValidator->validate($addressData); - if ($addressData->getId()) { - $address->load($addressData->getId()); - } - $address = $this->addressConverter->convertDataObjectToModel($addressData, $address); - $quote->setBillingAddress($address); - $quote->setDataChanges(true); - try { - $this->quoteRepository->save($quote); - } catch (\Exception $e) { - $this->logger->critical($e); - throw new InputException('Unable to save address. Please, check input data.'); - } - return $quote->getBillingAddress()->getId(); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Address/Billing/WriteServiceInterface.php b/app/code/Magento/Checkout/Service/V1/Address/Billing/WriteServiceInterface.php deleted file mode 100644 index b8ebd60a726ec6dde78079b8d9e1fd204b097704..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Address/Billing/WriteServiceInterface.php +++ /dev/null @@ -1,23 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Address\Billing; - -/** - * Quote billing address write service interface. - */ -interface WriteServiceInterface -{ - /** - * Assigns a specified billing address to a specified cart. - * - * @param int $cartId The cart ID. - * @param \Magento\Checkout\Service\V1\Data\Cart\Address $addressData Billing address data. - * @return int Address ID. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - * @throws \Magento\Framework\Exception\InputException The specified cart ID or address data is not valid. - */ - public function setAddress($cartId, $addressData); -} diff --git a/app/code/Magento/Checkout/Service/V1/Address/Converter.php b/app/code/Magento/Checkout/Service/V1/Address/Converter.php deleted file mode 100644 index 344c2e9bba3eeba263586d3aba4f4ece8faa504b..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Address/Converter.php +++ /dev/null @@ -1,111 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Address; - -use Magento\Checkout\Service\V1\Data\Cart\Address; -use Magento\Checkout\Service\V1\Data\Cart\AddressBuilder; -use Magento\Checkout\Service\V1\Data\Cart\Address\Region; -use Magento\Customer\Api\CustomerMetadataInterface; -use Magento\Framework\Api\AttributeValue; -use Magento\Framework\Api\SimpleDataObjectConverter; - -/** Quote shipping address converter service. */ -class Converter -{ - /** - * Address builder. - * - * @var AddressBuilder - */ - protected $addressBuilder; - - /** - * Customer metadata service interface. - * - * @var CustomerMetadataInterface - */ - protected $customerMetadata; - - /** - * Constructs a quote shipping address converter service object. - * - * @param AddressBuilder $addressBuilder Address builder. - * @param CustomerMetadataInterface $customerMetadata Metadata service. - */ - public function __construct(AddressBuilder $addressBuilder, CustomerMetadataInterface $customerMetadata) - { - $this->addressBuilder = $addressBuilder; - $this->customerMetadata = $customerMetadata; - } - - /** - * Converts a quote address model to an address data object. - * - * @param \Magento\Quote\Model\Quote\Address $address The quote address model. - * @return \Magento\Checkout\Service\V1\Data\Cart\Address Address data object. - */ - public function convertModelToDataObject(\Magento\Quote\Model\Quote\Address $address) - { - $data = [ - Address::KEY_COUNTRY_ID => $address->getCountryId(), - Address::KEY_ID => $address->getId(), - Address::KEY_CUSTOMER_ID => $address->getCustomerId(), - Address::KEY_REGION => [ - Region::REGION => $address->getRegion(), - Region::REGION_ID => $address->getRegionId(), - Region::REGION_CODE => $address->getRegionCode() - ], - Address::KEY_STREET => $address->getStreet(), - Address::KEY_COMPANY => $address->getCompany(), - Address::KEY_TELEPHONE => $address->getTelephone(), - Address::KEY_FAX => $address->getFax(), - Address::KEY_POSTCODE => $address->getPostcode(), - Address::KEY_CITY => $address->getCity(), - Address::KEY_FIRSTNAME => $address->getFirstname(), - Address::KEY_LASTNAME => $address->getLastname(), - Address::KEY_MIDDLENAME => $address->getMiddlename(), - Address::KEY_PREFIX => $address->getPrefix(), - Address::KEY_SUFFIX => $address->getSuffix(), - Address::KEY_EMAIL => $address->getEmail(), - Address::KEY_VAT_ID => $address->getVatId() - ]; - - foreach ($this->customerMetadata->getCustomAttributesMetadata() as $attributeMetadata) { - $attributeCode = $attributeMetadata->getAttributeCode(); - $method = 'get' . SimpleDataObjectConverter::snakeCaseToUpperCamelCase($attributeCode); - $data[Address::CUSTOM_ATTRIBUTES_KEY][] = - [AttributeValue::ATTRIBUTE_CODE => $attributeCode, AttributeValue::VALUE => $address->$method()]; - } - - return $this->addressBuilder->populateWithArray($data)->create(); - } - - /** - * Converts an address data object to a quote address model. - * - * @param \Magento\Checkout\Service\V1\Data\Cart\Address $dataObject The address data object. - * @param \Magento\Quote\Model\Quote\Address $address The address. - * @return \Magento\Quote\Model\Quote\Address Quote address model. - */ - public function convertDataObjectToModel($dataObject, $address) - { - $address->setData($dataObject->__toArray()); - - //set custom attributes - $customAttributes = $dataObject->getCustomAttributes(); - /** @var \Magento\Framework\Api\AttributeValue $attributeData */ - foreach ($customAttributes as $attributeData) { - $address->setData($attributeData->getAttributeCode(), $attributeData->getValue()); - } - - //set fields with custom logic - $address->setStreet($dataObject->getStreet()); - $address->setRegionId($dataObject->getRegion()->getRegionId()); - $address->setRegion($dataObject->getRegion()->getRegion()); - - return $address; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Address/Shipping/ReadService.php b/app/code/Magento/Checkout/Service/V1/Address/Shipping/ReadService.php deleted file mode 100644 index 600ca9796f1f59d9f4285f8b6d4f04c453df1a2d..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Address/Shipping/ReadService.php +++ /dev/null @@ -1,71 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Address\Shipping; - -use Magento\Checkout\Service\V1\Address\Converter as AddressConverter; -use Magento\Framework\Exception\NoSuchEntityException; - -/** Quote billing address read service object. */ -class ReadService implements ReadServiceInterface -{ - /** - * Quote repository. - * - * @var \Magento\Quote\Model\QuoteRepository - */ - protected $quoteRepository; - - /** - * Address converter. - * - * @var AddressConverter - */ - protected $addressConverter; - - /** - * Constructs a quote billing address read service object. - * - * @param \Magento\Quote\Model\QuoteRepository $quoteRepository Quote repository. - * @param AddressConverter $addressConverter Address converter. - */ - public function __construct( - \Magento\Quote\Model\QuoteRepository $quoteRepository, - AddressConverter $addressConverter - ) { - $this->quoteRepository = $quoteRepository; - $this->addressConverter = $addressConverter; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\Address Shipping address object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getAddress($cartId) - { - /** - * Quote. - * - * @var \Magento\Quote\Model\Quote $quote - */ - $quote = $this->quoteRepository->getActive($cartId); - if ($quote->isVirtual()) { - throw new NoSuchEntityException( - 'Cart contains virtual product(s) only. Shipping address is not applicable' - ); - } - - /** - * Address. - * - * @var \Magento\Quote\Model\Quote\Address $address - */ - $address = $quote->getShippingAddress(); - return $this->addressConverter->convertModelToDataObject($address); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceInterface.php b/app/code/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceInterface.php deleted file mode 100644 index 03cbbd02477c55f96d1652a231a75f88ba4af972..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceInterface.php +++ /dev/null @@ -1,19 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Address\Shipping; - -/** Quote billing address read service interface. */ -interface ReadServiceInterface -{ - /** - * Returns the shipping address for a specified quote. - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\Address Shipping address object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getAddress($cartId); -} diff --git a/app/code/Magento/Checkout/Service/V1/Address/Shipping/WriteService.php b/app/code/Magento/Checkout/Service/V1/Address/Shipping/WriteService.php deleted file mode 100644 index 5382b78b4724f9aab7ff97effc148b2c2146d5bc..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Address/Shipping/WriteService.php +++ /dev/null @@ -1,111 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Address\Shipping; - -use Magento\Framework\Exception\InputException; -use Magento\Framework\Exception\NoSuchEntityException; -use Psr\Log\LoggerInterface as Logger; - -/** Quote shipping address write service object. */ -class WriteService implements WriteServiceInterface -{ - /** - * Quote repository. - * - * @var \Magento\Quote\Model\QuoteRepository - */ - protected $quoteRepository; - - /** - * Quote address factory. - * - * @var \Magento\Quote\Model\Quote\AddressFactory - */ - protected $quoteAddressFactory; - - /** - * Address converter. - * - * @var \Magento\Checkout\Service\V1\Address\Converter - */ - protected $addressConverter; - - /** - * Address validator. - * - * @var \Magento\Checkout\Service\V1\Address\Validator - */ - protected $addressValidator; - - /** - * Logger. - * - * @var Logger - */ - protected $logger; - - /** - * Constructs a quote shipping address write service object. - * - * @param \Magento\Quote\Model\QuoteRepository $quoteRepository Quote repository. - * @param \Magento\Checkout\Service\V1\Address\Converter $addressConverter Address converter. - * @param \Magento\Checkout\Service\V1\Address\Validator $addressValidator Address validator. - * @param \Magento\Quote\Model\Quote\AddressFactory $quoteAddressFactory Quote address factory. - * @param Logger $logger Logger. - */ - public function __construct( - \Magento\Quote\Model\QuoteRepository $quoteRepository, - \Magento\Checkout\Service\V1\Address\Converter $addressConverter, - \Magento\Checkout\Service\V1\Address\Validator $addressValidator, - \Magento\Quote\Model\Quote\AddressFactory $quoteAddressFactory, - Logger $logger - ) { - $this->quoteRepository = $quoteRepository; - $this->quoteAddressFactory = $quoteAddressFactory; - $this->addressConverter = $addressConverter; - $this->addressValidator = $addressValidator; - $this->logger = $logger; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @param \Magento\Checkout\Service\V1\Data\Cart\Address $addressData The shipping address data. - * @return int Address ID. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - * @throws \Magento\Framework\Exception\InputException The specified cart ID or address data is not valid. - */ - public function setAddress($cartId, $addressData) - { - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->getActive($cartId); - if ($quote->isVirtual()) { - throw new NoSuchEntityException( - 'Cart contains virtual product(s) only. Shipping address is not applicable' - ); - } - /** @var \Magento\Quote\Model\Quote\Address $address */ - $address = $this->quoteAddressFactory->create(); - $this->addressValidator->validate($addressData); - if ($addressData->getId()) { - $address->load($addressData->getId()); - } - $address = $this->addressConverter->convertDataObjectToModel($addressData, $address); - $address->setSameAsBilling(0); - $address->setCollectShippingRates(true); - - $quote->setShippingAddress($address); - $quote->setDataChanges(true); - try { - $this->quoteRepository->save($quote); - } catch (\Exception $e) { - $this->logger->critical($e); - throw new InputException('Unable to save address. Please, check input data.'); - } - return $quote->getShippingAddress()->getId(); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceInterface.php b/app/code/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceInterface.php deleted file mode 100644 index 3d0d26860e700a767185f10f7419247ab28dcee7..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceInterface.php +++ /dev/null @@ -1,21 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Address\Shipping; - -/** Quote shipping address write service interface. */ -interface WriteServiceInterface -{ - /** - * Assigns a specified shipping address to a specified cart. - * - * @param int $cartId The cart ID. - * @param \Magento\Checkout\Service\V1\Data\Cart\Address $addressData The shipping address data. - * @return int Address ID. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - * @throws \Magento\Framework\Exception\InputException The specified cart ID or address data is not valid. - */ - public function setAddress($cartId, $addressData); -} diff --git a/app/code/Magento/Checkout/Service/V1/Cart/ReadService.php b/app/code/Magento/Checkout/Service/V1/Cart/ReadService.php deleted file mode 100644 index 2b22baf6e955bc4bdba4fb706214c617349dfe1e..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Cart/ReadService.php +++ /dev/null @@ -1,191 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Cart; - -use Magento\Checkout\Service\V1\Data; -use Magento\Framework\Api\Search\FilterGroup; -use Magento\Framework\Api\SearchCriteria; -use Magento\Framework\Exception\InputException; -use Magento\Quote\Model\Quote; -use Magento\Quote\Model\QuoteRepository; -use Magento\Quote\Model\Resource\Quote\Collection as QuoteCollection; - -/** - * Cart read service object. - */ -class ReadService implements ReadServiceInterface -{ - /** - * Quote repository. - * - * @var QuoteRepository - */ - private $quoteRepository; - - /** - * Quote collection. - * - * @var QuoteCollection - */ - private $quoteCollection; - - /** - * Search results builder. - * - * @var Data\CartSearchResultsBuilder - */ - private $searchResultsBuilder; - - /** - * Cart mapper. - * - * @var Data\CartMapper - */ - private $cartMapper; - - /** - * Array of valid search fields. - * - * @var array - */ - private $validSearchFields = [ - 'id', 'store_id', 'created_at', 'updated_at', 'converted_at', 'is_active', 'is_virtual', - 'items_count', 'items_qty', 'checkout_method', 'reserved_order_id', 'orig_order_id', 'base_grand_total', - 'grand_total', 'base_subtotal', 'subtotal', 'base_subtotal_with_discount', 'subtotal_with_discount', - 'customer_is_guest', 'customer_id', 'customer_group_id', 'customer_id', 'customer_tax_class_id', - 'customer_email', 'global_currency_code', 'base_currency_code', 'store_currency_code', 'quote_currency_code', - 'store_to_base_rate', 'store_to_quote_rate', 'base_to_global_rate', 'base_to_quote_rate', - ]; - - /** - * Cart data object - quote field map. - * - * @var array - */ - private $searchFieldMap = [ - 'id' => 'entity_id', - ]; - - /** - * Constructs a cart read service object. - * - * @param QuoteRepository $quoteRepository Quote repository. - * @param QuoteCollection $quoteCollection Quote collection. - * @param Data\CartSearchResultsBuilder $searchResultsBuilder Search results builder. - * @param Data\CartMapper $cartMapper Cart mapper. - */ - public function __construct( - QuoteRepository $quoteRepository, - QuoteCollection $quoteCollection, - Data\CartSearchResultsBuilder $searchResultsBuilder, - Data\CartMapper $cartMapper - ) { - $this->quoteRepository = $quoteRepository; - $this->quoteCollection = $quoteCollection; - $this->searchResultsBuilder = $searchResultsBuilder; - $this->cartMapper = $cartMapper; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart Cart object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getCart($cartId) - { - $quote = $this->quoteRepository->getActive($cartId); - return $this->cartMapper->map($quote); - } - - /** - * {@inheritDoc} - * - * @param int $customerId The customer ID. - * @return \Magento\Checkout\Service\V1\Data\Cart Cart object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified customer does not exist. - */ - public function getCartForCustomer($customerId) - { - $quote = $this->quoteRepository->getActiveForCustomer($customerId); - return $this->cartMapper->map($quote); - } - - /** - * {@inheritDoc} - * - * @param \Magento\Framework\Api\SearchCriteria $searchCriteria The search criteria. - * @return \Magento\Checkout\Service\V1\Data\CartSearchResults Cart search results object. - */ - public function getCartList(SearchCriteria $searchCriteria) - { - $this->searchResultsBuilder->setSearchCriteria($searchCriteria); - - foreach ($searchCriteria->getFilterGroups() as $group) { - $this->addFilterGroupToCollection($group, $this->quoteCollection); - } - - $this->searchResultsBuilder->setTotalCount($this->quoteCollection->getSize()); - $sortOrders = $searchCriteria->getSortOrders(); - if ($sortOrders) { - foreach ($sortOrders as $sortOrder) { - $this->quoteCollection->addOrder( - $this->getQuoteSearchField($sortOrder->getField()), - $sortOrder->getDirection() == SearchCriteria::SORT_ASC ? 'ASC' : 'DESC' - ); - } - } - $this->quoteCollection->setCurPage($searchCriteria->getCurrentPage()); - $this->quoteCollection->setPageSize($searchCriteria->getPageSize()); - - $cartList = []; - /** @var Quote $quote */ - foreach ($this->quoteCollection as $quote) { - $cartList[] = $this->cartMapper->map($quote); - } - $this->searchResultsBuilder->setItems($cartList); - - return $this->searchResultsBuilder->create(); - } - - /** - * Adds a specified filter group to the specified quote collection. - * - * @param FilterGroup $filterGroup The filter group. - * @param QuoteCollection $collection The quote collection. - * @return void - * @throws InputException The specified filter group or quote collection does not exist. - */ - protected function addFilterGroupToCollection(FilterGroup $filterGroup, QuoteCollection $collection) - { - $fields = []; - $conditions = []; - foreach ($filterGroup->getFilters() as $filter) { - $fields[] = $this->getQuoteSearchField($filter->getField()); - $condition = $filter->getConditionType() ? $filter->getConditionType() : 'eq'; - $conditions[] = [$condition => $filter->getValue()]; - } - if ($fields) { - $collection->addFieldToFilter($fields, $conditions); - } - } - - /** - * Returns a mapped search field. - * - * @param string $field The field. - * @return string Mapped search field. - * @throws InputException The specified field cannot be used for search. - */ - protected function getQuoteSearchField($field) - { - if (!in_array($field, $this->validSearchFields)) { - throw new InputException("Field '{$field}' cannot be used for search."); - } - return isset($this->searchFieldMap[$field]) ? $this->searchFieldMap[$field] : $field; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Cart/ReadServiceInterface.php b/app/code/Magento/Checkout/Service/V1/Cart/ReadServiceInterface.php deleted file mode 100644 index cb6dfda5f03bfc062af26ec0b7f2803398cb4b91..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Cart/ReadServiceInterface.php +++ /dev/null @@ -1,40 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Cart; - -use Magento\Framework\Api\SearchCriteria; - -/** - * Cart read service interface. - */ -interface ReadServiceInterface -{ - /** - * Enables an administrative user to return information for a specified cart. - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart Cart object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getCart($cartId); - - /** - * Returns information for the cart for a specified customer. - * - * @param int $customerId The customer ID. - * @return \Magento\Checkout\Service\V1\Data\Cart Cart object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified customer does not exist. - */ - public function getCartForCustomer($customerId); - - /** - * Enables administrative users to list carts that match specified search criteria. - * - * @param \Magento\Framework\Api\SearchCriteria $searchCriteria The search criteria. - * @return \Magento\Checkout\Service\V1\Data\CartSearchResults Cart search results object. - */ - public function getCartList(SearchCriteria $searchCriteria); -} diff --git a/app/code/Magento/Checkout/Service/V1/Cart/TotalsService.php b/app/code/Magento/Checkout/Service/V1/Cart/TotalsService.php deleted file mode 100644 index 3baa1a8ebc6e802326116787c69e87ef846fbabb..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Cart/TotalsService.php +++ /dev/null @@ -1,90 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Cart; - -use Magento\Checkout\Service\V1\Data\Cart\Totals; -use Magento\Checkout\Service\V1\Data\Cart; -use Magento\Quote\Model\Quote; -use Magento\Quote\Model\QuoteRepository; - -/** - * Cart totals service object. - */ -class TotalsService implements TotalsServiceInterface -{ - /** - * Cart totals builder. - * - * @var Cart\TotalsBuilder - */ - private $totalsBuilder; - - /** - * Cart totals mapper. - * - * @var Cart\TotalsMapper - */ - private $totalsMapper; - - /** - * Quote repository. - * - * @var QuoteRepository - */ - private $quoteRepository; - - /** - * Item totals mapper. - * - * @var Totals\ItemMapper; - */ - private $itemTotalsMapper; - - /** - * Constructs a cart totals service object. - * - * @param Cart\TotalsBuilder $totalsBuilder Cart totals builder. - * @param Cart\TotalsMapper $totalsMapper Cart totals mapper. - * @param QuoteRepository $quoteRepository Quote repository. - * @param Totals\ItemMapper $itemTotalsMapper Item totals mapper. - */ - public function __construct( - Cart\TotalsBuilder $totalsBuilder, - Cart\TotalsMapper $totalsMapper, - QuoteRepository $quoteRepository, - Totals\ItemMapper $itemTotalsMapper - ) { - $this->totalsBuilder = $totalsBuilder; - $this->totalsMapper = $totalsMapper; - $this->quoteRepository = $quoteRepository; - $this->itemTotalsMapper = $itemTotalsMapper; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @return Totals Quote totals data. - */ - public function getTotals($cartId) - { - /** - * Quote. - * - * @var \Magento\Quote\Model\Quote $quote - */ - $quote = $this->quoteRepository->getActive($cartId); - - $this->totalsBuilder->populateWithArray($this->totalsMapper->map($quote)); - $items = []; - foreach ($quote->getAllItems() as $item) { - $items[] = $this->itemTotalsMapper->extractDto($item); - } - $this->totalsBuilder->setItems($items); - - return $this->totalsBuilder->create(); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Cart/WriteService.php b/app/code/Magento/Checkout/Service/V1/Cart/WriteService.php deleted file mode 100644 index 27ef7882906ade4d0fdafd7935c2ed9c524025b4..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Cart/WriteService.php +++ /dev/null @@ -1,188 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Cart; - -use Magento\Authorization\Model\UserContextInterface; -use Magento\Framework\Exception\CouldNotSaveException; -use Magento\Framework\Exception\StateException; - -/** - * Cart write service object. - */ -class WriteService implements WriteServiceInterface -{ - /** - * Quote repository. - * - * @var \Magento\Quote\Model\QuoteRepository - */ - protected $quoteRepository; - - /** - * Store manager interface. - * - * @var \Magento\Store\Model\StoreManagerInterface - */ - protected $storeManager; - - /** - * Customer registry. - * - * @var \Magento\Customer\Api\CustomerRepositoryInterface - */ - protected $customerRepository; - - /** - * User context interface. - * - * @var UserContextInterface - */ - protected $userContext; - - /** - * Quote factory. - * - * @var \Magento\Quote\Model\QuoteManagement - */ - protected $quoteServiceFactory; - - /** - * @var \Magento\Customer\Model\CustomerFactory - */ - protected $customerModelFactory; - - /** - * Constructs a cart write service object. - * - * @param \Magento\Quote\Model\QuoteRepository $quoteRepository Quote repository. - * @param \Magento\Store\Model\StoreManagerInterface $storeManager Store manager. - * @param \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository Customer registry. - * @param UserContextInterface $userContext User context. - * @param \Magento\Quote\Model\QuoteManagement $quoteServiceFactory Quote service factory. - * @param \Magento\Customer\Model\CustomerFactory $customerModelFactory - */ - public function __construct( - \Magento\Quote\Model\QuoteRepository $quoteRepository, - \Magento\Store\Model\StoreManagerInterface $storeManager, - \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository, - UserContextInterface $userContext, - \Magento\Quote\Model\QuoteManagement $quoteServiceFactory, - \Magento\Customer\Model\CustomerFactory $customerModelFactory - ) { - $this->quoteRepository = $quoteRepository; - $this->storeManager = $storeManager; - $this->customerRepository = $customerRepository; - $this->userContext = $userContext; - $this->quoteServiceFactory = $quoteServiceFactory; - $this->customerModelFactory = $customerModelFactory; - } - - /** - * {@inheritDoc} - * - * @throws \Magento\Framework\Exception\CouldNotSaveException The empty cart and quote could not be created. - * @return int Cart ID. - */ - public function create() - { - $quote = $this->userContext->getUserType() == UserContextInterface::USER_TYPE_CUSTOMER - ? $this->createCustomerCart() - : $this->createAnonymousCart(); - - try { - $this->quoteRepository->save($quote); - } catch (\Exception $e) { - throw new CouldNotSaveException('Cannot create quote'); - } - return $quote->getId(); - } - - /** - * Creates an anonymous cart. - * - * @return \Magento\Quote\Model\Quote Cart object. - */ - protected function createAnonymousCart() - { - $storeId = $this->storeManager->getStore()->getId(); - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->create(); - $quote->setStoreId($storeId); - return $quote; - } - - /** - * Creates a cart for the currently logged-in customer. - * - * @return \Magento\Quote\Model\Quote Cart object. - * @throws CouldNotSaveException The cart could not be created. - */ - protected function createCustomerCart() - { - $storeId = $this->storeManager->getStore()->getId(); - $customer = $this->customerRepository->getById($this->userContext->getUserId()); - - try { - $this->quoteRepository->getActiveForCustomer($this->userContext->getUserId()); - throw new CouldNotSaveException('Cannot create quote'); - } catch (\Magento\Framework\Exception\NoSuchEntityException $e) { - } - - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->create(); - $quote->setStoreId($storeId); - $quote->setCustomer($customer); - $quote->setCustomerIsGuest(0); - return $quote; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @param int $customerId The customer ID. - * @return boolean - * @throws \Magento\Framework\Exception\StateException The customer cannot be assigned to the specified cart: The cart belongs to a different store or is not anonymous, or the customer already has an active cart. - */ - public function assignCustomer($cartId, $customerId) - { - $storeId = $this->storeManager->getStore()->getId(); - $quote = $this->quoteRepository->getActive($cartId); - $customer = $this->customerRepository->getById($customerId); - $customerModel = $this->customerModelFactory->create(); - - if (!in_array($storeId, $customerModel->load($customerId)->getSharedStoreIds())) { - throw new StateException('Cannot assign customer to the given cart. The cart belongs to different store.'); - } - if ($quote->getCustomerId()) { - throw new StateException('Cannot assign customer to the given cart. The cart is not anonymous.'); - } - try { - $this->quoteRepository->getForCustomer($customerId); - throw new StateException('Cannot assign customer to the given cart. Customer already has active cart.'); - } catch (\Magento\Framework\Exception\NoSuchEntityException $e) { - } - - $quote->setCustomer($customer); - $quote->setCustomerIsGuest(0); - $this->quoteRepository->save($quote); - return true; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @return int Order ID. - */ - public function order($cartId) - { - $quote = $this->quoteRepository->getActive($cartId); - $order = $this->quoteServiceFactory->submit($quote); - return $order->getId(); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Coupon/ReadService.php b/app/code/Magento/Checkout/Service/V1/Coupon/ReadService.php deleted file mode 100644 index ecb614bbf56b1116e68812d13efbd8d158281903..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Coupon/ReadService.php +++ /dev/null @@ -1,59 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Coupon; - -use Magento\Checkout\Service\V1\Data\Cart\Coupon as Coupon; -use Magento\Checkout\Service\V1\Data\Cart\CouponBuilder as CouponBuilder; - -/** - * Coupon read service object. - */ -class ReadService implements ReadServiceInterface -{ - /** - * Quote repository. - * - * @var \Magento\Quote\Model\QuoteRepository - */ - protected $quoteRepository; - - /** - * Coupon builder. - * - * @var CouponBuilder - */ - protected $couponBuilder; - - /** - * Constructs a coupon read service object. - * - * @param \Magento\Quote\Model\QuoteRepository $quoteRepository Quote repository. - * @param CouponBuilder $couponBuilder Coupon builder. - */ - public function __construct( - \Magento\Quote\Model\QuoteRepository $quoteRepository, - CouponBuilder $couponBuilder - ) { - $this->quoteRepository = $quoteRepository; - $this->couponBuilder = $couponBuilder; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\Coupon Coupon object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function get($cartId) - { - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->getActive($cartId); - $data = [Coupon::COUPON_CODE => $quote->getCouponCode()]; - $output = $this->couponBuilder->populateWithArray($data)->create(); - return $output; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Coupon/ReadServiceInterface.php b/app/code/Magento/Checkout/Service/V1/Coupon/ReadServiceInterface.php deleted file mode 100644 index d53b27d44d28e8955d75e2af48022c7a67a60285..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Coupon/ReadServiceInterface.php +++ /dev/null @@ -1,21 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Coupon; - -/** - * Coupon read service interface. - */ -interface ReadServiceInterface -{ - /** - * Returns information for a coupon in a specified cart. - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\Coupon Coupon object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function get($cartId); -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart.php b/app/code/Magento/Checkout/Service/V1/Data/Cart.php deleted file mode 100644 index d40daaec534cde2ebf0789ed76d34dce81af8580..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart.php +++ /dev/null @@ -1,296 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data; - -/** - * Cart data object. - * - * @codeCoverageIgnore - */ -class Cart extends \Magento\Framework\Api\AbstractExtensibleObject -{ - /** - * Cart ID. - */ - const ID = 'id'; - - /** - * ID of the store where the cart was created. - */ - const STORE_ID = 'store_id'; - - /** - * Cart creation date and time. - */ - const CREATED_AT = 'created_at'; - - /** - * Cart last update date and time. - */ - const UPDATED_AT = 'updated_at'; - - /** - * Cart conversion date and time. - */ - const CONVERTED_AT = 'converted_at'; - - /** - * Flag that shows whether the cart is still active. - */ - const IS_ACTIVE = 'is_active'; - - /** - * Flag that shows whether the cart is virtual. A virtual cart contains virtual items. - */ - const IS_VIRTUAL = 'is_virtual'; - - /** - * List of cart items. - */ - const ITEMS = 'items'; - - /** - * Number of different items or products in the cart. - */ - const ITEMS_COUNT = 'items_count'; - - /** - * Total quantity of all cart items. - */ - const ITEMS_QUANTITY = 'items_qty'; - - /** - * Information about the customer who is assigned to the cart. - */ - const CUSTOMER = 'customer'; - - /** - * Payment method that is used to process the cart. - */ - const CHECKOUT_METHOD = 'checkout_method'; - - /** - * Cart shipping address. - */ - const SHIPPING_ADDRESS = 'shipping_address'; - - /** - * Cart billing address. - */ - const BILLING_ADDRESS = 'shipping_address'; - - /** - * Information about cart totals. - */ - const TOTALS = 'totals'; - - /** - * The order ID that is reserved for the cart. - */ - const RESERVED_ORDER_ID = 'reserved_order_id'; - - /** - * Original order ID. - */ - const ORIG_ORDER_ID = 'orig_order_id'; - - /** - * Information about the quote currency, such as code, exchange rates, and so on. - */ - const CURRENCY = 'currency'; - - /** - * Returns the cart/quote ID. - * - * @return int Cart/quote ID. - */ - public function getId() - { - return $this->_get(self::ID); - } - - /** - * Returns the store ID for the store where the cart was created. - * - * @return int|null Store ID. Otherwise, null. - */ - public function getStoreId() - { - return $this->_get(self::STORE_ID); - } - - /** - * Returns the cart creation date and time. - * - * @return string|null Cart creation date and time. Otherwise, null. - */ - public function getCreatedAt() - { - return $this->_get(self::CREATED_AT); - } - - /** - * Returns the cart last update date and time. - * - * @return string|null Cart last update date and time. Otherwise, null. - */ - public function getUpdatedAt() - { - return $this->_get(self::UPDATED_AT); - } - - /** - * Returns the cart conversion date and time. - * - * @return string|null Cart conversion date and time. Otherwise, null. - */ - public function getConvertedAt() - { - return $this->_get(self::CONVERTED_AT); - } - - /** - * Determines whether the cart is still active. - * - * @return bool|null Active status flag value. Otherwise, null. - */ - public function getIsActive() - { - $value = $this->_get(self::IS_ACTIVE); - if (!is_null($value)) { - $value = (bool)$value; - } - - return $value; - } - - /** - * Determines whether the cart is a virtual cart. - * - * A virtual cart contains virtual items. - * - * @return bool|null Virtual flag value. Otherwise, null. - */ - public function getIsVirtual() - { - $value = $this->_get(self::IS_VIRTUAL); - if (!is_null($value)) { - $value = (bool)$value; - } - - return $value; - } - - /** - * Lists items in the cart. - * - * @return \Magento\Checkout\Service\V1\Data\Cart\Item[]|null Array of items. Otherwise, null. - */ - public function getItems() - { - return $this->_get(self::ITEMS); - } - - /** - * Returns the number of different items or products in the cart. - * - * @return int|null Number of different items or products in the cart. Otherwise, null. - */ - public function getItemsCount() - { - return $this->_get(self::ITEMS_COUNT); - } - - /** - * Returns the total quantity of all cart items. - * - * @return float|null Total quantity of all cart items. Otherwise, null. - */ - public function getItemsQty() - { - return $this->_get(self::ITEMS_QUANTITY); - } - - /** - * Returns information about the customer who is assigned to the cart. - * - * @return \Magento\Checkout\Service\V1\Data\Cart\Customer Information about the customer who is assigned to the cart. - */ - public function getCustomer() - { - return $this->_get(self::CUSTOMER); - } - - /** - * Returns the payment method that is used to process the cart. - * - * @return string|null Payment method. Otherwise, null. - */ - public function getCheckoutMethod() - { - return $this->_get(self::CHECKOUT_METHOD); - } - - /** - * Returns the cart shipping address. - * - * @return \Magento\Checkout\Service\V1\Data\Cart\Address|null Cart shipping address. Otherwise, null. - */ - public function getShippingAddress() - { - return $this->_get(self::SHIPPING_ADDRESS); - } - - /** - * Returns the cart billing address. - * - * @return \Magento\Checkout\Service\V1\Data\Cart\Address|null Cart billing address. Otherwise, null. - */ - public function getBillingAddress() - { - return $this->_get(self::BILLING_ADDRESS); - } - - /** - * Returns information about cart totals. - * - * @return \Magento\Checkout\Service\V1\Data\Cart\Totals|null Information about cart totals. Otherwise, null. - */ - public function getTotals() - { - return $this->_get(self::TOTALS); - } - - /** - * Returns the reserved order ID for the cart. - * - * @return string|null Reserved order ID. Otherwise, null. - */ - public function getReservedOrderId() - { - return $this->_get(self::RESERVED_ORDER_ID); - } - - /** - * Returns the original order ID for the cart. - * - * @return string|null Original order ID. Otherwise, null. - */ - public function getOrigOrderId() - { - return $this->_get(self::ORIG_ORDER_ID); - } - - /** - * Returns information about quote currency, such as code, exchange rate, and so on. - * - * @return \Magento\Checkout\Service\V1\Data\Cart\Currency|null Quote currency information. Otherwise, null. - */ - public function getCurrency() - { - return $this->_get(self::CURRENCY); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/Address/Region.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/Address/Region.php deleted file mode 100644 index e461b12aa9ad36fd96b27fb159944b7aeed4f128..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/Address/Region.php +++ /dev/null @@ -1,62 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\Cart\Address; - -/** - * @codeCoverageIgnore - */ -class Region extends \Magento\Framework\Api\AbstractExtensibleObject -{ - /**#@+ - * Array keys - */ - /** - * Region code. - */ - const REGION_CODE = 'region_code'; - - /** - * Region name. - */ - const REGION = 'region'; - - /** - * Region ID. - */ - const REGION_ID = 'region_id'; - - /**#@-*/ - - /** - * Returns the region code. - * - * @return string Region code. - */ - public function getRegionCode() - { - return $this->_get(self::REGION_CODE); - } - - /** - * Returns the region name. - * - * @return string Region. - */ - public function getRegion() - { - return $this->_get(self::REGION); - } - - /** - * Returns the region ID. - * - * @return int Region ID. - */ - public function getRegionId() - { - return $this->_get(self::REGION_ID); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/AddressBuilder.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/AddressBuilder.php deleted file mode 100644 index 02a37e8f28ed49c2283793b4f414697d8b874969..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/AddressBuilder.php +++ /dev/null @@ -1,261 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\Cart; - -use Magento\Checkout\Service\V1\Data\Cart\Address\Region; -use Magento\Checkout\Service\V1\Data\Cart\Address\RegionBuilder; -use Magento\Customer\Api\CustomerMetadataInterface; -use Magento\Framework\Api\ExtensibleObjectBuilder; -use Magento\Framework\Api\AttributeDataBuilder; - -/** - * Quote address data object builder - * - * @codeCoverageIgnore - */ -class AddressBuilder extends ExtensibleObjectBuilder -{ - /** - * Region builder - * - * @var \Magento\Checkout\Service\V1\Data\Cart\Address\RegionBuilder - */ - protected $_regionBuilder; - - /** - * @param \Magento\Framework\Api\ObjectFactory $objectFactory - * @param AttributeDataBuilder $valueBuilder - * @param CustomerMetadataInterface $metadataService - * @param RegionBuilder $regionBuilder - */ - public function __construct( - \Magento\Framework\Api\ObjectFactory $objectFactory, - AttributeDataBuilder $valueBuilder, - CustomerMetadataInterface $metadataService, - RegionBuilder $regionBuilder - ) { - parent::__construct($objectFactory, $valueBuilder, $metadataService); - $this->_regionBuilder = $regionBuilder; - $this->data[Address::KEY_REGION] = $regionBuilder->create(); - } - - /** - * Convenience method to return region builder - * - * @return RegionBuilder - */ - public function getRegionBuilder() - { - return $this->_regionBuilder; - } - - /** - * Set id - * - * @param int $id - * @return $this - */ - public function setId($id) - { - return $this->_set(Address::KEY_ID, $id); - } - - /** - * {@inheritdoc} - */ - protected function _setDataValues(array $data) - { - if (array_key_exists(Address::KEY_REGION, $data)) { - if (!is_array($data[Address::KEY_REGION])) { - // Region data has been submitted as individual keys of Address object. Let's extract it. - $regionData = []; - foreach ([Region::REGION, Region::REGION_CODE, Region::REGION_ID] as $attrCode) { - if (isset($data[$attrCode])) { - $regionData[$attrCode] = $data[$attrCode]; - } - } - } else { - $regionData = $data[Address::KEY_REGION]; - } - $data[Address::KEY_REGION] = $this->_regionBuilder->populateWithArray($regionData)->create(); - } - return parent::_setDataValues($data); - } - - /** - * Set region - * - * @param \Magento\Checkout\Service\V1\Data\Cart\Address\Region $region - * @return $this - */ - public function setRegion(\Magento\Checkout\Service\V1\Data\Cart\Address\Region $region) - { - return $this->_set(Address::KEY_REGION, $region); - } - - /** - * Set country id - * - * @param int $countryId - * @return $this - */ - public function setCountryId($countryId) - { - return $this->_set(Address::KEY_COUNTRY_ID, $countryId); - } - - /** - * Set street - * - * @param string[] $street - * @return $this - */ - public function setStreet($street) - { - return $this->_set(Address::KEY_STREET, $street); - } - - /** - * Set company - * - * @param string $company - * @return $this - */ - public function setCompany($company) - { - return $this->_set(Address::KEY_COMPANY, $company); - } - - /** - * Set telephone number - * - * @param string $telephone - * @return $this - */ - public function setTelephone($telephone) - { - return $this->_set(Address::KEY_TELEPHONE, $telephone); - } - - /** - * Set fax number - * - * @param string $fax - * @return $this - */ - public function setFax($fax) - { - return $this->_set(Address::KEY_FAX, $fax); - } - - /** - * Set postcode - * - * @param string $postcode - * @return $this - */ - public function setPostcode($postcode) - { - return $this->_set(Address::KEY_POSTCODE, $postcode); - } - - /** - * Set city name - * - * @param string $city - * @return $this - */ - public function setCity($city) - { - return $this->_set(Address::KEY_CITY, $city); - } - - /** - * Set first name - * - * @param string $firstname - * @return $this - */ - public function setFirstname($firstname) - { - return $this->_set(Address::KEY_FIRSTNAME, $firstname); - } - - /** - * Set last name - * - * @param string $lastname - * @return $this - */ - public function setLastname($lastname) - { - return $this->_set(Address::KEY_LASTNAME, $lastname); - } - - /** - * Set middle name - * - * @param string $middlename - * @return $this - */ - public function setMiddlename($middlename) - { - return $this->_set(Address::KEY_MIDDLENAME, $middlename); - } - - /** - * Set prefix - * - * @param string $prefix - * @return $this - */ - public function setPrefix($prefix) - { - return $this->_set(Address::KEY_PREFIX, $prefix); - } - - /** - * Set suffix - * - * @param string $suffix - * @return $this - */ - public function setSuffix($suffix) - { - return $this->_set(Address::KEY_SUFFIX, $suffix); - } - - /** - * Set Vat id - * - * @param string $vatId - * @return $this - */ - public function setVatId($vatId) - { - return $this->_set(Address::KEY_VAT_ID, $vatId); - } - - /** - * Set customer id - * - * @param string $customerId - * @return $this - */ - public function setCustomerId($customerId) - { - return $this->_set(Address::KEY_CUSTOMER_ID, $customerId); - } - - /** - * @param $value string - * @return $this - */ - public function setEmail($value) - { - return $this->_set(Address::KEY_EMAIL, $value); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/Coupon.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/Coupon.php deleted file mode 100644 index 539c388bcaf50388d848abf355b967890023e9c3..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/Coupon.php +++ /dev/null @@ -1,29 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\Cart; - -/** - * Coupon data for quote. - * - * @codeCoverageIgnore - */ -class Coupon extends \Magento\Framework\Api\AbstractExtensibleObject -{ - /** - * Coupon code. - */ - const COUPON_CODE = 'coupon_code'; - - /** - * Returns the coupon code. - * - * @return string Coupon code. - */ - public function getCouponCode() - { - return $this->_get(self::COUPON_CODE); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/CouponBuilder.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/CouponBuilder.php deleted file mode 100644 index 455d6f1f601d7757fa89c35a04ce10bb0651e09c..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/CouponBuilder.php +++ /dev/null @@ -1,23 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Data\Cart; - -/** - * @codeCoverageIgnore - */ -class CouponBuilder extends \Magento\Framework\Api\ExtensibleObjectBuilder -{ - /** - * @param string $value - * @return $this - */ - public function setCouponCode($value) - { - $this->_set(Coupon::COUPON_CODE, $value); - return $this; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/Currency.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/Currency.php deleted file mode 100644 index 4216bcfb595f184a71e0fdd30157da1fe2621b6d..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/Currency.php +++ /dev/null @@ -1,110 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\Cart; - -/** - * Currency data for quote - * - * @codeCoverageIgnore - */ -class Currency extends \Magento\Framework\Api\AbstractExtensibleObject -{ - const GLOBAL_CURRENCY_CODE = 'global_currency_code'; - - const BASE_CURRENCY_CODE = 'base_currency_code'; - - const STORE_CURRENCY_CODE = 'store_currency_code'; - - const QUOTE_CURRENCY_CODE = 'quote_currency_code'; - - const STORE_TO_BASE_RATE = 'store_to_base_rate'; - - const STORE_TO_QUOTE_RATE = 'store_to_quote_rate'; - - const BASE_TO_GLOBAL_RATE = 'base_to_global_rate'; - - const BASE_TO_QUOTE_RATE = 'base_to_quote_rate'; - - /** - * Get global currency code - * - * @return string|null - */ - public function getGlobalCurrencyCode() - { - return $this->_get(self::GLOBAL_CURRENCY_CODE); - } - - /** - * Get base currency code - * - * @return string|null - */ - public function getBaseCurrencyCode() - { - return $this->_get(self::BASE_CURRENCY_CODE); - } - - /** - * Get store currency code - * - * @return string|null - */ - public function getStoreCurrencyCode() - { - return $this->_get(self::STORE_CURRENCY_CODE); - } - - /** - * Get quote currency code - * - * @return string|null - */ - public function getQuoteCurrencyCode() - { - return $this->_get(self::QUOTE_CURRENCY_CODE); - } - - /** - * Get store currency to base currency rate - * - * @return float|null - */ - public function getStoreToBaseRate() - { - return $this->_get(self::STORE_TO_BASE_RATE); - } - - /** - * Get store currency to quote currency rate - * - * @return float|null - */ - public function getStoreToQuoteRate() - { - return $this->_get(self::STORE_TO_QUOTE_RATE); - } - - /** - * Get base currency to global currency rate - * - * @return float|null - */ - public function getBaseToGlobalRate() - { - return $this->_get(self::BASE_TO_GLOBAL_RATE); - } - - /** - * Get base currency to quote currency rate - * - * @return float|null - */ - public function getBaseToQuoteRate() - { - return $this->_get(self::BASE_TO_QUOTE_RATE); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/Customer.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/Customer.php deleted file mode 100644 index 30275de8afa9a10fd1ccf198e98e06b3bbf22aab..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/Customer.php +++ /dev/null @@ -1,200 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\Cart; - -/** - * Customer data for quote. - * - * @codeCoverageIgnore - */ -class Customer extends \Magento\Framework\Api\AbstractExtensibleObject -{ - /** - * Customer ID. - */ - const ID = 'id'; - - /** - * Customer tax class ID. - */ - const TAX_CLASS_ID = 'tax_class_id'; - - const GROUP_ID = 'group_id'; - - const EMAIL = 'email'; - - const PREFIX = 'prefix'; - - const FIRST_NAME = 'first_name'; - - const MIDDLE_NAME = 'middle_name'; - - const LAST_NAME = 'last_name'; - - const SUFFIX = 'suffix'; - - const DOB = 'dob'; - - const NOTE = 'note'; - - const NOTE_NOTIFY = 'note_notify'; - - const IS_GUEST = 'is_guest'; - - const TAXVAT = 'taxvat'; - - const GENDER = 'gender'; - - /** - * Get customer id - * - * @return int|null - */ - public function getId() - { - return $this->_get(self::ID); - } - - /** - * Get customer tax class id - * - * @return int|null - */ - public function getTaxClassId() - { - return $this->_get(self::TAX_CLASS_ID); - } - - /** - * Get customer group id - * - * @return int|null - */ - public function getGroupId() - { - return $this->_get(self::GROUP_ID); - } - - /** - * Get customer email - * - * @return string|null - */ - public function getEmail() - { - return $this->_get(self::EMAIL); - } - - /** - * Get customer name prefix - * - * @return string|null - */ - public function getPrefix() - { - return $this->_get(self::PREFIX); - } - - /** - * Get customer first name - * - * @return string|null - */ - public function getFirstName() - { - return $this->_get(self::FIRST_NAME); - } - - /** - * Get customer middle name - * - * @return string|null - */ - public function getMiddleName() - { - return $this->_get(self::MIDDLE_NAME); - } - - /** - * Get customer last name - * - * @return string|null - */ - public function getLastName() - { - return $this->_get(self::LAST_NAME); - } - - /** - * Get customer name suffix - * - * @return string|null - */ - public function getSuffix() - { - return $this->_get(self::SUFFIX); - } - - /** - * Get customer date of birth - * - * @return string|null - */ - public function getDob() - { - return $this->_get(self::DOB); - } - - /** - * Get note - * - * @return string|null - */ - public function getNote() - { - return $this->_get(self::NOTE); - } - - /** - * Get notification status - * - * @return string|null - */ - public function getNoteNotify() - { - return $this->_get(self::NOTE_NOTIFY); - } - - /** - * Is customer a guest? - * - * @return bool - */ - public function getIsGuest() - { - return (bool)$this->_get(self::IS_GUEST); - } - - /** - * Get taxvat value - * - * @return string|null - */ - public function getTaxVat() - { - return $this->_get(self::TAXVAT); - } - - /** - * Get gender - * - * @return string|null - */ - public function getGender() - { - return $this->_get(self::GENDER); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/CustomerBuilder.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/CustomerBuilder.php deleted file mode 100644 index 4d4d2fbc2636451ad165f2c2ca435ae13a935e33..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/CustomerBuilder.php +++ /dev/null @@ -1,179 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\Cart; - -/** - * Customer data builder for quote - * - * @codeCoverageIgnore - */ -class CustomerBuilder extends \Magento\Framework\Api\ExtensibleObjectBuilder -{ - /** - * Set customer id - * - * @param int|null $value - * @return $this - */ - public function setId($value) - { - return $this->_set(Customer::ID, $value); - } - - /** - * Set customer tax class id - * - * @param int|null $value - * @return $this - */ - public function setTaxClassId($value) - { - return $this->_set(Customer::TAX_CLASS_ID, $value); - } - - /** - * Set customer group id - * - * @param int|null $value - * @return $this - */ - public function setGroupId($value) - { - return $this->_set(Customer::GROUP_ID, $value); - } - - /** - * Set customer email - * - * @param string|null $value - * @return $this - */ - public function setEmail($value) - { - return $this->_set(Customer::EMAIL, $value); - } - - /** - * Set customer name prefix - * - * @param string|null $value - * @return $this - */ - public function setPrefix($value) - { - return $this->_set(Customer::PREFIX, $value); - } - - /** - * Set customer first name - * - * @param string|null $value - * @return $this - */ - public function setFirstName($value) - { - return $this->_set(Customer::FIRST_NAME, $value); - } - - /** - * Set customer middle name - * - * @param string|null $value - * @return $this - */ - public function setMiddleName($value) - { - return $this->_set(Customer::MIDDLE_NAME, $value); - } - - /** - * Set customer last name - * - * @param string|null $value - * @return $this - */ - public function setLastName($value) - { - return $this->_set(Customer::LAST_NAME, $value); - } - - /** - * Set customer name suffix - * - * @param string|null $value - * @return $this - */ - public function setSuffix($value) - { - return $this->_set(Customer::SUFFIX, $value); - } - - /** - * Set customer date of birth - * - * @param string|null $value - * @return $this - */ - public function setDob($value) - { - return $this->_set(Customer::DOB, $value); - } - - /** - * Set note - * - * @param string|null $value - * @return $this - */ - public function setNote($value) - { - return $this->_set(Customer::NOTE, $value); - } - - /** - * Set notification status - * - * @param string|null $value - * @return $this - */ - public function setNoteNotify($value) - { - return $this->_set(Customer::NOTE_NOTIFY, $value); - } - - /** - * Is customer a guest? - * - * @param bool $value - * @return $this - */ - public function setIsGuest($value) - { - return (bool)$this->_set(Customer::IS_GUEST, $value); - } - - /** - * Get taxvat value - * - * @param string $value - * @return $this - */ - public function setTaxVat($value) - { - return $this->_set(Customer::TAXVAT, $value); - } - - /** - * Get gender - * - * @param string $value - * @return $this - */ - public function setGender($value) - { - return $this->_set(Customer::GENDER, $value); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/CustomerMapper.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/CustomerMapper.php deleted file mode 100644 index 9a40d51b2d52cd9be23164a6780cb1f10abbbae2..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/CustomerMapper.php +++ /dev/null @@ -1,41 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\Cart; - -use Magento\Quote\Model\Quote; - -/** - * Cart mapper - */ -class CustomerMapper -{ - /** - * Fetch quote customer data - * - * @param Quote $quote - * @return array - */ - public function map(Quote $quote) - { - return [ - Customer::ID => $quote->getCustomerId(), - Customer::EMAIL => $quote->getCustomerEmail(), - Customer::GROUP_ID => $quote->getCustomerGroupId(), - Customer::TAX_CLASS_ID => $quote->getCustomerTaxClassId(), - Customer::PREFIX => $quote->getCustomerPrefix(), - Customer::FIRST_NAME => $quote->getCustomerFirstname(), - Customer::MIDDLE_NAME => $quote->getCustomerMiddlename(), - Customer::LAST_NAME => $quote->getCustomerLastname(), - Customer::SUFFIX => $quote->getCustomerSuffix(), - Customer::DOB => $quote->getCustomerDob(), - Customer::NOTE => $quote->getCustomerNote(), - Customer::NOTE_NOTIFY => $quote->getCustomerNoteNotify(), - Customer::IS_GUEST => $quote->getCustomerIsGuest(), - Customer::GENDER => $quote->getCustomerGender(), - Customer::TAXVAT => $quote->getCustomerTaxvat() - ]; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/Item.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/Item.php deleted file mode 100644 index 4307cfb5fb6d73145b2e1d4c27e63f0987f41741..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/Item.php +++ /dev/null @@ -1,105 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Data\Cart; - -/** - * Shopping cart item data object. - * - * @codeCoverageIgnore - */ -class Item extends \Magento\Framework\Api\AbstractExtensibleObject -{ - /** - * Item ID. - */ - const ITEM_ID = 'item_id'; - - /** - * Product SKU. - */ - const SKU = 'sku'; - - /** - * Product quantity. - */ - const QTY = 'qty'; - - /** - * Product name. - */ - const NAME = 'name'; - - /** - * Product price. - */ - const PRICE = 'price'; - - /** - * Product type. - */ - const PRODUCT_TYPE = 'product_type'; - - /** - * Returns the item ID. - * - * @return int|null Item ID. Otherwise, null. - */ - public function getItemId() - { - return $this->_get(self::ITEM_ID); - } - - /** - * Returns the product SKU. - * - * @return string|null Product SKU. Otherwise, null. - */ - public function getSku() - { - return $this->_get(self::SKU); - } - - /** - * Returns the product quantity. - * - * @return int Product quantity. - */ - public function getQty() - { - return $this->_get(self::QTY); - } - - /** - * Returns the product name. - * - * @return string|null Product name. Otherwise, null. - */ - public function getName() - { - return $this->_get(self::NAME); - } - - /** - * Returns the product price. - * - * @return float|null Product price. Otherwise, null. - */ - public function getPrice() - { - return $this->_get(self::PRICE); - } - - /** - * Returns the product type. - * - * @return string|null Product type. Otherwise, null. - */ - public function getProductType() - { - return $this->_get(self::PRODUCT_TYPE); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/PaymentMethod.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/PaymentMethod.php deleted file mode 100644 index cc5fa54eafb3d73127ff96ae15c12f480d95b8c6..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/PaymentMethod.php +++ /dev/null @@ -1,133 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Data\Cart; - -/** - * @codeCoverageIgnore - */ -class PaymentMethod extends \Magento\Framework\Api\AbstractExtensibleObject -{ - /** - * Payment method - */ - const METHOD = 'method'; - - /** - * Purchase order number - */ - const PO_NUMBER = 'po_number'; - - /** - * Credit card owner - */ - const CC_OWNER = 'cc_owner'; - - /** - * Credit card number - */ - const CC_NUMBER = 'cc_number'; - - /** - * Credit card type - */ - const CC_TYPE = 'cc_type'; - - /** - * Credit card expiration year - */ - const CC_EXP_YEAR = 'cc_exp_year'; - - /** - * Credit card expiration month - */ - const CC_EXP_MONTH = 'cc_exp_month'; - - /** - * Additional payment details - */ - const PAYMENT_DETAILS = 'payment_details'; - - /** - * Get purchase order number - * - * @return string|null - */ - public function getPoNumber() - { - return $this->_get(self::PO_NUMBER); - } - - /** - * Get payment method code - * - * @return string - */ - public function getMethod() - { - return $this->_get(self::METHOD); - } - - /** - * Get credit card owner - * - * @return string|null - */ - public function getCcOwner() - { - return $this->_get(self::CC_OWNER); - } - - /** - * Get credit card number - * - * @return string|null - */ - public function getCcNumber() - { - return $this->_get(self::CC_NUMBER); - } - - /** - * Get credit card type - * - * @return string|null - */ - public function getCcType() - { - return $this->_get(self::CC_TYPE); - } - - /** - * Get credit card expiration year - * - * @return string|null - */ - public function getCcExpYear() - { - return $this->_get(self::CC_EXP_YEAR); - } - - /** - * Get credit card expiration month - * - * @return string|null - */ - public function getCcExpMonth() - { - return $this->_get(self::CC_EXP_MONTH); - } - - /** - * Get payment additional details - * - * @return string|null - */ - public function getPaymentDetails() - { - return $this->_get(self::PAYMENT_DETAILS); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/PaymentMethod/Builder.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/PaymentMethod/Builder.php deleted file mode 100644 index 4c412e7a10d4a60a78af0af7e8eb49ffdc972ddc..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/PaymentMethod/Builder.php +++ /dev/null @@ -1,46 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Data\Cart\PaymentMethod; - -use Magento\Checkout\Service\V1\Data\Cart\PaymentMethod as QuotePaymentMethod; -use Magento\Framework\Exception\LocalizedException; -use Magento\Quote\Model\Quote; - -class Builder -{ - /** - * @param QuotePaymentMethod $object - * @param Quote $quote - * @return \Magento\Quote\Model\Quote\Payment - * @throws \Magento\Framework\Exception\LocalizedException - */ - public function build(QuotePaymentMethod $object, Quote $quote) - { - $payment = $quote->getPayment(); - try { - $data = $object->__toArray(); - $additionalDataValue = $object->getPaymentDetails(); - unset($data[QuotePaymentMethod::PAYMENT_DETAILS]); - if (!empty($additionalDataValue)) { - $additionalData = @unserialize($additionalDataValue); - if (is_array($additionalData) && !empty($additionalData)) { - $data = array_merge($data, $additionalData); - } - } - $data['checks'] = [ - \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_CHECKOUT, - \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_COUNTRY, - \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_CURRENCY, - \Magento\Payment\Model\Method\AbstractMethod::CHECK_ORDER_TOTAL_MIN_MAX, - ]; - $payment->importData($data); - } catch (\Exception $e) { - throw new LocalizedException('The requested Payment Method is not available.'); - } - return $payment; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/PaymentMethod/Converter.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/PaymentMethod/Converter.php deleted file mode 100644 index 083f54d39909bfb12405312761972d643671260e..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/PaymentMethod/Converter.php +++ /dev/null @@ -1,47 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Data\Cart\PaymentMethod; - -use Magento\Checkout\Service\V1\Data\Cart\PaymentMethod as QuotePaymentMethod; - -class Converter -{ - /** - * @var \Magento\Checkout\Service\V1\Data\Cart\PaymentMethodBuilder - */ - protected $builder; - - /** - * @param \Magento\Checkout\Service\V1\Data\Cart\PaymentMethodBuilder $builder - */ - public function __construct(\Magento\Checkout\Service\V1\Data\Cart\PaymentMethodBuilder $builder) - { - $this->builder = $builder; - } - - /** - * Convert quote payment object to payment data object - * - * @param \Magento\Quote\Model\Quote\Payment $object - * @return QuotePaymentMethod - */ - public function toDataObject(\Magento\Quote\Model\Quote\Payment $object) - { - $data = [ - QuotePaymentMethod::METHOD => $object->getMethod(), - QuotePaymentMethod::PO_NUMBER => $object->getPoNumber(), - QuotePaymentMethod::CC_OWNER => $object->getCcOwner(), - QuotePaymentMethod::CC_NUMBER => $object->getCcNumber(), - QuotePaymentMethod::CC_TYPE => $object->getCcType(), - QuotePaymentMethod::CC_EXP_YEAR => $object->getCcExpYear(), - QuotePaymentMethod::CC_EXP_MONTH => $object->getCcExpMonth(), - QuotePaymentMethod::PAYMENT_DETAILS => $object->getAdditionalData(), - ]; - - return $this->builder->populateWithArray($data)->create(); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/TotalsMapper.php b/app/code/Magento/Checkout/Service/V1/Data/Cart/TotalsMapper.php deleted file mode 100644 index d731d54609b06ea105605e557baebdee345c8ea9..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/TotalsMapper.php +++ /dev/null @@ -1,53 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\Cart; - -use Magento\Quote\Model\Quote; - -/** - * Totals data mapper - */ -class TotalsMapper -{ - /** - * Fetch quote totals data - * - * @param Quote $quote - * @return array - */ - public function map(Quote $quote) - { - $totals = [ - Totals::BASE_GRAND_TOTAL => $quote->getBaseGrandTotal(), - Totals::GRAND_TOTAL => $quote->getGrandTotal(), - Totals::BASE_SUBTOTAL => $quote->getBaseSubtotal(), - Totals::SUBTOTAL => $quote->getSubtotal(), - Totals::BASE_SUBTOTAL_WITH_DISCOUNT => $quote->getBaseSubtotalWithDiscount(), - Totals::SUBTOTAL_WITH_DISCOUNT => $quote->getSubtotalWithDiscount(), - - Totals::BASE_CURRENCY_CODE => $quote->getBaseCurrencyCode(), - Totals::QUOTE_CURRENCY_CODE => $quote->getQuoteCurrencyCode(), - ]; - - $shippingAddress = $quote->getShippingAddress(); - - $totals[Totals::DISCOUNT_AMOUNT] = $shippingAddress->getDiscountAmount(); - $totals[Totals::BASE_DISCOUNT_AMOUNT] = $shippingAddress->getBaseDiscountAmount(); - $totals[Totals::SHIPPING_AMOUNT] = $shippingAddress->getShippingAmount(); - $totals[Totals::BASE_SHIPPING_AMOUNT] = $shippingAddress->getBaseShippingAmount(); - $totals[Totals::SHIPPING_DISCOUNT_AMOUNT] = $shippingAddress->getShippingDiscountAmount(); - $totals[Totals::BASE_SHIPPING_DISCOUNT_AMOUNT] = $shippingAddress->getBaseShippingDiscountAmount(); - $totals[Totals::TAX_AMOUNT] = $shippingAddress->getTaxAmount(); - $totals[Totals::BASE_TAX_AMOUNT] = $shippingAddress->getBaseTaxAmount(); - $totals[Totals::SHIPPING_TAX_AMOUNT] = $shippingAddress->getShippingTaxAmount(); - $totals[Totals::BASE_SHIPPING_TAX_AMOUNT] = $shippingAddress->getBaseShippingTaxAmount(); - $totals[Totals::SUBTOTAL_INCL_TAX] = $shippingAddress->getSubtotalInclTax(); - $totals[Totals::BASE_SUBTOTAL_INCL_TAX] = $shippingAddress->getBaseSubtotalTotalInclTax(); - $totals[Totals::SHIPPING_INCL_TAX] = $shippingAddress->getShippingInclTax(); - $totals[Totals::BASE_SHIPPING_INCL_TAX] = $shippingAddress->getBaseShippingInclTax(); - return $totals; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/CartBuilder.php b/app/code/Magento/Checkout/Service/V1/Data/CartBuilder.php deleted file mode 100644 index 625649909ac64f24a2dd79da4caeaff44747d0ae..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/CartBuilder.php +++ /dev/null @@ -1,210 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data; - -use Magento\Checkout\Service\V1\Data\Cart\Currency; - -/** - * Cart data object builder - * - * @codeCoverageIgnore - */ -class CartBuilder extends \Magento\Framework\Api\ExtensibleObjectBuilder -{ - /** - * Cart/quote id - * - * @param int $value - * @return $this - */ - public function setId($value) - { - return $this->_set(Cart::ID, $value); - } - - /** - * Store id - * - * @param int $value - * @return $this - */ - public function setStoreId($value) - { - return $this->_set(Cart::STORE_ID, $value); - } - - /** - * set creation date and time - * - * @param string $value - * @return $this - */ - public function setCreatedAt($value) - { - return $this->_set(Cart::CREATED_AT, $value); - } - - /** - * Set last update date and time - * - * @param string $value - * @return $this - */ - public function setUpdatedAt($value) - { - return $this->_set(Cart::UPDATED_AT, $value); - } - - /** - * Set convertion date and time - * - * @param string $value - * @return $this - */ - public function setConvertedAt($value) - { - return $this->_set(Cart::CONVERTED_AT, $value); - } - - /** - * Set active status - * - * @param bool|null $value - * @return $this - */ - public function setIsActive($value) - { - return $this->_set(Cart::IS_ACTIVE, $value); - } - - /** - * Set virtual flag(if cart contains virtual products) - * - * @param bool|null $value - * @return $this - */ - public function setIsVirtual($value) - { - return $this->_set(Cart::IS_VIRTUAL, $value); - } - - /** - * Set cart items - * - * @param \Magento\Checkout\Service\V1\Data\Cart\Item[] $value - * @return $this - */ - public function setItems($value) - { - return $this->_set(Cart::ITEMS, $value); - } - - /** - * Set items count(amount of different products) - * - * @param int $value - * @return $this - */ - public function setItemsCount($value) - { - return $this->_set(Cart::ITEMS_COUNT, $value); - } - - /** - * Set items quantity(total amount of all products) - * - * @param float $value - * @return $this - */ - public function setItemsQty($value) - { - return $this->_set(Cart::ITEMS_QUANTITY, $value); - } - - /** - * Set customer data object - * - * @param \Magento\Checkout\Service\V1\Data\Cart\Customer $value - * @return $this - */ - public function setCustomer($value) - { - return $this->_set(Cart::CUSTOMER, $value); - } - - /** - * Set checkout method - * - * @param string $value - * @return $this - */ - public function setCheckoutMethod($value) - { - return $this->_set(Cart::CHECKOUT_METHOD, $value); - } - - /** - * Set shipping address data object - * - * @param \Magento\Checkout\Service\V1\Data\Cart\Address $value - * @return $this - */ - public function setShippingAddress($value) - { - return $this->_set(Cart::SHIPPING_ADDRESS, $value); - } - - /** - * Set billing address data object - * - * @param \Magento\Checkout\Service\V1\Data\Cart\Address $value - * @return $this - */ - public function setBillingAddress($value) - { - return $this->_set(Cart::BILLING_ADDRESS, $value); - } - - /** - * @param \Magento\Checkout\Service\V1\Data\Cart\Totals $value - * @return $this - */ - public function setTotals($value) - { - return $this->_set(Cart::TOTALS, $value); - } - - /** - * Set reserved order id - * - * @param string $value - * @return $this - */ - public function setReservedOrderId($value) - { - return $this->_set(Cart::RESERVED_ORDER_ID, $value); - } - - /** - * Set original order id - * - * @param string $value - * @return $this - */ - public function setOrigOrderId($value) - { - return $this->_set(Cart::ORIG_ORDER_ID, $value); - } - - /** - * @param \Magento\Checkout\Service\V1\Data\Cart\Currency|null $value - * @return $this - */ - public function setCurrency($value) - { - return $this->_set(Cart::CURRENCY, $value); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/CartMapper.php b/app/code/Magento/Checkout/Service/V1/Data/CartMapper.php deleted file mode 100644 index 89de1557babc61fa7685ea0093b67147623ae31a..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/CartMapper.php +++ /dev/null @@ -1,114 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data; - -use Magento\Checkout\Service\V1\Data\Cart; -use Magento\Quote\Model\Quote; - -/** - * Cart mapper - */ -class CartMapper -{ - /** - * @var Cart\TotalsBuilder - */ - private $totalsBuilder; - - /** - * @var CartBuilder - */ - private $cartBuilder; - - /** - * @var Cart\CustomerBuilder - */ - private $customerBuilder; - - /** - * @var Cart\CustomerMapper - */ - private $customerMapper; - - /** - * @var Cart\TotalsMapper - */ - private $totalsMapper; - - /** - * @var Cart\CurrencyMapper; - */ - private $currencyMapper; - - /** - * @var Cart\Totals\ItemMapper - */ - private $itemTotalsMapper; - - /** - * @param Cart\TotalsBuilder $totalsBuilder - * @param CartBuilder $cartBuilder - * @param Cart\CustomerBuilder $customerBuilder - * @param Cart\CustomerMapper $customerMapper - * @param Cart\TotalsMapper $totalsMapper - * @param Cart\CurrencyMapper $currencyMapper - * @param Cart\Totals\ItemMapper $itemTotalsMapper - */ - public function __construct( - Cart\TotalsBuilder $totalsBuilder, - CartBuilder $cartBuilder, - Cart\CustomerBuilder $customerBuilder, - Cart\CustomerMapper $customerMapper, - Cart\TotalsMapper $totalsMapper, - Cart\CurrencyMapper $currencyMapper, - Cart\Totals\ItemMapper $itemTotalsMapper - ) { - $this->totalsBuilder = $totalsBuilder; - $this->cartBuilder = $cartBuilder; - $this->customerBuilder = $customerBuilder; - $this->customerMapper = $customerMapper; - $this->totalsMapper = $totalsMapper; - $this->currencyMapper = $currencyMapper; - $this->itemTotalsMapper = $itemTotalsMapper; - } - - /** - * Fetch base quote data and map it to DTO fields - * - * @param Quote $quote - * @return array - */ - public function map(Quote $quote) - { - $this->cartBuilder->populateWithArray([ - Cart::ID => $quote->getId(), - Cart::STORE_ID => $quote->getStoreId(), - Cart::CREATED_AT => $quote->getCreatedAt(), - Cart::UPDATED_AT => $quote->getUpdatedAt(), - Cart::CONVERTED_AT => $quote->getConvertedAt(), - Cart::IS_ACTIVE => $quote->getIsActive(), - Cart::IS_VIRTUAL => $quote->getIsVirtual(), - Cart::ITEMS_COUNT => $quote->getItemsCount(), - Cart::ITEMS_QUANTITY => $quote->getItemsQty(), - Cart::CHECKOUT_METHOD => $quote->getCheckoutMethod(), - Cart::RESERVED_ORDER_ID => $quote->getReservedOrderId(), - Cart::ORIG_ORDER_ID => $quote->getOrigOrderId(), - ]); - - $this->customerBuilder->populateWithArray($this->customerMapper->map($quote)); - $this->totalsBuilder->populateWithArray($this->totalsMapper->map($quote)); - $items = []; - foreach ($quote->getAllItems() as $item) { - $items[] = $this->itemTotalsMapper->extractDto($item); - } - $this->totalsBuilder->setItems($items); - - $this->cartBuilder->setCustomer($this->customerBuilder->create()); - $this->cartBuilder->setTotals($this->totalsBuilder->create()); - $this->cartBuilder->setCurrency($this->currencyMapper->extractDto($quote)); - return $this->cartBuilder->create(); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/CartSearchResults.php b/app/code/Magento/Checkout/Service/V1/Data/CartSearchResults.php deleted file mode 100644 index 1ffb276415c3a525a9b8886f0d96de3c100c7e5b..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/CartSearchResults.php +++ /dev/null @@ -1,22 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data; - -/** - * @codeCoverageIgnore - */ -class CartSearchResults extends \Magento\Framework\Api\SearchResults -{ - /** - * Get items - * - * @return \Magento\Checkout\Service\V1\Data\Cart[] - */ - public function getItems() - { - return parent::getItems(); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/CartSearchResultsBuilder.php b/app/code/Magento/Checkout/Service/V1/Data/CartSearchResultsBuilder.php deleted file mode 100644 index f3f46270d2adb087859bc9b45572cd2fbe1a66dd..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/CartSearchResultsBuilder.php +++ /dev/null @@ -1,54 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data; - -use Magento\Framework\Api\AbstractSearchResultsBuilder; -use Magento\Framework\Api\AttributeDataBuilder; -use Magento\Framework\Api\MetadataServiceInterface; -use Magento\Framework\Api\ObjectFactory; -use Magento\Framework\Api\SearchCriteriaBuilder; - -/** - * @codeCoverageIgnore - */ -class CartSearchResultsBuilder extends AbstractSearchResultsBuilder -{ - /** - * Constructor - * - * @param ObjectFactory $objectFactory - * @param AttributeDataBuilder $valueBuilder - * @param MetadataServiceInterface $metadataService - * @param SearchCriteriaBuilder $searchCriteriaBuilder - * @param CartBuilder $itemObjectBuilder - */ - public function __construct( - ObjectFactory $objectFactory, - AttributeDataBuilder $valueBuilder, - MetadataServiceInterface $metadataService, - SearchCriteriaBuilder $searchCriteriaBuilder, - CartBuilder $itemObjectBuilder - ) { - parent::__construct( - $objectFactory, - $valueBuilder, - $metadataService, - $searchCriteriaBuilder, - $itemObjectBuilder - ); - } - - /** - * Set cart list - * - * @param \Magento\Checkout\Service\V1\Data\Cart[] $items - * @return $this - */ - public function setItems($items) - { - return parent::setItems($items); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/PaymentMethod.php b/app/code/Magento/Checkout/Service/V1/Data/PaymentMethod.php deleted file mode 100644 index db5c1fb6667d3a1e574c798821b93f91794e27ef..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/PaymentMethod.php +++ /dev/null @@ -1,37 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Data; - -/** - * @codeCoverageIgnore - */ -class PaymentMethod extends \Magento\Framework\Api\AbstractExtensibleObject -{ - const CODE = 'code'; - - const TITLE = 'title'; - - /** - * Get payment method code - * - * @return string - */ - public function getCode() - { - return $this->_get(self::CODE); - } - - /** - * Get payment method title - * - * @return string - */ - public function getTitle() - { - return $this->_get(self::TITLE); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Data/PaymentMethod/Converter.php b/app/code/Magento/Checkout/Service/V1/Data/PaymentMethod/Converter.php deleted file mode 100644 index 970763c2878aeef35f09c4c66410e56677559e44..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Data/PaymentMethod/Converter.php +++ /dev/null @@ -1,46 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\PaymentMethod; - -use Magento\Checkout\Service\V1\Data\PaymentMethod as QuotePaymentMethod; - -/** - * Payment method converter. - */ -class Converter -{ - /** - * Payment method builder. - * - * @var \Magento\Checkout\Service\V1\Data\Cart\PaymentMethodBuilder - */ - protected $builder; - - /** - * Constructs a payment method converter object. - * - * @param \Magento\Checkout\Service\V1\Data\PaymentMethodBuilder $builder Payment method builder. - */ - public function __construct(\Magento\Checkout\Service\V1\Data\PaymentMethodBuilder $builder) - { - $this->builder = $builder; - } - - /** - * Converts quote payment object to payment data object. - * - * @param \Magento\Payment\Model\MethodInterface $object The quote payment object. - * @return \Magento\Checkout\Service\V1\Data\Cart\PaymentMethod Payment data object. - */ - public function toDataObject(\Magento\Payment\Model\MethodInterface $object) - { - $data = [ - QuotePaymentMethod::CODE => $object->getCode(), - QuotePaymentMethod::TITLE => $object->getTitle(), - ]; - return $this->builder->populateWithArray($data)->create(); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Item/ReadService.php b/app/code/Magento/Checkout/Service/V1/Item/ReadService.php deleted file mode 100644 index 68ca13033f5491bc587c0b8de526b13fe9a669d6..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Item/ReadService.php +++ /dev/null @@ -1,60 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Item; - -/** - * Read service object. - */ -class ReadService implements ReadServiceInterface -{ - /** - * Quote repository. - * - * @var \Magento\Quote\Model\QuoteRepository - */ - protected $quoteRepository; - - /** - * Item mapper. - * - * @var \Magento\Checkout\Service\V1\Data\Cart\ItemMapper - */ - protected $itemMapper; - - /** - * Constructs a read service object. - * - * @param \Magento\Quote\Model\QuoteRepository $quoteRepository Quote repository. - * @param \Magento\Checkout\Service\V1\Data\Cart\ItemMapper $itemMapper Item mapper. - */ - public function __construct( - \Magento\Quote\Model\QuoteRepository $quoteRepository, - \Magento\Checkout\Service\V1\Data\Cart\ItemMapper $itemMapper - ) { - $this->quoteRepository = $quoteRepository; - $this->itemMapper = $itemMapper; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\Item[] Array of items. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getList($cartId) - { - $output = []; - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->getActive($cartId); - - /** @var \Magento\Quote\Model\Quote\Item $item */ - foreach ($quote->getAllItems() as $item) { - $output[] = $this->itemMapper->extractDto($item); - } - return $output; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/Item/ReadServiceInterface.php b/app/code/Magento/Checkout/Service/V1/Item/ReadServiceInterface.php deleted file mode 100644 index 6bbaaa7e5d72e883dac9e14a7ab2a41521163aab..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Item/ReadServiceInterface.php +++ /dev/null @@ -1,21 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Item; - -/** - * Read service interface. - */ -interface ReadServiceInterface -{ - /** - * Lists items that are assigned to a specified cart. - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\Item[] Array of items. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getList($cartId); -} diff --git a/app/code/Magento/Checkout/Service/V1/Item/WriteService.php b/app/code/Magento/Checkout/Service/V1/Item/WriteService.php deleted file mode 100644 index b8fc3a97ceb2c590bbbb00e6b76e574fc3825696..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/Item/WriteService.php +++ /dev/null @@ -1,137 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Item; - -use Magento\Framework\Exception\CouldNotSaveException; -use Magento\Framework\Exception\InputException; -use Magento\Framework\Exception\NoSuchEntityException; - -/** - * Write service object. - */ -class WriteService implements WriteServiceInterface -{ - /** - * Quote repository. - * - * @var \Magento\Quote\Model\QuoteRepository - */ - protected $quoteRepository; - - /** - * Product repository. - * - * @var \Magento\Catalog\Api\ProductRepositoryInterface - */ - protected $productRepository; - - /** - * Constructs a write service object. - * - * @param \Magento\Quote\Model\QuoteRepository $quoteRepository Quote repository. - * @param \Magento\Catalog\Api\ProductRepositoryInterface $productRepository - */ - public function __construct( - \Magento\Quote\Model\QuoteRepository $quoteRepository, - \Magento\Catalog\Api\ProductRepositoryInterface $productRepository - ) { - $this->quoteRepository = $quoteRepository; - $this->productRepository = $productRepository; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @param \Magento\Checkout\Service\V1\Data\Cart\Item $data The item. - * @return int Item ID. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - * @throws \Magento\Framework\Exception\CouldNotSaveException The specified item could not be saved to the cart. - * @throws \Magento\Framework\Exception\InputException The specified item or cart is not valid. - */ - public function addItem($cartId, \Magento\Checkout\Service\V1\Data\Cart\Item $data) - { - $qty = $data->getQty(); - if (!is_numeric($qty) || $qty <= 0) { - throw InputException::invalidFieldValue('qty', $qty); - } - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->getActive($cartId); - - $product = $this->productRepository->get($data->getSku()); - - try { - $quote->addProduct($product, $qty); - $this->quoteRepository->save($quote->collectTotals()); - } catch (\Exception $e) { - throw new CouldNotSaveException('Could not add item to quote'); - } - return $quote->getItemByProduct($product)->getId(); - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @param int $itemId The item ID of the item to be updated. - * @param \Magento\Checkout\Service\V1\Data\Cart\Item $data The item. - * @return bool - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified item or cart does not exist. - * @throws \Magento\Framework\Exception\CouldNotSaveException The item could not be updated. - * @throws \Magento\Framework\Exception\InputException The specified item or cart is not valid. - */ - public function updateItem($cartId, $itemId, \Magento\Checkout\Service\V1\Data\Cart\Item $data) - { - $qty = $data->getQty(); - if (!is_numeric($qty) || $qty <= 0) { - throw InputException::invalidFieldValue('qty', $qty); - } - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->getActive($cartId); - $quoteItem = $quote->getItemById($itemId); - if (!$quoteItem) { - throw new NoSuchEntityException("Cart $cartId doesn't contain item $itemId"); - } - $quoteItem->setData('qty', $qty); - - try { - $this->quoteRepository->save($quote->collectTotals()); - } catch (\Exception $e) { - throw new CouldNotSaveException('Could not update quote item'); - } - return true; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @param int $itemId The item ID of the item to be removed. - * @return bool - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified item or cart does not exist. - * @throws \Magento\Framework\Exception\CouldNotSaveException The item could not be removed. - */ - public function removeItem($cartId, $itemId) - { - /** - * Quote. - * - * @var \Magento\Quote\Model\Quote $quote - */ - $quote = $this->quoteRepository->getActive($cartId); - $quoteItem = $quote->getItemById($itemId); - if (!$quoteItem) { - throw new NoSuchEntityException("Cart $cartId doesn't contain item $itemId"); - } - try { - $quote->removeItem($itemId); - $this->quoteRepository->save($quote->collectTotals()); - } catch (\Exception $e) { - throw new CouldNotSaveException('Could not remove item from quote'); - } - return true; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/PaymentMethod/ReadService.php b/app/code/Magento/Checkout/Service/V1/PaymentMethod/ReadService.php deleted file mode 100644 index 20ea6ec225a09fcd026aabbf974fa6d030e3966a..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/PaymentMethod/ReadService.php +++ /dev/null @@ -1,101 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\PaymentMethod; - -use \Magento\Quote\Model\QuoteRepository; -use Magento\Checkout\Service\V1\Data\Cart\PaymentMethod\Converter as QuoteMethodConverter; -use Magento\Checkout\Service\V1\Data\PaymentMethod\Converter as PaymentMethodConverter; -use Magento\Payment\Model\MethodList; - -/** - * Payment method read service object. - */ -class ReadService implements ReadServiceInterface -{ - /** - * Quote repository. - * - * @var QuoteRepository - */ - protected $quoteRepository; - - /** - * Quote method converter. - * - * @var QuoteMethodConverter - */ - protected $quoteMethodConverter; - - /** - * Payment method converter. - * - * @var PaymentMethodConverter - */ - protected $paymentMethodConverter; - - /** - * Method list. - * - * @var MethodList - */ - protected $methodList; - - /** - * Constructs a payment method read service object. - * - * @param QuoteRepository $quoteRepository Quote repository. - * @param QuoteMethodConverter $quoteMethodConverter Quote method converter. - * @param PaymentMethodConverter $paymentMethodConverter Payment method converter. - * @param MethodList $methodList Method list. - */ - public function __construct( - QuoteRepository $quoteRepository, - QuoteMethodConverter $quoteMethodConverter, - PaymentMethodConverter $paymentMethodConverter, - MethodList $methodList - ) { - $this->quoteRepository = $quoteRepository; - $this->quoteMethodConverter = $quoteMethodConverter; - $this->paymentMethodConverter = $paymentMethodConverter; - $this->methodList = $methodList; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\PaymentMethod Payment method object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getPayment($cartId) - { - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->getActive($cartId); - $payment = $quote->getPayment(); - if (!$payment->getId()) { - return null; - } - return $this->quoteMethodConverter->toDataObject($payment); - } - - /** - * {@inheritDoc} - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\PaymentMethod[] Array of payment methods. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getList($cartId) - { - $output = []; - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->getActive($cartId); - foreach ($this->methodList->getAvailableMethods($quote) as $method) { - $output[] = $this->paymentMethodConverter->toDataObject($method); - } - return $output; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceInterface.php b/app/code/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceInterface.php deleted file mode 100644 index 228bafd2e5a3bb4f4525d40dc71299c89178f3db..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceInterface.php +++ /dev/null @@ -1,30 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\PaymentMethod; - -/** - * Payment method read service interface. - */ -interface ReadServiceInterface -{ - /** - * Returns the payment method for a specified shopping cart. - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\PaymentMethod Payment method object. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getPayment($cartId); - - /** - * Lists available payment methods for a specified shopping cart. - * - * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\PaymentMethod[] Array of payment methods. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function getList($cartId); -} diff --git a/app/code/Magento/Checkout/Service/V1/PaymentMethod/WriteService.php b/app/code/Magento/Checkout/Service/V1/PaymentMethod/WriteService.php deleted file mode 100644 index eff5131710a100f697a58abc88fdf4d2a954ee18..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/PaymentMethod/WriteService.php +++ /dev/null @@ -1,96 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\PaymentMethod; - -use Magento\Checkout\Service\V1\Data\Cart\PaymentMethod\Builder; -use Magento\Framework\Exception\State\InvalidTransitionException; -use Magento\Payment\Model\Checks\ZeroTotal; -use Magento\Quote\Model\QuoteRepository; - -/** - * Payment method write service object. - */ -class WriteService implements WriteServiceInterface -{ - /** - * Quote repository. - * - * @var QuoteRepository - */ - protected $quoteRepository; - - /** - * Payment method builder. - * - * @var Builder - */ - protected $paymentMethodBuilder; - - /** - * Zero total validator. - * - * @var ZeroTotal - */ - protected $zeroTotalValidator; - - /** - * Constructs a payment method write service object. - * - * @param QuoteRepository $quoteRepository Quote repository. - * @param Builder $paymentMethodBuilder Payment method builder. - * @param ZeroTotal $zeroTotalValidator Zero total validator. - */ - public function __construct( - QuoteRepository $quoteRepository, - Builder $paymentMethodBuilder, - ZeroTotal $zeroTotalValidator - ) { - $this->quoteRepository = $quoteRepository; - $this->paymentMethodBuilder = $paymentMethodBuilder; - $this->zeroTotalValidator = $zeroTotalValidator; - } - - /** - * {@inheritDoc} - * - * @param \Magento\Checkout\Service\V1\Data\Cart\PaymentMethod $method The payment method. - * @param int $cartId The cart ID. - * @return int Payment method ID. - * @throws \Magento\Framework\Exception\State\InvalidTransitionException The billing or shipping address is not set, or the specified payment method is not available. - */ - public function set(\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod $method, $cartId) - { - $quote = $this->quoteRepository->getActive($cartId); - - $payment = $this->paymentMethodBuilder->build($method, $quote); - if ($quote->isVirtual()) { - // check if billing address is set - if (is_null($quote->getBillingAddress()->getCountryId())) { - throw new InvalidTransitionException('Billing address is not set'); - } - $quote->getBillingAddress()->setPaymentMethod($payment->getMethod()); - } else { - // check if shipping address is set - if (is_null($quote->getShippingAddress()->getCountryId())) { - throw new InvalidTransitionException('Shipping address is not set'); - } - $quote->getShippingAddress()->setPaymentMethod($payment->getMethod()); - } - if (!$quote->isVirtual() && $quote->getShippingAddress()) { - $quote->getShippingAddress()->setCollectShippingRates(true); - } - - if (!$this->zeroTotalValidator->isApplicable($payment->getMethodInstance(), $quote)) { - throw new InvalidTransitionException('The requested Payment Method is not available.'); - } - - $quote->setTotalsCollectedFlag(false) - ->collectTotals() - ->save(); - - return $quote->getPayment()->getId(); - } -} diff --git a/app/code/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceInterface.php b/app/code/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceInterface.php deleted file mode 100644 index 8df03a63f104e6b629292c48f399616180c490d4..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceInterface.php +++ /dev/null @@ -1,23 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\PaymentMethod; - -/** - * Payment method write service interface. - */ -interface WriteServiceInterface -{ - /** - * Adds a specified payment method to a specified shopping cart. - * - * @param \Magento\Checkout\Service\V1\Data\Cart\PaymentMethod $method The payment method. - * @param int $cartId The cart ID. - * @return int Payment method ID. - * @throws \Magento\Framework\Exception\State\InvalidTransitionException The billing or shipping address is not set, or the specified payment method is not available. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - */ - public function set(\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod $method, $cartId); -} diff --git a/app/code/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceInterface.php b/app/code/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceInterface.php deleted file mode 100644 index 42848f2637b58445bbb8f2b737dcc6185dd61d6c..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceInterface.php +++ /dev/null @@ -1,32 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\ShippingMethod; - -/** - * Quote shipping method read service interface. - */ -interface ReadServiceInterface -{ - /** - * Returns selected shipping method for a specified quote. - * - * @param int $cartId The shopping cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\ShippingMethod Shipping method. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified shopping cart does not exist. - * @throws \Magento\Framework\Exception\StateException The shipping address is not set. - */ - public function getMethod($cartId); - - /** - * Lists applicable shipping methods for a specified quote. - * - * @param int $cartId The shopping cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\ShippingMethod[] An array of shipping methods. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified quote does not exist. - * @throws \Magento\Framework\Exception\StateException The shipping address is not set. - */ - public function getList($cartId); -} diff --git a/app/code/Magento/Checkout/Service/V1/ShippingMethod/WriteService.php b/app/code/Magento/Checkout/Service/V1/ShippingMethod/WriteService.php deleted file mode 100644 index bfccc0f3dc57a859cc42cdfe28a3fad16a9d9b63..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/ShippingMethod/WriteService.php +++ /dev/null @@ -1,92 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\ShippingMethod; - -use Magento\Framework\Exception\CouldNotSaveException; -use Magento\Framework\Exception\InputException; -use Magento\Framework\Exception\NoSuchEntityException; -use Magento\Framework\Exception\StateException; -use Magento\Quote\Model\QuoteRepository; - -/** - * Shipping method write service object. - */ -class WriteService implements WriteServiceInterface -{ - /** - * Address factory. - * - * @var \Magento\Quote\Model\Quote\AddressFactory - */ - protected $addressFactory; - - /** - * Quote repository. - * - * @var QuoteRepository - */ - protected $quoteRepository; - - /** - * Constructs a shipping method write service object. - * - * @param \Magento\Quote\Model\Quote\AddressFactory $addressFactory Address factory. - * @param QuoteRepository $quoteRepository Quote repository. - */ - public function __construct( - \Magento\Quote\Model\Quote\AddressFactory $addressFactory, - QuoteRepository $quoteRepository - ) { - $this->addressFactory = $addressFactory; - $this->quoteRepository = $quoteRepository; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The shopping cart ID. - * @param string $carrierCode The carrier code. - * @param string $methodCode The shipping method code. - * @return bool - * @throws \Magento\Framework\Exception\InputException The shipping method is not valid for an empty cart. - * @throws \Magento\Framework\Exception\CouldNotSaveException The shipping method could not be saved. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart contains only virtual products and the shipping method is not applicable. - * @throws \Magento\Framework\Exception\StateException The billing or shipping address is not set. - */ - public function setMethod($cartId, $carrierCode, $methodCode) - { - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->getActive($cartId); - if (0 == $quote->getItemsCount()) { - throw new InputException('Shipping method is not applicable for empty cart'); - } - - if ($quote->isVirtual()) { - throw new NoSuchEntityException( - 'Cart contains virtual product(s) only. Shipping method is not applicable.' - ); - } - $shippingAddress = $quote->getShippingAddress(); - if (!$shippingAddress->getCountryId()) { - throw new StateException('Shipping address is not set'); - } - $billingAddress = $quote->getBillingAddress(); - if (!$billingAddress->getCountryId()) { - throw new StateException('Billing address is not set'); - } - - $shippingAddress->setShippingMethod($carrierCode . '_' . $methodCode); - if (!$shippingAddress->requestShippingRates()) { - throw new NoSuchEntityException('Carrier with such method not found: ' . $carrierCode . ', ' . $methodCode); - } - try { - $this->quoteRepository->save($quote->collectTotals()); - } catch (\Exception $e) { - throw new CouldNotSaveException('Cannot set shipping method. ' . $e->getMessage()); - } - return true; - } -} diff --git a/app/code/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceInterface.php b/app/code/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceInterface.php deleted file mode 100644 index 04ecd30162a37aa0ae9533876e54eb4e88f39acd..0000000000000000000000000000000000000000 --- a/app/code/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceInterface.php +++ /dev/null @@ -1,26 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\ShippingMethod; - -/** - * Interface to choose the shipping method for a cart address. - */ -interface WriteServiceInterface -{ - /** - * Sets the carrier and shipping methods codes for a specified cart. - * - * @param int $cartId The shopping cart ID. - * @param string $carrierCode The carrier code. - * @param string $methodCode The shipping method code. - * @return bool - * @throws \Magento\Framework\Exception\InputException The shipping method is not valid for an empty cart. - * @throws \Magento\Framework\Exception\CouldNotSaveException The shipping method could not be saved. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart contains only virtual products so the shipping method does not apply. - * @throws \Magento\Framework\Exception\StateException The billing or shipping address is not set. - */ - public function setMethod($cartId, $carrierCode, $methodCode); -} diff --git a/app/code/Magento/Checkout/composer.json b/app/code/Magento/Checkout/composer.json index 38bd83c692b9ae685fe3d4b227e5e1ed991c90eb..721906c706c32b469c7e48ba92229e1887613e0b 100644 --- a/app/code/Magento/Checkout/composer.json +++ b/app/code/Magento/Checkout/composer.json @@ -5,7 +5,6 @@ "php": "~5.4.11|~5.5.0|~5.6.0", "magento/module-store": "0.42.0-beta4", "magento/module-sales": "0.42.0-beta4", - "magento/module-authorization": "0.42.0-beta4", "magento/module-catalog-inventory": "0.42.0-beta4", "magento/module-core": "0.42.0-beta4", "magento/module-customer": "0.42.0-beta4", diff --git a/app/code/Magento/Checkout/etc/di.xml b/app/code/Magento/Checkout/etc/di.xml index 33ae407c99345abf6624ce1ee1a04eb03f219f1d..f7d28cc7c961cfc47dbe1cd7cdd1dc391e05ac8c 100644 --- a/app/code/Magento/Checkout/etc/di.xml +++ b/app/code/Magento/Checkout/etc/di.xml @@ -23,19 +23,4 @@ <argument name="storage" xsi:type="object">Magento\Checkout\Model\Session\Storage</argument> </arguments> </type> - <preference for="Magento\Checkout\Service\V1\Item\ReadServiceInterface" type="Magento\Checkout\Service\V1\Item\ReadService" /> - <preference for="\Magento\Checkout\Service\V1\Item\WriteServiceInterface" type="Magento\Checkout\Service\V1\Item\WriteService" /> - <preference for="\Magento\Checkout\Service\V1\Address\Shipping\ReadServiceInterface" type="Magento\Checkout\Service\V1\Address\Shipping\ReadService" /> - <preference for="\Magento\Checkout\Service\V1\Address\Shipping\WriteServiceInterface" type="Magento\Checkout\Service\V1\Address\Shipping\WriteService" /> - <preference for="\Magento\Checkout\Service\V1\Address\Billing\ReadServiceInterface" type="Magento\Checkout\Service\V1\Address\Billing\ReadService" /> - <preference for="\Magento\Checkout\Service\V1\Address\Billing\WriteServiceInterface" type="Magento\Checkout\Service\V1\Address\Billing\WriteService" /> - <preference for="Magento\Checkout\Service\V1\Cart\ReadServiceInterface" type="Magento\Checkout\Service\V1\Cart\ReadService" /> - <preference for="Magento\Checkout\Service\V1\Cart\TotalsServiceInterface" type="Magento\Checkout\Service\V1\Cart\TotalsService" /> - <preference for="\Magento\Checkout\Service\V1\Cart\WriteServiceInterface" type="Magento\Checkout\Service\V1\Cart\WriteService" /> - <preference for="Magento\Checkout\Service\V1\ShippingMethod\WriteServiceInterface" type="Magento\Checkout\Service\V1\ShippingMethod\WriteService" /> - <preference for="Magento\Checkout\Service\V1\Coupon\ReadServiceInterface" type="Magento\Checkout\Service\V1\Coupon\ReadService" /> - <preference for="Magento\Checkout\Service\V1\Coupon\WriteServiceInterface" type="Magento\Checkout\Service\V1\Coupon\WriteService" /> - <preference for="Magento\Checkout\Service\V1\ShippingMethod\ReadServiceInterface" type="Magento\Checkout\Service\V1\ShippingMethod\ReadService" /> - <preference for="Magento\Checkout\Service\V1\PaymentMethod\ReadServiceInterface" type="\Magento\Checkout\Service\V1\PaymentMethod\ReadService" /> - <preference for="Magento\Checkout\Service\V1\PaymentMethod\WriteServiceInterface" type="\Magento\Checkout\Service\V1\PaymentMethod\WriteService" /> </config> diff --git a/app/code/Magento/Checkout/view/frontend/templates/button.phtml b/app/code/Magento/Checkout/view/frontend/templates/button.phtml index 172533b37b54483ce21f23d663a1c52f08aa204d..bbd2e27e279d57c0200f1c8e7330a1a6dfe7e2da 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/button.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/button.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Checkout\Block\Onepage\Success */ ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/additional/info.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/additional/info.phtml index ccec59cee49951a9261d3a266a6218ef821ccf4c..82efcb5bda2648a6f193e23485f70fe9edd30cc9 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/cart/additional/info.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/cart/additional/info.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/coupon.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/coupon.phtml index 2487fb279e2c05c2d1101a225ff804ff53b9a43d..affd2de86aacf906580ffd888faa21b0e77ba77f 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/cart/coupon.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/cart/coupon.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="block discount" id="block-discount" data-mage-init='{"collapsible":{"openedState": "active", "saveState": false}}'> <div class="title" data-role="title"> diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml index 13b2be3fbdaafaebfd35d41a6bb6029fd37e6e64..48741bc8f56778fc0d4b87e2d5b58add2798e31e 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Cart */ ?> <?php $mergedCells = ($this->helper('Magento\Tax\Helper\Data')->displayCartBothPrices() ? 2 : 1); ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/item/configure/updatecart.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/item/configure/updatecart.phtml index 7874e93c5d6d8911e7c01df82b92fb19360fd973..ec0b669af8705a11c75005ce110f410686239e5b 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/cart/item/configure/updatecart.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/cart/item/configure/updatecart.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Catalog\Block\Product\View */ ?> <?php $_product = $this->getProduct(); ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/item/default.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/item/default.phtml index c4b7a54c82f58807d601b8a07cafa9e41728fa44..e65a1f2f65632229fbb608a00ae2e8f41eceb634 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/cart/item/default.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/cart/item/default.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Cart\Item\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/item/price/sidebar.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/item/price/sidebar.phtml index 2313738810bfc539ae1e64017007750be451c610..79d5327513d502f2783dd3257f08108ff291883e 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/cart/item/price/sidebar.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/cart/item/price/sidebar.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Item\Price\Renderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/methods.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/methods.phtml index e5f2faebb9e73d2ffefd9447fb4233d8aeb01c20..941b87e97655c648ebb34ce03a7da869de9d4636 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/cart/methods.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/cart/methods.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Checkout\Block\Cart */ diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/minicart.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/minicart.phtml index f0d8c92de6566cc9fbf684f6ab8e764ad5a77173..0a7b63a393ac9984e696bf449869ed7c96c2c4e2 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/cart/minicart.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/cart/minicart.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Cart\Sidebar */ ?> <?php if ($this->getInList()): ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/shipping.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/shipping.phtml index 34f3e59efe3364a38463bb2248e1f1c2b136da42..c3a6bd227d70937139f3d7f596bf34f40d1ec20c 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/cart/shipping.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/cart/shipping.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Checkout\Block\Cart\Shipping */ ?> <div class="block shipping" id="block-shipping" data-mage-init='{"collapsible":{"openedState": "active", "saveState": false}}'> diff --git a/app/code/Magento/Checkout/view/frontend/templates/cart/sidebar/default.phtml b/app/code/Magento/Checkout/view/frontend/templates/cart/sidebar/default.phtml index 6a4e282672011eacc0b87e575e1f8e13504b02a3..bda5592a0731f09842514999af4b828c4af0e8f2 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/cart/sidebar/default.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/cart/sidebar/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Checkout\Block\Cart\Item\Renderer */ diff --git a/app/code/Magento/Checkout/view/frontend/templates/item/price/row.phtml b/app/code/Magento/Checkout/view/frontend/templates/item/price/row.phtml index a19936885ea8b3d6ac60801bca96c9669a445816..dd953145c0e584041e75a6ad525d40b0119b1ea1 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/item/price/row.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/item/price/row.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Checkout/view/frontend/templates/item/price/unit.phtml b/app/code/Magento/Checkout/view/frontend/templates/item/price/unit.phtml index 47a9df414edb031316c9cbe220dffc359bde3a12..940fdebb33ba53714a5ec69a89edc0ed6d6fb942 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/item/price/unit.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/item/price/unit.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Checkout/view/frontend/templates/js/components.phtml b/app/code/Magento/Checkout/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage.phtml index b908011858b4096caedfcc907b6d8aea3a244449..f8e5b4d5aa56d03ebecfef1595d5c79afbbfe9b2 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Checkout\Block\Onepage\Payment $_paymentBlock */ $_paymentBlock = $this->getLayout()->getBlock('checkout.onepage.payment'); ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/billing.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/billing.phtml index b8a5b9499af1710ac14228dae4bb47ee4917c386..1e337503117069f13f65fff41454525a2885d0a0 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/billing.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/billing.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var \Magento\Checkout\Block\Onepage\Billing $this */ ?> <form class="form billing" id="co-billing-form" data-hasrequired="<?php echo __('* Required Fields') ?>"> diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/failure.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/failure.phtml index 142b1f6dfde4d3b896ba217c7c5cb5861f31e172..ba797b7b4d8201377ebbfc84b2d56477b6161040 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/failure.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/failure.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getRealOrderId()) : ?><p><?php echo __('Order #') . $this->getRealOrderId() ?></p><?php endif ?> <?php if ($error = $this->getErrorMessage()) : ?><p><?php echo $error ?></p><?php endif ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/link.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/link.phtml index 9658b24101f08f032f70686fcacb761158ea8ff9..229b2ac050f9057b830b65db84c4a31da077ac59 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/link.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/link.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->isPossibleOnepageCheckout()):?> <button type="button" diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/login.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/login.phtml index 21a92194bdcc4708ce77c030ba9160fb7fb6a91c..47d5c7accb7d36ff60c67fd62d01bc4201c3f9c4 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/login.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/login.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/payment.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/payment.phtml index 92c18fed651e20175ff8b64e5d7d7dcd92e4aba8..528e5e22fb47129d3e7b6dca7d19990360b355e0 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/payment.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/payment.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <form id="co-payment-form" class="form payments"> <?php echo $this->getBlockHtml('formkey') ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/payment/methods.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/payment/methods.phtml index 2e241cb102064e0851c9b7bfc992d3342392a6d5..a05338be6e1a19ec75524826be37fe0f31f09517 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/payment/methods.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/payment/methods.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/progress.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/progress.phtml index 3871a5166871092f9da56fc432023905bc12517a..3133cf56765da093f7d437246945183eeb7e9c46 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/progress.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/progress.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Checkout\Block\Onepage\Progress */ ?> <div class="opc-block-progress<?php if ($this->isStepComplete('billing')): ?> active<?php endif; ?><?php if ($this->isStepComplete('payment')): ?> order-review-step<?php endif; ?>"> diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/info.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/info.phtml index 49369fbd7b112169aff6e8b8915d94a55812834d..710ac5abb8436f71cf266e8172f1169696ff94e3 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/info.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/info.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Onepage\Review\Info */ ?> <?php echo $this->getChildHtml('items_before'); ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item.phtml index 1e9f98a0ac2c42ffdfc6889bbfe91c2e44625189..feb98db7d786f001e6161a5bb044c889dc28b0f5 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this Magento\Checkout\Block\Cart\Item\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/row_excl_tax.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/row_excl_tax.phtml index f21be674673e5700c0c03ee6a3bfe6aa47c28977..3c50f62b146fb263fcaa315aae266105edf10227 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/row_excl_tax.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/row_excl_tax.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/row_incl_tax.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/row_incl_tax.phtml index e096f814934bbf7f51c8686553311e635a7fdf40..a2400474f0bdbefddd9838155ed8e8e760213c66 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/row_incl_tax.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/row_incl_tax.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/unit_excl_tax.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/unit_excl_tax.phtml index 8ce4a3970329de8084fbc16b7c772f1edfd49a6b..051852ec5624eb41ecfe63cf8a75833746137d76 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/unit_excl_tax.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/unit_excl_tax.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/unit_incl_tax.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/unit_incl_tax.phtml index bb9eda679db5efc5cbc03f55ab366c4364ff0e35..58a239d6f96f0d13efdc5afaac022abea044f551 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/unit_incl_tax.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/item/price/unit_incl_tax.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Checkout\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/totals.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/totals.phtml index 437385b8d8d5e49bfbe1b616f8dae95b43201020..302f7fe3f8a681c91f8b2a9b04467e0acef9132d 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/review/totals.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/review/totals.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @see \Magento\Checkout\Block\Cart\Totals */ diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping.phtml index fccdcd77dff12446e03625b3b3f22a8fd3a3d4b9..29b0718dacc172e086702c874fb7ae7b2137ace2 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <form class="form shipping address" id="co-shipping-form" data-hasrequired="<?php echo __('* Required Fields') ?>"> diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method.phtml index 43aba9aa35a13ea3199d13daf0a47760a350b82c..36e848cc0128c97cc071011b7dcf8c04e01c533c 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <form class="form methods-shipping" id="co-shipping-method-form"> <div id="checkout-shipping-method-load"></div> diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method/additional.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method/additional.phtml index 1c2f9bce2421b9cf8462a68d6c5c3728e0bf7890..6d72c8a9a035dc6522f611113b04276f35fd0962 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method/additional.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method/additional.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (!$this->getQuote()->isVirtual()): ?> <?php echo $this->helper('Magento\GiftMessage\Helper\Message')->getInline('onepage_checkout', $this->getQuote(), $this->getDontDisplayContainer()) ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method/available.phtml b/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method/available.phtml index 565359f24acb4f8804b5a207696e3024757e80ef..a5eb00a22a70f410c5dff2b6b4b95adba242eaf6 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method/available.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/onepage/shipping_method/available.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Checkout\Block\Onepage\Shipping\Method\Available */ ?> <?php $_shippingRateGroups = $this->getShippingRates(); ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/shipping/price.phtml b/app/code/Magento/Checkout/view/frontend/templates/shipping/price.phtml index 58922d51b13ae7971d8566f7a58aaf26d669478e..0571c89ce7b74d1da3768920069c002d9eff5d16 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/shipping/price.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/shipping/price.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Checkout\Block\Shipping\Price */ ?> diff --git a/app/code/Magento/Checkout/view/frontend/templates/success.phtml b/app/code/Magento/Checkout/view/frontend/templates/success.phtml index 8169694e953e24fd730b7aaa16fcead965756ed7..dbfd08207420fe057a7814448b3904694d794862 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/success.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/success.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Checkout\Block\Onepage\Success */ ?> <div class="checkout-success"> diff --git a/app/code/Magento/Checkout/view/frontend/templates/total/default.phtml b/app/code/Magento/Checkout/view/frontend/templates/total/default.phtml index f96e96d87b29a92e836d90a7df4cfd9d01d7facf..1b75bd7f79220b9055b2595670b536a3da1add84 100644 --- a/app/code/Magento/Checkout/view/frontend/templates/total/default.phtml +++ b/app/code/Magento/Checkout/view/frontend/templates/total/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <tr class="totals"> <th colspan="<?php echo $this->getColspan(); ?>" style="<?php echo $this->getTotal()->getStyle() ?>" class="mark" scope="row"> diff --git a/app/code/Magento/Checkout/view/frontend/web/js/opc-order-review.js b/app/code/Magento/Checkout/view/frontend/web/js/opc-order-review.js index c3c6b12819d96358cc13b4e61ceb3a1bb0dbab53..cda76773ef3c4ebe4f6b654886833425f5630486 100644 --- a/app/code/Magento/Checkout/view/frontend/web/js/opc-order-review.js +++ b/app/code/Magento/Checkout/view/frontend/web/js/opc-order-review.js @@ -37,8 +37,7 @@ define([ var isAgreementValid = true; agreementFormsGroup.find('form').each( function(){ - $(this).validation(); - isAgreementValid = isAgreementValid && $(this).validation && $(this).validation('isValid'); + isAgreementValid = $(this).validation() && $(this).validation('isValid') && isAgreementValid; } ); diff --git a/app/code/Magento/Checkout/view/frontend/web/js/overview.js b/app/code/Magento/Checkout/view/frontend/web/js/overview.js index 4ce29e190e4e2b5211de126dd5c0bf36e5111a77..94f918b73e64335f4d1d624959083620151f9afe 100644 --- a/app/code/Magento/Checkout/view/frontend/web/js/overview.js +++ b/app/code/Magento/Checkout/view/frontend/web/js/overview.js @@ -11,13 +11,12 @@ define([ "mage/translate" ], function($){ "use strict"; - + $.widget('mage.orderOverview', { options: { opacity: 0.5, // CSS opacity for the 'Place Order' button when it's clicked and then disabled. pleaseWaitLoader: 'span.please-wait', // 'Submitting order information...' Ajax loader. - placeOrderSubmit: 'button[type="submit"]', // The 'Place Order' button. - agreements: '#checkout-agreements' // Container for all of the checkout agreements and terms/conditions + placeOrderSubmit: 'button[type="submit"]' // The 'Place Order' button. }, /** @@ -29,14 +28,12 @@ define([ }, /** - * Verify that all agreements and terms/conditions are checked. Show the Ajax loader. Disable - * the submit button (i.e. Place Order). + * Show the Ajax loader. Disable the submit button (i.e. Place Order). * @return {Boolean} * @private */ _showLoader: function() { - if ($(this.options.agreements).find('input[type="checkbox"]:not(:checked)').length > 0) { - alert($.mage.__('Please agree to all Terms and Conditions before placing the orders.')); + if (!this.element.validation('isValid')) { return false; } this.element.find(this.options.pleaseWaitLoader).show().end() @@ -44,6 +41,6 @@ define([ return true; } }); - + return $.mage.orderOverview; }); \ No newline at end of file diff --git a/app/code/Magento/CheckoutAgreements/Api/CheckoutAgreementsRepositoryInterface.php b/app/code/Magento/CheckoutAgreements/Api/CheckoutAgreementsRepositoryInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..3d528c2a3969d4d9df645a92eff98c77f67cdec0 --- /dev/null +++ b/app/code/Magento/CheckoutAgreements/Api/CheckoutAgreementsRepositoryInterface.php @@ -0,0 +1,16 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\CheckoutAgreements\Api; + +interface CheckoutAgreementsRepositoryInterface +{ + /** + * Lists active checkout agreements. + * + * @return \Magento\CheckoutAgreements\Api\Data\AgreementInterface[] + */ + public function getList(); +} diff --git a/app/code/Magento/CheckoutAgreements/Api/Data/AgreementInterface.php b/app/code/Magento/CheckoutAgreements/Api/Data/AgreementInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..86daddcff06e5a6c50a66f6498b58347e9a1797f --- /dev/null +++ b/app/code/Magento/CheckoutAgreements/Api/Data/AgreementInterface.php @@ -0,0 +1,61 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\CheckoutAgreements\Api\Data; + +interface AgreementInterface +{ + /** + * Returns the agreement ID. + * + * @return int Agreement ID. + */ + public function getAgreementId(); + + /** + * Returns the agreement name. + * + * @return string Agreement name. + */ + public function getName(); + + /** + * Returns the agreement content. + * + * @return string Agreement content. + */ + public function getContent(); + + /** + * Returns the agreement content height, which is an optional CSS property. + * + * @return string|null Agreement content height. Otherwise, null. + */ + public function getContentHeight(); + + /** + * Returns the agreement checkbox text. + * + * @return string Agreement checkbox text. + */ + public function getCheckboxText(); + + /** + * Returns the agreement status. + * + * @return bool Agreement status. + * @SuppressWarnings(PHPMD.BooleanGetMethodName) + */ + public function getIsActive(); + + /** + * Returns the agreement content type. + * + * @return bool * true - HTML. + * * false - plain text. + * @SuppressWarnings(PHPMD.BooleanGetMethodName) + */ + public function getIsHtml(); +} diff --git a/app/code/Magento/CheckoutAgreements/Block/Adminhtml/Agreement/Edit/Form.php b/app/code/Magento/CheckoutAgreements/Block/Adminhtml/Agreement/Edit/Form.php index 32858a110220a74960daf27bfd56fef94a9f898f..c6cb28ad448597d4f87b71195f1c761ae5f0169c 100644 --- a/app/code/Magento/CheckoutAgreements/Block/Adminhtml/Agreement/Edit/Form.php +++ b/app/code/Magento/CheckoutAgreements/Block/Adminhtml/Agreement/Edit/Form.php @@ -45,6 +45,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic /** * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/CheckoutAgreements/Block/Adminhtml/Agreement/Grid.php b/app/code/Magento/CheckoutAgreements/Block/Adminhtml/Agreement/Grid.php index 7d81ec090d5d43be2ce99edf67aa6c4771779d42..ccf00e4ef614705798677b4eef5051d72f8ef074 100644 --- a/app/code/Magento/CheckoutAgreements/Block/Adminhtml/Agreement/Grid.php +++ b/app/code/Magento/CheckoutAgreements/Block/Adminhtml/Agreement/Grid.php @@ -119,6 +119,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid\Extended * @param \Magento\Framework\Data\Collection $collection * @param \Magento\Backend\Block\Widget\Grid\Column $column * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _filterStoreCondition($collection, $column) { diff --git a/app/code/Magento/CheckoutAgreements/Block/Agreements.php b/app/code/Magento/CheckoutAgreements/Block/Agreements.php index 802293ddcfc4b03d896b163cf6a74ec359f4f5f6..f43827a6b58201b97f3e4ae9fd89e485093523d3 100644 --- a/app/code/Magento/CheckoutAgreements/Block/Agreements.php +++ b/app/code/Magento/CheckoutAgreements/Block/Agreements.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CheckoutAgreements\Block; class Agreements extends \Magento\Framework\View\Element\Template diff --git a/app/code/Magento/CheckoutAgreements/Controller/Adminhtml/Agreement/Edit.php b/app/code/Magento/CheckoutAgreements/Controller/Adminhtml/Agreement/Edit.php index a9723bed6b61986172b7f62341bb71e186aad939..01fcef39eaf979376eea60929d7f853fd6d889c8 100644 --- a/app/code/Magento/CheckoutAgreements/Controller/Adminhtml/Agreement/Edit.php +++ b/app/code/Magento/CheckoutAgreements/Controller/Adminhtml/Agreement/Edit.php @@ -10,6 +10,7 @@ class Edit extends \Magento\CheckoutAgreements\Controller\Adminhtml\Agreement { /** * @return void + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/CheckoutAgreements/Model/Agreement.php b/app/code/Magento/CheckoutAgreements/Model/Agreement.php index 8a565ffb74e0448d6b25c5ee2c3114f56abd1da1..df49829e376a4e80745fbbaf38d8480b08c3834e 100644 --- a/app/code/Magento/CheckoutAgreements/Model/Agreement.php +++ b/app/code/Magento/CheckoutAgreements/Model/Agreement.php @@ -5,24 +5,10 @@ */ namespace Magento\CheckoutAgreements\Model; -/** - * @method \Magento\CheckoutAgreements\Model\Resource\Agreement _getResource() - * @method \Magento\CheckoutAgreements\Model\Resource\Agreement getResource() - * @method string getName() - * @method \Magento\CheckoutAgreements\Model\Agreement setName(string $value) - * @method string getContent() - * @method \Magento\CheckoutAgreements\Model\Agreement setContent(string $value) - * @method string getContentHeight() - * @method \Magento\CheckoutAgreements\Model\Agreement setContentHeight(string $value) - * @method string getCheckboxText() - * @method \Magento\CheckoutAgreements\Model\Agreement setCheckboxText(string $value) - * @method int getIsActive() - * @method \Magento\CheckoutAgreements\Model\Agreement setIsActive(int $value) - * @method int getIsHtml() - * @method \Magento\CheckoutAgreements\Model\Agreement setIsHtml(int $value) - * - */ -class Agreement extends \Magento\Framework\Model\AbstractModel +use Magento\CheckoutAgreements\Api\Data\AgreementInterface; +use Magento\Framework\Model\AbstractExtensibleModel; + +class Agreement extends AbstractExtensibleModel implements AgreementInterface { /** * Allowed CSS units for height field @@ -77,4 +63,62 @@ class Agreement extends \Magento\Framework\Model\AbstractModel return parent::beforeSave(); } + + //@codeCoverageIgnoreStart + /** + * @inheritdoc + */ + public function getAgreementId() + { + return $this->getData('agreement_id'); + } + + /** + * @inheritdoc + */ + public function getName() + { + return $this->getData('name'); + } + + /** + * @inheritdoc + */ + public function getContent() + { + return $this->getData('content'); + } + + /** + * @inheritdoc + */ + public function getContentHeight() + { + return $this->getData('content_height'); + } + + /** + * @inheritdoc + */ + public function getCheckboxText() + { + return $this->getData('checkbox_text'); + } + + /** + * @inheritdoc + */ + public function getIsActive() + { + return $this->getData('is_active'); + } + + /** + * @inheritdoc + */ + public function getIsHtml() + { + return $this->getData('is_html'); + } + //@codeCoverageIgnoreEnd } diff --git a/app/code/Magento/CheckoutAgreements/Service/V1/Agreement/ReadService.php b/app/code/Magento/CheckoutAgreements/Model/CheckoutAgreementsRepository.php similarity index 53% rename from app/code/Magento/CheckoutAgreements/Service/V1/Agreement/ReadService.php rename to app/code/Magento/CheckoutAgreements/Model/CheckoutAgreementsRepository.php index ff5684b6c4537ea10dee9c2cb0e522faca691781..892e1599241f3e1858379aed0788bd134f023914 100644 --- a/app/code/Magento/CheckoutAgreements/Service/V1/Agreement/ReadService.php +++ b/app/code/Magento/CheckoutAgreements/Model/CheckoutAgreementsRepository.php @@ -3,21 +3,22 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\CheckoutAgreements\Service\V1\Agreement; + +// @codingStandardsIgnoreFile + +namespace Magento\CheckoutAgreements\Model; use Magento\CheckoutAgreements\Model\Resource\Agreement\CollectionFactory as AgreementCollectionFactory; use Magento\CheckoutAgreements\Model\Resource\Agreement\Collection as AgreementCollection; -use Magento\CheckoutAgreements\Model\Agreement; use Magento\Framework\App\Config\ScopeConfigInterface; use Magento\Store\Model\StoreManagerInterface; use Magento\Store\Model\ScopeInterface; -use Magento\CheckoutAgreements\Service\V1\Data\AgreementBuilder; -use Magento\CheckoutAgreements\Service\V1\Data\Agreement as AgreementDataObject; +use Magento\CheckoutAgreements\Api\CheckoutAgreementsRepositoryInterface; /** - * Checkout agreement service. + * Checkout agreement repository. */ -class ReadService implements ReadServiceInterface +class CheckoutAgreementsRepository implements CheckoutAgreementsRepositoryInterface { /** * Collection factory. @@ -26,13 +27,6 @@ class ReadService implements ReadServiceInterface */ private $collectionFactory; - /** - * Agreement builder. - * - * @var AgreementBuilder - */ - private $agreementBuilder; - /** * Store manager. * @@ -48,21 +42,18 @@ class ReadService implements ReadServiceInterface private $scopeConfig; /** - * Constructs a checkout agreement service object. + * Constructs a checkout agreement data object. * * @param AgreementCollectionFactory $collectionFactory Collection factory. - * @param AgreementBuilder $agreementBuilder Agreement builder. * @param \Magento\Store\Model\StoreManagerInterface $storeManager Store manager. * @param ScopeConfigInterface $scopeConfig Scope config. */ public function __construct( AgreementCollectionFactory $collectionFactory, - AgreementBuilder $agreementBuilder, StoreManagerInterface $storeManager, ScopeConfigInterface $scopeConfig ) { $this->collectionFactory = $collectionFactory; - $this->agreementBuilder = $agreementBuilder; $this->storeManager = $storeManager; $this->scopeConfig = $scopeConfig; } @@ -70,7 +61,7 @@ class ReadService implements ReadServiceInterface /** * {@inheritdoc} * - * @return array|\Magento\CheckoutAgreements\Service\V1\Data\Agreement[] Array of checkout agreement service objects. + * @return \Magento\CheckoutAgreements\Api\Data\AgreementInterface[] Array of checkout agreement data objects. */ public function getList() { @@ -85,29 +76,9 @@ class ReadService implements ReadServiceInterface $agreementDataObjects = []; foreach ($agreementCollection as $agreement) { - $agreementDataObjects[] = $this->createAgreementDataObject($agreement); + $agreementDataObjects[] = $agreement; } return $agreementDataObjects; } - - /** - * Creates an agreement data object based on a specified agreement model. - * - * @param Agreement $agreement The agreement model. - * @return AgreementDataObject Agreement data object. - */ - protected function createAgreementDataObject(Agreement $agreement) - { - $this->agreementBuilder->populateWithArray([ - AgreementDataObject::ID => $agreement->getId(), - AgreementDataObject::NAME => $agreement->getName(), - AgreementDataObject::CONTENT => $agreement->getContent(), - AgreementDataObject::CONTENT_HEIGHT => $agreement->getContentHeight(), - AgreementDataObject::CHECKBOX_TEXT => $agreement->getCheckboxText(), - AgreementDataObject::ACTIVE => (bool)$agreement->getIsActive(), - AgreementDataObject::HTML => (bool)$agreement->getIsHtml(), - ]); - return $this->agreementBuilder->create(); - } } diff --git a/app/code/Magento/CheckoutAgreements/Model/Resource/Agreement.php b/app/code/Magento/CheckoutAgreements/Model/Resource/Agreement.php index 5b28e26a142f898e5866ec210f48fb276a3e1cae..943e6738e9e67f18c320d9e73259f486cc96e1c3 100644 --- a/app/code/Magento/CheckoutAgreements/Model/Resource/Agreement.php +++ b/app/code/Magento/CheckoutAgreements/Model/Resource/Agreement.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CheckoutAgreements\Model\Resource; /** diff --git a/app/code/Magento/CheckoutAgreements/Model/Resource/Agreement/Collection.php b/app/code/Magento/CheckoutAgreements/Model/Resource/Agreement/Collection.php index e62b3ed73ea8658e4843524b06f4231a54e9470e..163474a2c62d4ed05bf4c195cc89d77644ce496f 100644 --- a/app/code/Magento/CheckoutAgreements/Model/Resource/Agreement/Collection.php +++ b/app/code/Magento/CheckoutAgreements/Model/Resource/Agreement/Collection.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CheckoutAgreements\Model\Resource\Agreement; /** diff --git a/app/code/Magento/CheckoutAgreements/Service/V1/Agreement/ReadServiceInterface.php b/app/code/Magento/CheckoutAgreements/Service/V1/Agreement/ReadServiceInterface.php deleted file mode 100644 index baf99c5990d95ca15a85fd999c42eedceab92f38..0000000000000000000000000000000000000000 --- a/app/code/Magento/CheckoutAgreements/Service/V1/Agreement/ReadServiceInterface.php +++ /dev/null @@ -1,19 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\CheckoutAgreements\Service\V1\Agreement; - -/** - * Checkout agreement service interface. - */ -interface ReadServiceInterface -{ - /** - * Lists active checkout agreements. - * - * @return \Magento\CheckoutAgreements\Service\V1\Data\Agreement[] Array of active checkout agreements. - */ - public function getList(); -} diff --git a/app/code/Magento/CheckoutAgreements/Service/V1/Data/Agreement.php b/app/code/Magento/CheckoutAgreements/Service/V1/Data/Agreement.php deleted file mode 100644 index 52275580119de2a7613421416d80b9c6f262998e..0000000000000000000000000000000000000000 --- a/app/code/Magento/CheckoutAgreements/Service/V1/Data/Agreement.php +++ /dev/null @@ -1,122 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\CheckoutAgreements\Service\V1\Data; - -use Magento\Framework\Api\AbstractExtensibleObject; - -/** - * Checkout agreement data object. - * - * @codeCoverageIgnore - */ -class Agreement extends AbstractExtensibleObject -{ - /** - * Agreement ID. - */ - const ID = 'id'; - - /** - * Agreement name. - */ - const NAME = 'name'; - - /** - * Agreement content. - */ - const CONTENT = 'content'; - - /** - * Agreement content height. Optional CSS property. - */ - const CONTENT_HEIGHT = 'content_height'; - - /** - * Agreement checkbox text. Caption of UI component. - */ - const CHECKBOX_TEXT = 'checkbox_text'; - - /** - * Agreement status. - */ - const ACTIVE = 'active'; - - /** - * Agreement content type. True is HTML. False is plain text. - */ - const HTML = 'html'; - - /** - * Returns the agreement ID. - * - * @return int Agreement ID. - */ - public function getId() - { - return $this->_get(self::ID); - } - - /** - * Returns the agreement name. - * - * @return string Agreement name. - */ - public function getName() - { - return $this->_get(self::NAME); - } - - /** - * Returns the agreement content. - * - * @return string Agreement content. - */ - public function getContent() - { - return $this->_get(self::CONTENT); - } - - /** - * Returns the agreement content height, which is an optional CSS property. - * - * @return string|null Agreement content height. Otherwise, null. - */ - public function getContentHeight() - { - return $this->_get(self::CONTENT_HEIGHT); - } - - /** - * Returns the agreement checkbox text. - * - * @return string Agreement checkbox text. - */ - public function getCheckboxText() - { - return $this->_get(self::CHECKBOX_TEXT); - } - - /** - * Returns the agreement status. - * - * @return bool Agreement status. - */ - public function isActive() - { - return $this->_get(self::ACTIVE); - } - - /** - * Returns the agreement content type. - * - * @return bool * true - HTML. - * * false - plain text. - */ - public function isHtml() - { - return $this->_get(self::HTML); - } -} diff --git a/app/code/Magento/CheckoutAgreements/Service/V1/Data/AgreementBuilder.php b/app/code/Magento/CheckoutAgreements/Service/V1/Data/AgreementBuilder.php deleted file mode 100644 index 82f11f5f6b4053e5e0e60b271d8beee747c87bfc..0000000000000000000000000000000000000000 --- a/app/code/Magento/CheckoutAgreements/Service/V1/Data/AgreementBuilder.php +++ /dev/null @@ -1,93 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\CheckoutAgreements\Service\V1\Data; - -use Magento\Framework\Api\ExtensibleObjectBuilder; - -/** - * Checkout agreement data object builder. - * - * @codeCoverageIgnore - */ -class AgreementBuilder extends ExtensibleObjectBuilder -{ - /** - * Sets the agreement ID. - * - * @param int $value The agreement ID. - * @return $this - */ - public function setId($value) - { - return $this->_set(Agreement::ID, $value); - } - - /** - * Sets the agreement name. - * - * @param string $value The agreement name. - * @return $this - */ - public function setName($value) - { - return $this->_set(Agreement::NAME, $value); - } - - /** - * Sets the agreement content. - * - * @param string $value The agreement content. - * @return $this - */ - public function setContent($value) - { - return $this->_set(Agreement::CONTENT, $value); - } - - /** - * Sets the agreement content height, which is an optional CSS property. - * - * @param string $value The agreement content height. - * @return $this - */ - public function setContentHeight($value) - { - return $this->_set(Agreement::CONTENT_HEIGHT, $value); - } - - /** - * Sets the agreement checkbox text. - * - * @param string $value The agreement checkbox text. - * @return $this - */ - public function setCheckboxText($value) - { - return $this->_set(Agreement::CHECKBOX_TEXT, $value); - } - - /** - * Sets the agreement status. - * - * @param bool $value The agreement status value. Set to true for active. - * @return $this - */ - public function setActive($value) - { - return $this->_set(Agreement::ACTIVE, $value); - } - - /** - * Sets the agreement content type. - * - * @param bool $value The agreement content type. Set to true for HTML. Set to false for plain text. - * @return $this - */ - public function setHtml($value) - { - return $this->_set(Agreement::HTML, $value); - } -} diff --git a/app/code/Magento/CheckoutAgreements/etc/di.xml b/app/code/Magento/CheckoutAgreements/etc/di.xml index 057668faba72736c474f2b4d83528b526a18f58b..b72ba8165bc5e5dd08df20d658e6ebfd7f4ed8f2 100644 --- a/app/code/Magento/CheckoutAgreements/etc/di.xml +++ b/app/code/Magento/CheckoutAgreements/etc/di.xml @@ -6,7 +6,8 @@ */ --> <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/ObjectManager/etc/config.xsd"> - <preference for="Magento\CheckoutAgreements\Service\V1\Agreement\ReadServiceInterface" type="Magento\CheckoutAgreements\Service\V1\Agreement\ReadService" /> + <preference for="Magento\CheckoutAgreements\Api\CheckoutAgreementsRepositoryInterface" type="Magento\CheckoutAgreements\Model\CheckoutAgreementsRepository" /> + <preference for="Magento\CheckoutAgreements\Api\Data\AgreementInterface" type="Magento\CheckoutAgreements\Model\Agreement" /> <type name="Magento\Framework\Module\Updater\SetupFactory"> <arguments> <argument name="resourceTypes" xsi:type="array"> diff --git a/app/code/Magento/CheckoutAgreements/etc/webapi.xml b/app/code/Magento/CheckoutAgreements/etc/webapi.xml index 1c6fa3cd5572ba4eae62901abb1173b9c0444194..5b66e1ff52d5c71af405581abd683fbdf9547249 100644 --- a/app/code/Magento/CheckoutAgreements/etc/webapi.xml +++ b/app/code/Magento/CheckoutAgreements/etc/webapi.xml @@ -8,7 +8,7 @@ <routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../app/code/Magento/Webapi/etc/webapi.xsd"> <route url="/V1/carts/licence" method="GET"> - <service class="Magento\CheckoutAgreements\Service\V1\Agreement\ReadServiceInterface" method="getList"/> + <service class="Magento\CheckoutAgreements\Api\CheckoutAgreementsRepositoryInterface" method="getList"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> diff --git a/app/code/Magento/CheckoutAgreements/view/frontend/templates/agreements.phtml b/app/code/Magento/CheckoutAgreements/view/frontend/templates/agreements.phtml index 41effe8f9898b7246bf7cb470916dfc4d391c11b..783fcc4497b0705d134cf0f711de1225c0300e0a 100644 --- a/app/code/Magento/CheckoutAgreements/view/frontend/templates/agreements.phtml +++ b/app/code/Magento/CheckoutAgreements/view/frontend/templates/agreements.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/CheckoutAgreements/view/frontend/templates/multishipping_agreements.phtml b/app/code/Magento/CheckoutAgreements/view/frontend/templates/multishipping_agreements.phtml index 8d8d89abdbe471867f45fdd15c8bd7b651c895c4..decebb582354c710dec24a614c0076896ca5aeeb 100644 --- a/app/code/Magento/CheckoutAgreements/view/frontend/templates/multishipping_agreements.phtml +++ b/app/code/Magento/CheckoutAgreements/view/frontend/templates/multishipping_agreements.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Cms/Block/Adminhtml/Page/Edit/Tab/Main.php b/app/code/Magento/Cms/Block/Adminhtml/Page/Edit/Tab/Main.php index 1c6a982f545b4ea72fca90a1cdbdaee9aee4523c..7bf1236e1ee1313230bfd59dceec7e40f0fcf3a4 100644 --- a/app/code/Magento/Cms/Block/Adminhtml/Page/Edit/Tab/Main.php +++ b/app/code/Magento/Cms/Block/Adminhtml/Page/Edit/Tab/Main.php @@ -37,6 +37,7 @@ class Main extends \Magento\Backend\Block\Widget\Form\Generic implements \Magent * Prepare form * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Cms/Block/Adminhtml/Page/Grid.php b/app/code/Magento/Cms/Block/Adminhtml/Page/Grid.php index 966831d68ccf734966270e584db4cd0bf0a41348..ce330ce17a0b4ed1b7a4d2beef587060ab6cf27f 100644 --- a/app/code/Magento/Cms/Block/Adminhtml/Page/Grid.php +++ b/app/code/Magento/Cms/Block/Adminhtml/Page/Grid.php @@ -176,6 +176,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid\Extended * @param \Magento\Framework\Data\Collection $collection * @param \Magento\Framework\Object $column * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _filterStoreCondition($collection, \Magento\Framework\Object $column) { diff --git a/app/code/Magento/Cms/Block/Block.php b/app/code/Magento/Cms/Block/Block.php index 7061c9f42d2355408f23dfc5c144f5d2460b358f..2f8f28e4334fc17c2f112217efbb9aad8c4f3cf0 100644 --- a/app/code/Magento/Cms/Block/Block.php +++ b/app/code/Magento/Cms/Block/Block.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Cms\Block; /** diff --git a/app/code/Magento/Cms/Controller/Adminhtml/Block/Edit.php b/app/code/Magento/Cms/Controller/Adminhtml/Block/Edit.php index 20c6ef8e797691edbca3328165dc24032c32e84f..9214ba6354f13a3ed087dea1c341756af5c10961 100644 --- a/app/code/Magento/Cms/Controller/Adminhtml/Block/Edit.php +++ b/app/code/Magento/Cms/Controller/Adminhtml/Block/Edit.php @@ -12,6 +12,7 @@ class Edit extends \Magento\Cms\Controller\Adminhtml\Block * Edit CMS block * * @return void + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Cms/Controller/Adminhtml/Page/Edit.php b/app/code/Magento/Cms/Controller/Adminhtml/Page/Edit.php index 4c3a0427bb553bae79e1c316af91104b09ca50c7..1eea746d46d08c5d95692fc9333bd29efd74d1ae 100644 --- a/app/code/Magento/Cms/Controller/Adminhtml/Page/Edit.php +++ b/app/code/Magento/Cms/Controller/Adminhtml/Page/Edit.php @@ -60,6 +60,7 @@ class Edit extends \Magento\Backend\App\Action * Edit CMS page * * @return void + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Cms/Controller/Index/Index.php b/app/code/Magento/Cms/Controller/Index/Index.php index a1f99a751d90682108ed8bfc5cf3415c61096663..9fa1e103882df79132ff5364a5928a6219efb268 100644 --- a/app/code/Magento/Cms/Controller/Index/Index.php +++ b/app/code/Magento/Cms/Controller/Index/Index.php @@ -13,6 +13,7 @@ class Index extends \Magento\Framework\App\Action\Action * * @param string|null $coreRoute * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function execute($coreRoute = null) { diff --git a/app/code/Magento/Cms/Helper/Page.php b/app/code/Magento/Cms/Helper/Page.php index be765e259f4ad4e547db55a93249824e65baa933..b6ce2979c70d2a0e901bf71b0d814775a3015674 100644 --- a/app/code/Magento/Cms/Helper/Page.php +++ b/app/code/Magento/Cms/Helper/Page.php @@ -93,6 +93,7 @@ class Page extends \Magento\Framework\App\Helper\AbstractHelper * @param \Magento\Framework\Escaper $escaper * @param \Magento\Framework\App\ViewInterface $view * @param \Magento\Framework\View\Page\Config $pageConfig + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Helper\Context $context, @@ -140,6 +141,8 @@ class Page extends \Magento\Framework\App\Helper\AbstractHelper * @param int $pageId * @param bool $renderLayout * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _renderPage(Action $action, $pageId = null, $renderLayout = true) { diff --git a/app/code/Magento/Cms/Model/Resource/Block.php b/app/code/Magento/Cms/Model/Resource/Block.php index 9c554253d2940ddc050be867abcc21cae58779ce..894aa6d629576134cfa51e517905d78aa45aa23c 100644 --- a/app/code/Magento/Cms/Model/Resource/Block.php +++ b/app/code/Magento/Cms/Model/Resource/Block.php @@ -194,6 +194,7 @@ class Block extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param \Magento\Framework\Model\AbstractModel $object * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsUniqueBlockToStores(\Magento\Framework\Model\AbstractModel $object) { diff --git a/app/code/Magento/Cms/Model/Resource/CmsCriteriaMapper.php b/app/code/Magento/Cms/Model/Resource/CmsCriteriaMapper.php index 60305493e002f077568558bdc8c28984aae1a179..ffac24c942d62253aed5c41b61564ef26d0fdc3e 100644 --- a/app/code/Magento/Cms/Model/Resource/CmsCriteriaMapper.php +++ b/app/code/Magento/Cms/Model/Resource/CmsCriteriaMapper.php @@ -38,6 +38,7 @@ class CmsCriteriaMapper extends GenericMapper * * @param bool $flag * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function mapFirstStoreFlag($flag) { diff --git a/app/code/Magento/Cms/Model/Resource/Page.php b/app/code/Magento/Cms/Model/Resource/Page.php index d45a2001f65af00168f5cd3ed015fea1e7df114c..4efe1734c056c1177cf69944b27f4cb9934fed51 100644 --- a/app/code/Magento/Cms/Model/Resource/Page.php +++ b/app/code/Magento/Cms/Model/Resource/Page.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Cms\Model\Resource; /** diff --git a/app/code/Magento/Cms/Model/Wysiwyg/Config.php b/app/code/Magento/Cms/Model/Wysiwyg/Config.php index 3c6e755712a05aac54196966e3fb9a70886ccfe0..7fd5b26290dfc090bed06886557bb8919ed68b39 100644 --- a/app/code/Magento/Cms/Model/Wysiwyg/Config.php +++ b/app/code/Magento/Cms/Model/Wysiwyg/Config.php @@ -100,6 +100,7 @@ class Config extends \Magento\Framework\Object * @param \Magento\Store\Model\StoreManagerInterface $storeManager * @param array $windowSize * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Backend\Model\UrlInterface $backendUrl, diff --git a/app/code/Magento/Cms/Model/Wysiwyg/Images/Storage.php b/app/code/Magento/Cms/Model/Wysiwyg/Images/Storage.php index 516b6121012b8c9f2af84fd003b60f6998281fb3..18cf095879c3703cb41a91b4cca845760cc9e558 100644 --- a/app/code/Magento/Cms/Model/Wysiwyg/Images/Storage.php +++ b/app/code/Magento/Cms/Model/Wysiwyg/Images/Storage.php @@ -12,6 +12,8 @@ use Magento\Framework\App\Filesystem\DirectoryList; * Wysiwyg Images model * * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Storage extends \Magento\Framework\Object { @@ -187,6 +189,8 @@ class Storage extends \Magento\Framework\Object * * @param string $path Parent directory path * @return \Magento\Framework\Data\Collection\Filesystem + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getDirsCollection($path) { diff --git a/app/code/Magento/Cms/Model/Wysiwyg/Images/Storage/Collection.php b/app/code/Magento/Cms/Model/Wysiwyg/Images/Storage/Collection.php index 8fc88a3e673ff4cc2ad0c3dd44d69cedb9fd61f1..4971fd1f68fcd36c4133f3feee216840d2bde947 100644 --- a/app/code/Magento/Cms/Model/Wysiwyg/Images/Storage/Collection.php +++ b/app/code/Magento/Cms/Model/Wysiwyg/Images/Storage/Collection.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Cms\Model\Wysiwyg\Images\Storage; use Magento\Framework\App\Filesystem\DirectoryList; diff --git a/app/code/Magento/Cms/data/cms_setup/data-install-2.0.0.php b/app/code/Magento/Cms/data/cms_setup/data-install-2.0.0.php index a558037a94329b3f9eb4e4000cff93017aa584ea..46847bf5cff2abe633c7f1b55d675599ba6e52f6 100644 --- a/app/code/Magento/Cms/data/cms_setup/data-install-2.0.0.php +++ b/app/code/Magento/Cms/data/cms_setup/data-install-2.0.0.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Cms\Model\Resource\Setup */ $cmsPages = [ diff --git a/app/code/Magento/Cms/view/adminhtml/templates/browser/content.phtml b/app/code/Magento/Cms/view/adminhtml/templates/browser/content.phtml index a22706aef475947f2e0a4508f6b004eb155227b0..e002bfe7d65b873c20bcfc3c9ea8de5a369918af 100644 --- a/app/code/Magento/Cms/view/adminhtml/templates/browser/content.phtml +++ b/app/code/Magento/Cms/view/adminhtml/templates/browser/content.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Content */ ?> diff --git a/app/code/Magento/Cms/view/adminhtml/templates/browser/content/files.phtml b/app/code/Magento/Cms/view/adminhtml/templates/browser/content/files.phtml index 8e5ced05020d9d7b323d1ef8e788a23f9848ec79..131494d5a3a895a79dfa4ffe60fc2bafb3b241c6 100644 --- a/app/code/Magento/Cms/view/adminhtml/templates/browser/content/files.phtml +++ b/app/code/Magento/Cms/view/adminhtml/templates/browser/content/files.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Content\Files */ $_width = $this->getImagesWidth(); diff --git a/app/code/Magento/Cms/view/adminhtml/templates/browser/content/uploader.phtml b/app/code/Magento/Cms/view/adminhtml/templates/browser/content/uploader.phtml index 484eec24c25213286a17537274306ac1b605a427..c76e6fddfeaefc33f80ca24e001e540fd2222d32 100644 --- a/app/code/Magento/Cms/view/adminhtml/templates/browser/content/uploader.phtml +++ b/app/code/Magento/Cms/view/adminhtml/templates/browser/content/uploader.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Content\Uploader */ ?> diff --git a/app/code/Magento/Cms/view/adminhtml/templates/browser/tree.phtml b/app/code/Magento/Cms/view/adminhtml/templates/browser/tree.phtml index ca7bb4c901c596e3db5a1ae3291fb4519abbbb98..8102ca5cc857bd791c86fe5fde243fa448902df5 100644 --- a/app/code/Magento/Cms/view/adminhtml/templates/browser/tree.phtml +++ b/app/code/Magento/Cms/view/adminhtml/templates/browser/tree.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var \Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Tree $this */ ?> <div class="tree-panel" > diff --git a/app/code/Magento/Cms/view/adminhtml/templates/page/edit/form/renderer/content.phtml b/app/code/Magento/Cms/view/adminhtml/templates/page/edit/form/renderer/content.phtml index 2b709598a31c3ed357c7635f815be03d7484b91c..ea70f5e6d9e5d1e81e3e15cb1b63a6e22816a2cc 100644 --- a/app/code/Magento/Cms/view/adminhtml/templates/page/edit/form/renderer/content.phtml +++ b/app/code/Magento/Cms/view/adminhtml/templates/page/edit/form/renderer/content.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_element = $this->getElement() ?> diff --git a/app/code/Magento/Cms/view/frontend/templates/content.phtml b/app/code/Magento/Cms/view/frontend/templates/content.phtml index 7d2d1100cfcbdaf99851444fd0cd4f2bb61fd131..fe227c664e5ed03adca52c18f3abfd3d62a8d344 100644 --- a/app/code/Magento/Cms/view/frontend/templates/content.phtml +++ b/app/code/Magento/Cms/view/frontend/templates/content.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $pageData->getPageContent(); ?> diff --git a/app/code/Magento/Cms/view/frontend/templates/meta.phtml b/app/code/Magento/Cms/view/frontend/templates/meta.phtml index e19cdfe72ddfe0fb5da21566f8adbd9381010659..bf71d4807b8257423f0e2b6a0de538cf5d8fcf5b 100644 --- a/app/code/Magento/Cms/view/frontend/templates/meta.phtml +++ b/app/code/Magento/Cms/view/frontend/templates/meta.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($pageData->getPageMetaKeywords()): ?> <meta name="keywords" content="<?php echo $pageData->getPageMetaKeywords() ?>"/> diff --git a/app/code/Magento/ConfigurableProduct/Block/Adminhtml/Product/Attribute/Edit/Tab/Variations/Main.php b/app/code/Magento/ConfigurableProduct/Block/Adminhtml/Product/Attribute/Edit/Tab/Variations/Main.php index b2d488a12a207f4ab24373070c4ecd1b3c06f52e..946ad7fe76593534fb2ca2bdbc6b76b0ca180c94 100644 --- a/app/code/Magento/ConfigurableProduct/Block/Adminhtml/Product/Attribute/Edit/Tab/Variations/Main.php +++ b/app/code/Magento/ConfigurableProduct/Block/Adminhtml/Product/Attribute/Edit/Tab/Variations/Main.php @@ -11,6 +11,9 @@ */ namespace Magento\ConfigurableProduct\Block\Adminhtml\Product\Attribute\Edit\Tab\Variations; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Main extends \Magento\Eav\Block\Adminhtml\Attribute\Edit\Main\AbstractMain { /** diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/attribute/set/js.phtml b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/attribute/set/js.phtml index d567e97297cb2ce033526dcb12026bc88520655b..86aa4e4d7b5566fcd6bb1956122794bbe72484f1 100644 --- a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/attribute/set/js.phtml +++ b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/attribute/set/js.phtml @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <script> require(['jquery'], function(){ diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/composite/fieldset/configurable.phtml b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/composite/fieldset/configurable.phtml index 98048c0295cdb2302025622064dfbc46405f1828..54ca1bb89b6cc3f1540adc1080ae19010fcfe926 100644 --- a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/composite/fieldset/configurable.phtml +++ b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/composite/fieldset/configurable.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\ConfigurableProduct\Block\Adminhtml\Product\Composite\Fieldset\Configurable */ ?> diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/attribute-js-template.phtml b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/attribute-js-template.phtml index a039419161fae919683a8ac15d7799dfc44b2ef0..3870f9f7cd7d6b59ce684837066383d6ff5c1449 100644 --- a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/attribute-js-template.phtml +++ b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/attribute-js-template.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Framework\View\Element\Template */ ?> <script data-template-for="configurable-attribute" type="text/x-jquery-tmpl"> diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/attribute-template.phtml b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/attribute-template.phtml index ec22cc2ead7bc4ba7bae66739618968273e2248d..88919daee9bf51da1ef87a700003988109aa95bd 100644 --- a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/attribute-template.phtml +++ b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/attribute-template.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Framework\View\Element\Template */ $havePriceVariation = array_reduce( diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/config.phtml b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/config.phtml index bbae310539adef2c181b9d69b084680f61bf84cf..ff251e507b34cde535878792bb1e5dc2f2feaa22 100644 --- a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/config.phtml +++ b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/config.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\ConfigurableProduct\Block\Adminhtml\Product\Edit\Tab\Super\Config */ use Magento\ConfigurableProduct\Model\Product\Type\Configurable; diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/matrix.phtml b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/matrix.phtml index e13eb99291c3cf2c29b85e6284ce58859479e832..350278a567e2f0221cad66b60c2049ae84bc2321 100644 --- a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/matrix.phtml +++ b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/super/matrix.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\ConfigurableProduct\Block\Adminhtml\Product\Edit\Tab\Super\Config\Matrix */ ?> <?php diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/product/configurable/affected-attribute-set-selector/form.phtml b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/product/configurable/affected-attribute-set-selector/form.phtml index 2f82dc3cea8e3994eed31eeac3a92a2314ef9596..8fbec783c9eecf9aceb93ea9e1cb70f800365670 100644 --- a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/product/configurable/affected-attribute-set-selector/form.phtml +++ b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/product/configurable/affected-attribute-set-selector/form.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /* @var $this \Magento\Framework\View\Element\Template */ ?> <div id="<?php echo $this->getNameInLayout() ?>" style="display:none" data-role="dialog" data-id="affected-attribute-set-selector"> diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/product/configurable/affected-attribute-set-selector/js.phtml b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/product/configurable/affected-attribute-set-selector/js.phtml index e5bee19a9b65fe5ad8813f032ab277b2aea03b27..e152ac03776bc1845dda01ced8b348e22a3bf322 100644 --- a/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/product/configurable/affected-attribute-set-selector/js.phtml +++ b/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/product/configurable/affected-attribute-set-selector/js.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\ConfigurableProduct\Block\Product\Configurable\AttributeSelector */ ?> <script> diff --git a/app/code/Magento/ConfigurableProduct/view/frontend/templates/js/components.phtml b/app/code/Magento/ConfigurableProduct/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/ConfigurableProduct/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/ConfigurableProduct/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/ConfigurableProduct/view/frontend/templates/product/view/type/options/configurable.phtml b/app/code/Magento/ConfigurableProduct/view/frontend/templates/product/view/type/options/configurable.phtml index e168da87d1f3de2ea6db4220be10efd9628c8cbb..67e7df6afd16a6b4a5c032b797d60b9dc4f8e2d9 100644 --- a/app/code/Magento/ConfigurableProduct/view/frontend/templates/product/view/type/options/configurable.phtml +++ b/app/code/Magento/ConfigurableProduct/view/frontend/templates/product/view/type/options/configurable.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Contact/view/frontend/templates/form.phtml b/app/code/Magento/Contact/view/frontend/templates/form.phtml index c8d6c3582a439192885e6c47899972f1b93735c1..203018742a85edac48b488daed4a2714e1378692 100644 --- a/app/code/Magento/Contact/view/frontend/templates/form.phtml +++ b/app/code/Magento/Contact/view/frontend/templates/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <form class="form contact" action="<?php echo $this->getFormAction(); ?>" diff --git a/app/code/Magento/Core/App/Router/Base.php b/app/code/Magento/Core/App/Router/Base.php index e34fd166b9b986a0d58fdbfd895c1901dc37c3b8..fffca1867cb6eebb51615bf1fcc08c18a288601f 100644 --- a/app/code/Magento/Core/App/Router/Base.php +++ b/app/code/Magento/Core/App/Router/Base.php @@ -9,6 +9,10 @@ namespace Magento\Core\App\Router; use Magento\Framework\App\RequestInterface; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Base implements \Magento\Framework\App\RouterInterface { /** @@ -117,6 +121,8 @@ class Base implements \Magento\Framework\App\RouterInterface * @param string $routerId * @param \Magento\Framework\Code\NameBuilder $nameBuilder * @throws \InvalidArgumentException + * @SuppressWarnings(PHPMD.ExcessiveParameterList) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function __construct( \Magento\Framework\App\Router\ActionList $actionList, @@ -254,6 +260,8 @@ class Base implements \Magento\Framework\App\RouterInterface * @param \Magento\Framework\App\RequestInterface $request * @param array $params * @return \Magento\Framework\App\Action\Action|null + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function matchAction(\Magento\Framework\App\RequestInterface $request, array $params) { @@ -345,6 +353,7 @@ class Base implements \Magento\Framework\App\RouterInterface * @param \Magento\Framework\App\RequestInterface $request * @param string $path * @return void + * @SuppressWarnings(PHPMD.ExitExpression) */ protected function _checkShouldBeSecure(\Magento\Framework\App\RequestInterface $request, $path = '') { diff --git a/app/code/Magento/Core/Model/Asset/Config.php b/app/code/Magento/Core/Model/Asset/Config.php index 2960c751ac258bef1e258348e3203f25ec078289..817dd603a5f8e4ebbe3d4c9d368a4246e1ee4e00 100644 --- a/app/code/Magento/Core/Model/Asset/Config.php +++ b/app/code/Magento/Core/Model/Asset/Config.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\Asset; /** diff --git a/app/code/Magento/Core/Model/File/Storage.php b/app/code/Magento/Core/Model/File/Storage.php index 1961a8753289c1f5f4e38f697a2ea2cb24ab9178..540c0b8fb19a01444ea3282943f187f4540d4b0f 100644 --- a/app/code/Magento/Core/Model/File/Storage.php +++ b/app/code/Magento/Core/Model/File/Storage.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\File; use Magento\Framework\App\Filesystem\DirectoryList; @@ -11,6 +14,7 @@ use Magento\Framework\Model\AbstractModel; /** * Class Storage + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Storage extends AbstractModel { @@ -97,6 +101,7 @@ class Storage extends AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -195,6 +200,8 @@ class Storage extends AbstractModel * * @param array $storage * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function synchronize($storage) { diff --git a/app/code/Magento/Core/Model/File/Storage/Database.php b/app/code/Magento/Core/Model/File/Storage/Database.php index eebaa64ddd5b23872fc85850f57d50af0406e96f..8770fcf34b68893a59b75f6808f1031a3ec3aa2a 100644 --- a/app/code/Magento/Core/Model/File/Storage/Database.php +++ b/app/code/Magento/Core/Model/File/Storage/Database.php @@ -53,6 +53,7 @@ class Database extends \Magento\Core\Model\File\Storage\Database\AbstractDatabas * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param null $connectionName * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Core/Model/File/Storage/Directory/Database.php b/app/code/Magento/Core/Model/File/Storage/Directory/Database.php index 1e14ed3cf0fa442e9db65498581b140c08ff9b93..74979050fd4b94f7578b61dd18c765debd266f86 100644 --- a/app/code/Magento/Core/Model/File/Storage/Directory/Database.php +++ b/app/code/Magento/Core/Model/File/Storage/Directory/Database.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\File\Storage\Directory; /** @@ -40,6 +43,7 @@ class Database extends \Magento\Core\Model\File\Storage\Database\AbstractDatabas * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param null $connectionName * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Core/Model/File/Storage/File.php b/app/code/Magento/Core/Model/File/Storage/File.php index 589a72559cc58b9c338c47879a58172e501ec524..0ae3a40daf700d3ed94244039e247d9a13dda86a 100644 --- a/app/code/Magento/Core/Model/File/Storage/File.php +++ b/app/code/Magento/Core/Model/File/Storage/File.php @@ -131,6 +131,7 @@ class File * @param int $count * @param string $type * @return array|bool + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function collectData($offset = 0, $count = 100, $type = 'files') { diff --git a/app/code/Magento/Core/Model/File/Storage/Flag.php b/app/code/Magento/Core/Model/File/Storage/Flag.php index 6a455b13948b76cfa51dbef3044d3c571fd1300a..03887a4f81fdf8c7ecfe77a7226439c4926a3dd7 100644 --- a/app/code/Magento/Core/Model/File/Storage/Flag.php +++ b/app/code/Magento/Core/Model/File/Storage/Flag.php @@ -50,6 +50,7 @@ class Flag extends \Magento\Framework\Flag * * @param \Exception $e * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function passError(\Exception $e) { diff --git a/app/code/Magento/Core/Model/File/Validator/AvailablePath.php b/app/code/Magento/Core/Model/File/Validator/AvailablePath.php index 5381b8af10aee3a76b91b0165b2ed0505bc9689e..1b828a354ec3ef53c4e5bacbc88997225ef666af 100644 --- a/app/code/Magento/Core/Model/File/Validator/AvailablePath.php +++ b/app/code/Magento/Core/Model/File/Validator/AvailablePath.php @@ -191,6 +191,7 @@ class AvailablePath extends \Zend_Validate_Abstract * @param string $value File/dir path * @return bool * @throws \Exception Throw exception on empty both paths masks types + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isValid($value) { @@ -232,6 +233,8 @@ class AvailablePath extends \Zend_Validate_Abstract * @param string[] $paths Protected/available paths masks * @param bool $protected Paths masks is protected? * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _isValidByPaths($valuePathInfo, $paths, $protected) { diff --git a/app/code/Magento/Core/Model/File/Validator/NotProtectedExtension.php b/app/code/Magento/Core/Model/File/Validator/NotProtectedExtension.php index e74a01f94de2100d82df8edd6675f99842e07e4c..a4e57209398de9e2512063da027d59de197d45ad 100644 --- a/app/code/Magento/Core/Model/File/Validator/NotProtectedExtension.php +++ b/app/code/Magento/Core/Model/File/Validator/NotProtectedExtension.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\File\Validator; /** diff --git a/app/code/Magento/Core/Model/Layout/Merge.php b/app/code/Magento/Core/Model/Layout/Merge.php index 49556843082e4cb3a545176e53086b7ab31903b8..7627c26dcea011b867262a0ec50fd466b0b4b183 100644 --- a/app/code/Magento/Core/Model/Layout/Merge.php +++ b/app/code/Magento/Core/Model/Layout/Merge.php @@ -10,6 +10,8 @@ use Magento\Framework\App\Filesystem\DirectoryList; /** * Layout merge model + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Merge implements \Magento\Framework\View\Layout\ProcessorInterface { @@ -169,6 +171,7 @@ class Merge implements \Magento\Framework\View\Layout\ProcessorInterface * @param \Magento\Framework\Filesystem $filesystem * @param \Magento\Framework\View\Design\ThemeInterface $theme Non-injectable theme instance * @param string $cacheSuffix + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\DesignInterface $design, diff --git a/app/code/Magento/Core/Model/Observer.php b/app/code/Magento/Core/Model/Observer.php index f60375aeda72efd0f037469a033b256c5dbf90fe..d7f98a7af4a5dc555d4cc63c8f61706641e9f8c5 100644 --- a/app/code/Magento/Core/Model/Observer.php +++ b/app/code/Magento/Core/Model/Observer.php @@ -57,6 +57,7 @@ class Observer * @param \Magento\Framework\View\Asset\Repository $assetRepo * @param Theme\Registration $registration * @param \Psr\Log\LoggerInterface $logger + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function __construct( \Magento\Framework\App\Cache\Frontend\Pool $cacheFrontendPool, diff --git a/app/code/Magento/Core/Model/Resource/Config.php b/app/code/Magento/Core/Model/Resource/Config.php index 0bbc234e6bc9254dc6869c577c0a745161f064c3..b1f4795206d2d0b5841cd33845d0058994b6e6a0 100644 --- a/app/code/Magento/Core/Model/Resource/Config.php +++ b/app/code/Magento/Core/Model/Resource/Config.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\Resource; /** diff --git a/app/code/Magento/Core/Model/Resource/Design.php b/app/code/Magento/Core/Model/Resource/Design.php index df4bff17d80ce1b1c98f7146c2088c664757c95a..cc46d6be28404776160bcd2bd2f601143882837c 100644 --- a/app/code/Magento/Core/Model/Resource/Design.php +++ b/app/code/Magento/Core/Model/Resource/Design.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\Resource; use Magento\Framework\Stdlib\DateTime; @@ -106,6 +109,8 @@ class Design extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param string $dateTo * @param int $currentId * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _checkIntersection($storeId, $dateFrom, $dateTo, $currentId) { diff --git a/app/code/Magento/Core/Model/Resource/Layout/Update.php b/app/code/Magento/Core/Model/Resource/Layout/Update.php index d6dd5b7e001dc93bb9bc88bd465ab648c5e1ce41..00d3e0eff82816fc674d7c1fc3360fb6514b85a6 100644 --- a/app/code/Magento/Core/Model/Resource/Layout/Update.php +++ b/app/code/Magento/Core/Model/Resource/Layout/Update.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\Resource\Layout; /** diff --git a/app/code/Magento/Core/Model/Resource/Variable.php b/app/code/Magento/Core/Model/Resource/Variable.php index 0ed9582d16e438aa1970e7ef7001cb161723f594..89f12a20106ee768f78f1fdf52b1ef81bdb26822 100644 --- a/app/code/Magento/Core/Model/Resource/Variable.php +++ b/app/code/Magento/Core/Model/Resource/Variable.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\Resource; /** diff --git a/app/code/Magento/Core/Model/TemplateEngine/Decorator/DebugHints.php b/app/code/Magento/Core/Model/TemplateEngine/Decorator/DebugHints.php index fe7d4f5bde5f1de15a2f8f392727d4cb8af928d5..d08a2b358f49346da60a7f7126bca32ba8258947 100644 --- a/app/code/Magento/Core/Model/TemplateEngine/Decorator/DebugHints.php +++ b/app/code/Magento/Core/Model/TemplateEngine/Decorator/DebugHints.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\TemplateEngine\Decorator; class DebugHints implements \Magento\Framework\View\TemplateEngineInterface diff --git a/app/code/Magento/Core/Model/TemplateEngine/Plugin/DebugHints.php b/app/code/Magento/Core/Model/TemplateEngine/Plugin/DebugHints.php index 72aa182d6f9f4fe782966b40f2c569370b395979..ee3a7e22f96c88cf283874599c4e0af3916f4931 100644 --- a/app/code/Magento/Core/Model/TemplateEngine/Plugin/DebugHints.php +++ b/app/code/Magento/Core/Model/TemplateEngine/Plugin/DebugHints.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\TemplateEngine\Plugin; class DebugHints diff --git a/app/code/Magento/Core/Model/Url/RouteParamsResolver.php b/app/code/Magento/Core/Model/Url/RouteParamsResolver.php index f08c89fbbadbfeb10a8172920d696d3c4e5d506e..3cabde3cc42c9c2a20a71390a58dfc9cb5a3bc7e 100644 --- a/app/code/Magento/Core/Model/Url/RouteParamsResolver.php +++ b/app/code/Magento/Core/Model/Url/RouteParamsResolver.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\Url; class RouteParamsResolver extends \Magento\Framework\Object implements \Magento\Framework\Url\RouteParamsResolverInterface @@ -50,6 +53,8 @@ class RouteParamsResolver extends \Magento\Framework\Object implements \Magento\ /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function setRouteParams(array $data, $unsetOldParams = true) { diff --git a/app/code/Magento/Core/Model/Variable/Config.php b/app/code/Magento/Core/Model/Variable/Config.php index d6cda985cd31f61c53f321a1bf71fd3c6b069a76..aa4af98d5112832ebcc976e14ca7b7b9296328b3 100644 --- a/app/code/Magento/Core/Model/Variable/Config.php +++ b/app/code/Magento/Core/Model/Variable/Config.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Variable Wysiwyg Plugin Config * diff --git a/app/code/Magento/Core/view/frontend/templates/messages.phtml b/app/code/Magento/Core/view/frontend/templates/messages.phtml index 9c2e61b4a80a6f5af61b36730f438b56d15c6a4a..c5c19765b1fdf22b602e4f4fd749c184203e7756 100644 --- a/app/code/Magento/Core/view/frontend/templates/messages.phtml +++ b/app/code/Magento/Core/view/frontend/templates/messages.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php foreach ($types as $type) { if ($messages = $this->getMessages($type)) { diff --git a/app/code/Magento/Cron/Model/Backend/Config/Structure/Converter.php b/app/code/Magento/Cron/Model/Backend/Config/Structure/Converter.php index d01472b6c3c62665bce9f678f330065b21a39dc7..dafb84f95ec90802c3f4d66e3eb6b72d27123b10 100644 --- a/app/code/Magento/Cron/Model/Backend/Config/Structure/Converter.php +++ b/app/code/Magento/Cron/Model/Backend/Config/Structure/Converter.php @@ -28,6 +28,7 @@ class Converter * * @return array * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function afterConvert(\Magento\Backend\Model\Config\Structure\Converter $subject, array $result) { diff --git a/app/code/Magento/Cron/Model/Observer.php b/app/code/Magento/Cron/Model/Observer.php index 06d50162570fb2216c2b9836f192676ea9147dab..2f8a1dafaa0a468261865288cb11bbdd0951566b 100644 --- a/app/code/Magento/Cron/Model/Observer.php +++ b/app/code/Magento/Cron/Model/Observer.php @@ -11,6 +11,9 @@ namespace Magento\Cron\Model; use Magento\Framework\App\Filesystem\DirectoryList; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Observer { /**#@+ @@ -118,6 +121,9 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function dispatch($observer) { diff --git a/app/code/Magento/Cron/Model/Schedule.php b/app/code/Magento/Cron/Model/Schedule.php index e3bf41f7c5526af6fbb02a340a07c41fa1dd0ff5..aea7916579d9c4c99dcf2d43c643e1f65013e63d 100644 --- a/app/code/Magento/Cron/Model/Schedule.php +++ b/app/code/Magento/Cron/Model/Schedule.php @@ -128,6 +128,8 @@ class Schedule extends \Magento\Framework\Model\AbstractModel * @param int $num * @return bool * @throws Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function matchCronExpression($expr, $num) { diff --git a/app/code/Magento/CurrencySymbol/Controller/Adminhtml/System/Currency/SaveRates.php b/app/code/Magento/CurrencySymbol/Controller/Adminhtml/System/Currency/SaveRates.php index 7ffd6dd70d821aeaec55cf609a027464cb52da75..01ba604f11065b040db154c4d422b4882490a500 100644 --- a/app/code/Magento/CurrencySymbol/Controller/Adminhtml/System/Currency/SaveRates.php +++ b/app/code/Magento/CurrencySymbol/Controller/Adminhtml/System/Currency/SaveRates.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CurrencySymbol\Controller\Adminhtml\System\Currency; class SaveRates extends \Magento\CurrencySymbol\Controller\Adminhtml\System\Currency diff --git a/app/code/Magento/CurrencySymbol/Model/System/Currencysymbol.php b/app/code/Magento/CurrencySymbol/Model/System/Currencysymbol.php index 507b7f84bdfeac0e1893dd1d46c2c76fb9fbb573..19261b5ba0c895f514b3549da4a67d0e35c774d0 100644 --- a/app/code/Magento/CurrencySymbol/Model/System/Currencysymbol.php +++ b/app/code/Magento/CurrencySymbol/Model/System/Currencysymbol.php @@ -139,6 +139,8 @@ class Currencysymbol * Returns currency symbol properties array based on config values * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getCurrencySymbolsData() { diff --git a/app/code/Magento/CurrencySymbol/view/adminhtml/templates/grid.phtml b/app/code/Magento/CurrencySymbol/view/adminhtml/templates/grid.phtml index 6fda0838c38e5d9c60112f62898652a194a2be58..539a5d49171c36a94158e2b553ed4bcc1ca77030 100644 --- a/app/code/Magento/CurrencySymbol/view/adminhtml/templates/grid.phtml +++ b/app/code/Magento/CurrencySymbol/view/adminhtml/templates/grid.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rate/matrix.phtml b/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rate/matrix.phtml index 0e52efe888f09f0fa06c9c510baf163dfbc1034d..e749382db2c898163726317804efe4b1000881cc 100644 --- a/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rate/matrix.phtml +++ b/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rate/matrix.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rate/services.phtml b/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rate/services.phtml index 2ef9ce021ff20d4fe830437e99ddcf8855bfb61a..80eec83eef6c75f495486b388bbca5eff0242fda 100644 --- a/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rate/services.phtml +++ b/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rate/services.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rates.phtml b/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rates.phtml index e4b2a983985e3133dae3e99ecdff09c4866379f0..6834b24cffad9b34b3a4f8ce4c4db54aa29ed397 100644 --- a/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rates.phtml +++ b/app/code/Magento/CurrencySymbol/view/adminhtml/templates/system/currency/rates.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Addresses.php b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Addresses.php index 6aa58a32a0d0c3fe266a187add0ac9155c9dad85..1d6b498ffe26475c7e1c5bec1b9d11aec3cc7832 100644 --- a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Addresses.php +++ b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Addresses.php @@ -19,6 +19,7 @@ use Magento\Customer\Model\Address\Mapper as AddressMapper; * Customer addresses forms * * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Addresses extends GenericMetadata { diff --git a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Reviews.php b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Reviews.php index b7787ba79b7dbbf601ded309122b4a300ad7cd0d..f8a715c4213c29bb39555e78daca203f821085e6 100644 --- a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Reviews.php +++ b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Reviews.php @@ -11,6 +11,9 @@ */ namespace Magento\Customer\Block\Adminhtml\Edit\Tab; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Reviews extends \Magento\Review\Block\Adminhtml\Grid { /** diff --git a/app/code/Magento/Customer/Helper/Address.php b/app/code/Magento/Customer/Helper/Address.php index 2f1faad85cac8d603298ff376547f83391024a29..398522e04a45838cc4537906d3e3d616395c63b6 100644 --- a/app/code/Magento/Customer/Helper/Address.php +++ b/app/code/Magento/Customer/Helper/Address.php @@ -15,6 +15,7 @@ use Magento\Framework\Exception\NoSuchEntityException; * Customer address helper * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Address extends \Magento\Framework\App\Helper\AbstractHelper { diff --git a/app/code/Magento/Customer/Model/AccountManagement.php b/app/code/Magento/Customer/Model/AccountManagement.php index 56871b94cebd593d9c5c237e98acf65bd34c5c84..c5c59b797fae8087e2c8a07428dcb38e66f040f6 100644 --- a/app/code/Magento/Customer/Model/AccountManagement.php +++ b/app/code/Magento/Customer/Model/AccountManagement.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Model; use Magento\Customer\Api\AccountManagementInterface; diff --git a/app/code/Magento/Customer/Model/Address.php b/app/code/Magento/Customer/Model/Address.php index 9186a155381718d937b67e1eb0d24b1343d7773d..7e89c37cbcc4c32c197668bf7f1beddfa6fe990c 100644 --- a/app/code/Magento/Customer/Model/Address.php +++ b/app/code/Magento/Customer/Model/Address.php @@ -16,6 +16,7 @@ use Magento\Framework\Api\AttributeDataBuilder; * * @method int getParentId() getParentId() * @method \Magento\Customer\Model\Address setParentId() setParentId(int $parentId) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Address extends \Magento\Customer\Model\Address\AbstractAddress { @@ -54,6 +55,7 @@ class Address extends \Magento\Customer\Model\Address\AbstractAddress * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Customer/Model/Address/AbstractAddress.php b/app/code/Magento/Customer/Model/Address/AbstractAddress.php index 64490f90d083c6c05557190e70e8e1892bda6b6d..777c4d6a04e2aa52121d03d13a4c22f7771ac456 100644 --- a/app/code/Magento/Customer/Model/Address/AbstractAddress.php +++ b/app/code/Magento/Customer/Model/Address/AbstractAddress.php @@ -27,6 +27,7 @@ use Magento\Framework\Api\AttributeDataBuilder; * @method string getTelephone() * @method string getPostcode() * @method bool getShouldIgnoreValidation() + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class AbstractAddress extends \Magento\Framework\Model\AbstractExtensibleModel { @@ -123,6 +124,7 @@ class AbstractAddress extends \Magento\Framework\Model\AbstractExtensibleModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -472,6 +474,7 @@ class AbstractAddress extends \Magento\Framework\Model\AbstractExtensibleModel * @return AddressInterface * @deprecated Use Api/Data/AddressInterface as a result of service operations. Don't rely on the model to provide * the instance of Api/Data/AddressInterface + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getDataModel($defaultBillingAddressId = null, $defaultShippingAddressId = null) { @@ -527,6 +530,8 @@ class AbstractAddress extends \Magento\Framework\Model\AbstractExtensibleModel * Validate address attribute values * * @return bool|array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validate() { diff --git a/app/code/Magento/Customer/Model/Address/Mapper.php b/app/code/Magento/Customer/Model/Address/Mapper.php index fe19174210d149bb3b8a170cba11000d2bfda25a..3fefe1c52cb54138c35d5fddcdc3ecd0d61e406c 100644 --- a/app/code/Magento/Customer/Model/Address/Mapper.php +++ b/app/code/Magento/Customer/Model/Address/Mapper.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Model\Address; use Magento\Customer\Api\Data\AddressInterface; diff --git a/app/code/Magento/Customer/Model/App/Action/ContextPlugin.php b/app/code/Magento/Customer/Model/App/Action/ContextPlugin.php index 024bef6043f414e536c70a6e1fe0e46d07916e8e..164740604d7f52c60bb99f1bce4cbbd8cd5584e2 100644 --- a/app/code/Magento/Customer/Model/App/Action/ContextPlugin.php +++ b/app/code/Magento/Customer/Model/App/Action/ContextPlugin.php @@ -41,6 +41,7 @@ class ContextPlugin * @param callable $proceed * @param \Magento\Framework\App\RequestInterface $request * @return mixed + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aroundDispatch( \Magento\Framework\App\Action\Action $subject, diff --git a/app/code/Magento/Customer/Model/Customer.php b/app/code/Magento/Customer/Model/Customer.php index 2dce07dea3fdba08c583a6333bd73ce180147f19..6cd272bb0c84ab27a5883d6791dc57f50d1b8f1b 100644 --- a/app/code/Magento/Customer/Model/Customer.php +++ b/app/code/Magento/Customer/Model/Customer.php @@ -31,6 +31,10 @@ use Magento\Framework\Api\AttributeDataBuilder; * @method Customer setPasswordHash($string) * @method string getPasswordHash() * @method string getConfirmation() + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel { @@ -219,6 +223,7 @@ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel * @param DataObjectProcessor $dataObjectProcessor * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -991,6 +996,8 @@ class Customer extends \Magento\Framework\Model\AbstractExtensibleModel * (i.e. its change is requested) * * @return bool|string[] + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validate() { diff --git a/app/code/Magento/Customer/Model/Customer/Mapper.php b/app/code/Magento/Customer/Model/Customer/Mapper.php index 92b618edb243d9d05f48a3d7b9f8f43d34d6bc06..c9f499c8226f30e3cb637d60fbf00e306dd31ebd 100644 --- a/app/code/Magento/Customer/Model/Customer/Mapper.php +++ b/app/code/Magento/Customer/Model/Customer/Mapper.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Model\Customer; use Magento\Customer\Api\Data\CustomerInterface; diff --git a/app/code/Magento/Customer/Model/Group.php b/app/code/Magento/Customer/Model/Group.php index ce608ce69a2df9b933d00e412f06bea2445325da..a586e39007900ca49a7ee55faf627f0586bad16e 100644 --- a/app/code/Magento/Customer/Model/Group.php +++ b/app/code/Magento/Customer/Model/Group.php @@ -78,6 +78,7 @@ class Group extends \Magento\Framework\Model\AbstractExtensibleModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Customer/Model/GroupManagement.php b/app/code/Magento/Customer/Model/GroupManagement.php index 52d557faaa8586b8296b934efbc544dffb94fbf5..d090e95592744f01dde02f2cbe23e143ae78dc09 100644 --- a/app/code/Magento/Customer/Model/GroupManagement.php +++ b/app/code/Magento/Customer/Model/GroupManagement.php @@ -17,6 +17,9 @@ use Magento\Customer\Api\GroupRepositoryInterface; use Magento\Customer\Api\Data\GroupDataBuilder; use Magento\Customer\Model\GroupFactory; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class GroupManagement implements \Magento\Customer\Api\GroupManagementInterface { const XML_PATH_DEFAULT_ID = 'customer/create_account/default_group'; diff --git a/app/code/Magento/Customer/Model/Metadata/ElementFactory.php b/app/code/Magento/Customer/Model/Metadata/ElementFactory.php index 81bbad11e015d4e8b6d52c9bb60cfd0e93d20da9..a6f9b33d4bed23bbf8b0c5f87735593b81566486 100644 --- a/app/code/Magento/Customer/Model/Metadata/ElementFactory.php +++ b/app/code/Magento/Customer/Model/Metadata/ElementFactory.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Model\Metadata; class ElementFactory diff --git a/app/code/Magento/Customer/Model/Metadata/Form/AbstractData.php b/app/code/Magento/Customer/Model/Metadata/Form/AbstractData.php index 69f1811f75eb4a6e6b5b1d41ca90bea07d101940..239fc3fb5ba5a0450cc8879acf28ba95cf7315de 100644 --- a/app/code/Magento/Customer/Model/Metadata/Form/AbstractData.php +++ b/app/code/Magento/Customer/Model/Metadata/Form/AbstractData.php @@ -5,10 +5,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Model\Metadata\Form; use Magento\Framework\Api\ArrayObjectSearch; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ abstract class AbstractData { /** @@ -257,6 +263,8 @@ abstract class AbstractData * * @param string $value * @return array|true + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _validateInputRule($value) { @@ -437,6 +445,7 @@ abstract class AbstractData * Return is AJAX Request * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsAjaxRequest() { diff --git a/app/code/Magento/Customer/Model/Metadata/Form/Date.php b/app/code/Magento/Customer/Model/Metadata/Form/Date.php index 85119b1f203f04c57acfbed8bdc67c422d2fd684..6e55f61a5d225b968120b3013a093e4c2103c5aa 100644 --- a/app/code/Magento/Customer/Model/Metadata/Form/Date.php +++ b/app/code/Magento/Customer/Model/Metadata/Form/Date.php @@ -22,6 +22,8 @@ class Date extends AbstractData /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validateValue($value) { diff --git a/app/code/Magento/Customer/Model/Metadata/Form/File.php b/app/code/Magento/Customer/Model/Metadata/Form/File.php index 2c870b7a1f7035909f4b30849af97060ce9a743b..a9db19a68f90883bea48fc494ed0993e9d55d7d2 100644 --- a/app/code/Magento/Customer/Model/Metadata/Form/File.php +++ b/app/code/Magento/Customer/Model/Metadata/Form/File.php @@ -12,6 +12,9 @@ use Magento\Framework\Filesystem; use Magento\Framework\App\Filesystem\DirectoryList; use Magento\Framework\Api\ArrayObjectSearch; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class File extends AbstractData { /** @@ -55,6 +58,7 @@ class File extends AbstractData * @param \Magento\Core\Model\File\Validator\NotProtectedExtension $fileValidator * @param Filesystem $fileSystem * @param UploaderFactory $uploaderFactory + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate, @@ -78,6 +82,7 @@ class File extends AbstractData /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function extractValue(\Magento\Framework\App\RequestInterface $request) { @@ -194,6 +199,8 @@ class File extends AbstractData /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validateValue($value) { diff --git a/app/code/Magento/Customer/Model/Metadata/Form/Image.php b/app/code/Magento/Customer/Model/Metadata/Form/Image.php index 9950d4f4f4b89e7ea84ef824f047b9884871f779..b1e4ce9f362bb368c73da2e93ba8d934b6b60c2a 100644 --- a/app/code/Magento/Customer/Model/Metadata/Form/Image.php +++ b/app/code/Magento/Customer/Model/Metadata/Form/Image.php @@ -17,6 +17,8 @@ class Image extends File * * @param array $value * @return string[] + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _validateByRules($value) { diff --git a/app/code/Magento/Customer/Model/Metadata/Form/Multiline.php b/app/code/Magento/Customer/Model/Metadata/Form/Multiline.php index cec0be11f61edd3cf7b0f2cd5c48a26f86c82460..5a67fbf9cccb17c9d1eb5a32f80f9d4d369116f5 100644 --- a/app/code/Magento/Customer/Model/Metadata/Form/Multiline.php +++ b/app/code/Magento/Customer/Model/Metadata/Form/Multiline.php @@ -25,6 +25,7 @@ class Multiline extends Text /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function validateValue($value) { diff --git a/app/code/Magento/Customer/Model/Metadata/Form/Text.php b/app/code/Magento/Customer/Model/Metadata/Form/Text.php index a7a3ceb2ee887911ff4000ae94319e44b8f0902d..89c93562e50dd575cbb658551467e01c4f02d2a6 100644 --- a/app/code/Magento/Customer/Model/Metadata/Form/Text.php +++ b/app/code/Magento/Customer/Model/Metadata/Form/Text.php @@ -50,6 +50,8 @@ class Text extends AbstractData /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validateValue($value) { diff --git a/app/code/Magento/Customer/Model/Observer.php b/app/code/Magento/Customer/Model/Observer.php index 921993eccb833e26d1761481369da2e111bc5eed..d20135db19bbf761074891fd2d279552f6935247 100644 --- a/app/code/Magento/Customer/Model/Observer.php +++ b/app/code/Magento/Customer/Model/Observer.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Model; /** @@ -151,6 +154,7 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function afterAddressSave($observer) { diff --git a/app/code/Magento/Customer/Model/Renderer/Region.php b/app/code/Magento/Customer/Model/Renderer/Region.php index 20d45ee772c6fb6f03b2b5c70f148db1fd6740da..1704789268f6374d644ab26810d24e0d5ebdc2fc 100644 --- a/app/code/Magento/Customer/Model/Renderer/Region.php +++ b/app/code/Magento/Customer/Model/Renderer/Region.php @@ -56,6 +56,8 @@ class Region implements \Magento\Framework\Data\Form\Element\Renderer\RendererIn /** * @param AbstractElement $element * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function render(AbstractElement $element) { diff --git a/app/code/Magento/Customer/Model/Resource/AddressRepository.php b/app/code/Magento/Customer/Model/Resource/AddressRepository.php index 90959b667315a1bb3b0b1069aebe31843ac5150b..6ef055761a2e58f5c3d7e85d71497c60aca83169 100644 --- a/app/code/Magento/Customer/Model/Resource/AddressRepository.php +++ b/app/code/Magento/Customer/Model/Resource/AddressRepository.php @@ -13,6 +13,9 @@ use Magento\Framework\Api\Search\FilterGroup; use Magento\Framework\Api\SortOrder; use Magento\Framework\Exception\InputException; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class AddressRepository implements \Magento\Customer\Api\AddressRepositoryInterface { /** diff --git a/app/code/Magento/Customer/Model/Resource/Customer.php b/app/code/Magento/Customer/Model/Resource/Customer.php index 3b406e0ff3902fe5675882bff56b67d7a010754a..4577a1a113bd39fa1c78c09f597b640e99e12f8f 100644 --- a/app/code/Magento/Customer/Model/Resource/Customer.php +++ b/app/code/Magento/Customer/Model/Resource/Customer.php @@ -9,6 +9,7 @@ use Magento\Framework\Exception\InputException; /** * Customer entity resource model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Customer extends \Magento\Eav\Model\Entity\AbstractEntity { @@ -40,6 +41,7 @@ class Customer extends \Magento\Eav\Model\Entity\AbstractEntity * @param \Magento\Framework\Validator\Factory $validatorFactory * @param \Magento\Framework\Stdlib\DateTime $dateTime * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Resource $resource, @@ -182,6 +184,7 @@ class Customer extends \Magento\Eav\Model\Entity\AbstractEntity * * @param \Magento\Customer\Model\Customer $customer * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _saveAddresses(\Magento\Customer\Model\Customer $customer) { diff --git a/app/code/Magento/Customer/Model/Resource/CustomerRepository.php b/app/code/Magento/Customer/Model/Resource/CustomerRepository.php index 47b67411fafbd9b2f10dad4a64e2401684efd44a..f8100f6de0373821f4df27fe3af52d424cbb600b 100644 --- a/app/code/Magento/Customer/Model/Resource/CustomerRepository.php +++ b/app/code/Magento/Customer/Model/Resource/CustomerRepository.php @@ -13,6 +13,7 @@ use Magento\Framework\Exception\NoSuchEntityException; /** * Customer repository. + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class CustomerRepository implements \Magento\Customer\Api\CustomerRepositoryInterface { @@ -89,6 +90,7 @@ class CustomerRepository implements \Magento\Customer\Api\CustomerRepositoryInte * @param \Magento\Framework\Event\ManagerInterface $eventManager * @param \Magento\Store\Model\StoreManagerInterface $storeManager * @param \Magento\Framework\Api\ExtensibleDataObjectConverter $extensibleDataObjectConverter + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Customer\Model\CustomerFactory $customerFactory, @@ -120,6 +122,7 @@ class CustomerRepository implements \Magento\Customer\Api\CustomerRepositoryInte /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function save(\Magento\Customer\Api\Data\CustomerInterface $customer, $passwordHash = null) { diff --git a/app/code/Magento/Customer/Model/Resource/Group/Grid/ServiceCollection.php b/app/code/Magento/Customer/Model/Resource/Group/Grid/ServiceCollection.php index 22980e9d14f0cb3a78449e3a8143ca23d64dd31a..04589231f0bcbe46be5e3bc192ac438847fc3ab1 100644 --- a/app/code/Magento/Customer/Model/Resource/Group/Grid/ServiceCollection.php +++ b/app/code/Magento/Customer/Model/Resource/Group/Grid/ServiceCollection.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Model\Resource\Group\Grid; use Magento\Core\Model\EntityFactory; @@ -56,6 +59,7 @@ class ServiceCollection extends AbstractServiceCollection * @param bool $printQuery * @param bool $logQuery * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function loadData($printQuery = false, $logQuery = false) { diff --git a/app/code/Magento/Customer/Model/Resource/Setup.php b/app/code/Magento/Customer/Model/Resource/Setup.php index a3b4333c5b7bf58bb9fecfe62d906084856fedee..3e1f8da9666f56fb1484e8709faa7db0075db304 100644 --- a/app/code/Magento/Customer/Model/Resource/Setup.php +++ b/app/code/Magento/Customer/Model/Resource/Setup.php @@ -47,6 +47,8 @@ class Setup extends \Magento\Eav\Model\Entity\Setup * Add customer attributes to customer forms * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function installCustomerForms() { @@ -114,6 +116,7 @@ class Setup extends \Magento\Eav\Model\Entity\Setup * Retrieve default entities: customer, customer_address * * @return array + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getDefaultEntities() { diff --git a/app/code/Magento/Customer/Model/Session.php b/app/code/Magento/Customer/Model/Session.php index ddfabd8fbcab26ada8886ccda1176c08db7b524a..2f5115569e53f556d4148a9ee27491c46e23cf0c 100644 --- a/app/code/Magento/Customer/Model/Session.php +++ b/app/code/Magento/Customer/Model/Session.php @@ -14,6 +14,7 @@ use Magento\Customer\Model\Resource\Customer as ResourceCustomer; /** * Customer session model * @method string getNoReferer() + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Session extends \Magento\Framework\Session\SessionManager { @@ -112,6 +113,7 @@ class Session extends \Magento\Framework\Session\SessionManager * @param \Magento\Framework\App\Http\Context $httpContext * @param CustomerRepositoryInterface $customerRepository * @param GroupManagementInterface $groupManagement + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Request\Http $request, diff --git a/app/code/Magento/Customer/view/adminhtml/templates/edit/js.phtml b/app/code/Magento/Customer/view/adminhtml/templates/edit/js.phtml index a0c57e3e5b6a5a2460d4279ea747d97faae5d97c..bc03450977917dabdd5debcd3f0805e1b0b3b93f 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/edit/js.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/edit/js.phtml @@ -3,4 +3,7 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> diff --git a/app/code/Magento/Customer/view/adminhtml/templates/edit/tab/account/form/renderer/group.phtml b/app/code/Magento/Customer/view/adminhtml/templates/edit/tab/account/form/renderer/group.phtml index 50b68da8b0fc7498ef7ac111382321872c1803e2..25f5e012252ae24718952058f0e0a895199fdd40 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/edit/tab/account/form/renderer/group.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/edit/tab/account/form/renderer/group.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Customer\Block\Adminhtml\Edit\Renderer\Attribute\Group $this */ diff --git a/app/code/Magento/Customer/view/adminhtml/templates/edit/tab/account/form/renderer/sendemail.phtml b/app/code/Magento/Customer/view/adminhtml/templates/edit/tab/account/form/renderer/sendemail.phtml index fd9eb327097134084e1949f3d3bfd9c0343cafe4..a73b42b2bc2fe82cdb131e0c29fde4d86c42811f 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/edit/tab/account/form/renderer/sendemail.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/edit/tab/account/form/renderer/sendemail.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Customer\Block\Adminhtml\Edit\Renderer\Attribute\Sendemail $this */ diff --git a/app/code/Magento/Customer/view/adminhtml/templates/sales/order/create/address/form/renderer/vat.phtml b/app/code/Magento/Customer/view/adminhtml/templates/sales/order/create/address/form/renderer/vat.phtml index eddc0554a6afcc503fb276a210a8914f926d157b..175341dd7b60b57acfa6dd51ed0daee288658618 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/sales/order/create/address/form/renderer/vat.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/sales/order/create/address/form/renderer/vat.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_element = $this->getElement(); diff --git a/app/code/Magento/Customer/view/adminhtml/templates/system/config/validatevat.phtml b/app/code/Magento/Customer/view/adminhtml/templates/system/config/validatevat.phtml index bb7309a276d40a596c39bfbacad20a1acca83536..ee154f5e3486262389ece17852bc5bf5e2f494c1 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/system/config/validatevat.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/system/config/validatevat.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Customer/view/adminhtml/templates/tab/addresses.phtml b/app/code/Magento/Customer/view/adminhtml/templates/tab/addresses.phtml index ab87821f4903c11c325a736144c96074d1bc434e..ee931b00be13838bffb858fcbde16884532d98a1 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/tab/addresses.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/tab/addresses.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Customer\Block\Adminhtml\Edit\Tab\Addresses */ ?> <script data-template="tab-address-content" type="text/x-jquery-tmpl"> diff --git a/app/code/Magento/Customer/view/adminhtml/templates/tab/cart.phtml b/app/code/Magento/Customer/view/adminhtml/templates/tab/cart.phtml index 318a86133930f1e27db2f7c1c219db7b270d0e82..c876642597c2d1b9d674a7072fca7f0c0aa38cff 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/tab/cart.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/tab/cart.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Customer\Block\Adminhtml\Edit\Tab\Cart */ ?> <?php if ($this->getCartHeader()): ?> diff --git a/app/code/Magento/Customer/view/adminhtml/templates/tab/newsletter.phtml b/app/code/Magento/Customer/view/adminhtml/templates/tab/newsletter.phtml index b622d823d53d50bdd46ab76436c27d004b7daabd..c2f1325e9b5e9b58dbe707145addc83517c3dd59 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/tab/newsletter.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/tab/newsletter.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="entry-edit"> <?php echo $this->getForm()->getHtml() ?> diff --git a/app/code/Magento/Customer/view/adminhtml/templates/tab/view/personal_info.phtml b/app/code/Magento/Customer/view/adminhtml/templates/tab/view/personal_info.phtml index d6cc5cd6eaedb3a39017b1a981dbc72a4dabbb82..cd3e77def831d32ee7ff9db8df708ebd06da3816 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/tab/view/personal_info.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/tab/view/personal_info.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Template for block \Magento\Customer\Block\Adminhtml\Edit\Tab\View\Status\PersonalInfo */ diff --git a/app/code/Magento/Customer/view/adminhtml/templates/tab/view/sales.phtml b/app/code/Magento/Customer/view/adminhtml/templates/tab/view/sales.phtml index 98cc5642da418a989ffc888def33289538ef0555..dc6e656c1451c3b2a72cd37a38b916550f72b3cb 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/tab/view/sales.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/tab/view/sales.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Customer\Block\Adminhtml\Edit\Tab\View\Sales */ ?> <?php $singleStoreMode = $this->isSingleStoreMode(); ?> diff --git a/app/code/Magento/Customer/view/frontend/templates/account/customer.phtml b/app/code/Magento/Customer/view/frontend/templates/account/customer.phtml index 6b41daa14eeae7e632a14b3fe89d2d3ef2e314b5..4d94ac8d130640558bcd0522bcd708776b68edf7 100644 --- a/app/code/Magento/Customer/view/frontend/templates/account/customer.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/account/customer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if($this->customerLoggedIn()): ?> <li class="customer-welcome"> @@ -16,4 +19,4 @@ </div> <?php endif; ?> </li> -<?php endif; ?> \ No newline at end of file +<?php endif; ?> diff --git a/app/code/Magento/Customer/view/frontend/templates/account/dashboard/address.phtml b/app/code/Magento/Customer/view/frontend/templates/account/dashboard/address.phtml index e125e2bbfc7b595d0ec922024b493d2abcd79b05..9002a562a269c7230759f93dfeab4f5b49371d42 100644 --- a/app/code/Magento/Customer/view/frontend/templates/account/dashboard/address.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/account/dashboard/address.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Customer\Block\Account\Dashboard\Address $this */ ?> <div class="block block-dashboard-addresses"> diff --git a/app/code/Magento/Customer/view/frontend/templates/account/dashboard/info.phtml b/app/code/Magento/Customer/view/frontend/templates/account/dashboard/info.phtml index 46c687b43b26658b946210ffdf076e6995ae487c..47e509332865c1458e576cabb43508babba6b1cb 100644 --- a/app/code/Magento/Customer/view/frontend/templates/account/dashboard/info.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/account/dashboard/info.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Customer\Block\Account\Dashboard\Info $this */ ?> <div class="block block-dashboard-info"> diff --git a/app/code/Magento/Customer/view/frontend/templates/account/link/back.phtml b/app/code/Magento/Customer/view/frontend/templates/account/link/back.phtml index 89d9bc1c5a357ba463202a069448601165818b18..c3c1f8a8263ed90ab9e00d7bb7a235ac47e9a197 100644 --- a/app/code/Magento/Customer/view/frontend/templates/account/link/back.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/account/link/back.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="actions-toolbar"> <div class="secondary"><a class="action back" href="<?php echo $this->escapeUrl($this->getBackUrl()) ?>"><span><?php echo __('Back') ?></span></a></div> diff --git a/app/code/Magento/Customer/view/frontend/templates/additionalinfocustomer.phtml b/app/code/Magento/Customer/view/frontend/templates/additionalinfocustomer.phtml index ff34a320a54aaf556dfd771f720a063d8c17c8aa..1a69ab4852e63861119a994ee9c6de14b52763aa 100644 --- a/app/code/Magento/Customer/view/frontend/templates/additionalinfocustomer.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/additionalinfocustomer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Customer/view/frontend/templates/address/book.phtml b/app/code/Magento/Customer/view/frontend/templates/address/book.phtml index 9a489615ca3359591ace55682baf6eca9776cc33..a43a70e4cf7835e43addc5e5bedbda0f3b45da5f 100644 --- a/app/code/Magento/Customer/view/frontend/templates/address/book.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/address/book.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Customer/view/frontend/templates/address/edit.phtml b/app/code/Magento/Customer/view/frontend/templates/address/edit.phtml index 28de5182ebcf123bc723b72003b74d63af269be4..ecefffcdd5f287cd930e8387a6dcfa4e1ffa5d97 100644 --- a/app/code/Magento/Customer/view/frontend/templates/address/edit.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/address/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Customer/view/frontend/templates/form/confirmation.phtml b/app/code/Magento/Customer/view/frontend/templates/form/confirmation.phtml index 5f9c117f2ff026c474c8272460403cbef8340f87..fde01563bf6ebf65245b942d70a081e0a13e8d7e 100644 --- a/app/code/Magento/Customer/view/frontend/templates/form/confirmation.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/form/confirmation.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <form action="" method="post" id="form-validate" class="form send confirmation" data-mage-init='{"validation":{}}'> <fieldset class="fieldset" data-hasrequired="<?php echo __('* Required Fields') ?>"> diff --git a/app/code/Magento/Customer/view/frontend/templates/form/edit.phtml b/app/code/Magento/Customer/view/frontend/templates/form/edit.phtml index ac69936069953a7423d8637f0f8261395f963791..fef3fe5925656db9eefe2b392e8627c037929fb1 100644 --- a/app/code/Magento/Customer/view/frontend/templates/form/edit.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/form/edit.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Customer\Block\Form\Edit $this */ ?> <form class="form form-edit-account" action="<?php echo $this->getUrl('customer/account/editPost') ?>" method="post" id="form-validate" enctype="multipart/form-data" data-hasrequired="<?php echo __('* Required Fields') ?>" autocomplete="off"> diff --git a/app/code/Magento/Customer/view/frontend/templates/form/forgotpassword.phtml b/app/code/Magento/Customer/view/frontend/templates/form/forgotpassword.phtml index 6ea86c19faa2e681fa9f812291a1a43750cd34f3..5015484f07fb928ab607829fcd92d72499273f69 100644 --- a/app/code/Magento/Customer/view/frontend/templates/form/forgotpassword.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/form/forgotpassword.phtml @@ -5,6 +5,9 @@ * * @var $this \Magento\Customer\Block\Account\Forgotpassword */ + +// @codingStandardsIgnoreFile + ?> <form class="form password forget" action="<?php echo $this->getUrl('*/*/forgotpasswordpost') ?>" diff --git a/app/code/Magento/Customer/view/frontend/templates/form/login.phtml b/app/code/Magento/Customer/view/frontend/templates/form/login.phtml index 402fd64e85d5731cb4f3055e247556ec42763cd4..c3ac3196103f1abc3bf2fd67fb64dcfa0eb77286 100644 --- a/app/code/Magento/Customer/view/frontend/templates/form/login.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/form/login.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Customer\Block\Form\Login $this */ ?> <?php diff --git a/app/code/Magento/Customer/view/frontend/templates/form/newsletter.phtml b/app/code/Magento/Customer/view/frontend/templates/form/newsletter.phtml index 49fe0d0e4ac2a3586213dad2aaf1f4f0bf025ce2..11c4819b9df95f2ed5a7bc078e22c9a7d935b999 100644 --- a/app/code/Magento/Customer/view/frontend/templates/form/newsletter.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/form/newsletter.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml('form_before')?> <form class="form form-newsletter-manage" action="<?php echo $this->getAction() ?>" method="post" id="form-validate"> diff --git a/app/code/Magento/Customer/view/frontend/templates/form/register.phtml b/app/code/Magento/Customer/view/frontend/templates/form/register.phtml index c5e770fe209e114c840cc1a1574c44d63bf46045..c60c01c21b12b90e9a942d64c3cab049c9e0d5cd 100644 --- a/app/code/Magento/Customer/view/frontend/templates/form/register.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/form/register.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Customer/view/frontend/templates/form/resetforgottenpassword.phtml b/app/code/Magento/Customer/view/frontend/templates/form/resetforgottenpassword.phtml index c8561e373e0ecd596f82a09344dc4e23729b16ab..b73f2bb0f7ae858e016d8aabaeae5d60de31afc4 100644 --- a/app/code/Magento/Customer/view/frontend/templates/form/resetforgottenpassword.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/form/resetforgottenpassword.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Customer\Block\Account\Resetpassword $this */ ?> <form action="<?php echo $this->getUrl('*/*/resetpasswordpost', ['_query' => ['id' => $this->getCustomerId(), 'token' => $this->getResetPasswordLinkToken()]]); ?>" diff --git a/app/code/Magento/Customer/view/frontend/templates/js/components.phtml b/app/code/Magento/Customer/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Customer/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Customer/view/frontend/templates/newcustomer.phtml b/app/code/Magento/Customer/view/frontend/templates/newcustomer.phtml index a92dd5be986ce183fb1fcdc4491547b51fc5ac67..7a50e3435ed02324acbe0df769863c4f33de6520 100644 --- a/app/code/Magento/Customer/view/frontend/templates/newcustomer.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/newcustomer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Customer/view/frontend/templates/widget/dob.phtml b/app/code/Magento/Customer/view/frontend/templates/widget/dob.phtml index 9e4f73573822d3cbef603528c8bdfbe441256fef..2fb484d208ce3977ce4b0587a0052265090f6dc9 100644 --- a/app/code/Magento/Customer/view/frontend/templates/widget/dob.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/widget/dob.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** USAGE: diff --git a/app/code/Magento/Customer/view/frontend/templates/widget/gender.phtml b/app/code/Magento/Customer/view/frontend/templates/widget/gender.phtml index 88811b0ea8569c0c3cd1b662a5f5fbc0c70bb645..d1539783ae7a53f03a1d4f812bcfa39760bbe4a8 100644 --- a/app/code/Magento/Customer/view/frontend/templates/widget/gender.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/widget/gender.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="field gender<?php if ($this->isRequired()) echo ' required' ?>"> <label class="label" for="<?php echo $this->getFieldId('gender')?>"><span><?php echo __('Gender') ?></span></label> diff --git a/app/code/Magento/Customer/view/frontend/templates/widget/name.phtml b/app/code/Magento/Customer/view/frontend/templates/widget/name.phtml index 317612c3582e718ff31253e826b02663dc779c88..1824b642469fd712b1a2293c892d90747fb2e8f7 100644 --- a/app/code/Magento/Customer/view/frontend/templates/widget/name.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/widget/name.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** USAGE: diff --git a/app/code/Magento/Customer/view/frontend/templates/widget/taxvat.phtml b/app/code/Magento/Customer/view/frontend/templates/widget/taxvat.phtml index 854193dcc2247290b57e4ec67841203fd8bbc671..c7040532aab80c07deb8007fa0eaa2c175c53d63 100644 --- a/app/code/Magento/Customer/view/frontend/templates/widget/taxvat.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/widget/taxvat.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="field taxvat<?php if ($this->isRequired()) echo ' required'; ?>"> <label class="label" for="<?php echo $this->getFieldId('taxvat')?>"><span><?php echo __('Tax/VAT number') ?></span></label> diff --git a/app/code/Magento/CustomerImportExport/Model/Export/Address.php b/app/code/Magento/CustomerImportExport/Model/Export/Address.php index 479b3847fbc729ac8715f0a4647b92a2fbb54a8b..bfe77d3e13c450aa353d8bb7af894494bd81f0ca 100644 --- a/app/code/Magento/CustomerImportExport/Model/Export/Address.php +++ b/app/code/Magento/CustomerImportExport/Model/Export/Address.php @@ -5,6 +5,9 @@ */ namespace Magento\CustomerImportExport\Model\Export; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Address extends \Magento\ImportExport\Model\Export\Entity\AbstractEav { /**#@+ @@ -109,6 +112,7 @@ class Address extends \Magento\ImportExport\Model\Export\Entity\AbstractEav * @param \Magento\CustomerImportExport\Model\Export\CustomerFactory $eavCustomerFactory * @param \Magento\Customer\Model\Resource\Address\CollectionFactory $addressColFactory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, diff --git a/app/code/Magento/CustomerImportExport/Model/Import/AbstractCustomer.php b/app/code/Magento/CustomerImportExport/Model/Import/AbstractCustomer.php index 68e54fe4ad7e1ccffbe8f9f6d5648e58fdf2fce6..fd577239948e53d486348ad0bd6e2b4009878302 100644 --- a/app/code/Magento/CustomerImportExport/Model/Import/AbstractCustomer.php +++ b/app/code/Magento/CustomerImportExport/Model/Import/AbstractCustomer.php @@ -9,6 +9,7 @@ use Magento\CustomerImportExport\Model\Resource\Import\Customer\Storage; /** * Import entity abstract customer model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractCustomer extends \Magento\ImportExport\Model\Import\Entity\AbstractEav { @@ -79,6 +80,7 @@ abstract class AbstractCustomer extends \Magento\ImportExport\Model\Import\Entit * @param \Magento\Eav\Model\Config $eavConfig * @param \Magento\CustomerImportExport\Model\Resource\Import\Customer\StorageFactory $storageFactory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Core\Helper\Data $coreData, diff --git a/app/code/Magento/CustomerImportExport/Model/Import/Address.php b/app/code/Magento/CustomerImportExport/Model/Import/Address.php index 5eed460e571f6e1b7846737940d7a743bba915ad..425c3bab09f303f81aee5460a085c770fc3ecc8c 100644 --- a/app/code/Magento/CustomerImportExport/Model/Import/Address.php +++ b/app/code/Magento/CustomerImportExport/Model/Import/Address.php @@ -5,6 +5,10 @@ */ namespace Magento\CustomerImportExport\Model\Import; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Address extends AbstractCustomer { /**#@+ @@ -226,6 +230,8 @@ class Address extends AbstractCustomer * @param \Magento\Customer\Model\Resource\Address\Attribute\CollectionFactory $attributesFactory * @param \Magento\Framework\Stdlib\DateTime $dateTime * @param array $data + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Core\Helper\Data $coreData, @@ -451,6 +457,8 @@ class Address extends AbstractCustomer * * @param array $rowData * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _prepareDataForUpdate(array $rowData) { @@ -577,6 +585,7 @@ class Address extends AbstractCustomer * * @param array $defaults * @return $this + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _saveCustomerDefaults(array $defaults) { @@ -641,6 +650,8 @@ class Address extends AbstractCustomer * @param array $rowData * @param int $rowNumber * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _validateRowForUpdate(array $rowData, $rowNumber) { diff --git a/app/code/Magento/CustomerImportExport/Model/Import/Customer.php b/app/code/Magento/CustomerImportExport/Model/Import/Customer.php index c2bb61efd6570d9021b9a003bc79bd640f5c275b..a498218c67381f0ed6baabef9bd49c9f56342e38 100644 --- a/app/code/Magento/CustomerImportExport/Model/Import/Customer.php +++ b/app/code/Magento/CustomerImportExport/Model/Import/Customer.php @@ -5,6 +5,9 @@ */ namespace Magento\CustomerImportExport\Model\Import; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Customer extends AbstractCustomer { /** @@ -128,6 +131,7 @@ class Customer extends AbstractCustomer * @param \Magento\Customer\Model\Resource\Attribute\CollectionFactory $attrCollectionFactory * @param \Magento\Customer\Model\CustomerFactory $customerFactory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Core\Helper\Data $coreData, @@ -276,6 +280,8 @@ class Customer extends AbstractCustomer * * @param array $rowData * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _prepareDataForUpdate(array $rowData) { @@ -363,6 +369,7 @@ class Customer extends AbstractCustomer * Import data rows * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _importData() { @@ -430,6 +437,8 @@ class Customer extends AbstractCustomer * @param array $rowData * @param int $rowNumber * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _validateRowForUpdate(array $rowData, $rowNumber) { diff --git a/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Container.php b/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Container.php index fd7e904516c9d73432aa06af9e72d6087f4a05b2..9d4a2c9dcab25d0fe1e1499f360fbd31de80f115 100644 --- a/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Container.php +++ b/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Container.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\DesignEditor\Block\Adminhtml\Editor; /** diff --git a/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Form/Renderer.php b/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Form/Renderer.php index 409ec8fc5f5a4a0328a2bfff745093fc14890bc3..275d18f9e429a20bd759ac407c459ab8c0d25e1f 100644 --- a/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Form/Renderer.php +++ b/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Form/Renderer.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Color-picker form element renderer */ diff --git a/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Form/Renderer/LogoUploader.php b/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Form/Renderer/LogoUploader.php index 7c7aac95ee12d39cf7a87629211cf1462b31d6d3..28db136b67d8f651be513e987e634e0508b6b5a0 100644 --- a/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Form/Renderer/LogoUploader.php +++ b/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Form/Renderer/LogoUploader.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\DesignEditor\Block\Adminhtml\Editor\Form\Renderer; /** diff --git a/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Toolbar/Buttons/Edit.php b/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Toolbar/Buttons/Edit.php index f0601a8196a46f4559f80a99f404f79ff9d2edb9..f2771c3694de21a58ce6167b680f574e655b742b 100644 --- a/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Toolbar/Buttons/Edit.php +++ b/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Toolbar/Buttons/Edit.php @@ -81,6 +81,7 @@ class Edit extends \Magento\Backend\Block\Widget\Button\SplitButton * Whether button is disabled * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDisabled() { diff --git a/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Toolbar/Buttons/Save.php b/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Toolbar/Buttons/Save.php index 45a5a618c242e2e3c3dc134a58ff0fd11c9d63c1..ad833388d9e0a4480cd7c52941f7ad2ebb502a6d 100644 --- a/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Toolbar/Buttons/Save.php +++ b/app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Toolbar/Buttons/Save.php @@ -79,6 +79,7 @@ class Save extends \Magento\Backend\Block\Widget\Button\SplitButton * Whether button is disabled * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDisabled() { diff --git a/app/code/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/Tools/JsList.php b/app/code/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/Tools/JsList.php index ef2b8b72ef1ad5aceab4bf7cd9813e52d6fff2ad..8133a7bfcbd0791bf827ecb83357803bf74ee03d 100644 --- a/app/code/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/Tools/JsList.php +++ b/app/code/Magento/DesignEditor/Controller/Adminhtml/System/Design/Editor/Tools/JsList.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\DesignEditor\Controller\Adminhtml\System\Design\Editor\Tools; class JsList extends \Magento\DesignEditor\Controller\Adminhtml\System\Design\Editor\Tools diff --git a/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Form/Renderer/Factory.php b/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Form/Renderer/Factory.php index 2611c0da296dd68b463e4cb1b09d6553a3d771c2..c3e19c8a2d682078f1fdf6562f50a4f880f97485 100644 --- a/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Form/Renderer/Factory.php +++ b/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Form/Renderer/Factory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\DesignEditor\Model\Editor\Tools\QuickStyles\Form\Renderer; use Magento\Framework\Data\Form\Element\Renderer\RendererInterface; diff --git a/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Renderer/Factory.php b/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Renderer/Factory.php index 6b6d156210ad774b043fafd25d16c78d135330f2..14a2bc8970f949c8bc275d31a0ad627f1b621067 100644 --- a/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Renderer/Factory.php +++ b/app/code/Magento/DesignEditor/Model/Editor/Tools/QuickStyles/Renderer/Factory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\DesignEditor\Model\Editor\Tools\QuickStyles\Renderer; /** diff --git a/app/code/Magento/DesignEditor/Model/Observer.php b/app/code/Magento/DesignEditor/Model/Observer.php index 6058551e4a3654f7e492acc3643cf814c7deb0fb..846f7992e8c0b18c84d1881a2de7037672b3c8e4 100644 --- a/app/code/Magento/DesignEditor/Model/Observer.php +++ b/app/code/Magento/DesignEditor/Model/Observer.php @@ -48,6 +48,7 @@ class Observer * * @param EventObserver $event * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function clearJs(EventObserver $event) { diff --git a/app/code/Magento/DesignEditor/Model/Url/NavigationMode.php b/app/code/Magento/DesignEditor/Model/Url/NavigationMode.php index 38a8ab66a502749a1d90772d664543c9805195d7..af413fcd477b0b044e36d1bc9ed4bfc3c6637eb5 100644 --- a/app/code/Magento/DesignEditor/Model/Url/NavigationMode.php +++ b/app/code/Magento/DesignEditor/Model/Url/NavigationMode.php @@ -44,6 +44,7 @@ class NavigationMode extends \Magento\Framework\Url * @param string $scopeType * @param \Magento\DesignEditor\Helper\Data $helper * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Route\ConfigInterface $routeConfig, diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/container.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/container.phtml index 4ee4f0791d6ceedaf64b6df4464ac9a4d6bb7b73..e2f53a5555d5cf8d66c98bea81ac8920537dfbb3 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/container.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/container.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Container */ ?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/color-picker.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/color-picker.phtml index 1be30cf7f6e0e52909047891bc0c5cca1b026c3b..f4103565a24935fcfbce4cae3bccad9dd49075bc 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/color-picker.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/color-picker.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Form\Renderer\ColorPicker */ ?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite.phtml index 50a12b22aa369050d8de71d4b40afc55dbcf15f8..a34053ec0c2740c11d36c03fbf7e3fa529e9939e 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Form\Renderer\Composite */ ?> <?php diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite/children.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite/children.phtml index 40b05756b023d79ae248e5e3fc237760828f677d..02a6d27d127ad73d705617b66aec525f295c08f3 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite/children.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite/children.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Form\Renderer\Composite */ ?> <?php diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite/wrapper.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite/wrapper.phtml index 8f3879ee560c66ba2440b4a6433b8787a21cf86d..f14050bb4fbb351b4046389d99dc6b3d296dbc7d 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite/wrapper.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/composite/wrapper.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Form\Renderer\Composite */ ?> <?php diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/element/wrapper.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/element/wrapper.phtml index f06a99f2b3c8817b32b8b75243aafb376ee21327..8d4dce8884c1e165e1fa388044cd6804067171e0 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/element/wrapper.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/element/wrapper.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* former part of \Magento\Framework\Data\Form\Element\AbstractElement::getElementHtml() */ ?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/logo-uploader.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/logo-uploader.phtml index 9ce45e52445f26bc1fad21ec933c28a1fffda026..314b3321d8b2b8d8e8993b0c49e73aed8ca6d168 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/logo-uploader.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/logo-uploader.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Form\Renderer\LogoUploader */ ?> <?php /** @var $element \Magento\DesignEditor\Block\Adminhtml\Editor\Form\Element\LogoUploader */?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/simple.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/simple.phtml index 400138948f2236e039f025024c6db32675dca4a1..c0d33c4d0d84bb9e51dffa634c000e8c47228412 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/simple.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/simple.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Form\Renderer\ColorPicker */ ?> <?php diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/template.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/template.phtml index e20ab01a0eeb09a07d5cfe2ef46df8653e50a306..17b71747825ca24be45112cba1b3de4a421b1ba5 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/template.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/form/renderer/template.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Form\Renderer\Checkbox */ ?> <?php diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/toolbar/buttons.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/toolbar/buttons.phtml index 0f78fd322d87500b7b09886c8a63595e0f8204dc..2694bf66dbac6a668bccbe41018128721748abe6 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/toolbar/buttons.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/toolbar/buttons.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Toolbar\Buttons */ ?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/toolbar/buttons/edit.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/toolbar/buttons/edit.phtml index 4923ade335382366af50ad49ef9621d6ff67798b..f67f83345ca09445f30c33b7acd008ffa47e4e9d 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/toolbar/buttons/edit.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/toolbar/buttons/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Toolbar\Buttons\Edit */ diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools.phtml index 38b836a36011fff64b5bc6bf4aa5de9b48d0f2d9..cd74d7dcfb52ed7a41d694922d8434f04c6f5147 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Tools */ ?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/block.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/block.phtml index c0a8ae9b5107aef8cefaf2b43a5543d222bd1544..3c78a93dde6b55d018778920ab271c4bd775ad13 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/block.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/block.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Tools\Block */ ?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/code/custom.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/code/custom.phtml index 7418f6cc9156d4fc9a2fa1024a01645c84fe8f37..9c5632221339aa11cd127f4e2c4b511b9981f742 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/code/custom.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/code/custom.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Tools\Code\Custom */ ?> <div id="vde-tab-custom-messages-placeholder"></div> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/code/js.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/code/js.phtml index a397ce4e107c63c4cecf6e2da0eaee643875dbb2..2fa1b0f9d218337bead686076375ccf9fb2b20d6 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/code/js.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/code/js.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Tools\Code\Js */ ?> <div id="vde-tab-js-messages-placeholder"></div> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/files/content/files.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/files/content/files.phtml index a20fee247a986faf6095009bc391e4a672edb5ab..de35aa79a816f6af599ef90bf882476fff36b0a3 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/files/content/files.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/files/content/files.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/settings.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/settings.phtml index c4d38417e871c704d7127b62e9ff302401047fbe..fadcf835db331f11b1b74b71f959192be2e747ec 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/settings.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/settings.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Tools\Settings */ ?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/tabs.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/tabs.phtml index b87324129da75be6565fedbee91e6f2d9bb7a67f..be422d61d7e047898080e60da2f50c01d50cad18 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/tabs.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/tabs.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Editor\Tools\Tabs\AbstractTabs */ ?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/tabs/super-handle.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/tabs/super-handle.phtml index 61217d12e4e6a9934526e2281961089e49449b0b..14df774abf2dfb29ab7498441f6092fd0ade27c8 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/tabs/super-handle.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/editor/tools/tabs/super-handle.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Backend\Block\Template */ ?> <li class="item<?php echo ' ',$this->getClass(); ?><?php echo $this->getIsHidden() ? ' hidden' : '' ?><?php echo $this->getIsDisabled() ? ' disabled' : '' ?>"> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/available.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/available.phtml index 111d85972b3c355129208bf00872d00d5925b081..9faf2a2eab414d134c4617a0bc10acbd68cd411b 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/available.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/available.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Theme */?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/button.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/button.phtml index 34b3a00a2475f471fbd36945e32e5c5ebac3e018..8a84e69201f8226a52520e767d3ac9efd7b477b8 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/button.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/button.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/customized.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/customized.phtml index 7e384006881bf5921b2c60d9158122f14aa7fc94..8eea9a6d145b8af75c69a337cc3eddc7ccde4af5 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/customized.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/customized.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Theme */?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/list/available.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/list/available.phtml index 1f22c9d7099e434384f7f78d981f9a3234e497b9..993f45050fa90b5ac508d6478decb51df35ef481 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/list/available.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/list/available.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Theme\Selector\SelectorList\Available */?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/list/customized.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/list/customized.phtml index adbcd78222932e183f4a3d32ebf303b2435c87d3..94e827929b0abab5bdbc17a16684bfd4808eccf8 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/list/customized.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/list/customized.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Theme\Selector\SelectorList\AbstractSelectorList */?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/first_entrance.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/first_entrance.phtml index 00bedb2be73bd3a353ff33ca9f0aadca0834ab25..dffd1c51c5a3acc07e8480bb8f413efc5ab2b1bb 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/first_entrance.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/first_entrance.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Backend\Block\Template */?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/storeview.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/storeview.phtml index 0c25310f54ad515ea0e028f3401b1cc316cc58ec..1cb62d26e45135c20d36bca4609c8655838411d0 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/storeview.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/storeview.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\DesignEditor\Block\Adminhtml\Theme\Selector\StoreView */?> diff --git a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/theme_edit.phtml b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/theme_edit.phtml index ef73f24c4e0a83bff820e0b7b8113dc4e5764d8e..59e66712dd0fbcb6c5f4307a31dff0ea77b490de 100644 --- a/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/theme_edit.phtml +++ b/app/code/Magento/DesignEditor/view/adminhtml/templates/theme/selector/theme_edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <script> diff --git a/app/code/Magento/DesignEditor/view/frontend/templates/translate_inline.phtml b/app/code/Magento/DesignEditor/view/frontend/templates/translate_inline.phtml index d56fc37da8d0b825dfe3b06a135f2fab00ef602e..a8346f1dfdc34a95be869bbc277605cc5e899071 100644 --- a/app/code/Magento/DesignEditor/view/frontend/templates/translate_inline.phtml +++ b/app/code/Magento/DesignEditor/view/frontend/templates/translate_inline.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Framework\View\Element\Template */ ?> diff --git a/app/code/Magento/Dhl/Block/Adminhtml/Unitofmeasure.php b/app/code/Magento/Dhl/Block/Adminhtml/Unitofmeasure.php index 66d9168c8e79e5c2822777b713bc34ceaf925e48..2cf8353c40866cd2e577bc93b1f8cd6b4ed1f36d 100644 --- a/app/code/Magento/Dhl/Block/Adminhtml/Unitofmeasure.php +++ b/app/code/Magento/Dhl/Block/Adminhtml/Unitofmeasure.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Dhl\Block\Adminhtml; /** diff --git a/app/code/Magento/Dhl/Model/Carrier.php b/app/code/Magento/Dhl/Model/Carrier.php index 66f4aaa64639928a088e59e5dcf903cd49f5a9cc..6b82978549bf8b8676bc89ef1f42f84ee6c14895 100644 --- a/app/code/Magento/Dhl/Model/Carrier.php +++ b/app/code/Magento/Dhl/Model/Carrier.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Dhl\Model; use Magento\Catalog\Model\Product\Type; @@ -15,6 +18,9 @@ use Magento\Shipping\Model\Rate\Result; /** * DHL International (API v1.4) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shipping\Model\Carrier\CarrierInterface { @@ -207,6 +213,7 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * @param \Magento\Framework\HTTP\ZendClientFactory $httpClientFactory * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, @@ -370,6 +377,8 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * * @param \Magento\Framework\Object $request * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function setRequest(\Magento\Framework\Object $request) { @@ -611,6 +620,7 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * * @param string $code One-symbol code (see getDhlProducts()) * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDhlProductTitle($code) { @@ -657,6 +667,8 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * Prepare items to pieces * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getAllItems() { @@ -747,6 +759,7 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * * @param \Magento\Shipping\Model\Simplexml\Element $nodeBkgDetails * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _makePieces(\Magento\Shipping\Model\Simplexml\Element $nodeBkgDetails) { @@ -1009,6 +1022,8 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * @param string $response * @return bool|\Magento\Framework\Object|Result|Error * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _parseResponse($response) { @@ -1096,6 +1111,7 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * * @param \SimpleXMLElement $shipmentDetails * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _addRate(\SimpleXMLElement $shipmentDetails) { @@ -1291,6 +1307,7 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * * @param \Magento\Framework\Object|null $params * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getContainerTypes(\Magento\Framework\Object $params = null) { @@ -1360,6 +1377,9 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * * @return Result|\Magento\Framework\Object * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _doRequest() { @@ -1553,6 +1573,8 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * @param RateRequest $rawRequest * @param string $originRegion * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _shipmentDetails($xml, $rawRequest, $originRegion = '') { @@ -1741,6 +1763,8 @@ class Carrier extends \Magento\Dhl\Model\AbstractDhl implements \Magento\Shippin * @param string[] $trackings * @param string $response * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _parseXmlTrackingResponse($trackings, $response) { diff --git a/app/code/Magento/Dhl/Model/Plugin/Checkout/Block/Cart/Shipping.php b/app/code/Magento/Dhl/Model/Plugin/Checkout/Block/Cart/Shipping.php index 459a363a26597ad9824f301632ee1e56db8f7f95..43ed90ffedcdc732a05cde308c5c914b27ec59b0 100644 --- a/app/code/Magento/Dhl/Model/Plugin/Checkout/Block/Cart/Shipping.php +++ b/app/code/Magento/Dhl/Model/Plugin/Checkout/Block/Cart/Shipping.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Dhl\Model\Plugin\Checkout\Block\Cart; /** diff --git a/app/code/Magento/Directory/Model/Country.php b/app/code/Magento/Directory/Model/Country.php index 03c8fdc65eb13226ca32ff3bd87ba716da70dc1f..4da7c58e06f0a90b3fe09ba1c45cd4887b535c34 100644 --- a/app/code/Magento/Directory/Model/Country.php +++ b/app/code/Magento/Directory/Model/Country.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Country model * diff --git a/app/code/Magento/Directory/Model/Currency.php b/app/code/Magento/Directory/Model/Currency.php index c20e8f7e80a5d6996621385e25789e1d446f0cdc..3b5ec26325abc5716c3c2137e5c4e75549eaf4d0 100644 --- a/app/code/Magento/Directory/Model/Currency.php +++ b/app/code/Magento/Directory/Model/Currency.php @@ -14,6 +14,9 @@ namespace Magento\Directory\Model; use Magento\Directory\Exception; use Magento\Directory\Model\Currency\Filter; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Currency extends \Magento\Framework\Model\AbstractModel { /** @@ -73,6 +76,7 @@ class Currency extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -86,7 +90,13 @@ class Currency extends \Magento\Framework\Model\AbstractModel \Magento\Framework\Data\Collection\Db $resourceCollection = null, array $data = [] ) { - parent::__construct($context, $registry, $resource, $resourceCollection, $data); + parent::__construct( + $context, + $registry, + $resource, + $resourceCollection, + $data + ); $this->_localeFormat = $localeFormat; $this->_storeManager = $storeManager; $this->_directoryHelper = $directoryHelper; @@ -148,6 +158,7 @@ class Currency extends \Magento\Framework\Model\AbstractModel * @param string $id * @param string $field * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function load($id, $field = null) { diff --git a/app/code/Magento/Directory/Model/Currency/Import/Factory.php b/app/code/Magento/Directory/Model/Currency/Import/Factory.php index 894a203a069bc5e74eab9cacb9192885d527adad..3b9970ba5cfb4aeb47bdcfc3d62f36f01f575b5b 100644 --- a/app/code/Magento/Directory/Model/Currency/Import/Factory.php +++ b/app/code/Magento/Directory/Model/Currency/Import/Factory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Directory\Model\Currency\Import; class Factory diff --git a/app/code/Magento/Directory/Model/Currency/Import/Webservicex.php b/app/code/Magento/Directory/Model/Currency/Import/Webservicex.php index 60a2c9c21d9b0b35f0fa9ad1cb8ac93e45367df9..9068c4429d7925d5a2f761b9e954177fce5e7bee 100644 --- a/app/code/Magento/Directory/Model/Currency/Import/Webservicex.php +++ b/app/code/Magento/Directory/Model/Currency/Import/Webservicex.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Currency rate import model (From www.webservicex.net) */ diff --git a/app/code/Magento/Directory/Model/Observer.php b/app/code/Magento/Directory/Model/Observer.php index 59d2499e08630f22ece378df0bbaf4420f7f9227..23d0b5c52f010583ae316fd3ee91fea5c6743a29 100644 --- a/app/code/Magento/Directory/Model/Observer.php +++ b/app/code/Magento/Directory/Model/Observer.php @@ -84,6 +84,7 @@ class Observer /** * @param mixed $schedule * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function scheduledUpdateCurrencyRates($schedule) { diff --git a/app/code/Magento/Directory/Model/Resource/Country/Collection.php b/app/code/Magento/Directory/Model/Resource/Country/Collection.php index e97ae6aa0b99c61653aa339e3361cea26fd8a487..2c188154998a6392fac02525810c060d488475a3 100644 --- a/app/code/Magento/Directory/Model/Resource/Country/Collection.php +++ b/app/code/Magento/Directory/Model/Resource/Country/Collection.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Directory Country Resource Collection */ @@ -54,6 +56,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac * @param \Magento\Framework\Locale\ResolverInterface $localeResolver * @param mixed $connection * @param \Magento\Framework\Model\Resource\Db\AbstractDb $resource + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Core\Model\EntityFactory $entityFactory, diff --git a/app/code/Magento/Directory/Model/Resource/Currency.php b/app/code/Magento/Directory/Model/Resource/Currency.php index db63429f1c00999713e1e105f79b908f367ce620..078faf74e58d765253c17b890bf4ade7da1f55d1 100644 --- a/app/code/Magento/Directory/Model/Resource/Currency.php +++ b/app/code/Magento/Directory/Model/Resource/Currency.php @@ -161,6 +161,7 @@ class Currency extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param \Magento\Directory\Model\Currency $model * @param string $path * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getConfigCurrencies($model, $path) { diff --git a/app/code/Magento/Directory/Model/Resource/Region.php b/app/code/Magento/Directory/Model/Resource/Region.php index 9346c0cc49aea9c7aed15f201d8d14d89aa590ff..f6d3ddeed228616dfec7f0da30cdb5e57eeaded1 100644 --- a/app/code/Magento/Directory/Model/Resource/Region.php +++ b/app/code/Magento/Directory/Model/Resource/Region.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Directory Region Resource Model */ diff --git a/app/code/Magento/Directory/view/frontend/templates/currency.phtml b/app/code/Magento/Directory/view/frontend/templates/currency.phtml index bcc61f1a3e7db0d0670fec6ae803046e597b305b..e0f3b9f24f32762d099ab5ecc954647fc5de33ea 100644 --- a/app/code/Magento/Directory/view/frontend/templates/currency.phtml +++ b/app/code/Magento/Directory/view/frontend/templates/currency.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Directory/view/frontend/templates/currency/switch.phtml b/app/code/Magento/Directory/view/frontend/templates/currency/switch.phtml index af561c5147681222ffba29079f3eb6a30c2d0e12..6589dc8816982535772cdbbb042b1caadd0626e1 100644 --- a/app/code/Magento/Directory/view/frontend/templates/currency/switch.phtml +++ b/app/code/Magento/Directory/view/frontend/templates/currency/switch.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <p><?php echo __('Your current currency is: %1.', $currency->getCode()) ?></p> <p><a href="<?php echo $this->getBaseUrl(); ?>" class="action continue"><span><?php echo __('Continue') ?></span></a></p> diff --git a/app/code/Magento/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php b/app/code/Magento/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php index 96e198f9b12c3ddd340149cb092bf4beb85e7a7a..50cdaebedacbc9b6b7aa2030f5bd136248a88aec 100644 --- a/app/code/Magento/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php +++ b/app/code/Magento/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php @@ -9,6 +9,7 @@ namespace Magento\Downloadable\Block\Adminhtml\Catalog\Product\Edit\Tab\Download * Adminhtml catalog product downloadable items tab links section * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Links extends \Magento\Backend\Block\Template { @@ -88,6 +89,7 @@ class Links extends \Magento\Backend\Block\Template * @param \Magento\Eav\Model\Entity\AttributeFactory $attributeFactory * @param \Magento\Backend\Model\UrlFactory $urlFactory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Backend\Block\Template\Context $context, @@ -215,6 +217,7 @@ class Links extends \Magento\Backend\Block\Template * Check exists defined links title * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUsedDefault() { @@ -225,6 +228,7 @@ class Links extends \Magento\Backend\Block\Template * Return true if price in website scope * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsPriceWebsiteScope() { @@ -242,6 +246,8 @@ class Links extends \Magento\Backend\Block\Template * Return array of links * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getLinkData() { diff --git a/app/code/Magento/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Samples.php b/app/code/Magento/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Samples.php index dd8b6b932b6197f6bdd96c2431471443a8ad7438..8725016bcd3eb00ac56f4b515df51c9ab091fb96 100644 --- a/app/code/Magento/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Samples.php +++ b/app/code/Magento/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Samples.php @@ -189,6 +189,7 @@ class Samples extends \Magento\Backend\Block\Widget * Check exists defined samples title * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUsedDefault() { diff --git a/app/code/Magento/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php b/app/code/Magento/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php index 2ce0a5886f70c57457e8c2c2ba579b8b40546e0a..f2724cdfbd8c669014b7527331c89b2a32f2637f 100644 --- a/app/code/Magento/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php +++ b/app/code/Magento/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Block\Adminhtml\Sales\Items\Column\Downloadable; use Magento\Downloadable\Model\Link\Purchased; diff --git a/app/code/Magento/Downloadable/Block/Catalog/Product/Links.php b/app/code/Magento/Downloadable/Block/Catalog/Product/Links.php index 18d7fb4d305be749403a520336c2d3e11ff743a4..544d9c091faf67a14c96ad0627c53d04da988162 100644 --- a/app/code/Magento/Downloadable/Block/Catalog/Product/Links.php +++ b/app/code/Magento/Downloadable/Block/Catalog/Product/Links.php @@ -46,6 +46,7 @@ class Links extends \Magento\Catalog\Block\Product\AbstractProduct * Enter description here... * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getLinksPurchasedSeparately() { @@ -54,6 +55,7 @@ class Links extends \Magento\Catalog\Block\Product\AbstractProduct /** * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getLinkSelectionRequired() { @@ -137,6 +139,7 @@ class Links extends \Magento\Catalog\Block\Product\AbstractProduct * Return true if target of link new window * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsOpenInNewWindow() { @@ -151,6 +154,7 @@ class Links extends \Magento\Catalog\Block\Product\AbstractProduct * * @param Link $link * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsLinkChecked($link) { diff --git a/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php b/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php index 4fd51e7e64136231b721f23c18e73a3cdccb0d36..179b2816b92e3e001b32ad04ff40d61861b07e2b 100644 --- a/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php +++ b/app/code/Magento/Downloadable/Block/Catalog/Product/Samples.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Block\Catalog\Product; use Magento\Downloadable\Model\Resource\Sample; @@ -60,6 +63,7 @@ class Samples extends \Magento\Catalog\Block\Product\AbstractProduct * Return true if target of link new window * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsOpenInNewWindow() { diff --git a/app/code/Magento/Downloadable/Block/Checkout/Cart/Item/Renderer.php b/app/code/Magento/Downloadable/Block/Checkout/Cart/Item/Renderer.php index a2a4b9839c58e950c31cdd898343805104135e11..4d4506765375100de70a7c5b8c3923166d775ded 100644 --- a/app/code/Magento/Downloadable/Block/Checkout/Cart/Item/Renderer.php +++ b/app/code/Magento/Downloadable/Block/Checkout/Cart/Item/Renderer.php @@ -33,6 +33,7 @@ class Renderer extends \Magento\Checkout\Block\Cart\Item\Renderer * @param \Magento\Downloadable\Helper\Catalog\Product\Configuration $downloadableProductConfiguration * @param \Magento\Framework\Module\Manager $moduleManager * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, diff --git a/app/code/Magento/Downloadable/Block/Checkout/Success.php b/app/code/Magento/Downloadable/Block/Checkout/Success.php index 752f4e2109e32a2f32636eb59ed1ddda0f3688b5..644ecc9688535b31ac5d42420568a0099677b319 100644 --- a/app/code/Magento/Downloadable/Block/Checkout/Success.php +++ b/app/code/Magento/Downloadable/Block/Checkout/Success.php @@ -56,6 +56,7 @@ class Success extends \Magento\Checkout\Block\Onepage\Success * Return true if order(s) has one or more downloadable products * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getOrderHasDownloadable() { diff --git a/app/code/Magento/Downloadable/Block/Customer/Products/ListProducts.php b/app/code/Magento/Downloadable/Block/Customer/Products/ListProducts.php index 62a2044250e530371c98e15beea95c8cd893eea1..66356a4b33bdc28e7fc62d1fce5c48d712df2b77 100644 --- a/app/code/Magento/Downloadable/Block/Customer/Products/ListProducts.php +++ b/app/code/Magento/Downloadable/Block/Customer/Products/ListProducts.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Block\Customer\Products; use Magento\Downloadable\Model\Link\Purchased\Item; @@ -159,6 +162,7 @@ class ListProducts extends \Magento\Framework\View\Element\Template * Return true if target of link new window * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsOpenInNewWindow() { diff --git a/app/code/Magento/Downloadable/Block/Sales/Order/Email/Items/Downloadable.php b/app/code/Magento/Downloadable/Block/Sales/Order/Email/Items/Downloadable.php index fa5792e201c06c14eddb0d07e00c8d4545775984..80c7998839e1f2cc996f4be85d2f41bc5e98d37e 100644 --- a/app/code/Magento/Downloadable/Block/Sales/Order/Email/Items/Downloadable.php +++ b/app/code/Magento/Downloadable/Block/Sales/Order/Email/Items/Downloadable.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Block\Sales\Order\Email\Items; use Magento\Downloadable\Model\Link\Purchased; diff --git a/app/code/Magento/Downloadable/Block/Sales/Order/Email/Items/Order/Downloadable.php b/app/code/Magento/Downloadable/Block/Sales/Order/Email/Items/Order/Downloadable.php index 253484b4ca699a6c83e4827ed37f1da804fbba37..2def86d9c63e08f4123847c905bf66e8aba8eff2 100644 --- a/app/code/Magento/Downloadable/Block/Sales/Order/Email/Items/Order/Downloadable.php +++ b/app/code/Magento/Downloadable/Block/Sales/Order/Email/Items/Order/Downloadable.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Block\Sales\Order\Email\Items\Order; use Magento\Downloadable\Model\Link\Purchased\Item; diff --git a/app/code/Magento/Downloadable/Block/Sales/Order/Item/Renderer/Downloadable.php b/app/code/Magento/Downloadable/Block/Sales/Order/Item/Renderer/Downloadable.php index 941fb00b40bb3ae376e24370e4b01c970a2937b0..7176465cae4437758a013a619683582b42949145 100644 --- a/app/code/Magento/Downloadable/Block/Sales/Order/Item/Renderer/Downloadable.php +++ b/app/code/Magento/Downloadable/Block/Sales/Order/Item/Renderer/Downloadable.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Block\Sales\Order\Item\Renderer; use Magento\Downloadable\Model\Link\Purchased; diff --git a/app/code/Magento/Downloadable/Controller/Customer/Products.php b/app/code/Magento/Downloadable/Controller/Customer/Products.php index 2033aa4de701130fc05b870aaad5e32f7cebeb79..33c4360bb9fb526d0426a36f53d37a2ba243b09a 100644 --- a/app/code/Magento/Downloadable/Controller/Customer/Products.php +++ b/app/code/Magento/Downloadable/Controller/Customer/Products.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Controller\Customer; use Magento\Framework\App\RequestInterface; diff --git a/app/code/Magento/Downloadable/Controller/Download/Link.php b/app/code/Magento/Downloadable/Controller/Download/Link.php index ac1766522120e32fd0359c88b1ac8271dba70128..0c0cd1bbe8544c02137b5e0d853112b908b59c8f 100644 --- a/app/code/Magento/Downloadable/Controller/Download/Link.php +++ b/app/code/Magento/Downloadable/Controller/Download/Link.php @@ -26,6 +26,10 @@ class Link extends \Magento\Downloadable\Controller\Download * Download link action * * @return void|ResponseInterface + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.ExitExpression) */ public function execute() { diff --git a/app/code/Magento/Downloadable/Controller/Download/LinkSample.php b/app/code/Magento/Downloadable/Controller/Download/LinkSample.php index 130992ca01acc177a7c21c5ba0172d3950eb0bab..351fc26c55c5f73eb3d02914e044da4b69267a2c 100644 --- a/app/code/Magento/Downloadable/Controller/Download/LinkSample.php +++ b/app/code/Magento/Downloadable/Controller/Download/LinkSample.php @@ -15,6 +15,7 @@ class LinkSample extends \Magento\Downloadable\Controller\Download * Download link's sample action * * @return ResponseInterface + * @SuppressWarnings(PHPMD.ExitExpression) */ public function execute() { diff --git a/app/code/Magento/Downloadable/Controller/Download/Sample.php b/app/code/Magento/Downloadable/Controller/Download/Sample.php index 4b1102ac5b35b0de05e6c9680115f1e56441cf8b..a8cecbc48bd075a86d2f201c024d3e790fcadff2 100644 --- a/app/code/Magento/Downloadable/Controller/Download/Sample.php +++ b/app/code/Magento/Downloadable/Controller/Download/Sample.php @@ -15,6 +15,7 @@ class Sample extends \Magento\Downloadable\Controller\Download * Download sample action * * @return ResponseInterface + * @SuppressWarnings(PHPMD.ExitExpression) */ public function execute() { diff --git a/app/code/Magento/Downloadable/Helper/Catalog/Product/Configuration.php b/app/code/Magento/Downloadable/Helper/Catalog/Product/Configuration.php index 749126e47bf5de88e2b6a510bb4f0c0c2af5fb07..8d4df3c04791accc9fdc49e496a4c777a584178a 100644 --- a/app/code/Magento/Downloadable/Helper/Catalog/Product/Configuration.php +++ b/app/code/Magento/Downloadable/Helper/Catalog/Product/Configuration.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Helper\Catalog\Product; /** diff --git a/app/code/Magento/Downloadable/Helper/Data.php b/app/code/Magento/Downloadable/Helper/Data.php index 622cdcd1487a08a220acc3d9e636e405a36c5189..faab224de0f9ece8f5081a8122c28ccc3ff8ab13 100644 --- a/app/code/Magento/Downloadable/Helper/Data.php +++ b/app/code/Magento/Downloadable/Helper/Data.php @@ -38,6 +38,7 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * * @param \Magento\Downloadable\Model\Link|Item $link * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsShareable($link) { diff --git a/app/code/Magento/Downloadable/Helper/Download.php b/app/code/Magento/Downloadable/Helper/Download.php index d54c436b78179da2e62ba65921b6831a48bc00a8..4351cf3dccbf55249f5086184630cc662080abd7 100644 --- a/app/code/Magento/Downloadable/Helper/Download.php +++ b/app/code/Magento/Downloadable/Helper/Download.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Helper; use Magento\Framework\App\Filesystem\DirectoryList; @@ -11,6 +14,7 @@ use Magento\Framework\Model\Exception as CoreException; /** * Downloadable Products Download Helper + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Download extends \Magento\Framework\App\Helper\AbstractHelper { @@ -294,6 +298,7 @@ class Download extends \Magento\Framework\App\Helper\AbstractHelper * * @param mixed $store * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getContentDisposition($store = null) { diff --git a/app/code/Magento/Downloadable/Model/Observer.php b/app/code/Magento/Downloadable/Model/Observer.php index df03020572301c229c76aa145819e03c85ac729e..87fce9c49a4dd5ada0eb52a37307673164351675 100644 --- a/app/code/Magento/Downloadable/Model/Observer.php +++ b/app/code/Magento/Downloadable/Model/Observer.php @@ -11,6 +11,7 @@ use Magento\Store\Model\ScopeInterface; * Downloadable Products Observer * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Observer { @@ -111,6 +112,8 @@ class Observer * * @param \Magento\Framework\Object $observer * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function saveDownloadableOrderItem($observer) { @@ -230,6 +233,8 @@ class Observer * * @param \Magento\Framework\Object $observer * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function setLinkStatus($observer) { diff --git a/app/code/Magento/Downloadable/Model/Product/Type.php b/app/code/Magento/Downloadable/Model/Product/Type.php index 295bfdad03370bb3bcd79d92d3263bdafba50036..7fcce95622ed09df8a726120b6920c85e9afa88b 100644 --- a/app/code/Magento/Downloadable/Model/Product/Type.php +++ b/app/code/Magento/Downloadable/Model/Product/Type.php @@ -11,6 +11,7 @@ use Magento\Catalog\Api\ProductRepositoryInterface; * Downloadable product type model * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Type extends \Magento\Catalog\Model\Product\Type\Virtual { @@ -73,6 +74,7 @@ class Type extends \Magento\Catalog\Model\Product\Type\Virtual * @param \Magento\Downloadable\Model\Resource\Sample\CollectionFactory $samplesFactory * @param \Magento\Downloadable\Model\SampleFactory $sampleFactory * @param \Magento\Downloadable\Model\LinkFactory $linkFactory + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Catalog\Model\Product\Option $catalogProductOption, @@ -187,6 +189,7 @@ class Type extends \Magento\Catalog\Model\Product\Type\Virtual * * @param \Magento\Catalog\Model\Product $product * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getLinkSelectionRequired($product) { @@ -229,6 +232,9 @@ class Type extends \Magento\Catalog\Model\Product\Type\Virtual * * @param \Magento\Catalog\Model\Product $product * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function save($product) { @@ -490,6 +496,7 @@ class Type extends \Magento\Catalog\Model\Product\Type\Virtual * @param \Magento\Catalog\Model\Product $product * @param \Magento\Framework\Object $buyRequest * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function processBuyRequest($product, $buyRequest) { @@ -561,6 +568,8 @@ class Type extends \Magento\Catalog\Model\Product\Type\Virtual * @param \Magento\Catalog\Model\Product $product * @param string $processMode * @return array|string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _prepareProduct(\Magento\Framework\Object $buyRequest, $product, $processMode) { diff --git a/app/code/Magento/Downloadable/Model/Resource/Link.php b/app/code/Magento/Downloadable/Model/Resource/Link.php index a8551127a09eac9969ff77eef80e325a274b4d02..758401cb4b2e7778fe5f71f110582bfbb4e9627f 100644 --- a/app/code/Magento/Downloadable/Model/Resource/Link.php +++ b/app/code/Magento/Downloadable/Model/Resource/Link.php @@ -70,6 +70,7 @@ class Link extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param \Magento\Downloadable\Model\Link $linkObject * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function saveItemTitleAndPrice($linkObject) { diff --git a/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/AbstractItems.php b/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/AbstractItems.php index 6d37b4b34e41c1c0ed26d7cea1e12328a54cbe55..913d2f31f15cf928e1be3f38e5503b40d24c650e 100644 --- a/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/AbstractItems.php +++ b/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/AbstractItems.php @@ -3,10 +3,14 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Model\Sales\Order\Pdf\Items; /** * Order Downloadable Pdf Items renderer + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractItems extends \Magento\Sales\Model\Order\Pdf\Items\AbstractItems { @@ -46,6 +50,7 @@ abstract class AbstractItems extends \Magento\Sales\Model\Order\Pdf\Items\Abstra * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/Creditmemo.php b/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/Creditmemo.php index f36030df917aa4c09ec9c02cfeb5d6f71a1bfee9..63a063842af1a697af18dca537728709b4b74b4d 100644 --- a/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/Creditmemo.php +++ b/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/Creditmemo.php @@ -28,6 +28,7 @@ class Creditmemo extends \Magento\Downloadable\Model\Sales\Order\Pdf\Items\Abstr * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/Invoice.php b/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/Invoice.php index f78c138699d5495cb4ad4656d6c9b5cf45ea3955..1bd20800ae0383b8639da82874783266a95e91b2 100644 --- a/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/Invoice.php +++ b/app/code/Magento/Downloadable/Model/Sales/Order/Pdf/Items/Invoice.php @@ -28,6 +28,7 @@ class Invoice extends \Magento\Downloadable\Model\Sales\Order\Pdf\Items\Abstract * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -63,6 +64,7 @@ class Invoice extends \Magento\Downloadable\Model\Sales\Order\Pdf\Items\Abstract * Draw item line * * @return void + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function draw() { diff --git a/app/code/Magento/Downloadable/view/adminhtml/templates/product/composite/fieldset/downloadable.phtml b/app/code/Magento/Downloadable/view/adminhtml/templates/product/composite/fieldset/downloadable.phtml index 73b83098f2c4d5117326cffdaf757f5c67044627..a5d10ad338f57501b29d8988d914fafbd1b6f8d5 100644 --- a/app/code/Magento/Downloadable/view/adminhtml/templates/product/composite/fieldset/downloadable.phtml +++ b/app/code/Magento/Downloadable/view/adminhtml/templates/product/composite/fieldset/downloadable.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Downloadable\Block\Adminhtml\Catalog\Product\Composite\Fieldset\Downloadable */ ?> <?php $_linksPurchasedSeparately = $this->getLinksPurchasedSeparately(); ?> diff --git a/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable.phtml b/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable.phtml index 6bf51b413e7bd03be9c0a9a5be9964e2cf9c4f30..bb64dbcfa41d59cbbfcd59e953838fdc49961b9c 100644 --- a/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable.phtml +++ b/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/links.phtml b/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/links.phtml index e5ba1ac238ce7b1927d553b1a24d11f8ab79f7e2..63e1d5dd1a39ea67eae20fbe854e8e070c891485 100644 --- a/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/links.phtml +++ b/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/links.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/samples.phtml b/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/samples.phtml index 02057dd2c59bbd4655d8e8e30145c864272cd3a6..fc38586b5b3fb070a834b511523523b90baab8d2 100644 --- a/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/samples.phtml +++ b/app/code/Magento/Downloadable/view/adminhtml/templates/product/edit/downloadable/samples.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/creditmemo/name.phtml b/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/creditmemo/name.phtml index 7c2d947026a9d16edc8ec8e8c7176135577365ef..a02c238cb9014ed1e6d86b3a8a8ea8a7fe328150 100644 --- a/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/creditmemo/name.phtml +++ b/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/creditmemo/name.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($_item = $this->getItem()): ?> diff --git a/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/invoice/name.phtml b/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/invoice/name.phtml index cb0d1443ee5beaadbab05ea2117d4b01d11b9393..c6aab1a4b0dbf391b8eae857e56c05474a37a015 100644 --- a/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/invoice/name.phtml +++ b/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/invoice/name.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($_item = $this->getItem()): ?> diff --git a/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/name.phtml b/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/name.phtml index e5366a877da8b276415221891ccc4a083994f520..e723058544141e3e21e8dde66f7a058eaaceda17 100644 --- a/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/name.phtml +++ b/app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/name.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($_item = $this->getItem()): ?> diff --git a/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/links.phtml b/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/links.phtml index dd3ab9d975d1009edbd19bfd9c5f13dd7a6ae213..f5de1b1c17d6c8b42750fe777fa9301dc3abf564 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/links.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/links.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Downloadable\Block\Catalog\Product\Links */ ?> <?php $_linksPurchasedSeparately = $this->getLinksPurchasedSeparately(); ?> diff --git a/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/samples.phtml b/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/samples.phtml index ddba63489926f1d4c37c64205e40a66ceff727a5..0d623925b828dce85b32352b39c92d63180f71dd 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/samples.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/samples.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Downloadable product links * diff --git a/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/type.phtml b/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/type.phtml index afeaa4371f4ecca6e16c14cd31441cac6e2cc24c..23790561051795c0e66f383d57df3ed3514eb473 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/type.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/catalog/product/type.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Downloadable product type * diff --git a/app/code/Magento/Downloadable/view/frontend/templates/checkout/cart/item/default.phtml b/app/code/Magento/Downloadable/view/frontend/templates/checkout/cart/item/default.phtml index fda54f7b37bd27c7cecc9b8f99cf948fcb11534d..70bd4cb6afd6dcfe27901756f64fcb490fad73a3 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/checkout/cart/item/default.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/checkout/cart/item/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_item = $this->getItem(); diff --git a/app/code/Magento/Downloadable/view/frontend/templates/checkout/links.phtml b/app/code/Magento/Downloadable/view/frontend/templates/checkout/links.phtml index cff04cebc6d05cdd1749b223ae49f0b248ca4e27..57f170df1b92a5482967237333de305cb3109116 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/checkout/links.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/checkout/links.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($links = $this->getLinks()): ?> <dl class="cart item options"> diff --git a/app/code/Magento/Downloadable/view/frontend/templates/checkout/success.phtml b/app/code/Magento/Downloadable/view/frontend/templates/checkout/success.phtml index 978a4aa1b1dfdae11d28f2b726cd3fd7f9d5deb3..00d340b828f17de72c49a78dba92c210843a4b83 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/checkout/success.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/checkout/success.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getOrderHasDownloadable()): ?> <?php echo __('Go to <a href="%1">My Downloadable Products</a>', $this->getDownloadableProductsUrl()) ?> diff --git a/app/code/Magento/Downloadable/view/frontend/templates/customer/products/list.phtml b/app/code/Magento/Downloadable/view/frontend/templates/customer/products/list.phtml index 4a59b0a4fbdb7af0f101ccaf80631bc0745765f6..d0de5703b59caa9051ef41f3b927f0a54fe579bb 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/customer/products/list.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/customer/products/list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/creditmemo/downloadable.phtml b/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/creditmemo/downloadable.phtml index 9247a39475b14143002b349db73be1232a0430d3..fc595b4c5635aed29c8442b007f1d6c0296ad621 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/creditmemo/downloadable.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/creditmemo/downloadable.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Downloadable\Block\Sales\Order\Email\Items\Downloadable */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/invoice/downloadable.phtml b/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/invoice/downloadable.phtml index ac4b6bf730fa4c15210a45d6bcf70c5e6a9e5bb0..be81eaad8641c45a67faa24d7163352734503a08 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/invoice/downloadable.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/invoice/downloadable.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Downloadable\Block\Sales\Order\Email\Items\Downloadable */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/order/downloadable.phtml b/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/order/downloadable.phtml index a06956972c957a60ffca485e8de105cae6793f90..46a48ae27569f719d57b852eed32d8cdc4157c91 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/order/downloadable.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/email/order/items/order/downloadable.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Downloadable\Block\Sales\Order\Email\Items\Order\Downloadable */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Downloadable/view/frontend/templates/js/components.phtml b/app/code/Magento/Downloadable/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Downloadable/view/frontend/templates/sales/order/creditmemo/items/renderer/downloadable.phtml b/app/code/Magento/Downloadable/view/frontend/templates/sales/order/creditmemo/items/renderer/downloadable.phtml index 6ee377d824ed26a5634094faefef9c841f33a702..e29b554e00970abdeff254115476727b8c24c3b4 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/sales/order/creditmemo/items/renderer/downloadable.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/sales/order/creditmemo/items/renderer/downloadable.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Downloadable\Block\Sales\Order\Item\Renderer\Downloadable */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Downloadable/view/frontend/templates/sales/order/invoice/items/renderer/downloadable.phtml b/app/code/Magento/Downloadable/view/frontend/templates/sales/order/invoice/items/renderer/downloadable.phtml index 95dcf7c0480e0ede447cf01a5c80797e58ee871f..759bfb0f913d721f0d7ad5bf1c66b89502871b3c 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/sales/order/invoice/items/renderer/downloadable.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/sales/order/invoice/items/renderer/downloadable.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Downloadable\Block\Sales\Order\Item\Renderer\Downloadable */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Downloadable/view/frontend/templates/sales/order/items/renderer/downloadable.phtml b/app/code/Magento/Downloadable/view/frontend/templates/sales/order/items/renderer/downloadable.phtml index a90322e4c2c7e40ea89492db85c95280d4fe91b6..407c4d359c6f679f56ce4e16407fa5ca3dbff478 100644 --- a/app/code/Magento/Downloadable/view/frontend/templates/sales/order/items/renderer/downloadable.phtml +++ b/app/code/Magento/Downloadable/view/frontend/templates/sales/order/items/renderer/downloadable.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Downloadable\Block\Sales\Order\Item\Renderer\Downloadable */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Eav/Api/Data/AttributeInterface.php b/app/code/Magento/Eav/Api/Data/AttributeInterface.php index b6bc71a689cd62e6dece743e00dadfaf8ca4fcd3..4d91ac5c841494f513100b556448de980597e5fe 100644 --- a/app/code/Magento/Eav/Api/Data/AttributeInterface.php +++ b/app/code/Magento/Eav/Api/Data/AttributeInterface.php @@ -74,6 +74,7 @@ interface AttributeInterface extends \Magento\Framework\Api\ExtensibleDataInterf * Whether attribute is required. * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsRequired(); diff --git a/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Main/AbstractMain.php b/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Main/AbstractMain.php index cd8b740e487b59a4b8bcfbe7c1d9db44a4c1d84a..e24bded921403101d8d4a412e0cd0b968e74a468 100644 --- a/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Main/AbstractMain.php +++ b/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Main/AbstractMain.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Product attribute add/edit form main tab * @@ -100,6 +102,7 @@ abstract class AbstractMain extends \Magento\Backend\Block\Widget\Form\Generic * Preparing default form elements for editing attribute * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Eav/Helper/Data.php b/app/code/Magento/Eav/Helper/Data.php index 208af48b6cb59be3c11763592ae0447773cb2c37..851c189bc9f06aaba86f4f53c4dc0042591bba5e 100644 --- a/app/code/Magento/Eav/Helper/Data.php +++ b/app/code/Magento/Eav/Helper/Data.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Helper; /** diff --git a/app/code/Magento/Eav/Model/Attribute.php b/app/code/Magento/Eav/Model/Attribute.php index c5066616623ad3b7209a7217dd0c027d8e85199e..d6a034e9bbebb4d7ff5629f257cdde3e27df70c8 100644 --- a/app/code/Magento/Eav/Model/Attribute.php +++ b/app/code/Magento/Eav/Model/Attribute.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * EAV attribute resource model (Using Forms) * diff --git a/app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php b/app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php index 8e0c35eb117d26de987fa4975230df1544510bb1..9e0889d58fd3f48064a1c9776ffd8ed111e6cf46 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model\Attribute\Data; use Magento\Framework\App\RequestInterface; @@ -12,6 +15,7 @@ use Magento\Framework\Model\Exception as CoreException; * EAV Attribute Abstract Data Model * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractData { @@ -285,6 +289,8 @@ abstract class AbstractData * * @param string $value * @return string|true + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _validateInputRule($value) { @@ -479,6 +485,7 @@ abstract class AbstractData * Return is AJAX Request * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsAjaxRequest() { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Date.php b/app/code/Magento/Eav/Model/Attribute/Data/Date.php index a0d20a8134f5c57c7e2271a451572f522875df59..b1ef1c3c84b35eb61667b8c14c18ff326ce0a5c6 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Date.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Date.php @@ -32,6 +32,8 @@ class Date extends \Magento\Eav\Model\Attribute\Data\AbstractData * * @param array|string $value * @return bool|array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validateValue($value) { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/File.php b/app/code/Magento/Eav/Model/Attribute/Data/File.php index f0b4209e275e940bcbedcb085228d601a265d39c..d01a73a73d9ebed99dc98d7abca252d718d03e63 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/File.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/File.php @@ -64,6 +64,7 @@ class File extends \Magento\Eav\Model\Attribute\Data\AbstractData * * @param RequestInterface $request * @return array|string|bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function extractValue(RequestInterface $request) { @@ -163,6 +164,8 @@ class File extends \Magento\Eav\Model\Attribute\Data\AbstractData * * @param array|string $value * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validateValue($value) { @@ -205,6 +208,7 @@ class File extends \Magento\Eav\Model\Attribute\Data\AbstractData * * @param array|string $value * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function compactValue($value) { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Image.php b/app/code/Magento/Eav/Model/Attribute/Data/Image.php index ae8ea362d1248a9b0e8fab1e045b6719b25f5cd0..4110ddba02cf4dc03f9b477f4a8f753a617f2870 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Image.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Image.php @@ -18,6 +18,8 @@ class Image extends \Magento\Eav\Model\Attribute\Data\File * * @param array $value * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _validateByRules($value) { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Text.php b/app/code/Magento/Eav/Model/Attribute/Data/Text.php index 5a6dabc2951b3f2f751870ead63a43f8f9ef4d81..4826543c56fbd9b33cccc0d4676a7365ca39e8f5 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Text.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Text.php @@ -53,6 +53,8 @@ class Text extends \Magento\Eav\Model\Attribute\Data\AbstractData * * @param array|string $value * @return bool|array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validateValue($value) { diff --git a/app/code/Magento/Eav/Model/AttributeDataFactory.php b/app/code/Magento/Eav/Model/AttributeDataFactory.php index 4ce92246b7a58ffdd188c1447b0e03b62d10bb32..84e3a099faa843a3c4c0ecdfc0a31afea89d2c17 100644 --- a/app/code/Magento/Eav/Model/AttributeDataFactory.php +++ b/app/code/Magento/Eav/Model/AttributeDataFactory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model; /** diff --git a/app/code/Magento/Eav/Model/AttributeRepository.php b/app/code/Magento/Eav/Model/AttributeRepository.php index 52af10c54d8812ddd4c2b500cd5aa2554e8761fd..86437cdbf3d48452e55aaefa5b6c2c0702c643a1 100644 --- a/app/code/Magento/Eav/Model/AttributeRepository.php +++ b/app/code/Magento/Eav/Model/AttributeRepository.php @@ -12,6 +12,9 @@ use Magento\Framework\Exception\InputException; use Magento\Framework\Exception\NoSuchEntityException; use Magento\Framework\Exception\StateException; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class AttributeRepository implements \Magento\Eav\Api\AttributeRepositoryInterface { /** diff --git a/app/code/Magento/Eav/Model/AttributeSetRepository.php b/app/code/Magento/Eav/Model/AttributeSetRepository.php index 975c4dab62d8f14b18018646dfc38ee7f5ab364e..29cfc020a170711c6f2560f924faf45870866aa8 100644 --- a/app/code/Magento/Eav/Model/AttributeSetRepository.php +++ b/app/code/Magento/Eav/Model/AttributeSetRepository.php @@ -16,6 +16,9 @@ use Magento\Framework\Exception\CouldNotDeleteException; use Magento\Framework\Exception\CouldNotSaveException; use Magento\Framework\Exception\NoSuchEntityException; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class AttributeSetRepository implements AttributeSetRepositoryInterface { /** diff --git a/app/code/Magento/Eav/Model/Config.php b/app/code/Magento/Eav/Model/Config.php index 226fc7497a04ba7bdde5fa4351a87844c991cc41..e6afd9b32c8216ecb443e2d6b41a1680716071a5 100644 --- a/app/code/Magento/Eav/Model/Config.php +++ b/app/code/Magento/Eav/Model/Config.php @@ -7,6 +7,9 @@ namespace Magento\Eav\Model; use Magento\Eav\Model\Entity\Type; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Config { /**#@+ @@ -450,6 +453,8 @@ class Config * @param mixed $entityType * @param \Magento\Framework\Object $object * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getEntityAttributeCodes($entityType, $object = null) { diff --git a/app/code/Magento/Eav/Model/Entity/AbstractEntity.php b/app/code/Magento/Eav/Model/Entity/AbstractEntity.php index 432fb97f969b84f2262061bef148c396111cfc95..e7d7baa3cd43b1c27343564047e694d5f6c0999b 100644 --- a/app/code/Magento/Eav/Model/Entity/AbstractEntity.php +++ b/app/code/Magento/Eav/Model/Entity/AbstractEntity.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model\Entity; use Magento\Eav\Model\Entity\Attribute\AbstractAttribute; @@ -17,6 +20,9 @@ use Magento\Framework\Model\Exception; * Entity/Attribute/Model - entity abstract * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\AbstractResource implements EntityInterface { @@ -414,6 +420,7 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * * @param string|int|Element $attribute * @return AbstractAttribute|false + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getAttribute($attribute) { @@ -637,6 +644,7 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * @param \Magento\Framework\Object $object * @param AbstractAttribute $attribute * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _isApplicableAttribute($object, $attribute) { @@ -657,6 +665,8 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * * @throws \Exception|\Magento\Eav\Model\Entity\Attribute\Exception * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function walkAttributes($partMethod, array $args = [], $collectExceptionMessages = null) { @@ -739,6 +749,7 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * @param string $method * @param array $args array of arguments * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _isCallableAttributeInstance($instance, $method, $args) { @@ -1081,6 +1092,7 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * @param \Magento\Framework\Object $object * @param string|int $rowId * @return \Zend_Db_Select + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _getLoadRowSelect($object, $rowId) { @@ -1229,6 +1241,8 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * * @param \Magento\Framework\Object $newObject * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _collectSaveData($newObject) { @@ -1333,6 +1347,7 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * @param mixed $v New value of the attribute. Can be used in subclasses. * @param array $origData * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _canUpdateAttribute(AbstractAttribute $attribute, $v, array &$origData) { @@ -1387,6 +1402,8 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * * @param array $saveData array('newObject', 'entityRow', 'insert', 'update', 'delete') * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _processSaveData($saveData) { @@ -1496,6 +1513,7 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * @param mixed $valueId * @param mixed $value * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _updateAttribute($object, $attribute, $valueId, $value) { @@ -1589,6 +1607,7 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * @param string $table * @param array $info * @return \Magento\Framework\Object + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _deleteAttributes($object, $table, $info) { @@ -1617,6 +1636,7 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * @param string $attributeCode * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function saveAttribute(\Magento\Framework\Object $object, $attributeCode) { @@ -1689,6 +1709,7 @@ abstract class AbstractEntity extends \Magento\Framework\Model\Resource\Abstract * @param \Magento\Framework\Object|int|string $object * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function delete($object) { diff --git a/app/code/Magento/Eav/Model/Entity/Attribute.php b/app/code/Magento/Eav/Model/Entity/Attribute.php index ab1c45e9d61471f0c9cffa273888febb84831f13..681ab2a4fc09226caac4b05785430a34a74506c6 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute.php @@ -12,6 +12,7 @@ use Magento\Framework\Api\AttributeDataBuilder; * EAV Entity attribute model * * @method \Magento\Eav\Model\Entity\Attribute setOption($value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Attribute extends \Magento\Eav\Model\Entity\Attribute\AbstractAttribute implements \Magento\Framework\Object\IdentityInterface @@ -80,6 +81,7 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute\AbstractAttribute im * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -208,6 +210,8 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute\AbstractAttribute im * * @return $this * @throws Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function beforeSave() { @@ -307,6 +311,7 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute\AbstractAttribute im * * @param string $type frontend_input field value * @return string backend_type field value + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getBackendTypeByInput($type) { @@ -350,6 +355,7 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute\AbstractAttribute im * * @param string $type frontend_input field name * @return string default_value field value + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getDefaultValueByInput($type) { diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php b/app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php index c954b9fe13601a8cdd1286aa31291f78d90fd7a0..71280078353b11e150f7b680187ea55eee614bb4 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php @@ -10,6 +10,9 @@ use Magento\Framework\Api\AttributeDataBuilder; /** * Entity/Attribute/Model - attribute abstract + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractAttribute extends \Magento\Framework\Model\AbstractExtensibleModel implements AttributeInterface, @@ -118,6 +121,7 @@ abstract class AbstractAttribute extends \Magento\Framework\Model\AbstractExtens * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -300,6 +304,7 @@ abstract class AbstractAttribute extends \Magento\Framework\Model\AbstractExtens /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsVisibleOnFront() { @@ -657,6 +662,7 @@ abstract class AbstractAttribute extends \Magento\Framework\Model\AbstractExtens * Retrieve flat columns DDL definition * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function _getFlatColumnsDdlDefinition() { @@ -740,6 +746,7 @@ abstract class AbstractAttribute extends \Magento\Framework\Model\AbstractExtens * Used in database compatible mode * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _getFlatColumnsOldDefinition() { @@ -814,6 +821,7 @@ abstract class AbstractAttribute extends \Magento\Framework\Model\AbstractExtens * Retrieve index data for flat table * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getFlatIndexes() { diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Backend/AbstractBackend.php b/app/code/Magento/Eav/Model/Entity/Attribute/Backend/AbstractBackend.php index a3b44a9821819470b9fbb6d229604ceb2858e1bb..e0b6cf4a8d77e15d36cbe92c105ecef18a4a4f68 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Backend/AbstractBackend.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Backend/AbstractBackend.php @@ -7,6 +7,7 @@ namespace Magento\Eav\Model\Entity\Attribute\Backend; /** * Entity/Attribute/Model - attribute backend abstract + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractBackend implements \Magento\Eav\Model\Entity\Attribute\Backend\BackendInterface { @@ -212,6 +213,7 @@ abstract class AbstractBackend implements \Magento\Eav\Model\Entity\Attribute\Ba * @param \Magento\Framework\Object $object * @throws \Magento\Eav\Exception * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function validate($object) { @@ -244,6 +246,7 @@ abstract class AbstractBackend implements \Magento\Eav\Model\Entity\Attribute\Ba * * @param \Magento\Framework\Object $object * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterLoad($object) { @@ -271,6 +274,7 @@ abstract class AbstractBackend implements \Magento\Eav\Model\Entity\Attribute\Ba * * @param \Magento\Framework\Object $object * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterSave($object) { @@ -282,6 +286,7 @@ abstract class AbstractBackend implements \Magento\Eav\Model\Entity\Attribute\Ba * * @param \Magento\Framework\Object $object * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function beforeDelete($object) { @@ -293,6 +298,7 @@ abstract class AbstractBackend implements \Magento\Eav\Model\Entity\Attribute\Ba * * @param \Magento\Framework\Object $object * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterDelete($object) { diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Backend/Datetime.php b/app/code/Magento/Eav/Model/Entity/Attribute/Backend/Datetime.php index e88a8af0ce75ba5b615f31771ed6d37aaa37401f..c4bc5512eda1a02174145d824e053dc5db7d4ff3 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Backend/Datetime.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Backend/Datetime.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model\Entity\Attribute\Backend; use Magento\Eav\Exception as EavException; diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/Datetime.php b/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/Datetime.php index 2ce33331461d31caf574e72495d796c70ab48d2d..57f0b73b6c7589bc64f66324209ea3e63ffd4a54 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/Datetime.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/Datetime.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model\Entity\Attribute\Frontend; class Datetime extends \Magento\Eav\Model\Entity\Attribute\Frontend\AbstractFrontend diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Set.php b/app/code/Magento/Eav/Model/Entity/Attribute/Set.php index b4c7dd586fb03ffd92125f1f6dfe684b6f5dc252..6d0775efb81a7e5593060b82e2d71b1cbe27377b 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Set.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Set.php @@ -22,6 +22,9 @@ namespace Magento\Eav\Model\Entity\Attribute; use Magento\Eav\Model\Entity\Type; use Magento\Framework\Api\AttributeDataBuilder; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Set extends \Magento\Framework\Model\AbstractExtensibleModel implements \Magento\Eav\Api\Data\AttributeSetInterface { @@ -70,6 +73,7 @@ class Set extends \Magento\Framework\Model\AbstractExtensibleModel implements * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -156,6 +160,8 @@ class Set extends \Magento\Framework\Model\AbstractExtensibleModel implements * * @param array $data * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function organizeData($data) { @@ -263,6 +269,7 @@ class Set extends \Magento\Framework\Model\AbstractExtensibleModel implements * @param array $attributes * @param int $setId * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function addSetInfo($entityType, array $attributes, $setId = null) { diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php b/app/code/Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php index 59451eec414a5626e3a590fd75f32edf573bc636..9c805984a21cd0bb9e2f67818189945b8ac35433 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php @@ -9,6 +9,7 @@ namespace Magento\Eav\Model\Entity\Attribute\Source; * Entity/Attribute/Model - attribute selection source abstract * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractSource implements \Magento\Eav\Model\Entity\Attribute\Source\SourceInterface, @@ -94,6 +95,7 @@ abstract class AbstractSource implements * @param \Magento\Eav\Model\Entity\Collection\AbstractCollection $collection * @param string $dir direction * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function addValueSortToCollection($collection, $dir = \Magento\Framework\Data\Collection::SORT_ORDER_DESC) { @@ -125,6 +127,7 @@ abstract class AbstractSource implements * * @param int $store * @return \Magento\Framework\DB\Select|null + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getFlatUpdateSelect($store) { diff --git a/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php b/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php index 146a4a96fe117216ff05094fa10571a6262be5f0..17d41237c1621f0315938b72e3d03c6fa726d35b 100644 --- a/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php +++ b/app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php @@ -9,6 +9,9 @@ use Magento\Framework\DB\Select; /** * Entity/Attribute/Model - collection abstract + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractCollection extends \Magento\Framework\Data\Collection\Db { @@ -125,6 +128,7 @@ abstract class AbstractCollection extends \Magento\Framework\Data\Collection\Db * @param \Magento\Eav\Model\Resource\Helper $resourceHelper * @param \Magento\Framework\Validator\UniversalFactory $universalFactory * @param mixed $connection + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Core\Model\EntityFactory $entityFactory, @@ -621,6 +625,8 @@ abstract class AbstractCollection extends \Magento\Framework\Data\Collection\Db * @param null $storeId * @return $this * @throws \Magento\Eav\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function joinAttribute($alias, $attribute, $bind, $filter = null, $joinType = 'inner', $storeId = null) { @@ -771,6 +777,7 @@ abstract class AbstractCollection extends \Magento\Framework\Data\Collection\Db * @param string $joinType * @return $this * @throws \Magento\Eav\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function joinTable($table, $bind, $fields = null, $cond = null, $joinType = 'inner') { @@ -1098,6 +1105,9 @@ abstract class AbstractCollection extends \Magento\Framework\Data\Collection\Db * @param bool $logQuery * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function _loadAttributes($printQuery = false, $logQuery = false) { @@ -1192,6 +1202,7 @@ abstract class AbstractCollection extends \Magento\Framework\Data\Collection\Db * @param string $table * @param string $type * @return Select + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _addLoadAttributesSelectValues($select, $table, $type) { @@ -1288,6 +1299,7 @@ abstract class AbstractCollection extends \Magento\Framework\Data\Collection\Db * @param string $joinType inner|left * @return $this * @throws \Magento\Eav\Exception + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _addAttributeJoin($attributeCode, $joinType = 'inner') { diff --git a/app/code/Magento/Eav/Model/Entity/Setup.php b/app/code/Magento/Eav/Model/Entity/Setup.php index dd5aaec360adc744834204f788388977d834a523..d2d6a1fc1754ef45d4115cadab3e7becda4414d8 100644 --- a/app/code/Magento/Eav/Model/Entity/Setup.php +++ b/app/code/Magento/Eav/Model/Entity/Setup.php @@ -7,6 +7,9 @@ */ namespace Magento\Eav\Model\Entity; +/** + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + */ class Setup extends \Magento\Framework\Module\DataSetup { /** @@ -768,6 +771,7 @@ class Setup extends \Magento\Framework\Module\DataSetup * @param array $option * @return void * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function addAttributeOption($option) { @@ -1217,6 +1221,8 @@ class Setup extends \Magento\Framework\Module\DataSetup * * @param array $entities * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function installEntities($entities = null) { diff --git a/app/code/Magento/Eav/Model/Entity/Setup/Context.php b/app/code/Magento/Eav/Model/Entity/Setup/Context.php index bbd61209c57d8931767d8415dd38675de5e570f2..031c7b8ad9464b85c3eefdb01fccb692266dfa27 100644 --- a/app/code/Magento/Eav/Model/Entity/Setup/Context.php +++ b/app/code/Magento/Eav/Model/Entity/Setup/Context.php @@ -25,6 +25,7 @@ class Context extends \Magento\Framework\Module\Setup\Context * @param \Magento\Framework\Encryption\EncryptorInterface $encryptor * @param \Magento\Framework\Filesystem $filesystem * @param PropertyMapperInterface $attributeMapper + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Psr\Log\LoggerInterface $logger, diff --git a/app/code/Magento/Eav/Model/Form.php b/app/code/Magento/Eav/Model/Form.php index 6d960254fe485e91c3a1c167f8e28b9c6541b451..919985062333e000196f493d4b4d05a192b88890 100644 --- a/app/code/Magento/Eav/Model/Form.php +++ b/app/code/Magento/Eav/Model/Form.php @@ -11,6 +11,8 @@ use Magento\Framework\App\RequestInterface; * EAV Entity Form Model * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class Form { @@ -577,6 +579,7 @@ abstract class Form * Return is AJAX Request * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsAjaxRequest() { diff --git a/app/code/Magento/Eav/Model/Resource/Attribute.php b/app/code/Magento/Eav/Model/Resource/Attribute.php index 86b228f3da99359eac6c5d4ca6d5977845b18411..0111844ee74cb846742034214dd39ba3f387c62a 100644 --- a/app/code/Magento/Eav/Model/Resource/Attribute.php +++ b/app/code/Magento/Eav/Model/Resource/Attribute.php @@ -86,6 +86,7 @@ abstract class Attribute extends \Magento\Eav\Model\Resource\Entity\Attribute * * @param \Magento\Framework\Model\AbstractModel $object * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _afterSave(AbstractModel $object) { diff --git a/app/code/Magento/Eav/Model/Resource/Entity/Attribute.php b/app/code/Magento/Eav/Model/Resource/Entity/Attribute.php index 2b9ea59ec2b4715501f053bdb5e91510269b5a08..0d10528a5ae92b55676465d5a977e525a88d1ea5 100644 --- a/app/code/Magento/Eav/Model/Resource/Entity/Attribute.php +++ b/app/code/Magento/Eav/Model/Resource/Entity/Attribute.php @@ -261,6 +261,7 @@ class Attribute extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param null $attributeGroupId * @param null $attributeSortOrder * @return $this + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function saveInSetIncluding( AbstractModel $object, diff --git a/app/code/Magento/Eav/Model/Resource/Form/Fieldset.php b/app/code/Magento/Eav/Model/Resource/Form/Fieldset.php index 04eebbc2c110dfd1c63226389f58f77bb10960c8..0cbb38ec3dd7f5c0464a2f3443d166c4ba121f4e 100644 --- a/app/code/Magento/Eav/Model/Resource/Form/Fieldset.php +++ b/app/code/Magento/Eav/Model/Resource/Form/Fieldset.php @@ -34,6 +34,8 @@ class Fieldset extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param FormFieldset|AbstractModel $object * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _afterSave(AbstractModel $object) { diff --git a/app/code/Magento/Email/view/adminhtml/templates/template/edit.phtml b/app/code/Magento/Email/view/adminhtml/templates/template/edit.phtml index a3092a2a368e6bdfd1653c8f1f851660c05209cf..5c1ae09ee32b085bb7ad06d7bd918abfcf8fd427 100644 --- a/app/code/Magento/Email/view/adminhtml/templates/template/edit.phtml +++ b/app/code/Magento/Email/view/adminhtml/templates/template/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (!$this->getEditMode()): ?> <form action="<?php echo $this->getLoadUrl() ?>" method="post" id="email_template_load_form"> diff --git a/app/code/Magento/Email/view/adminhtml/templates/template/list.phtml b/app/code/Magento/Email/view/adminhtml/templates/template/list.phtml index 04c42695a8c0784d43d1975cabc76be0b6c412eb..0f136e1bfbc4819a3c3f24b08a921917ff04e1bb 100644 --- a/app/code/Magento/Email/view/adminhtml/templates/template/list.phtml +++ b/app/code/Magento/Email/view/adminhtml/templates/template/list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="page-actions"><?php echo $this->getChildHtml('add_button') ?></div> <?php echo $this->getChildHtml('grid') ?> diff --git a/app/code/Magento/Fedex/Model/Carrier.php b/app/code/Magento/Fedex/Model/Carrier.php index 4a9a2281b4014ac03e589413405e57a56c482209..e71ed00512e0c84d04726a585b8516fe3de40972 100644 --- a/app/code/Magento/Fedex/Model/Carrier.php +++ b/app/code/Magento/Fedex/Model/Carrier.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Fedex\Model; use Magento\Quote\Model\Quote\Address\RateRequest; @@ -13,6 +16,8 @@ use Magento\Shipping\Model\Rate\Result; * Fedex shipping implementation * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\Carrier\CarrierInterface { @@ -253,6 +258,8 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * * @param RateRequest $request * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function setRequest(RateRequest $request) { @@ -493,6 +500,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * * @param mixed $response * @return Result + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _prepareRateResponse($response) { @@ -690,6 +698,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * * @param mixed $response * @return Result + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _parseXmlResponse($response) { @@ -778,6 +787,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * @param string $type * @param string $code * @return array|false + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getCode($type, $code = '') { @@ -1048,6 +1058,9 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * @param string[] $trackingValue * @param \stdClass $response * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _parseTrackingResponse($trackingValue, $response) { @@ -1223,6 +1236,9 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * * @param \Magento\Framework\Object $request * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _formShipmentRequest(\Magento\Framework\Object $request) { @@ -1452,6 +1468,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * * @param \Magento\Framework\Object|null $params * @return array|bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getContainerTypes(\Magento\Framework\Object $params = null) { diff --git a/app/code/Magento/GiftMessage/Api/CartRepositoryInterface.php b/app/code/Magento/GiftMessage/Api/CartRepositoryInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..62a7916c14ca9479e2a9feefa458aa2c8aacf5ed --- /dev/null +++ b/app/code/Magento/GiftMessage/Api/CartRepositoryInterface.php @@ -0,0 +1,31 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\GiftMessage\Api; + +interface CartRepositoryInterface +{ + /** + * Returns the gift message for a specified order. + * + * @param int $cartId The shopping cart ID. + * @return \Magento\GiftMessage\Api\Data\MessageInterface Gift message. + */ + public function get($cartId); + + /** + * Sets the gift message for an entire order. + * + * @param int $cartId The cart ID. + * @param \Magento\GiftMessage\Api\Data\MessageInterface $giftMessage The gift message. + * @return bool + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + * @throws \Magento\Framework\Exception\InputException You cannot add gift messages to empty carts. + * @throws \Magento\Framework\Exception\State\InvalidTransitionException You cannot add gift messages to + * virtual products. + * @throws \Magento\Framework\Exception\CouldNotSaveException The specified gift message could not be saved. + */ + public function save($cartId, \Magento\GiftMessage\Api\Data\MessageInterface $giftMessage); +} diff --git a/app/code/Magento/GiftMessage/Api/Data/MessageInterface.php b/app/code/Magento/GiftMessage/Api/Data/MessageInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..876e4c7514ad874921d06e7597653e02cc525c6c --- /dev/null +++ b/app/code/Magento/GiftMessage/Api/Data/MessageInterface.php @@ -0,0 +1,44 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\GiftMessage\Api\Data; + +interface MessageInterface extends \Magento\Framework\Api\ExtensibleDataInterface +{ + /** + * Returns the gift message ID. + * + * @return int|null Gift message ID. Otherwise, null. + */ + public function getGiftMessageId(); + + /** + * Returns the customer ID. + * + * @return int|null Customer ID. Otherwise, null. + */ + public function getCustomerId(); + + /** + * Returns the sender name. + * + * @return string Sender name. + */ + public function getSender(); + + /** + * Returns the recipient name. + * + * @return string Recipient name. + */ + public function getRecipient(); + + /** + * Returns the message text. + * + * @return string Message text. + */ + public function getMessage(); +} diff --git a/app/code/Magento/GiftMessage/Api/ItemRepositoryInterface.php b/app/code/Magento/GiftMessage/Api/ItemRepositoryInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..f0141740b3ed9b34f40822415c3d301e16e27876 --- /dev/null +++ b/app/code/Magento/GiftMessage/Api/ItemRepositoryInterface.php @@ -0,0 +1,34 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\GiftMessage\Api; + +interface ItemRepositoryInterface +{ + /** + * Returns the gift message for a specified item in a specified shopping cart. + * + * @param int $cartId The shopping cart ID. + * @param int $itemId The item ID. + * @return \Magento\GiftMessage\Api\Data\MessageInterface Gift message. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified item does not exist in the cart. + */ + public function get($cartId, $itemId); + + /** + * Sets the gift message for a specified item in a specified shopping cart. + * + * @param int $cartId The cart ID. + * @param \Magento\GiftMessage\Api\Data\MessageInterface $giftMessage The gift message. + * @param int $itemId The item ID. + * @return bool + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + * @throws \Magento\Framework\Exception\InputException You cannot add gift messages to empty carts. + * @throws \Magento\Framework\Exception\State\InvalidTransitionException You cannot add gift messages to + * virtual products. + * @throws \Magento\Framework\Exception\CouldNotSaveException The specified gift message could not be saved. + */ + public function save($cartId, \Magento\GiftMessage\Api\Data\MessageInterface $giftMessage, $itemId); +} diff --git a/app/code/Magento/GiftMessage/Block/Message/Inline.php b/app/code/Magento/GiftMessage/Block/Message/Inline.php index cc2a2554eebd40046368d98154804e4ed94616fa..dedec8c760dc868263e5970756baf036d2505d70 100644 --- a/app/code/Magento/GiftMessage/Block/Message/Inline.php +++ b/app/code/Magento/GiftMessage/Block/Message/Inline.php @@ -275,6 +275,7 @@ class Inline extends \Magento\Framework\View\Element\Template * Check if items has messages * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getItemsHasMesssages() { @@ -290,6 +291,7 @@ class Inline extends \Magento\Framework\View\Element\Template * Check if entity has message * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getEntityHasMessage() { diff --git a/app/code/Magento/GiftMessage/Helper/Message.php b/app/code/Magento/GiftMessage/Helper/Message.php index d4ce4cb4f2b00bba7f01033b90dd9d0bf742aca7..7672d3f08763ecb24e284aba464b34bcf15789fe 100644 --- a/app/code/Magento/GiftMessage/Helper/Message.php +++ b/app/code/Magento/GiftMessage/Helper/Message.php @@ -3,10 +3,14 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GiftMessage\Helper; /** * Gift Message helper + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Message extends \Magento\Core\Helper\Data { @@ -71,6 +75,7 @@ class Message extends \Magento\Core\Helper\Data * @param \Magento\Framework\Escaper $escaper * @param array $skipMessageCheck * @param bool $dbCompatibleMode + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Helper\Context $context, @@ -136,6 +141,7 @@ class Message extends \Magento\Core\Helper\Data * @param \Magento\Framework\Object $entity * @param \Magento\Store\Model\Store|int|null $store * @return bool|string|null + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isMessagesAvailable($type, \Magento\Framework\Object $entity, $store = null) { @@ -288,6 +294,7 @@ class Message extends \Magento\Core\Helper\Data * @param array $quote * @param \Magento\Store\Model\Store|int|null $store * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getAvailableForQuoteItems($quote, $store = null) { @@ -305,6 +312,7 @@ class Message extends \Magento\Core\Helper\Data * @param array $items * @param \Magento\Store\Model\Store|int|null $store * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getAvailableForAddressItems($items, $store = null) { diff --git a/app/code/Magento/GiftMessage/Model/CartRepository.php b/app/code/Magento/GiftMessage/Model/CartRepository.php new file mode 100644 index 0000000000000000000000000000000000000000..528ccf78320b624bdbdcf75bbf5aac889108dbc9 --- /dev/null +++ b/app/code/Magento/GiftMessage/Model/CartRepository.php @@ -0,0 +1,116 @@ +<?php +/** + * + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ + +namespace Magento\GiftMessage\Model; + +use Magento\Framework\Exception\CouldNotSaveException; +use Magento\Framework\Exception\InputException; +use Magento\Framework\Exception\State\InvalidTransitionException; + +/** + * Shopping cart gift message repository object. + */ +class CartRepository implements \Magento\GiftMessage\Api\CartRepositoryInterface +{ + /** + * Quote repository. + * + * @var \Magento\Quote\Model\QuoteRepository + */ + protected $quoteRepository; + + /** + * Store manager interface. + * + * @var \Magento\Store\Model\StoreManagerInterface + */ + protected $storeManager; + + /** + * Gift message manager. + * + * @var \Magento\GiftMessage\Model\GiftMessageManager + */ + protected $giftMessageManager; + + /** + * Message helper. + * + * @var \Magento\GiftMessage\Helper\Message + */ + protected $helper; + + /** + * Message factory. + * + * @var \Magento\GiftMessage\Model\MessageFactory + */ + protected $messageFactory; + + /** + * @param \Magento\Quote\Model\QuoteRepository $quoteRepository + * @param \Magento\Store\Model\StoreManagerInterface $storeManager + * @param GiftMessageManager $giftMessageManager + * @param \Magento\GiftMessage\Helper\Message $helper + * @param MessageFactory $messageFactory + */ + public function __construct( + \Magento\Quote\Model\QuoteRepository $quoteRepository, + \Magento\Store\Model\StoreManagerInterface $storeManager, + \Magento\GiftMessage\Model\GiftMessageManager $giftMessageManager, + \Magento\GiftMessage\Helper\Message $helper, + \Magento\GiftMessage\Model\MessageFactory $messageFactory + ) { + $this->quoteRepository = $quoteRepository; + $this->giftMessageManager = $giftMessageManager; + $this->storeManager = $storeManager; + $this->helper = $helper; + $this->messageFactory = $messageFactory; + } + + /** + * {@inheritDoc} + */ + public function get($cartId) + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->getActive($cartId); + + $messageId = $quote->getGiftMessageId(); + if (!$messageId) { + return null; + } + + return $this->messageFactory->create()->load($messageId); + } + + /** + * {@inheritDoc} + */ + public function save($cartId, \Magento\GiftMessage\Api\Data\MessageInterface $giftMessage) + { + /** + * Quote. + * + * @var \Magento\Quote\Model\Quote $quote + */ + $quote = $this->quoteRepository->getActive($cartId); + + if (0 == $quote->getItemsCount()) { + throw new InputException('Gift Messages is not applicable for empty cart'); + } + + if ($quote->isVirtual()) { + throw new InvalidTransitionException('Gift Messages is not applicable for virtual products'); + } + if (!$this->helper->getIsMessagesAvailable('quote', $quote, $this->storeManager->getStore())) { + throw new CouldNotSaveException('Gift Message is not available'); + } + $this->giftMessageManager->setMessage($quote, 'quote', $giftMessage); + return true; + } +} diff --git a/app/code/Magento/GiftMessage/Model/GiftMessageManager.php b/app/code/Magento/GiftMessage/Model/GiftMessageManager.php index 79fb3fafac8e22443530e9137b976d822111e894..7fc655d323ab3f2816c55ff433071d19d05ae3f9 100644 --- a/app/code/Magento/GiftMessage/Model/GiftMessageManager.php +++ b/app/code/Magento/GiftMessage/Model/GiftMessageManager.php @@ -5,6 +5,9 @@ */ namespace Magento\GiftMessage\Model; +use Magento\Framework\Exception\State\InvalidTransitionException; +use Magento\Framework\Exception\CouldNotSaveException; + class GiftMessageManager { /** @@ -25,6 +28,7 @@ class GiftMessageManager * @param array $giftMessages * @param \Magento\Quote\Model\Quote $quote * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function add($giftMessages, $quote) { @@ -84,4 +88,38 @@ class GiftMessageManager } return $this; } + + /** + * Sets the gift message to item or quote. + * + * @param \Magento\Quote\Model\Quote $quote The quote. + * @param string $type The type. + * @param \Magento\GiftMessage\Api\Data\MessageInterface $giftMessage The gift message. + * @param null|int $entityId The entity ID. + * @return void + * @throws \Magento\Framework\Exception\CouldNotSaveException The specified gift message is not available. + * @throws \Magento\Framework\Exception\State\InvalidTransitionException The billing or shipping address is not set. + */ + public function setMessage(\Magento\Quote\Model\Quote $quote, $type, $giftMessage, $entityId = null) + { + if (is_null($quote->getBillingAddress()->getCountryId())) { + throw new InvalidTransitionException('Billing address is not set'); + } + + // check if shipping address is set + if (is_null($quote->getShippingAddress()->getCountryId())) { + throw new InvalidTransitionException('Shipping address is not set'); + } + $message[$type][$entityId] = [ + 'from' => $giftMessage->getSender(), + 'to' => $giftMessage->getRecipient(), + 'message' => $giftMessage->getMessage(), + ]; + + try { + $this->add($message, $quote); + } catch (\Exception $e) { + throw new CouldNotSaveException('Could not add gift message to shopping cart'); + } + } } diff --git a/app/code/Magento/GiftMessage/Model/ItemRepository.php b/app/code/Magento/GiftMessage/Model/ItemRepository.php new file mode 100644 index 0000000000000000000000000000000000000000..90db371ca8fbdf8ffad383f375a9350e81fdbd01 --- /dev/null +++ b/app/code/Magento/GiftMessage/Model/ItemRepository.php @@ -0,0 +1,128 @@ +<?php +/** + * + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ + +namespace Magento\GiftMessage\Model; + +use Magento\Framework\Exception\CouldNotSaveException; +use Magento\Framework\Exception\InputException; +use Magento\Framework\Exception\State\InvalidTransitionException; +use Magento\Framework\Exception\NoSuchEntityException; + +/** + * Shopping cart gift message item repository object. + */ +class ItemRepository implements \Magento\GiftMessage\Api\ItemRepositoryInterface +{ + /** + * Quote repository. + * + * @var \Magento\Quote\Model\QuoteRepository + */ + protected $quoteRepository; + + /** + * Store manager interface. + * + * @var \Magento\Store\Model\StoreManagerInterface + */ + protected $storeManager; + + /** + * Gift message manager. + * + * @var \Magento\GiftMessage\Model\GiftMessageManager + */ + protected $giftMessageManager; + + /** + * Message helper. + * + * @var \Magento\GiftMessage\Helper\Message + */ + protected $helper; + + /** + * Message factory. + * + * @var \Magento\GiftMessage\Model\MessageFactory + */ + protected $messageFactory; + + /** + * @param \Magento\Quote\Model\QuoteRepository $quoteRepository + * @param \Magento\Store\Model\StoreManagerInterface $storeManager + * @param GiftMessageManager $giftMessageManager + * @param \Magento\GiftMessage\Helper\Message $helper + * @param MessageFactory $messageFactory + */ + public function __construct( + \Magento\Quote\Model\QuoteRepository $quoteRepository, + \Magento\Store\Model\StoreManagerInterface $storeManager, + \Magento\GiftMessage\Model\GiftMessageManager $giftMessageManager, + \Magento\GiftMessage\Helper\Message $helper, + \Magento\GiftMessage\Model\MessageFactory $messageFactory + ) { + $this->quoteRepository = $quoteRepository; + $this->giftMessageManager = $giftMessageManager; + $this->storeManager = $storeManager; + $this->helper = $helper; + $this->messageFactory = $messageFactory; + } + + /** + * {@inheritDoc} + */ + public function get($cartId, $itemId) + { + /** + * Quote. + * + * @var \Magento\Quote\Model\Quote $quote + */ + $quote = $this->quoteRepository->getActive($cartId); + if (!$item = $quote->getItemById($itemId)) { + throw new NoSuchEntityException('There is no item with provided id in the cart'); + }; + $messageId = $item->getGiftMessageId(); + if (!$messageId) { + return null; + } + + /** + * Model. + * + * @var \Magento\GiftMessage\Model\Message $model + */ + return $this->messageFactory->create()->load($messageId); + } + + /** + * {@inheritDoc} + */ + public function save($cartId, \Magento\GiftMessage\Api\Data\MessageInterface $giftMessage, $itemId) + { + /** + * Quote. + * + * @var \Magento\Quote\Model\Quote $quote + */ + $quote = $this->quoteRepository->getActive($cartId); + + if (!$item = $quote->getItemById($itemId)) { + throw new NoSuchEntityException("There is no product with provided itemId: $itemId in the cart"); + }; + + if ($item->getIsVirtual()) { + throw new InvalidTransitionException('Gift Messages is not applicable for virtual products'); + } + if (!$this->helper->getIsMessagesAvailable('items', $quote, $this->storeManager->getStore())) { + throw new CouldNotSaveException('Gift Message is not available'); + } + $this->giftMessageManager->setMessage($quote, 'quote_item', $giftMessage, $itemId); + return true; + } +} diff --git a/app/code/Magento/GiftMessage/Model/Message.php b/app/code/Magento/GiftMessage/Model/Message.php index 0ecfeae37c180d71b171e499edfff72982caf8db..808025555d590796a6202d5d58079c5d6a253047 100644 --- a/app/code/Magento/GiftMessage/Model/Message.php +++ b/app/code/Magento/GiftMessage/Model/Message.php @@ -5,23 +5,22 @@ */ namespace Magento\GiftMessage\Model; +use Magento\Framework\Api\AttributeDataBuilder; + /** * Gift Message model * * @method \Magento\GiftMessage\Model\Resource\Message _getResource() * @method \Magento\GiftMessage\Model\Resource\Message getResource() - * @method int getCustomerId() * @method \Magento\GiftMessage\Model\Message setCustomerId(int $value) - * @method string getSender() * @method \Magento\GiftMessage\Model\Message setSender(string $value) - * @method string getRecipient() * @method \Magento\GiftMessage\Model\Message setRecipient(string $value) - * @method string getMessage() * @method \Magento\GiftMessage\Model\Message setMessage(string $value) * * @author Magento Core Team <core@magentocommerce.com> */ -class Message extends \Magento\Framework\Model\AbstractModel +class Message extends \Magento\Framework\Model\AbstractExtensibleModel implements + \Magento\GiftMessage\Api\Data\MessageInterface { /** * @var \Magento\GiftMessage\Model\TypeFactory @@ -31,21 +30,33 @@ class Message extends \Magento\Framework\Model\AbstractModel /** * @param \Magento\Framework\Model\Context $context * @param \Magento\Framework\Registry $registry - * @param \Magento\GiftMessage\Model\Resource\Message $resource + * @param \Magento\Framework\Api\MetadataServiceInterface $metadataService + * @param AttributeDataBuilder $customAttributeBuilder + * @param Resource\Message $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection - * @param \Magento\GiftMessage\Model\TypeFactory $typeFactory + * @param TypeFactory $typeFactory * @param array $data */ public function __construct( \Magento\Framework\Model\Context $context, \Magento\Framework\Registry $registry, + \Magento\Framework\Api\MetadataServiceInterface $metadataService, + AttributeDataBuilder $customAttributeBuilder, \Magento\GiftMessage\Model\Resource\Message $resource, \Magento\Framework\Data\Collection\Db $resourceCollection, \Magento\GiftMessage\Model\TypeFactory $typeFactory, array $data = [] ) { $this->_typeFactory = $typeFactory; - parent::__construct($context, $registry, $resource, $resourceCollection, $data); + parent::__construct( + $context, + $registry, + $metadataService, + $customAttributeBuilder, + $resource, + $resourceCollection, + $data + ); } /** @@ -76,4 +87,46 @@ class Message extends \Magento\Framework\Model\AbstractModel { return trim($this->getMessage()) == ''; } + + /** + * @codeCoverageIgnoreStart + * {@inheritdoc} + */ + public function getGiftMessageId() + { + return $this->getData('gift_message_id'); + } + + /** + * {@inheritdoc} + */ + public function getCustomerId() + { + return $this->getData('customer_id'); + } + + /** + * {@inheritdoc} + */ + public function getSender() + { + return $this->getData('sender'); + } + + /** + * {@inheritdoc} + */ + public function getRecipient() + { + return $this->getData('recipient'); + } + + /** + * {@inheritdoc} + */ + public function getMessage() + { + return $this->getData('message'); + } + ////@codeCoverageIgnoreEnd } diff --git a/app/code/Magento/GiftMessage/Model/Save.php b/app/code/Magento/GiftMessage/Model/Save.php index 600f7da8744737f736b6eb501e92eb7ef20a3893..ee45cb98cf92405349b68eabeea9772aee3c4b4d 100644 --- a/app/code/Magento/GiftMessage/Model/Save.php +++ b/app/code/Magento/GiftMessage/Model/Save.php @@ -80,6 +80,7 @@ class Save extends \Magento\Framework\Object /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getSaved() { @@ -243,6 +244,7 @@ class Save extends \Magento\Framework\Object * * @param \Magento\Framework\Object $item * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsAllowedQuoteItem($item) { diff --git a/app/code/Magento/GiftMessage/Service/V1/Data/Message.php b/app/code/Magento/GiftMessage/Service/V1/Data/Message.php deleted file mode 100644 index 768b74a47e020fc7d6e6d2aed61e4d02b2bd3efa..0000000000000000000000000000000000000000 --- a/app/code/Magento/GiftMessage/Service/V1/Data/Message.php +++ /dev/null @@ -1,89 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\GiftMessage\Service\V1\Data; - -/** - * Gift message data object. - * - * @codeCoverageIgnore - */ -class Message extends \Magento\Framework\Api\AbstractExtensibleObject -{ - /** - * Gift message ID. - */ - const GIFT_MESSAGE_ID = 'gift_message_id'; - - /** - * Sender name. - */ - const SENDER = 'sender'; - - /** - * Recipient name. - */ - const RECIPIENT = 'recipient'; - - /** - * Message text. - */ - const MESSAGE = 'message'; - - /** - * Customer ID. - */ - const CUSTOMER_ID = 'customer_id'; - - /** - * Returns the gift message ID. - * - * @return int|null Gift message ID. Otherwise, null. - */ - public function getGiftMessageId() - { - return $this->_get(self::GIFT_MESSAGE_ID); - } - - /** - * Returns the customer ID. - * - * @return int|null Customer ID. Otherwise, null. - */ - public function getCustomerId() - { - return $this->_get(self::CUSTOMER_ID); - } - - /** - * Returns the sender name. - * - * @return string Sender name. - */ - public function getSender() - { - return $this->_get(self::SENDER); - } - - /** - * Returns the recipient name. - * - * @return string Recipient name. - */ - public function getRecipient() - { - return $this->_get(self::RECIPIENT); - } - - /** - * Returns the message text. - * - * @return string Message text. - */ - public function getMessage() - { - return $this->_get(self::MESSAGE); - } -} diff --git a/app/code/Magento/GiftMessage/Service/V1/ReadService.php b/app/code/Magento/GiftMessage/Service/V1/ReadService.php deleted file mode 100644 index e1e0dda0ace03d2329a4ecd324c4584d5056aaa3..0000000000000000000000000000000000000000 --- a/app/code/Magento/GiftMessage/Service/V1/ReadService.php +++ /dev/null @@ -1,108 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\GiftMessage\Service\V1; - -use Magento\Framework\Exception\NoSuchEntityException; - -/** - * Shopping cart gift message service object. - */ -class ReadService implements ReadServiceInterface -{ - /** - * Quote repository. - * - * @var \Magento\Quote\Model\QuoteRepository - */ - protected $quoteRepository; - - /** - * Message factory. - * - * @var \Magento\GiftMessage\Model\MessageFactory - */ - protected $messageFactory; - - /** - * Message mapper. - * - * @var \Magento\GiftMessage\Service\V1\Data\MessageMapper - */ - protected $messageMapper; - - /** - * Constructs a shopping cart gift message service object. - * - * @param \Magento\Quote\Model\QuoteRepository $quoteRepository Quote repository. - * @param \Magento\GiftMessage\Model\MessageFactory $messageFactory Message factory. - * @param \Magento\GiftMessage\Service\V1\Data\MessageMapper $messageMapper Message mapper. - */ - public function __construct( - \Magento\Quote\Model\QuoteRepository $quoteRepository, - \Magento\GiftMessage\Model\MessageFactory $messageFactory, - \Magento\GiftMessage\Service\V1\Data\MessageMapper $messageMapper - ) { - $this->quoteRepository = $quoteRepository; - $this->messageFactory = $messageFactory; - $this->messageMapper = $messageMapper; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The shopping cart ID. - * @return \Magento\GiftMessage\Service\V1\Data\Message Gift message. - */ - public function get($cartId) - { - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->getActive($cartId); - - $messageId = $quote->getGiftMessageId(); - if (!$messageId) { - return null; - } - - /** @var \Magento\GiftMessage\Model\Message $model */ - $model = $this->messageFactory->create()->load($messageId); - - return $this->messageMapper->extractDto($model); - } - - /** - * {@inheritDoc} - * - * @param int $cartId The shopping cart ID. - * @param int $itemId The item ID. - * @return \Magento\GiftMessage\Service\V1\Data\Message Gift message. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified item does not exist in the cart. - */ - public function getItemMessage($cartId, $itemId) - { - /** - * Quote. - * - * @var \Magento\Quote\Model\Quote $quote - */ - $quote = $this->quoteRepository->getActive($cartId); - if (!$item = $quote->getItemById($itemId)) { - throw new NoSuchEntityException('There is no item with provided id in the cart'); - }; - $messageId = $item->getGiftMessageId(); - if (!$messageId) { - return null; - } - - /** - * Model. - * - * @var \Magento\GiftMessage\Model\Message $model - */ - $model = $this->messageFactory->create()->load($messageId); - - return $this->messageMapper->extractDto($model); - } -} diff --git a/app/code/Magento/GiftMessage/Service/V1/ReadServiceInterface.php b/app/code/Magento/GiftMessage/Service/V1/ReadServiceInterface.php deleted file mode 100644 index 6da2510a67e52e29a0d78781b2864495750545bb..0000000000000000000000000000000000000000 --- a/app/code/Magento/GiftMessage/Service/V1/ReadServiceInterface.php +++ /dev/null @@ -1,30 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\GiftMessage\Service\V1; - -/** - * Quote shipping method read service interface. - */ -interface ReadServiceInterface -{ - /** - * Returns the gift message for a specified order. - * - * @param int $cartId The shopping cart ID. - * @return \Magento\GiftMessage\Service\V1\Data\Message Gift message. - */ - public function get($cartId); - - /** - * Returns the gift message for a specified item in a specified shopping cart. - * - * @param int $cartId The shopping cart ID. - * @param int $itemId The item ID. - * @return \Magento\GiftMessage\Service\V1\Data\Message Gift message. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified item does not exist in the cart. - */ - public function getItemMessage($cartId, $itemId); -} diff --git a/app/code/Magento/GiftMessage/Service/V1/WriteService.php b/app/code/Magento/GiftMessage/Service/V1/WriteService.php deleted file mode 100644 index 0163c329a40ce534ae237c060f91de5f6b568507..0000000000000000000000000000000000000000 --- a/app/code/Magento/GiftMessage/Service/V1/WriteService.php +++ /dev/null @@ -1,163 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\GiftMessage\Service\V1; - -use Magento\Framework\Exception\CouldNotSaveException; -use Magento\Framework\Exception\InputException; -use Magento\Framework\Exception\NoSuchEntityException; -use Magento\Framework\Exception\State\InvalidTransitionException; - -/** - * Gift message write service data object. - */ -class WriteService implements WriteServiceInterface -{ - /** - * Quote repository. - * - * @var \Magento\Quote\Model\QuoteRepository - */ - protected $quoteRepository; - - /** - * Store manager interface. - * - * @var \Magento\Store\Model\StoreManagerInterface - */ - protected $storeManager; - - /** - * Gift message manager. - * - * @var \Magento\GiftMessage\Model\GiftMessageManager - */ - protected $giftMessageManager; - - /** - * Message helper. - * - * @var \Magento\GiftMessage\Helper\Message - */ - protected $helper; - - /** - * Constructs a gift message write service data object. - * - * @param \Magento\Quote\Model\QuoteRepository $quoteRepository Quote repository. - * @param \Magento\Store\Model\StoreManagerInterface $storeManager Store manager. - * @param \Magento\GiftMessage\Model\GiftMessageManager $giftMessageManager Gift message manager. - * @param \Magento\GiftMessage\Helper\Message $helper Message helper. - */ - public function __construct( - \Magento\Quote\Model\QuoteRepository $quoteRepository, - \Magento\Store\Model\StoreManagerInterface $storeManager, - \Magento\GiftMessage\Model\GiftMessageManager $giftMessageManager, - \Magento\GiftMessage\Helper\Message $helper - ) { - $this->quoteRepository = $quoteRepository; - $this->giftMessageManager = $giftMessageManager; - $this->storeManager = $storeManager; - $this->helper = $helper; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The shopping cart ID. - * @param Data\Message $giftMessage The gift message. - * @return bool - * @throws \Magento\Framework\Exception\InputException You cannot add gift messages to empty carts. - * @throws \Magento\Framework\Exception\State\InvalidTransitionException You cannot add gift messages to virtual - * products. - */ - public function setForQuote($cartId, \Magento\GiftMessage\Service\V1\Data\Message $giftMessage) - { - /** - * Quote. - * - * @var \Magento\Quote\Model\Quote $quote - */ - $quote = $this->quoteRepository->getActive($cartId); - - if (0 == $quote->getItemsCount()) { - throw new InputException('Gift Messages is not applicable for empty cart'); - } - - if ($quote->isVirtual()) { - throw new InvalidTransitionException('Gift Messages is not applicable for virtual products'); - } - - $this->setMessage($quote, 'quote', $giftMessage); - return true; - } - - /** - * {@inheritDoc} - * - * @param int $cartId The shopping cart ID. - * @param Data\Message $giftMessage The gift message. - * @param int $itemId The item ID. - * @return bool - * @throws \Magento\Framework\Exception\State\InvalidTransitionException You cannot add gift messages to - * virtual products. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified item does not exist in the cart. - */ - public function setForItem($cartId, \Magento\GiftMessage\Service\V1\Data\Message $giftMessage, $itemId) - { - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->quoteRepository->getActive($cartId); - - if (!$item = $quote->getItemById($itemId)) { - throw new NoSuchEntityException("There is no product with provided itemId: $itemId in the cart"); - }; - - if ($item->getIsVirtual()) { - throw new InvalidTransitionException('Gift Messages is not applicable for virtual products'); - } - - $this->setMessage($quote, 'quote_item', $giftMessage, $itemId); - return true; - } - - /** - * Sets the gift message to item or quote. - * - * @param \Magento\Quote\Model\Quote $quote The quote. - * @param string $type The type. - * @param \Magento\GiftMessage\Service\V1\Data\Message $giftMessage The gift message. - * @param null|int $entityId The entity ID. - * @return void - * @throws \Magento\Framework\Exception\CouldNotSaveException The specified gift message is not available. - * @throws \Magento\Framework\Exception\State\InvalidTransitionException The billing or shipping address is not set. - */ - protected function setMessage(\Magento\Quote\Model\Quote $quote, $type, $giftMessage, $entityId = null) - { - if (is_null($quote->getBillingAddress()->getCountryId())) { - throw new InvalidTransitionException('Billing address is not set'); - } - - // check if shipping address is set - if (is_null($quote->getShippingAddress()->getCountryId())) { - throw new InvalidTransitionException('Shipping address is not set'); - } - - $configType = $type == 'quote' ? '' : 'items'; - if (!$this->helper->getIsMessagesAvailable($configType, $quote, $this->storeManager->getStore())) { - throw new CouldNotSaveException('Gift Message is not available'); - } - $message[$type][$entityId] = [ - 'from' => $giftMessage->getSender(), - 'to' => $giftMessage->getRecipient(), - 'message' => $giftMessage->getMessage(), - ]; - - try { - $this->giftMessageManager->add($message, $quote); - } catch (\Exception $e) { - throw new CouldNotSaveException('Could not add gift message to shopping cart'); - } - } -} diff --git a/app/code/Magento/GiftMessage/Service/V1/WriteServiceInterface.php b/app/code/Magento/GiftMessage/Service/V1/WriteServiceInterface.php deleted file mode 100644 index 295485887416ec9ec665a823338b36bb783cf993..0000000000000000000000000000000000000000 --- a/app/code/Magento/GiftMessage/Service/V1/WriteServiceInterface.php +++ /dev/null @@ -1,41 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\GiftMessage\Service\V1; - -/** - * Quote shipping method read service. - */ -interface WriteServiceInterface -{ - /** - * Sets the gift message for an entire order. - * - * @param int $cartId The cart ID. - * @param \Magento\GiftMessage\Service\V1\Data\Message $giftMessage The gift message. - * @return bool - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - * @throws \Magento\Framework\Exception\InputException You cannot add gift messages to empty carts. - * @throws \Magento\Framework\Exception\State\InvalidTransitionException You cannot add gift messages to - * virtual products. - * @throws \Magento\Framework\Exception\CouldNotSaveException The specified gift message could not be saved. - */ - public function setForQuote($cartId, \Magento\GiftMessage\Service\V1\Data\Message $giftMessage); - - /** - * Sets the gift message for a specified item. - * - * @param int $cartId The cart ID. - * @param \Magento\GiftMessage\Service\V1\Data\Message $giftMessage The gift message. - * @param int $itemId The item ID. - * @return bool - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - * @throws \Magento\Framework\Exception\InputException You cannot add gift messages to empty carts. - * @throws \Magento\Framework\Exception\State\InvalidTransitionException You cannot add gift messages to - * virtual products. - * @throws \Magento\Framework\Exception\CouldNotSaveException The specified gift message could not be saved. - */ - public function setForItem($cartId, \Magento\GiftMessage\Service\V1\Data\Message $giftMessage, $itemId); -} diff --git a/app/code/Magento/GiftMessage/etc/di.xml b/app/code/Magento/GiftMessage/etc/di.xml index a01e8d4bed694f3190fc2132796ee6c9c56d5fc6..f49fdfcd4b5c4c51487985c7a004c0bd2edd0fba 100644 --- a/app/code/Magento/GiftMessage/etc/di.xml +++ b/app/code/Magento/GiftMessage/etc/di.xml @@ -20,6 +20,7 @@ </argument> </arguments> </type> - <preference for="Magento\GiftMessage\Service\V1\ReadServiceInterface" type="Magento\GiftMessage\Service\V1\ReadService"/> - <preference for="Magento\GiftMessage\Service\V1\WriteServiceInterface" type="Magento\GiftMessage\Service\V1\WriteService"/> + <preference for="Magento\GiftMessage\Api\CartRepositoryInterface" type="Magento\GiftMessage\Model\CartRepository"/> + <preference for="Magento\GiftMessage\Api\ItemRepositoryInterface" type="Magento\GiftMessage\Model\ItemRepository"/> + <preference for="Magento\GiftMessage\Api\Data\MessageInterface" type="Magento\GiftMessage\Model\Message"/> </config> diff --git a/app/code/Magento/GiftMessage/etc/webapi.xml b/app/code/Magento/GiftMessage/etc/webapi.xml index e5875d5d09d5a9c24a0bfaaff409ae315c3e65d8..c5dd571a7ac105813159525195c8074be14be8c6 100644 --- a/app/code/Magento/GiftMessage/etc/webapi.xml +++ b/app/code/Magento/GiftMessage/etc/webapi.xml @@ -8,25 +8,25 @@ <routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../app/code/Magento/Webapi/etc/webapi.xsd"> <route url="/V1/carts/:cartId/gift-message" method="GET"> - <service class="Magento\GiftMessage\Service\V1\ReadServiceInterface" method="get"/> + <service class="Magento\GiftMessage\Api\CartRepositoryInterface" method="get"/> <resources> <resource ref="Magento_Sales::create" /> </resources> </route> <route url="/V1/carts/:cartId/gift-message/:itemId" method="GET"> - <service class="Magento\GiftMessage\Service\V1\ReadServiceInterface" method="getItemMessage"/> + <service class="Magento\GiftMessage\Api\ItemRepositoryInterface" method="get"/> <resources> <resource ref="Magento_Sales::create" /> </resources> </route> - <route url="/V1/carts/:cartId/gift-message" method="PUT"> - <service class="Magento\GiftMessage\Service\V1\WriteServiceInterface" method="setForQuote"/> + <route url="/V1/carts/:cartId/gift-message" method="POST"> + <service class="Magento\GiftMessage\Api\CartRepositoryInterface" method="save"/> <resources> <resource ref="Magento_Sales::create" /> </resources> </route> - <route url="/V1/carts/:cartId/gift-message/:itemId" method="PUT"> - <service class="Magento\GiftMessage\Service\V1\WriteServiceInterface" method="setForItem"/> + <route url="/V1/carts/:cartId/gift-message/:itemId" method="POST"> + <service class="Magento\GiftMessage\Api\ItemRepositoryInterface" method="save"/> <resources> <resource ref="Magento_Sales::create" /> </resources> diff --git a/app/code/Magento/GiftMessage/view/adminhtml/templates/giftoptionsform.phtml b/app/code/Magento/GiftMessage/view/adminhtml/templates/giftoptionsform.phtml index 243c87efbe082413886056c419d7110c39584811..a1975f3e8fbb35a4fb4ea17fa2202b83bc6e2abf 100644 --- a/app/code/Magento/GiftMessage/view/adminhtml/templates/giftoptionsform.phtml +++ b/app/code/Magento/GiftMessage/view/adminhtml/templates/giftoptionsform.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->canDisplayGiftmessageForm()): ?> diff --git a/app/code/Magento/GiftMessage/view/adminhtml/templates/popup.phtml b/app/code/Magento/GiftMessage/view/adminhtml/templates/popup.phtml index 747f2aa31e355f9fdbc233445193ad783d73e0c9..18cc1e82bf760f0963918df6e06732d577420452 100644 --- a/app/code/Magento/GiftMessage/view/adminhtml/templates/popup.phtml +++ b/app/code/Magento/GiftMessage/view/adminhtml/templates/popup.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getChildHtml()) :?> diff --git a/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/create/giftoptions.phtml b/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/create/giftoptions.phtml index 3eccaf65a090bfc54b0e80cc3987a118244b1b24..c628714a4f72e75810550f3c297388631f3a7a78 100644 --- a/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/create/giftoptions.phtml +++ b/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/create/giftoptions.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/create/items.phtml b/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/create/items.phtml index 4778d49229e1d5496c2391edc49530d53aa69872..08308c4ba999243c4507e57585dcbc4bd119f883 100644 --- a/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/create/items.phtml +++ b/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/create/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->canDisplayGiftMessage()): ?> diff --git a/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/view/giftoptions.phtml b/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/view/giftoptions.phtml index b5011dd12bbbf3aa920220abb89a543e8ea05eec..ea281e18a9f2325c50a5341d88090ba302fb40e9 100644 --- a/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/view/giftoptions.phtml +++ b/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/view/giftoptions.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_childHtml = trim($this->getChildHtml('', false)); ?> diff --git a/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/view/items.phtml b/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/view/items.phtml index d337ebc21f9446d8337d7623e4370d51ff6da6ad..09b181ebdfbfbdb99245ee62813aad3db14cd1c0 100644 --- a/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/view/items.phtml +++ b/app/code/Magento/GiftMessage/view/adminhtml/templates/sales/order/view/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->canDisplayGiftmessage()): ?> diff --git a/app/code/Magento/GiftMessage/view/frontend/templates/inline.phtml b/app/code/Magento/GiftMessage/view/frontend/templates/inline.phtml index 3d3a03a7e88585b1e76e5648c98f0732751bb427..4e70de76630fb707de0fbcd01d539bb83524aee1 100644 --- a/app/code/Magento/GiftMessage/view/frontend/templates/inline.phtml +++ b/app/code/Magento/GiftMessage/view/frontend/templates/inline.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_giftMessage = false; ?> <?php switch ($this->getCheckoutType()): ?> diff --git a/app/code/Magento/GoogleAnalytics/Block/Ga.php b/app/code/Magento/GoogleAnalytics/Block/Ga.php index 9d43e1f144d71de2ebb5f617f0264e0b097a426a..8236e5fac9e5422e43293066b922e852e8a5668b 100644 --- a/app/code/Magento/GoogleAnalytics/Block/Ga.php +++ b/app/code/Magento/GoogleAnalytics/Block/Ga.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleAnalytics\Block; /** diff --git a/app/code/Magento/GoogleAnalytics/Helper/Data.php b/app/code/Magento/GoogleAnalytics/Helper/Data.php index 2545895e56b2ae1c7710ba68866a3d3b70701ab7..49b29bc28cf3e6b34418f3a7fabf1b87eb46bb01 100644 --- a/app/code/Magento/GoogleAnalytics/Helper/Data.php +++ b/app/code/Magento/GoogleAnalytics/Helper/Data.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleAnalytics\Helper; use Magento\Store\Model\Store; diff --git a/app/code/Magento/GoogleAnalytics/view/frontend/templates/ga.phtml b/app/code/Magento/GoogleAnalytics/view/frontend/templates/ga.phtml index 543754fa4fa7ab8a990587af02855e546dae8e92..09e206fa5a82daeb879a6f6c4b9a3ede220e8458 100644 --- a/app/code/Magento/GoogleAnalytics/view/frontend/templates/ga.phtml +++ b/app/code/Magento/GoogleAnalytics/view/frontend/templates/ga.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\GoogleAnalytics\Block\Ga */ ?> <?php if (!$this->helper('Magento\Store\Helper\Cookie')->isUserNotAllowSaveCookie()): ?> diff --git a/app/code/Magento/GoogleOptimizer/Block/Adminhtml/Catalog/Category/Edit/Tab/Googleoptimizer.php b/app/code/Magento/GoogleOptimizer/Block/Adminhtml/Catalog/Category/Edit/Tab/Googleoptimizer.php index 1895625c2479a7aa2c60efda9731ca715b0d9607..2fc44ab02315a9c60de7ca26b166a351576a3fc9 100644 --- a/app/code/Magento/GoogleOptimizer/Block/Adminhtml/Catalog/Category/Edit/Tab/Googleoptimizer.php +++ b/app/code/Magento/GoogleOptimizer/Block/Adminhtml/Catalog/Category/Edit/Tab/Googleoptimizer.php @@ -7,6 +7,9 @@ */ namespace Magento\GoogleOptimizer\Block\Adminhtml\Catalog\Category\Edit\Tab; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Googleoptimizer extends \Magento\Catalog\Block\Adminhtml\Form { /** diff --git a/app/code/Magento/GoogleOptimizer/Block/Code/Category.php b/app/code/Magento/GoogleOptimizer/Block/Code/Category.php index 3a6a42e58907cde1fa1f29b1ec1d5c9b439f8245..5e611ec1be1362947f3ccd0923a0604ad9a933ec 100644 --- a/app/code/Magento/GoogleOptimizer/Block/Code/Category.php +++ b/app/code/Magento/GoogleOptimizer/Block/Code/Category.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleOptimizer\Block\Code; class Category extends \Magento\GoogleOptimizer\Block\AbstractCode implements \Magento\Framework\View\Block\IdentityInterface diff --git a/app/code/Magento/GoogleOptimizer/Block/Code/Product.php b/app/code/Magento/GoogleOptimizer/Block/Code/Product.php index 98a9888c196dcd0e7fa1f59cde4c7b70a6a566c3..371debd2a72741b724fbcd2c69238240f094f626 100644 --- a/app/code/Magento/GoogleOptimizer/Block/Code/Product.php +++ b/app/code/Magento/GoogleOptimizer/Block/Code/Product.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleOptimizer\Block\Code; class Product extends \Magento\GoogleOptimizer\Block\AbstractCode implements \Magento\Framework\View\Block\IdentityInterface diff --git a/app/code/Magento/GoogleOptimizer/Helper/Data.php b/app/code/Magento/GoogleOptimizer/Helper/Data.php index 6f6ef4e1956d0e0dc621f12a4a492d07200dc54c..8010a5fc27292710c38eaa3e366b4d8c7648a765 100644 --- a/app/code/Magento/GoogleOptimizer/Helper/Data.php +++ b/app/code/Magento/GoogleOptimizer/Helper/Data.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleOptimizer\Helper; class Data extends \Magento\Framework\App\Helper\AbstractHelper diff --git a/app/code/Magento/GoogleOptimizer/Model/Observer/Block/Category/Tab.php b/app/code/Magento/GoogleOptimizer/Model/Observer/Block/Category/Tab.php index a2077c5ed4f029b6d5d095208925409bd4f07b93..3c9b1b2d3fb63e62fdb19866ee4be5bd29bd8121 100644 --- a/app/code/Magento/GoogleOptimizer/Model/Observer/Block/Category/Tab.php +++ b/app/code/Magento/GoogleOptimizer/Model/Observer/Block/Category/Tab.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleOptimizer\Model\Observer\Block\Category; use Magento\Framework\Event\Observer as EventObserver; diff --git a/app/code/Magento/GoogleShopping/Block/Adminhtml/Items/Item.php b/app/code/Magento/GoogleShopping/Block/Adminhtml/Items/Item.php index 2a213dd90e5633227e1d31080e7de947d5aed786..073826ff9ebb613492bb4daafbb1fb5753f67310 100644 --- a/app/code/Magento/GoogleShopping/Block/Adminhtml/Items/Item.php +++ b/app/code/Magento/GoogleShopping/Block/Adminhtml/Items/Item.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleShopping\Block\Adminhtml\Items; /** diff --git a/app/code/Magento/GoogleShopping/Block/Adminhtml/Types/Edit/Form.php b/app/code/Magento/GoogleShopping/Block/Adminhtml/Types/Edit/Form.php index 6c4edeb942f464491cca2c16db2f026bb7e11900..7d2ca2231ef508fd48b19b10c03258d910b0c6ab 100644 --- a/app/code/Magento/GoogleShopping/Block/Adminhtml/Types/Edit/Form.php +++ b/app/code/Magento/GoogleShopping/Block/Adminhtml/Types/Edit/Form.php @@ -71,6 +71,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * @param \Magento\Framework\Data\Form\Element\Factory $elementFactory * @param \Magento\GoogleShopping\Helper\Category $googleShoppingCategory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Backend\Block\Template\Context $context, diff --git a/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Items/Index.php b/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Items/Index.php index 6dea87aa9a32833f7529a8c6e92443183065400f..56380c2148cfacfde955603861af9d03fa33fbb4 100644 --- a/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Items/Index.php +++ b/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Items/Index.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleShopping\Controller\Adminhtml\Googleshopping\Items; use Magento\Backend\App\Action; diff --git a/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Items/Refresh.php b/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Items/Refresh.php index ee0b27779d6ddb569cfbcc53deb7b37e1d9c6532..03fc43a2939797febd4ccdcc5bb1b837a3e9783c 100644 --- a/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Items/Refresh.php +++ b/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Items/Refresh.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleShopping\Controller\Adminhtml\Googleshopping\Items; class Refresh extends \Magento\GoogleShopping\Controller\Adminhtml\Googleshopping\Items diff --git a/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Types/Save.php b/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Types/Save.php index 3da4fe25f1c62e215917ff22268098dc6f9bfc3b..78368e75a7f77f457db3fc467b31d208d4d2ba2a 100644 --- a/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Types/Save.php +++ b/app/code/Magento/GoogleShopping/Controller/Adminhtml/Googleshopping/Types/Save.php @@ -12,6 +12,7 @@ class Save extends \Magento\GoogleShopping\Controller\Adminhtml\Googleshopping\T * Save attribute set mapping * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/GoogleShopping/Helper/Category.php b/app/code/Magento/GoogleShopping/Helper/Category.php index 38d17c11f9e0a2ef0ca1b2f2b1b8d8ca14818160..36f2b197544fe02a3bab927d02acfb86cfde367e 100644 --- a/app/code/Magento/GoogleShopping/Helper/Category.php +++ b/app/code/Magento/GoogleShopping/Helper/Category.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleShopping\Helper; /** diff --git a/app/code/Magento/GoogleShopping/Helper/Data.php b/app/code/Magento/GoogleShopping/Helper/Data.php index 18469118375f4208178ede60243f72a45f4a8d2b..30e39ba157abfeb04d30bb66a9ec9636aa757106 100644 --- a/app/code/Magento/GoogleShopping/Helper/Data.php +++ b/app/code/Magento/GoogleShopping/Helper/Data.php @@ -86,6 +86,7 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * @param string $message \Exception message to parse * @param null|\Magento\Catalog\Model\Product $product * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function parseGdataExceptionMessage($message, $product = null) { diff --git a/app/code/Magento/GoogleShopping/Model/Attribute.php b/app/code/Magento/GoogleShopping/Model/Attribute.php index 545c91d2f45b21f280dcd39923231f6293335f02..adbe22f41a86b983e875e59cf36cc2beae5b1915 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute.php @@ -109,6 +109,7 @@ class Attribute extends \Magento\Framework\Model\AbstractModel * * @param int $setId attribute set id * @return array + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getAllowedAttributes($setId) { diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/ContentLanguage.php b/app/code/Magento/GoogleShopping/Model/Attribute/ContentLanguage.php index 56d7dc701b8a5a28b97f1438ed4e6b5f903f37ee..e78e3b68c2f1d995c31965e33e8538d70f3657d0 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/ContentLanguage.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/ContentLanguage.php @@ -30,6 +30,7 @@ class ContentLanguage extends \Magento\GoogleShopping\Model\Attribute\DefaultAtt * @param \Magento\GoogleShopping\Model\Config $config * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/DefaultAttribute.php b/app/code/Magento/GoogleShopping/Model/Attribute/DefaultAttribute.php index b3f83375ce1ad5fe01c32385e7b942c4d4af81f8..0c9b83bf976edf37780fbf404fec3f43c905745b 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/DefaultAttribute.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/DefaultAttribute.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Default attribute model * @@ -11,6 +13,9 @@ */ namespace Magento\GoogleShopping\Model\Attribute; +/** + * @SuppressWarnings(PHPMD.NumberOfChildren) + */ class DefaultAttribute extends \Magento\GoogleShopping\Model\Attribute { /** diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/Destinations.php b/app/code/Magento/GoogleShopping/Model/Attribute/Destinations.php index 19b6b01e582dac6790f15af4a8f1a9a051f002f2..43dc01798d763a0d517a2c0eef59bf653c227d25 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/Destinations.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/Destinations.php @@ -30,6 +30,7 @@ class Destinations extends \Magento\GoogleShopping\Model\Attribute\DefaultAttrib * @param \Magento\GoogleShopping\Model\Config $config * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/GoogleProductCategory.php b/app/code/Magento/GoogleShopping/Model/Attribute/GoogleProductCategory.php index 98bfca9bd664f98155d88341dc22a2f533c4aec4..1ac9b00897baee8d298808acc0c356a16c97bc1b 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/GoogleProductCategory.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/GoogleProductCategory.php @@ -38,6 +38,7 @@ class GoogleProductCategory extends \Magento\GoogleShopping\Model\Attribute\Defa * @param \Magento\GoogleShopping\Model\Config $config * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/ImageLink.php b/app/code/Magento/GoogleShopping/Model/Attribute/ImageLink.php index 7afd93bcff94abc8078de14df0e1120f22ae209e..e286f926ea2ca575528a1aba0bc07a69bc9071ae 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/ImageLink.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/ImageLink.php @@ -28,6 +28,7 @@ class ImageLink extends \Magento\GoogleShopping\Model\Attribute\DefaultAttribute * @param \Magento\Catalog\Helper\Product $catalogProduct * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/Link.php b/app/code/Magento/GoogleShopping/Model/Attribute/Link.php index a234faf07f410d8d1d7b042fe26386cf6cd71b53..1e9b15cd96b556b55fada2f964136dab97b9f013 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/Link.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/Link.php @@ -28,6 +28,7 @@ class Link extends \Magento\GoogleShopping\Model\Attribute\DefaultAttribute * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/Price.php b/app/code/Magento/GoogleShopping/Model/Attribute/Price.php index 6a7eba0a92b034794a85d4762b5e755d6ea25a2f..a75a1f1a774fb21782fce489c671a8783e8ea4db 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/Price.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/Price.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleShopping\Model\Attribute; use Magento\Catalog\Model\Product; diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/ProductType.php b/app/code/Magento/GoogleShopping/Model/Attribute/ProductType.php index 2a614ea22daacd1674de3a64ae76d45b7fd322de..9be717ab564b6981c6e527319631dce30853c65f 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/ProductType.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/ProductType.php @@ -30,6 +30,7 @@ class ProductType extends \Magento\GoogleShopping\Model\Attribute\DefaultAttribu * @param \Magento\Catalog\Api\CategoryRepositoryInterface $categoryRepository * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/SalePriceEffectiveDate.php b/app/code/Magento/GoogleShopping/Model/Attribute/SalePriceEffectiveDate.php index a7c7a14ce20255386c97c7c4308b37d3b8a3d477..494e7185eb277037d3213af27e6613495c08ca1f 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/SalePriceEffectiveDate.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/SalePriceEffectiveDate.php @@ -19,6 +19,8 @@ class SalePriceEffectiveDate extends \Magento\GoogleShopping\Model\Attribute\Def * @param \Magento\Catalog\Model\Product $product * @param \Magento\Framework\Gdata\Gshopping\Entry $entry * @return \Magento\Framework\Gdata\Gshopping\Entry + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function convertAttribute($product, $entry) { diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/TargetCountry.php b/app/code/Magento/GoogleShopping/Model/Attribute/TargetCountry.php index f83f5ce54b5757ebeaabe59566799787be446b9f..ca24c2f97d22f743da7c37ae9dd432134bb4b6a6 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/TargetCountry.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/TargetCountry.php @@ -30,6 +30,7 @@ class TargetCountry extends \Magento\GoogleShopping\Model\Attribute\DefaultAttri * @param \Magento\GoogleShopping\Model\Config $config * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/GoogleShopping/Model/Attribute/Tax.php b/app/code/Magento/GoogleShopping/Model/Attribute/Tax.php index ead001020d259969ffd49b479b723da0cf47ce6f..1e49ece6ae9170f70a7e26beab7fc5fe0d4d41b3 100644 --- a/app/code/Magento/GoogleShopping/Model/Attribute/Tax.php +++ b/app/code/Magento/GoogleShopping/Model/Attribute/Tax.php @@ -13,6 +13,7 @@ use Magento\Tax\Api\Data\TaxClassKeyInterface; * Tax attribute model * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Tax extends \Magento\GoogleShopping\Model\Attribute\DefaultAttribute { @@ -93,6 +94,7 @@ class Tax extends \Magento\GoogleShopping\Model\Attribute\DefaultAttribute * @param \Magento\Customer\Api\GroupManagementInterface $groupManagement * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/GoogleShopping/Model/Config.php b/app/code/Magento/GoogleShopping/Model/Config.php index 7007b555fbdb84a2095bb8814444653a598a5675..5e4ef7014d13d80afb2c1a834654a1b2f481f22b 100644 --- a/app/code/Magento/GoogleShopping/Model/Config.php +++ b/app/code/Magento/GoogleShopping/Model/Config.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleShopping\Model; /** @@ -244,6 +247,7 @@ class Config extends \Magento\Framework\Object * where: key - attribute name, value - group name * * @return array + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getAttributeGroupsFlat() { @@ -272,6 +276,7 @@ class Config extends \Magento\Framework\Object * * @param int $storeId * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsDebug($storeId) { @@ -282,6 +287,7 @@ class Config extends \Magento\Framework\Object * Returns all required attributes * * @return array + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getRequiredAttributes() { diff --git a/app/code/Magento/GoogleShopping/Model/MassOperations.php b/app/code/Magento/GoogleShopping/Model/MassOperations.php index d22319e6aa225b8da954b8d634307c1d862371c6..7cabe18ba1a86c9175a3559f49d91429b75408e5 100644 --- a/app/code/Magento/GoogleShopping/Model/MassOperations.php +++ b/app/code/Magento/GoogleShopping/Model/MassOperations.php @@ -12,6 +12,7 @@ use Magento\GoogleShopping\Model\Resource\Item\Collection as ItemCollection; * Controller for mass opertions with items * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class MassOperations { @@ -74,6 +75,7 @@ class MassOperations * @param \Magento\GoogleShopping\Helper\Data $gleShoppingData * @param \Magento\GoogleShopping\Helper\Category $gleShoppingCategory * @param array $data + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function __construct( \Magento\GoogleShopping\Model\Resource\Item\CollectionFactory $collectionFactory, @@ -143,6 +145,8 @@ class MassOperations * @param int $storeId * @return $this * @throws \Exception|\Zend_Gdata_App_CaptchaRequiredException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function addProducts($productIds, $storeId) { @@ -217,6 +221,7 @@ class MassOperations * @param int[]|ItemCollection $items * @return $this * @throws \Exception|\Zend_Gdata_App_CaptchaRequiredException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function synchronizeItems($items) { @@ -303,6 +308,7 @@ class MassOperations * @param int[]|ItemCollection $items * @return $this * @throws \Exception|\Zend_Gdata_App_CaptchaRequiredException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function deleteItems($items) { diff --git a/app/code/Magento/GoogleShopping/Model/Observer.php b/app/code/Magento/GoogleShopping/Model/Observer.php index 92308116337d14600eabafed794995be5334d54b..3fc97c0a8991d02824a0dac071a9e0ae1b09abbd 100644 --- a/app/code/Magento/GoogleShopping/Model/Observer.php +++ b/app/code/Magento/GoogleShopping/Model/Observer.php @@ -146,6 +146,7 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function checkSynchronizationOperations(\Magento\Framework\Event\Observer $observer) { diff --git a/app/code/Magento/GoogleShopping/Model/Resource/Attribute/Collection.php b/app/code/Magento/GoogleShopping/Model/Resource/Attribute/Collection.php index fc26f93ff7850a9cf22ec037027cdd27e5309e7c..855192cfab25a71a28a7b1b6eadb1f4217c10ad3 100644 --- a/app/code/Magento/GoogleShopping/Model/Resource/Attribute/Collection.php +++ b/app/code/Magento/GoogleShopping/Model/Resource/Attribute/Collection.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleShopping\Model\Resource\Attribute; /** @@ -94,6 +97,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac * Get flag - whether to join attribute_set_id to attributes or not * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getJoinAttributeSetFlag() { diff --git a/app/code/Magento/GoogleShopping/Model/Resource/Grid/Collection.php b/app/code/Magento/GoogleShopping/Model/Resource/Grid/Collection.php index f0c4e582e1c8bcb558511b28a9bc9f44f5026847..9771f00fe4084cbdd33832bddc699e351b53236a 100644 --- a/app/code/Magento/GoogleShopping/Model/Resource/Grid/Collection.php +++ b/app/code/Magento/GoogleShopping/Model/Resource/Grid/Collection.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * GoogleShopping Types collection * diff --git a/app/code/Magento/GoogleShopping/Model/Service.php b/app/code/Magento/GoogleShopping/Model/Service.php index 134a4c6c4c75a7d5347301e4cbd1dc93d5202558..87192e45dfc7bce6db60b1e68a9098ac6c02408d 100644 --- a/app/code/Magento/GoogleShopping/Model/Service.php +++ b/app/code/Magento/GoogleShopping/Model/Service.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleShopping\Model; /** diff --git a/app/code/Magento/GoogleShopping/Model/Source/Destinationstates.php b/app/code/Magento/GoogleShopping/Model/Source/Destinationstates.php index 03ee3addbba8e5234fca2b614899b05aae168a8a..836245c56de98013b440a784a8e01ad012f2ecc8 100644 --- a/app/code/Magento/GoogleShopping/Model/Source/Destinationstates.php +++ b/app/code/Magento/GoogleShopping/Model/Source/Destinationstates.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\GoogleShopping\Model\Source; /** diff --git a/app/code/Magento/GoogleShopping/Model/Type.php b/app/code/Magento/GoogleShopping/Model/Type.php index 4c95a44c3e59b21da7a2159ebb9c1e156d6288a7..715f76597a6eb4ed222a092099a10d7f23e0e6a6 100644 --- a/app/code/Magento/GoogleShopping/Model/Type.php +++ b/app/code/Magento/GoogleShopping/Model/Type.php @@ -64,6 +64,7 @@ class Type extends \Magento\Framework\Model\AbstractModel * @param \Magento\GoogleShopping\Model\Resource\Type $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -111,6 +112,7 @@ class Type extends \Magento\Framework\Model\AbstractModel * @param CatalogModelProduct $product * @param Entry $entry * @return Entry + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function convertProductToEntry($product, $entry) { diff --git a/app/code/Magento/GoogleShopping/view/adminhtml/templates/captcha.phtml b/app/code/Magento/GoogleShopping/view/adminhtml/templates/captcha.phtml index c957e3269413dbe2faa762f473716b8df57234d7..651229c12f515b8374923adb125cc6eab5489538 100644 --- a/app/code/Magento/GoogleShopping/view/adminhtml/templates/captcha.phtml +++ b/app/code/Magento/GoogleShopping/view/adminhtml/templates/captcha.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getGcontentCaptchaToken() && $this->getGcontentCaptchaUrl()): ?> diff --git a/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit.phtml b/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit.phtml index cf530730e50ad281cc93c4100bb69c95af592a3a..e456f8529a0149f5fcae156cf2a110ee394cc105 100644 --- a/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit.phtml +++ b/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <script> diff --git a/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit/attributes.phtml b/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit/attributes.phtml index eed576c26c3479792e4ca99f62b43310b3973855..e693dbb9e672a7b0550dae9dfe47d98296f2b2b6 100644 --- a/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit/attributes.phtml +++ b/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit/attributes.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getAttributeSetSelected()): ?> diff --git a/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit/select.phtml b/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit/select.phtml index 1903c6e5f62b3d7831a986dcf65b584db2a4bc0e..d9d5652ad3b265252698c4a34f4e595d971fa0b4 100644 --- a/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit/select.phtml +++ b/app/code/Magento/GoogleShopping/view/adminhtml/templates/types/edit/select.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <select id="<?php echo $this->getId() ?>" name="<?php echo $this->getName() ?>" class="<?php echo $this->getClass() ?>" title=""> diff --git a/app/code/Magento/GroupedProduct/view/adminhtml/templates/catalog/product/composite/fieldset/grouped.phtml b/app/code/Magento/GroupedProduct/view/adminhtml/templates/catalog/product/composite/fieldset/grouped.phtml index 227515794af60b326ecd0c496955e812ecbfc045..11465a7d2396956b83b75ab5941f928473d5991d 100644 --- a/app/code/Magento/GroupedProduct/view/adminhtml/templates/catalog/product/composite/fieldset/grouped.phtml +++ b/app/code/Magento/GroupedProduct/view/adminhtml/templates/catalog/product/composite/fieldset/grouped.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\GroupedProduct\Block\Adminhtml\Product\Composite\Fieldset\Grouped */ ?> diff --git a/app/code/Magento/GroupedProduct/view/adminhtml/templates/product/grouped/grouped.phtml b/app/code/Magento/GroupedProduct/view/adminhtml/templates/product/grouped/grouped.phtml index af984f3c1bbd61ea190a97bd4094f89eaa47a0d4..c3b4134cfbe2f0500b3f82d2a5ec320e40eb0586 100644 --- a/app/code/Magento/GroupedProduct/view/adminhtml/templates/product/grouped/grouped.phtml +++ b/app/code/Magento/GroupedProduct/view/adminhtml/templates/product/grouped/grouped.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Framework\View\Element\Template */ /** @var $this \Magento\Framework\View\Element\Template */ diff --git a/app/code/Magento/GroupedProduct/view/base/templates/product/price/final_price.phtml b/app/code/Magento/GroupedProduct/view/base/templates/product/price/final_price.phtml index e5a522a2241bf879ed061774a81ccaf0a9bf741b..2d2fd99f62dbb6b917961c132dc389120d47b343 100644 --- a/app/code/Magento/GroupedProduct/view/base/templates/product/price/final_price.phtml +++ b/app/code/Magento/GroupedProduct/view/base/templates/product/price/final_price.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Template for displaying grouped product price */ diff --git a/app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/default.phtml b/app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/default.phtml index 6e4bfd48d9479f6a5ce4a727a3e294a179d80fa0..95b5c5e5006567f25fdb62d55673bb53649b36b6 100644 --- a/app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/default.phtml +++ b/app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Catalog\Block\Product\View\AbstractView */?> <?php $_product = $this->getProduct() ?> diff --git a/app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/grouped.phtml b/app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/grouped.phtml index f345a7cef3005290e730a858bcf7c51882ff196b..edc0122cabe56955edd50cb338776cb9bdb1a4c3 100644 --- a/app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/grouped.phtml +++ b/app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/grouped.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Grouped product data template * diff --git a/app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php b/app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php index 578407449813ab5126cb7ddea0a3d746a08be4f9..c4f2d1ab861a75f235ec17169cfe1a445ee8f196 100644 --- a/app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php +++ b/app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php @@ -210,6 +210,7 @@ class Filter extends \Magento\Backend\Block\Widget\Grid\Extended * @param Attribute $attribute * @param mixed $value * @return string + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _getSelectHtmlWithValue(Attribute $attribute, $value) { @@ -323,6 +324,7 @@ class Filter extends \Magento\Backend\Block\Widget\Grid\Extended * @param \Magento\Framework\Object $column * @param boolean $isExport * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function decorateFilter($value, Attribute $row, \Magento\Framework\Object $column, $isExport) { diff --git a/app/code/Magento/ImportExport/Helper/Data.php b/app/code/Magento/ImportExport/Helper/Data.php index 6000763b63598824fa45f72c9a1c678c91882675..43ec77d4f66f10c73bc0f8f8e3054da28813b29d 100644 --- a/app/code/Magento/ImportExport/Helper/Data.php +++ b/app/code/Magento/ImportExport/Helper/Data.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ImportExport\Helper; /** diff --git a/app/code/Magento/ImportExport/Model/Export.php b/app/code/Magento/ImportExport/Model/Export.php index 21cfc97d95726bc5231f83bdfe3dea9a7ab6b0c9..6abad2c2ee392421d5938a520f7d649d1ea0e296 100644 --- a/app/code/Magento/ImportExport/Model/Export.php +++ b/app/code/Magento/ImportExport/Model/Export.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ImportExport\Model; /** diff --git a/app/code/Magento/ImportExport/Model/Export/AbstractEntity.php b/app/code/Magento/ImportExport/Model/Export/AbstractEntity.php index 8450774a2201437c30c816de5fd03b02038b1a42..7241c25053d9dc8c567ba7a65fd5bdcae43d156f 100644 --- a/app/code/Magento/ImportExport/Model/Export/AbstractEntity.php +++ b/app/code/Magento/ImportExport/Model/Export/AbstractEntity.php @@ -13,6 +13,7 @@ use Magento\ImportExport\Model\Export; * Export entity abstract model * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.TooManyFields) */ abstract class AbstractEntity { @@ -176,6 +177,7 @@ abstract class AbstractEntity * @param \Magento\ImportExport\Model\Export\Factory $collectionFactory * @param \Magento\ImportExport\Model\Resource\CollectionByPagesIteratorFactory $resourceColFactory * @param array $data + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function __construct( \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, diff --git a/app/code/Magento/ImportExport/Model/Export/Adapter/AbstractAdapter.php b/app/code/Magento/ImportExport/Model/Export/Adapter/AbstractAdapter.php index 715d06f80402a6f0e5af667f50f0fa7b34b6f9f7..51b3a8a9a4690cf9f09083d6a46ca118c729615a 100644 --- a/app/code/Magento/ImportExport/Model/Export/Adapter/AbstractAdapter.php +++ b/app/code/Magento/ImportExport/Model/Export/Adapter/AbstractAdapter.php @@ -109,6 +109,7 @@ abstract class AbstractAdapter * * @param array $headerColumns * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setHeaderCols(array $headerColumns) { diff --git a/app/code/Magento/ImportExport/Model/Export/Entity/AbstractEav.php b/app/code/Magento/ImportExport/Model/Export/Entity/AbstractEav.php index c17ac6e481ac82ca57089b0982e8e389ac30b578..8803d34fc3d7061be086a9d5ad8c2627ac41377b 100644 --- a/app/code/Magento/ImportExport/Model/Export/Entity/AbstractEav.php +++ b/app/code/Magento/ImportExport/Model/Export/Entity/AbstractEav.php @@ -14,6 +14,7 @@ use Magento\Store\Model\Store; * Export EAV entity abstract model * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractEav extends \Magento\ImportExport\Model\Export\AbstractEntity { @@ -103,6 +104,7 @@ abstract class AbstractEav extends \Magento\ImportExport\Model\Export\AbstractEn * * @param AbstractCollection $collection * @return AbstractCollection + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function filterEntityCollection(AbstractCollection $collection) { diff --git a/app/code/Magento/ImportExport/Model/Export/Entity/AbstractEntity.php b/app/code/Magento/ImportExport/Model/Export/Entity/AbstractEntity.php index 0adea8ff300f690cf349bb5613524b27e38a4193..584b19dc908930fcfb0cba7c1b977e22490d9274 100644 --- a/app/code/Magento/ImportExport/Model/Export/Entity/AbstractEntity.php +++ b/app/code/Magento/ImportExport/Model/Export/Entity/AbstractEntity.php @@ -11,6 +11,8 @@ use Magento\ImportExport\Model\Export\Adapter\AbstractAdapter; * Export entity abstract model * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractEntity { @@ -244,6 +246,7 @@ abstract class AbstractEntity * * @param \Magento\Eav\Model\Entity\Collection\AbstractCollection $collection * @return \Magento\Eav\Model\Entity\Collection\AbstractCollection + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _prepareEntityCollection(\Magento\Eav\Model\Entity\Collection\AbstractCollection $collection) { diff --git a/app/code/Magento/ImportExport/Model/Export/Entity/Factory.php b/app/code/Magento/ImportExport/Model/Export/Entity/Factory.php index 751da52806ae7a668c52c16c410fd3ed65dc1236..dd377a1235de87f9d564e7bf63126b6926bff615 100644 --- a/app/code/Magento/ImportExport/Model/Export/Entity/Factory.php +++ b/app/code/Magento/ImportExport/Model/Export/Entity/Factory.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Export entity factory */ diff --git a/app/code/Magento/ImportExport/Model/Import.php b/app/code/Magento/ImportExport/Model/Import.php index 743492a45e6b264cb6b1dc76b96a9e22c3691f77..69d0912b2d22e3f1716dc453b466d6a88187a5ff 100644 --- a/app/code/Magento/ImportExport/Model/Import.php +++ b/app/code/Magento/ImportExport/Model/Import.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ImportExport\Model; use Magento\Framework\App\Filesystem\DirectoryList; @@ -15,6 +18,7 @@ use Magento\Framework\HTTP\Adapter\FileTransferFactory; * * @method string getBehavior() getBehavior() * @method \Magento\ImportExport\Model\Import setEntity() setEntity(string $value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Import extends \Magento\ImportExport\Model\AbstractModel { @@ -124,6 +128,7 @@ class Import extends \Magento\ImportExport\Model\AbstractModel * @param Source\Import\Behavior\Factory $behaviorFactory * @param \Magento\Indexer\Model\IndexerRegistry $indexerRegistry * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Psr\Log\LoggerInterface $logger, diff --git a/app/code/Magento/ImportExport/Model/Import/AbstractEntity.php b/app/code/Magento/ImportExport/Model/Import/AbstractEntity.php index e52bff681c7fcb7cad69c2fe95d2a5d4e10791a1..4285ddd4224050551ab26e86dfcfb7981c0c1b03 100644 --- a/app/code/Magento/ImportExport/Model/Import/AbstractEntity.php +++ b/app/code/Magento/ImportExport/Model/Import/AbstractEntity.php @@ -8,6 +8,8 @@ namespace Magento\ImportExport\Model\Import; /** * Import entity abstract model + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractEntity { @@ -244,6 +246,7 @@ abstract class AbstractEntity * @param \Magento\ImportExport\Model\Resource\Helper $resourceHelper * @param \Magento\Framework\App\Resource $resource * @param array $data + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function __construct( \Magento\Core\Helper\Data $coreData, @@ -319,6 +322,8 @@ abstract class AbstractEntity * Validate data rows and save bunches to DB * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _saveValidatedBunches() { @@ -596,6 +601,7 @@ abstract class AbstractEntity * @param array $rowData Row data * @param int $rowNumber * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isAttributeValid($attributeCode, array $attributeParams, array $rowData, $rowNumber) { diff --git a/app/code/Magento/ImportExport/Model/Import/Entity/AbstractEav.php b/app/code/Magento/ImportExport/Model/Import/Entity/AbstractEav.php index defdbc98c945d8a7b2b25fbfbc39e1d40ba90c23..1345aa9c341d26fa3fa84c5412fc6bfa34259ca7 100644 --- a/app/code/Magento/ImportExport/Model/Import/Entity/AbstractEav.php +++ b/app/code/Magento/ImportExport/Model/Import/Entity/AbstractEav.php @@ -7,6 +7,7 @@ namespace Magento\ImportExport\Model\Import\Entity; /** * Import EAV entity abstract model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractEav extends \Magento\ImportExport\Model\Import\AbstractEntity { @@ -82,6 +83,7 @@ abstract class AbstractEav extends \Magento\ImportExport\Model\Import\AbstractEn * @param \Magento\ImportExport\Model\Export\Factory $collectionFactory * @param \Magento\Eav\Model\Config $eavConfig * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Core\Helper\Data $coreData, diff --git a/app/code/Magento/ImportExport/Model/Import/Entity/AbstractEntity.php b/app/code/Magento/ImportExport/Model/Import/Entity/AbstractEntity.php index e2b48ff43fad41fc18099a9d38e14e84b3160bae..bdb200723d9b9893a7ef5df648452b1f076a2bd5 100644 --- a/app/code/Magento/ImportExport/Model/Import/Entity/AbstractEntity.php +++ b/app/code/Magento/ImportExport/Model/Import/Entity/AbstractEntity.php @@ -9,6 +9,8 @@ use Magento\ImportExport\Model\Import\AbstractSource; /** * Import entity abstract model + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractEntity { @@ -257,6 +259,7 @@ abstract class AbstractEntity * * @param array $rowData * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _isRowScopeDefault(array $rowData) { @@ -288,6 +291,7 @@ abstract class AbstractEntity * Validate data rows and save bunches to DB. * * @return $this|void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _saveValidatedBunches() { @@ -574,6 +578,7 @@ abstract class AbstractEntity * @param array $rowData Row data * @param int $rowNum * @return boolean + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isAttributeValid($attrCode, array $attrParams, array $rowData, $rowNum) { diff --git a/app/code/Magento/ImportExport/Model/Import/Entity/Factory.php b/app/code/Magento/ImportExport/Model/Import/Entity/Factory.php index 38d3b5a1edd5fc6e5df35b7695894c52ec28df75..d07e8c13081d812397f0e52cc425cee48cb9db7e 100644 --- a/app/code/Magento/ImportExport/Model/Import/Entity/Factory.php +++ b/app/code/Magento/ImportExport/Model/Import/Entity/Factory.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Import entity factory */ diff --git a/app/code/Magento/Indexer/Model/Processor/InvalidateCache.php b/app/code/Magento/Indexer/Model/Processor/InvalidateCache.php index 233559a219a8f20555d675bc1eec12950bb80448..df397b3f720fd5cd0746dad8fd9c5ed10ed51767 100644 --- a/app/code/Magento/Indexer/Model/Processor/InvalidateCache.php +++ b/app/code/Magento/Indexer/Model/Processor/InvalidateCache.php @@ -46,6 +46,7 @@ class InvalidateCache * * @param \Magento\Indexer\Model\Processor $subject * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterUpdateMview(\Magento\Indexer\Model\Processor $subject) { diff --git a/app/code/Magento/Integration/view/adminhtml/templates/integration/tokens_exchange.phtml b/app/code/Magento/Integration/view/adminhtml/templates/integration/tokens_exchange.phtml index 0d6bf6a6041fcb92818b0ed82d563e6372309340..cfc1c7b134e7e7aaedd810f7d46d822cf09a2e69 100644 --- a/app/code/Magento/Integration/view/adminhtml/templates/integration/tokens_exchange.phtml +++ b/app/code/Magento/Integration/view/adminhtml/templates/integration/tokens_exchange.phtml @@ -7,5 +7,8 @@ * * @var \Magento\Backend\Block\Template $this */ + +// @codingStandardsIgnoreFile + ?> <div><p><?php echo __("Please setup or sign in into your 3rd party account to complete setup of this integration."); ?></p></div> diff --git a/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/filter.phtml b/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/filter.phtml index b604f334f5376ded65ca962400b719f2277a3778..b87ca94f8b4bb95605aa6c70ad3a45728b3d0a20 100644 --- a/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/filter.phtml +++ b/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/filter.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/state.phtml b/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/state.phtml index f8213d988d5aecc4d9a13db393533dac6c667957..970c7bcb9d8bc1de3c9c47828ebb4d33a9ac84b6 100644 --- a/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/state.phtml +++ b/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/state.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/view.phtml b/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/view.phtml index ba471a9a2815fd8bdae4f077417c255f666b6bf5..20e288a9115fb07e2085ea13e2076d4ff62ae762 100644 --- a/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/view.phtml +++ b/app/code/Magento/LayeredNavigation/view/frontend/templates/layer/view.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Log/Model/Aggregation.php b/app/code/Magento/Log/Model/Aggregation.php index 9fa40f6d3ad93230bc3ab1cce2f139f1f86d249c..30046eeb81353401489020c17e019ec12b862301 100644 --- a/app/code/Magento/Log/Model/Aggregation.php +++ b/app/code/Magento/Log/Model/Aggregation.php @@ -75,6 +75,7 @@ class Aggregation extends \Magento\Framework\Model\AbstractModel * * @param string $lastDate * @return null|void + * @SuppressWarnings(PHPMD.UnusedPrivateMethod) */ private function _removeEmpty($lastDate) { @@ -186,6 +187,7 @@ class Aggregation extends \Magento\Framework\Model\AbstractModel * @param int|string $in * @param null $offset * @return bool|string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ private function _date($in, $offset = null) { @@ -202,6 +204,7 @@ class Aggregation extends \Magento\Framework\Model\AbstractModel * @param int|string $in * @param null $offset * @return int + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ private function _timestamp($in, $offset = null) { diff --git a/app/code/Magento/Log/Model/Cron.php b/app/code/Magento/Log/Model/Cron.php index dcf9c7501c8ac290de1e521247cd5dbc3cc8bbe3..80396b78c15d65db02107c5660b066aa72969fa8 100644 --- a/app/code/Magento/Log/Model/Cron.php +++ b/app/code/Magento/Log/Model/Cron.php @@ -66,6 +66,7 @@ class Cron extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Log/Model/Resource/Log.php b/app/code/Magento/Log/Model/Resource/Log.php index 72e43569fc8d355ecadb8f758e0a94f427a1a0fb..a5f9996ba45631d8e930ae89197f9e1edcae9f0a 100644 --- a/app/code/Magento/Log/Model/Resource/Log.php +++ b/app/code/Magento/Log/Model/Resource/Log.php @@ -131,6 +131,7 @@ class Log extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param int $time * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _cleanCustomers($time) { diff --git a/app/code/Magento/Log/Model/Resource/Visitor/Collection.php b/app/code/Magento/Log/Model/Resource/Visitor/Collection.php index 379fabc98cedf29585c9816a4ff4d832ddeea454..a067aa6865dea50793277a9c61ea428d07e22494 100644 --- a/app/code/Magento/Log/Model/Resource/Visitor/Collection.php +++ b/app/code/Magento/Log/Model/Resource/Visitor/Collection.php @@ -173,6 +173,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac * Return true if online filter used * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsOnlineFilterUsed() { diff --git a/app/code/Magento/Log/Model/Resource/Visitor/Online.php b/app/code/Magento/Log/Model/Resource/Visitor/Online.php index 69060784d35c30c6cc3cf13432d9926e22fd1a5b..ffdfe18859e6a8d64858130694b0485f33079e16 100644 --- a/app/code/Magento/Log/Model/Resource/Visitor/Online.php +++ b/app/code/Magento/Log/Model/Resource/Visitor/Online.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Log\Model\Resource\Visitor; /** @@ -43,6 +46,7 @@ class Online extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param \Magento\Log\Model\Visitor\Online $object * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function prepare(\Magento\Log\Model\Visitor\Online $object) { diff --git a/app/code/Magento/Log/Model/Visitor.php b/app/code/Magento/Log/Model/Visitor.php index c22caad70e98e05f93d5d8db0586bafe74232d27..ddd051f7ba5c3703625e49e65ac9510caefe296c 100644 --- a/app/code/Magento/Log/Model/Visitor.php +++ b/app/code/Magento/Log/Model/Visitor.php @@ -63,6 +63,7 @@ class Visitor extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Log/view/adminhtml/templates/customer/status.phtml b/app/code/Magento/Log/view/adminhtml/templates/customer/status.phtml index d07c88fe1b38c57eee0fbd44b7f526a76e71cca8..aac139b1a3cd8932d6b7b132178d45e5f292e793 100644 --- a/app/code/Magento/Log/view/adminhtml/templates/customer/status.phtml +++ b/app/code/Magento/Log/view/adminhtml/templates/customer/status.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Template for block \Magento\Log\Block\Adminhtml\Customer\Edit\Tab\View\Status */ diff --git a/app/code/Magento/Log/view/adminhtml/templates/online.phtml b/app/code/Magento/Log/view/adminhtml/templates/online.phtml index 9228aa320afa5a3a1b7e14c79d3773991984487f..1d27f92b1d57cdd4045ec77cdb17e900c03c669d 100644 --- a/app/code/Magento/Log/view/adminhtml/templates/online.phtml +++ b/app/code/Magento/Log/view/adminhtml/templates/online.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml('grid') ?> diff --git a/app/code/Magento/Msrp/view/base/templates/product/price/msrp.phtml b/app/code/Magento/Msrp/view/base/templates/product/price/msrp.phtml index 5bd225acf1a2bd437151334646233828e1912708..e20d53d4d9d6fa36720ea4429fd432f9e48d20af 100644 --- a/app/code/Magento/Msrp/view/base/templates/product/price/msrp.phtml +++ b/app/code/Magento/Msrp/view/base/templates/product/price/msrp.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Template for displaying product price at product view page, gift registry and wish-list * diff --git a/app/code/Magento/Msrp/view/frontend/templates/popup.phtml b/app/code/Magento/Msrp/view/frontend/templates/popup.phtml index 48287e72b1d1fdec3fe70e8effad0fecde27ea10..a73e2da7bef60760adb39cc36bdd4d751a4b46f4 100644 --- a/app/code/Magento/Msrp/view/frontend/templates/popup.phtml +++ b/app/code/Magento/Msrp/view/frontend/templates/popup.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Msrp\Block\Popup $this */ diff --git a/app/code/Magento/Msrp/view/frontend/templates/render/item/price_msrp_item.phtml b/app/code/Magento/Msrp/view/frontend/templates/render/item/price_msrp_item.phtml index be002953de589539a6827aa8e961afbd05b99357..3751ec3ae109cd0ae457557ea6f46e713e3dfb87 100644 --- a/app/code/Magento/Msrp/view/frontend/templates/render/item/price_msrp_item.phtml +++ b/app/code/Magento/Msrp/view/frontend/templates/render/item/price_msrp_item.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Msrp/view/frontend/templates/render/item/price_msrp_rss.phtml b/app/code/Magento/Msrp/view/frontend/templates/render/item/price_msrp_rss.phtml index 642bda0d48756f03fa01172f37dc0706aad13fef..d3cb59434cbac9c3dda56453eed9f02d0b54c001 100644 --- a/app/code/Magento/Msrp/view/frontend/templates/render/item/price_msrp_rss.phtml +++ b/app/code/Magento/Msrp/view/frontend/templates/render/item/price_msrp_rss.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Multishipping/Block/Checkout/Overview.php b/app/code/Magento/Multishipping/Block/Checkout/Overview.php index 8687571a9980bd2a0857d1eed8f89fe852283141..21d9e51815452b76c0aed6d6d089cbb4c61650a4 100644 --- a/app/code/Magento/Multishipping/Block/Checkout/Overview.php +++ b/app/code/Magento/Multishipping/Block/Checkout/Overview.php @@ -133,6 +133,7 @@ class Overview extends \Magento\Sales\Block\Items\AbstractItems /** * @param Address $address * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getShippingAddressRate($address) { diff --git a/app/code/Magento/Multishipping/Controller/Checkout.php b/app/code/Magento/Multishipping/Controller/Checkout.php index 230c7ad46c693df099342294f41a5d1b97573b17..baa5cffd12797b2e98fde9da51c8b9a49c0fcd78 100644 --- a/app/code/Magento/Multishipping/Controller/Checkout.php +++ b/app/code/Magento/Multishipping/Controller/Checkout.php @@ -11,6 +11,7 @@ use Magento\Framework\App\RequestInterface; /** * Multishipping checkout controller + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Checkout extends \Magento\Checkout\Controller\Action implements \Magento\Checkout\Controller\Express\RedirectLoginInterface @@ -77,6 +78,8 @@ class Checkout extends \Magento\Checkout\Controller\Action implements * * @param RequestInterface $request * @return \Magento\Framework\App\ResponseInterface + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function dispatch(RequestInterface $request) { diff --git a/app/code/Magento/Multishipping/Controller/Checkout/OverviewPost.php b/app/code/Magento/Multishipping/Controller/Checkout/OverviewPost.php index bd56ac135c7f5baf8fdab2d1329b29dd15b2f478..4e9fce82bde999c519d1693f29b9a2dfc0a1e98d 100644 --- a/app/code/Magento/Multishipping/Controller/Checkout/OverviewPost.php +++ b/app/code/Magento/Multishipping/Controller/Checkout/OverviewPost.php @@ -43,6 +43,7 @@ class OverviewPost extends \Magento\Multishipping\Controller\Checkout * Overview action * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Multishipping/Helper/Data.php b/app/code/Magento/Multishipping/Helper/Data.php index 521d1cda2eb60eb9e0f47b356cf7d830531ec53c..d7458c1e1a0470bb40acb6ef00a22b9c77e9494a 100644 --- a/app/code/Magento/Multishipping/Helper/Data.php +++ b/app/code/Magento/Multishipping/Helper/Data.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Helper; /** diff --git a/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping.php b/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping.php index 50d342810398444f459099af8981fcd8dd34886b..809ec11f824c0bb52cb5b27e830e79a6b347bd08 100644 --- a/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping.php +++ b/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Model\Checkout\Type; use Magento\Customer\Api\AddressRepositoryInterface; @@ -11,6 +14,9 @@ use Magento\Sales\Model\Order\Email\Sender\OrderSender; /** * Multishipping checkout model + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Multishipping extends \Magento\Framework\Object { @@ -149,6 +155,7 @@ class Multishipping extends \Magento\Framework\Object * @param \Magento\Framework\Api\SearchCriteriaBuilder $searchCriteriaBuilder * @param \Magento\Framework\Api\FilterBuilder $filterBuilder * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Checkout\Model\Session $checkoutSession, @@ -202,6 +209,7 @@ class Multishipping extends \Magento\Framework\Object * Split virtual/not virtual items between default billing/shipping addresses * * @return \Magento\Multishipping\Model\Checkout\Type\Multishipping + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _init() { @@ -361,6 +369,8 @@ class Multishipping extends \Magento\Framework\Object * @param array $info * @return \Magento\Multishipping\Model\Checkout\Type\Multishipping * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function setShippingItemsInformation($info) { @@ -444,6 +454,8 @@ class Multishipping extends \Magento\Framework\Object * @param int $quoteItemId * @param array $data array('qty'=>$qty, 'address'=>$customerAddressId) * @return \Magento\Multishipping\Model\Checkout\Type\Multishipping + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _addShippingItem($quoteItemId, $data) { @@ -604,10 +616,10 @@ class Multishipping extends \Magento\Framework\Object if ($address->getAddressType() == 'billing') { $order->setIsVirtual(1); } else { - $order->setShippingAddress($this->quoteAddressToOrderAddress->addressToOrderAddress($address)); + $order->setShippingAddress($this->quoteAddressToOrderAddress->convert($address)); } - $order->setPayment($this->quotePaymentToOrderPayment->paymentToOrderPayment($quote->getPayment())); + $order->setPayment($this->quotePaymentToOrderPayment->convert($quote->getPayment())); if ($this->priceCurrency->round($address->getGrandTotal()) == 0) { $order->getPayment()->setMethod('free'); } @@ -622,7 +634,7 @@ class Multishipping extends \Magento\Framework\Object )->setProductOptions( $_quoteItem->getProduct()->getTypeInstance()->getOrderOptions($_quoteItem->getProduct()) ); - $orderItem = $this->quoteItemToOrderItem->itemToOrderItem($item); + $orderItem = $this->quoteItemToOrderItem->convert($_quoteItem); if ($item->getParentItem()) { $orderItem->setParentItem($order->getItemByQuoteItemId($item->getParentItem()->getId())); } diff --git a/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping/State.php b/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping/State.php index 462968de8d120b6de47e4d9114916ab472acac98..793a808e2a2ecf54d319f23c79ee780cea0305ce 100644 --- a/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping/State.php +++ b/app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping/State.php @@ -144,6 +144,7 @@ class State extends \Magento\Framework\Object * * @param string $step * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCompleteStep($step) { diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/address/select.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/address/select.phtml index 04bdd592206fffd5066c28d42d4e4925fdd7a6b2..dac5501e9d214e70855ce28d96c48b2e0216d92a 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/address/select.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/address/select.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Multishipping\Block\Checkout\Address\Select $this */ ?> <div class="multicheckout"> diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/addresses.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/addresses.phtml index 3ac80bc353af543ddb23918fa12172e29cba5935..367ae99a906472da4c47e0cf902e774eff577941 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/addresses.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/addresses.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/billing.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/billing.phtml index 3a301a4a0ed22ef4694835b038d0dc72fdeb553b..c286971abb7d5ceaf1c718d5c2964ac85f0beffc 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/billing.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/billing.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/billing/items.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/billing/items.phtml index f802304418c63d3396c154499f77143b38b7c1e3..0dd1962c34f010c95fc965cc165d804e657aaa8e 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/billing/items.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/billing/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getQuote()->hasVirtualItems()): ?> <div class="block block-other"> diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/item/default.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/item/default.phtml index b2a877b9d859d7fe2c62a2464e45f0bb82c80dde..b9b4988bcf5c8da55a5d1e7dcaa92722f2a92d3b 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/item/default.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/item/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <strong class="product name product-item-name"><a href="<?php echo $this->getProductUrl() ?>"><?php echo $this->escapeHtml($this->getProductName()) ?></a></strong> <?php if ($_options = $this->getOptionList()): ?> diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/link.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/link.phtml index f225bbca3a9a415e64a9df136095d51310ace0dc..cc1f8ff73222abe5f393a046b9c8c073eb1323cc 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/link.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/link.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <a class="action multicheckout" href="<?php echo $this->getCheckoutUrl()?>" title="<?php echo __('Checkout with Multiple Addresses');?>"><span><?php echo __('Checkout with Multiple Addresses');?></span></a> diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/overview.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/overview.phtml index 79b0fb5b282c3333b8a6d08b934a28dd2c9dd9a5..64358eb5197713f61be652ad1a99e8f9e0efb8c3 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/overview.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/overview.phtml @@ -3,8 +3,11 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> -<form action="<?php echo $this->getPostActionUrl() ?>" method="post" id="review-order-form" data-mage-init='{"orderOverview": {}}' class="form multicheckout order-review"> +<form action="<?php echo $this->getPostActionUrl() ?>" method="post" id="review-order-form" data-mage-init='{"orderOverview": {}, "validation":{}}' class="form multicheckout order-review"> <?php echo $this->getBlockHtml('formkey'); ?> <div class="block block-billing"> <div class="block-title"><strong><?php echo __('Billing Information') ?></strong></div> diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/overview/item.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/overview/item.phtml index 5dd56e7b200318d4b60527a1bca4cce39da03927..c2e07722eccc543f06b36d3f284593707c5679ad 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/overview/item.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/overview/item.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/shipping.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/shipping.phtml index bf788a1793236c776889c2694ff44e713a326806..c58c8f5efd3d51fbb2c002d0469bc37694f3dc00 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/shipping.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/shipping.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/state.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/state.phtml index 9788426ab3b8afb91524de3654870b6127effb91..e71b701338f20fc4a65e744c3eb36fb6c7623a53 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/state.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/state.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Multishipping/view/frontend/templates/checkout/success.phtml b/app/code/Magento/Multishipping/view/frontend/templates/checkout/success.phtml index ba9b64fa1e8ff4d5915fe325ead214075c603e43..f0e0d9512e113afbdb89c0c28864a804f912384c 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/checkout/success.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/checkout/success.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="multicheckout success"> <h2 class="subtitle"><?php echo __('Thank you for your purchase!') ?></h2> diff --git a/app/code/Magento/Multishipping/view/frontend/templates/js/components.phtml b/app/code/Magento/Multishipping/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Multishipping/view/frontend/templates/multishipping/item/default.phtml b/app/code/Magento/Multishipping/view/frontend/templates/multishipping/item/default.phtml index 8f9c7c23cf2d39317bd12d2f3a8b1c0341c70a35..bafd229b4d6ba455b26eb6c5d43cbb1a5e8686b5 100644 --- a/app/code/Magento/Multishipping/view/frontend/templates/multishipping/item/default.phtml +++ b/app/code/Magento/Multishipping/view/frontend/templates/multishipping/item/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="product details"> <strong class="product name"><a href="<?php echo $this->getProductUrl() ?>"><?php echo $this->escapeHtml($this->getProductName()) ?></a></strong> diff --git a/app/code/Magento/Newsletter/Block/Adminhtml/Problem.php b/app/code/Magento/Newsletter/Block/Adminhtml/Problem.php index cad43065e2dbc6d2f3485b26ee5a8d45eb626f63..c3ae83df04bcea5d47684129144a8670a51af796 100644 --- a/app/code/Magento/Newsletter/Block/Adminhtml/Problem.php +++ b/app/code/Magento/Newsletter/Block/Adminhtml/Problem.php @@ -40,6 +40,7 @@ class Problem extends \Magento\Backend\Block\Template /** * @return void + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _construct() { @@ -101,6 +102,7 @@ class Problem extends \Magento\Backend\Block\Template * Return true if the size is greater than 0 * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getShowButtons() { diff --git a/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Edit.php b/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Edit.php index 6ef487bb2bab83ac5e2685fb09ff737981f2fd24..271ae2c7c6635a82217e8a47b6936cb4f9cb2f29 100644 --- a/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Edit.php +++ b/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Edit.php @@ -218,6 +218,7 @@ class Edit extends \Magento\Backend\Block\Template * Getter for availability preview mode * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsPreview() { @@ -241,6 +242,7 @@ class Edit extends \Magento\Backend\Block\Template * Getter for id of current store (the only one in single-store mode and current in multi-stores mode) * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ protected function getStoreId() { @@ -251,6 +253,7 @@ class Edit extends \Magento\Backend\Block\Template * Getter for check is this newsletter the plain text. * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsTextType() { @@ -261,6 +264,7 @@ class Edit extends \Magento\Backend\Block\Template * Getter for availability resume action * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCanResume() { @@ -271,6 +275,7 @@ class Edit extends \Magento\Backend\Block\Template * Getter for header text * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getHeaderText() { diff --git a/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Edit/Form.php b/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Edit/Form.php index 716d3272bc449092e3e56f69a35ab48af4262a64..7675ac57c9a7104c31a23ad4eef0006eaccbbefe 100644 --- a/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Edit/Form.php +++ b/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Edit/Form.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Newsletter\Block\Adminhtml\Queue\Edit; /** @@ -57,6 +60,9 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * or from newsletter queue grid by edit option. * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Preview/Form.php b/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Preview/Form.php index 936ab42d14178c2308b1e196e504371402b44c43..c6b88dfe2eafbefd4f2b08e6b539662d83b58b22 100644 --- a/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Preview/Form.php +++ b/app/code/Magento/Newsletter/Block/Adminhtml/Queue/Preview/Form.php @@ -17,6 +17,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * Preparing from for revision page * * @return \Magento\Backend\Block\Widget\Form + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _prepareForm() { diff --git a/app/code/Magento/Newsletter/Block/Adminhtml/Template/Edit.php b/app/code/Magento/Newsletter/Block/Adminhtml/Template/Edit.php index 5ff6b98580345bd7043c75eb3952a7e267d1ca95..52641dcdc49fd239243a59d5a89c6dc6a02a27f5 100644 --- a/app/code/Magento/Newsletter/Block/Adminhtml/Template/Edit.php +++ b/app/code/Magento/Newsletter/Block/Adminhtml/Template/Edit.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Newsletter Template Edit Block * @@ -56,6 +58,7 @@ class Edit extends \Magento\Backend\Block\Widget * Preparing block layout * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareLayout() { @@ -171,6 +174,7 @@ class Edit extends \Magento\Backend\Block\Widget * Return edit flag for block * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getEditMode() { @@ -278,6 +282,7 @@ class Edit extends \Magento\Backend\Block\Widget * Getter for id of current store (the only one in single-store mode and current in multi-stores mode) * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ protected function getStoreId() { diff --git a/app/code/Magento/Newsletter/Block/Adminhtml/Template/Edit/Form.php b/app/code/Magento/Newsletter/Block/Adminhtml/Template/Edit/Form.php index fe3d2e7e12bdf84b08b2c41db4ad0a9abeaa45ad..18de6a18d03c5ebeb6e6079bda4bf10fa9b7e9e7 100644 --- a/app/code/Magento/Newsletter/Block/Adminhtml/Template/Edit/Form.php +++ b/app/code/Magento/Newsletter/Block/Adminhtml/Template/Edit/Form.php @@ -50,6 +50,8 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * Prepare form before rendering HTML * * @return $this + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Newsletter/Block/Adminhtml/Template/Preview/Form.php b/app/code/Magento/Newsletter/Block/Adminhtml/Template/Preview/Form.php index ff54609427df62940a8d140001078d687a1be9a1..b88a7309a7282d724004dcc1a525dead6117af25 100644 --- a/app/code/Magento/Newsletter/Block/Adminhtml/Template/Preview/Form.php +++ b/app/code/Magento/Newsletter/Block/Adminhtml/Template/Preview/Form.php @@ -17,6 +17,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * Preparing from for revision page * * @return \Magento\Backend\Block\Widget\Form + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _prepareForm() { diff --git a/app/code/Magento/Newsletter/Controller/Adminhtml/Queue/Save.php b/app/code/Magento/Newsletter/Controller/Adminhtml/Queue/Save.php index 0da1c89d1c6b835aa189bf4b7198067b2e569ae0..8bcc262340cc5d620447cbbc679e403de312620f 100644 --- a/app/code/Magento/Newsletter/Controller/Adminhtml/Queue/Save.php +++ b/app/code/Magento/Newsletter/Controller/Adminhtml/Queue/Save.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Newsletter\Controller\Adminhtml\Queue; class Save extends \Magento\Newsletter\Controller\Adminhtml\Queue @@ -13,6 +16,7 @@ class Save extends \Magento\Newsletter\Controller\Adminhtml\Queue * * @throws \Magento\Framework\Model\Exception * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Newsletter/Model/Queue.php b/app/code/Magento/Newsletter/Model/Queue.php index 85b50fa153d49d3d1f3796adf69afb657661052c..72239c7dcfabd57bc466a3773e292e719169dfbf 100644 --- a/app/code/Magento/Newsletter/Model/Queue.php +++ b/app/code/Magento/Newsletter/Model/Queue.php @@ -31,6 +31,7 @@ namespace Magento\Newsletter\Model; * @method string getQueueFinishAt() * @method \Magento\Newsletter\Model\Queue setQueueFinishAt(string $value) * @SuppressWarnings(PHPMD.LongVariable) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Queue extends \Magento\Email\Model\AbstractTemplate { @@ -124,6 +125,7 @@ class Queue extends \Magento\Email\Model\AbstractTemplate * @param \Magento\Newsletter\Model\Resource\Subscriber\CollectionFactory $subscriberCollectionFactory * @param \Magento\Newsletter\Model\Queue\TransportBuilder $transportBuilder * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -196,6 +198,7 @@ class Queue extends \Magento\Email\Model\AbstractTemplate * * @param int $count * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function sendPerSubscriber($count = 20) { @@ -320,6 +323,7 @@ class Queue extends \Magento\Email\Model\AbstractTemplate * Getter for save stores flag. * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getSaveStoresFlag() { diff --git a/app/code/Magento/Newsletter/Model/Resource/Grid/Collection.php b/app/code/Magento/Newsletter/Model/Resource/Grid/Collection.php index 8ddac79f305ae15f7eb452b7ae004ee718ea720b..0de676b32e8cd6b8d79016a445897f8892c678aa 100644 --- a/app/code/Magento/Newsletter/Model/Resource/Grid/Collection.php +++ b/app/code/Magento/Newsletter/Model/Resource/Grid/Collection.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Newsletter problems collection * diff --git a/app/code/Magento/Newsletter/Model/Resource/Subscriber/Collection.php b/app/code/Magento/Newsletter/Model/Resource/Subscriber/Collection.php index 04c57f977d4891fe1555b432c90aeb9ead5d39ea..9c3afee8b9da91dcd1c112a6f0b57143d5b4b6d9 100644 --- a/app/code/Magento/Newsletter/Model/Resource/Subscriber/Collection.php +++ b/app/code/Magento/Newsletter/Model/Resource/Subscriber/Collection.php @@ -264,6 +264,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac * Get queue joined flag * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getQueueJoinedFlag() { diff --git a/app/code/Magento/Newsletter/Model/Resource/Template.php b/app/code/Magento/Newsletter/Model/Resource/Template.php index 9fea41a14401409ed28f4e7721533d76f13f4e65..9ca3e1351e2942367fc4eb35e05db427bc647732 100644 --- a/app/code/Magento/Newsletter/Model/Resource/Template.php +++ b/app/code/Magento/Newsletter/Model/Resource/Template.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Newsletter\Model\Resource; /** diff --git a/app/code/Magento/Newsletter/Model/Subscriber.php b/app/code/Magento/Newsletter/Model/Subscriber.php index bbc21a7dcc9ebb32da57d17f6e263bdc2aa2528c..a201e88646585247aa7deb2860f5419c94a5cd32 100644 --- a/app/code/Magento/Newsletter/Model/Subscriber.php +++ b/app/code/Magento/Newsletter/Model/Subscriber.php @@ -136,6 +136,7 @@ class Subscriber extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Newsletter/Model/Template.php b/app/code/Magento/Newsletter/Model/Template.php index 46f0270e193b49931f9dafc7b2534d3d4c023b78..4ff5e4d526c661f2cad580ffdf468e27c121da3a 100644 --- a/app/code/Magento/Newsletter/Model/Template.php +++ b/app/code/Magento/Newsletter/Model/Template.php @@ -32,6 +32,7 @@ namespace Magento\Newsletter\Model; * @method \Magento\Newsletter\Model\Template setModifiedAt(string $value) * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Template extends \Magento\Email\Model\AbstractTemplate { @@ -101,6 +102,7 @@ class Template extends \Magento\Email\Model\AbstractTemplate * @param \Magento\Newsletter\Model\TemplateFactory $templateFactory * @param \Magento\Framework\Filter\FilterManager $filterManager * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -217,6 +219,7 @@ class Template extends \Magento\Email\Model\AbstractTemplate * Check Template Text Preprocessed * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getTemplateTextPreprocessed() { diff --git a/app/code/Magento/Newsletter/view/adminhtml/templates/preview/iframeswitcher.phtml b/app/code/Magento/Newsletter/view/adminhtml/templates/preview/iframeswitcher.phtml index cbff054dd92fe898593dd9b954794686bb4fbc27..cf09d83f1df88cfaeb3d991ba09c4f30ff5fe579 100644 --- a/app/code/Magento/Newsletter/view/adminhtml/templates/preview/iframeswitcher.phtml +++ b/app/code/Magento/Newsletter/view/adminhtml/templates/preview/iframeswitcher.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div id="preview" class="cms-revision-preview"> <div class="toolbar"> diff --git a/app/code/Magento/Newsletter/view/adminhtml/templates/preview/store.phtml b/app/code/Magento/Newsletter/view/adminhtml/templates/preview/store.phtml index 935cce22196302ce3d7349a2903734f207704544..b9c42dfe7a2bc86d6c4d95673bbe8804a852a8ab 100644 --- a/app/code/Magento/Newsletter/view/adminhtml/templates/preview/store.phtml +++ b/app/code/Magento/Newsletter/view/adminhtml/templates/preview/store.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($websites = $this->getWebsites()): ?> diff --git a/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml b/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml index bffcc4a783b0be12049771745b6ef3b5fab51693..fb872704914cc35329afc00a4d3ef94103874dfd 100644 --- a/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml +++ b/app/code/Magento/Newsletter/view/adminhtml/templates/problem/list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml('grid') ?> diff --git a/app/code/Magento/Newsletter/view/adminhtml/templates/queue/edit.phtml b/app/code/Magento/Newsletter/view/adminhtml/templates/queue/edit.phtml index 57aa808cb7bfd3642ecd5f7035f5f5f6dc6693f4..bfb2eb9c81c064a57b703612312098eb584097b1 100644 --- a/app/code/Magento/Newsletter/view/adminhtml/templates/queue/edit.phtml +++ b/app/code/Magento/Newsletter/view/adminhtml/templates/queue/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Newsletter\Block\Adminhtml\Queue\Edit */ ?> <div class="page-actions"> diff --git a/app/code/Magento/Newsletter/view/adminhtml/templates/queue/list.phtml b/app/code/Magento/Newsletter/view/adminhtml/templates/queue/list.phtml index c1e2599f8e5d8fe14d88a0161ce8a871470a7b97..edc99139da10c27628a4141d12e176be722a7ae1 100644 --- a/app/code/Magento/Newsletter/view/adminhtml/templates/queue/list.phtml +++ b/app/code/Magento/Newsletter/view/adminhtml/templates/queue/list.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml('grid'); ?> diff --git a/app/code/Magento/Newsletter/view/adminhtml/templates/subscriber/list.phtml b/app/code/Magento/Newsletter/view/adminhtml/templates/subscriber/list.phtml index 2dc5299ef588a3aa8a76964acc6d4b1c4a87e990..dc0936b43a3de087faa0c5159be962cdb24ed0d6 100644 --- a/app/code/Magento/Newsletter/view/adminhtml/templates/subscriber/list.phtml +++ b/app/code/Magento/Newsletter/view/adminhtml/templates/subscriber/list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml('grid') ?> <?php if (count($this->getQueueAsOptions())>0 && $this->getShowQueueAdd()): ?> diff --git a/app/code/Magento/Newsletter/view/adminhtml/templates/template/edit.phtml b/app/code/Magento/Newsletter/view/adminhtml/templates/template/edit.phtml index 283620035a7570bcdc29999f4c826f0b855bab46..f4d7f8f1d5a14bc64c21f8f3decd727002347c4d 100644 --- a/app/code/Magento/Newsletter/view/adminhtml/templates/template/edit.phtml +++ b/app/code/Magento/Newsletter/view/adminhtml/templates/template/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Newsletter\Block\Adminhtml\Template\Edit */ ?> <form action="<?php echo $this->getSaveUrl() ?>" method="post" id="newsletter_template_edit_form"> diff --git a/app/code/Magento/Newsletter/view/adminhtml/templates/template/list.phtml b/app/code/Magento/Newsletter/view/adminhtml/templates/template/list.phtml index 9228aa320afa5a3a1b7e14c79d3773991984487f..1d27f92b1d57cdd4045ec77cdb17e900c03c669d 100644 --- a/app/code/Magento/Newsletter/view/adminhtml/templates/template/list.phtml +++ b/app/code/Magento/Newsletter/view/adminhtml/templates/template/list.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml('grid') ?> diff --git a/app/code/Magento/Newsletter/view/frontend/templates/js/components.phtml b/app/code/Magento/Newsletter/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Newsletter/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Newsletter/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Newsletter/view/frontend/templates/subscribe.phtml b/app/code/Magento/Newsletter/view/frontend/templates/subscribe.phtml index d3134fd7eb4ced6e1780239a7beecea39979de21..b98b69a605794e4836b217d7cb9660d1ef0f4e1a 100644 --- a/app/code/Magento/Newsletter/view/frontend/templates/subscribe.phtml +++ b/app/code/Magento/Newsletter/view/frontend/templates/subscribe.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="block newsletter"> <div class="title"><strong>Newsletter</strong></div> diff --git a/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/banktransfer.phtml b/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/banktransfer.phtml index 1614526442054e579a736d55704928c29903a232..00c2561926980aa38e5eaa3bd63996707b0d1611 100644 --- a/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/banktransfer.phtml +++ b/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/banktransfer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($instructions = $this->getInstructions()): ?> <ul class="form-list checkout-agreements" id="payment_form_<?php echo $this->getMethodCode() ?>" style="display:none;"> diff --git a/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/cashondelivery.phtml b/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/cashondelivery.phtml index 0a5c26ad023bceae16049d1cb103fb6dd4362c43..7ff8963cc97da2b0053375a6586b716ff5328ac8 100644 --- a/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/cashondelivery.phtml +++ b/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/cashondelivery.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @var $this \Magento\OfflinePayments\Block\Form\Cashondelivery */ diff --git a/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/checkmo.phtml b/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/checkmo.phtml index b7f61d6302315b76676d37b466c6ecd66d123cca..f8173386f3e8f0bceb76d1009fde8576970d8166 100644 --- a/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/checkmo.phtml +++ b/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/checkmo.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <fieldset class="fieldset payment method" id="payment_form_<?php echo $this->getMethodCode() ?>" style="display:none"> <?php if ($this->getMethod()->getPayableTo()): ?> diff --git a/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/purchaseorder.phtml b/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/purchaseorder.phtml index f4cebb6ed674bfcde647badcf8e2817e1b142463..4996b06a724b2c6cad2e17dc6b5b3ddf8fe1588f 100644 --- a/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/purchaseorder.phtml +++ b/app/code/Magento/OfflinePayments/view/adminhtml/templates/form/purchaseorder.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <fieldset class="fieldset payment method" id="payment_form_<?php echo $this->getMethodCode() ?>" style="display:none"> <div class="field field-number required"> diff --git a/app/code/Magento/OfflinePayments/view/adminhtml/templates/info/checkmo.phtml b/app/code/Magento/OfflinePayments/view/adminhtml/templates/info/checkmo.phtml index fbfb425f02e518e31b82f7bf7c5231568430f653..7fba0d299840c717df6c17b711e9a88405f4a629 100644 --- a/app/code/Magento/OfflinePayments/view/adminhtml/templates/info/checkmo.phtml +++ b/app/code/Magento/OfflinePayments/view/adminhtml/templates/info/checkmo.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->escapeHtml($this->getMethod()->getTitle()) ?> <?php if ($this->getInfo()->getAdditionalData()): ?> diff --git a/app/code/Magento/OfflinePayments/view/adminhtml/templates/info/pdf/checkmo.phtml b/app/code/Magento/OfflinePayments/view/adminhtml/templates/info/pdf/checkmo.phtml index d89c99066fa6a523cd9a76a5e89ad5a777eb0dfa..ab8c7e3d74d597b669886117a1c5e05053d15d71 100644 --- a/app/code/Magento/OfflinePayments/view/adminhtml/templates/info/pdf/checkmo.phtml +++ b/app/code/Magento/OfflinePayments/view/adminhtml/templates/info/pdf/checkmo.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->escapeHtml($this->getMethod()->getTitle()) ?> {{pdf_row_separator}} diff --git a/app/code/Magento/OfflinePayments/view/frontend/templates/form/banktransfer.phtml b/app/code/Magento/OfflinePayments/view/frontend/templates/form/banktransfer.phtml index fb12d3bb982f9e3c5d7f7032077dc28b7f20d591..c1e8d9c0a5625fc662c349b33621f0070862bd68 100644 --- a/app/code/Magento/OfflinePayments/view/frontend/templates/form/banktransfer.phtml +++ b/app/code/Magento/OfflinePayments/view/frontend/templates/form/banktransfer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($instructions = $this->getInstructions()): ?> <div class="items <?php echo $this->getMethodCode() ?> instructions agreement content" id="payment_form_<?php echo $this->getMethodCode() ?>" style="display: none;"> diff --git a/app/code/Magento/OfflinePayments/view/frontend/templates/form/cashondelivery.phtml b/app/code/Magento/OfflinePayments/view/frontend/templates/form/cashondelivery.phtml index 8d608055fa9468c19920eed7d6383d6d739088f4..0f6277e6868e8b257eb18363716baa0e3ddf2091 100644 --- a/app/code/Magento/OfflinePayments/view/frontend/templates/form/cashondelivery.phtml +++ b/app/code/Magento/OfflinePayments/view/frontend/templates/form/cashondelivery.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @see \Magento\OfflinePayments\Block\Form\Cashondelivery */ diff --git a/app/code/Magento/OfflinePayments/view/frontend/templates/form/checkmo.phtml b/app/code/Magento/OfflinePayments/view/frontend/templates/form/checkmo.phtml index c012151c31a36dfd260924629e9771e3e4df8be7..4fcebe8885965b94d6b2238cea15e962b5e2daaa 100644 --- a/app/code/Magento/OfflinePayments/view/frontend/templates/form/checkmo.phtml +++ b/app/code/Magento/OfflinePayments/view/frontend/templates/form/checkmo.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getMethod()->getMailingAddress() || $this->getMethod()->getPayableTo()): ?> <dl class="items check payable" id="payment_form_<?php echo $this->getMethodCode() ?>" style="display:none;"> diff --git a/app/code/Magento/OfflinePayments/view/frontend/templates/form/purchaseorder.phtml b/app/code/Magento/OfflinePayments/view/frontend/templates/form/purchaseorder.phtml index 050b7b7d07cff9b6e87623e85fb469c7d4a6a076..905181a1274f9611c33ca73262d83961803c399e 100644 --- a/app/code/Magento/OfflinePayments/view/frontend/templates/form/purchaseorder.phtml +++ b/app/code/Magento/OfflinePayments/view/frontend/templates/form/purchaseorder.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <fieldset class="fieldset items <?php echo $this->getMethodCode() ?>" id="payment_form_<?php echo $this->getMethodCode() ?>" style="display: none"> <div class="field number required"> diff --git a/app/code/Magento/OfflinePayments/view/frontend/templates/info/checkmo.phtml b/app/code/Magento/OfflinePayments/view/frontend/templates/info/checkmo.phtml index daf65b7812a03d5a2337e3779e42e35f7334428d..c482883c6e0ed4743df973c91b85f94474717157 100644 --- a/app/code/Magento/OfflinePayments/view/frontend/templates/info/checkmo.phtml +++ b/app/code/Magento/OfflinePayments/view/frontend/templates/info/checkmo.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <dl class="payment-method checkmemo"> <dt class="title"><?php echo $this->escapeHtml($this->getMethod()->getTitle()) ?></dt> diff --git a/app/code/Magento/OfflineShipping/Model/Carrier/Flatrate.php b/app/code/Magento/OfflineShipping/Model/Carrier/Flatrate.php index ac4774ea204eb8e3d2be3fffce1c2e11e62ce411..ff96421b77034d67dc4cf1cb6ab6c4d83077d3ad 100644 --- a/app/code/Magento/OfflineShipping/Model/Carrier/Flatrate.php +++ b/app/code/Magento/OfflineShipping/Model/Carrier/Flatrate.php @@ -57,6 +57,8 @@ class Flatrate extends \Magento\Shipping\Model\Carrier\AbstractCarrier implement /** * @param \Magento\Quote\Model\Quote\Address\RateRequest $request * @return Result|bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function collectRates(\Magento\Quote\Model\Quote\Address\RateRequest $request) { diff --git a/app/code/Magento/OfflineShipping/Model/Carrier/Pickup.php b/app/code/Magento/OfflineShipping/Model/Carrier/Pickup.php index 01db8ac139cd048c531e97a3181fe0e25c1640cd..e1411217d1d5d1b96dae3cfd82ee4ba78047b4b1 100644 --- a/app/code/Magento/OfflineShipping/Model/Carrier/Pickup.php +++ b/app/code/Magento/OfflineShipping/Model/Carrier/Pickup.php @@ -52,6 +52,7 @@ class Pickup extends \Magento\Shipping\Model\Carrier\AbstractCarrier implements /** * @param \Magento\Quote\Model\Quote\Address\RateRequest $request * @return \Magento\Shipping\Model\Rate\Result + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function collectRates(\Magento\Quote\Model\Quote\Address\RateRequest $request) { diff --git a/app/code/Magento/OfflineShipping/Model/Carrier/Tablerate.php b/app/code/Magento/OfflineShipping/Model/Carrier/Tablerate.php index 58f439930efee892e67e7456e37a8a4d80aed2b0..4456feee0578c38c56347f4ec2f474d5d5d765fa 100644 --- a/app/code/Magento/OfflineShipping/Model/Carrier/Tablerate.php +++ b/app/code/Magento/OfflineShipping/Model/Carrier/Tablerate.php @@ -51,6 +51,7 @@ class Tablerate extends \Magento\Shipping\Model\Carrier\AbstractCarrier implemen * @param \Magento\Quote\Model\Quote\Address\RateResult\MethodFactory $resultMethodFactory * @param \Magento\OfflineShipping\Model\Resource\Carrier\TablerateFactory $tablerateFactory * @param array $data + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function __construct( \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, @@ -73,6 +74,9 @@ class Tablerate extends \Magento\Shipping\Model\Carrier\AbstractCarrier implemen /** * @param \Magento\Quote\Model\Quote\Address\RateRequest $request * @return \Magento\Shipping\Model\Rate\Result + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function collectRates(\Magento\Quote\Model\Quote\Address\RateRequest $request) { diff --git a/app/code/Magento/OfflineShipping/Model/Plugin/Checkout/Block/Cart/Shipping.php b/app/code/Magento/OfflineShipping/Model/Plugin/Checkout/Block/Cart/Shipping.php index 6247a343565f386fa8d6b7833a1f864463f69a42..b3bc246030b9386d471eb0819511a097e7edb208 100644 --- a/app/code/Magento/OfflineShipping/Model/Plugin/Checkout/Block/Cart/Shipping.php +++ b/app/code/Magento/OfflineShipping/Model/Plugin/Checkout/Block/Cart/Shipping.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Checkout cart shipping block plugin * diff --git a/app/code/Magento/OfflineShipping/Model/Quote/Freeshipping.php b/app/code/Magento/OfflineShipping/Model/Quote/Freeshipping.php index 44943d1d9935663ebaf3f94409fea48dab54d7e0..efe7c7f63f4062d051244b81ce6fc64f12953ebc 100644 --- a/app/code/Magento/OfflineShipping/Model/Quote/Freeshipping.php +++ b/app/code/Magento/OfflineShipping/Model/Quote/Freeshipping.php @@ -39,6 +39,7 @@ class Freeshipping extends \Magento\Quote\Model\Quote\Address\Total\AbstractTota * * @param \Magento\Quote\Model\Quote\Address $address * @return \Magento\OfflineShipping\Model\Quote\Freeshipping + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function collect(Address $address) { @@ -93,6 +94,7 @@ class Freeshipping extends \Magento\Quote\Model\Quote\Address\Total\AbstractTota * * @param \Magento\Quote\Model\Quote\Address $address * @return \Magento\OfflineShipping\Model\Quote\Freeshipping + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function fetch(Address $address) { diff --git a/app/code/Magento/OfflineShipping/Model/Resource/Carrier/Tablerate.php b/app/code/Magento/OfflineShipping/Model/Resource/Carrier/Tablerate.php index 9c58cfb9196f020e9be2ca461b45aa345ede990b..23985af45cddcce41807863f3aa01f40b40dfb14 100644 --- a/app/code/Magento/OfflineShipping/Model/Resource/Carrier/Tablerate.php +++ b/app/code/Magento/OfflineShipping/Model/Resource/Carrier/Tablerate.php @@ -14,6 +14,10 @@ namespace Magento\OfflineShipping\Model\Resource\Carrier; use Magento\Framework\Filesystem; use Magento\Framework\Filesystem\DirectoryList; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Tablerate extends \Magento\Framework\Model\Resource\Db\AbstractDb { /** @@ -241,6 +245,8 @@ class Tablerate extends \Magento\Framework\Model\Resource\Db\AbstractDb * @return \Magento\OfflineShipping\Model\Resource\Carrier\Tablerate * @todo: this method should be refactored as soon as updated design will be provided * @see https://wiki.corp.x.com/display/MCOMS/Magento+Filesystem+Decisions + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function uploadAndImport(\Magento\Framework\Object $object) { @@ -403,6 +409,8 @@ class Tablerate extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param array $row * @param int $rowNumber * @return array|false + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getImportRow($row, $rowNumber = 0) { diff --git a/app/code/Magento/PageCache/Model/App/FrontController/BuiltinPlugin.php b/app/code/Magento/PageCache/Model/App/FrontController/BuiltinPlugin.php index 50fb8210de847b77a69fe3fca838c7cd98b7c62f..83b9140a6c6adc3f34b02ceabb225eac10221316 100644 --- a/app/code/Magento/PageCache/Model/App/FrontController/BuiltinPlugin.php +++ b/app/code/Magento/PageCache/Model/App/FrontController/BuiltinPlugin.php @@ -57,6 +57,7 @@ class BuiltinPlugin * @param callable $proceed * @param \Magento\Framework\App\RequestInterface $request * @return \Magento\Framework\Controller\ResultInterface|\Magento\Framework\App\Response\Http + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aroundDispatch( \Magento\Framework\App\FrontControllerInterface $subject, diff --git a/app/code/Magento/PageCache/Model/App/FrontController/VarnishPlugin.php b/app/code/Magento/PageCache/Model/App/FrontController/VarnishPlugin.php index 99ed432631319828421421921d74add7edf5520a..da41b208c7859b4081ee2ac8d50ae227580cabee 100644 --- a/app/code/Magento/PageCache/Model/App/FrontController/VarnishPlugin.php +++ b/app/code/Magento/PageCache/Model/App/FrontController/VarnishPlugin.php @@ -45,6 +45,7 @@ class VarnishPlugin * @param callable $proceed * @param \Magento\Framework\App\RequestInterface $request * @return false|\Magento\Framework\App\Response\Http|\Magento\Framework\Controller\ResultInterface + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aroundDispatch( \Magento\Framework\App\FrontControllerInterface $subject, diff --git a/app/code/Magento/PageCache/Model/Controller/Result/BuiltinPlugin.php b/app/code/Magento/PageCache/Model/Controller/Result/BuiltinPlugin.php index 554d300c2a9996d3815675d59175058c9db31ac2..a9d3bbaaa6e89309eb151c44d7474622b29bce3f 100644 --- a/app/code/Magento/PageCache/Model/Controller/Result/BuiltinPlugin.php +++ b/app/code/Magento/PageCache/Model/Controller/Result/BuiltinPlugin.php @@ -57,6 +57,7 @@ class BuiltinPlugin * @param callable $proceed * @param ResponseHttp $response * @return \Magento\Framework\Controller\ResultInterface + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aroundRenderResult( \Magento\Framework\Controller\ResultInterface $subject, diff --git a/app/code/Magento/PageCache/view/frontend/templates/js/components.phtml b/app/code/Magento/PageCache/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/PageCache/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/PageCache/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Payment/Block/Form/Cc.php b/app/code/Magento/Payment/Block/Form/Cc.php index e6ae5c10e030493187d089d8d7d285376c065077..494e76a7a7580eba2cbdb06aaa66526f33c29cab 100644 --- a/app/code/Magento/Payment/Block/Form/Cc.php +++ b/app/code/Magento/Payment/Block/Form/Cc.php @@ -37,6 +37,7 @@ class Cc extends \Magento\Payment\Block\Form * Retrieve availables credit card types * * @return array + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getCcAvailableTypes() { diff --git a/app/code/Magento/Payment/Block/Info.php b/app/code/Magento/Payment/Block/Info.php index bb1ecc9dec5b1f4b8efbe76efe96e571268e01d9..533acfaaf234635529a3b42d1a55cfb35ab8565a 100644 --- a/app/code/Magento/Payment/Block/Info.php +++ b/app/code/Magento/Payment/Block/Info.php @@ -114,6 +114,7 @@ class Info extends \Magento\Framework\View\Element\Template * false => full information may be shown * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsSecureMode() { diff --git a/app/code/Magento/Payment/Helper/Data.php b/app/code/Magento/Payment/Helper/Data.php index 2cdabe15c30e0d38260f48a737e84a88fad9e3bc..6f77f919472e893a745e1ae516f3c7dc88e90cac 100644 --- a/app/code/Magento/Payment/Helper/Data.php +++ b/app/code/Magento/Payment/Helper/Data.php @@ -18,6 +18,7 @@ use Magento\Payment\Model\MethodInterface; /** * Payment module base helper + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Data extends \Magento\Framework\App\Helper\AbstractHelper { @@ -265,6 +266,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * @param bool $withGroups * @param Store|null $store * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getPaymentMethodList($sorted = true, $asLabelValue = false, $withGroups = false, $store = null) { diff --git a/app/code/Magento/Payment/Model/Method/AbstractMethod.php b/app/code/Magento/Payment/Model/Method/AbstractMethod.php index 6774295014abb326ea1e5e6f9281e6a373421ddb..ca6dd62a7c5856d84d6706e77910e093cbdc7046 100644 --- a/app/code/Magento/Payment/Model/Method/AbstractMethod.php +++ b/app/code/Magento/Payment/Model/Method/AbstractMethod.php @@ -3,18 +3,28 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Payment\Model\Method; use Magento\Payment\Model\Checks\PaymentMethodChecksInterface; use Magento\Payment\Model\MethodInterface; use Magento\Sales\Model\Order\Invoice; use Magento\Sales\Model\Order\Payment; +use Magento\Quote\Api\Data\PaymentMethodInterface; /** * Payment method abstract model * @method AbstractMethod setStore() + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ -abstract class AbstractMethod extends \Magento\Framework\Object implements MethodInterface, PaymentMethodChecksInterface +abstract class AbstractMethod extends \Magento\Framework\Model\AbstractExtensibleModel implements + MethodInterface, + PaymentMethodChecksInterface, + PaymentMethodInterface { const ACTION_ORDER = 'order'; @@ -210,24 +220,40 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho protected $logger; /** - * @param \Magento\Framework\Event\ManagerInterface $eventManager + * @param \Magento\Framework\Model\Context $context + * @param \Magento\Framework\Registry $registry + * @param \Magento\Framework\Api\MetadataServiceInterface $metadataService + * @param \Magento\Framework\Api\AttributeDataBuilder $customAttributeBuilder * @param \Magento\Payment\Helper\Data $paymentData * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig - * @param \Psr\Log\LoggerInterface $logger + * @param \Magento\Framework\Model\Resource\AbstractResource $resource + * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data */ public function __construct( - \Magento\Framework\Event\ManagerInterface $eventManager, + \Magento\Framework\Model\Context $context, + \Magento\Framework\Registry $registry, + \Magento\Framework\Api\MetadataServiceInterface $metadataService, + \Magento\Framework\Api\AttributeDataBuilder $customAttributeBuilder, \Magento\Payment\Helper\Data $paymentData, \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, - \Psr\Log\LoggerInterface $logger, + \Magento\Framework\Model\Resource\AbstractResource $resource = null, + \Magento\Framework\Data\Collection\Db $resourceCollection = null, array $data = [] ) { - parent::__construct($data); - $this->logger = $logger; - $this->_eventManager = $eventManager; + parent::__construct( + $context, + $registry, + $metadataService, + $customAttributeBuilder, + $resource, + $resourceCollection, + $data + ); $this->_paymentData = $paymentData; $this->_scopeConfig = $scopeConfig; + $this->_eventManager = $context->getEventDispatcher(); + $this->logger = $context->getLogger(); } /** @@ -305,6 +331,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * * @param \Magento\Framework\Object $payment * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function canVoid(\Magento\Framework\Object $payment) { @@ -358,6 +385,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * @param \Magento\Payment\Model\Info $payment * @param string $transactionId * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function fetchTransactionInfo(\Magento\Payment\Model\Info $payment, $transactionId) { @@ -419,6 +447,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * * @param string $currencyCode * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function canUseForCurrency($currencyCode) { @@ -507,6 +536,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function order(\Magento\Framework\Object $payment, $amount) { @@ -524,6 +554,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function authorize(\Magento\Framework\Object $payment, $amount) { @@ -541,6 +572,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function capture(\Magento\Framework\Object $payment, $amount) { @@ -588,6 +620,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * @param float $amount * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function refund(\Magento\Framework\Object $payment, $amount) { @@ -615,6 +648,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * @param \Magento\Framework\Object $payment * * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function cancel(\Magento\Framework\Object $payment) { @@ -641,6 +675,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * * @param \Magento\Payment\Model\Info $payment * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function canReviewPayment(\Magento\Payment\Model\Info $payment) { @@ -761,6 +796,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * @param object $stateObject * * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function initialize($paymentAction, $stateObject) { @@ -795,6 +831,7 @@ abstract class AbstractMethod extends \Magento\Framework\Object implements Metho * Define if debugging is enabled * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDebugFlag() { diff --git a/app/code/Magento/Payment/Model/Method/Cc.php b/app/code/Magento/Payment/Model/Method/Cc.php index 031f6155cbf5b2ecdda8fe1fadc8887c6b28f992..ab4058f3789c723d03664657ade6e5cf126956af 100644 --- a/app/code/Magento/Payment/Model/Method/Cc.php +++ b/app/code/Magento/Payment/Model/Method/Cc.php @@ -5,6 +5,9 @@ */ namespace Magento\Payment\Model\Method; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Cc extends \Magento\Payment\Model\Method\AbstractMethod { /** @@ -40,26 +43,45 @@ class Cc extends \Magento\Payment\Model\Method\AbstractMethod protected $_centinelService; /** - * @param \Magento\Framework\Event\ManagerInterface $eventManager + * @param \Magento\Framework\Model\Context $context + * @param \Magento\Framework\Registry $registry + * @param \Magento\Framework\Api\MetadataServiceInterface $metadataService + * @param \Magento\Framework\Api\AttributeDataBuilder $customAttributeBuilder * @param \Magento\Payment\Helper\Data $paymentData * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig - * @param \Psr\Log\LoggerInterface $logger * @param \Magento\Framework\Module\ModuleListInterface $moduleList * @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate * @param \Magento\Centinel\Model\Service $centinelService + * @param \Magento\Framework\Model\Resource\AbstractResource $resource + * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( - \Magento\Framework\Event\ManagerInterface $eventManager, + \Magento\Framework\Model\Context $context, + \Magento\Framework\Registry $registry, + \Magento\Framework\Api\MetadataServiceInterface $metadataService, + \Magento\Framework\Api\AttributeDataBuilder $customAttributeBuilder, \Magento\Payment\Helper\Data $paymentData, \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, - \Psr\Log\LoggerInterface $logger, \Magento\Framework\Module\ModuleListInterface $moduleList, \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate, \Magento\Centinel\Model\Service $centinelService, + \Magento\Framework\Model\Resource\AbstractResource $resource = null, + \Magento\Framework\Data\Collection\Db $resourceCollection = null, array $data = [] ) { - parent::__construct($eventManager, $paymentData, $scopeConfig, $logger, $data); + parent::__construct( + $context, + $registry, + $metadataService, + $customAttributeBuilder, + $paymentData, + $scopeConfig, + $resource, + $resourceCollection, + $data + ); $this->_moduleList = $moduleList; $this->_localeDate = $localeDate; $this->_centinelService = $centinelService; diff --git a/app/code/Magento/Payment/Model/Method/Free.php b/app/code/Magento/Payment/Model/Method/Free.php index c229101b5a514a689bbd31604d1d9c2ff5d0abbd..b7a7e00f601dbe9cf3e4124757070b6eb11de0fd 100644 --- a/app/code/Magento/Payment/Model/Method/Free.php +++ b/app/code/Magento/Payment/Model/Method/Free.php @@ -41,22 +41,41 @@ class Free extends \Magento\Payment\Model\Method\AbstractMethod protected $priceCurrency; /** - * @param \Magento\Framework\Event\ManagerInterface $eventManager + * @param \Magento\Framework\Model\Context $context + * @param \Magento\Framework\Registry $registry + * @param \Magento\Framework\Api\MetadataServiceInterface $metadataService + * @param \Magento\Framework\Api\AttributeDataBuilder $customAttributeBuilder * @param \Magento\Payment\Helper\Data $paymentData * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig - * @param \Psr\Log\LoggerInterface $logger * @param PriceCurrencyInterface $priceCurrency + * @param \Magento\Framework\Model\Resource\AbstractResource $resource + * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( - \Magento\Framework\Event\ManagerInterface $eventManager, + \Magento\Framework\Model\Context $context, + \Magento\Framework\Registry $registry, + \Magento\Framework\Api\MetadataServiceInterface $metadataService, + \Magento\Framework\Api\AttributeDataBuilder $customAttributeBuilder, \Magento\Payment\Helper\Data $paymentData, \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, - \Psr\Log\LoggerInterface $logger, PriceCurrencyInterface $priceCurrency, + \Magento\Framework\Model\Resource\AbstractResource $resource = null, + \Magento\Framework\Data\Collection\Db $resourceCollection = null, array $data = [] ) { - parent::__construct($eventManager, $paymentData, $scopeConfig, $logger, $data); + parent::__construct( + $context, + $registry, + $metadataService, + $customAttributeBuilder, + $paymentData, + $scopeConfig, + $resource, + $resourceCollection, + $data + ); $this->priceCurrency = $priceCurrency; } diff --git a/app/code/Magento/Payment/view/adminhtml/templates/form/cc.phtml b/app/code/Magento/Payment/view/adminhtml/templates/form/cc.phtml index b09d32a295e68627a3615e2549d65a3ef75a3155..847af50f37e715fdd4062a9995a1295343095434 100644 --- a/app/code/Magento/Payment/view/adminhtml/templates/form/cc.phtml +++ b/app/code/Magento/Payment/view/adminhtml/templates/form/cc.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_code = $this->getMethodCode() ?> <fieldset class="fieldset payment method" id="payment_form_<?php echo $_code ?>" style="display:none"> diff --git a/app/code/Magento/Payment/view/adminhtml/templates/info/default.phtml b/app/code/Magento/Payment/view/adminhtml/templates/info/default.phtml index 4ea8730a2d41bde140539bc5f21830dcbdfcde7e..cd03f7eab0e8fbefc664145bcf4d9834f012c5f1 100644 --- a/app/code/Magento/Payment/view/adminhtml/templates/info/default.phtml +++ b/app/code/Magento/Payment/view/adminhtml/templates/info/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Payment/view/adminhtml/templates/info/instructions.phtml b/app/code/Magento/Payment/view/adminhtml/templates/info/instructions.phtml index c9dca93608218775b29f47fdea889eee4cbc9852..33159eaea14a5e42a5e511ec48bc425d37c10d73 100644 --- a/app/code/Magento/Payment/view/adminhtml/templates/info/instructions.phtml +++ b/app/code/Magento/Payment/view/adminhtml/templates/info/instructions.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Payment/view/adminhtml/templates/info/pdf/default.phtml b/app/code/Magento/Payment/view/adminhtml/templates/info/pdf/default.phtml index 0134ea7b75a058a22dd10f904b419595c9fa837a..2002851d2a93a6f2df4aa05b22920cd9b7da1670 100644 --- a/app/code/Magento/Payment/view/adminhtml/templates/info/pdf/default.phtml +++ b/app/code/Magento/Payment/view/adminhtml/templates/info/pdf/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Payment/view/adminhtml/templates/info/substitution.phtml b/app/code/Magento/Payment/view/adminhtml/templates/info/substitution.phtml index 4f5041d28690184aea99e5414f7ee4ea5f0d6f66..27b52b5c34dd6a4dda17e49dcf82bf345dc5fb6e 100644 --- a/app/code/Magento/Payment/view/adminhtml/templates/info/substitution.phtml +++ b/app/code/Magento/Payment/view/adminhtml/templates/info/substitution.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div><?php echo __('%1 is not available. You still can process offline actions.', $this->escapeHtml($this->getMethod()->getTitle())) ?></div> diff --git a/app/code/Magento/Payment/view/frontend/templates/form/cc.phtml b/app/code/Magento/Payment/view/frontend/templates/form/cc.phtml index ba983304f5d2f6ba5f914df8788039c46db1f543..f551c252a4ce658ba14e1d7bfbddefbb4edf1b12 100644 --- a/app/code/Magento/Payment/view/frontend/templates/form/cc.phtml +++ b/app/code/Magento/Payment/view/frontend/templates/form/cc.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_code = $this->getMethodCode() ?> <fieldset class="fieldset payment items ccard <?php echo $_code ?>" id="payment_form_<?php echo $_code ?>" style="display: none;"> diff --git a/app/code/Magento/Payment/view/frontend/templates/info/default.phtml b/app/code/Magento/Payment/view/frontend/templates/info/default.phtml index b198076a0ab6d8e5839aeb65cff0c2d9c3822ee2..8ae798f3353f7bac36a68d53e6d66a045a968e8c 100644 --- a/app/code/Magento/Payment/view/frontend/templates/info/default.phtml +++ b/app/code/Magento/Payment/view/frontend/templates/info/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Payment/view/frontend/templates/info/instructions.phtml b/app/code/Magento/Payment/view/frontend/templates/info/instructions.phtml index 9aa879810df38bf7366917fb0b50e8f69afaac16..9412214833d7a5b4be37d30a360ab2e6e6848439 100644 --- a/app/code/Magento/Payment/view/frontend/templates/info/instructions.phtml +++ b/app/code/Magento/Payment/view/frontend/templates/info/instructions.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Persistent/Helper/Data.php b/app/code/Magento/Persistent/Helper/Data.php index 002dd36c26519ee2e9ad34d9370d2c7fd09476f1..b5b23229d72709f1e4e053fd64e1569410781297 100644 --- a/app/code/Magento/Persistent/Helper/Data.php +++ b/app/code/Magento/Persistent/Helper/Data.php @@ -157,6 +157,7 @@ class Data extends \Magento\Core\Helper\Data * Check if set `Clear on Logout` in config settings * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getClearOnLogout() { @@ -191,6 +192,7 @@ class Data extends \Magento\Core\Helper\Data * * @param \Magento\Framework\Event\Observer $observer * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function canProcess($observer) { diff --git a/app/code/Magento/Persistent/Model/Observer/ClearExpiredCronJob.php b/app/code/Magento/Persistent/Model/Observer/ClearExpiredCronJob.php index bbe563dd26d0c935eb266c9833ea0816f2b3ec07..8594aae8e72032ef5cd5752a9c22a5513ef31b24 100644 --- a/app/code/Magento/Persistent/Model/Observer/ClearExpiredCronJob.php +++ b/app/code/Magento/Persistent/Model/Observer/ClearExpiredCronJob.php @@ -39,6 +39,7 @@ class ClearExpiredCronJob * * @param \Magento\Cron\Model\Schedule $schedule * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function execute(\Magento\Cron\Model\Schedule $schedule) { diff --git a/app/code/Magento/Persistent/Model/Observer/CustomerAuthenticatedEvent.php b/app/code/Magento/Persistent/Model/Observer/CustomerAuthenticatedEvent.php index fe0d75eb032597228bfdd39e2f93ffaf64a333f6..598ddfd82a3b529000c263b22ef07bf3fe3a76d5 100644 --- a/app/code/Magento/Persistent/Model/Observer/CustomerAuthenticatedEvent.php +++ b/app/code/Magento/Persistent/Model/Observer/CustomerAuthenticatedEvent.php @@ -47,6 +47,7 @@ class CustomerAuthenticatedEvent * * @param \Magento\Framework\Event\Observer $observer * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function execute($observer) { diff --git a/app/code/Magento/Persistent/Model/Observer/Session.php b/app/code/Magento/Persistent/Model/Observer/Session.php index d2c0159dc2b8f92600968113b45e79413719d3cd..1576a9828fe0c1e081d404144e9d8d3dd95614ce 100644 --- a/app/code/Magento/Persistent/Model/Observer/Session.php +++ b/app/code/Magento/Persistent/Model/Observer/Session.php @@ -73,6 +73,7 @@ class Session /** * @param Observer $observer * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function synchronizePersistentOnLogin(Observer $observer) { diff --git a/app/code/Magento/Persistent/Model/Observer/SetLoadPersistentQuote.php b/app/code/Magento/Persistent/Model/Observer/SetLoadPersistentQuote.php index 457bc9f44f5689236fc28aad61e13580a6bbd528..c72e99656119e59a557c5a788e14cd79d30d4c0f 100644 --- a/app/code/Magento/Persistent/Model/Observer/SetLoadPersistentQuote.php +++ b/app/code/Magento/Persistent/Model/Observer/SetLoadPersistentQuote.php @@ -59,6 +59,7 @@ class SetLoadPersistentQuote * * @param \Magento\Framework\Event\Observer $observer * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function execute($observer) { diff --git a/app/code/Magento/Persistent/Model/Session.php b/app/code/Magento/Persistent/Model/Session.php index e69c4638d7d700256668f601b1aa9b441bc78841..afd932a75f7147222b469b3dbe41698d33f8e511 100644 --- a/app/code/Magento/Persistent/Model/Session.php +++ b/app/code/Magento/Persistent/Model/Session.php @@ -110,6 +110,7 @@ class Session extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -163,6 +164,7 @@ class Session extends \Magento\Framework\Model\AbstractModel * Get if model loads expired sessions * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getLoadExpired() { diff --git a/app/code/Magento/Persistent/view/frontend/templates/remember_me.phtml b/app/code/Magento/Persistent/view/frontend/templates/remember_me.phtml index 2b1ce8436c005211b47f8f63026925ebfe335605..b5f9f08ab86167ae093072d67391c17a647eb050 100644 --- a/app/code/Magento/Persistent/view/frontend/templates/remember_me.phtml +++ b/app/code/Magento/Persistent/view/frontend/templates/remember_me.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/ProductAlert/Block/Email/AbstractEmail.php b/app/code/Magento/ProductAlert/Block/Email/AbstractEmail.php index f1782cccf53413187e831c492a5a79ae584f91c8..b44dd2ca416aa8042f0814493f21f7c3386e9f66 100644 --- a/app/code/Magento/ProductAlert/Block/Email/AbstractEmail.php +++ b/app/code/Magento/ProductAlert/Block/Email/AbstractEmail.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ProductAlert\Block\Email; use Magento\Framework\Pricing\PriceCurrencyInterface; diff --git a/app/code/Magento/ProductAlert/Model/Email.php b/app/code/Magento/ProductAlert/Model/Email.php index cc7842121d556b0329f8d8e494ec99a54127d85e..395d2d9bef1416d60602e56d3dce9b3d8fdf1ea9 100644 --- a/app/code/Magento/ProductAlert/Model/Email.php +++ b/app/code/Magento/ProductAlert/Model/Email.php @@ -9,6 +9,7 @@ namespace Magento\ProductAlert\Model; * ProductAlert Email processor * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Email extends \Magento\Framework\Model\AbstractModel { @@ -119,6 +120,7 @@ class Email extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -281,6 +283,9 @@ class Email extends \Magento\Framework\Model\AbstractModel * Send customer email * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function send() { diff --git a/app/code/Magento/ProductAlert/Model/Observer.php b/app/code/Magento/ProductAlert/Model/Observer.php index d2b238b0848d75218891109f7ad1f7e61cc57d5e..3a601e4518b66c4723ce26606c6c0c5b7be12313 100644 --- a/app/code/Magento/ProductAlert/Model/Observer.php +++ b/app/code/Magento/ProductAlert/Model/Observer.php @@ -9,6 +9,7 @@ namespace Magento\ProductAlert\Model; * ProductAlert observer * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Observer { @@ -124,6 +125,7 @@ class Observer * @param \Magento\Framework\Mail\Template\TransportBuilder $transportBuilder * @param \Magento\ProductAlert\Model\EmailFactory $emailFactory * @param \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Catalog\Helper\Data $catalogData, @@ -173,6 +175,8 @@ class Observer * * @param \Magento\ProductAlert\Model\Email $email * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _processPrice(\Magento\ProductAlert\Model\Email $email) { @@ -258,6 +262,8 @@ class Observer * * @param \Magento\ProductAlert\Model\Email $email * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _processStock(\Magento\ProductAlert\Model\Email $email) { diff --git a/app/code/Magento/ProductAlert/Model/Resource/AbstractResource.php b/app/code/Magento/ProductAlert/Model/Resource/AbstractResource.php index 09a8a75d559c13e49468b1b7edaee82fa41de1d4..af2fc5b9153a9eff477bea7d7cb6ef12c2f7ffa4 100644 --- a/app/code/Magento/ProductAlert/Model/Resource/AbstractResource.php +++ b/app/code/Magento/ProductAlert/Model/Resource/AbstractResource.php @@ -63,6 +63,7 @@ abstract class AbstractResource extends \Magento\Framework\Model\Resource\Db\Abs * @param int $customerId * @param int $websiteId * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function deleteCustomer(\Magento\Framework\Model\AbstractModel $object, $customerId, $websiteId = null) { diff --git a/app/code/Magento/ProductAlert/Model/Resource/Price.php b/app/code/Magento/ProductAlert/Model/Resource/Price.php index b68c190d5c17bc1547f210d4ccce96dfdfbe42a5..1d457c4981b8aad76045c297b70a075f1999d612 100644 --- a/app/code/Magento/ProductAlert/Model/Resource/Price.php +++ b/app/code/Magento/ProductAlert/Model/Resource/Price.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ProductAlert\Model\Resource; /** diff --git a/app/code/Magento/ProductAlert/Model/Resource/Stock.php b/app/code/Magento/ProductAlert/Model/Resource/Stock.php index 6e48aee304c7a2c7ec8a3c6bd5164e08fc38797f..637aaea87065da8126fce215618a2a3d2465048d 100644 --- a/app/code/Magento/ProductAlert/Model/Resource/Stock.php +++ b/app/code/Magento/ProductAlert/Model/Resource/Stock.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ProductAlert\Model\Resource; /** diff --git a/app/code/Magento/ProductAlert/view/frontend/templates/email/price.phtml b/app/code/Magento/ProductAlert/view/frontend/templates/email/price.phtml index aade28e6ed550c509f93a4120c2d5a8c26c28def..2720ccca2c986eaf25e31689ddaca965c5ea7f33 100644 --- a/app/code/Magento/ProductAlert/view/frontend/templates/email/price.phtml +++ b/app/code/Magento/ProductAlert/view/frontend/templates/email/price.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\ProductAlert\Block\Email\Price */ ?> <?php if ($_products = $this->getProducts()): ?> diff --git a/app/code/Magento/ProductAlert/view/frontend/templates/email/stock.phtml b/app/code/Magento/ProductAlert/view/frontend/templates/email/stock.phtml index 83a65caa63ed4754200127f8662a2a7105661293..a18b63ee5a353a180608bc00353393b0b81d251b 100644 --- a/app/code/Magento/ProductAlert/view/frontend/templates/email/stock.phtml +++ b/app/code/Magento/ProductAlert/view/frontend/templates/email/stock.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\ProductAlert\Block\Email\Stock */ ?> <?php if ($_products = $this->getProducts()): ?> diff --git a/app/code/Magento/Quote/Api/BillingAddressManagementInterface.php b/app/code/Magento/Quote/Api/BillingAddressManagementInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..ebadf462e06060dc3d649acf4670ff9db18bf667 --- /dev/null +++ b/app/code/Magento/Quote/Api/BillingAddressManagementInterface.php @@ -0,0 +1,29 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api; + +interface BillingAddressManagementInterface +{ + /** + * Assigns a specified billing address to a specified cart. + * + * @param int $cartId The cart ID. + * @param \Magento\Quote\Api\Data\AddressInterface $address Billing address data. + * @return int Address ID. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + * @throws \Magento\Framework\Exception\InputException The specified cart ID or address data is not valid. + */ + public function assign($cartId, \Magento\Quote\Api\Data\AddressInterface $address); + + /** + * Returns the billing address for a specified quote. + * + * @param int $cartId The cart ID. + * @return \Magento\Quote\Api\Data\AddressInterface Quote billing address object. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + */ + public function get($cartId); +} diff --git a/app/code/Magento/Checkout/Service/V1/Item/WriteServiceInterface.php b/app/code/Magento/Quote/Api/CartItemRepositoryInterface.php similarity index 55% rename from app/code/Magento/Checkout/Service/V1/Item/WriteServiceInterface.php rename to app/code/Magento/Quote/Api/CartItemRepositoryInterface.php index 30a0db6dfb4a1eedb2e914f3ed95df59ac736ccc..708f29fef341501425887b6495ae9aaa564c94a3 100644 --- a/app/code/Magento/Checkout/Service/V1/Item/WriteServiceInterface.php +++ b/app/code/Magento/Quote/Api/CartItemRepositoryInterface.php @@ -3,37 +3,39 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Item; +namespace Magento\Quote\Api; -/** - * Write service interface. - */ -interface WriteServiceInterface +interface CartItemRepositoryInterface { /** - * Adds the specified item to the specified cart. + * Lists items that are assigned to a specified cart. * * @param int $cartId The cart ID. - * @param \Magento\Checkout\Service\V1\Data\Cart\Item $data The item. - * @return int Item ID. + * @return \Magento\Quote\Api\Data\CartItemInterface[] Array of items. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + */ + public function getList($cartId); + + /** + * Adds the specified item to the specified cart. + * + * @param \Magento\Quote\Api\Data\CartItemInterface $cartItem The item. + * @return \Magento\Quote\Api\Data\CartItemInterface Item. * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. * @throws \Magento\Framework\Exception\CouldNotSaveException The specified item could not be saved to the cart. * @throws \Magento\Framework\Exception\InputException The specified item or cart is not valid. */ - public function addItem($cartId, \Magento\Checkout\Service\V1\Data\Cart\Item $data); + public function save(\Magento\Quote\Api\Data\CartItemInterface $cartItem); /** - * Updates the specified item in the specified cart. + * Remove bundle option * - * @param int $cartId The cart ID. - * @param int $itemId The item ID of the item to be updated. - * @param \Magento\Checkout\Service\V1\Data\Cart\Item $data The item. - * @return bool - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified item or cart does not exist. - * @throws \Magento\Framework\Exception\CouldNotSaveException The item could not be updated. - * @throws \Magento\Framework\Exception\InputException The specified item or cart is not valid. + * @param \Magento\Quote\Api\Data\CartItemInterface $cartItem + * @return void + * @throws \Magento\Framework\Exception\CouldNotSaveException + * @throws \Magento\Webapi\Exception */ - public function updateItem($cartId, $itemId, \Magento\Checkout\Service\V1\Data\Cart\Item $data); + public function delete(\Magento\Quote\Api\Data\CartItemInterface $cartItem); /** * Removes the specified item from the specified cart. @@ -44,5 +46,5 @@ interface WriteServiceInterface * @throws \Magento\Framework\Exception\NoSuchEntityException The specified item or cart does not exist. * @throws \Magento\Framework\Exception\CouldNotSaveException The item could not be removed. */ - public function removeItem($cartId, $itemId); + public function deleteById($cartId, $itemId); } diff --git a/app/code/Magento/Checkout/Service/V1/Cart/WriteServiceInterface.php b/app/code/Magento/Quote/Api/CartManagementInterface.php similarity index 53% rename from app/code/Magento/Checkout/Service/V1/Cart/WriteServiceInterface.php rename to app/code/Magento/Quote/Api/CartManagementInterface.php index d38945578132893e3e85e1bd28afa1dc81892db5..4bf49813ac4313319350c774ee038d1f312453da 100644 --- a/app/code/Magento/Checkout/Service/V1/Cart/WriteServiceInterface.php +++ b/app/code/Magento/Quote/Api/CartManagementInterface.php @@ -3,29 +3,37 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Cart; +namespace Magento\Quote\Api; -/** - * Cart write service interface. - */ -interface WriteServiceInterface +interface CartManagementInterface { /** * Enables an administrative or guest user to create an empty cart and quote for an anonymous customer. * + * @param int $storeId * @throws \Magento\Framework\Exception\CouldNotSaveException The empty cart and quote could not be created. * @return int Cart ID. */ - public function create(); + public function createEmptyCart($storeId); + + /** + * Returns information for the cart for a specified customer. + * + * @param int $customerId The customer ID. + * @return \Magento\Quote\Api\Data\CartInterface Cart object. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified customer does not exist. + */ + public function getCartForCustomer($customerId); /** * Assigns a specified customer to a specified shopping cart. * * @param int $cartId The cart ID. * @param int $customerId The customer ID. + * @param int $storeId * @return boolean */ - public function assignCustomer($cartId, $customerId); + public function assignCustomer($cartId, $customerId, $storeId); /** * Places an order for a specified cart. @@ -33,5 +41,5 @@ interface WriteServiceInterface * @param int $cartId The cart ID. * @return int Order ID. */ - public function order($cartId); + public function placeOrder($cartId); } diff --git a/app/code/Magento/Quote/Api/CartRepositoryInterface.php b/app/code/Magento/Quote/Api/CartRepositoryInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..63db4ccd4c0951cfa226556e854e4677929564c5 --- /dev/null +++ b/app/code/Magento/Quote/Api/CartRepositoryInterface.php @@ -0,0 +1,26 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api; + +interface CartRepositoryInterface +{ + /** + * Enables an administrative user to return information for a specified cart. + * + * @param int $cartId + * @return \Magento\Quote\Api\Data\CartInterface + * @throws \Magento\Framework\Exception\NoSuchEntityException + */ + public function get($cartId); + + /** + * Enables administrative users to list carts that match specified search criteria. + * + * @param \Magento\Framework\Api\SearchCriteria $searchCriteria + * @return \Magento\Quote\Api\Data\CartSearchResultsInterface + */ + public function getList(\Magento\Framework\Api\SearchCriteria $searchCriteria); +} diff --git a/app/code/Magento/Checkout/Service/V1/Cart/TotalsServiceInterface.php b/app/code/Magento/Quote/Api/CartTotalRepositoryInterface.php similarity index 58% rename from app/code/Magento/Checkout/Service/V1/Cart/TotalsServiceInterface.php rename to app/code/Magento/Quote/Api/CartTotalRepositoryInterface.php index d88f5421ed4e360286f700e749ff29e43e08130e..305c06e8ffedb31a0fdcf3894f7b245b967555ed 100644 --- a/app/code/Magento/Checkout/Service/V1/Cart/TotalsServiceInterface.php +++ b/app/code/Magento/Quote/Api/CartTotalRepositoryInterface.php @@ -3,19 +3,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Cart; +namespace Magento\Quote\Api; -/** - * Totals service interface. - */ -interface TotalsServiceInterface +interface CartTotalRepositoryInterface { /** * Returns quote totals data for a specified cart. * * @param int $cartId The cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\Totals Quote totals data. + * @return \Magento\Quote\Api\Data\TotalsInterface Quote totals data. * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. */ - public function getTotals($cartId); + public function get($cartId); } diff --git a/app/code/Magento/Checkout/Service/V1/Coupon/WriteServiceInterface.php b/app/code/Magento/Quote/Api/CouponManagementInterface.php similarity index 59% rename from app/code/Magento/Checkout/Service/V1/Coupon/WriteServiceInterface.php rename to app/code/Magento/Quote/Api/CouponManagementInterface.php index 586071765cc15d9825148eaadee1afb560dd6f00..280d248d49d2f48b9ea1248dbcb20198f2536adf 100644 --- a/app/code/Magento/Checkout/Service/V1/Coupon/WriteServiceInterface.php +++ b/app/code/Magento/Quote/Api/CouponManagementInterface.php @@ -1,25 +1,36 @@ <?php /** + * * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Coupon; + +namespace Magento\Quote\Api; /** - * Coupon write service interface. + * Coupon management service interface. */ -interface WriteServiceInterface +interface CouponManagementInterface { + /** + * Returns information for a coupon in a specified cart. + * + * @param int $cartId The cart ID. + * @return string The coupon code data. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + */ + public function get($cartId); + /** * Adds a coupon by code to a specified cart. * * @param int $cartId The cart ID. - * @param \Magento\Checkout\Service\V1\Data\Cart\Coupon $couponCodeData The coupon code data. + * @param string $couponCode The coupon code data. * @return bool * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. * @throws \Magento\Framework\Exception\CouldNotSaveException The specified coupon could not be added. */ - public function set($cartId, \Magento\Checkout\Service\V1\Data\Cart\Coupon $couponCodeData); + public function set($cartId, $couponCode); /** * Deletes a coupon from a specified cart. @@ -29,5 +40,5 @@ interface WriteServiceInterface * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. * @throws \Magento\Framework\Exception\CouldNotDeleteException The specified coupon could not be deleted. */ - public function delete($cartId); + public function remove($cartId); } diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/Address.php b/app/code/Magento/Quote/Api/Data/AddressInterface.php similarity index 50% rename from app/code/Magento/Checkout/Service/V1/Data/Cart/Address.php rename to app/code/Magento/Quote/Api/Data/AddressInterface.php index a65d1cbc5d5215629c25a2e678030202d75889c3..d5f23c64c59147ed93d4e9d6f9ba90bcf7a1c2dd 100644 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/Address.php +++ b/app/code/Magento/Quote/Api/Data/AddressInterface.php @@ -3,14 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Data\Cart; +namespace Magento\Quote\Api\Data; -/** - * Quote billing/shipping address data - * - * @codeCoverageIgnore - */ -class Address extends \Magento\Framework\Api\AbstractExtensibleObject +interface AddressInterface extends \Magento\Framework\Api\ExtensibleDataInterface { /**#@+ * Constants defined for keys of array, makes typos less likely @@ -21,9 +16,13 @@ class Address extends \Magento\Framework\Api\AbstractExtensibleObject const KEY_ID = 'id'; - const KEY_CUSTOMER_ID = 'customer_id'; + const REGION_ID = 'region_id'; - const KEY_REGION = 'region'; + const REGION_CODE = 'region_code'; + + const REGION = 'region'; + + const KEY_CUSTOMER_ID = 'customer_id'; const KEY_STREET = 'street'; @@ -56,168 +55,131 @@ class Address extends \Magento\Framework\Api\AbstractExtensibleObject * * @return int|null */ - public function getId() - { - return $this->_get(self::KEY_ID); - } + public function getId(); /** - * Get region + * Get region name * - * @return \Magento\Checkout\Service\V1\Data\Cart\Address\Region|null + * @return string + */ + public function getRegion(); + + /** + * Get region id + * + * @return string + */ + public function getRegionId(); + + /** + * Get region code + * + * @return string */ - public function getRegion() - { - return $this->_get(self::KEY_REGION); - } + public function getRegionCode(); /** * Get country id * * @return string */ - public function getCountryId() - { - return $this->_get(self::KEY_COUNTRY_ID); - } + public function getCountryId(); /** * Get street * * @return string[] */ - public function getStreet() - { - return $this->_get(self::KEY_STREET); - } + public function getStreet(); /** * Get company * * @return string|null */ - public function getCompany() - { - return $this->_get(self::KEY_COMPANY); - } + public function getCompany(); /** * Get telephone number * * @return string */ - public function getTelephone() - { - return $this->_get(self::KEY_TELEPHONE); - } + public function getTelephone(); /** * Get fax number * * @return string|null */ - public function getFax() - { - return $this->_get(self::KEY_FAX); - } + public function getFax(); /** * Get postcode * * @return string */ - public function getPostcode() - { - return $this->_get(self::KEY_POSTCODE); - } + public function getPostcode(); /** * Get city name * * @return string */ - public function getCity() - { - return $this->_get(self::KEY_CITY); - } + public function getCity(); /** * Get first name * * @return string */ - public function getFirstname() - { - return $this->_get(self::KEY_FIRSTNAME); - } + public function getFirstname(); /** * Get last name * * @return string */ - public function getLastname() - { - return $this->_get(self::KEY_LASTNAME); - } + public function getLastname(); /** * Get middle name * * @return string|null */ - public function getMiddlename() - { - return $this->_get(self::KEY_MIDDLENAME); - } + public function getMiddlename(); /** * Get prefix * * @return string|null */ - public function getPrefix() - { - return $this->_get(self::KEY_PREFIX); - } + public function getPrefix(); /** * Get suffix * * @return string|null */ - public function getSuffix() - { - return $this->_get(self::KEY_SUFFIX); - } + public function getSuffix(); /** * Get Vat id * * @return string|null */ - public function getVatId() - { - return $this->_get(self::KEY_VAT_ID); - } + public function getVatId(); /** * Get customer id * * @return string|null */ - public function getCustomerId() - { - return $this->_get(self::KEY_CUSTOMER_ID); - } + public function getCustomerId(); /** * Get billing/shipping email * * @return string */ - public function getEmail() - { - return $this->_get(self::KEY_EMAIL); - } + public function getEmail(); } diff --git a/app/code/Magento/Quote/Api/Data/CartInterface.php b/app/code/Magento/Quote/Api/Data/CartInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..50df790dee2f0c836d95967402fe0df441a9b32b --- /dev/null +++ b/app/code/Magento/Quote/Api/Data/CartInterface.php @@ -0,0 +1,151 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api\Data; + +interface CartInterface extends \Magento\Framework\Api\ExtensibleDataInterface +{ + /** + * Returns the cart/quote ID. + * + * @return int Cart/quote ID. + */ + public function getId(); + + /** + * Returns the cart creation date and time. + * + * @return string|null Cart creation date and time. Otherwise, null. + */ + public function getCreatedAt(); + + /** + * Returns the cart last update date and time. + * + * @return string|null Cart last update date and time. Otherwise, null. + */ + public function getUpdatedAt(); + + /** + * Returns the cart conversion date and time. + * + * @return string|null Cart conversion date and time. Otherwise, null. + */ + public function getConvertedAt(); + + /** + * Determines whether the cart is still active. + * + * @return bool|null Active status flag value. Otherwise, null. + */ + public function getIsActive(); + + /** + * Determines whether the cart is a virtual cart. + * + * A virtual cart contains virtual items. + * + * @return bool|null Virtual flag value. Otherwise, null. + */ + public function getIsVirtual(); + + /** + * Lists items in the cart. + * + * @return \Magento\Quote\Api\Data\CartItemInterface[]|null Array of items. Otherwise, null. + */ + public function getItems(); + + /** + * Returns the number of different items or products in the cart. + * + * @return int|null Number of different items or products in the cart. Otherwise, null. + */ + public function getItemsCount(); + + /** + * Returns the total quantity of all cart items. + * + * @return float|null Total quantity of all cart items. Otherwise, null. + */ + public function getItemsQty(); + + /** + * Returns information about the customer who is assigned to the cart. + * + * @return \Magento\Customer\Api\Data\CustomerInterface Information about the customer who is assigned to the cart. + */ + public function getCustomer(); + + /** + * Returns the payment method that is used to process the cart. + * + * @return string|null Payment method. Otherwise, null. + */ + public function getCheckoutMethod(); + + /** + * Returns the cart shipping address. + * + * @return \Magento\Quote\Api\Data\AddressInterface|null Cart shipping address. Otherwise, null. + */ + public function getShippingAddress(); + + /** + * Returns the cart billing address. + * + * @return \Magento\Quote\Api\Data\AddressInterface|null Cart billing address. Otherwise, null. + */ + public function getBillingAddress(); + + /** + * Returns the reserved order ID for the cart. + * + * @return string|null Reserved order ID. Otherwise, null. + */ + public function getReservedOrderId(); + + /** + * Returns the original order ID for the cart. + * + * @return string|null Original order ID. Otherwise, null. + */ + public function getOrigOrderId(); + + /** + * Returns information about quote currency, such as code, exchange rate, and so on. + * + * @return \Magento\Quote\Api\Data\CurrencyInterface|null Quote currency information. Otherwise, null. + */ + public function getCurrency(); + + /** + * True for guest customers, false for logged in customers + * + * @return bool|null + */ + public function getCustomerIsGuest(); + + /** + * Customer notice text + * + * @return string|null + */ + public function getCustomerNote(); + + /** + * Send customer notification flag + * + * @return bool|null + */ + public function getCustomerNoteNotify(); + + /** + * Get customer tax class ID. + * + * @return string|null + */ + public function getCustomerTaxClassId(); +} diff --git a/app/code/Magento/Quote/Api/Data/CartItemInterface.php b/app/code/Magento/Quote/Api/Data/CartItemInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..7e931438f86548944e6e44ba4298fc52fda22db8 --- /dev/null +++ b/app/code/Magento/Quote/Api/Data/CartItemInterface.php @@ -0,0 +1,58 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api\Data; + +interface CartItemInterface extends \Magento\Framework\Api\ExtensibleDataInterface +{ + /** + * Returns the item ID. + * + * @return int|null Item ID. Otherwise, null. + */ + public function getItemId(); + + /** + * Returns the product SKU. + * + * @return string|null Product SKU. Otherwise, null. + */ + public function getSku(); + + /** + * Returns the product quantity. + * + * @return int Product quantity. + */ + public function getQty(); + + /** + * Returns the product name. + * + * @return string|null Product name. Otherwise, null. + */ + public function getName(); + + /** + * Returns the product price. + * + * @return float|null Product price. Otherwise, null. + */ + public function getPrice(); + + /** + * Returns the product type. + * + * @return string|null Product type. Otherwise, null. + */ + public function getProductType(); + + /** + * Returns Quote id. + * + * @return int + */ + public function getQuoteId(); +} diff --git a/app/code/Magento/Quote/Api/Data/CartSearchResultsInterface.php b/app/code/Magento/Quote/Api/Data/CartSearchResultsInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..7ffaa3fafb78215cb3e772ceaafe0430881d571e --- /dev/null +++ b/app/code/Magento/Quote/Api/Data/CartSearchResultsInterface.php @@ -0,0 +1,16 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api\Data; + +interface CartSearchResultsInterface extends \Magento\Framework\Api\SearchResultsInterface +{ + /** + * Get carts list. + * + * @return \Magento\Quote\Api\Data\CartInterface[] + */ + public function getItems(); +} diff --git a/app/code/Magento/Quote/Api/Data/CurrencyInterface.php b/app/code/Magento/Quote/Api/Data/CurrencyInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..4577709e3e9a1280a6428a705fe0099e6911c772 --- /dev/null +++ b/app/code/Magento/Quote/Api/Data/CurrencyInterface.php @@ -0,0 +1,65 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api\Data; + +interface CurrencyInterface extends \Magento\Framework\Api\ExtensibleDataInterface +{ + /** + * Get global currency code + * + * @return string|null + */ + public function getGlobalCurrencyCode(); + + /** + * Get base currency code + * + * @return string|null + */ + public function getBaseCurrencyCode(); + + /** + * Get store currency code + * + * @return string|null + */ + public function getStoreCurrencyCode(); + + /** + * Get quote currency code + * + * @return string|null + */ + public function getQuoteCurrencyCode(); + + /** + * Get store currency to base currency rate + * + * @return float|null + */ + public function getStoreToBaseRate(); + + /** + * Get store currency to quote currency rate + * + * @return float|null + */ + public function getStoreToQuoteRate(); + + /** + * Get base currency to global currency rate + * + * @return float|null + */ + public function getBaseToGlobalRate(); + + /** + * Get base currency to quote currency rate + * + * @return float|null + */ + public function getBaseToQuoteRate(); +} diff --git a/app/code/Magento/Quote/Api/Data/PaymentInterface.php b/app/code/Magento/Quote/Api/Data/PaymentInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..c6b00bc9cd5210c8dc0fbd516541372da79c08c4 --- /dev/null +++ b/app/code/Magento/Quote/Api/Data/PaymentInterface.php @@ -0,0 +1,65 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api\Data; + +interface PaymentInterface extends \Magento\Framework\Api\ExtensibleDataInterface +{ + /** + * Get purchase order number + * + * @return string|null + */ + public function getPoNumber(); + + /** + * Get payment method code + * + * @return string + */ + public function getMethod(); + + /** + * Get credit card owner + * + * @return string|null + */ + public function getCcOwner(); + + /** + * Get credit card number + * + * @return string|null + */ + public function getCcNumber(); + + /** + * Get credit card type + * + * @return string|null + */ + public function getCcType(); + + /** + * Get credit card expiration year + * + * @return string|null + */ + public function getCcExpYear(); + + /** + * Get credit card expiration month + * + * @return string|null + */ + public function getCcExpMonth(); + + /** + * Get payment additional details + * + * @return string[]|null + */ + public function getAdditionalData(); +} diff --git a/app/code/Magento/Quote/Api/Data/PaymentMethodInterface.php b/app/code/Magento/Quote/Api/Data/PaymentMethodInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..3be900400f305ed076761bfab80a498dd7637d24 --- /dev/null +++ b/app/code/Magento/Quote/Api/Data/PaymentMethodInterface.php @@ -0,0 +1,23 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api\Data; + +interface PaymentMethodInterface extends \Magento\Framework\Api\ExtensibleDataInterface +{ + /** + * Get payment method code + * + * @return string + */ + public function getCode(); + + /** + * Get payment method title + * + * @return string + */ + public function getTitle(); +} diff --git a/app/code/Magento/Quote/Api/Data/ShippingMethodInterface.php b/app/code/Magento/Quote/Api/Data/ShippingMethodInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..62dafce5a1dce5b5541d9c851fb3ea3c85b20e8e --- /dev/null +++ b/app/code/Magento/Quote/Api/Data/ShippingMethodInterface.php @@ -0,0 +1,94 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api\Data; + +interface ShippingMethodInterface extends \Magento\Framework\Api\ExtensibleDataInterface +{ + /** + * Shipping carrier code. + */ + const CARRIER_CODE = 'carrier_code'; + + /** + * Shipping method code. + */ + const METHOD_CODE = 'method_code'; + + /** + * Shipping carrier title. + */ + const CARRIER_TITLE = 'carrier_title'; + + /** + * Shipping method title. + */ + const METHOD_TITLE = 'method_title'; + + /** + * Shipping amount in store currency. + */ + const SHIPPING_AMOUNT = 'amount'; + + /** + * Shipping amount in base currency. + */ + const BASE_SHIPPING_AMOUNT = 'base_amount'; + + /** + * Available. + */ + const AVAILABLE = 'available'; + + /** + * Returns the shipping carrier code. + * + * @return string Shipping carrier code. + */ + public function getCarrierCode(); + + /** + * Returns the shipping method code. + * + * @return string Shipping method code. + */ + public function getMethodCode(); + + /** + * Returns the shipping carrier title. + * + * @return string|null Shipping carrier title. Otherwise, null. + */ + public function getCarrierTitle(); + + /** + * Returns the shipping method title. + * + * @return string|null Shipping method title. Otherwise, null. + */ + public function getMethodTitle(); + + /** + * Returns the shipping amount in store currency. + * + * @return float Shipping amount in store currency. + */ + public function getAmount(); + + /** + * Returns the shipping amount in base currency. + * + * @return float Shipping amount in base currency. + */ + public function getBaseAmount(); + + /** + * Returns the value of the availability flag for the current shipping method. + * + * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) + */ + public function getAvailable(); +} diff --git a/app/code/Magento/Quote/Api/Data/TotalsInterface.php b/app/code/Magento/Quote/Api/Data/TotalsInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..a07bd69c683f4d365b97a524530759ad3c40392f --- /dev/null +++ b/app/code/Magento/Quote/Api/Data/TotalsInterface.php @@ -0,0 +1,170 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api\Data; + +interface TotalsInterface extends \Magento\Framework\Api\ExtensibleDataInterface +{ + /** + * Get grand total in quote currency + * + * @return float|null + */ + public function getGrandTotal(); + + /** + * Get grand total in base currency + * + * @return float|null + */ + public function getBaseGrandTotal(); + + /** + * Get subtotal in quote currency + * + * @return float|null + */ + public function getSubtotal(); + + /** + * Get subtotal in base currency + * + * @return float|null + */ + public function getBaseSubtotal(); + + /** + * Get discount amount in quote currency + * + * @return float|null + */ + public function getDiscountAmount(); + + /** + * Get discount amount in base currency + * + * @return float|null + */ + public function getBaseDiscountAmount(); + + /** + * Get subtotal in quote currency with applied discount + * + * @return float|null + */ + public function getSubtotalWithDiscount(); + + /** + * Get subtotal in base currency with applied discount + * + * @return float|null + */ + public function getBaseSubtotalWithDiscount(); + + /** + * Get shipping amount in quote currency + * + * @return float|null + */ + public function getShippingAmount(); + + /** + * Get shipping amount in base currency + * + * @return float|null + */ + public function getBaseShippingAmount(); + + /** + * Get shipping discount amount in quote currency + * + * @return float|null + */ + public function getShippingDiscountAmount(); + + /** + * Get shipping discount amount in base currency + * + * @return float|null + */ + public function getBaseShippingDiscountAmount(); + + /** + * Get tax amount in quote currency + * + * @return float|null + */ + public function getTaxAmount(); + + /** + * Get tax amount in base currency + * + * @return float|null + */ + public function getBaseTaxAmount(); + + /** + * Get shipping tax amount in quote currency + * + * @return float|null + */ + public function getShippingTaxAmount(); + + /** + * Get shipping tax amount in base currency + * + * @return float|null + */ + public function getBaseShippingTaxAmount(); + + /** + * Get subtotal including tax in quote currency + * + * @return float|null + */ + public function getSubtotalInclTax(); + + /** + * Get subtotal including tax in base currency + * + * @return float|null + */ + public function getBaseSubtotalInclTax(); + + /** + * Get shipping including tax in quote currency + * + * @return float|null + */ + public function getShippingInclTax(); + + /** + * Get shipping including tax in base currency + * + * @return float|null + */ + public function getBaseShippingInclTax(); + + /** + * Get base currency code + * + * @return string|null + */ + public function getBaseCurrencyCode(); + + /** + * Get quote currency code + * + * @return string|null + */ + public function getQuoteCurrencyCode(); + + /** + * Get totals by items + * + * @return \Magento\Quote\Api\Data\TotalsItemInterface[]|null + */ + public function getItems(); +} diff --git a/app/code/Magento/Quote/Api/Data/TotalsItemInterface.php b/app/code/Magento/Quote/Api/Data/TotalsItemInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..c600c7bc2cbffb81a55a9e9510b844b8fd8d2184 --- /dev/null +++ b/app/code/Magento/Quote/Api/Data/TotalsItemInterface.php @@ -0,0 +1,121 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api\Data; + +interface TotalsItemInterface extends \Magento\Framework\Api\ExtensibleDataInterface +{ + /** + * Returns the item price in quote currency. + * + * @return float Item price in quote currency. + */ + public function getPrice(); + + /** + * Returns the item price in base currency. + * + * @return float Item price in base currency. + */ + public function getBasePrice(); + + /** + * Returns the item quantity. + * + * @return int Item quantity. + */ + public function getQty(); + + /** + * Returns the row total in quote currency. + * + * @return float Row total in quote currency. + */ + public function getRowTotal(); + + /** + * Returns the row total in base currency. + * + * @return float Row total in base currency. + */ + public function getBaseRowTotal(); + + /** + * Returns the row total with discount in quote currency. + * + * @return float|null Row total with discount in quote currency. Otherwise, null. + */ + public function getRowTotalWithDiscount(); + + /** + * Returns the tax amount in quote currency. + * + * @return float|null Tax amount in quote currency. Otherwise, null. + */ + public function getTaxAmount(); + + /** + * Returns the tax amount in base currency. + * + * @return float|null Tax amount in base currency. Otherwise, null. + */ + public function getBaseTaxAmount(); + + /** + * Returns the tax percent. + * + * @return int|null Tax percent. Otherwise, null. + */ + public function getTaxPercent(); + + /** + * Returns the discount amount in quote currency. + * + * @return float|null Discount amount in quote currency. Otherwise, null. + */ + public function getDiscountAmount(); + + /** + * Returns the discount amount in base currency. + * + * @return float|null Discount amount in base currency. Otherwise, null. + */ + public function getBaseDiscountAmount(); + + /** + * Returns the discount percent. + * + * @return int|null Discount percent. Otherwise, null. + */ + public function getDiscountPercent(); + + /** + * Returns the price including tax in quote currency. + * + * @return float|null Price including tax in quote currency. Otherwise, null. + */ + public function getPriceInclTax(); + + /** + * Returns the price including tax in base currency. + * + * @return float|null Price including tax in base currency. Otherwise, null. + */ + public function getBasePriceInclTax(); + + /** + * Returns the row total including tax in quote currency. + * + * @return float|null Row total including tax in quote currency. Otherwise, null. + */ + public function getRowTotalInclTax(); + + /** + * Returns the row total including tax in base currency. + * + * @return float|null Row total including tax in base currency. Otherwise, null. + */ + public function getBaseRowTotalInclTax(); +} diff --git a/app/code/Magento/Quote/Api/PaymentMethodManagementInterface.php b/app/code/Magento/Quote/Api/PaymentMethodManagementInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..47fa55271c3c86742b444c7ba8d684516c7fd460 --- /dev/null +++ b/app/code/Magento/Quote/Api/PaymentMethodManagementInterface.php @@ -0,0 +1,39 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api; + +interface PaymentMethodManagementInterface +{ + /** + * Adds a specified payment method to a specified shopping cart. + * + * @param int $cartId The cart ID. + * @param \Magento\Quote\Api\Data\PaymentInterface $method The payment method. + * @return int Payment method ID. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + * @throws \Magento\Framework\Exception\State\InvalidTransitionException The billing or shipping address + * is not set, or the specified payment method is not available. + */ + public function set($cartId, \Magento\Quote\Api\Data\PaymentInterface $method); + + /** + * Returns the payment method for a specified shopping cart. + * + * @param int $cartId The cart ID. + * @return \Magento\Quote\Api\Data\PaymentInterface Payment method object. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + */ + public function get($cartId); + + /** + * Lists available payment methods for a specified shopping cart. + * + * @param int $cartId The cart ID. + * @return \Magento\Quote\Api\Data\PaymentMethodInterface[] Array of payment methods. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + */ + public function getList($cartId); +} diff --git a/app/code/Magento/Quote/Api/ShippingAddressManagementInterface.php b/app/code/Magento/Quote/Api/ShippingAddressManagementInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..c6fda8942d5b5a4006e47636b4873517501c1ed2 --- /dev/null +++ b/app/code/Magento/Quote/Api/ShippingAddressManagementInterface.php @@ -0,0 +1,29 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api; + +interface ShippingAddressManagementInterface +{ + /** + * Assigns a specified shipping address to a specified cart. + * + * @param int $cartId The cart ID. + * @param \Magento\Quote\Api\Data\AddressInterface $address The shipping address data. + * @return int Address ID. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + * @throws \Magento\Framework\Exception\InputException The specified cart ID or address data is not valid. + */ + public function assign($cartId, \Magento\Quote\Api\Data\AddressInterface $address); + + /** + * Returns the shipping address for a specified quote. + * + * @param int $cartId The cart ID. + * @return \Magento\Quote\Api\Data\AddressInterface Shipping address object. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. + */ + public function get($cartId); +} diff --git a/app/code/Magento/Quote/Api/ShippingMethodManagementInterface.php b/app/code/Magento/Quote/Api/ShippingMethodManagementInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..9e7577a8f69614c328b50239b5fa9ef84032d571 --- /dev/null +++ b/app/code/Magento/Quote/Api/ShippingMethodManagementInterface.php @@ -0,0 +1,44 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Api; + +interface ShippingMethodManagementInterface +{ + /** + * Sets the carrier and shipping methods codes for a specified cart. + * + * @param int $cartId The shopping cart ID. + * @param string $carrierCode The carrier code. + * @param string $methodCode The shipping method code. + * @return bool + * @throws \Magento\Framework\Exception\InputException The shipping method is not valid for an empty cart. + * @throws \Magento\Framework\Exception\CouldNotSaveException The shipping method could not be saved. + * @throws \Magento\Framework\Exception\StateException The billing or shipping address is not set. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart contains only virtual products + * so the shipping method does not apply. + */ + public function set($cartId, $carrierCode, $methodCode); + + /** + * Returns selected shipping method for a specified quote. + * + * @param int $cartId The shopping cart ID. + * @return \Magento\Quote\Api\Data\ShippingMethodInterface Shipping method. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified shopping cart does not exist. + * @throws \Magento\Framework\Exception\StateException The shipping address is not set. + */ + public function get($cartId); + + /** + * Lists applicable shipping methods for a specified quote. + * + * @param int $cartId The shopping cart ID. + * @return \Magento\Quote\Api\Data\ShippingMethodInterface[] An array of shipping methods. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified quote does not exist. + * @throws \Magento\Framework\Exception\StateException The shipping address is not set. + */ + public function getList($cartId); +} diff --git a/app/code/Magento/Quote/Model/BillingAddressManagement.php b/app/code/Magento/Quote/Model/BillingAddressManagement.php new file mode 100644 index 0000000000000000000000000000000000000000..5e5140fc9e749bc5a05a04d3ccd79e73478c3a3a --- /dev/null +++ b/app/code/Magento/Quote/Model/BillingAddressManagement.php @@ -0,0 +1,80 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Model; + +use Magento\Quote\Model\QuoteRepository; +use Magento\Framework\Exception\InputException; +use Psr\Log\LoggerInterface as Logger; +use Magento\Quote\Api\BillingAddressManagementInterface; + +/** Quote billing address write service object. */ +class BillingAddressManagement implements BillingAddressManagementInterface +{ + /** + * Validator. + * + * @var QuoteAddressValidator + */ + protected $addressValidator; + + /** + * Logger. + * + * @var Logger + */ + protected $logger; + + /** + * Quote repository. + * + * @var QuoteRepository + */ + protected $quoteRepository; + + /** + * Constructs a quote billing address service object. + * + * @param QuoteRepository $quoteRepository Quote repository. + * @param QuoteAddressValidator $addressValidator Address validator. + * @param Logger $logger Logger. + */ + public function __construct( + QuoteRepository $quoteRepository, + QuoteAddressValidator $addressValidator, + Logger $logger + ) { + $this->addressValidator = $addressValidator; + $this->logger = $logger; + $this->quoteRepository = $quoteRepository; + } + + /** + * {@inheritDoc} + */ + public function assign($cartId, \Magento\Quote\Api\Data\AddressInterface $address) + { + $quote = $this->quoteRepository->getActive($cartId); + $this->addressValidator->validate($address); + $quote->setBillingAddress($address); + $quote->setDataChanges(true); + try { + $this->quoteRepository->save($quote); + } catch (\Exception $e) { + $this->logger->critical($e); + throw new InputException('Unable to save address. Please, check input data.'); + } + return $quote->getBillingAddress()->getId(); + } + + /** + * {@inheritDoc} + */ + public function get($cartId) + { + $cart = $this->quoteRepository->getActive($cartId); + return $cart->getBillingAddress(); + } +} diff --git a/app/code/Magento/Checkout/Model/Cart/Access/WritePlugin.php b/app/code/Magento/Quote/Model/Cart/Access/CartManagementPlugin.php similarity index 81% rename from app/code/Magento/Checkout/Model/Cart/Access/WritePlugin.php rename to app/code/Magento/Quote/Model/Cart/Access/CartManagementPlugin.php index ee735b2e2aecb1ae8badeccd06270ee171ad0ca3..f46eee82917f5701cfd5c90a815b3a1c696e56ae 100644 --- a/app/code/Magento/Checkout/Model/Cart/Access/WritePlugin.php +++ b/app/code/Magento/Quote/Model/Cart/Access/CartManagementPlugin.php @@ -4,12 +4,12 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Model\Cart\Access; +namespace Magento\Quote\Model\Cart\Access; use Magento\Framework\Exception\AuthorizationException; use Magento\Authorization\Model\UserContextInterface; -class WritePlugin +class CartManagementPlugin { /** * @var UserContextInterface @@ -35,18 +35,20 @@ class WritePlugin /** * Check whether access is allowed for create cart resource * - * @param \Magento\Checkout\Service\V1\Cart\WriteServiceInterface $subject + * @param \Magento\Quote\Api\CartManagementInterface $subject * @param int $cartId * @param int $customerId + * @param int $storeId * * @return void * @throws AuthorizationException if access denied * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function beforeAssignCustomer( - \Magento\Checkout\Service\V1\Cart\WriteServiceInterface $subject, + \Magento\Quote\Api\CartManagementInterface $subject, $cartId, - $customerId + $customerId, + $storeId ) { if (!in_array($this->userContext->getUserType(), $this->allowedUserTypes)) { throw new AuthorizationException('Access denied'); diff --git a/app/code/Magento/Checkout/Model/Cart/Access/ReadPlugin.php b/app/code/Magento/Quote/Model/Cart/Access/CartRepositoryPlugin.php similarity index 78% rename from app/code/Magento/Checkout/Model/Cart/Access/ReadPlugin.php rename to app/code/Magento/Quote/Model/Cart/Access/CartRepositoryPlugin.php index 3424273af6b570c7abfa8f7e4e32a722c403d45c..562332c96dcf6c5161ffa3384820484282900310 100644 --- a/app/code/Magento/Checkout/Model/Cart/Access/ReadPlugin.php +++ b/app/code/Magento/Quote/Model/Cart/Access/CartRepositoryPlugin.php @@ -4,13 +4,13 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Model\Cart\Access; +namespace Magento\Quote\Model\Cart\Access; use Magento\Framework\Api\SearchCriteria; use Magento\Framework\Exception\AuthorizationException; use Magento\Authorization\Model\UserContextInterface; -class ReadPlugin +class CartRepositoryPlugin { /** * @var UserContextInterface @@ -36,15 +36,15 @@ class ReadPlugin /** * Check whether access is allowed for cart resource * - * @param \Magento\Checkout\Service\V1\Cart\ReadServiceInterface $subject + * @param \Magento\Quote\Api\CartRepositoryInterface $subject * @param int $cartId * * @return void * @throws AuthorizationException if access denied * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ - public function beforeGetCart( - \Magento\Checkout\Service\V1\Cart\ReadServiceInterface $subject, + public function beforeGet( + \Magento\Quote\Api\CartRepositoryInterface $subject, $cartId ) { if (!in_array($this->userContext->getUserType(), $this->allowedUserTypes)) { @@ -55,15 +55,15 @@ class ReadPlugin /** * Check whether access is allowed for cart list resource * - * @param \Magento\Checkout\Service\V1\Cart\ReadServiceInterface $subject + * @param \Magento\Quote\Api\CartRepositoryInterface $subject * @param SearchCriteria $searchCriteria * * @return void * @throws AuthorizationException if access denied * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ - public function beforeGetCartList( - \Magento\Checkout\Service\V1\Cart\ReadServiceInterface $subject, + public function beforeGetList( + \Magento\Quote\Api\CartRepositoryInterface $subject, SearchCriteria $searchCriteria ) { if (!in_array($this->userContext->getUserType(), $this->allowedUserTypes)) { diff --git a/app/code/Magento/Quote/Model/Cart/CartTotalRepository.php b/app/code/Magento/Quote/Model/Cart/CartTotalRepository.php new file mode 100644 index 0000000000000000000000000000000000000000..e0eda7e9b1c20ca8efd1b83afac2c0a6e601ba73 --- /dev/null +++ b/app/code/Magento/Quote/Model/Cart/CartTotalRepository.php @@ -0,0 +1,66 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Model\Cart; + +use Magento\Quote\Api; +use Magento\Quote\Model\QuoteRepository; +use Magento\Quote\Api\CartTotalRepositoryInterface; + +/** + * Cart totals data object. + */ +class CartTotalRepository implements CartTotalRepositoryInterface +{ + /** + * Cart totals builder. + * + * @var Api\Data\TotalsDataBuilder + */ + private $totalsBuilder; + + /** + * Quote repository. + * + * @var QuoteRepository + */ + private $quoteRepository; + + /** + * Constructs a cart totals data object. + * + * @param Api\Data\TotalsDataBuilder $totalsBuilder Cart totals builder. + * @param QuoteRepository $quoteRepository Quote repository. + */ + public function __construct( + Api\Data\TotalsDataBuilder $totalsBuilder, + QuoteRepository $quoteRepository + ) { + $this->totalsBuilder = $totalsBuilder; + $this->quoteRepository = $quoteRepository; + } + + /** + * {@inheritDoc} + * + * @param int $cartId The cart ID. + * @return Totals Quote totals data. + */ + public function get($cartId) + { + /** + * Quote. + * + * @var \Magento\Quote\Model\Quote $quote + */ + $quote = $this->quoteRepository->getActive($cartId); + $shippingAddress = $quote->getShippingAddress(); + $totals = array_merge($shippingAddress->getData(), $quote->getData()); + $this->totalsBuilder->populateWithArray($totals); + $this->totalsBuilder->setItems($quote->getAllItems()); + + return $this->totalsBuilder->create(); + } +} diff --git a/app/code/Magento/Quote/Model/Cart/Currency.php b/app/code/Magento/Quote/Model/Cart/Currency.php new file mode 100644 index 0000000000000000000000000000000000000000..343d02d04638b0de280f0f14849e1fcf02741697 --- /dev/null +++ b/app/code/Magento/Quote/Model/Cart/Currency.php @@ -0,0 +1,77 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Model\Cart; + +/** + * @codeCoverageIgnore + */ +class Currency extends \Magento\Framework\Model\AbstractExtensibleModel implements + \Magento\Quote\Api\Data\CurrencyInterface +{ + /** + * {@inheritdoc} + */ + public function getGlobalCurrencyCode() + { + return $this->getData('global_currency_code'); + } + + /** + * {@inheritdoc} + */ + public function getBaseCurrencyCode() + { + return $this->getData('base_currency_code'); + } + + /** + * {@inheritdoc} + */ + public function getStoreCurrencyCode() + { + return $this->getData('store_currency_code'); + } + + /** + * {@inheritdoc} + */ + public function getQuoteCurrencyCode() + { + return $this->getData('quote_currency_code'); + } + + /** + * {@inheritdoc} + */ + public function getStoreToBaseRate() + { + return $this->getData('store_to_base_rate'); + } + + /** + * {@inheritdoc} + */ + public function getStoreToQuoteRate() + { + return $this->getData('store_to_quote_rate'); + } + + /** + * {@inheritdoc} + */ + public function getBaseToGlobalRate() + { + return $this->getData('base_to_global_rate'); + } + + /** + * {@inheritdoc} + */ + public function getBaseToQuoteRate() + { + return $this->getData('base_to_quote_rate'); + } +} diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/ShippingMethod.php b/app/code/Magento/Quote/Model/Cart/ShippingMethod.php similarity index 72% rename from app/code/Magento/Checkout/Service/V1/Data/Cart/ShippingMethod.php rename to app/code/Magento/Quote/Model/Cart/ShippingMethod.php index 2b0d921bdfa5bfba75a8e2310d5a8ea2e38d82a2..7d12d08caa4826d9af91d9c9a52645cc8a36949c 100644 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/ShippingMethod.php +++ b/app/code/Magento/Quote/Model/Cart/ShippingMethod.php @@ -3,50 +3,18 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Data\Cart; +namespace Magento\Quote\Model\Cart; + +use Magento\Quote\Api\Data\ShippingMethodInterface; /** * Quote shipping method data. * * @codeCoverageIgnore */ -class ShippingMethod extends \Magento\Framework\Api\AbstractExtensibleObject +class ShippingMethod extends \Magento\Framework\Api\AbstractExtensibleObject implements + ShippingMethodInterface { - /** - * Shipping carrier code. - */ - const CARRIER_CODE = 'carrier_code'; - - /** - * Shipping method code. - */ - const METHOD_CODE = 'method_code'; - - /** - * Shipping carrier title. - */ - const CARRIER_TITLE = 'carrier_title'; - - /** - * Shipping method title. - */ - const METHOD_TITLE = 'method_title'; - - /** - * Shipping amount in store currency. - */ - const SHIPPING_AMOUNT = 'amount'; - - /** - * Shipping amount in base currency. - */ - const BASE_SHIPPING_AMOUNT = 'base_amount'; - - /** - * Available. - */ - const AVAILABLE = 'available'; - /** * Returns the shipping carrier code. * @@ -111,6 +79,7 @@ class ShippingMethod extends \Magento\Framework\Api\AbstractExtensibleObject * Returns the value of the availability flag for the current shipping method. * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getAvailable() { diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/ShippingMethodConverter.php b/app/code/Magento/Quote/Model/Cart/ShippingMethodConverter.php similarity index 87% rename from app/code/Magento/Checkout/Service/V1/Data/Cart/ShippingMethodConverter.php rename to app/code/Magento/Quote/Model/Cart/ShippingMethodConverter.php index b232b4629deb7ce6b41c1233c5806e48b8ea1af2..6a41f4a20ab267a29788320f4a600e5b56d2f435 100644 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/ShippingMethodConverter.php +++ b/app/code/Magento/Quote/Model/Cart/ShippingMethodConverter.php @@ -3,30 +3,29 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Data\Cart; +namespace Magento\Quote\Model\Cart; /** * Quote shipping method data. * - * @codeCoverageIgnore */ class ShippingMethodConverter { /** * Shipping method builder. * - * @var ShippingMethodBuilder + * @var \Magento\Quote\Api\Data\ShippingMethodDataBuilder */ protected $builder; /** * Constructs a shipping method builder object. * - * @param ShippingMethodBuilder $builder Shipping method builder. + * @param \Magento\Quote\Api\Data\ShippingMethodDataBuilder $builder Shipping method builder. * @param \Magento\Store\Model\StoreManagerInterface $storeManager Store manager interface. */ public function __construct( - \Magento\Checkout\Service\V1\Data\Cart\ShippingMethodBuilder $builder, + \Magento\Quote\Api\Data\ShippingMethodDataBuilder $builder, \Magento\Store\Model\StoreManagerInterface $storeManager ) { $this->builder = $builder; diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/Totals.php b/app/code/Magento/Quote/Model/Cart/Totals.php similarity index 75% rename from app/code/Magento/Checkout/Service/V1/Data/Cart/Totals.php rename to app/code/Magento/Quote/Model/Cart/Totals.php index f76f1e115a567ae1832c096140837464bb2e834b..db3783fe0a9bb1a6330e3d2ce112318a0bbf9f60 100644 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/Totals.php +++ b/app/code/Magento/Quote/Model/Cart/Totals.php @@ -3,14 +3,17 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Data\Cart; +namespace Magento\Quote\Model\Cart; + +use Magento\Quote\Api\Data\TotalsInterface; +use Magento\Framework\Model\AbstractExtensibleModel; /** * Cart Totals * * @codeCoverageIgnore */ -class Totals extends \Magento\Framework\Api\AbstractExtensibleObject +class Totals extends AbstractExtensibleModel implements TotalsInterface { /* TOTALS */ const GRAND_TOTAL = 'grand_total'; @@ -54,7 +57,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getGrandTotal() { - return $this->_get(self::GRAND_TOTAL); + return $this->getData(self::GRAND_TOTAL); } /** @@ -64,7 +67,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseGrandTotal() { - return $this->_get(self::BASE_GRAND_TOTAL); + return $this->getData(self::BASE_GRAND_TOTAL); } /** @@ -74,7 +77,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getSubtotal() { - return $this->_get(self::SUBTOTAL); + return $this->getData(self::SUBTOTAL); } /** @@ -84,7 +87,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseSubtotal() { - return $this->_get(self::BASE_SUBTOTAL); + return $this->getData(self::BASE_SUBTOTAL); } /** @@ -94,7 +97,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getDiscountAmount() { - return $this->_get(self::DISCOUNT_AMOUNT); + return $this->getData(self::DISCOUNT_AMOUNT); } /** @@ -104,7 +107,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseDiscountAmount() { - return $this->_get(self::BASE_DISCOUNT_AMOUNT); + return $this->getData(self::BASE_DISCOUNT_AMOUNT); } /** @@ -114,7 +117,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getSubtotalWithDiscount() { - return $this->_get(self::SUBTOTAL_WITH_DISCOUNT); + return $this->getData(self::SUBTOTAL_WITH_DISCOUNT); } /** @@ -124,7 +127,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseSubtotalWithDiscount() { - return $this->_get(self::BASE_SUBTOTAL_WITH_DISCOUNT); + return $this->getData(self::BASE_SUBTOTAL_WITH_DISCOUNT); } /** @@ -134,7 +137,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getShippingAmount() { - return $this->_get(self::SHIPPING_AMOUNT); + return $this->getData(self::SHIPPING_AMOUNT); } /** @@ -144,7 +147,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseShippingAmount() { - return $this->_get(self::BASE_SHIPPING_AMOUNT); + return $this->getData(self::BASE_SHIPPING_AMOUNT); } /** @@ -154,7 +157,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getShippingDiscountAmount() { - return $this->_get(self::SHIPPING_DISCOUNT_AMOUNT); + return $this->getData(self::SHIPPING_DISCOUNT_AMOUNT); } /** @@ -164,7 +167,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseShippingDiscountAmount() { - return $this->_get(self::BASE_SHIPPING_DISCOUNT_AMOUNT); + return $this->getData(self::BASE_SHIPPING_DISCOUNT_AMOUNT); } /** @@ -174,7 +177,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getTaxAmount() { - return $this->_get(self::TAX_AMOUNT); + return $this->getData(self::TAX_AMOUNT); } /** @@ -184,7 +187,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseTaxAmount() { - return $this->_get(self::BASE_TAX_AMOUNT); + return $this->getData(self::BASE_TAX_AMOUNT); } /** @@ -194,7 +197,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getShippingTaxAmount() { - return $this->_get(self::SHIPPING_TAX_AMOUNT); + return $this->getData(self::SHIPPING_TAX_AMOUNT); } /** @@ -204,7 +207,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseShippingTaxAmount() { - return $this->_get(self::BASE_SHIPPING_TAX_AMOUNT); + return $this->getData(self::BASE_SHIPPING_TAX_AMOUNT); } /** @@ -214,7 +217,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getSubtotalInclTax() { - return $this->_get(self::SUBTOTAL_INCL_TAX); + return $this->getData(self::SUBTOTAL_INCL_TAX); } /** @@ -224,7 +227,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseSubtotalInclTax() { - return $this->_get(self::BASE_SUBTOTAL_INCL_TAX); + return $this->getData(self::BASE_SUBTOTAL_INCL_TAX); } /** @@ -234,7 +237,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getShippingInclTax() { - return $this->_get(self::SHIPPING_INCL_TAX); + return $this->getData(self::SHIPPING_INCL_TAX); } /** @@ -244,7 +247,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseShippingInclTax() { - return $this->_get(self::BASE_SHIPPING_INCL_TAX); + return $this->getData(self::BASE_SHIPPING_INCL_TAX); } /** @@ -254,7 +257,7 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getBaseCurrencyCode() { - return $this->_get(self::BASE_CURRENCY_CODE); + return $this->getData(self::BASE_CURRENCY_CODE); } /** @@ -264,16 +267,16 @@ class Totals extends \Magento\Framework\Api\AbstractExtensibleObject */ public function getQuoteCurrencyCode() { - return $this->_get(self::QUOTE_CURRENCY_CODE); + return $this->getData(self::QUOTE_CURRENCY_CODE); } /** * Get totals by items * - * @return \Magento\Checkout\Service\V1\Data\Cart\Totals\Item[]|null + * @return \Magento\Quote\Api\Data\TotalsItemInterface[]|null */ public function getItems() { - return $this->_get(self::ITEMS); + return $this->getData(self::ITEMS); } } diff --git a/app/code/Magento/Checkout/Service/V1/Data/Cart/Totals/Item.php b/app/code/Magento/Quote/Model/Cart/Totals/Item.php similarity index 96% rename from app/code/Magento/Checkout/Service/V1/Data/Cart/Totals/Item.php rename to app/code/Magento/Quote/Model/Cart/Totals/Item.php index 7d81c3f85a756fc2cf383d0d84960dbaae937ad1..0ebed2fbadd184d086948f10d8f1f5b3ae4f2860 100644 --- a/app/code/Magento/Checkout/Service/V1/Data/Cart/Totals/Item.php +++ b/app/code/Magento/Quote/Model/Cart/Totals/Item.php @@ -3,14 +3,17 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Data\Cart\Totals; +namespace Magento\Quote\Model\Cart\Totals; + +use Magento\Quote\Api\Data\TotalsItemInterface; +use Magento\Framework\Api\AbstractExtensibleObject; /** * Cart item totals. * * @codeCoverageIgnore */ -class Item extends \Magento\Framework\Api\AbstractExtensibleObject +class Item extends AbstractExtensibleObject implements TotalsItemInterface { /** * Price. diff --git a/app/code/Magento/Checkout/Service/V1/Coupon/WriteService.php b/app/code/Magento/Quote/Model/CouponManagement.php similarity index 61% rename from app/code/Magento/Checkout/Service/V1/Coupon/WriteService.php rename to app/code/Magento/Quote/Model/CouponManagement.php index 7ce08e5e3f6cee785ffafb7a4291b17c417245b7..dc9fb49b6eacb87861b3fc8f0c468aacf8c9e5af 100644 --- a/app/code/Magento/Checkout/Service/V1/Coupon/WriteService.php +++ b/app/code/Magento/Quote/Model/CouponManagement.php @@ -1,19 +1,21 @@ <?php /** + * * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Coupon; -use Magento\Checkout\Service\V1\Data\Cart\CouponBuilder as CouponBuilder; +namespace Magento\Quote\Model; + +use \Magento\Quote\Api\CouponManagementInterface; use Magento\Framework\Exception\CouldNotDeleteException; use Magento\Framework\Exception\CouldNotSaveException; use Magento\Framework\Exception\NoSuchEntityException; /** - * Coupon write service object. + * Coupon management object. */ -class WriteService implements WriteServiceInterface +class CouponManagement implements CouponManagementInterface { /** * Quote repository. @@ -23,36 +25,30 @@ class WriteService implements WriteServiceInterface protected $quoteRepository; /** - * Coupon builder. - * - * @var CouponBuilder - */ - protected $couponBuilder; - - /** - * Constructs a coupon write service object. + * Constructs a coupon read service object. * * @param \Magento\Quote\Model\QuoteRepository $quoteRepository Quote repository. - * @param CouponBuilder $couponBuilder Coupon builder. */ public function __construct( - \Magento\Quote\Model\QuoteRepository $quoteRepository, - CouponBuilder $couponBuilder + \Magento\Quote\Model\QuoteRepository $quoteRepository ) { $this->quoteRepository = $quoteRepository; - $this->couponBuilder = $couponBuilder; } /** * {@inheritdoc} - * - * @param int $cartId The cart ID. - * @param \Magento\Checkout\Service\V1\Data\Cart\Coupon $couponCodeData The coupon code data. - * @return bool - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - * @throws \Magento\Framework\Exception\CouldNotSaveException The specified coupon could not be added. */ - public function set($cartId, \Magento\Checkout\Service\V1\Data\Cart\Coupon $couponCodeData) + public function get($cartId) + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->getActive($cartId); + return $quote->getCouponCode(); + } + + /** + * {@inheritdoc} + */ + public function set($cartId, $couponCode) { /** @var \Magento\Quote\Model\Quote $quote */ $quote = $this->quoteRepository->getActive($cartId); @@ -60,7 +56,6 @@ class WriteService implements WriteServiceInterface throw new NoSuchEntityException("Cart $cartId doesn't contain products"); } $quote->getShippingAddress()->setCollectShippingRates(true); - $couponCode = trim($couponCodeData->getCouponCode()); try { $quote->setCouponCode($couponCode); @@ -76,13 +71,8 @@ class WriteService implements WriteServiceInterface /** * {@inheritdoc} - * - * @param int $cartId The cart ID. - * @return bool - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart does not exist. - * @throws \Magento\Framework\Exception\CouldNotDeleteException The specified coupon could not be deleted. */ - public function delete($cartId) + public function remove($cartId) { /** @var \Magento\Quote\Model\Quote $quote */ $quote = $this->quoteRepository->getActive($cartId); diff --git a/app/code/Magento/Quote/Model/PaymentMethodManagement.php b/app/code/Magento/Quote/Model/PaymentMethodManagement.php new file mode 100644 index 0000000000000000000000000000000000000000..37a61c905ff4f160f3e3c873fe3d6a46e15344d4 --- /dev/null +++ b/app/code/Magento/Quote/Model/PaymentMethodManagement.php @@ -0,0 +1,107 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Model; + +use Magento\Framework\Exception\State\InvalidTransitionException; + +class PaymentMethodManagement implements \Magento\Quote\Api\PaymentMethodManagementInterface +{ + /** + * @var \Magento\Quote\Model\QuoteRepository + */ + protected $quoteRepository; + + /** + * @var \Magento\Payment\Model\Checks\ZeroTotal + */ + protected $zeroTotalValidator; + + /** + * @var \Magento\Payment\Model\MethodList + */ + protected $methodList; + + /** + * @param QuoteRepository $quoteRepository + * @param \Magento\Payment\Model\Checks\ZeroTotal $zeroTotalValidator + * @param \Magento\Payment\Model\MethodList $methodList + */ + public function __construct( + \Magento\Quote\Model\QuoteRepository $quoteRepository, + \Magento\Payment\Model\Checks\ZeroTotal $zeroTotalValidator, + \Magento\Payment\Model\MethodList $methodList + ) { + $this->quoteRepository = $quoteRepository; + $this->zeroTotalValidator = $zeroTotalValidator; + $this->methodList = $methodList; + } + + /** + * {@inheritdoc} + */ + public function set($cartId, \Magento\Quote\Api\Data\PaymentInterface $method) + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->getActive($cartId); + + $method->setChecks([ + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_CHECKOUT, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_COUNTRY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_CURRENCY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_ORDER_TOTAL_MIN_MAX, + ]); + $payment = $quote->getPayment(); + $payment->importData($method->getData()); + + if ($quote->isVirtual()) { + // check if billing address is set + if (is_null($quote->getBillingAddress()->getCountryId())) { + throw new InvalidTransitionException('Billing address is not set'); + } + $quote->getBillingAddress()->setPaymentMethod($payment->getMethod()); + } else { + // check if shipping address is set + if (is_null($quote->getShippingAddress()->getCountryId())) { + throw new InvalidTransitionException('Shipping address is not set'); + } + $quote->getShippingAddress()->setPaymentMethod($payment->getMethod()); + } + if (!$quote->isVirtual() && $quote->getShippingAddress()) { + $quote->getShippingAddress()->setCollectShippingRates(true); + } + + if (!$this->zeroTotalValidator->isApplicable($payment->getMethodInstance(), $quote)) { + throw new InvalidTransitionException('The requested Payment Method is not available.'); + } + + $quote->setTotalsCollectedFlag(false)->collectTotals()->save(); + return $quote->getPayment()->getId(); + } + + /** + * {@inheritdoc} + */ + public function get($cartId) + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->getActive($cartId); + $payment = $quote->getPayment(); + if (!$payment->getId()) { + return null; + } + return $payment; + } + + /** + * {@inheritdoc} + */ + public function getList($cartId) + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->getActive($cartId); + return $this->methodList->getAvailableMethods($quote); + } +} diff --git a/app/code/Magento/Quote/Model/Quote.php b/app/code/Magento/Quote/Model/Quote.php index 57cc6983b6228a645a1e9628a32836be3cf17b61..9b46dff721101aad8a071638b96c6fc757fd7ee2 100644 --- a/app/code/Magento/Quote/Model/Quote.php +++ b/app/code/Magento/Quote/Model/Quote.php @@ -3,14 +3,18 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Quote\Model; use Magento\Customer\Api\Data\CustomerInterface; use Magento\Customer\Api\Data\GroupInterface; -use Magento\Framework\Model\AbstractModel; +use Magento\Framework\Model\AbstractExtensibleModel; use Magento\Quote\Model\Quote\Address; use Magento\Sales\Model\Resource; use Magento\Sales\Model\Status; +use Magento\Framework\Api\AttributeDataBuilder; /** * Quote model @@ -23,22 +27,15 @@ use Magento\Sales\Model\Status; * sales_quote_delete_after * * @method Quote setStoreId(int $value) - * @method string getCreatedAt() * @method Quote setCreatedAt(string $value) - * @method string getUpdatedAt() * @method Quote setUpdatedAt(string $value) - * @method string getConvertedAt() * @method Quote setConvertedAt(string $value) - * @method int getIsActive() * @method Quote setIsActive(int $value) * @method Quote setIsVirtual(int $value) * @method int getIsMultiShipping() * @method Quote setIsMultiShipping(int $value) - * @method int getItemsCount() * @method Quote setItemsCount(int $value) - * @method float getItemsQty() * @method Quote setItemsQty(float $value) - * @method int getOrigOrderId() * @method Quote setOrigOrderId(int $value) * @method float getStoreToBaseRate() * @method Quote setStoreToBaseRate(float $value) @@ -73,17 +70,13 @@ use Magento\Sales\Model\Status; * @method Quote setCustomerSuffix(string $value) * @method string getCustomerDob() * @method Quote setCustomerDob(string $value) - * @method string getCustomerNote() * @method Quote setCustomerNote(string $value) - * @method int getCustomerNoteNotify() * @method Quote setCustomerNoteNotify(int $value) - * @method int getCustomerIsGuest() * @method Quote setCustomerIsGuest(int $value) * @method string getRemoteIp() * @method Quote setRemoteIp(string $value) * @method string getAppliedRuleIds() * @method Quote setAppliedRuleIds(string $value) - * @method string getReservedOrderId() * @method Quote setReservedOrderId(string $value) * @method string getPasswordHash() * @method Quote setPasswordHash(string $value) @@ -119,8 +112,12 @@ use Magento\Sales\Model\Status; * @method Quote setIsPersistent(bool $value) * @method Quote setSharedStoreIds(array $values) * @method Quote setWebsite($value) + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ -class Quote extends \Magento\Framework\Model\AbstractModel +class Quote extends AbstractExtensibleModel implements \Magento\Quote\Api\Data\CartInterface { /** * Checkout login method key @@ -328,10 +325,17 @@ class Quote extends \Magento\Framework\Model\AbstractModel */ protected $customerRepository; + /** + * @var Cart\CurrencyFactory + */ + protected $currencyFactory; + /** * @param \Magento\Framework\Model\Context $context * @param \Magento\Framework\Registry $registry - * @param \Magento\Quote\Model\QuoteValidator $quoteValidator + * @param \Magento\Framework\Api\MetadataServiceInterface $metadataService + * @param AttributeDataBuilder $customAttributeBuilder + * @param QuoteValidator $quoteValidator * @param \Magento\Catalog\Helper\Product $catalogProduct * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig * @param \Magento\Store\Model\StoreManagerInterface $storeManager @@ -357,13 +361,17 @@ class Quote extends \Magento\Framework\Model\AbstractModel * @param \Magento\Customer\Api\Data\CustomerDataBuilder $customerBuilder * @param \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository * @param \Magento\Framework\Api\ExtensibleDataObjectConverter $extensibleDataObjectConverter + * @param Cart\CurrencyFactory $currencyFactory * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, \Magento\Framework\Registry $registry, + \Magento\Framework\Api\MetadataServiceInterface $metadataService, + AttributeDataBuilder $customAttributeBuilder, \Magento\Quote\Model\QuoteValidator $quoteValidator, \Magento\Catalog\Helper\Product $catalogProduct, \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, @@ -390,6 +398,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel \Magento\Customer\Api\Data\CustomerDataBuilder $customerBuilder, \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository, \Magento\Framework\Api\ExtensibleDataObjectConverter $extensibleDataObjectConverter, + \Magento\Quote\Model\Cart\CurrencyFactory $currencyFactory, \Magento\Framework\Model\Resource\AbstractResource $resource = null, \Magento\Framework\Data\Collection\Db $resourceCollection = null, array $data = [] @@ -420,7 +429,16 @@ class Quote extends \Magento\Framework\Model\AbstractModel $this->customerBuilder = $customerBuilder; $this->customerRepository = $customerRepository; $this->extensibleDataObjectConverter = $extensibleDataObjectConverter; - parent::__construct($context, $registry, $resource, $resourceCollection, $data); + $this->currencyFactory = $currencyFactory; + parent::__construct( + $context, + $registry, + $metadataService, + $customAttributeBuilder, + $resource, + $resourceCollection, + $data + ); } /** @@ -433,6 +451,126 @@ class Quote extends \Magento\Framework\Model\AbstractModel $this->_init('Magento\Quote\Model\Resource\Quote'); } + /** + * @codeCoverageIgnoreStart + * + * {@inheritdoc} + */ + public function getCurrency() + { + $currency = $this->getData('currency'); + if (!$currency) { + $currency = $this->currencyFactory->create() + ->setGlobalCurrencyCode($this->getGlobalCurrencyCode()) + ->setBaseCurrencyCode($this->getBaseCurrencyCode()) + ->setStoreCurrencyCode($this->getStoreCurrencyCode()) + ->setQuoteCurrencyCode($this->getQuoteCurrencyCode()) + ->setStoreToBaseRate($this->getStoreToBaseRate()) + ->setStoreToQuoteRate($this->getStoreToQuoteRate()) + ->setBaseToGlobalRate($this->getBaseToGlobalRate()) + ->setBaseToQuoteRate($this->getBaseToQuoteRate()); + } + return $currency; + } + + /** + * {@inheritdoc} + */ + public function getItems() + { + return $this->_getData('items'); + } + + /** + * {@inheritdoc} + */ + public function getCreatedAt() + { + return $this->_getData('created_at'); + } + + /** + * {@inheritdoc} + */ + public function getUpdatedAt() + { + return $this->_getData('updated_at'); + } + + /** + * {@inheritdoc} + */ + public function getConvertedAt() + { + return $this->_getData('converted_at'); + } + + /** + * {@inheritdoc} + */ + public function getIsActive() + { + return $this->_getData('is_active'); + } + + /** + * {@inheritdoc} + */ + public function getItemsCount() + { + return $this->_getData('items_count'); + } + + /** + * {@inheritdoc} + */ + public function getItemsQty() + { + return $this->_getData('items_qty'); + } + + /** + * {@inheritdoc} + */ + public function getOrigOrderId() + { + return $this->_getData('orig_order_id'); + + } + + /** + * {@inheritdoc} + */ + public function getReservedOrderId() + { + return $this->_getData('reserved_order_id'); + } + + /** + * {@inheritdoc} + */ + public function getCustomerIsGuest() + { + return $this->_getData('customer_is_guest'); + } + + /** + * {@inheritdoc} + */ + public function getCustomerNote() + { + return $this->_getData('customer_note'); + } + + /** + * {@inheritdoc} + */ + public function getCustomerNoteNotify() + { + return $this->_getData('customer_note_notify'); + } + //@codeCoverageIgnoreEnd + /** * Get quote store identifier * @@ -786,9 +924,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel } /** - * Get customer tax class ID. - * - * @return string + * {@inheritdoc} */ public function getCustomerTaxClassId() { @@ -1060,6 +1196,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel * * @param bool $useCache * @return \Magento\Eav\Model\Entity\Collection\AbstractCollection + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getItemsCollection($useCache = true) { @@ -1269,6 +1406,8 @@ class Quote extends \Magento\Framework\Model\AbstractModel * @param null|string $processMode * @return \Magento\Quote\Model\Quote\Item|string * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function addProduct( \Magento\Catalog\Model\Product $product, @@ -1356,6 +1495,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel * @param \Magento\Catalog\Model\Product $product * @param int $qty * @return \Magento\Quote\Model\Quote\Item + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _addCatalogProduct(\Magento\Catalog\Model\Product $product, $qty = 1) { @@ -1410,6 +1550,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel * @throws \Magento\Framework\Model\Exception * * @see \Magento\Catalog\Helper\Product::addParamsToBuyRequest() + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function updateItem($itemId, $buyRequest, $params = null) { @@ -1586,6 +1727,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel /** * @param string $paymentId * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getPaymentById($paymentId) { @@ -1918,6 +2060,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel * @param string $type An internal error type ('error', 'qty', etc.), passed then to adding messages routine * @param array $params * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function removeErrorInfosByParams($type, $params) { @@ -2008,6 +2151,8 @@ class Quote extends \Magento\Framework\Model\AbstractModel /** * @param bool $multishipping * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validateMinimumAmount($multishipping = false) { @@ -2099,6 +2244,7 @@ class Quote extends \Magento\Framework\Model\AbstractModel * Check quote for virtual product only * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsVirtual() { diff --git a/app/code/Magento/Quote/Model/Quote/Address.php b/app/code/Magento/Quote/Model/Quote/Address.php index 8435303c8dff0ea595474ae4b39b537c6a493ec0..b05e8b9cc713591b1084345baf1fbb0607b77b6e 100644 --- a/app/code/Magento/Quote/Model/Quote/Address.php +++ b/app/code/Magento/Quote/Model/Quote/Address.php @@ -19,7 +19,6 @@ use Magento\Framework\Api\AttributeDataBuilder; * @method Address setCreatedAt(string $value) * @method string getUpdatedAt() * @method Address setUpdatedAt(string $value) - * @method int getCustomerId() * @method Address setCustomerId(int $value) * @method int getSaveInAddressBook() * @method Address setSaveInAddressBook(int $value) @@ -29,14 +28,12 @@ use Magento\Framework\Api\AttributeDataBuilder; * @method Address setCustomerAddressData(\Magento\Customer\Api\Data\AddressInterface $value) * @method string getAddressType() * @method Address setAddressType(string $value) - * @method string getEmail() * @method Address setEmail(string $value) * @method Address setPrefix(string $value) * @method Address setFirstname(string $value) * @method Address setMiddlename(string $value) * @method Address setLastname(string $value) * @method Address setSuffix(string $value) - * @method string getCompany() * @method Address setCompany(string $value) * @method Address setCity(string $value) * @method Address setRegion(string $value) @@ -44,7 +41,6 @@ use Magento\Framework\Api\AttributeDataBuilder; * @method Address setPostcode(string $value) * @method Address setCountryId(string $value) * @method Address setTelephone(string $value) - * @method string getFax() * @method Address setFax(string $value) * @method int getSameAsBilling() * @method Address setSameAsBilling(int $value) @@ -112,8 +108,13 @@ use Magento\Framework\Api\AttributeDataBuilder; * @method \Magento\SalesRule\Model\Rule[] getCartFixedRules() * @method int[] getAppliedRuleIds() * @method Address setBaseShippingInclTax(float $value) + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ -class Address extends \Magento\Customer\Model\Address\AbstractAddress +class Address extends \Magento\Customer\Model\Address\AbstractAddress implements + \Magento\Quote\Api\Data\AddressInterface { const RATES_FETCH = 1; @@ -234,6 +235,11 @@ class Address extends \Magento\Customer\Model\Address\AbstractAddress */ protected $addressMapper; + /** + * @var Address\RateRequestFactory + */ + protected $_rateRequestFactory; + /** * @param \Magento\Framework\Model\Context $context * @param \Magento\Framework\Registry $registry @@ -263,6 +269,7 @@ class Address extends \Magento\Customer\Model\Address\AbstractAddress * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -561,6 +568,8 @@ class Address extends \Magento\Customer\Model\Address\AbstractAddress * Get all available address items * * @return \Magento\Quote\Model\Quote\Address\Item[] + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getAllItems() { @@ -949,6 +958,8 @@ class Address extends \Magento\Customer\Model\Address\AbstractAddress * * @param \Magento\Quote\Model\Quote\Item\AbstractItem $item * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function requestShippingRates(\Magento\Quote\Model\Quote\Item\AbstractItem $item = null) { @@ -1176,6 +1187,7 @@ class Address extends \Magento\Customer\Model\Address\AbstractAddress * @param float $value * @param bool $alreadyExclTax * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setShippingAmount($value, $alreadyExclTax = false) { @@ -1188,6 +1200,7 @@ class Address extends \Magento\Customer\Model\Address\AbstractAddress * @param float $value * @param bool $alreadyExclTax * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setBaseShippingAmount($value, $alreadyExclTax = false) { @@ -1337,4 +1350,127 @@ class Address extends \Magento\Customer\Model\Address\AbstractAddress { return $this->validator; } + + /** + * {@inheritdoc} + * @codeCoverageIgnoreStart + */ + public function getCountryId() + { + return $this->getData(self::KEY_COUNTRY_ID); + } + + /** + * {@inheritdoc} + */ + public function getStreet() + { + $street = $this->getData(self::KEY_STREET); + return explode("\n", $street); + } + + /** + * {@inheritdoc} + */ + public function getCompany() + { + return $this->getData(self::KEY_COMPANY); + } + + /** + * {@inheritdoc} + */ + public function getTelephone() + { + return $this->getData(self::KEY_TELEPHONE); + } + + /** + * {@inheritdoc} + */ + public function getFax() + { + return $this->getData(self::KEY_FAX); + } + + /** + * {@inheritdoc} + */ + public function getPostcode() + { + return $this->getData(self::KEY_POSTCODE); + } + + /** + * {@inheritdoc} + */ + public function getCity() + { + return $this->getData(self::KEY_CITY); + } + + /** + * {@inheritdoc} + */ + public function getFirstname() + { + return $this->getData(self::KEY_FIRSTNAME); + } + + /** + * {@inheritdoc} + */ + public function getLastname() + { + return $this->getData(self::KEY_LASTNAME); + } + + /** + * {@inheritdoc} + */ + public function getMiddlename() + { + return $this->getData(self::KEY_MIDDLENAME); + } + + /** + * {@inheritdoc} + */ + public function getPrefix() + { + return $this->getData(self::KEY_PREFIX); + } + + /** + * {@inheritdoc} + */ + public function getSuffix() + { + return $this->getData(self::KEY_SUFFIX); + } + + /** + * {@inheritdoc} + */ + public function getVatId() + { + return $this->getData(self::KEY_VAT_ID); + } + + /** + * {@inheritdoc} + */ + public function getCustomerId() + { + return $this->getData(self::KEY_CUSTOMER_ID); + } + + /** + * {@inheritdoc} + */ + public function getEmail() + { + return $this->getData(self::KEY_EMAIL); + } + //@codeCoverageIgnoreEnd } diff --git a/app/code/Magento/Quote/Model/Quote/Address/Total/AbstractTotal.php b/app/code/Magento/Quote/Model/Quote/Address/Total/AbstractTotal.php index 43371a61ac4e8dfad061af4156e3a401c988525f..3fc97522eaa26de16783c9eba121a8bc8efc7d5b 100644 --- a/app/code/Magento/Quote/Model/Quote/Address/Total/AbstractTotal.php +++ b/app/code/Magento/Quote/Model/Quote/Address/Total/AbstractTotal.php @@ -7,6 +7,7 @@ namespace Magento\Quote\Model\Quote\Address\Total; /** * Sales Quote Address Total abstract model + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractTotal { @@ -231,6 +232,7 @@ abstract class AbstractTotal * * @param \Magento\Quote\Model\Quote\Item\AbstractItem $item * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsItemRowTotalCompoundable(\Magento\Quote\Model\Quote\Item\AbstractItem $item) { @@ -247,6 +249,7 @@ abstract class AbstractTotal * @param array $config * @param store $store * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function processConfigArray($config, $store) { diff --git a/app/code/Magento/Quote/Model/Quote/Address/Total/Collector.php b/app/code/Magento/Quote/Model/Quote/Address/Total/Collector.php index 871f25cca448fc7cac24a5c7fad66e3aa5bf61ea..bc19616dd902fc7882111f38db335d6daddb5377 100644 --- a/app/code/Magento/Quote/Model/Quote/Address/Total/Collector.php +++ b/app/code/Magento/Quote/Model/Quote/Address/Total/Collector.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Quote\Model\Quote\Address\Total; /** @@ -138,6 +141,7 @@ class Collector extends \Magento\Sales\Model\Config\Ordered * Initialize retrievers array * * @return $this + * @SuppressWarnings(PHPMD.UnusedPrivateMethod) */ private function _initRetrievers() { diff --git a/app/code/Magento/Quote/Model/Quote/Address/Total/Discount.php b/app/code/Magento/Quote/Model/Quote/Address/Total/Discount.php index 0b966bc1f09aad641b5a02bc7418a715d7fd8c62..aa50ef3fbe82259882832ba86d04269c49ebdd72 100644 --- a/app/code/Magento/Quote/Model/Quote/Address/Total/Discount.php +++ b/app/code/Magento/Quote/Model/Quote/Address/Total/Discount.php @@ -34,6 +34,7 @@ class Discount extends \Magento\Quote\Model\Quote\Address\Total\AbstractTotal /** * @param \Magento\Quote\Model\Quote\Address $address * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function collect(\Magento\Quote\Model\Quote\Address $address) { diff --git a/app/code/Magento/Quote/Model/Quote/Address/Total/Shipping.php b/app/code/Magento/Quote/Model/Quote/Address/Total/Shipping.php index 74c617ff304232d2febe75f2ed3ad6956900f967..50627185999fdf43dca48fda3b112f9b858c0d59 100644 --- a/app/code/Magento/Quote/Model/Quote/Address/Total/Shipping.php +++ b/app/code/Magento/Quote/Model/Quote/Address/Total/Shipping.php @@ -29,6 +29,9 @@ class Shipping extends \Magento\Quote\Model\Quote\Address\Total\AbstractTotal * * @param \Magento\Quote\Model\Quote\Address $address * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function collect(\Magento\Quote\Model\Quote\Address $address) { diff --git a/app/code/Magento/Quote/Model/Quote/Address/Total/Tax.php b/app/code/Magento/Quote/Model/Quote/Address/Total/Tax.php index 5cb075d4fad977c32e4261413055030c9c3f6f19..d2ed16c319f8f96ae39edcf8ff44ac7216e5e800 100644 --- a/app/code/Magento/Quote/Model/Quote/Address/Total/Tax.php +++ b/app/code/Magento/Quote/Model/Quote/Address/Total/Tax.php @@ -60,6 +60,9 @@ class Tax extends \Magento\Quote\Model\Quote\Address\Total\AbstractTotal /** * @param \Magento\Quote\Model\Quote\Address $address * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function collect(\Magento\Quote\Model\Quote\Address $address) { diff --git a/app/code/Magento/Quote/Model/Quote/Item.php b/app/code/Magento/Quote/Model/Quote/Item.php index 27808700ed1fe43fc53dbb2995e46c2c2830a3f2..80df19e6741dcb68a18321be00301336f67be031 100644 --- a/app/code/Magento/Quote/Model/Quote/Item.php +++ b/app/code/Magento/Quote/Model/Quote/Item.php @@ -3,20 +3,23 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Quote\Model\Quote; +use Magento\Framework\Api\AttributeDataBuilder; +use Magento\Framework\Api\MetadataServiceInterface; + /** * Sales Quote Item Model * * @method \Magento\Quote\Model\Resource\Quote\Item _getResource() * @method \Magento\Quote\Model\Resource\Quote\Item getResource() - * @method int getQuoteId() - * @method \Magento\Quote\Model\Quote\Item setQuoteId(int $value) * @method string getCreatedAt() * @method \Magento\Quote\Model\Quote\Item setCreatedAt(string $value) * @method string getUpdatedAt() * @method \Magento\Quote\Model\Quote\Item setUpdatedAt(string $value) - * @method int getProductId() * @method \Magento\Quote\Model\Quote\Item setProductId(int $value) * @method int getStoreId() * @method \Magento\Quote\Model\Quote\Item setStoreId(int $value) @@ -24,10 +27,6 @@ namespace Magento\Quote\Model\Quote; * @method \Magento\Quote\Model\Quote\Item setParentItemId(int $value) * @method int getIsVirtual() * @method \Magento\Quote\Model\Quote\Item setIsVirtual(int $value) - * @method string getSku() - * @method \Magento\Quote\Model\Quote\Item setSku(string $value) - * @method string getName() - * @method \Magento\Quote\Model\Quote\Item setName(string $value) * @method string getDescription() * @method \Magento\Quote\Model\Quote\Item setDescription(string $value) * @method string getAdditionalData() @@ -97,8 +96,9 @@ namespace Magento\Quote\Model\Quote; * @method null|bool getHasConfigurationUnavailableError() * @method \Magento\Quote\Model\Quote\Item setHasConfigurationUnavailableError(bool $value) * @method \Magento\Quote\Model\Quote\Item unsHasConfigurationUnavailableError() + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ -class Item extends \Magento\Quote\Model\Quote\Item\AbstractItem +class Item extends \Magento\Quote\Model\Quote\Item\AbstractItem implements \Magento\Quote\Api\Data\CartItemInterface { /** * Prefix of model events names @@ -180,12 +180,14 @@ class Item extends \Magento\Quote\Model\Quote\Item\AbstractItem /** * @param \Magento\Framework\Model\Context $context * @param \Magento\Framework\Registry $registry - * @param \Magento\Catalog\Api\ProductRepositoryInterface $productRepository, + * @param MetadataServiceInterface $metadataService + * @param AttributeDataBuilder $customAttributeBuilder + * @param \Magento\Catalog\Api\ProductRepositoryInterface $productRepository * @param \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency * @param \Magento\Sales\Model\Status\ListFactory $statusListFactory * @param \Magento\Framework\Locale\FormatInterface $localeFormat * @param Item\OptionFactory $itemOptionFactory - * @param \Magento\Quote\Model\Quote\Item\Compare $quoteItemCompare + * @param Item\Compare $quoteItemCompare * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection @@ -196,6 +198,8 @@ class Item extends \Magento\Quote\Model\Quote\Item\AbstractItem public function __construct( \Magento\Framework\Model\Context $context, \Magento\Framework\Registry $registry, + MetadataServiceInterface $metadataService, + AttributeDataBuilder $customAttributeBuilder, \Magento\Catalog\Api\ProductRepositoryInterface $productRepository, \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency, \Magento\Sales\Model\Status\ListFactory $statusListFactory, @@ -215,6 +219,8 @@ class Item extends \Magento\Quote\Model\Quote\Item\AbstractItem parent::__construct( $context, $registry, + $metadataService, + $customAttributeBuilder, $productRepository, $priceCurrency, $resource, @@ -896,4 +902,55 @@ class Item extends \Magento\Quote\Model\Quote\Item\AbstractItem return $this; } + + /** + * @codeCoverageIgnoreStart + * + * {@inheritdoc} + */ + public function getItemId() + { + return $this->getData('item_id'); + } + + /** + * {@inheritdoc} + */ + public function getSku() + { + return $this->getData('sku'); + } + + /** + * {@inheritdoc} + */ + public function getQty() + { + return $this->getData('qty'); + } + + /** + * {@inheritdoc} + */ + public function getName() + { + return $this->getData('name'); + } + + /** + * {@inheritdoc} + */ + public function getPrice() + { + return $this->getData('price'); + } + + /** + * {@inheritdoc} + */ + public function getQuoteId() + { + return $this->getData('quote_id'); + } + //@codeCoverageIgnoreEnd } diff --git a/app/code/Magento/Quote/Model/Quote/Item/AbstractItem.php b/app/code/Magento/Quote/Model/Quote/Item/AbstractItem.php index 898ee30862e3590c92a53c127b83bdbd65fd5fa0..b1740148f0f03bd26ab9631bc15f040565deccf1 100644 --- a/app/code/Magento/Quote/Model/Quote/Item/AbstractItem.php +++ b/app/code/Magento/Quote/Model/Quote/Item/AbstractItem.php @@ -6,6 +6,7 @@ namespace Magento\Quote\Model\Quote\Item; use Magento\Quote\Model\Quote\Item; +use Magento\Framework\Api\AttributeDataBuilder; /** * Quote item abstract model @@ -42,8 +43,9 @@ use Magento\Quote\Model\Quote\Item; * @method float getDiscountTaxCompensation() * @method float getRowTotal() * @method float getPriceInclTax() + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ -abstract class AbstractItem extends \Magento\Framework\Model\AbstractModel implements +abstract class AbstractItem extends \Magento\Framework\Model\AbstractExtensibleModel implements \Magento\Catalog\Model\Product\Configuration\Item\ItemInterface { /** @@ -81,6 +83,8 @@ abstract class AbstractItem extends \Magento\Framework\Model\AbstractModel imple /** * @param \Magento\Framework\Model\Context $context * @param \Magento\Framework\Registry $registry + * @param \Magento\Framework\Api\MetadataServiceInterface $metadataService + * @param AttributeDataBuilder $customAttributeBuilder * @param \Magento\Catalog\Api\ProductRepositoryInterface $productRepository * @param \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency * @param \Magento\Framework\Model\Resource\AbstractResource $resource @@ -90,13 +94,23 @@ abstract class AbstractItem extends \Magento\Framework\Model\AbstractModel imple public function __construct( \Magento\Framework\Model\Context $context, \Magento\Framework\Registry $registry, + \Magento\Framework\Api\MetadataServiceInterface $metadataService, + AttributeDataBuilder $customAttributeBuilder, \Magento\Catalog\Api\ProductRepositoryInterface $productRepository, \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency, \Magento\Framework\Model\Resource\AbstractResource $resource = null, \Magento\Framework\Data\Collection\Db $resourceCollection = null, array $data = [] ) { - parent::__construct($context, $registry, $resource, $resourceCollection, $data); + parent::__construct( + $context, + $registry, + $metadataService, + $customAttributeBuilder, + $resource, + $resourceCollection, + $data + ); $this->productRepository = $productRepository; $this->priceCurrency = $priceCurrency; } diff --git a/app/code/Magento/Quote/Model/Quote/Item/Repository.php b/app/code/Magento/Quote/Model/Quote/Item/Repository.php new file mode 100644 index 0000000000000000000000000000000000000000..50c79c12f852f98830237bf6d48b7fe9f31aa9ef --- /dev/null +++ b/app/code/Magento/Quote/Model/Quote/Item/Repository.php @@ -0,0 +1,139 @@ +<?php +/** + * + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Model\Quote\Item; + +use Magento\Framework\Exception\CouldNotSaveException; +use Magento\Framework\Exception\InputException; +use Magento\Framework\Exception\NoSuchEntityException; + +class Repository implements \Magento\Quote\Api\CartItemRepositoryInterface +{ + /** + * Quote repository. + * + * @var \Magento\Quote\Model\QuoteRepository + */ + protected $quoteRepository; + + /** + * Product repository. + * + * @var \Magento\Catalog\Api\ProductRepositoryInterface + */ + protected $productRepository; + + /** + * @var \Magento\Quote\Api\Data\CartItemDataBuilder + */ + protected $itemDataBuilder; + + /** + * Constructs a read service object. + * + * @param \Magento\Quote\Model\QuoteRepository $quoteRepository + * @param \Magento\Catalog\Api\ProductRepositoryInterface $productRepository + * @param \Magento\Quote\Api\Data\CartItemDataBuilder $itemDataBuilder + */ + public function __construct( + \Magento\Quote\Model\QuoteRepository $quoteRepository, + \Magento\Catalog\Api\ProductRepositoryInterface $productRepository, + \Magento\Quote\Api\Data\CartItemDataBuilder $itemDataBuilder + ) { + $this->quoteRepository = $quoteRepository; + $this->productRepository = $productRepository; + $this->itemDataBuilder = $itemDataBuilder; + } + + /** + * {@inheritdoc} + */ + public function getList($cartId) + { + $output = []; + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->getActive($cartId); + + /** @var \Magento\Quote\Model\Quote\Item $item */ + foreach ($quote->getAllItems() as $item) { + $output[] = $item; + } + return $output; + } + + /** + * {@inheritdoc} + */ + public function save(\Magento\Quote\Api\Data\CartItemInterface $cartItem) + { + $qty = $cartItem->getQty(); + if (!is_numeric($qty) || $qty <= 0) { + throw InputException::invalidFieldValue('qty', $qty); + } + $cartId = $cartItem->getQuoteId(); + + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->getActive($cartId); + + $itemId = $cartItem->getItemId(); + try { + /** update item qty */ + if (isset($itemId)) { + $cartItem = $quote->getItemById($itemId); + if (!$cartItem) { + throw new NoSuchEntityException("Cart $cartId doesn't contain item $itemId"); + } + $product = $this->productRepository->get($cartItem->getSku()); + $cartItem->setData('qty', $qty); + } else { + $product = $this->productRepository->get($cartItem->getSku()); + $quote->addProduct($product, $qty); + } + $this->quoteRepository->save($quote->collectTotals()); + } catch (\Exception $e) { + if ($e instanceof NoSuchEntityException) { + throw $e; + } + throw new CouldNotSaveException('Could not save quote'); + } + return $quote->getItemByProduct($product); + } + + /** + * {@inheritdoc} + */ + public function delete(\Magento\Quote\Api\Data\CartItemInterface $cartItem) + { + $cartId = $cartItem->getQuoteId(); + $itemId = $cartItem->getItemId(); + /** + * Quote. + * + * @var \Magento\Quote\Model\Quote $quote + */ + $quote = $this->quoteRepository->getActive($cartId); + $quoteItem = $quote->getItemById($itemId); + if (!$quoteItem) { + throw new NoSuchEntityException("Cart $cartId doesn't contain item $itemId"); + } + try { + $quote->removeItem($itemId); + $this->quoteRepository->save($quote->collectTotals()); + } catch (\Exception $e) { + throw new CouldNotSaveException('Could not remove item from quote'); + } + } + + /** + * {@inheritdoc} + */ + public function deleteById($cartId, $itemId) + { + $item = $this->itemDataBuilder->setQuoteId($cartId)->setItemId($itemId)->create(); + $this->delete($item); + return true; + } +} diff --git a/app/code/Magento/Quote/Model/Quote/Item/Updater.php b/app/code/Magento/Quote/Model/Quote/Item/Updater.php index c1bff61908606e8bc9bccd7e587ec1c993ff0f8a..a71d872dc76405a5df8e3965c45d7b4014ad7e50 100644 --- a/app/code/Magento/Quote/Model/Quote/Item/Updater.php +++ b/app/code/Magento/Quote/Model/Quote/Item/Updater.php @@ -55,6 +55,7 @@ class Updater * @param array $info * @throws InvalidArgumentException * @return Updater + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function update(Item $item, array $info) { diff --git a/app/code/Magento/Quote/Model/Quote/Payment.php b/app/code/Magento/Quote/Model/Quote/Payment.php index b7ae2cf005ca8772d96216a5784f761e42019088..1b511c6d3428e384a11c9c689daf12bc395e717d 100644 --- a/app/code/Magento/Quote/Model/Quote/Payment.php +++ b/app/code/Magento/Quote/Model/Quote/Payment.php @@ -18,9 +18,7 @@ use Magento\Framework\Api\AttributeDataBuilder; * @method \Magento\Quote\Model\Quote\Payment setCreatedAt(string $value) * @method string getUpdatedAt() * @method \Magento\Quote\Model\Quote\Payment setUpdatedAt(string $value) - * @method string getMethod() * @method \Magento\Quote\Model\Quote\Payment setMethod(string $value) - * @method string getCcType() * @method \Magento\Quote\Model\Quote\Payment setCcType(string $value) * @method string getCcNumberEnc() * @method \Magento\Quote\Model\Quote\Payment setCcNumberEnc(string $value) @@ -34,16 +32,15 @@ use Magento\Framework\Api\AttributeDataBuilder; * @method \Magento\Quote\Model\Quote\Payment setCcSsStartMonth(int $value) * @method int getCcSsStartYear() * @method \Magento\Quote\Model\Quote\Payment setCcSsStartYear(int $value) - * @method string getPoNumber() * @method \Magento\Quote\Model\Quote\Payment setPoNumber(string $value) - * @method string getAdditionalData() * @method \Magento\Quote\Model\Quote\Payment setAdditionalData(string $value) * @method string getCcSsIssue() * @method \Magento\Quote\Model\Quote\Payment setCcSsIssue(string $value) * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ -class Payment extends \Magento\Payment\Model\Info +class Payment extends \Magento\Payment\Model\Info implements \Magento\Quote\Api\Data\PaymentInterface { /** * @var string @@ -78,6 +75,7 @@ class Payment extends \Magento\Payment\Model\Info * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -235,4 +233,81 @@ class Payment extends \Magento\Payment\Model\Info $method = parent::getMethodInstance(); return $method->setStore($this->getQuote()->getStore()); } + + /** + * @codeCoverageIgnoreStart + * + * {@inheritdoc} + */ + public function getPoNumber() + { + return $this->getData('po_number'); + } + + /** + * {@inheritdoc} + */ + public function getMethod() + { + return $this->getData('method'); + } + + /** + * {@inheritdoc} + */ + public function getCcOwner() + { + return $this->getData('cc_owner'); + } + + /** + * {@inheritdoc} + */ + public function getCcNumber() + { + return $this->getData('cc_number'); + } + + /** + * {@inheritdoc} + */ + public function getCcType() + { + return $this->getData('cc_type'); + } + + /** + * {@inheritdoc} + */ + public function getCcExpYear() + { + $expirationYear = $this->getData('cc_exp_year') ?: null; + return $expirationYear; + } + + /** + * {@inheritdoc} + */ + public function getCcExpMonth() + { + return $this->getData('cc_exp_month'); + } + + /** + * {@inheritdoc} + */ + public function getAdditionalData() + { + $additionalDataValue = $this->getData('additional_data'); + if (is_string($additionalDataValue)) { + $additionalData = @unserialize($additionalDataValue); + if (is_array($additionalData)) { + return $additionalData; + } + } elseif (is_array($additionalDataValue)) { + return $additionalDataValue; + } + return null; + } + //@codeCoverageIgnoreEnd } diff --git a/app/code/Magento/Checkout/Service/V1/Address/Validator.php b/app/code/Magento/Quote/Model/QuoteAddressValidator.php similarity index 89% rename from app/code/Magento/Checkout/Service/V1/Address/Validator.php rename to app/code/Magento/Quote/Model/QuoteAddressValidator.php index 1ca1d0677f2802531ae2da9afcf6ee2c48b29155..b195066721af0a0885cd49c631154d7fb0fe986a 100644 --- a/app/code/Magento/Checkout/Service/V1/Address/Validator.php +++ b/app/code/Magento/Quote/Model/QuoteAddressValidator.php @@ -3,10 +3,10 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Address; +namespace Magento\Quote\Model; -/** Quote shipping address validator service. */ -class Validator +/** Quote shipping/billing address validator service. */ +class QuoteAddressValidator { /** * Address factory. @@ -39,12 +39,12 @@ class Validator /** * Validates the fields in a specified address data object. * - * @param \Magento\Checkout\Service\V1\Data\Cart\Address $addressData The address data object. + * @param \Magento\Quote\Api\Data\AddressInterface $addressData The address data object. * @return bool * @throws \Magento\Framework\Exception\InputException The specified address belongs to another customer. * @throws \Magento\Framework\Exception\NoSuchEntityException The specified customer ID or address ID is not valid. */ - public function validate($addressData) + public function validate(\Magento\Quote\Api\Data\AddressInterface $addressData) { //validate customer id if ($addressData->getCustomerId()) { diff --git a/app/code/Magento/Quote/Model/QuoteManagement.php b/app/code/Magento/Quote/Model/QuoteManagement.php index e8c66eddd8a196a32974facea3b5d6bb30480086..7ff8097290597cf1d68362f18427680d498b0ef8 100644 --- a/app/code/Magento/Quote/Model/QuoteManagement.php +++ b/app/code/Magento/Quote/Model/QuoteManagement.php @@ -14,11 +14,16 @@ use Magento\Quote\Model\Quote\Address\ToOrder as ToOrderConverter; use Magento\Quote\Model\Quote\Address\ToOrderAddress as ToOrderAddressConverter; use Magento\Quote\Model\Quote\Item\ToOrderItem as ToOrderItemConverter; use Magento\Quote\Model\Quote\Payment\ToOrderPayment as ToOrderPaymentConverter; +use Magento\Authorization\Model\UserContextInterface; +use Magento\Framework\Exception\CouldNotSaveException; +use Magento\Framework\Exception\StateException; /** * Class QuoteManagement + * + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ -class QuoteManagement +class QuoteManagement implements \Magento\Quote\Api\CartManagementInterface { /** * @var EventManager @@ -65,6 +70,26 @@ class QuoteManagement */ protected $quotePaymentToOrderPayment; + /** + * @var UserContextInterface + */ + protected $userContext; + + /** + * @var QuoteRepository + */ + protected $quoteRepository; + + /** + * @var \Magento\Customer\Api\CustomerRepositoryInterface + */ + protected $customerRepository; + + /** + * @var \Magento\Customer\Model\CustomerFactory + */ + protected $customerModelFactory; + /** * @param EventManager $eventManager * @param QuoteValidator $quoteValidator @@ -75,6 +100,11 @@ class QuoteManagement * @param ToOrderAddressConverter $quoteAddressToOrderAddress * @param ToOrderItemConverter $quoteItemToOrderItem * @param ToOrderPaymentConverter $quotePaymentToOrderPayment + * @param UserContextInterface $userContext + * @param QuoteRepository $quoteRepository + * @param \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository + * @param \Magento\Customer\Model\CustomerFactory $customerModelFactory + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( EventManager $eventManager, @@ -85,7 +115,11 @@ class QuoteManagement ToOrderConverter $quoteAddressToOrder, ToOrderAddressConverter $quoteAddressToOrderAddress, ToOrderItemConverter $quoteItemToOrderItem, - ToOrderPaymentConverter $quotePaymentToOrderPayment + ToOrderPaymentConverter $quotePaymentToOrderPayment, + UserContextInterface $userContext, + QuoteRepository $quoteRepository, + \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository, + \Magento\Customer\Model\CustomerFactory $customerModelFactory ) { $this->eventManager = $eventManager; $this->quoteValidator = $quoteValidator; @@ -96,9 +130,119 @@ class QuoteManagement $this->quoteAddressToOrderAddress = $quoteAddressToOrderAddress; $this->quoteItemToOrderItem = $quoteItemToOrderItem; $this->quotePaymentToOrderPayment = $quotePaymentToOrderPayment; + $this->userContext = $userContext; + $this->quoteRepository = $quoteRepository; + $this->customerRepository = $customerRepository; + $this->customerModelFactory = $customerModelFactory; + } + + /** + * {@inheritdoc} + */ + public function createEmptyCart($storeId) + { + $quote = $this->userContext->getUserType() == UserContextInterface::USER_TYPE_CUSTOMER + ? $this->createCustomerCart($storeId) + : $this->createAnonymousCart($storeId); + + try { + $this->quoteRepository->save($quote); + } catch (\Exception $e) { + throw new CouldNotSaveException('Cannot create quote'); + } + return $quote->getId(); + } + + /** + * {@inheritdoc} + */ + public function assignCustomer($cartId, $customerId, $storeId) + { + $quote = $this->quoteRepository->getActive($cartId); + $customer = $this->customerRepository->getById($customerId); + $customerModel = $this->customerModelFactory->create(); + + if (!in_array($storeId, $customerModel->load($customerId)->getSharedStoreIds())) { + throw new StateException('Cannot assign customer to the given cart. The cart belongs to different store.'); + } + if ($quote->getCustomerId()) { + throw new StateException('Cannot assign customer to the given cart. The cart is not anonymous.'); + } + try { + $this->quoteRepository->getForCustomer($customerId); + throw new StateException('Cannot assign customer to the given cart. Customer already has active cart.'); + } catch (\Magento\Framework\Exception\NoSuchEntityException $e) { + + } + + $quote->setCustomer($customer); + $quote->setCustomerIsGuest(0); + $this->quoteRepository->save($quote); + return true; + + } + + /** + * Creates an anonymous cart. + * + * @param int $storeId + * @return \Magento\Quote\Model\Quote Cart object. + */ + protected function createAnonymousCart($storeId) + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->create(); + $quote->setStoreId($storeId); + return $quote; } /** + * Creates a cart for the currently logged-in customer. + * + * @param int $storeId + * @return \Magento\Quote\Model\Quote Cart object. + * @throws CouldNotSaveException The cart could not be created. + */ + protected function createCustomerCart($storeId) + { + $customer = $this->customerRepository->getById($this->userContext->getUserId()); + + try { + $this->quoteRepository->getActiveForCustomer($this->userContext->getUserId()); + throw new CouldNotSaveException('Cannot create quote'); + } catch (\Magento\Framework\Exception\NoSuchEntityException $e) { + + } + + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->create(); + $quote->setStoreId($storeId); + $quote->setCustomer($customer); + $quote->setCustomerIsGuest(0); + return $quote; + } + + /** + * {@inheritdoc} + */ + public function placeOrder($cartId) + { + $quote = $this->quoteRepository->getActive($cartId); + $order = $this->submit($quote); + return $order->getId(); + } + + /** + * {@inheritdoc} + */ + public function getCartForCustomer($customerId) + { + return $this->quoteRepository->getActiveForCustomer($customerId); + } + + /** + * Delete quote item + * * @param Quote $quote * @param array $orderData * @return \Magento\Framework\Model\AbstractExtensibleModel|\Magento\Sales\Api\Data\OrderInterface|object|void @@ -216,6 +360,7 @@ class QuoteManagement 'quote' => $quote ] ); + $this->quoteRepository->save($quote); } catch (\Exception $e) { $this->eventManager->dispatch( 'sales_model_service_quote_submit_failure', diff --git a/app/code/Magento/Quote/Model/QuoteRepository.php b/app/code/Magento/Quote/Model/QuoteRepository.php index b0c8927015f864c8268faf3042344ce9f40b8780..82c02292af678aa8d41d0fbd0df22a9e32452458 100644 --- a/app/code/Magento/Quote/Model/QuoteRepository.php +++ b/app/code/Magento/Quote/Model/QuoteRepository.php @@ -5,12 +5,15 @@ */ namespace Magento\Quote\Model; -use \Magento\Framework\Exception\NoSuchEntityException; +use Magento\Framework\Exception\NoSuchEntityException; use Magento\Quote\Model\Quote; -use Magento\Quote\Model\QuoteFactory; use Magento\Store\Model\StoreManagerInterface; +use Magento\Framework\Api\SearchCriteria; +use Magento\Framework\Api\Search\FilterGroup; +use Magento\Quote\Model\Resource\Quote\Collection as QuoteCollection; +use Magento\Framework\Exception\InputException; -class QuoteRepository +class QuoteRepository implements \Magento\Quote\Api\CartRepositoryInterface { /** * @var Quote[] @@ -32,16 +35,32 @@ class QuoteRepository */ protected $storeManager; + /** + * @var \Magento\Quote\Model\Resource\Quote\Collection + */ + protected $quoteCollection; + + /** + * @var \Magento\Quote\Api\Data\CartSearchResultsDataBuilder + */ + protected $searchResultsBuilder; + /** * @param QuoteFactory $quoteFactory * @param StoreManagerInterface $storeManager + * @param \Magento\Quote\Model\Resource\Quote\Collection $quoteCollection + * @param \Magento\Quote\Api\Data\CartSearchResultsDataBuilder $searchResultsBuilder */ public function __construct( QuoteFactory $quoteFactory, - StoreManagerInterface $storeManager + StoreManagerInterface $storeManager, + \Magento\Quote\Model\Resource\Quote\Collection $quoteCollection, + \Magento\Quote\Api\Data\CartSearchResultsDataBuilder $searchResultsBuilder ) { $this->quoteFactory = $quoteFactory; $this->storeManager = $storeManager; + $this->searchResultsBuilder = $searchResultsBuilder; + $this->quoteCollection = $quoteCollection; } /** @@ -61,7 +80,7 @@ class QuoteRepository * @param int $cartId * @param int[] $sharedStoreIds * @throws NoSuchEntityException - * @return Quote + * @return \Magento\Quote\Api\Data\CartInterface */ public function get($cartId, array $sharedStoreIds = []) { @@ -176,4 +195,55 @@ class QuoteRepository } return $quote; } + + /** + * {@inheritdoc} + */ + public function getList(\Magento\Framework\Api\SearchCriteria $searchCriteria) + { + $this->searchResultsBuilder->setSearchCriteria($searchCriteria); + + foreach ($searchCriteria->getFilterGroups() as $group) { + $this->addFilterGroupToCollection($group, $this->quoteCollection); + } + + $this->searchResultsBuilder->setTotalCount($this->quoteCollection->getSize()); + $sortOrders = $searchCriteria->getSortOrders(); + if ($sortOrders) { + foreach ($sortOrders as $sortOrder) { + $this->quoteCollection->addOrder( + $sortOrder->getField(), + $sortOrder->getDirection() == SearchCriteria::SORT_ASC ? 'ASC' : 'DESC' + ); + } + } + $this->quoteCollection->setCurPage($searchCriteria->getCurrentPage()); + $this->quoteCollection->setPageSize($searchCriteria->getPageSize()); + + $this->searchResultsBuilder->setItems($this->quoteCollection->getItems()); + + return $this->searchResultsBuilder->create(); + } + + /** + * Adds a specified filter group to the specified quote collection. + * + * @param FilterGroup $filterGroup The filter group. + * @param QuoteCollection $collection The quote collection. + * @return void + * @throws InputException The specified filter group or quote collection does not exist. + */ + protected function addFilterGroupToCollection(FilterGroup $filterGroup, QuoteCollection $collection) + { + $fields = []; + $conditions = []; + foreach ($filterGroup->getFilters() as $filter) { + $fields[] = $filter->getField(); + $condition = $filter->getConditionType() ? $filter->getConditionType() : 'eq'; + $conditions[] = [$condition => $filter->getValue()]; + } + if ($fields) { + $collection->addFieldToFilter($fields, $conditions); + } + } } diff --git a/app/code/Magento/Quote/Model/QuoteRepository/Plugin/Authorization.php b/app/code/Magento/Quote/Model/QuoteRepository/Plugin/Authorization.php index 9af85c916acdb18621cd428cf152dee24431f751..14b7752728d1143352592b7a567cac0f57653c48 100644 --- a/app/code/Magento/Quote/Model/QuoteRepository/Plugin/Authorization.php +++ b/app/code/Magento/Quote/Model/QuoteRepository/Plugin/Authorization.php @@ -32,6 +32,7 @@ class Authorization * @param \Magento\Quote\Model\Quote $quote * @return \Magento\Quote\Model\Quote * @throws \Magento\Framework\Exception\NoSuchEntityException + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterGetActive( \Magento\Quote\Model\QuoteRepository $subject, @@ -50,6 +51,7 @@ class Authorization * @param \Magento\Quote\Model\Quote $quote * @return \Magento\Quote\Model\Quote * @throws \Magento\Framework\Exception\NoSuchEntityException + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterGetActiveForCustomer( \Magento\Quote\Model\QuoteRepository $subject, diff --git a/app/code/Magento/Quote/Model/Resource/Quote.php b/app/code/Magento/Quote/Model/Resource/Quote.php index d712a93ee3bb1bd2d1d0fa4345a7915df74dc83c..fac8e129483c30bc6eec359ad5a3f77d7d207f54 100644 --- a/app/code/Magento/Quote/Model/Resource/Quote.php +++ b/app/code/Magento/Quote/Model/Resource/Quote.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Quote\Model\Resource; use Magento\Framework\Model\Resource\Db\AbstractDb; diff --git a/app/code/Magento/Quote/Model/Resource/Quote/Address/Attribute/Backend.php b/app/code/Magento/Quote/Model/Resource/Quote/Address/Attribute/Backend.php index ad0bff45a3cac4897ddb80f699b15cf32a468677..7724381733562f8017326482fe15e78ce2c74125 100644 --- a/app/code/Magento/Quote/Model/Resource/Quote/Address/Attribute/Backend.php +++ b/app/code/Magento/Quote/Model/Resource/Quote/Address/Attribute/Backend.php @@ -17,6 +17,7 @@ class Backend extends \Magento\Eav\Model\Entity\Attribute\Backend\AbstractBacken * * @param \Magento\Quote\Model\Quote\Address $address * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function collectTotals(\Magento\Quote\Model\Quote\Address $address) { diff --git a/app/code/Magento/Quote/Model/Resource/Quote/Address/Attribute/Frontend.php b/app/code/Magento/Quote/Model/Resource/Quote/Address/Attribute/Frontend.php index 4b834adc23fdf19f36faf7ce5d3880ced9e53b25..32351c123247545a2271167d28944cef0cead38f 100644 --- a/app/code/Magento/Quote/Model/Resource/Quote/Address/Attribute/Frontend.php +++ b/app/code/Magento/Quote/Model/Resource/Quote/Address/Attribute/Frontend.php @@ -17,6 +17,7 @@ class Frontend extends \Magento\Eav\Model\Entity\Attribute\Frontend\AbstractFron * * @param \Magento\Quote\Model\Quote\Address $address * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function fetchTotals(\Magento\Quote\Model\Quote\Address $address) { diff --git a/app/code/Magento/Quote/Model/Resource/Quote/Item/Collection.php b/app/code/Magento/Quote/Model/Resource/Quote/Item/Collection.php index 9c0b2bc67e38ead743bbf9f543ba98e17f7bb157..3de177e2915b46febf6b118e1046426fe4897227 100644 --- a/app/code/Magento/Quote/Model/Resource/Quote/Item/Collection.php +++ b/app/code/Magento/Quote/Model/Resource/Quote/Item/Collection.php @@ -183,6 +183,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac * Add products to items and item options * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _assignProducts() { diff --git a/app/code/Magento/Quote/Model/ShippingAddressManagement.php b/app/code/Magento/Quote/Model/ShippingAddressManagement.php new file mode 100644 index 0000000000000000000000000000000000000000..13b92793ab36844f3cdf414f76379990ebf86dda --- /dev/null +++ b/app/code/Magento/Quote/Model/ShippingAddressManagement.php @@ -0,0 +1,105 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Model; + +use Magento\Framework\Exception\InputException; +use Magento\Framework\Exception\NoSuchEntityException; +use Psr\Log\LoggerInterface as Logger; +use Magento\Quote\Api\ShippingAddressManagementInterface; + +/** Quote shipping address write service object. */ +class ShippingAddressManagement implements ShippingAddressManagementInterface +{ + /** + * Quote repository. + * + * @var \Magento\Quote\Model\QuoteRepository + */ + protected $quoteRepository; + + /** + * Logger. + * + * @var Logger + */ + protected $logger; + + /** + * Validator. + * + * @var QuoteAddressValidator + */ + protected $addressValidator; + + /** + * Constructs a quote shipping address write service object. + * + * @param QuoteRepository $quoteRepository + * @param QuoteAddressValidator $addressValidator + * @param Logger $logger + */ + public function __construct( + \Magento\Quote\Model\QuoteRepository $quoteRepository, + QuoteAddressValidator $addressValidator, + Logger $logger + ) { + $this->quoteRepository = $quoteRepository; + $this->addressValidator = $addressValidator; + $this->logger = $logger; + } + + /** + * {@inheritDoc} + */ + public function assign($cartId, \Magento\Quote\Api\Data\AddressInterface $address) + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->getActive($cartId); + if ($quote->isVirtual()) { + throw new NoSuchEntityException( + 'Cart contains virtual product(s) only. Shipping address is not applicable' + ); + } + $this->addressValidator->validate($address); + $address->setSameAsBilling(0); + $address->setCollectShippingRates(true); + + $quote->setShippingAddress($address); + $quote->setDataChanges(true); + try { + $this->quoteRepository->save($quote); + } catch (\Exception $e) { + $this->logger->critical($e); + throw new InputException('Unable to save address. Please, check input data.'); + } + return $quote->getShippingAddress()->getId(); + } + + /** + * {@inheritDoc} + */ + public function get($cartId) + { + /** + * Quote. + * + * @var \Magento\Quote\Model\Quote $quote + */ + $quote = $this->quoteRepository->getActive($cartId); + if ($quote->isVirtual()) { + throw new NoSuchEntityException( + 'Cart contains virtual product(s) only. Shipping address is not applicable' + ); + } + + /** + * Address. + * + * @var \Magento\Quote\Model\Quote\Address $address + */ + return $quote->getShippingAddress(); + } +} diff --git a/app/code/Magento/Checkout/Service/V1/ShippingMethod/ReadService.php b/app/code/Magento/Quote/Model/ShippingMethodManagement.php similarity index 50% rename from app/code/Magento/Checkout/Service/V1/ShippingMethod/ReadService.php rename to app/code/Magento/Quote/Model/ShippingMethodManagement.php index f0a8c56201a91c19e7b8ec53e23f3402ec1c8d32..b73445ce19a533d0d2d24475a9ce93f3181c4760 100644 --- a/app/code/Magento/Checkout/Service/V1/ShippingMethod/ReadService.php +++ b/app/code/Magento/Quote/Model/ShippingMethodManagement.php @@ -4,19 +4,21 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\ShippingMethod; +// @codingStandardsIgnoreFile + +namespace Magento\Quote\Model; -use Magento\Checkout\Service\V1\Data\Cart\ShippingMethod; -use Magento\Checkout\Service\V1\Data\Cart\ShippingMethodBuilder; -use Magento\Checkout\Service\V1\Data\Cart\ShippingMethodConverter; use Magento\Framework\Exception\InputException; use Magento\Framework\Exception\StateException; -use Magento\Quote\Model\QuoteRepository; +use Magento\Framework\Exception\NoSuchEntityException; +use Magento\Framework\Exception\CouldNotSaveException; +use Magento\Quote\Api\ShippingMethodManagementInterface; +use Magento\Quote\Api\Data\ShippingMethodInterface; /** * Shipping method read service. */ -class ReadService implements ReadServiceInterface +class ShippingMethodManagement implements ShippingMethodManagementInterface { /** * Quote repository. @@ -28,14 +30,14 @@ class ReadService implements ReadServiceInterface /** * Shipping method builder. * - * @var \Magento\Checkout\Service\V1\Data\Cart\ShippingMethodBuilder + * @var \Magento\Quote\Api\Data\ShippingMethodDataBuilder */ protected $methodBuilder; /** - * Shipping method converter. + * Shipping method converter * - * @var ShippingMethodConverter + * @var \Magento\Quote\Model\Cart\ShippingMethodConverter */ protected $converter; @@ -43,28 +45,23 @@ class ReadService implements ReadServiceInterface * Constructs a shipping method read service object. * * @param QuoteRepository $quoteRepository Quote repository. - * @param ShippingMethodConverter $converter Shipping method converter. - * @param \Magento\Checkout\Service\V1\Data\Cart\ShippingMethodBuilder $methodBuilder Shipping method builder. + * @param \Magento\Quote\Api\Data\ShippingMethodDataBuilder $methodBuilder Shipping method builder. + * @param \Magento\Quote\Model\Cart\ShippingMethodConverter $converter Shipping method builder converter. */ public function __construct( QuoteRepository $quoteRepository, - ShippingMethodConverter $converter, - \Magento\Checkout\Service\V1\Data\Cart\ShippingMethodBuilder $methodBuilder + \Magento\Quote\Api\Data\ShippingMethodDataBuilder $methodBuilder, + Cart\ShippingMethodConverter $converter ) { $this->quoteRepository = $quoteRepository; - $this->converter = $converter; $this->methodBuilder = $methodBuilder; + $this->converter = $converter; } /** * {@inheritDoc} - * - * @param int $cartId The shopping cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\ShippingMethod Shipping method. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified shopping cart does not exist. - * @throws \Magento\Framework\Exception\StateException The shipping address is not set. */ - public function getMethod($cartId) + public function get($cartId) { /** @var \Magento\Quote\Model\Quote $quote */ $quote = $this->quoteRepository->getActive($cartId); @@ -84,13 +81,13 @@ class ReadService implements ReadServiceInterface list($carrierTitle, $methodTitle) = $this->divideNames(' - ', $shippingAddress->getShippingDescription()); $output = [ - ShippingMethod::CARRIER_CODE => $carrierCode, - ShippingMethod::METHOD_CODE => $methodCode, - ShippingMethod::CARRIER_TITLE => $carrierTitle, - ShippingMethod::METHOD_TITLE => $methodTitle, - ShippingMethod::SHIPPING_AMOUNT => $shippingAddress->getShippingAmount(), - ShippingMethod::BASE_SHIPPING_AMOUNT => $shippingAddress->getBaseShippingAmount(), - ShippingMethod::AVAILABLE => true, + ShippingMethodInterface::CARRIER_CODE => $carrierCode, + ShippingMethodInterface::METHOD_CODE => $methodCode, + ShippingMethodInterface::CARRIER_TITLE => $carrierTitle, + ShippingMethodInterface::METHOD_TITLE => $methodTitle, + ShippingMethodInterface::SHIPPING_AMOUNT => $shippingAddress->getShippingAmount(), + ShippingMethodInterface::BASE_SHIPPING_AMOUNT => $shippingAddress->getBaseShippingAmount(), + ShippingMethodInterface::AVAILABLE => true, ]; return $this->methodBuilder->populateWithArray($output)->create(); @@ -114,11 +111,6 @@ class ReadService implements ReadServiceInterface /** * {@inheritDoc} - * - * @param int $cartId The shopping cart ID. - * @return \Magento\Checkout\Service\V1\Data\Cart\ShippingMethod[] An array of shipping methods. - * @throws \Magento\Framework\Exception\NoSuchEntityException The specified quote does not exist. - * @throws \Magento\Framework\Exception\StateException The shipping address is not set. */ public function getList($cartId) { @@ -145,4 +137,50 @@ class ReadService implements ReadServiceInterface } return $output; } + + /** + * {@inheritDoc} + * + * @param int $cartId The shopping cart ID. + * @param string $carrierCode The carrier code. + * @param string $methodCode The shipping method code. + * @return bool + * @throws \Magento\Framework\Exception\InputException The shipping method is not valid for an empty cart. + * @throws \Magento\Framework\Exception\CouldNotSaveException The shipping method could not be saved. + * @throws \Magento\Framework\Exception\NoSuchEntityException The specified cart contains only virtual products and the shipping method is not applicable. + * @throws \Magento\Framework\Exception\StateException The billing or shipping address is not set. + */ + public function set($cartId, $carrierCode, $methodCode) + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->quoteRepository->getActive($cartId); + if (0 == $quote->getItemsCount()) { + throw new InputException('Shipping method is not applicable for empty cart'); + } + + if ($quote->isVirtual()) { + throw new NoSuchEntityException( + 'Cart contains virtual product(s) only. Shipping method is not applicable.' + ); + } + $shippingAddress = $quote->getShippingAddress(); + if (!$shippingAddress->getCountryId()) { + throw new StateException('Shipping address is not set'); + } + $billingAddress = $quote->getBillingAddress(); + if (!$billingAddress->getCountryId()) { + throw new StateException('Billing address is not set'); + } + + $shippingAddress->setShippingMethod($carrierCode . '_' . $methodCode); + if (!$shippingAddress->requestShippingRates()) { + throw new NoSuchEntityException('Carrier with such method not found: ' . $carrierCode . ', ' . $methodCode); + } + try { + $this->quoteRepository->save($quote->collectTotals()); + } catch (\Exception $e) { + throw new CouldNotSaveException('Cannot set shipping method. ' . $e->getMessage()); + } + return true; + } } diff --git a/app/code/Magento/Quote/etc/di.xml b/app/code/Magento/Quote/etc/di.xml index 072334a39d2fc9961d7968732dd09abffabea23e..d6e44321ac6f3f887a5b7b505e53fd0622e45e40 100644 --- a/app/code/Magento/Quote/etc/di.xml +++ b/app/code/Magento/Quote/etc/di.xml @@ -6,6 +6,11 @@ */ --> <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/ObjectManager/etc/config.xsd"> + <preference for="Magento\Quote\Api\ShippingMethodManagementInterface" type="Magento\Quote\Model\ShippingMethodManagement" /> + <preference for="Magento\Quote\Api\Data\ShippingMethodInterface" type="Magento\Quote\Model\Cart\ShippingMethod" /> + <preference for="Magento\Quote\Api\BillingAddressManagementInterface" type="Magento\Quote\Model\BillingAddressManagement" /> + <preference for="Magento\Quote\Api\ShippingAddressManagementInterface" type="Magento\Quote\Model\ShippingAddressManagement" /> + <preference for="Magento\Quote\Api\Data\AddressInterface" type="Magento\Quote\Model\Quote\Address" /> <type name="Magento\Framework\Module\Updater\SetupFactory"> <arguments> <argument name="resourceTypes" xsi:type="array"> @@ -13,4 +18,18 @@ </argument> </arguments> </type> + <preference for="Magento\Quote\Api\Data\CartItemInterface" type="Magento\Quote\Model\Quote\Item" /> + <preference for="Magento\Quote\Api\Data\CartInterface" type="Magento\Quote\Model\Quote" /> + <preference for="Magento\Quote\Api\CartItemRepositoryInterface" type="Magento\Quote\Model\Quote\Item\Repository" /> + <preference for="Magento\Quote\Api\CartRepositoryInterface" type="Magento\Quote\Model\QuoteRepository" /> + <preference for="Magento\Quote\Api\Data\CartSearchResultsInterface" type="Magento\Framework\Api\SearchResults" /> + <preference for="Magento\Quote\Api\PaymentMethodManagementInterface" type="\Magento\Quote\Model\PaymentMethodManagement" /> + <preference for="Magento\Quote\Api\Data\PaymentInterface" type="\Magento\Quote\Model\Quote\Payment" /> + <preference for="Magento\Quote\Api\CouponManagementInterface" type="Magento\Quote\Model\CouponManagement" /> + <preference for="Magento\Quote\Api\CartManagementInterface" type="Magento\Quote\Model\QuoteManagement" /> + <preference for="Magento\Authorization\Model\UserContextInterface" type="Magento\Authorization\Model\CompositeUserContext"/> + <preference for="Magento\Quote\Api\CartTotalRepositoryInterface" type="\Magento\Quote\Model\Cart\CartTotalRepository" /> + <preference for="Magento\Quote\Api\Data\TotalsInterface" type="\Magento\Quote\Model\Cart\Totals" /> + <preference for="Magento\Quote\Api\Data\TotalsItemInterface" type="\Magento\Quote\Model\Quote\Cart\Totals\Item" /> + <preference for="Magento\Quote\Api\Data\CurrencyInterface" type="\Magento\Quote\Model\Cart\Currency" /> </config> diff --git a/app/code/Magento/Checkout/etc/webapi.xml b/app/code/Magento/Quote/etc/webapi.xml similarity index 59% rename from app/code/Magento/Checkout/etc/webapi.xml rename to app/code/Magento/Quote/etc/webapi.xml index 786e9bb82884ab54de2ae696feffe794ce409a8c..2a4e83c5597b137926a0726771adae2d41836969 100644 --- a/app/code/Magento/Checkout/etc/webapi.xml +++ b/app/code/Magento/Quote/etc/webapi.xml @@ -7,148 +7,148 @@ --> <routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../app/code/Magento/Webapi/etc/webapi.xsd"> - <route url="/V1/carts/" method="POST"> - <service class="Magento\Checkout\Service\V1\Cart\WriteServiceInterface" method="create"/> + <route url="/V1/carts/:cartId" method="GET"> + <service class="Magento\Quote\Api\CartRepositoryInterface" method="get"/> <resources> - <resource ref="Magento_Sales::create" /> + <resource ref="Magento_Catalog::products" /> </resources> </route> - <route url="/V1/carts/:cartId" method="PUT"> - <service class="Magento\Checkout\Service\V1\Cart\WriteServiceInterface" method="assignCustomer"/> + <route url="/V1/carts" method="PUT"> + <service class="Magento\Quote\Api\CartRepositoryInterface" method="getList"/> <resources> - <resource ref="Magento_Sales::create" /> + <resource ref="Magento_Catalog::products" /> </resources> </route> - <route url="/V1/carts/:cartId/items" method="GET"> - <service class="Magento\Checkout\Service\V1\Item\ReadServiceInterface" method="getList"/> + <route url="/V1/carts/" method="POST"> + <service class="Magento\Quote\Api\CartManagementInterface" method="createEmptyCart"/> <resources> - <resource ref="Magento_Catalog::products" /> + <resource ref="Magento_Sales::create" /> </resources> </route> - <route url="/V1/carts/:cartId/items" method="POST"> - <service class="Magento\Checkout\Service\V1\Item\WriteServiceInterface" method="addItem"/> + <route url="/V1/carts/:cartId" method="PUT"> + <service class="Magento\Quote\Api\CartManagementInterface" method="assignCustomer"/> <resources> - <resource ref="Magento_Catalog::products" /> + <resource ref="Magento_Sales::create" /> </resources> </route> - <route url="/V1/carts/:cartId/items/:itemId" method="PUT"> - <service class="Magento\Checkout\Service\V1\Item\WriteServiceInterface" method="updateItem"/> + <route url="/V1/carts/:cartId/selected-shipping-method" method="PUT"> + <service class="Magento\Quote\Api\ShippingMethodManagementInterface" method="set"/> <resources> - <resource ref="Magento_Catalog::products" /> + <resource ref="Magento_Sales::sales" /> </resources> </route> - <route url="/V1/carts/:cartId/items/:itemId" method="DELETE"> - <service class="Magento\Checkout\Service\V1\Item\WriteServiceInterface" method="removeItem"/> + <route url="/V1/carts/:cartId/selected-shipping-method" method="GET"> + <service class="Magento\Quote\Api\ShippingMethodManagementInterface" method="get"/> <resources> - <resource ref="Magento_Catalog::products" /> + <resource ref="Magento_Sales::sales" /> </resources> </route> - <route url="/V1/carts/:cartId" method="GET"> - <service class="Magento\Checkout\Service\V1\Cart\ReadServiceInterface" method="getCart"/> + <route url="/V1/carts/:cartId/shipping-methods" method="GET"> + <service class="Magento\Quote\Api\ShippingMethodManagementInterface" method="getList"/> <resources> - <resource ref="Magento_Catalog::products" /> - </resources> + <resource ref="Magento_Sales::sales" /> + </resources> </route> - <route url="/V1/customer/:customerId/cart" method="GET"> - <service class="Magento\Checkout\Service\V1\Cart\ReadServiceInterface" method="getCartForCustomer"/> + <route url="/V1/carts/:cartId/items" method="GET"> + <service class="Magento\Quote\Api\CartItemRepositoryInterface" method="getList"/> <resources> <resource ref="Magento_Catalog::products" /> </resources> </route> - <route url="/V1/carts" method="GET"> - <service class="Magento\Checkout\Service\V1\Cart\ReadServiceInterface" method="getCartList"/> + <route url="/V1/carts/items" method="POST"> + <service class="Magento\Quote\Api\CartItemRepositoryInterface" method="save"/> <resources> <resource ref="Magento_Catalog::products" /> </resources> </route> - <route url="/V1/carts/:cartId/shipping-address" method="GET"> - <service class="Magento\Checkout\Service\V1\Address\Shipping\ReadServiceInterface" method="getAddress"/> + <route url="/V1/carts/items/:itemId" method="PUT"> + <service class="Magento\Quote\Api\CartItemRepositoryInterface" method="save"/> <resources> - <resource ref="Magento_Sales::sales" /> + <resource ref="Magento_Catalog::products" /> </resources> </route> - <route url="/V1/carts/:cartId/shipping-address" method="POST"> - <service class="Magento\Checkout\Service\V1\Address\Shipping\WriteServiceInterface" method="setAddress"/> + <route url="/V1/carts/:cartId/items/:itemId" method="DELETE"> + <service class="Magento\Quote\Api\CartItemRepositoryInterface" method="deleteById"/> <resources> - <resource ref="Magento_Sales::sales" /> + <resource ref="Magento_Catalog::products" /> </resources> </route> - <route url="/V1/carts/:cartId/billing-address" method="GET"> - <service class="Magento\Checkout\Service\V1\Address\Billing\ReadServiceInterface" method="getAddress"/> + <route url="/V1/carts/:cartId/selected-payment-methods" method="GET"> + <service class="Magento\Quote\Api\PaymentMethodManagementInterface" method="get"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route> - <route url="/V1/carts/:cartId/billing-address" method="POST"> - <service class="Magento\Checkout\Service\V1\Address\Billing\WriteServiceInterface" method="setAddress"/> + <route url="/V1/carts/:cartId/selected-payment-methods" method="PUT"> + <service class="Magento\Quote\Api\PaymentMethodManagementInterface" method="set"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route> - <route url="/V1/carts/:cartId/selected-shipping-method" method="PUT"> - <service class="Magento\Checkout\Service\V1\ShippingMethod\WriteServiceInterface" method="setMethod"/> + <route url="/V1/carts/:cartId/payment-methods" method="GET"> + <service class="Magento\Quote\Api\PaymentMethodManagementInterface" method="getList"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route> - <route url="/V1/carts/:cartId/selected-shipping-method" method="GET"> - <service class="Magento\Checkout\Service\V1\ShippingMethod\ReadServiceInterface" method="getMethod"/> + <route url="/V1/carts/:cartId/billing-address" method="GET"> + <service class="Magento\Quote\Api\BillingAddressManagementInterface" method="get"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route> - <route url="/V1/carts/:cartId/shipping-methods" method="GET"> - <service class="Magento\Checkout\Service\V1\ShippingMethod\ReadServiceInterface" method="getList"/> + <route url="/V1/carts/:cartId/billing-address" method="POST"> + <service class="Magento\Quote\Api\BillingAddressManagementInterface" method="assign"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route> <route url="/V1/carts/:cartId/coupons" method="GET"> - <service class="Magento\Checkout\Service\V1\Coupon\ReadServiceInterface" method="get"/> + <service class="Magento\Quote\Api\CouponManagementInterface" method="get"/> <resources> <resource ref="Magento_SalesRule::quote" /> </resources> </route> - <route url="/V1/carts/:cartId/coupons" method="PUT"> - <service class="Magento\Checkout\Service\V1\Coupon\WriteServiceInterface" method="set"/> + <route url="/V1/carts/:cartId/coupons/:couponCode" method="PUT"> + <service class="Magento\Quote\Api\CouponManagementInterface" method="set"/> <resources> <resource ref="Magento_SalesRule::quote" /> </resources> </route> <route url="/V1/carts/:cartId/coupons" method="DELETE"> - <service class="Magento\Checkout\Service\V1\Coupon\WriteServiceInterface" method="delete"/> + <service class="Magento\Quote\Api\CouponManagementInterface" method="remove"/> <resources> <resource ref="Magento_SalesRule::quote" /> </resources> </route> - <route url="/V1/carts/:cartId/selected-payment-methods" method="GET"> - <service class="Magento\Checkout\Service\V1\PaymentMethod\ReadServiceInterface" method="getPayment"/> + <route url="/V1/carts/:cartId/shipping-address" method="GET"> + <service class="Magento\Quote\Api\ShippingAddressManagementInterface" method="get"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route> - <route url="/V1/carts/:cartId/selected-payment-methods" method="PUT"> - <service class="Magento\Checkout\Service\V1\PaymentMethod\WriteServiceInterface" method="set"/> + <route url="/V1/carts/:cartId/shipping-address" method="POST"> + <service class="Magento\Quote\Api\ShippingAddressManagementInterface" method="assign"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route> - <route url="/V1/carts/:cartId/payment-methods" method="GET"> - <service class="Magento\Checkout\Service\V1\PaymentMethod\ReadServiceInterface" method="getList"/> + <route url="/V1/carts/:cartId/order" method="PUT"> + <service class="Magento\Quote\Api\CartManagementInterface" method="placeOrder"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route> <route url="/V1/carts/:cartId/totals" method="GET"> - <service class="Magento\Checkout\Service\V1\Cart\TotalsServiceInterface" method="getTotals"/> + <service class="Magento\Quote\Api\CartTotalRepositoryInterface" method="get"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route> - <route url="/V1/carts/:cartId/order" method="PUT"> - <service class="Magento\Checkout\Service\V1\Cart\WriteServiceInterface" method="order"/> + <route url="/V1/customer/:customerId/cart" method="GET"> + <service class="Magento\Quote\Api\CartManagementInterface" method="getCartForCustomer"/> <resources> - <resource ref="Magento_Sales::sales" /> + <resource ref="Magento_Catalog::products" /> </resources> </route> </routes> diff --git a/app/code/Magento/Checkout/etc/webapi_rest/di.xml b/app/code/Magento/Quote/etc/webapi_rest/di.xml similarity index 50% rename from app/code/Magento/Checkout/etc/webapi_rest/di.xml rename to app/code/Magento/Quote/etc/webapi_rest/di.xml index 637fd9850d74dd1fd48b61687ba9cea64f0ce408..67774a740401df953616e1fedae05e822e81d32e 100644 --- a/app/code/Magento/Checkout/etc/webapi_rest/di.xml +++ b/app/code/Magento/Quote/etc/webapi_rest/di.xml @@ -6,10 +6,10 @@ */ --> <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../lib/internal/Magento/Framework/ObjectManager/etc/config.xsd"> - <type name="Magento\Checkout\Service\V1\Cart\ReadServiceInterface"> - <plugin name="admin_access" type="\Magento\Checkout\Model\Cart\Access\ReadPlugin" /> + <type name="Magento\Quote\Api\CartRepositoryInterface"> + <plugin name="admin_access" type="\Magento\Quote\Model\Cart\Access\CartRepositoryPlugin" /> </type> - <type name="Magento\Checkout\Service\V1\Cart\WriteServiceInterface"> - <plugin name="admin_access" type="\Magento\Checkout\Model\Cart\Access\WritePlugin" /> + <type name="Magento\Quote\Api\CartManagementInterface"> + <plugin name="admin_access" type="\Magento\Quote\Model\Cart\Access\CartManagementPlugin" /> </type> </config> diff --git a/app/code/Magento/Checkout/etc/webapi_soap/di.xml b/app/code/Magento/Quote/etc/webapi_soap/di.xml similarity index 50% rename from app/code/Magento/Checkout/etc/webapi_soap/di.xml rename to app/code/Magento/Quote/etc/webapi_soap/di.xml index 637fd9850d74dd1fd48b61687ba9cea64f0ce408..67774a740401df953616e1fedae05e822e81d32e 100644 --- a/app/code/Magento/Checkout/etc/webapi_soap/di.xml +++ b/app/code/Magento/Quote/etc/webapi_soap/di.xml @@ -6,10 +6,10 @@ */ --> <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../lib/internal/Magento/Framework/ObjectManager/etc/config.xsd"> - <type name="Magento\Checkout\Service\V1\Cart\ReadServiceInterface"> - <plugin name="admin_access" type="\Magento\Checkout\Model\Cart\Access\ReadPlugin" /> + <type name="Magento\Quote\Api\CartRepositoryInterface"> + <plugin name="admin_access" type="\Magento\Quote\Model\Cart\Access\CartRepositoryPlugin" /> </type> - <type name="Magento\Checkout\Service\V1\Cart\WriteServiceInterface"> - <plugin name="admin_access" type="\Magento\Checkout\Model\Cart\Access\WritePlugin" /> + <type name="Magento\Quote\Api\CartManagementInterface"> + <plugin name="admin_access" type="\Magento\Quote\Model\Cart\Access\CartManagementPlugin" /> </type> </config> diff --git a/app/code/Magento/Reports/Block/Adminhtml/Config/Form/Field/YtdStart.php b/app/code/Magento/Reports/Block/Adminhtml/Config/Form/Field/YtdStart.php index 228564cad23ace5763b6a85ed951c69898007eb6..046bfe1aa2dd769dfbba0bd69f4a7edccc6ac986 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Config/Form/Field/YtdStart.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Config/Form/Field/YtdStart.php @@ -17,6 +17,7 @@ class YtdStart extends \Magento\Backend\Block\System\Config\Form\Field /** * @param AbstractElement $element * @return string + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getElementHtml(AbstractElement $element) { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Filter/Form.php b/app/code/Magento/Reports/Block/Adminhtml/Filter/Form.php index b91ef443699a08d24b2cd986792051c3987d80fb..3399d0bd34b4234e35ca6b2ab5216a867ee0a573 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Filter/Form.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Filter/Form.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Adminhtml\Filter; /** @@ -52,6 +55,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * @param string $fieldId * @param bool $defaultVisibility * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getFieldVisibility($fieldId, $defaultVisibility = true) { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Grid.php index d7a3c99fb0115d9ce0eb1d4ee3e0237d402760a6..ffe52417938c1a70831f6e7c517b0f5615ae7526 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Grid.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Adminhtml; /** @@ -72,6 +75,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid * Apply sorting and filtering to collection * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _prepareCollection() { @@ -184,6 +188,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid * * @param array $data * @return $this + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _setFilterValues($data) { @@ -209,6 +214,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid * Return visibility of store switcher * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getStoreSwitcherVisibility() { @@ -241,6 +247,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid * Return visibility of date filter * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDateFilterVisibility() { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Grid/AbstractGrid.php b/app/code/Magento/Reports/Block/Adminhtml/Grid/AbstractGrid.php index fa7e3329043384c732681d55173156f17a4fdb9f..7404aa6600f66404e4095e46dc38a4778fec27d8 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Grid/AbstractGrid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Grid/AbstractGrid.php @@ -186,6 +186,8 @@ class AbstractGrid extends \Magento\Backend\Block\Widget\Grid\Extended /** * @return $this|\Magento\Backend\Block\Widget\Grid + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _prepareCollection() { @@ -393,6 +395,7 @@ class AbstractGrid extends \Magento\Backend\Block\Widget\Grid\Extended * @param \Magento\Reports\Model\Resource\Report\Collection\AbstractCollection $collection * @param \Magento\Framework\Object $filterData * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _addCustomFilter($collection, $filterData) { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Grid/Column/Renderer/Currency.php b/app/code/Magento/Reports/Block/Adminhtml/Grid/Column/Renderer/Currency.php index 2af3ddc72cc47361557175da03445fb6ee176af8..ac9cf8c700bd7efc13558d6fb0161388dd2de4e3 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Grid/Column/Renderer/Currency.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Grid/Column/Renderer/Currency.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Adminhtml\Grid\Column\Renderer; /** diff --git a/app/code/Magento/Reports/Block/Adminhtml/Product/Viewed/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Product/Viewed/Grid.php index 4bc033806c14078cbd3020398da56d72613b0f05..b97781a1f04d98982deac868243fff14e8a7bc1c 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Product/Viewed/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Product/Viewed/Grid.php @@ -9,6 +9,7 @@ namespace Magento\Reports\Block\Adminhtml\Product\Viewed; * Adminhtml most viewed products report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Bestsellers/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Bestsellers/Grid.php index d12f64956c96f8f2ac7f3318710e30cabca91007..d6820a811970fded00679f36d5ad6564ccae7e36 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Sales/Bestsellers/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Sales/Bestsellers/Grid.php @@ -9,6 +9,7 @@ namespace Magento\Reports\Block\Adminhtml\Sales\Bestsellers; * Adminhtml bestsellers report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Coupons/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Coupons/Grid.php index c8b8e1183de07842bea4a665d7c14a6064a8a052..c04265b1c531f9c8eaef861a81eacdd8998afc84 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Sales/Coupons/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Sales/Coupons/Grid.php @@ -9,6 +9,7 @@ namespace Magento\Reports\Block\Adminhtml\Sales\Coupons; * Adminhtml coupons report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid { @@ -41,6 +42,7 @@ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid /** * @return \Magento\Backend\Block\Widget\Grid\Extended + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareColumns() { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Invoiced/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Invoiced/Grid.php index c5eec01ddc391c29ddf452dbe5af063ca5ba9d60..414c2e775872a1e9a36795e820c9b417533c1416 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Sales/Invoiced/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Sales/Invoiced/Grid.php @@ -3,12 +3,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Adminhtml\Sales\Invoiced; /** * Adminhtml invoiced report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Refunded/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Refunded/Grid.php index 282d9ae30336d1d8ddb88db0a1e5f002c2d5430b..e5f68a315f74013a51de8df19dc74cfbc996efb5 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Sales/Refunded/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Sales/Refunded/Grid.php @@ -3,12 +3,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Adminhtml\Sales\Refunded; /** * Adminhtml refunded report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Sales/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Sales/Grid.php index 2820a424a76ae72f9f5f5537c5f47670fd5df07b..012e170b2c269dac90cdd6b43d1461edf4aa4ee4 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Sales/Sales/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Sales/Sales/Grid.php @@ -3,12 +3,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Adminhtml\Sales\Sales; /** * Adminhtml sales report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid { @@ -39,6 +43,7 @@ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid /** * @return \Magento\Backend\Block\Widget\Grid\Extended + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareColumns() { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Shipping/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Shipping/Grid.php index 4dc7d8fefe70cede14472c30621f94a86ef386ee..ee594aaa3447565990652114cee7ba498b1f3011 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Sales/Shipping/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Sales/Shipping/Grid.php @@ -3,12 +3,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Adminhtml\Sales\Shipping; /** * Adminhtml shipping report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Tax/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Tax/Grid.php index c565dcf44b89689878bd729dddf4086889039f61..48c3a647299b4b3cc76dde1dd63ed36a0e05f7a2 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Sales/Tax/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Sales/Tax/Grid.php @@ -3,12 +3,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Adminhtml\Sales\Tax; /** * Adminhtml tax report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid { @@ -153,6 +157,7 @@ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid * Preparing collection. Filter canceled statuses for orders in taxes * * @return $this + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _prepareCollection() { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Abandoned/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Abandoned/Grid.php index bb2252e78fd86861b74136f18fa54980b349656c..4ef5903836cc0b82e097b768f1f59f7ec672cd6a 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Abandoned/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Abandoned/Grid.php @@ -9,6 +9,7 @@ namespace Magento\Reports\Block\Adminhtml\Shopcart\Abandoned; * Adminhtml abandoned shopping carts report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\Shopcart { @@ -86,6 +87,7 @@ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\Shopcart /** * @return \Magento\Backend\Block\Widget\Grid\Extended + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareColumns() { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Customer/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Customer/Grid.php index c509eeeac0260ef025ecde47ee8a857606740517..4d5fab61661678b4838b8c17996dfe0e9e80f7f6 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Customer/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Customer/Grid.php @@ -9,6 +9,7 @@ namespace Magento\Reports\Block\Adminhtml\Shopcart\Customer; * Adminhtml items in carts report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\Shopcart { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Product/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Product/Grid.php index cd49650ef6b6424fcf9992a7f3b03b43ea42b818..a4837b8f21861bff88ee59dd564d207c4eab75a5 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Product/Grid.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Product/Grid.php @@ -9,6 +9,7 @@ namespace Magento\Reports\Block\Adminhtml\Shopcart\Product; * Adminhtml products in carts report grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Reports\Block\Adminhtml\Grid\Shopcart { diff --git a/app/code/Magento/Reports/Block/Adminhtml/Wishlist.php b/app/code/Magento/Reports/Block/Adminhtml/Wishlist.php index e60807dfc45023fbc533f65ad1f4a1ec45b85f28..690c98b4d692559de2d645c23623801f0ebe4705 100644 --- a/app/code/Magento/Reports/Block/Adminhtml/Wishlist.php +++ b/app/code/Magento/Reports/Block/Adminhtml/Wishlist.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Adminhtml; /** diff --git a/app/code/Magento/Reports/Block/Product/Compared.php b/app/code/Magento/Reports/Block/Product/Compared.php index 2ce868921e363dc1b880d48f363635e6096fadd4..6693d0053ea87edac053ff4e54bb3ada3de04152 100644 --- a/app/code/Magento/Reports/Block/Product/Compared.php +++ b/app/code/Magento/Reports/Block/Product/Compared.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Product; /** diff --git a/app/code/Magento/Reports/Block/Product/Viewed.php b/app/code/Magento/Reports/Block/Product/Viewed.php index c34b21cc73fe01436635bf60d0173e2474c6e529..addfa8cafd53a941194c033bbcdc9f9978b393e0 100644 --- a/app/code/Magento/Reports/Block/Product/Viewed.php +++ b/app/code/Magento/Reports/Block/Product/Viewed.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Block\Product; /** diff --git a/app/code/Magento/Reports/Controller/Adminhtml/Report/Sales.php b/app/code/Magento/Reports/Controller/Adminhtml/Report/Sales.php index c91b2f4c2bb3d21862c8305cd6ca29c528c9d322..cbb4b377759a9ad8567430b2761a43cbd2a53f50 100644 --- a/app/code/Magento/Reports/Controller/Adminhtml/Report/Sales.php +++ b/app/code/Magento/Reports/Controller/Adminhtml/Report/Sales.php @@ -11,6 +11,9 @@ */ namespace Magento\Reports\Controller\Adminhtml\Report; +/** + * @SuppressWarnings(PHPMD.NumberOfChildren) + */ class Sales extends AbstractReport { /** diff --git a/app/code/Magento/Reports/Helper/Data.php b/app/code/Magento/Reports/Helper/Data.php index 74d44adbb953470466c071ec903674f3aa21473c..7553ee48de465cc896f4dc1d07015272b579be43 100644 --- a/app/code/Magento/Reports/Helper/Data.php +++ b/app/code/Magento/Reports/Helper/Data.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Reports data helper */ @@ -42,6 +44,7 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * @param string $to * @param string $period * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getIntervals($from, $to, $period = self::REPORT_PERIOD_TYPE_DAY) { diff --git a/app/code/Magento/Reports/Model/DateFactory.php b/app/code/Magento/Reports/Model/DateFactory.php index fce16f4badf058e171e2b8ed296240a196308ed8..b604af9135446a9aea30ce5a684cd1fd1c68b5e4 100644 --- a/app/code/Magento/Reports/Model/DateFactory.php +++ b/app/code/Magento/Reports/Model/DateFactory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Model; class DateFactory diff --git a/app/code/Magento/Reports/Model/Event/Observer.php b/app/code/Magento/Reports/Model/Event/Observer.php index 7d03a411baf273158b5f8f20d720e241605eba7f..0283cf6e15df5dcca6fabe573da3882bd2ce61e1 100644 --- a/app/code/Magento/Reports/Model/Event/Observer.php +++ b/app/code/Magento/Reports/Model/Event/Observer.php @@ -107,6 +107,7 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function customerLogin(\Magento\Framework\Event\Observer $observer) { @@ -130,6 +131,7 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function customerLogout(\Magento\Framework\Event\Observer $observer) { @@ -182,6 +184,7 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function catalogProductCompareRemoveProduct(\Magento\Framework\Event\Observer $observer) { @@ -197,6 +200,7 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function catalogProductCompareClear(\Magento\Framework\Event\Observer $observer) { diff --git a/app/code/Magento/Reports/Model/Item.php b/app/code/Magento/Reports/Model/Item.php index 02611d3f133fe6ec56840461cbcf6266ce522021..ecc9c805e91722136affdff251c4123ca873613c 100644 --- a/app/code/Magento/Reports/Model/Item.php +++ b/app/code/Magento/Reports/Model/Item.php @@ -33,6 +33,7 @@ class Item extends \Magento\Framework\Object * Get is empty indicator * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsEmpty() { diff --git a/app/code/Magento/Reports/Model/Product/Index/AbstractIndex.php b/app/code/Magento/Reports/Model/Product/Index/AbstractIndex.php index 1fc837231ebc487c10adbfd29f33f386b9678727..4d3ca4716833f3ba99cd5dae823c9085e92880c6 100644 --- a/app/code/Magento/Reports/Model/Product/Index/AbstractIndex.php +++ b/app/code/Magento/Reports/Model/Product/Index/AbstractIndex.php @@ -59,6 +59,7 @@ abstract class AbstractIndex extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Reports/Model/Product/Index/Compared.php b/app/code/Magento/Reports/Model/Product/Index/Compared.php index b1af74dc46abb1df4dac7398ee33a3f18d8a6f57..2bf6917f348786a75cce710579f3fa04b588278e 100644 --- a/app/code/Magento/Reports/Model/Product/Index/Compared.php +++ b/app/code/Magento/Reports/Model/Product/Index/Compared.php @@ -49,6 +49,7 @@ class Compared extends \Magento\Reports\Model\Product\Index\AbstractIndex * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Reports/Model/Resource/Entity/Summary/Collection/AbstractCollection.php b/app/code/Magento/Reports/Model/Resource/Entity/Summary/Collection/AbstractCollection.php index dc3c8db4fffb6f5bb46094cdbb5bad6e976e124d..0e8ca1d37f81aa6291fe7c5594d1bc89f1c28339 100644 --- a/app/code/Magento/Reports/Model/Resource/Entity/Summary/Collection/AbstractCollection.php +++ b/app/code/Magento/Reports/Model/Resource/Entity/Summary/Collection/AbstractCollection.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Reports summary collection * @@ -84,6 +86,7 @@ class AbstractCollection extends \Magento\Framework\Data\Collection * * @param int $period * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setDatePeriod($period) { @@ -95,6 +98,7 @@ class AbstractCollection extends \Magento\Framework\Data\Collection * * @param int $storeId * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setStoreFilter($storeId) { diff --git a/app/code/Magento/Reports/Model/Resource/Event.php b/app/code/Magento/Reports/Model/Resource/Event.php index 787e8d36c28102245e71e9c719f6d1c12c9d91ad..313876eb8d89a67752d069a4bc37281806c475c3 100644 --- a/app/code/Magento/Reports/Model/Resource/Event.php +++ b/app/code/Magento/Reports/Model/Resource/Event.php @@ -55,6 +55,7 @@ class Event extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param int $customerId * @param array $types * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function updateCustomerType(\Magento\Reports\Model\Event $model, $visitorId, $customerId, $types = []) { @@ -169,6 +170,7 @@ class Event extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param \Magento\Reports\Model\Event $object * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function clean(\Magento\Reports\Model\Event $object) { diff --git a/app/code/Magento/Reports/Model/Resource/Order/Collection.php b/app/code/Magento/Reports/Model/Resource/Order/Collection.php index 06f1ed962c9cc6defe373e4d21c74bbd43137b89..bc04bbe5a5c58ede12b689729a898570dabd975d 100644 --- a/app/code/Magento/Reports/Model/Resource/Order/Collection.php +++ b/app/code/Magento/Reports/Model/Resource/Order/Collection.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Model\Resource\Order; use Magento\Framework\DB\Select; @@ -11,6 +14,7 @@ use Magento\Framework\DB\Select; * Reports orders collection * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Collection extends \Magento\Sales\Model\Resource\Order\Collection { @@ -106,6 +110,7 @@ class Collection extends \Magento\Sales\Model\Resource\Order\Collection * * @param string $range * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function checkIsLive($range) { @@ -362,6 +367,7 @@ class Collection extends \Magento\Sales\Model\Resource\Order\Collection * @param string $tzFrom * @param string $tzTo * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _getTZRangeExpressionForAttribute($range, $attribute, $tzFrom = '+00:00', $tzTo = null) { @@ -384,6 +390,7 @@ class Collection extends \Magento\Sales\Model\Resource\Order\Collection * @param string $customEnd * @param bool $returnObjects * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getDateRange($range, $customStart, $customEnd, $returnObjects = false) { @@ -540,6 +547,7 @@ class Collection extends \Magento\Sales\Model\Resource\Order\Collection * * @param int $isFilter * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _calculateTotalsAggregated($isFilter = 0) { diff --git a/app/code/Magento/Reports/Model/Resource/Product/Collection.php b/app/code/Magento/Reports/Model/Resource/Product/Collection.php index 97228e4d29cf1986e12c0f4a4ec3ee4b511b092b..0ebba9cca35cf36d1db35a6d1f180ab41f9437a8 100644 --- a/app/code/Magento/Reports/Model/Resource/Product/Collection.php +++ b/app/code/Magento/Reports/Model/Resource/Product/Collection.php @@ -11,6 +11,9 @@ */ namespace Magento\Reports\Model\Resource\Product; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Collection extends \Magento\Catalog\Model\Resource\Product\Collection { const SELECT_COUNT_SQL_TYPE_CART = 1; diff --git a/app/code/Magento/Reports/Model/Resource/Product/Index/AbstractIndex.php b/app/code/Magento/Reports/Model/Resource/Product/Index/AbstractIndex.php index bbdc48439e66bcfd5491bd84ee90bd48d0c05ce2..9397a7272a74dca2c3528452579a8da4b45074c3 100644 --- a/app/code/Magento/Reports/Model/Resource/Product/Index/AbstractIndex.php +++ b/app/code/Magento/Reports/Model/Resource/Product/Index/AbstractIndex.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Model\Resource\Product\Index; /** diff --git a/app/code/Magento/Reports/Model/Resource/Product/Index/Collection/AbstractCollection.php b/app/code/Magento/Reports/Model/Resource/Product/Index/Collection/AbstractCollection.php index aaa46e3164cbc443249026feca7d1a6225e8d6cc..0da793945459bf645a4d73b07aa73364c708e7b0 100644 --- a/app/code/Magento/Reports/Model/Resource/Product/Index/Collection/AbstractCollection.php +++ b/app/code/Magento/Reports/Model/Resource/Product/Index/Collection/AbstractCollection.php @@ -11,6 +11,9 @@ */ namespace Magento\Reports\Model\Resource\Product\Index\Collection; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ abstract class AbstractCollection extends \Magento\Catalog\Model\Resource\Product\Collection { /** diff --git a/app/code/Magento/Reports/Model/Resource/Product/Lowstock/Collection.php b/app/code/Magento/Reports/Model/Resource/Product/Lowstock/Collection.php index bb7310d9760f8aa7c8bdb38e91b91c35a39bfb65..891dbabb61f921a2ea2a1d6ee19df22b47c90b0f 100644 --- a/app/code/Magento/Reports/Model/Resource/Product/Lowstock/Collection.php +++ b/app/code/Magento/Reports/Model/Resource/Product/Lowstock/Collection.php @@ -11,6 +11,9 @@ */ namespace Magento\Reports\Model\Resource\Product\Lowstock; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Collection extends \Magento\Reports\Model\Resource\Product\Collection { /** diff --git a/app/code/Magento/Reports/Model/Resource/Quote/Collection.php b/app/code/Magento/Reports/Model/Resource/Quote/Collection.php index 197cb90347cf39ef16a487f7324cf78d57dafa94..6ff03c604e1ce160363d445ad0b83b5746bc3b81 100644 --- a/app/code/Magento/Reports/Model/Resource/Quote/Collection.php +++ b/app/code/Magento/Reports/Model/Resource/Quote/Collection.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Reports quote collection * diff --git a/app/code/Magento/Reports/Model/Resource/Report/AbstractReport.php b/app/code/Magento/Reports/Model/Resource/Report/AbstractReport.php index 3c74db144db62de0d74452f6e240943f1443334c..0ffd17fd9c7db31aacb03cee226c4fa8e248300e 100644 --- a/app/code/Magento/Reports/Model/Resource/Report/AbstractReport.php +++ b/app/code/Magento/Reports/Model/Resource/Report/AbstractReport.php @@ -4,10 +4,13 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Reports\Model\Resource\Report; /** * Abstract report aggregate resource model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractReport extends \Magento\Framework\Model\Resource\Db\AbstractDb { @@ -276,6 +279,7 @@ abstract class AbstractReport extends \Magento\Framework\Model\Resource\Db\Abstr * @param string $alias * @param string $relatedAlias * @return \Magento\Framework\DB\Select + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ protected function _getTableDateRangeRelatedSelect( $table, diff --git a/app/code/Magento/Reports/Model/Resource/Report/Product/Viewed.php b/app/code/Magento/Reports/Model/Resource/Report/Product/Viewed.php index e86195185f3ec82db748b153ae3238c8ea9c31dd..4f14518968734f06696080d5d9051f866b8969db 100644 --- a/app/code/Magento/Reports/Model/Resource/Report/Product/Viewed.php +++ b/app/code/Magento/Reports/Model/Resource/Report/Product/Viewed.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Most viewed product report aggregate resource model * @@ -79,6 +81,7 @@ class Viewed extends \Magento\Sales\Model\Resource\Report\AbstractReport * @param null|mixed $from * @param null|mixed $to * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function aggregate($from = null, $to = null) { diff --git a/app/code/Magento/Reports/Model/Resource/Report/Product/Viewed/Collection.php b/app/code/Magento/Reports/Model/Resource/Report/Product/Viewed/Collection.php index 24c60fec3319941ea5706d47049eea1d83d1c8e7..2f06240e07d106a9c9750be5a0e69b05e139bcb4 100644 --- a/app/code/Magento/Reports/Model/Resource/Report/Product/Viewed/Collection.php +++ b/app/code/Magento/Reports/Model/Resource/Report/Product/Viewed/Collection.php @@ -4,11 +4,16 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Report most viewed collection */ namespace Magento\Reports\Model\Resource\Report\Product\Viewed; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Collection extends \Magento\Reports\Model\Resource\Report\Collection\AbstractCollection { /** @@ -219,6 +224,9 @@ class Collection extends \Magento\Reports\Model\Resource\Report\Collection\Abstr * totals * * @return $this|\Magento\Framework\Model\Resource\Db\Collection\AbstractCollection + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _beforeLoad() { diff --git a/app/code/Magento/Reports/Model/Resource/Review/Customer/Collection.php b/app/code/Magento/Reports/Model/Resource/Review/Customer/Collection.php index cfd2365c682343b49c37f48e55a2f42ec9ae5868..c2abe745e0a17bb06902b8799f263c6a792ece3f 100644 --- a/app/code/Magento/Reports/Model/Resource/Review/Customer/Collection.php +++ b/app/code/Magento/Reports/Model/Resource/Review/Customer/Collection.php @@ -29,6 +29,7 @@ class Collection extends \Magento\Review\Model\Resource\Review\Collection * @param \Magento\Customer\Model\Resource\Customer $customerResource * @param mixed $connection * @param \Magento\Framework\Model\Resource\Db\AbstractDb $resource + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Core\Model\EntityFactory $entityFactory, diff --git a/app/code/Magento/Reports/Model/Resource/Shopcart/Product/Collection.php b/app/code/Magento/Reports/Model/Resource/Shopcart/Product/Collection.php index 9a5f19c6c32c8321f3e85c39cbed38f6fe16d3b8..8c251de78d6bd554fe73729dcef77b779fcd000d 100644 --- a/app/code/Magento/Reports/Model/Resource/Shopcart/Product/Collection.php +++ b/app/code/Magento/Reports/Model/Resource/Shopcart/Product/Collection.php @@ -32,6 +32,7 @@ class Collection extends \Magento\Reports\Model\Resource\Product\Collection * @param string $from * @param string $to * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setDateRange($from, $to) { diff --git a/app/code/Magento/Reports/Model/Totals.php b/app/code/Magento/Reports/Model/Totals.php index 0982638cb8ecfdf4b915b718351ea640d34257e4..75fbaaed53317b09e1ccafb5a91a1c605d090895 100644 --- a/app/code/Magento/Reports/Model/Totals.php +++ b/app/code/Magento/Reports/Model/Totals.php @@ -19,6 +19,8 @@ class Totals * @param string $from * @param string $to * @return \Magento\Framework\Object + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function countTotals($grid, $from, $to) { diff --git a/app/code/Magento/Reports/data/reports_setup/data-install-2.0.0.php b/app/code/Magento/Reports/data/reports_setup/data-install-2.0.0.php index daf541ed3b51441d170351cc9cd4de16fb8d291e..1273bbcde6890a7248e8f9aef3c67b38c3f1d841 100644 --- a/app/code/Magento/Reports/data/reports_setup/data-install-2.0.0.php +++ b/app/code/Magento/Reports/data/reports_setup/data-install-2.0.0.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $installer \Magento\Reports\Model\Resource\Setup */ $installer = $this; /* diff --git a/app/code/Magento/Reports/view/adminhtml/templates/grid.phtml b/app/code/Magento/Reports/view/adminhtml/templates/grid.phtml index d12eb397e687c6c2ab1b72a7e9c8efe5e0ae6193..146ab829796fd14034ff7f8e49f407a3dd1ceacd 100644 --- a/app/code/Magento/Reports/view/adminhtml/templates/grid.phtml +++ b/app/code/Magento/Reports/view/adminhtml/templates/grid.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Reports\Block\Adminhtml\Grid */ diff --git a/app/code/Magento/Reports/view/adminhtml/templates/report/grid/container.phtml b/app/code/Magento/Reports/view/adminhtml/templates/report/grid/container.phtml index 94fe3484a36f351443554f3b85374060dbfcecfe..23a52b20aa483327946a12545a4eb05640f6e38f 100644 --- a/app/code/Magento/Reports/view/adminhtml/templates/report/grid/container.phtml +++ b/app/code/Magento/Reports/view/adminhtml/templates/report/grid/container.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="reports-content"> diff --git a/app/code/Magento/Reports/view/adminhtml/templates/report/refresh/statistics.phtml b/app/code/Magento/Reports/view/adminhtml/templates/report/refresh/statistics.phtml index 027ef242060ef664342626560cb84bd09d5eceec..476eb5940c95c5eca090a4f04459bfd204a56abe 100644 --- a/app/code/Magento/Reports/view/adminhtml/templates/report/refresh/statistics.phtml +++ b/app/code/Magento/Reports/view/adminhtml/templates/report/refresh/statistics.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="page-actions"><?php echo $this->getButtonsHtml() ?></div> <?php echo $this->getChildHtml('grid') ?> diff --git a/app/code/Magento/Reports/view/adminhtml/templates/store/switcher.phtml b/app/code/Magento/Reports/view/adminhtml/templates/store/switcher.phtml index b4c27a635baa070eed5769a49e178ee0e577ff2d..6acf5ebffcc52bd993f0108924fd4da2cd31657c 100644 --- a/app/code/Magento/Reports/view/adminhtml/templates/store/switcher.phtml +++ b/app/code/Magento/Reports/view/adminhtml/templates/store/switcher.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Reports/view/adminhtml/templates/store/switcher/enhanced.phtml b/app/code/Magento/Reports/view/adminhtml/templates/store/switcher/enhanced.phtml index dc6182ad1eb9d1f46b9707a9dacb5464d03700ba..38233a4477095b6dbb38bf6e6d1a9e097763d93f 100644 --- a/app/code/Magento/Reports/view/adminhtml/templates/store/switcher/enhanced.phtml +++ b/app/code/Magento/Reports/view/adminhtml/templates/store/switcher/enhanced.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Reports/view/frontend/templates/js/components.phtml b/app/code/Magento/Reports/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Reports/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Reports/view/frontend/templates/product/widget/viewed.phtml b/app/code/Magento/Reports/view/frontend/templates/product/widget/viewed.phtml index deba99b44ca68572a76a58d7e50756a53530118e..9366134008b7bb551374b63af5ddbbfa5dc2a716 100644 --- a/app/code/Magento/Reports/view/frontend/templates/product/widget/viewed.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/product/widget/viewed.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Reports\Block\Product\Widget\Viewed */ ?> diff --git a/app/code/Magento/Reports/view/frontend/templates/product/widget/viewed/item.phtml b/app/code/Magento/Reports/view/frontend/templates/product/widget/viewed/item.phtml index 3d60dc094b0f3abe8975fce65019f64a7cbf7c72..6a034ee7a4f67c668790e8d22441d8dfecad82f3 100644 --- a/app/code/Magento/Reports/view/frontend/templates/product/widget/viewed/item.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/product/widget/viewed/item.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Reports\Block\Product\Widget\Viewed\Item */ ?> diff --git a/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_default_list.phtml b/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_default_list.phtml index 152cd7ac497cf44baa651503392b39aedd025161..dc783681253441bd9eb5091e80ee201b7d3b099d 100644 --- a/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_default_list.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_default_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($exist = $this->getRecentlyComparedProducts()) { diff --git a/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_images_list.phtml b/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_images_list.phtml index c7f31e7f2661b669953557b977af42f27c290d80..34d6dc69024ca54502810fd6b7733e4f7acd9fc9 100644 --- a/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_images_list.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_images_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($exist = $this->getRecentlyComparedProducts()) { diff --git a/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_names_list.phtml b/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_names_list.phtml index edd4a24b9ab6415e238c55c2efc0d6426b0afded..4839a54647868a74a0899721cbd7434c74ae4f90 100644 --- a/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_names_list.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/widget/compared/column/compared_names_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($_products = $this->getRecentlyComparedProducts()): ?> <div class="block widget block-compared-products-names"> diff --git a/app/code/Magento/Reports/view/frontend/templates/widget/compared/content/compared_grid.phtml b/app/code/Magento/Reports/view/frontend/templates/widget/compared/content/compared_grid.phtml index ab08bb94387347a2ccc263d62ddb0238a505ed93..9d7790176f57041c04c3f51cd838756cba79a9f7 100644 --- a/app/code/Magento/Reports/view/frontend/templates/widget/compared/content/compared_grid.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/widget/compared/content/compared_grid.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Reports/view/frontend/templates/widget/compared/content/compared_list.phtml b/app/code/Magento/Reports/view/frontend/templates/widget/compared/content/compared_list.phtml index d9e54ff22d9bac41ed88295427e494861235c561..0b52ca4664c235b0e6f4a9237e4456ff629cbc57 100644 --- a/app/code/Magento/Reports/view/frontend/templates/widget/compared/content/compared_list.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/widget/compared/content/compared_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_default_list.phtml b/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_default_list.phtml index 14496071a749893e8352ed902c37afe4317af3f9..3f2285905c7ea3fd7282bdad1a2eec7dfe8e1cb6 100644 --- a/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_default_list.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_default_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_images_list.phtml b/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_images_list.phtml index 29f151524634e45719e1834d4131c73e535cee47..bd95f6f5f879d2de14de5d01936c6fa88f922763 100644 --- a/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_images_list.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_images_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_names_list.phtml b/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_names_list.phtml index 12c49ca2ac34d1a34dce3b6e30a2962f6b2c2555..89112448c3c70758ec46f0006c494710f9d7d83e 100644 --- a/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_names_list.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/widget/viewed/column/viewed_names_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Reports/view/frontend/templates/widget/viewed/content/viewed_grid.phtml b/app/code/Magento/Reports/view/frontend/templates/widget/viewed/content/viewed_grid.phtml index 72b07a32c53da0b1a6444be9970962a58376467f..6e014c1442c8518d3eb43e8637d9f025fc6fe407 100644 --- a/app/code/Magento/Reports/view/frontend/templates/widget/viewed/content/viewed_grid.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/widget/viewed/content/viewed_grid.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Reports/view/frontend/templates/widget/viewed/content/viewed_list.phtml b/app/code/Magento/Reports/view/frontend/templates/widget/viewed/content/viewed_list.phtml index ccf80c74187c6c94918ba2fbf1fbe9e18b8f7969..aa85c35e2a2ca49bea566e20a31b7ba57892bdf5 100644 --- a/app/code/Magento/Reports/view/frontend/templates/widget/viewed/content/viewed_list.phtml +++ b/app/code/Magento/Reports/view/frontend/templates/widget/viewed/content/viewed_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Review/Block/Adminhtml/Add.php b/app/code/Magento/Review/Block/Adminhtml/Add.php index 0f9789d0fac5ba78644d21f37efdd47e43ada156..ce58795f990a07583fd59ebe119649066a5a23a9 100644 --- a/app/code/Magento/Review/Block/Adminhtml/Add.php +++ b/app/code/Magento/Review/Block/Adminhtml/Add.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Review\Block\Adminhtml; /** diff --git a/app/code/Magento/Review/Block/Adminhtml/Add/Form.php b/app/code/Magento/Review/Block/Adminhtml/Add/Form.php index 58e8d93332ff50534609a084ca7b7b65e8d1c810..ef18b5786913d006ecc81f2b1870731cb9140440 100644 --- a/app/code/Magento/Review/Block/Adminhtml/Add/Form.php +++ b/app/code/Magento/Review/Block/Adminhtml/Add/Form.php @@ -51,6 +51,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * Prepare add review form * * @return void + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Review/Block/Adminhtml/Edit.php b/app/code/Magento/Review/Block/Adminhtml/Edit.php index 099f40c1d76dcdf584d1572a71ad3e802d3283eb..90b62eca191fc8c1880b27e958fb10ba4f9fc2a2 100644 --- a/app/code/Magento/Review/Block/Adminhtml/Edit.php +++ b/app/code/Magento/Review/Block/Adminhtml/Edit.php @@ -55,6 +55,7 @@ class Edit extends \Magento\Backend\Block\Widget\Form\Container * Initialize edit review * * @return void + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _construct() { diff --git a/app/code/Magento/Review/Block/Adminhtml/Edit/Form.php b/app/code/Magento/Review/Block/Adminhtml/Edit/Form.php index f7e570bb1baa4ca5cbb60e0cdf53777141448af0..e5904fd543c42c30bb50f9689fce036319b5b2c5 100644 --- a/app/code/Magento/Review/Block/Adminhtml/Edit/Form.php +++ b/app/code/Magento/Review/Block/Adminhtml/Edit/Form.php @@ -68,6 +68,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * Prepare edit review form * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Review/Block/Adminhtml/Grid.php b/app/code/Magento/Review/Block/Adminhtml/Grid.php index 5f7a3aa9fc424afa9cf1f28d2b5a6fc6687a635b..73c09bc930e47a95a862513d3fd70bc6e1ffd181 100644 --- a/app/code/Magento/Review/Block/Adminhtml/Grid.php +++ b/app/code/Magento/Review/Block/Adminhtml/Grid.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Adminhtml reviews grid * @@ -153,6 +155,7 @@ class Grid extends \Magento\Backend\Block\Widget\Grid\Extended * Prepare grid columns * * @return \Magento\Backend\Block\Widget\Grid + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareColumns() { diff --git a/app/code/Magento/Review/Block/Adminhtml/Product/Edit/Tab/Reviews.php b/app/code/Magento/Review/Block/Adminhtml/Product/Edit/Tab/Reviews.php index b6e4d5da0acccdb6f96b922018b92cdd349cde23..d95a576962c38171ef1daee0a32505ef56f8bcc2 100644 --- a/app/code/Magento/Review/Block/Adminhtml/Product/Edit/Tab/Reviews.php +++ b/app/code/Magento/Review/Block/Adminhtml/Product/Edit/Tab/Reviews.php @@ -7,6 +7,9 @@ */ namespace Magento\Review\Block\Adminhtml\Product\Edit\Tab; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Reviews extends \Magento\Review\Block\Adminhtml\Grid { /** diff --git a/app/code/Magento/Review/Block/Adminhtml/Product/Grid.php b/app/code/Magento/Review/Block/Adminhtml/Product/Grid.php index 8e2fda6f25c36bc08a6f212e6aa7b77f0df1ac9b..86f2ee89153e0abb2c9a09e01da0520a9c96daa7 100644 --- a/app/code/Magento/Review/Block/Adminhtml/Product/Grid.php +++ b/app/code/Magento/Review/Block/Adminhtml/Product/Grid.php @@ -9,6 +9,7 @@ namespace Magento\Review\Block\Adminhtml\Product; * Adminhtml product grid block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Catalog\Block\Adminhtml\Product\Grid { diff --git a/app/code/Magento/Review/Block/Adminhtml/Rating/Detailed.php b/app/code/Magento/Review/Block/Adminhtml/Rating/Detailed.php index 79ac016cc13e0a98c38390d5d3f07f7d240089d3..e1332212f7959cc0abbfae71fe00aca03f37e895 100644 --- a/app/code/Magento/Review/Block/Adminhtml/Rating/Detailed.php +++ b/app/code/Magento/Review/Block/Adminhtml/Rating/Detailed.php @@ -149,6 +149,7 @@ class Detailed extends \Magento\Backend\Block\Template * @param Option $option * @param \Magento\Review\Model\Rating $rating * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function isSelected($option, $rating) { diff --git a/app/code/Magento/Review/Block/Adminhtml/Rating/Edit/Tab/Form.php b/app/code/Magento/Review/Block/Adminhtml/Rating/Edit/Tab/Form.php index 3d0a0990732d0d17c66a4935a20dc0bc2f631ff7..d3971e9e08abbb914828d1e6a6cf64d43b784647 100644 --- a/app/code/Magento/Review/Block/Adminhtml/Rating/Edit/Tab/Form.php +++ b/app/code/Magento/Review/Block/Adminhtml/Rating/Edit/Tab/Form.php @@ -61,6 +61,9 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * Prepare rating edit form * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Review/Block/Form.php b/app/code/Magento/Review/Block/Form.php index 391a2e64315db61dd98ad82e178a88ca34b62d7a..88429e9c1195415d153f9b0ad4e7b0a9fe46bb07 100644 --- a/app/code/Magento/Review/Block/Form.php +++ b/app/code/Magento/Review/Block/Form.php @@ -14,6 +14,7 @@ use Magento\Review\Model\Resource\Rating\Collection as RatingCollection; * Review form block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Form extends \Magento\Framework\View\Element\Template { @@ -86,6 +87,7 @@ class Form extends \Magento\Framework\View\Element\Template * @param \Magento\Framework\App\Http\Context $httpContext * @param \Magento\Customer\Model\Url $customerUrl * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\View\Element\Template\Context $context, diff --git a/app/code/Magento/Review/Block/Product/View.php b/app/code/Magento/Review/Block/Product/View.php index 0a9194717af43e6084a609edf915ca897ac7f30c..377301f384d8d907618c06b604abb5cc6d1cc16a 100644 --- a/app/code/Magento/Review/Block/Product/View.php +++ b/app/code/Magento/Review/Block/Product/View.php @@ -12,6 +12,7 @@ use Magento\Review\Model\Resource\Review\Collection as ReviewCollection; * Product Reviews Page * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class View extends \Magento\Catalog\Block\Product\View { @@ -42,6 +43,7 @@ class View extends \Magento\Catalog\Block\Product\View * @param \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency * @param \Magento\Review\Model\Resource\Review\CollectionFactory $collectionFactory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Catalog\Block\Product\Context $context, diff --git a/app/code/Magento/Review/Controller/Adminhtml/Product/Save.php b/app/code/Magento/Review/Controller/Adminhtml/Product/Save.php index d3fc11045bfb219a0713864eafb7d3a0c49dbe7e..39150b4857d5dd54094f4ccaf89d82772d601051 100644 --- a/app/code/Magento/Review/Controller/Adminhtml/Product/Save.php +++ b/app/code/Magento/Review/Controller/Adminhtml/Product/Save.php @@ -10,6 +10,7 @@ class Save extends \Magento\Review\Controller\Adminhtml\Product { /** * @return mixed + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Review/Controller/Product.php b/app/code/Magento/Review/Controller/Product.php index 3521c9f6b601f76084d96bc73d6511b39aa21ca3..b44a29ec6c42fe188ee2cbd65ec391a4dc15fee9 100644 --- a/app/code/Magento/Review/Controller/Product.php +++ b/app/code/Magento/Review/Controller/Product.php @@ -14,6 +14,7 @@ use Magento\Review\Model\Review; * Review controller * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Product extends \Magento\Framework\App\Action\Action { @@ -107,6 +108,7 @@ class Product extends \Magento\Framework\App\Action\Action * @param \Magento\Framework\Session\Generic $reviewSession * @param \Magento\Store\Model\StoreManagerInterface $storeManager * @param \Magento\Core\App\Action\FormKeyValidator $formKeyValidator + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Action\Context $context, diff --git a/app/code/Magento/Review/Controller/Product/Post.php b/app/code/Magento/Review/Controller/Product/Post.php index c4910d951822f6a8a9cf19c864ddbfe1fc2d1136..f96213b50840bb6f0b74114a02b58c12af5bb7d8 100644 --- a/app/code/Magento/Review/Controller/Product/Post.php +++ b/app/code/Magento/Review/Controller/Product/Post.php @@ -14,6 +14,7 @@ class Post extends \Magento\Review\Controller\Product * Submit new review action * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Review/Helper/Action/Pager.php b/app/code/Magento/Review/Helper/Action/Pager.php index a276ab2ac6d5d794b6da09c996643bba78dd84ef..e6c8b6a2fb2f24d21c808554dfedc55045ee81a5 100644 --- a/app/code/Magento/Review/Helper/Action/Pager.php +++ b/app/code/Magento/Review/Helper/Action/Pager.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Review\Helper\Action; use Magento\Framework\Model\Exception; diff --git a/app/code/Magento/Review/Helper/Data.php b/app/code/Magento/Review/Helper/Data.php index 2a7f7ec10b0c903668bb4b5a21e9f58b48d505b8..a514519405b270e5de710f611917be9dc4f179f7 100644 --- a/app/code/Magento/Review/Helper/Data.php +++ b/app/code/Magento/Review/Helper/Data.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Review\Helper; /** @@ -77,6 +80,7 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * Return an indicator of whether or not guest is allowed to write * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsGuestAllowToWrite() { diff --git a/app/code/Magento/Review/Model/Resource/Rating.php b/app/code/Magento/Review/Model/Resource/Rating.php index dc360c221f78ba73f618f77a8cc42b34bcd790df..ffe552b3c104d2e0b0abce711e514f26db9f9151 100644 --- a/app/code/Magento/Review/Model/Resource/Rating.php +++ b/app/code/Magento/Review/Model/Resource/Rating.php @@ -159,6 +159,7 @@ class Rating extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param \Magento\Framework\Model\AbstractModel|\Magento\Review\Model\Rating $object * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _afterSave(\Magento\Framework\Model\AbstractModel $object) { diff --git a/app/code/Magento/Review/Model/Resource/Review/Product/Collection.php b/app/code/Magento/Review/Model/Resource/Review/Product/Collection.php index abef04b8346e6ee4b56667f49699fee2cad37072..d6c65b46c43e21600e3da5074dab2a521bd4ca0d 100644 --- a/app/code/Magento/Review/Model/Resource/Review/Product/Collection.php +++ b/app/code/Magento/Review/Model/Resource/Review/Product/Collection.php @@ -11,6 +11,7 @@ use Magento\Eav\Model\Entity\Attribute\AbstractAttribute; * Review Product Collection * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Collection extends \Magento\Catalog\Model\Resource\Product\Collection { @@ -448,6 +449,7 @@ class Collection extends \Magento\Catalog\Model\Resource\Product\Collection * @param array|null $condition * @param string $joinType * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function addAttributeToFilter($attribute, $condition = null, $joinType = 'inner') { diff --git a/app/code/Magento/Review/Model/Review.php b/app/code/Magento/Review/Model/Review.php index 4292125f31e517da6c32a229f9bb62118c7c8324..3660815cf0249498575242fc03feea81a36ef0a7 100644 --- a/app/code/Magento/Review/Model/Review.php +++ b/app/code/Magento/Review/Model/Review.php @@ -19,6 +19,7 @@ use Magento\Review\Model\Resource\Review\Status\Collection as StatusCollection; * @method \Magento\Review\Model\Review setEntityPkValue(int $value) * @method int getStatusId() * @method \Magento\Review\Model\Review setStatusId(int $value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Review extends \Magento\Framework\Model\AbstractModel { @@ -121,6 +122,7 @@ class Review extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Review/view/adminhtml/templates/rating/detailed.phtml b/app/code/Magento/Review/view/adminhtml/templates/rating/detailed.phtml index b1321cfbef03a0b37ed650ccbda2f23dd6313aec..1e04a02ba904ac06f616cee4ed1c1173e07562b0 100644 --- a/app/code/Magento/Review/view/adminhtml/templates/rating/detailed.phtml +++ b/app/code/Magento/Review/view/adminhtml/templates/rating/detailed.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getRating() && $this->getRating()->getSize()): ?> <div class="nested"> diff --git a/app/code/Magento/Review/view/adminhtml/templates/rating/form.phtml b/app/code/Magento/Review/view/adminhtml/templates/rating/form.phtml index f7e773ca1863a9b4e866e957eddda6207cfbefcd..cc56a7a9a5e451ad346349c4fa7eaef70f4d805f 100644 --- a/app/code/Magento/Review/view/adminhtml/templates/rating/form.phtml +++ b/app/code/Magento/Review/view/adminhtml/templates/rating/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="message info"> <div><?php echo __('Please specify a rating title for a store, or we\'ll just use the default value.'); ?></div> diff --git a/app/code/Magento/Review/view/adminhtml/templates/rating/options.phtml b/app/code/Magento/Review/view/adminhtml/templates/rating/options.phtml index 9d7af8197b66e4010379b453bcfe189aefc5486e..3d5a039bebe172ffd3ec198b09090803ec0e1947 100644 --- a/app/code/Magento/Review/view/adminhtml/templates/rating/options.phtml +++ b/app/code/Magento/Review/view/adminhtml/templates/rating/options.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="entry-edit-head"> <h4 class="icon-head head-edit-form fieldset-legend"><?php echo __('Assigned Options') ?></h4> diff --git a/app/code/Magento/Review/view/adminhtml/templates/rating/stars/detailed.phtml b/app/code/Magento/Review/view/adminhtml/templates/rating/stars/detailed.phtml index 9d270faf7d0c384f7bb974376700742dba68d90d..641dde0b7c008ab5726ad43e948df1dc15147f77 100644 --- a/app/code/Magento/Review/view/adminhtml/templates/rating/stars/detailed.phtml +++ b/app/code/Magento/Review/view/adminhtml/templates/rating/stars/detailed.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getRating() && $this->getRating()->getSize()): ?> <div class="ratings-container"> diff --git a/app/code/Magento/Review/view/adminhtml/templates/rating/stars/summary.phtml b/app/code/Magento/Review/view/adminhtml/templates/rating/stars/summary.phtml index e29a32ff228a7aab519785f0d910af3a0870f6eb..c5394e0bcb4d1168dc3edaa5b93e98c9e395b2c9 100644 --- a/app/code/Magento/Review/view/adminhtml/templates/rating/stars/summary.phtml +++ b/app/code/Magento/Review/view/adminhtml/templates/rating/stars/summary.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getRatingSummary()->getCount()): ?> <div class="rating-box"> diff --git a/app/code/Magento/Review/view/adminhtml/templates/rss/grid/link.phtml b/app/code/Magento/Review/view/adminhtml/templates/rss/grid/link.phtml index 652e65e1dbc7ba254d54a14897bd81bd86704611..8ccde118920025656143cb7fcb1e6ccd2719db4e 100644 --- a/app/code/Magento/Review/view/adminhtml/templates/rss/grid/link.phtml +++ b/app/code/Magento/Review/view/adminhtml/templates/rss/grid/link.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Review\Block\Adminhtml\Grid\Rss\Link */ ?> <?php if ($this->isRssAllowed() && $this->getLink()): ?> diff --git a/app/code/Magento/Review/view/frontend/templates/customer/list.phtml b/app/code/Magento/Review/view/frontend/templates/customer/list.phtml index 1c920e199b2bce6554df426dc5011ac00997f372..84b2f72995d0816de421ad40f0ac83f60a7a9e95 100644 --- a/app/code/Magento/Review/view/frontend/templates/customer/list.phtml +++ b/app/code/Magento/Review/view/frontend/templates/customer/list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getCollection() && $this->count()): ?> <div class="table-wrapper reviews"> diff --git a/app/code/Magento/Review/view/frontend/templates/customer/recent.phtml b/app/code/Magento/Review/view/frontend/templates/customer/recent.phtml index 042d0c48946ea15156e5119367792882e4cd02c9..2fc2d83149f98e758c6c61e8512863d56cbc544d 100644 --- a/app/code/Magento/Review/view/frontend/templates/customer/recent.phtml +++ b/app/code/Magento/Review/view/frontend/templates/customer/recent.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Review/view/frontend/templates/customer/view.phtml b/app/code/Magento/Review/view/frontend/templates/customer/view.phtml index 128c24a021b3f989d813841817237985f80e15d5..b60f1858b64ace9043f8e2a1c4e6fe604b28af06 100644 --- a/app/code/Magento/Review/view/frontend/templates/customer/view.phtml +++ b/app/code/Magento/Review/view/frontend/templates/customer/view.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getProductData()->getId()): ?> <?php $imageBlock = $this->getLayout()->createBlock('Magento\Catalog\Block\Product\Image'); ?> diff --git a/app/code/Magento/Review/view/frontend/templates/detailed.phtml b/app/code/Magento/Review/view/frontend/templates/detailed.phtml index 13374f014b747ff1c7c6def4c097c120202fb353..7ffa92cea0ec02aa6e00eb3983c7eaa002de4881 100644 --- a/app/code/Magento/Review/view/frontend/templates/detailed.phtml +++ b/app/code/Magento/Review/view/frontend/templates/detailed.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (!empty($collection) && $collection->getSize()): ?> <div class="table-wrapper"> diff --git a/app/code/Magento/Review/view/frontend/templates/form.phtml b/app/code/Magento/Review/view/frontend/templates/form.phtml index ae8a03e69e55e4710a35aefda78805198714a7d5..94ab2d74533f1bfc180483cefcf07b2823e5d606 100644 --- a/app/code/Magento/Review/view/frontend/templates/form.phtml +++ b/app/code/Magento/Review/view/frontend/templates/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Review\Block\Form */ diff --git a/app/code/Magento/Review/view/frontend/templates/helper/summary.phtml b/app/code/Magento/Review/view/frontend/templates/helper/summary.phtml index a3cc9f332c2b1c655af8fe7c3da575f2f48a0374..b112d00721c7d7b1840901fbe51b0d92b875c737 100644 --- a/app/code/Magento/Review/view/frontend/templates/helper/summary.phtml +++ b/app/code/Magento/Review/view/frontend/templates/helper/summary.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $url = $this->getReviewsUrl() . '#reviews'; ?> <?php $urlForm = $this->getReviewsUrl() . '#review-form'; ?> diff --git a/app/code/Magento/Review/view/frontend/templates/helper/summary_short.phtml b/app/code/Magento/Review/view/frontend/templates/helper/summary_short.phtml index 0c125ca10020451519bfc475ca574bc0f0eedab3..01c71a64bfb954a70a87e057ec8383eb5e4e7021 100644 --- a/app/code/Magento/Review/view/frontend/templates/helper/summary_short.phtml +++ b/app/code/Magento/Review/view/frontend/templates/helper/summary_short.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $url = $this->getReviewsUrl() . '#reviews'; ?> <?php $urlForm = $this->getReviewsUrl() . '#review-form'; ?> diff --git a/app/code/Magento/Review/view/frontend/templates/product/view/count.phtml b/app/code/Magento/Review/view/frontend/templates/product/view/count.phtml index 73df469ed1d07589825c30229358acf00a082e2f..9e6b13665e145c04169e668601f17f7ab32273f8 100644 --- a/app/code/Magento/Review/view/frontend/templates/product/view/count.phtml +++ b/app/code/Magento/Review/view/frontend/templates/product/view/count.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (!empty($count)):?> <a href="#customer-reviews" class="nobr"><?php echo __('%1 Review(s)', $count) ?></a> diff --git a/app/code/Magento/Review/view/frontend/templates/product/view/list.phtml b/app/code/Magento/Review/view/frontend/templates/product/view/list.phtml index c0f74d3a281f3b99268d3bea961ed11283099d11..cbb0f9c173e529eba680c6571f422a8f0f5eca86 100644 --- a/app/code/Magento/Review/view/frontend/templates/product/view/list.phtml +++ b/app/code/Magento/Review/view/frontend/templates/product/view/list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Review/view/frontend/templates/product/view/other.phtml b/app/code/Magento/Review/view/frontend/templates/product/view/other.phtml index fdb1119f88327f781f5cb1c7822ad6f3d93ea24e..3bd787ea696539121f118566dcc315f2c4317b64 100644 --- a/app/code/Magento/Review/view/frontend/templates/product/view/other.phtml +++ b/app/code/Magento/Review/view/frontend/templates/product/view/other.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Review\Block\Product\View\Other */ ?> diff --git a/app/code/Magento/Review/view/frontend/templates/redirect.phtml b/app/code/Magento/Review/view/frontend/templates/redirect.phtml index 3d1f8869e3bcd0b476fad84d4cc4d448aa647a9d..b2e82d1b9cacb983774dd588cb788e5023d3e980 100644 --- a/app/code/Magento/Review/view/frontend/templates/redirect.phtml +++ b/app/code/Magento/Review/view/frontend/templates/redirect.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* if(isset($GET['limit'])) { diff --git a/app/code/Magento/Review/view/frontend/templates/view.phtml b/app/code/Magento/Review/view/frontend/templates/view.phtml index f779b0ddd8b0906c0aabd30e3394842120b9b1ae..1f6cfa6bbb9f70d47fa8ee5eb9244ed0e2a9a2b6 100644 --- a/app/code/Magento/Review/view/frontend/templates/view.phtml +++ b/app/code/Magento/Review/view/frontend/templates/view.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getProductData()->getId()): ?> <div class="product-review"> diff --git a/app/code/Magento/Rss/view/frontend/templates/feeds.phtml b/app/code/Magento/Rss/view/frontend/templates/feeds.phtml index 266a3c61b06b11801554a52c14cdce4f3c1a14b4..fe1ea96e8c8594789918bcb386a537e9b1286dc9 100644 --- a/app/code/Magento/Rss/view/frontend/templates/feeds.phtml +++ b/app/code/Magento/Rss/view/frontend/templates/feeds.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <table class="data table rss"> <caption class="table-caption"><?php echo __('Feed'); ?></caption> diff --git a/app/code/Magento/Rule/Model/AbstractModel.php b/app/code/Magento/Rule/Model/AbstractModel.php index e94c84ae9fd1f7f34e44a7fe86cfa7c35d3a898d..ccdd7bf107780a516c94bf1a89a15728421efdc4 100644 --- a/app/code/Magento/Rule/Model/AbstractModel.php +++ b/app/code/Magento/Rule/Model/AbstractModel.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Abstract Rule entity data model */ @@ -100,6 +102,7 @@ abstract class AbstractModel extends \Magento\Framework\Model\AbstractModel * * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function beforeSave() { @@ -297,6 +300,7 @@ abstract class AbstractModel extends \Magento\Framework\Model\AbstractModel * * @param array $data * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _convertFlatToRecursive(array $data) { @@ -351,6 +355,8 @@ abstract class AbstractModel extends \Magento\Framework\Model\AbstractModel * * @param \Magento\Framework\Object $object * @return bool|string[] - return true if validation passed successfully. Array with errors description otherwise + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validateData(\Magento\Framework\Object $object) { diff --git a/app/code/Magento/Rule/Model/Action/AbstractAction.php b/app/code/Magento/Rule/Model/Action/AbstractAction.php index 710a5dcbe9203673f0472a55f30441002991c079..8e01621b733e0ab7b60568444c36a465bacc022e 100644 --- a/app/code/Magento/Rule/Model/Action/AbstractAction.php +++ b/app/code/Magento/Rule/Model/Action/AbstractAction.php @@ -338,6 +338,7 @@ abstract class AbstractAction extends \Magento\Framework\Object implements Actio /** * @param string $format * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function asString($format = '') { diff --git a/app/code/Magento/Rule/Model/Condition/AbstractCondition.php b/app/code/Magento/Rule/Model/Condition/AbstractCondition.php index 59f917beb6bbd725357625deba10f1a24ddffab2..6bc5bd70d37e79939021284eda38e6c0a4812bb2 100644 --- a/app/code/Magento/Rule/Model/Condition/AbstractCondition.php +++ b/app/code/Magento/Rule/Model/Condition/AbstractCondition.php @@ -14,6 +14,10 @@ namespace Magento\Rule\Model\Condition; use Magento\Framework\Data\Form; use Magento\Framework\Data\Form\Element\AbstractElement; +/** + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + */ abstract class AbstractCondition extends \Magento\Framework\Object implements ConditionInterface { /** @@ -217,6 +221,7 @@ abstract class AbstractCondition extends \Magento\Framework\Object implements Co /** * @param array $arr * @return $this + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function loadArray($arr) { @@ -408,6 +413,7 @@ abstract class AbstractCondition extends \Magento\Framework\Object implements Co /** * @return array|string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getValueName() { @@ -702,6 +708,9 @@ abstract class AbstractCondition extends \Magento\Framework\Object implements Co * * @param object|array|int|string|float|bool $validatedValue product attribute value * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function validateAttribute($validatedValue) { diff --git a/app/code/Magento/Rule/Model/Condition/Combine.php b/app/code/Magento/Rule/Model/Condition/Combine.php index 2f290cd984774dfd96f3100819ccdd96b1eb0c81..f68a13163a0b62dd93d4f887ff3a12134d32aa5b 100644 --- a/app/code/Magento/Rule/Model/Condition/Combine.php +++ b/app/code/Magento/Rule/Model/Condition/Combine.php @@ -200,6 +200,7 @@ class Combine extends AbstractCondition * @param array $arr * @param string $key * @return $this + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function loadArray($arr, $key = 'conditions') { diff --git a/app/code/Magento/Rule/Model/Condition/Product/AbstractProduct.php b/app/code/Magento/Rule/Model/Condition/Product/AbstractProduct.php index ee74a67b7ff67d49997067312bc18a6accc5de99..696fc409c69a7d1e1769317213427ef3a839e333 100644 --- a/app/code/Magento/Rule/Model/Condition/Product/AbstractProduct.php +++ b/app/code/Magento/Rule/Model/Condition/Product/AbstractProduct.php @@ -11,6 +11,10 @@ */ namespace Magento\Rule\Model\Condition\Product; +/** + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ abstract class AbstractProduct extends \Magento\Rule\Model\Condition\AbstractCondition { /** @@ -189,6 +193,7 @@ abstract class AbstractProduct extends \Magento\Rule\Model\Condition\AbstractCon * 'value_option' - hashed array: array($value => $label, ...), * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _prepareValueOptions() { @@ -457,6 +462,7 @@ abstract class AbstractProduct extends \Magento\Rule\Model\Condition\AbstractCon * Retrieve Explicit Apply * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getExplicitApply() { @@ -483,6 +489,7 @@ abstract class AbstractProduct extends \Magento\Rule\Model\Condition\AbstractCon * * @param array $arr * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function loadArray($arr) { @@ -526,6 +533,8 @@ abstract class AbstractProduct extends \Magento\Rule\Model\Condition\AbstractCon * * @param \Magento\Framework\Model\AbstractModel $model * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validate(\Magento\Framework\Model\AbstractModel $model) { diff --git a/app/code/Magento/Rule/Model/Condition/Sql/Builder.php b/app/code/Magento/Rule/Model/Condition/Sql/Builder.php index aa5f1d74847af8fbba9b0aea90edcde8568ca143..43e1ab5177159766d4d0bdf1e48ada4134dd3540 100644 --- a/app/code/Magento/Rule/Model/Condition/Sql/Builder.php +++ b/app/code/Magento/Rule/Model/Condition/Sql/Builder.php @@ -141,6 +141,7 @@ class Builder * @param Combine $combine * @param string $value * @return string + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getMappedSqlCombination(Combine $combine, $value = '') { diff --git a/app/code/Magento/Sales/Api/CreditmemoCommentRepositoryInterface.php b/app/code/Magento/Sales/Api/CreditmemoCommentRepositoryInterface.php index 4fca9528e43ff385417b5749e8dd23a07d11f75d..5df81ef17ce49fb0007e3f584a64d079c03b3451 100644 --- a/app/code/Magento/Sales/Api/CreditmemoCommentRepositoryInterface.php +++ b/app/code/Magento/Sales/Api/CreditmemoCommentRepositoryInterface.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Api; /** diff --git a/app/code/Magento/Sales/Api/CreditmemoManagementInterface.php b/app/code/Magento/Sales/Api/CreditmemoManagementInterface.php index 0295d03d2dce5e2de4c8ba0b4d2b4c0fff8ede82..0211a82933663431c110c1da6c206c63b7cafaaa 100644 --- a/app/code/Magento/Sales/Api/CreditmemoManagementInterface.php +++ b/app/code/Magento/Sales/Api/CreditmemoManagementInterface.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Api; /** diff --git a/app/code/Magento/Sales/Api/Data/CreditmemoInterface.php b/app/code/Magento/Sales/Api/Data/CreditmemoInterface.php index d3d0bee1c621888b249e5166345b9fcb2469b646..e7047e546f03668e2001fce706ca00ab5f3aaf5f 100644 --- a/app/code/Magento/Sales/Api/Data/CreditmemoInterface.php +++ b/app/code/Magento/Sales/Api/Data/CreditmemoInterface.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Api\Data; /** diff --git a/app/code/Magento/Sales/Api/OrderManagementInterface.php b/app/code/Magento/Sales/Api/OrderManagementInterface.php index 943ad02d1e61655c9246f5cedd2612882a2250c0..071d1ac787f6b00b68a4c99d181cfcd5f94b822d 100644 --- a/app/code/Magento/Sales/Api/OrderManagementInterface.php +++ b/app/code/Magento/Sales/Api/OrderManagementInterface.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Api; /** diff --git a/app/code/Magento/Sales/Api/OrderStatusHistoryRepositoryInterface.php b/app/code/Magento/Sales/Api/OrderStatusHistoryRepositoryInterface.php index 660b27a82aa685b93f7f6058e8260ea53a0082ef..66db1edbaa4662929f132b537c37d0203f6479e4 100644 --- a/app/code/Magento/Sales/Api/OrderStatusHistoryRepositoryInterface.php +++ b/app/code/Magento/Sales/Api/OrderStatusHistoryRepositoryInterface.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Api; /** diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Address/Form.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Address/Form.php index 2510300b9ca0954eaffc903047d0bc79efcdf217..c2b04646e891dc815a62624b3819162dd7944be7 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Address/Form.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Address/Form.php @@ -9,6 +9,8 @@ use Magento\Framework\Pricing\PriceCurrencyInterface; /** * Adminhtml sales order address block + * @SuppressWarnings(PHPMD.DepthOfInheritance) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Form extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\Address { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/AbstractCreate.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/AbstractCreate.php index d1f3ecc4f8c067f657c6813dd998e57b9ea2a8a2..83bb55bfe1b72efbec78a2944bcaf16c2ec6eecc 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/AbstractCreate.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/AbstractCreate.php @@ -11,6 +11,7 @@ use Magento\Framework\Pricing\PriceCurrencyInterface; * Adminhtml sales order create abstract block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractCreate extends \Magento\Backend\Block\Widget { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Address.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Address.php index 59f81853b034bfa3893d976b87590b96bd8fca4c..a72cf38445f4ccf07f6332b5d5509403676942ca 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Address.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Address.php @@ -9,6 +9,7 @@ namespace Magento\Sales\Block\Adminhtml\Order\Create\Billing; * Adminhtml sales order create billing address block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\Address { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form.php index 8334ec391ef907f35b2a78b8585afa1b68066c45..5c4e676481b9e763c368d3eb8e15c89c27d14dcd 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form.php @@ -56,6 +56,7 @@ class Form extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate * @param \Magento\Framework\Locale\CurrencyInterface $localeCurrency * @param \Magento\Customer\Model\Address\Mapper $addressMapper * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Backend\Block\Template\Context $context, diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/AbstractForm.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/AbstractForm.php index 712a00ea0b9482029a8a22d987ac7676625671da..db49cde19169e44967ddc82ab4aac3284989dd34 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/AbstractForm.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/AbstractForm.php @@ -141,6 +141,7 @@ abstract class AbstractForm extends \Magento\Sales\Block\Adminhtml\Order\Create\ * * @param \Magento\Framework\Data\Form\Element\AbstractElement $element * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _addAdditionalFormElementData(\Magento\Framework\Data\Form\Element\AbstractElement $element) { @@ -153,6 +154,7 @@ abstract class AbstractForm extends \Magento\Sales\Block\Adminhtml\Order\Create\ * @param \Magento\Customer\Api\Data\AttributeMetadataInterface[] $attributes * @param \Magento\Framework\Data\Form\AbstractForm $form * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _addAttributesToForm($attributes, \Magento\Framework\Data\Form\AbstractForm $form) { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Account.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Account.php index aaa9f93d055618399cc50d611737ef4c1d546973..08137358bf707fcf9fd251f21c9d2c9e0dd1f152 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Account.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Account.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Block\Adminhtml\Order\Create\Form; use Magento\Framework\Api\ExtensibleDataObjectConverter; @@ -46,6 +49,7 @@ class Account extends AbstractForm * @param \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository * @param ExtensibleDataObjectConverter $extensibleDataObjectConverter * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Backend\Block\Template\Context $context, diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Address.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Address.php index 8dec273fe7ba482a160bc1b60fd405ee24480bd8..b139f0314352608c075dbf379ffcea3215aa345d 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Address.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Form/Address.php @@ -10,6 +10,7 @@ use Magento\Framework\Pricing\PriceCurrencyInterface; /** * Order create address form + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\AbstractForm { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Items/Grid.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Items/Grid.php index a9aed237d31a257188b18424aadb57d27efd138a..6d53e62c71ab36b157551a929ffe97997acf6228 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Items/Grid.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Items/Grid.php @@ -14,6 +14,7 @@ use Magento\Quote\Model\Quote\Item; /** * Adminhtml sales order create items grid block + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Grid extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate { @@ -82,6 +83,7 @@ class Grid extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate * @param StockRegistryInterface $stockRegistry * @param StockStateInterface $stockState * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Backend\Block\Template\Context $context, @@ -447,6 +449,7 @@ class Grid extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate * Get flag for rights to move items to customer storage * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getMoveToCustomerStorage() { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Shipping/Address.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Shipping/Address.php index b4a0f91f686ba19db746674e58f3e91092fcc407..e6c03f666a8e8f05024e0d4b7ccc4c3405c189e4 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Shipping/Address.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Shipping/Address.php @@ -9,6 +9,7 @@ namespace Magento\Sales\Block\Adminhtml\Order\Create\Shipping; * Adminhtml sales order create shipping address block * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\Address { @@ -63,6 +64,7 @@ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\Address * Same as billing address flag * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsAsBilling() { @@ -73,6 +75,7 @@ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\Address * Saving shipping address must be turned off, when it is the same as billing * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDontSaveInAddressBook() { @@ -119,6 +122,7 @@ class Address extends \Magento\Sales\Block\Adminhtml\Order\Create\Form\Address * Return true is the quote is virtual * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsDisabled() { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/AbstractSidebar.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/AbstractSidebar.php index 28c05b5379901b6e8f4d1148cc67147ea1d7a778..ada04889aa2674a3fff8514b66c78de4abd5b606 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/AbstractSidebar.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Sidebar/AbstractSidebar.php @@ -140,6 +140,7 @@ class AbstractSidebar extends \Magento\Sales\Block\Adminhtml\Order\Create\Abstra * Retrieve all items * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getItems() { @@ -218,6 +219,7 @@ class AbstractSidebar extends \Magento\Sales\Block\Adminhtml\Order\Create\Abstra * * @param string|int|null $productType * @return false + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function isConfigurationRequired($productType) { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals.php index b999c6d3d92ca2c6139e27ad8acbeb324fade6fe..66dc3274dd4def11ae4837029ed03419e7091c6e 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals.php @@ -187,6 +187,7 @@ class Totals extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate * Get note notification * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getNoteNotify() { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Discount.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Discount.php index 2b4a79d4bbd2bd766323857fa325e14c1c413f26..584f443efbefcbf9a88ce8ffd36fcc1c59b7c5d3 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Discount.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Discount.php @@ -11,6 +11,7 @@ use Magento\Framework\Pricing\PriceCurrencyInterface; * Subtotal Total Row Renderer * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Discount extends \Magento\Sales\Block\Adminhtml\Order\Create\Totals\DefaultTotals { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Grandtotal.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Grandtotal.php index 2fe463f3809c2ddadf9508a7a74447f933e4a540..67211ec745a2eb9800e5e4caeeb96dae464e58a2 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Grandtotal.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Grandtotal.php @@ -11,6 +11,7 @@ use Magento\Framework\Pricing\PriceCurrencyInterface; * Subtotal Total Row Renderer * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grandtotal extends \Magento\Sales\Block\Adminhtml\Order\Create\Totals\DefaultTotals { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Shipping.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Shipping.php index b34c835fbc3d3a53292cd68570d9261dd0733354..1d00dad06c8c553ee7a0d63fb561c800a7fb2d07 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Shipping.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Shipping.php @@ -11,6 +11,7 @@ use Magento\Framework\Pricing\PriceCurrencyInterface; * Subtotal Total Row Renderer * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Shipping extends \Magento\Sales\Block\Adminhtml\Order\Create\Totals\DefaultTotals { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Subtotal.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Subtotal.php index 48a00d5b49286476e590367779829aba48ad862c..7f7fb65e1322e71c85766bb8eeba3e405d0bc2cd 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Subtotal.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Subtotal.php @@ -11,6 +11,7 @@ use Magento\Framework\Pricing\PriceCurrencyInterface; * Subtotal Total Row Renderer * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Subtotal extends \Magento\Sales\Block\Adminhtml\Order\Create\Totals\DefaultTotals { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Tax.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Tax.php index 839c55464c75cc973cbeba6efddb094bd339c074..42731212784eb73a523acf465f8eec3ad18dafe1 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Tax.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Totals/Tax.php @@ -9,6 +9,7 @@ namespace Magento\Sales\Block\Adminhtml\Order\Create\Totals; * Tax Total Row Renderer * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Tax extends \Magento\Sales\Block\Adminhtml\Order\Create\Totals\DefaultTotals { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/Create/Items.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/Create/Items.php index 4749e8127d036a620f6bfb7e01efea39b249db46..7b77a9a64c407553f5268b2ee72a0cdf92df7d73 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/Create/Items.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/Create/Items.php @@ -92,6 +92,7 @@ class Items extends \Magento\Sales\Block\Adminhtml\Items\AbstractItems * Get is submit button disabled or not * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDisableSubmitButton() { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/View.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/View.php index ea629a60c9c1ad67f77a71c57a463dd552cacd1b..598eed53a15d6aa25d0e5b7768a606a0c35e2a43 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/View.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Invoice/View.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Block\Adminhtml\Order\Invoice; /** @@ -54,6 +57,8 @@ class View extends \Magento\Backend\Block\Widget\Form\Container * Constructor * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _construct() { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Status/Edit/Form.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Status/Edit/Form.php index 7e8db3001f810459bac35064c948901d6d01f066..a14eb0ed898024d1031eb17ad87234ac060a1515 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Status/Edit/Form.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Status/Edit/Form.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Block\Adminhtml\Order\Status\Edit; /** * Edit status form + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Form extends \Magento\Sales\Block\Adminhtml\Order\Status\NewStatus\Form { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/View.php b/app/code/Magento/Sales/Block/Adminhtml/Order/View.php index fd9ce395e74ea99e39581c1c1ba0bfb86103b9df..79020e2a0c59067cc3569df62efee82bc9a5257e 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/View.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/View.php @@ -64,6 +64,9 @@ class View extends \Magento\Backend\Block\Widget\Form\Container * Constructor * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _construct() { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form.php b/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form.php index fde3381ab014ba5962b42ccb84268a43206c3aa5..b7aefa2d344ef1d56b5a9797092e1542bb43a382 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form.php @@ -9,6 +9,7 @@ namespace Magento\Sales\Block\Adminhtml\Report\Filter; * Sales Adminhtml report filter form * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Form extends \Magento\Reports\Block\Adminhtml\Filter\Form { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form/Coupon.php b/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form/Coupon.php index f69da0c59b9726cc53b00dcd24d11995dc1b225d..b67df217903c4123dedc5b399f1110a8422f22cd 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form/Coupon.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form/Coupon.php @@ -9,6 +9,7 @@ namespace Magento\Sales\Block\Adminhtml\Report\Filter\Form; * Sales Adminhtml report filter form for coupons report * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Coupon extends \Magento\Sales\Block\Adminhtml\Report\Filter\Form { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form/Order.php b/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form/Order.php index a9c5b16967156ccc18b6dc20cb22a0a482bfdb39..b8309267361eb24d5ac0266a16035c710aab15e1 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form/Order.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Report/Filter/Form/Order.php @@ -9,6 +9,7 @@ namespace Magento\Sales\Block\Adminhtml\Report\Filter\Form; * Sales Adminhtml report filter form order * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Order extends \Magento\Sales\Block\Adminhtml\Report\Filter\Form { @@ -16,6 +17,7 @@ class Order extends \Magento\Sales\Block\Adminhtml\Report\Filter\Form * Preparing form * * @return $this + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _prepareForm() { diff --git a/app/code/Magento/Sales/Block/Adminhtml/System/Config/Form/Fieldset/Order/Statuses.php b/app/code/Magento/Sales/Block/Adminhtml/System/Config/Form/Fieldset/Order/Statuses.php index b3aee4a4bcab9e2bd5f9d04e10fa5b5da73f703d..1f775bf7c6634c47de1c972acf55de457c7c4bad 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/System/Config/Form/Fieldset/Order/Statuses.php +++ b/app/code/Magento/Sales/Block/Adminhtml/System/Config/Form/Fieldset/Order/Statuses.php @@ -104,6 +104,7 @@ class Statuses extends \Magento\Backend\Block\System\Config\Form\Fieldset * @param string $id * @param string $status * @return string + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getFieldHtml($fieldset, $id, $status) { diff --git a/app/code/Magento/Sales/Block/Items/AbstractItems.php b/app/code/Magento/Sales/Block/Items/AbstractItems.php index 11523ac439eb979b5e93401d16e611fb38bdc583..728b46470af08ca1b81c90b95346364304580277 100644 --- a/app/code/Magento/Sales/Block/Items/AbstractItems.php +++ b/app/code/Magento/Sales/Block/Items/AbstractItems.php @@ -9,6 +9,7 @@ namespace Magento\Sales\Block\Items; * Abstract block for display sales (quote/order/invoice etc.) items * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class AbstractItems extends \Magento\Framework\View\Element\Template { @@ -23,6 +24,7 @@ class AbstractItems extends \Magento\Framework\View\Element\Template * @param string $type * @return \Magento\Framework\View\Element\AbstractBlock * @throws \RuntimeException + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getItemRenderer($type) { @@ -47,6 +49,7 @@ class AbstractItems extends \Magento\Framework\View\Element\Template * * @param \Magento\Framework\View\Element\AbstractBlock $renderer * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _prepareItem(\Magento\Framework\View\Element\AbstractBlock $renderer) { diff --git a/app/code/Magento/Sales/Block/Order/Creditmemo/Totals.php b/app/code/Magento/Sales/Block/Order/Creditmemo/Totals.php index 4fa114b5ee96d01086ae7842ed825de6240d00d1..a03ca172c5f7c293487bb93f9d7bde266f78483b 100644 --- a/app/code/Magento/Sales/Block/Order/Creditmemo/Totals.php +++ b/app/code/Magento/Sales/Block/Order/Creditmemo/Totals.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Block\Order\Creditmemo; use Magento\Sales\Model\Order\Creditmemo; diff --git a/app/code/Magento/Sales/Block/Order/Item/Renderer/DefaultRenderer.php b/app/code/Magento/Sales/Block/Order/Item/Renderer/DefaultRenderer.php index 79a29a35ba58109fbc8d958901f878fa3c5b1c72..c6ea7d810dc0948e6984bf152d6783cb2278ec28 100644 --- a/app/code/Magento/Sales/Block/Order/Item/Renderer/DefaultRenderer.php +++ b/app/code/Magento/Sales/Block/Order/Item/Renderer/DefaultRenderer.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Block\Order\Item\Renderer; use Magento\Sales\Model\Order\CreditMemo\Item as CreditMemoItem; @@ -123,6 +126,7 @@ class DefaultRenderer extends \Magento\Framework\View\Element\Template * ) * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getFormatedOptionValue($optionValue) { diff --git a/app/code/Magento/Sales/Block/Order/Totals.php b/app/code/Magento/Sales/Block/Order/Totals.php index 5c19f07551de92c75e589a6bff298ff0fe7f80dc..a173a51146d3a1b699a8e12d9d3cd458f7a42c9d 100644 --- a/app/code/Magento/Sales/Block/Order/Totals.php +++ b/app/code/Magento/Sales/Block/Order/Totals.php @@ -285,6 +285,7 @@ class Totals extends \Magento\Framework\View\Element\Template * * @param array $order * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function applySortOrder($order) { diff --git a/app/code/Magento/Sales/Block/Status/Grid/Column/State.php b/app/code/Magento/Sales/Block/Status/Grid/Column/State.php index ac83c7879bd59cf798b10daeaa358ede3ec7d085..7f5b650e85fc7b6d4c70bb51f938d1f6352853c7 100644 --- a/app/code/Magento/Sales/Block/Status/Grid/Column/State.php +++ b/app/code/Magento/Sales/Block/Status/Grid/Column/State.php @@ -45,6 +45,7 @@ class State extends \Magento\Backend\Block\Widget\Grid\Column * @param \Magento\Backend\Block\Widget\Grid\Column $column * @param bool $isExport * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function decorateState($value, $row, $column, $isExport) { diff --git a/app/code/Magento/Sales/Block/Status/Grid/Column/Unassign.php b/app/code/Magento/Sales/Block/Status/Grid/Column/Unassign.php index 27629b7809f1819cfc8a0284ff8a224006b9f013..0d924f05464a9ee88855914f8b611b3188c7aa59 100644 --- a/app/code/Magento/Sales/Block/Status/Grid/Column/Unassign.php +++ b/app/code/Magento/Sales/Block/Status/Grid/Column/Unassign.php @@ -25,6 +25,7 @@ class Unassign extends \Magento\Backend\Block\Widget\Grid\Column * @param \Magento\Backend\Block\Widget\Grid\Column $column * @param bool $isExport * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function decorateAction($value, $row, $column, $isExport) { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/View.php b/app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/View.php index f535f59bc08586889146362388f04be661a22896..267d84431bd5b2dc4f4d5d160f36473348c7de35 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/View.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/View.php @@ -20,6 +20,7 @@ class View extends \Magento\Backend\App\Action * Creditmemo information page * * @return void + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order.php b/app/code/Magento/Sales/Controller/Adminhtml/Order.php index 5aa141ae06b18e76ec6af6b473197d5efa533702..ae425500611ade3fb71ca663dcbb58cc7faf1ede 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order.php @@ -11,6 +11,7 @@ use Magento\Backend\App\Action; * Adminhtml sales orders controller * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Order extends \Magento\Backend\App\Action { @@ -101,6 +102,7 @@ class Order extends \Magento\Backend\App\Action * Acl check for admin * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _isAllowed() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/Create.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/Create.php index 1d22b23b24bc449226be32eae6618cf0233337a3..08ac01a05321aad30771c27d55496c2298b1b75e 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/Create.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/Create.php @@ -11,6 +11,7 @@ use Magento\Backend\App\Action; * Adminhtml sales orders creation process controller * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Create extends \Magento\Backend\App\Action { @@ -120,6 +121,9 @@ class Create extends \Magento\Backend\App\Action * * @param string $action * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _processActionData($action = null) { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/Create/Save.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/Create/Save.php index 601b6e683104be1afb1287d0e8b2738857f2b27d..49c7f1ae5ff482681a48d640a8d396ce233d2099 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/Create/Save.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/Create/Save.php @@ -13,6 +13,7 @@ class Save extends \Magento\Sales\Controller\Adminhtml\Order\Create * Saving quote and create order * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Save.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Save.php index 2856c97fecce926a7df987f8e03dc9000f86379a..29416472331b4a298753f2cc991c8ea8a0c77d4d 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Save.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Save.php @@ -50,6 +50,8 @@ class Save extends \Magento\Backend\App\Action * We can save only new creditmemo. Existing creditmemos are not editable * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoader.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoader.php index 66b0cc06f0568f78a1e26d50ea210cd6470bad27..4468f01f7e68ce0a11579e15313013d6491dac8a 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoader.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoader.php @@ -79,6 +79,7 @@ class CreditmemoLoader extends Object * @param \Magento\Framework\Registry $registry * @param \Magento\CatalogInventory\Api\StockConfigurationInterface $stockConfiguration * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Sales\Model\Order\CreditmemoFactory $creditmemoFactory, @@ -173,6 +174,7 @@ class CreditmemoLoader extends Object * Initialize creditmemo model instance * * @return \Magento\Sales\Model\Order\Creditmemo|false + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function load() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/Save.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/Save.php index 82bcd79fe9a910ce21fbdf4e0adc0bdd8b67ebbc..cbc04f14c659dd0aa314ee6cc7acf0a50af2c45a 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/Save.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/Save.php @@ -95,6 +95,9 @@ class Save extends \Magento\Backend\App\Action * We can save only new invoice. Existing invoices are not editable * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/Pdfdocs.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/Pdfdocs.php index d7c3b45d5b29fab83323286cf4c579a74c59ec79..9fdebb897551af735087c9a593f15a9ed995385d 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/Pdfdocs.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/Pdfdocs.php @@ -15,6 +15,7 @@ class Pdfdocs extends \Magento\Sales\Controller\Adminhtml\Order * Print all documents for selected orders * * @return ResponseInterface|void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Shipment/AbstractShipment/View.php b/app/code/Magento/Sales/Controller/Adminhtml/Shipment/AbstractShipment/View.php index cd7bf2de861eecd5a38570c88fed6cadfa4c14ca..ba190ac2cbc5040338ca608dc560995455a633c3 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Shipment/AbstractShipment/View.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Shipment/AbstractShipment/View.php @@ -20,6 +20,7 @@ abstract class View extends \Magento\Backend\App\Action * Shipment information page * * @return void + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php b/app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php index ee5dca3db252af6309a2f2ec3bb5df4fbc1914b6..84defe91734829fc7a6c513c5fe0ab73665be1e1 100644 --- a/app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php +++ b/app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php @@ -14,6 +14,8 @@ class DownloadCustomOption extends \Magento\Framework\App\Action\Action * Custom options download action * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExitExpression) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Order/Plugin/Authentication.php b/app/code/Magento/Sales/Controller/Order/Plugin/Authentication.php index 13356e24e572ddbd593fd3f050c00a376aa728cc..02aaad1b1baaa4df85de61e19c61ae6657367eac 100644 --- a/app/code/Magento/Sales/Controller/Order/Plugin/Authentication.php +++ b/app/code/Magento/Sales/Controller/Order/Plugin/Authentication.php @@ -38,6 +38,7 @@ class Authentication * @param \Magento\Framework\App\ActionInterface $subject * @param RequestInterface $request * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function beforeDispatch(\Magento\Framework\App\ActionInterface $subject, RequestInterface $request) { diff --git a/app/code/Magento/Sales/Helper/Guest.php b/app/code/Magento/Sales/Helper/Guest.php index 71318f24cacbd184168a09d227df3dd068ea044e..5ba1261f9a00552c590f0e88f727370db940724b 100644 --- a/app/code/Magento/Sales/Helper/Guest.php +++ b/app/code/Magento/Sales/Helper/Guest.php @@ -10,6 +10,7 @@ use Magento\Framework\App as App; /** * Sales module base helper + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Guest extends \Magento\Core\Helper\Data { diff --git a/app/code/Magento/Sales/Helper/Reorder.php b/app/code/Magento/Sales/Helper/Reorder.php index 9740e150da4844a185c1f7f7a502f70e270cdce9..f93c02fccdef0da47c54ca7b6ad1d6b8ca447af3 100644 --- a/app/code/Magento/Sales/Helper/Reorder.php +++ b/app/code/Magento/Sales/Helper/Reorder.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Helper; /** diff --git a/app/code/Magento/Sales/Model/AdminOrder/Create.php b/app/code/Magento/Sales/Model/AdminOrder/Create.php index 59189864b2b544d358aaa04bfc36aa0c7f11fed7..fd4ec66b5e13c3fc087df66717682f265a9baf10 100644 --- a/app/code/Magento/Sales/Model/AdminOrder/Create.php +++ b/app/code/Magento/Sales/Model/AdminOrder/Create.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\AdminOrder; use Magento\Customer\Api\AddressMetadataInterface; @@ -11,6 +14,9 @@ use Magento\Quote\Model\Quote\Item; /** * Order create model + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Model\Cart\CartInterface { @@ -229,6 +235,7 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode * @param \Magento\Customer\Model\Customer\Mapper $customerMapper * @param \Magento\Quote\Model\QuoteManagement $quoteManagement * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\ObjectManagerInterface $objectManager, @@ -300,6 +307,7 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode * Return is validate data in import flag * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsValidate() { @@ -434,6 +442,8 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode * @param \Magento\Sales\Model\Order $order * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function initFromOrder(\Magento\Sales\Model\Order $order) { @@ -715,6 +725,8 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode * @param int $qty * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function moveQuoteItem($item, $moveTo, $qty) { @@ -840,6 +852,9 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode * @param array $data * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function applySidebarData($data) { @@ -1553,6 +1568,8 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode * * @param array $data * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function importPostData($data) { @@ -1653,6 +1670,7 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode * Set customer data to quote. * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function _prepareCustomer() { @@ -1715,6 +1733,7 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode * @param \Magento\Quote\Model\Quote\Address $quoteCustomerAddress * @return void * @throws \InvalidArgumentException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _prepareCustomerAddress($customer, $quoteCustomerAddress) { @@ -1840,6 +1859,8 @@ class Create extends \Magento\Framework\Object implements \Magento\Checkout\Mode * * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _validate() { diff --git a/app/code/Magento/Sales/Model/Config/Converter.php b/app/code/Magento/Sales/Model/Config/Converter.php index 7529fc9d34c3791c199451a399baf7365bfc0a18..4f4b80f5995d1c8a5b4fe31d015f3172eaed026d 100644 --- a/app/code/Magento/Sales/Model/Config/Converter.php +++ b/app/code/Magento/Sales/Model/Config/Converter.php @@ -17,6 +17,7 @@ class Converter implements \Magento\Framework\Config\ConverterInterface * @param mixed $source * @return array * @throws \InvalidArgumentException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function convert($source) { diff --git a/app/code/Magento/Sales/Model/Convert/Order.php b/app/code/Magento/Sales/Model/Convert/Order.php index 76a2ff567121d4c45669cac5f74217d33630aee2..7ac320f80388b437544d4378fb9826834bdc09a1 100644 --- a/app/code/Magento/Sales/Model/Convert/Order.php +++ b/app/code/Magento/Sales/Model/Convert/Order.php @@ -9,6 +9,9 @@ */ namespace Magento\Sales\Model\Convert; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Order extends \Magento\Framework\Object { /** diff --git a/app/code/Magento/Sales/Model/Order.php b/app/code/Magento/Sales/Model/Order.php index ed7228c6288dcf69f2d606ae18da62258901c247..d2269ca8a1b7b6f3154f6b8bb5a10e67fe0c7b65 100644 --- a/app/code/Magento/Sales/Model/Order.php +++ b/app/code/Magento/Sales/Model/Order.php @@ -176,6 +176,10 @@ use Magento\Sales\Model\Resource\Order\Status\History\Collection as HistoryColle * @method bool hasForcedCanCreditmemo() * @method bool getIsInProcess() * @method \Magento\Customer\Model\Customer getCustomer() + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Order extends AbstractModel implements EntityInterface, ApiOrderInterface { @@ -412,6 +416,7 @@ class Order extends AbstractModel implements EntityInterface, ApiOrderInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -530,6 +535,7 @@ class Order extends AbstractModel implements EntityInterface, ApiOrderInterface * Return flag for order if it can sends new email to customer. * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCanSendNewEmailFlag() { @@ -590,6 +596,8 @@ class Order extends AbstractModel implements EntityInterface, ApiOrderInterface * Retrieve order cancel availability * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function canCancel() { @@ -649,6 +657,7 @@ class Order extends AbstractModel implements EntityInterface, ApiOrderInterface * Retrieve order invoice availability * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function canInvoice() { @@ -759,6 +768,7 @@ class Order extends AbstractModel implements EntityInterface, ApiOrderInterface * Retrieve order shipment availability * * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function canShip() { @@ -842,6 +852,7 @@ class Order extends AbstractModel implements EntityInterface, ApiOrderInterface * * @param bool $ignoreSalable * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _canReorder($ignoreSalable = false) { @@ -2002,6 +2013,7 @@ class Order extends AbstractModel implements EntityInterface, ApiOrderInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsNotVirtual() { diff --git a/app/code/Magento/Sales/Model/Order/Address.php b/app/code/Magento/Sales/Model/Order/Address.php index 7d549e8c29c4e0e91b62206c40890cc2021fbe73..2cf363e7de2d8a38d33b8180f92b90a57abebeab 100644 --- a/app/code/Magento/Sales/Model/Order/Address.php +++ b/app/code/Magento/Sales/Model/Order/Address.php @@ -38,6 +38,7 @@ use Magento\Sales\Api\Data\OrderAddressInterface; * @method Address setMiddlename(string $value) * @method Address setSuffix(string $value) * @method Address setCompany(string $value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Address extends AbstractAddress implements OrderAddressInterface { @@ -78,6 +79,7 @@ class Address extends AbstractAddress implements OrderAddressInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Sales/Model/Order/Builder.php b/app/code/Magento/Sales/Model/Order/Builder.php index 2dd79cd89ba61e913682b3956731bae9b149398d..f0c2e25e4cdb4ce0affca3865030285f7fb16b9b 100644 --- a/app/code/Magento/Sales/Model/Order/Builder.php +++ b/app/code/Magento/Sales/Model/Order/Builder.php @@ -8,6 +8,9 @@ namespace Magento\Sales\Model\Order; use Magento\Sales\Model\OrderFactory; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + */ class Builder { /** diff --git a/app/code/Magento/Sales/Model/Order/Creditmemo.php b/app/code/Magento/Sales/Model/Order/Creditmemo.php index 1ccb71d61d0e48e1e4f5c8fbff012d431d669388..b9a2aea4780d63fe940f6087ff4120ca8f2a20d0 100644 --- a/app/code/Magento/Sales/Model/Order/Creditmemo.php +++ b/app/code/Magento/Sales/Model/Order/Creditmemo.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order; use Magento\Framework\Api\AttributeDataBuilder; @@ -60,6 +63,9 @@ use Magento\Sales\Model\EntityInterface; * @method \Magento\Sales\Model\Order\Creditmemo setBaseShippingHiddenTaxAmnt(float $value) * @method \Magento\Sales\Model\Order\Creditmemo setShippingInclTax(float $value) * @method \Magento\Sales\Model\Order\Creditmemo setBaseShippingInclTax(float $value) + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Creditmemo extends AbstractModel implements EntityInterface, CreditmemoInterface { @@ -165,6 +171,7 @@ class Creditmemo extends AbstractModel implements EntityInterface, CreditmemoInt * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -754,6 +761,7 @@ class Creditmemo extends AbstractModel implements EntityInterface, CreditmemoInt /** * @param bool $reload * @return \Magento\Sales\Model\Resource\Order\Creditmemo\Comment\Collection + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getCommentsCollection($reload = false) { diff --git a/app/code/Magento/Sales/Model/Order/Creditmemo/Comment.php b/app/code/Magento/Sales/Model/Order/Creditmemo/Comment.php index 27312a4aa22b9c6bdbde9053adcffd1edbb7d681..e3b00c1136294977299d37cfa4e0d809fd4dc45e 100644 --- a/app/code/Magento/Sales/Model/Order/Creditmemo/Comment.php +++ b/app/code/Magento/Sales/Model/Order/Creditmemo/Comment.php @@ -43,6 +43,7 @@ class Comment extends AbstractModel implements CreditmemoCommentInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Sales/Model/Order/Creditmemo/Total/AbstractTotal.php b/app/code/Magento/Sales/Model/Order/Creditmemo/Total/AbstractTotal.php index b6cfb7a2d74f46f4a94085bc190ae67a4713900b..0b3af734428d8d2e49521dbc762e4af4f2abb1c8 100644 --- a/app/code/Magento/Sales/Model/Order/Creditmemo/Total/AbstractTotal.php +++ b/app/code/Magento/Sales/Model/Order/Creditmemo/Total/AbstractTotal.php @@ -17,6 +17,7 @@ abstract class AbstractTotal extends \Magento\Sales\Model\Order\Total\AbstractTo * * @param \Magento\Sales\Model\Order\Creditmemo $creditmemo * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function collect(\Magento\Sales\Model\Order\Creditmemo $creditmemo) { diff --git a/app/code/Magento/Sales/Model/Order/Customer.php b/app/code/Magento/Sales/Model/Order/Customer.php index 22edcac7c43186e12bb26de16d432858943d445c..87fb453e710f72085f367abc41c878d0cb9cbd5f 100644 --- a/app/code/Magento/Sales/Model/Order/Customer.php +++ b/app/code/Magento/Sales/Model/Order/Customer.php @@ -93,6 +93,7 @@ class Customer * @param string $customerPrefix * @param string $customerSuffix * @param string $customerTaxvat + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( $customerDob, diff --git a/app/code/Magento/Sales/Model/Order/Email/NotifySender.php b/app/code/Magento/Sales/Model/Order/Email/NotifySender.php index 2c027d604582b83bd4134e41177395ad3e224bc0..9244852e77523d8ac1d6db2d29b5a93bc5da013e 100644 --- a/app/code/Magento/Sales/Model/Order/Email/NotifySender.php +++ b/app/code/Magento/Sales/Model/Order/Email/NotifySender.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order\Email; use Magento\Sales\Model\Order; diff --git a/app/code/Magento/Sales/Model/Order/Invoice.php b/app/code/Magento/Sales/Model/Order/Invoice.php index 93854c2be239442c8467e46aafbffd648c4fd469..b494782a7dfab66c2d4c8879cc5613854f58fc19 100644 --- a/app/code/Magento/Sales/Model/Order/Invoice.php +++ b/app/code/Magento/Sales/Model/Order/Invoice.php @@ -52,6 +52,9 @@ use Magento\Sales\Model\EntityInterface; * @method \Magento\Sales\Model\Order\Invoice setBaseShippingHiddenTaxAmnt(float $value) * @method \Magento\Sales\Model\Order\Invoice setShippingInclTax(float $value) * @method \Magento\Sales\Model\Order\Invoice setBaseShippingInclTax(float $value) + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Invoice extends AbstractModel implements EntityInterface, InvoiceInterface { @@ -166,6 +169,7 @@ class Invoice extends AbstractModel implements EntityInterface, InvoiceInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -617,6 +621,7 @@ class Invoice extends AbstractModel implements EntityInterface, InvoiceInterface * * @return $this * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function register() { diff --git a/app/code/Magento/Sales/Model/Order/Invoice/Comment.php b/app/code/Magento/Sales/Model/Order/Invoice/Comment.php index 7743e0c21fa00aef3b5bffaa04d75fc4da5678a7..3b4f4787f70c891850220d042b1aff4d7c245743 100644 --- a/app/code/Magento/Sales/Model/Order/Invoice/Comment.php +++ b/app/code/Magento/Sales/Model/Order/Invoice/Comment.php @@ -43,6 +43,7 @@ class Comment extends AbstractModel implements InvoiceCommentInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Sales/Model/Order/Invoice/Total/AbstractTotal.php b/app/code/Magento/Sales/Model/Order/Invoice/Total/AbstractTotal.php index a9bff16a96859750b26073160b3cee1e5fa5d4d5..ae4e6111cada93fda613c355fe937afc0de2441a 100644 --- a/app/code/Magento/Sales/Model/Order/Invoice/Total/AbstractTotal.php +++ b/app/code/Magento/Sales/Model/Order/Invoice/Total/AbstractTotal.php @@ -17,6 +17,7 @@ abstract class AbstractTotal extends \Magento\Sales\Model\Order\Total\AbstractTo * * @param \Magento\Sales\Model\Order\Invoice $invoice * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function collect(\Magento\Sales\Model\Order\Invoice $invoice) { diff --git a/app/code/Magento/Sales/Model/Order/Invoice/Total/Tax.php b/app/code/Magento/Sales/Model/Order/Invoice/Total/Tax.php index f6314349b17a9aef7705f2842520acad1fa1d9fe..d1d2cee1f3ec2ac6ee6ad92a7c84b6ee57ac7bec 100644 --- a/app/code/Magento/Sales/Model/Order/Invoice/Total/Tax.php +++ b/app/code/Magento/Sales/Model/Order/Invoice/Total/Tax.php @@ -12,6 +12,7 @@ class Tax extends AbstractTotal * * @param \Magento\Sales\Model\Order\Invoice $invoice * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function collect(\Magento\Sales\Model\Order\Invoice $invoice) { diff --git a/app/code/Magento/Sales/Model/Order/Item.php b/app/code/Magento/Sales/Model/Order/Item.php index 6f6044f24b3ae06ed97f92fe9861ebd0e2237f50..fcc9aa7959fb31e2287962ec790271ced56b3534 100644 --- a/app/code/Magento/Sales/Model/Order/Item.php +++ b/app/code/Magento/Sales/Model/Order/Item.php @@ -94,6 +94,9 @@ use Magento\Sales\Api\Data\OrderItemInterface; * @method \Magento\Sales\Model\Order\Item setBaseTaxRefunded(float $value) * @method \Magento\Sales\Model\Order\Item setDiscountRefunded(float $value) * @method \Magento\Sales\Model\Order\Item setBaseDiscountRefunded(float $value) + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Item extends AbstractExtensibleModel implements OrderItemInterface { @@ -181,6 +184,7 @@ class Item extends AbstractExtensibleModel implements OrderItemInterface * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param \Magento\Store\Model\StoreManagerInterface $storeManager * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -371,6 +375,8 @@ class Item extends AbstractExtensibleModel implements OrderItemInterface * Retrieve item status identifier * * @return int + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getStatusId() { @@ -625,6 +631,7 @@ class Item extends AbstractExtensibleModel implements OrderItemInterface * Check if discount has to be applied to parent item * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getForceApplyDiscountToParentItem() { @@ -668,6 +675,7 @@ class Item extends AbstractExtensibleModel implements OrderItemInterface * * @param bool $shipment * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function isDummy($shipment = false) { diff --git a/app/code/Magento/Sales/Model/Order/Payment.php b/app/code/Magento/Sales/Model/Order/Payment.php index c1c956a50b92e29e470c3fa4251687daf18a1455..0ada9c295824bd8e2f916a262383ec1564be87ce 100644 --- a/app/code/Magento/Sales/Model/Order/Payment.php +++ b/app/code/Magento/Sales/Model/Order/Payment.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order; use Magento\Framework\Api\AttributeDataBuilder; @@ -67,6 +70,9 @@ use Magento\Sales\Api\Data\OrderPaymentInterface; * @method \Magento\Sales\Model\Order\Payment setCcNumberEnc(string $value) * @method \Magento\Sales\Model\Order\Payment setCcTransId(string $value) * @method \Magento\Sales\Model\Order\Payment setAddressStatus(string $value) + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Payment extends Info implements OrderPaymentInterface { @@ -159,6 +165,7 @@ class Payment extends Info implements OrderPaymentInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -279,6 +286,7 @@ class Payment extends Info implements OrderPaymentInterface * This method is supposed to be called only when order is placed * * @return $this + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function place() { @@ -693,6 +701,8 @@ class Payment extends Info implements OrderPaymentInterface * @return $this * @throws \Exception * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function refund($creditmemo) { @@ -788,6 +798,7 @@ class Payment extends Info implements OrderPaymentInterface * * @param float $amount * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function registerRefundNotification($amount) { @@ -976,6 +987,8 @@ class Payment extends Info implements OrderPaymentInterface * @param bool $isOnline * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function registerPaymentReviewAction($action, $isOnline) { @@ -1193,6 +1206,8 @@ class Payment extends Info implements OrderPaymentInterface * @param float $amount * @param string $gatewayCallback * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _void($isOnline, $amount = null, $gatewayCallback = 'void') { @@ -1267,6 +1282,8 @@ class Payment extends Info implements OrderPaymentInterface * @param \Magento\Sales\Model\AbstractModel $salesDocument * @param bool $failsafe * @return null|\Magento\Sales\Model\Order\Payment\Transaction + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _addTransaction($type, $salesDocument = null, $failsafe = false) { diff --git a/app/code/Magento/Sales/Model/Order/Payment/Transaction.php b/app/code/Magento/Sales/Model/Order/Payment/Transaction.php index 82c5dc8495d2ee7bb31b1c531604f6e0dde0485e..1d87d92ad1751983e08f68a1fb5b106063a23c9c 100644 --- a/app/code/Magento/Sales/Model/Order/Payment/Transaction.php +++ b/app/code/Magento/Sales/Model/Order/Payment/Transaction.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order\Payment; use Magento\Framework\Api\AttributeDataBuilder; @@ -23,6 +26,8 @@ use Magento\Sales\Api\Data\TransactionInterface; * @method \Magento\Sales\Model\Order\Payment\Transaction setCreatedAt(string $value) * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Transaction extends AbstractExtensibleModel implements TransactionInterface { @@ -161,6 +166,7 @@ class Transaction extends AbstractExtensibleModel implements TransactionInterfac * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -300,6 +306,9 @@ class Transaction extends AbstractExtensibleModel implements TransactionInterfac * @param string $txnId * @param bool $recursive * @return Transaction[] + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getChildTransactions($types = null, $txnId = null, $recursive = false) { @@ -568,6 +577,7 @@ class Transaction extends AbstractExtensibleModel implements TransactionInterfac * @return $this * @throws \Magento\Framework\Model\Exception * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function close($shouldSave = true) { @@ -727,6 +737,8 @@ class Transaction extends AbstractExtensibleModel implements TransactionInterfac * * @return void * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _loadChildren() { diff --git a/app/code/Magento/Sales/Model/Order/Pdf/AbstractPdf.php b/app/code/Magento/Sales/Model/Order/Pdf/AbstractPdf.php index 0e1157c30245d0dff406441d7dad381be6e338a4..a2c0b3de2f296987d0b30c15b6e07744b246d2c6 100644 --- a/app/code/Magento/Sales/Model/Order/Pdf/AbstractPdf.php +++ b/app/code/Magento/Sales/Model/Order/Pdf/AbstractPdf.php @@ -3,12 +3,17 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order\Pdf; use Magento\Framework\App\Filesystem\DirectoryList; /** * Sales Order PDF abstract model + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractPdf extends \Magento\Framework\Object { @@ -219,6 +224,7 @@ abstract class AbstractPdf extends \Magento\Framework\Object * @param \Zend_Pdf_Page &$page * @param null $store * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function insertLogo(&$page, $store = null) { @@ -330,6 +336,7 @@ abstract class AbstractPdf extends \Magento\Framework\Object * * @param array $address * @return int Height + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _calcAddressHeight($address) { @@ -355,6 +362,9 @@ abstract class AbstractPdf extends \Magento\Framework\Object * @param \Magento\Sales\Model\Order $obj * @param bool $putOrderId * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function insertOrder(&$page, $obj, $putOrderId = true) { @@ -930,6 +940,9 @@ abstract class AbstractPdf extends \Magento\Framework\Object * @param array $pageSettings * @throws \Magento\Framework\Model\Exception * @return \Zend_Pdf_Page + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function drawLineBlocks(\Zend_Pdf_Page $page, array $draw, array $pageSettings = []) { diff --git a/app/code/Magento/Sales/Model/Order/Pdf/Creditmemo.php b/app/code/Magento/Sales/Model/Order/Pdf/Creditmemo.php index 03b9131ec0b414208767bc84c3cddb208577ef35..acd8d3f9b6d78474726192cf53fa521f997b935c 100644 --- a/app/code/Magento/Sales/Model/Order/Pdf/Creditmemo.php +++ b/app/code/Magento/Sales/Model/Order/Pdf/Creditmemo.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Model\Order\Pdf; /** * Sales Order Creditmemo PDF model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Creditmemo extends AbstractPdf { diff --git a/app/code/Magento/Sales/Model/Order/Pdf/Invoice.php b/app/code/Magento/Sales/Model/Order/Pdf/Invoice.php index 1e3c554387dc7b3c417be82e3c90fd0d87d98bff..79b3130b684496b306b556ac7a089651960137f5 100644 --- a/app/code/Magento/Sales/Model/Order/Pdf/Invoice.php +++ b/app/code/Magento/Sales/Model/Order/Pdf/Invoice.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Model\Order\Pdf; /** * Sales Order Invoice PDF model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Invoice extends AbstractPdf { diff --git a/app/code/Magento/Sales/Model/Order/Pdf/Items/AbstractItems.php b/app/code/Magento/Sales/Model/Order/Pdf/Items/AbstractItems.php index ea036a57e78be13303900f8727e1b088501b0e76..a6c248caedf751d6250b892afa0107b41372268e 100644 --- a/app/code/Magento/Sales/Model/Order/Pdf/Items/AbstractItems.php +++ b/app/code/Magento/Sales/Model/Order/Pdf/Items/AbstractItems.php @@ -9,6 +9,7 @@ use Magento\Framework\App\Filesystem\DirectoryList; /** * Sales Order Pdf Items renderer Abstract + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractItems extends \Magento\Framework\Model\AbstractModel { diff --git a/app/code/Magento/Sales/Model/Order/Pdf/Shipment.php b/app/code/Magento/Sales/Model/Order/Pdf/Shipment.php index b38f5334997e2a805bb4a7f9f68ff63df1a9e52b..46594554ba69d203c2f2215dd2cdbac639d0c53b 100644 --- a/app/code/Magento/Sales/Model/Order/Pdf/Shipment.php +++ b/app/code/Magento/Sales/Model/Order/Pdf/Shipment.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Model\Order\Pdf; /** * Sales Order Shipment PDF model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Shipment extends AbstractPdf { diff --git a/app/code/Magento/Sales/Model/Order/Pdf/Total/DefaultTotal.php b/app/code/Magento/Sales/Model/Order/Pdf/Total/DefaultTotal.php index c5b7e801a368bbd2365dc10908ffbf63472985aa..aef42991031bf93a575ad64431320130a8f807d6 100644 --- a/app/code/Magento/Sales/Model/Order/Pdf/Total/DefaultTotal.php +++ b/app/code/Magento/Sales/Model/Order/Pdf/Total/DefaultTotal.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order\Pdf\Total; /** @@ -89,6 +92,7 @@ class DefaultTotal extends \Magento\Framework\Object * ) * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getFullTaxInfo() { diff --git a/app/code/Magento/Sales/Model/Order/Shipment.php b/app/code/Magento/Sales/Model/Order/Shipment.php index eb6ecf045f6fd8123ae7d6acf9cfac04e9d3af3b..7941d2e5706018ca71ef4186d0b1d07136d9b518 100644 --- a/app/code/Magento/Sales/Model/Order/Shipment.php +++ b/app/code/Magento/Sales/Model/Order/Shipment.php @@ -27,6 +27,7 @@ use Magento\Sales\Model\EntityInterface; * @method \Magento\Sales\Model\Order\Shipment setIncrementId(string $value) * @method \Magento\Sales\Model\Order\Shipment setCreatedAt(string $value) * @method \Magento\Sales\Model\Order\Shipment setUpdatedAt(string $value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Shipment extends AbstractModel implements EntityInterface, ShipmentInterface { @@ -113,6 +114,7 @@ class Shipment extends AbstractModel implements EntityInterface, ShipmentInterfa * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Sales/Model/Order/Shipment/Comment.php b/app/code/Magento/Sales/Model/Order/Shipment/Comment.php index a4c1ed52c006f3126426e2f8e048343d6897bc15..bec79910266e960b1260e34c4c4102da06f267b1 100644 --- a/app/code/Magento/Sales/Model/Order/Shipment/Comment.php +++ b/app/code/Magento/Sales/Model/Order/Shipment/Comment.php @@ -43,6 +43,7 @@ class Comment extends AbstractModel implements ShipmentCommentInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Sales/Model/Order/Shipment/Item.php b/app/code/Magento/Sales/Model/Order/Shipment/Item.php index 9f78dad996e7377079881a3a66594fe2a0269dd8..0980fc98559069616451237b3ee6be0efcf5e45e 100644 --- a/app/code/Magento/Sales/Model/Order/Shipment/Item.php +++ b/app/code/Magento/Sales/Model/Order/Shipment/Item.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order\Shipment; use Magento\Framework\Api\AttributeDataBuilder; diff --git a/app/code/Magento/Sales/Model/Order/Shipment/Track.php b/app/code/Magento/Sales/Model/Order/Shipment/Track.php index 6d7d8b5e9eccaf75e70616cde05d66a2598bdc75..41c4c2521d9639cd5bf3f25f1a53084954983b2e 100644 --- a/app/code/Magento/Sales/Model/Order/Shipment/Track.php +++ b/app/code/Magento/Sales/Model/Order/Shipment/Track.php @@ -23,6 +23,7 @@ use Magento\Sales\Model\AbstractModel; * @method \Magento\Sales\Model\Order\Shipment\Track setUpdatedAt(string $value) * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Track extends AbstractModel implements ShipmentTrackInterface { @@ -68,6 +69,7 @@ class Track extends AbstractModel implements ShipmentTrackInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Sales/Model/Order/Status/History.php b/app/code/Magento/Sales/Model/Order/Status/History.php index c5ca7be39735f319bad9416e0af407d616febd9a..306ba2715f4cd703bba8ef5e15d0b9ccdaf611e7 100644 --- a/app/code/Magento/Sales/Model/Order/Status/History.php +++ b/app/code/Magento/Sales/Model/Order/Status/History.php @@ -57,6 +57,7 @@ class History extends AbstractModel implements OrderStatusHistoryInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Sales/Model/Resource/Collection/AbstractCollection.php b/app/code/Magento/Sales/Model/Resource/Collection/AbstractCollection.php index 46a8e399166a5968a9a9307a19370ed603072487..6edcac391a19be29f25fdc1f585116c159fc7684 100644 --- a/app/code/Magento/Sales/Model/Resource/Collection/AbstractCollection.php +++ b/app/code/Magento/Sales/Model/Resource/Collection/AbstractCollection.php @@ -163,6 +163,7 @@ abstract class AbstractCollection extends \Magento\Framework\Model\Resource\Db\C * @return $this * * @todo implement join functionality if necessary + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function joinAttribute($alias, $attribute, $bind, $filter = null, $joinType = 'inner', $storeId = null) { diff --git a/app/code/Magento/Sales/Model/Resource/Entity.php b/app/code/Magento/Sales/Model/Resource/Entity.php index f948734924783eada454776cfa9031e99787fa3a..2cc6faf6f126694130ff20a91c69eb05e5978a01 100644 --- a/app/code/Magento/Sales/Model/Resource/Entity.php +++ b/app/code/Magento/Sales/Model/Resource/Entity.php @@ -10,6 +10,7 @@ use Magento\Sales\Model\EntityInterface; /** * Flat sales resource abstract + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class Entity extends AbstractDb { diff --git a/app/code/Magento/Sales/Model/Resource/Order/Grid/Collection.php b/app/code/Magento/Sales/Model/Resource/Order/Grid/Collection.php index 43c78c11bf5b82cc61d02ca4aef3ce12647ccade..5b673d4a23dc5bad3e9dfa631ca32fdb8ba451a4 100644 --- a/app/code/Magento/Sales/Model/Resource/Order/Grid/Collection.php +++ b/app/code/Magento/Sales/Model/Resource/Order/Grid/Collection.php @@ -86,6 +86,7 @@ class Collection extends \Magento\Sales\Model\Resource\Order\Collection * Get customer mode flag value * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsCustomerMode() { diff --git a/app/code/Magento/Sales/Model/Resource/Order/Handler/State.php b/app/code/Magento/Sales/Model/Resource/Order/Handler/State.php index 39d46be2bd97b4fcf61f6cd3eeddd9d3a8cd1a5f..a0530530e0b14a6f854f7c62e705428fb2ca4382 100644 --- a/app/code/Magento/Sales/Model/Resource/Order/Handler/State.php +++ b/app/code/Magento/Sales/Model/Resource/Order/Handler/State.php @@ -18,6 +18,8 @@ class State * * @param Order $order * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function check(Order $order) { diff --git a/app/code/Magento/Sales/Model/Resource/Order/Plugin/Authorization.php b/app/code/Magento/Sales/Model/Resource/Order/Plugin/Authorization.php index 33d6e9ab88f20e181f3fc7b911f8ac26b2c039dd..4fc8acc8046c127a33caa8c4ce0046475926fe07 100644 --- a/app/code/Magento/Sales/Model/Resource/Order/Plugin/Authorization.php +++ b/app/code/Magento/Sales/Model/Resource/Order/Plugin/Authorization.php @@ -35,6 +35,7 @@ class Authorization * @param null|string $field * @return \Magento\Sales\Model\Order * @throws NoSuchEntityException + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aroundLoad( \Magento\Sales\Model\Resource\Order $subject, diff --git a/app/code/Magento/Sales/Model/Resource/Order/Status.php b/app/code/Magento/Sales/Model/Resource/Order/Status.php index e013a4a85c101a5280befcf662e02f83165c58e5..fb47d4cb1781c0947a9d4c0230b1e790345a06d6 100644 --- a/app/code/Magento/Sales/Model/Resource/Order/Status.php +++ b/app/code/Magento/Sales/Model/Resource/Order/Status.php @@ -266,6 +266,7 @@ class Status extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param string $state * @return string + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function getStatusByState($state) { diff --git a/app/code/Magento/Sales/Model/Resource/Report/Bestsellers.php b/app/code/Magento/Sales/Model/Resource/Report/Bestsellers.php index d0529e458400ec10e4eadaff2c3e9440fdadb5fb..173d376346079dd0d7fc149201de5e8b3ad2d6a0 100644 --- a/app/code/Magento/Sales/Model/Resource/Report/Bestsellers.php +++ b/app/code/Magento/Sales/Model/Resource/Report/Bestsellers.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Model\Resource\Report; /** * Bestsellers report resource model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Bestsellers extends AbstractReport { @@ -80,6 +81,7 @@ class Bestsellers extends AbstractReport * @param string|int|\Zend_Date|array|null $to * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function aggregate($from = null, $to = null) { diff --git a/app/code/Magento/Sales/Model/Resource/Report/Bestsellers/Collection.php b/app/code/Magento/Sales/Model/Resource/Report/Bestsellers/Collection.php index 331a909384f6bffb470b32717998131dafa67a67..3ea1cfc8bae97789526812ca3fac0e6b55d39d0a 100644 --- a/app/code/Magento/Sales/Model/Resource/Report/Bestsellers/Collection.php +++ b/app/code/Magento/Sales/Model/Resource/Report/Bestsellers/Collection.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Resource\Report\Bestsellers; /** @@ -217,6 +220,9 @@ class Collection extends \Magento\Sales\Model\Resource\Report\Collection\Abstrac * but before adding unions and calculating totals * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _beforeLoad() { diff --git a/app/code/Magento/Sales/Model/Resource/Report/Invoiced.php b/app/code/Magento/Sales/Model/Resource/Report/Invoiced.php index 9d931bc56a8743dbd9d146c962a1dc712962f654..ceb64d2658b67dcee2baf3763617168bb9290570 100644 --- a/app/code/Magento/Sales/Model/Resource/Report/Invoiced.php +++ b/app/code/Magento/Sales/Model/Resource/Report/Invoiced.php @@ -50,6 +50,7 @@ class Invoiced extends AbstractReport * @param string|null $to * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _aggregateByInvoiceCreatedAt($from, $to) { diff --git a/app/code/Magento/Sales/Model/Resource/Report/Order/Createdat.php b/app/code/Magento/Sales/Model/Resource/Report/Order/Createdat.php index f48f917c1298e015c1e25d25ee1cec2250533897..0de50475f360db0bbc4491d5b1e3ce398f02a118 100644 --- a/app/code/Magento/Sales/Model/Resource/Report/Order/Createdat.php +++ b/app/code/Magento/Sales/Model/Resource/Report/Order/Createdat.php @@ -42,6 +42,8 @@ class Createdat extends \Magento\Sales\Model\Resource\Report\AbstractReport * @param string|int|\Zend_Date|array|null $to * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _aggregateByField($aggregationField, $from, $to) { diff --git a/app/code/Magento/Sales/Model/Resource/Report/Refunded.php b/app/code/Magento/Sales/Model/Resource/Report/Refunded.php index 583b86da77de7cfe082ca657e68c70d3a5c47d0a..80a0f43fb28d2daab8e2edfe8b0754a95336b731 100644 --- a/app/code/Magento/Sales/Model/Resource/Report/Refunded.php +++ b/app/code/Magento/Sales/Model/Resource/Report/Refunded.php @@ -137,6 +137,7 @@ class Refunded extends AbstractReport * @param string|null $to * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _aggregateByRefundCreatedAt($from, $to) { diff --git a/app/code/Magento/Sales/Model/Resource/Report/Shipping.php b/app/code/Magento/Sales/Model/Resource/Report/Shipping.php index 387d810862e9ae505644857519ec64d7aae28528..5d041dac931ef9b188f71d3d873e7b12e10de816 100644 --- a/app/code/Magento/Sales/Model/Resource/Report/Shipping.php +++ b/app/code/Magento/Sales/Model/Resource/Report/Shipping.php @@ -141,6 +141,7 @@ class Shipping extends AbstractReport * @param string|null $to * @return $this * @throws \Exception + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _aggregateByShippingCreatedAt($from, $to) { diff --git a/app/code/Magento/Sales/Model/Resource/Setup.php b/app/code/Magento/Sales/Model/Resource/Setup.php index c856c3a4a91390687be1abbae61caa203075c378..6a308344f68f947358f2490b9337414595296d54 100644 --- a/app/code/Magento/Sales/Model/Resource/Setup.php +++ b/app/code/Magento/Sales/Model/Resource/Setup.php @@ -159,6 +159,8 @@ class Setup extends \Magento\Eav\Model\Entity\Setup * @param string $code * @param array $data * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getAttributeColumnDefinition($code, $data) { diff --git a/app/code/Magento/Sales/Model/Service/Order.php b/app/code/Magento/Sales/Model/Service/Order.php index ad9c8ded4693a25b9d5271e159c861f49faf4b6a..5860dd46d6c91ef5a11130759b024f1f32f1bccc 100644 --- a/app/code/Magento/Sales/Model/Service/Order.php +++ b/app/code/Magento/Sales/Model/Service/Order.php @@ -205,6 +205,8 @@ class Order * @param object $invoice * @param array $data * @return \Magento\Sales\Model\Order\Creditmemo + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function prepareInvoiceCreditmemo($invoice, $data = []) { @@ -316,6 +318,7 @@ class Order * @param \Magento\Sales\Model\Order\Item $item * @param array $qtys * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _canInvoiceItem($item, $qtys = []) { @@ -356,6 +359,7 @@ class Order * @param \Magento\Sales\Model\Order\Item $item * @param array $qtys * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _canShipItem($item, $qtys = []) { @@ -402,6 +406,7 @@ class Order * @param array $qtys * @param array $invoiceQtysRefundLimits * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _canRefundItem($item, $qtys = [], $invoiceQtysRefundLimits = []) { diff --git a/app/code/Magento/Sales/view/adminhtml/templates/items/column/name.phtml b/app/code/Magento/Sales/view/adminhtml/templates/items/column/name.phtml index 9fc94e8a439f26e69acd656e29f26d134db6efe3..dd9e46018498c2b2eff7f820ab54e1d92980f2ee 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/items/column/name.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/items/column/name.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Sales/view/adminhtml/templates/items/column/qty.phtml b/app/code/Magento/Sales/view/adminhtml/templates/items/column/qty.phtml index b43ddc2c57a378d3a312ffaa5a519155cc02628b..77fb1ce783226decd83539945015b8312ec7d790 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/items/column/qty.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/items/column/qty.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($_item = $this->getItem()): ?> <table cellspacing="0" class="qty-table"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/items/price/row.phtml b/app/code/Magento/Sales/view/adminhtml/templates/items/price/row.phtml index 6f8efd8ca688129680fd80f56bc266fe19120cdd..27eeaea2a092f6ab48b0f7cff2d32a27d0b0cbd1 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/items/price/row.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/items/price/row.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Sales\Block\Adminhtml\Items\Column\DefaultColumn $this */ diff --git a/app/code/Magento/Sales/view/adminhtml/templates/items/price/total.phtml b/app/code/Magento/Sales/view/adminhtml/templates/items/price/total.phtml index 40500face1c56b2010bf4e17f5272f6d0990c936..09086c0477d09ae4ab7ee266ee83c58fd6da5dab 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/items/price/total.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/items/price/total.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Sales\Block\Adminhtml\Items\Column\DefaultColumn $this */ diff --git a/app/code/Magento/Sales/view/adminhtml/templates/items/price/unit.phtml b/app/code/Magento/Sales/view/adminhtml/templates/items/price/unit.phtml index 52741f30012eac6c0d0f9f4be8e887c8fa5961d2..81d9dedfd189361a5c93c4ce07d6beabda2d712e 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/items/price/unit.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/items/price/unit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Sales\Block\Adminhtml\Items\Column\DefaultColumn $this */ diff --git a/app/code/Magento/Sales/view/adminhtml/templates/items/renderer/default.phtml b/app/code/Magento/Sales/view/adminhtml/templates/items/renderer/default.phtml index c8761f9b8bca77a550113eb48fbec71c8af4d6e8..1f7e6fb4a5e848569aeef8422aafc9aeb87875f6 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/items/renderer/default.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getItem()->getName() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/address/form.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/address/form.phtml index 3716f80e4dfcca99fb70dadf8fd9d2e481be7f12..55c896f34a96df0c07495bcbfd9ff796919e6050 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/address/form.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/address/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="message message-info"> <div class="message-inner"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/comments/view.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/comments/view.phtml index 860b17146bb8de6fb6576f71751fb4a102ceb781..23af5210b39fa5b765a16497d929e810d9259663 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/comments/view.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/comments/view.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($_entity = $this->getEntity()): ?> <div id="comments_block"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/abstract.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/abstract.phtml index e34054186bc3eb012f849501151679f04d46c79d..9ce326d446a8aa7722287aa6a63a941e7a430afc 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/abstract.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/abstract.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="fieldset-wrapper-title"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/billing/method/form.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/billing/method/form.phtml index 988a3b2d0770c90b5a47875c6c6a214261647a70..3e6161a03889101c741ca6a6e2f53e7390d50701 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/billing/method/form.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/billing/method/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->hasMethods()): ?> <div id="order-billing_method_form"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/comment.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/comment.phtml index f4bb723c7ad46c35eaf305dc742f40ae739a5868..6b46e3e78d94ad73a9bbcd61123208b0d6d3d1fb 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/comment.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/comment.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <!--<h4 class="icon-head fieldset-legend <?php echo $this->getHeaderCssClass() ?>"><?php echo $this->getHeaderText() ?></h4>--> <label for="order-comment"><?php echo __('Order Comments') ?></label><br /> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/coupons/form.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/coupons/form.phtml index f6531d0c601f852a4e92c4fede0a5b5826a8e976..ea93c9e692d338eae58e4bb82c2bd99ccf287551 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/coupons/form.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/coupons/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/data.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/data.phtml index e5d31d190fe86e90b060ea5e555a5c21364a6afe..1e0cb9b37021ae5db71be1597b37430e556fa737 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/data.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/data.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="page-create-order"> <script> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/form.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/form.phtml index e5b981914eb0898075a6a9976a372a152194f113..cc34fec1e78647c4372e6d0f4a3b624fe752af54 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/form.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var \Magento\Sales\Block\Adminhtml\Order\Create\Form $this */ ?> <form id="edit_form" data-order-config='<?php echo $this->getOrderDataJson() ?>' data-load-base-url="<?php echo $this->getLoadBlockUrl() ?>" action="<?php echo $this->getSaveUrl() ?>" method="post" enctype="multipart/form-data"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/form/address.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/form/address.phtml index 4270bd0dba031c83d531fe5d1e6c96d634d6f05f..1adec92d5b2415f923c15df435774d3685ae1f2e 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/form/address.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/form/address.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @var \Magento\Sales\Block\Adminhtml\Order\Create\Billing\Address|\Magento\Sales\Block\Adminhtml\Order\Create\Shipping\Address $this */ diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/giftmessage.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/giftmessage.phtml index 5c12eab59e48dd4b5cf33e6417bcc6e25dc725a3..8b0bd2ceebf7aba2dfb4265a325074dca1ca6182 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/giftmessage.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/giftmessage.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->helper('Magento\GiftMessage\Helper\Message')->getIsMessagesAvailable('main', $this->getQuote(), $this->getStoreId())): ?> <?php $_items = $this->getItems(); ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/items.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/items.phtml index d67ec6012c27829dd018a0bd040cc22f63bda976..40b50025b94fe513f33ef4d93b7a859276c9eb4d 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/items.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="fieldset-wrapper-title"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/grid.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/grid.phtml index e43faf84a9898974faa82e2f0f73cb796043f82b..a7010061de1460218f772f6eb95141b229309a25 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/grid.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/grid.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/row.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/row.phtml index a4eaf9a360a983a7e7450c606c38c87f18069f3a..e14e843a1564b47599f594898ea27b717da8317c 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/row.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/row.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Sales\Block\Adminhtml\Order\Create\Items\Grid $this */ diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/total.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/total.phtml index 7f959c1e552c5a2f752ac63b2c373048ddc151aa..96339794392a140607696b8020a511e363be118d 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/total.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/total.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Sales\Block\Adminhtml\Order\Create\Items\Grid $this */ diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/unit.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/unit.phtml index 9718766a827fe1e966fc7b89d25e02cf66cac20d..9d04c05f8a34c074b60156d6cc5109a03e64d0fb 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/unit.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/items/price/unit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Sales\Block\Adminhtml\Order\Create\Items\Grid $this */ diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/newsletter/form.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/newsletter/form.phtml index 21c9c9c2996213774c3eca7b2f07f75a3a94caba..5d1982e987dcc59f13c285e76b76f8f2810191f3 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/newsletter/form.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/newsletter/form.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <input type="checkbox" name="newsletter:subscribe"> <label for="newsletter:subscribe" style="width: 90%; float: none;"><?php echo __('Subscribe to Newsletter'); ?></label><br/> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/shipping/method/form.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/shipping/method/form.phtml index 992c336464791093fcb95bb13691827a7dbf6e24..74b952f041732f9d5df7fc647f03d112fa8ad697 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/shipping/method/form.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/shipping/method/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Adminhtml\Order\Create\Shipping\Method\Form */ ?> <?php $_shippingRateGroups = $this->getShippingRates(); ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/sidebar.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/sidebar.phtml index 948c6be8b567117c3e7511f75f91bfe691be2499..088cbd658045be76b7b21168407945a631bebb11 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/sidebar.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/sidebar.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Sales\Block\Adminhtml\Order\Create\Sidebar */ ?> <div class="customer-current-activity-inner"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/sidebar/items.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/sidebar/items.phtml index d81a436ee3fb17eea6dc8df15b25a6b705eb40ae..2da0c29c1ec49bd8e97f1d32d0104cea569a081e 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/sidebar/items.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/sidebar/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\AbstractSidebar */ ?> <div class="create-order-sidebar-block" id="sidebar_data_<?php echo $this->getDataId() ?>"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/store/select.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/store/select.phtml index 91551cac984569c7413b33c36a6007fa4cbc8ed3..a1939afd258b0381ab44d36c76d9f5e0250989a0 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/store/select.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/store/select.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Sales\Block\Adminhtml\Order\Create\Store\Select */ ?> <div class="store-scope form-inline"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals.phtml index ec19a1b48c57fa92a59555b8c13d4bc2c720265d..60b6e11da34a41644a7a44b8d399be61dd33e614 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <legend class="legend"><span><?php echo __('Order Totals') ?></span></legend> <table class="data-table" cellspacing="0"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/default.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/default.phtml index 93e9f0acd3d2615ad12b1af126c4ece07081288b..76dd4eeb66842626c71aa3e1a13ca85c27432fe7 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/default.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <tr class="<?php echo $this->getTotal()->getCode(); ?> row-totals"> <td style="<?php echo $this->getTotal()->getStyle() ?>" class="a-right" colspan="<?php echo $this->getColspan(); ?>"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/grandtotal.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/grandtotal.phtml index 62870a09cfc0e5931e378436ce4874daa7939d5a..bd75b807f45247b6647f499d37b636426ba9a115 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/grandtotal.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/grandtotal.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Tax\Block\Checkout\Grandtotal * @see \Magento\Tax\Block\Checkout\Grandtotal diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/shipping.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/shipping.phtml index f6dd2d460ef0b844a86ba20691bede31967682b4..951a4a388b95f11cf93286f6631bec9f4235a8ee 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/shipping.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/shipping.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Tax\Block\Checkout\Shipping * @see \Magento\Tax\Block\Checkout\Shipping diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/subtotal.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/subtotal.phtml index b329c6917624f50492c26064cc6752816bcc71a6..c3c5e3ed5eef699cf11422ed568333aedd08a607 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/subtotal.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/subtotal.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Sales\Block\Adminhtml\Order\Create\Totals\Subtotal * @see \Magento\Sales\Block\Adminhtml\Order\Create\Totals\Subtotal diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/tax.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/tax.phtml index f9777da229597e5d83795bdc9e9394b9261bbaea..7a5f483c0ec25f35fc3a61b187fe71312462808a 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/tax.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/create/totals/tax.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php global $taxIter; $taxIter++; ?> <?php if ($this->helper('Magento\Tax\Helper\Data')->displayFullSummary()): ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/form.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/form.phtml index 2d76548f8498a668443ec65030a3a8f40e05d09d..ff4bbded0347e4b39672a2db77f9fe36e4e8a370 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/form.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <form id="edit_form" method="post" action="<?php echo $this->getSaveUrl() ?>"> <?php echo $this->getBlockHtml('formkey')?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items.phtml index e3406620992accbea1fc6c55e970c99b21168399..6ce7f6e3ac679c4724becf0ff958b86b067e1533 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_items = $this->getCreditmemo()->getAllItems() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items/renderer/default.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items/renderer/default.phtml index a285db5e369d36ce5e15a1f74ef9cc84ffa7cbc5..3f778b83f086995f3a3c7b671f2a6368e7f0a111 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items/renderer/default.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRenderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/totals/adjustments.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/totals/adjustments.phtml index b2c955838fd0679a327a90c5fb73d86a45ec53c8..61cf98f47fcc79f8706f67712bee99fc589b84b8 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/totals/adjustments.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/create/totals/adjustments.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_source = $this->getSource() ?> <?php if ($_source): ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/form.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/form.phtml index 430201c0cdbacb3636e1abf7ac06aaa9c5594a93..57f80e69f8a59f95f45d3cb3076092708f100d40 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/form.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_order = $this->getCreditmemo()->getOrder() ?> <?php echo $this->getChildHtml('order_info') ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/items.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/items.phtml index 56fc1ae70c183ed1a83e650046c580b6e4ff7b91..967fc53635ce0fc553f0f244da682b4d9b894381 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/items.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_items = $this->getCreditmemo()->getAllItems() ?> <div class="fieldset-wrapper"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/items/renderer/default.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/items/renderer/default.phtml index d29d907d1f2b836aecc13c48178bd95d863bf012..83555ad4117dd063c66f02bcebcd473d09f06e42 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/items/renderer/default.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/creditmemo/view/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRenderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/details.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/details.phtml index 02cba53a043cf43afdf8cfe6e0b8c329b34e5d84..add08518ea7722c11c5fb361913d21d9377556f3 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/details.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/details.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* store view name = $_order->getStore()->getName() web site name = $_order->getStore()->getWebsite()->getName() diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/giftoptions.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/giftoptions.phtml index c114d5ea2338f4b9b4e1a81fcb98dc947e291915..74245e781e2485dad628ea890f6f93ec62d1c909 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/giftoptions.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/giftoptions.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getChildHtml()): ?> <div class="fieldset-wrapper order-gift-options clearfix"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/form.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/form.phtml index 55b63b8e9d98300c7978cc006216bb9959e6bab2..a5a24c7ca6cf3b0884d038f73c0bcdf0aa5e7cc5 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/form.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <form id="edit_form" method="post" action="<?php echo $this->getSaveUrl() ?>"> <?php echo $this->getBlockHtml('formkey')?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/items.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/items.phtml index 677a1f5c78e425392f4dd2e555d15e9f9f20c239..ea8cca9f3ee42551e311f3f261bec9f90ae42236 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/items.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="fieldset-wrapper"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/items/renderer/default.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/items/renderer/default.phtml index a04f1e717f45ba760233dc7505d92d07f12bbfe5..44ad6f88e4e15c8e6308c0764f18fd28847737df 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/items/renderer/default.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRenderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/form.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/form.phtml index 0273514e8f4b5aebfe03f8a150d0adf9797df644..bed963601c833effc4beed0b091ae279f645fd37 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/form.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_invoice = $this->getInvoice() ?> <?php $_order = $_invoice->getOrder() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/items.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/items.phtml index de508d3645d4e3a830971a73732878051eedac8e..f0649065e7ff65c73216ed25e4f15e5af7a6d4de 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/items.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="grid"> <table cellspacing="0" class="data order-tables"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/items/renderer/default.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/items/renderer/default.phtml index 5c78e0b33e58ecba64d34dd79e7e34033cf66023..6bee257e4d551951e4839001d374b19508e26751 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/items/renderer/default.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/invoice/view/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRenderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/totalbar.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/totalbar.phtml index 41226bc7a5608748c48b407ae16830eed057b407..3ea8064fd4835c281e01c683327a8abcd81023a5 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/totalbar.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/totalbar.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (sizeof($this->getTotals()) > 0): ?> <table cellspacing="0" class="items-to-invoice"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/totals.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/totals.phtml index e0fad63857514df11275862b3254f600fcfa5167..ac7182795609a6bd31cb6862b7d00fab4ea85658 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/totals.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/totals.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /*$_source = $this->getSource(); ?> <?php $this->setPriceDataObject($_source) ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/discount.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/discount.phtml index 23e6ce604afb9cb5928f0d0a798acf452e33e4bd..c4ab4aa4746e4f0af1a4f7310406a809fbea2397 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/discount.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/discount.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_source = $this->getSource() ?> <?php $_order = $this->getOrder() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/due.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/due.phtml index 9b5a208a66c9741d125f7c05978824d9b09ebd36..f6cd709024606803300a0ef4b6337742577e1f76 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/due.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/due.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getCanDisplayTotalDue()): ?> <tr> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/grand.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/grand.phtml index ca1a20df8831d8d3325f7514d7d051043bb7e000..6eaf0785fb29bacc0efddb0e4cca15431f6f7557 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/grand.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/grand.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_source = $this->getSource() ?> <?php $this->setPriceDataObject($_source) ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/item.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/item.phtml index 0b1ee30ebe37b7b919a6d69e8a3478fc7a4c5eb1..fb5363b2e4ee05e98495e2269aae6599980e7e76 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/item.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/item.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_source = $this->getSource() ?> <?php $this->setPriceDataObject($_source) ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/paid.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/paid.phtml index 29d7bab5759b95ed6ab4b375b195599a7e512463..bfa6bb1e6c8cae277ec475b32c114077416885a5 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/paid.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/paid.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getCanDisplayTotalPaid()): ?> <tr> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/refunded.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/refunded.phtml index 3f24da57b05d4f84cae991f08ae23c9e9990e26e..3f95c981f60881f2192feb7e3b9e6359403dad2c 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/refunded.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/refunded.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getCanDisplayTotalRefunded()): ?> <tr> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/shipping.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/shipping.phtml index 3f7b10e905a9a741803d7cd6c5cde49a17208c80..06cd186baa17794564893cf320b3938a41c76c31 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/shipping.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/shipping.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_source = $this->getSource() ?> <?php $this->setPriceDataObject($_source) ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/tax.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/tax.phtml index 2607277dc3be8e741cfdc6a7da7ff2c83a1cde9b..c7bb38ddcb4029a05cc2c1a9e004755b406e633c 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/totals/tax.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/totals/tax.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Sales\Block\Adminhtml\Order\Totals\Tax */ ?> <?php diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/view/giftmessage.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/view/giftmessage.phtml index e9c3f2186dd6d09a6054b519fee1afc9b4f61bd0..0b19be4ac4dfcd0cd6f89c2c559c67986e925914 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/view/giftmessage.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/view/giftmessage.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->canDisplayGiftmessage()): ?> <?php $_required = $this->getMessage()->getMessage() != ''?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/view/history.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/view/history.phtml index f725af66fdb588ac5f3ef049b81e8b93794c091a..bc0ca07df458a3bda3a54dbd571322adf2095f51 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/view/history.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/view/history.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div id="order_history_block"> <?php if ($this->canAddComment()):?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/view/info.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/view/info.phtml index 919d90c65c2adec3943a216c12929f7a9818506a..de2a3fe86d7261ec4562dafd7b7d281b25c0ff75 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/view/info.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/view/info.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Adminhtml\Order\View\Info */ ?> <?php $_order = $this->getOrder() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/view/items.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/view/items.phtml index c483b77824ed628b7e216501a1d23553ed6ee652..ec03b899edf0087d5388415dd23664b0f32135f2 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/view/items.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/view/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_order = $this->getOrder() ?> <div class="grid"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/view/items/renderer/default.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/view/items/renderer/default.phtml index d760c722c741b5e351dafb400374031bccd3accf..290ccba64a12204bbb87ec317a8d439c13738738 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/view/items/renderer/default.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/view/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Adminhtml\Order\View\Items\Renderer\DefaultRenderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/view/tab/history.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/view/tab/history.phtml index 4ab2cc74c6a99d3031af98e655684e84aefb5616..587d80e27d68f9b3681194c1455238b55bc3a28b 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/view/tab/history.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/view/tab/history.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="fieldset-wrapper"> <ul class="note-list"> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/order/view/tab/info.phtml b/app/code/Magento/Sales/view/adminhtml/templates/order/view/tab/info.phtml index 26431f848ca4e1d50671a523c003f0350544cc1f..772dd3dd12c07ee76f5531998ecbd0239c3d848a 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/order/view/tab/info.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/order/view/tab/info.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Adminhtml\Order\View\Tab\Info */ ?> <?php $_order = $this->getOrder() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/page/js/components.phtml b/app/code/Magento/Sales/view/adminhtml/templates/page/js/components.phtml index 3fbf38c208e782479ef692a4de6647ae58b51a1a..e4b6ea73bdcc3d4800ff7c43155f3aba3bcc30b8 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/page/js/components.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/page/js/components.phtml @@ -5,5 +5,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/rss/order/grid/link.phtml b/app/code/Magento/Sales/view/adminhtml/templates/rss/order/grid/link.phtml index a33965d1e047c9d74b5f6074177965c643a95432..54f7be34d7c7043d557e34fa58504670d3ed8fe1 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/rss/order/grid/link.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/rss/order/grid/link.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Sales\Block\Adminhtml\Rss\Order\Grid\Link */ ?> <?php if ($this->isRssAllowed() && $this->getLink()): ?> diff --git a/app/code/Magento/Sales/view/adminhtml/templates/transactions/detail.phtml b/app/code/Magento/Sales/view/adminhtml/templates/transactions/detail.phtml index 15c09aa0713e5b4bc96fad9843415728b2aad0c2..7d3564c822b40227d1ddf4481f582d492b218b02 100644 --- a/app/code/Magento/Sales/view/adminhtml/templates/transactions/detail.phtml +++ b/app/code/Magento/Sales/view/adminhtml/templates/transactions/detail.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="page-actions"><?php echo $this->getButtonsHtml() ?></div> <div class="fieldset-wrapper"> diff --git a/app/code/Magento/Sales/view/frontend/templates/email/creditmemo/items.phtml b/app/code/Magento/Sales/view/frontend/templates/email/creditmemo/items.phtml index 71c907fdb4f0eb668255d48e35e5a27433a08cae..f748fbf43af4bab2be37df2b177c3fb4f3dfa31e 100644 --- a/app/code/Magento/Sales/view/frontend/templates/email/creditmemo/items.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/email/creditmemo/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_creditmemo = $this->getCreditmemo() ?> <?php $_order = $this->getOrder() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/email/invoice/items.phtml b/app/code/Magento/Sales/view/frontend/templates/email/invoice/items.phtml index 29ba88018f614d90a23aaeec5e390417a2de42d1..68838929ac6858decac6756b3fd8ce5a6122dd08 100644 --- a/app/code/Magento/Sales/view/frontend/templates/email/invoice/items.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/email/invoice/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_invoice = $this->getInvoice() ?> <?php $_order = $this->getOrder() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/email/items.phtml b/app/code/Magento/Sales/view/frontend/templates/email/items.phtml index 3185abac3d7f7b7f02625f5afff33aebd94ae6d1..5b97b7c93db76a8f4b4c9cf7252216e1877a63f4 100644 --- a/app/code/Magento/Sales/view/frontend/templates/email/items.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/email/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_order = $this->getOrder() ?> <?php if ($_order): ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/email/items/creditmemo/default.phtml b/app/code/Magento/Sales/view/frontend/templates/email/items/creditmemo/default.phtml index 48c4467de8af92ad88eb8fdc8bbd88f906bfa4f7..7d7ded1758e67ada1a9d934cdfa52a63d3ee1939 100644 --- a/app/code/Magento/Sales/view/frontend/templates/email/items/creditmemo/default.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/email/items/creditmemo/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_item = $this->getItem() ?> <?php $_order = $this->getItem()->getOrder(); ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/email/items/invoice/default.phtml b/app/code/Magento/Sales/view/frontend/templates/email/items/invoice/default.phtml index 48c4467de8af92ad88eb8fdc8bbd88f906bfa4f7..7d7ded1758e67ada1a9d934cdfa52a63d3ee1939 100644 --- a/app/code/Magento/Sales/view/frontend/templates/email/items/invoice/default.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/email/items/invoice/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_item = $this->getItem() ?> <?php $_order = $this->getItem()->getOrder(); ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/email/items/order/default.phtml b/app/code/Magento/Sales/view/frontend/templates/email/items/order/default.phtml index 15a6a7e4fc30ea5124c63782e5181b4e84578136..fa77988ed811a5edf361954368efcaab186f72f6 100644 --- a/app/code/Magento/Sales/view/frontend/templates/email/items/order/default.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/email/items/order/default.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Sales\Block\Order\Email\Items\DefaultItems */ /** @var $_item \Magento\Sales\Model\Order\Item */ diff --git a/app/code/Magento/Sales/view/frontend/templates/email/items/price/row.phtml b/app/code/Magento/Sales/view/frontend/templates/email/items/price/row.phtml index f37a65f9b010f819bcd0926b20c100dd342ca83a..bce28e7b09628960857c45fdc75ab11d1c2dc9d1 100644 --- a/app/code/Magento/Sales/view/frontend/templates/email/items/price/row.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/email/items/price/row.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Sales\Block\Order\Email\Items\DefaultItems $this */ diff --git a/app/code/Magento/Sales/view/frontend/templates/email/items/shipment/default.phtml b/app/code/Magento/Sales/view/frontend/templates/email/items/shipment/default.phtml index d0d06ef52ddbf7505ed6441b7b288c22122e57f7..dee8a9db7af960810dc990018b9f8a5fa99800d3 100644 --- a/app/code/Magento/Sales/view/frontend/templates/email/items/shipment/default.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/email/items/shipment/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_item = $this->getItem() ?> <tr> diff --git a/app/code/Magento/Sales/view/frontend/templates/email/shipment/items.phtml b/app/code/Magento/Sales/view/frontend/templates/email/shipment/items.phtml index 68bb5574608ace1dd0f877e5b2196b031b0576fc..001c7be145b27c0a22665360c39db67a3cece75f 100644 --- a/app/code/Magento/Sales/view/frontend/templates/email/shipment/items.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/email/shipment/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_shipment = $this->getShipment() ?> <?php $_order = $this->getOrder() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/email/shipment/track.phtml b/app/code/Magento/Sales/view/frontend/templates/email/shipment/track.phtml index 2be9fbea5bf229d338104b1119c95b6dd28eb103..103fdae42f1d85b08367fed6e8bd5aa8808b2df0 100644 --- a/app/code/Magento/Sales/view/frontend/templates/email/shipment/track.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/email/shipment/track.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_shipment = $this->getShipment() ?> <?php $_order = $this->getOrder() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/guest/form.phtml b/app/code/Magento/Sales/view/frontend/templates/guest/form.phtml index 675ac4831c2ef4d4ffbd698c6113ef605c005c45..14091e50f3cf9c5aab7b36c38debf491bcd2929d 100644 --- a/app/code/Magento/Sales/view/frontend/templates/guest/form.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/guest/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <form class="form form-orders-search" id="oar-widget-orders-and-returns-form" data-mage-init='{"ordersReturns":{}, "validation":{}}' action="<?php echo $this->getActionUrl() ?>" method="post" name="guest_post"> diff --git a/app/code/Magento/Sales/view/frontend/templates/items/price/row.phtml b/app/code/Magento/Sales/view/frontend/templates/items/price/row.phtml index 041b5a3c0334f233a4382520a916e6504a861461..762b8d6b9969304db106a224ad16ea16c083332f 100644 --- a/app/code/Magento/Sales/view/frontend/templates/items/price/row.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/items/price/row.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer $this */ $_item = $this->getItem(); ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/items/price/total_after_discount.phtml b/app/code/Magento/Sales/view/frontend/templates/items/price/total_after_discount.phtml index 7f9cec2d8f631b119372696f35a5cfe2a5a05546..c7fbd22a5f3ed2d092aa93b4b244e4e1f1beacfc 100644 --- a/app/code/Magento/Sales/view/frontend/templates/items/price/total_after_discount.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/items/price/total_after_discount.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer $this */ $_item = $this->getItem(); ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/items/price/unit.phtml b/app/code/Magento/Sales/view/frontend/templates/items/price/unit.phtml index 99701092acdaad98637a9365c3c57625aed045d9..ee146a735b6a9fcb92e0d055426ebd56e9d2d2ff 100644 --- a/app/code/Magento/Sales/view/frontend/templates/items/price/unit.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/items/price/unit.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer $this */ $_item = $this->getItem(); ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/js/components.phtml b/app/code/Magento/Sales/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Sales/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/comments.phtml b/app/code/Magento/Sales/view/frontend/templates/order/comments.phtml index 695f58ea3296fb34e8361625685be79aebd6a67c..a723d4461f8802081d6022e8b83d15919b57ea8a 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/comments.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/comments.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items.phtml b/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items.phtml index e59592bb6f248b9be94b49e9374ed5126571c958..2e994281949fbc424af37ab245ce6f6afeabd822 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_order = $this->getOrder() ?> <div class="actions-toolbar"> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items/renderer/default.phtml b/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items/renderer/default.phtml index 648b8d37fbc42fef092f0c0b61c90f4198d266a2..9885826af7b8c6065f69e79ed612c011f92e6b9f 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items/renderer/default.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/history.phtml b/app/code/Magento/Sales/view/frontend/templates/order/history.phtml index d083ecae975d38a7c8a887fbd00dea7f825a987c..8f5779f5a9564049d2f4edac05826e1e4706bc99 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/history.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/history.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_orders = $this->getOrders(); ?> <?php echo $this->getChildHtml('info');?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/info.phtml b/app/code/Magento/Sales/view/frontend/templates/order/info.phtml index 6f50c0e8460bf7896a1ac4ff2477522f28e08c89..690059cdadaa400f618fa3d14b8e3975b2b50ee6 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/info.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/info.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Order\Info */ ?> <?php $_order = $this->getOrder() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/info/buttons.phtml b/app/code/Magento/Sales/view/frontend/templates/order/info/buttons.phtml index 5f5b979cb8510b6d26f8b99057d84d476a546926..3982f1cbc1f229c03c0635f9cdbe8b1a652d4a6d 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/info/buttons.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/info/buttons.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="actions"> <?php $_order = $this->getOrder() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/info/buttons/rss.phtml b/app/code/Magento/Sales/view/frontend/templates/order/info/buttons/rss.phtml index 86ebea3eb090d5d8c6da35a4d081806f910070e4..ffd3b3349fd74484c79518f5f32e94cbb80d49d8 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/info/buttons/rss.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/info/buttons/rss.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Sales\Block\Order\Info\Buttons\Rss */ ?> <?php if ($this->isRssAllowed() && $this->getLink()): ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/invoice/items.phtml b/app/code/Magento/Sales/view/frontend/templates/order/invoice/items.phtml index 8c96be003c79673352c372fff2bd1a5eae292864..9c162c88b0a4181a5605676b05993619ceaf43f1 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/invoice/items.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/invoice/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_order = $this->getOrder() ?> <div class="actions-toolbar"> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/invoice/items/renderer/default.phtml b/app/code/Magento/Sales/view/frontend/templates/order/invoice/items/renderer/default.phtml index fd7adfdcbd6b260564415fadde58cf37d9824b08..6c27411e5952d90a1103fa951b13cb8dc75f4865 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/invoice/items/renderer/default.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/invoice/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/items.phtml b/app/code/Magento/Sales/view/frontend/templates/order/items.phtml index cd2e054a2b14001ae5b4a17505176c01e0af220c..26e5fa568b47acc520eeeb3ba5f5798315f6867d 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/items.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_order = $this->getOrder() ?> <?php $_giftMessage; ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/items/renderer/default.phtml b/app/code/Magento/Sales/view/frontend/templates/order/items/renderer/default.phtml index 967074190e39e655011f41ba0a1110c76779c270..abc4a8c4643536293adb74a98e302574303d0b4b 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/items/renderer/default.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/items/renderer/default.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer */ $_item = $this->getItem(); ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/order_comments.phtml b/app/code/Magento/Sales/view/frontend/templates/order/order_comments.phtml index 25636dfa40b75b7b01d3c898282389c08181a743..3d073e282cd3f6e97326f12dc76c3443c79a912d 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/order_comments.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/order_comments.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Order\View*/?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/order_date.phtml b/app/code/Magento/Sales/view/frontend/templates/order/order_date.phtml index d1c771e2fe4d48b0264c39e8e91759dcac36f767..bc6c07248eea1625ce51a3ae17f94455bc0ad424 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/order_date.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/order_date.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="order-date"><?php echo __('<span class="label">Order Date:</span> %1', '<date>' . $this->formatDate($this->getOrder()->getCreatedAtStoreDate(), 'long') . '</date>') ?></div> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/print/creditmemo.phtml b/app/code/Magento/Sales/view/frontend/templates/order/print/creditmemo.phtml index 9b10b00f88e92f0a8035cf9e30aff9caedc9ba6a..fc3339d4d33c1bfe6f9a0dcf2a634ca9d410e5f0 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/print/creditmemo.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/print/creditmemo.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_order = $this->getOrder() ?> <?php $_creditmemo = $this->getCreditmemo() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/print/invoice.phtml b/app/code/Magento/Sales/view/frontend/templates/order/print/invoice.phtml index 5ecfdeb8134b199a65f670872a718adfdb21aaa5..15fa73c75632d3309d3c18c64d140e9f55fc24fa 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/print/invoice.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/print/invoice.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_order = $this->getOrder() ?> <?php $_invoice = $this->getInvoice() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/print/shipment.phtml b/app/code/Magento/Sales/view/frontend/templates/order/print/shipment.phtml index a3e0665bdec5b3441836e716b8e90355ae426dcf..d71391f9bf667070b41338d60a69daf3be1ff86b 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/print/shipment.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/print/shipment.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /* @var $this \Magento\Sales\Block\Order\PrintOrder\Shipment */ ?> <?php $order = $this->getOrder(); ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/recent.phtml b/app/code/Magento/Sales/view/frontend/templates/order/recent.phtml index 307739e8df4a1bcccf648c9d283a913898c50cb2..70c3fbbe87f30d6fad3c38cdd33c807595f823d8 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/recent.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/recent.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="block block-dashboard-orders"> <?php $_orders = $this->getOrders(); ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/shipment/items/renderer/default.phtml b/app/code/Magento/Sales/view/frontend/templates/order/shipment/items/renderer/default.phtml index 8986722b1d07f1d1819d29a30ec4da84a7a1c245..030d677fcbbca71455293579d1e713dd5fca17a8 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/shipment/items/renderer/default.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/shipment/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_item = $this->getItem() ?> <?php $_order = $this->getItem()->getOrderItem()->getOrder() ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/totals.phtml b/app/code/Magento/Sales/view/frontend/templates/order/totals.phtml index abfdec91d22be6ef0e05579fabb715be0b86d6ba..49f7e75aac44fb516f0f9becdb7c9c8582a970be 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/totals.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/totals.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Sales\Block\Order\Totals * @see \Magento\Sales\Block\Order\Totals diff --git a/app/code/Magento/Sales/view/frontend/templates/order/view.phtml b/app/code/Magento/Sales/view/frontend/templates/order/view.phtml index d3b1167912640bb534c7e12889ae00cb00f89d72..43779c2cbf3c03aac42d192870e4e6e061966dd6 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/view.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/view.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Sales\Block\Order\View*/?> <div class="order-details-items ordered"> diff --git a/app/code/Magento/Sales/view/frontend/templates/reorder/sidebar.phtml b/app/code/Magento/Sales/view/frontend/templates/reorder/sidebar.phtml index ab4b05ed78cfe2584405830125261dc6e78ce25f..d04daf4e5587cfe4d2baf2f75dd7807a3b128e3b 100644 --- a/app/code/Magento/Sales/view/frontend/templates/reorder/sidebar.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/reorder/sidebar.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Sales/view/frontend/templates/widget/guest/form.phtml b/app/code/Magento/Sales/view/frontend/templates/widget/guest/form.phtml index cee5441daba93c70c5d2f90dec2a5f5c77ae3ca8..7cf9e95c0f0f8d389cbe1a8aad94f29b450f8747 100644 --- a/app/code/Magento/Sales/view/frontend/templates/widget/guest/form.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/widget/guest/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\Sales\Block\Widget\Guest\Form */ ?> <?php if ($this->isEnable()): ?> diff --git a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Actions.php b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Actions.php index 075a54de7abc57cf32876799bc085b9c2a4bf6e5..97198aaac6a31459addbcd192954793eb3a477d2 100644 --- a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Actions.php +++ b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Actions.php @@ -85,6 +85,7 @@ class Actions extends \Magento\Backend\Block\Widget\Form\Generic implements * Prepare form before rendering HTML * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Form.php b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Form.php index 37b04892acd00f5d9ac5f58fc692c69c9c030de8..c2e17d7add90b1e6a26d10abf5c9d865357e4db1 100644 --- a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Form.php +++ b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Form.php @@ -41,6 +41,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * Prepare coupon codes generation parameters form * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Grid.php b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Grid.php index 7dece310192cbf057ed2cd1975d16ea3109b761e..8e726aef97be44ed6334bab0d5fa8376f9276f9b 100644 --- a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Grid.php +++ b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Grid.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\SalesRule\Block\Adminhtml\Promo\Quote\Edit\Tab\Coupons; /** diff --git a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Main.php b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Main.php index 9ac3264d6f07a7aa1260dcaef50c46609d2a43ae..3a786b66aef8838113d36e8aa5df14a6070d222a 100644 --- a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Main.php +++ b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Main.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\SalesRule\Block\Adminhtml\Promo\Quote\Edit\Tab; use Magento\Backend\Block\Template\Context; @@ -116,6 +119,8 @@ class Main extends Generic implements TabInterface * Prepare form before rendering HTML * * @return $this + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Edit.php b/app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Edit.php index f408f5ced5dcb977460a8ede22acbfe0c3c0ab27..6138a59b95ac241b6df44e33edd90fba92fcc369 100644 --- a/app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Edit.php +++ b/app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Edit.php @@ -12,6 +12,7 @@ class Edit extends \Magento\SalesRule\Controller\Adminhtml\Promo\Quote * Promo quote edit action * * @return void + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Save.php b/app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Save.php index 256bd7cdcdc678615e04b237847cfb9aa31775ab..c9547549fa1baf262436af28201d3fc97d12a079 100644 --- a/app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Save.php +++ b/app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Save.php @@ -12,6 +12,8 @@ class Save extends \Magento\SalesRule\Controller\Adminhtml\Promo\Quote * Promo quote save action * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/SalesRule/Helper/Coupon.php b/app/code/Magento/SalesRule/Helper/Coupon.php index a445973a998939d1c9880b2a1bd0b0fd0f719611..2b3282ae12e647e3cc765233625359ac83710cbd 100644 --- a/app/code/Magento/SalesRule/Helper/Coupon.php +++ b/app/code/Magento/SalesRule/Helper/Coupon.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\SalesRule\Helper; /** diff --git a/app/code/Magento/SalesRule/Model/Observer.php b/app/code/Magento/SalesRule/Model/Observer.php index 881016526c6c3fdbaa4a82b53b782cfdf145b681..a31d559ee54756197e8b6c1137069ad14f17c0ca 100644 --- a/app/code/Magento/SalesRule/Model/Observer.php +++ b/app/code/Magento/SalesRule/Model/Observer.php @@ -7,6 +7,9 @@ namespace Magento\SalesRule\Model; use Magento\Framework\Event\Observer as EventObserver; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Observer { /** @@ -90,6 +93,7 @@ class Observer /** * @param EventObserver $observer * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function salesOrderAfterPlace($observer) { diff --git a/app/code/Magento/SalesRule/Model/Quote/Discount.php b/app/code/Magento/SalesRule/Model/Quote/Discount.php index 7d99533a1d4d3d8af7f2ed34dca41cfe51b37d25..d108bb891e6ec7e6f4a684f55b6443a702a8c925 100644 --- a/app/code/Magento/SalesRule/Model/Quote/Discount.php +++ b/app/code/Magento/SalesRule/Model/Quote/Discount.php @@ -59,6 +59,7 @@ class Discount extends \Magento\Quote\Model\Quote\Address\Total\AbstractTotal * * @param Address $address * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function collect(Address $address) { diff --git a/app/code/Magento/SalesRule/Model/Resource/Report/Rule/Createdat.php b/app/code/Magento/SalesRule/Model/Resource/Report/Rule/Createdat.php index 32eafd1b1424b37b3b08ea875c26633262b61757..8f87fc3feb640e41759c71091bc638bf37575cc8 100644 --- a/app/code/Magento/SalesRule/Model/Resource/Report/Rule/Createdat.php +++ b/app/code/Magento/SalesRule/Model/Resource/Report/Rule/Createdat.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\SalesRule\Model\Resource\Report\Rule; /** @@ -42,6 +45,7 @@ class Createdat extends \Magento\Reports\Model\Resource\Report\AbstractReport * @param mixed $from * @param mixed $to * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _aggregateByOrder($aggregationField, $from, $to) { diff --git a/app/code/Magento/SalesRule/Model/Resource/Rule/Collection.php b/app/code/Magento/SalesRule/Model/Resource/Rule/Collection.php index 3ca4e0d272faf9c0e6ac612f0be8f12b604c89a9..a3d49f61e3946222e717d347706e1df4610c9a3b 100644 --- a/app/code/Magento/SalesRule/Model/Resource/Rule/Collection.php +++ b/app/code/Magento/SalesRule/Model/Resource/Rule/Collection.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\SalesRule\Model\Resource\Rule; /** diff --git a/app/code/Magento/SalesRule/Model/Rule.php b/app/code/Magento/SalesRule/Model/Rule.php index 713d65305f405b75f623eca36ba717455d68581a..66dd6c7f054fcfadfab0166b17bf026c89052994 100644 --- a/app/code/Magento/SalesRule/Model/Rule.php +++ b/app/code/Magento/SalesRule/Model/Rule.php @@ -63,6 +63,7 @@ use Magento\Quote\Model\Quote\Address; * @method \Magento\SalesRule\Model\Rule setCouponCode(string $value) * @method int getRuleId() * @method \Magento\SalesRule\Model\Rule setRuleId(int $ruleId) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Rule extends \Magento\Rule\Model\AbstractModel { @@ -185,6 +186,7 @@ class Rule extends \Magento\Rule\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -436,6 +438,8 @@ class Rule extends \Magento\Rule\Model\AbstractModel * @param int $saveAttemptCount Number of attempts to save newly created coupon * @return \Magento\SalesRule\Model\Coupon|null * @throws \Exception|\Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function acquireCoupon($saveNewlyCreated = true, $saveAttemptCount = 10) { @@ -525,6 +529,7 @@ class Rule extends \Magento\Rule\Model\AbstractModel * * @param Address $address * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsValidForAddress($address) { diff --git a/app/code/Magento/SalesRule/Model/Rule/Condition/Product/Found.php b/app/code/Magento/SalesRule/Model/Rule/Condition/Product/Found.php index 11092ec2fd22283c2e07fc15a34d61e8c95a848d..8255735b36cdbb45f5a7b6c4d1fb3dcdbc68fce7 100644 --- a/app/code/Magento/SalesRule/Model/Rule/Condition/Product/Found.php +++ b/app/code/Magento/SalesRule/Model/Rule/Condition/Product/Found.php @@ -55,6 +55,7 @@ class Found extends \Magento\SalesRule\Model\Rule\Condition\Product\Combine * * @param \Magento\Framework\Model\AbstractModel $model * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function validate(\Magento\Framework\Model\AbstractModel $model) { diff --git a/app/code/Magento/SalesRule/Model/RulesApplier.php b/app/code/Magento/SalesRule/Model/RulesApplier.php index 1d814f2042045efa20b3cae79e882c96f9c64eff..20b8c40142e50f2234bd0e2f6b203ea178118565 100644 --- a/app/code/Magento/SalesRule/Model/RulesApplier.php +++ b/app/code/Magento/SalesRule/Model/RulesApplier.php @@ -48,6 +48,7 @@ class RulesApplier * @param bool $skipValidation * @param mixed $couponCode * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function applyRules($item, $rules, $skipValidation, $couponCode) { diff --git a/app/code/Magento/SalesRule/Model/Utility.php b/app/code/Magento/SalesRule/Model/Utility.php index e5fe1cd50e3905014bc6199e34ae0e4fcd822c12..3b170bc61e7e4a3441a68bb869dad84aa7582384 100644 --- a/app/code/Magento/SalesRule/Model/Utility.php +++ b/app/code/Magento/SalesRule/Model/Utility.php @@ -77,6 +77,8 @@ class Utility * @param \Magento\SalesRule\Model\Rule $rule * @param \Magento\Quote\Model\Quote\Address $address * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function canProcessRule($rule, $address) { @@ -180,6 +182,7 @@ class Utility * @param \Magento\SalesRule\Model\Rule\Action\Discount\Data $discountData * @param \Magento\Quote\Model\Quote\Item\AbstractItem $item * @return $this + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function deltaRoundingFix( \Magento\SalesRule\Model\Rule\Action\Discount\Data $discountData, diff --git a/app/code/Magento/SalesRule/Model/Validator.php b/app/code/Magento/SalesRule/Model/Validator.php index 4d6d2ef3942ad1aea60f12ae016f76a2bcb17c8d..a9b4ab5899628f49d1bab617a8178794bbf157ca 100644 --- a/app/code/Magento/SalesRule/Model/Validator.php +++ b/app/code/Magento/SalesRule/Model/Validator.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\SalesRule\Model; use Magento\Quote\Model\Quote\Address; @@ -19,6 +22,7 @@ use Magento\Quote\Model\Quote\Item\AbstractItem; * @method Validator setWebsiteId($id) * @method mixed getCustomerGroupId() * @method Validator setCustomerGroupId($id) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Validator extends \Magento\Framework\Model\AbstractModel { @@ -101,6 +105,7 @@ class Validator extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -246,6 +251,7 @@ class Validator extends \Magento\Framework\Model\AbstractModel * * @param Address $address * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function processShippingAmount(Address $address) { diff --git a/app/code/Magento/Search/Block/Adminhtml/Dashboard/Last.php b/app/code/Magento/Search/Block/Adminhtml/Dashboard/Last.php index bb6565132e775bc050bf93a37fb5164dd30c6046..b0fbd373efa7fa5403dde0299ce837582ae647c1 100644 --- a/app/code/Magento/Search/Block/Adminhtml/Dashboard/Last.php +++ b/app/code/Magento/Search/Block/Adminhtml/Dashboard/Last.php @@ -7,6 +7,7 @@ namespace Magento\Search\Block\Adminhtml\Dashboard; /** * Dashboard last search keywords block + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Last extends \Magento\Backend\Block\Dashboard\Grid { diff --git a/app/code/Magento/Search/Block/Adminhtml/Dashboard/Top.php b/app/code/Magento/Search/Block/Adminhtml/Dashboard/Top.php index c54e05fbe0e6731979b34df88c4f3bd3ce8de5c5..e08ec6515edb1b598bd1a7d054aae66ab2b4af32 100644 --- a/app/code/Magento/Search/Block/Adminhtml/Dashboard/Top.php +++ b/app/code/Magento/Search/Block/Adminhtml/Dashboard/Top.php @@ -7,6 +7,7 @@ namespace Magento\Search\Block\Adminhtml\Dashboard; /** * Dashboard last search keywords block + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Top extends \Magento\Backend\Block\Dashboard\Grid { diff --git a/app/code/Magento/Search/Block/Adminhtml/Term/Edit/Form.php b/app/code/Magento/Search/Block/Adminhtml/Term/Edit/Form.php index 6b4cee2a663f5e949fd40c1bb78611749b9f854c..a7b63d6f28acb2a7027bf01e12a021a7189cad61 100644 --- a/app/code/Magento/Search/Block/Adminhtml/Term/Edit/Form.php +++ b/app/code/Magento/Search/Block/Adminhtml/Term/Edit/Form.php @@ -51,6 +51,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * Prepare form fields * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Search/Controller/Adminhtml/Term/Edit.php b/app/code/Magento/Search/Controller/Adminhtml/Term/Edit.php index ef21b7293e33ceccfd0b19749fe25fff1b6403e1..8f650796bf1973909679e931713355054012e558 100644 --- a/app/code/Magento/Search/Controller/Adminhtml/Term/Edit.php +++ b/app/code/Magento/Search/Controller/Adminhtml/Term/Edit.php @@ -33,6 +33,7 @@ class Edit extends \Magento\Search\Controller\Adminhtml\Term /** * @return \Magento\Backend\Model\View\Result\Page + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Search/Controller/Adminhtml/Term/Save.php b/app/code/Magento/Search/Controller/Adminhtml/Term/Save.php index a186dfba7c169c5cd60e515bc527f18acec2622c..e40b00253d4b1e5dc4fa3e1ad7286dfdc4ef25b5 100644 --- a/app/code/Magento/Search/Controller/Adminhtml/Term/Save.php +++ b/app/code/Magento/Search/Controller/Adminhtml/Term/Save.php @@ -31,6 +31,7 @@ class Save extends \Magento\Search\Controller\Adminhtml\Term * Save search query * * @return \Magento\Backend\Model\View\Result\Redirect + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Search/Helper/Data.php b/app/code/Magento/Search/Helper/Data.php index e4b0202e1a79c75eec8e1b27679ff4165193d3b0..603f9317fe2b39d7b4776bbd63a84ef471b9f908 100644 --- a/app/code/Magento/Search/Helper/Data.php +++ b/app/code/Magento/Search/Helper/Data.php @@ -251,6 +251,7 @@ class Data extends AbstractHelper * * @param mixed $store * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function checkNotes($store = null) { diff --git a/app/code/Magento/Search/Model/Query.php b/app/code/Magento/Search/Model/Query.php index 9a0bfd70914431f9f61833b95fd8d0a038667e21..917abf841a7da2b22d9cf1096863efbff0f86fac 100644 --- a/app/code/Magento/Search/Model/Query.php +++ b/app/code/Magento/Search/Model/Query.php @@ -40,6 +40,7 @@ use Magento\Store\Model\StoreManagerInterface; * @method string getUpdatedAt() * @method \Magento\Search\Model\Query setUpdatedAt(string $value) * @method \Magento\Search\Model\Query setIsQueryTextExceeded(bool $value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Query extends AbstractModel implements QueryInterface { diff --git a/app/code/Magento/Search/Model/Resource/Helper.php b/app/code/Magento/Search/Model/Resource/Helper.php index 8ccf11e186a9d2b869a796655b2b3407576068b8..3a9ddcf7bb682b3df296196d947db83a9594dc01 100644 --- a/app/code/Magento/Search/Model/Resource/Helper.php +++ b/app/code/Magento/Search/Model/Resource/Helper.php @@ -25,6 +25,7 @@ class Helper extends \Magento\Framework\DB\Helper * @param string $str The source string * @param int $maxWordLength * @return array (0 => words, 1 => terms) + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function prepareTerms($str, $maxWordLength = 0) { diff --git a/app/code/Magento/Search/Model/Resource/Query.php b/app/code/Magento/Search/Model/Resource/Query.php index 855d5fa38faf8f51f10271296b49af732288ecde..b2af20520e73f86ea32cf07792512be48b14ecbd 100644 --- a/app/code/Magento/Search/Model/Resource/Query.php +++ b/app/code/Magento/Search/Model/Resource/Query.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Search\Model\Resource; use Magento\Framework\DB\Select; diff --git a/app/code/Magento/Search/view/frontend/templates/search_data.phtml b/app/code/Magento/Search/view/frontend/templates/search_data.phtml index 2c65a6a8fb8dd1a2edb147e833f372a9ffd67e19..f03536c1aa4e318e13724427c5372c238f5daf0e 100644 --- a/app/code/Magento/Search/view/frontend/templates/search_data.phtml +++ b/app/code/Magento/Search/view/frontend/templates/search_data.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Search/view/frontend/templates/term.phtml b/app/code/Magento/Search/view/frontend/templates/term.phtml index d15c1bddfe103f1898ea159ce96ca642a7db3f8b..c7c2d888159ae68dc3377646952e39542365f583 100644 --- a/app/code/Magento/Search/view/frontend/templates/term.phtml +++ b/app/code/Magento/Search/view/frontend/templates/term.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (sizeof($this->getTerms()) > 0): ?> <ul class="search-terms"> diff --git a/app/code/Magento/Sendfriend/Controller/Product/Sendmail.php b/app/code/Magento/Sendfriend/Controller/Product/Sendmail.php index 4d1645da39aa034827f4ac3c37e37e85b362d9a5..e3ac2a66b17ef58c0110fd96c8bc0d822d9f2e95 100644 --- a/app/code/Magento/Sendfriend/Controller/Product/Sendmail.php +++ b/app/code/Magento/Sendfriend/Controller/Product/Sendmail.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sendfriend\Controller\Product; use Magento\Framework\Exception\NoSuchEntityException; @@ -37,6 +40,7 @@ class Sendmail extends \Magento\Sendfriend\Controller\Product * Send Email Post Action * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Sendfriend/Helper/Data.php b/app/code/Magento/Sendfriend/Helper/Data.php index 0b14d107863c49e781cc524596d92076c2c4b04a..e7befbc90105faea6729863e522ca7121ccab82e 100644 --- a/app/code/Magento/Sendfriend/Helper/Data.php +++ b/app/code/Magento/Sendfriend/Helper/Data.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sendfriend\Helper; /** diff --git a/app/code/Magento/Sendfriend/Model/Observer.php b/app/code/Magento/Sendfriend/Model/Observer.php index 6d792a985ff493a2e95b085ec069abe9a8a52924..b3883234c174074d88c7313e7426865e634d7e11 100644 --- a/app/code/Magento/Sendfriend/Model/Observer.php +++ b/app/code/Magento/Sendfriend/Model/Observer.php @@ -31,6 +31,7 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function register(\Magento\Framework\Event\Observer $observer) { diff --git a/app/code/Magento/Sendfriend/Model/Resource/Sendfriend.php b/app/code/Magento/Sendfriend/Model/Resource/Sendfriend.php index d74e7a6cb15dab12094a03bf41652523951b3bd1..e2e98e4b7c1430506462d65e306cda1a3baf39da 100644 --- a/app/code/Magento/Sendfriend/Model/Resource/Sendfriend.php +++ b/app/code/Magento/Sendfriend/Model/Resource/Sendfriend.php @@ -30,6 +30,7 @@ class Sendfriend extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param int $startTime * @param int $websiteId * @return int + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getSendCount($object, $ip, $startTime, $websiteId = null) { diff --git a/app/code/Magento/Sendfriend/Model/Sendfriend.php b/app/code/Magento/Sendfriend/Model/Sendfriend.php index d365253ebfd91b65745669b7c097476e1452eb25..fc91a198568dae8c697e667feefda63a42b2173c 100644 --- a/app/code/Magento/Sendfriend/Model/Sendfriend.php +++ b/app/code/Magento/Sendfriend/Model/Sendfriend.php @@ -18,6 +18,7 @@ use Magento\Framework\Model\Exception as CoreException; * @method \Magento\Sendfriend\Model\Sendfriend setTime(int $value) * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Sendfriend extends \Magento\Framework\Model\AbstractModel { @@ -121,6 +122,7 @@ class Sendfriend extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -219,6 +221,8 @@ class Sendfriend extends \Magento\Framework\Model\AbstractModel * Validate Form data * * @return bool|string[] + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validate() { @@ -268,6 +272,7 @@ class Sendfriend extends \Magento\Framework\Model\AbstractModel * * @param array $recipients * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function setRecipients($recipients) { diff --git a/app/code/Magento/Sendfriend/view/frontend/templates/send.phtml b/app/code/Magento/Sendfriend/view/frontend/templates/send.phtml index 50f4b22f3b9e8255f489a0516b55f313b8c6d880..91604d10ef48f6935c1ecfe8e401fe599cb42681 100644 --- a/app/code/Magento/Sendfriend/view/frontend/templates/send.phtml +++ b/app/code/Magento/Sendfriend/view/frontend/templates/send.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * Send to friend form * diff --git a/app/code/Magento/Shipping/Block/Adminhtml/View/Form.php b/app/code/Magento/Shipping/Block/Adminhtml/View/Form.php index 9dafeb0810e4ea133850562a9a3c69302f89f0b4..2f848e0a150c139f624847ddbdab1d9a89abd174 100644 --- a/app/code/Magento/Shipping/Block/Adminhtml/View/Form.php +++ b/app/code/Magento/Shipping/Block/Adminhtml/View/Form.php @@ -70,6 +70,7 @@ class Form extends \Magento\Sales\Block\Adminhtml\Order\AbstractOrder * Get create label button html * * @return string + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getCreateLabelButton() { diff --git a/app/code/Magento/Shipping/Block/Tracking/Popup.php b/app/code/Magento/Shipping/Block/Tracking/Popup.php index 61cab60211554252e5c98ba5d0a00538c958a282..2959384a80acd7377399d80ca1a36fa266619e9b 100644 --- a/app/code/Magento/Shipping/Block/Tracking/Popup.php +++ b/app/code/Magento/Shipping/Block/Tracking/Popup.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Shipping\Block\Tracking; class Popup extends \Magento\Framework\View\Element\Template @@ -86,6 +89,7 @@ class Popup extends \Magento\Framework\View\Element\Template * Is 'contact us' option enabled? * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getContactUsEnabled() { diff --git a/app/code/Magento/Shipping/Controller/Adminhtml/Order/Shipment/MassPrintShippingLabel.php b/app/code/Magento/Shipping/Controller/Adminhtml/Order/Shipment/MassPrintShippingLabel.php index 8ef98d7eb22bc8700bd8bb47b6fc8c8b58d56d55..09b92ee211a1ce0cb121e81304945b947a6c744f 100644 --- a/app/code/Magento/Shipping/Controller/Adminhtml/Order/Shipment/MassPrintShippingLabel.php +++ b/app/code/Magento/Shipping/Controller/Adminhtml/Order/Shipment/MassPrintShippingLabel.php @@ -50,6 +50,7 @@ class MassPrintShippingLabel extends \Magento\Backend\App\Action * Push pdf document with shipping labels to user browser * * @return ResponseInterface|void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Shipping/Controller/Adminhtml/Order/Shipment/Save.php b/app/code/Magento/Shipping/Controller/Adminhtml/Order/Shipment/Save.php index 9a3fcde21810585778de0c198c15020073cec8f6..7e35623f2d79bacbc748ae48cbdb1b280feb77ac 100644 --- a/app/code/Magento/Shipping/Controller/Adminhtml/Order/Shipment/Save.php +++ b/app/code/Magento/Shipping/Controller/Adminhtml/Order/Shipment/Save.php @@ -78,6 +78,8 @@ class Save extends \Magento\Backend\App\Action * We can save only new shipment. Existing shipments are not editable * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Shipping/Helper/Data.php b/app/code/Magento/Shipping/Helper/Data.php index b1c29f0d1bbba8af00995a4cd5e696ccd2d9c871..c7cddf2cab81c15c62b9dffc4fb6accb44f43d39 100644 --- a/app/code/Magento/Shipping/Helper/Data.php +++ b/app/code/Magento/Shipping/Helper/Data.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Shipping data helper */ diff --git a/app/code/Magento/Shipping/Model/Carrier/AbstractCarrier.php b/app/code/Magento/Shipping/Model/Carrier/AbstractCarrier.php index 2ac193161e577cbcee220c5e8dbc79cee7b69ae9..147f50e0ba15b9debdd514b581b46fcff1f0257c 100644 --- a/app/code/Magento/Shipping/Model/Carrier/AbstractCarrier.php +++ b/app/code/Magento/Shipping/Model/Carrier/AbstractCarrier.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Shipping\Model\Carrier; use Magento\Quote\Model\Quote\Address\AbstractCarrierInterface; @@ -133,6 +136,7 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst * * @param string $field * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getConfigFlag($field) { @@ -162,6 +166,7 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst * * @param Request $request * @return \Magento\Framework\Object + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function requestToShipment($request) { @@ -174,6 +179,7 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst * * @param Request $request * @return \Magento\Framework\Object + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function returnOfShipment($request) { @@ -185,6 +191,7 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst * * @param \Magento\Framework\Object|null $params * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getContainerTypes(\Magento\Framework\Object $params = null) { @@ -196,6 +203,8 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst * * @param \Magento\Framework\Object|null $params * @return array|bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getAllowedContainers(\Magento\Framework\Object $params = null) { @@ -259,6 +268,7 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst * * @param \Magento\Framework\Object|null $params * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getDeliveryConfirmationTypes(\Magento\Framework\Object $params = null) { @@ -268,6 +278,7 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst /** * @param \Magento\Quote\Model\Quote\Address\RateRequest $request * @return $this|bool|false|\Magento\Framework\Model\AbstractModel + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function checkAvailableShipCountries(\Magento\Quote\Model\Quote\Address\RateRequest $request) { @@ -314,6 +325,7 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst * * @param \Magento\Quote\Model\Quote\Address\RateRequest $request * @return $this|bool|Error + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function proccessAdditionalValidation(\Magento\Quote\Model\Quote\Address\RateRequest $request) { @@ -374,6 +386,8 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst /** * @param \Magento\Quote\Model\Quote\Address\RateRequest $request * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _updateFreeMethodQuote($request) { @@ -554,6 +568,7 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst * * @param string|null $countryId * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function isZipCodeRequired($countryId = null) { @@ -577,6 +592,7 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst * Define if debugging is enabled * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDebugFlag() { @@ -609,6 +625,7 @@ abstract class AbstractCarrier extends \Magento\Framework\Object implements Abst * * @param \Magento\Framework\Object $params * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getContentTypes(\Magento\Framework\Object $params) { diff --git a/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php b/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php index a0c7ea000be84fb387481d6f3810720842261aca..592adb163f83660748e94335abef687ee62d7876 100644 --- a/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php +++ b/app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php @@ -12,6 +12,7 @@ use Magento\Shipping\Model\Shipment\Request; /** * Abstract online shipping carrier model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractCarrierOnline extends AbstractCarrier { @@ -247,6 +248,7 @@ abstract class AbstractCarrierOnline extends AbstractCarrier * * @param RateRequest $request * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getAllItems(RateRequest $request) { @@ -279,6 +281,8 @@ abstract class AbstractCarrierOnline extends AbstractCarrier * * @param RateRequest $request * @return $this|bool|Error + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function proccessAdditionalValidation(RateRequest $request) { @@ -518,6 +522,7 @@ abstract class AbstractCarrierOnline extends AbstractCarrier * @return bool * * @todo implement rollback logic + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function rollBack($data) { @@ -566,6 +571,7 @@ abstract class AbstractCarrierOnline extends AbstractCarrier * * @param null|string $countyDest * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function isGirthAllowed($countyDest = null) { diff --git a/app/code/Magento/Shipping/Model/Config.php b/app/code/Magento/Shipping/Model/Config.php index 68cb91bf39e2dee8519161ce6a05d9b56a8372c4..c5ac94f1ef5b3c51c82073bd1f07388fddd38694 100644 --- a/app/code/Magento/Shipping/Model/Config.php +++ b/app/code/Magento/Shipping/Model/Config.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Shipping\Model; class Config extends \Magento\Framework\Object diff --git a/app/code/Magento/Shipping/Model/Info.php b/app/code/Magento/Shipping/Model/Info.php index ccbf79eaa36d525874095e3be0a2f24203b0cd56..c455c59d91e71d332f543974c93dab3b66a62778 100644 --- a/app/code/Magento/Shipping/Model/Info.php +++ b/app/code/Magento/Shipping/Model/Info.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Shipping\Model; use Magento\Sales\Model\Order\Shipment; diff --git a/app/code/Magento/Shipping/Model/Order/Pdf/Packaging.php b/app/code/Magento/Shipping/Model/Order/Pdf/Packaging.php index 80a94cc517f277e79bb05b1008da414375c01bdd..2e481201d7f10cb6f2718eff22e947ddf4c48488 100644 --- a/app/code/Magento/Shipping/Model/Order/Pdf/Packaging.php +++ b/app/code/Magento/Shipping/Model/Order/Pdf/Packaging.php @@ -7,6 +7,9 @@ namespace Magento\Shipping\Model\Order\Pdf; use Magento\Shipping\Helper\Carrier; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Packaging extends \Magento\Sales\Model\Order\Pdf\AbstractPdf { /** @@ -142,6 +145,10 @@ class Packaging extends \Magento\Sales\Model\Order\Pdf\AbstractPdf * * @param \Zend_Pdf_Page $page * @return \Magento\Shipping\Model\Order\Pdf\Packaging + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _drawPackageBlock(\Zend_Pdf_Page $page) { diff --git a/app/code/Magento/Shipping/Model/Rate/Result.php b/app/code/Magento/Shipping/Model/Rate/Result.php index 14f1f881083dc7e117fd00cc1bfa757cee9f8d33..697b91b4d5941629c46b1caf9d4bffdbbecf0fb9 100644 --- a/app/code/Magento/Shipping/Model/Rate/Result.php +++ b/app/code/Magento/Shipping/Model/Rate/Result.php @@ -182,6 +182,7 @@ class Result * Sort rates by price from min to max * * @return $this + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function sortRatesByPrice() { diff --git a/app/code/Magento/Shipping/Model/Shipping.php b/app/code/Magento/Shipping/Model/Shipping.php index 8c67b2ed527190fd0ce70e68f2c1d9cbb5b3d106..bcb067aba82ed22e0984fe47e43f52287ade8c48 100644 --- a/app/code/Magento/Shipping/Model/Shipping.php +++ b/app/code/Magento/Shipping/Model/Shipping.php @@ -8,6 +8,9 @@ namespace Magento\Shipping\Model; use Magento\Sales\Model\Order\Shipment; use Magento\Quote\Model\Quote\Address\RateCollectorInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Shipping implements RateCollectorInterface { /** @@ -231,6 +234,8 @@ class Shipping implements RateCollectorInterface * @param string $carrierCode * @param \Magento\Quote\Model\Quote\Address\RateRequest $request * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function collectCarrierRates($carrierCode, $request) { @@ -310,6 +315,8 @@ class Shipping implements RateCollectorInterface * @param \Magento\Shipping\Model\Carrier\AbstractCarrier $carrier * @param \Magento\Quote\Model\Quote\Address\RateRequest $request * @return array [int, float] + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function composePackagesForCarrier($carrier, $request) { diff --git a/app/code/Magento/Shipping/Model/Shipping/LabelGenerator.php b/app/code/Magento/Shipping/Model/Shipping/LabelGenerator.php index e55c9991d8bdcfa1f4e1c870adefa479a65e260c..e51a5eb891f07b31598f2cbe03c30d5d4829c0e0 100644 --- a/app/code/Magento/Shipping/Model/Shipping/LabelGenerator.php +++ b/app/code/Magento/Shipping/Model/Shipping/LabelGenerator.php @@ -9,6 +9,9 @@ namespace Magento\Shipping\Model\Shipping; use Magento\Framework\App\Filesystem\DirectoryList; use Magento\Framework\App\RequestInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class LabelGenerator { /** diff --git a/app/code/Magento/Shipping/Model/Shipping/Labels.php b/app/code/Magento/Shipping/Model/Shipping/Labels.php index a279416633ca4cac85371c1cab8f02373983a1f1..40b7add661e011da1e88900076c500ef482f6865 100644 --- a/app/code/Magento/Shipping/Model/Shipping/Labels.php +++ b/app/code/Magento/Shipping/Model/Shipping/Labels.php @@ -3,12 +3,16 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Shipping\Model\Shipping; use Magento\Sales\Model\Order\Shipment; /** * Shipping labels model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Labels extends \Magento\Shipping\Model\Shipping { @@ -34,6 +38,7 @@ class Labels extends \Magento\Shipping\Model\Shipping * @param \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry * @param \Magento\Backend\Model\Auth\Session $authSession * @param \Magento\Shipping\Model\Shipment\Request $request + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, @@ -69,6 +74,8 @@ class Labels extends \Magento\Shipping\Model\Shipping * @param Shipment $orderShipment * @return \Magento\Framework\Object * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function requestToShipment(Shipment $orderShipment) { diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/create/form.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/create/form.phtml index 38e4943a7f77b3f097b859ad04d12d691ec06858..3be6425cab0f1a44826eca845408be24bc5f3876 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/create/form.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/create/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <form id="edit_form" method="post" action="<?php echo $this->getSaveUrl() ?>"> <?php echo $this->getBlockHtml('formkey')?> diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/create/items.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/create/items.phtml index aa29650b2761ae142b129dd569f3c50e50a25eae..fc7b6960ebd1a05caefaacf9ea4afd44f4a6a5ca 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/create/items.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/create/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="fieldset-wrapper"> <div class="fieldset-wrapper-title"> diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/create/items/renderer/default.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/create/items/renderer/default.phtml index 761aec30674fda57b784f01e861e67f427edf1e3..2101fc41f1ce0e45c551045c7106f3c3ba112957 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/create/items/renderer/default.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/create/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_item = $this->getItem() ?> <tr> diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/order/Tracking/view.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/order/Tracking/view.phtml index a1f7be2a39dba7da47487e829df731c59d857396..98ab4af25e613aee86d6071e3a809f98c481a949 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/order/Tracking/view.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/order/Tracking/view.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this Magento\Shipping\Block\Adminhtml\Order\Tracking\View */ ?> <table cellspacing="0" class="data-table" id="shipment_tracking_info"> diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/grid.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/grid.phtml index 157b63e2b35de35043af6eb7b67e601367dceba2..0e213c1b817cdadf2ffb368ab1bd3e648b9c5e9f 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/grid.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/grid.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="grid"> <table cellspacing="0" class="data-table"> diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/packed.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/packed.phtml index 4d290a74b5a5ac1b0203c6015d85f06152684645..92b3bd34f5b04ea72329046325ddfe81c1ec796d 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/packed.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/packed.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div id="popup-window-mask" style="display:none;"></div> <div id="packed_window" style="display:none;" class="packed-window"> diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup.phtml index cc8d316e7fec6420f871ef660e67cf5cd0409f16..cc236a2e9d2f62a87ad2d372faacfa9df08055ae 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Shipping\Block\Adminhtml\Order\Packaging */ ?> <?php diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/order/tracking.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/order/tracking.phtml index 2caf8723676e9ef04e9d056ac46d6a29f6ead5e4..c3e00c43e7baba96f2adebfa6ff930d4bc33a597 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/order/tracking.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/order/tracking.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this Magento\Shipping\Block\Adminhtml\Order\Tracking */?> <script> diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/order/view/info.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/order/view/info.phtml index 1ec147e360b67ac415e7c5a5cd42fc3af1dc29a1..0b590f2f8f9c5f4c33989569b1b682c81c1ac7c4 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/order/view/info.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/order/view/info.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Shipping\Block\Adminhtml\View */ ?> <?php $order = $this->getOrder() ?> diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/view/form.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/view/form.phtml index cab45f4fd6336602294724ffb7537f31b18f5c15..5d8a5c3bf2d910c72fd1cf37176c28001f92ac50 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/view/form.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/view/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_order = $this->getShipment()->getOrder() ?> <?php echo $this->getChildHtml('order_info') ?> diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/view/items.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/view/items.phtml index 7ec4fb2de9ffda1ffdc18b03e4217e00f95c1ab9..fb13e9585feab6117df14752cd8803fa8f694f20 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/view/items.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/view/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="grid"> <table cellspacing="0" class="data"> diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/view/items/renderer/default.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/view/items/renderer/default.phtml index 62443c04c4ae3c12022856444e3f13cb4e622a30..0d2b5945c480c331e743bc5d9a802438dbf8a707 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/view/items/renderer/default.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/view/items/renderer/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_item = $this->getItem() ?> <tr class="border"> diff --git a/app/code/Magento/Shipping/view/frontend/templates/items.phtml b/app/code/Magento/Shipping/view/frontend/templates/items.phtml index f636df52fedc044150c0cf3c2681fe3103df3f75..2d3b1173e5853d9c2525484a4aa095c28f5b82d9 100644 --- a/app/code/Magento/Shipping/view/frontend/templates/items.phtml +++ b/app/code/Magento/Shipping/view/frontend/templates/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Shipping\Block\Items */ ?> <?php $_order = $this->getOrder() ?> diff --git a/app/code/Magento/Shipping/view/frontend/templates/tracking/link.phtml b/app/code/Magento/Shipping/view/frontend/templates/tracking/link.phtml index d98cadf13321b6fe93a10ca6339b4ec4b23775be..6603dd32deb00364e1e437b0ae6e8202cbd38e72 100644 --- a/app/code/Magento/Shipping/view/frontend/templates/tracking/link.phtml +++ b/app/code/Magento/Shipping/view/frontend/templates/tracking/link.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Shipping\Block\Tracking\Link */ ?> <?php $order = $this->getOrder() ?> diff --git a/app/code/Magento/Shipping/view/frontend/templates/tracking/popup.phtml b/app/code/Magento/Shipping/view/frontend/templates/tracking/popup.phtml index 678847951b89e4721ea0b266ef2135f5d677780c..11ef871e43541391620733cf9227f97de763007d 100644 --- a/app/code/Magento/Shipping/view/frontend/templates/tracking/popup.phtml +++ b/app/code/Magento/Shipping/view/frontend/templates/tracking/popup.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Shipping\Block\Tracking\Popup */ ?> <?php $_results = $this->getTrackingInfo(); ?> diff --git a/app/code/Magento/Sitemap/Controller/Adminhtml/Sitemap/Edit.php b/app/code/Magento/Sitemap/Controller/Adminhtml/Sitemap/Edit.php index c6fea032b57406cc7840fac919c32812f63b02f0..47cf66a319c0e9e0c7d78e521fb0f96078dd2dbc 100644 --- a/app/code/Magento/Sitemap/Controller/Adminhtml/Sitemap/Edit.php +++ b/app/code/Magento/Sitemap/Controller/Adminhtml/Sitemap/Edit.php @@ -29,6 +29,7 @@ class Edit extends \Magento\Sitemap\Controller\Adminhtml\Sitemap * Edit sitemap * * @return void + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Sitemap/Controller/Adminhtml/Sitemap/Save.php b/app/code/Magento/Sitemap/Controller/Adminhtml/Sitemap/Save.php index 58f216f7b22ba929ee009a7c001fba6318670e5b..63e15c1c0c91c281120fb9e5aab1f22ae13e39a0 100644 --- a/app/code/Magento/Sitemap/Controller/Adminhtml/Sitemap/Save.php +++ b/app/code/Magento/Sitemap/Controller/Adminhtml/Sitemap/Save.php @@ -15,6 +15,7 @@ class Save extends \Magento\Sitemap\Controller\Adminhtml\Sitemap * Save action * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Sitemap/Model/Observer.php b/app/code/Magento/Sitemap/Model/Observer.php index 4805c3676f19f1d050af5435bee91df5143a1906..f0f7066e7091ecca43e48db61813d9b5adf4c622 100644 --- a/app/code/Magento/Sitemap/Model/Observer.php +++ b/app/code/Magento/Sitemap/Model/Observer.php @@ -90,6 +90,8 @@ class Observer * * @param \Magento\Cron\Model\Schedule $schedule * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function scheduledGenerateSitemaps($schedule) { diff --git a/app/code/Magento/Sitemap/Model/Resource/Catalog/Product.php b/app/code/Magento/Sitemap/Model/Resource/Catalog/Product.php index 9f7b3200e89dd8326458ac7f3bd225c1ff5230b3..bd3741d3f5f416e92d896f10ed3053b97ba5f6df 100644 --- a/app/code/Magento/Sitemap/Model/Resource/Catalog/Product.php +++ b/app/code/Magento/Sitemap/Model/Resource/Catalog/Product.php @@ -11,6 +11,7 @@ use Magento\CatalogUrlRewrite\Model\ProductUrlRewriteGenerator; * Sitemap resource product collection model * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Product extends \Magento\Framework\Model\Resource\Db\AbstractDb { diff --git a/app/code/Magento/Sitemap/Model/Sitemap.php b/app/code/Magento/Sitemap/Model/Sitemap.php index 0235f1e75adb55fae856428192ab540142cdc8b8..4baabe60a907eb0d60984115ce3e29cb3ad54142 100644 --- a/app/code/Magento/Sitemap/Model/Sitemap.php +++ b/app/code/Magento/Sitemap/Model/Sitemap.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sitemap\Model; use Magento\Framework\App\Filesystem\DirectoryList; @@ -22,6 +25,8 @@ use Magento\Framework\App\Filesystem\DirectoryList; * @method \Magento\Sitemap\Model\Sitemap setSitemapTime(string $value) * @method int getStoreId() * @method \Magento\Sitemap\Model\Sitemap setStoreId(int $value) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Sitemap extends \Magento\Framework\Model\AbstractModel { @@ -157,6 +162,7 @@ class Sitemap extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Store/App/Action/Plugin/Context.php b/app/code/Magento/Store/App/Action/Plugin/Context.php index 8332f4bca5aaa02f2fa65d05228783bf402e6e32..9ac06a3058ba99fbf04e3fe211ad8e6e1e835e6d 100644 --- a/app/code/Magento/Store/App/Action/Plugin/Context.php +++ b/app/code/Magento/Store/App/Action/Plugin/Context.php @@ -54,6 +54,7 @@ class Context * @param callable $proceed * @param \Magento\Framework\App\RequestInterface $request * @return mixed + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aroundDispatch( \Magento\Framework\App\Action\Action $subject, diff --git a/app/code/Magento/Store/Model/Resource/Group/Collection.php b/app/code/Magento/Store/Model/Resource/Group/Collection.php index 832c7b46d2c8c84ad4ccc22562036048856c50d6..3f36a0229884193d4f197a22878232718882cb75 100644 --- a/app/code/Magento/Store/Model/Resource/Group/Collection.php +++ b/app/code/Magento/Store/Model/Resource/Group/Collection.php @@ -36,6 +36,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac * Is load default (admin) store * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getLoadDefault() { diff --git a/app/code/Magento/Store/Model/Resource/Store/Collection.php b/app/code/Magento/Store/Model/Resource/Store/Collection.php index 6f8df5c43fab92ebb1965ace63be40b632d6544b..3eb4358c1e5724f67dc1096bf7adb41d7029204f 100644 --- a/app/code/Magento/Store/Model/Resource/Store/Collection.php +++ b/app/code/Magento/Store/Model/Resource/Store/Collection.php @@ -51,6 +51,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac * Is load default (admin) store * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getLoadDefault() { diff --git a/app/code/Magento/Store/Model/Resource/Website.php b/app/code/Magento/Store/Model/Resource/Website.php index 5a44136529c90d686371d40cae2e617a296de500..1213b6c8de7eb359b7eb8ef6a36a4aaa69c0145a 100644 --- a/app/code/Magento/Store/Model/Resource/Website.php +++ b/app/code/Magento/Store/Model/Resource/Website.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Store\Model\Resource; /** diff --git a/app/code/Magento/Store/Model/Resource/Website/Collection.php b/app/code/Magento/Store/Model/Resource/Website/Collection.php index 1b263ec39dfc127cf4a7cc57bbc3a8c83b4c9b3a..3c50219847772b12b8effdb57a5f9423f9619fac 100644 --- a/app/code/Magento/Store/Model/Resource/Website/Collection.php +++ b/app/code/Magento/Store/Model/Resource/Website/Collection.php @@ -57,6 +57,7 @@ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\Abstrac * Is load default (admin) website * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getLoadDefault() { diff --git a/app/code/Magento/Store/Model/Storage/Db.php b/app/code/Magento/Store/Model/Storage/Db.php index 90bafe68904cf9bb0b674886d4289e7d065af2b8..f9cd545b5b1e740fa844a6c6cc336a6bda61766e 100644 --- a/app/code/Magento/Store/Model/Storage/Db.php +++ b/app/code/Magento/Store/Model/Storage/Db.php @@ -14,6 +14,10 @@ use Magento\Store\Model\StoreFactory; use Magento\Store\Model\Website; use Magento\Store\Model\WebsiteFactory as WebsiteFactory; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Db implements \Magento\Store\Model\StoreManagerInterface { /** @@ -133,6 +137,7 @@ class Db implements \Magento\Store\Model\StoreManagerInterface * @param State $appState * @param bool $isSingleStoreAllowed * @param null $currentStore + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( StoreFactory $storeFactory, @@ -179,6 +184,7 @@ class Db implements \Magento\Store\Model\StoreManagerInterface * Init store, group and website collections * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _initStores() { @@ -283,6 +289,8 @@ class Db implements \Magento\Store\Model\StoreManagerInterface * @param null|string|bool|int|Store $storeId * @return Store * @throws \Magento\Framework\App\InitException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getStore($storeId = null) { @@ -433,6 +441,7 @@ class Db implements \Magento\Store\Model\StoreManagerInterface * @param bool $withDefault * @param bool $codeKey * @return Group[] + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getGroups($withDefault = false, $codeKey = false) { diff --git a/app/code/Magento/Store/Model/StorageFactory.php b/app/code/Magento/Store/Model/StorageFactory.php index b46c0a09a4cb4148367b5c38cbbfcaf326871dab..cf53216bd169cd611b88f46838345831bef4bfaf 100644 --- a/app/code/Magento/Store/Model/StorageFactory.php +++ b/app/code/Magento/Store/Model/StorageFactory.php @@ -7,6 +7,9 @@ namespace Magento\Store\Model; use Magento\Framework\Profiler; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class StorageFactory { /** diff --git a/app/code/Magento/Store/Model/Store.php b/app/code/Magento/Store/Model/Store.php index e36ea55f6087333b7f4d12e6bebf38af2e159574..442347f72b5f1ae8673cae6a176b1497b6541045 100644 --- a/app/code/Magento/Store/Model/Store.php +++ b/app/code/Magento/Store/Model/Store.php @@ -19,6 +19,10 @@ use Magento\Framework\Model\AbstractModel; * @method int getStoreId() * @method \Magento\Store\Model\Store setSortOrder(int $value) * @method \Magento\Store\Model\Store setIsActive(int $value) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * @SuppressWarnings(PHPMD.ExcessivePublicCount) */ class Store extends AbstractModel implements \Magento\Framework\App\ScopeInterface, @@ -317,6 +321,7 @@ class Store extends AbstractModel implements * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param bool $isCustomEntryPoint * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -526,6 +531,8 @@ class Store extends AbstractModel implements * @param boolean|null $secure * @return string * @throws \InvalidArgumentException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getBaseUrl($type = \Magento\Framework\UrlInterface::URL_TYPE_LINK, $secure = null) { @@ -1031,6 +1038,8 @@ class Store extends AbstractModel implements * * @param bool|string $fromStore * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getCurrentUrl($fromStore = true) { diff --git a/app/code/Magento/Store/Model/System/Store.php b/app/code/Magento/Store/Model/System/Store.php index 38850ba6ced3eb2becd35f9a6c8e51e1b4782cb8..d12f4d791e310915f62055ac738d48120815d0b8 100644 --- a/app/code/Magento/Store/Model/System/Store.php +++ b/app/code/Magento/Store/Model/System/Store.php @@ -100,6 +100,8 @@ class Store extends \Magento\Framework\Object * @param bool $empty * @param bool $all * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getStoreValuesForForm($empty = false, $all = false) { @@ -156,6 +158,8 @@ class Store extends \Magento\Framework\Object * @param array $groupIds * @param array $websiteIds * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getStoresStructure($isAll = false, $storeIds = [], $groupIds = [], $websiteIds = []) { diff --git a/app/code/Magento/Store/Model/Website.php b/app/code/Magento/Store/Model/Website.php index 746777c9f4138b3c8e7744c6196b705b928d5592..6299b99237f2014b79cade78d25fc19bf2763ce8 100644 --- a/app/code/Magento/Store/Model/Website.php +++ b/app/code/Magento/Store/Model/Website.php @@ -26,6 +26,8 @@ use Magento\Store\Model\StoreManagerInterface; * @method \Magento\Store\Model\Website setDefaultGroupId(int $value) * @method int getIsDefault() * @method \Magento\Store\Model\Website setIsDefault(int $value) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Website extends \Magento\Framework\Model\AbstractModel implements \Magento\Framework\Object\IdentityInterface, @@ -175,6 +177,7 @@ class Website extends \Magento\Framework\Model\AbstractModel implements * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Store/view/frontend/templates/switch/flags.phtml b/app/code/Magento/Store/view/frontend/templates/switch/flags.phtml index da14314d708f3b68ca1e83ba1756bf3900499da3..60839e5f31a78f61aa6a532becab9da640dc37c6 100644 --- a/app/code/Magento/Store/view/frontend/templates/switch/flags.phtml +++ b/app/code/Magento/Store/view/frontend/templates/switch/flags.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if (count($this->getStores())>1): ?> <div class="form-language"> diff --git a/app/code/Magento/Store/view/frontend/templates/switch/languages.phtml b/app/code/Magento/Store/view/frontend/templates/switch/languages.phtml index 0a266dd0064b444dd4844e903734cafccb7985a2..26d29298ce3b2227882f9b3daadeebbad4401a21 100644 --- a/app/code/Magento/Store/view/frontend/templates/switch/languages.phtml +++ b/app/code/Magento/Store/view/frontend/templates/switch/languages.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Store/view/frontend/templates/switch/stores.phtml b/app/code/Magento/Store/view/frontend/templates/switch/stores.phtml index b5f7346fa6a9259e3686db2280bfd430b400c736..20935584a94d51f5976d7b8594f657c590d21b18 100644 --- a/app/code/Magento/Store/view/frontend/templates/switch/stores.phtml +++ b/app/code/Magento/Store/view/frontend/templates/switch/stores.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Tax/Api/Data/QuoteDetailsItemInterface.php b/app/code/Magento/Tax/Api/Data/QuoteDetailsItemInterface.php index 3c439a5c418324fc4fca291227cafda31544923d..405eae5862810b0b9ce4054e17baf916a7af5a67 100644 --- a/app/code/Magento/Tax/Api/Data/QuoteDetailsItemInterface.php +++ b/app/code/Magento/Tax/Api/Data/QuoteDetailsItemInterface.php @@ -72,6 +72,7 @@ interface QuoteDetailsItemInterface extends \Magento\Framework\Api\ExtensibleDat * Get indicate that if the tax is included in the unit price and row total * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getTaxIncluded(); diff --git a/app/code/Magento/Tax/Block/Adminhtml/Rate/Form.php b/app/code/Magento/Tax/Block/Adminhtml/Rate/Form.php index 54aedb14aaacea1f64a21020c376a0d8c47a81e8..7886702d51034b7e92ca5dbee59f4484ceed7bdc 100644 --- a/app/code/Magento/Tax/Block/Adminhtml/Rate/Form.php +++ b/app/code/Magento/Tax/Block/Adminhtml/Rate/Form.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Admin product tax class add form * @@ -14,6 +16,9 @@ namespace Magento\Tax\Block\Adminhtml\Rate; use Magento\Framework\Exception\NoSuchEntityException; use Magento\Tax\Controller\RegistryConstants; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Form extends \Magento\Backend\Block\Widget\Form\Generic { const FORM_ELEMENT_ID = 'rate-form'; @@ -71,6 +76,7 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic * @param \Magento\Tax\Api\TaxRateRepositoryInterface $taxRateRepository * @param \Magento\Tax\Model\TaxRateCollection $taxRateCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Backend\Block\Template\Context $context, @@ -104,6 +110,9 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic /** * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Tax/Block/Adminhtml/Rule/Edit/Form.php b/app/code/Magento/Tax/Block/Adminhtml/Rule/Edit/Form.php index 0afe26138498fec811d94fdf2fbee9564cf734c3..0d2b16bee6f0dff1154bba3c025f3a0f9b0b541a 100644 --- a/app/code/Magento/Tax/Block/Adminhtml/Rule/Edit/Form.php +++ b/app/code/Magento/Tax/Block/Adminhtml/Rule/Edit/Form.php @@ -90,6 +90,9 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic /** * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Tax/Block/Checkout/Cart/Sidebar/Totals.php b/app/code/Magento/Tax/Block/Checkout/Cart/Sidebar/Totals.php index 167d30a11f40d0bcd77e267c432902002cdcae55..7b0b5bf2cc4d86ac9f9bf0eab8758d9db0c8afb1 100644 --- a/app/code/Magento/Tax/Block/Checkout/Cart/Sidebar/Totals.php +++ b/app/code/Magento/Tax/Block/Checkout/Cart/Sidebar/Totals.php @@ -86,6 +86,7 @@ class Totals extends SidebarTotals * Return whether subtotal should be displayed including tax * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDisplaySubtotalInclTax() { @@ -96,6 +97,7 @@ class Totals extends SidebarTotals * Return whether subtotal should be displayed excluding tax * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDisplaySubtotalExclTax() { @@ -106,6 +108,7 @@ class Totals extends SidebarTotals * Return whether subtotal should be displayed excluding and including tax * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getDisplaySubtotalBoth() { diff --git a/app/code/Magento/Tax/Block/Sales/Order/Tax.php b/app/code/Magento/Tax/Block/Sales/Order/Tax.php index af87c80d409afa5a581daf6c75887b1906d78adf..86737961b60e2409050ec30a2da3d872958de441 100644 --- a/app/code/Magento/Tax/Block/Sales/Order/Tax.php +++ b/app/code/Magento/Tax/Block/Sales/Order/Tax.php @@ -115,6 +115,7 @@ class Tax extends \Magento\Framework\View\Element\Template /** * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _initSubtotal() { diff --git a/app/code/Magento/Tax/Controller/Adminhtml/Rule.php b/app/code/Magento/Tax/Controller/Adminhtml/Rule.php index 0a7e7af49fd7f83933ecd43eee8d60561c39164c..1ff5f1711a3418ad4d715c2ee44202f9ad9bd547 100644 --- a/app/code/Magento/Tax/Controller/Adminhtml/Rule.php +++ b/app/code/Magento/Tax/Controller/Adminhtml/Rule.php @@ -81,6 +81,7 @@ class Rule extends \Magento\Backend\App\Action * * @param array $postData * @return \Magento\Tax\Api\Data\TaxRuleInterface + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function populateTaxRule($postData) { diff --git a/app/code/Magento/Tax/Helper/Data.php b/app/code/Magento/Tax/Helper/Data.php index 8d824e169c8881c5f5dc3d9583505050b0caada2..580aacd2f63ab4fb2357df744da120a563e19680 100644 --- a/app/code/Magento/Tax/Helper/Data.php +++ b/app/code/Magento/Tax/Helper/Data.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tax\Helper; use Magento\Framework\Pricing\PriceCurrencyInterface; @@ -22,6 +25,8 @@ use Magento\Sales\Model\EntityInterface; /** * Catalog data helper + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Data extends \Magento\Framework\App\Helper\AbstractHelper { @@ -170,6 +175,7 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * @param \Magento\Catalog\Helper\Data $catalogHelper * @param OrderTaxManagementInterface $orderTaxManagement * @param PriceCurrencyInterface $priceCurrency + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Helper\Context $context, @@ -790,6 +796,7 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * @param EntityInterface $order * @param EntityInterface $salesItem * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function calculateTaxForItems(EntityInterface $order, EntityInterface $salesItem) { diff --git a/app/code/Magento/Tax/Model/Calculation.php b/app/code/Magento/Tax/Model/Calculation.php index 2e997213216a34ed87670bd4371275c83f2c4d9d..8be6f10337d3902e757593b56e01d47168333e7b 100644 --- a/app/code/Magento/Tax/Model/Calculation.php +++ b/app/code/Magento/Tax/Model/Calculation.php @@ -20,6 +20,8 @@ use Magento\Tax\Model\Config; /** * Tax Calculation Model + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Calculation extends \Magento\Framework\Model\AbstractModel { @@ -187,6 +189,7 @@ class Calculation extends \Magento\Framework\Model\AbstractModel * @param PriceCurrencyInterface $priceCurrency * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -470,6 +473,9 @@ class Calculation extends \Magento\Framework\Model\AbstractModel * @param null|int|\Magento\Store\Model\Store $store * @param int $customerId * @return \Magento\Framework\Object + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getRateRequest( $shippingAddress = null, diff --git a/app/code/Magento/Tax/Model/Calculation/AbstractCalculator.php b/app/code/Magento/Tax/Model/Calculation/AbstractCalculator.php index 8fbda6ad0698e7271ce7eac2eea21feb85a230e4..0181d2e3426149d5fdd206979d1e877e5dc166c2 100644 --- a/app/code/Magento/Tax/Model/Calculation/AbstractCalculator.php +++ b/app/code/Magento/Tax/Model/Calculation/AbstractCalculator.php @@ -14,6 +14,9 @@ use Magento\Tax\Api\Data\TaxDetailsItemInterface; use Magento\Tax\Api\TaxClassManagementInterface; use Magento\Tax\Model\Calculation; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ abstract class AbstractCalculator { /**#@+ diff --git a/app/code/Magento/Tax/Model/Calculation/Rate.php b/app/code/Magento/Tax/Model/Calculation/Rate.php index d349ef20f63141be338921cc46ee3c43a898f5fd..77d534bff26d27fa4dd6e7a662a709d6b283347e 100644 --- a/app/code/Magento/Tax/Model/Calculation/Rate.php +++ b/app/code/Magento/Tax/Model/Calculation/Rate.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Tax\Model\Calculation; use Magento\Directory\Model\Region; @@ -23,6 +25,7 @@ use Magento\Framework\Exception\CouldNotDeleteException; * @method \Magento\Tax\Model\Calculation\Rate setZipIsRange(int $value) * @method \Magento\Tax\Model\Calculation\Rate setZipFrom(int $value) * @method \Magento\Tax\Model\Calculation\Rate setZipTo(int $value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Rate extends \Magento\Framework\Model\AbstractExtensibleModel implements \Magento\Tax\Api\Data\TaxRateInterface { @@ -63,6 +66,7 @@ class Rate extends \Magento\Framework\Model\AbstractExtensibleModel implements \ * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -105,6 +109,8 @@ class Rate extends \Magento\Framework\Model\AbstractExtensibleModel implements \ * * @return \Magento\Tax\Model\Calculation\Rate * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function beforeSave() { diff --git a/app/code/Magento/Tax/Model/Calculation/RateRepository.php b/app/code/Magento/Tax/Model/Calculation/RateRepository.php index 6d62f585e4a14f7bbb09ac2102f84fb0c1081ee8..142735233d5b8f484fd5a4397d30a9bebf03db07 100644 --- a/app/code/Magento/Tax/Model/Calculation/RateRepository.php +++ b/app/code/Magento/Tax/Model/Calculation/RateRepository.php @@ -18,6 +18,9 @@ use Magento\Tax\Api\Data\TaxRateInterface as TaxRateDataObject; use Magento\Tax\Model\Calculation\Rate\Converter; use Magento\Tax\Model\Resource\Calculation\Rate\Collection; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class RateRepository implements \Magento\Tax\Api\TaxRateRepositoryInterface { const MESSAGE_TAX_RATE_ID_IS_NOT_ALLOWED = 'id is not expected for this request.'; diff --git a/app/code/Magento/Tax/Model/Calculation/Rule.php b/app/code/Magento/Tax/Model/Calculation/Rule.php index d92455159c257288c0f291ca041627173cca81e0..929beae5f49390aeb902a813e83f184a44152b71 100644 --- a/app/code/Magento/Tax/Model/Calculation/Rule.php +++ b/app/code/Magento/Tax/Model/Calculation/Rule.php @@ -59,6 +59,7 @@ class Rule extends \Magento\Framework\Model\AbstractExtensibleModel implements T * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Tax/Model/Calculation/Rule/Validator.php b/app/code/Magento/Tax/Model/Calculation/Rule/Validator.php index 2c29986cc5108592f5ef405246bca9481b56a0cd..a8b304942a0226bb9eabeec86316f968de0d62f5 100644 --- a/app/code/Magento/Tax/Model/Calculation/Rule/Validator.php +++ b/app/code/Magento/Tax/Model/Calculation/Rule/Validator.php @@ -33,6 +33,9 @@ class Validator extends \Magento\Framework\Validator\AbstractValidator * @param \Magento\Tax\Model\Calculation\Rule $value * @return boolean * @throws Zend_Validate_Exception If validation of $value is impossible + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function isValid($value) { diff --git a/app/code/Magento/Tax/Model/Config.php b/app/code/Magento/Tax/Model/Config.php index a02796b698d1af44814ff0764f6bc33e0b1868bb..116529a13b55162195607487539b4400fd1f29ff 100644 --- a/app/code/Magento/Tax/Model/Config.php +++ b/app/code/Magento/Tax/Model/Config.php @@ -13,6 +13,9 @@ namespace Magento\Tax\Model; use Magento\Store\Model\Store; +/** + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + */ class Config { // tax notifications @@ -263,6 +266,7 @@ class Config * Get flag what we need use shipping price exclude tax * * @return bool $flag + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getNeedUseShippingExcludeTax() { @@ -784,6 +788,7 @@ class Config * * @param null|string|bool|int|Store $store * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getInfoUrl($store = null) { @@ -800,6 +805,7 @@ class Config * * @param null|int|string|Store $store * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function needPriceConversion($store = null) { diff --git a/app/code/Magento/Tax/Model/Observer.php b/app/code/Magento/Tax/Model/Observer.php index f7143a62112c1c450109dbda1c6737a44993f9c3..eca55e6365cf7a66b628c3c64880e826ba1b73c9 100644 --- a/app/code/Magento/Tax/Model/Observer.php +++ b/app/code/Magento/Tax/Model/Observer.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Tax Event Observer */ @@ -117,6 +119,9 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function salesEventOrderAfterSave(\Magento\Framework\Event\Observer $observer) { @@ -254,6 +259,7 @@ class Observer * * @param \Magento\Cron\Model\Schedule $schedule * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aggregateSalesReportTaxData($schedule) { diff --git a/app/code/Magento/Tax/Model/Quote/ToOrderConverter.php b/app/code/Magento/Tax/Model/Quote/ToOrderConverter.php index 5db47dec6ea8fefee047dd95d3508c231f6f0db7..18fa11ad4c952efca48bdee43123e2e7a6588d36 100644 --- a/app/code/Magento/Tax/Model/Quote/ToOrderConverter.php +++ b/app/code/Magento/Tax/Model/Quote/ToOrderConverter.php @@ -21,8 +21,9 @@ class ToOrderConverter * @param QuoteAddress $address * @param array $additional * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ - public function beforeConvert(QuoteAddressToOrder $subject, QuoteAddress $address, $additional) + public function beforeConvert(QuoteAddressToOrder $subject, QuoteAddress $address, $additional = []) { $this->quoteAddress = $address; return [$address, $additional]; @@ -32,6 +33,7 @@ class ToOrderConverter * @param QuoteAddressToOrder $subject * @param OrderInterface $order * @return OrderInterface + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterConvert(QuoteAddressToOrder $subject, OrderInterface $order) { diff --git a/app/code/Magento/Tax/Model/Resource/Calculation.php b/app/code/Magento/Tax/Model/Resource/Calculation.php index 5ce230adbe9503c2ea7f9bb005d193b9e0e09f0e..160bea26fe1f9c5e03fd3cd6f1d58a4672305f33 100644 --- a/app/code/Magento/Tax/Model/Resource/Calculation.php +++ b/app/code/Magento/Tax/Model/Resource/Calculation.php @@ -130,6 +130,8 @@ class Calculation extends \Magento\Framework\Model\Resource\Db\AbstractDb * @param \Magento\Framework\Object $request * @param array|null $rates * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getCalculationProcess($request, $rates = null) { @@ -263,6 +265,9 @@ class Calculation extends \Magento\Framework\Model\Resource\Db\AbstractDb * * @param \Magento\Framework\Object $request * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _getRates($request) { diff --git a/app/code/Magento/Tax/Model/Resource/Sales/Order/Tax/Item.php b/app/code/Magento/Tax/Model/Resource/Sales/Order/Tax/Item.php index 7d73c540f14856de118b2513f733a29e59119db5..b13eb4cdfa3733eb669bcb776d12236f439420ac 100644 --- a/app/code/Magento/Tax/Model/Resource/Sales/Order/Tax/Item.php +++ b/app/code/Magento/Tax/Model/Resource/Sales/Order/Tax/Item.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Sales order tax resource model * diff --git a/app/code/Magento/Tax/Model/Sales/Total/Quote/CommonTaxCollector.php b/app/code/Magento/Tax/Model/Sales/Total/Quote/CommonTaxCollector.php index 82c093195d0a745814e1f0567e7b27f23ad3f816..c9f57704b409168753ef192dbf2c5a8a2691d250 100644 --- a/app/code/Magento/Tax/Model/Sales/Total/Quote/CommonTaxCollector.php +++ b/app/code/Magento/Tax/Model/Sales/Total/Quote/CommonTaxCollector.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tax\Model\Sales\Total\Quote; use Magento\Customer\Api\Data\AddressDataBuilder as CustomerAddressBuilder; @@ -20,6 +23,7 @@ use Magento\Tax\Api\Data\TaxDetailsItemInterface; /** * Tax totals calculation model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class CommonTaxCollector extends AbstractTotal { @@ -709,6 +713,8 @@ class CommonTaxCollector extends AbstractTotal * @param float $baseAmount * @param float $rate * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _saveAppliedTaxes( QuoteAddress $address, diff --git a/app/code/Magento/Tax/Model/Sales/Total/Quote/Tax.php b/app/code/Magento/Tax/Model/Sales/Total/Quote/Tax.php index 597a80bf753a406530ba4ea5a51bf6f83eb4ee32..cfccee02b695f17663b350c5a9b4745eb5bdec22 100644 --- a/app/code/Magento/Tax/Model/Sales/Total/Quote/Tax.php +++ b/app/code/Magento/Tax/Model/Sales/Total/Quote/Tax.php @@ -13,6 +13,7 @@ use Magento\Tax\Model\Calculation; /** * Tax totals calculation model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Tax extends CommonTaxCollector { @@ -230,6 +231,7 @@ class Tax extends CommonTaxCollector * @param Address $address * @param array $itemsByType * @return $this + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function processExtraTaxables(Address $address, Array $itemsByType) { @@ -281,6 +283,7 @@ class Tax extends CommonTaxCollector * * @param Address $address * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function fetch(Address $address) { diff --git a/app/code/Magento/Tax/Model/TaxCalculation.php b/app/code/Magento/Tax/Model/TaxCalculation.php index 65eb1e2c18df47e5d308bdf3a41e7ea410791f88..ae2017ce90c6f25ce280736b22092dd5879e7f3f 100644 --- a/app/code/Magento/Tax/Model/TaxCalculation.php +++ b/app/code/Magento/Tax/Model/TaxCalculation.php @@ -20,6 +20,9 @@ use Magento\Tax\Model\Calculation\AbstractCalculator; use Magento\Store\Model\StoreManagerInterface; use Magento\Tax\Api\TaxCalculationInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class TaxCalculation implements TaxCalculationInterface { /** diff --git a/app/code/Magento/Tax/Model/TaxClass/Repository.php b/app/code/Magento/Tax/Model/TaxClass/Repository.php index 9518d9854ac6d4b1070058084f1b4142ea17524f..10698b291590b26605c46b9a86eac9d1ee208648 100644 --- a/app/code/Magento/Tax/Model/TaxClass/Repository.php +++ b/app/code/Magento/Tax/Model/TaxClass/Repository.php @@ -21,6 +21,9 @@ use Magento\Tax\Model\ClassModelRegistry; use Magento\Tax\Model\Resource\TaxClass\Collection as TaxClassCollection; use Magento\Tax\Model\Resource\TaxClass\CollectionFactory as TaxClassCollectionFactory; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Repository implements \Magento\Tax\Api\TaxClassRepositoryInterface { /** diff --git a/app/code/Magento/Tax/Model/TaxRuleRepository.php b/app/code/Magento/Tax/Model/TaxRuleRepository.php index 991169ee45d65269d4780f7129ec0fdf93fe31eb..675f018765539265225ba284ea8435d0fea48e82 100644 --- a/app/code/Magento/Tax/Model/TaxRuleRepository.php +++ b/app/code/Magento/Tax/Model/TaxRuleRepository.php @@ -22,6 +22,9 @@ use Magento\Tax\Model\Resource\Calculation\Rule as Resource; use Magento\Tax\Model\Resource\Calculation\Rule\Collection; use Magento\Tax\Model\Resource\Calculation\Rule\CollectionFactory; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class TaxRuleRepository implements TaxRuleRepositoryInterface { /** diff --git a/app/code/Magento/Tax/view/adminhtml/templates/items/price/row.phtml b/app/code/Magento/Tax/view/adminhtml/templates/items/price/row.phtml index d22474d46c02fe1fe4be1cd3642c4068921e7bd9..36f6d039cbfe81184ae8566ba2bf4ac37c149140 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/items/price/row.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/items/price/row.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Tax\Block\Adminhtml\Items\Price\Renderer $this */ diff --git a/app/code/Magento/Tax/view/adminhtml/templates/items/price/total.phtml b/app/code/Magento/Tax/view/adminhtml/templates/items/price/total.phtml index 8a78cff00278ed053d549ecc694dcf9e31659573..2dca743b9efff2c80effd5de196216edb9144b74 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/items/price/total.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/items/price/total.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Tax\Block\Adminhtml\Items\Price\Renderer $this */ diff --git a/app/code/Magento/Tax/view/adminhtml/templates/items/price/unit.phtml b/app/code/Magento/Tax/view/adminhtml/templates/items/price/unit.phtml index c9eb78a964eb57945a8bdf74c1d8f9af60260f18..48094d068aae27941704d1c2ecba612e5abf274d 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/items/price/unit.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/items/price/unit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Tax\Block\Adminhtml\Items\Price\Renderer $this */ diff --git a/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/row.phtml b/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/row.phtml index 85fd68f69c6d6bafd3ba08a45e92eaed4990d838..db5eec6e9cd9936fd4c258c71679a8590797c53d 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/row.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/row.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Tax\Block\Adminhtml\Items\Price\Renderer $this */ diff --git a/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/total.phtml b/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/total.phtml index 9c54a2ea6d7ed56bb90275082eaf734dd6a9d5a7..e06f57de36074941e8cfd8f0e065514fe2643ee2 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/total.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/total.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Tax\Block\Adminhtml\Items\Price\Renderer $this */ diff --git a/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/unit.phtml b/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/unit.phtml index be15aa941c3087d0f9138f3c1ddcecd9dece1dee..9fbe691194ae0bcb9174ef81b04cca37531d2c8e 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/unit.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/order/create/items/price/unit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Tax\Block\Adminhtml\Items\Price\Renderer $this */ diff --git a/app/code/Magento/Tax/view/adminhtml/templates/rate/form.phtml b/app/code/Magento/Tax/view/adminhtml/templates/rate/form.phtml index 778086ccc36958b84dbcfa77498f39a9be3178db..63652dad28b90a7b01d304d67f419af99ab68741 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/rate/form.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/rate/form.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="entry-edit"> <?php echo $this->getFormHtml() ?> diff --git a/app/code/Magento/Tax/view/adminhtml/templates/rate/js.phtml b/app/code/Magento/Tax/view/adminhtml/templates/rate/js.phtml index c3605bad850826c31e708c9e987dd2d1268cc1f9..dca9643affa6aa92dcc677c93ca609711545643e 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/rate/js.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/rate/js.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <script> require([ diff --git a/app/code/Magento/Tax/view/adminhtml/templates/rate/title.phtml b/app/code/Magento/Tax/view/adminhtml/templates/rate/title.phtml index b91236614d440a717857e8404ff0efad6a44ccea..182e54b825a79c1e1c95a5e90c6d579331ee2899 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/rate/title.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/rate/title.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div id="tax-rate-titles-table" class="form-inline"> <?php $_labels = $this->getTitles() ?> diff --git a/app/code/Magento/Tax/view/adminhtml/templates/toolbar/class/save.phtml b/app/code/Magento/Tax/view/adminhtml/templates/toolbar/class/save.phtml index adb8a7ef74235309dc7dddf12a35a5e380c59e6f..611cc27fa33acef904fbf4d03b8d514b96b92ee6 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/toolbar/class/save.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/toolbar/class/save.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="page-actions"> <?php echo $this->getBackButtonHtml() ?> diff --git a/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rate/add.phtml b/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rate/add.phtml index b43379e5a04c2d6b9b74edb360e261d6258ee85d..4d1dccf3ddf08b5d2858cd531b8ee2dfbd7e59a5 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rate/add.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rate/add.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildhtml('grid') ?> diff --git a/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rate/save.phtml b/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rate/save.phtml index 16f2e123b6d459b1d787b4b8aad5fe7785305636..ffef43a1956cd96a0cc00c95017753e6d3ebcab3 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rate/save.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rate/save.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($form): ?> <?php echo $form->toHtml();?> diff --git a/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rule/save.phtml b/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rule/save.phtml index 9d50608721f772000ca237875d97cc12a794aff7..6601a6fee7a8fa0326abc62791df4e274a438e7e 100644 --- a/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rule/save.phtml +++ b/app/code/Magento/Tax/view/adminhtml/templates/toolbar/rule/save.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="page-actions"> <?php echo $this->getBackButtonHtml(); ?> diff --git a/app/code/Magento/Tax/view/base/templates/pricing/adjustment.phtml b/app/code/Magento/Tax/view/base/templates/pricing/adjustment.phtml index 23d3ddd40f1fd0d18872e1641b9c8ae2c728a1a4..73014836ba2091a798afb465f174f9ba433b84b2 100644 --- a/app/code/Magento/Tax/view/base/templates/pricing/adjustment.phtml +++ b/app/code/Magento/Tax/view/base/templates/pricing/adjustment.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Tax\Pricing\Render\Adjustment $this */ ?> diff --git a/app/code/Magento/Tax/view/base/templates/pricing/adjustment/bundle.phtml b/app/code/Magento/Tax/view/base/templates/pricing/adjustment/bundle.phtml index 74e44645c5d449cb1b2d7c5f9a9f741777828f71..242b49afcdd3906a1a7ee568f9dbd89c1d126963 100644 --- a/app/code/Magento/Tax/view/base/templates/pricing/adjustment/bundle.phtml +++ b/app/code/Magento/Tax/view/base/templates/pricing/adjustment/bundle.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Tax\Pricing\Render\Adjustment $this */ ?> diff --git a/app/code/Magento/Tax/view/frontend/templates/checkout/cart/item/price/sidebar.phtml b/app/code/Magento/Tax/view/frontend/templates/checkout/cart/item/price/sidebar.phtml index c04709c6b633928e37ed355a1a3211f5b74a464f..c58739df971053c9a51475e88dc87b19f94481de 100644 --- a/app/code/Magento/Tax/view/frontend/templates/checkout/cart/item/price/sidebar.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/checkout/cart/item/price/sidebar.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Tax\Block\Item\Price\Renderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Tax/view/frontend/templates/checkout/cart/minicart/totals.phtml b/app/code/Magento/Tax/view/frontend/templates/checkout/cart/minicart/totals.phtml index e172d60ae67a7ada5ce9311c6e271ae234c32618..4ccaa70f926355694facf7421f060448bf95fb54 100644 --- a/app/code/Magento/Tax/view/frontend/templates/checkout/cart/minicart/totals.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/checkout/cart/minicart/totals.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this Magento\Tax\Block\Checkout\Cart\Sidebar\Totals */ ?> diff --git a/app/code/Magento/Tax/view/frontend/templates/checkout/grandtotal.phtml b/app/code/Magento/Tax/view/frontend/templates/checkout/grandtotal.phtml index 82dbc0a2380164cab45fcb747763d6faef2d54a9..c2bd553543d8c9dfe51c7c158531579917644eaa 100644 --- a/app/code/Magento/Tax/view/frontend/templates/checkout/grandtotal.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/checkout/grandtotal.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Tax\Block\Checkout\Grandtotal */ diff --git a/app/code/Magento/Tax/view/frontend/templates/checkout/shipping.phtml b/app/code/Magento/Tax/view/frontend/templates/checkout/shipping.phtml index d288eda19564c2927b9ee5882e0f916cebf277eb..dbceb0cb467139e780ad4f5dd244593b17f57ea1 100644 --- a/app/code/Magento/Tax/view/frontend/templates/checkout/shipping.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/checkout/shipping.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Tax\Block\Checkout\Shipping * @see \Magento\Tax\Block\Checkout\Shipping diff --git a/app/code/Magento/Tax/view/frontend/templates/checkout/shipping/price.phtml b/app/code/Magento/Tax/view/frontend/templates/checkout/shipping/price.phtml index d7f08999b6f1d05db8a0b823e10b71e58ff46107..591ebbacac082536c6511b679f28fa2cdff04d21 100644 --- a/app/code/Magento/Tax/view/frontend/templates/checkout/shipping/price.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/checkout/shipping/price.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Tax\Block\Checkout\Shipping\Price */ ?> diff --git a/app/code/Magento/Tax/view/frontend/templates/checkout/subtotal.phtml b/app/code/Magento/Tax/view/frontend/templates/checkout/subtotal.phtml index 1818d6a5360fc9e1af21aea26ef60974415f4b12..cc16babf635a6548e24bf187ff61e7f312265c90 100644 --- a/app/code/Magento/Tax/view/frontend/templates/checkout/subtotal.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/checkout/subtotal.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Tax\Block\Checkout\Subtotal * @see \Magento\Tax\Block\Checkout\Subtotal diff --git a/app/code/Magento/Tax/view/frontend/templates/checkout/tax.phtml b/app/code/Magento/Tax/view/frontend/templates/checkout/tax.phtml index 93fb746addef5c56ab1ed6f40f786c4e18dbdd48..ae3062eb89d0800e33f53ed84c29bda3a67a4d64 100644 --- a/app/code/Magento/Tax/view/frontend/templates/checkout/tax.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/checkout/tax.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Tax\Block\Checkout\Tax * @see \Magento\Tax\Block\Checkout\Tax diff --git a/app/code/Magento/Tax/view/frontend/templates/email/items/price/row.phtml b/app/code/Magento/Tax/view/frontend/templates/email/items/price/row.phtml index 5b003c46139933f50f231160876d1f4f8f67f86c..3204c0570021e00dcdca15e7c4a443d6d90b11df 100644 --- a/app/code/Magento/Tax/view/frontend/templates/email/items/price/row.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/email/items/price/row.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Tax\Block\Item\Price\Renderer $this */ diff --git a/app/code/Magento/Tax/view/frontend/templates/item/price/row.phtml b/app/code/Magento/Tax/view/frontend/templates/item/price/row.phtml index 14c3c7ba761733ee23f317a2204db8e9ab3f479f..ecb7dfc01f6cc04b35047749865c2c82d5e061a1 100644 --- a/app/code/Magento/Tax/view/frontend/templates/item/price/row.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/item/price/row.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Tax\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Tax/view/frontend/templates/item/price/total_after_discount.phtml b/app/code/Magento/Tax/view/frontend/templates/item/price/total_after_discount.phtml index 59805ea42370e76b0d4ac07c8ec206bb0661564e..59d60a1d7fc74b5d3acd175863dc6a0178b265f8 100644 --- a/app/code/Magento/Tax/view/frontend/templates/item/price/total_after_discount.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/item/price/total_after_discount.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Tax\Block\Item\Price\Renderer $this */ $_item = $this->getItem(); ?> diff --git a/app/code/Magento/Tax/view/frontend/templates/item/price/unit.phtml b/app/code/Magento/Tax/view/frontend/templates/item/price/unit.phtml index 082352620bde0964f4bcb7f7802748da09db4ff9..3194c867b65cc9519312433f3bf9611a7c4a916a 100644 --- a/app/code/Magento/Tax/view/frontend/templates/item/price/unit.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/item/price/unit.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Tax\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Tax/view/frontend/templates/order/tax.phtml b/app/code/Magento/Tax/view/frontend/templates/order/tax.phtml index df9efdbbf3e8b04231c13d97919447d7dad75383..bdb8466a910d69b4cec79ccfa5e085cfb3e10d28 100644 --- a/app/code/Magento/Tax/view/frontend/templates/order/tax.phtml +++ b/app/code/Magento/Tax/view/frontend/templates/order/tax.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php $_order = $this->getOrder(); diff --git a/app/code/Magento/TaxImportExport/Model/Rate/CsvImportHandler.php b/app/code/Magento/TaxImportExport/Model/Rate/CsvImportHandler.php index e75dc06d7ab5f751395d9c7c0f66f18546d0824d..44a392b7484a588a06a1fe1ec226b0390ded1ac5 100644 --- a/app/code/Magento/TaxImportExport/Model/Rate/CsvImportHandler.php +++ b/app/code/Magento/TaxImportExport/Model/Rate/CsvImportHandler.php @@ -142,6 +142,7 @@ class CsvImportHandler * @param array $validFields assoc array of valid file fields * @return array * @throws \Magento\Framework\Model\Exception + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _filterRateData(array $rateRawData, array $invalidFields, array $validFields) { diff --git a/app/code/Magento/TaxImportExport/view/adminhtml/templates/importExport.phtml b/app/code/Magento/TaxImportExport/view/adminhtml/templates/importExport.phtml index d23d064e686cae3be53046b9ad6adcfdc5f26e67..fb5fc443fe42ff4a594b6e78df2c2b1bb2296be0 100644 --- a/app/code/Magento/TaxImportExport/view/adminhtml/templates/importExport.phtml +++ b/app/code/Magento/TaxImportExport/view/adminhtml/templates/importExport.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="import-export-tax-rates"> <?php if (!$this->getIsReadonly()): ?> diff --git a/app/code/Magento/Theme/view/adminhtml/templates/browser/content/files.phtml b/app/code/Magento/Theme/view/adminhtml/templates/browser/content/files.phtml index 77c1f6b1ccbbbbbac3e65c96f40838be8dab0265..088aa900b849c7f8ca6c8ea1d30b4febfb42475c 100644 --- a/app/code/Magento/Theme/view/adminhtml/templates/browser/content/files.phtml +++ b/app/code/Magento/Theme/view/adminhtml/templates/browser/content/files.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Theme/view/base/templates/root.phtml b/app/code/Magento/Theme/view/base/templates/root.phtml index 1abea1421349e8bd5d77d0dc6575f2d36b7ac2cb..df0de42938530989d5751bd6e427832874a77788 100644 --- a/app/code/Magento/Theme/view/base/templates/root.phtml +++ b/app/code/Magento/Theme/view/base/templates/root.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <!doctype html> <html <?php echo $htmlAttributes ?>> diff --git a/app/code/Magento/Theme/view/frontend/templates/callouts/left_col.phtml b/app/code/Magento/Theme/view/frontend/templates/callouts/left_col.phtml index 27aa62051cdb47b1ffb2e7b75d6c7bfbe0418a0e..3d26ab369375985cc441a347c08ff66c23e5bd38 100644 --- a/app/code/Magento/Theme/view/frontend/templates/callouts/left_col.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/callouts/left_col.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="block block-banner"> <div class="block-content"> diff --git a/app/code/Magento/Theme/view/frontend/templates/callouts/right_col.phtml b/app/code/Magento/Theme/view/frontend/templates/callouts/right_col.phtml index 27aa62051cdb47b1ffb2e7b75d6c7bfbe0418a0e..3d26ab369375985cc441a347c08ff66c23e5bd38 100644 --- a/app/code/Magento/Theme/view/frontend/templates/callouts/right_col.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/callouts/right_col.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="block block-banner"> <div class="block-content"> diff --git a/app/code/Magento/Theme/view/frontend/templates/html/block.phtml b/app/code/Magento/Theme/view/frontend/templates/html/block.phtml index c418c25733a731118dc1e0013ffbda5622195f0c..c041525a0a130369d8623bdae712ec07e58b708b 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/block.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/block.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="block <?php echo $this->getBlockCss(); ?>"> <div class="block-title <?php echo $this->getBlockCss(); ?>-title"><strong><?php echo $this->getBlockTitle(); ?></strong></div> diff --git a/app/code/Magento/Theme/view/frontend/templates/html/breadcrumbs.phtml b/app/code/Magento/Theme/view/frontend/templates/html/breadcrumbs.phtml index 26ddadbece5848de25c75c31efdff675adabc5d4..7a1ac1da4eab0bc75ccfcd37783c0588f6808f6e 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/breadcrumbs.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/breadcrumbs.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($crumbs && is_array($crumbs)) : ?> <div class="breadcrumbs"> diff --git a/app/code/Magento/Theme/view/frontend/templates/html/collapsible.phtml b/app/code/Magento/Theme/view/frontend/templates/html/collapsible.phtml index ae267efb8e4ae592d4b055fb9ce743b3f6fd933d..6e3b91aef494301113fff2dc3a8222bef0b28fca 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/collapsible.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/collapsible.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="block <?php echo $this->getBlockCss(); ?>"> diff --git a/app/code/Magento/Theme/view/frontend/templates/html/container.phtml b/app/code/Magento/Theme/view/frontend/templates/html/container.phtml index c83baf666a119f65ad89f4ed9a8180293004fb86..594c738e487010629a32eff2693d1c7e14fd61bd 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/container.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/container.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml(); ?> diff --git a/app/code/Magento/Theme/view/frontend/templates/html/footer.phtml b/app/code/Magento/Theme/view/frontend/templates/html/footer.phtml index 5b08729dcdf87fbb8571195390a4cfdeb019e5fb..f00f79fae167edad4b850e088d5205010283bb8a 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/footer.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/footer.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="footer-container"> <div class="footer"> diff --git a/app/code/Magento/Theme/view/frontend/templates/html/header.phtml b/app/code/Magento/Theme/view/frontend/templates/html/header.phtml index 4b8dc034ebdb7368b2faa3c4e824f877d9450a90..7de615e9174a709063ac916daeaa695f3025d03a 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/header.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/header.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var \Magento\Theme\Block\Html\Header $this */ diff --git a/app/code/Magento/Theme/view/frontend/templates/html/header/logo.phtml b/app/code/Magento/Theme/view/frontend/templates/html/header/logo.phtml index 801ec16dc71824306c01fb9eb24909a64fd81da2..6ae7216aa8fe8b4a4423aa008874bd19a0f991fe 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/header/logo.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/header/logo.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var \Magento\Theme\Block\Html\Header\Logo $this */ diff --git a/app/code/Magento/Theme/view/frontend/templates/html/notices.phtml b/app/code/Magento/Theme/view/frontend/templates/html/notices.phtml index 0d7e5a793a6c8f5f287200f4093d4fa3cac7f5aa..35ccc6db8955e1b8d48330bce4d0f36df7699967 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/notices.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/notices.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Theme/view/frontend/templates/html/pager.phtml b/app/code/Magento/Theme/view/frontend/templates/html/pager.phtml index be498084cb71a43b1051d1a704a73cb873749f11..15855ee05b8d16dd65ce4ebf4c3bf4b029e7f7ae 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/pager.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/pager.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Theme/view/frontend/templates/html/sections.phtml b/app/code/Magento/Theme/view/frontend/templates/html/sections.phtml index 40ac34e1668431ae58fb94eaded19e39d9830ee9..b1a21ccc8dbdda98550801922e847a20f101ce02 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/sections.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/sections.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Theme/view/frontend/templates/html/skiptarget.phtml b/app/code/Magento/Theme/view/frontend/templates/html/skiptarget.phtml index df30bd4609cc7c2179f7e7c6c47f3ebc1be41d05..aa88448729952539cb44a1826b718da2a8e75bbf 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/skiptarget.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/skiptarget.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + $target_id = $this->getTargetId(); ?> <a id="<?php echo $target_id?>" name="<?php echo $target_id?>" tabindex="0"></a> diff --git a/app/code/Magento/Theme/view/frontend/templates/html/title.phtml b/app/code/Magento/Theme/view/frontend/templates/html/title.phtml index 25a435de956d0cef2bdc651327660b8cf02a53d9..cca31459612a243de6537285d448ef55e48a1dff 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/title.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/title.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Theme\Block\Html\Title */ diff --git a/app/code/Magento/Theme/view/frontend/templates/html/topmenu.phtml b/app/code/Magento/Theme/view/frontend/templates/html/topmenu.phtml index 0849bca62a2f4449d0c7cdd9ec9ae4cc7261e28e..c83095a5f44d7d22991ace76b5c818db52de8b71 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/topmenu.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/topmenu.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Theme/view/frontend/templates/js/components.phtml b/app/code/Magento/Theme/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Theme/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Theme/view/frontend/templates/link.phtml b/app/code/Magento/Theme/view/frontend/templates/link.phtml index 3c74b6202fdedc78086e67637cc419225c3af146..589a6db07b76b7383e42d5a1b65ef22a8bcb8501 100644 --- a/app/code/Magento/Theme/view/frontend/templates/link.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/link.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Framework\View\Element\Html\Link */ diff --git a/app/code/Magento/Translation/Model/Inline/Parser.php b/app/code/Magento/Translation/Model/Inline/Parser.php index ae2fb54556b1485f7c378fec07f310ff5bd62c69..7635037657204c828d5049ee9a63ea076fa7fa83 100644 --- a/app/code/Magento/Translation/Model/Inline/Parser.php +++ b/app/code/Magento/Translation/Model/Inline/Parser.php @@ -272,6 +272,7 @@ class Parser implements \Magento\Framework\Translate\Inline\ParserInterface * @param array $matches * @param array $options * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _getAttributeLocation($matches, $options) { @@ -285,6 +286,7 @@ class Parser implements \Magento\Framework\Translate\Inline\ParserInterface * @param array $matches * @param array $options * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _getTagLocation($matches, $options) { diff --git a/app/code/Magento/Translation/Model/Js/DataProvider.php b/app/code/Magento/Translation/Model/Js/DataProvider.php index 3a397628f9159522bbe98705403fcde2e546799d..317dc602a3c7abc55998972f72d9b9f4b8450027 100644 --- a/app/code/Magento/Translation/Model/Js/DataProvider.php +++ b/app/code/Magento/Translation/Model/Js/DataProvider.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Translation\Model\Js; class DataProvider implements DataProviderInterface @@ -12,6 +14,7 @@ class DataProvider implements DataProviderInterface * Get translation data * * @return string[] + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getData() { diff --git a/app/code/Magento/Translation/view/adminhtml/templates/translate_inline.phtml b/app/code/Magento/Translation/view/adminhtml/templates/translate_inline.phtml index 445fb55a0099e9807503f3a801ffd62c1396081c..63cf2df2387826a64180d1416789ae6ef4685330 100644 --- a/app/code/Magento/Translation/view/adminhtml/templates/translate_inline.phtml +++ b/app/code/Magento/Translation/view/adminhtml/templates/translate_inline.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <link rel="stylesheet" type="text/css" href="<?php echo $this->getViewFileUrl('prototype/windows/themes/default.css') ?>"/> diff --git a/app/code/Magento/Translation/view/frontend/templates/translate_inline.phtml b/app/code/Magento/Translation/view/frontend/templates/translate_inline.phtml index e31968a43908b9e89908333772f661e965c20ab5..34712ef99b2831417426e4ad52110027664c161b 100644 --- a/app/code/Magento/Translation/view/frontend/templates/translate_inline.phtml +++ b/app/code/Magento/Translation/view/frontend/templates/translate_inline.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <link rel="stylesheet" type="text/css" href="<?php echo $this->getViewFileUrl('prototype/windows/themes/default.css') ?>"/> diff --git a/app/code/Magento/Ui/Component/AbstractView.php b/app/code/Magento/Ui/Component/AbstractView.php index 308f30bd03ab6e28c35b1bf6c66e56bfe378af6a..e67d0e1ff40ee6b3182c77bebb844c143fa8a84c 100644 --- a/app/code/Magento/Ui/Component/AbstractView.php +++ b/app/code/Magento/Ui/Component/AbstractView.php @@ -19,6 +19,8 @@ use Magento\Ui\DataProvider\Manager; /** * Abstract class AbstractView + * @SuppressWarnings(PHPMD.NumberOfChildren) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractView extends Template implements UiComponentInterface { diff --git a/app/code/Magento/Ui/Component/Filter/Type/Date.php b/app/code/Magento/Ui/Component/Filter/Type/Date.php index 0dc2c3b5f46e9c058d418fa48dd27c8563b5e9d9..fa7a9564032774cf76e01c3078f7a403d7251ed9 100644 --- a/app/code/Magento/Ui/Component/Filter/Type/Date.php +++ b/app/code/Magento/Ui/Component/Filter/Type/Date.php @@ -19,6 +19,7 @@ use Magento\Ui\DataProvider\Manager; /** * Class Date + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Date extends FilterAbstract { @@ -56,6 +57,7 @@ class Date extends FilterAbstract * @param FilterPool $filterPool * @param ResolverInterface $localeResolver * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( TemplateContext $context, diff --git a/app/code/Magento/Ui/Component/Form.php b/app/code/Magento/Ui/Component/Form.php index 30887037e5fcce8d6c523283e9ef01f88655fd25..4e4435b6773638f14a510253edf655d196508f6a 100644 --- a/app/code/Magento/Ui/Component/Form.php +++ b/app/code/Magento/Ui/Component/Form.php @@ -19,6 +19,7 @@ use Magento\Ui\DataProvider\Manager; /** * Class Form + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Form extends AbstractView { @@ -74,6 +75,7 @@ class Form extends AbstractView * @param ActionPool $actionPool * @param ButtonProviderFactory $buttonProviderFactory * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( TemplateContext $context, @@ -210,6 +212,7 @@ class Form extends AbstractView * @param array $itemA * @param array $itemB * @return int + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function sortButtons(array $itemA, array $itemB) { diff --git a/app/code/Magento/Ui/Component/Form/Element/AbstractFormElement.php b/app/code/Magento/Ui/Component/Form/Element/AbstractFormElement.php index e07e2b5d6a3d8fd827b50afa766b707c2ba91fc8..e536143ab6b4a719b6e8582159d748eb1bc8d182 100644 --- a/app/code/Magento/Ui/Component/Form/Element/AbstractFormElement.php +++ b/app/code/Magento/Ui/Component/Form/Element/AbstractFormElement.php @@ -38,6 +38,7 @@ abstract class AbstractFormElement extends AbstractView implements ElementInterf /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsReadonly() { diff --git a/app/code/Magento/Ui/Component/Form/Element/ElementInterface.php b/app/code/Magento/Ui/Component/Form/Element/ElementInterface.php index f0ffa83010988c9866762214f7ba9d4a61e44773..f6cd906ed59ec2b3113b6513f3d33e4bd88d2755 100644 --- a/app/code/Magento/Ui/Component/Form/Element/ElementInterface.php +++ b/app/code/Magento/Ui/Component/Form/Element/ElementInterface.php @@ -24,6 +24,7 @@ interface ElementInterface extends UiComponentInterface /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsReadonly(); diff --git a/app/code/Magento/Ui/Component/Form/Element/Radio.php b/app/code/Magento/Ui/Component/Form/Element/Radio.php index bc856928cacc366585fb7757479e4cd3aa78ead3..1737d460db14218d51e0edad5542b86c716a4723 100644 --- a/app/code/Magento/Ui/Component/Form/Element/Radio.php +++ b/app/code/Magento/Ui/Component/Form/Element/Radio.php @@ -12,6 +12,7 @@ class Radio extends AbstractFormElement { /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getChecked() { diff --git a/app/code/Magento/Ui/Component/Form/Element/Select.php b/app/code/Magento/Ui/Component/Form/Element/Select.php index 6432e055a515e60d1f6f07df246f898d058d2a8d..59a366d3e4b2aac3a270c2e41cefa9e2e4e1e1f1 100644 --- a/app/code/Magento/Ui/Component/Form/Element/Select.php +++ b/app/code/Magento/Ui/Component/Form/Element/Select.php @@ -15,6 +15,7 @@ class Select extends AbstractFormElement * * @param string $optionValue * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsSelected($optionValue) { diff --git a/app/code/Magento/Ui/Component/Form/Fieldset.php b/app/code/Magento/Ui/Component/Form/Fieldset.php index d1372885f12efe38610114f84311fcb3548904b6..03fd8f62d6e847ba154c2390de4cde80732dcca0 100644 --- a/app/code/Magento/Ui/Component/Form/Fieldset.php +++ b/app/code/Magento/Ui/Component/Form/Fieldset.php @@ -29,6 +29,7 @@ class Fieldset extends AbstractView /** * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsCollapsible() { diff --git a/app/code/Magento/Ui/Component/Layout/AbstractStructure.php b/app/code/Magento/Ui/Component/Layout/AbstractStructure.php index 5d71edf9bba6f30d212e0145499a811bdda42ae7..8fdd8616b7c8b2b22eb3b2b390e06d3d534ed9b8 100644 --- a/app/code/Magento/Ui/Component/Layout/AbstractStructure.php +++ b/app/code/Magento/Ui/Component/Layout/AbstractStructure.php @@ -20,6 +20,7 @@ use Magento\Ui\DataProvider\Metadata; /** * Class AbstractStructure + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class AbstractStructure extends AbstractView { @@ -89,6 +90,7 @@ class AbstractStructure extends AbstractView /** * @inheritdoc + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function prepare() { @@ -204,6 +206,7 @@ class AbstractStructure extends AbstractView /** * @param array $dataSourceConfig * @return void + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function processDataSource(array $dataSourceConfig) { @@ -442,6 +445,7 @@ class AbstractStructure extends AbstractView * @param string $dataScope * @param array $element * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function addElementToCollection(array & $collection, $elementName, $dataScope, array $element) { @@ -540,6 +544,7 @@ class AbstractStructure extends AbstractView * @param array $one * @param array $two * @return int + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function sortChildren(array $one, array $two) { diff --git a/app/code/Magento/Ui/Component/Listing.php b/app/code/Magento/Ui/Component/Listing.php index cbef1135d420ccec16ad65d44f7bc1fdcbe0aea3..efd05db22a826931acf8edfae37ce4f25c6cb533 100644 --- a/app/code/Magento/Ui/Component/Listing.php +++ b/app/code/Magento/Ui/Component/Listing.php @@ -18,6 +18,7 @@ use Magento\Ui\DataProvider\Manager; /** * Class Listing + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Listing extends AbstractView { @@ -59,6 +60,7 @@ class Listing extends AbstractView * @param ActionPool $actionPool * @param RowPool $dataProviderRowPool * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( TemplateContext $context, diff --git a/app/code/Magento/Ui/Controller/Adminhtml/Form/Fieldset.php b/app/code/Magento/Ui/Controller/Adminhtml/Form/Fieldset.php index fc90f0840bdd762f78520955b9494a004133a5fa..9c556c7191cdf6d854d146abea66c7c9586e7126 100644 --- a/app/code/Magento/Ui/Controller/Adminhtml/Form/Fieldset.php +++ b/app/code/Magento/Ui/Controller/Adminhtml/Form/Fieldset.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Ui\Controller\Adminhtml\Form; /** diff --git a/app/code/Magento/Ui/DataProvider/Config/Converter.php b/app/code/Magento/Ui/DataProvider/Config/Converter.php index 9de11534752a69d14fa7d845bcde730d8f615a09..6402821d585af92a6283787813f6e74fbdfcc860 100644 --- a/app/code/Magento/Ui/DataProvider/Config/Converter.php +++ b/app/code/Magento/Ui/DataProvider/Config/Converter.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Ui\DataProvider\Config; use Magento\Framework\Config\ConverterInterface; @@ -48,6 +50,7 @@ class Converter implements ConverterInterface * * @param \DOMNode $source * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function toArray(\DOMNode $source) { @@ -100,6 +103,8 @@ class Converter implements ConverterInterface * * @param \DOMDocument $source * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function convert($source) { diff --git a/app/code/Magento/Ui/DataProvider/Manager.php b/app/code/Magento/Ui/DataProvider/Manager.php index acc60ea7bf9e5a702fd11b24dcc31204f1838068..c2f2379ff77ba8ded751261fe6754a1c1241067c 100644 --- a/app/code/Magento/Ui/DataProvider/Manager.php +++ b/app/code/Magento/Ui/DataProvider/Manager.php @@ -96,6 +96,7 @@ class Manager * @param string $dataSource * @param array $filters * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getData($dataSource, array $filters = []) { diff --git a/app/code/Magento/Ui/DataProvider/Metadata.php b/app/code/Magento/Ui/DataProvider/Metadata.php index 949fd14d7753fedce1ce20d6a3223725059d9f0e..3606699e59b90707cbec8dcdc2a92cd16126f1f1 100644 --- a/app/code/Magento/Ui/DataProvider/Metadata.php +++ b/app/code/Magento/Ui/DataProvider/Metadata.php @@ -247,6 +247,9 @@ class Metadata implements \Iterator, \ArrayAccess * @param string $name * @param array $field * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function prepare($name, array & $field) { diff --git a/app/code/Magento/Ui/view/base/templates/control/button/default.phtml b/app/code/Magento/Ui/view/base/templates/control/button/default.phtml index c5cb6598445dade2ade795ccde7bb879fde8aef3..98e1435a334dddd8e78471dbc05eb97bbaa70473 100644 --- a/app/code/Magento/Ui/view/base/templates/control/button/default.phtml +++ b/app/code/Magento/Ui/view/base/templates/control/button/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** diff --git a/app/code/Magento/Ui/view/base/templates/filter_pool/active.phtml b/app/code/Magento/Ui/view/base/templates/filter_pool/active.phtml index 34599608b9b4130991d784e6b77a79a70e4c8361..021ede69ad571d74c2d80cbfbf981be0b0965287 100644 --- a/app/code/Magento/Ui/view/base/templates/filter_pool/active.phtml +++ b/app/code/Magento/Ui/view/base/templates/filter_pool/active.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var \Magento\Ui\Component\Filter $this */ diff --git a/app/code/Magento/Ui/view/base/templates/form/fieldset/default.phtml b/app/code/Magento/Ui/view/base/templates/form/fieldset/default.phtml index 35792fb71fe68f2720fbf99e9ffcc2f378f4bb51..95a5eab05ec51076356c92a6caf1eb0b9bbd7e6f 100644 --- a/app/code/Magento/Ui/view/base/templates/form/fieldset/default.phtml +++ b/app/code/Magento/Ui/view/base/templates/form/fieldset/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var \Magento\Ui\Component\Form\Fieldset $this */ diff --git a/app/code/Magento/Ui/view/base/templates/layout/group/default.phtml b/app/code/Magento/Ui/view/base/templates/layout/group/default.phtml index cf31ce434773e930563352000ef53ca63ad5cbe9..f1a8897d5849792a960cb56d8e8106ec3041c9a3 100644 --- a/app/code/Magento/Ui/view/base/templates/layout/group/default.phtml +++ b/app/code/Magento/Ui/view/base/templates/layout/group/default.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var \Magento\Ui\Component\Layout\Group $this */ diff --git a/app/code/Magento/Ups/Helper/Config.php b/app/code/Magento/Ups/Helper/Config.php index 465678c76af2d94aa7d0080fb5e4812505d3ebe2..2fd5bf7aa04624729e1cb819ac170188418bab76 100644 --- a/app/code/Magento/Ups/Helper/Config.php +++ b/app/code/Magento/Ups/Helper/Config.php @@ -37,6 +37,7 @@ class Config * Get configuration data of carrier * * @return array + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function getCodes() { diff --git a/app/code/Magento/Ups/Model/Carrier.php b/app/code/Magento/Ups/Model/Carrier.php index 6cbca74e7d3ed61203a2fc730ba59e8e5517e3e1..e88b68ea433cafc08dba11c7c4dbec7547c6aaf8 100644 --- a/app/code/Magento/Ups/Model/Carrier.php +++ b/app/code/Magento/Ups/Model/Carrier.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Ups\Model; use Magento\Quote\Model\Quote\Address\RateRequest; @@ -14,6 +17,8 @@ use Magento\Ups\Helper\Config; /** * UPS shipping implementation + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Carrier extends AbstractCarrierOnline implements CarrierInterface { @@ -201,6 +206,9 @@ class Carrier extends AbstractCarrierOnline implements CarrierInterface * * @param RateRequest $request * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function setRequest(RateRequest $request) { @@ -492,6 +500,7 @@ class Carrier extends AbstractCarrierOnline implements CarrierInterface * * @param string $response * @return Result + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _parseCgiResponse($response) { @@ -561,6 +570,9 @@ class Carrier extends AbstractCarrierOnline implements CarrierInterface * Get xml rates * * @return Result + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _getXmlQuotes() { @@ -748,6 +760,7 @@ XMLRequest; * * @param mixed $xmlResponse * @return Result + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _parseXmlResponse($xmlResponse) { @@ -973,6 +986,8 @@ XMLAuth; * @param string $trackingValue * @param string $xmlResponse * @return null + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _parseXmlTrackingResponse($trackingValue, $xmlResponse) { @@ -1134,6 +1149,9 @@ XMLAuth; * * @param \Magento\Framework\Object $request * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _formShipmentRequest(\Magento\Framework\Object $request) { @@ -1506,6 +1524,7 @@ XMLAuth; * * @param \Magento\Framework\Object|null $params * @return array|bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getContainerTypes(\Magento\Framework\Object $params = null) { diff --git a/app/code/Magento/Ups/Model/Config/Source/OriginShipment.php b/app/code/Magento/Ups/Model/Config/Source/OriginShipment.php index 40fe4c853b4ecffab081c9f9b2852660b495ddbe..baf8df8773611cd7dddfcbe42b90c34e34c45dc9 100644 --- a/app/code/Magento/Ups/Model/Config/Source/OriginShipment.php +++ b/app/code/Magento/Ups/Model/Config/Source/OriginShipment.php @@ -19,6 +19,7 @@ class OriginShipment extends \Magento\Ups\Model\Config\Source\Generic /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function toOptionArray() { diff --git a/app/code/Magento/Ups/Model/Config/Source/Unitofmeasure.php b/app/code/Magento/Ups/Model/Config/Source/Unitofmeasure.php index bb297694431a66e8c07aaf61bc8a497104738de3..7a6f75395a9c6a432860697eb47ba3d19e3416aa 100644 --- a/app/code/Magento/Ups/Model/Config/Source/Unitofmeasure.php +++ b/app/code/Magento/Ups/Model/Config/Source/Unitofmeasure.php @@ -19,6 +19,7 @@ class Unitofmeasure extends \Magento\Ups\Model\Config\Source\Generic /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function toOptionArray() { diff --git a/app/code/Magento/Ups/view/adminhtml/templates/system/shipping/carrier_config.phtml b/app/code/Magento/Ups/view/adminhtml/templates/system/shipping/carrier_config.phtml index 873568fa9971da787e0b92ab381fadaccbeec461..07424f23d1dd1060d4aef81c19421d1d200c85cf 100644 --- a/app/code/Magento/Ups/view/adminhtml/templates/system/shipping/carrier_config.phtml +++ b/app/code/Magento/Ups/view/adminhtml/templates/system/shipping/carrier_config.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $upsModel \Magento\Ups\Helper\Config */ /** @var $this \Magento\Ups\Block\Backend\System\CarrierConfig */ $upsCarrierConfig = $this->getCarrierConfig(); diff --git a/app/code/Magento/UrlRewrite/Block/Catalog/Product/Grid.php b/app/code/Magento/UrlRewrite/Block/Catalog/Product/Grid.php index b3a01003252a2ccea5ac8943ebf15d706a105dd4..f300660f42f601a82e76d082777c03ead01a83e1 100644 --- a/app/code/Magento/UrlRewrite/Block/Catalog/Product/Grid.php +++ b/app/code/Magento/UrlRewrite/Block/Catalog/Product/Grid.php @@ -9,6 +9,7 @@ namespace Magento\UrlRewrite\Block\Catalog\Product; * Products grid for URL rewrites editing * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Catalog\Block\Adminhtml\Product\Grid { diff --git a/app/code/Magento/UrlRewrite/Block/Cms/Page/Grid.php b/app/code/Magento/UrlRewrite/Block/Cms/Page/Grid.php index e755954ced4b4cd0368dd7cbf07ac8416c4ad23a..04b9b9cb51085a9703b332f9bebb907f9bddd44e 100644 --- a/app/code/Magento/UrlRewrite/Block/Cms/Page/Grid.php +++ b/app/code/Magento/UrlRewrite/Block/Cms/Page/Grid.php @@ -9,6 +9,7 @@ namespace Magento\UrlRewrite\Block\Cms\Page; * CMS pages grid for URL rewrites * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.DepthOfInheritance) */ class Grid extends \Magento\Cms\Block\Adminhtml\Page\Grid { diff --git a/app/code/Magento/UrlRewrite/view/adminhtml/templates/categories.phtml b/app/code/Magento/UrlRewrite/view/adminhtml/templates/categories.phtml index 526c4d75b3035728efd2c13b83233076775cb513..edb2043180e3080cb6fa12c1f63251a023196704 100644 --- a/app/code/Magento/UrlRewrite/view/adminhtml/templates/categories.phtml +++ b/app/code/Magento/UrlRewrite/view/adminhtml/templates/categories.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\UrlRewrite\Block\Catalog\Category\Tree */ ?> <fieldset class="fieldset" data-ui-id="category-selector"> diff --git a/app/code/Magento/UrlRewrite/view/adminhtml/templates/edit.phtml b/app/code/Magento/UrlRewrite/view/adminhtml/templates/edit.phtml index e640b690d9efce8edbf61fc94f2ee2df464a06a5..dfa66b948b3979d63db0cd0c1b192e065065da7e 100644 --- a/app/code/Magento/UrlRewrite/view/adminhtml/templates/edit.phtml +++ b/app/code/Magento/UrlRewrite/view/adminhtml/templates/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** * @var $this \Magento\UrlRewrite\Block\Edit */ diff --git a/app/code/Magento/UrlRewrite/view/adminhtml/templates/selector.phtml b/app/code/Magento/UrlRewrite/view/adminhtml/templates/selector.phtml index dd7e123bd02c0a0be88c77de770da726049ae0ef..fa3c88c6333a5c1a009d1bf4dc8ab7045178be1b 100644 --- a/app/code/Magento/UrlRewrite/view/adminhtml/templates/selector.phtml +++ b/app/code/Magento/UrlRewrite/view/adminhtml/templates/selector.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /** @var $this \Magento\UrlRewrite\Block\Selector */ ?> <div class="form-inline"> diff --git a/app/code/Magento/User/Block/User/Edit/Tab/Main.php b/app/code/Magento/User/Block/User/Edit/Tab/Main.php index d84ca166cff17c1b757205cdfb478383c023e0c7..5eec5e84e013e6eca7cda23a2ae95bc87d9c612e 100644 --- a/app/code/Magento/User/Block/User/Edit/Tab/Main.php +++ b/app/code/Magento/User/Block/User/Edit/Tab/Main.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\User\Block\User\Edit\Tab; /** diff --git a/app/code/Magento/User/Controller/Adminhtml/User/Save.php b/app/code/Magento/User/Controller/Adminhtml/User/Save.php index e080bedeba812fad7781c4c7ba5587f76513166a..fcf6d4b54ea99a08df16479b516c89c713c59aa8 100644 --- a/app/code/Magento/User/Controller/Adminhtml/User/Save.php +++ b/app/code/Magento/User/Controller/Adminhtml/User/Save.php @@ -10,6 +10,8 @@ class Save extends \Magento\User\Controller\Adminhtml\User { /** * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/User/Model/Resource/User.php b/app/code/Magento/User/Model/Resource/User.php index 1012a360aa651444e07c5d824605bdca73586442..a25b0836d6973fa1935a3cb18649be62e507104e 100644 --- a/app/code/Magento/User/Model/Resource/User.php +++ b/app/code/Magento/User/Model/Resource/User.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\User\Model\Resource; use Magento\Authorization\Model\Acl\Role\Group as RoleGroup; @@ -12,6 +15,7 @@ use Magento\User\Model\User as ModelUser; /** * ACL user resource + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class User extends \Magento\Framework\Model\Resource\Db\AbstractDb { diff --git a/app/code/Magento/User/view/adminhtml/templates/admin/forgotpassword.phtml b/app/code/Magento/User/view/adminhtml/templates/admin/forgotpassword.phtml index d173a29ffa272f1db9603366241568b38ecda5d3..5657758c199dcf23d740cc4ce27ca908822cd5f0 100644 --- a/app/code/Magento/User/view/adminhtml/templates/admin/forgotpassword.phtml +++ b/app/code/Magento/User/view/adminhtml/templates/admin/forgotpassword.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <!doctype html> <html lang="en"> diff --git a/app/code/Magento/User/view/adminhtml/templates/admin/forgotpassword_url.phtml b/app/code/Magento/User/view/adminhtml/templates/admin/forgotpassword_url.phtml index 4fd332836f25ce3544cbd5f5d14b5ecd597a65fd..a7251b5b6538ab6f082af98a9838b590b6e84859 100644 --- a/app/code/Magento/User/view/adminhtml/templates/admin/forgotpassword_url.phtml +++ b/app/code/Magento/User/view/adminhtml/templates/admin/forgotpassword_url.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="links"> <a class="action-forgotpassword" href="<?php echo $this->helper('Magento\Backend\Helper\Data')->getUrl('adminhtml/auth/forgotpassword', ['_nosecret' => true])?>"><?php echo __('Forgot your password?') ?></a> diff --git a/app/code/Magento/User/view/adminhtml/templates/admin/resetforgottenpassword.phtml b/app/code/Magento/User/view/adminhtml/templates/admin/resetforgottenpassword.phtml index 48405e15091fc975051fb898a9cded2792b0cce0..d2c97581ce3394e6c5d579b43d1701433aeab4eb 100644 --- a/app/code/Magento/User/view/adminhtml/templates/admin/resetforgottenpassword.phtml +++ b/app/code/Magento/User/view/adminhtml/templates/admin/resetforgottenpassword.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html lang="en"> diff --git a/app/code/Magento/User/view/adminhtml/templates/role/edit.phtml b/app/code/Magento/User/view/adminhtml/templates/role/edit.phtml index 7c8f082bad99d1aefe0517990249914863fb0dad..854c85003794a3c5c75414da0edea03df5b75a34 100644 --- a/app/code/Magento/User/view/adminhtml/templates/role/edit.phtml +++ b/app/code/Magento/User/view/adminhtml/templates/role/edit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/User/view/adminhtml/templates/role/users_grid_js.phtml b/app/code/Magento/User/view/adminhtml/templates/role/users_grid_js.phtml index 57b73dff04c153cf201ff8b2f19e6301fcafe67c..60026b71834c242c8c4e5b4d1cbb0dc90f0b2143 100644 --- a/app/code/Magento/User/view/adminhtml/templates/role/users_grid_js.phtml +++ b/app/code/Magento/User/view/adminhtml/templates/role/users_grid_js.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <script> require([ diff --git a/app/code/Magento/User/view/adminhtml/templates/user/roles_grid_js.phtml b/app/code/Magento/User/view/adminhtml/templates/user/roles_grid_js.phtml index 48adde0625c70425fc2586728c153ba7ab710c8d..3dc25bde09e9ada1563698d1dfae9386c9b2bdf7 100644 --- a/app/code/Magento/User/view/adminhtml/templates/user/roles_grid_js.phtml +++ b/app/code/Magento/User/view/adminhtml/templates/user/roles_grid_js.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <script> require([ diff --git a/app/code/Magento/Usps/Block/Rma/Adminhtml/Rma/Edit/Tab/General/Shipping/Packaging/Plugin.php b/app/code/Magento/Usps/Block/Rma/Adminhtml/Rma/Edit/Tab/General/Shipping/Packaging/Plugin.php index 24797911abd7287062c2a173e39a377a0ae3c35b..cc5bca51fa49bcf8247adb39aaba56c694bd877f 100644 --- a/app/code/Magento/Usps/Block/Rma/Adminhtml/Rma/Edit/Tab/General/Shipping/Packaging/Plugin.php +++ b/app/code/Magento/Usps/Block/Rma/Adminhtml/Rma/Edit/Tab/General/Shipping/Packaging/Plugin.php @@ -46,6 +46,7 @@ class Plugin * @param \Magento\Framework\Object $subject $subject * @param bool $result * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterIsGirthAllowed(\Magento\Framework\Object $subject, $result) { @@ -58,6 +59,7 @@ class Plugin * @param \Magento\Framework\Object $subject * @param \Closure $proceed * @return array + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aroundCheckSizeAndGirthParameter(\Magento\Framework\Object $subject, \Closure $proceed) { diff --git a/app/code/Magento/Usps/Model/Carrier.php b/app/code/Magento/Usps/Model/Carrier.php index b3de0074d630840eaefc5397509293d4a92df866..efccb26521a6358956bfc189fe02a4039dc5686a 100644 --- a/app/code/Magento/Usps/Model/Carrier.php +++ b/app/code/Magento/Usps/Model/Carrier.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Usps\Model; use Magento\Shipping\Helper\Carrier as CarrierHelper; @@ -11,6 +14,8 @@ use Magento\Shipping\Model\Rate\Result; /** * USPS shipping + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\Carrier\CarrierInterface { @@ -195,6 +200,9 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * * @param \Magento\Quote\Model\Quote\Address\RateRequest $request * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function setRequest(\Magento\Quote\Model\Quote\Address\RateRequest $request) { @@ -362,6 +370,9 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * * @link http://www.usps.com/webtools/htm/Rate-Calculators-v2-3.htm * @return Result + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _getXmlQuotes() { @@ -484,6 +495,8 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * @param string $response * @return Result * @link http://www.usps.com/webtools/htm/Rate-Calculators-v2-3.htm + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _parseXmlResponse($response) { @@ -584,6 +597,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * @param string $type * @param string $code * @return array|false + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getCode($type, $code = '') { @@ -1019,6 +1033,8 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * @param string $trackingvalue * @param string $response * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _parseXmlTrackingResponse($trackingvalue, $response) { @@ -1122,6 +1138,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * * @param string $countryId * @return string|false + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _getCountryName($countryId) { @@ -1450,6 +1467,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * @param string $serviceType * @return string * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _formUsSignatureConfirmationShipmentRequest(\Magento\Framework\Object $request, $serviceType) { @@ -1549,6 +1567,9 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * * @param \Magento\Framework\Object $request * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _formIntlShipmentRequest(\Magento\Framework\Object $request) { @@ -1800,6 +1821,7 @@ class Carrier extends AbstractCarrierOnline implements \Magento\Shipping\Model\C * * @param \Magento\Framework\Object $request * @return \Magento\Framework\Object + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _doShipmentRequest(\Magento\Framework\Object $request) { diff --git a/app/code/Magento/Usps/Model/Source/Method.php b/app/code/Magento/Usps/Model/Source/Method.php index f161f0a33b7d63d79f03fac76742ec8f340d6337..ad2edd94fc768efc35cdd7f7ba1d67fb32e86ea7 100644 --- a/app/code/Magento/Usps/Model/Source/Method.php +++ b/app/code/Magento/Usps/Model/Source/Method.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Usps\Model\Source; /** diff --git a/app/code/Magento/Webapi/view/adminhtml/templates/integration/activate/permissions/tab/webapi.phtml b/app/code/Magento/Webapi/view/adminhtml/templates/integration/activate/permissions/tab/webapi.phtml index 35903869d87e8b3f7a14e9f4f3073678e10560be..4513220c07caee8f56dc1abf1f442413e5b3d3ae 100644 --- a/app/code/Magento/Webapi/view/adminhtml/templates/integration/activate/permissions/tab/webapi.phtml +++ b/app/code/Magento/Webapi/view/adminhtml/templates/integration/activate/permissions/tab/webapi.phtml @@ -7,6 +7,9 @@ * * @var \Magento\Webapi\Block\Adminhtml\Integration\Activate\Permissions\Tab\Webapi $this */ + +// @codingStandardsIgnoreFile + ?> <fieldset class="fieldset form-inline entry-edit"> <?php if ($this->isTreeEmpty()): ?> diff --git a/app/code/Magento/Webapi/view/adminhtml/templates/resourcetree.phtml b/app/code/Magento/Webapi/view/adminhtml/templates/resourcetree.phtml index 71d9249d62d461d637123395b7502bddfc3c555c..006bfc06806f773eb5a86815f19e666252cc013d 100644 --- a/app/code/Magento/Webapi/view/adminhtml/templates/resourcetree.phtml +++ b/app/code/Magento/Webapi/view/adminhtml/templates/resourcetree.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Weee/Block/Renderer/Weee/Tax.php b/app/code/Magento/Weee/Block/Renderer/Weee/Tax.php index 5dc9086d1645d6cc16b365c6d9cb6cf1b14cb186..43995cb9ff49d59433fe178840eb0bcd9b3da5ac 100644 --- a/app/code/Magento/Weee/Block/Renderer/Weee/Tax.php +++ b/app/code/Magento/Weee/Block/Renderer/Weee/Tax.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Weee\Block\Renderer\Weee; use Magento\Framework\Data\Form\Element\AbstractElement; diff --git a/app/code/Magento/Weee/Helper/Data.php b/app/code/Magento/Weee/Helper/Data.php index d03520c87a2fda78d3537027afd31d0de5fd741d..aa6ac7d19875fd67ac0243e09a2815835a37ca7d 100644 --- a/app/code/Magento/Weee/Helper/Data.php +++ b/app/code/Magento/Weee/Helper/Data.php @@ -210,6 +210,7 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper * @param string $zone * @param Store|int|string $store * @return bool|int + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function typeOfDisplay( $compareTo = null, diff --git a/app/code/Magento/Weee/Model/Attribute/Backend/Weee/Tax.php b/app/code/Magento/Weee/Model/Attribute/Backend/Weee/Tax.php index c1cffc5c3cd45ed24df0888b364c5d35919df5e1..284593f0d3cfd2d57be62fd4803def7210fa592f 100644 --- a/app/code/Magento/Weee/Model/Attribute/Backend/Weee/Tax.php +++ b/app/code/Magento/Weee/Model/Attribute/Backend/Weee/Tax.php @@ -92,6 +92,7 @@ class Tax extends \Magento\Catalog\Model\Product\Attribute\Backend\Price * * @param \Magento\Catalog\Model\Product $object * @return $this + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function afterLoad($object) { diff --git a/app/code/Magento/Weee/Model/Observer.php b/app/code/Magento/Weee/Model/Observer.php index 3269a875f78c1d4a4c1a910af82d778aeaafb627..daca840e903b7e2e8c0f11390a84c259a66ff837 100644 --- a/app/code/Magento/Weee/Model/Observer.php +++ b/app/code/Magento/Weee/Model/Observer.php @@ -5,6 +5,9 @@ */ namespace Magento\Weee\Model; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Observer extends \Magento\Framework\Model\AbstractModel { /** @@ -45,6 +48,7 @@ class Observer extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Weee/Model/Tax.php b/app/code/Magento/Weee/Model/Tax.php index 68951499429c89d58abfdfbd01cb97b006a0236d..7eab12df0722dbead3edf7667a66d52aab10a2c8 100644 --- a/app/code/Magento/Weee/Model/Tax.php +++ b/app/code/Magento/Weee/Model/Tax.php @@ -11,6 +11,9 @@ use Magento\Store\Model\Website; use Magento\Tax\Model\Calculation; use Magento\Customer\Api\AccountManagementInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Tax extends \Magento\Framework\Model\AbstractModel { /** @@ -96,6 +99,7 @@ class Tax extends \Magento\Framework\Model\AbstractModel * @param PriceCurrencyInterface $priceCurrency * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -197,6 +201,8 @@ class Tax extends \Magento\Framework\Model\AbstractModel * @param Website $website * @param bool $calculateTax * @return \Magento\Framework\Object[] + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getProductWeeeAttributes( $product, diff --git a/app/code/Magento/Weee/Model/Total/Creditmemo/Weee.php b/app/code/Magento/Weee/Model/Total/Creditmemo/Weee.php index 0c82ec0a5ee1487b4f625d0a74abf70fa339cea3..4107c5d55a44174261641944f63fb4e983910f82 100644 --- a/app/code/Magento/Weee/Model/Total/Creditmemo/Weee.php +++ b/app/code/Magento/Weee/Model/Total/Creditmemo/Weee.php @@ -38,6 +38,10 @@ class Weee extends \Magento\Sales\Model\Order\Creditmemo\Total\AbstractTotal * * @param Creditmemo $creditmemo * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function collect(Creditmemo $creditmemo) { diff --git a/app/code/Magento/Weee/Model/Total/Invoice/Weee.php b/app/code/Magento/Weee/Model/Total/Invoice/Weee.php index a13308b72f533f68bcaf7de14864346559f466c2..b89362baf000fa84ca1d9aa4d89441e4a5f3925d 100644 --- a/app/code/Magento/Weee/Model/Total/Invoice/Weee.php +++ b/app/code/Magento/Weee/Model/Total/Invoice/Weee.php @@ -36,6 +36,9 @@ class Weee extends \Magento\Sales\Model\Order\Invoice\Total\AbstractTotal * * @param \Magento\Sales\Model\Order\Invoice $invoice * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function collect(\Magento\Sales\Model\Order\Invoice $invoice) { diff --git a/app/code/Magento/Weee/Model/Total/Quote/Weee.php b/app/code/Magento/Weee/Model/Total/Quote/Weee.php index 174d2d96f8cab9e583694c12fc4b03f131dd9734..3ba498c70c4f700f5d6830f1b65b702ff74c45ef 100644 --- a/app/code/Magento/Weee/Model/Total/Quote/Weee.php +++ b/app/code/Magento/Weee/Model/Total/Quote/Weee.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Weee\Model\Total\Quote; use Magento\Framework\Pricing\PriceCurrencyInterface; @@ -126,6 +129,8 @@ class Weee extends AbstractTotal * @param \Magento\Quote\Model\Quote\Address $address * @param \Magento\Quote\Model\Quote\Item\AbstractItem $item * @return void|$this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _process(\Magento\Quote\Model\Quote\Address $address, $item) { @@ -311,6 +316,7 @@ class Weee extends AbstractTotal * * @param \Magento\Quote\Model\Quote\Address $address * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function fetch(\Magento\Quote\Model\Quote\Address $address) { diff --git a/app/code/Magento/Weee/Model/Total/Quote/WeeeTax.php b/app/code/Magento/Weee/Model/Total/Quote/WeeeTax.php index 1c801fb2323f4c35a65b224177004308da2d14de..9008fda31b5233cc0eeda0f700c79d8f663b1ebe 100644 --- a/app/code/Magento/Weee/Model/Total/Quote/WeeeTax.php +++ b/app/code/Magento/Weee/Model/Total/Quote/WeeeTax.php @@ -16,6 +16,8 @@ class WeeeTax extends Weee * * @param \Magento\Quote\Model\Quote\Address $address * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function collect(\Magento\Quote\Model\Quote\Address $address) { diff --git a/app/code/Magento/Weee/view/adminhtml/templates/items/price/row.phtml b/app/code/Magento/Weee/view/adminhtml/templates/items/price/row.phtml index 56e96894609f8121c8988e66eefba4a99faa664a..460393161bd6ce536cc4affcd971e4b740e82fad 100644 --- a/app/code/Magento/Weee/view/adminhtml/templates/items/price/row.phtml +++ b/app/code/Magento/Weee/view/adminhtml/templates/items/price/row.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Weee\Block\Adminhtml\Items\Price\Renderer $this */ diff --git a/app/code/Magento/Weee/view/adminhtml/templates/items/price/total.phtml b/app/code/Magento/Weee/view/adminhtml/templates/items/price/total.phtml index fc5037c7b1a72353788fce76952fd3ed74a30c7a..a54d234656ceb55fbdaf607ecd60b03b20327a1b 100644 --- a/app/code/Magento/Weee/view/adminhtml/templates/items/price/total.phtml +++ b/app/code/Magento/Weee/view/adminhtml/templates/items/price/total.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Weee\Block\Adminhtml\Items\Price\Renderer $this */ diff --git a/app/code/Magento/Weee/view/adminhtml/templates/items/price/unit.phtml b/app/code/Magento/Weee/view/adminhtml/templates/items/price/unit.phtml index cb9928b5f2c264f861fdb2b7274232da316b210a..533d874ba3dd6634772ab04ffe2f53d752e79a50 100644 --- a/app/code/Magento/Weee/view/adminhtml/templates/items/price/unit.phtml +++ b/app/code/Magento/Weee/view/adminhtml/templates/items/price/unit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Weee\Block\Adminhtml\Items\Price\Renderer $this */ diff --git a/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/row.phtml b/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/row.phtml index 2bc26762b8fabfc830c3bd0bf90ed7fbc21d8f46..ca8bfceef26b6ea9a47b95769c49dfe19078a00d 100644 --- a/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/row.phtml +++ b/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/row.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Weee\Block\Item\Price\Renderer */ diff --git a/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/total.phtml b/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/total.phtml index 57827f4d5489bd330d30da3c67548963630a69db..35127cbf95f04b2f713fc4bc91284301d3642a5d 100644 --- a/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/total.phtml +++ b/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/total.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Weee\Block\Item\Price\Renderer $this */ diff --git a/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/unit.phtml b/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/unit.phtml index 08a1a7f7887fb31e54509a7de53e1d74d0c41362..ebff20c3f4e2c36ed2689dc871efb40e7479557e 100644 --- a/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/unit.phtml +++ b/app/code/Magento/Weee/view/adminhtml/templates/order/create/items/price/unit.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Weee\Block\Item\Price\Renderer $this */ diff --git a/app/code/Magento/Weee/view/adminhtml/templates/renderer/tax.phtml b/app/code/Magento/Weee/view/adminhtml/templates/renderer/tax.phtml index b1ca5c16c489bb64f33cb75fb4c7f8a00f34cf1b..44243d19a4dc46fc8896ce03223383fc004e5971 100644 --- a/app/code/Magento/Weee/view/adminhtml/templates/renderer/tax.phtml +++ b/app/code/Magento/Weee/view/adminhtml/templates/renderer/tax.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var $this \Magento\Weee\Block\Renderer\Weee\Tax */ diff --git a/app/code/Magento/Weee/view/base/templates/pricing/adjustment.phtml b/app/code/Magento/Weee/view/base/templates/pricing/adjustment.phtml index ca3e295f83e75f676a8aa9e46a878585acfe6707..79ecab8181839c6d8d8d988668ba364d683ef6e9 100644 --- a/app/code/Magento/Weee/view/base/templates/pricing/adjustment.phtml +++ b/app/code/Magento/Weee/view/base/templates/pricing/adjustment.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php diff --git a/app/code/Magento/Weee/view/frontend/templates/checkout/cart/item/price/sidebar.phtml b/app/code/Magento/Weee/view/frontend/templates/checkout/cart/item/price/sidebar.phtml index e94b43959156d76a518de93836011c1e80a38fbe..58be1c22e053e3129230ee9c47b6ae2479f940cf 100644 --- a/app/code/Magento/Weee/view/frontend/templates/checkout/cart/item/price/sidebar.phtml +++ b/app/code/Magento/Weee/view/frontend/templates/checkout/cart/item/price/sidebar.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Weee\Block\Item\Price\Renderer */ ?> <?php $_item = $this->getItem() ?> diff --git a/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/row_excl_tax.phtml b/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/row_excl_tax.phtml index ac842cdfe6ecdc6d71dee8e5c7a48972f1d101dc..1fae6dfcbf3efe2df2599f33e8c1b9e0df9916b8 100644 --- a/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/row_excl_tax.phtml +++ b/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/row_excl_tax.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Weee\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/row_incl_tax.phtml b/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/row_incl_tax.phtml index ff00cb4e9bf152957e69f1686c0ec94296e3557d..5782357df3b224145e62b3b5321a3d5af34671bc 100644 --- a/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/row_incl_tax.phtml +++ b/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/row_incl_tax.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Weee\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/unit_excl_tax.phtml b/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/unit_excl_tax.phtml index 419a17a992baab9980cb42ab5fc586b8dfa38ff8..5ed7782e839206497d516eb575bf2f0474550f33 100644 --- a/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/unit_excl_tax.phtml +++ b/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/unit_excl_tax.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Weee\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/unit_incl_tax.phtml b/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/unit_incl_tax.phtml index 8cfd55c4277e1812872f715cdfd4f5c2c967fbff..a3bdf78bc3c405ccb1c726d63039e17369d85861 100644 --- a/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/unit_incl_tax.phtml +++ b/app/code/Magento/Weee/view/frontend/templates/checkout/onepage/review/item/price/unit_incl_tax.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Weee\Block\Item\Price\Renderer */ $_item = $this->getItem(); diff --git a/app/code/Magento/Weee/view/frontend/templates/email/items/price/row.phtml b/app/code/Magento/Weee/view/frontend/templates/email/items/price/row.phtml index 50353124f100fb2efe29ba99f02f557ed062de36..8a46deb9f8fc80d577e1cf6d5f594a6e9517def9 100644 --- a/app/code/Magento/Weee/view/frontend/templates/email/items/price/row.phtml +++ b/app/code/Magento/Weee/view/frontend/templates/email/items/price/row.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Weee\Block\Item\Price\Renderer $this */ diff --git a/app/code/Magento/Weee/view/frontend/templates/item/price/row.phtml b/app/code/Magento/Weee/view/frontend/templates/item/price/row.phtml index b17ca8be9fa1820d43f9e519e616e5204f7bf3ae..c5df85d313ce185b20fa788ac0d9b2b967d3f4f0 100644 --- a/app/code/Magento/Weee/view/frontend/templates/item/price/row.phtml +++ b/app/code/Magento/Weee/view/frontend/templates/item/price/row.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Weee\Block\Item\Price\Renderer */ $item = $this->getItem(); diff --git a/app/code/Magento/Weee/view/frontend/templates/item/price/total_after_discount.phtml b/app/code/Magento/Weee/view/frontend/templates/item/price/total_after_discount.phtml index a7e1bc5529cb6c50278641216609946ec42a46af..c094b12eb04fd7948eab50bd8909e47033f63e61 100644 --- a/app/code/Magento/Weee/view/frontend/templates/item/price/total_after_discount.phtml +++ b/app/code/Magento/Weee/view/frontend/templates/item/price/total_after_discount.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var \Magento\Weee\Block\Item\Price\Renderer $this */ $_item = $this->getItem(); ?> diff --git a/app/code/Magento/Weee/view/frontend/templates/item/price/unit.phtml b/app/code/Magento/Weee/view/frontend/templates/item/price/unit.phtml index 06f21282765f40294c16627b895d03da9bf1476f..1d5a0f621ee7883ab3733b2dc820f44db29d840b 100644 --- a/app/code/Magento/Weee/view/frontend/templates/item/price/unit.phtml +++ b/app/code/Magento/Weee/view/frontend/templates/item/price/unit.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Weee\Block\Item\Price\Renderer */ $item = $this->getItem(); diff --git a/app/code/Magento/Widget/Block/Adminhtml/Widget.php b/app/code/Magento/Widget/Block/Adminhtml/Widget.php index 4a91071fc1802ad10c1bbc1fed63d388e81979eb..cc8d4932b55c4e48d37baba7e66c664701531292 100644 --- a/app/code/Magento/Widget/Block/Adminhtml/Widget.php +++ b/app/code/Magento/Widget/Block/Adminhtml/Widget.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * WYSIWYG widget plugin main block * diff --git a/app/code/Magento/Widget/Block/Adminhtml/Widget/Chooser.php b/app/code/Magento/Widget/Block/Adminhtml/Widget/Chooser.php index 2d55a8fa810d0455254cadc384bbe55947fadd82..8d49f625148908f0de4c9142d196400e37a98b62 100644 --- a/app/code/Magento/Widget/Block/Adminhtml/Widget/Chooser.php +++ b/app/code/Magento/Widget/Block/Adminhtml/Widget/Chooser.php @@ -119,6 +119,7 @@ class Chooser extends \Magento\Backend\Block\Template * Flag to indicate include hidden field before chooser or not * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getHiddenEnabled() { diff --git a/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main.php b/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main.php index f3c95ff9b4b2311f553eef425caaffd05d38206f..409741cec2280a23401a8a7a6e69341c305788f7 100644 --- a/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main.php +++ b/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main.php @@ -109,6 +109,7 @@ class Main extends \Magento\Backend\Block\Widget\Form\Generic implements \Magent * Prepare form before rendering HTML * * @return $this + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _prepareForm() { diff --git a/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main/Layout.php b/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main/Layout.php index 2db9f1f3a65fda8d9417b6275ce727bb846ed1b0..b80f97e56e2ba80af5e9d7b63ce8da519439ff09 100644 --- a/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main/Layout.php +++ b/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main/Layout.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Widget\Block\Adminhtml\Widget\Instance\Edit\Tab\Main; use Magento\Framework\Data\Form\Element\AbstractElement; @@ -185,6 +188,7 @@ class Layout extends \Magento\Backend\Block\Template implements \Magento\Framewo * Generate array of parameters for every container type to create html template * * @return array + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getDisplayOnContainers() { diff --git a/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Properties.php b/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Properties.php index c2add4b2bd5a2545ac43562a25be057ac43c7a64..665a0dcda716301b26052fc149e075c91b2d4a08 100644 --- a/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Properties.php +++ b/app/code/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Properties.php @@ -11,6 +11,9 @@ */ namespace Magento\Widget\Block\Adminhtml\Widget\Instance\Edit\Tab; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class Properties extends \Magento\Widget\Block\Adminhtml\Widget\Options implements \Magento\Backend\Block\Widget\Tab\TabInterface { diff --git a/app/code/Magento/Widget/Block/Adminhtml/Widget/Options.php b/app/code/Magento/Widget/Block/Adminhtml/Widget/Options.php index 433bff93d24cbc68b62e7554e8b296178cdbac76..eec29885c95734eff2f38a0aff6166f8b4e2f585 100644 --- a/app/code/Magento/Widget/Block/Adminhtml/Widget/Options.php +++ b/app/code/Magento/Widget/Block/Adminhtml/Widget/Options.php @@ -134,6 +134,8 @@ class Options extends \Magento\Backend\Block\Widget\Form\Generic * * @param \Magento\Framework\Object $parameter * @return \Magento\Framework\Data\Form\Element\AbstractElement + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _addField($parameter) { diff --git a/app/code/Magento/Widget/Model/NamespaceResolver.php b/app/code/Magento/Widget/Model/NamespaceResolver.php index 46832d20756b0b0eea6094b5c11b6f0568f012cd..f4e035bdea589a6d61f7a5fda4ca643c1e93930f 100644 --- a/app/code/Magento/Widget/Model/NamespaceResolver.php +++ b/app/code/Magento/Widget/Model/NamespaceResolver.php @@ -34,6 +34,8 @@ class NamespaceResolver * @param string $name * @param bool $asFullModuleName * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function determineOmittedNamespace($name, $asFullModuleName = false) { diff --git a/app/code/Magento/Widget/Model/Template/Filter.php b/app/code/Magento/Widget/Model/Template/Filter.php index 081e508e9c00c52368974ba57035a5aa156de357..b22efabc1483bc662444fb0be9e344cd5f50d642 100644 --- a/app/code/Magento/Widget/Model/Template/Filter.php +++ b/app/code/Magento/Widget/Model/Template/Filter.php @@ -7,6 +7,7 @@ namespace Magento\Widget\Model\Template; /** * Template Filter Model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Filter extends \Magento\Cms\Model\Template\Filter { @@ -34,6 +35,7 @@ class Filter extends \Magento\Cms\Model\Template\Filter * @param \Magento\Backend\Model\UrlInterface $backendUrlBuilder * @param \Magento\Widget\Model\Resource\Widget $widgetResource * @param \Magento\Widget\Model\Widget $widget + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Stdlib\String $string, diff --git a/app/code/Magento/Widget/Model/Widget.php b/app/code/Magento/Widget/Model/Widget.php index f55a55451e6f7928607cf5e3619d3b8007c3e281..569c2fae5e22d3f027e20b1161c528b22afecbc3 100644 --- a/app/code/Magento/Widget/Model/Widget.php +++ b/app/code/Magento/Widget/Model/Widget.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Widget model for different purposes * @@ -117,6 +119,8 @@ class Widget * * @param string $type Widget type * @return \Magento\Framework\Object + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getConfigAsObject($type) { diff --git a/app/code/Magento/Widget/Model/Widget/Instance.php b/app/code/Magento/Widget/Model/Widget/Instance.php index 11a0f14073483705663edf28a63409e731ea1f3d..f0344e35cc13a04ec4977057cb3e1d2cb3b32a83 100644 --- a/app/code/Magento/Widget/Model/Widget/Instance.php +++ b/app/code/Magento/Widget/Model/Widget/Instance.php @@ -18,6 +18,7 @@ use Magento\Framework\App\Filesystem\DirectoryList; * @method \Magento\Widget\Model\Widget\Instance setSortOrder(int $value) * @method \Magento\Widget\Model\Widget\Instance setThemeId(int $value) * @method int getThemeId() + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Instance extends \Magento\Framework\Model\AbstractModel { @@ -123,6 +124,7 @@ class Instance extends \Magento\Framework\Model\AbstractModel * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $relatedCacheTypes * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -187,6 +189,8 @@ class Instance extends \Magento\Framework\Model\AbstractModel * Processing object before save data * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function beforeSave() { @@ -408,6 +412,7 @@ class Instance extends \Magento\Framework\Model\AbstractModel * Load widget XML config and merge with theme widget config * * @return array|null + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getWidgetConfigAsArray() { @@ -532,6 +537,8 @@ class Instance extends \Magento\Framework\Model\AbstractModel * @param string $container * @param string $templatePath * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function generateLayoutUpdateXml($container, $templatePath = '') { diff --git a/app/code/Magento/Widget/view/adminhtml/templates/instance/edit/layout.phtml b/app/code/Magento/Widget/view/adminhtml/templates/instance/edit/layout.phtml index 4f7e76aa3b19568e6bf296d9092da57b48be6a42..ccd04fb7a617b2f6f9b7361036b40d5f5ab077d0 100644 --- a/app/code/Magento/Widget/view/adminhtml/templates/instance/edit/layout.phtml +++ b/app/code/Magento/Widget/view/adminhtml/templates/instance/edit/layout.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <fieldset class="fieldset"> <legend class="legend"><span><?php echo __('Layout Updates') ?></span></legend> diff --git a/app/code/Magento/Wishlist/Block/AbstractBlock.php b/app/code/Magento/Wishlist/Block/AbstractBlock.php index e608b7b93948c7c9a61e2e841fa5f167f8d182a0..a8a1b6a56abe0f25e76f8f9d86e853491ed2d215 100644 --- a/app/code/Magento/Wishlist/Block/AbstractBlock.php +++ b/app/code/Magento/Wishlist/Block/AbstractBlock.php @@ -81,6 +81,7 @@ abstract class AbstractBlock extends \Magento\Catalog\Block\Product\AbstractProd * * @param \Magento\Wishlist\Model\Resource\Item\Collection $collection * @return \Magento\Wishlist\Block\Customer\Wishlist + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _prepareCollection($collection) { diff --git a/app/code/Magento/Wishlist/Block/Customer/Sidebar.php b/app/code/Magento/Wishlist/Block/Customer/Sidebar.php index 72d357a33ea961167d68f2216e94154d0f1df7f8..1898c981c239bb2616dcf44b9fe9f9a9929cf0cc 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Sidebar.php +++ b/app/code/Magento/Wishlist/Block/Customer/Sidebar.php @@ -57,6 +57,7 @@ class Sidebar extends \Magento\Wishlist\Block\AbstractBlock implements \Magento\ * * @deprecated after 1.6.2.0 * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCanDisplayWishlist() { diff --git a/app/code/Magento/Wishlist/Controller/Index/Add.php b/app/code/Magento/Wishlist/Controller/Index/Add.php index e8c9864d08f8945dd8086300fa2a015812f2e61c..91b2eede9db6437d9b17d9735a29a855f4953885 100644 --- a/app/code/Magento/Wishlist/Controller/Index/Add.php +++ b/app/code/Magento/Wishlist/Controller/Index/Add.php @@ -52,6 +52,9 @@ class Add extends Action\Action implements IndexInterface * * @return void * @throws NotFoundException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function execute() { diff --git a/app/code/Magento/Wishlist/Controller/Index/Cart.php b/app/code/Magento/Wishlist/Controller/Index/Cart.php index 167a08195ce19d0244ba1ee8aab8532b3fdcc3d4..9f599b5e1d44263d56bc8f5eb11192c5043ac416 100644 --- a/app/code/Magento/Wishlist/Controller/Index/Cart.php +++ b/app/code/Magento/Wishlist/Controller/Index/Cart.php @@ -10,6 +10,9 @@ use Magento\Framework\App\Action; use Magento\Framework\App\ResponseInterface; use Magento\Wishlist\Controller\IndexInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Cart extends Action\Action implements IndexInterface { /** @@ -92,6 +95,8 @@ class Cart extends Action\Action implements IndexInterface * to product view page with message about needed defined required options * * @return ResponseInterface + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Wishlist/Controller/Index/DownloadCustomOption.php b/app/code/Magento/Wishlist/Controller/Index/DownloadCustomOption.php index 4e87d03ce965973ba83f3f1bc4118d53be906305..3c26bf8e64db6f7007b465927d10622f2e5a3816 100644 --- a/app/code/Magento/Wishlist/Controller/Index/DownloadCustomOption.php +++ b/app/code/Magento/Wishlist/Controller/Index/DownloadCustomOption.php @@ -33,6 +33,8 @@ class DownloadCustomOption extends Action\Action implements IndexInterface * Custom options download action * * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExitExpression) */ public function execute() { diff --git a/app/code/Magento/Wishlist/Controller/Index/Fromcart.php b/app/code/Magento/Wishlist/Controller/Index/Fromcart.php index fa4dda67b9ca8b2895408f9d5d3df894f061331f..174a12bdd49ddf0ad32283097460d8dd835b1794 100644 --- a/app/code/Magento/Wishlist/Controller/Index/Fromcart.php +++ b/app/code/Magento/Wishlist/Controller/Index/Fromcart.php @@ -34,6 +34,7 @@ class Fromcart extends Action\Action implements IndexInterface * * @return \Zend_Controller_Response_Abstract * @throws NotFoundException + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function execute() { diff --git a/app/code/Magento/Wishlist/Controller/Index/Send.php b/app/code/Magento/Wishlist/Controller/Index/Send.php index 39449a53fd3cb3385322115c58bc57fd41a68678..c989d815bda47004d0eb6a2ed73395160cb34152 100644 --- a/app/code/Magento/Wishlist/Controller/Index/Send.php +++ b/app/code/Magento/Wishlist/Controller/Index/Send.php @@ -11,6 +11,9 @@ use Magento\Framework\App\Action\NotFoundException; use Magento\Framework\App\ResponseInterface; use Magento\Wishlist\Controller\IndexInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Send extends Action\Action implements IndexInterface { /** @@ -83,6 +86,9 @@ class Send extends Action\Action implements IndexInterface * * @return ResponseInterface|void * @throws NotFoundException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function execute() { diff --git a/app/code/Magento/Wishlist/Controller/Index/Update.php b/app/code/Magento/Wishlist/Controller/Index/Update.php index adce8168110f2563017e71582a073f4aa4e49772..3a35fced9d37cb8d4453de94876d0d566b951394 100644 --- a/app/code/Magento/Wishlist/Controller/Index/Update.php +++ b/app/code/Magento/Wishlist/Controller/Index/Update.php @@ -51,6 +51,8 @@ class Update extends Action\Action implements IndexInterface * * @return ResponseInterface|void * @throws NotFoundException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Wishlist/Controller/WishlistProvider.php b/app/code/Magento/Wishlist/Controller/WishlistProvider.php index 368c086d2c94b6940410907d3bb2bb676e97bd3e..20daf96c7b1011fbca8cd96ed2836ac369b38919 100644 --- a/app/code/Magento/Wishlist/Controller/WishlistProvider.php +++ b/app/code/Magento/Wishlist/Controller/WishlistProvider.php @@ -55,6 +55,7 @@ class WishlistProvider implements WishlistProviderInterface /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getWishlist($wishlistId = null) { diff --git a/app/code/Magento/Wishlist/Helper/Data.php b/app/code/Magento/Wishlist/Helper/Data.php index aa891ea8cd1df47c27d922c16ce38ba6f8e1a184..2eed816763a185c68f41171aaeb6743f63a81665 100644 --- a/app/code/Magento/Wishlist/Helper/Data.php +++ b/app/code/Magento/Wishlist/Helper/Data.php @@ -11,6 +11,7 @@ use Magento\Wishlist\Controller\WishlistProviderInterface; * Wishlist Data Helper * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Data extends \Magento\Framework\App\Helper\AbstractHelper { diff --git a/app/code/Magento/Wishlist/Helper/Rss.php b/app/code/Magento/Wishlist/Helper/Rss.php index 2ab829a15d2a43bd2c79a3d966f0f70e5749477b..5cfee1dc5f20510cff14bd89bce9f4cffdbf69d6 100644 --- a/app/code/Magento/Wishlist/Helper/Rss.php +++ b/app/code/Magento/Wishlist/Helper/Rss.php @@ -6,6 +6,9 @@ namespace Magento\Wishlist\Helper; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Rss extends \Magento\Wishlist\Helper\Data { /** @@ -35,6 +38,7 @@ class Rss extends \Magento\Wishlist\Helper\Data * @param \Magento\Wishlist\Controller\WishlistProviderInterface $wishlistProvider * @param \Magento\Customer\Api\Data\CustomerDataBuilder $customerBuilder * @param \Magento\Customer\Api\CustomerRepositoryInterface $customerRepository + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Helper\Context $context, diff --git a/app/code/Magento/Wishlist/Model/Item.php b/app/code/Magento/Wishlist/Model/Item.php index f9b15970143e190090368477f643331a524e554e..314afecc70465724a6fccaa2c92a8c1b9b39e01a 100644 --- a/app/code/Magento/Wishlist/Model/Item.php +++ b/app/code/Magento/Wishlist/Model/Item.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Wishlist\Model; use Magento\Catalog\Api\ProductRepositoryInterface; @@ -27,6 +30,7 @@ use Magento\Wishlist\Model\Resource\Item\Option\CollectionFactory; * @method \Magento\Wishlist\Model\Item setAddedAt(string $value) * @method string getDescription() * @method \Magento\Wishlist\Model\Item setDescription(string $value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Item extends AbstractModel implements ItemInterface { @@ -132,6 +136,7 @@ class Item extends AbstractModel implements ItemInterface * @param \Magento\Framework\Model\Resource\AbstractResource $resource * @param \Magento\Framework\Data\Collection\Db $resourceCollection * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, diff --git a/app/code/Magento/Wishlist/Model/ItemCarrier.php b/app/code/Magento/Wishlist/Model/ItemCarrier.php index a94c5804d34b5b1a01694b20afe1144b4e3a95f4..093022fd52078c33ceaac3f822839f852f3c6745 100644 --- a/app/code/Magento/Wishlist/Model/ItemCarrier.php +++ b/app/code/Magento/Wishlist/Model/ItemCarrier.php @@ -15,6 +15,9 @@ use Magento\Framework\Message\ManagerInterface as MessageManager; use Magento\Framework\UrlInterface; use Magento\Wishlist\Helper\Data as WishlistHelper; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class ItemCarrier { /** @@ -101,6 +104,9 @@ class ItemCarrier * @param Wishlist $wishlist * @param array $qtys * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function moveAllToCart(Wishlist $wishlist, $qtys) { diff --git a/app/code/Magento/Wishlist/Model/Observer.php b/app/code/Magento/Wishlist/Model/Observer.php index 282121b75004cbcf908acfa0c6a12a06087d87d0..a484c5c8b9a208a4ef4d4f24a30e8a42ed6239f1 100644 --- a/app/code/Magento/Wishlist/Model/Observer.php +++ b/app/code/Magento/Wishlist/Model/Observer.php @@ -122,6 +122,7 @@ class Observer /** * @param \Magento\Framework\Event\Observer $observer * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function processAddToCart($observer) { @@ -177,6 +178,7 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function customerLogin(\Magento\Framework\Event\Observer $observer) { @@ -190,6 +192,7 @@ class Observer * * @param \Magento\Framework\Event\Observer $observer * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function customerLogout(\Magento\Framework\Event\Observer $observer) { diff --git a/app/code/Magento/Wishlist/Model/Resource/Item/Collection.php b/app/code/Magento/Wishlist/Model/Resource/Item/Collection.php index 7494f287f8af20b58f8c8fcc632c51dbe782b150..847f86a83e75922ae2b9eba6837b7b18b2ad0828 100644 --- a/app/code/Magento/Wishlist/Model/Resource/Item/Collection.php +++ b/app/code/Magento/Wishlist/Model/Resource/Item/Collection.php @@ -7,6 +7,8 @@ namespace Magento\Wishlist\Model\Resource\Item; /** * Wishlist item collection + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Collection extends \Magento\Framework\Model\Resource\Db\Collection\AbstractCollection { diff --git a/app/code/Magento/Wishlist/Model/Resource/Item/Collection/Grid.php b/app/code/Magento/Wishlist/Model/Resource/Item/Collection/Grid.php index 705b219bd04035a92d8bc6d1170c61b29ccf7368..d9bad91899272ffe8d6006c243f4b40f9af7d11b 100644 --- a/app/code/Magento/Wishlist/Model/Resource/Item/Collection/Grid.php +++ b/app/code/Magento/Wishlist/Model/Resource/Item/Collection/Grid.php @@ -11,6 +11,9 @@ namespace Magento\Wishlist\Model\Resource\Item\Collection; use Magento\Customer\Controller\RegistryConstants as RegistryConstants; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Grid extends \Magento\Wishlist\Model\Resource\Item\Collection { /** diff --git a/app/code/Magento/Wishlist/Model/Wishlist.php b/app/code/Magento/Wishlist/Model/Wishlist.php index bf637020ddd685bdd0b92d32dc5876f86d08fcfc..45933e31a1a7f4d255f5fac6d298f35e011adaf0 100644 --- a/app/code/Magento/Wishlist/Model/Wishlist.php +++ b/app/code/Magento/Wishlist/Model/Wishlist.php @@ -23,6 +23,7 @@ use Magento\Wishlist\Model\Resource\Wishlist\Collection; * @method \Magento\Wishlist\Model\Wishlist setSharingCode(string $value) * @method string getUpdatedAt() * @method \Magento\Wishlist\Model\Wishlist setUpdatedAt(string $value) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Wishlist extends \Magento\Framework\Model\AbstractModel implements \Magento\Framework\Object\IdentityInterface { @@ -135,6 +136,7 @@ class Wishlist extends \Magento\Framework\Model\AbstractModel implements \Magent * @param ProductRepositoryInterface $productRepository * @param bool $useCurrentWebsite * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\Model\Context $context, @@ -370,6 +372,8 @@ class Wishlist extends \Magento\Framework\Model\AbstractModel implements \Magent * @param bool $forciblySetQty * @throws \Magento\Framework\Model\Exception * @return Item|string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function addNewItem($product, $buyRequest = null, $forciblySetQty = false) { @@ -600,6 +604,8 @@ class Wishlist extends \Magento\Framework\Model\AbstractModel implements \Magent * @throws Exception * * @see \Magento\Catalog\Helper\Product::addParamsToBuyRequest() + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function updateItem($itemId, $buyRequest, $params = null) { diff --git a/app/code/Magento/Wishlist/sql/wishlist_setup/install-2.0.0.php b/app/code/Magento/Wishlist/sql/wishlist_setup/install-2.0.0.php index 56e1abe9ae014cb1feaf137bab0e795126e93a3a..8d30ddbd7b30b68aac5eaa7043191973a716cd8b 100644 --- a/app/code/Magento/Wishlist/sql/wishlist_setup/install-2.0.0.php +++ b/app/code/Magento/Wishlist/sql/wishlist_setup/install-2.0.0.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /* @var $installer \Magento\Setup\Module\SetupModule */ $installer = $this; diff --git a/app/code/Magento/Wishlist/view/adminhtml/templates/customer/edit/tab/wishlist.phtml b/app/code/Magento/Wishlist/view/adminhtml/templates/customer/edit/tab/wishlist.phtml index ee82d2d638693d771eaebbe1c71361d439458138..266d47e4593d085ab6cc7f5d424edaf8926a03ee 100644 --- a/app/code/Magento/Wishlist/view/adminhtml/templates/customer/edit/tab/wishlist.phtml +++ b/app/code/Magento/Wishlist/view/adminhtml/templates/customer/edit/tab/wishlist.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @var $this \Magento\Framework\View\Element\Template */ diff --git a/app/code/Magento/Wishlist/view/frontend/templates/button/share.phtml b/app/code/Magento/Wishlist/view/frontend/templates/button/share.phtml index 87981a7c2f9a6a28720dd830d563cf86b5eaff24..3991fbcf0f24e4b05728c2435473b812a542f696 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/button/share.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/button/share.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Wishlist\Block\Customer\Wishlist\Button */ ?> <?php if ($this->getWishlist()->getItemsCount() && $this->getWishlist()->getShared() < $this->getConfig()->getSharingEmailLimit()): ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/button/tocart.phtml b/app/code/Magento/Wishlist/view/frontend/templates/button/tocart.phtml index 872dbf1e6879fd06c11f5ab27890b3015bc6c17c..0d1c7bd7f527f7a4435fb243f315f411df8444be 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/button/tocart.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/button/tocart.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getWishlist()->getItemsCount() && $this->getWishlist()->isSalable()): ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/button/update.phtml b/app/code/Magento/Wishlist/view/frontend/templates/button/update.phtml index f4b058938bb8cce34d0944818600ed791f8fbcf9..c0c3807b5ccb0aa26c5f1c2197b52d54f13bbce6 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/button/update.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/button/update.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php if ($this->getWishlist()->getItemsCount()): ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/email/items.phtml b/app/code/Magento/Wishlist/view/frontend/templates/email/items.phtml index 26bb715eed991ed5371541dc5312ad3cd5aba01c..c48029a6bc5d1a02a7649730ab24e96907bbb38a 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/email/items.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/email/items.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Wishlist\Block\Share\Email\Items */ ?> <?php $l = $this->getWishlistItemsCount() ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/column/actions.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/column/actions.phtml index 1346e78554c65c7be24c5a6f1d279c57b2390bca..9a4d27751f76b07982ee2a82173821789f369a86 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/item/column/actions.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/item/column/actions.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /* @var \Magento\Wishlist\Model\Item $item */ ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/column/cart.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/column/cart.phtml index d15fa004e43e94863549bd8dce7dc5a6b286f865..6559dc3ce7c1b6265167f29f20fe82089c4ca4bb 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/item/column/cart.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/item/column/cart.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /* @var $this \Magento\Wishlist\Block\Customer\Wishlist\Item\Column\Cart */ /* @var \Magento\Wishlist\Model\Item $item */ $item = $this->getItem(); diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/column/comment.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/column/comment.phtml index f87ff5c5d3a47b78af4879a519ee8739bc487ee4..d748c629d2e4f9f7791a0e1d37ab93c84cc4f8de 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/item/column/comment.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/item/column/comment.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /* @var \Magento\Wishlist\Model\Item $item */ $item = $this->getItem(); diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/column/edit.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/column/edit.phtml index 2e1f95ffd8728e794acc8628ccdfa63bb7ea62bc..b07a108332ec28ac29b4832ea2563d32b32b03a6 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/item/column/edit.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/item/column/edit.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /* @var \Magento\Wishlist\Model\Item $item */ $item = $this->getItem(); $product = $item->getProduct(); diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/column/image.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/column/image.phtml index e108bb00cf1eb4d037d4456c67b021f19a4c4440..25d4675cb0a2c85ec5bb34a8236caf105637a6dd 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/item/column/image.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/item/column/image.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /* @var \Magento\Wishlist\Model\Item $item */ $item = $this->getItem(); $product = $item->getProduct(); diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/column/name.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/column/name.phtml index a4469c5e1f3a7602f8f99b9ad0ab7020292820b0..51926c9beb60825ffcce588961ff030193ef4abe 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/item/column/name.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/item/column/name.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /* @var \Magento\Wishlist\Model\Item $item */ $item = $this->getItem(); $product = $item->getProduct(); diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/column/price.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/column/price.phtml index fc84c28629e46d04aa9f83fb59eb2aca78dceb66..ffd35d1a31db1dfe6592756c331d233f2bbd8301 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/item/column/price.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/item/column/price.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /* @var \Magento\Wishlist\Model\Item $item */ ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/column/remove.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/column/remove.phtml index 6c09eecb96ce7872e25234bdf8cbf80ab289c7b9..20a2458f7a04a7cbd931b78ea330535021331bd5 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/item/column/remove.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/item/column/remove.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <a href="#" data-role="remove" data-post-remove='<?php echo $this->getItemRemoveParams($this->getItem()); ?>' title="<?php echo __('Remove Item') ?>" class="btn-remove action delete"> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/configure/addto.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/configure/addto.phtml index 416a9e6b72523eb4ae060e8f3c18de60f802534e..7e5042ab2ea8ebc8b3e95a5401adbf84b0039407 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/item/configure/addto.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/item/configure/addto.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <div class="product-addto-links" data-role="add-to-links"> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/item/list.phtml b/app/code/Magento/Wishlist/view/frontend/templates/item/list.phtml index 0d36507547198198565f573e1d4d1d38a6e5debb..9601fd557d3817ccaab1c20c77d36ae28a3a70fa 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/item/list.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/item/list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php /** @var \Magento\Wishlist\Block\Customer\Wishlist\Items $this */ diff --git a/app/code/Magento/Wishlist/view/frontend/templates/js/components.phtml b/app/code/Magento/Wishlist/view/frontend/templates/js/components.phtml index 99be8e37348cec69521e018a61f416324e582a94..43f7e9c30c0126f46204910ee749ef83ad81e815 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/js/components.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/js/components.phtml @@ -3,5 +3,8 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <?php echo $this->getChildHtml() ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/link.phtml b/app/code/Magento/Wishlist/view/frontend/templates/link.phtml index c2b312ffa50aa34efeffa4de96ce1e6ef51c1d5f..ed84ed72388be9e20512055a75a799e06c5fbebb 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/link.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/link.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Wishlist\Block\Link */ ?> <li class="link wishlist"> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/options_list.phtml b/app/code/Magento/Wishlist/view/frontend/templates/options_list.phtml index cfa90e4c054eb47ccf1e12d8033d2a8d0e11475d..9b66b4bbb566bd59408d712d8c5e0216f17a32fe 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/options_list.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/options_list.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Wishlist\Block\Customer\Wishlist\Item\Options */ ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/rss/email.phtml b/app/code/Magento/Wishlist/view/frontend/templates/rss/email.phtml index b4be8a2ac87d79005c64090fe8bbc2fdca94c7db..5cd029e105e32e4e8d0f651bfcee3c6723fe54ff 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/rss/email.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/rss/email.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Wishlist\Block\Rss\EmailLink */ ?> <?php if ($this->getLink()): ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/rss/wishlist.phtml b/app/code/Magento/Wishlist/view/frontend/templates/rss/wishlist.phtml index ab7ea7b436e8791818909d0e987598e6d4c2a55f..1f55d5f8ca037bcd53e9112e123ac8561d2ddd8c 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/rss/wishlist.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/rss/wishlist.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Wishlist\Block\Rss\Link */ ?> <?php if ($this->isRssAllowed() && $this->getLink() && $this->helper('Magento\Wishlist\Helper\Data')->getWishlist()->getItemsCount()): ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/shared.phtml b/app/code/Magento/Wishlist/view/frontend/templates/shared.phtml index 48eb0afdfc41d78b8c46d22a9cd767d7b51cc810..f2c671832ec83ccb6c71db1085aa701e7f5b7162 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/shared.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/shared.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Wishlist\Block\Share\Wishlist */ $imageBlock = $this->getLayout()->createBlock('Magento\Catalog\Block\Product\Image'); ?> diff --git a/app/code/Magento/Wishlist/view/frontend/templates/sharing.phtml b/app/code/Magento/Wishlist/view/frontend/templates/sharing.phtml index d9477b34c725b7c685a20b59cd6b4dd89f9f705b..2fe96e7784940ef7734b180f2a5257663d5719da 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/sharing.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/sharing.phtml @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** @var $this \Magento\Wishlist\Block\Customer\Sharing */ ?> <form class="form wishlist share" diff --git a/app/code/Magento/Wishlist/view/frontend/templates/sidebar.phtml b/app/code/Magento/Wishlist/view/frontend/templates/sidebar.phtml index ec6137afee6c5b05ae37baab84633f6af71c4416..732ab1714e2c0099b457862caa34812fa3f268c1 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/sidebar.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/sidebar.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Wishlist\Block\Customer\Sidebar */ ?> <?php diff --git a/app/code/Magento/Wishlist/view/frontend/templates/view.phtml b/app/code/Magento/Wishlist/view/frontend/templates/view.phtml index c152b3b67572d72667429252de2e32a8fab65824..b47de0c8c54f06f14f19956d5ad1f246dc81bfd0 100644 --- a/app/code/Magento/Wishlist/view/frontend/templates/view.phtml +++ b/app/code/Magento/Wishlist/view/frontend/templates/view.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + /* @var $this \Magento\Wishlist\Block\Customer\Wishlist */ ?> diff --git a/dev/tests/api-functional/_files/Magento/TestModule4/Service/V1/DataObjectServiceInterface.php b/dev/tests/api-functional/_files/Magento/TestModule4/Service/V1/DataObjectServiceInterface.php index b67c6545cb9f3ff9d58018268d77c9788ccc207e..f3b219f7e65a5b0fc61be6a73054ec6f9088c18f 100644 --- a/dev/tests/api-functional/_files/Magento/TestModule4/Service/V1/DataObjectServiceInterface.php +++ b/dev/tests/api-functional/_files/Magento/TestModule4/Service/V1/DataObjectServiceInterface.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\TestModule4\Service\V1; use Magento\TestModule4\Service\V1\Entity\DataObjectRequest; diff --git a/dev/tests/api-functional/_files/Magento/TestModule4/Service/V1/Entity/ExtensibleRequest.php b/dev/tests/api-functional/_files/Magento/TestModule4/Service/V1/Entity/ExtensibleRequest.php index 25bbcf16458a0c57e40b003f89a3e76441958e88..d96ca365fbd34fa3d1efa4fb02efa4267243ccfa 100644 --- a/dev/tests/api-functional/_files/Magento/TestModule4/Service/V1/Entity/ExtensibleRequest.php +++ b/dev/tests/api-functional/_files/Magento/TestModule4/Service/V1/Entity/ExtensibleRequest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\TestModule4\Service\V1\Entity; class ExtensibleRequest extends \Magento\Framework\Model\AbstractExtensibleModel implements ExtensibleRequestInterface diff --git a/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/CustomAttributeDataObject.php b/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/CustomAttributeDataObject.php index 86cdddf8d5949849f9f13b0686f8d1c2dd6842aa..54dbbdffc5accd97a9fe58f133001127574f8bf2 100644 --- a/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/CustomAttributeDataObject.php +++ b/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/CustomAttributeDataObject.php @@ -3,12 +3,15 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\TestModuleMSC\Model\Data; use Magento\TestModuleMSC\Api\Data\CustomAttributeDataObjectInterface; +use Magento\Framework\Api\AbstractExtensibleObject; -class CustomAttributeDataObject extends \Magento\Framework\Api\AbstractExtensibleObject implements - CustomAttributeDataObjectInterface +class CustomAttributeDataObject extends AbstractExtensibleObject implements CustomAttributeDataObjectInterface { /** * @return string diff --git a/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/CustomAttributeNestedDataObject.php b/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/CustomAttributeNestedDataObject.php index 4e9e2afcf9cacb09330436b6f739ffbdd855f3f7..24937c7ecae46870cb3af65c34e1cad80daf9310 100644 --- a/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/CustomAttributeNestedDataObject.php +++ b/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/CustomAttributeNestedDataObject.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\TestModuleMSC\Model\Data; use Magento\TestModuleMSC\Api\Data\CustomAttributeNestedDataObjectInterface; diff --git a/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/Item.php b/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/Item.php index c3854c46419ef5c04b10598d4560e15f58a06efe..c35147c0e7745c3829215f1c93ba772894a9f0f5 100644 --- a/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/Item.php +++ b/dev/tests/api-functional/_files/Magento/TestModuleMSC/Model/Data/Item.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\TestModuleMSC\Model\Data; use Magento\TestModuleMSC\Api\Data\ItemInterface; diff --git a/dev/tests/api-functional/framework/Magento/TestFramework/Annotation/ApiDataFixture.php b/dev/tests/api-functional/framework/Magento/TestFramework/Annotation/ApiDataFixture.php index 849f7838a3e0de87eed0edcdf5afc3e65c4b01f0..749c0de354ea2b9530f392c478be5eea5ccf5e61 100644 --- a/dev/tests/api-functional/framework/Magento/TestFramework/Annotation/ApiDataFixture.php +++ b/dev/tests/api-functional/framework/Magento/TestFramework/Annotation/ApiDataFixture.php @@ -9,6 +9,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\TestFramework\Annotation; class ApiDataFixture diff --git a/dev/tests/api-functional/framework/Magento/TestFramework/Authentication/Rest/OauthClient.php b/dev/tests/api-functional/framework/Magento/TestFramework/Authentication/Rest/OauthClient.php index 6a71b708ac95f5941def2e26e81ad96946476036..ae4604fd1c322d09f41da047fc23ae9fcff6934f 100644 --- a/dev/tests/api-functional/framework/Magento/TestFramework/Authentication/Rest/OauthClient.php +++ b/dev/tests/api-functional/framework/Magento/TestFramework/Authentication/Rest/OauthClient.php @@ -19,6 +19,9 @@ use OAuth\OAuth1\Signature\SignatureInterface; use OAuth\OAuth1\Token\StdOAuth1Token; use OAuth\OAuth1\Token\TokenInterface; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class OauthClient extends AbstractService { /** @var string|null */ diff --git a/dev/tests/api-functional/framework/Magento/TestFramework/TestCase/Webapi/Adapter/Rest.php b/dev/tests/api-functional/framework/Magento/TestFramework/TestCase/Webapi/Adapter/Rest.php index 26ae75ed20431bd2bf9f4bf56c5a7192040bb058..7488f42ae06740f31bbb0723920220e1edd51239 100644 --- a/dev/tests/api-functional/framework/Magento/TestFramework/TestCase/Webapi/Adapter/Rest.php +++ b/dev/tests/api-functional/framework/Magento/TestFramework/TestCase/Webapi/Adapter/Rest.php @@ -62,6 +62,7 @@ class Rest implements \Magento\TestFramework\TestCase\Webapi\AdapterInterface * {@inheritdoc} * @throws \LogicException * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function call($serviceInfo, $arguments = [], $storeCode = null) { diff --git a/dev/tests/api-functional/framework/Magento/TestFramework/TestCase/WebapiAbstract.php b/dev/tests/api-functional/framework/Magento/TestFramework/TestCase/WebapiAbstract.php index e0f80d3ef43a7d8a4e6dd8958093340e67c89927..50cd00f7497f0d5a6bf4f801b01d00828f875772 100644 --- a/dev/tests/api-functional/framework/Magento/TestFramework/TestCase/WebapiAbstract.php +++ b/dev/tests/api-functional/framework/Magento/TestFramework/TestCase/WebapiAbstract.php @@ -11,6 +11,9 @@ use Magento\Framework\App\Filesystem\DirectoryList; use Magento\Framework\Filesystem; use Magento\Webapi\Model\Soap\Fault; +/** + * @SuppressWarnings(PHPMD.NumberOfChildren) + */ abstract class WebapiAbstract extends \PHPUnit_Framework_TestCase { /** TODO: Reconsider implementation of fixture-management methods after implementing several tests */ diff --git a/dev/tests/api-functional/testsuite/Magento/Catalog/Api/CategoryManagementTest.php b/dev/tests/api-functional/testsuite/Magento/Catalog/Api/CategoryManagementTest.php index 1281c5d2ef18aa8d3213586dbf5b4df340bdfecb..9bcc44ac3a7b993869bb2e4627218f917e96c577 100644 --- a/dev/tests/api-functional/testsuite/Magento/Catalog/Api/CategoryManagementTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Catalog/Api/CategoryManagementTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Api; use Magento\TestFramework\TestCase\WebapiAbstract; diff --git a/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductAttributeManagementTest.php b/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductAttributeManagementTest.php index bb5aaf7920ff3c7e3ac8e33e2ab0b89f200044b5..b6838804873bff5d690822da4948741a229b540f 100644 --- a/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductAttributeManagementTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductAttributeManagementTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Api; use Magento\TestFramework\Helper\Bootstrap; diff --git a/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductCustomOptionRepositoryTest.php b/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductCustomOptionRepositoryTest.php index 3f1ee1c99f4eded12cc7acd42c7547f6737aa9cb..e6a159a4675067d0b7c3551eced9ce7e9c2a3673 100644 --- a/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductCustomOptionRepositoryTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductCustomOptionRepositoryTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Api; use Magento\TestFramework\Helper\Bootstrap; @@ -95,6 +97,7 @@ class ProductCustomOptionRepositoryTest extends WebapiAbstract /** * @magentoApiDataFixture Magento/Catalog/_files/product_with_options.php * @magentoAppIsolation enabled + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function testGetList() { @@ -136,6 +139,7 @@ class ProductCustomOptionRepositoryTest extends WebapiAbstract * @magentoApiDataFixture Magento/Catalog/_files/product_without_options.php * @magentoAppIsolation enabled * @dataProvider optionDataProvider + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function testSave($optionData) { @@ -281,6 +285,7 @@ class ProductCustomOptionRepositoryTest extends WebapiAbstract * @magentoApiDataFixture Magento/Catalog/_files/product_with_options.php * @magentoAppIsolation enabled * @dataProvider validOptionDataProvider + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function testUpdateOptionAddingNewValue($optionType) { diff --git a/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductMediaAttributeManagementTest.php b/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductMediaAttributeManagementTest.php index a470b771b754656220c8247748e771a304d03e46..d8eca5a6c52809f194b67f08dbe28faf89b29fc7 100644 --- a/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductMediaAttributeManagementTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductMediaAttributeManagementTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Api; use Magento\TestFramework\TestCase\WebapiAbstract; diff --git a/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductTierPriceManagementTest.php b/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductTierPriceManagementTest.php index cc95447785187e169c75e74a88417ceeb9029ec7..1dbc5e0d5218d56d2713ffa6a491539bb4065bbb 100644 --- a/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductTierPriceManagementTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductTierPriceManagementTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Api; use Magento\TestFramework\TestCase\WebapiAbstract; diff --git a/dev/tests/api-functional/testsuite/Magento/CatalogInventory/Api/LowStockItemsTest.php b/dev/tests/api-functional/testsuite/Magento/CatalogInventory/Api/LowStockItemsTest.php index 564bdbcb41a748275d70732dccd34f08a5d4ac9b..bbcf1389aafad111e7d5af62cd0b6cd2a2459123 100644 --- a/dev/tests/api-functional/testsuite/Magento/CatalogInventory/Api/LowStockItemsTest.php +++ b/dev/tests/api-functional/testsuite/Magento/CatalogInventory/Api/LowStockItemsTest.php @@ -23,6 +23,7 @@ class LowStockItemsTest extends WebapiAbstract * @param array $result * @magentoApiDataFixture Magento/Catalog/_files/multiple_products.php * @dataProvider getLowStockItemsDataProvider + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function testGetLowStockItems($qty, $currentPage, $pageSize, $result) { diff --git a/dev/tests/api-functional/testsuite/Magento/CatalogInventory/Api/StockItemTest.php b/dev/tests/api-functional/testsuite/Magento/CatalogInventory/Api/StockItemTest.php index 595a0a2bd410618b1e186a857bf4ab4682446941..747b12d4f189c58e21b053318e9aeb20a0a642df 100644 --- a/dev/tests/api-functional/testsuite/Magento/CatalogInventory/Api/StockItemTest.php +++ b/dev/tests/api-functional/testsuite/Magento/CatalogInventory/Api/StockItemTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogInventory\Api; use Magento\TestFramework\Helper\Bootstrap; diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Billing/ReadServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Billing/ReadServiceTest.php deleted file mode 100644 index d5510f855ed522be2878d4dc137b4d9a4759da03..0000000000000000000000000000000000000000 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Billing/ReadServiceTest.php +++ /dev/null @@ -1,86 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Address\Billing; - -use Magento\Checkout\Service\V1\Data\Cart\Address; -use Magento\Checkout\Service\V1\Data\Cart\Address\Region; -use Magento\TestFramework\TestCase\WebapiAbstract; -use Magento\Webapi\Model\Rest\Config as RestConfig; - -class ReadServiceTest extends WebapiAbstract -{ - const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutAddressBillingReadServiceV1'; - const RESOURCE_PATH = '/V1/carts/'; - - /** - * @var \Magento\TestFramework\ObjectManager - */ - protected $objectManager; - - protected function setUp() - { - $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); - } - - /** - * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php - */ - public function testGetAddress() - { - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); - $quote->load('test_order_1', 'reserved_order_id'); - - /** @var \Magento\Quote\Model\Quote\Address $address */ - $address = $quote->getBillingAddress(); - - $data = [ - Address::KEY_COUNTRY_ID => $address->getCountryId(), - Address::KEY_ID => (int)$address->getId(), - Address::KEY_CUSTOMER_ID => $address->getCustomerId(), - Address::KEY_REGION => [ - Region::REGION => $address->getRegion(), - Region::REGION_ID => $address->getRegionId(), - Region::REGION_CODE => $address->getRegionCode(), - ], - Address::KEY_STREET => $address->getStreet(), - Address::KEY_COMPANY => $address->getCompany(), - Address::KEY_TELEPHONE => $address->getTelephone(), - Address::KEY_POSTCODE => $address->getPostcode(), - Address::KEY_CITY => $address->getCity(), - Address::KEY_FIRSTNAME => $address->getFirstname(), - Address::KEY_LASTNAME => $address->getLastname(), - Address::KEY_EMAIL => $address->getEmail(), - Address::CUSTOM_ATTRIBUTES_KEY => [['attribute_code' => 'disable_auto_group_change', 'value' => null]], - ]; - - $cartId = $quote->getId(); - - $serviceInfo = [ - 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/billing-address', - 'httpMethod' => RestConfig::HTTP_METHOD_GET, - ], - 'soap' => [ - 'service' => self::SERVICE_NAME, - 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'GetAddress', - ], - ]; - - if (TESTS_WEB_API_ADAPTER == self::ADAPTER_SOAP) { - unset($data[Address::KEY_PREFIX]); - unset($data[Address::KEY_SUFFIX]); - unset($data[Address::KEY_MIDDLENAME]); - unset($data[Address::KEY_FAX]); - unset($data[Address::KEY_VAT_ID]); - } - - $requestData = ["cartId" => $cartId]; - $this->assertEquals($data, $this->_webApiCall($serviceInfo, $requestData)); - } -} diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceTest.php deleted file mode 100644 index 316e61db3d8dc7cecf061dbda246c35d2d2c1910..0000000000000000000000000000000000000000 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceTest.php +++ /dev/null @@ -1,112 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Address\Shipping; - -use Magento\Checkout\Service\V1\Data\Cart\Address; -use Magento\Checkout\Service\V1\Data\Cart\Address\Region; -use Magento\TestFramework\TestCase\WebapiAbstract; -use Magento\Webapi\Model\Rest\Config as RestConfig; - -class ReadServiceTest extends WebapiAbstract -{ - const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutAddressShippingReadServiceV1'; - const RESOURCE_PATH = '/V1/carts/'; - - /** - * @var \Magento\TestFramework\ObjectManager - */ - protected $objectManager; - - protected function setUp() - { - $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); - } - - /** - * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php - */ - public function testGetAddress() - { - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); - $quote->load('test_order_1', 'reserved_order_id'); - - /** @var \Magento\Quote\Model\Quote\Address $address */ - $address = $quote->getShippingAddress(); - - $data = [ - Address::KEY_COUNTRY_ID => $address->getCountryId(), - Address::KEY_ID => (int)$address->getId(), - Address::KEY_CUSTOMER_ID => $address->getCustomerId(), - Address::KEY_REGION => [ - Region::REGION => $address->getRegion(), - Region::REGION_ID => $address->getRegionId(), - Region::REGION_CODE => $address->getRegionCode(), - ], - Address::KEY_STREET => $address->getStreet(), - Address::KEY_COMPANY => $address->getCompany(), - Address::KEY_TELEPHONE => $address->getTelephone(), - Address::KEY_POSTCODE => $address->getPostcode(), - Address::KEY_CITY => $address->getCity(), - Address::KEY_FIRSTNAME => $address->getFirstname(), - Address::KEY_LASTNAME => $address->getLastname(), - Address::KEY_EMAIL => $address->getEmail(), - Address::CUSTOM_ATTRIBUTES_KEY => [['attribute_code' => 'disable_auto_group_change', 'value' => null]], - ]; - - $cartId = $quote->getId(); - - $serviceInfo = $this->getServiceInfo(); - $serviceInfo['rest']['resourcePath'] = str_replace('{cart_id}', $cartId, $serviceInfo['rest']['resourcePath']); - - if (TESTS_WEB_API_ADAPTER == self::ADAPTER_SOAP) { - unset($data[Address::KEY_PREFIX]); - unset($data[Address::KEY_SUFFIX]); - unset($data[Address::KEY_MIDDLENAME]); - unset($data[Address::KEY_FAX]); - unset($data[Address::KEY_VAT_ID]); - } - - $requestData = ["cartId" => $cartId]; - $this->assertEquals($data, $this->_webApiCall($serviceInfo, $requestData)); - } - - /** - * @magentoApiDataFixture Magento/Checkout/_files/quote_with_virtual_product_and_address.php - * - * @expectedException \Exception - * @expectedExceptionMessage Cart contains virtual product(s) only. Shipping address is not applicable - */ - public function testGetAddressOfQuoteWithVirtualProduct() - { - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); - $cartId = $quote->load('test_order_with_virtual_product', 'reserved_order_id')->getId(); - - $serviceInfo = $this->getServiceInfo(); - $serviceInfo['rest']['resourcePath'] = str_replace('{cart_id}', $cartId, $serviceInfo['rest']['resourcePath']); - - $this->_webApiCall($serviceInfo, ["cartId" => $cartId]); - } - - /** - * @return array - */ - protected function getServiceInfo() - { - return $serviceInfo = [ - 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . '{cart_id}/shipping-address', - 'httpMethod' => RestConfig::HTTP_METHOD_GET, - ], - 'soap' => [ - 'service' => self::SERVICE_NAME, - 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'GetAddress', - ], - ]; - } -} diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Coupon/ReadServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Coupon/ReadServiceTest.php deleted file mode 100644 index 4b8e7a4e32dcf154e99ae98945fd4b6bf1238845..0000000000000000000000000000000000000000 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Coupon/ReadServiceTest.php +++ /dev/null @@ -1,56 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Coupon; - -use Magento\Checkout\Service\V1\Data\Cart\Coupon as Coupon; -use Magento\TestFramework\TestCase\WebapiAbstract; -use Magento\Webapi\Model\Rest\Config as RestConfig; - -class ReadServiceTest extends WebapiAbstract -{ - const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutCouponReadServiceV1'; - const RESOURCE_PATH = '/V1/carts/'; - - /** - * @var \Magento\TestFramework\ObjectManager - */ - protected $objectManager; - - protected function setUp() - { - $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); - } - - /** - * @magentoApiDataFixture Magento/Checkout/_files/quote_with_coupon_saved.php - */ - public function testGet() - { - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); - $quote->load('test_order_1', 'reserved_order_id'); - $cartId = $quote->getId(); - $data = [ - Coupon::COUPON_CODE => $quote->getCouponCode(), - ]; - $serviceInfo = [ - 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/coupons', - 'httpMethod' => RestConfig::HTTP_METHOD_GET, - ], - 'soap' => [ - 'service' => self::SERVICE_NAME, - 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'Get', - ], - ]; - - $requestData = ["cartId" => $cartId]; - $this->assertEquals($data, $this->_webApiCall($serviceInfo, $requestData)); - } -} diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Item/ReadServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Item/ReadServiceTest.php deleted file mode 100644 index af342783b7a84d74794b588cdc27a0f78babce12..0000000000000000000000000000000000000000 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Item/ReadServiceTest.php +++ /dev/null @@ -1,66 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Item; - -use Magento\Checkout\Service\V1\Data\Cart\Item as Item; -use Magento\TestFramework\TestCase\WebapiAbstract; -use Magento\Webapi\Model\Rest\Config as RestConfig; - -class ReadServiceTest extends WebapiAbstract -{ - const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutItemReadServiceV1'; - const RESOURCE_PATH = '/V1/carts/'; - - /** - * @var \Magento\TestFramework\ObjectManager - */ - protected $objectManager; - - protected function setUp() - { - $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); - } - - /** - * @magentoApiDataFixture Magento/Checkout/_files/quote_with_items_saved.php - */ - public function testGetList() - { - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); - $quote->load('test_order_item_with_items', 'reserved_order_id'); - $cartId = $quote->getId(); - $output = []; - foreach ($quote->getAllItems() as $item) { - $data = [ - Item::ITEM_ID => $item->getId(), - Item::SKU => $item->getSku(), - Item::NAME => $item->getName(), - Item::PRICE => $item->getPrice(), - Item::QTY => $item->getQty(), - Item::PRODUCT_TYPE => $item->getProductType(), - ]; - - $output[] = $data; - } - $serviceInfo = [ - 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/items', - 'httpMethod' => RestConfig::HTTP_METHOD_GET, - ], - 'soap' => [ - 'service' => self::SERVICE_NAME, - 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'GetList', - ], - ]; - - $requestData = ["cartId" => $cartId]; - $this->assertEquals($output, $this->_webApiCall($serviceInfo, $requestData)); - } -} diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceTest.php deleted file mode 100644 index 9a1a0126b96dc57a18f70f6e426bd6a88b77eba7..0000000000000000000000000000000000000000 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceTest.php +++ /dev/null @@ -1,90 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\PaymentMethod; - -use Magento\Checkout\Service\V1\Data\PaymentMethod; -use Magento\TestFramework\TestCase\WebapiAbstract; -use Magento\Webapi\Model\Rest\Config as RestConfig; - -class ReadServiceTest extends WebapiAbstract -{ - const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutPaymentMethodReadServiceV1'; - const RESOURCE_PATH = '/V1/carts/'; - - /** - * @var \Magento\TestFramework\ObjectManager - */ - protected $objectManager; - - protected function setUp() - { - $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); - } - - /** - * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php - */ - public function testGetList() - { - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); - $quote->load('test_order_1', 'reserved_order_id'); - $cartId = $quote->getId(); - - $serviceInfo = [ - 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/payment-methods', - 'httpMethod' => RestConfig::HTTP_METHOD_GET, - ], - 'soap' => [ - 'service' => self::SERVICE_NAME, - 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'getList', - ], - ]; - - $requestData = ["cartId" => $cartId]; - $requestResponse = $this->_webApiCall($serviceInfo, $requestData); - - $expectedResponse = [ - PaymentMethod::CODE => 'checkmo', - PaymentMethod::TITLE => 'Check / Money order', - ]; - - $this->assertGreaterThan(0, count($requestResponse)); - $this->assertContains($expectedResponse, $requestResponse); - } - - /** - * @magentoApiDataFixture Magento/Checkout/_files/quote_with_payment_saved.php - */ - public function testGetPayment() - { - /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); - $quote->load('test_order_1_with_payment', 'reserved_order_id'); - $cartId = $quote->getId(); - - $serviceInfo = [ - 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/selected-payment-methods', - 'httpMethod' => RestConfig::HTTP_METHOD_GET, - ], - 'soap' => [ - 'service' => self::SERVICE_NAME, - 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'getPayment', - ], - ]; - - $requestData = ["cartId" => $cartId]; - $requestResponse = $this->_webApiCall($serviceInfo, $requestData); - - $this->assertArrayHasKey('method', $requestResponse); - $this->assertEquals('checkmo', $requestResponse['method']); - } -} diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceTest.php deleted file mode 100644 index 372088cd6e2a5c12fd4b84767447728ea25aa3c5..0000000000000000000000000000000000000000 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceTest.php +++ /dev/null @@ -1,107 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\ShippingMethod; - -use Magento\TestFramework\ObjectManager; -use Magento\TestFramework\TestCase\WebapiAbstract; -use Magento\Webapi\Model\Rest\Config as RestConfig; - -class WriteServiceTest extends WebapiAbstract -{ - /** - * @var ObjectManager - */ - private $objectManager; - - /** - * @var \Magento\Quote\Model\Quote - */ - protected $quote; - - protected function setUp() - { - $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); - $this->quote = $this->objectManager->create('Magento\Quote\Model\Quote'); - } - - protected function getServiceInfo() - { - return [ - 'rest' => [ - 'resourcePath' => '/V1/carts/' . $this->quote->getId() . '/selected-shipping-method', - 'httpMethod' => RestConfig::HTTP_METHOD_PUT, - ], - 'soap' => [ - 'service' => 'checkoutShippingMethodWriteServiceV1', - 'serviceVersion' => 'V1', - 'operation' => 'checkoutShippingMethodWriteServiceV1SetMethod', - ], - ]; - } - - /** - * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php - */ - public function testSetMethod() - { - $this->quote->load('test_order_1', 'reserved_order_id'); - $serviceInfo = $this->getServiceInfo(); - - $requestData = [ - 'cartId' => $this->quote->getId(), - 'carrierCode' => 'flatrate', - 'methodCode' => 'flatrate', - ]; - $result = $this->_webApiCall($serviceInfo, $requestData); - $this->assertEquals(true, $result); - } - - /** - * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php - */ - public function testSetMethodWrongMethod() - { - $this->quote->load('test_order_1', 'reserved_order_id'); - $serviceInfo = $this->getServiceInfo(); - - $requestData = [ - 'cartId' => $this->quote->getId(), - 'carrierCode' => 'flatrate', - 'methodCode' => 'wrongMethod', - ]; - try { - $this->_webApiCall($serviceInfo, $requestData); - } catch (\SoapFault $e) { - $message = $e->getMessage(); - } catch (\Exception $e) { - $message = json_decode($e->getMessage())->message; - } - $this->assertEquals('Carrier with such method not found: flatrate, wrongMethod', $message); - } - - /** - * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php - */ - public function testSetMethodWithoutShippingAddress() - { - $this->quote->load('test_order_with_simple_product_without_address', 'reserved_order_id'); - $serviceInfo = $this->getServiceInfo(); - - $requestData = [ - 'cartId' => $this->quote->getId(), - 'carrierCode' => 'flatrate', - 'methodCode' => 'flatrate', - ]; - try { - $this->_webApiCall($serviceInfo, $requestData); - } catch (\SoapFault $e) { - $message = $e->getMessage(); - } catch (\Exception $e) { - $message = json_decode($e->getMessage())->message; - } - $this->assertEquals('Shipping address is not set', $message); - } -} diff --git a/dev/tests/api-functional/testsuite/Magento/CheckoutAgreements/Service/V1/Agreement/ReadServiceTest.php b/dev/tests/api-functional/testsuite/Magento/CheckoutAgreements/Api/CheckoutAgreementsRepositoryTest.php similarity index 90% rename from dev/tests/api-functional/testsuite/Magento/CheckoutAgreements/Service/V1/Agreement/ReadServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/CheckoutAgreements/Api/CheckoutAgreementsRepositoryTest.php index 2e7bbc45370db071493ac57e783227d1181bcba9..392219a98f1469f8bac629e5fb666e4e858ac624 100644 --- a/dev/tests/api-functional/testsuite/Magento/CheckoutAgreements/Service/V1/Agreement/ReadServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/CheckoutAgreements/Api/CheckoutAgreementsRepositoryTest.php @@ -3,12 +3,12 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\CheckoutAgreements\Service\V1\Agreement; +namespace Magento\CheckoutAgreements\Api; use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class ReadServiceTest extends WebapiAbstract +class CheckoutAgreementsRepositoryTest extends WebapiAbstract { /** * @var array @@ -19,9 +19,9 @@ class ReadServiceTest extends WebapiAbstract { $this->listServiceInfo = [ 'soap' => [ - 'service' => 'checkoutAgreementsAgreementReadServiceV1', + 'service' => 'checkoutAgreementsCheckoutAgreementsRepositoryV1', 'serviceVersion' => 'V1', - 'operation' => 'checkoutAgreementsAgreementReadServiceV1GetList', + 'operation' => 'checkoutAgreementsCheckoutAgreementsRepositoryV1getList', ], 'rest' => [ 'resourcePath' => '/V1/carts/licence/', @@ -74,12 +74,12 @@ class ReadServiceTest extends WebapiAbstract $agreements = $this->_webApiCall($this->listServiceInfo, []); $this->assertCount(1, $agreements); $agreementData = $agreements[0]; - $this->assertEquals($agreementModel->getId(), $agreementData['id']); + $this->assertEquals($agreementModel->getId(), $agreementData['agreement_id']); $this->assertEquals($agreementModel->getName(), $agreementData['name']); $this->assertEquals($agreementModel->getContent(), $agreementData['content']); $this->assertEquals($agreementModel->getContentHeight(), $agreementData['content_height']); $this->assertEquals($agreementModel->getCheckboxText(), $agreementData['checkbox_text']); - $this->assertEquals($agreementModel->getIsActive(), $agreementData['active']); - $this->assertEquals($agreementModel->getIsHtml(), $agreementData['html']); + $this->assertEquals($agreementModel->getIsActive(), $agreementData['is_active']); + $this->assertEquals($agreementModel->getIsHtml(), $agreementData['is_html']); } } diff --git a/dev/tests/api-functional/testsuite/Magento/ConfigurableProduct/Api/OptionRepositoryTest.php b/dev/tests/api-functional/testsuite/Magento/ConfigurableProduct/Api/OptionRepositoryTest.php index 7bf583b74df506d70c5ebb84d4bcef77c81216b9..1c4993fd6ca1921a2d3c2fe7b065198a3c3dbd8f 100644 --- a/dev/tests/api-functional/testsuite/Magento/ConfigurableProduct/Api/OptionRepositoryTest.php +++ b/dev/tests/api-functional/testsuite/Magento/ConfigurableProduct/Api/OptionRepositoryTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ConfigurableProduct\Api; use Magento\Webapi\Model\Rest\Config; diff --git a/dev/tests/api-functional/testsuite/Magento/Customer/Api/AddressMetadataTest.php b/dev/tests/api-functional/testsuite/Magento/Customer/Api/AddressMetadataTest.php index 4a85003340c26a9100690283ad601419efac2765..4f701f7b038ddf52a7e2022479733a1469676b97 100644 --- a/dev/tests/api-functional/testsuite/Magento/Customer/Api/AddressMetadataTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Customer/Api/AddressMetadataTest.php @@ -195,6 +195,7 @@ class AddressMetadataTest extends WebapiAbstract * @param array $expectedResult * @param array $actualResult * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function checkValidationRules($expectedResult, $actualResult) { diff --git a/dev/tests/api-functional/testsuite/Magento/Customer/Api/AddressRepositoryTest.php b/dev/tests/api-functional/testsuite/Magento/Customer/Api/AddressRepositoryTest.php index 6d8fa26eb22ea148d2d0a5aae4f4b1777110b8d9..371c7229b112c60b8a5ac7d44c2c7bd6c4075812 100644 --- a/dev/tests/api-functional/testsuite/Magento/Customer/Api/AddressRepositoryTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Customer/Api/AddressRepositoryTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Api; use Magento\TestFramework\Helper\Bootstrap; diff --git a/dev/tests/api-functional/testsuite/Magento/Customer/Api/CustomerMetadataTest.php b/dev/tests/api-functional/testsuite/Magento/Customer/Api/CustomerMetadataTest.php index 1d028b00d348a155ff1065d6388b9b092eb3e47f..c0ffddb6f33942b7fbfb650dc6947993e87f8bea 100644 --- a/dev/tests/api-functional/testsuite/Magento/Customer/Api/CustomerMetadataTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Customer/Api/CustomerMetadataTest.php @@ -256,6 +256,7 @@ class CustomerMetadataTest extends WebapiAbstract * @param array $expectedResult * @param array $actualResult * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function checkValidationRules($expectedResult, $actualResult) { diff --git a/dev/tests/api-functional/testsuite/Magento/Downloadable/Service/V1/DownloadableLink/WriteServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Downloadable/Service/V1/DownloadableLink/WriteServiceTest.php index be271d6775cccc858793b60c54e6e6602f1bf0f1..b398ffcaa81fd5a91e8419069d5efe1018b32aa2 100644 --- a/dev/tests/api-functional/testsuite/Magento/Downloadable/Service/V1/DownloadableLink/WriteServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Downloadable/Service/V1/DownloadableLink/WriteServiceTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Service\V1\DownloadableLink; use Magento\Catalog\Model\Product; diff --git a/dev/tests/api-functional/testsuite/Magento/Downloadable/Service/V1/DownloadableSample/WriteServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Downloadable/Service/V1/DownloadableSample/WriteServiceTest.php index a322af9750842faf335e2a38cffbd9a8761a3633..f6a35621f59edf42b73235ed97f9ce78c38cd7f4 100644 --- a/dev/tests/api-functional/testsuite/Magento/Downloadable/Service/V1/DownloadableSample/WriteServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Downloadable/Service/V1/DownloadableSample/WriteServiceTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Downloadable\Service\V1\DownloadableSample; use Magento\Catalog\Model\Product; diff --git a/dev/tests/api-functional/testsuite/Magento/Framework/Stdlib/CookieManagerTest.php b/dev/tests/api-functional/testsuite/Magento/Framework/Stdlib/CookieManagerTest.php index c6f10aab5508ca9c126db72a1f3b586279dc12af..219416fd6db0c23aef5782eff447bd2386d6623b 100644 --- a/dev/tests/api-functional/testsuite/Magento/Framework/Stdlib/CookieManagerTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Framework/Stdlib/CookieManagerTest.php @@ -152,6 +152,7 @@ class CookieManagerTest extends \Magento\TestFramework\TestCase\WebapiAbstract * @param string $cookieName * @param array $cookies * @return $cookie|null + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ private function findCookie($cookieName, $cookies) { diff --git a/dev/tests/api-functional/testsuite/Magento/GiftMessage/Service/V1/ReadServiceTest.php b/dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/CartRepositoryTest.php similarity index 63% rename from dev/tests/api-functional/testsuite/Magento/GiftMessage/Service/V1/ReadServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/CartRepositoryTest.php index 0f2b0fc0bac7b844346a0d99a1ecf54c5a1eb39d..b34a8ab1ff966768b881821568227a3fbc196895 100644 --- a/dev/tests/api-functional/testsuite/Magento/GiftMessage/Service/V1/ReadServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/CartRepositoryTest.php @@ -4,15 +4,15 @@ * See COPYING.txt for license details. */ -namespace Magento\GiftMessage\Service\V1; +namespace Magento\GiftMessage\Api; use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class ReadServiceTest extends WebapiAbstract +class CartRepositoryTest extends WebapiAbstract { const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'giftMessageReadServiceV1'; + const SERVICE_NAME = 'giftMessageCartRepositoryV1'; const RESOURCE_PATH = '/V1/carts/'; /** @@ -64,39 +64,43 @@ class ReadServiceTest extends WebapiAbstract /** * @magentoApiDataFixture Magento/GiftMessage/_files/quote_with_item_message.php */ - public function testGetItemMessage() + public function testSave() { + // sales/gift_options/allow_order must be set to 1 in system configuration + // @todo remove next statement when \Magento\TestFramework\TestCase\WebapiAbstract::_updateAppConfig is fixed + $this->markTestIncomplete('This test relies on system configuration state.'); /** @var \Magento\Quote\Model\Quote $quote */ $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); $quote->load('test_order_item_with_message', 'reserved_order_id'); - $product = $this->objectManager->create('Magento\Catalog\Model\Product'); - $product->load($product->getIdBySku('simple_with_message')); - $itemId = $quote->getItemByProduct($product)->getId(); - /** @var \Magento\Catalog\Model\Product $product */ + $cartId = $quote->getId(); $serviceInfo = [ 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/gift-message/' . $itemId, - 'httpMethod' => RestConfig::HTTP_METHOD_GET, + 'resourcePath' => self::RESOURCE_PATH . $cartId . '/gift-message', + 'httpMethod' => RestConfig::HTTP_METHOD_POST, ], 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'getItemMessage', + 'operation' => self::SERVICE_NAME . 'Save', ], ]; - $expectedMessage = [ - 'recipient' => 'Jane Roe', - 'sender' => 'John Doe', - 'message' => 'Gift Message Text', + $requestData = [ + 'cartId' => $cartId, + 'giftMessage' => [ + 'recipient' => 'John Doe', + 'sender' => 'Jane Roe', + 'message' => 'Gift Message Text New', + ], ]; - - $requestData = ["cartId" => $cartId, "itemId" => $itemId]; - $resultMessage = $this->_webApiCall($serviceInfo, $requestData); - $this->assertCount(5, $resultMessage); - unset($resultMessage['gift_message_id']); - unset($resultMessage['customer_id']); - $this->assertEquals($expectedMessage, $resultMessage); + $this->assertTrue($this->_webApiCall($serviceInfo, $requestData)); + $quote->load('test_order_item_with_message', 'reserved_order_id'); + $quote->getGiftMessageId(); + /** @var \Magento\GiftMessage\Model\Message $message */ + $message = $this->objectManager->create('Magento\GiftMessage\Model\Message')->load($quote->getGiftMessageId()); + $this->assertEquals('John Doe', $message->getRecipient()); + $this->assertEquals('Jane Roe', $message->getSender()); + $this->assertEquals('Gift Message Text New', $message->getMessage()); } } diff --git a/dev/tests/api-functional/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php b/dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/ItemRepositoryTest.php similarity index 66% rename from dev/tests/api-functional/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/ItemRepositoryTest.php index a5161f2e2b83077a4edc6ee8e715f84875ea22d1..fe797f5fca2a55c626623d91eba06de51587904f 100644 --- a/dev/tests/api-functional/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/ItemRepositoryTest.php @@ -4,15 +4,17 @@ * See COPYING.txt for license details. */ -namespace Magento\GiftMessage\Service\V1; +// @codingStandardsIgnoreFile + +namespace Magento\GiftMessage\Api; use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class WriteServiceTest extends WebapiAbstract +class ItemRepositoryTest extends WebapiAbstract { const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'giftMessageWriteServiceV1'; + const SERVICE_NAME = 'giftMessageItemRepositoryV1'; const RESOURCE_PATH = '/V1/carts/'; /** @@ -28,50 +30,46 @@ class WriteServiceTest extends WebapiAbstract /** * @magentoApiDataFixture Magento/GiftMessage/_files/quote_with_item_message.php */ - public function testSetForQuote() + public function testGet() { - // sales/gift_options/allow_order must be set to 1 in system configuration - // @todo remove next statement when \Magento\TestFramework\TestCase\WebapiAbstract::_updateAppConfig is fixed - $this->markTestIncomplete('This test relies on system configuration state.'); /** @var \Magento\Quote\Model\Quote $quote */ $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); $quote->load('test_order_item_with_message', 'reserved_order_id'); - + $product = $this->objectManager->create('Magento\Catalog\Model\Product'); + $product->load($product->getIdBySku('simple_with_message')); + $itemId = $quote->getItemByProduct($product)->getId(); + /** @var \Magento\Catalog\Model\Product $product */ $cartId = $quote->getId(); $serviceInfo = [ 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/gift-message', - 'httpMethod' => RestConfig::HTTP_METHOD_PUT, + 'resourcePath' => self::RESOURCE_PATH . $cartId . '/gift-message/' . $itemId, + 'httpMethod' => RestConfig::HTTP_METHOD_GET, ], 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'SetForQuote', + 'operation' => self::SERVICE_NAME . 'Get', ], ]; - $requestData = [ - 'cartId' => $cartId, - 'giftMessage' => [ - 'recipient' => 'John Doe', - 'sender' => 'Jane Roe', - 'message' => 'Gift Message Text New', - ], + $expectedMessage = [ + 'recipient' => 'Jane Roe', + 'sender' => 'John Doe', + 'message' => 'Gift Message Text', ]; - $this->assertTrue($this->_webApiCall($serviceInfo, $requestData)); - $quote->load('test_order_item_with_message', 'reserved_order_id'); - $quote->getGiftMessageId(); - /** @var \Magento\GiftMessage\Model\Message $message */ - $message = $this->objectManager->create('Magento\GiftMessage\Model\Message')->load($quote->getGiftMessageId()); - $this->assertEquals('John Doe', $message->getRecipient()); - $this->assertEquals('Jane Roe', $message->getSender()); - $this->assertEquals('Gift Message Text New', $message->getMessage()); + + $requestData = ["cartId" => $cartId, "itemId" => $itemId]; + $resultMessage = $this->_webApiCall($serviceInfo, $requestData); + $this->assertCount(5, $resultMessage); + unset($resultMessage['gift_message_id']); + unset($resultMessage['customer_id']); + $this->assertEquals($expectedMessage, $resultMessage); } /** * @magentoApiDataFixture Magento/GiftMessage/_files/quote_with_item_message.php */ - public function testSetForItem() + public function testSave() { // sales/gift_options/allow_items must be set to 1 in system configuration // @todo remove next statement when \Magento\TestFramework\TestCase\WebapiAbstract::_updateAppConfig is fixed @@ -86,12 +84,12 @@ class WriteServiceTest extends WebapiAbstract $serviceInfo = [ 'rest' => [ 'resourcePath' => self::RESOURCE_PATH . $cartId . '/gift-message/' . $itemId, - 'httpMethod' => RestConfig::HTTP_METHOD_PUT, + 'httpMethod' => RestConfig::HTTP_METHOD_POST, ], 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'SetForItem', + 'operation' => self::SERVICE_NAME . 'Save', ], ]; diff --git a/dev/tests/api-functional/testsuite/Magento/Integration/Service/V1/CustomerTokenServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Integration/Service/V1/CustomerTokenServiceTest.php index 03318d3bffac91c0dbed9360efed9e4ba89658ae..c565a0e9bb846e00c7a68225265a159dd6d9108f 100644 --- a/dev/tests/api-functional/testsuite/Magento/Integration/Service/V1/CustomerTokenServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Integration/Service/V1/CustomerTokenServiceTest.php @@ -83,6 +83,7 @@ class CustomerTokenServiceTest extends WebapiAbstract /** * @dataProvider validationDataProvider + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function testCreateCustomerAccessTokenEmptyOrNullCredentials($username, $password) { diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Billing/WriteServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Quote/Api/BillingAddressManagementTest.php similarity index 50% rename from dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Billing/WriteServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/Quote/Api/BillingAddressManagementTest.php index 4644c779b9bb50895ccda8993e7652be20049af3..ec4e8a0d5089878d61bbde2dda7be3194c552407 100644 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Billing/WriteServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Quote/Api/BillingAddressManagementTest.php @@ -4,15 +4,16 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Address\Billing; +namespace Magento\Quote\Api; +use Magento\Quote\Api\Data\AddressInterface; use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class WriteServiceTest extends WebapiAbstract +class BillingAddressManagementTest extends WebapiAbstract { const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutAddressBillingWriteServiceV1'; + const SERVICE_NAME = 'quoteBillingAddressManagementV1'; const RESOURCE_PATH = '/V1/carts/'; /** @@ -20,15 +21,55 @@ class WriteServiceTest extends WebapiAbstract */ protected $objectManager; - /** - * @var \Magento\Checkout\Service\V1\Data\Cart\AddressBuilder - */ - protected $builder; - protected function setUp() { $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); - $this->builder = $this->objectManager->create('Magento\Checkout\Service\V1\Data\Cart\AddressBuilder'); + } + + /** + * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php + */ + public function testGetAddress() + { + $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote->load('test_order_1', 'reserved_order_id'); + + /** @var \Magento\Quote\Model\Quote\Address $address */ + $address = $quote->getBillingAddress(); + + $data = [ + AddressInterface::KEY_COUNTRY_ID => $address->getCountryId(), + AddressInterface::KEY_ID => (int)$address->getId(), + AddressInterface::KEY_CUSTOMER_ID => $address->getCustomerId(), + AddressInterface::REGION => $address->getRegion(), + AddressInterface::REGION_ID => $address->getRegionId(), + AddressInterface::REGION_CODE => $address->getRegionCode(), + AddressInterface::KEY_STREET => $address->getStreet(), + AddressInterface::KEY_COMPANY => $address->getCompany(), + AddressInterface::KEY_TELEPHONE => $address->getTelephone(), + AddressInterface::KEY_POSTCODE => $address->getPostcode(), + AddressInterface::KEY_CITY => $address->getCity(), + AddressInterface::KEY_FIRSTNAME => $address->getFirstname(), + AddressInterface::KEY_LASTNAME => $address->getLastname(), + AddressInterface::KEY_EMAIL => $address->getEmail() + ]; + + $cartId = $quote->getId(); + + $serviceInfo = [ + 'rest' => [ + 'resourcePath' => self::RESOURCE_PATH . $cartId . '/billing-address', + 'httpMethod' => RestConfig::HTTP_METHOD_GET, + ], + 'soap' => [ + 'service' => self::SERVICE_NAME, + 'serviceVersion' => self::SERVICE_VERSION, + 'operation' => self::SERVICE_NAME . 'Get', + ], + ]; + + $requestData = ["cartId" => $cartId]; + $this->assertEquals($data, $this->_webApiCall($serviceInfo, $requestData)); } /** @@ -48,7 +89,7 @@ class WriteServiceTest extends WebapiAbstract 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'SetAddress', + 'operation' => self::SERVICE_NAME . 'Assign', ], ]; @@ -59,11 +100,9 @@ class WriteServiceTest extends WebapiAbstract 'company' => 'eBay Inc', 'street' => ['Typical Street', 'Tiny House 18'], 'city' => 'Big City', - 'region' => [ - 'region_id' => 12, - 'region' => 'California', - 'region_code' => 'CA', - ], + 'region_id' => 12, + 'region' => 'California', + 'region_code' => 'CA', 'postcode' => '0985432', 'country_id' => 'US', 'telephone' => '88776655', @@ -71,7 +110,7 @@ class WriteServiceTest extends WebapiAbstract ]; $requestData = [ "cartId" => $quote->getId(), - 'addressData' => $addressData, + 'address' => $addressData, ]; $addressId = $this->_webApiCall($serviceInfo, $requestData); @@ -79,16 +118,15 @@ class WriteServiceTest extends WebapiAbstract //reset $quote to reload data $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); $quote->load('test_order_1', 'reserved_order_id'); - $savedData = $quote->getBillingAddress()->getData(); + $address = $quote->getBillingAddress(); + $address->getRegionCode(); + $savedData = $address->getData(); $this->assertEquals($addressId, $savedData['address_id']); //custom checks for street, region and address_type foreach ($addressData['street'] as $streetLine) { $this->assertContains($streetLine, $quote->getBillingAddress()->getStreet()); } unset($addressData['street']); - $this->assertEquals($addressData['region']['region_id'], $savedData['region_id']); - $this->assertEquals($addressData['region']['region'], $savedData['region']); - unset($addressData['region']); $this->assertEquals('billing', $savedData['address_type']); //check the rest of fields foreach ($addressData as $key => $value) { diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Item/WriteServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Quote/Api/CartItemRepositoryTest.php similarity index 61% rename from dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Item/WriteServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/Quote/Api/CartItemRepositoryTest.php index 4faa6cd4ffebd6b4fcdf7209a1b7c492eb02162e..3938820417255b9ff5046eee897b84ee286df65a 100644 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Item/WriteServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Quote/Api/CartItemRepositoryTest.php @@ -1,18 +1,18 @@ <?php /** + * * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ - -namespace Magento\Checkout\Service\V1\Item; +namespace Magento\Quote\Api; use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class WriteServiceTest extends WebapiAbstract +class CartItemRepositoryTest extends WebapiAbstract { const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutItemWriteServiceV1'; + const SERVICE_NAME = 'quoteCartItemRepositoryV1'; const RESOURCE_PATH = '/V1/carts/'; /** @@ -25,12 +25,53 @@ class WriteServiceTest extends WebapiAbstract $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); } + /** + * @magentoApiDataFixture Magento/Checkout/_files/quote_with_items_saved.php + */ + public function testGetList() + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote->load('test_order_item_with_items', 'reserved_order_id'); + $cartId = $quote->getId(); + $output = []; + /** @var \Magento\Quote\Api\Data\CartItemInterface $item */ + foreach ($quote->getAllItems() as $item) { + $data = [ + 'item_id' => $item->getItemId(), + 'sku' => $item->getSku(), + 'name' => $item->getName(), + 'price' => $item->getPrice(), + 'qty' => $item->getQty(), + 'product_type' => $item->getProductType(), + 'quote_id' => $item->getQuoteId() + ]; + + $output[] = $data; + } + $serviceInfo = [ + 'rest' => [ + 'resourcePath' => self::RESOURCE_PATH . $cartId . '/items', + 'httpMethod' => RestConfig::HTTP_METHOD_GET, + ], + 'soap' => [ + 'service' => self::SERVICE_NAME, + 'serviceVersion' => self::SERVICE_VERSION, + 'operation' => self::SERVICE_NAME . 'GetList', + ], + ]; + + $requestData = ["cartId" => $cartId]; + $this->assertEquals($output, $this->_webApiCall($serviceInfo, $requestData)); + } + /** * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php * @magentoApiDataFixture Magento/Catalog/_files/product_simple.php */ public function testAddItem() { + /** @var \Magento\Catalog\Model\Product $product */ $product = $this->objectManager->create('Magento\Catalog\Model\Product')->load(2); $productSku = $product->getSku(); /** @var \Magento\Quote\Model\Quote $quote */ @@ -39,21 +80,21 @@ class WriteServiceTest extends WebapiAbstract $cartId = $quote->getId(); $serviceInfo = [ 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/items', + 'resourcePath' => self::RESOURCE_PATH . 'items', 'httpMethod' => RestConfig::HTTP_METHOD_POST, ], 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'AddItem', + 'operation' => self::SERVICE_NAME . 'Save', ], ]; $requestData = [ - "cartId" => $cartId, - "data" => [ + "cartItem" => [ "sku" => $productSku, "qty" => 7, + "quote_id" => $cartId, ], ]; $this->_webApiCall($serviceInfo, $requestData); @@ -82,7 +123,7 @@ class WriteServiceTest extends WebapiAbstract 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'RemoveItem', + 'operation' => self::SERVICE_NAME . 'DeleteById', ], ]; @@ -111,27 +152,38 @@ class WriteServiceTest extends WebapiAbstract $itemId = $quote->getItemByProduct($product)->getId(); $serviceInfo = [ 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/items/' . $itemId, + 'resourcePath' => self::RESOURCE_PATH . 'items/' . $itemId, 'httpMethod' => RestConfig::HTTP_METHOD_PUT, ], 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'UpdateItem', + 'operation' => self::SERVICE_NAME . 'Save', ], ]; - $requestData = [ - "cartId" => $cartId, - "itemId" => $itemId, - "data" => [ - "qty" => 5, - ], - ]; - $this->assertTrue($this->_webApiCall($serviceInfo, $requestData)); + if (TESTS_WEB_API_ADAPTER == self::ADAPTER_SOAP) { + $requestData = [ + "cartItem" => [ + "qty" => 5, + "quote_id" => $cartId, + "itemId" => $itemId, + ], + ]; + } else { + $requestData = [ + "cartItem" => [ + "qty" => 5, + "quote_id" => $cartId, + ], + ]; + } + $this->_webApiCall($serviceInfo, $requestData); $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); $quote->load('test_order_item_with_items', 'reserved_order_id'); $this->assertTrue($quote->hasProductId(1)); - $this->assertEquals(5, $quote->getItemByProduct($product)->getQty()); + $item = $quote->getItemByProduct($product); + $this->assertEquals(5, $item->getQty()); + $this->assertEquals($itemId, $item->getItemId()); } } diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Quote/Api/CartManagementTest.php similarity index 68% rename from dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/Quote/Api/CartManagementTest.php index 70f3ba753b99bb0c189690edc10cacc17a1240fb..4a4be8cbde228eb1a957eebb672d9e8be4a7e144 100644 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Quote/Api/CartManagementTest.php @@ -4,15 +4,15 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Cart; +namespace Magento\Quote\Api; use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class WriteServiceTest extends WebapiAbstract +class CartManagementTest extends WebapiAbstract { const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutCartWriteServiceV1'; + const SERVICE_NAME = 'quoteCartManagementV1'; const RESOURCE_PATH = '/V1/carts/'; protected $createdQuotes = []; @@ -37,11 +37,12 @@ class WriteServiceTest extends WebapiAbstract 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'Create', + 'operation' => self::SERVICE_NAME . 'CreateEmptyCart', ], ]; - $quoteId = $this->_webApiCall($serviceInfo); + $requestData = ['storeId' => 1]; + $quoteId = $this->_webApiCall($serviceInfo, $requestData); $this->assertGreaterThan(0, $quoteId); $this->createdQuotes[] = $quoteId; } @@ -77,15 +78,16 @@ class WriteServiceTest extends WebapiAbstract 'httpMethod' => RestConfig::HTTP_METHOD_PUT, ], 'soap' => [ - 'service' => 'checkoutCartWriteServiceV1', + 'service' => self::SERVICE_NAME, 'serviceVersion' => 'V1', - 'operation' => 'checkoutCartWriteServiceV1AssignCustomer', + 'operation' => self::SERVICE_NAME . 'AssignCustomer', ], ]; $requestData = [ 'cartId' => $cartId, 'customerId' => $customerId, + 'storeId' => 1, ]; // Cart must be anonymous (see fixture) $this->assertEmpty($quote->getCustomerId()); @@ -112,8 +114,8 @@ class WriteServiceTest extends WebapiAbstract $serviceInfo = [ 'soap' => [ 'serviceVersion' => 'V1', - 'service' => 'checkoutCartWriteServiceV1', - 'operation' => 'checkoutCartWriteServiceV1AssignCustomer', + 'service' => self::SERVICE_NAME, + 'operation' => self::SERVICE_NAME . 'AssignCustomer', ], 'rest' => [ 'resourcePath' => '/V1/carts/' . $cartId, @@ -123,6 +125,7 @@ class WriteServiceTest extends WebapiAbstract $requestData = [ 'cartId' => $cartId, 'customerId' => $customerId, + 'storeId' => 1, ]; $this->_webApiCall($serviceInfo, $requestData); @@ -138,9 +141,9 @@ class WriteServiceTest extends WebapiAbstract $customerId = 1; $serviceInfo = [ 'soap' => [ - 'service' => 'checkoutCartWriteServiceV1', + 'service' => self::SERVICE_NAME, 'serviceVersion' => 'V1', - 'operation' => 'checkoutCartWriteServiceV1AssignCustomer', + 'operation' => self::SERVICE_NAME . 'AssignCustomer', ], 'rest' => [ 'resourcePath' => '/V1/carts/' . $cartId, @@ -150,6 +153,7 @@ class WriteServiceTest extends WebapiAbstract $requestData = [ 'cartId' => $cartId, 'customerId' => $customerId, + 'storeId' => 1, ]; $this->_webApiCall($serviceInfo, $requestData); @@ -175,15 +179,16 @@ class WriteServiceTest extends WebapiAbstract 'resourcePath' => '/V1/carts/' . $cartId, ], 'soap' => [ - 'service' => 'checkoutCartWriteServiceV1', + 'service' => self::SERVICE_NAME, 'serviceVersion' => 'V1', - 'operation' => 'checkoutCartWriteServiceV1AssignCustomer', + 'operation' => self::SERVICE_NAME . 'AssignCustomer', ], ]; $requestData = [ 'cartId' => $cartId, 'customerId' => $customerId, + 'storeId' => 1, ]; $this->_webApiCall($serviceInfo, $requestData); } @@ -207,9 +212,9 @@ class WriteServiceTest extends WebapiAbstract $serviceInfo = [ 'soap' => [ - 'service' => 'checkoutCartWriteServiceV1', + 'service' => self::SERVICE_NAME, 'serviceVersion' => 'V1', - 'operation' => 'checkoutCartWriteServiceV1AssignCustomer', + 'operation' => self::SERVICE_NAME . 'AssignCustomer', ], 'rest' => [ 'httpMethod' => RestConfig::HTTP_METHOD_PUT, @@ -220,6 +225,7 @@ class WriteServiceTest extends WebapiAbstract $requestData = [ 'cartId' => $cartId, 'customerId' => $customerId, + 'storeId' => 1, ]; $this->_webApiCall($serviceInfo, $requestData); } @@ -247,8 +253,8 @@ class WriteServiceTest extends WebapiAbstract $serviceInfo = [ 'soap' => [ - 'service' => 'checkoutCartWriteServiceV1', - 'operation' => 'checkoutCartWriteServiceV1AssignCustomer', + 'service' => self::SERVICE_NAME, + 'operation' => self::SERVICE_NAME . 'AssignCustomer', 'serviceVersion' => 'V1', ], 'rest' => [ @@ -260,6 +266,7 @@ class WriteServiceTest extends WebapiAbstract $requestData = [ 'cartId' => $cartId, 'customerId' => $customerId, + 'storeId' => 1, ]; $this->_webApiCall($serviceInfo, $requestData); } @@ -267,17 +274,16 @@ class WriteServiceTest extends WebapiAbstract /** * @magentoApiDataFixture Magento/Checkout/_files/quote_with_check_payment.php */ - public function testOrderPlacesOrder() + public function testPlaceOrder() { /** @var $quote \Magento\Quote\Model\Quote */ $quote = $this->objectManager->create('Magento\Quote\Model\Quote')->load('test_order_1', 'reserved_order_id'); - $cartId = $quote->getId(); $serviceInfo = [ 'soap' => [ - 'service' => 'checkoutCartWriteServiceV1', - 'operation' => 'checkoutCartWriteServiceV1Order', + 'service' => 'quoteCartManagementV1', + 'operation' => 'quoteCartManagementV1PlaceOrder', 'serviceVersion' => 'V1', ], 'rest' => [ @@ -286,15 +292,76 @@ class WriteServiceTest extends WebapiAbstract ], ]; - $requestData = [ - 'cartId' => $cartId, - ]; - $this->_webApiCall($serviceInfo, $requestData); + $orderId = $this->_webApiCall($serviceInfo, ['cartId' => $cartId]); + /** @var \Magento\Sales\Model\Order $order */ - $order = $this->objectManager->create('Magento\Sales\Model\Order')->load(1); + $order = $this->objectManager->create('Magento\Sales\Model\Order')->load($orderId); $items = $order->getAllItems(); $this->assertCount(1, $items); $this->assertEquals('Simple Product', $items[0]->getName()); $quote->delete(); } + + /** + * @magentoApiDataFixture Magento/Sales/_files/quote_with_customer.php + */ + public function testGetCartForCustomer() + { + $cart = $this->getCart('test01'); + $customerId = $cart->getCustomer()->getId(); + + $serviceInfo = [ + 'rest' => [ + 'resourcePath' => '/V1/customer/' . $customerId . '/cart', + 'httpMethod' => RestConfig::HTTP_METHOD_GET, + ], + 'soap' => [ + 'service' => 'quoteCartManagementV1', + 'serviceVersion' => 'V1', + 'operation' => 'quoteCartManagementV1GetCartForCustomer', + ], + ]; + + $requestData = ['customerId' => $customerId]; + $cartData = $this->_webApiCall($serviceInfo, $requestData); + + $this->assertEquals($cart->getId(), $cartData['id']); + $this->assertEquals($cart->getCreatedAt(), $cartData['created_at']); + $this->assertEquals($cart->getUpdatedAt(), $cartData['updated_at']); + $this->assertEquals($cart->getIsActive(), $cartData['is_active']); + $this->assertEquals($cart->getIsVirtual(), $cartData['is_virtual']); + $this->assertEquals($cart->getOrigOrderId(), $cartData['orig_order_id']); + $this->assertEquals($cart->getItemsCount(), $cartData['items_count']); + $this->assertEquals($cart->getItemsQty(), $cartData['items_qty']); + + $this->assertContains('customer', $cartData); + $this->assertEquals(false, $cartData['customer_is_guest']); + $this->assertContains('currency', $cartData); + $this->assertEquals($cart->getGlobalCurrencyCode(), $cartData['currency']['global_currency_code']); + $this->assertEquals($cart->getBaseCurrencyCode(), $cartData['currency']['base_currency_code']); + $this->assertEquals($cart->getQuoteCurrencyCode(), $cartData['currency']['quote_currency_code']); + $this->assertEquals($cart->getStoreCurrencyCode(), $cartData['currency']['store_currency_code']); + $this->assertEquals($cart->getBaseToGlobalRate(), $cartData['currency']['base_to_global_rate']); + $this->assertEquals($cart->getBaseToQuoteRate(), $cartData['currency']['base_to_quote_rate']); + $this->assertEquals($cart->getStoreToBaseRate(), $cartData['currency']['store_to_base_rate']); + $this->assertEquals($cart->getStoreToQuoteRate(), $cartData['currency']['store_to_quote_rate']); + } + + /** + * Retrieve quote by given reserved order ID + * + * @param string $reservedOrderId + * @return \Magento\Quote\Model\Quote + * @throws \InvalidArgumentException + */ + protected function getCart($reservedOrderId) + { + /** @var $cart \Magento\Quote\Model\Quote */ + $cart = $this->objectManager->get('Magento\Quote\Model\Quote'); + $cart->load($reservedOrderId, 'reserved_order_id'); + if (!$cart->getId()) { + throw new \InvalidArgumentException('There is no quote with provided reserved order ID.'); + } + return $cart; + } } diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Cart/ReadServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Quote/Api/CartRepositoryTest.php similarity index 61% rename from dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Cart/ReadServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/Quote/Api/CartRepositoryTest.php index c5f621411d6e96cea138e9e4fe17bea54e506bad..428d5cceeae59078e7c8c8225ea64d58b8d29818 100644 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Cart/ReadServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Quote/Api/CartRepositoryTest.php @@ -3,17 +3,18 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Cart; +namespace Magento\Quote\Api; -use Magento\Checkout\Service\V1\Data\Cart; use Magento\Framework\Api\FilterBuilder; use Magento\Framework\Api\SearchCriteria; use Magento\Framework\Api\SearchCriteriaBuilder; +use Magento\Framework\Api\SortOrderBuilder; +use Magento\Framework\Api\SortOrder; use Magento\TestFramework\ObjectManager; use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class ReadServiceTest extends WebapiAbstract +class CartRepositoryTest extends WebapiAbstract { /** * @var ObjectManager @@ -92,9 +93,9 @@ class ReadServiceTest extends WebapiAbstract 'httpMethod' => RestConfig::HTTP_METHOD_GET, ], 'soap' => [ - 'service' => 'checkoutCartReadServiceV1', + 'service' => 'quoteCartRepositoryV1', 'serviceVersion' => 'V1', - 'operation' => 'checkoutCartReadServiceV1GetCart', + 'operation' => 'quoteCartRepositoryV1Get', ], ]; @@ -103,18 +104,14 @@ class ReadServiceTest extends WebapiAbstract $this->assertEquals($cart->getId(), $cartData['id']); $this->assertEquals($cart->getCreatedAt(), $cartData['created_at']); $this->assertEquals($cart->getUpdatedAt(), $cartData['updated_at']); - $this->assertEquals($cart->getStoreId(), $cartData['store_id']); $this->assertEquals($cart->getIsActive(), $cartData['is_active']); $this->assertEquals($cart->getIsVirtual(), $cartData['is_virtual']); $this->assertEquals($cart->getOrigOrderId(), $cartData['orig_order_id']); $this->assertEquals($cart->getItemsCount(), $cartData['items_count']); $this->assertEquals($cart->getItemsQty(), $cartData['items_qty']); - + //following checks will be uncommented when all cart related services are ready $this->assertContains('customer', $cartData); - $this->assertEquals(1, $cartData['customer']['is_guest']); - $this->assertContains('totals', $cartData); - $this->assertEquals($cart->getSubtotal(), $cartData['totals']['subtotal']); - $this->assertEquals($cart->getGrandTotal(), $cartData['totals']['grand_total']); + $this->assertEquals(true, $cartData['customer_is_guest']); $this->assertContains('currency', $cartData); $this->assertEquals($cart->getGlobalCurrencyCode(), $cartData['currency']['global_currency_code']); $this->assertEquals($cart->getBaseCurrencyCode(), $cartData['currency']['base_currency_code']); @@ -136,9 +133,9 @@ class ReadServiceTest extends WebapiAbstract $serviceInfo = [ 'soap' => [ - 'service' => 'checkoutCartReadServiceV1', + 'service' => 'quoteCartRepositoryV1', 'serviceVersion' => 'V1', - 'operation' => 'checkoutCartReadServiceV1GetCart', + 'operation' => 'quoteCartRepositoryV1Get', ], 'rest' => [ 'resourcePath' => '/V1/carts/' . $cartId, @@ -151,60 +148,24 @@ class ReadServiceTest extends WebapiAbstract } /** - * @magentoApiDataFixture Magento/Sales/_files/quote_with_customer.php + * @magentoApiDataFixture Magento/Sales/_files/quote.php */ - public function testGetCartForCustomer() + public function testGetList() { $cart = $this->getCart('test01'); - $customerId = $cart->getCustomer()->getId(); $serviceInfo = [ 'rest' => [ - 'resourcePath' => '/V1/customer/' . $customerId . '/cart', - 'httpMethod' => RestConfig::HTTP_METHOD_GET, + 'resourcePath' => '/V1/carts', + 'httpMethod' => RestConfig::HTTP_METHOD_PUT, ], 'soap' => [ - 'service' => 'checkoutCartReadServiceV1', + 'service' => 'quoteCartRepositoryV1', 'serviceVersion' => 'V1', - 'operation' => 'checkoutCartReadServiceV1GetCartForCustomer', + 'operation' => 'quoteCartRepositoryV1GetList', ], ]; - $requestData = ['customerId' => $customerId]; - $cartData = $this->_webApiCall($serviceInfo, $requestData); - $this->assertEquals($cart->getId(), $cartData['id']); - $this->assertEquals($cart->getCreatedAt(), $cartData['created_at']); - $this->assertEquals($cart->getUpdatedAt(), $cartData['updated_at']); - $this->assertEquals($cart->getStoreId(), $cartData['store_id']); - $this->assertEquals($cart->getIsActive(), $cartData['is_active']); - $this->assertEquals($cart->getIsVirtual(), $cartData['is_virtual']); - $this->assertEquals($cart->getOrigOrderId(), $cartData['orig_order_id']); - $this->assertEquals($cart->getItemsCount(), $cartData['items_count']); - $this->assertEquals($cart->getItemsQty(), $cartData['items_qty']); - - $this->assertContains('customer', $cartData); - $this->assertEquals(0, $cartData['customer']['is_guest']); - $this->assertContains('totals', $cartData); - $this->assertEquals($cart->getSubtotal(), $cartData['totals']['subtotal']); - $this->assertEquals($cart->getGrandTotal(), $cartData['totals']['grand_total']); - $this->assertContains('currency', $cartData); - $this->assertEquals($cart->getGlobalCurrencyCode(), $cartData['currency']['global_currency_code']); - $this->assertEquals($cart->getBaseCurrencyCode(), $cartData['currency']['base_currency_code']); - $this->assertEquals($cart->getQuoteCurrencyCode(), $cartData['currency']['quote_currency_code']); - $this->assertEquals($cart->getStoreCurrencyCode(), $cartData['currency']['store_currency_code']); - $this->assertEquals($cart->getBaseToGlobalRate(), $cartData['currency']['base_to_global_rate']); - $this->assertEquals($cart->getBaseToQuoteRate(), $cartData['currency']['base_to_quote_rate']); - $this->assertEquals($cart->getStoreToBaseRate(), $cartData['currency']['store_to_base_rate']); - $this->assertEquals($cart->getStoreToQuoteRate(), $cartData['currency']['store_to_quote_rate']); - } - - /** - * @magentoApiDataFixture Magento/Sales/_files/quote.php - */ - public function testGetCartList() - { - $cart = $this->getCart('test01'); - // The following two filters are used as alternatives. The target cart does not match the first one. $grandTotalFilter = $this->filterBuilder->setField('grand_total') ->setConditionType('gteq') @@ -217,11 +178,11 @@ class ReadServiceTest extends WebapiAbstract $yesterdayDate = (new \DateTime())->sub(new \DateInterval('P1D'))->format('Y-m-d'); $tomorrowDate = (new \DateTime())->add(new \DateInterval('P1D'))->format('Y-m-d'); - $minCreatedAtFilter = $this->filterBuilder->setField(Cart::CREATED_AT) + $minCreatedAtFilter = $this->filterBuilder->setField('created_at') ->setConditionType('gteq') ->setValue($yesterdayDate) ->create(); - $maxCreatedAtFilter = $this->filterBuilder->setField(Cart::CREATED_AT) + $maxCreatedAtFilter = $this->filterBuilder->setField('created_at') ->setConditionType('lteq') ->setValue($tomorrowDate) ->create(); @@ -235,17 +196,6 @@ class ReadServiceTest extends WebapiAbstract $searchCriteria = $this->searchBuilder->create()->__toArray(); $requestData = ['searchCriteria' => $searchCriteria]; - $serviceInfo = [ - 'rest' => [ - 'resourcePath' => '/V1/carts' . '?' . http_build_query($requestData), - 'httpMethod' => RestConfig::HTTP_METHOD_GET, - ], - 'soap' => [ - 'service' => 'checkoutCartReadServiceV1', - 'serviceVersion' => 'V1', - 'operation' => 'checkoutCartReadServiceV1GetCartList', - ], - ]; $searchResult = $this->_webApiCall($serviceInfo, $requestData); $this->assertArrayHasKey('total_count', $searchResult); $this->assertEquals(1, $searchResult['total_count']); @@ -257,21 +207,28 @@ class ReadServiceTest extends WebapiAbstract $this->assertEquals($cart->getCreatedAt(), $cartData['created_at']); $this->assertEquals($cart->getUpdatedAt(), $cartData['updated_at']); $this->assertEquals($cart->getIsActive(), $cartData['is_active']); - $this->assertEquals($cart->getStoreId(), $cartData['store_id']); - $this->assertContains('totals', $cartData); - $this->assertEquals($cart->getBaseSubtotal(), $cartData['totals']['base_subtotal']); - $this->assertEquals($cart->getBaseGrandTotal(), $cartData['totals']['base_grand_total']); - $this->assertContains('customer', $cartData); - $this->assertEquals(1, $cartData['customer']['is_guest']); + $this->assertContains('customer_is_guest', $cartData); + $this->assertEquals(1, $cartData['customer_is_guest']); } /** * @expectedException \Exception - * @expectedExceptionMessage Field 'invalid_field' cannot be used for search. */ - public function testGetCartListThrowsExceptionIfProvidedSearchFieldIsInvalid() + public function testGetListThrowsExceptionIfProvidedSearchFieldIsInvalid() { + $serviceInfo = [ + 'soap' => [ + 'service' => 'quoteCartRepositoryV1', + 'serviceVersion' => 'V1', + 'operation' => 'quoteCartRepositoryV1GetList', + ], + 'rest' => [ + 'resourcePath' => '/V1/carts', + 'httpMethod' => RestConfig::HTTP_METHOD_PUT, + ], + ]; + $invalidFilter = $this->filterBuilder->setField('invalid_field') ->setConditionType('eq') ->setValue(0) @@ -280,17 +237,6 @@ class ReadServiceTest extends WebapiAbstract $this->searchBuilder->addFilter([$invalidFilter]); $searchCriteria = $this->searchBuilder->create()->__toArray(); $requestData = ['searchCriteria' => $searchCriteria]; - $serviceInfo = [ - 'soap' => [ - 'service' => 'checkoutCartReadServiceV1', - 'serviceVersion' => 'V1', - 'operation' => 'checkoutCartReadServiceV1GetCartList', - ], - 'rest' => [ - 'resourcePath' => '/V1/carts' . '?' . http_build_query($requestData), - 'httpMethod' => RestConfig::HTTP_METHOD_GET, - ], - ]; $this->_webApiCall($serviceInfo, $requestData); } } diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Cart/TotalsServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Quote/Api/CartTotalRepositoryTest.php similarity index 94% rename from dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Cart/TotalsServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/Quote/Api/CartTotalRepositoryTest.php index 309f92958af160b4f56ad9cb875774d916ddfb58..d5a98ef36eb99e80c509f86311cc7ca69709e9f5 100644 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Cart/TotalsServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Quote/Api/CartTotalRepositoryTest.php @@ -4,17 +4,17 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Cart; +namespace Magento\Quote\Api; -use Magento\Checkout\Service\V1\Data\Cart\Totals; -use Magento\Checkout\Service\V1\Data\Cart\Totals\Item as ItemTotals; +use Magento\Quote\Model\Cart\Totals; +use Magento\Quote\Model\Cart\Totals\Item as ItemTotals; use Magento\Framework\Api\FilterBuilder; use Magento\Framework\Api\SearchCriteriaBuilder; use Magento\TestFramework\ObjectManager; use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class TotalsServiceTest extends WebapiAbstract +class CartTotalRepositoryTest extends WebapiAbstract { /** * @var ObjectManager @@ -109,9 +109,9 @@ class TotalsServiceTest extends WebapiAbstract { return [ 'soap' => [ - 'service' => 'checkoutCartTotalsServiceV1', + 'service' => 'quoteCartTotalRepositoryV1', 'serviceVersion' => 'V1', - 'operation' => 'checkoutCartTotalsServiceV1GetTotals', + 'operation' => 'quoteCartTotalRepositoryV1get', ], 'rest' => [ 'resourcePath' => '/V1/carts/' . $cartId . '/totals', diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Coupon/WriteServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Quote/Api/CouponManagementTest.php similarity index 74% rename from dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Coupon/WriteServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/Quote/Api/CouponManagementTest.php index 0599c1d885fd131b1a6d35082c5fc50b3b2a2612..07d86c26ddd64da9594d2b0996aa4bc0dda45af7 100644 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Coupon/WriteServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Quote/Api/CouponManagementTest.php @@ -1,19 +1,19 @@ <?php /** + * * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Coupon; +namespace Magento\Quote\Api; -use Magento\Checkout\Service\V1\Data\Cart\Coupon; use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class WriteServiceTest extends WebapiAbstract +class CouponManagementTest extends WebapiAbstract { const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutCouponWriteServiceV1'; + const SERVICE_NAME = 'quoteCouponManagementV1'; const RESOURCE_PATH = '/V1/carts/'; /** @@ -26,6 +26,32 @@ class WriteServiceTest extends WebapiAbstract $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); } + /** + * @magentoApiDataFixture Magento/Checkout/_files/quote_with_coupon_saved.php + */ + public function testGet() + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote->load('test_order_1', 'reserved_order_id'); + $cartId = $quote->getId(); + $couponCode = $quote->getCouponCode(); + $serviceInfo = [ + 'rest' => [ + 'resourcePath' => self::RESOURCE_PATH . $cartId . '/coupons/' , + 'httpMethod' => RestConfig::HTTP_METHOD_GET, + ], + 'soap' => [ + 'service' => self::SERVICE_NAME, + 'serviceVersion' => self::SERVICE_VERSION, + 'operation' => self::SERVICE_NAME . 'Get', + ], + ]; + + $requestData = ["cartId" => $cartId]; + $this->assertEquals($couponCode, $this->_webApiCall($serviceInfo, $requestData)); + } + /** * @magentoApiDataFixture Magento/Checkout/_files/quote_with_coupon_saved.php */ @@ -43,7 +69,7 @@ class WriteServiceTest extends WebapiAbstract 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'Delete', + 'operation' => self::SERVICE_NAME . 'Remove', ], ]; $requestData = ["cartId" => $cartId]; @@ -64,9 +90,11 @@ class WriteServiceTest extends WebapiAbstract $quote->load('test_order_1', 'reserved_order_id'); $cartId = $quote->getId(); + $couponCode = 'invalid_coupon_code'; + $serviceInfo = [ 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/coupons', + 'resourcePath' => self::RESOURCE_PATH . $cartId . '/coupons/' . $couponCode, 'httpMethod' => RestConfig::HTTP_METHOD_PUT, ], 'soap' => [ @@ -76,11 +104,9 @@ class WriteServiceTest extends WebapiAbstract ], ]; - $data = [Coupon::COUPON_CODE => 'invalid_coupon_code']; - $requestData = [ "cartId" => $cartId, - "couponCodeData" => $data, + "couponCode" => $couponCode, ]; $this->_webApiCall($serviceInfo, $requestData); @@ -96,10 +122,12 @@ class WriteServiceTest extends WebapiAbstract $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); $quote->load('test01', 'reserved_order_id'); $cartId = $quote->getId(); - + $salesRule = $this->objectManager->create('Magento\SalesRule\Model\Rule'); + $salesRule->load('Test Coupon', 'name'); + $couponCode = $salesRule->getCouponCode(); $serviceInfo = [ 'rest' => [ - 'resourcePath' => self::RESOURCE_PATH . $cartId . '/coupons', + 'resourcePath' => self::RESOURCE_PATH . $cartId . '/coupons/' . $couponCode, 'httpMethod' => RestConfig::HTTP_METHOD_PUT, ], 'soap' => [ @@ -109,15 +137,9 @@ class WriteServiceTest extends WebapiAbstract ], ]; - $salesRule = $this->objectManager->create('Magento\SalesRule\Model\Rule'); - $salesRule->load('Test Coupon', 'name'); - - $couponCode = $salesRule->getCouponCode(); - $data = [Coupon::COUPON_CODE => $couponCode]; - $requestData = [ "cartId" => $cartId, - "couponCodeData" => $data, + "couponCode" => $couponCode, ]; $this->assertTrue($this->_webApiCall($serviceInfo, $requestData)); diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Quote/Api/PaymentMethodManagementTest.php similarity index 63% rename from dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/Quote/Api/PaymentMethodManagementTest.php index a4b9a3f485502c5c4026fcf2f315f3ec1e4c1ce0..d1f11c14fecfc3ae6960e65f8f1563180d4c27aa 100644 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Quote/Api/PaymentMethodManagementTest.php @@ -3,15 +3,14 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\PaymentMethod; +namespace Magento\Quote\Api; -use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class WriteServiceTest extends WebapiAbstract +class PaymentMethodManagementTest extends \Magento\TestFramework\TestCase\WebapiAbstract { const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutPaymentMethodWriteServiceV1'; + const SERVICE_NAME = 'quotePaymentMethodManagementV1'; const RESOURCE_PATH = '/V1/carts/'; /** @@ -30,7 +29,7 @@ class WriteServiceTest extends WebapiAbstract public function testReSetPayment() { /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote = $this->objectManager->create('\Magento\Quote\Model\Quote'); $quote->load('test_order_1_with_payment', 'reserved_order_id'); $cartId = $quote->getId(); @@ -58,7 +57,7 @@ class WriteServiceTest extends WebapiAbstract ], ]; - $this->_webApiCall($serviceInfo, $requestData); + $this->assertNotNull($this->_webApiCall($serviceInfo, $requestData)); } /** @@ -67,7 +66,7 @@ class WriteServiceTest extends WebapiAbstract public function testSetPaymentWithVirtualProduct() { /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote = $this->objectManager->create('\Magento\Quote\Model\Quote'); $quote->load('test_order_with_virtual_product', 'reserved_order_id'); $cartId = $quote->getId(); @@ -103,7 +102,7 @@ class WriteServiceTest extends WebapiAbstract public function testSetPaymentWithSimpleProduct() { /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote = $this->objectManager->create('\Magento\Quote\Model\Quote'); $quote->load('test_order_1', 'reserved_order_id'); $cartId = $quote->getId(); @@ -142,7 +141,7 @@ class WriteServiceTest extends WebapiAbstract public function testSetPaymentWithVirtualProductWithoutAddress() { /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote = $this->objectManager->create('\Magento\Quote\Model\Quote'); $quote->load('test_order_with_virtual_product_without_address', 'reserved_order_id'); $cartId = $quote->getId(); @@ -169,7 +168,7 @@ class WriteServiceTest extends WebapiAbstract 'cc_exp_month' => '1', ], ]; - $this->_webApiCall($serviceInfo, $requestData); + $this->assertNotNull($this->_webApiCall($serviceInfo, $requestData)); } /** @@ -180,7 +179,7 @@ class WriteServiceTest extends WebapiAbstract public function testSetPaymentWithSimpleProductWithoutAddress() { /** @var \Magento\Quote\Model\Quote $quote */ - $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote = $this->objectManager->create('\Magento\Quote\Model\Quote'); $quote->load('test_order_with_simple_product_without_address', 'reserved_order_id'); $cartId = $quote->getId(); @@ -207,6 +206,84 @@ class WriteServiceTest extends WebapiAbstract 'cc_exp_month' => '1', ], ]; - $this->_webApiCall($serviceInfo, $requestData); + $this->assertNotNull($this->_webApiCall($serviceInfo, $requestData)); + } + + /** + * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php + */ + public function testGetList() + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote->load('test_order_1', 'reserved_order_id'); + $cartId = $quote->getId(); + + $serviceInfo = [ + 'rest' => [ + 'resourcePath' => self::RESOURCE_PATH . $cartId . '/payment-methods', + 'httpMethod' => RestConfig::HTTP_METHOD_GET, + ], + 'soap' => [ + 'service' => self::SERVICE_NAME, + 'serviceVersion' => self::SERVICE_VERSION, + 'operation' => self::SERVICE_NAME . 'getList', + ], + ]; + + $requestData = ["cartId" => $cartId]; + $requestResponse = $this->_webApiCall($serviceInfo, $requestData); + + $expectedResponse = [ + 'code' => 'checkmo', + 'title' => 'Check / Money order', + ]; + + $this->assertGreaterThan(0, count($requestResponse)); + $this->assertContains($expectedResponse, $requestResponse); + } + + /** + * @magentoApiDataFixture Magento/Checkout/_files/quote_with_payment_saved.php + */ + public function testGet() + { + /** @var \Magento\Quote\Model\Quote $quote */ + $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote->load('test_order_1_with_payment', 'reserved_order_id'); + $cartId = $quote->getId(); + + $serviceInfo = [ + 'rest' => [ + 'resourcePath' => self::RESOURCE_PATH . $cartId . '/selected-payment-methods', + 'httpMethod' => RestConfig::HTTP_METHOD_GET, + ], + 'soap' => [ + 'service' => self::SERVICE_NAME, + 'serviceVersion' => self::SERVICE_VERSION, + 'operation' => self::SERVICE_NAME . 'get', + ], + ]; + + $requestData = ["cartId" => $cartId]; + $requestResponse = $this->_webApiCall($serviceInfo, $requestData); + + $this->assertArrayHasKey('method', $requestResponse); + $this->assertArrayHasKey('po_number', $requestResponse); + $this->assertArrayHasKey('cc_owner', $requestResponse); + $this->assertArrayHasKey('cc_type', $requestResponse); + $this->assertArrayHasKey('cc_exp_year', $requestResponse); + $this->assertArrayHasKey('cc_exp_month', $requestResponse); + $this->assertArrayHasKey('additional_data', $requestResponse); + + $this->assertNotNull($requestResponse['method']); + $this->assertNotNull($requestResponse['po_number']); + $this->assertNotNull($requestResponse['cc_owner']); + $this->assertNotNull($requestResponse['cc_type']); + $this->assertNotNull($requestResponse['cc_exp_year']); + $this->assertNotNull($requestResponse['cc_exp_month']); + $this->assertNotNull($requestResponse['additional_data']); + + $this->assertEquals('checkmo', $requestResponse['method']); } } diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Quote/Api/ShippingAddressManagementTest.php similarity index 51% rename from dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/Quote/Api/ShippingAddressManagementTest.php index a318918c707ff4e33b66497a5d2332103e345e74..64a93d6d1a34200a890cd6ed64b244cb5e1d71a1 100644 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Quote/Api/ShippingAddressManagementTest.php @@ -4,15 +4,16 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Address\Shipping; +namespace Magento\Quote\Api; +use Magento\Quote\Api\Data\AddressInterface; use Magento\TestFramework\TestCase\WebapiAbstract; use Magento\Webapi\Model\Rest\Config as RestConfig; -class WriteServiceTest extends WebapiAbstract +class ShippingAddressManagementTest extends WebapiAbstract { const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutAddressShippingWriteServiceV1'; + const SERVICE_NAME = 'quoteShippingAddressManagementV1'; const RESOURCE_PATH = '/V1/carts/'; /** @@ -20,15 +21,81 @@ class WriteServiceTest extends WebapiAbstract */ protected $objectManager; + protected function setUp() + { + $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); + } + /** - * @var \Magento\Checkout\Service\V1\Data\Cart\AddressBuilder + * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php */ - protected $builder; + public function testGetAddress() + { + $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $quote->load('test_order_1', 'reserved_order_id'); - protected function setUp() + /** @var \Magento\Quote\Model\Quote\Address $address */ + $address = $quote->getShippingAddress(); + + $data = [ + AddressInterface::KEY_COUNTRY_ID => $address->getCountryId(), + AddressInterface::KEY_ID => (int)$address->getId(), + AddressInterface::KEY_CUSTOMER_ID => $address->getCustomerId(), + AddressInterface::REGION => $address->getRegion(), + AddressInterface::REGION_ID => $address->getRegionId(), + AddressInterface::REGION_CODE => $address->getRegionCode(), + AddressInterface::KEY_STREET => $address->getStreet(), + AddressInterface::KEY_COMPANY => $address->getCompany(), + AddressInterface::KEY_TELEPHONE => $address->getTelephone(), + AddressInterface::KEY_POSTCODE => $address->getPostcode(), + AddressInterface::KEY_CITY => $address->getCity(), + AddressInterface::KEY_FIRSTNAME => $address->getFirstname(), + AddressInterface::KEY_LASTNAME => $address->getLastname(), + AddressInterface::KEY_EMAIL => $address->getEmail() + ]; + + $cartId = $quote->getId(); + + $serviceInfo = [ + 'rest' => [ + 'resourcePath' => self::RESOURCE_PATH . $quote->getId() . '/shipping-address', + 'httpMethod' => RestConfig::HTTP_METHOD_GET, + ], + 'soap' => [ + 'service' => self::SERVICE_NAME, + 'serviceVersion' => self::SERVICE_VERSION, + 'operation' => self::SERVICE_NAME . 'Get', + ], + ]; + + $requestData = ["cartId" => $cartId]; + $this->assertEquals($data, $this->_webApiCall($serviceInfo, $requestData)); + } + + /** + * @magentoApiDataFixture Magento/Checkout/_files/quote_with_virtual_product_and_address.php + * + * @expectedException \Exception + * @expectedExceptionMessage Cart contains virtual product(s) only. Shipping address is not applicable + */ + public function testGetAddressOfQuoteWithVirtualProduct() { - $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); - $this->builder = $this->objectManager->create('Magento\Checkout\Service\V1\Data\Cart\AddressBuilder'); + $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + $cartId = $quote->load('test_order_with_virtual_product', 'reserved_order_id')->getId(); + + $serviceInfo = [ + 'rest' => [ + 'resourcePath' => self::RESOURCE_PATH . $quote->getId() . '/shipping-address', + 'httpMethod' => RestConfig::HTTP_METHOD_GET, + ], + 'soap' => [ + 'service' => self::SERVICE_NAME, + 'serviceVersion' => self::SERVICE_VERSION, + 'operation' => self::SERVICE_NAME . 'Get', + ], + ]; + + $this->_webApiCall($serviceInfo, ["cartId" => $cartId]); } /** @@ -48,7 +115,7 @@ class WriteServiceTest extends WebapiAbstract 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'SetAddress', + 'operation' => self::SERVICE_NAME . 'Assign', ], ]; @@ -59,11 +126,9 @@ class WriteServiceTest extends WebapiAbstract 'company' => 'eBay Inc', 'street' => ['Typical Street', 'Tiny House 18'], 'city' => 'Big City', - 'region' => [ - 'region_id' => 12, - 'region' => 'California', - 'region_code' => 'CA', - ], + 'region_id' => 12, + 'region' => 'California', + 'region_code' => 'CA', 'postcode' => '0985432', 'country_id' => 'US', 'telephone' => '88776655', @@ -71,7 +136,7 @@ class WriteServiceTest extends WebapiAbstract ]; $requestData = [ "cartId" => $quote->getId(), - 'addressData' => $addressData, + 'address' => $addressData, ]; $addressId = $this->_webApiCall($serviceInfo, $requestData); @@ -79,19 +144,19 @@ class WriteServiceTest extends WebapiAbstract //reset $quote to reload data $quote = $this->objectManager->create('Magento\Quote\Model\Quote'); $quote->load('test_order_1', 'reserved_order_id'); - $savedData = $quote->getShippingAddress()->getData(); - $this->assertEquals($addressId, $savedData['address_id']); + $address = $quote->getShippingAddress(); + $address->getRegionCode(); + $savedData = $address->getData(); + $this->assertEquals($addressId, $savedData['address_id'], 'Invalid address ID'); $this->assertEquals(0, $savedData['same_as_billing']); //custom checks for street, region and address_type $this->assertEquals($addressData['street'], $quote->getShippingAddress()->getStreet()); unset($addressData['street']); - $this->assertEquals($addressData['region']['region_id'], $savedData['region_id']); - $this->assertEquals($addressData['region']['region'], $savedData['region']); - unset($addressData['region']); + $this->assertEquals('shipping', $savedData['address_type']); //check the rest of fields foreach ($addressData as $key => $value) { - $this->assertEquals($value, $savedData[$key]); + $this->assertEquals($value, $savedData[$key], 'Invalid value for ' . $key); } } @@ -117,7 +182,7 @@ class WriteServiceTest extends WebapiAbstract 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'SetAddress', + 'operation' => self::SERVICE_NAME . 'Assign', ], ]; @@ -128,11 +193,9 @@ class WriteServiceTest extends WebapiAbstract 'company' => 'eBay Inc', 'street' => ['Typical Street', 'Tiny House 18'], 'city' => 'Big City', - 'region' => [ - 'region_id' => 12, - 'region' => 'California', - 'region_code' => 'CA', - ], + 'region_id' => 12, + 'region' => 'California', + 'region_code' => 'CA', 'postcode' => '0985432', 'country_id' => 'US', 'telephone' => '88776655', @@ -140,7 +203,7 @@ class WriteServiceTest extends WebapiAbstract ]; $requestData = [ "cartId" => $quote->getId(), - 'addressData' => $addressData, + 'address' => $addressData, ]; $this->_webApiCall($serviceInfo, $requestData); diff --git a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceTest.php b/dev/tests/api-functional/testsuite/Magento/Quote/Api/ShippingMethodManagementTest.php similarity index 57% rename from dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceTest.php rename to dev/tests/api-functional/testsuite/Magento/Quote/Api/ShippingMethodManagementTest.php index de4697fd4aa9eb66dcdbc1f1d9c1a282e6a21578..02c398ff921927fa1c5ede9c3d55194ab0303a9d 100644 --- a/dev/tests/api-functional/testsuite/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Quote/Api/ShippingMethodManagementTest.php @@ -3,27 +3,111 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ +namespace Magento\Quote\Api; -namespace Magento\Checkout\Service\V1\ShippingMethod; - -use Magento\Checkout\Service\V1\Data\Cart\ShippingMethod; +use Magento\TestFramework\ObjectManager; use Magento\TestFramework\TestCase\WebapiAbstract; +use Magento\Quote\Api\Data\ShippingMethodInterface; use Magento\Webapi\Model\Rest\Config as RestConfig; -class ReadServiceTest extends WebapiAbstract +class ShippingMethodManagementTest extends WebapiAbstract { const SERVICE_VERSION = 'V1'; - const SERVICE_NAME = 'checkoutShippingMethodReadServiceV1'; + const SERVICE_NAME = 'quoteShippingMethodManagementV1'; const RESOURCE_PATH = '/V1/carts/'; /** - * @var \Magento\TestFramework\ObjectManager + * @var ObjectManager */ - protected $objectManager; + private $objectManager; + + /** + * @var \Magento\Quote\Model\Quote + */ + protected $quote; protected function setUp() { $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); + $this->quote = $this->objectManager->create('Magento\Quote\Model\Quote'); + } + + protected function getServiceInfo() + { + return [ + 'rest' => [ + 'resourcePath' => '/V1/carts/' . $this->quote->getId() . '/selected-shipping-method', + 'httpMethod' => RestConfig::HTTP_METHOD_PUT, + ], + 'soap' => [ + 'service' => self::SERVICE_NAME, + 'serviceVersion' => self::SERVICE_VERSION, + 'operation' => self::SERVICE_NAME . 'Set', + ], + ]; + } + + /** + * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php + */ + public function testSetMethod() + { + $this->quote->load('test_order_1', 'reserved_order_id'); + $serviceInfo = $this->getServiceInfo(); + + $requestData = [ + 'cartId' => $this->quote->getId(), + 'carrierCode' => 'flatrate', + 'methodCode' => 'flatrate', + ]; + $result = $this->_webApiCall($serviceInfo, $requestData); + $this->assertEquals(true, $result); + } + + /** + * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php + */ + public function testSetMethodWrongMethod() + { + $this->quote->load('test_order_1', 'reserved_order_id'); + $serviceInfo = $this->getServiceInfo(); + + $requestData = [ + 'cartId' => $this->quote->getId(), + 'carrierCode' => 'flatrate', + 'methodCode' => 'wrongMethod', + ]; + try { + $this->_webApiCall($serviceInfo, $requestData); + } catch (\SoapFault $e) { + $message = $e->getMessage(); + } catch (\Exception $e) { + $message = json_decode($e->getMessage())->message; + } + $this->assertEquals('Carrier with such method not found: flatrate, wrongMethod', $message); + } + + /** + * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php + */ + public function testSetMethodWithoutShippingAddress() + { + $this->quote->load('test_order_with_simple_product_without_address', 'reserved_order_id'); + $serviceInfo = $this->getServiceInfo(); + + $requestData = [ + 'cartId' => $this->quote->getId(), + 'carrierCode' => 'flatrate', + 'methodCode' => 'flatrate', + ]; + try { + $this->_webApiCall($serviceInfo, $requestData); + } catch (\SoapFault $e) { + $message = $e->getMessage(); + } catch (\Exception $e) { + $message = json_decode($e->getMessage())->message; + } + $this->assertEquals('Shipping address is not set', $message); } /** @@ -41,13 +125,13 @@ class ReadServiceTest extends WebapiAbstract list($carrierCode, $methodCode) = explode('_', $shippingAddress->getShippingMethod()); list($carrierTitle, $methodTitle) = explode(' - ', $shippingAddress->getShippingDescription()); $data = [ - ShippingMethod::CARRIER_CODE => $carrierCode, - ShippingMethod::METHOD_CODE => $methodCode, - ShippingMethod::CARRIER_TITLE => $carrierTitle, - ShippingMethod::METHOD_TITLE => $methodTitle, - ShippingMethod::SHIPPING_AMOUNT => $shippingAddress->getShippingAmount(), - ShippingMethod::BASE_SHIPPING_AMOUNT => $shippingAddress->getBaseShippingAmount(), - ShippingMethod::AVAILABLE => true, + ShippingMethodInterface::CARRIER_CODE => $carrierCode, + ShippingMethodInterface::METHOD_CODE => $methodCode, + ShippingMethodInterface::CARRIER_TITLE => $carrierTitle, + ShippingMethodInterface::METHOD_TITLE => $methodTitle, + ShippingMethodInterface::SHIPPING_AMOUNT => $shippingAddress->getShippingAmount(), + ShippingMethodInterface::BASE_SHIPPING_AMOUNT => $shippingAddress->getBaseShippingAmount(), + ShippingMethodInterface::AVAILABLE => true, ]; $requestData = ["cartId" => $cartId]; @@ -116,6 +200,7 @@ class ReadServiceTest extends WebapiAbstract /** * @param string $cartId * @return array + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function getSelectedMethodServiceInfo($cartId) { @@ -127,7 +212,7 @@ class ReadServiceTest extends WebapiAbstract 'soap' => [ 'service' => self::SERVICE_NAME, 'serviceVersion' => self::SERVICE_VERSION, - 'operation' => self::SERVICE_NAME . 'GetMethod', + 'operation' => self::SERVICE_NAME . 'Get', ], ]; } @@ -163,8 +248,8 @@ class ReadServiceTest extends WebapiAbstract protected function convertRates($groupedRates, $currencyCode) { $result = []; - /** @var \Magento\Checkout\Service\V1\Data\Cart\ShippingMethodConverter $converter */ - $converter = $this->objectManager->create('Magento\Checkout\Service\V1\Data\Cart\ShippingMethodConverter'); + /** @var \Magento\Quote\Model\Cart\ShippingMethodConverter $converter */ + $converter = $this->objectManager->create('\Magento\Quote\Model\Cart\ShippingMethodConverter'); foreach ($groupedRates as $carrierRates) { foreach ($carrierRates as $rate) { $result[] = $converter->modelToDataObject($rate, $currencyCode)->__toArray(); diff --git a/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/CreditmemoCreateTest.php b/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/CreditmemoCreateTest.php index 8c6087b2e8c76de1a30adb59d426576cd8ee8a20..3884e6e449c6695f7df146c5fdb7b1b764dab1f2 100644 --- a/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/CreditmemoCreateTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/CreditmemoCreateTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Service\V1; use Magento\TestFramework\TestCase\WebapiAbstract; diff --git a/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/OrderAddressUpdateTest.php b/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/OrderAddressUpdateTest.php index f1455585d4f3460e5a35c8dbac5b1aff3d4133ee..5827ababd9fb042eeaad7e9751440938119f93f6 100644 --- a/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/OrderAddressUpdateTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/OrderAddressUpdateTest.php @@ -20,6 +20,7 @@ class OrderAddressUpdateTest extends WebapiAbstract /** * @magentoApiDataFixture Magento/Sales/_files/order.php + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function testOrderAddressUpdate() { diff --git a/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/OrderStatusHistoryAddTest.php b/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/OrderStatusHistoryAddTest.php index 4886ef2da167e688d5ebca450210b623a32a222d..b5bda07bc0a0138b51137b42d05ef2048053a02f 100644 --- a/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/OrderStatusHistoryAddTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/OrderStatusHistoryAddTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Service\V1; use Magento\Sales\Api\Data\OrderStatusHistoryInterface; @@ -33,6 +36,7 @@ class OrderStatusHistoryAddTest extends WebapiAbstract /** * @magentoApiDataFixture Magento/Sales/_files/order.php + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function testOrderCommentAdd() { diff --git a/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/ShipmentCreateTest.php b/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/ShipmentCreateTest.php index d15b8cacd4c789a5b179522142a27e9757c8ce39..38925a62319c9454358e545dc3b365e06fb2b2c5 100644 --- a/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/ShipmentCreateTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/ShipmentCreateTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Service\V1; use Magento\TestFramework\TestCase\WebapiAbstract; diff --git a/dev/tests/api-functional/testsuite/Magento/Tax/Api/TaxClassRepositoryTest.php b/dev/tests/api-functional/testsuite/Magento/Tax/Api/TaxClassRepositoryTest.php index 9cad14372f9520b35cd7079055b6e13844b530b1..4dfd23166bd53cb76bcafce8841baedd8d9b1810 100644 --- a/dev/tests/api-functional/testsuite/Magento/Tax/Api/TaxClassRepositoryTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Tax/Api/TaxClassRepositoryTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Tax\Api; use Magento\Framework\Api\FilterBuilder; diff --git a/dev/tests/api-functional/testsuite/Magento/Webapi/Routing/ServiceVersionV1Test.php b/dev/tests/api-functional/testsuite/Magento/Webapi/Routing/ServiceVersionV1Test.php index b576028352f1b691609bd3ffa54a0e3d85b2d46b..6061850059dacf24947d2323f56a88405e1749a5 100644 --- a/dev/tests/api-functional/testsuite/Magento/Webapi/Routing/ServiceVersionV1Test.php +++ b/dev/tests/api-functional/testsuite/Magento/Webapi/Routing/ServiceVersionV1Test.php @@ -71,6 +71,7 @@ class ServiceVersionV1Test extends \Magento\Webapi\Routing\BaseService /** * Test get item with any type + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function testItemAnyType() { diff --git a/dev/tests/api-functional/testsuite/Magento/Webapi/WsdlGenerationFromDataObjectTest.php b/dev/tests/api-functional/testsuite/Magento/Webapi/WsdlGenerationFromDataObjectTest.php index 2d7c98bde2267f274e03db022436f914ff298d46..23bb628f55448a1dd85da8582c7360498358e584 100644 --- a/dev/tests/api-functional/testsuite/Magento/Webapi/WsdlGenerationFromDataObjectTest.php +++ b/dev/tests/api-functional/testsuite/Magento/Webapi/WsdlGenerationFromDataObjectTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Webapi; use Magento\TestFramework\Helper\Bootstrap; @@ -220,6 +222,7 @@ RESPONSE_TYPE; * Ensure that complex type generated from Data Object is correct. * * @param string $wsdlContent + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _checkReferencedTypeDeclaration($wsdlContent) { @@ -585,6 +588,7 @@ GENERIC_FAULT_IN_MESSAGES; /** * @param string $wsdlContent + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _checkFaultsComplexTypeSection($wsdlContent) { diff --git a/dev/tests/functional/tests/app/Magento/Customer/Test/Repository/CustomerInjectable.php b/dev/tests/functional/tests/app/Magento/Customer/Test/Repository/CustomerInjectable.php index 8154cf0f2186fa1755228078d7b1a21458e99e5e..1e369f4420ab02afef8680ab4a8d67ff18dd3a5c 100644 --- a/dev/tests/functional/tests/app/Magento/Customer/Test/Repository/CustomerInjectable.php +++ b/dev/tests/functional/tests/app/Magento/Customer/Test/Repository/CustomerInjectable.php @@ -19,6 +19,7 @@ class CustomerInjectable extends AbstractRepository * @param array $defaultData * * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function __construct(array $defaultConfig = [], array $defaultData = []) { @@ -116,5 +117,15 @@ class CustomerInjectable extends AbstractRepository 'password_confirmation' => '123123q', 'address' => ['presets' => 'US_address_TX'], ]; + + $this->_data['johndoe_with_multiple_addresses'] = [ + 'firstname' => 'John', + 'lastname' => 'Doe', + 'group_id' => ['dataSet' => 'General'], + 'email' => 'JohnDoe_%isolation%@example.com', + 'password' => '123123q', + 'password_confirmation' => '123123q', + 'address' => ['presets' => 'US_address_NY, US_address'], + ]; } } diff --git a/dev/tests/integration/framework/Magento/TestFramework/Db/Adapter/Mysql.php b/dev/tests/integration/framework/Magento/TestFramework/Db/Adapter/Mysql.php index 2309e3dbfa7ea26d396e4cdf55eb69e1ae592558..ec9723704da7ee667efaa7a61ce662caf7d49b04 100644 --- a/dev/tests/integration/framework/Magento/TestFramework/Db/Adapter/Mysql.php +++ b/dev/tests/integration/framework/Magento/TestFramework/Db/Adapter/Mysql.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * See \Magento\TestFramework\Db\Adapter\TransactionInterface */ diff --git a/dev/tests/integration/framework/Magento/TestFramework/Db/Mysql.php b/dev/tests/integration/framework/Magento/TestFramework/Db/Mysql.php index fd1f83b2b043f93b64aed1232fd68c5e3b808f1c..f823efc6e1b0964f0950d159e59e72e155a421d0 100644 --- a/dev/tests/integration/framework/Magento/TestFramework/Db/Mysql.php +++ b/dev/tests/integration/framework/Magento/TestFramework/Db/Mysql.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * MySQL platform database handler */ diff --git a/dev/tests/integration/testsuite/Magento/Backend/Block/System/Config/FormStub.php b/dev/tests/integration/testsuite/Magento/Backend/Block/System/Config/FormStub.php index cbb8303fc6d900d155062fa7d5cb60f1ac31f021..d8b79308b4a2ddd056ec101c48f668d9d96f7c78 100644 --- a/dev/tests/integration/testsuite/Magento/Backend/Block/System/Config/FormStub.php +++ b/dev/tests/integration/testsuite/Magento/Backend/Block/System/Config/FormStub.php @@ -9,6 +9,9 @@ */ namespace Magento\Backend\Block\System\Config; +/** + * @SuppressWarnings(PHPMD.DepthOfInheritance) + */ class FormStub extends \Magento\Backend\Block\System\Config\Form { /** diff --git a/dev/tests/integration/testsuite/Magento/Backend/Block/Widget/Grid/MassactionTest.php b/dev/tests/integration/testsuite/Magento/Backend/Block/Widget/Grid/MassactionTest.php index e39928d690044be7bbf8276afb553b185ddba16d..713b6e42e32ab4462db340588139aebe52b43b1c 100644 --- a/dev/tests/integration/testsuite/Magento/Backend/Block/Widget/Grid/MassactionTest.php +++ b/dev/tests/integration/testsuite/Magento/Backend/Block/Widget/Grid/MassactionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Grid; use Magento\Framework\App\Bootstrap; diff --git a/dev/tests/integration/testsuite/Magento/Backend/Controller/Adminhtml/System/ConfigTest.php b/dev/tests/integration/testsuite/Magento/Backend/Controller/Adminhtml/System/ConfigTest.php index 3aeb7044dc2679ded414c5d34f80a7b599bc64ed..883b43e6ef7c9797c9748ff6784ffc7054375f6c 100644 --- a/dev/tests/integration/testsuite/Magento/Backend/Controller/Adminhtml/System/ConfigTest.php +++ b/dev/tests/integration/testsuite/Magento/Backend/Controller/Adminhtml/System/ConfigTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Controller\Adminhtml\System; use Magento\TestFramework\Helper\Bootstrap; diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/Product/NewActionTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/Product/NewActionTest.php index 0b6b0aac88e7d8555c508dc91b6eee985dcc1c80..4c5465fa32be618221cd3a835b297436a03265bb 100644 --- a/dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/Product/NewActionTest.php +++ b/dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/Product/NewActionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Controller\Adminhtml\Product; /** diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php index ded35b42fbbf3ce928ddc2ed427f8277f3436769..e91f71a3dbd3ac9d75ae3bbc81c8fee7d68f1705 100644 --- a/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php +++ b/dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/CompareTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Controller\Product; /** diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Model/Product/ImageTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Model/Product/ImageTest.php index 9a69bfb74fa9ed3c5231752a53f6d2fe80443da1..6535205bf7952692884141653d20e29dc43763ea 100644 --- a/dev/tests/integration/testsuite/Magento/Catalog/Model/Product/ImageTest.php +++ b/dev/tests/integration/testsuite/Magento/Catalog/Model/Product/ImageTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product; /** diff --git a/dev/tests/integration/testsuite/Magento/Catalog/Model/Resource/Product/OptionTest.php b/dev/tests/integration/testsuite/Magento/Catalog/Model/Resource/Product/OptionTest.php index 9d4adc03375f4a5c4f69d48cc9b03374388ff405..766af41eb77bb545f40bf9eb84c4d3ac0574c7b8 100644 --- a/dev/tests/integration/testsuite/Magento/Catalog/Model/Resource/Product/OptionTest.php +++ b/dev/tests/integration/testsuite/Magento/Catalog/Model/Resource/Product/OptionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Resource\Product; class OptionTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Import/ProductTest.php b/dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Import/ProductTest.php index 4d0db7515582db4c64d6bce76138b19a42cd830f..49b3901576e4a72fa22032059564beb5a0ad0c71 100644 --- a/dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Import/ProductTest.php +++ b/dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/Import/ProductTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test class for \Magento\CatalogImportExport\Model\Import\Product * diff --git a/dev/tests/integration/testsuite/Magento/CatalogInventory/Block/Adminhtml/Form/Field/CustomergroupTest.php b/dev/tests/integration/testsuite/Magento/CatalogInventory/Block/Adminhtml/Form/Field/CustomergroupTest.php index 88041c87154c4a53dd16000cae357f7be8adf325..43e21347809a56f500f6c84c918cd5d100cbd077 100644 --- a/dev/tests/integration/testsuite/Magento/CatalogInventory/Block/Adminhtml/Form/Field/CustomergroupTest.php +++ b/dev/tests/integration/testsuite/Magento/CatalogInventory/Block/Adminhtml/Form/Field/CustomergroupTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogInventory\Block\Adminhtml\Form\Field; class CustomergroupTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/integration/testsuite/Magento/CatalogSearch/Model/Layer/Filter/CategoryTest.php b/dev/tests/integration/testsuite/Magento/CatalogSearch/Model/Layer/Filter/CategoryTest.php index 1abea6b412188475305c07edf78f5e57fbeb2708..127025defec77eeb8bd12e898cd7fec4e24a2d7d 100644 --- a/dev/tests/integration/testsuite/Magento/CatalogSearch/Model/Layer/Filter/CategoryTest.php +++ b/dev/tests/integration/testsuite/Magento/CatalogSearch/Model/Layer/Filter/CategoryTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogSearch\Model\Layer\Filter; /** diff --git a/dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGeneratorTest.php b/dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGeneratorTest.php index 9cd202f4c073b2f099354678240fb9f355872af6..9b3387532ab4dc6a1d31a59c03aa62fe4b1413b0 100644 --- a/dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGeneratorTest.php +++ b/dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGeneratorTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogUrlRewrite\Model; use Magento\UrlRewrite\Service\V1\Data\UrlRewrite; diff --git a/dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_simple_product_saved.php b/dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_simple_product_saved.php index b012b9bc5ceb9f0483cec05f82cb25f6236717d8..3d410ba47f558b83bcc8d91d93bed5221a22f37c 100644 --- a/dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_simple_product_saved.php +++ b/dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_simple_product_saved.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + require 'simple_product.php'; /** @var \Magento\Quote\Model\Quote $quote */ diff --git a/dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_virtual_product_and_address.php b/dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_virtual_product_and_address.php index bf5f3db33102d397cf5d192c6cd34f5f1c61de3d..f892d8e7abade648085ddb2cb5b6f1cc44d79a48 100644 --- a/dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_virtual_product_and_address.php +++ b/dev/tests/integration/testsuite/Magento/Checkout/_files/quote_with_virtual_product_and_address.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + require __DIR__ . '/../../Customer/_files/customer.php'; require __DIR__ . '/../../Customer/_files/customer_address.php'; require __DIR__ . '/../../../Magento/Catalog/_files/product_virtual.php'; diff --git a/dev/tests/integration/testsuite/Magento/Cms/Controller/RouterTest.php b/dev/tests/integration/testsuite/Magento/Cms/Controller/RouterTest.php index ee0fb9721e02fddc2126a5b03170e2a2ee73bd16..69e7ee649b9a3fe42006d772ba3c613c3a4ff23f 100644 --- a/dev/tests/integration/testsuite/Magento/Cms/Controller/RouterTest.php +++ b/dev/tests/integration/testsuite/Magento/Cms/Controller/RouterTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Cms\Controller; class RouterTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/ConfigTest.php b/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/ConfigTest.php index 05b199d588294b1e0da7035464782fc6bc1e56d1..b3c492d07d29ce2d775ca328f070d90ccb5be646 100644 --- a/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/ConfigTest.php +++ b/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Block/Adminhtml/Product/Edit/Tab/Super/ConfigTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ConfigurableProduct\Block\Adminhtml\Product\Edit\Tab\Super; use Magento\Catalog\Model\Resource\Eav\Attribute; diff --git a/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php b/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php index 65e19b28c8005d2eeaa61eda88a89ae0ebcc2250..b2dd9e25b682027b88aa1a1a940f70c0f1a2556b 100644 --- a/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php +++ b/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ConfigurableProduct\Model\Product\Type; /** diff --git a/dev/tests/integration/testsuite/Magento/Core/Model/Variable/ConfigTest.php b/dev/tests/integration/testsuite/Magento/Core/Model/Variable/ConfigTest.php index 760bff128035a468a0bacd51eeca00616a882a37..b3961b0edbc99779c7ce31fedc6c06e658b141ba 100644 --- a/dev/tests/integration/testsuite/Magento/Core/Model/Variable/ConfigTest.php +++ b/dev/tests/integration/testsuite/Magento/Core/Model/Variable/ConfigTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\Variable; /** diff --git a/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php b/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php old mode 100755 new mode 100644 index ce1f87bae5ca9093b4343f4334431e640262d194..229a899bfe198014a9e128b96a3cad967fd3e262 --- a/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php +++ b/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Controller; use Magento\Framework\Message\MessageInterface; diff --git a/dev/tests/integration/testsuite/Magento/Customer/Controller/AjaxLoginTest.php b/dev/tests/integration/testsuite/Magento/Customer/Controller/AjaxLoginTest.php old mode 100755 new mode 100644 index bed8311b66666ac23891b431f16b5508fe714eed..f05eabf4e646c9159768b9e06f71c764c8a88ecd --- a/dev/tests/integration/testsuite/Magento/Customer/Controller/AjaxLoginTest.php +++ b/dev/tests/integration/testsuite/Magento/Customer/Controller/AjaxLoginTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Controller; use Magento\TestFramework\Helper\Bootstrap; diff --git a/dev/tests/integration/testsuite/Magento/Customer/Model/CustomerRegistryTest.php b/dev/tests/integration/testsuite/Magento/Customer/Model/CustomerRegistryTest.php index 74c601fcbfb89d1c8b1e2f89f5bd2449ed154239..a36d9f9be6991f3c53609968910694053fec1cca 100644 --- a/dev/tests/integration/testsuite/Magento/Customer/Model/CustomerRegistryTest.php +++ b/dev/tests/integration/testsuite/Magento/Customer/Model/CustomerRegistryTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Model; use Magento\Framework\Exception\NoSuchEntityException; diff --git a/dev/tests/integration/testsuite/Magento/Customer/_files/customer_non_default_website_id.php b/dev/tests/integration/testsuite/Magento/Customer/_files/customer_non_default_website_id.php index a2c4e2b4330f1e0f63fd578527fbdd7926826792..9409d8607459ff11c9a5edf581677b4600ed1a55 100644 --- a/dev/tests/integration/testsuite/Magento/Customer/_files/customer_non_default_website_id.php +++ b/dev/tests/integration/testsuite/Magento/Customer/_files/customer_non_default_website_id.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * @var \Magento\Store\Model\Website $website */ diff --git a/dev/tests/integration/testsuite/Magento/CustomerImportExport/Model/Export/AddressTest.php b/dev/tests/integration/testsuite/Magento/CustomerImportExport/Model/Export/AddressTest.php index b509986ad98edbd14e1d967a729ba83fe716f9f2..73012c62e5cfde76deba26e987bca4e5f12ea609 100644 --- a/dev/tests/integration/testsuite/Magento/CustomerImportExport/Model/Export/AddressTest.php +++ b/dev/tests/integration/testsuite/Magento/CustomerImportExport/Model/Export/AddressTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CustomerImportExport\Model\Export; use Magento\CustomerImportExport\Model\Import\Address as ImportAddress; diff --git a/dev/tests/integration/testsuite/Magento/CustomerImportExport/Model/Import/CustomerTest.php b/dev/tests/integration/testsuite/Magento/CustomerImportExport/Model/Import/CustomerTest.php index 9956a84d8ef08f4cbf591d4904b06690cc9a302f..802d203628aaab984beec52d8200c5f4a23120f4 100644 --- a/dev/tests/integration/testsuite/Magento/CustomerImportExport/Model/Import/CustomerTest.php +++ b/dev/tests/integration/testsuite/Magento/CustomerImportExport/Model/Import/CustomerTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CustomerImportExport\Model\Import; use Magento\Framework\App\Filesystem\DirectoryList; diff --git a/dev/tests/integration/testsuite/Magento/Directory/Model/ObserverTest.php b/dev/tests/integration/testsuite/Magento/Directory/Model/ObserverTest.php index 143899361816a3dc12348da871128f9cf35bc8d0..018c8b1c71e89679b86a824bafccf0a881dd1dd0 100644 --- a/dev/tests/integration/testsuite/Magento/Directory/Model/ObserverTest.php +++ b/dev/tests/integration/testsuite/Magento/Directory/Model/ObserverTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Directory\Model; use Magento\Framework\ObjectManagerInterface; diff --git a/dev/tests/integration/testsuite/Magento/Downloadable/_files/order_with_downloadable_product.php b/dev/tests/integration/testsuite/Magento/Downloadable/_files/order_with_downloadable_product.php index 2bb8ef0c6f2bf4839fa9c2c866f87b94d245c00f..17b240e156d18cadf0f3ffd403172a3ab3cfb11d 100644 --- a/dev/tests/integration/testsuite/Magento/Downloadable/_files/order_with_downloadable_product.php +++ b/dev/tests/integration/testsuite/Magento/Downloadable/_files/order_with_downloadable_product.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + $billingAddress = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create( 'Magento\Sales\Model\Order\Address', [ diff --git a/dev/tests/integration/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php b/dev/tests/integration/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php index ff6d1b7ffdc68df7cfaef5ede9887abd4e9ba072..3f164c9d5312577ca04f70532db1c2d2b787a4e8 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Api/Code/Generator/DataBuilderTest.php @@ -42,7 +42,7 @@ class DataBuilderTest extends \PHPUnit_Framework_TestCase public function getBuildersToTest() { return [ - ['Magento\Checkout\Service\V1\Data\Cart\TotalsBuilder'], + ['Magento\Catalog\Api\Data\ProductDataBuilder'], ]; } diff --git a/dev/tests/integration/testsuite/Magento/Framework/DB/Adapter/Pdo/MysqlTest.php b/dev/tests/integration/testsuite/Magento/Framework/DB/Adapter/Pdo/MysqlTest.php index 028007540e460e526eb2bb099785ae2bf0b1babb..5ef77c5a35df7a16d73bd6cc1f27f8e236070302 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/DB/Adapter/Pdo/MysqlTest.php +++ b/dev/tests/integration/testsuite/Magento/Framework/DB/Adapter/Pdo/MysqlTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test for an PDO MySQL adapter */ diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php index de68dad400be59536059db46b66e949b65b38638..8625ff972836b0c3cb949bb4c17e5696e34afbbf 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php @@ -4,48 +4,75 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Fixture; class Intercepted extends InterceptedParent implements InterceptedInterface { protected $_key; + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function A($param1) { $this->_key = $param1; return $this; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function B($param1, $param2) { return '<B>' . $param1 . $param2 . $this->C($param1) . '</B>'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function C($param1) { return '<C>' . $param1 . '</C>'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function D($param1) { return '<D>' . $this->_key . $param1 . '</D>'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ final public function E($param1) { return '<E>' . $this->_key . $param1 . '</E>'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function F($param1) { return '<F>' . $param1 . '</F>'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function G($param1) { return '<G>' . $param1 . "</G>"; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function K($param1) { return '<K>' . $param1 . '</K>'; diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/InterfacePlugin.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/InterfacePlugin.php index 5df8f6194e21b30ef8833e08cb4ec4baeba28aff..6537af6d81d661675876e1bb7e56794b9526d562 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/InterfacePlugin.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/InterfacePlugin.php @@ -15,6 +15,7 @@ class InterfacePlugin * @param \Closure $next * @param string $param1 * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function aroundC(InterceptedInterface $subject, \Closure $next, $param1) { @@ -32,16 +33,25 @@ class InterfacePlugin return '<IP:F>' . $subject->D($next($subject->C($param1))) . '</IP:F>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function beforeG(InterceptedInterface $subject, $param1) { return ['<IP:bG>' . $param1 . '</IP:bG>']; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundG(InterceptedInterface $subject, \Closure $next, $param1) { return $next('<IP:G>' . $param1 . '</IP:G>'); } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function afterG(InterceptedInterface $subject, $result) { return '<IP:aG>' . $result . '</IP:aG>'; diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/Plugin.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/Plugin.php index a62fba71a142f612d338050acb60402fa43550db..f8ce0abe8d8b9d0c285df20abfaed1c35e176690 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/Plugin.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/Plugin.php @@ -15,33 +15,51 @@ class Plugin */ protected $_counter = 0; + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundC(Intercepted $subject, \Closure $next, $param1) { return '<P:C>' . $next($param1) . '</P:C>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundD(Intercepted $subject, \Closure $next, $param1) { $this->_counter++; return '<P:D>' . $this->_counter . ': ' . $next($param1) . '</P:D>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundK(Intercepted $subject, \Closure $next, $param1) { $result = $subject->C($param1); return '<P:K>' . $subject->F($result) . '</P:K>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function beforeG(Intercepted $subject, $param1) { return ['<P:bG>' . $param1 . '</P:bG>']; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundG(Intercepted $subject, \Closure $next, $param1) { return $next('<P:G>' . $param1 . '</P:G>'); } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function afterG(Intercepted $subject, $result) { return '<P:aG>' . $result . '</P:aG>'; diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedInterface.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedInterface.php index 753ad18a32d888ba4307a660714b1d41536fe178..4087d96fe7448748b6749e780c5d3ac598572ca9 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedInterface.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedInterface.php @@ -4,11 +4,20 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Fixture; interface InterceptedInterface { + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function C($param1); + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function F($param1); } diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedParent.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedParent.php index 243f5ff826bec4c7a1fab96b1db073549f8ed611..976821372a60ac325d2b5c51ff878a00105f66bf 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedParent.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedParent.php @@ -4,15 +4,24 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Fixture; class InterceptedParent implements InterceptedParentInterface { + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function A($param1) { return 'A' . $param1 . 'A'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function B($param1, $param2) { return $param1 . $param2 . $this->A($param1); diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedParentInterface.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedParentInterface.php index 4e5af1f9bfb0cf609e54b89f2f560a735e72a51d..e2b8d95d4be16bf862a6094904b672b1b1fef852 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedParentInterface.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/InterceptedParentInterface.php @@ -4,9 +4,15 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Fixture; interface InterceptedParentInterface { + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function A($param1); } diff --git a/dev/tests/integration/testsuite/Magento/Framework/Less/File/Collector/AggregatedTest.php b/dev/tests/integration/testsuite/Magento/Framework/Less/File/Collector/AggregatedTest.php index e673471242dc188416746526982d48ed5a8def67..486b24864741b7a6757d1129b5e2b0466d6be708 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Less/File/Collector/AggregatedTest.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Less/File/Collector/AggregatedTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Less\File\Collector; use Magento\Framework\App\Bootstrap; diff --git a/dev/tests/integration/testsuite/Magento/Framework/Model/Resource/Db/AbstractTest.php b/dev/tests/integration/testsuite/Magento/Framework/Model/Resource/Db/AbstractTest.php index df6d447b8a902f267400143c5c131216d96f2454..8730fa5f88420e71a973474287186f737c8ab161 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Model/Resource/Db/AbstractTest.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Model/Resource/Db/AbstractTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Model\Resource\Db; class AbstractTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php b/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php index e552d9e04e8dbc7a69c6b928ec6ec3e86d081d75..de404bc3b42ae039e77d7f478f371b37a52e3cca 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Stdlib\Cookie; use Magento\Framework\ObjectManagerInterface; diff --git a/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieReaderTest.php b/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieReaderTest.php index ae239fdf418860d6a0a7d471800f5fca25dff21e..bd8e0b968f0befb09696951bd0a38c0f631f797a 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieReaderTest.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieReaderTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Stdlib\Cookie; use Magento\Framework\Stdlib\Cookie\PhpCookieReader; @@ -52,4 +54,4 @@ class PhpCookieReaderTest extends \PHPUnit_Framework_TestCase { $_COOKIE = $this->preTestCookies; } -} \ No newline at end of file +} diff --git a/dev/tests/integration/testsuite/Magento/ImportExport/Model/Export/EntityAbstractTest.php b/dev/tests/integration/testsuite/Magento/ImportExport/Model/Export/EntityAbstractTest.php index 0d41f9bd54d3349ce2f58fbbca5de3b3a05c25ae..3c445575a6fdaff22b07b36ebe0a5bf565769369 100644 --- a/dev/tests/integration/testsuite/Magento/ImportExport/Model/Export/EntityAbstractTest.php +++ b/dev/tests/integration/testsuite/Magento/ImportExport/Model/Export/EntityAbstractTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test for abstract export model */ diff --git a/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/Address/SelectTest.php b/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/Address/SelectTest.php index 49cadf9818468612d802b504d60ab0a781547290..f8d1592526586595cfc4a0876cd54d1acecfd03f 100644 --- a/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/Address/SelectTest.php +++ b/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/Address/SelectTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Block\Checkout\Address; use Magento\TestFramework\Helper\Bootstrap; diff --git a/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php b/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php index 4869f2de7494a0718b2a74b9175c7cb56d640d39..273b2a0de635195f6412854472ff2a065af95ae1 100644 --- a/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php +++ b/dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Block\Checkout; /** diff --git a/dev/tests/integration/testsuite/Magento/Reports/Controller/Adminhtml/Report/Product/ViewedTest.php b/dev/tests/integration/testsuite/Magento/Reports/Controller/Adminhtml/Report/Product/ViewedTest.php index c5eeff1fa5183418b1906a49d1a1f6eadbe8b56e..b5defd098a0dad2727e0a48f30505420586cbb82 100644 --- a/dev/tests/integration/testsuite/Magento/Reports/Controller/Adminhtml/Report/Product/ViewedTest.php +++ b/dev/tests/integration/testsuite/Magento/Reports/Controller/Adminhtml/Report/Product/ViewedTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Controller\Adminhtml\Report\Product; /** diff --git a/dev/tests/integration/testsuite/Magento/Reports/Model/Resource/Report/Product/Viewed/CollectionTest.php b/dev/tests/integration/testsuite/Magento/Reports/Model/Resource/Report/Product/Viewed/CollectionTest.php index 1ce6751ecb9387907235f454d9ad70b491563c36..64a7aea1d1cb5c1d6da78a4049716fc0b9adef66 100644 --- a/dev/tests/integration/testsuite/Magento/Reports/Model/Resource/Report/Product/Viewed/CollectionTest.php +++ b/dev/tests/integration/testsuite/Magento/Reports/Model/Resource/Report/Product/Viewed/CollectionTest.php @@ -47,6 +47,7 @@ class CollectionTest extends \PHPUnit_Framework_TestCase * @param $dateFrom * @param $dateTo * @param $isTotal + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function testTableSelection($period, $expectedTable, $dateFrom, $dateTo, $isTotal = false) { @@ -92,6 +93,7 @@ class CollectionTest extends \PHPUnit_Framework_TestCase * Data provider for testTableSelection * * @return array + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function tableForPeriodDataProvider() { diff --git a/dev/tests/integration/testsuite/Magento/Reports/_files/viewed_products.php b/dev/tests/integration/testsuite/Magento/Reports/_files/viewed_products.php index c533298f6b35962bc7495ced319bf3330cb2df64..cd856d8ee58d79fc70bf2d3a3b6e7ba0ab5f3894 100644 --- a/dev/tests/integration/testsuite/Magento/Reports/_files/viewed_products.php +++ b/dev/tests/integration/testsuite/Magento/Reports/_files/viewed_products.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get('Magento\Framework\App\AreaList') ->getArea('adminhtml') ->load(\Magento\Framework\App\Area::PART_CONFIG); diff --git a/dev/tests/integration/testsuite/Magento/Review/Block/Adminhtml/Edit/FormTest.php b/dev/tests/integration/testsuite/Magento/Review/Block/Adminhtml/Edit/FormTest.php index 3afe59ef076e030dcff48b6d26d2ea9a2d0fe156..1675b709557b08d840203ce96c40fb85f5d17097 100644 --- a/dev/tests/integration/testsuite/Magento/Review/Block/Adminhtml/Edit/FormTest.php +++ b/dev/tests/integration/testsuite/Magento/Review/Block/Adminhtml/Edit/FormTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Review\Block\Adminhtml\Edit; class FormTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/integration/testsuite/Magento/Review/Block/FormTest.php b/dev/tests/integration/testsuite/Magento/Review/Block/FormTest.php index 1b4d9e68d3019b6efbebd10ca65c9d28adbab2f8..e1d3c2c021b63f5dfa2f37bb24b91ad9d5c95207 100644 --- a/dev/tests/integration/testsuite/Magento/Review/Block/FormTest.php +++ b/dev/tests/integration/testsuite/Magento/Review/Block/FormTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Review\Block; class FormTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/integration/testsuite/Magento/Sales/Model/Resource/Order/StatusTest.php b/dev/tests/integration/testsuite/Magento/Sales/Model/Resource/Order/StatusTest.php index c859ec0d9950e81c3ddf69349790b0a8d76e1ce2..cdeb6cc7102516f45a7c4794551fe272d8600ce4 100644 --- a/dev/tests/integration/testsuite/Magento/Sales/Model/Resource/Order/StatusTest.php +++ b/dev/tests/integration/testsuite/Magento/Sales/Model/Resource/Order/StatusTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Resource\Order; use Magento\TestFramework\Helper\Bootstrap; diff --git a/dev/tests/integration/testsuite/Magento/Sales/_files/order.php b/dev/tests/integration/testsuite/Magento/Sales/_files/order.php index a41f51dea23ffc365c3b6de1d7dd8b91a3d9b0d1..dfd4511b37c4b6e3becded198d8ab4f1191f023a 100644 --- a/dev/tests/integration/testsuite/Magento/Sales/_files/order.php +++ b/dev/tests/integration/testsuite/Magento/Sales/_files/order.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + require 'default_rollback.php'; require __DIR__ . '/../../../Magento/Catalog/_files/product_simple.php'; /** @var \Magento\Catalog\Model\Product $product */ diff --git a/dev/tests/integration/testsuite/Magento/Sales/_files/order_fixture_store.php b/dev/tests/integration/testsuite/Magento/Sales/_files/order_fixture_store.php index bcd7663b2173482a90399f4796384f865129ea75..6bbd0430c0bfc3f3a637465ea1aa9d5b30ea0d55 100644 --- a/dev/tests/integration/testsuite/Magento/Sales/_files/order_fixture_store.php +++ b/dev/tests/integration/testsuite/Magento/Sales/_files/order_fixture_store.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + require __DIR__ . '/../../../Magento/Core/_files/store.php'; require __DIR__ . '/../../../Magento/Catalog/_files/product_simple_duplicated.php'; diff --git a/dev/tests/integration/testsuite/Magento/Store/Model/StoreTest.php b/dev/tests/integration/testsuite/Magento/Store/Model/StoreTest.php index 50bb1ab77ac2d11ac63ac774967664e8781bb2b7..af24b2b206fb178470dab6329e7e8d18dc1c4b9a 100644 --- a/dev/tests/integration/testsuite/Magento/Store/Model/StoreTest.php +++ b/dev/tests/integration/testsuite/Magento/Store/Model/StoreTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Store\Model; use Magento\Framework\App\Bootstrap; diff --git a/dev/tests/integration/testsuite/Magento/Tax/Model/Calculation/RateRepositoryTest.php b/dev/tests/integration/testsuite/Magento/Tax/Model/Calculation/RateRepositoryTest.php index 0ff1439b7d6f2295e73f464219b7f6d8a39bbc60..2085012b1f1fe060dd7d4cc825b102ab031c420b 100644 --- a/dev/tests/integration/testsuite/Magento/Tax/Model/Calculation/RateRepositoryTest.php +++ b/dev/tests/integration/testsuite/Magento/Tax/Model/Calculation/RateRepositoryTest.php @@ -12,6 +12,9 @@ use Magento\Tax\Api\Data\TaxRateInterface; use Magento\Tax\Model\TaxRuleFixtureFactory; use Magento\TestFramework\Helper\Bootstrap; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class RateRepositoryTest extends \PHPUnit_Framework_TestCase { /** @@ -507,6 +510,7 @@ class RateRepositoryTest extends \PHPUnit_Framework_TestCase * * @magentoDbIsolation enabled * @dataProvider searchTaxRatesDataProvider + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function testGetList($filters, $filterGroup, $expectedRateCodes) { diff --git a/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SetupUtil.php b/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SetupUtil.php index 512d07d9fbdc66ecd52ac768af7836c93f0fade4..573cc9d964267c3353c31b73a8bad36e417af5cc 100644 --- a/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SetupUtil.php +++ b/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SetupUtil.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tax\Model\Sales\Total\Quote; use Magento\Tax\Model\Config; diff --git a/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SubtotalTest.php b/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SubtotalTest.php index 5163182cd51c5ee16defd8fe5241f2761fcffb30..cd731795215d0bf9f049576684f167634af2e53c 100644 --- a/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SubtotalTest.php +++ b/dev/tests/integration/testsuite/Magento/Tax/Model/Sales/Total/Quote/SubtotalTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Tax\Model\Sales\Total\Quote; use Magento\Tax\Model\ClassModel; diff --git a/dev/tests/integration/testsuite/Magento/Tax/Pricing/AdjustmentTest.php b/dev/tests/integration/testsuite/Magento/Tax/Pricing/AdjustmentTest.php index e1fa1b0d22374666dcdf207a7172961043972b17..2f1d00c08c99e2b86cc3807e4028d66f8dd49447 100644 --- a/dev/tests/integration/testsuite/Magento/Tax/Pricing/AdjustmentTest.php +++ b/dev/tests/integration/testsuite/Magento/Tax/Pricing/AdjustmentTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Tax\Pricing; class AdjustmentTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/integration/testsuite/Magento/Test/Integrity/LayoutTest.php b/dev/tests/integration/testsuite/Magento/Test/Integrity/LayoutTest.php index 0ba4b440cfa637179a911ff82eb1aadb2b5c2a0e..0529cf8577a6f2580ac498424d64e0dab7b60e48 100644 --- a/dev/tests/integration/testsuite/Magento/Test/Integrity/LayoutTest.php +++ b/dev/tests/integration/testsuite/Magento/Test/Integrity/LayoutTest.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Test\Integrity; class LayoutTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/TemplateFilesTest.php b/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/TemplateFilesTest.php index fa3ba33cdd0783140a9b910971e082bc0c1e3a49..b3a71c7e530fb006c4ef758a74960543c6d79564 100644 --- a/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/TemplateFilesTest.php +++ b/dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/TemplateFilesTest.php @@ -43,6 +43,7 @@ class TemplateFilesTest extends \Magento\TestFramework\TestCase\AbstractIntegrit /** * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function allTemplatesDataProvider() { diff --git a/dev/tests/integration/testsuite/Magento/Test/Integrity/Theme/TemplateFilesTest.php b/dev/tests/integration/testsuite/Magento/Test/Integrity/Theme/TemplateFilesTest.php index 7461e380b7967aa5661f522af9dfdb260b309005..af6e3cd1cb7e6271e3cb2cd4d1263b7162ad71aa 100644 --- a/dev/tests/integration/testsuite/Magento/Test/Integrity/Theme/TemplateFilesTest.php +++ b/dev/tests/integration/testsuite/Magento/Test/Integrity/Theme/TemplateFilesTest.php @@ -62,6 +62,7 @@ class TemplateFilesTest extends \Magento\TestFramework\TestCase\AbstractIntegrit * * @param \SimpleXMLElement $layoutXml * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _getLayoutTemplates($layoutXml) { diff --git a/dev/tests/integration/testsuite/Magento/User/Controller/Adminhtml/User/InvalidateTokenTest.php b/dev/tests/integration/testsuite/Magento/User/Controller/Adminhtml/User/InvalidateTokenTest.php index 0d80739d9b45725820475fb555b33282b4083a86..65c7948cd5a8ba7157d215373aa30d316f00f011 100644 --- a/dev/tests/integration/testsuite/Magento/User/Controller/Adminhtml/User/InvalidateTokenTest.php +++ b/dev/tests/integration/testsuite/Magento/User/Controller/Adminhtml/User/InvalidateTokenTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\User\Controller\Adminhtml\User; use Magento\Framework\Message\MessageInterface; diff --git a/dev/tests/integration/testsuite/Magento/User/Model/UserTest.php b/dev/tests/integration/testsuite/Magento/User/Model/UserTest.php index b91b15f6e961e170294cecf76fe0829d055eec6d..08648da473c851fe13211ba5ef7700b9fd1320c9 100644 --- a/dev/tests/integration/testsuite/Magento/User/Model/UserTest.php +++ b/dev/tests/integration/testsuite/Magento/User/Model/UserTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\User\Model; /** diff --git a/dev/tests/integration/testsuite/Magento/Weee/Model/TaxTest.php b/dev/tests/integration/testsuite/Magento/Weee/Model/TaxTest.php index cd38e2d88b7d874829f57f2117119a18dc180a00..bc287e21e45b11b2bee282f38ab70c5250327966 100644 --- a/dev/tests/integration/testsuite/Magento/Weee/Model/TaxTest.php +++ b/dev/tests/integration/testsuite/Magento/Weee/Model/TaxTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Weee\Model; use Magento\Customer\Api\Data\CustomerDataBuilder; diff --git a/dev/tests/integration/testsuite/Magento/Widget/Model/Config/ReaderTest.php b/dev/tests/integration/testsuite/Magento/Widget/Model/Config/ReaderTest.php index 9f15a97686b6233c26e1945a2a79f91b4c3d9d91..60099ca1a352254869aee777fbfea1c2c4b7be51 100644 --- a/dev/tests/integration/testsuite/Magento/Widget/Model/Config/ReaderTest.php +++ b/dev/tests/integration/testsuite/Magento/Widget/Model/Config/ReaderTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Widget\Model\Config; use Magento\TestFramework\Helper\Bootstrap; diff --git a/dev/tests/integration/testsuite/Magento/Wishlist/Helper/RssTest.php b/dev/tests/integration/testsuite/Magento/Wishlist/Helper/RssTest.php index 2d5cb31d0e4f8deee4f58b2fb431e91f11f0e902..72264a8ccf60d40c0a06515cdfc02b31e26e3297 100644 --- a/dev/tests/integration/testsuite/Magento/Wishlist/Helper/RssTest.php +++ b/dev/tests/integration/testsuite/Magento/Wishlist/Helper/RssTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Wishlist\Helper; class RssTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/BlacklistInterface.php b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/BlacklistInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..a87c8afb8126863eff1a568451fcadbf941ab1b9 --- /dev/null +++ b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/BlacklistInterface.php @@ -0,0 +1,20 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ + +// @codingStandardsIgnoreFile + +namespace Magento\TestFramework\CodingStandard\Tool; + +interface BlacklistInterface +{ + /** + * Set list of paths to be excluded from tool run + * + * @param array $blackList + * @return void + */ + public function setBlackList(array $blackList); +} diff --git a/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CodeMessDetector.php b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CodeMessDetector.php index ecbc37577bdf99af054153e8d547f4fab884aa1c..ed5c2b33fdb300f95da2efff0e1ceb3835ad1575 100644 --- a/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CodeMessDetector.php +++ b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CodeMessDetector.php @@ -9,21 +9,23 @@ */ namespace Magento\TestFramework\CodingStandard\Tool; -class CodeMessDetector implements \Magento\TestFramework\CodingStandard\ToolInterface +use \Magento\TestFramework\CodingStandard\ToolInterface; + +class CodeMessDetector implements ToolInterface { /** * Ruleset directory * * @var string */ - protected $_rulesetFile; + private $rulesetFile; /** * Report file * * @var string */ - protected $_reportFile; + private $reportFile; /** * Constructor @@ -33,8 +35,8 @@ class CodeMessDetector implements \Magento\TestFramework\CodingStandard\ToolInte */ public function __construct($rulesetFile, $reportFile) { - $this->_reportFile = $reportFile; - $this->_rulesetFile = $rulesetFile; + $this->reportFile = $reportFile; + $this->rulesetFile = $rulesetFile; } /** @@ -44,35 +46,31 @@ class CodeMessDetector implements \Magento\TestFramework\CodingStandard\ToolInte */ public function canRun() { - return class_exists('PHP_PMD_TextUI_Command'); + return class_exists('PHPMD\TextUI\Command'); } /** - * Run tool for files specified - * - * @param array $whiteList Files/directories to be inspected - * @param array $blackList Files/directories to be excluded from the inspection - * @param array $extensions Array of alphanumeric strings, for example: 'php', 'xml', 'phtml', 'css'... - * - * @return int + * {@inheritdoc} */ - public function run(array $whiteList, array $blackList = [], array $extensions = []) + public function run(array $whiteList) { + if (empty($whiteList)) { + return \PHPMD\TextUI\Command::EXIT_SUCCESS; + } + $commandLineArguments = [ 'run_file_mock', //emulate script name in console arguments implode(',', $whiteList), 'xml', //report format - $this->_rulesetFile, - '--exclude', - implode(',', $blackList), + $this->rulesetFile, '--reportfile', - $this->_reportFile, + $this->reportFile, ]; - $options = new \PHP_PMD_TextUI_CommandLineOptions($commandLineArguments); + $options = new \PHPMD\TextUI\CommandLineOptions($commandLineArguments); - $command = new \PHP_PMD_TextUI_Command(); + $command = new \PHPMD\TextUI\Command(); - return $command->run($options, new \PHP_PMD_RuleSetFactory()); + return $command->run($options, new \PHPMD\RuleSetFactory()); } } diff --git a/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CodeSniffer.php b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CodeSniffer.php index 75807b3d1d84e214cf9edb9565819fe77670b4ea..8fad6ea044f991990631bfc98b90822e7875ff3f 100644 --- a/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CodeSniffer.php +++ b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CodeSniffer.php @@ -12,28 +12,35 @@ namespace Magento\TestFramework\CodingStandard\Tool; use Magento\TestFramework\CodingStandard\Tool\CodeSniffer\Wrapper; use Magento\TestFramework\CodingStandard\ToolInterface; -class CodeSniffer implements ToolInterface +class CodeSniffer implements ToolInterface, ExtensionInterface { /** * Ruleset directory * * @var string */ - protected $rulesetDir; + private $rulesetDir; /** * Report file * * @var string */ - protected $reportFile; + private $reportFile; /** * PHPCS cli tool wrapper * * @var Wrapper */ - protected $wrapper; + private $wrapper; + + /** + * List of extensions for tool run + * + * @var array + */ + private $extensions = ['php']; /** * Constructor @@ -50,64 +57,41 @@ class CodeSniffer implements ToolInterface } /** - * Whether the tool can be ran on the current environment - * - * @return bool + * {@inheritdoc} */ - public function canRun() + public function setExtensions(array $extensions) { - return class_exists('PHP_CodeSniffer_CLI'); + $this->extensions = $extensions; } /** - * Return the version of code sniffer found + * Whether the tool can be ran on the current environment * - * @return string + * @return bool */ - public function version() + public function canRun() { - return $this->wrapper->version(); + return class_exists('PHP_CodeSniffer_CLI'); } /** - * Run tool for files specified - * - * @param array $whiteList Files/directories to be inspected - * @param array $blackList Files/directories to be excluded from the inspection - * @param array $extensions Array of alphanumeric strings, for example: 'php', 'xml', 'phtml', 'css'... - * @param int $warningSeverity Severity level of warnings, default is 0 - * - * @return int + * {@inheritdoc} */ - public function run( - array $whiteList, - array $blackList = [], - array $extensions = [], - $warningSeverity = 0 - ) { - $whiteList = array_map( - function ($item) { - return $item; - }, - $whiteList - ); - - $blackList = array_map( - function ($item) { - return preg_quote($item); - }, - $blackList - ); + public function run(array $whiteList) + { + if (empty($whiteList)) { + return 0; + } $this->wrapper->checkRequirements(); $settings = $this->wrapper->getDefaults(); $settings['files'] = $whiteList; $settings['standard'] = [$this->rulesetDir]; - $settings['ignored'] = $blackList; - $settings['extensions'] = $extensions; + $settings['extensions'] = $this->extensions; $settings['reportFile'] = $this->reportFile; - $settings['warningSeverity'] = $warningSeverity; + $settings['warningSeverity'] = 0; $settings['reports']['checkstyle'] = null; + $this->wrapper->setValues($settings); ob_start(); @@ -116,14 +100,4 @@ class CodeSniffer implements ToolInterface return $result; } - - /** - * Get report file - * - * @return string - */ - public function getReportFile() - { - return $this->reportFile; - } } diff --git a/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CopyPasteDetector.php b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CopyPasteDetector.php index 67b9a1ca31842d22f9a647497f5baf8d2e9fbcd2..7d3b1a991127a5d06c2f8214efc15a283b70bc40 100644 --- a/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CopyPasteDetector.php +++ b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CopyPasteDetector.php @@ -4,19 +4,30 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * PHP Copy Paste Detector v1.4.0 tool wrapper */ namespace Magento\TestFramework\CodingStandard\Tool; -class CopyPasteDetector implements \Magento\TestFramework\CodingStandard\ToolInterface +use Magento\TestFramework\CodingStandard\ToolInterface; + +class CopyPasteDetector implements ToolInterface, BlacklistInterface { /** * Report file * * @var string */ - protected $_reportFile; + private $reportFile; + + /** + * List of paths to be excluded from tool run + * + * @var array + */ + private $blacklist; /** * Constructor @@ -25,7 +36,15 @@ class CopyPasteDetector implements \Magento\TestFramework\CodingStandard\ToolInt */ public function __construct($reportFile) { - $this->_reportFile = $reportFile; + $this->reportFile = $reportFile; + } + + /** + * {@inheritdoc} + */ + public function setBlackList(array $blackList) + { + $this->blacklist = $blackList; } /** @@ -45,17 +64,14 @@ class CopyPasteDetector implements \Magento\TestFramework\CodingStandard\ToolInt * Run tool for files specified * * @param array $whiteList Files/directories to be inspected - * @param array $blackList Files/directories to be excluded from the inspection - * @param array $extensions Array of alphanumeric strings, for example: 'php', 'xml', 'phtml', 'css'... + * @return int * * @SuppressWarnings(PHPMD.UnusedLocalVariable) - * - * @return int */ - public function run(array $whiteList, array $blackList = [], array $extensions = []) + public function run(array $whiteList) { $blackListStr = ' '; - foreach ($blackList as $file) { + foreach ($this->blacklist as $file) { $file = escapeshellarg(trim($file)); if (!$file) { continue; @@ -64,8 +80,8 @@ class CopyPasteDetector implements \Magento\TestFramework\CodingStandard\ToolInt } $command = 'phpcpd' . ' --log-pmd ' . escapeshellarg( - $this->_reportFile - ) . ' --min-lines 13' . $blackListStr . ' ' . BP; + $this->reportFile + ) . ' --min-lines 13' . $blackListStr . ' ' . implode(' ', $whiteList); exec($command, $output, $exitCode); diff --git a/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/ExtensionInterface.php b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/ExtensionInterface.php new file mode 100644 index 0000000000000000000000000000000000000000..8d8f8e966f23e65c5d41c8f35a126c10881be467 --- /dev/null +++ b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/ExtensionInterface.php @@ -0,0 +1,19 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ + +namespace Magento\TestFramework\CodingStandard\Tool; + +interface ExtensionInterface +{ + /** + * Set extensions for tool to run + * Example: 'php', 'xml', 'phtml', 'css' + * + * @param array $extensions + * @return void + */ + public function setExtensions(array $extensions); +} diff --git a/dev/tests/static/framework/Magento/TestFramework/CodingStandard/ToolInterface.php b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/ToolInterface.php index 43967eac691bc8b917ef606ebee3a32dd79d7e77..41cf691cdf9e240f8894f9d985807db3018d14d0 100644 --- a/dev/tests/static/framework/Magento/TestFramework/CodingStandard/ToolInterface.php +++ b/dev/tests/static/framework/Magento/TestFramework/CodingStandard/ToolInterface.php @@ -19,13 +19,10 @@ interface ToolInterface public function canRun(); /** - * Run tool for files cpecified + * Run tool for files specified * * @param array $whiteList Files/directories to be inspected - * @param array $blackList Files/directories to be excluded from the inspection - * @param array $extensions Array of alphanumeric strings, for example: 'php', 'xml', 'phtml', 'css'... - * * @return int */ - public function run(array $whiteList, array $blackList = [], array $extensions = []); + public function run(array $whiteList); } diff --git a/dev/tests/static/framework/Magento/TestFramework/Utility/ChangedFiles.php b/dev/tests/static/framework/Magento/TestFramework/Utility/ChangedFiles.php index 4ed93a6e9bb3b134566559d12db5101deef36fbe..d513da4dc16777bdb7223e38c8c0068feb58570c 100644 --- a/dev/tests/static/framework/Magento/TestFramework/Utility/ChangedFiles.php +++ b/dev/tests/static/framework/Magento/TestFramework/Utility/ChangedFiles.php @@ -6,6 +6,8 @@ namespace Magento\TestFramework\Utility; +use Magento\Framework\Test\Utility\Files; + /** * A helper to gather various changed files * if INCREMENTAL_BUILD env variable is set by CI build infrastructure, only files changed in the @@ -22,16 +24,14 @@ class ChangedFiles public static function getPhpFiles($changedFilesList) { $fileHelper = \Magento\Framework\Test\Utility\Files::init(); - $allPhpFiles = $fileHelper->getPhpFiles(); if (isset($_ENV['INCREMENTAL_BUILD'])) { - $phpFiles = file($changedFilesList, FILE_IGNORE_NEW_LINES); - foreach ($phpFiles as $key => $phpFile) { - $phpFiles[$key] = $fileHelper->getPathToSource() . '/' . $phpFile; + $phpFiles = Files::readLists($changedFilesList); + if (!empty($phpFiles)) { + $phpFiles = \Magento\Framework\Test\Utility\Files::composeDataSets($phpFiles); + $phpFiles = array_intersect_key($phpFiles, $fileHelper->getPhpFiles()); } - $phpFiles = \Magento\Framework\Test\Utility\Files::composeDataSets($phpFiles); - $phpFiles = array_intersect_key($phpFiles, $allPhpFiles); } else { - $phpFiles = $allPhpFiles; + $phpFiles = $fileHelper->getPhpFiles(); } return $phpFiles; diff --git a/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/CodingStandard/Tool/CodeSnifferTest.php b/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/CodingStandard/Tool/CodeSnifferTest.php index fec684fd4c0cef81ee58855b1d480cb64be43407..8f71637e829994b74f55a926b80e2a68bc3e2789 100644 --- a/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/CodingStandard/Tool/CodeSnifferTest.php +++ b/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/CodingStandard/Tool/CodeSnifferTest.php @@ -40,7 +40,6 @@ class CodeSnifferTest extends \PHPUnit_Framework_TestCase public function testRun() { $whiteList = ['test' . rand(), 'test' . rand()]; - $blackList = ['test' . rand(), 'test' . rand()]; $extensions = ['test' . rand(), 'test' . rand()]; $this->_wrapper->expects($this->once())->method('getDefaults')->will($this->returnValue([])); @@ -48,22 +47,18 @@ class CodeSnifferTest extends \PHPUnit_Framework_TestCase $expectedCliEmulation = [ 'files' => $whiteList, 'standard' => [self::RULE_SET], - 'ignored' => $blackList, 'extensions' => $extensions, 'reportFile' => self::REPORT_FILE, 'warningSeverity' => 0, 'reports' => ['checkstyle' => null], ]; + $this->_tool->setExtensions($extensions); + $this->_wrapper->expects($this->once())->method('setValues')->with($this->equalTo($expectedCliEmulation)); $this->_wrapper->expects($this->once())->method('process'); - $this->_tool->run($whiteList, $blackList, $extensions); - } - - public function testGetReportFile() - { - $this->assertEquals(self::REPORT_FILE, $this->_tool->getReportFile()); + $this->_tool->run($whiteList); } } diff --git a/dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php b/dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php index 0510c8cb4fec81748ad1b031a0ae9e31ee19a928..c382d8c2026f7d3f044fafbc136525ecffc220c3 100644 --- a/dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php +++ b/dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php @@ -257,8 +257,15 @@ class CompilerTest extends \PHPUnit_Framework_TestCase } $class = new \ReflectionClass($className); $parent = $class->getParentClass(); + $file = false; + if ($parent) { + $basePath = \Magento\Framework\Test\Utility\Files::init()->getPathToSource(); + $file = str_replace('\\', DIRECTORY_SEPARATOR, $parent->getFileName()); + $basePath = str_replace('\\', DIRECTORY_SEPARATOR, $basePath); + $file = str_replace($basePath . DIRECTORY_SEPARATOR, '', $file); + } /** Prevent analysis of non Magento classes */ - if ($parent && in_array($parent->getFileName(), $allowedFiles)) { + if ($parent && in_array($file, $allowedFiles)) { $output = array_merge( $this->_buildInheritanceHierarchyTree($parent->getName(), $allowedFiles), [$className], diff --git a/dev/tests/static/testsuite/Magento/Test/Legacy/ObsoleteCodeTest.php b/dev/tests/static/testsuite/Magento/Test/Legacy/ObsoleteCodeTest.php index 17b1064d56f0893e4a57ad9eeb4c0512871f3467..dcb1b59726ce23c2a6deb25bba29b854908bac19 100644 --- a/dev/tests/static/testsuite/Magento/Test/Legacy/ObsoleteCodeTest.php +++ b/dev/tests/static/testsuite/Magento/Test/Legacy/ObsoleteCodeTest.php @@ -130,7 +130,7 @@ class ObsoleteCodeTest extends \PHPUnit_Framework_TestCase $this->_testObsoleteConstants($content); $this->_testObsoletePropertySkipCalculate($content); }, - \Magento\TestFramework\Utility\ChangedFiles::getPhpFiles(__DIR__ . '/_files/changed_files.txt') + \Magento\TestFramework\Utility\ChangedFiles::getPhpFiles(__DIR__ . '/_files/changed_files*') ); } diff --git a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_config_nodes.php b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_config_nodes.php index 246d4e1aa8a41eefd95ea71cd7c6b7853b28c416..724512ff417f5ce5c635e1c8ba45328e61d11284 100644 --- a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_config_nodes.php +++ b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_config_nodes.php @@ -7,6 +7,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + return [ '/config/global/fieldsets' => '', '/config/global/cache/betatypes' => '', diff --git a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_constants.php b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_constants.php index 6297a430b414de2bef3fa76cf7b2ffd81aa8ee6e..a648097786fb8e93016e61b84a4612753a0eab63 100644 --- a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_constants.php +++ b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_constants.php @@ -7,6 +7,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + return [ ['ADMIN_STORE_ID', 'Magento\Framework\AppInterface'], ['BACKORDERS_BELOW'], diff --git a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php index 9ea166fe28d77ae86fe8d5b7b08552fab4606347..d2109ce14c60e1dba38d7630429f04b048a02124 100644 --- a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php +++ b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + return [ ['__get', 'Magento\Framework\Object'], ['__set', 'Magento\Framework\Object'], diff --git a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_namespaces.php b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_namespaces.php index a266869939c2fb4daab08ac7e1590fad7d80de12..91f2539d15511b4790bf74e6c5eca6a5e6c07cda 100644 --- a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_namespaces.php +++ b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_namespaces.php @@ -70,5 +70,8 @@ return [ ['Magento\RecurringPayment'], ['Magento\PayPalRecurringPayment'], ['Magento\ConfigurableProduct\Service'], - ['Magento\Catalog\Service'] + ['Magento\Catalog\Service'], + ['Magento\CheckoutAgreements\Service'], + ['Magento\Checkout\Service'], + ['Magento\GiftMessage\Service'] ]; diff --git a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_properties.php b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_properties.php index 87e62ec811f7ec5d7a00c26adb354df8b9f7a616..07abf20721f22a252052d45b745506477b9b3a5b 100644 --- a/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_properties.php +++ b/dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_properties.php @@ -7,6 +7,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + return [ ['_addresses', 'Magento\Customer\Model\Customer'], ['_addMinimalPrice', 'Magento\Catalog\Model\Resource\Product\Collection'], diff --git a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/classes/normal_class.php b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/classes/normal_class.php index 4ec266905e67125178983f212a4d1ff27cc07690..657908ba8229ca498fb7ab8816843bf783c8ac7f 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/classes/normal_class.php +++ b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/classes/normal_class.php @@ -3,8 +3,11 @@ * Doc block for this file */ +// @codingStandardsIgnoreFile + /** * Doc block for this class + * @SuppressWarnings(PHPMD.UnusedPrivateField) */ class Magento_Test_Php_Exemplar_CodeStyleTest_phpcs_input_coding_style_classes_normal_class { diff --git a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/method_without_scope.php b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/method_without_scope.php index 146fae12ef89eb36dcece820c81f30f315090c77..368e768525ff3b4f4803e99989f77e71b4127b23 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/method_without_scope.php +++ b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/method_without_scope.php @@ -3,6 +3,8 @@ * Doc block for this file */ +// @codingStandardsIgnoreFile + /** * Doc block for this class */ diff --git a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/multiline_wrong_declaration.php b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/multiline_wrong_declaration.php index 750b756fa073fc6862255aaf0c32c2f04ecca7b9..f70fe08470a7f4db321ecd41ffb1c67f39de3bbc 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/multiline_wrong_declaration.php +++ b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/multiline_wrong_declaration.php @@ -8,7 +8,11 @@ * @param int $moreEvenLongerParamForAllThatRoutineStuff * @param float $andThereGoesOneParameter * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ + +// @codingStandardsIgnoreFile + function thereGoesFunc($someLongParam, $anotherLongParam, $moreEvenLongerParamForAllThatRoutineStuff, $andThereGoesOneParameter ) { @@ -27,6 +31,7 @@ function thereGoesFunc($someLongParam, $anotherLongParam, $moreEvenLongerParamFo * @param int $moreEvenLongerParamForAllThatRoutineStuff * @param float $andThereGoesOneParameter * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ function thereGoesAnotherFunc($someLongParam, $anotherLongParam, $moreEvenLongerParamForAllThatRoutineStuff, $andThereGoesOneParameter @@ -46,6 +51,7 @@ function thereGoesAnotherFunc($someLongParam, $anotherLongParam, $moreEvenLonger * @param int $moreEvenLongerParamForAllThatRoutineStuff * @param float $andThereGoesOneParameter * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ function thereGoesThirdFunc($someLongParam, $anotherLongParam, $moreEvenLongerParamForAllThatRoutineStuff, $andThereGoesOneParameter @@ -65,6 +71,7 @@ function thereGoesThirdFunc($someLongParam, $anotherLongParam, $moreEvenLongerPa * @param int $moreEvenLongerParamForAllThatRoutineStuff * @param float $andThereGoesOneParameter * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ function thereGoesFourthFunc($someLongParam, $anotherLongParam, $moreEvenLongerParamForAllThatRoutineStuff, $andThereGoesOneParameter) @@ -84,6 +91,7 @@ function thereGoesFourthFunc($someLongParam, $anotherLongParam, $moreEvenLongerP * @param int $moreEvenLongerParamForAllThatRoutineStuff * @param float $andThereGoesOneParameter * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ function thereGoesFifthFunc($someLongParam, $anotherLongParam, $moreEvenLongerParamForAllThatRoutineStuff, $andThereGoesOneParameter) diff --git a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/normal_func.php b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/normal_func.php index acd5360c0f161dc225ef3748c94dd6693d6eaaac..72c8cc4ad1c9fdb81ea4d3b2a61c57dbb317269b 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/normal_func.php +++ b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/normal_func.php @@ -6,6 +6,9 @@ * @param string|null $inParam * @return string */ + +// @codingStandardsIgnoreFile + function someFunc($inParam) { if ($inParam === null) { @@ -23,6 +26,8 @@ function someFunc($inParam) * @param int $moreEvenLongerParamForAllThatRoutineStuff * @param float $andThereGoesOneParameter * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ function anotherFunc($someLongParam, $anotherLongParam, $moreEvenLongerParamForAllThatRoutineStuff, $andThereGoesOneParameter diff --git a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/unneeded_multiline.php b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/unneeded_multiline.php index c32855bbeb647f6bc8dab3d2ba69ba0f6ddbc6ff..b5f9052441eee9687e6e5f2e63d2a1f653b2f1dc 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/unneeded_multiline.php +++ b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/functions/unneeded_multiline.php @@ -6,7 +6,11 @@ * @param string|null $a * @param bool $b * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ + +// @codingStandardsIgnoreFile + function thereGoesFunc($a, $b ) { diff --git a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/inline_doc/format/wrong_align.php b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/inline_doc/format/wrong_align.php index 312abd2e855cabb2556117f24650fb6d442b93c3..1c80b5708e93f60cca4910aaabc8a1351e5b6d65 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/inline_doc/format/wrong_align.php +++ b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/inline_doc/format/wrong_align.php @@ -8,6 +8,9 @@ * @copyright ... * @license ... */ + +// @codingStandardsIgnoreFile + class Magento_Test_Php_Exemplar_CodeStyleTest_phpcs_input_coding_style_inline_doc_format_wrong_align { /** diff --git a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/inline_doc/normal.php b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/inline_doc/normal.php index de702f43d38cba8b1ee4347eeed15c95cb7b93d4..15c44b8e07818e1d57b0d8e284aebb7fc716ceaa 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/inline_doc/normal.php +++ b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/coding_style/inline_doc/normal.php @@ -7,6 +7,9 @@ * @copyright ... * @license ... */ + +// @codingStandardsIgnoreFile + class Magento_Test_Php_Exemplar_CodeStyleTest_phpcs_input_coding_style_inline_doc_normal { /** diff --git a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/naming/property/normal_underscore.php b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/naming/property/normal_underscore.php index eaae02799752c6abc612f8fb6f1e0c06cc5be318..ff4ac13b9d000ac7e66839c8856b564184faea6f 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/naming/property/normal_underscore.php +++ b/dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input/naming/property/normal_underscore.php @@ -1,4 +1,10 @@ <?php +/** + * @SuppressWarnings(PHPMD.UnusedPrivateField) + */ + +// @codingStandardsIgnoreFile + class Magento_Test_Php_Exemplar_CodeStyleTest_phpcs_input_naming_property_normal_underscore { private $_private = 1; diff --git a/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php b/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php index 977450de7cb1fde2403a98b083c03291f3060b85..2a24060a14dd0a5e99f9bbc5be4783dfc58ddc47 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php +++ b/dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Test\Php; use Magento\Framework\Test\Utility; @@ -10,7 +13,7 @@ use Magento\TestFramework\CodingStandard\Tool\CodeMessDetector; use Magento\TestFramework\CodingStandard\Tool\CodeSniffer; use Magento\TestFramework\CodingStandard\Tool\CodeSniffer\Wrapper; use Magento\TestFramework\CodingStandard\Tool\CopyPasteDetector; -use PHP_PMD_TextUI_Command; +use PHPMD\TextUI\Command; use PHPUnit_Framework_TestCase; use Magento\Framework\Test\Utility\Files; @@ -29,16 +32,6 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase */ protected static $pathToSource = ''; - /** - * @var array - */ - protected static $whiteList = []; - - /** - * @var array - */ - protected static $blackList = []; - /** * Setup basics for all tests * @@ -51,22 +44,40 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase if (!is_dir(self::$reportDir)) { mkdir(self::$reportDir, 0777); } - self::setupFileLists(); } /** - * Helper method to setup the black and white lists + * Returns whitelist based on blacklist and git changed files * - * @param string $type - * @return void + * @param array $fileTypes + * @return array */ - public static function setupFileLists($type = '') + public static function getWhitelist($fileTypes = ['php']) { - if ($type != '' && !preg_match('/\/$/', $type)) { - $type = $type . '/'; + $directoriesToCheck = file(__DIR__ . '/_files/whitelist/common.txt', FILE_IGNORE_NEW_LINES); + + $changedFiles = array_filter( + Utility\Files::readLists(__DIR__ . '/_files/changed_files*'), + function ($path) use ($directoriesToCheck) { + foreach ($directoriesToCheck as $directory) { + if (strpos($path, BP . '/' . $directory) === 0) { + return true; + } + } + return false; + } + ); + + if (!empty($fileTypes)) { + $changedFiles = array_filter( + $changedFiles, + function ($path) use ($fileTypes) { + return in_array(pathinfo($path, PATHINFO_EXTENSION), $fileTypes); + } + ); } - self::$whiteList = Utility\Files::readLists(__DIR__ . '/_files/' . $type . 'whitelist/*.txt'); - self::$blackList = Utility\Files::readLists(__DIR__ . '/_files/' . $type . 'blacklist/*.txt'); + + return $changedFiles; } /** @@ -83,15 +94,12 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase if (!$codeSniffer->canRun()) { $this->markTestSkipped('PHP Code Sniffer is not installed.'); } - if (version_compare($codeSniffer->version(), '1.4.7') === -1) { + if (version_compare($wrapper->version(), '1.4.7') === -1) { $this->markTestSkipped('PHP Code Sniffer Build Too Old.'); } - self::setupFileLists('phpcs'); - $result = $codeSniffer->run(self::$whiteList, self::$blackList, ['php']); - $this->assertFileExists( - $reportFile, - 'Expected ' . $reportFile . ' to be created by phpcs run with PSR2 standard' - ); + + $result = $codeSniffer->run(self::getWhitelist()); + $this->assertEquals( 0, $result, @@ -112,8 +120,8 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase if (!$codeSniffer->canRun()) { $this->markTestSkipped('PHP Code Sniffer is not installed.'); } - self::setupFileLists(); - $result = $codeSniffer->run(self::$whiteList, self::$blackList, ['php', 'phtml']); + $codeSniffer->setExtensions(['php', 'phtml']); + $result = $codeSniffer->run(self::getWhitelist(['php', 'phtml'])); $this->assertEquals( 0, $result, @@ -139,12 +147,11 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase if (!$codeSniffer->canRun()) { $this->markTestSkipped('PHP Code Sniffer is not installed.'); } - self::setupFileLists('phpcs'); - $severity = 0; // Change to 5 to see the warnings + $result = $codeSniffer->run(self::getWhitelist(['php'])); $this->assertEquals( 0, - $result = $codeSniffer->run(self::$whiteList, self::$blackList, ['php'], $severity), + $result, "PHP Code Sniffer has found {$result} error(s): See detailed report in {$reportFile}" ); } @@ -152,18 +159,11 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase /** * Run mess detector on code * - * @param array $whiteList * @return void - * @dataProvider whiteListDataProvider */ - public function testCodeMess($whiteList) + public function testCodeMess() { - if (count($whiteList) == 1) { - $formattedPath = preg_replace('~/~', '_', preg_replace('~' . self::$pathToSource . '~', '', $whiteList[0])); - } else { - $formattedPath = '_app_lib'; - } - $reportFile = self::$reportDir . '/phpmd_report' . $formattedPath . '.xml'; + $reportFile = self::$reportDir . '/phpmd_report.xml'; $codeMessDetector = new CodeMessDetector(realpath(__DIR__ . '/_files/phpmd/ruleset.xml'), $reportFile); if (!$codeMessDetector->canRun()) { @@ -171,40 +171,15 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase } $this->assertEquals( - PHP_PMD_TextUI_Command::EXIT_SUCCESS, - $codeMessDetector->run($whiteList, self::$blackList), + Command::EXIT_SUCCESS, + $codeMessDetector->run(self::getWhitelist(['php'])), "PHP Code Mess has found error(s): See detailed report in {$reportFile}" ); // delete empty reports - unlink($reportFile); - } - - /** - * To improve the test execution performance the whitelist is split into smaller parts: - * - in case of dev code (tests, tools, etc) each whitelist entry is fed separately to phpmd - * - app/lib code is still being executed within a single whitelist to make sure that all design - * metrics (depth of inheritance, number of children, etc.) are being calculated in a correct way. - * @return array - */ - public function whiteListDataProvider() - { - $whiteList = []; - $testCodePattern = '~' . self::$pathToSource . '/dev/~'; - $nonTestCode = []; - - self::setupFileLists(); - - foreach (self::$whiteList as $path) { - if (!preg_match($testCodePattern, $path)) { - $nonTestCode[] = $path; - } else { - $whiteList[] = [[$path]]; - } + if (file_exists($reportFile)) { + unlink($reportFile); } - $whiteList[] = [$nonTestCode]; - - return $whiteList; } /** @@ -221,14 +196,15 @@ class LiveCodeTest extends PHPUnit_Framework_TestCase $this->markTestSkipped('PHP Copy/Paste Detector is not available.'); } - self::setupFileLists(); $blackList = []; foreach (glob(__DIR__ . '/_files/phpcpd/blacklist/*.txt') as $list) { $blackList = array_merge($blackList, file($list, FILE_IGNORE_NEW_LINES)); } + $copyPasteDetector->setBlackList($blackList); + $this->assertTrue( - $copyPasteDetector->run([], $blackList), + $copyPasteDetector->run([BP]), "PHP Copy/Paste Detector has found error(s): See detailed report in {$reportFile}" ); } diff --git a/dev/tests/static/testsuite/Magento/Test/Php/_files/blacklist/common.txt b/dev/tests/static/testsuite/Magento/Test/Php/_files/blacklist/common.txt deleted file mode 100644 index 8b0e96b4500ba4c14ddb1afce061f51d3c2f6cfc..0000000000000000000000000000000000000000 --- a/dev/tests/static/testsuite/Magento/Test/Php/_files/blacklist/common.txt +++ /dev/null @@ -1,118 +0,0 @@ -# Files or directories that are excluded from static code analysis for any reason -# Glob patterns are supported -# Overrides the white list -# -app/code/Magento/Backend/Model/Config.php -app/code/Magento/Backend/Model/Config/Structure/Converter.php -app/code/Magento/Backend/Model/Menu/Config.php -app/code/Magento/Backend/Block/Widget/Grid -app/code/Magento/Backend/view -app/code/Magento/ConfigurableProduct/view -app/code/Magento/DesignEditor/view -app/code/Magento/Email/view -app/code/Magento/Integration/view -app/code/Magento/Msrp/view -app/code/Magento/Theme/view -app/code/Magento/User/view -app/code/Magento/Webapi/view -app/code/Magento/GroupedProduct/view -app/code/Magento/Rss/view -app/code/Magento/UrlRewrite/view -dev/tests/integration/framework/Magento/TestFramework/Db/Mysql.php -dev/tests/integration/framework/Magento/TestFramework/Db/Adapter/Mysql.php -dev/tests/integration/framework/Magento/TestFramework/Db/ConnectionAdapter.php -dev/tests/integration/testsuite/Magento/Framework/DB/Adapter/Pdo/MysqlTest.php -dev/tests/integration/testsuite/Magento/Test/Integrity/Modular/TemplateFilesTest.php -dev/tests/integration/testsuite/Magento/Test/Integrity/Theme/TemplateFilesTest.php -dev/tests/integration/testsuite/Magento/Backend/Block/System/Config/FormStub.php -dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture -dev/tests/integration/testsuite/Magento/Framework/Code/_expected -dev/tests/integration/tmp -dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeMessTest/phpmd/input -dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input -dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/expected -dev/tests/static/testsuite/Magento/Test/Legacy/_files -dev/tests/unit/testsuite/Magento/Core/Model/Resource/Db/AbstractTest.php -dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files -dev/tests/unit/testsuite/Magento/Framework/Session/ConfigTest.php -dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngine/_files -lib/internal/Magento/Framework/App/Config/Element.php -lib/internal/Magento/Framework/Archive -lib/internal/Magento/Framework/Backup -lib/internal/Magento/Framework/Cache/Backend/Database.php -lib/internal/Magento/Framework/Cache/Backend/Eaccelerator.php -lib/internal/Magento/Framework/Cache/Backend/Memcached.php -lib/internal/Magento/Framework/Cache/Core.php -lib/internal/Magento/Framework/Data/Collection.php -lib/internal/Magento/Framework/Data/Collection/Db.php -lib/internal/Magento/Framework/Data/Collection/Db/FetchStrategy/Cache.php -lib/internal/Magento/Framework/Data/Collection/Db/FetchStrategy/Query.php -lib/internal/Magento/Framework/Data/Collection/Db/FetchStrategyInterface.php -lib/internal/Magento/Framework/Data/Collection/Filesystem.php -lib/internal/Magento/Framework/Data/Form.php -lib/internal/Magento/Framework/Data/Form/AbstractForm.php -lib/internal/Magento/Framework/Data/Form/Element/AbstractElement.php -lib/internal/Magento/Framework/Data/Form/Element/Button.php -lib/internal/Magento/Framework/Data/Form/Element/Checkbox.php -lib/internal/Magento/Framework/Data/Form/Element/Checkboxes.php -lib/internal/Magento/Framework/Data/Form/Element/Collection.php -lib/internal/Magento/Framework/Data/Form/Element/Column.php -lib/internal/Magento/Framework/Data/Form/Element/Date.php -lib/internal/Magento/Framework/Data/Form/Element/Editablemultiselect.php -lib/internal/Magento/Framework/Data/Form/Element/Editor.php -lib/internal/Magento/Framework/Data/Form/Element/Fieldset.php -lib/internal/Magento/Framework/Data/Form/Element/File.php -lib/internal/Magento/Framework/Data/Form/Element/Gallery.php -lib/internal/Magento/Framework/Data/Form/Element/Hidden.php -lib/internal/Magento/Framework/Data/Form/Element/Image.php -lib/internal/Magento/Framework/Data/Form/Element/Imagefile.php -lib/internal/Magento/Framework/Data/Form/Element/Label.php -lib/internal/Magento/Framework/Data/Form/Element/Link.php -lib/internal/Magento/Framework/Data/Form/Element/Multiline.php -lib/internal/Magento/Framework/Data/Form/Element/Multiselect.php -lib/internal/Magento/Framework/Data/Form/Element/Note.php -lib/internal/Magento/Framework/Data/Form/Element/Obscure.php -lib/internal/Magento/Framework/Data/Form/Element/Password.php -lib/internal/Magento/Framework/Data/Form/Element/Radio.php -lib/internal/Magento/Framework/Data/Form/Element/Radios.php -lib/internal/Magento/Framework/Data/Form/Element/Renderer/RendererInterface.php -lib/internal/Magento/Framework/Data/Form/Element/Reset.php -lib/internal/Magento/Framework/Data/Form/Element/Select.php -lib/internal/Magento/Framework/Data/Form/Element/Submit.php -lib/internal/Magento/Framework/Data/Form/Element/Text.php -lib/internal/Magento/Framework/Data/Form/Element/Textarea.php -lib/internal/Magento/Framework/Data/Form/Element/Time.php -lib/internal/Magento/Framework/Data/Form/Filter/Date.php -lib/internal/Magento/Framework/Data/Form/Filter/Escapehtml.php -lib/internal/Magento/Framework/Data/Form/Filter/FilterInterface.php -lib/internal/Magento/Framework/Data/Form/Filter/Striptags.php -lib/internal/Magento/Framework/Data/Tree.php -lib/internal/Magento/Framework/Data/Tree/Db.php -lib/internal/Magento/Framework/Data/Tree/Dbp.php -lib/internal/Magento/Framework/Data/Tree/Node.php -lib/internal/Magento/Framework/Data/Tree/Node/Collection.php -lib/internal/Magento/Framework/DB -lib/internal/Magento/Framework/Stdlib/DateTime.php -lib/internal/Magento/Framework/Debug.php -lib/internal/Magento/Framework/Event.php -lib/internal/Magento/Framework/Event -lib/internal/Magento/Framework/File/Csv.php -lib/internal/Magento/Framework/File/CsvMulty.php -lib/internal/Magento/Framework/File/Transfer/Adapter/Http.php -lib/internal/Magento/Framework/File/Uploader.php -lib/internal/Magento/Framework/Gdata -lib/internal/Magento/Framework/HTTP/Adapter/Curl.php -lib/internal/Magento/Framework/HTTP/Client.php -lib/internal/Magento/Framework/HTTP/Client/Curl.php -lib/internal/Magento/Framework/HTTP/Client/Socket.php -lib/internal/Magento/Framework/HTTP/ClientInterface.php -lib/internal/Magento/Framework/Image -lib/internal/Magento/Framework/Image.php -lib/internal/Magento/Framework/Io -lib/internal/Magento/Framework/Object -lib/internal/Magento/Framework/Object.php -lib/internal/Magento/Framework/Simplexml -lib/internal/Magento/Framework/System -lib/internal/Magento/Framework/Util.php -lib/internal/Magento/Framework/Xml -vendor diff --git a/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcs/blacklist/common.txt b/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcs/blacklist/common.txt deleted file mode 100644 index 0e230d6265703550fb3222212211dc0d207d3c99..0000000000000000000000000000000000000000 --- a/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcs/blacklist/common.txt +++ /dev/null @@ -1,41 +0,0 @@ -# Files or directories that are excluded from static code analysis for any reason -# Glob patterns are supported -# Overrides the white list -# -# Formatter introduces long line -app/bootstrap.php -# Formatter introduces long line -app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/NewCategory.php -# Formatter introduces long line -app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php -# Formatter introduces long line -app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Category.php -# Formatter introduces long line -app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Weight.php -# Formatter introduces long line -app/code/Magento/Catalog/Block/Adminhtml/Product/Options/Ajax.php -# Formatter introduces long line -app/code/Magento/Cms/Block/Adminhtml/Page/Edit/Tab/Design.php -# Formatter introduces long line -app/code/Magento/Backend/Block/Page/System/Config/Robots/Reset.php -# Formatter introduces long line -app/code/Magento/Backend/Block/System/Store/Edit.php -# Not magento code -dev/tools/layout -# PSR-1 not applied to -dev/tests/js -# Example files that are expected to fail code sniffer -dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeStyleTest/phpcs/input -# Example files that are expected to fail code mess detector -dev/tests/static/testsuite/Magento/Test/Php/Exemplar/CodeMessTest/phpmd/input -# __ method for Translate cannot be in camelCase -lib/internal/Magento/Framework/Translate/Adapter.php -# __ method for Translate cannot be in camelCase -lib/internal/Magento/Framework/Translate/AdapterInterface.php -# Exclude unit, integration, and api-functional tests from PSR-X code style check -dev/tests/api-functional -dev/tests/integration -dev/tests/unit -# Newer version of phpcs does not complain about spacing issue. This appears to be a bug in the phpcs version that is currently run in bamboo. -app/code/Magento/Sales/Model/Order/Payment/Transaction.php -vendor diff --git a/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcs/whitelist/common.txt b/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcs/whitelist/common.txt deleted file mode 100644 index bd9a1028a5ede1523e4f9b691a9fdbac68e25b3f..0000000000000000000000000000000000000000 --- a/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcs/whitelist/common.txt +++ /dev/null @@ -1,8 +0,0 @@ -# Files or directories that are included into php code sniffer analysis -# Glob patterns are supported -# -app -dev -index.php -lib/internal/Magento -pub diff --git a/dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xml b/dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xml index c6cdc91d42f8d4882a2bcbafd5d031684070d780..8252342c83817d451b00a48bb645ca7ed4f2ce93 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xml +++ b/dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xml @@ -28,11 +28,19 @@ <rule ref="rulesets/unusedcode.xml" /> <!-- Code design rules --> - <rule ref="rulesets/design.xml" /> + <rule ref="rulesets/design.xml/ExitExpression" /> + <rule ref="rulesets/design.xml/EvalExpression" /> + <rule ref="rulesets/design.xml/GotoStatement" /> + <rule ref="rulesets/design.xml/NumberOfChildren" /> + <rule ref="rulesets/design.xml/DepthOfInheritance"> + <properties> + <property name="minimum" value="8" /> + </properties> + </rule> + <rule ref="rulesets/design.xml/CouplingBetweenObjects" /> <!-- Naming Rules --> <rule ref="rulesets/naming.xml/ShortMethodName" /> - <rule ref="rulesets/naming.xml/ConstructorWithNameAsEnclosingClass" /> <rule ref="rulesets/naming.xml/ConstantNamingConventions" /> <rule ref="rulesets/naming.xml/BooleanGetMethodName" /> </ruleset> diff --git a/dev/tests/static/testsuite/Magento/Test/Php/_files/whitelist/common.txt b/dev/tests/static/testsuite/Magento/Test/Php/_files/whitelist/common.txt index 58699d3f8c545d6e7697a7668de6dff99b53ad07..ef69654a548bdbb4894794ce817bacaf32c88ae5 100644 --- a/dev/tests/static/testsuite/Magento/Test/Php/_files/whitelist/common.txt +++ b/dev/tests/static/testsuite/Magento/Test/Php/_files/whitelist/common.txt @@ -1,148 +1,9 @@ -# Files or directories that are included into static code analysis -# Glob patterns are supported -# -app/bootstrap.php -app/code/Magento/Backend/Block/Page/System/Config/Robots/Reset.php -app/code/Magento/Backend/Block/System/Store/Edit -app/code/Magento/Backend/Block/System/Store/Edit.php -app/code/Magento/Backend/Model/Observer.php -app/code/Magento/Bundle/Model/Plugin -app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/NewCategory.php -app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php -app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php -app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Category.php -app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Weight.php -app/code/Magento/Catalog/Block/Adminhtml/Product/Options/Ajax.php -app/code/Magento/Catalog/Block/Product/TemplateSelector.php -app/code/Magento/Catalog/Block/Product/View/BaseImage.php -app/code/Magento/Catalog/Block/Product/View/Gallery.php -app/code/Magento/Catalog/Block/Product/View/Tabs.php -app/code/Magento/Catalog/Model/Attribute/Config -app/code/Magento/Catalog/Model/Attribute/Config.php -app/code/Magento/Catalog/Model/Resource/Category/Collection -app/code/Magento/Catalog/Model/Product/Type.php -app/code/Magento/Catalog/Model/ProductOptions -app/code/Magento/Catalog/Model/ProductTypes -app/code/Magento/Catalog/Model/Plugin -app/code/Magento/CatalogInventory/Block/Adminhtml/Form/Field/Stock.php -app/code/Magento/Centinel/Model/State/Jcb.php -app/code/Magento/Checkout/Block/Cart/Link.php -app/code/Magento/Checkout/Block/Link.php -app/code/Magento/Cms/Block/Adminhtml/Page/Edit/Tab/Design.php -app/code/Magento/Cms/Controller/Router.php -app/code/Magento/Cms/Model/Template/FilterProvider.php -app/code/Magento/ConfigurableImportExport -app/code/Magento/ConfigurableProduct -app/code/Magento/Core/data -app/code/Magento/Core/Model/Design.php -app/code/Magento/Core/Model/Layout/Update.php -app/code/Magento/Core/Model/Resource/Theme -app/code/Magento/Core/Model/Resource/Theme.php -app/code/Magento/Core/Model/Theme -app/code/Magento/Core/Model/Theme.php -app/code/Magento/Core/Model/Url/SecurityInfo.php -app/code/Magento/Cron/Model/Config/Converter -app/code/Magento/Cron/Model/Config/Reader -app/code/Magento/Cron/Model/Config/Data.php -app/code/Magento/Cron/Model/Config/SchemaLocator.php -app/code/Magento/Cron/Model/Config.php -app/code/Magento/Cron/Model/ConfigInterface.php -app/code/Magento/Directory/Helper -app/code/Magento/Customer/Block -app/code/Magento/Customer/Controller -app/code/Magento/Customer/Helper -app/code/Magento/Customer/Model/Visitor.php -app/code/Magento/Customer/Model/Resource/Visitor.php -app/code/Magento/Customer/Model/Address/Config -app/code/Magento/Customer/Model/Address/Config.php -app/code/Magento/CustomerImportExport/Model/Import/CustomerComposite.php -app/code/Magento/CustomerImportExport/Model/Resource/Import/Customer/Storage.php -app/code/Magento/CustomerImportExport/Model/Resource/Import/CustomerComposite/Data.php -app/code/Magento/Directory/Model/Currency/DefaultLocator.php -app/code/Magento/Directory/Model/Resource/Region -app/code/Magento/Eav/Model/Cache/Type.php -app/code/Magento/GiftMessage/Model/Plugin -app/code/Magento/GiftMessage/Model/Type/Plugin -app/code/Magento/GiftMessage/Service -app/code/Magento/GoogleShopping/Block/SiteVerification.php -app/code/Magento/GoogleShopping/Model/AttributeFactory.php -app/code/Magento/GroupedImportExport -app/code/Magento/Eav/Model/Entity/Attribute/Config -app/code/Magento/Eav/Model/Entity/Attribute/Config.php -app/code/Magento/Email -app/code/Magento/ImportExport/Model/Export/Config -app/code/Magento/ImportExport/Model/Export/Config.php -app/code/Magento/ImportExport/Model/Export/ConfigInterface.php -app/code/Magento/ImportExport/Model/Import/Config -app/code/Magento/ImportExport/Model/Import/Config.php -app/code/Magento/ImportExport/Model/Import/ConfigInterface.php -app/code/Magento/ImportExport/Controller/Adminhtml/Import.php -app/code/Magento/Integration -app/code/Magento/Log/Model/Resource/Helper.php -app/code/Magento/Log/Model/Resource/Shell.php -app/code/Magento/Log/Model/Shell.php -app/code/Magento/Log/Model/Shell -app/code/Magento/Msrp -app/code/Magento/ProductAlert/Block/Product/View -app/code/Magento/Reports/Block/Adminhtml/Customer -app/code/Magento/Reports/Block/Adminhtml/Product -app/code/Magento/Reports/Controller/Adminhtml/Report/Customer.php -app/code/Magento/Reports/Controller/Adminhtml/Report/Product.php -app/code/Magento/Reports/Model/Plugin -app/code/Magento/Reports/Model/Resource/Accounts -app/code/Magento/Reports/Model/Resource/Customer -app/code/Magento/Reports/Model/Resource/Report/Collection.php -app/code/Magento/Sales/Block/Guest/Link.php -app/code/Magento/Sales/Block/Order/Link.php -app/code/Magento/Sales/Block/Order/Info/Buttons/Rss.php -app/code/Magento/Sales/Block/Adminhtml/Order/Details.php -app/code/Magento/Sales/Model/Order/Pdf/Config -app/code/Magento/Sales/Model/Order/Pdf/Config.php -app/code/Magento/Sales/Model/Order/Pdf/Total/Factory.php -app/code/Magento/Sales/Model/Observer -app/code/Magento/Quote/Model/Quote/Address/*Interface.php -app/code/Magento/Quote/Model/Quote/Address/*Interface.php -app/code/Magento/Sales/Model/Resource/Order/Rss/OrderStatus.php -app/code/Magento/Sales/Model/Rss/NewOrder.php -app/code/Magento/Sales/Model/Rss/OrderStatus.php -app/code/Magento/SalesRule/Model/Plugin -app/code/Magento/Sendfriend/Block/Plugin/Catalog/Product/View.php -app/code/Magento/Shipping/Block/Adminhtml/Order/Tracking/Invoice.php -app/code/Magento/Shipping/Model/Observer.php -app/code/Magento/Shipping/Model/Order/Track.php -app/code/Magento/Shipping/Model/CarrierFactory.php -app/code/Magento/Shipping/Model/Resource/Order -app/code/Magento/Theme -app/code/Magento/Webapi -app/code/Magento/GroupedProduct -app/code/Magento/Rss -app/code/Magento/CatalogUrlRewrite -app/code/Magento/CmsUrlRewrite -app/code/Magento/UrlRewrite -app/code/Magento/Wishlist/Block/Link.php -app/code/Magento/Wishlist/Block/Rss -app/code/Magento/Wishlist/Model/Rss/Wishlist.php -dev/shell +app/code/Magento +lib/internal/Magento/Framework +dev/tools/Magento +dev/tests/api-functional dev/tests/functional -dev/tests/integration/* -dev/tests/js +dev/tests/integration dev/tests/performance dev/tests/static -dev/tests/unit/framework -dev/tests/unit/testsuite/Magento/* -dev/tools -lib/internal/Magento/Framework/App -lib/internal/Magento/Framework/Backup/Db -lib/internal/Magento/Framework/Backup/Factory.php -lib/internal/Magento/Framework/Cache/Core.php -lib/internal/Magento/Framework/Convert -lib/internal/Magento/Framework/Exception -lib/internal/Magento/Framework/Stdlib/DateTime.php -lib/internal/Magento/Framework/Object.php -lib/internal/Magento/Framework/Data/Argument -lib/internal/Magento/Framework/ObjectManager -lib/internal/Magento/Framework/Api -lib/internal/Magento/Framework/Url/SecurityInfoInterface.php -lib/internal/Magento/Framework/View -lib/internal/Magento/Framework/Locale/Validator.php -lib/internal/Magento/Framework/Notification +dev/tests/unit diff --git a/dev/tests/unit/testsuite/Magento/AdminNotification/Block/ToolbarEntryTest.php b/dev/tests/unit/testsuite/Magento/AdminNotification/Block/ToolbarEntryTest.php index 683b1dee5850d8c70224d1d654da1d67383291f9..2c408ae1aa635035b8a725adf14327931f56950d 100644 --- a/dev/tests/unit/testsuite/Magento/AdminNotification/Block/ToolbarEntryTest.php +++ b/dev/tests/unit/testsuite/Magento/AdminNotification/Block/ToolbarEntryTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test class for \Magento\AdminNotification\Block\ToolbarEntry */ diff --git a/dev/tests/unit/testsuite/Magento/Backend/Block/System/Config/Form/Field/ImageTest.php b/dev/tests/unit/testsuite/Magento/Backend/Block/System/Config/Form/Field/ImageTest.php index 7da41c293028ecf40bda13b890caf393de5d9cac..7b971cdb97f81cac457f630fd2d91795e9e05b6d 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Block/System/Config/Form/Field/ImageTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Block/System/Config/Form/Field/ImageTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Tests for \Magento\Framework\Data\Form\Element\Image */ diff --git a/dev/tests/unit/testsuite/Magento/Backend/Block/System/Config/FormTest.php b/dev/tests/unit/testsuite/Magento/Backend/Block/System/Config/FormTest.php index a273fb5b3fb41fcaf7af5821fa87fdfd7921a4bf..0a697297a03beedf9c1e86562069235829331f38 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Block/System/Config/FormTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Block/System/Config/FormTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\System\Config; class FormTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Backend/Block/Widget/Grid/ColumnSetTest.php b/dev/tests/unit/testsuite/Magento/Backend/Block/Widget/Grid/ColumnSetTest.php index 389f5054d8826b89257b3fd043ee71e71050e510..c6f1264a4bf780a03da397d75119b3b92c1d7aba 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Block/Widget/Grid/ColumnSetTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Block/Widget/Grid/ColumnSetTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Block\Widget\Grid; class ColumnSetTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Cache/CleanMediaTest.php b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Cache/CleanMediaTest.php index f8dc96754c3c083ae84c93f54413626b54d28dd3..f790cefacb9d61c383d49e970949406b5128baab 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Cache/CleanMediaTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Cache/CleanMediaTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Controller\Adminhtml\Cache; class CleanMediaTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/AbstractTestCase.php b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/AbstractTestCase.php index 03f7337a5cf486d20a82f276c5640b6d59834669..628361d81f6a3d89cf320ae43fa1b01e0be1ed88 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/AbstractTestCase.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/AbstractTestCase.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Controller\Adminhtml\Dashboard; /** @@ -47,4 +50,4 @@ class AbstractTestCase extends \PHPUnit_Framework_TestCase $result = $controller->execute(); $this->assertInstanceOf('Magento\Framework\Controller\Result\Raw', $result); } -} \ No newline at end of file +} diff --git a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/CustomersMostTest.php b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/CustomersMostTest.php index db0953e5722d085028cfa27646750a0f3f7dfdff..f5e8faa95a9be8a04eb291f52bb80574c848e9de 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/CustomersMostTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/CustomersMostTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Controller\Adminhtml\Dashboard; /** @@ -17,4 +20,4 @@ class CustomersMostTest extends AbstractTestCase 'Magento\Backend\Block\Dashboard\Tab\Customers\Most' ); } -} \ No newline at end of file +} diff --git a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/CustomersNewestTest.php b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/CustomersNewestTest.php index 659cfb0e7eee10e821b8a28f8c8f69ea6e44a3ff..ae26588381e0ffb254c6dd996d0bceee3c22538c 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/CustomersNewestTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/CustomersNewestTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Controller\Adminhtml\Dashboard; /** @@ -17,4 +20,4 @@ class CustomersNewestTest extends AbstractTestCase 'Magento\Backend\Block\Dashboard\Tab\Customers\Newest' ); } -} \ No newline at end of file +} diff --git a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/ProductsViewedTest.php b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/ProductsViewedTest.php index a596b5601e1ad355b992642ca11fd13173f2f4eb..58c718b8e190b1efe189ad7045a5a574811a3819 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/ProductsViewedTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Controller/Adminhtml/Dashboard/ProductsViewedTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Controller\Adminhtml\Dashboard; /** @@ -17,4 +20,4 @@ class ProductsViewedTest extends AbstractTestCase 'Magento\Backend\Block\Dashboard\Tab\Products\Viewed' ); } -} \ No newline at end of file +} diff --git a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Backend/Cookie/LifetimeTest.php b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Backend/Cookie/LifetimeTest.php index 996b6678266e7b56110ed29738c9e2fafd7c5202..48669c595a16d13b8579d43886cfbdfa34b60648 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Backend/Cookie/LifetimeTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Backend/Cookie/LifetimeTest.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Model\Config\Backend\Cookie; use Magento\Framework\Session\Config\Validator\CookieLifetimeValidator; diff --git a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Backend/Cookie/PathTest.php b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Backend/Cookie/PathTest.php index be9207e5c6fe8e3f904fc72d09047eb49c63a6ad..80535bd3a7a8e5750418770dfb53a34352508e73 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Backend/Cookie/PathTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Backend/Cookie/PathTest.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Model\Config\Backend\Cookie; use Magento\Framework\Session\Config\Validator\CookiePathValidator; diff --git a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Source/Storage/Media/DatabaseTest.php b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Source/Storage/Media/DatabaseTest.php index 1ce3008588eb202ea59850c5eab1365494038ab7..ea9b0305958526150fa48ff9bb77f539315723e8 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Source/Storage/Media/DatabaseTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/Source/Storage/Media/DatabaseTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Model\Config\Source\Storage\Media; use Magento\Framework\App\DeploymentConfig\ResourceConfig; diff --git a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/StructureTest.php b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/StructureTest.php index 8295bf4373e12a1588d3e0c94b68932179e94fbd..a7b8c95fb8dabfa13773461c44be29de7308b159 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Model/Config/StructureTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Model/Config/StructureTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Backend\Model\Config; class StructureTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Backend/Model/Session/QuoteTest.php b/dev/tests/unit/testsuite/Magento/Backend/Model/Session/QuoteTest.php index eae156f7039938437c2d22f904e73250fa790eb5..ac801cd35c338ef38ae42c970d6bed179b8b6b8e 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Model/Session/QuoteTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Model/Session/QuoteTest.php @@ -7,6 +7,7 @@ namespace Magento\Backend\Model\Session; /** * Class QuoteTest + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class QuoteTest extends \PHPUnit_Framework_TestCase { @@ -89,6 +90,7 @@ class QuoteTest extends \PHPUnit_Framework_TestCase * Set up * * @return void + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function setUp() { diff --git a/dev/tests/unit/testsuite/Magento/Backend/Model/UrlTest.php b/dev/tests/unit/testsuite/Magento/Backend/Model/UrlTest.php index d2fcc6cd2408a2382c939faae45b12bb5e100aec..ab47208132cd1273112c856feb5ed4e045f02873 100644 --- a/dev/tests/unit/testsuite/Magento/Backend/Model/UrlTest.php +++ b/dev/tests/unit/testsuite/Magento/Backend/Model/UrlTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test class for \Magento\Backend\Model\Url */ diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle/OptionTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle/OptionTest.php index 597f5a58b436d33ebbe216f9272a7d0d7e7bc460..c6f2121e63cdc5e47e74b92a47a86e799f6517e5 100644 --- a/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle/OptionTest.php +++ b/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/Bundle/OptionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Bundle\Block\Catalog\Product\View\Type\Bundle; class OptionTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/BundleTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/BundleTest.php index fc0e35d8a2496d6885bb79c83c870efec1bbd560..0ab5f8cd9e8d5fd87f5ff61829d2559c72b4d91d 100644 --- a/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/BundleTest.php +++ b/dev/tests/unit/testsuite/Magento/Bundle/Block/Catalog/Product/View/Type/BundleTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Bundle\Block\Catalog\Product\View\Type; use Magento\Bundle\Block\Catalog\Product\View\Type\Bundle as BundleBlock; diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Model/LinkManagementTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Model/LinkManagementTest.php index 3d35555c256ffe6b4ba3513012b35e36afa2d676..723814408cadc4b7889116c6403c9e6e4aa2557a 100644 --- a/dev/tests/unit/testsuite/Magento/Bundle/Model/LinkManagementTest.php +++ b/dev/tests/unit/testsuite/Magento/Bundle/Model/LinkManagementTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Bundle\Model; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Model/OptionRepositoryTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Model/OptionRepositoryTest.php index b8ad6a8a2fb1c345c88291752484bc6e44016552..7bff3de04713e455b38ba66d0e10c9d2f4fa8a11 100644 --- a/dev/tests/unit/testsuite/Magento/Bundle/Model/OptionRepositoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Bundle/Model/OptionRepositoryTest.php @@ -339,6 +339,9 @@ class OptionRepositoryTest extends \PHPUnit_Framework_TestCase $this->assertEquals($optionId, $this->model->save($productMock, $optionMock)); } + /** + * @SuppressWarnings(PHPMD.UnusedLocalVariable) + */ public function testUpdate() { $productId = 1; diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Adjustment/CalculatorTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Adjustment/CalculatorTest.php index d50ffb47b6fa24815bb1bfac38987067bbb7df38..e86ce9938c915cbdf8f6e3799369ef15da055fcd 100644 --- a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Adjustment/CalculatorTest.php +++ b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Adjustment/CalculatorTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Bundle\Pricing\Adjustment; use Magento\Bundle\Model\Product\Price as ProductPrice; diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/BundleSelectionPriceTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/BundleSelectionPriceTest.php index 716dbd625882a45c5b98d346a66b71ca42910681..ff9c9373125981f67ac32d6309ffcd2729c0a59e 100644 --- a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/BundleSelectionPriceTest.php +++ b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/BundleSelectionPriceTest.php @@ -164,6 +164,7 @@ class BundleSelectionPriceTest extends \PHPUnit_Framework_TestCase * * @param bool $useRegularPrice * @dataProvider useRegularPriceDataProvider + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function testGetValueTypeDynamic($useRegularPrice) { diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/DiscountCalculatorTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/DiscountCalculatorTest.php index 46abdf85c13bfcda31c12644a64377dacef5747f..90d9ecf56f2387de963e7197590c06a56b0a2645 100644 --- a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/DiscountCalculatorTest.php +++ b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/DiscountCalculatorTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Bundle\Pricing\Price; use Magento\Catalog\Pricing\Price\FinalPrice; diff --git a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/GroupPriceTest.php b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/GroupPriceTest.php index 8a342f55a5c87369dac42a2837a6605af73e9aeb..f57db1fc2ba47beae2a5e6ee1cf8b88b0ae6c43c 100644 --- a/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/GroupPriceTest.php +++ b/dev/tests/unit/testsuite/Magento/Bundle/Pricing/Price/GroupPriceTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Bundle\Pricing\Price; class GroupPriceTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Block/Adminhtml/Category/AbstractCategoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Block/Adminhtml/Category/AbstractCategoryTest.php index cd333f1084e3cff0d28d1bdfa84ff1dfd2447265..067a798dec8dc8a001a76435698acf630677bdae 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Block/Adminhtml/Category/AbstractCategoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Block/Adminhtml/Category/AbstractCategoryTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Block\Adminhtml\Category; class AbstractCategoryTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Block/Layer/ViewTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Block/Layer/ViewTest.php index 2dbbedd282848d4a8a1b1bf201c64b63e424b42b..c210938a5655d4b3800c3deb0d34f9eae01005b6 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Block/Layer/ViewTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Block/Layer/ViewTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Block\Layer; class ViewTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/AbstractProductTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/AbstractProductTest.php index bd0a63848a01e8e69c9d7db0a963913724715b5d..8489f90f8d4e53f0dfe818b56f11408101ec5be5 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/AbstractProductTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/AbstractProductTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Block\Product; /** diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/ViewTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/ViewTest.php index 07939b4af2997ff94e5426f516d66ceb2f856f72..a24913f94e3f91f9b86f6cff3c5d7ae351358fda 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/ViewTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Block/Product/ViewTest.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Block\Product; class ViewTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/SaveTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/SaveTest.php index 268dc23b7c20b3f6cf6fa9d28b34307b8f350632..9e484f562bb08123cadec8eddd78dd23d956beaf 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/SaveTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/SaveTest.php @@ -7,6 +7,7 @@ namespace Magento\Catalog\Controller\Adminhtml\Category; /** * Class SaveTest + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class SaveTest extends \PHPUnit_Framework_TestCase { @@ -79,6 +80,7 @@ class SaveTest extends \PHPUnit_Framework_TestCase * Set up * * @return void + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function setUp() { @@ -208,6 +210,7 @@ class SaveTest extends \PHPUnit_Framework_TestCase * @return void * * @dataProvider dataProviderExecute + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function testExecute($categoryId, $storeId, $activeTabId, $parentId) { diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/Widget/CategoriesJsonTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/Widget/CategoriesJsonTest.php index 73cb35cd910c4b8e12cda9294a04807b96547152..13653fcab211b966830e17e652903415833a0c0a 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/Widget/CategoriesJsonTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/Widget/CategoriesJsonTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Controller\Adminhtml\Category\Widget; class CategoriesJsonTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/Widget/ChooserTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/Widget/ChooserTest.php index a9341574976c6e8c2e50929ef21e0bda6479f003..e8fbd0e48984574c4777584a8d6b3e17207ee017 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/Widget/ChooserTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Adminhtml/Category/Widget/ChooserTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Controller\Adminhtml\Category\Widget; class ChooserTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Product/Compare/IndexTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Product/Compare/IndexTest.php index 8651eeddaeee9fd0fffd04af7ed694aec1db03c6..4fbc2520073e6ae996e19915e3867e0054b62aa2 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Controller/Product/Compare/IndexTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Controller/Product/Compare/IndexTest.php @@ -4,10 +4,17 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Controller\Product\Compare; use Magento\Catalog\Model\Resource\Product\Compare\Item; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class IndexTest extends \PHPUnit_Framework_TestCase { /** @var \Magento\Catalog\Controller\Product\Compare\Index */ diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/App/Action/ContextPluginTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/App/Action/ContextPluginTest.php index 6438e226925a5c989a5fe1e7a3270fe6d6c7a397..0b75edb91339b417287023ed54db3bc08c440e2c 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/App/Action/ContextPluginTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/App/Action/ContextPluginTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\App\Action; /** diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Attribute/Backend/CustomlayoutupdateTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Attribute/Backend/CustomlayoutupdateTest.php index f0172f61760bdbe472e76e366d7833d15ad6bd11..d81f994ac651139f5d067f2d1fbecabf0980858b 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Attribute/Backend/CustomlayoutupdateTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Attribute/Backend/CustomlayoutupdateTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Attribute\Backend; use Magento\Framework\Object; diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/Attribute/Backend/SortbyTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/Attribute/Backend/SortbyTest.php index b70e8603cf355c52c48265e83084f2054479cccf..2b53761a3e69ba8d4a736ffcce49883ededa169f 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/Attribute/Backend/SortbyTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/Attribute/Backend/SortbyTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Category\Attribute\Backend; class SortbyTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/AttributeRepositoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/AttributeRepositoryTest.php index 033aac16b2a35cee51994a18f891353f6cffc1b2..6d732839032ba270ab53d7dfd3199dd5ef86bb9c 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/AttributeRepositoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/AttributeRepositoryTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Category; class AttributeRepositoryTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/TreeTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/TreeTest.php index 7cd636423f6d8aa2ab36ad1e24fb9d3118733698..8b38af7d56cf11789780bb23e96598f7e90ec2cf 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/TreeTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Category/TreeTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Category; class TreeTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/CategoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/CategoryTest.php index f2acac23f6346625626f088664ccc01d72849e7b..b6c02ba81cfe5261b5d83435b7725a0cd186c952 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/CategoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/CategoryTest.php @@ -4,8 +4,14 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class CategoryTest extends \PHPUnit_Framework_TestCase { /** @var \Magento\Catalog\Model\Category */ diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Category/AffectCacheTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Category/AffectCacheTest.php index e85a96138433567d9a28323d49efba28d7a646e4..0c429ca3b0d307f134f4c5a1c68383aaf01c45ed 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Category/AffectCacheTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Category/AffectCacheTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Category; class AffectCacheTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/AffectCacheTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/AffectCacheTest.php index b64b75a231673b668b1e4c87b9312edce0b9223e..3cc1ea6c9a7d9406173b79dec63690bca0772c41 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/AffectCacheTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/AffectCacheTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Product; class AffectCacheTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/EraserTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/EraserTest.php index 22356c44c90b82d814a058f18c149ee00399e340..c666bd8fe562aea22d4df06cc205bb1497bea873 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/EraserTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/EraserTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Product\Flat\Action; class EraserTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/RowTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/RowTest.php index 57639149f1fd15f0eca6354ac51fa7d94d1d3e5a..70146267648875adab1acefe84c4b871c907e9c5 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/RowTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/RowTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Product\Flat\Action; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/RowsTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/RowsTest.php index d986cd69e08306de668d68de552ee619d5343c7f..0789115e201847cc1ea7cb953f864047e81aafad 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/RowsTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/RowsTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Product\Flat\Action; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Price/Plugin/CustomerGroupTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Price/Plugin/CustomerGroupTest.php index a81e075e87ec9499a462aac0f0f449e1c544dae9..9918a2a5aabe6f4fb30215b273836e604432afd0 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Price/Plugin/CustomerGroupTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Indexer/Product/Price/Plugin/CustomerGroupTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Indexer\Product\Price\Plugin; class CustomerGroupTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/AvailabilityFlagTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/AvailabilityFlagTest.php index db49b44bf81a2d42993513299c831989f24c2355..cc6bf85af0a54d84390fa245d1b8b0cb15c663f1 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/AvailabilityFlagTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/AvailabilityFlagTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Layer\Category; class AvailabilityFlagTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/CollectionFilterTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/CollectionFilterTest.php index 99311ea2d28f379fc85d332d889edb0aaa6305fa..99ff6566e00ffaad403427189c44837d9ed08f0b 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/CollectionFilterTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/CollectionFilterTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Layer\Category; class CollectionFilterTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/FilterableAttributeListTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/FilterableAttributeListTest.php index f822e76b4069805d76d04a1d9a9e1c780d251ae7..dae378983bc9369da81837fd2e629605034e1494 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/FilterableAttributeListTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Category/FilterableAttributeListTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Layer\Category; class FilterableAttributeListTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/AttributeTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/AttributeTest.php index 8ffb53ffbd420a855a59b3e21a6e480130990de8..74725687834c145cdc0e3676272f0eed0a8d3364 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/AttributeTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/AttributeTest.php @@ -9,6 +9,9 @@ namespace Magento\Catalog\Model\Layer\Filter; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; use PHPUnit_Framework_MockObject_MockObject as MockObject; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class AttributeTest extends \PHPUnit_Framework_TestCase { /** @var \Magento\Catalog\Model\Resource\Layer\Filter\Attribute|MockObject */ @@ -46,6 +49,9 @@ class AttributeTest extends \PHPUnit_Framework_TestCase /** @var \Magento\Catalog\Model\Layer\Filter\Item\DataBuilder|MockObject */ private $itemDataBuilder; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ protected function setUp() { /** @var \Magento\Catalog\Model\Layer\Filter\ItemFactory $filterItemFactory */ diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/DataProvider/CategoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/DataProvider/CategoryTest.php index b131668677b1b0616b3d26d3e85fce0a83a36ec6..387c212cf3808a29c4fcf98c23cdcd4fc30ae665 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/DataProvider/CategoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/DataProvider/CategoryTest.php @@ -34,6 +34,9 @@ class CategoryTest extends \PHPUnit_Framework_TestCase */ private $target; + /** + * @SuppressWarnings(PHPMD.UnusedLocalVariable) + */ protected function setUp() { /** @var \Magento\Framework\Registry $var */ diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/PriceTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/PriceTest.php index 13e4651c380cebd7f5d0a908c107bf26b30d374b..e3cc7a3095c652a02d953ead43f7d1eba7bbd2f2 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/PriceTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Filter/PriceTest.php @@ -11,6 +11,7 @@ use PHPUnit_Framework_MockObject_MockObject as MockObject; /** * Test for \Magento\Catalog\Model\Layer\Filter\Price + * @SuppressWarnings(PHPMD.UnusedPrivateField) */ class PriceTest extends \PHPUnit_Framework_TestCase { @@ -50,6 +51,9 @@ class PriceTest extends \PHPUnit_Framework_TestCase /** @var \Magento\Catalog\Model\Layer\State|MockObject */ private $state; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ protected function setUp() { $this->request = $this->getMockBuilder('\Magento\Framework\App\RequestInterface') diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/FilterListTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/FilterListTest.php index a9597d643e96a3fc419f9a88b80df9c7ca7af935..4da641bc12ab3e75e33bb6b98d0843a74d6754fe 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/FilterListTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/FilterListTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Layer; class FilterListTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Search/FilterableAttributeListTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Search/FilterableAttributeListTest.php index 4c2b9e41b2d6c2d0266ac79524dba406af2bb518..2afb8894af13f6b52dcbd0cb8086abf1e88498d1 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Search/FilterableAttributeListTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layer/Search/FilterableAttributeListTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Layer\Search; class FilterableAttributeListTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/LayerTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/LayerTest.php index ed43f9df57fdd64cf2a76584e14d093ef7530007..10a9fad9e999486018759af27d1f192ed99e2795 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/LayerTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/LayerTest.php @@ -10,6 +10,7 @@ use Magento\TestFramework\Helper\ObjectManager; /** * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * @SuppressWarnings(PHPMD.TooManyFields) */ class LayerTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layout/DepersonalizePluginTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layout/DepersonalizePluginTest.php index 402a945b676423da15a45630fd87c93f5f92c8b4..e3785dc0597438b0d723a5cfe4ffe143a504d6c5 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Layout/DepersonalizePluginTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Layout/DepersonalizePluginTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Layout; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/ManagementTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/ManagementTest.php index 9e557abe38c4f133a5533d61f5c3c8e660503d9a..eed3bbd143def33e8f46d8c6968e9f47cf79c233 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/ManagementTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/ManagementTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product\Attribute; class ManagementTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/RepositoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/RepositoryTest.php index e2b722a6467564aeaa678150909faf1f0bb4ab66..8cecb48fe4deead0a9b775ed82ce97377a44cbf3 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/RepositoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/RepositoryTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product\Attribute; class RepositoryTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Source/StatusTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Source/StatusTest.php index 4a0a5f9c58899a16da698bbfd3a3aa2d50a94f07..e60e93c25a433e30b2ddd54ad448f464d9cffdd9 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Source/StatusTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/Source/StatusTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product\Attribute\Source; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/TypesListTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/TypesListTest.php index c9e3f52e0a5e6315a4cf12188c6222dd9950958d..e8ddde956122fedf3571fc65bdff631f624f332b 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/TypesListTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Attribute/TypesListTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product\Attribute; class TypesListTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/LinkTypeProviderTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/LinkTypeProviderTest.php index 095253b7ed2dafbd49f0c7757ae02fc1ea21d03a..33f854d885c7bc13e8a4a593bb2ea7ef9bdba848 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/LinkTypeProviderTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/LinkTypeProviderTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product; class LinkTypeProviderTest extends \PHPUnit_Framework_TestCase @@ -66,6 +69,9 @@ class LinkTypeProviderTest extends \PHPUnit_Framework_TestCase ); } + /** + * @SuppressWarnings(PHPMD.UnusedLocalVariable) + */ public function testGetItems() { $expectedResult = []; diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Option/Validator/PoolTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Option/Validator/PoolTest.php index c49f3f2cbbac3600ce57d96efd64ee3887928f40..3474b5c24848e0bf0a3f3fab7c79accfc47ae74d 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Option/Validator/PoolTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/Option/Validator/PoolTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product\Option\Validator; class PoolTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/PriceModifierTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/PriceModifierTest.php index fe291a1c4ca11068d8f9521bbd39110410156233..9feb30c610fea1787ff97aba8e820b24d77b1346 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/PriceModifierTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/PriceModifierTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product; class PriceModifierTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/TierPriceManagementTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/TierPriceManagementTest.php index 9f63916000aeeb4e6cb06aeacaaeb3a5f11fb304..42e114740a7ace570859a3a2b7659ce25c16c62e 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/TierPriceManagementTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Product/TierPriceManagementTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Product; use Magento\Customer\Model\GroupManagement; diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/ProductTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/ProductTest.php index 67628ef7ea3e5859626d039be8a1cb3b8f1c42d0..1dc92b950212b39003fed8943591093a4fd0247c 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/ProductTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/ProductTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Category/TreeTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Category/TreeTest.php index 480ffdde0eb181845215de5d3d0c77410fa782c6..a9421ac5ce0cc73ffac53060695692526b654e9d 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Category/TreeTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Category/TreeTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Resource\Category; class TreeTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Eav/AttributeTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Eav/AttributeTest.php index 7612c2559d051079e60ffc642f21320871d33e62..f0eb9f0193f318c39e16f1c810a0e97f9b2def40 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Eav/AttributeTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Eav/AttributeTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Resource\Eav; class AttributeTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Product/Attribute/Backend/MediaTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Product/Attribute/Backend/MediaTest.php index f71dd5afe0878a1714d0912b9d69b75afd5383f1..77c9104daf06f5653d116d9483a636b96a7c4b8d 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Product/Attribute/Backend/MediaTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Product/Attribute/Backend/MediaTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Resource\Product\Attribute\Backend; /** diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Product/Option/CollectionTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Product/Option/CollectionTest.php index 3bdd598dc475c63dbd2b281a7907a0617b2f03e6..8ab0bf35a4b57062def707f55c4af7534902ef0a 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Product/Option/CollectionTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Resource/Product/Option/CollectionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Model\Resource\Product\Option; class CollectionTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Model/Rss/CategoryTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Model/Rss/CategoryTest.php index 5207893b9360ccbcdf6821e4175443699ec82123..1b316834f8c73764001a11ee8a1a791b05085bbc 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Model/Rss/CategoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Model/Rss/CategoryTest.php @@ -87,6 +87,9 @@ class CategoryTest extends \PHPUnit_Framework_TestCase ); } + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function testGetProductCollection() { $storeId = 1; diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/BasePriceTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/BasePriceTest.php index a3b8171283f65251df8d0ba28ef92faac8c65bad..e6b127982df8bf8e440020d8613ff001b022fd1f 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/BasePriceTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/BasePriceTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Pricing\Price; /** diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/GroupPriceTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/GroupPriceTest.php index 5aaf0fb679c0bafcb381db7815915f05ec7aa266..504c34b5318dabdc5f078c3b11b4683b0e4dc3c7 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/GroupPriceTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/GroupPriceTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Pricing\Price; /** diff --git a/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/TierPriceTest.php b/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/TierPriceTest.php index 5d5065baf36c2de8d2703faa0595a32ebd3d6234..e323dcce39eaeee6758cf2099f9e7c461ce7ed9b 100644 --- a/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/TierPriceTest.php +++ b/dev/tests/unit/testsuite/Magento/Catalog/Pricing/Price/TierPriceTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Catalog\Pricing\Price; use Magento\Customer\Model\Group; diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ObserverTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ObserverTest.php index f61d444b46b8ded5c4d7df2df636df8e1d0b3c71..069a87d165de4724a0137efd56900409da28057b 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ObserverTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/ObserverTest.php @@ -85,6 +85,9 @@ class ObserverTest extends \PHPUnit_Framework_TestCase */ protected $eventObserver; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ protected function setUp() { $this->stockStatus = $this->getMockBuilder('Magento\CatalogInventory\Model\Stock\Status') diff --git a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Spi/StockRegistryProviderTest.php b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Spi/StockRegistryProviderTest.php index d8ed93ae763d33abf20de459a8894aecf950fabb..e6b3676c654765855eb011bffc39014dc4b98a93 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Spi/StockRegistryProviderTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogInventory/Model/Spi/StockRegistryProviderTest.php @@ -102,6 +102,9 @@ class StockRegistryProviderTest extends \PHPUnit_Framework_TestCase protected $productSku = 'simple'; protected $websiteId = 111; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ protected function setUp() { $this->objectManagerHelper = new ObjectManagerHelper($this); diff --git a/dev/tests/unit/testsuite/Magento/CatalogRule/Model/CronTest.php b/dev/tests/unit/testsuite/Magento/CatalogRule/Model/CronTest.php index 60006335bf3e89dc2fa7d195c5ce910efe984ff6..03f996e09940ca502279302190f3c7da3125f7cc 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogRule/Model/CronTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogRule/Model/CronTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\CatalogRule\Model; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/CategoryTest.php b/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/CategoryTest.php index 9a2c294a8e47ef32eff44e22c75303b6627335c5..0a8fa28cf0e7e823c0934f5268c63fbc3b214173 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/CategoryTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/CategoryTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogRule\Plugin\Indexer; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/CustomerGroupTest.php b/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/CustomerGroupTest.php index 46604676dcdf076b98b25085dc8a00f56212ac8a..bf6ac53ee909ac047bfcd28668d9c8719cdaa6e6 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/CustomerGroupTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/CustomerGroupTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogRule\Plugin\Indexer; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/ImportExportTest.php b/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/ImportExportTest.php index 37b5f00dd658cddc089568874bb04f23bc6f2a09..304707fb2204dfd2d3f6a95af188291e71d0524a 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/ImportExportTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/ImportExportTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogRule\Plugin\Indexer; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/WebsiteTest.php b/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/WebsiteTest.php index 8a1609efa93fa666a69a0f822619e6ffb59884dc..c5645a8599abc0e9eb8de7dee5994961f91399ee 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/WebsiteTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogRule/Plugin/Indexer/WebsiteTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CatalogRule\Plugin\Indexer; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Adapter/Mysql/Filter/PreprocessorTest.php b/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Adapter/Mysql/Filter/PreprocessorTest.php index 870a89f5cec29fbc7affdcb12895378c43f278d1..656d52726e05c40c39f9c989afb93fdecf4b3e62 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Adapter/Mysql/Filter/PreprocessorTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Adapter/Mysql/Filter/PreprocessorTest.php @@ -10,6 +10,9 @@ use Magento\Framework\DB\Select; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; use PHPUnit_Framework_MockObject_MockObject as MockObject; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class PreprocessorTest extends \PHPUnit_Framework_TestCase { /** diff --git a/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/AttributeTest.php b/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/AttributeTest.php index a07a8f57944171f130c634c5bc89a9c6d9635782..32ee450a8f41c247e4efac52822f14b11bd523cd 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/AttributeTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/AttributeTest.php @@ -9,6 +9,9 @@ namespace Magento\CatalogSearch\Model\Layer\Filter; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; use PHPUnit_Framework_MockObject_MockObject as MockObject; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class AttributeTest extends \PHPUnit_Framework_TestCase { /** @@ -230,6 +233,9 @@ class AttributeTest extends \PHPUnit_Framework_TestCase $this->assertEquals($expectedFilterItems, $result); } + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function testGetItemsWithoutApply() { $attributeCode = 'attributeCode'; diff --git a/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/CategoryTest.php b/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/CategoryTest.php index bf6f97d3ba0d5946eb32dbdc7c9ba1d27a350bf0..eec5ad1b215e3e312d31578bf3a31eea6099b84f 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/CategoryTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/CategoryTest.php @@ -227,6 +227,9 @@ class CategoryTest extends \PHPUnit_Framework_TestCase $this->target->apply($this->request); } + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function testGetItems() { $this->category->expects($this->any()) diff --git a/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/PriceTest.php b/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/PriceTest.php index a3e127c566488fa300031248b8d47d4bd591924f..8b831e591e0f5658f53dce04611c4735b69bf17c 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/PriceTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogSearch/Model/Layer/Filter/PriceTest.php @@ -11,6 +11,7 @@ use PHPUnit_Framework_MockObject_MockObject as MockObject; /** * Test for \Magento\CatalogSearch\Model\Layer\Filter\Price + * @SuppressWarnings(PHPMD.UnusedPrivateField) */ class PriceTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/CatalogWidget/Block/Product/ProductsListTest.php b/dev/tests/unit/testsuite/Magento/CatalogWidget/Block/Product/ProductsListTest.php index 2984882436fa62301995afc2a538ee7453faee52..2a2886db769f865ebc6bbd98ad2b25684beece55 100644 --- a/dev/tests/unit/testsuite/Magento/CatalogWidget/Block/Product/ProductsListTest.php +++ b/dev/tests/unit/testsuite/Magento/CatalogWidget/Block/Product/ProductsListTest.php @@ -11,6 +11,7 @@ use Magento\Catalog\Model\Product\Visibility; /** * Class ProductsListTest + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class ProductsListTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Controller/Onepage/IndexTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Controller/Onepage/IndexTest.php index 5468c42017381a1a0a79784cfc1e4285908baa56..1fd79006a5b2246281f0eead91c956d616fd6b5a 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Controller/Onepage/IndexTest.php +++ b/dev/tests/unit/testsuite/Magento/Checkout/Controller/Onepage/IndexTest.php @@ -10,6 +10,9 @@ namespace Magento\Checkout\Controller\Onepage; use Magento\TestFramework\Helper\ObjectManager as ObjectManager; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + */ class IndexTest extends \PHPUnit_Framework_TestCase { /** diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Helper/CartTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Helper/CartTest.php index 92de0a169a8ac4ec0eb9f0b0a14e86814d82052c..c01449d988414ee12b160f2281910f6a9efed3e6 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Helper/CartTest.php +++ b/dev/tests/unit/testsuite/Magento/Checkout/Helper/CartTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Helper; use Magento\Framework\App\Action\Action; @@ -201,6 +204,7 @@ class CartTest extends \PHPUnit_Framework_TestCase * @param string $expectedPostData * * @dataProvider deletePostJsonDataProvider + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function testGetDeletePostJson($id, $url, $isAjax, $expectedPostData) { diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Helper/DataTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Helper/DataTest.php index b37fe984cc8f6c0ef9f971247f066e70633ee82e..9e88e7178acf602aaff791e8baed99a763aa46c0 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Helper/DataTest.php +++ b/dev/tests/unit/testsuite/Magento/Checkout/Helper/DataTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Helper; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Model/Layout/DepersonalizePluginTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Model/Layout/DepersonalizePluginTest.php index d01b6aa2d648fdc1143956c3b019333d6967a0b0..b09e0f6a6867208536a7a0b226935a9f86cdb129 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Model/Layout/DepersonalizePluginTest.php +++ b/dev/tests/unit/testsuite/Magento/Checkout/Model/Layout/DepersonalizePluginTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Model\Layout; /** diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Model/SessionTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Model/SessionTest.php index 5e47cead68f680c482f40c615bf10f84db701398..4151d9b246801171593acec670da372c0d8d9dc1 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Model/SessionTest.php +++ b/dev/tests/unit/testsuite/Magento/Checkout/Model/SessionTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test class for \Magento\Checkout\Model\Session */ diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Model/Type/OnepageTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Model/Type/OnepageTest.php index d9c86e7d48859b32684b4a8b81cdd8c9e6cfbc58..7b46a4a2c8eef0639e6cd0fd6665ed2182fc854d 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Model/Type/OnepageTest.php +++ b/dev/tests/unit/testsuite/Magento/Checkout/Model/Type/OnepageTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Checkout\Model\Type; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; @@ -97,6 +99,9 @@ class OnepageTest extends \PHPUnit_Framework_TestCase /** @var \Magento\Framework\Api\ExtensibleDataObjectConverter|\PHPUnit_Framework_MockObject_MockObject */ protected $extensibleDataObjectConverterMock; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ protected function setUp() { $this->addressRepositoryMock = $this->getMockForAbstractClass( @@ -379,6 +384,8 @@ class OnepageTest extends \PHPUnit_Framework_TestCase * @SuppressWarnings(PHPMD.ExcessiveMethodLength) * @SuppressWarnings(PHPMD.ExcessiveParameterList) * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function testSaveBilling( $data, diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/ReadServiceTest.php deleted file mode 100644 index bfe221961b52867e07b751c20336a15f763cb52c..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/ReadServiceTest.php +++ /dev/null @@ -1,49 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Address\Billing; - -class ReadServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var ReadService - */ - protected $service; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $converterMock; - - protected function setUp() - { - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->converterMock = $this->getMock('\Magento\Checkout\Service\V1\Address\Converter', [], [], '', false); - - $this->service = new ReadService($this->quoteRepositoryMock, $this->converterMock); - } - - public function testGetAddress() - { - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $this->quoteRepositoryMock->expects($this->once())->method('getActive') - ->with('cartId')->will($this->returnValue($quoteMock)); - - $addressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', [], [], '', false); - $quoteMock->expects($this->any())->method('getBillingAddress')->will($this->returnValue($addressMock)); - - $this->converterMock->expects($this->once())->method('convertModelToDataObject') - ->with($addressMock)->will($this->returnValue('BillingAddress')); - - $this->assertEquals('BillingAddress', $this->service->getAddress('cartId')); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/WriteServiceTest.php deleted file mode 100644 index 3b853623ce4327dc3784047286860d5e6c456333..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Billing/WriteServiceTest.php +++ /dev/null @@ -1,187 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Address\Billing; - -class WriteServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var WriteService - */ - protected $service; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $addressFactoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteAddressMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $validatorMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $converterMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $loggerMock; - - protected function setUp() - { - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->addressFactoryMock = $this->getMock( - '\Magento\Quote\Model\Quote\AddressFactory', ['create', '__wakeup'], [], '', false - ); - - $this->quoteAddressMock = $this->getMock( - '\Magento\Quote\Model\Quote\Address', - ['getCustomerId', 'load', 'getData', 'setData', 'setStreet', 'setRegionId', 'setRegion', '__wakeup'], - [], - '', - false - ); - $this->addressFactoryMock->expects($this->any()) - ->method('create') - ->will($this->returnValue($this->quoteAddressMock)); - - $this->validatorMock = $this->getMock( - '\Magento\Checkout\Service\V1\Address\Validator', [], [], '', false - ); - - $this->converterMock = $this->getMock( - '\Magento\Checkout\Service\V1\Address\Converter', [], [], '', false - ); - - $this->loggerMock = $this->getMock('\Psr\Log\LoggerInterface', [], [], '', false); - - $this->service = new \Magento\Checkout\Service\V1\Address\Billing\WriteService( - $this->quoteRepositoryMock, - $this->converterMock, - $this->validatorMock, - $this->addressFactoryMock, - $this->loggerMock - ); - } - - /** - * @expectedException \Magento\Framework\Exception\NoSuchEntityException - * @expectedExceptionMessage error123 - */ - public function testSetAddressValidationFailed() - { - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with('cartId') - ->will($this->returnValue($quoteMock)); - - $this->validatorMock->expects($this->once())->method('validate') - ->will($this->throwException(new \Magento\Framework\Exception\NoSuchEntityException('error123'))); - - $this->service->setAddress('cartId', null); - } - - public function testSetAddress() - { - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with('cartId') - ->will($this->returnValue($quoteMock)); - - $builder = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\Address\RegionBuilder', ['create'], [], '', false - ); - - $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - /** @var \Magento\Checkout\Service\V1\Data\Cart\AddressBuilder $addressDataBuilder */ - $addressDataBuilder = $objectManager->getObject( - 'Magento\Checkout\Service\V1\Data\Cart\AddressBuilder', - ['regionBuilder' => $builder] - ); - /** @var \Magento\Checkout\Service\V1\Data\Cart\Address $addressData */ - $addressData = $addressDataBuilder->setId(454)->create(); - - $this->validatorMock->expects($this->once())->method('validate') - ->with($addressData) - ->will($this->returnValue(true)); - - $this->converterMock->expects($this->once())->method('convertDataObjectToModel') - ->with($addressData, $this->quoteAddressMock) - ->will($this->returnValue($this->quoteAddressMock)); - - $quoteMock->expects($this->once())->method('setBillingAddress')->with($this->quoteAddressMock); - $quoteMock->expects($this->once())->method('setDataChanges')->with(true); - $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock); - $addressId = 1; - $billingAddressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', [], [], '', false); - $billingAddressMock->expects($this->once())->method('getId')->will($this->returnValue($addressId)); - $quoteMock->expects($this->once())->method('getBillingAddress') - ->will($this->returnValue($billingAddressMock)); - - $this->assertEquals($addressId, $this->service->setAddress('cartId', $addressData)); - } - - /** - * @expectedException \Magento\Framework\Exception\InputException - * @expectedExceptionMessage Unable to save address. Please, check input data. - */ - public function testSetAddressWithInabilityToSaveQuote() - { - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with('cartId') - ->will($this->returnValue($quoteMock)); - - $builder = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\Address\RegionBuilder', ['create'], [], '', false - ); - - $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - - /** @var \Magento\Checkout\Service\V1\Data\Cart\AddressBuilder $addressDataBuilder */ - $addressDataBuilder = $objectManager->getObject( - 'Magento\Checkout\Service\V1\Data\Cart\AddressBuilder', - ['regionBuilder' => $builder] - ); - /** @var \Magento\Checkout\Service\V1\Data\Cart\Address $addressData */ - $addressData = $addressDataBuilder->setId(454)->create(); - - $this->validatorMock->expects($this->once())->method('validate') - ->with($addressData) - ->will($this->returnValue(true)); - - $this->converterMock->expects($this->once())->method('convertDataObjectToModel') - ->with($addressData, $this->quoteAddressMock) - ->will($this->returnValue($this->quoteAddressMock)); - - $quoteMock->expects($this->once())->method('setBillingAddress')->with($this->quoteAddressMock); - $quoteMock->expects($this->once())->method('setDataChanges')->with(true); - $this->quoteRepositoryMock->expects($this->once()) - ->method('save') - ->with($quoteMock) - ->willThrowException( - new \Exception('Some DB Error') - ); - $this->service->setAddress('cartId', $addressData); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/ConverterTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/ConverterTest.php deleted file mode 100644 index e1cd60d8d334baf5cbcfa03857b3339323d1d06c..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/ConverterTest.php +++ /dev/null @@ -1,150 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Address; - -use Magento\Checkout\Service\V1\Data\Cart\Address; -use Magento\Checkout\Service\V1\Data\Cart\Address\Region; -use Magento\Framework\Api\AttributeValue; - -class ConverterTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var Converter - */ - protected $model; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $addressBuilderMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $metadataServiceMock; - - protected function setUp() - { - $this->addressBuilderMock = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\AddressBuilder', [], [], '', false - ); - $this->metadataServiceMock = $this - ->getMockBuilder('Magento\Customer\Api\CustomerMetadataInterface') - ->setMethods(['getCustomAttributesMetadata']) - ->getMockForAbstractClass(); - $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - $this->model = $objectManager->getObject( - 'Magento\Checkout\Service\V1\Address\Converter', - ['addressBuilder' => $this->addressBuilderMock, 'customerMetadata' => $this->metadataServiceMock] - ); - } - - public function testConvertModelToDataObject() - { - $addressMockMethods = [ - 'getCountryId', 'getId', 'getCustomerId', 'getRegion', 'getRegionId', 'getRegionCode', - 'getStreet', 'getCompany', 'getTelephone', 'getFax', 'getPostcode', 'getFirstname', 'getMiddlename', - 'getLastname', 'getPrefix', 'getSuffix', 'getEmail', 'getVatId', 'getCustomField', 'getCity', '__wakeup', - ]; - $addressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', $addressMockMethods, [], '', false); - - $addressMock->expects($this->atLeastOnce())->method('getCountryId')->will($this->returnValue(1)); - $addressMock->expects($this->atLeastOnce())->method('getId')->will($this->returnValue(2)); - $addressMock->expects($this->atLeastOnce())->method('getCustomerId')->will($this->returnValue(3)); - $addressMock->expects($this->atLeastOnce())->method('getRegion')->will($this->returnValue('Alabama')); - $addressMock->expects($this->atLeastOnce())->method('getRegionId')->will($this->returnValue(4)); - $addressMock->expects($this->atLeastOnce())->method('getRegionCode')->will($this->returnValue('aa')); - $addressMock->expects($this->atLeastOnce())->method('getStreet')->will($this->returnValue('street')); - $addressMock->expects($this->atLeastOnce())->method('getCompany')->will($this->returnValue('company')); - $addressMock->expects($this->atLeastOnce())->method('getTelephone')->will($this->returnValue('123-123')); - $addressMock->expects($this->atLeastOnce())->method('getFax')->will($this->returnValue('234-234')); - $addressMock->expects($this->atLeastOnce())->method('getPostcode')->will($this->returnValue('80010')); - $addressMock->expects($this->atLeastOnce())->method('getCity')->will($this->returnValue('Town')); - $addressMock->expects($this->atLeastOnce())->method('getFirstname')->will($this->returnValue('Vasya')); - $addressMock->expects($this->atLeastOnce())->method('getMiddlename')->will($this->returnValue('Vasya')); - $addressMock->expects($this->atLeastOnce())->method('getLastname')->will($this->returnValue('Pupkin')); - $addressMock->expects($this->atLeastOnce())->method('getPrefix')->will($this->returnValue('prefix')); - $addressMock->expects($this->atLeastOnce())->method('getSuffix')->will($this->returnValue('suffix')); - $addressMock->expects($this->atLeastOnce())->method('getEmail')->will($this->returnValue('aaa@aaa.com')); - $addressMock->expects($this->atLeastOnce())->method('getVatId')->will($this->returnValue(5)); - $addressMock->expects($this->atLeastOnce())->method('getCustomField')->will($this->returnValue('custom_value')); - - $testData = [ - Address::KEY_COUNTRY_ID => 1, - Address::KEY_ID => 2, - Address::KEY_CUSTOMER_ID => 3, - Address::KEY_REGION => [ - Region::REGION => 'Alabama', - Region::REGION_ID => 4, - Region::REGION_CODE => 'aa', - ], - Address::KEY_STREET => 'street', - Address::KEY_COMPANY => 'company', - Address::KEY_TELEPHONE => '123-123', - Address::KEY_FAX => '234-234', - Address::KEY_POSTCODE => '80010', - Address::KEY_CITY => 'Town', - Address::KEY_FIRSTNAME => 'Vasya', - Address::KEY_LASTNAME => 'Pupkin', - Address::KEY_MIDDLENAME => 'Vasya', - Address::KEY_PREFIX => 'prefix', - Address::KEY_SUFFIX => 'suffix', - Address::KEY_EMAIL => 'aaa@aaa.com', - Address::KEY_VAT_ID => 5, - Address::CUSTOM_ATTRIBUTES_KEY => [['attribute_code' => 'custom_field', 'value' => 'custom_value']], - ]; - - $this->metadataServiceMock - ->expects($this->any()) - ->method('getCustomAttributesMetadata') - ->will($this->returnValue([new \Magento\Framework\Object(['attribute_code' => 'custom_field'])])); - - $this->addressBuilderMock->expects($this->once())->method('populateWithArray')->with($testData)->will( - $this->returnValue($this->addressBuilderMock) - ); - $this->addressBuilderMock->expects($this->once())->method('create')->will( - $this->returnValue('Expected value') - ); - - $this->assertEquals('Expected value', $this->model->convertModelToDataObject($addressMock)); - } - - public function testConvertDataObjectToModel() - { - $dataObjectMock = $this->getMock('Magento\Checkout\Service\V1\Data\Cart\Address', [], [], '', false); - $methods = ['setData', 'setStreet', 'setRegionId', 'setRegion', '__wakeUp']; - $addressMock = $this->getMock('Magento\Quote\Model\Quote\Address', $methods, [], '', false); - $attributeValueMock = $this->getMock('\Magento\Framework\Api\AttributeValue', [], [], '', false); - $attributeValueMock->expects($this->once())->method('getAttributeCode')->will($this->returnValue('value_code')); - $attributeValueMock->expects($this->once())->method('getValue')->will($this->returnValue('value')); - - $addressData = [ - 'some_code' => 'some_value', - ]; - $regionMock = $this->getMock('Magento\Checkout\Service\V1\Data\Cart\Address\Region', [], [], '', false); - - $dataObjectMock->expects($this->once())->method('__toArray')->will($this->returnValue($addressData)); - $valueMap = [ - [$addressData, null], - ['attribute_value', 'value'], - ]; - $addressMock->expects($this->any())->method('setData')->will($this->returnValueMap($valueMap)); - $dataObjectMock - ->expects($this->once()) - ->method('getCustomAttributes') - ->will($this->returnValue([$attributeValueMock])); - $dataObjectMock->expects($this->once())->method('getStreet')->will($this->returnValue('street')); - $addressMock->expects($this->once())->method('setStreet')->with('street'); - $dataObjectMock->expects($this->any())->method('getRegion')->will($this->returnValue($regionMock)); - $regionMock->expects($this->once())->method('getRegionId')->will($this->returnValue('regionId')); - $regionMock->expects($this->once())->method('getRegion')->will($this->returnValue('region')); - $addressMock->expects($this->once())->method('setRegionId')->with('regionId'); - $addressMock->expects($this->once())->method('setRegion')->with('region'); - $this->model->convertDataObjectToModel($dataObjectMock, $addressMock); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceTest.php deleted file mode 100644 index 54700a7b9c3bda0192ca91715da0d9235689409b..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/ReadServiceTest.php +++ /dev/null @@ -1,68 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Address\Shipping; - -class ReadServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var ReadService - */ - protected $service; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $converterMock; - - protected function setUp() - { - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->converterMock = $this->getMock('\Magento\Checkout\Service\V1\Address\Converter', [], [], '', false); - - $this->service = new ReadService($this->quoteRepositoryMock, $this->converterMock); - } - - public function testGetAddress() - { - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with('cartId')->will( - $this->returnValue($quoteMock) - ); - - $addressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', [], [], '', false); - $quoteMock->expects($this->any())->method('getShippingAddress')->will($this->returnValue($addressMock)); - $quoteMock->expects($this->any())->method('isVirtual')->will($this->returnValue(false)); - - $this->converterMock->expects($this->once())->method('convertModelToDataObject') - ->with($addressMock)->will($this->returnValue('ShippingAddress')); - - $this->assertEquals('ShippingAddress', $this->service->getAddress('cartId')); - } - - /** - * @expectedException \Exception - * @expectedExceptionMessage Cart contains virtual product(s) only. Shipping address is not applicable - */ - public function testGetAddressOfQuoteWithVirtualProducts() - { - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with('cartId')->will( - $this->returnValue($quoteMock) - ); - - $quoteMock->expects($this->any())->method('isVirtual')->will($this->returnValue(true)); - $quoteMock->expects($this->never())->method('getShippingAddress'); - - $this->service->getAddress('cartId'); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/PaymentMethod/BuilderTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/PaymentMethod/BuilderTest.php deleted file mode 100644 index f0fba140b1cad11817dde59bbc6e0d41cceb722c..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/PaymentMethod/BuilderTest.php +++ /dev/null @@ -1,84 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Cart\PaymentMethod; - -class BuilderTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var \Magento\Checkout\Service\V1\Data\Cart\PaymentMethod\Builder - */ - protected $builder; - - /** - * @var \Magento\TestFramework\Helper\ObjectManager - */ - protected $objectManager; - - protected function setUp() - { - $this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - $this->builder = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\Data\Cart\PaymentMethod\Builder' - ); - } - - public function testBuildPaymentObject() - { - $paymentData = [ - 'method' => 'checkmo', - 'payment_details' => 'paymentDetailsTest', - ]; - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod', [], [], '', false); - $paymentMethodMock->expects($this->once())->method('__toArray')->will($this->returnValue($paymentData)); - $paymentMethodMock->expects($this->once()) - ->method('getPaymentDetails') - ->will($this->returnValue(serialize(['paymentDetailsTest']))); - - $paymentMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', [], [], '', false); - $paymentMock->expects($this->once()) - ->method('importData') - ->with($this->contains('checkmo')) - ->will($this->returnSelf()); - - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock)); - - $this->assertEquals($paymentMock, $this->builder->build($paymentMethodMock, $quoteMock)); - } - - /** - * @expectedException \Exception - * @expectedExceptionMessage The requested Payment Method is not available. - */ - public function testBuildPaymentObjectThrowsExceptionIfPaymentMethodNotAvailable() - { - $paymentData = [ - 'method' => 'notAvailableMethod', - 'payment_details' => 'paymentDetailsTest', - ]; - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod', [], [], '', false); - $paymentMethodMock->expects($this->once())->method('__toArray')->will($this->returnValue($paymentData)); - $paymentMethodMock->expects($this->once()) - ->method('getPaymentDetails') - ->will($this->returnValue(['paymentDetailsTest'])); - - $paymentMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', [], [], '', false); - $paymentMock->expects($this->once()) - ->method('importData') - ->with($this->contains('notAvailableMethod')) - ->will($this->throwException( - new \Magento\Framework\Exception\LocalizedException('The requested Payment Method is not available.')) - ); - - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock)); - - $this->assertEquals($paymentMock, $this->builder->build($paymentMethodMock, $quoteMock)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/PaymentMethod/ConverterTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/PaymentMethod/ConverterTest.php deleted file mode 100644 index d1260cc7f48f5a13094ca4d8c374332ecf0d7b4e..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/PaymentMethod/ConverterTest.php +++ /dev/null @@ -1,91 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Cart\PaymentMethod; - -use Magento\Checkout\Service\V1\Data\Cart\PaymentMethod; - -class ConverterTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var \Magento\Checkout\Service\V1\Data\Cart\PaymentMethod\Converter - */ - protected $converter; - - /** - * @var \Magento\TestFramework\Helper\ObjectManager - */ - protected $objectManager; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $paymentMethodBuilderMock; - - protected function setUp() - { - $this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - $this->paymentMethodBuilderMock = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\PaymentMethodBuilder', - ['populateWithArray', 'create'], - [], - '', - false - ); - - $this->converter = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\Data\Cart\PaymentMethod\Converter', - [ - 'builder' => $this->paymentMethodBuilderMock, - ] - ); - } - - public function testConvertQuotePaymentObjectToPaymentDataObject() - { - $paymentMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', - [ - 'getMethod', 'getPoNumber', 'getCcOwner', 'getCcNumber', - 'getCcType', 'getCcExpYear', 'getCcExpMonth', 'getAdditionalData', '__wakeup' - ], - [], - '', - false - ); - $paymentMock->expects($this->once())->method('getMethod')->will($this->returnValue('checkmo')); - $paymentMock->expects($this->once())->method('getPoNumber')->will($this->returnValue(100)); - $paymentMock->expects($this->once())->method('getCcOwner')->will($this->returnValue('tester')); - $paymentMock->expects($this->once())->method('getCcNumber')->will($this->returnValue(100200300)); - $paymentMock->expects($this->once())->method('getCcType')->will($this->returnValue('visa')); - $paymentMock->expects($this->once())->method('getCcExpYear')->will($this->returnValue(2014)); - $paymentMock->expects($this->once())->method('getCcExpMonth')->will($this->returnValue(10)); - $paymentMock->expects($this->once())->method('getAdditionalData')->will($this->returnValue('test')); - - $data = [ - PaymentMethod::METHOD => 'checkmo', - PaymentMethod::PO_NUMBER => 100, - PaymentMethod::CC_OWNER => 'tester', - PaymentMethod::CC_NUMBER => 100200300, - PaymentMethod::CC_TYPE => 'visa', - PaymentMethod::CC_EXP_YEAR => 2014, - PaymentMethod::CC_EXP_MONTH => 10, - PaymentMethod::PAYMENT_DETAILS => 'test', - ]; - - $this->paymentMethodBuilderMock->expects($this->once()) - ->method('populateWithArray') - ->with($data) - ->will($this->returnSelf()); - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\PaymentMethod', [], [], '', false); - - $this->paymentMethodBuilderMock->expects($this->once()) - ->method('create') - ->will($this->returnValue($paymentMethodMock)); - - $this->assertEquals($paymentMethodMock, $this->converter->toDataObject($paymentMock)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/ReadServiceTest.php deleted file mode 100644 index b500f6372972a73a98fac13a01d11c91a0d10a38..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/ReadServiceTest.php +++ /dev/null @@ -1,191 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Cart; - -use Magento\Framework\Api\SearchCriteria; - -/** - * @SuppressWarnings(PHPMD.TooManyFields) - */ -class ReadServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var ReadService - */ - protected $service; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteCollectionMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $searchResultsBuilderMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $cartMapperMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteMock; - - protected function setUp() - { - $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $methods = [ - 'getId', 'getStoreId', 'getCreatedAt', 'getUpdatedAt', 'getConvertedAt', - 'getIsActive', 'getIsVirtual', 'getItemsCount', 'getItemsQty', 'getCheckoutMethod', 'getReservedOrderId', - 'getOrigOrderId', 'getBaseGrandTotal', 'getBaseSubtotal', 'getSubtotal', 'getBaseSubtotalWithDiscount', - 'getSubtotalWithDiscount', 'getCustomerId', 'getCustomerEmail', 'getCustomerGroupId', - 'getCustomerTaxClassId', 'getCustomerPrefix', 'getCustomerFirstname', 'getCustomerMiddlename', - 'getCustomerLastname', 'getCustomerSuffix', 'getCustomerDob', 'getCustomerNote', 'getCustomerNoteNotify', - 'getCustomerIsGuest', 'getCustomerGender', 'getCustomerTaxvat', '__wakeup', 'load', 'getGrandTotal', - 'getGlobalCurrencyCode', 'getBaseCurrencyCode', 'getStoreCurrencyCode', 'getQuoteCurrencyCode', - 'getStoreToBaseRate', 'getStoreToQuoteRate', 'getBaseToGlobalRate', 'getBaseToQuoteRate', 'setStoreId', - 'getShippingAddress', 'getAllItems', - ]; - $this->quoteMock = $this->getMock('\Magento\Quote\Model\Quote', $methods, [], '', false); - $this->quoteCollectionMock = $objectManager->getCollectionMock( - 'Magento\Quote\Model\Resource\Quote\Collection', [$this->quoteMock]); - $this->searchResultsBuilderMock = - $this->getMock('\Magento\Checkout\Service\V1\Data\CartSearchResultsBuilder', [], [], '', false); - $this->cartMapperMock = $this->getMock('\Magento\Checkout\Service\V1\Data\CartMapper', ['map'], [], '', false); - - $this->service = new ReadService( - $this->quoteRepositoryMock, - $this->quoteCollectionMock, - $this->searchResultsBuilderMock, - $this->cartMapperMock - ); - } - - public function testGetCart() - { - $cartId = 12; - $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId) - ->will($this->returnValue($this->quoteMock)); - - $this->cartMapperMock->expects($this->once())->method('map')->with($this->quoteMock); - - $this->service->getCart($cartId); - } - - public function testGetCartForCustomer() - { - $customerId = 12; - $this->quoteRepositoryMock->expects($this->once())->method('getActiveForCustomer')->with($customerId) - ->will($this->returnValue($this->quoteMock)); - - $this->cartMapperMock->expects($this->once())->method('map')->with($this->quoteMock); - - $this->service->getCartForCustomer($customerId); - } - - /** - * @param int $direction - * @param string $expected - * @dataProvider getCartListSuccessDataProvider - */ - public function testGetCartListSuccess($direction, $expected) - { - $searchResult = $this->getMock('\Magento\Checkout\Service\V1\Data\CartSearchResults', [], [], '', false); - $searchCriteriaMock = $this->getMock('\Magento\Framework\Api\SearchCriteria', [], [], '', false); - - $cartMock = $this->getMock('Magento\Payment\Model\Cart', [], [], '', false); - $this->searchResultsBuilderMock - ->expects($this->once()) - ->method('setSearchCriteria') - ->will($this->returnValue($searchCriteriaMock)); - $filterGroupMock = $this->getMock('\Magento\Framework\Api\Search\FilterGroup', [], [], '', false); - $searchCriteriaMock - ->expects($this->any()) - ->method('getFilterGroups') - ->will($this->returnValue([$filterGroupMock])); - - $filterMock = $this->getMock('\Magento\Framework\Api\Filter', [], [], '', false); - $filterGroupMock->expects($this->any())->method('getFilters')->will($this->returnValue([$filterMock])); - $filterMock->expects($this->once())->method('getField')->will($this->returnValue('store_id')); - $filterMock->expects($this->any())->method('getConditionType')->will($this->returnValue('eq')); - $filterMock->expects($this->once())->method('getValue')->will($this->returnValue('filter_value')); - $this->quoteCollectionMock - ->expects($this->once()) - ->method('addFieldToFilter') - ->with(['store_id'], [0 => ['eq' => 'filter_value']]); - - $this->quoteCollectionMock->expects($this->once())->method('getSize')->will($this->returnValue(10)); - $this->searchResultsBuilderMock->expects($this->once())->method('setTotalCount')->with(10); - $sortOrderMock = $this->getMockBuilder('Magento\Framework\Api\SortOrder') - ->setMethods(['getField', 'getDirection']) - ->disableOriginalConstructor() - ->getMock(); - $sortOrderMock->expects($this->once())->method('getField')->will($this->returnValue('id')); - $sortOrderMock->expects($this->once())->method('getDirection')->will($this->returnValue($direction)); - $searchCriteriaMock - ->expects($this->once()) - ->method('getSortOrders') - ->will($this->returnValue([$sortOrderMock])); - $this->quoteCollectionMock->expects($this->once())->method('addOrder')->with('entity_id', $expected); - $searchCriteriaMock->expects($this->once())->method('getCurrentPage')->will($this->returnValue(1)); - $searchCriteriaMock->expects($this->once())->method('getPageSize')->will($this->returnValue(10)); - - $this->cartMapperMock->expects($this->once())->method('map')->with($this->quoteMock) - ->will($this->returnValue($cartMock)); - - $this->searchResultsBuilderMock->expects($this->once())->method('setItems')->with([$cartMock]); - $this->searchResultsBuilderMock - ->expects($this->once()) - ->method('create') - ->will($this->returnValue($searchResult)); - $this->assertEquals($searchResult, $this->service->getCartList($searchCriteriaMock)); - } - - /** - * @expectedException \Magento\Framework\Exception\InputException - * @expectedExceptionMessage Field 'any_value' cannot be used for search. - */ - public function testGetCartListWithNotExistingField() - { - $searchCriteriaMock = $this->getMock('\Magento\Framework\Api\SearchCriteria', [], [], '', false); - $this->searchResultsBuilderMock - ->expects($this->once()) - ->method('setSearchCriteria') - ->will($this->returnValue($searchCriteriaMock)); - - $filterGroupMock = $this->getMock('\Magento\Framework\Api\Search\FilterGroup', [], [], '', false); - $searchCriteriaMock - ->expects($this->any()) - ->method('getFilterGroups') - ->will($this->returnValue([$filterGroupMock])); - $filterMock = $this->getMock('\Magento\Framework\Api\Filter', [], [], '', false); - $filterGroupMock->expects($this->any())->method('getFilters')->will($this->returnValue([$filterMock])); - $filterMock->expects($this->once())->method('getField')->will($this->returnValue('any_value')); - $filterMock->expects($this->never())->method('getConditionType'); - $this->service->getCartList($searchCriteriaMock); - } - - /** - * @return array - */ - public function getCartListSuccessDataProvider() - { - return [ - 'asc' => [SearchCriteria::SORT_ASC, 'ASC'], - 'desc' => [SearchCriteria::SORT_DESC, 'DESC'] - ]; - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/TotalsServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/TotalsServiceTest.php deleted file mode 100644 index 64f5cffc6ce0f1d7484e2910a7477d6ec2b40787..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/TotalsServiceTest.php +++ /dev/null @@ -1,86 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Cart; - -class TotalsServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $quoteMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $itemTotalsMapperMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $totalsMapperMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $totalsBuilderMock; - - /** - * @var TotalsService - */ - private $service; - - public function setUp() - { - $this->quoteMock = $this->getMock( - 'Magento\Quote\Model\Quote', [], [], '', false - ); - $this->totalsBuilderMock = $this->getMock( - 'Magento\Checkout\Service\V1\Data\Cart\TotalsBuilder', - ['populateWithArray', 'setItems', 'create'], - [], - '', - false - ); - $this->totalsMapperMock = $this->getMock( - 'Magento\Checkout\Service\V1\Data\Cart\TotalsMapper', [], [], '', false - ); - $this->quoteRepositoryMock = $this->getMock( - 'Magento\Quote\Model\QuoteRepository', [], [], '', false - ); - $this->itemTotalsMapperMock = $this->getMock( - 'Magento\Checkout\Service\V1\Data\Cart\Totals\ItemMapper', ['extractDto'], [], '', false - ); - - $this->service = new TotalsService( - $this->totalsBuilderMock, - $this->totalsMapperMock, - $this->quoteRepositoryMock, - $this->itemTotalsMapperMock - ); - } - - public function testGetTotals() - { - $cartId = 12; - $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId) - ->will($this->returnValue($this->quoteMock)); - - $this->totalsMapperMock->expects($this->once()) - ->method('map') - ->with($this->quoteMock) - ->will($this->returnValue(['test'])); - - $item = $this->getMock('Magento\Quote\Model\Quote\Item', [], [], '', false); - $this->quoteMock->expects($this->once())->method('getAllItems')->will($this->returnValue([$item])); - $this->service->getTotals($cartId); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php deleted file mode 100644 index 7434e70ad591ee3b927c31341de9a972b2e6d8d5..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Cart/WriteServiceTest.php +++ /dev/null @@ -1,424 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Cart; - -use Magento\Framework\Exception\CouldNotSaveException; -use Magento\TestFramework\Helper\ObjectManager; - -/** - * Class WriteServiceTest - */ -class WriteServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var \Magento\Checkout\Service\V1\Cart\WriteService - */ - protected $service; - - /** - * @var \Magento\TestFramework\Helper\ObjectManager - */ - protected $objectManager; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $storeManagerMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $storeMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $userContextMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteServiceFactory; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $customerRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $customerFactoryMock; - - public function setUp() - { - $this->objectManager = new ObjectManager($this); - $this->storeManagerMock = $this->getMock('\Magento\Store\Model\StoreManagerInterface'); - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->userContextMock = $this->getMock('\Magento\Authorization\Model\UserContextInterface'); - - $this->storeMock = $this->getMock('\Magento\Store\Model\Store', [], [], '', false); - $this->quoteMock = - $this->getMock('\Magento\Quote\Model\Quote', - [ - 'setStoreId', - 'getId', - 'getStoreId', - 'getCustomerId', - 'setCustomer', - 'setCustomerIsGuest', - '__wakeup', - ], - [], '', false); - - $this->customerRepositoryMock = $this->getMock( - '\Magento\Customer\Api\CustomerRepositoryInterface', [], [], '', false - ); - - $this->customerFactoryMock = $this->getMock( - 'Magento\Customer\Model\CustomerFactory', - ['create'], - [], - '', - false - ); - - $this->quoteServiceFactory = $this->getMock( - 'Magento\Quote\Model\QuoteManagement', - [], - [], - '', - false - ); - $this->service = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\Cart\WriteService', - [ - 'storeManager' => $this->storeManagerMock, - 'customerRepository' => $this->customerRepositoryMock, - 'quoteRepository' => $this->quoteRepositoryMock, - 'userContext' => $this->userContextMock, - 'quoteServiceFactory' => $this->quoteServiceFactory, - 'customerModelFactory' => $this->customerFactoryMock - ] - ); - } - - public function testCreateAnonymousCart() - { - $storeId = 345; - - $this->userContextMock->expects($this->once())->method('getUserType') - ->willReturn(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_ADMIN); - $this->storeManagerMock->expects($this->once()) - ->method('getStore') - ->will($this->returnValue($this->storeMock)); - $this->storeMock->expects($this->once()) - ->method('getId') - ->will($this->returnValue($storeId)); - - $this->quoteRepositoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock); - $this->quoteMock->expects($this->once())->method('setStoreId')->with($storeId); - $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); - $this->quoteMock->expects($this->once())->method('getId')->willReturn(100); - $this->assertEquals(100, $this->service->create()); - } - - /** - * @expectedException \Magento\Framework\Exception\CouldNotSaveException - * @expectedExceptionMessage Cannot create quote - */ - public function testCreateCustomerCartWhenCustomerHasActiveCart() - { - $storeId = 345; - $userId = 50; - - $customerMock = $this->getMockForAbstractClass( - 'Magento\Customer\Api\Data\CustomerInterface', - [], - '', - false - ); - $this->customerRepositoryMock->expects($this->once()) - ->method('getById') - ->with($userId) - ->will($this->returnValue($customerMock)); - - $this->userContextMock->expects($this->once())->method('getUserType') - ->willReturn(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_CUSTOMER); - $this->userContextMock->expects($this->any())->method('getUserId')->willReturn($userId); - $this->storeManagerMock->expects($this->once()) - ->method('getStore') - ->will($this->returnValue($this->storeMock)); - $this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId)); - - $customerQuoteMock = $this->getMock('\Magento\Quote\Model\Quote', - [ - 'getIsActive', - 'getId', - '__wakeup' - ], - [], - '', - false - ); - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActiveForCustomer') - ->with($userId) - ->willReturn($customerQuoteMock); - $this->quoteRepositoryMock->expects($this->never())->method('save')->with($this->quoteMock); - - $this->service->create(); - } - - public function testCreateCustomerCart() - { - $storeId = 345; - $userId = 50; - - $customerMock = $this->getMockForAbstractClass( - 'Magento\Customer\Api\Data\CustomerInterface', - [], - '', - false - ); - $this->customerRepositoryMock->expects($this->once()) - ->method('getById')->with($userId)->will($this->returnValue($customerMock)); - $this->userContextMock->expects($this->once())->method('getUserType') - ->willReturn(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_CUSTOMER); - $this->userContextMock->expects($this->any())->method('getUserId')->willReturn($userId); - $this->storeManagerMock->expects($this->once()) - ->method('getStore') - ->will($this->returnValue($this->storeMock)); - $this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId)); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActiveForCustomer') - ->with($userId) - ->willThrowException(new \Magento\Framework\Exception\NoSuchEntityException()); - $this->quoteRepositoryMock->expects($this->once())->method('create')->willReturn($this->quoteMock); - - $this->quoteMock->expects($this->once())->method('setStoreId')->with($storeId); - $this->quoteMock->expects($this->once())->method('setCustomer')->with($customerMock); - $this->quoteMock->expects($this->once())->method('setCustomerIsGuest')->with(0); - $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); - $this->quoteMock->expects($this->once())->method('getId')->willReturn(100); - $this->assertEquals(100, $this->service->create()); - } - - /** - * @expectedException \Magento\Framework\Exception\CouldNotSaveException - * @expectedExceptionMessage Cannot create quote - */ - public function testCreateWithException() - { - $storeId = 345; - - $this->storeManagerMock->expects($this->once()) - ->method('getStore') - ->will($this->returnValue($this->storeMock)); - $this->storeMock->expects($this->once()) - ->method('getId') - ->will($this->returnValue($storeId)); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('create') - ->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once()) - ->method('setStoreId') - ->with($storeId); - $this->quoteRepositoryMock->expects($this->once()) - ->method('save') - ->will($this->throwException(new CouldNotSaveException('Cannot create quote'))); - - $this->service->create(); - } - - /** - * @expectedException \Magento\Framework\Exception\StateException - * @expectedExceptionMessage Cannot assign customer to the given cart. The cart belongs to different store. - */ - public function testAssignCustomerStateExceptionWithStoreId() - { - $cartId = 956; - $customerId = 125; - $storeId = 12; - - $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock)); - $this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId)); - $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $customerMock = $this->getMockForAbstractClass( - 'Magento\Customer\Api\Data\CustomerInterface', - [], - '', - false - ); - $this->customerRepositoryMock->expects($this->once()) - ->method('getById')->with($customerId)->will($this->returnValue($customerMock)); - $customerModelMock = $this->getMockBuilder('Magento\Customer\Model\Customer') - ->disableOriginalConstructor() - ->setMethods(['load', 'getSharedStoreIds']) - ->getMock(); - $this->customerFactoryMock->expects($this->once())->method('create')->willReturn($customerModelMock); - $customerModelMock->expects($this->once()) - ->method('load') - ->with($customerId) - ->willReturnSelf(); - $customerModelMock->expects($this->once())->method('getSharedStoreIds')->will( - $this->returnValue([11]) - ); - - $this->service->assignCustomer($cartId, $customerId); - } - - /** - * @expectedException \Magento\Framework\Exception\StateException - * @expectedExceptionMessage Cannot assign customer to the given cart. The cart is not anonymous. - */ - public function testAssignCustomerStateExceptionWithCustomerId() - { - $cartId = 956; - $customerId = 125; - $storeId = 12; - - $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock)); - $this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId)); - $customerMock = $this->getMockForAbstractClass( - 'Magento\Customer\Api\Data\CustomerInterface', - [], - '', - false - ); - $this->customerRepositoryMock->expects($this->once()) - ->method('getById')->with($customerId)->will($this->returnValue($customerMock)); - - $customerModelMock = $this->getMockBuilder('Magento\Customer\Model\Customer') - ->disableOriginalConstructor() - ->setMethods(['load', 'getSharedStoreIds']) - ->getMock(); - $this->customerFactoryMock->expects($this->once())->method('create')->willReturn($customerModelMock); - $customerModelMock->expects($this->once()) - ->method('load') - ->with($customerId) - ->willReturnSelf(); - $customerModelMock->expects($this->once())->method('getSharedStoreIds')->will( - $this->returnValue([$storeId]) - ); - $this->quoteMock->expects($this->once())->method('getCustomerId')->will($this->returnValue($customerId)); - $this->quoteMock->expects($this->never())->method('setCustomer'); - - $this->service->assignCustomer($cartId, $customerId); - } - - /** - * @expectedException \Magento\Framework\Exception\StateException - * @expectedExceptionMessage Cannot assign customer to the given cart. Customer already has active cart. - */ - public function testAssignCustomerStateExceptionWithAlreadyAssignedCustomer() - { - $cartId = 956; - $customerId = 125; - $storeId = 12; - - $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock)); - $this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId)); - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); - - $customerModelMock = $this->getMockBuilder('Magento\Customer\Model\Customer') - ->disableOriginalConstructor() - ->setMethods(['load', 'getSharedStoreIds']) - ->getMock(); - $this->customerFactoryMock->expects($this->once())->method('create')->willReturn($customerModelMock); - $customerModelMock->expects($this->once())->method('getSharedStoreIds')->will($this->returnValue([$storeId])); - $customerModelMock->expects($this->once()) - ->method('load') - ->with($customerId) - ->willReturnSelf(); - $this->quoteMock->expects($this->once())->method('getCustomerId')->will($this->returnValue(null)); - - $customerQuoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $this->quoteRepositoryMock->expects($this->once()) - ->method('getForCustomer') - ->with($customerId) - ->will($this->returnValue($customerQuoteMock)); - - $this->quoteMock->expects($this->never())->method('setCustomer'); - - $this->service->assignCustomer($cartId, $customerId); - } - - public function testAssignCustomer() - { - $cartId = 956; - $customerId = 125; - $storeId = 12; - - $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock)); - $this->storeMock->expects($this->once())->method('getId')->will($this->returnValue($storeId)); - $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $customerMock = $this->getMockForAbstractClass( - 'Magento\Customer\Api\Data\CustomerInterface', - [], - '', - false, - true, - true - ); - $this->customerRepositoryMock->expects($this->once()) - ->method('getById')->with($customerId)->will($this->returnValue($customerMock)); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getForCustomer') - ->with($customerId) - ->willThrowException(new \Magento\Framework\Exception\NoSuchEntityException()); - - $customerModelMock = $this->getMockBuilder('Magento\Customer\Model\Customer') - ->disableOriginalConstructor() - ->setMethods(['load', 'getSharedStoreIds']) - ->getMock(); - $this->customerFactoryMock->expects($this->once())->method('create')->willReturn($customerModelMock); - $customerModelMock->expects($this->once())->method('getSharedStoreIds')->will($this->returnValue([$storeId])); - $customerModelMock->expects($this->once()) - ->method('load') - ->with($customerId) - ->willReturnSelf(); - $this->quoteMock->expects($this->once())->method('getCustomerId')->will($this->returnValue(false)); - $this->quoteMock->expects($this->once()) - ->method('setCustomer')->with($customerMock)->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once()) - ->method('setCustomerIsGuest')->with(0)->will($this->returnValue($this->quoteMock)); - $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); - - $this->assertTrue($this->service->assignCustomer($cartId, $customerId)); - } - - public function testOrder() - { - $cartId = 123; - $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $orderMock = $this->getMock('Magento\Sales\Model\Order', [], [], '', false); - $orderMock->expects($this->any())->method('getId')->will($this->returnValue(5)); - $this->quoteServiceFactory->expects($this->once())->method('submit')->with($this->quoteMock) - ->will($this->returnValue($orderMock)); - $this->assertEquals(5, $this->service->order($cartId)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/ReadServiceTest.php deleted file mode 100644 index 5742b27ae5567a381582637c06d414ae80d8446c..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/ReadServiceTest.php +++ /dev/null @@ -1,68 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Coupon; - -use Magento\Checkout\Service\V1\Data\Cart\Coupon as Coupon; - -class ReadServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var ReadService - */ - protected $service; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $couponBuilderMock; - - protected function setUp() - { - $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->couponBuilderMock = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\CouponBuilder', [], [], '', false - ); - $this->service = $objectManager->getObject( - 'Magento\Checkout\Service\V1\Coupon\ReadService', - [ - 'quoteRepository' => $this->quoteRepositoryMock, - 'couponBuilder' => $this->couponBuilderMock, - ] - ); - } - - public function testGetCoupon() - { - $cartId = 11; - $couponCode = 'test_coupon_code'; - - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', ['getCouponCode', '__wakeup'], [], '', false); - $quoteMock->expects($this->any())->method('getCouponCode')->will($this->returnValue($couponCode)); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($quoteMock)); - - $data = [Coupon::COUPON_CODE => $couponCode]; - - $this->couponBuilderMock->expects($this->once()) - ->method('populateWithArray') - ->with($data) - ->will($this->returnSelf()); - $this->couponBuilderMock->expects($this->once())->method('create')->will($this->returnValue('couponCode')); - - $this->assertEquals('couponCode', $this->service->get($cartId)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/Cart/CustomerMapperTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/Cart/CustomerMapperTest.php deleted file mode 100644 index 599757e903d3479080741bfb6c370912ad7c9ce5..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/Cart/CustomerMapperTest.php +++ /dev/null @@ -1,66 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\Cart; - -class CustomerMapperTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var \Magento\Checkout\Service\V1\Data\Cart\CustomerMapper - */ - protected $mapper; - - protected function setUp() - { - $this->mapper = new \Magento\Checkout\Service\V1\Data\Cart\CustomerMapper(); - } - - public function testMap() - { - $methods = ['getCustomerId', 'getCustomerEmail', 'getCustomerGroupId', 'getCustomerTaxClassId', - 'getCustomerPrefix', 'getCustomerFirstname', 'getCustomerMiddlename', 'getCustomerLastname', - 'getCustomerSuffix', 'getCustomerDob', 'getCustomerNote', 'getCustomerNoteNotify', - 'getCustomerIsGuest', 'getCustomerGender', 'getCustomerTaxvat', '__wakeUp', ]; - $quoteMock = $this->getMock('Magento\Quote\Model\Quote', $methods, [], '', false); - $expected = [ - Customer::ID => 10, - Customer::EMAIL => 'customer@example.com', - Customer::GROUP_ID => '4', - Customer::TAX_CLASS_ID => 10, - Customer::PREFIX => 'prefix_', - Customer::FIRST_NAME => 'First Name', - Customer::MIDDLE_NAME => 'Middle Name', - Customer::LAST_NAME => 'Last Name', - Customer::SUFFIX => 'suffix', - Customer::DOB => '1/1/1989', - Customer::NOTE => 'customer_note', - Customer::NOTE_NOTIFY => 'note_notify', - Customer::IS_GUEST => false, - Customer::GENDER => 'male', - Customer::TAXVAT => 'taxvat', - ]; - $expectedMethods = [ - 'getCustomerId' => 10, - 'getCustomerEmail' => 'customer@example.com', - 'getCustomerGroupId' => 4, - 'getCustomerTaxClassId' => 10, - 'getCustomerPrefix' => 'prefix_', - 'getCustomerFirstname' => 'First Name', - 'getCustomerMiddlename' => 'Middle Name', - 'getCustomerLastname' => 'Last Name', - 'getCustomerSuffix' => 'suffix', - 'getCustomerDob' => '1/1/1989', - 'getCustomerNote' => 'customer_note', - 'getCustomerNoteNotify' => 'note_notify', - 'getCustomerIsGuest' => false, - 'getCustomerGender' => 'male', - 'getCustomerTaxvat' => 'taxvat', - ]; - foreach ($expectedMethods as $method => $value) { - $quoteMock->expects($this->once())->method($method)->will($this->returnValue($value)); - } - $this->assertEquals($expected, $this->mapper->map($quoteMock)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/Cart/TotalsMapperTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/Cart/TotalsMapperTest.php deleted file mode 100644 index 0519c7928d2b172746f88187917cf578e9e673b8..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/Cart/TotalsMapperTest.php +++ /dev/null @@ -1,100 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data\Cart; - -class TotalsMapperTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var \Magento\Checkout\Service\V1\Data\Cart\TotalsMapper - */ - protected $mapper; - - protected function setUp() - { - $this->mapper = new \Magento\Checkout\Service\V1\Data\Cart\TotalsMapper(); - } - - public function testMap() - { - $methods = ['getBaseGrandTotal', 'getGrandTotal', 'getBaseSubtotal', 'getSubtotal','getBaseCurrencyCode', - 'getBaseSubtotalWithDiscount', 'getSubtotalWithDiscount', 'getShippingAddress', '__wakeUp', - 'getQuoteCurrencyCode', ]; - $quoteMock = $this->getMock('Magento\Quote\Model\Quote', $methods, [], '', false); - $methods = [ - 'getDiscountAmount', 'getBaseDiscountAmount', 'getShippingAmount', 'getBaseShippingAmount', - 'getShippingDiscountAmount', 'getBaseShippingDiscountAmount', 'getTaxAmount', 'getBaseTaxAmount', - 'getShippingTaxAmount', 'getBaseShippingTaxAmount', 'getSubtotalInclTax', 'getBaseSubtotalTotalInclTax', - 'getShippingInclTax', 'getBaseShippingInclTax', 'getId', '__wakeUp', - ]; - - $shippingAddressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', $methods, [], '', false); - - $quoteMock->expects($this->any())->method('getShippingAddress') - ->will($this->returnValue($shippingAddressMock)); - - $expected = [ - Totals::BASE_GRAND_TOTAL => 100, - Totals::GRAND_TOTAL => 150, - Totals::BASE_SUBTOTAL => 150, - Totals::SUBTOTAL => 150, - Totals::BASE_SUBTOTAL_WITH_DISCOUNT => 120, - Totals::SUBTOTAL_WITH_DISCOUNT => 120, - Totals::BASE_CURRENCY_CODE => 'EUR', - Totals::QUOTE_CURRENCY_CODE => 'BR', - Totals::DISCOUNT_AMOUNT => 110, - Totals::BASE_DISCOUNT_AMOUNT => 110, - Totals::SHIPPING_AMOUNT => 20, - Totals::BASE_SHIPPING_AMOUNT => 20, - Totals::SHIPPING_DISCOUNT_AMOUNT => 5, - Totals::BASE_SHIPPING_DISCOUNT_AMOUNT => 5, - Totals::TAX_AMOUNT => 3, - Totals::BASE_TAX_AMOUNT => 3, - Totals::SHIPPING_TAX_AMOUNT => 1, - Totals::BASE_SHIPPING_TAX_AMOUNT => 1, - Totals::SUBTOTAL_INCL_TAX => 153, - Totals::BASE_SUBTOTAL_INCL_TAX => 153, - Totals::SHIPPING_INCL_TAX => 21, - Totals::BASE_SHIPPING_INCL_TAX => 21, - ]; - $expectedQuoteMethods = [ - 'getBaseGrandTotal' => 100, - 'getGrandTotal' => 150, - 'getBaseSubtotal' => 150, - 'getSubtotal' => 150, - 'getBaseSubtotalWithDiscount' => 120, - 'getSubtotalWithDiscount' => 120, - ]; - - $addressMethods = [ - 'getDiscountAmount' => 110, - 'getBaseDiscountAmount' => 110, - 'getShippingAmount' => 20, - 'getBaseShippingAmount' => 20, - 'getShippingDiscountAmount' => 5, - 'getBaseShippingDiscountAmount' => 5, - 'getTaxAmount' => 3, - 'getBaseTaxAmount' => 3, - 'getShippingTaxAmount' => 1, - 'getBaseShippingTaxAmount' => 1, - 'getSubtotalInclTax' => 153, - 'getBaseSubtotalTotalInclTax' => 153, - 'getShippingInclTax' => 21, - 'getBaseShippingInclTax' => 21, - ]; - - $quoteMock->expects($this->atLeastOnce())->method('getBaseCurrencyCode')->will($this->returnValue('EUR')); - $quoteMock->expects($this->atLeastOnce())->method('getQuoteCurrencyCode')->will($this->returnValue('BR')); - - foreach ($expectedQuoteMethods as $method => $value) { - $quoteMock->expects($this->once())->method($method)->will($this->returnValue($value)); - } - foreach ($addressMethods as $method => $value) { - $shippingAddressMock->expects($this->once())->method($method)->will($this->returnValue($value)); - } - - $this->assertEquals($expected, $this->mapper->map($quoteMock)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/CartMapperTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/CartMapperTest.php deleted file mode 100644 index 19c4d479363d410e42aaf787a6fb7970ded51dc5..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/CartMapperTest.php +++ /dev/null @@ -1,170 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\Checkout\Service\V1\Data; - -class CartMapperTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var \Magento\Checkout\Service\V1\Data\CartMapper - */ - protected $mapper; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $totalsBuilder; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $cartBuilder; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $customerBuilder; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $customerMapper; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $totalsMapper; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $currencyMapper; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $itemTotalsMapper; - - protected function setUp() - { - $this->totalsBuilder = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\TotalsBuilder', - ['populateWithArray', 'setItems', 'create'], - [], - '', - false - ); - $this->cartBuilder = $this->getMock( - '\Magento\Checkout\Service\V1\Data\CartBuilder', - [], - [], - '', - false - ); - $this->customerBuilder = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\CustomerBuilder', - [], - [], - '', - false - ); - $this->customerMapper = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\CustomerMapper', - [], - [], - '', - false - ); - $this->totalsMapper = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\TotalsMapper', [], [], '', false); - $this->currencyMapper = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\CurrencyMapper', - ['extractDto'], - [], - '', - false - ); - $this->itemTotalsMapper = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\Totals\ItemMapper', - ['extractDto'], - [], - '', - false - ); - - $this->mapper = new \Magento\Checkout\Service\V1\Data\CartMapper( - $this->totalsBuilder, - $this->cartBuilder, - $this->customerBuilder, - $this->customerMapper, - $this->totalsMapper, - $this->currencyMapper, - $this->itemTotalsMapper - ); - } - - public function testMap() - { - $methods = ['getId', 'getStoreId', 'getCreatedAt','getUpdatedAt', 'getConvertedAt', 'getIsActive', - 'getIsVirtual', 'getItemsCount', 'getItemsQty', 'getCheckoutMethod', 'getReservedOrderId', 'getOrigOrderId', - 'getAllItems', '__wakeUp', ]; - $quoteMock = $this->getMock('Magento\Quote\Model\Quote', $methods, [], '', false); - $itemMock = $this->getMock('Magento\Quote\Model\Quote\Item', [], [], '', false); - $quoteMock->expects($this->once())->method('getAllItems')->will($this->returnValue([$itemMock])); - $expected = [ - Cart::ID => 12, - Cart::STORE_ID => 1, - Cart::CREATED_AT => '2014-04-02 12:28:50', - Cart::UPDATED_AT => '2014-04-02 12:28:50', - Cart::CONVERTED_AT => '2014-04-02 12:28:50', - Cart::IS_ACTIVE => true, - Cart::IS_VIRTUAL => false, - Cart::ITEMS_COUNT => 10, - Cart::ITEMS_QUANTITY => 15, - Cart::CHECKOUT_METHOD => 'check mo', - Cart::RESERVED_ORDER_ID => 'order_id', - Cart::ORIG_ORDER_ID => 'orig_order_id', - ]; - $expectedMethods = [ - 'getId' => 12, - 'getStoreId' => 1, - 'getCreatedAt' => '2014-04-02 12:28:50', - 'getUpdatedAt' => '2014-04-02 12:28:50', - 'getConvertedAt' => '2014-04-02 12:28:50', - 'getIsActive' => true, - 'getIsVirtual' => false, - 'getItemsCount' => 10, - 'getItemsQty' => 15, - 'getCheckoutMethod' => 'check mo', - 'getReservedOrderId' => 'order_id', - 'getOrigOrderId' => 'orig_order_id', - ]; - foreach ($expectedMethods as $method => $value) { - $quoteMock->expects($this->once())->method($method)->will($this->returnValue($value)); - } - $this->customerMapper->expects($this->once())->method('map')->with($quoteMock) - ->will($this->returnValue(['testCustomer'])); - $this->customerBuilder->expects($this->once())->method('populateWithArray')->with(['testCustomer']); - $this->customerBuilder->expects($this->once())->method('create')->will($this->returnValue('customer')); - - $this->totalsMapper->expects($this->once())->method('map')->with($quoteMock) - ->will($this->returnValue(['testTotals'])); - $this->totalsBuilder->expects($this->once())->method('populateWithArray')->with(['testTotals']); - $this->totalsBuilder->expects($this->once())->method('create')->will($this->returnValue('totals')); - - $this->itemTotalsMapper->expects($this->once())->method('extractDto')->with($itemMock) - ->will($this->returnValue('mappedItem')); - - $this->totalsBuilder->expects($this->once())->method('setItems')->with(['mappedItem']); - - $this->currencyMapper->expects($this->once())->method('extractDto')->with($quoteMock) - ->will($this->returnValue('currency')); - - $this->cartBuilder->expects($this->once())->method('populateWithArray')->with($expected); - $this->cartBuilder->expects($this->once())->method('setCustomer')->with('customer'); - $this->cartBuilder->expects($this->once())->method('setTotals')->with('totals'); - $this->cartBuilder->expects($this->once())->method('setCurrency')->with('currency'); - $this->mapper->map($quoteMock); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/PaymentMethod/ConverterTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/PaymentMethod/ConverterTest.php deleted file mode 100644 index e20603f39db3d13af4df67614ea2e1e51a1774d2..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/PaymentMethod/ConverterTest.php +++ /dev/null @@ -1,67 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Data\PaymentMethod; - -use Magento\Checkout\Service\V1\Data\PaymentMethod; - -class ConverterTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var Converter - */ - protected $converter; - - /** - * @var \Magento\TestFramework\Helper\ObjectManager - */ - protected $objectManager; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $paymentMethodBuilderMock; - - protected function setUp() - { - $this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - $this->paymentMethodBuilderMock = $this->getMock( - '\Magento\Checkout\Service\V1\Data\PaymentMethodBuilder', ['populateWithArray', 'create'], [], '', false - ); - - $this->converter = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\Data\PaymentMethod\Converter', - [ - 'builder' => $this->paymentMethodBuilderMock, - ] - ); - } - - public function testConvertQuotePaymentObjectToPaymentDataObject() - { - $methodMock = $this->getMock('\Magento\Payment\Model\Method\AbstractMethod', [], [], '', false); - $methodMock->expects($this->once())->method('getCode')->will($this->returnValue('paymentCode')); - $methodMock->expects($this->once())->method('getTitle')->will($this->returnValue('paymentTitle')); - - $data = [ - PaymentMethod::TITLE => 'paymentTitle', - PaymentMethod::CODE => 'paymentCode', - ]; - - $this->paymentMethodBuilderMock->expects($this->once()) - ->method('populateWithArray') - ->with($data) - ->will($this->returnSelf()); - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\PaymentMethod', [], [], '', false); - - $this->paymentMethodBuilderMock->expects($this->once()) - ->method('create') - ->will($this->returnValue($paymentMethodMock)); - - $this->assertEquals($paymentMethodMock, $this->converter->toDataObject($methodMock)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/ReaderServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/ReaderServiceTest.php deleted file mode 100644 index 1aabf10474cc164f5658110864e92b8d52dac591..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/ReaderServiceTest.php +++ /dev/null @@ -1,62 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\Item; - -use Magento\Checkout\Service\V1\Data\Cart\Item as Item; - -class ReaderServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var ReadService - */ - protected $service; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $itemMapperMock; - - protected function setUp() - { - $this->quoteRepositoryMock = $this->getMock('Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->itemMapperMock = - $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\ItemMapper', ['extractDto'], [], '', false); - $this->service = new ReadService($this->quoteRepositoryMock, $this->itemMapperMock); - } - - public function testGetList() - { - $quoteMock = $this->getMock('Magento\Quote\Model\Quote', [], [], '', false); - $this->quoteRepositoryMock->expects($this->once())->method('getActive') - ->with(33) - ->will($this->returnValue($quoteMock)); - $itemMock = $this->getMock('\Magento\Quote\Model\Quote\Item', - ['getSku', 'getName', 'getPrice', 'getQty', 'getProductType', '__wakeup'], [], '', false); - $quoteMock->expects($this->any())->method('getAllItems')->will($this->returnValue([$itemMock])); - $testData = [ - Item::ITEM_ID => 7, - Item::SKU => 'prd_SKU', - Item::NAME => 'prd_NAME', - Item::PRICE => 100.15, - Item::QTY => 16, - Item::PRODUCT_TYPE => 'simple', - ]; - - $this->itemMapperMock - ->expects($this->once()) - ->method('extractDto') - ->with($itemMock) - ->will($this->returnValue($testData)); - $this->assertEquals([$testData], $this->service->getList(33)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceTest.php deleted file mode 100644 index 005e01f97370e8ff01372cb36a323cb93d17df69..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/ReadServiceTest.php +++ /dev/null @@ -1,138 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\PaymentMethod; - -class ReadServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var ReadService - */ - protected $service; - - /** - * @var \Magento\TestFramework\Helper\ObjectManager - */ - protected $objectManager; - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $paymentMethodConverterMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteMethodConverterMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $methodListMock; - - protected function setUp() - { - $this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->quoteMethodConverterMock = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod\Converter', [], [], '', false - ); - $this->paymentMethodConverterMock = $this->getMock( - '\Magento\Checkout\Service\V1\Data\PaymentMethod\Converter', [], [], '', false - ); - $this->methodListMock = $this->getMock('\Magento\Payment\Model\MethodList', [], [], '', false); - - $this->service = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\PaymentMethod\ReadService', - [ - 'quoteRepository' => $this->quoteRepositoryMock, - 'quoteMethodConverter' => $this->quoteMethodConverterMock, - 'paymentMethodConverter' => $this->paymentMethodConverterMock, - 'methodList' => $this->methodListMock, - ] - ); - } - - public function testGetPaymentIfPaymentMethodNotSet() - { - $cartId = 11; - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $paymentMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', [], [], '', false); - $quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock)); - $paymentMock->expects($this->once())->method('getId')->will($this->returnValue(null)); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($quoteMock)); - - $this->assertNull($this->service->getPayment($cartId)); - } - - public function testGetPaymentSuccess() - { - $cartId = 11; - - $paymentMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', [], [], '', false); - $paymentMock->expects($this->once())->method('getId')->will($this->returnValue(1)); - - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock)); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($quoteMock)); - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod', [], [], '', false); - - $this->quoteMethodConverterMock->expects($this->once()) - ->method('toDataObject') - ->with($paymentMock) - ->will($this->returnValue($paymentMethodMock)); - - $this->assertEquals($paymentMethodMock, $this->service->getPayment($cartId)); - } - - public function testGetList() - { - $cartId = 10; - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($quoteMock)); - - $methodList = [ - $this->getMock('\Magento\Payment\Model\MethodInterface'), - $this->getMock('\Magento\Payment\Model\MethodInterface'), - ]; - - $this->methodListMock->expects($this->once()) - ->method('getAvailableMethods') - ->with($quoteMock) - ->will($this->returnValue($methodList)); - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\PaymentMethod', [], [], '', false); - - $this->paymentMethodConverterMock->expects($this->atLeastOnce()) - ->method('toDataObject') - ->will($this->returnValue($paymentMethodMock)); - - $expectedResult = [ - $this->getMock('\Magento\Checkout\Service\V1\Data\PaymentMethod', [], [], '', false), - $this->getMock('\Magento\Checkout\Service\V1\Data\PaymentMethod', [], [], '', false), - ]; - - $this->assertEquals($expectedResult, $this->service->getList($cartId)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceTest.php deleted file mode 100644 index 37ef4ab56a8922d11681ab84fc5338f0dc8252e0..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/PaymentMethod/WriteServiceTest.php +++ /dev/null @@ -1,305 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\PaymentMethod; - -class WriteServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var WriteService - */ - protected $service; - - /** - * @var \Magento\TestFramework\Helper\ObjectManager - */ - protected $objectManager; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $paymentMethodBuilderMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $methodListMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $validatorMock; - - protected function setUp() - { - $this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->paymentMethodBuilderMock = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod\Builder', [], [], '', false - ); - $this->methodListMock = $this->getMock('\Magento\Payment\Model\MethodList', [], [], '', false); - $this->validatorMock = $this->getMock('\Magento\Payment\Model\Checks\ZeroTotal', [], [], '', false); - - $this->service = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\PaymentMethod\WriteService', - [ - 'quoteRepository' => $this->quoteRepositoryMock, - 'paymentMethodBuilder' => $this->paymentMethodBuilderMock, - 'methodList' => $this->methodListMock, - 'zeroTotalValidator' => $this->validatorMock, - ] - ); - } - - /** - * @expectedException \Exception - * @expectedExceptionMessage Billing address is not set - */ - public function testSetVirtualQuotePaymentThrowsExceptionIfBillingAdressNotSet() - { - $cartId = 11; - - $paymentsCollectionMock = $this->getMock( - '\Magento\Eav\Model\Entity\Collection\AbstractCollection', [], [], '', false - ); - - $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); - $quoteMock->expects($this->any()) - ->method('getPaymentsCollection') - ->will($this->returnValue($paymentsCollectionMock)); - $quoteMock->expects($this->any())->method('isVirtual')->will($this->returnValue(true)); - - $billingAddressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', [], [], '', false); - $quoteMock->expects($this->any())->method('getBillingAddress')->will($this->returnValue($billingAddressMock)); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($quoteMock)); - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod', [], [], '', false); - - $this->service->set($paymentMethodMock, $cartId); - } - - public function testSetVirtualQuotePaymentSuccess() - { - $cartId = 11; - $paymentId = 13; - $paymentsCollectionMock = $this->getMock( - '\Magento\Eav\Model\Entity\Collection\AbstractCollection', [], [], '', false - ); - - $quoteMock = $this->getMock( - '\Magento\Quote\Model\Quote', - [ - 'setTotalsCollectedFlag', '__wakeup', 'getPaymentsCollection', 'getPayment', - 'getItemsCollection', 'isVirtual', 'getBillingAddress', 'collectTotals', 'save' - ], [], '', false - ); - $quoteMock->expects($this->any()) - ->method('getPaymentsCollection') - ->will($this->returnValue($paymentsCollectionMock)); - $quoteMock->expects($this->any())->method('isVirtual')->will($this->returnValue(true)); - - $billingAddressMock = - $this->getMock('\Magento\Quote\Model\Quote\Address', ['getCountryId', '__wakeup'], [], '', false); - $billingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(1)); - $quoteMock->expects($this->any())->method('getBillingAddress')->will($this->returnValue($billingAddressMock)); - - $quoteMock->expects($this->once())->method('setTotalsCollectedFlag')->will($this->returnSelf()); - $quoteMock->expects($this->once())->method('collectTotals')->will($this->returnSelf()); - - $paymentMock = $this->getMock('Magento\Quote\Model\Quote\Payment', [], [], '', false); - $paymentMock->expects($this->once())->method('getId')->will($this->returnValue($paymentId)); - - $methodMock = $this->getMockForAbstractClass( - '\Magento\Payment\Model\Method\AbstractMethod', [], '', false, false - ); - - $paymentMock->expects($this->once())->method('getMethodInstance')->will($this->returnValue($methodMock)); - - $quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock)); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($quoteMock)); - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod', [], [], '', false); - $this->validatorMock->expects($this->once())->method('isApplicable') - ->with($methodMock, $quoteMock)->will($this->returnValue(true)); - - $this->paymentMethodBuilderMock->expects($this->once()) - ->method('build') - ->with($paymentMethodMock, $quoteMock) - ->will($this->returnValue($paymentMock)); - - $this->assertEquals($paymentId, $this->service->set($paymentMethodMock, $cartId)); - } - - /** - * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException - * @expectedExceptionMessage The requested Payment Method is not available. - */ - public function testSetVirtualQuotePaymentFail() - { - $cartId = 11; - - $paymentsCollectionMock = $this->getMock( - '\Magento\Eav\Model\Entity\Collection\AbstractCollection', [], [], '', false - ); - - $quoteMock = $this->getMock( - '\Magento\Quote\Model\Quote', - [ - 'setTotalsCollectedFlag', '__wakeup', 'getPaymentsCollection', 'getPayment', - 'getItemsCollection', 'isVirtual', 'getBillingAddress', 'collectTotals' - ], [], '', false - ); - $quoteMock->expects($this->any()) - ->method('getPaymentsCollection') - ->will($this->returnValue($paymentsCollectionMock)); - $quoteMock->expects($this->any())->method('isVirtual')->will($this->returnValue(true)); - - $billingAddressMock = - $this->getMock('\Magento\Quote\Model\Quote\Address', ['getCountryId', '__wakeup'], [], '', false); - $billingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(1)); - $quoteMock->expects($this->any())->method('getBillingAddress')->will($this->returnValue($billingAddressMock)); - - $quoteMock->expects($this->never())->method('setTotalsCollectedFlag'); - $quoteMock->expects($this->never())->method('collectTotals'); - - $paymentMock = $this->getMock('Magento\Quote\Model\Quote\Payment', [], [], '', false); - $paymentMock->expects($this->never())->method('getId'); - - $methodMock = $this->getMockForAbstractClass( - '\Magento\Payment\Model\Method\AbstractMethod', [], '', false, false - ); - - $paymentMock->expects($this->once())->method('getMethodInstance')->will($this->returnValue($methodMock)); - - $quoteMock->expects($this->never())->method('getPayment'); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($quoteMock)); - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod', [], [], '', false); - $this->validatorMock->expects($this->once())->method('isApplicable') - ->with($methodMock, $quoteMock)->will($this->returnValue(false)); - - $this->paymentMethodBuilderMock->expects($this->once()) - ->method('build') - ->with($paymentMethodMock, $quoteMock) - ->will($this->returnValue($paymentMock)); - - $this->service->set($paymentMethodMock, $cartId); - } - - /** - * @expectedException \Exception - * @expectedExceptionMessage Shipping address is not set - */ - public function testSetNotVirtualQuotePaymentThrowsExceptionIfShippingAddressNotSet() - { - $cartId = 11; - $quoteMock = $this->getMock( - '\Magento\Quote\Model\Quote', - ['__wakeup', 'getPaymentsCollection', 'isVirtual', 'getShippingAddress'], [], '', false - ); - - $paymentsCollectionMock = $this->getMock( - '\Magento\Eav\Model\Entity\Collection\AbstractCollection', [], [], '', false - ); - - $quoteMock->expects($this->any()) - ->method('getPaymentsCollection') - ->will($this->returnValue($paymentsCollectionMock)); - $quoteMock->expects($this->any())->method('isVirtual')->will($this->returnValue(false)); - $quoteMock->expects($this->any()) - ->method('getShippingAddress') - ->will($this->returnValue($this->getMock('\Magento\Quote\Model\Quote\Address', [], [], '', false))); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($quoteMock)); - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod', [], [], '', false); - $paymentMock = $this->getMock('Magento\Quote\Model\Quote\Payment', [], [], '', false); - - $this->paymentMethodBuilderMock->expects($this->once()) - ->method('build') - ->with($paymentMethodMock, $quoteMock) - ->will($this->returnValue($paymentMock)); - - $this->service->set($paymentMethodMock, $cartId); - } - - public function testSetNotVirtualQuotePaymentSuccess() - { - $cartId = 11; - $paymentId = 13; - - $paymentsCollectionMock = $this->getMock( - '\Magento\Eav\Model\Entity\Collection\AbstractCollection', [], [], '', false - ); - - $quoteMock = $this->getMock( - '\Magento\Quote\Model\Quote', - [ - 'setTotalsCollectedFlag', '__wakeup', 'getPaymentsCollection', 'getPayment', - 'getItemsCollection', 'isVirtual', 'getShippingAddress', 'collectTotals', 'save' - ], [], '', false - ); - $quoteMock->expects($this->any()) - ->method('getPaymentsCollection') - ->will($this->returnValue($paymentsCollectionMock)); - $quoteMock->expects($this->any())->method('isVirtual')->will($this->returnValue(false)); - - $shippingAddressMock = - $this->getMock('\Magento\Quote\Model\Quote\Address', ['getCountryId', '__wakeup'], [], '', false); - $shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(1)); - $quoteMock->expects($this->any())->method('getShippingAddress')->will($this->returnValue($shippingAddressMock)); - - $quoteMock->expects($this->once())->method('setTotalsCollectedFlag')->will($this->returnSelf()); - $quoteMock->expects($this->once())->method('collectTotals')->will($this->returnSelf()); - - $paymentMock = $this->getMock('Magento\Quote\Model\Quote\Payment', [], [], '', false); - $paymentMock->expects($this->once())->method('getId')->will($this->returnValue($paymentId)); - - $methodMock = $this->getMockForAbstractClass( - '\Magento\Payment\Model\Method\AbstractMethod', [], '', false, false - ); - $paymentMock->expects($this->once())->method('getMethodInstance')->will($this->returnValue($methodMock)); - $this->validatorMock->expects($this->once())->method('isApplicable') - ->with($methodMock, $quoteMock)->will($this->returnValue(true)); - - $quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock)); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($quoteMock)); - - $paymentMethodMock = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\PaymentMethod', [], [], '', false); - - $this->paymentMethodBuilderMock->expects($this->once()) - ->method('build') - ->with($paymentMethodMock, $quoteMock) - ->will($this->returnValue($paymentMock)); - - $this->assertEquals($paymentId, $this->service->set($paymentMethodMock, $cartId)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceTest.php deleted file mode 100644 index 196f0db3ceb025f82061bbdaaa17ceea3a2b34d9..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/ReadServiceTest.php +++ /dev/null @@ -1,268 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\Checkout\Service\V1\ShippingMethod; - -use Magento\Checkout\Service\V1\Data\Cart\ShippingMethod; -use Magento\TestFramework\Helper\ObjectManager; - -class ReadServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var ReadService - */ - protected $service; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $shippingAddressMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $methodBuilderMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $converterMock; - - /** - * @var \Magento\TestFramework\Helper\ObjectManager - */ - protected $objectManager; - - protected function setUp() - { - $this->objectManager = new ObjectManager($this); - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->methodBuilderMock = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\ShippingMethodBuilder', - ['populateWithArray', 'create'], - [], - '', - false - ); - $this->storeMock = $this->getMock('\Magento\Store\Model\Store', [], [], '', false); - $this->quoteMock = $this->getMock( - '\Magento\Quote\Model\Quote', - [ - 'getShippingAddress', - 'isVirtual', - 'getItemsCount', - 'getQuoteCurrencyCode', - '__wakeup', - ], - [], - '', - false - ); - $this->shippingAddressMock = $this->getMock( - '\Magento\Quote\Model\Quote\Address', - [ - 'getCountryId', - 'getShippingMethod', - 'getShippingDescription', - 'getShippingAmount', - 'getBaseShippingAmount', - 'getGroupedAllShippingRates', - 'collectShippingRates', - '__wakeup', - ], - [], - '', - false - ); - $this->converterMock = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\ShippingMethodConverter', - [], - [], - '', - false - ); - - $this->service = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\ShippingMethod\ReadService', - [ - 'quoteRepository' => $this->quoteRepositoryMock, - 'methodBuilder' => $this->methodBuilderMock, - 'converter' => $this->converterMock, - ] - ); - } - - /** - * @expectedException \Magento\Framework\Exception\StateException - * @expectedExceptionMessage Shipping address not set. - */ - public function testGetMethodWhenShippingAddressIsNotSet() - { - $cartId = 666; - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(null)); - - $this->assertNull($this->service->getMethod($cartId)); - } - - /** - * @expectedException \Magento\Framework\Exception\InputException - * @expectedExceptionMessage Line "WrongShippingMethod" doesn't contain delimiter _ - */ - public function testGetMethodWhenShippingMethodIsInvalid() - { - $cartId = 884; - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(34)); - $this->shippingAddressMock->expects($this->exactly(2)) - ->method('getShippingMethod') - ->will($this->returnValue('WrongShippingMethod')); - - $this->assertNull($this->service->getMethod($cartId)); - } - - public function testGetMethod() - { - $cartId = 666; - $countryId = 1; - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->any()) - ->method('getCountryId')->will($this->returnValue($countryId)); - $this->shippingAddressMock->expects($this->any()) - ->method('getShippingMethod')->will($this->returnValue('one_two')); - $this->shippingAddressMock->expects($this->once()) - ->method('getShippingDescription')->will($this->returnValue('carrier - method')); - $this->shippingAddressMock->expects($this->once()) - ->method('getShippingAmount')->will($this->returnValue(123.56)); - $this->shippingAddressMock->expects($this->once()) - ->method('getBaseShippingAmount')->will($this->returnValue(100.06)); - $output = [ - ShippingMethod::CARRIER_CODE => 'one', - ShippingMethod::METHOD_CODE => 'two', - ShippingMethod::CARRIER_TITLE => 'carrier', - ShippingMethod::METHOD_TITLE => 'method', - ShippingMethod::SHIPPING_AMOUNT => 123.56, - ShippingMethod::BASE_SHIPPING_AMOUNT => 100.06, - ShippingMethod::AVAILABLE => true, - ]; - $this->methodBuilderMock->expects($this->once()) - ->method('populateWithArray')->with($output)->will($this->returnValue($this->methodBuilderMock)); - $this->methodBuilderMock->expects($this->once())->method('create'); - - $this->service->getMethod($cartId); - } - - public function testGetMethodIfMethodIsNotSet() - { - $cartId = 666; - $countryId = 1; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->any()) - ->method('getCountryId')->will($this->returnValue($countryId)); - $this->shippingAddressMock->expects($this->any()) - ->method('getShippingMethod')->will($this->returnValue(null)); - - $this->assertNull($this->service->getMethod($cartId)); - } - - public function testGetListForVirtualCart() - { - $cartId = 834; - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once()) - ->method('isVirtual')->will($this->returnValue(true)); - - $this->assertEquals([], $this->service->getList($cartId)); - } - - public function testGetListForEmptyCart() - { - $cartId = 834; - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once()) - ->method('isVirtual')->will($this->returnValue(false)); - $this->quoteMock->expects($this->once()) - ->method('getItemsCount')->will($this->returnValue(0)); - - $this->assertEquals([], $this->service->getList($cartId)); - } - - /** - * @expectedException \Magento\Framework\Exception\StateException - * @expectedExceptionMessage Shipping address not set. - */ - public function testGetListWhenShippingAddressIsNotSet() - { - $cartId = 834; - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once()) - ->method('isVirtual')->will($this->returnValue(false)); - $this->quoteMock->expects($this->once()) - ->method('getItemsCount')->will($this->returnValue(3)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(null)); - - $this->service->getList($cartId); - } - - public function testGetList() - { - $cartId = 834; - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once()) - ->method('isVirtual')->will($this->returnValue(false)); - $this->quoteMock->expects($this->once()) - ->method('getItemsCount')->will($this->returnValue(3)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(345)); - $this->shippingAddressMock->expects($this->once())->method('collectShippingRates'); - $shippingRateMock = $this->getMock('\Magento\Quote\Model\Quote\Address\Rate', [], [], '', false); - $this->shippingAddressMock->expects($this->once()) - ->method('getGroupedAllShippingRates') - ->will($this->returnValue([[$shippingRateMock]])); - - $currencyCode = 'EUR'; - $this->quoteMock->expects($this->once()) - ->method('getQuoteCurrencyCode') - ->will($this->returnValue($currencyCode)); - - $this->converterMock->expects($this->once()) - ->method('modelToDataObject') - ->with($shippingRateMock, $currencyCode) - ->will($this->returnValue('RateValue')); - $this->assertEquals(['RateValue'], $this->service->getList($cartId)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/CheckoutAgreements/Model/CheckoutAgreementsRepositoryTest.php b/dev/tests/unit/testsuite/Magento/CheckoutAgreements/Model/CheckoutAgreementsRepositoryTest.php new file mode 100644 index 0000000000000000000000000000000000000000..24541f489f6e398f2e262d2de67de6df2c66f14b --- /dev/null +++ b/dev/tests/unit/testsuite/Magento/CheckoutAgreements/Model/CheckoutAgreementsRepositoryTest.php @@ -0,0 +1,98 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\CheckoutAgreements\Model; + +use Magento\Store\Model\ScopeInterface; +use Magento\TestFramework\Helper\ObjectManager; + +class CheckoutAgreementsRepositoryTest extends \PHPUnit_Framework_TestCase +{ + /** + * @var CheckoutAgreementsRepository + */ + private $model; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + private $factoryMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + private $storeManagerMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + private $scopeConfigMock; + + /** + * @var ObjectManager + */ + private $objectManager; + + protected function setUp() + { + $this->objectManager = new ObjectManager($this); + + $this->factoryMock = $this->getMock( + 'Magento\CheckoutAgreements\Model\Resource\Agreement\CollectionFactory', + ['create'], + [], + '', + false + ); + $this->storeManagerMock = $this->getMock('Magento\Store\Model\StoreManagerInterface'); + $this->scopeConfigMock = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface'); + $this->model = new CheckoutAgreementsRepository( + $this->factoryMock, + $this->storeManagerMock, + $this->scopeConfigMock + ); + } + + public function testGetListReturnsEmptyListIfCheckoutAgreementsAreDisabledOnFrontend() + { + $this->scopeConfigMock->expects($this->once()) + ->method('isSetFlag') + ->with('checkout/options/enable_agreements', ScopeInterface::SCOPE_STORE, null) + ->will($this->returnValue(false)); + $this->factoryMock->expects($this->never())->method('create'); + $this->assertEmpty($this->model->getList()); + } + + public function testGetListReturnsTheListOfActiveCheckoutAgreements() + { + $this->scopeConfigMock->expects($this->once()) + ->method('isSetFlag') + ->with('checkout/options/enable_agreements', ScopeInterface::SCOPE_STORE, null) + ->will($this->returnValue(true)); + + $agreementDataObject = $this->getMock( + 'Magento\CheckoutAgreements\Model\Agreement', + [], + [], + '', + false + ); + + $storeId = 1; + $storeMock = $this->getMock('Magento\Store\Model\Store', [], [], '', false); + $storeMock->expects($this->any())->method('getId')->will($this->returnValue($storeId)); + $this->storeManagerMock->expects($this->any())->method('getStore')->will($this->returnValue($storeMock)); + + $collectionMock = $this->objectManager->getCollectionMock( + 'Magento\CheckoutAgreements\Model\Resource\Agreement\Collection', + [$agreementDataObject] + ); + $this->factoryMock->expects($this->once())->method('create')->will($this->returnValue($collectionMock)); + $collectionMock->expects($this->once())->method('addStoreFilter')->with($storeId); + $collectionMock->expects($this->once())->method('addFieldToFilter')->with('is_active', 1); + + $this->assertEquals([$agreementDataObject], $this->model->getList()); + } +} diff --git a/dev/tests/unit/testsuite/Magento/CheckoutAgreements/Service/V1/Agreement/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/CheckoutAgreements/Service/V1/Agreement/ReadServiceTest.php deleted file mode 100644 index 14d2432ef89404909c151b7d7a84f9a0c02e6e23..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/CheckoutAgreements/Service/V1/Agreement/ReadServiceTest.php +++ /dev/null @@ -1,159 +0,0 @@ -<?php -/** - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ -namespace Magento\CheckoutAgreements\Service\V1\Agreement; - -use Magento\Store\Model\ScopeInterface; -use Magento\TestFramework\Helper\ObjectManager; - -class ReadServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var ReadService - */ - private $service; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $factoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $agreementBuilderMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $storeManagerMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - private $scopeConfigMock; - - /** - * @var ObjectManager - */ - private $objectManager; - - protected function setUp() - { - $this->objectManager = new ObjectManager($this); - - $this->factoryMock = $this->getMock( - 'Magento\CheckoutAgreements\Model\Resource\Agreement\CollectionFactory', - ['create'], - [], - '', - false - ); - $this->agreementBuilderMock = $this->getMock( - 'Magento\CheckoutAgreements\Service\V1\Data\AgreementBuilder', - [], - [], - '', - false - ); - $this->storeManagerMock = $this->getMock('Magento\Store\Model\StoreManagerInterface'); - $this->scopeConfigMock = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface'); - $this->service = new ReadService( - $this->factoryMock, - $this->agreementBuilderMock, - $this->storeManagerMock, - $this->scopeConfigMock - ); - } - - public function testGetListReturnsEmptyListIfCheckoutAgreementsAreDisabledOnFrontend() - { - $this->scopeConfigMock->expects($this->once()) - ->method('isSetFlag') - ->with('checkout/options/enable_agreements', ScopeInterface::SCOPE_STORE, null) - ->will($this->returnValue(false)); - $this->factoryMock->expects($this->never())->method('create'); - $this->assertEmpty($this->service->getList()); - } - - public function testGetListReturnsTheListOfActiveCheckoutAgreements() - { - $this->scopeConfigMock->expects($this->once()) - ->method('isSetFlag') - ->with('checkout/options/enable_agreements', ScopeInterface::SCOPE_STORE, null) - ->will($this->returnValue(true)); - - $agreementData = [ - 'id' => 1, - 'name' => 'Checkout Agreement', - 'content' => 'Agreement content: <b>HTML</b>', - 'content_height' => '100px', - 'checkbox_text' => 'Checkout Agreement Checkbox Text', - 'active' => true, - 'html' => true, - ]; - - $storeId = 1; - $storeMock = $this->getMock('Magento\Store\Model\Store', [], [], '', false); - $storeMock->expects($this->any())->method('getId')->will($this->returnValue($storeId)); - $this->storeManagerMock->expects($this->any())->method('getStore')->will($this->returnValue($storeMock)); - - $collectionMock = $this->objectManager->getCollectionMock( - 'Magento\CheckoutAgreements\Model\Resource\Agreement\Collection', - [$this->getAgreementMock($agreementData)] - ); - $this->factoryMock->expects($this->once())->method('create')->will($this->returnValue($collectionMock)); - $collectionMock->expects($this->once())->method('addStoreFilter')->with($storeId); - $collectionMock->expects($this->once())->method('addFieldToFilter')->with('is_active', 1); - - $agreementDataObject = $this->getMock( - 'Magento\CheckoutAgreements\Service\V1\Data\Agreement', - [], - [], - '', - false - ); - $this->agreementBuilderMock->expects($this->once())->method('populateWithArray')->with($agreementData); - $this->agreementBuilderMock->expects($this->once())->method('create') - ->will($this->returnValue($agreementDataObject)); - - $this->assertEquals([$agreementDataObject], $this->service->getList()); - } - - /** - * Retrieve agreement mock based on given data - * - * @param array $agreementData - * @return \PHPUnit_Framework_MockObject_MockObject - */ - protected function getAgreementMock(array $agreementData) - { - $agreementMock = $this->getMock( - 'Magento\CheckoutAgreements\Model\Agreement', - [ - 'getId', 'getName', 'getContent', 'getContentHeight', 'getCheckboxText', 'getIsActive', 'getIsHtml', - '__wakeup', '__sleep', - ], - [], - '', - false - ); - $agreementMock->expects($this->any())->method('getId') - ->will($this->returnValue($agreementData['id'])); - $agreementMock->expects($this->any())->method('getName') - ->will($this->returnValue($agreementData['name'])); - $agreementMock->expects($this->any())->method('getContent') - ->will($this->returnValue($agreementData['content'])); - $agreementMock->expects($this->any())->method('getContentHeight') - ->will($this->returnValue($agreementData['content_height'])); - $agreementMock->expects($this->any())->method('getCheckboxText') - ->will($this->returnValue($agreementData['checkbox_text'])); - $agreementMock->expects($this->any())->method('getIsActive') - ->will($this->returnValue($agreementData['active'])); - $agreementMock->expects($this->any())->method('getIsHtml') - ->will($this->returnValue($agreementData['html'])); - return $agreementMock; - } -} diff --git a/dev/tests/unit/testsuite/Magento/Cms/Controller/Adminhtml/Wysiwyg/DirectiveTest.php b/dev/tests/unit/testsuite/Magento/Cms/Controller/Adminhtml/Wysiwyg/DirectiveTest.php index 021506cdbb6349e2f36d92280f51637d0ed6359f..ffd990dfc3bfbc2b084c699cdc090269c08b5ec1 100644 --- a/dev/tests/unit/testsuite/Magento/Cms/Controller/Adminhtml/Wysiwyg/DirectiveTest.php +++ b/dev/tests/unit/testsuite/Magento/Cms/Controller/Adminhtml/Wysiwyg/DirectiveTest.php @@ -7,6 +7,7 @@ namespace Magento\Cms\Controller\Adminhtml\Wysiwyg; /** * @covers \Magento\Cms\Controller\Adminhtml\Wysiwyg\Directive + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class DirectiveTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/ConfigurableImportExport/Model/Export/RowCustomizerTest.php b/dev/tests/unit/testsuite/Magento/ConfigurableImportExport/Model/Export/RowCustomizerTest.php index fe6b17f7b64945a7735936c72a22f623821a4ebe..f0c1ec9543a98ddce7eea519f16d85ab9abb01d6 100644 --- a/dev/tests/unit/testsuite/Magento/ConfigurableImportExport/Model/Export/RowCustomizerTest.php +++ b/dev/tests/unit/testsuite/Magento/ConfigurableImportExport/Model/Export/RowCustomizerTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ConfigurableImportExport\Model\Export; class RowCustomizerTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Helper/DataTest.php b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Helper/DataTest.php index 1a66db756cb41875afc40b1a7dd87e9e90befa9c..a311d556f3db678b722e53ad62132a128cec0a77 100644 --- a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Helper/DataTest.php +++ b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Helper/DataTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ConfigurableProduct\Helper; class DataTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php index afbc22d2ab4fa4eaafafb1f2ad685774e2038ccc..3c42dda177637b1bea20b69162de4b84957d7f50 100644 --- a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php +++ b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Type/ConfigurableTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ConfigurableProduct\Model\Product\Type; /** diff --git a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Type/PluginTest.php b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Type/PluginTest.php index efdb6f3b60ea7e8b6e47cb93d99e3e91d21601b7..252e24e70f3ebca45cf8aa2385cea834615a2e89 100644 --- a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Type/PluginTest.php +++ b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Type/PluginTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ConfigurableProduct\Model\Product\Type; /** diff --git a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Validator/PluginTest.php b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Validator/PluginTest.php index e53e31a9e71bfbf6d003bb72410a13269f1e5fcf..618adb2c0ec09339a101f0640564de29766c9adf 100644 --- a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Validator/PluginTest.php +++ b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Product/Validator/PluginTest.php @@ -326,6 +326,7 @@ class PluginTest extends \PHPUnit_Framework_TestCase * @param bool $isValid * @internal param array $attributes * @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Catalog\Model\Product + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ private function createProduct($index, $id, $isValid = true) { diff --git a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProductTest.php b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProductTest.php index 45fa854c4b98a64b8609e4b33b473882bec7b21c..63fe1758344e6d932500f5f342e2146c7ec5f0a8 100644 --- a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProductTest.php +++ b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/Quote/Item/QuantityValidator/Initializer/Option/Plugin/ConfigurableProductTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ConfigurableProduct\Model\Quote\Item\QuantityValidator\Initializer\Option\Plugin; class ConfigurableProductTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/SuggestedAttributeListTest.php b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/SuggestedAttributeListTest.php index b3fced22ce5914c36ee2002b5c7591fa4da34cf9..7d41bd7f67a3918f9b8dc3135e7ccae6eec7ea61 100644 --- a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/SuggestedAttributeListTest.php +++ b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Model/SuggestedAttributeListTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\ConfigurableProduct\Model; class SuggestedAttributeListTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Pricing/Price/AttributePriceTest.php b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Pricing/Price/AttributePriceTest.php index 6211a2b8d6d4c5bc3a878831c7a440ea7271591f..5d88d7b9e3158528d6d018c023e34d48c8fae2eb 100644 --- a/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Pricing/Price/AttributePriceTest.php +++ b/dev/tests/unit/testsuite/Magento/ConfigurableProduct/Pricing/Price/AttributePriceTest.php @@ -126,6 +126,9 @@ class AttributePriceTest extends \PHPUnit_Framework_TestCase $this->assertInstanceOf('Magento\ConfigurableProduct\Pricing\Price\AttributePrice', $object); } + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function testPrepareJsonAttributes() { $options = []; diff --git a/dev/tests/unit/testsuite/Magento/Contact/Controller/Index/IndexTest.php b/dev/tests/unit/testsuite/Magento/Contact/Controller/Index/IndexTest.php index 9a65b3dc4a24a6ec0555dd69d503e8956bf35585..77f1a5a81b5d889dd8948326df68e4ade00ef482 100644 --- a/dev/tests/unit/testsuite/Magento/Contact/Controller/Index/IndexTest.php +++ b/dev/tests/unit/testsuite/Magento/Contact/Controller/Index/IndexTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Contact\Controller\Index; class IndexTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Contact/Controller/IndexTest.php b/dev/tests/unit/testsuite/Magento/Contact/Controller/IndexTest.php index 9ff953a0b0c84a81760bb145986f069b4f75fa06..26e655449859b80fca1855cd426d19c7e0a2db1e 100644 --- a/dev/tests/unit/testsuite/Magento/Contact/Controller/IndexTest.php +++ b/dev/tests/unit/testsuite/Magento/Contact/Controller/IndexTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Contact\Controller; class IndexTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Contact/Helper/DataTest.php b/dev/tests/unit/testsuite/Magento/Contact/Helper/DataTest.php index 3a4d656ce9349701e6ffeedb2199d148f0f01bb6..4fc132525ddb93cea4edb92969785eb3605688f9 100644 --- a/dev/tests/unit/testsuite/Magento/Contact/Helper/DataTest.php +++ b/dev/tests/unit/testsuite/Magento/Contact/Helper/DataTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Contact\Helper; class DataTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Core/App/Router/NoRouteHandlerTest.php b/dev/tests/unit/testsuite/Magento/Core/App/Router/NoRouteHandlerTest.php index e07bb630bb156116d2b95041e9e17ecc6acd19b5..e8abb1785539627d7bc6a824ba188bdcac9a60fb 100644 --- a/dev/tests/unit/testsuite/Magento/Core/App/Router/NoRouteHandlerTest.php +++ b/dev/tests/unit/testsuite/Magento/Core/App/Router/NoRouteHandlerTest.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\App\Router; class NoRouteHandlerTest extends \Magento\Test\BaseTestCase diff --git a/dev/tests/unit/testsuite/Magento/Core/Helper/ThemeTest.php b/dev/tests/unit/testsuite/Magento/Core/Helper/ThemeTest.php index f1e3d0e740a013b254136380f0778658f88ee7a3..49618259aed696df8ecfd7d4ed472a15ad294574 100644 --- a/dev/tests/unit/testsuite/Magento/Core/Helper/ThemeTest.php +++ b/dev/tests/unit/testsuite/Magento/Core/Helper/ThemeTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Helper; class ThemeTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Core/Model/Asset/ConfigTest.php b/dev/tests/unit/testsuite/Magento/Core/Model/Asset/ConfigTest.php index ce6b16735417918a11753b6051e71f197a8d6a01..c4d8376d265f93a8d1d95edd2d6f13d2068239fb 100644 --- a/dev/tests/unit/testsuite/Magento/Core/Model/Asset/ConfigTest.php +++ b/dev/tests/unit/testsuite/Magento/Core/Model/Asset/ConfigTest.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\Asset; class ConfigTest extends \Magento\Test\BaseTestCase diff --git a/dev/tests/unit/testsuite/Magento/Core/Model/Asset/Plugin/CleanMergedJsCssTest.php b/dev/tests/unit/testsuite/Magento/Core/Model/Asset/Plugin/CleanMergedJsCssTest.php index a017e16ad47497bcaa5581dc4b9b9ea04143eb43..38bbd0585dab14c286a7b85c543f9cc828a66ae3 100644 --- a/dev/tests/unit/testsuite/Magento/Core/Model/Asset/Plugin/CleanMergedJsCssTest.php +++ b/dev/tests/unit/testsuite/Magento/Core/Model/Asset/Plugin/CleanMergedJsCssTest.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\Asset\Plugin; use Magento\Framework\App\Filesystem\DirectoryList; diff --git a/dev/tests/unit/testsuite/Magento/Core/Model/Layout/DepersonalizePluginTest.php b/dev/tests/unit/testsuite/Magento/Core/Model/Layout/DepersonalizePluginTest.php index 67d0ba772c37d8fd184a41c21c7e4cf501f74cf9..9f9fa70be441ebce8409c996fbd80078a26ecbee 100644 --- a/dev/tests/unit/testsuite/Magento/Core/Model/Layout/DepersonalizePluginTest.php +++ b/dev/tests/unit/testsuite/Magento/Core/Model/Layout/DepersonalizePluginTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\Layout; /** diff --git a/dev/tests/unit/testsuite/Magento/Core/Model/Theme/Image/PathTest.php b/dev/tests/unit/testsuite/Magento/Core/Model/Theme/Image/PathTest.php index 73dd5f28bcb09cf5269ddb8be1827182e5a71016..0946f99a4428673dc048d988e4c9d277119018b5 100644 --- a/dev/tests/unit/testsuite/Magento/Core/Model/Theme/Image/PathTest.php +++ b/dev/tests/unit/testsuite/Magento/Core/Model/Theme/Image/PathTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test of image path model */ diff --git a/dev/tests/unit/testsuite/Magento/Core/Model/View/DesignTest.php b/dev/tests/unit/testsuite/Magento/Core/Model/View/DesignTest.php index d8e6b26db1304ee971360ad089b24b7369b10578..1d39b20dce769fcb868335b36e1d67250f85bed6 100644 --- a/dev/tests/unit/testsuite/Magento/Core/Model/View/DesignTest.php +++ b/dev/tests/unit/testsuite/Magento/Core/Model/View/DesignTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Core\Model\View; class DesignTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Account/Dashboard/InfoTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Account/Dashboard/InfoTest.php index 494a059576145e8ea0574974e2113005003081ec..1dff9e68fa72c5c0116b974ba13bdebaaeeff725 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Block/Account/Dashboard/InfoTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Account/Dashboard/InfoTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Block\Account\Dashboard; use Magento\Framework\Exception\NoSuchEntityException; diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php index c815cf90e997ef68bedbe9b5b085acba601cce6f..bba967cdbf8d8ebacb85c2b415430493e1708349 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/AccountTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Block\Adminhtml\Edit\Tab; use Magento\Customer\Api\AccountManagementInterface; diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/DobTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/DobTest.php index 8a25a5dfab295f43f1460fe7f7f1151a556ea63f..7c491edfbfc483b64455583ab66d7fb9bee88a9d 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/DobTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/DobTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Block\Widget; use Magento\Framework\Exception\NoSuchEntityException; diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/GenderTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/GenderTest.php index 5e5ac45b3f10c2a4731f009feb5960893cece448..5976f3033d9563c4aa83008744ddf1768a6cb4a5 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/GenderTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/GenderTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Block\Widget; use Magento\Customer\Api\Data\CustomerInterface; diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/NameTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/NameTest.php index cd2be564342facebf3a2ae3d40eb28736845ad48..4986a88c4ab0452cb8dbf920ceaeae6dedbb0ad6 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/NameTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/NameTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Block\Widget; use Magento\Customer\Api\Data\AttributeMetadataInterface; @@ -409,6 +412,7 @@ class NameTest extends \PHPUnit_Framework_TestCase * Helper method for testing all show*() methods. * * @param array $data Customer attribute(s) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ private function _setUpShowAttribute(array $data) { diff --git a/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/TaxvatTest.php b/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/TaxvatTest.php index 625a2af8f2a31edb6e811206de61952a5f85eb76..9ec8f85628191dab80c851b05ca82a118a500839 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/TaxvatTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Block/Widget/TaxvatTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Block\Widget; use Magento\Framework\Exception\NoSuchEntityException; diff --git a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php index 32fb9e96846ec6a16298eeb58ee6961016f9ac67..bd6a6616f385a0f6f13473a854a5cb660c2f3dcf 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Controller\Account; use Magento\Customer\Helper\Address; diff --git a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreatePostTest.php b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreatePostTest.php index cfef2f2111e7720a0875907fbf31c374a2e6eb48..326dfd3427c802ef3116a8d3bb9c205804abb746 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreatePostTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreatePostTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Controller\Account; use Magento\Customer\Api\AccountManagementInterface; @@ -117,6 +120,9 @@ class CreatePostTest extends \PHPUnit_Framework_TestCase */ protected $messageManagerMock; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ protected function setUp() { /** diff --git a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreateTest.php b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreateTest.php index 6cf60dea206b516d11f52c634d7dfd3825e92640..202d2a4319c55eb67c7d120beb7c3dfa1b4f33c4 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreateTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/CreateTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Controller\Account; class CreateTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Customer/Controller/Adminhtml/Index/ResetPasswordTest.php b/dev/tests/unit/testsuite/Magento/Customer/Controller/Adminhtml/Index/ResetPasswordTest.php index 6b4df762a7ecd4f7135d33c7d6c566324192fec3..7dd5138256e04848cf3b09f898b9c4a1b4101caa 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Controller/Adminhtml/Index/ResetPasswordTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Controller/Adminhtml/Index/ResetPasswordTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Controller\Adminhtml\Index; use Magento\Customer\Api\Data\CustomerInterface; diff --git a/dev/tests/unit/testsuite/Magento/Customer/Controller/Ajax/LoginTest.php b/dev/tests/unit/testsuite/Magento/Customer/Controller/Ajax/LoginTest.php index 46d43acd309a63d730a58b8c0be7b27985404407..fcbe8fe3c6b2f1d5cf0da15a13524b2d447d0f0f 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Controller/Ajax/LoginTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Controller/Ajax/LoginTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test customer ajax login controller */ diff --git a/dev/tests/unit/testsuite/Magento/Customer/Helper/Session/CurrentCustomerTest.php b/dev/tests/unit/testsuite/Magento/Customer/Helper/Session/CurrentCustomerTest.php index 48425e87cefc42eaeb88abd0577737f734118c43..587ab8ec24e233d80d96870ffdf5a30443b82069 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Helper/Session/CurrentCustomerTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Helper/Session/CurrentCustomerTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Customer\Helper\Session; class CurrentCustomerTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/AddressTest.php b/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/AddressTest.php index ef3eadbebd0f669cbd7698571044358fe5c16e8c..ec8a8a50763b4690bc405c8403869b560111cb87 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/AddressTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/AddressTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Model\Resource; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; diff --git a/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/GroupTest.php b/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/GroupTest.php index 018bd82a1946b219b9bb3e2924017a6d0b8d2a80..496164e7d3e30925c54ba828ba4ddfa13f555d6d 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/GroupTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Model/Resource/GroupTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Customer\Model\Resource; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; diff --git a/dev/tests/unit/testsuite/Magento/CustomerImportExport/Model/Import/CustomerCompositeTest.php b/dev/tests/unit/testsuite/Magento/CustomerImportExport/Model/Import/CustomerCompositeTest.php index 77f0be04722cabd12d0fe0e0d737294fc5510cfa..9766f8b4dfb4b8e823af840884910c510549f15e 100644 --- a/dev/tests/unit/testsuite/Magento/CustomerImportExport/Model/Import/CustomerCompositeTest.php +++ b/dev/tests/unit/testsuite/Magento/CustomerImportExport/Model/Import/CustomerCompositeTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\CustomerImportExport\Model\Import; use Magento\Framework\Filesystem\Driver\File; diff --git a/dev/tests/unit/testsuite/Magento/CustomerImportExport/Model/Import/CustomerTest.php b/dev/tests/unit/testsuite/Magento/CustomerImportExport/Model/Import/CustomerTest.php index 9a9ebcaf3c39c577af3227008e0962896289c818..8e8cd46c46f7ad1e67de38db515c7a61381b853c 100644 --- a/dev/tests/unit/testsuite/Magento/CustomerImportExport/Model/Import/CustomerTest.php +++ b/dev/tests/unit/testsuite/Magento/CustomerImportExport/Model/Import/CustomerTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test class for \Magento\CustomerImportExport\Model\Import\Customer */ diff --git a/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Varien/Router/StandardTest.php b/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Varien/Router/StandardTest.php index eb66ffaa0a512b744641e3c1e23c81ab15ac8113..2eb10c274c9b316fe2f959d2b69cd3733b941bc7 100644 --- a/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Varien/Router/StandardTest.php +++ b/dev/tests/unit/testsuite/Magento/DesignEditor/Controller/Varien/Router/StandardTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\DesignEditor\Controller\Varien\Router; class StandardTest extends \PHPUnit_Framework_TestCase @@ -72,6 +75,7 @@ class StandardTest extends \PHPUnit_Framework_TestCase * Data provider for testMatch * * @return array + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function matchDataProvider() { diff --git a/dev/tests/unit/testsuite/Magento/Directory/Model/Resource/Country/CollectionTest.php b/dev/tests/unit/testsuite/Magento/Directory/Model/Resource/Country/CollectionTest.php index 5fce71af34260d55fac021ba92acadae7223d565..6ed2d9637585b8ac5f6066de6e7d5a8e8b9311c9 100644 --- a/dev/tests/unit/testsuite/Magento/Directory/Model/Resource/Country/CollectionTest.php +++ b/dev/tests/unit/testsuite/Magento/Directory/Model/Resource/Country/CollectionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Directory\Model\Resource\Country; class CollectionTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/AbstractDataTest.php b/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/AbstractDataTest.php index dcd0396c8c4075bdac0395c7be4d08b00e4778b5..2be45254f3253432c3be106afce8cc3318b54730 100644 --- a/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/AbstractDataTest.php +++ b/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/AbstractDataTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model\Attribute\Data; class AbstractDataTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/FileTest.php b/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/FileTest.php index cfd756727b44aeaaadfcf9b83ef37dd96d4327e8..861eaad796a58e9fe1fd438d43742dba0eff5ea2 100644 --- a/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/FileTest.php +++ b/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/FileTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model\Attribute\Data; class FileTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/ImageTest.php b/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/ImageTest.php index 062f984267f962f7b186ce8c9a15dc43b2b54703..cee50b4230c7aa6d1e2d60de11b2193a3f212f43 100644 --- a/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/ImageTest.php +++ b/dev/tests/unit/testsuite/Magento/Eav/Model/Attribute/Data/ImageTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model\Attribute\Data; class ImageTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Eav/Model/AttributeManagementTest.php b/dev/tests/unit/testsuite/Magento/Eav/Model/AttributeManagementTest.php index fed7d5d977bc3e855a2d4e087f02815d74f203f8..62a1032d5bc738117c0e428bf64b004f9f65cc05 100644 --- a/dev/tests/unit/testsuite/Magento/Eav/Model/AttributeManagementTest.php +++ b/dev/tests/unit/testsuite/Magento/Eav/Model/AttributeManagementTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model; use Magento\Framework\Exception\NoSuchEntityException; diff --git a/dev/tests/unit/testsuite/Magento/Eav/Model/Entity/Attribute/Source/BooleanTest.php b/dev/tests/unit/testsuite/Magento/Eav/Model/Entity/Attribute/Source/BooleanTest.php index f35715418935e9ab835d30b4fab40ad8ed479739..a9a07a925c3708a8b61a1c0e64bc35020d989e3e 100644 --- a/dev/tests/unit/testsuite/Magento/Eav/Model/Entity/Attribute/Source/BooleanTest.php +++ b/dev/tests/unit/testsuite/Magento/Eav/Model/Entity/Attribute/Source/BooleanTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model\Entity\Attribute\Source; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Eav/Model/Resource/Attribute/CollectionTest.php b/dev/tests/unit/testsuite/Magento/Eav/Model/Resource/Attribute/CollectionTest.php index 8b4d1557541a9f1b8db1b90431573dd1488fe6d0..dcbb61434b3e9db4636cad53128e555319ebac04 100644 --- a/dev/tests/unit/testsuite/Magento/Eav/Model/Resource/Attribute/CollectionTest.php +++ b/dev/tests/unit/testsuite/Magento/Eav/Model/Resource/Attribute/CollectionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model\Resource\Attribute; class CollectionTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Eav/Model/Resource/Entity/AttributeTest.php b/dev/tests/unit/testsuite/Magento/Eav/Model/Resource/Entity/AttributeTest.php index bb9e4f7e1f4096a567615019ea2a1b7e867b58d1..1b18f8abfaffcf87efa4e7ca17172272782f69d8 100644 --- a/dev/tests/unit/testsuite/Magento/Eav/Model/Resource/Entity/AttributeTest.php +++ b/dev/tests/unit/testsuite/Magento/Eav/Model/Resource/Entity/AttributeTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Eav\Model\Resource\Entity; class AttributeTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Eav/Plugin/Model/Resource/Entity/AttributeTest.php b/dev/tests/unit/testsuite/Magento/Eav/Plugin/Model/Resource/Entity/AttributeTest.php index c33f650d7870b2958d8ba96bbe3893d490c87d53..595d38f50566191e9dae58822e12d29dfef27445 100644 --- a/dev/tests/unit/testsuite/Magento/Eav/Plugin/Model/Resource/Entity/AttributeTest.php +++ b/dev/tests/unit/testsuite/Magento/Eav/Plugin/Model/Resource/Entity/AttributeTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Eav\Plugin\Model\Resource\Entity; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Email/Block/Adminhtml/Template/PreviewTest.php b/dev/tests/unit/testsuite/Magento/Email/Block/Adminhtml/Template/PreviewTest.php index 47cfc50804c01194f1dc8a703831a78ee0c711f1..fe240f2422bde4758f769f8d73f56257fff19446 100644 --- a/dev/tests/unit/testsuite/Magento/Email/Block/Adminhtml/Template/PreviewTest.php +++ b/dev/tests/unit/testsuite/Magento/Email/Block/Adminhtml/Template/PreviewTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Email\Block\Adminhtml\Template; class PreviewTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Action/ActionTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Action/ActionTest.php index fe97c3493894a6a36ad5344231f0d932c9bad783..ff35c7bc3f63f1db13d0dd109e406caa6cd08824 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/App/Action/ActionTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/App/Action/ActionTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\App\Action; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/AreaListTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/AreaListTest.php index 4e5fbf432dcdd1bb26af8d69229ccbcd72be9818..7ff04a056c152b287132740763511918b7017a1a 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/App/AreaListTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/App/AreaListTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\App; class AreaListTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/BootstrapTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/BootstrapTest.php index 8b6623f6a15e5d24553fb4b96b4fc809cc814a28..e75b7b92ca79545033c66d3ece84f9eeb97cd4b2 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/App/BootstrapTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/App/BootstrapTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\App; use Magento\Framework\App\Filesystem\DirectoryList; diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/ObjectManager/ConfigLoaderTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/ObjectManager/ConfigLoaderTest.php index 7df5ce2fd7fc620d78114555d99ace847470a125..8b0716f74fefc290a6fce2957651c5a76d7a245f 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/App/ObjectManager/ConfigLoaderTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/App/ObjectManager/ConfigLoaderTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\App\ObjectManager; class ConfigLoaderTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Request/HttpTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Request/HttpTest.php index d8c55f972051af092a12da2fabbe918853bb7fc4..06eb42dde552fcc622baab9ef2675604e46cdccd 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/App/Request/HttpTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/App/Request/HttpTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\App\Request; use Magento\Framework\App\Request\Http as Request; diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/ResourceTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/ResourceTest.php index 3c3b5ee00004a7b49b31e1b1dd573f5b5a1aebdb..a46c8e31ab9fd275a3b3c9f83de46c5f4c72c028 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/App/ResourceTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/App/ResourceTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\App; class ResourceTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/StaticResourceTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/StaticResourceTest.php index b00c2f73bbd42acd76fd4a633d45296f520bca15..96f474e92fa55bd016c6ab1866d7ca1d9f10df65 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/App/StaticResourceTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/App/StaticResourceTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\App; class StaticResourceTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassLoaderWrapperTest.php b/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassLoaderWrapperTest.php index 50bd31912845fb71434905f96322cb383c9c4207..bac8e50c417f27cff857ad1cbb694a4c0d0f79ee 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassLoaderWrapperTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Autoload/ClassLoaderWrapperTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Autoload; use Composer\Autoload\ClassLoader; diff --git a/dev/tests/unit/testsuite/Magento/Framework/Cache/CoreTest.php b/dev/tests/unit/testsuite/Magento/Framework/Cache/CoreTest.php index c0aed68861414402364d001cae1ae0e8d6cd79a5..ebf8885193066e14252f630f7150964c7ea23240 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Cache/CoreTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Cache/CoreTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * \Magento\Framework\Cache\Core test case */ diff --git a/dev/tests/unit/testsuite/Magento/Framework/Code/Reader/_files/ClassesForArgumentsReader.php b/dev/tests/unit/testsuite/Magento/Framework/Code/Reader/_files/ClassesForArgumentsReader.php index 58c4d4761d89b98ba8b42f3b9b4ffec34d0c9a33..9987087c3d3ee84189eccab7a076f3ec2dc51972 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Code/Reader/_files/ClassesForArgumentsReader.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Code/Reader/_files/ClassesForArgumentsReader.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + class ClassWithAllArgumentTypes { const DEFAULT_VALUE = 'Const Value'; diff --git a/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/ConstructorArgumentTypesTest.php b/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/ConstructorArgumentTypesTest.php index 0de3d403d5885e1c0bc2fca674fece3b5b8b069e..090f0e015985c42b63fab89c8632103016e18601 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/ConstructorArgumentTypesTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/ConstructorArgumentTypesTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Code\Validator; class ConstructorArgumentTypesTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForArgumentSequence.php b/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForArgumentSequence.php index 4374a707577e8bc40a0dfb6b934ad2a72b9ae252..2351fea354730611502c147b1e455d956d6ef622 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForArgumentSequence.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForArgumentSequence.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace ArgumentSequence; class ContextObject implements \Magento\Framework\ObjectManager\ContextInterface diff --git a/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForConstructorIntegrity.php b/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForConstructorIntegrity.php index 0a4e6d30be129e70c0f1973a8d37d7bf4d006da6..a2a0dca965eefa392e9623a658c3667b0696389b 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForConstructorIntegrity.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForConstructorIntegrity.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + class ClassA { } diff --git a/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForContextAggregation.php b/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForContextAggregation.php index 40f13a0ae358a99148840327f5d60466df13c336..93cb41d540a7142106392eee6400f587f76769f7 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForContextAggregation.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForContextAggregation.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + class ClassFirst { } diff --git a/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForTypeDuplication.php b/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForTypeDuplication.php index e6d060cf06419cd9d28e2150e133e3d1a7414df9..ff245498d073626dc411c088b1de05f3a3db82f9 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForTypeDuplication.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Code/Validator/_files/ClassesForTypeDuplication.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace TypeDuplication; interface ArgumentInterface diff --git a/dev/tests/unit/testsuite/Magento/Framework/Config/Composer/PackageTest.php b/dev/tests/unit/testsuite/Magento/Framework/Config/Composer/PackageTest.php index d03df69dee1d9ec97b85fd9fbc23d58a35e9dab4..f932a3ea151fcfb1635b950782577ac45ad1a69f 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Config/Composer/PackageTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Config/Composer/PackageTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Config\Composer; class PackageTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Config/DataTest.php b/dev/tests/unit/testsuite/Magento/Framework/Config/DataTest.php index 90be29ca4621e472238cb5f51f03d434aca937f8..ef432cbfd3c7aa374dadbae4ca9884b6e4bf5cca 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Config/DataTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Config/DataTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Config; class DataTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/DB/AbstractMapperTest.php b/dev/tests/unit/testsuite/Magento/Framework/DB/AbstractMapperTest.php index e28c03d36106e46bcde357a81c5cf768512fff9d..be23023b85c89a6b5f342c1f73b854c70a2cd7e5 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/DB/AbstractMapperTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/DB/AbstractMapperTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\DB; /** diff --git a/dev/tests/unit/testsuite/Magento/Framework/DB/Adapter/Pdo/MysqlTest.php b/dev/tests/unit/testsuite/Magento/Framework/DB/Adapter/Pdo/MysqlTest.php index e22d3a334d854ea01de5b7869c472d5b8e03d874..1b1c50685df127ea3859602291c8b4307de93588 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/DB/Adapter/Pdo/MysqlTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/DB/Adapter/Pdo/MysqlTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * \Magento\Framework\DB\Adapter\Pdo\Mysql class test */ diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/Collection/DbTest.php b/dev/tests/unit/testsuite/Magento/Framework/Data/Collection/DbTest.php index e4e04f216a07226c21fe1e5e02d83edb11acd764..3bbb57d093b01d4f70463a7de19fd5b335043238 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Data/Collection/DbTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Data/Collection/DbTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Data\Collection; class DbTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Data/Form/Element/AbstractElementTest.php b/dev/tests/unit/testsuite/Magento/Framework/Data/Form/Element/AbstractElementTest.php index 06608c1f43bc22671c3760cd5d6a5eba02ebe997..a65be33f106bd60b7b771e24eba4fb05908c2e3e 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Data/Form/Element/AbstractElementTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Data/Form/Element/AbstractElementTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Tests for \Magento\Framework\Data\Form\Element\AbstractElement */ diff --git a/dev/tests/unit/testsuite/Magento/Framework/File/CsvTest.php b/dev/tests/unit/testsuite/Magento/Framework/File/CsvTest.php index f013ad13cfb7ce5b4f2a7ef451b46fda5c906d05..80c360d50d854bafd11c2186a53ce3f782761b04 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/File/CsvTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/File/CsvTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test class for \Magento\Framework\File\Csv. */ diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/Generator/InterceptorTest.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/Generator/InterceptorTest.php index f9684ec960e0cee2284345502c112ac1ec1b4907..5fb90c588b2b03d5671e86bc637225fd8c0e62c8 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/Generator/InterceptorTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/Generator/InterceptorTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Code\Generator; class InterceptorTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/InterfaceValidatorTest.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/InterfaceValidatorTest.php index a457e5d6479f666ada1d018553c1d82dfad3a27c..3585187b57c1c04ef22f177839cb719e0ecb2741 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/InterfaceValidatorTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/Code/InterfaceValidatorTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Code; class InterfaceValidatorTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/ExtraParameters.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/ExtraParameters.php index 199fefa92fcbeff11f9d5ec2e894d18e9e4ff953..6b3aedde8310af79d8a1902c17992eb137dbdab1 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/ExtraParameters.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/ExtraParameters.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Custom\Module\Model\InterfaceValidator\ItemPlugin; class ExtraParameters diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/IncompatibleArgumentsCount.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/IncompatibleArgumentsCount.php index e7f1488d7829e75d2ff36c0c19e468874b3f786f..f6de307fb9c7ee9304679b3c18d1f56db50b4da0 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/IncompatibleArgumentsCount.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/IncompatibleArgumentsCount.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Custom\Module\Model\InterfaceValidator\ItemPlugin; class IncompatibleArgumentsCount diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/IncompatibleArgumentsType.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/IncompatibleArgumentsType.php index c4ae623ef39805ccbb06dc582dd43a6cf41e28eb..6b104b2a0b0184896908f9700999a1c76dd1b97b 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/IncompatibleArgumentsType.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/IncompatibleArgumentsType.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Custom\Module\Model\InterfaceValidator\ItemPlugin; class IncompatibleArgumentsType diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/InvalidProceed.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/InvalidProceed.php index a75b305865ce0e4abb4a382e6a9c2dc108a0a3f8..07ed13934f6728a6f577d5257de516fb8fddffbd 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/InvalidProceed.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/InvalidProceed.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Custom\Module\Model\InterfaceValidator\ItemPlugin; class InvalidProceed diff --git a/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/ValidPlugin.php b/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/ValidPlugin.php index 748f08235968a1994dd6339e98d23ceb7ea6be42..9a51d1a894a17a92b27f79c832b9b77705637939 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/ValidPlugin.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Interception/Custom/Module/Model/InterfaceValidator/ItemPlugin/ValidPlugin.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Custom\Module\Model\InterfaceValidator\ItemPlugin; class ValidPlugin diff --git a/dev/tests/unit/testsuite/Magento/Framework/Less/FileGeneratorTest.php b/dev/tests/unit/testsuite/Magento/Framework/Less/FileGeneratorTest.php index 5dd7159b993b6931cee0f8f5826ad99d46ef4a55..cae64ac721c4bd98446e99cb74269463a3e2967a 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Less/FileGeneratorTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Less/FileGeneratorTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Less; use Magento\Framework\App\Filesystem\DirectoryList; diff --git a/dev/tests/unit/testsuite/Magento/Framework/Less/PreProcessor/Instruction/ImportTest.php b/dev/tests/unit/testsuite/Magento/Framework/Less/PreProcessor/Instruction/ImportTest.php index 3c12c8e9d90eaae85a8b41d0b981c876b76a9334..e15630ee028561a826ff21ce60eca12038283369 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Less/PreProcessor/Instruction/ImportTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Less/PreProcessor/Instruction/ImportTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Less\PreProcessor\Instruction; class ImportTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Less/PreProcessor/Instruction/MagentoImportTest.php b/dev/tests/unit/testsuite/Magento/Framework/Less/PreProcessor/Instruction/MagentoImportTest.php index 07ad34a5fa1bfc96d74c70ff6f16350db3115acf..c70ac5bd6bdc16dc90107b5440153843f3ba8949 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Less/PreProcessor/Instruction/MagentoImportTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Less/PreProcessor/Instruction/MagentoImportTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Less\PreProcessor\Instruction; class MagentoImportTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Locale/ConfigTest.php b/dev/tests/unit/testsuite/Magento/Framework/Locale/ConfigTest.php index 166fcc537c0b2f19bc794a0372d795e32da97b1e..9699274f56ead8e25034e5d19edef5393e3454bb 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Locale/ConfigTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Locale/ConfigTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Locale; class ConfigTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Locale/CurrencyTest.php b/dev/tests/unit/testsuite/Magento/Framework/Locale/CurrencyTest.php index c7b313e2e8eb13ac4129ad1be84cebce5036e843..c04b01b2d4f9744692d86f4a597a1aba8b6a9914 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Locale/CurrencyTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Locale/CurrencyTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Locale; diff --git a/dev/tests/unit/testsuite/Magento/Framework/Message/ManagerTest.php b/dev/tests/unit/testsuite/Magento/Framework/Message/ManagerTest.php index 3b17dcd35592942814d81df0dba8c4ff063d2b19..6fee9007cc8f21b64d48759334bf3a27e99d6186 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Message/ManagerTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Message/ManagerTest.php @@ -168,6 +168,9 @@ class ManagerTest extends \PHPUnit_Framework_TestCase $this->assertEquals($messageCollection, $this->model->getMessages(true)); } + /** + * @SuppressWarnings(PHPMD.UnusedLocalVariable) + */ public function testAddException() { $exceptionMessage = 'exception message'; diff --git a/dev/tests/unit/testsuite/Magento/Framework/Model/Resource/Db/AbstractDbTest.php b/dev/tests/unit/testsuite/Magento/Framework/Model/Resource/Db/AbstractDbTest.php index e3199a3c30f485ac18ad2d4f89fd002c423c18be..f7c3c49ea5e686b0f59533c352d5940e9ca68ced 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Model/Resource/Db/AbstractDbTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Model/Resource/Db/AbstractDbTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Model\Resource\Db; class AbstractDbTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Model/Resource/Db/Collection/AbstractCollectionTest.php b/dev/tests/unit/testsuite/Magento/Framework/Model/Resource/Db/Collection/AbstractCollectionTest.php index 6127434681775f7433f5231739b24fda6ddbf2c1..3a883fbb7a4caf681fa67fbbc636b0b116849669 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Model/Resource/Db/Collection/AbstractCollectionTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Model/Resource/Db/Collection/AbstractCollectionTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Model\Resource\Db\Collection; use Magento\Framework\Object as MagentoObject; diff --git a/dev/tests/unit/testsuite/Magento/Framework/Mview/Config/Data/ProxyTest.php b/dev/tests/unit/testsuite/Magento/Framework/Mview/Config/Data/ProxyTest.php index 7e400b5e607938cd3c51362de8e2c97f49259d21..40270d32b8de3aba3d821ffec6677d5bc33b3a86 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Mview/Config/Data/ProxyTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Mview/Config/Data/ProxyTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Mview\Config\Data; class ProxyTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Mview/ConfigTest.php b/dev/tests/unit/testsuite/Magento/Framework/Mview/ConfigTest.php index 138b0d412f4379aea9c7349c27e0abd2663cd12c..7ba95225f3112f244d16315e33245aac02f6f15a 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Mview/ConfigTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Mview/ConfigTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Mview; class ConfigTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Mview/View/CollectionTest.php b/dev/tests/unit/testsuite/Magento/Framework/Mview/View/CollectionTest.php index 3ce52356f96a5c6844022ea157d56cc21ed264ce..b7e41b0b644f8a592c71e310af1aa774e668d0f3 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Mview/View/CollectionTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Mview/View/CollectionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Mview\View; class CollectionTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionFactoryTest.php index 810b0658ea3da389f0314bbea8430533e342cf94..4f0e5c342340f69cc241e88ebf310aa0b9062e78 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionFactoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionFactoryTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Mview\View; class SubscriptionFactoryTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionTest.php b/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionTest.php index 7534fe8248a776006d1f00a400a9b388d0acb4cf..be2fd374c0650e689414585e2d6eb9bd27b4855c 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Mview/View/SubscriptionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Mview\View; class SubscriptionTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Config/Reader/_files/ConfigDomMock.php b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Config/Reader/_files/ConfigDomMock.php index 3fb090231b82439919d76a8d91890d27490961f6..492fbab7633205c23ebd1afb384bbc7492a2af9e 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Config/Reader/_files/ConfigDomMock.php +++ b/dev/tests/unit/testsuite/Magento/Framework/ObjectManager/Config/Reader/_files/ConfigDomMock.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + class ConfigDomMock extends \PHPUnit_Framework_TestCase { /** diff --git a/dev/tests/unit/testsuite/Magento/Framework/Phrase/Renderer/CompositeTest.php b/dev/tests/unit/testsuite/Magento/Framework/Phrase/Renderer/CompositeTest.php index 5240391806c6923ef2c16d5e365df1b0e747755f..7d7799da50ad76b27c78b1698c0a4fdb432f5f44 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Phrase/Renderer/CompositeTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Phrase/Renderer/CompositeTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Phrase\Renderer; class CompositeTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Session/ConfigTest.php b/dev/tests/unit/testsuite/Magento/Framework/Session/ConfigTest.php index 7cf2c23ac1f70c3611aa594daf822e8c58c1e6dc..e51b345024e437f48a4fe454538ee3ecc5fdb550 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Session/ConfigTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Session/ConfigTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test class for \Magento\Framework\Session\Config */ diff --git a/dev/tests/unit/testsuite/Magento/Framework/ShellTest.php b/dev/tests/unit/testsuite/Magento/Framework/ShellTest.php index fdb1ecc39edb145da37c22ed9b7785ea99def227..d2d5ba75e69097eabd633d796ce0cca4bafaca50 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/ShellTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/ShellTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework; class ShellTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php b/dev/tests/unit/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php index b55e6bedcf03bb8a347d773dc1803fe02047eb54..ea06bde7734e323f8341b3af8e86f5b6d491ab74 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Stdlib/Cookie/CookieScopeTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Stdlib\Cookie; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieManagerTest.php b/dev/tests/unit/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieManagerTest.php index fd54f64bc406f3c571c3955bce7aff5b2733c62a..f731e2c8f2375db109ded7415078054b116e56ab 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieManagerTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Stdlib/Cookie/PhpCookieManagerTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + // @codingStandardsIgnoreStart namespace { $mockTranslateSetCookie = false; diff --git a/dev/tests/unit/testsuite/Magento/Framework/Test/Utility/FilesTest.php b/dev/tests/unit/testsuite/Magento/Framework/Test/Utility/FilesTest.php index 480dc93a159a7087ffbff3e41cc0009709b58542..9c7dccdfd0e347ccfcd753f8a6ae9e00566c5044 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/Test/Utility/FilesTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/Test/Utility/FilesTest.php @@ -44,21 +44,21 @@ class FilesTest extends \PHPUnit_Framework_TestCase $this->assertSame([], Files::init()->readLists(__DIR__ . '/_files/no_good.txt')); } - /** - * @expectedException \Exception - * @expectedExceptionMessage The glob() pattern 'bar/unknown' didn't return any result. - */ public function testReadListsCorruptedDir() { - Files::init()->readLists(__DIR__ . '/_files/list_corrupted_dir.txt'); + $result = Files::init()->readLists(__DIR__ . '/_files/list_corrupted_dir.txt'); + + foreach ($result as $path) { + $this->assertNotContains('bar/unknown', $path); + } } - /** - * @expectedException \Exception - * @expectedExceptionMessage The glob() pattern 'unknown.txt' didn't return any result. - */ public function testReadListsCorruptedFile() { - Files::init()->readLists(__DIR__ . '/_files/list_corrupted_file.txt'); + $result = Files::init()->readLists(__DIR__ . '/_files/list_corrupted_file.txt'); + + foreach ($result as $path) { + $this->assertNotContains('unknown.txt', $path); + } } } diff --git a/dev/tests/unit/testsuite/Magento/Framework/UrlTest.php b/dev/tests/unit/testsuite/Magento/Framework/UrlTest.php index 2270de236ddc972fccd64c11dd8abc2ec33fa95f..916d0154e9f85139bcf00c1c709c1e066d31dae5 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/UrlTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/UrlTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework; /** diff --git a/dev/tests/unit/testsuite/Magento/Framework/ValidatorFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/ValidatorFactoryTest.php index 2f6a092034376adc39dc1bc6c0b924735c7faa73..aa48533df8654bef4834cf990b979775dfd6c763 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/ValidatorFactoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/ValidatorFactoryTest.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MergedTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MergedTest.php index d69b1755ea46cd665051c9e23e6a74a75b749de6..63d7fd42fb261a0d44d8405126989eebb57f0fce 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MergedTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/MergedTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Asset; class MergedTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/ModuleNotation/ResolverTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/ModuleNotation/ResolverTest.php index 74b7cb4eb897eafe231076df6185d4153c95f45a..fb4cfe1cb1463c1d0977506bad59e11d10c6324d 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/ModuleNotation/ResolverTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/ModuleNotation/ResolverTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Asset\ModuleNotation; class ResolverTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/PreProcessor/ModuleNotationTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/PreProcessor/ModuleNotationTest.php index a4ce6ba4138df47399618cd85efd2f0eb313d3be..414d21796ee70394aff0fde22e20091d38d22ca5 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/PreProcessor/ModuleNotationTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/PreProcessor/ModuleNotationTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Asset\PreProcessor; class ModuleNotationTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/RepositoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/RepositoryTest.php index 2b698915516e81e4b7ffe32e9cb7bb3dfbaaf481..b5cd4b03b9994136cd0e841d5be558c0a3a869d0 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/RepositoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/RepositoryTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Asset; class RepositoryTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/SourceTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/SourceTest.php index 15862f74256296debae5f7352a4c26a33ac0b8b3..8afbb1a372982dff4b35450415aa29aae4c30580 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Asset/SourceTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Asset/SourceTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Asset; use Magento\Framework\App\Filesystem\DirectoryList; diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/BlockPoolTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/BlockPoolTest.php index daf08c3bdaf40c85d0af1392fc52374ba9463bfc..5146fc9abf73fe2ea6749b5af29fe41d93ce47a7 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/BlockPoolTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/BlockPoolTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View; /** diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/DataSourcePoolTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/DataSourcePoolTest.php index db8d5747b3abcf0912347cae2ab8f2b604601d64..c7b73cbd2e3eceb7f208b40da8b046841cef555d 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/DataSourcePoolTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/DataSourcePoolTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View; /** diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/CacheData/FlatTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/CacheData/FlatTest.php index e08eda12a3fe802e209df5073f071b32747430df..be64df60fb07b467d9e1e9c7e888adfab5a222c0 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/CacheData/FlatTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/CacheData/FlatTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Design\FileResolution\Fallback\CacheData; class FlatTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/CacheData/GroupedTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/CacheData/GroupedTest.php index d578a5097b544fbca242548926dd39106bc01505..c3bf25cde02a0c4232e9ab91c3a0fee5da1f7b21 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/CacheData/GroupedTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/CacheData/GroupedTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Design\FileResolution\Fallback\CacheData; class GroupedTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/Resolver/AlternativeTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/Resolver/AlternativeTest.php index f9bba6e60a7427ace3be74f7af3c0e5bdebacd92..80441a9e29524b018a95facf41170b6b8cbbd18b 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/Resolver/AlternativeTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/Resolver/AlternativeTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Design\FileResolution\Fallback\Resolver; use Magento\Framework\App\Filesystem\DirectoryList; diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/Resolver/SimpleTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/Resolver/SimpleTest.php index d09fc77758cf3303e7fd6411b2a51c9bce7177cd..8d630c2b35f6819ed8b20541b51aa2fd33d86977 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/Resolver/SimpleTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Design/FileResolution/Fallback/Resolver/SimpleTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Design\FileResolution\Fallback\Resolver; use Magento\Framework\App\Filesystem\DirectoryList; diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Design/Theme/ImageTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Design/Theme/ImageTest.php index 6997945dfc982a37b04aed6d1dcdbf45ece072c2..fc283081345933b25bf8c224640bcd24bbcacf2b 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Design/Theme/ImageTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Design/Theme/ImageTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test theme image model */ diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Decorator/ModuleDependencyTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Decorator/ModuleDependencyTest.php index 3d3460610062f0c9104aa91d88cb7fe8494ce18b..ce7742dba428b379712ccded86c4e70b46d3f7c5 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Decorator/ModuleDependencyTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Decorator/ModuleDependencyTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\File\Collector\Decorator; class ModuleDependencyTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Decorator/ModuleOutputTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Decorator/ModuleOutputTest.php index 86f54dbfefaf57dec964a41d8e3a360e717cac14..89fd9fa7429f0c28a1d7bb29acc40faae8ca4c70 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Decorator/ModuleOutputTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Decorator/ModuleOutputTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\File\Collector\Decorator; class ModuleOutputTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Override/BaseTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Override/BaseTest.php index 49fe2c1aaa215194111d9c492cbf1f1754d77d1b..f6d2297afef60b532bbd2179193fffd9a3f9bd8a 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Override/BaseTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Override/BaseTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\File\Collector\Override; use Magento\Framework\App\Filesystem\DirectoryList; diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Override/ThemeModularTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Override/ThemeModularTest.php index 279077eb85440ccbb55de7458c87ad5811ba8944..01c7e203617bbb10f8e4245836054231bbc54736 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Override/ThemeModularTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/File/Collector/Override/ThemeModularTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\File\Collector\Override; use Magento\Framework\App\Filesystem\DirectoryList; diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/File/FileListTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/File/FileListTest.php index 5a5249cf105f1d403a75107a3aac48047d3b7367..fcab2e2c5bc7ce360827be7775f22450ceb80eea 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/File/FileListTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/File/FileListTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\File; class FileListTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/FileSystemTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/FileSystemTest.php index 6750319c542f3d85681d09d65c8532448699b4f9..a473e5ae8fd0169dd97ef516f7d747dc5a085612 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/FileSystemTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/FileSystemTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test for view filesystem model */ diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Reader/MoveTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Reader/MoveTest.php index c5703cbde8bb9d5f7572523fa760cef227a9906f..9f85c1d86826bca62c09a8148b6c725337fbfb34 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Reader/MoveTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Layout/Reader/MoveTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Layout\Reader; use Magento\Framework\View\Layout\ScheduledStructure; diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/Result/LayoutTest.php b/dev/tests/unit/testsuite/Magento/Framework/View/Result/LayoutTest.php index b9dc7d0afbf4eb802b4c5123385e61dad1b88b7e..99537b2c7814d0e0a2beba20e12fc34516f726d1 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/Result/LayoutTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/View/Result/LayoutTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\View\Result; /** diff --git a/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngine/_files/simple.phtml b/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngine/_files/simple.phtml index 2d3052dbfd4cefabec43e63861aa094666e441d7..3747449c2c33a4c3a8f057a4294797ef7fa52e47 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngine/_files/simple.phtml +++ b/dev/tests/unit/testsuite/Magento/Framework/View/TemplateEngine/_files/simple.phtml @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + ?> <html><?php $this->testMethod(); diff --git a/dev/tests/unit/testsuite/Magento/GiftMessage/Model/CartRepositoryTest.php b/dev/tests/unit/testsuite/Magento/GiftMessage/Model/CartRepositoryTest.php new file mode 100644 index 0000000000000000000000000000000000000000..c2712492bba77c1d6250553f368de9b7c4d43a3d --- /dev/null +++ b/dev/tests/unit/testsuite/Magento/GiftMessage/Model/CartRepositoryTest.php @@ -0,0 +1,184 @@ +<?php +/** + * + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ + +namespace Magento\GiftMessage\Model; + +class CartRepositoryTest extends \PHPUnit_Framework_TestCase +{ + /** + * @var CartRepository + */ + protected $cartRepository; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $quoteRepositoryMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $messageFactoryMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $quoteMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $messageMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $quoteItemMock; + + /** + * @var string + */ + protected $cartId = 13; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $storeManagerMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $giftMessageManagerMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $helperMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $storeMock; + + protected function setUp() + { + $this->quoteRepositoryMock = $this->getMock('Magento\Quote\Model\QuoteRepository', [], [], '', false); + $this->messageFactoryMock = $this->getMock( + 'Magento\GiftMessage\Model\MessageFactory', + [ + 'create', + '__wakeup' + ], + [], + '', + false + ); + $this->messageMock = $this->getMock('Magento\GiftMessage\Model\Message', [], [], '', false); + $this->quoteItemMock = $this->getMock( + '\Magento\Quote\Model\Quote\Item', + [ + 'getGiftMessageId', + '__wakeup' + ], + [], + '', + false + ); + $this->quoteMock = $this->getMock( + '\Magento\Quote\Model\Quote', + [ + 'getGiftMessageId', + 'getItemById', + 'getItemsCount', + 'isVirtual', + '__wakeup', + ], + [], + '', + false + ); + $this->storeManagerMock = $this->getMock('Magento\Store\Model\StoreManagerInterface'); + $this->giftMessageManagerMock = + $this->getMock('Magento\GiftMessage\Model\GiftMessageManager', [], [], '', false); + $this->helperMock = $this->getMock('Magento\GiftMessage\Helper\Message', [], [], '', false); + $this->storeMock = $this->getMock('Magento\Store\Model\Store', [], [], '', false); + $this->cartRepository = new CartRepository( + $this->quoteRepositoryMock, + $this->storeManagerMock, + $this->giftMessageManagerMock, + $this->helperMock, + $this->messageFactoryMock + ); + + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive') + ->with($this->cartId) + ->will($this->returnValue($this->quoteMock)); + } + + public function testGetWithOutMessageId() + { + $messageId = 0; + + $this->quoteMock->expects($this->once())->method('getGiftMessageId')->will($this->returnValue($messageId)); + + $this->assertNull($this->cartRepository->get($this->cartId)); + } + + public function testGet() + { + $messageId = 156; + + $this->quoteMock->expects($this->once())->method('getGiftMessageId')->will($this->returnValue($messageId)); + $this->messageFactoryMock->expects($this->once()) + ->method('create') + ->will($this->returnValue($this->messageMock)); + $this->messageMock->expects($this->once())->method('load')->will($this->returnValue($this->messageMock)); + + $this->assertEquals($this->messageMock, $this->cartRepository->get($this->cartId)); + } + + /** + * @expectedException \Magento\Framework\Exception\InputException + * @expectedExceptionMessage Gift Messages is not applicable for empty cart + */ + public function testSaveWithInputException() + { + $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(0)); + + $this->cartRepository->save($this->cartId, $this->messageMock); + } + + /** + * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException + * @expectedExceptionMessage Gift Messages is not applicable for virtual products + */ + public function testSaveWithInvalidTransitionException() + { + $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1)); + $this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(true)); + + $this->cartRepository->save($this->cartId, $this->messageMock); + } + + public function testSave() + { + $this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false)); + $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1)); + $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock)); + $this->helperMock->expects($this->once()) + ->method('getIsMessagesAvailable') + ->with('quote', $this->quoteMock, $this->storeMock) + ->will($this->returnValue(true)); + $this->giftMessageManagerMock->expects($this->once()) + ->method('setMessage') + ->with($this->quoteMock, 'quote', $this->messageMock) + ->will($this->returnValue($this->giftMessageManagerMock)); + + $this->assertTrue($this->cartRepository->save($this->cartId, $this->messageMock)); + } +} diff --git a/dev/tests/unit/testsuite/Magento/GiftMessage/Model/GiftMessageManagerTest.php b/dev/tests/unit/testsuite/Magento/GiftMessage/Model/GiftMessageManagerTest.php index 2b616a6b74318aff0b6bc0681bd6d429c9dd430d..b264a94ede81ca169897ab91cd1e6352efcf965b 100644 --- a/dev/tests/unit/testsuite/Magento/GiftMessage/Model/GiftMessageManagerTest.php +++ b/dev/tests/unit/testsuite/Magento/GiftMessage/Model/GiftMessageManagerTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\GiftMessage\Model; class GiftMessageManagerTest extends \PHPUnit_Framework_TestCase @@ -44,6 +46,16 @@ class GiftMessageManagerTest extends \PHPUnit_Framework_TestCase */ protected $giftMessageMock; + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $billingAddressMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $shippingAddressMock; + protected function setUp() { $this->messageFactoryMock = @@ -56,6 +68,8 @@ class GiftMessageManagerTest extends \PHPUnit_Framework_TestCase 'save', 'getItemById', 'getAddressById', + 'getBillingAddress', + 'getShippingAddress', '__wakeup'], [], '', @@ -100,6 +114,9 @@ class GiftMessageManagerTest extends \PHPUnit_Framework_TestCase 'setSender', 'setRecipient', 'setMessage', + 'getSender', + 'getRecipient', + 'getMessage', 'getId', 'delete', 'save', @@ -109,6 +126,10 @@ class GiftMessageManagerTest extends \PHPUnit_Framework_TestCase '', false); + $this->billingAddressMock = + $this->getMock('\Magento\Sales\Model\Quote\Address', ['getCountryId', '__wakeup'], [], '', false); + $this->shippingAddressMock = + $this->getMock('\Magento\Sales\Model\Quote\Address', ['getCountryId', '__wakeup'], [], '', false); $this->model = new GiftMessageManager($this->messageFactoryMock); } @@ -287,4 +308,62 @@ class GiftMessageManagerTest extends \PHPUnit_Framework_TestCase $this->model->add($giftMessages, $this->quoteMock); } + + /** + * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException + * @expectedExceptionMessage Billing address is not set + */ + public function testSetMessageEmptyBillingAddressException() + { + $this->quoteMock->expects($this->once()) + ->method('getBillingAddress') + ->will($this->returnValue($this->billingAddressMock)); + $this->billingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(null)); + + $this->model->setMessage($this->quoteMock, 'item', $this->giftMessageMock); + } + + /** + * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException + * @expectedExceptionMessage Shipping address is not set + */ + public function testSetMessageEmptyShippingAddressException() + { + $this->quoteMock->expects($this->once()) + ->method('getBillingAddress') + ->will($this->returnValue($this->billingAddressMock)); + $this->billingAddressMock->expects($this->any())->method('getCountryId')->will($this->returnValue(12)); + $this->quoteMock->expects($this->once()) + ->method('getShippingAddress') + ->will($this->returnValue($this->shippingAddressMock)); + $this->shippingAddressMock->expects($this->any())->method('getCountryId')->will($this->returnValue(null)); + + $this->model->setMessage($this->quoteMock, 'item', $this->giftMessageMock); + } + + /** + * @expectedException \Magento\Framework\Exception\CouldNotSaveException + * @expectedExceptionMessage Could not add gift message to shopping cart + */ + public function testSetMessageCouldNotAddGiftMessageException() + { + $this->quoteMock->expects($this->once()) + ->method('getBillingAddress') + ->will($this->returnValue($this->billingAddressMock)); + $this->billingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(12)); + $this->quoteMock->expects($this->once()) + ->method('getShippingAddress') + ->will($this->returnValue($this->shippingAddressMock)); + $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(13)); + $this->giftMessageMock->expects($this->once())->method('getSender')->will($this->returnValue('sender')); + $this->giftMessageMock->expects($this->once())->method('getRecipient')->will($this->returnValue('recipient')); + $this->giftMessageMock->expects($this->once())->method('getMessage')->will($this->returnValue('Message')); + + $this->messageFactoryMock->expects($this->once()) + ->method('create') + ->willThrowException(new \Exception()); + + $this->model->setMessage($this->quoteMock, 'item', $this->giftMessageMock); + } + } diff --git a/dev/tests/unit/testsuite/Magento/GiftMessage/Model/ItemRepositoryTest.php b/dev/tests/unit/testsuite/Magento/GiftMessage/Model/ItemRepositoryTest.php new file mode 100644 index 0000000000000000000000000000000000000000..18fb89322ce346894f8746baa0650c205634bb02 --- /dev/null +++ b/dev/tests/unit/testsuite/Magento/GiftMessage/Model/ItemRepositoryTest.php @@ -0,0 +1,223 @@ +<?php +/** + * + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ + +namespace Magento\GiftMessage\Model; + + +class ItemRepositoryTest extends \PHPUnit_Framework_TestCase +{ + /** + * @var ItemRepository + */ + protected $itemRepository; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $quoteRepositoryMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $messageFactoryMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $quoteMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $messageMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $quoteItemMock; + + /** + * @var string + */ + protected $cartId = 13; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $storeManagerMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $giftMessageManagerMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $helperMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $storeMock; + + protected function setUp() + { + $this->quoteRepositoryMock = $this->getMock('Magento\Quote\Model\QuoteRepository', [], [], '', false); + $this->messageFactoryMock = $this->getMock( + 'Magento\GiftMessage\Model\MessageFactory', + [ + 'create', + '__wakeup' + ], + [], + '', + false + ); + $this->messageMock = $this->getMock('Magento\GiftMessage\Model\Message', [], [], '', false); + $this->quoteItemMock = $this->getMock( + '\Magento\Qote\Model\Quote\Item', + [ + 'getGiftMessageId', + '__wakeup' + ], + [], + '', + false + ); + $this->quoteMock = $this->getMock( + '\Magento\Quote\Model\Quote', + [ + 'getGiftMessageId', + 'getItemById', + '__wakeup', + ], + [], + '', + false + ); + $this->storeManagerMock = $this->getMock('Magento\Store\Model\StoreManagerInterface'); + $this->giftMessageManagerMock = + $this->getMock('Magento\GiftMessage\Model\GiftMessageManager', [], [], '', false); + $this->helperMock = $this->getMock('Magento\GiftMessage\Helper\Message', [], [], '', false); + $this->storeMock = $this->getMock('Magento\Store\Model\Store', [], [], '', false); + $this->itemRepository = new ItemRepository( + $this->quoteRepositoryMock, + $this->storeManagerMock, + $this->giftMessageManagerMock, + $this->helperMock, + $this->messageFactoryMock + ); + + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive') + ->with($this->cartId) + ->will($this->returnValue($this->quoteMock)); + } + + /** + * @expectedException \Magento\Framework\Exception\NoSuchEntityException + * @expectedExceptionMessage There is no item with provided id in the cart + */ + public function testGetWithNoSuchEntityException() + { + $itemId = 2; + + $this->quoteMock->expects($this->once())->method('getItemById')->with($itemId)->will($this->returnValue(null)); + + $this->itemRepository->get($this->cartId, $itemId); + } + + public function testGetWithoutMessageId() + { + $messageId = 0; + $itemId = 2; + + $this->quoteMock->expects($this->once()) + ->method('getItemById') + ->with($itemId) + ->will($this->returnValue($this->quoteItemMock)); + $this->quoteItemMock->expects($this->once())->method('getGiftMessageId')->will($this->returnValue($messageId)); + + $this->assertNull($this->itemRepository->get($this->cartId, $itemId)); + } + + public function testGet() + { + $messageId = 123; + $itemId = 2; + + $this->quoteMock->expects($this->once()) + ->method('getItemById') + ->with($itemId) + ->will($this->returnValue($this->quoteItemMock)); + $this->quoteItemMock->expects($this->once())->method('getGiftMessageId')->will($this->returnValue($messageId)); + $this->messageFactoryMock->expects($this->once()) + ->method('create') + ->will($this->returnValue($this->messageMock)); + $this->messageMock->expects($this->once()) + ->method('load') + ->with($messageId) + ->will($this->returnValue($this->messageMock)); + + $this->assertEquals($this->messageMock, $this->itemRepository->get($this->cartId, $itemId)); + } + + /** + * @expectedException \Magento\Framework\Exception\NoSuchEntityException + * @expectedExceptionMessage There is no product with provided itemId: 1 in the cart + */ + public function testSaveWithNoSuchEntityException() + { + $itemId = 1; + + $this->quoteMock->expects($this->once())->method('getItemById')->with($itemId)->will($this->returnValue(null)); + + $this->itemRepository->save($this->cartId, $this->messageMock, $itemId); + } + + /** + * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException + * @expectedExceptionMessage Gift Messages is not applicable for virtual products + */ + public function testSaveWithInvalidTransitionException() + { + $itemId = 1; + + $quoteItem = $this->getMock('\Magento\Sales\Model\Quote\Item', ['getIsVirtual', '__wakeup'], [], '', false); + $this->quoteMock->expects($this->once()) + ->method('getItemById') + ->with($itemId) + ->will($this->returnValue($quoteItem)); + $quoteItem->expects($this->once())->method('getIsVirtual')->will($this->returnValue(1)); + + $this->itemRepository->save($this->cartId, $this->messageMock, $itemId); + } + + public function testSave() + { + $itemId = 1; + + $quoteItem = $this->getMock('\Magento\Sales\Model\Quote\Item', ['getIsVirtual', '__wakeup'], [], '', false); + $this->quoteMock->expects($this->once()) + ->method('getItemById') + ->with($itemId) + ->will($this->returnValue($quoteItem)); + $quoteItem->expects($this->once())->method('getIsVirtual')->will($this->returnValue(0)); + $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock)); + $this->helperMock->expects($this->once()) + ->method('getIsMessagesAvailable') + ->with('items', $this->quoteMock, $this->storeMock) + ->will($this->returnValue(true)); + $this->giftMessageManagerMock->expects($this->once()) + ->method('setMessage') + ->with($this->quoteMock, 'quote_item', $this->messageMock, $itemId) + ->will($this->returnValue($this->giftMessageManagerMock)); + + $this->assertTrue($this->itemRepository->save($this->cartId, $this->messageMock, $itemId)); + } +} diff --git a/dev/tests/unit/testsuite/Magento/GiftMessage/Model/Type/Plugin/OnepageTest.php b/dev/tests/unit/testsuite/Magento/GiftMessage/Model/Type/Plugin/OnepageTest.php index f5837c449a2dd44383dd5662a049ad5b8c1beda8..a2d5d278ed302a5a879db95dac9b543409adfec1 100644 --- a/dev/tests/unit/testsuite/Magento/GiftMessage/Model/Type/Plugin/OnepageTest.php +++ b/dev/tests/unit/testsuite/Magento/GiftMessage/Model/Type/Plugin/OnepageTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\GiftMessage\Model\Type\Plugin; class OnepageTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/ReadServiceTest.php b/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/ReadServiceTest.php deleted file mode 100644 index ac28515811ba34adffbb36cf425bd546eeb39705..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/ReadServiceTest.php +++ /dev/null @@ -1,186 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\GiftMessage\Service\V1; - -class ReadServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var ReadService - */ - protected $service; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $messageFactoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $messageMapperMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $messageMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteItemMock; - - /** - * @var string - */ - protected $cardId; - - protected function setUp() - { - $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - $this->cardId = 13; - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->messageFactoryMock = $this->getMock( - '\Magento\GiftMessage\Model\MessageFactory', - [ - 'create', - '__wakeup' - ], - [], - '', - false); - $this->messageMapperMock = $this->getMock( - '\Magento\GiftMessage\Service\V1\Data\MessageMapper', - [ - 'extractDto', - '__wakeup' - ], - [], - '', - false); - $this->messageMock = $this->getMock('\Magento\GiftMessage\Model\Message', [], [], '', false); - $this->quoteItemMock = $this->getMock( - '\Magento\Quote\Model\Quote\Item', - [ - 'getGiftMessageId', - '__wakeup' - ], - [], - '', - false); - $this->quoteMock = $this->getMock( - '\Magento\Quote\Model\Quote', - [ - 'getGiftMessageId', - 'getItemById', - '__wakeup', - ], - [], - '', - false); - - $this->service = $objectManager->getObject( - 'Magento\GiftMessage\Service\V1\ReadService', - [ - 'quoteRepository' => $this->quoteRepositoryMock, - 'messageFactory' => $this->messageFactoryMock, - 'messageMapper' => $this->messageMapperMock, - ] - ); - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($this->cardId) - ->will($this->returnValue($this->quoteMock)); - } - - public function testGetWithOutMessageId() - { - $messageId = 0; - - $this->quoteMock->expects($this->once())->method('getGiftMessageId')->will($this->returnValue($messageId)); - - $this->assertNull($this->service->get($this->cardId)); - } - - public function testGet() - { - $messageId = 156; - - $this->quoteMock->expects($this->once())->method('getGiftMessageId')->will($this->returnValue($messageId)); - $this->messageFactoryMock->expects($this->once()) - ->method('create') - ->will($this->returnValue($this->messageMock)); - $this->messageMock->expects($this->once())->method('load')->will($this->returnValue($this->messageMock)); - $this->messageMapperMock->expects($this->once()) - ->method('extractDto')->with($this->messageMock)->will($this->returnValue(['Expected value'])); - - $this->assertEquals(['Expected value'], $this->service->get($this->cardId)); - } - - /** - * @expectedException \Magento\Framework\Exception\NoSuchEntityException - * @expectedExceptionMessage There is no item with provided id in the cart - */ - public function testGetItemMessageWithNoSuchEntityException() - { - $itemId = 2; - - $this->quoteMock->expects($this->once())->method('getItemById')->with($itemId)->will($this->returnValue(null)); - - $this->service->getItemMessage($this->cardId, $itemId); - } - - public function testGetItemMessageWithoutMessageId() - { - $messageId = 0; - $itemId = 2; - - $this->quoteMock->expects($this->once()) - ->method('getItemById') - ->with($itemId) - ->will($this->returnValue($this->quoteItemMock)); - $this->quoteItemMock->expects($this->once())->method('getGiftMessageId')->will($this->returnValue($messageId)); - - $this->assertNull($this->service->getItemMessage($this->cardId, $itemId)); - } - - public function testGetItemMessage() - { - $messageId = 123; - $itemId = 2; - - $this->quoteMock->expects($this->once()) - ->method('getItemById') - ->with($itemId) - ->will($this->returnValue($this->quoteItemMock)); - $this->quoteItemMock->expects($this->once())->method('getGiftMessageId')->will($this->returnValue($messageId)); - $this->messageFactoryMock->expects($this->once()) - ->method('create') - ->will($this->returnValue($this->messageMock)); - $this->messageMock->expects($this->once()) - ->method('load') - ->with($messageId) - ->will($this->returnValue($this->messageMock)); - $this->messageMapperMock->expects($this->once()) - ->method('extractDto') - ->with($this->messageMock) - ->will($this->returnValue(['Expected value'])); - - $this->assertEquals(['Expected value'], $this->service->getItemMessage($this->cardId, $itemId)); - } -} diff --git a/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php deleted file mode 100644 index 08a34847fdde6c3f4519bfafdf9574d4a14e151d..0000000000000000000000000000000000000000 --- a/dev/tests/unit/testsuite/Magento/GiftMessage/Service/V1/WriteServiceTest.php +++ /dev/null @@ -1,388 +0,0 @@ -<?php -/** - * - * Copyright © 2015 Magento. All rights reserved. - * See COPYING.txt for license details. - */ - -namespace Magento\GiftMessage\Service\V1; - -class WriteServiceTest extends \PHPUnit_Framework_TestCase -{ - /** - * @var WriteService - */ - protected $service; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteRepositoryMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $storeManagerMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $giftMessageManagerMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $helperMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $giftMessageMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $quoteMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $billingAddressMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $shippingAddressMock; - - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $storeMock; - - protected function setUp() - { - $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - - $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->storeManagerMock = $this->getMock('\Magento\Store\Model\StoreManagerInterface'); - $this->giftMessageManagerMock = - $this->getMock('\Magento\GiftMessage\Model\GiftMessageManager', [], [], '', false); - $this->helperMock = $this->getMock('\Magento\GiftMessage\Helper\Message', [], [], '', false); - $this->giftMessageMock = $this->getMock('\Magento\GiftMessage\Service\V1\Data\Message', [], [], '', false); - $this->quoteMock = $this->getMock( - '\Magento\Quote\Model\Quote', - [ - 'getItemsCount', - 'isVirtual', - 'getBillingAddress', - 'getShippingAddress', - 'getItemById', - '__wakeup' - ], - [], - '', - false - ); - $this->billingAddressMock = - $this->getMock('\Magento\Quote\Model\Quote\Address', ['getCountryId', '__wakeup'], [], '', false); - $this->shippingAddressMock = - $this->getMock('\Magento\Quote\Model\Quote\Address', ['getCountryId', '__wakeup'], [], '', false); - $this->storeMock = $this->getMock('\Magento\Store\Model\Store', [], [], '', false); - - $this->service = $objectManager->getObject( - 'Magento\GiftMessage\Service\V1\WriteService', - [ - 'quoteRepository' => $this->quoteRepositoryMock, - 'storeManager' => $this->storeManagerMock, - 'giftMessageManager' => $this->giftMessageManagerMock, - 'helper' => $this->helperMock - ] - ); - } - - /** - * @expectedException \Magento\Framework\Exception\InputException - * @expectedExceptionMessage Gift Messages is not applicable for empty cart - */ - public function testSetForQuoteWithInputException() - { - $cartId = 665; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(0)); - - $this->service->setForQuote($cartId, $this->giftMessageMock); - } - - /** - * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException - * @expectedExceptionMessage Gift Messages is not applicable for virtual products - */ - public function testSetForQuoteWithInvalidTransitionException() - { - $cartId = 665; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1)); - $this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(true)); - - $this->service->setForQuote($cartId, $this->giftMessageMock); - } - - public function testSetForQuote() - { - $cartId = 665; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1)); - $this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false)); - $this->quoteMock->expects($this->once()) - ->method('getBillingAddress') - ->will($this->returnValue($this->billingAddressMock)); - $this->billingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(12)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress') - ->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(13)); - $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock)); - $this->helperMock->expects($this->once()) - ->method('getIsMessagesAvailable') - ->with('', $this->quoteMock, $this->storeMock) - ->will($this->returnValue(true)); - $this->giftMessageMock->expects($this->once())->method('getSender')->will($this->returnValue('sender')); - $this->giftMessageMock->expects($this->once())->method('getRecipient')->will($this->returnValue('recipient')); - $this->giftMessageMock->expects($this->once())->method('getMessage')->will($this->returnValue('Message')); - $message['quote'][null] = - [ - 'from' => 'sender', - 'to' => 'recipient', - 'message' => 'Message', - ]; - $this->giftMessageManagerMock->expects($this->once()) - ->method('add') - ->with($message, $this->quoteMock) - ->will($this->returnValue($this->giftMessageManagerMock)); - - $this->assertTrue($this->service->setForQuote($cartId, $this->giftMessageMock)); - } - - /** - * @expectedException \Magento\Framework\Exception\NoSuchEntityException - * @expectedExceptionMessage There is no product with provided itemId: 1 in the cart - */ - public function testSetForItemWithNoSuchEntityException() - { - $cartId = 665; - $itemId = 1; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once())->method('getItemById')->with($itemId)->will($this->returnValue(null)); - - $this->service->setForItem($cartId, $this->giftMessageMock, $itemId); - } - - /** - * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException - * @expectedExceptionMessage Gift Messages is not applicable for virtual products - */ - public function testSetForItemWithInvalidTransitionException() - { - $cartId = 665; - $itemId = 1; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $quoteItem = $this->getMock('\Magento\Quote\Model\Quote\Item', ['getIsVirtual', '__wakeup'], [], '', false); - $this->quoteMock->expects($this->once()) - ->method('getItemById') - ->with($itemId) - ->will($this->returnValue($quoteItem)); - $quoteItem->expects($this->once())->method('getIsVirtual')->will($this->returnValue(1)); - - $this->service->setForItem($cartId, $this->giftMessageMock, $itemId); - } - - public function testSetForItem() - { - $cartId = 665; - $itemId = 1; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $quoteItem = $this->getMock('\Magento\Quote\Model\Quote\Item', ['getIsVirtual', '__wakeup'], [], '', false); - $this->quoteMock->expects($this->once()) - ->method('getItemById') - ->with($itemId) - ->will($this->returnValue($quoteItem)); - $quoteItem->expects($this->once())->method('getIsVirtual')->will($this->returnValue(0)); - $this->quoteMock->expects($this->once()) - ->method('getBillingAddress') - ->will($this->returnValue($this->billingAddressMock)); - $this->billingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(12)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress') - ->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(13)); - $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock)); - $this->helperMock->expects($this->once()) - ->method('getIsMessagesAvailable') - ->with('items', $this->quoteMock, $this->storeMock) - ->will($this->returnValue(true)); - $this->giftMessageMock->expects($this->once())->method('getSender')->will($this->returnValue('sender')); - $this->giftMessageMock->expects($this->once())->method('getRecipient')->will($this->returnValue('recipient')); - $this->giftMessageMock->expects($this->once())->method('getMessage')->will($this->returnValue('Message')); - $message['quote_item'][1] = - [ - 'from' => 'sender', - 'to' => 'recipient', - 'message' => 'Message', - ]; - $this->giftMessageManagerMock->expects($this->once()) - ->method('add') - ->with($message, $this->quoteMock) - ->will($this->returnValue($this->giftMessageManagerMock)); - - $this->assertTrue($this->service->setForItem($cartId, $this->giftMessageMock, $itemId)); - } - - /** - * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException - * @expectedExceptionMessage Billing address is not set - */ - public function testSetMessageEmptyBillingAddressException() - { - $cartId = 665; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1)); - $this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false)); - $this->quoteMock->expects($this->once()) - ->method('getBillingAddress') - ->will($this->returnValue($this->billingAddressMock)); - $this->billingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(null)); - - $this->service->setForQuote($cartId, $this->giftMessageMock); - } - - /** - * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException - * @expectedExceptionMessage Shipping address is not set - */ - public function testSetMessageEmptyShippingAddressException() - { - $cartId = 665; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1)); - $this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false)); - $this->quoteMock->expects($this->once()) - ->method('getBillingAddress') - ->will($this->returnValue($this->billingAddressMock)); - $this->billingAddressMock->expects($this->any())->method('getCountryId')->will($this->returnValue(12)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress') - ->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->any())->method('getCountryId')->will($this->returnValue(null)); - - $this->service->setForQuote($cartId, $this->giftMessageMock); - } - - /** - * @expectedException \Magento\Framework\Exception\CouldNotSaveException - * @expectedExceptionMessage Gift Message is not available - */ - public function testSetMessageGiftMessageIsNotAvailableException() - { - $cartId = 665; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1)); - $this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false)); - $this->quoteMock->expects($this->once()) - ->method('getBillingAddress') - ->will($this->returnValue($this->billingAddressMock)); - $this->billingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(12)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress') - ->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(13)); - $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock)); - $this->helperMock->expects($this->once()) - ->method('getIsMessagesAvailable') - ->with('', $this->quoteMock, $this->storeMock) - ->will($this->returnValue(false)); - - $this->service->setForQuote($cartId, $this->giftMessageMock); - } - - /** - * @expectedException \Magento\Framework\Exception\CouldNotSaveException - * @expectedExceptionMessage Could not add gift message to shopping cart - */ - public function testSetMessageCouldNotAddGiftMessageException() - { - $cartId = 665; - - $this->quoteRepositoryMock->expects($this->once()) - ->method('getActive') - ->with($cartId) - ->will($this->returnValue($this->quoteMock)); - $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1)); - $this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false)); - $this->quoteMock->expects($this->once()) - ->method('getBillingAddress') - ->will($this->returnValue($this->billingAddressMock)); - $this->billingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(12)); - $this->quoteMock->expects($this->once()) - ->method('getShippingAddress') - ->will($this->returnValue($this->shippingAddressMock)); - $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(13)); - $this->storeManagerMock->expects($this->once())->method('getStore')->will($this->returnValue($this->storeMock)); - $this->helperMock->expects($this->once()) - ->method('getIsMessagesAvailable') - ->with('', $this->quoteMock, $this->storeMock) - ->will($this->returnValue(true)); - $this->giftMessageMock->expects($this->once())->method('getSender')->will($this->returnValue('sender')); - $this->giftMessageMock->expects($this->once())->method('getRecipient')->will($this->returnValue('recipient')); - $this->giftMessageMock->expects($this->once())->method('getMessage')->will($this->returnValue('Message')); - $message['quote'][null] = - [ - 'from' => 'sender', - 'to' => 'recipient', - 'message' => 'Message', - ]; - $exception = - new \Magento\Framework\Exception\CouldNotSaveException('Could not add gift message to shopping cart'); - $this->giftMessageManagerMock->expects($this->once()) - ->method('add') - ->with($message, $this->quoteMock) - ->will($this->throwException($exception)); - - $this->service->setForQuote($cartId, $this->giftMessageMock); - } -} diff --git a/dev/tests/unit/testsuite/Magento/GoogleShopping/Model/ObserverTest.php b/dev/tests/unit/testsuite/Magento/GoogleShopping/Model/ObserverTest.php index 930c52facbf964cb51021e13ba693a051e2160c4..3ce39e7517b55d79fd0d7e074a3a862550be10b8 100644 --- a/dev/tests/unit/testsuite/Magento/GoogleShopping/Model/ObserverTest.php +++ b/dev/tests/unit/testsuite/Magento/GoogleShopping/Model/ObserverTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\GoogleShopping\Model; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; diff --git a/dev/tests/unit/testsuite/Magento/GroupedProduct/Model/Product/Type/GroupedTest.php b/dev/tests/unit/testsuite/Magento/GroupedProduct/Model/Product/Type/GroupedTest.php index 486805b85499162d34c1596e3b2b5a2618c72c46..5e4f8bbeffa32d7e834e3c05abe048e1b7f89576 100644 --- a/dev/tests/unit/testsuite/Magento/GroupedProduct/Model/Product/Type/GroupedTest.php +++ b/dev/tests/unit/testsuite/Magento/GroupedProduct/Model/Product/Type/GroupedTest.php @@ -284,6 +284,9 @@ class GroupedTest extends \PHPUnit_Framework_TestCase ]; } + /** + * @SuppressWarnings(PHPMD.UnusedLocalVariable) + */ public function testGetChildrenMsrpWhenNoChildrenWithMsrp() { $key = '_cache_instance_associated_products'; diff --git a/dev/tests/unit/testsuite/Magento/Indexer/Model/Processor/InvalidateCacheTest.php b/dev/tests/unit/testsuite/Magento/Indexer/Model/Processor/InvalidateCacheTest.php index cdbd873935a3a7a8bff2d348200815516c90d29d..03c205112f2b71d490a98664e9765b583bacca57 100644 --- a/dev/tests/unit/testsuite/Magento/Indexer/Model/Processor/InvalidateCacheTest.php +++ b/dev/tests/unit/testsuite/Magento/Indexer/Model/Processor/InvalidateCacheTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Indexer\Model\Processor; class InvalidateCacheTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/DeleteTest.php b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/DeleteTest.php index 8c8193f3422c4756658d7e776a6d4f7b946fb2eb..c21cdcf35af3e7e5e94c99dd8eefc88e2fcbf7c8 100644 --- a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/DeleteTest.php +++ b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/DeleteTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Integration\Controller\Adminhtml\Integration; use Magento\Integration\Block\Adminhtml\Integration\Edit\Tab\Info; diff --git a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/EditTest.php b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/EditTest.php index 6a9471ebc758f0adaa4a18786aade1501bea73cc..f4d5d880d82cf653fc7168ba8c71f9a10f8ac12c 100644 --- a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/EditTest.php +++ b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/EditTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Integration\Controller\Adminhtml\Integration; use Magento\Integration\Block\Adminhtml\Integration\Edit\Tab\Info; diff --git a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/NewActionTest.php b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/NewActionTest.php index b988a9ce154d2dc150a3487e4ecc28ea855c9e49..1c734a594f765a57e9716ee87cdbfb1a93726bc2 100644 --- a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/NewActionTest.php +++ b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/NewActionTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Integration\Controller\Adminhtml\Integration; class NewActionTest extends \Magento\Integration\Controller\Adminhtml\IntegrationTest diff --git a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/PermissionsDialogTest.php b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/PermissionsDialogTest.php index 9854d3bc6d28bd63635afd599cb0e6818b6b2820..38bbda5638eec13073d0faca9c8916157e3c17eb 100644 --- a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/PermissionsDialogTest.php +++ b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/PermissionsDialogTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Integration\Controller\Adminhtml\Integration; use Magento\Framework\View\Layout\Element as LayoutElement; diff --git a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/SaveTest.php b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/SaveTest.php index 32e8b0f5450dddcfc800c40d4b432fb5462b18ea..f737bddb816ca2ae77ae3e40d4100706ed8c3742 100644 --- a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/SaveTest.php +++ b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/SaveTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Integration\Controller\Adminhtml\Integration; use Magento\Integration\Block\Adminhtml\Integration\Edit\Tab\Info; diff --git a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/TokensDialogTest.php b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/TokensDialogTest.php index 2fd35e1e5925ff2e7fbf9e28bd97b8cf36e08430..1153951fb30b523de4a25bdd5047a7bf32a8fadb 100644 --- a/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/TokensDialogTest.php +++ b/dev/tests/unit/testsuite/Magento/Integration/Controller/Adminhtml/Integration/TokensDialogTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Integration\Controller\Adminhtml\Integration; diff --git a/dev/tests/unit/testsuite/Magento/Integration/Oauth/OauthTest.php b/dev/tests/unit/testsuite/Magento/Integration/Oauth/OauthTest.php index 82de98bfa27d44d2ad33ac4520c8d1b31a0c5b47..24785d1098a71fe9ed63b514d5dee3aa920c0bb9 100644 --- a/dev/tests/unit/testsuite/Magento/Integration/Oauth/OauthTest.php +++ b/dev/tests/unit/testsuite/Magento/Integration/Oauth/OauthTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Integration\Oauth; /** diff --git a/dev/tests/unit/testsuite/Magento/Integration/Service/V1/AdminTokenServiceTest.php b/dev/tests/unit/testsuite/Magento/Integration/Service/V1/AdminTokenServiceTest.php index d05b834df31109b51546fbc1a75442693a7737ec..322c4fa49c8320183f8b92188aa1315fcc87d876 100644 --- a/dev/tests/unit/testsuite/Magento/Integration/Service/V1/AdminTokenServiceTest.php +++ b/dev/tests/unit/testsuite/Magento/Integration/Service/V1/AdminTokenServiceTest.php @@ -6,6 +6,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Integration\Service\V1; use Magento\Integration\Model\Integration; diff --git a/dev/tests/unit/testsuite/Magento/Msrp/Helper/DataTest.php b/dev/tests/unit/testsuite/Magento/Msrp/Helper/DataTest.php index 3100a5bbca24484022afc1c05a3f5a25b99d1623..c7a073466ed0cee9073852f2f22c320e026f6c5b 100644 --- a/dev/tests/unit/testsuite/Magento/Msrp/Helper/DataTest.php +++ b/dev/tests/unit/testsuite/Magento/Msrp/Helper/DataTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Msrp\Helper; diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Address/SelectTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Address/SelectTest.php index 4f06e8d537f5e280b8a3602ca15d04783d91af47..a9f6fb059d287b7e676a61bf2e11d3e7cb414f5b 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Address/SelectTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Address/SelectTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Block\Checkout\Address; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php index 5379e44a2f214a21e9d257edca0be9cb937e509e..6e27ebf3ad9917b963fdc77dba25ccc974bc7c6d 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Block\Checkout; use Magento\Quote\Model\Quote\Address; diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Payment/InfoTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Payment/InfoTest.php index e3cf18debc0ee4239fc0fe75354e13363fb3be40..83cc63d851dcdf959e5a06e85e305febbf9094d2 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Payment/InfoTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/Payment/InfoTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Block\Checkout\Payment; class InfoTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/ShippingTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/ShippingTest.php index eefb8443f2dc65697cf66b1758433e57cfba91f4..931c92190cb8d621371c405e7f4c3cdbc053919c 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/ShippingTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/ShippingTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Block\Checkout; use Magento\Framework\Pricing\PriceCurrencyInterface; diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/StateTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/StateTest.php index 0c407b9b6a5346f397cf52034fa2740675fcd066..d07fcdd7fecfb9caaafe4e1f489ed0153a4c8550 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/StateTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/StateTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Block\Checkout; class StateTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/SuccessTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/SuccessTest.php index b28feaab72584a1e42daea63dcac17d26e322ed4..411eaaa51d40aabd62361670a293902ec914f7df 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/SuccessTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Block/Checkout/SuccessTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Block\Checkout; class SuccessTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditAddressTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditAddressTest.php index 618ccb352cde31d3fbe2abdd05dc270ee05c8d83..bbe3cfe2425740431f05c1695e4d24964969420f 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditAddressTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditAddressTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Controller\Checkout\Address; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditBillingTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditBillingTest.php index f66930101e89a652bee4230d6ac90416a4bcee4a..c178364067e7122e6a4dfa029773ca08dedfd714 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditBillingTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditBillingTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Controller\Checkout\Address; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditShippingTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditShippingTest.php index f1430495082550a6251de47ed9e1a4a6e26a1ecc..15dfbd50095bd6ae8213cd65c5deb8eb76e3f9b1 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditShippingTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/EditShippingTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Controller\Checkout\Address; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/NewBillingTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/NewBillingTest.php index cbd350b1c34b6bb5eb8aa00cfcb031d4af36346a..4ea11e167fad8340bd90d770789314811eace7c7 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/NewBillingTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/NewBillingTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Controller\Checkout\Address; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/NewShippingTest.php b/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/NewShippingTest.php index e860f2c7f25c46a764e590bfbb044f737084fb52..a03519add7ece1f993e182cfb586ba7ec43779c6 100644 --- a/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/NewShippingTest.php +++ b/dev/tests/unit/testsuite/Magento/Multishipping/Controller/Checkout/Address/NewShippingTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Multishipping\Controller\Checkout\Address; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Newsletter/Controller/Manage/SaveTest.php b/dev/tests/unit/testsuite/Magento/Newsletter/Controller/Manage/SaveTest.php index 94d6344cc75021cd3d58cf914e5d4f26b46d07dd..124efe1c353af5af3434cd21a6c271a583f3cd79 100644 --- a/dev/tests/unit/testsuite/Magento/Newsletter/Controller/Manage/SaveTest.php +++ b/dev/tests/unit/testsuite/Magento/Newsletter/Controller/Manage/SaveTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Newsletter\Controller\Manage; use Magento\Framework\Exception\NoSuchEntityException; diff --git a/dev/tests/unit/testsuite/Magento/PageCache/Controller/Block/EsiTest.php b/dev/tests/unit/testsuite/Magento/PageCache/Controller/Block/EsiTest.php index c07eee4e5a6b19083832f63324172a298f5655a7..fb490f17e4b460575b5ac011879918b801bb32ca 100644 --- a/dev/tests/unit/testsuite/Magento/PageCache/Controller/Block/EsiTest.php +++ b/dev/tests/unit/testsuite/Magento/PageCache/Controller/Block/EsiTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\PageCache\Controller\Block; class EsiTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/PageCache/Controller/Block/RenderTest.php b/dev/tests/unit/testsuite/Magento/PageCache/Controller/Block/RenderTest.php index ebe45e119033dddaae96f8a915d6db235c1a289a..62071ae2df7394d402986ab91528fba0de579697 100644 --- a/dev/tests/unit/testsuite/Magento/PageCache/Controller/Block/RenderTest.php +++ b/dev/tests/unit/testsuite/Magento/PageCache/Controller/Block/RenderTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\PageCache\Controller\Block; class RenderTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/PageCache/Model/Controller/Result/BuiltinPluginTest.php b/dev/tests/unit/testsuite/Magento/PageCache/Model/Controller/Result/BuiltinPluginTest.php index 622c154601a2b8515d3c5cf2d9b6bccbfecc26f1..f1d4b5ce27727172b946fa46c1dd3addc9f2f468 100644 --- a/dev/tests/unit/testsuite/Magento/PageCache/Model/Controller/Result/BuiltinPluginTest.php +++ b/dev/tests/unit/testsuite/Magento/PageCache/Model/Controller/Result/BuiltinPluginTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\PageCache\Model\Controller\Result; class BuiltinPluginTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/FlushAllCacheTest.php b/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/FlushAllCacheTest.php index 7a5e532dc98e0cb2cfa05fbf6a435741386d4214..b5c7e0acd2ac1eda176b8faf8c6da69fd9d548a8 100644 --- a/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/FlushAllCacheTest.php +++ b/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/FlushAllCacheTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\PageCache\Model\Observer; class FlushAllCacheTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/FlushCacheByTagsTest.php b/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/FlushCacheByTagsTest.php index e3a5f10919a5fa605145508d9c39195e7e479108..ebd5665cee7371e32f9fc224dce3dd7d52dc5eab 100644 --- a/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/FlushCacheByTagsTest.php +++ b/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/FlushCacheByTagsTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\PageCache\Model\Observer; class FlushCacheByTagsTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/ProcessLayoutRenderElementTest.php b/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/ProcessLayoutRenderElementTest.php index 06959e3421356034fc22a08e7bc38d8f8286a680..b307760aad42a7918956541e9ee45c985529ae1c 100644 --- a/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/ProcessLayoutRenderElementTest.php +++ b/dev/tests/unit/testsuite/Magento/PageCache/Model/Observer/ProcessLayoutRenderElementTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\PageCache\Model\Observer; class ProcessLayoutRenderElementTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Payment/Block/FormTest.php b/dev/tests/unit/testsuite/Magento/Payment/Block/FormTest.php index c8039c60332dbcb27991bd8e64a2b7a79476ced7..d523a8443e54922e69afae43d97e9ce163ec389c 100644 --- a/dev/tests/unit/testsuite/Magento/Payment/Block/FormTest.php +++ b/dev/tests/unit/testsuite/Magento/Payment/Block/FormTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Payment\Block; use Magento\Framework\Object; diff --git a/dev/tests/unit/testsuite/Magento/Payment/Block/Info/SubstitutionTest.php b/dev/tests/unit/testsuite/Magento/Payment/Block/Info/SubstitutionTest.php index 8322174e45ef960f60f95c6e42ff3ed4559f3a4b..82ad3a3460298fb8e902b4c6cd435284ca41ca2f 100644 --- a/dev/tests/unit/testsuite/Magento/Payment/Block/Info/SubstitutionTest.php +++ b/dev/tests/unit/testsuite/Magento/Payment/Block/Info/SubstitutionTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Payment\Block\Info; class SubstitutionTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Payment/Model/Config/Source/AllmethodsTest.php b/dev/tests/unit/testsuite/Magento/Payment/Model/Config/Source/AllmethodsTest.php index 2cd8f13ab78d8c503f461ad4e4f26570bfd41bce..dfcc3b59ee82cdd74f245b8de4c3c76967d10512 100644 --- a/dev/tests/unit/testsuite/Magento/Payment/Model/Config/Source/AllmethodsTest.php +++ b/dev/tests/unit/testsuite/Magento/Payment/Model/Config/Source/AllmethodsTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Payment\Model\Config\Source; class AllmethodsTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Payment/Model/ConfigTest.php b/dev/tests/unit/testsuite/Magento/Payment/Model/ConfigTest.php index 4bcd1783e086f84b9e62f2a782c65cfb8c672753..d62c4c2b960f6854c0c5861bc54b15b155e548b6 100644 --- a/dev/tests/unit/testsuite/Magento/Payment/Model/ConfigTest.php +++ b/dev/tests/unit/testsuite/Magento/Payment/Model/ConfigTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Payment\Model; use Magento\Store\Model\ScopeInterface; diff --git a/dev/tests/unit/testsuite/Magento/Payment/Model/Method/FreeTest.php b/dev/tests/unit/testsuite/Magento/Payment/Model/Method/FreeTest.php index f3d5527baad36d2fe1f2056f5427123e1ec01e99..327b4721cada578857424f16efcf564bc73336f7 100644 --- a/dev/tests/unit/testsuite/Magento/Payment/Model/Method/FreeTest.php +++ b/dev/tests/unit/testsuite/Magento/Payment/Model/Method/FreeTest.php @@ -18,17 +18,25 @@ class FreeTest extends \PHPUnit_Framework_TestCase protected function setUp() { - $eventManager = $this->getMock('Magento\Framework\Event\ManagerInterface', [], [], '', false); $paymentData = $this->getMock('Magento\Payment\Helper\Data', [], [], '', false); $this->scopeConfig = $this->getMock('Magento\Framework\App\Config\ScopeConfigInterface', [], [], '', false); - $logger = $this->getMock('Psr\Log\LoggerInterface'); $this->currencyPrice = $this->getMockBuilder('Magento\Framework\Pricing\PriceCurrencyInterface')->getMock(); + $context = $this->getMock('\Magento\Framework\Model\Context', ['getEventDispatcher'], [], '', false); + $eventManagerMock = $this->getMock('\Magento\Framework\Event\ManagerInterface'); + $context->expects($this->any())->method('getEventDispatcher')->willReturn($eventManagerMock); + + $registry = $this->getMock('\Magento\Framework\Registry', [], [], '', false); + $metadataService = $this->getMock('\Magento\Framework\Api\MetadataServiceInterface'); + $customAttributeBuilder = $this->getMock('\Magento\Framework\Api\AttributeDataBuilder', [], [], '', false); + $this->methodFree = new \Magento\Payment\Model\Method\Free( - $eventManager, + $context, + $registry, + $metadataService, + $customAttributeBuilder, $paymentData, $this->scopeConfig, - $logger, $this->currencyPrice ); } diff --git a/dev/tests/unit/testsuite/Magento/Payment/Model/MethodListTest.php b/dev/tests/unit/testsuite/Magento/Payment/Model/MethodListTest.php index d559b415c790889b484c66377f16e0306a29cf57..7442764bd5c7faeafb91a1ed9cb527e376f5dad0 100644 --- a/dev/tests/unit/testsuite/Magento/Payment/Model/MethodListTest.php +++ b/dev/tests/unit/testsuite/Magento/Payment/Model/MethodListTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Payment\Model; class MethodListTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Persistent/Block/Header/AdditionalTest.php b/dev/tests/unit/testsuite/Magento/Persistent/Block/Header/AdditionalTest.php index 6666c8c0938d6561df24bdf47c5fa9068eb7afc5..2b7241c10ef7bb09d84f5f85a3454156b8009bc5 100644 --- a/dev/tests/unit/testsuite/Magento/Persistent/Block/Header/AdditionalTest.php +++ b/dev/tests/unit/testsuite/Magento/Persistent/Block/Header/AdditionalTest.php @@ -7,6 +7,7 @@ namespace Magento\Persistent\Block\Header; /** * Class AdditionalTest + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class AdditionalTest extends \PHPUnit_Framework_TestCase { @@ -86,6 +87,7 @@ class AdditionalTest extends \PHPUnit_Framework_TestCase * Set up * * @return void + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function setUp() { diff --git a/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/ApplyBlockPersistentDataTest.php b/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/ApplyBlockPersistentDataTest.php index 2284e94e455bddfbda4a9d40c95993f177d9c948..246c8a83cbbded6b27d6fd6d24bcde5a3c7cc743 100644 --- a/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/ApplyBlockPersistentDataTest.php +++ b/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/ApplyBlockPersistentDataTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Persistent\Model\Observer; class ApplyBlockPersistentDataTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/RemovePersistentCookieTest.php b/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/RemovePersistentCookieTest.php index 1f1d3f29960edb6dadbe2224d0b54988a5178ed2..127be1b927955424ebb7b2fd09c5c4cec195ddc0 100644 --- a/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/RemovePersistentCookieTest.php +++ b/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/RemovePersistentCookieTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Persistent\Model\Observer; class RemovePersistentCookieTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/UpdateCustomerCookiesTest.php b/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/UpdateCustomerCookiesTest.php index e2b4b31f80147d8bab44a1b5d33fb56f8259d529..8602aef31ded170bce40f2b97c873532d2e1ae55 100644 --- a/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/UpdateCustomerCookiesTest.php +++ b/dev/tests/unit/testsuite/Magento/Persistent/Model/Observer/UpdateCustomerCookiesTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Persistent\Model\Observer; /** diff --git a/dev/tests/unit/testsuite/Magento/Persistent/Model/QuoteManagerTest.php b/dev/tests/unit/testsuite/Magento/Persistent/Model/QuoteManagerTest.php index e828f3c8d54934a699137f02aaf213fc1b3ae4f5..160b1451b5952424a21940c204f18680e8be2f2b 100644 --- a/dev/tests/unit/testsuite/Magento/Persistent/Model/QuoteManagerTest.php +++ b/dev/tests/unit/testsuite/Magento/Persistent/Model/QuoteManagerTest.php @@ -5,6 +5,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Persistent\Model; class QuoteManagerTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/BillingAddressManagementTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/BillingAddressManagementTest.php new file mode 100644 index 0000000000000000000000000000000000000000..309cd33a4a344163587d458a234656941ea3f808 --- /dev/null +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/BillingAddressManagementTest.php @@ -0,0 +1,121 @@ +<?php +/** + * + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ + +namespace Magento\Quote\Model; + +class BillingAddressManagementTest extends \PHPUnit_Framework_TestCase +{ + /** + * @var BillingAddressManagement + */ + protected $model; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $quoteRepositoryMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $validatorMock; + + protected function setUp() + { + $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); + $this->validatorMock = $this->getMock('\Magento\Quote\Model\QuoteAddressValidator', [], [], '', false); + $logger = $this->getMock('\Psr\Log\LoggerInterface'); + $this->model = new BillingAddressManagement($this->quoteRepositoryMock, $this->validatorMock, $logger); + } + + public function testGetAddress() + { + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $this->quoteRepositoryMock->expects($this->once())->method('getActive') + ->with('cartId')->will($this->returnValue($quoteMock)); + + $addressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', [], [], '', false); + $quoteMock->expects($this->any())->method('getBillingAddress')->will($this->returnValue($addressMock)); + + $this->assertEquals($addressMock, $this->model->get('cartId')); + } + + + /** + * @expectedException \Magento\Framework\Exception\NoSuchEntityException + * @expectedExceptionMessage error123 + */ + public function testSetAddressValidationFailed() + { + $address = $this->getMock('\Magento\Quote\Api\Data\AddressInterface'); + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive') + ->with('cartId') + ->will($this->returnValue($quoteMock)); + + $this->validatorMock->expects($this->once())->method('validate') + ->will($this->throwException(new \Magento\Framework\Exception\NoSuchEntityException('error123'))); + + $this->model->assign('cartId', $address); + } + + public function testSetAddress() + { + $address = $this->getMock('Magento\Quote\Model\Quote\Address', [], [], '', false, false); + + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive') + ->with('cartId') + ->will($this->returnValue($quoteMock)); + + $this->validatorMock->expects($this->once())->method('validate') + ->with($address) + ->will($this->returnValue(true)); + + $quoteMock->expects($this->once())->method('setBillingAddress')->with($address); + $quoteMock->expects($this->once())->method('setDataChanges')->with(true); + $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock); + $addressId = 1; + $billingAddressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', [], [], '', false); + $billingAddressMock->expects($this->once())->method('getId')->will($this->returnValue($addressId)); + $quoteMock->expects($this->once())->method('getBillingAddress') + ->will($this->returnValue($billingAddressMock)); + + $this->assertEquals($addressId, $this->model->assign('cartId', $address)); + } + + /** + * @expectedException \Magento\Framework\Exception\InputException + * @expectedExceptionMessage Unable to save address. Please, check input data. + */ + public function testSetAddressWithInabilityToSaveQuote() + { + $address = $this->getMock('Magento\Quote\Model\Quote\Address', [], [], '', false, false); + + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive') + ->with('cartId') + ->will($this->returnValue($quoteMock)); + + $this->validatorMock->expects($this->once())->method('validate') + ->with($address) + ->will($this->returnValue(true)); + + $quoteMock->expects($this->once())->method('setBillingAddress')->with($address); + $quoteMock->expects($this->once())->method('setDataChanges')->with(true); + $this->quoteRepositoryMock->expects($this->once()) + ->method('save') + ->with($quoteMock) + ->willThrowException( + new \Exception('Some DB Error') + ); + $this->model->assign('cartId', $address); + } +} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Model/Cart/Access/WritePluginTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Cart/Access/CartManagementPluginTest.php similarity index 81% rename from dev/tests/unit/testsuite/Magento/Checkout/Model/Cart/Access/WritePluginTest.php rename to dev/tests/unit/testsuite/Magento/Quote/Model/Cart/Access/CartManagementPluginTest.php index 903cd6e15d433c6ca7f8507a9799a8f8d1ae1adc..bad7fdd3829213d01361017b1ab7a6b7e079ffcf 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Model/Cart/Access/WritePluginTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Cart/Access/CartManagementPluginTest.php @@ -4,12 +4,12 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Model\Cart\Access; +namespace Magento\Quote\Model\Cart\Access; -class WritePluginTest extends \PHPUnit_Framework_TestCase +class CartManagementPluginTest extends \PHPUnit_Framework_TestCase { /** - * @var \Magento\Checkout\Model\Cart\Access\WritePlugin + * @var \Magento\Quote\Model\Cart\Access\CartManagementPlugin */ protected $model; @@ -26,8 +26,8 @@ class WritePluginTest extends \PHPUnit_Framework_TestCase protected function setUp() { $this->userContextMock = $this->getMock('Magento\Authorization\Model\UserContextInterface'); - $this->subjectMock = $this->getMock('\Magento\Checkout\Service\V1\Cart\WriteServiceInterface'); - $this->model = new WritePlugin($this->userContextMock); + $this->subjectMock = $this->getMock('\Magento\Quote\Api\CartManagementInterface'); + $this->model = new CartManagementPlugin($this->userContextMock); } /** @@ -37,7 +37,7 @@ class WritePluginTest extends \PHPUnit_Framework_TestCase public function testBeforeCreateSuccess($userType) { $this->userContextMock->expects($this->once())->method('getUserType')->will($this->returnValue($userType)); - $this->model->beforeAssignCustomer($this->subjectMock, 1, 1); + $this->model->beforeAssignCustomer($this->subjectMock, 1, 1, 1); } public function successTypeDataProvider() @@ -56,6 +56,6 @@ class WritePluginTest extends \PHPUnit_Framework_TestCase { $this->userContextMock->expects($this->once())->method('getUserType') ->will($this->returnValue(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_CUSTOMER)); - $this->model->beforeAssignCustomer($this->subjectMock, 1, 1); + $this->model->beforeAssignCustomer($this->subjectMock, 1, 1, 1); } } diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Model/Cart/Access/ReadPluginTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Cart/Access/CartRepositoryPluginTest.php similarity index 77% rename from dev/tests/unit/testsuite/Magento/Checkout/Model/Cart/Access/ReadPluginTest.php rename to dev/tests/unit/testsuite/Magento/Quote/Model/Cart/Access/CartRepositoryPluginTest.php index 30f9984145a353181804cc71b4cee921dade10c2..1e171673ef5d05e8de3e855a455a78a99a6ad3ed 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Model/Cart/Access/ReadPluginTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Cart/Access/CartRepositoryPluginTest.php @@ -4,12 +4,12 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Model\Cart\Access; +namespace Magento\Quote\Model\Cart\Access; -class ReadPluginTest extends \PHPUnit_Framework_TestCase +class CartRepositoryPluginTest extends \PHPUnit_Framework_TestCase { /** - * @var \Magento\Checkout\Model\Cart\Access\ReadPlugin + * @var \Magento\Quote\Model\Cart\Access\CartRepositoryPlugin */ protected $model; @@ -26,18 +26,18 @@ class ReadPluginTest extends \PHPUnit_Framework_TestCase protected function setUp() { $this->userContextMock = $this->getMock('Magento\Authorization\Model\UserContextInterface'); - $this->subjectMock = $this->getMock('\Magento\Checkout\Service\V1\Cart\ReadServiceInterface'); - $this->model = new ReadPlugin($this->userContextMock); + $this->subjectMock = $this->getMock('\Magento\Quote\Api\CartRepositoryInterface'); + $this->model = new CartRepositoryPlugin($this->userContextMock); } /** * @param int $userType * @dataProvider successTypeDataProvider */ - public function testBeforeGetCartSuccess($userType) + public function testBeforeGetSuccess($userType) { $this->userContextMock->expects($this->once())->method('getUserType')->will($this->returnValue($userType)); - $this->model->beforeGetCart($this->subjectMock, 1); + $this->model->beforeGet($this->subjectMock, 1); } /** @@ -48,7 +48,7 @@ class ReadPluginTest extends \PHPUnit_Framework_TestCase { $this->userContextMock->expects($this->once())->method('getUserType') ->will($this->returnValue(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_CUSTOMER)); - $this->model->beforeGetCart($this->subjectMock, 1); + $this->model->beforeGet($this->subjectMock, 1); } public function successTypeDataProvider() @@ -63,10 +63,10 @@ class ReadPluginTest extends \PHPUnit_Framework_TestCase * @param int $userType * @dataProvider successTypeDataProvider */ - public function testBeforeGetCartListSuccess($userType) + public function testBeforeGetCartSuccess($userType) { $this->userContextMock->expects($this->once())->method('getUserType')->will($this->returnValue($userType)); - $this->model->beforeGetCartList( + $this->model->beforeGetList( $this->subjectMock, $this->getMock('\Magento\Framework\Api\SearchCriteria', [], [], '', false) ); @@ -76,11 +76,11 @@ class ReadPluginTest extends \PHPUnit_Framework_TestCase * @expectedException \Magento\Framework\Exception\AuthorizationException * @expectedExceptionMessage Access denied */ - public function testBeforeGetCartListDenied() + public function testBeforeGetListDenied() { $this->userContextMock->expects($this->once())->method('getUserType') ->will($this->returnValue(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_CUSTOMER)); - $this->model->beforeGetCartList( + $this->model->beforeGetList( $this->subjectMock, $this->getMock('\Magento\Framework\Api\SearchCriteria', [], [], '', false) ); diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/Cart/CartTotalRepositoryTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Cart/CartTotalRepositoryTest.php new file mode 100644 index 0000000000000000000000000000000000000000..a7fb88418d9794a9c4bc13a15f10b8191070d436 --- /dev/null +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Cart/CartTotalRepositoryTest.php @@ -0,0 +1,68 @@ +<?php +/** + * + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Model\Cart; + +class CartTotalRepositoryTest extends \PHPUnit_Framework_TestCase +{ + /** + * @var \Magento\Quote\Model\Cart\CartTotalRepository + */ + protected $model; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + private $quoteRepositoryMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + private $quoteMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + private $totalsBuilderMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $addressMock; + + public function setUp() + { + $this->totalsBuilderMock = $this->getMock( + 'Magento\Quote\Api\Data\TotalsDataBuilder', + ['populateWithArray', 'setItems', 'create'], + [], + '', + false + ); + $this->quoteMock = $this->getMock('Magento\Quote\Model\Quote', [], [], '', false); + $this->quoteRepositoryMock = $this->getMock('Magento\Quote\Model\QuoteRepository', [], [], '', false); + $this->addressMock = $this->getMock('Magento\Quote\Model\Quote\Address', [], [], '', false); + + $this->model = new CartTotalRepository( + $this->totalsBuilderMock, + $this->quoteRepositoryMock + ); + } + + public function testGetTotals() + { + $cartId = 12; + $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId) + ->will($this->returnValue($this->quoteMock)); + $this->quoteMock->expects($this->once())->method('getShippingAddress')->willReturn($this->addressMock); + $this->addressMock->expects($this->once())->method('getData')->willReturn(['addressData']); + $this->quoteMock->expects($this->once())->method('getData')->willReturn(['quoteData']); + + $item = $this->getMock('Magento\Quote\Model\Quote\Item', [], [], '', false); + $this->quoteMock->expects($this->once())->method('getAllItems')->will($this->returnValue([$item])); + $this->model->get($cartId); + } +} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/Cart/ShippingMethodConverterTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Cart/ShippingMethodConverterTest.php similarity index 92% rename from dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/Cart/ShippingMethodConverterTest.php rename to dev/tests/unit/testsuite/Magento/Quote/Model/Cart/ShippingMethodConverterTest.php index 64dcef35521a1eb39858c5213370440b4557e9fa..6bd008cd8e640a757c020c690f8ffca666feb4f5 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Data/Cart/ShippingMethodConverterTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Cart/ShippingMethodConverterTest.php @@ -5,7 +5,9 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Data\Cart; +// @codingStandardsIgnoreFile + +namespace Magento\Quote\Model\Cart; class ShippingMethodConverterTest extends \PHPUnit_Framework_TestCase { @@ -48,7 +50,7 @@ class ShippingMethodConverterTest extends \PHPUnit_Framework_TestCase { $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); $this->builderMock = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\ShippingMethodBuilder', + '\Magento\Quote\Api\Data\ShippingMethodDataBuilder', ['populateWithArray', 'create'], [], '', @@ -57,7 +59,7 @@ class ShippingMethodConverterTest extends \PHPUnit_Framework_TestCase $this->storeManagerMock = $this->getMock('\Magento\Store\Model\StoreManagerInterface'); $this->currencyMock = $this->getMock('\Magento\Directory\Model\Currency', [], [], '', false); $this->shippingMethodMock = - $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\ShippingMethod', [], [], '', false); + $this->getMock('\Magento\Quote\Api\Data\ShippingMethodInterface'); $this->rateModelMock = $this->getMock('\Magento\Quote\Model\Quote\Address\Rate', [ 'getPrice', @@ -73,7 +75,7 @@ class ShippingMethodConverterTest extends \PHPUnit_Framework_TestCase $this->storeMock = $this->getMock('\Magento\Store\Model\Store', [], [], '', false); $this->converter = $objectManager->getObject( - 'Magento\Checkout\Service\V1\Data\Cart\ShippingMethodConverter', + 'Magento\Quote\Model\Cart\ShippingMethodConverter', [ 'builder' => $this->builderMock, 'storeManager' => $this->storeManagerMock, diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/CouponManagementTest.php similarity index 84% rename from dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/WriteServiceTest.php rename to dev/tests/unit/testsuite/Magento/Quote/Model/CouponManagementTest.php index 7c4d64ee12cacda6ddb2e6f69c8d456a2a68fa6c..57435806a4f2514df20f4a1d389df128e247275f 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Coupon/WriteServiceTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/CouponManagementTest.php @@ -5,14 +5,16 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Coupon; +// @codingStandardsIgnoreFile -class WriteServiceTest extends \PHPUnit_Framework_TestCase +namespace Magento\Quote\Model; + +class CouponManagementTest extends \PHPUnit_Framework_TestCase { /** - * @var WriteService + * @var CouponManagement */ - protected $service; + protected $couponManagement; /** * @var \PHPUnit_Framework_MockObject_MockObject @@ -24,21 +26,11 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase */ protected $quoteMock; - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $couponBuilderMock; - /** * @var \PHPUnit_Framework_MockObject_MockObject */ protected $storeMock; - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $couponCodeDataMock; - /** * @var \PHPUnit_Framework_MockObject_MockObject */ @@ -46,10 +38,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase protected function setUp() { - $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->couponBuilderMock = - $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\CouponBuilder', [], [], '', false); $this->storeMock = $this->getMock('\Magento\Store\Model\Store', [], [], '', false); $this->quoteMock = $this->getMock( '\Magento\Quote\Model\Quote', @@ -66,7 +55,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase '', false ); - $this->couponCodeDataMock = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\Coupon', [], [], '', false); $this->quoteAddressMock = $this->getMock( '\Magento\Quote\Model\Quote\Address', [ @@ -76,15 +64,28 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase [], '', false); - $this->service = $objectManager->getObject( - 'Magento\Checkout\Service\V1\Coupon\WriteService', - [ - 'quoteRepository' => $this->quoteRepositoryMock, - 'couponBuilder' => $this->couponBuilderMock, - ] + $this->couponManagement = new CouponManagement( + $this->quoteRepositoryMock ); } + public function testGetCoupon() + { + $cartId = 11; + $couponCode = 'test_coupon_code'; + + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', ['getCouponCode', '__wakeup'], [], '', false); + $quoteMock->expects($this->any())->method('getCouponCode')->will($this->returnValue($couponCode)); + + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive') + ->with($cartId) + ->will($this->returnValue($quoteMock)); + + + $this->assertEquals($couponCode, $this->couponManagement->get($cartId)); + } + /** * @expectedException \Magento\Framework\Exception\NoSuchEntityException * @expectedExceptionMessage Cart 33 doesn't contain products @@ -97,7 +98,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(0)); - $this->service->set($cartId, $this->couponCodeDataMock); + $this->couponManagement->set($cartId, 'coupon_code'); } /** @@ -115,8 +116,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->quoteMock->expects($this->once()) ->method('getShippingAddress')->will($this->returnValue($this->quoteAddressMock)); $this->quoteAddressMock->expects($this->once())->method('setCollectShippingRates')->with(true); - $this->couponCodeDataMock->expects($this->once()) - ->method('getCouponCode')->will($this->returnValue($couponCode)); $this->quoteMock->expects($this->once())->method('setCouponCode')->with($couponCode); $exceptionMessage = 'Could not apply coupon code'; $exception = new \Magento\Framework\Exception\CouldNotDeleteException($exceptionMessage); @@ -126,7 +125,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->with($this->quoteMock) ->willThrowException($exception); - $this->service->set($cartId, $this->couponCodeDataMock); + $this->couponManagement->set($cartId, $couponCode); } /** @@ -144,14 +143,12 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->quoteMock->expects($this->once()) ->method('getShippingAddress')->will($this->returnValue($this->quoteAddressMock)); $this->quoteAddressMock->expects($this->once())->method('setCollectShippingRates')->with(true); - $this->couponCodeDataMock->expects($this->once()) - ->method('getCouponCode')->will($this->returnValue($couponCode)); $this->quoteMock->expects($this->once())->method('setCouponCode')->with($couponCode); $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock)); $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); $this->quoteMock->expects($this->once())->method('getCouponCode')->will($this->returnValue('invalidCoupon')); - $this->service->set($cartId, $this->couponCodeDataMock); + $this->couponManagement->set($cartId, $couponCode); } public function testSet() @@ -165,14 +162,12 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->quoteMock->expects($this->once()) ->method('getShippingAddress')->will($this->returnValue($this->quoteAddressMock)); $this->quoteAddressMock->expects($this->once())->method('setCollectShippingRates')->with(true); - $this->couponCodeDataMock->expects($this->once()) - ->method('getCouponCode')->will($this->returnValue($couponCode)); $this->quoteMock->expects($this->once())->method('setCouponCode')->with($couponCode); $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock)); $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); $this->quoteMock->expects($this->once())->method('getCouponCode')->will($this->returnValue($couponCode)); - $this->assertTrue($this->service->set($cartId, $this->couponCodeDataMock)); + $this->assertTrue($this->couponManagement->set($cartId, $couponCode)); } /** @@ -188,7 +183,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(0)); $this->quoteMock->expects($this->never())->method('getShippingAddress'); - $this->service->delete($cartId); + $this->couponManagement->remove($cartId); } /** @@ -215,7 +210,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->with($this->quoteMock) ->willThrowException($exception); - $this->service->delete($cartId); + $this->couponManagement->remove($cartId); } /** @@ -238,7 +233,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); $this->quoteMock->expects($this->once())->method('getCouponCode')->will($this->returnValue('123_ABC')); - $this->service->delete($cartId); + $this->couponManagement->remove($cartId); } public function testDelete() @@ -257,6 +252,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); $this->quoteMock->expects($this->once())->method('getCouponCode')->will($this->returnValue('')); - $this->assertTrue($this->service->delete($cartId)); + $this->assertTrue($this->couponManagement->remove($cartId)); } } diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/Observer/Backend/CustomerQuoteTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Observer/Backend/CustomerQuoteTest.php index ac67c2867b42ee4c76d2d030014bd15c5efd7a8b..c1e59dbfd91ce85f9c1bea837717f40fa19583ce 100644 --- a/dev/tests/unit/testsuite/Magento/Quote/Model/Observer/Backend/CustomerQuoteTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Observer/Backend/CustomerQuoteTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Quote\Model\Observer\Backend; class CustomerQuoteTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php index a852304a03be3eb3cc6f8a62330a1891c33984d1..efdb5bfdb222557169ece9d4aea60df7363c4edb 100644 --- a/dev/tests/unit/testsuite/Magento/Quote/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Observer/Frontend/Quote/Address/CollectTotalsTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Quote\Model\Observer\Frontend\Quote\Address; /** @@ -75,6 +78,9 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase */ protected $groupInterfaceMock; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ protected function setUp() { $this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); @@ -191,6 +197,9 @@ class CollectTotalsTest extends \PHPUnit_Framework_TestCase $this->model->dispatch($this->observerMock); } + /** + * @SuppressWarnings(PHPMD.UnusedLocalVariable) + */ public function testDispatchWithCustomerCountryNotInEUAndNotLoggedCustomerInGroup() { $this->groupManagementMock->expects($this->once()) diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/PaymentMethodManagementTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/PaymentMethodManagementTest.php new file mode 100644 index 0000000000000000000000000000000000000000..3d6402af1149b5b98f8fd2bb98f13ffe35a5d8e4 --- /dev/null +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/PaymentMethodManagementTest.php @@ -0,0 +1,409 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Model; + +class PaymentMethodManagementTest extends \PHPUnit_Framework_TestCase +{ + /** + * @var \Magento\Quote\Model\PaymentMethodManagement + */ + protected $model; + + /** + * @var \Magento\TestFramework\Helper\ObjectManager + */ + protected $objectManager; + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $quoteRepositoryMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $methodListMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $zeroTotalMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $paymentMethodBuilder; + + protected function setUp() + { + $this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); + $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); + $this->methodListMock = $this->getMock('\Magento\Payment\Model\MethodList', [], [], '', false); + $this->zeroTotalMock = $this->getMock('\Magento\Payment\Model\Checks\ZeroTotal', [], [], '', false); + $this->paymentMethodBuilder = $this->getMock( + '\Magento\Quote\Api\Data\PaymentMethodDataBuilder', + [], + [], + '', + false + ); + + $this->model = $this->objectManager->getObject( + '\Magento\Quote\Model\PaymentMethodManagement', + [ + 'quoteRepository' => $this->quoteRepositoryMock, + 'methodList' => $this->methodListMock, + 'zeroTotalValidator' => $this->zeroTotalMock, + 'paymentMethodBuilder' => $this->paymentMethodBuilder, + ] + ); + } + + public function testGetPaymentIfPaymentMethodNotSet() + { + $cartId = 11; + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $paymentMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', [], [], '', false); + $quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock)); + $paymentMock->expects($this->once())->method('getId')->will($this->returnValue(null)); + + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive') + ->with($cartId) + ->will($this->returnValue($quoteMock)); + + $this->assertNull($this->model->get($cartId)); + } + + public function testGetPaymentSuccess() + { + $cartId = 11; + + $paymentMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', [], [], '', false); + $paymentMock->expects($this->once())->method('getId')->will($this->returnValue(1)); + + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $quoteMock->expects($this->once())->method('getPayment')->will($this->returnValue($paymentMock)); + + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive') + ->with($cartId) + ->will($this->returnValue($quoteMock)); + $this->assertEquals($paymentMock, $this->model->get($cartId)); + } + + public function testGetList() + { + $cartId = 10; + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive') + ->with($cartId) + ->will($this->returnValue($quoteMock)); + + $paymentMethod = $this->getMock('\Magento\Quote\Api\Data\PaymentMethodInterface'); + $this->methodListMock->expects($this->once()) + ->method('getAvailableMethods') + ->with($quoteMock) + ->will($this->returnValue([$paymentMethod])); + $this->assertEquals([$paymentMethod], $this->model->getList($cartId)); + } + + public function testSetVirtualProduct() + { + $cartId = 100; + $paymentId = 200; + $methodData = ['method' => 'data']; + $paymentMethod = 'checkmo'; + + $quoteMock = $this->getMock( + '\Magento\Quote\Model\Quote', + ['setTotalsCollectedFlag', 'getPayment', 'isVirtual', 'getBillingAddress', 'collectTotals', 'save'], + [], + '', + false + ); + $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)->willReturn($quoteMock); + + $methodMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', ['setChecks', 'getData'], [], '', false); + $methodMock->expects($this->once()) + ->method('setChecks') + ->with([ + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_CHECKOUT, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_COUNTRY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_CURRENCY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_ORDER_TOTAL_MIN_MAX, + ]) + ->willReturnSelf(); + $methodMock->expects($this->once())->method('getData')->willReturn($methodData); + + $paymentMock = $this->getMock( + '\Magento\Quote\Model\Quote\Payment', + ['importData', 'getMethod', 'getMethodInstance', 'getId'], + [], + '', + false + ); + $paymentMock->expects($this->once())->method('importData')->with($methodData)->willReturnSelf(); + $paymentMock->expects($this->once())->method('getMethod')->willReturn($paymentMethod); + + $billingAddressMock = $this->getMock( + '\Magento\Quote\Model\Quote\Address', + ['getCountryId', 'setPaymentMethod'], + [], + '', + false + ); + $billingAddressMock->expects($this->once())->method('getCountryId')->willReturn(100); + $billingAddressMock->expects($this->once()) + ->method('setPaymentMethod') + ->with($paymentMethod) + ->willReturnSelf(); + + $quoteMock->expects($this->exactly(2))->method('getPayment')->willReturn($paymentMock); + $quoteMock->expects($this->exactly(2))->method('isVirtual')->willReturn(true); + $quoteMock->expects($this->exactly(2))->method('getBillingAddress')->willReturn($billingAddressMock); + + $methodInstance = $this->getMock('\Magento\Payment\Model\Checks\PaymentMethodChecksInterface'); + $paymentMock->expects($this->once())->method('getMethodInstance')->willReturn($methodInstance); + + $this->zeroTotalMock->expects($this->once()) + ->method('isApplicable') + ->with($methodInstance, $quoteMock) + ->willReturn(true); + + $quoteMock->expects($this->once())->method('setTotalsCollectedFlag')->with(false)->willReturnSelf(); + $quoteMock->expects($this->once())->method('collectTotals')->willReturnSelf(); + $quoteMock->expects($this->once())->method('save')->willReturnSelf(); + + $paymentMock->expects($this->once())->method('getId')->willReturn($paymentId); + $this->assertEquals($paymentId, $this->model->set($cartId, $methodMock)); + } + + /** + * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException + * @expectedExceptionMessage Billing address is not set + */ + public function testSetVirtualProductThrowsExceptionIfBillingAddressNotSet() + { + $cartId = 100; + $methodData = ['method' => 'data']; + + $quoteMock = $this->getMock( + '\Magento\Quote\Model\Quote', + ['getPayment', 'isVirtual', 'getBillingAddress'], + [], + '', + false + ); + $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)->willReturn($quoteMock); + + $methodMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', ['setChecks', 'getData'], [], '', false); + $methodMock->expects($this->once()) + ->method('setChecks') + ->with([ + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_CHECKOUT, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_COUNTRY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_CURRENCY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_ORDER_TOTAL_MIN_MAX, + ]) + ->willReturnSelf(); + $methodMock->expects($this->once())->method('getData')->willReturn($methodData); + + $paymentMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', ['importData', 'getMethod'], [], '', false); + $paymentMock->expects($this->once())->method('importData')->with($methodData)->willReturnSelf(); + + $billingAddressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', ['getCountryId'], [], '', false); + $billingAddressMock->expects($this->once())->method('getCountryId')->willReturn(null); + + $quoteMock->expects($this->once())->method('getPayment')->willReturn($paymentMock); + $quoteMock->expects($this->once())->method('isVirtual')->willReturn(true); + $quoteMock->expects($this->once())->method('getBillingAddress')->willReturn($billingAddressMock); + + $this->model->set($cartId, $methodMock); + } + + /** + * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException + * @expectedExceptionMessage The requested Payment Method is not available. + */ + public function testSetVirtualProductThrowsExceptionIfPaymentMethodNotAvailable() + { + $cartId = 100; + $methodData = ['method' => 'data']; + $paymentMethod = 'checkmo'; + + $quoteMock = $this->getMock( + '\Magento\Quote\Model\Quote', + ['getPayment', 'isVirtual', 'getBillingAddress'], + [], + '', + false + ); + $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)->willReturn($quoteMock); + + $methodMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', ['setChecks', 'getData'], [], '', false); + $methodMock->expects($this->once()) + ->method('setChecks') + ->with([ + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_CHECKOUT, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_COUNTRY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_CURRENCY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_ORDER_TOTAL_MIN_MAX, + ]) + ->willReturnSelf(); + $methodMock->expects($this->once())->method('getData')->willReturn($methodData); + + $paymentMock = $this->getMock( + '\Magento\Quote\Model\Quote\Payment', + ['importData', 'getMethod', 'getMethodInstance'], + [], + '', + false + ); + $paymentMock->expects($this->once())->method('importData')->with($methodData)->willReturnSelf(); + $paymentMock->expects($this->once())->method('getMethod')->willReturn($paymentMethod); + + $billingAddressMock = $this->getMock( + '\Magento\Quote\Model\Quote\Address', + ['getCountryId', 'setPaymentMethod'], + [], + '', + false + ); + $billingAddressMock->expects($this->once())->method('getCountryId')->willReturn(100); + $billingAddressMock->expects($this->once()) + ->method('setPaymentMethod') + ->with($paymentMethod) + ->willReturnSelf(); + + $quoteMock->expects($this->once())->method('getPayment')->willReturn($paymentMock); + $quoteMock->expects($this->exactly(2))->method('isVirtual')->willReturn(true); + $quoteMock->expects($this->exactly(2))->method('getBillingAddress')->willReturn($billingAddressMock); + + $methodInstance = $this->getMock('\Magento\Payment\Model\Checks\PaymentMethodChecksInterface'); + $paymentMock->expects($this->once())->method('getMethodInstance')->willReturn($methodInstance); + + $this->zeroTotalMock->expects($this->once()) + ->method('isApplicable') + ->with($methodInstance, $quoteMock) + ->willReturn(false); + $this->model->set($cartId, $methodMock); + } + + public function testSetSimpleProduct() + { + $cartId = 100; + $paymentId = 20; + $methodData = ['method' => 'data']; + $paymentMethod = 'checkmo'; + + $quoteMock = $this->getMock( + '\Magento\Quote\Model\Quote', + ['getPayment', 'isVirtual', 'getShippingAddress', 'setTotalsCollectedFlag', 'collectTotals', 'save'], + [], + '', + false + ); + $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)->willReturn($quoteMock); + + $methodMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', ['setChecks', 'getData'], [], '', false); + $methodMock->expects($this->once()) + ->method('setChecks') + ->with([ + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_CHECKOUT, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_COUNTRY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_CURRENCY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_ORDER_TOTAL_MIN_MAX, + ]) + ->willReturnSelf(); + $methodMock->expects($this->once())->method('getData')->willReturn($methodData); + + $paymentMock = $this->getMock( + '\Magento\Quote\Model\Quote\Payment', + ['importData', 'getMethod', 'getMethodInstance', 'getId'], + [], + '', + false + ); + $paymentMock->expects($this->once())->method('importData')->with($methodData)->willReturnSelf(); + $paymentMock->expects($this->once())->method('getMethod')->willReturn($paymentMethod); + + $shippingAddressMock = $this->getMock( + '\Magento\Quote\Model\Quote\Address', + ['getCountryId', 'setPaymentMethod'], + [], + '', + false + ); + $shippingAddressMock->expects($this->once())->method('getCountryId')->willReturn(100); + $shippingAddressMock->expects($this->once()) + ->method('setPaymentMethod') + ->with($paymentMethod) + ->willReturnSelf(); + + $quoteMock->expects($this->exactly(2))->method('getPayment')->willReturn($paymentMock); + $quoteMock->expects($this->exactly(2))->method('isVirtual')->willReturn(false); + $quoteMock->expects($this->exactly(4))->method('getShippingAddress')->willReturn($shippingAddressMock); + + $methodInstance = $this->getMock('\Magento\Payment\Model\Checks\PaymentMethodChecksInterface'); + $paymentMock->expects($this->once())->method('getMethodInstance')->willReturn($methodInstance); + + $this->zeroTotalMock->expects($this->once()) + ->method('isApplicable') + ->with($methodInstance, $quoteMock) + ->willReturn(true); + + $quoteMock->expects($this->once())->method('setTotalsCollectedFlag')->with(false)->willReturnSelf(); + $quoteMock->expects($this->once())->method('collectTotals')->willReturnSelf(); + $quoteMock->expects($this->once())->method('save')->willReturnSelf(); + + $paymentMock->expects($this->once())->method('getId')->willReturn($paymentId); + $this->assertEquals($paymentId, $this->model->set($cartId, $methodMock)); + } + + /** + * @expectedException \Magento\Framework\Exception\State\InvalidTransitionException + * @expectedExceptionMessage Shipping address is not set + */ + public function testSetSimpleProductTrowsExceptionIfShippingAddressNotSet() + { + $cartId = 100; + $methodData = ['method' => 'data']; + + $quoteMock = $this->getMock( + '\Magento\Quote\Model\Quote', + ['getPayment', 'isVirtual', 'getShippingAddress'], + [], + '', + false + ); + $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with($cartId)->willReturn($quoteMock); + + $methodMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', ['setChecks', 'getData'], [], '', false); + $methodMock->expects($this->once()) + ->method('setChecks') + ->with([ + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_CHECKOUT, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_COUNTRY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_USE_FOR_CURRENCY, + \Magento\Payment\Model\Method\AbstractMethod::CHECK_ORDER_TOTAL_MIN_MAX, + ]) + ->willReturnSelf(); + $methodMock->expects($this->once())->method('getData')->willReturn($methodData); + + $paymentMock = $this->getMock('\Magento\Quote\Model\Quote\Payment', ['importData'], [], '', false); + $paymentMock->expects($this->once())->method('importData')->with($methodData)->willReturnSelf(); + + $shippingAddressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', ['getCountryId'], [], '', false); + $shippingAddressMock->expects($this->once())->method('getCountryId')->willReturn(null); + + $quoteMock->expects($this->once())->method('getPayment')->willReturn($paymentMock); + $quoteMock->expects($this->once())->method('isVirtual')->willReturn(false); + $quoteMock->expects($this->once())->method('getShippingAddress')->willReturn($shippingAddressMock); + + $this->model->set($cartId, $methodMock); + } +} diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/AddressTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/AddressTest.php index d2ce34e3ddd956e435bcf9b86c5d47e24a5fa73f..6d45948f758f97ab288da9546093ae7b1d8eb97c 100644 --- a/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/AddressTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/AddressTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Quote\Model\Quote; use Magento\Store\Model\ScopeInterface; diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/Item/CompareTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/Item/CompareTest.php index 8fd0c411b6319ce450d2080ad0521c0f96a1f449..866f647b8e0e067c3193403fec0384f59868af54 100644 --- a/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/Item/CompareTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/Item/CompareTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Quote\Model\Quote\Item; /** diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/Item/RepositoryTest.php similarity index 59% rename from dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/WriteServiceTest.php rename to dev/tests/unit/testsuite/Magento/Quote/Model/Quote/Item/RepositoryTest.php index ee0069f41359e8d5f15c443096f0fc12df2e3fc4..8d814d30d59e7de3c33de27ce5cf031c1f15552e 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Item/WriteServiceTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/Item/RepositoryTest.php @@ -5,14 +5,14 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Item; +namespace Magento\Quote\Model\Quote\Item; -class WriteServiceTest extends \PHPUnit_Framework_TestCase +class RepositoryTest extends \PHPUnit_Framework_TestCase { /** - * @var WriteService + * @var Repository */ - protected $service; + protected $repository; /** * @var \PHPUnit_Framework_MockObject_MockObject @@ -44,19 +44,30 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase */ protected $quoteItemMock; + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $itemBuilderMock; + protected function setUp() { $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); $this->productRepositoryMock = $this->getMock('Magento\Catalog\Api\ProductRepositoryInterface', [], [], '', false); - $this->dataMock = $this->getMock('\Magento\Checkout\Service\V1\Data\Cart\Item', [], [], '', false); + $methods = ['setQuoteId', 'setItemId', 'create']; + $this->itemBuilderMock = $this->getMock('Magento\Quote\Api\Data\CartItemDataBuilder', $methods, [], '', false); + $this->dataMock = $this->getMock('Magento\Quote\Api\Data\CartItemInterface'); $this->quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); $this->productMock = $this->getMock('\Magento\Catalog\Model\Product', [], [], '', false); $this->quoteItemMock = - $this->getMock('\Magento\Quote\Model\Quote\Item', ['getId', 'setData', '__wakeUp'], [], '', false); + $this->getMock('Magento\Quote\Model\Quote\Item', ['getId', 'getSku', 'setData', '__wakeUp'], [], '', false); - $this->service = new WriteService($this->quoteRepositoryMock, $this->productRepositoryMock); + $this->repository = new Repository( + $this->quoteRepositoryMock, + $this->productRepositoryMock, + $this->itemBuilderMock + ); } /** @@ -65,12 +76,10 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase * @expectedExceptionMessage Invalid value of * @dataProvider addItemWithInvalidQtyDataProvider */ - public function testAddItemWithInvalidQty($value) + public function testSaveItemWithInvalidQty($value) { - $cartId = 12; $this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue($value)); - - $this->service->addItem($cartId, $this->dataMock); + $this->repository->save($this->dataMock); } public function addItemWithInvalidQtyDataProvider() @@ -88,33 +97,37 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase /** * @expectedException \Magento\Framework\Exception\CouldNotSaveException - * @expectedExceptionMessage Could not add item to quote + * @expectedExceptionMessage Could not save quote */ - public function testAddItemCouldNotSaveException() + public function testSaveCouldNotSaveException() { $cartId = 13; $this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue(12)); + $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId); $this->quoteRepositoryMock->expects($this->once())->method('getActive') ->with($cartId)->will($this->returnValue($this->quoteMock)); $this->dataMock->expects($this->once())->method('getSku')->will($this->returnValue('product_sku')); + $this->dataMock->expects($this->once())->method('getItemId')->will($this->returnValue(null)); + $this->quoteMock->expects($this->never())->method('getItemById'); $this->productRepositoryMock->expects($this->once()) ->method('get')->with('product_sku')->will($this->returnValue($this->productMock)); $this->quoteMock->expects($this->once())->method('addProduct')->with($this->productMock, 12); $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock)); - $exceptionMessage = 'Could not add item to quote'; + $exceptionMessage = 'Could not save quote'; $exception = new \Magento\Framework\Exception\CouldNotSaveException($exceptionMessage); $this->quoteRepositoryMock->expects($this->once()) ->method('save') ->with($this->quoteMock) ->willThrowException($exception); - $this->service->addItem($cartId, $this->dataMock); + $this->repository->save($this->dataMock); } - public function testAddItem() + public function testSave() { $cartId = 13; $this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue(12)); + $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId); $this->quoteRepositoryMock->expects($this->once()) ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); $this->productRepositoryMock->expects($this->once()) @@ -122,6 +135,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->will($this->returnValue($this->productMock)); $this->dataMock->expects($this->once())->method('getSku'); $this->quoteMock->expects($this->once())->method('addProduct')->with($this->productMock, 12); + $this->quoteMock->expects($this->never())->method('getItemById'); $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock)); $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); $this->quoteMock @@ -129,35 +143,8 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->method('getItemByProduct') ->with($this->productMock) ->will($this->returnValue($this->quoteItemMock)); - $this->quoteItemMock->expects($this->once())->method('getId')->will($this->returnValue(5)); - $this->assertEquals(5, $this->service->addItem($cartId, $this->dataMock)); - } - - /** - * @param null|string|bool|int|float $value - * @expectedException \Magento\Framework\Exception\InputException - * @expectedExceptionMessage Invalid value of - * @dataProvider updateItemWithInvalidQtyDataProvider - */ - public function testUpdateItemWithInvalidQty($value) - { - $cartId = 11; - $itemID = 'item_sku'; - $this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue($value)); - $this->service->updateItem($cartId, $itemID, $this->dataMock); - } - - public function updateItemWithInvalidQtyDataProvider() - { - return [ - ['string'], - [0], - [''], - [null], - [-12], - [false], - [-13.1], - ]; + $this->dataMock->expects($this->once())->method('getItemId')->will($this->returnValue(null)); + $this->assertEquals($this->quoteItemMock, $this->repository->save($this->dataMock)); } /** @@ -169,81 +156,112 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $cartId = 11; $itemId = 5; $this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue(12)); + $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId); + $this->dataMock->expects($this->once())->method('getItemId')->will($this->returnValue($itemId)); $this->quoteRepositoryMock->expects($this->once()) ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); $this->quoteMock->expects($this->once()) ->method('getItemById')->with($itemId)->will($this->returnValue(false)); $this->quoteItemMock->expects($this->never())->method('setData'); + $this->quoteItemMock->expects($this->never())->method('addProduct'); - $this->service->updateItem($cartId, $itemId, $this->dataMock); + $this->repository->save($this->dataMock); } /** * @expectedException \Magento\Framework\Exception\CouldNotSaveException - * @expectedExceptionMessage Could not update quote item + * @expectedExceptionMessage Could not save quote */ public function testUpdateItemWithCouldNotSaveException() { $cartId = 11; $itemId = 5; + $productSku = 'product_sku'; $this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue(12)); + $this->dataMock->expects($this->once())->method('getItemId')->will($this->returnValue($itemId)); + $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId); $this->quoteRepositoryMock->expects($this->once()) ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); $this->quoteMock->expects($this->once()) ->method('getItemById')->with($itemId)->will($this->returnValue($this->quoteItemMock)); $this->quoteItemMock->expects($this->once())->method('setData')->with('qty', 12); + $this->quoteItemMock->expects($this->once())->method('getSku')->willReturn($productSku); + $this->productRepositoryMock + ->expects($this->once()) + ->method('get') + ->with($productSku) + ->willReturn($this->productMock); $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock)); - $exceptionMessage = 'Could not update quote item'; + $this->quoteItemMock->expects($this->never())->method('addProduct'); + $exceptionMessage = 'Could not save quote'; $exception = new \Magento\Framework\Exception\CouldNotSaveException($exceptionMessage); $this->quoteRepositoryMock->expects($this->once()) ->method('save') ->with($this->quoteMock) ->willThrowException($exception); - $this->service->updateItem($cartId, $itemId, $this->dataMock); + $this->repository->save($this->dataMock); } public function testUpdateItem() { $cartId = 11; $itemId = 5; + $productSku = 'product_sku'; $this->dataMock->expects($this->once())->method('getQty')->will($this->returnValue(12)); + $this->dataMock->expects($this->once())->method('getItemId')->will($this->returnValue($itemId)); + $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId); $this->quoteRepositoryMock->expects($this->once()) ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); $this->quoteMock->expects($this->once()) ->method('getItemById')->with($itemId)->will($this->returnValue($this->quoteItemMock)); $this->quoteItemMock->expects($this->once())->method('setData')->with('qty', 12); + $this->quoteItemMock->expects($this->once())->method('getSku')->willReturn($productSku); + $this->productRepositoryMock + ->expects($this->once()) + ->method('get') + ->with($productSku) + ->willReturn($this->productMock); + $this->quoteItemMock->expects($this->never())->method('addProduct'); $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock)); $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); - - $this->assertTrue($this->service->updateItem($cartId, $itemId, $this->dataMock)); + $this->quoteMock + ->expects($this->once()) + ->method('getItemByProduct') + ->with($this->productMock) + ->willReturn($this->quoteItemMock); + $this->assertEquals($this->quoteItemMock, $this->repository->save($this->dataMock)); } /** * @expectedException \Magento\Framework\Exception\NoSuchEntityException * @expectedExceptionMessage Cart 11 doesn't contain item 5 */ - public function testRemoveItemWithInvalidQuoteItem() + public function testDeleteWithInvalidQuoteItem() { $cartId = 11; $itemId = 5; + $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId); + $this->dataMock->expects($this->once())->method('getItemId')->willReturn($itemId); $this->quoteRepositoryMock->expects($this->once()) ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); $this->quoteMock->expects($this->once()) ->method('getItemById')->with($itemId)->will($this->returnValue(false)); $this->quoteMock->expects($this->never())->method('removeItem'); - $this->service->removeItem($cartId, $itemId, $this->dataMock); + $this->repository->delete($this->dataMock); } /** * @expectedException \Magento\Framework\Exception\CouldNotSaveException * @expectedExceptionMessage Could not remove item from quote */ - public function testRemoveItemWithCouldNotSaveException() + public function testDeleteWithCouldNotSaveException() { $cartId = 11; $itemId = 5; + $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId); + $this->dataMock->expects($this->once())->method('getItemId')->willReturn($itemId); $this->quoteRepositoryMock->expects($this->once()) ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); $this->quoteMock->expects($this->once()) @@ -258,13 +276,47 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->with($this->quoteMock) ->willThrowException($exception); - $this->service->removeItem($cartId, $itemId, $this->dataMock); + $this->repository->delete($this->dataMock); + } + + public function testDelete() + { + $cartId = 11; + $itemId = 5; + $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId); + $this->dataMock->expects($this->once())->method('getItemId')->willReturn($itemId); + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); + $this->quoteMock->expects($this->once()) + ->method('getItemById')->with($itemId)->will($this->returnValue($this->quoteItemMock)); + $this->quoteMock->expects($this->once())->method('removeItem'); + $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock)); + $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); + + $this->repository->delete($this->dataMock); + } + + public function testGetList() + { + $quoteMock = $this->getMock('Magento\Quote\Model\Quote', [], [], '', false); + $this->quoteRepositoryMock->expects($this->once())->method('getActive') + ->with(33) + ->will($this->returnValue($quoteMock)); + $itemMock = $this->getMock('\Magento\Quote\Model\Quote\Item', [], [], '', false); + $quoteMock->expects($this->any())->method('getAllItems')->will($this->returnValue([$itemMock])); + + $this->assertEquals([$itemMock], $this->repository->getList(33)); } - public function testRemoveItem() + public function testDeleteById() { $cartId = 11; $itemId = 5; + $this->itemBuilderMock->expects($this->once())->method('setQuoteId')->with($cartId)->willReturnSelf(); + $this->itemBuilderMock->expects($this->once())->method('setItemId')->with($itemId)->willReturnSelf(); + $this->itemBuilderMock->expects($this->once())->method('create')->willReturn($this->dataMock); + $this->dataMock->expects($this->once())->method('getQuoteId')->willReturn($cartId); + $this->dataMock->expects($this->once())->method('getItemId')->willReturn($itemId); $this->quoteRepositoryMock->expects($this->once()) ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); $this->quoteMock->expects($this->once()) @@ -273,6 +325,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnValue($this->quoteMock)); $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); - $this->assertTrue($this->service->removeItem($cartId, $itemId, $this->dataMock)); + $this->assertTrue($this->repository->deleteById($cartId, $itemId)); } } diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/ItemTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/ItemTest.php index 5a829956b522aa2e55ddaa55572ca69c1ffbc983..131ec74296564e732039ca6e4fc3322c048b6021 100644 --- a/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/ItemTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/ItemTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Quote\Model\Quote; class ItemTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/PaymentTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/PaymentTest.php new file mode 100644 index 0000000000000000000000000000000000000000..b09fe0b26b47d5432828ff32dbe50f1c38abdecf --- /dev/null +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/Quote/PaymentTest.php @@ -0,0 +1,48 @@ +<?php +/** + * Copyright © 2015 Magento. All rights reserved. + * See COPYING.txt for license details. + */ +namespace Magento\Quote\Model\Quote; + +use Magento\TestFramework\Helper\ObjectManager; + +class PaymentTest extends \PHPUnit_Framework_TestCase +{ + /** + * @var Payment + */ + private $model; + + protected function setUp() + { + $objectManager = new ObjectManager($this); + $this->model = $objectManager->getObject( + '\Magento\Quote\Model\Quote\Payment' + ); + } + + /** + * @param int|string|null $databaseValue + * @param int|string|null $expectedValue + * @dataProvider yearValueDataProvider + */ + public function testGetCcExpYearReturnsValidValue($databaseValue, $expectedValue) + { + $this->model->setData('cc_exp_year', $databaseValue); + $this->assertEquals($expectedValue, $this->model->getCcExpYear()); + } + + /** + * @return array + */ + public function yearValueDataProvider() + { + return [ + [null, null], + [0, null], + ['0', null], + [1939, 1939], + ]; + } +} diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/ValidatorTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteAddressValidatorTest.php similarity index 71% rename from dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/ValidatorTest.php rename to dev/tests/unit/testsuite/Magento/Quote/Model/QuoteAddressValidatorTest.php index 2485f8a6e17b44d294a73e70291e1f1772243076..32c0b6b32c5c53b0d85fe936b9624f7134438c89 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/ValidatorTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteAddressValidatorTest.php @@ -5,14 +5,14 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Address; +// @codingStandardsIgnoreFile -use Magento\Checkout\Service\V1\Data\Cart\Address; +namespace Magento\Quote\Model; -class ValidatorTest extends \PHPUnit_Framework_TestCase +class QuoteAddressValidatorTest extends \PHPUnit_Framework_TestCase { /** - * @var \Magento\Checkout\Service\V1\Address\Validator + * @var QuoteAddressValidator */ protected $model; @@ -36,11 +36,6 @@ class ValidatorTest extends \PHPUnit_Framework_TestCase */ protected $quoteAddressMock; - /** - * @var \Magento\Checkout\Service\V1\Data\Cart\AddressBuilder - */ - protected $addressDataBuilder; - /** * @var \PHPUnit_Framework_MockObject_MockObject */ @@ -64,22 +59,7 @@ class ValidatorTest extends \PHPUnit_Framework_TestCase '\Magento\Customer\Model\CustomerFactory', ['create', '__wakeup'], [], '', false); $this->customerMock = $this->getMock('\Magento\Customer\Model\Customer', [], [], '', false); - $builder = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\Address\RegionBuilder', ['create'], [], '', false - ); - - $this->addressDataBuilder = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\Data\Cart\AddressBuilder', - ['regionBuilder' => $builder] - ); - - $this->model = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\Address\Validator', - [ - 'quoteAddressFactory' => $this->addressFactoryMock, - 'customerFactory' => $this->customerFactoryMock, - ] - ); + $this->model = new QuoteAddressValidator($this->addressFactoryMock, $this->customerFactoryMock); } /** @@ -97,11 +77,9 @@ class ValidatorTest extends \PHPUnit_Framework_TestCase $this->customerMock->expects($this->once())->method('load')->with($customerId); $this->customerMock->expects($this->once())->method('getId')->will($this->returnValue(null)); - $addressData = $this->addressDataBuilder - ->setCustomerId($customerId) - ->setCompany('eBay Inc') - ->create(); - $this->model->validate($addressData); + $address = $this->getMock('\Magento\Quote\Api\Data\AddressInterface'); + $address->expects($this->atLeastOnce())->method('getCustomerId')->willReturn($customerId); + $this->model->validate($address); } /** @@ -116,11 +94,9 @@ class ValidatorTest extends \PHPUnit_Framework_TestCase $this->addressFactoryMock->expects($this->once())->method('create') ->will($this->returnValue($this->quoteAddressMock)); - $addressData = $this->addressDataBuilder - ->setId(101) - ->setCompany('eBay Inc') - ->create(); - $this->model->validate($addressData); + $address = $this->getMock('\Magento\Quote\Api\Data\AddressInterface'); + $address->expects($this->atLeastOnce())->method('getId')->willReturn(101); + $this->model->validate($address); } /** @@ -131,8 +107,8 @@ class ValidatorTest extends \PHPUnit_Framework_TestCase $this->customerFactoryMock->expects($this->never())->method('create'); $this->addressFactoryMock->expects($this->never())->method('create'); - $addressData = $this->addressDataBuilder->setCompany('eBay Inc')->create(); - $this->assertTrue($this->model->validate($addressData)); + $address = $this->getMock('\Magento\Quote\Api\Data\AddressInterface'); + $this->assertTrue($this->model->validate($address)); } /** @@ -144,12 +120,9 @@ class ValidatorTest extends \PHPUnit_Framework_TestCase $addressCustomer = 100; $addressId = 100; - /** Address data object */ - $addressData = $this->addressDataBuilder - ->setId($addressId) - ->setCompany('eBay Inc') - ->setCustomerId($addressCustomer) - ->create(); + $address = $this->getMock('\Magento\Quote\Api\Data\AddressInterface'); + $address->expects($this->atLeastOnce())->method('getId')->willReturn($addressId); + $address->expects($this->atLeastOnce())->method('getCustomerId')->willReturn($addressCustomer); /** Customer mock */ $this->customerFactoryMock->expects($this->once()) @@ -169,7 +142,7 @@ class ValidatorTest extends \PHPUnit_Framework_TestCase ->will($this->returnValue(10)); /** Validate */ - $this->model->validate($addressData); + $this->model->validate($address); } public function testValidateWithValidAddress() @@ -177,12 +150,9 @@ class ValidatorTest extends \PHPUnit_Framework_TestCase $addressCustomer = 100; $addressId = 100; - /** Address data object */ - $addressData = $this->addressDataBuilder - ->setId($addressId) - ->setCompany('eBay Inc') - ->setCustomerId($addressCustomer) - ->create(); + $address = $this->getMock('\Magento\Quote\Api\Data\AddressInterface'); + $address->expects($this->atLeastOnce())->method('getId')->willReturn($addressId); + $address->expects($this->atLeastOnce())->method('getCustomerId')->willReturn($addressCustomer); /** Customer mock */ $this->customerFactoryMock->expects($this->once()) @@ -202,6 +172,6 @@ class ValidatorTest extends \PHPUnit_Framework_TestCase ->will($this->returnValue($addressCustomer)); /** Validate */ - $this->model->validate($addressData); + $this->model->validate($address); } } diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteManagementTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteManagementTest.php index bcb93755ebf3e6adfaa3c990a0e0fb71d618fd35..56e96636e95f65499191460d28001c78aeb07b73 100644 --- a/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteManagementTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteManagementTest.php @@ -6,6 +6,11 @@ namespace Magento\Quote\Model; +use \Magento\Framework\Exception\NoSuchEntityException; + +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class QuoteManagementTest extends \PHPUnit_Framework_TestCase { /** @@ -53,11 +58,31 @@ class QuoteManagementTest extends \PHPUnit_Framework_TestCase */ protected $orderManagement; + /** + * @var \Magento\Quote\Model\QuoteRepository|\PHPUnit_Framework_MockObject_MockObject + */ + protected $quoteRepositoryMock; + /** * @var CustomerManagement */ protected $customerManagement; + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $userContextMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $customerRepositoryMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $customerFactoryMock; + protected function setUp() { $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); @@ -99,6 +124,23 @@ class QuoteManagementTest extends \PHPUnit_Framework_TestCase $this->quoteItemToOrderItem = $this->getMock('Magento\Quote\Model\Quote\Item\ToOrderItem', [], [], '', false); $this->orderManagement = $this->getMock('Magento\Sales\Api\OrderManagementInterface', [], [], '', false); $this->customerManagement = $this->getMock('Magento\Quote\Model\CustomerManagement', [], [], '', false); + $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); + + $this->userContextMock = $this->getMock('\Magento\Authorization\Model\UserContextInterface', [], [], '', false); + $this->customerRepositoryMock = $this->getMock( + '\Magento\Customer\Api\CustomerRepositoryInterface', + ['create', 'save', 'get', 'getById', 'getList', 'delete', 'deleteById'], + [], + '', + false + ); + $this->customerFactoryMock = $this->getMock( + '\Magento\Customer\Model\CustomerFactory', + ['create'], + [], + '', + false + ); $this->model = $objectManager->getObject( 'Magento\Quote\Model\QuoteManagement', @@ -111,11 +153,331 @@ class QuoteManagementTest extends \PHPUnit_Framework_TestCase 'quoteAddressToOrder' => $this->quoteAddressToOrder, 'quoteAddressToOrderAddress' => $this->quoteAddressToOrderAddress, 'quoteItemToOrderItem' => $this->quoteItemToOrderItem, - 'quotePaymentToOrderPayment' => $this->quotePaymentToOrderPayment + 'quotePaymentToOrderPayment' => $this->quotePaymentToOrderPayment, + 'quoteRepository' => $this->quoteRepositoryMock, + 'userContext' => $this->userContextMock, + 'customerRepository' => $this->customerRepositoryMock, + 'customerModelFactory' => $this->customerFactoryMock, ] ); } + public function testCreateEmptyCartAnonymous() + { + $storeId = 345; + $quoteId = 2311; + + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + + $this->userContextMock->expects($this->once())->method('getUserType') + ->willReturn(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_GUEST); + + $this->quoteRepositoryMock->expects($this->once())->method('create')->willReturn($quoteMock); + $quoteMock->expects($this->any())->method('setStoreId')->with($storeId); + + + $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock); + $quoteMock->expects($this->once())->method('getId')->willReturn($quoteId); + + $this->assertEquals($quoteId, $this->model->createEmptyCart($storeId)); + } + + public function testCreateEmptyCartLoggedInUser() + { + $storeId = 345; + $quoteId = 2311; + $userId = 567; + + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + + $this->userContextMock->expects($this->once())->method('getUserType') + ->willReturn(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_CUSTOMER); + + $this->userContextMock->expects($this->atLeastOnce())->method('getUserId')->willReturn($userId); + + $customerMock = $this->getMock('\Magento\Customer\Api\Data\CustomerInterface', [], [], '', false); + $this->customerRepositoryMock + ->expects($this->once()) + ->method('getById') + ->with($userId) + ->willReturn($customerMock); + + $this->quoteRepositoryMock + ->expects($this->once()) + ->method('getActiveForCustomer') + ->with($userId) + ->willThrowException(new NoSuchEntityException()); + + $this->quoteRepositoryMock->expects($this->once())->method('create')->willReturn($quoteMock); + $quoteMock->expects($this->any())->method('setStoreId')->with($storeId); + $quoteMock->expects($this->any())->method('setCustomer')->with($customerMock); + $quoteMock->expects($this->any())->method('setCustomerIsGuest')->with(0); + + + $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock); + $quoteMock->expects($this->once())->method('getId')->willReturn($quoteId); + + $this->assertEquals($quoteId, $this->model->createEmptyCart($storeId)); + } + + /** + * @expectedException \Magento\Framework\Exception\CouldNotSaveException + */ + public function testCreateEmptyCartLoggedInUserException() + { + $storeId = 345; + $userId = 567; + + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + + $this->userContextMock->expects($this->once())->method('getUserType') + ->willReturn(\Magento\Authorization\Model\UserContextInterface::USER_TYPE_CUSTOMER); + + $this->userContextMock->expects($this->atLeastOnce())->method('getUserId')->willReturn($userId); + + $customerMock = $this->getMock('\Magento\Customer\Api\Data\CustomerInterface', [], [], '', false); + $this->customerRepositoryMock + ->expects($this->once()) + ->method('getById') + ->with($userId) + ->willReturn($customerMock); + + $this->quoteRepositoryMock + ->expects($this->once()) + ->method('getActiveForCustomer') + ->with($userId); + + $this->quoteRepositoryMock->expects($this->never())->method('create')->willReturn($quoteMock); + + $this->quoteRepositoryMock->expects($this->never())->method('save')->with($quoteMock); + + $this->model->createEmptyCart($storeId); + } + + /** + * @expectedException \Magento\Framework\Exception\StateException + * @expectedExceptionMessage Cannot assign customer to the given cart. The cart belongs to different store + */ + public function testAssignCustomerFromAnotherStore() + { + $cartId = 220; + $customerId = 455; + $storeId = 5; + + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $customerMock = $this->getMock('\Magento\Customer\Api\Data\CustomerInterface', [], [], '', false); + + $this->quoteRepositoryMock + ->expects($this->once()) + ->method('getActive') + ->with($cartId) + ->willReturn($quoteMock); + + $this->customerRepositoryMock + ->expects($this->once()) + ->method('getById') + ->with($customerId) + ->willReturn($customerMock); + + $customerModelMock = $this->getMock( + '\Magento\Customer\Model\Customer', + ['load', 'getSharedStoreIds'], + [], + '', + false + ); + $this->customerFactoryMock->expects($this->once())->method('create')->willReturn($customerModelMock); + $customerModelMock + ->expects($this->once()) + ->method('load') + ->with($customerId) + ->willReturnSelf(); + + $customerModelMock + ->expects($this->once()) + ->method('getSharedStoreIds') + ->willReturn([]); + + $this->model->assignCustomer($cartId, $customerId, $storeId); + } + + /** + * @expectedException \Magento\Framework\Exception\StateException + * @expectedExceptionMessage Cannot assign customer to the given cart. The cart is not anonymous. + */ + public function testAssignCustomerToNonanonymousCart() + { + $cartId = 220; + $customerId = 455; + $storeId = 5; + + $quoteMock = $this->getMock( + '\Magento\Quote\Model\Quote', + ['getCustomerId', 'setCustomer', 'setCustomerIsGuest'], + [], + '', + false + ); + $customerMock = $this->getMock('\Magento\Customer\Api\Data\CustomerInterface', [], [], '', false); + + $this->quoteRepositoryMock + ->expects($this->once()) + ->method('getActive') + ->with($cartId) + ->willReturn($quoteMock); + + $this->customerRepositoryMock + ->expects($this->once()) + ->method('getById') + ->with($customerId) + ->willReturn($customerMock); + + $customerModelMock = $this->getMock( + '\Magento\Customer\Model\Customer', + ['load', 'getSharedStoreIds'], + [], + '', + false + ); + $this->customerFactoryMock->expects($this->once())->method('create')->willReturn($customerModelMock); + $customerModelMock + ->expects($this->once()) + ->method('load') + ->with($customerId) + ->willReturnSelf(); + + $customerModelMock + ->expects($this->once()) + ->method('getSharedStoreIds') + ->willReturn([$storeId, 'some store value']); + + $quoteMock->expects($this->once())->method('getCustomerId')->willReturn(753); + + $this->model->assignCustomer($cartId, $customerId, $storeId); + } + + /** + * @expectedException \Magento\Framework\Exception\StateException + * @expectedExceptionMessage Cannot assign customer to the given cart. Customer already has active cart. + */ + public function testAssignCustomerNoSuchCustomer() + { + $cartId = 220; + $customerId = 455; + $storeId = 5; + + $quoteMock = $this->getMock( + '\Magento\Quote\Model\Quote', + ['getCustomerId', 'setCustomer', 'setCustomerIsGuest'], + [], + '', + false + ); + $customerMock = $this->getMock('\Magento\Customer\Api\Data\CustomerInterface', [], [], '', false); + + $this->quoteRepositoryMock + ->expects($this->once()) + ->method('getActive') + ->with($cartId) + ->willReturn($quoteMock); + + $this->customerRepositoryMock + ->expects($this->once()) + ->method('getById') + ->with($customerId) + ->willReturn($customerMock); + + $customerModelMock = $this->getMock( + '\Magento\Customer\Model\Customer', + ['load', 'getSharedStoreIds'], + [], + '', + false + ); + $this->customerFactoryMock->expects($this->once())->method('create')->willReturn($customerModelMock); + $customerModelMock + ->expects($this->once()) + ->method('load') + ->with($customerId) + ->willReturnSelf(); + + $customerModelMock + ->expects($this->once()) + ->method('getSharedStoreIds') + ->willReturn([$storeId, 'some store value']); + + $quoteMock->expects($this->once())->method('getCustomerId')->willReturn(null); + + $this->quoteRepositoryMock + ->expects($this->once()) + ->method('getForCustomer') + ->with($customerId); + + $this->model->assignCustomer($cartId, $customerId, $storeId); + } + + public function testAssignCustomer() + { + $cartId = 220; + $customerId = 455; + $storeId = 5; + + $quoteMock = $this->getMock( + '\Magento\Quote\Model\Quote', + ['getCustomerId', 'setCustomer', 'setCustomerIsGuest'], + [], + '', + false + ); + $customerMock = $this->getMock('\Magento\Customer\Api\Data\CustomerInterface', [], [], '', false); + + $this->quoteRepositoryMock + ->expects($this->once()) + ->method('getActive') + ->with($cartId) + ->willReturn($quoteMock); + + $this->customerRepositoryMock + ->expects($this->once()) + ->method('getById') + ->with($customerId) + ->willReturn($customerMock); + + $customerModelMock = $this->getMock( + '\Magento\Customer\Model\Customer', + ['load', 'getSharedStoreIds'], + [], + '', + false + ); + $this->customerFactoryMock->expects($this->once())->method('create')->willReturn($customerModelMock); + $customerModelMock + ->expects($this->once()) + ->method('load') + ->with($customerId) + ->willReturnSelf(); + + $customerModelMock + ->expects($this->once()) + ->method('getSharedStoreIds') + ->willReturn([$storeId, 'some store value']); + + $quoteMock->expects($this->once())->method('getCustomerId')->willReturn(null); + + $this->quoteRepositoryMock + ->expects($this->once()) + ->method('getForCustomer') + ->with($customerId) + ->willThrowException(new NoSuchEntityException()); + + $quoteMock->expects($this->once())->method('setCustomer')->with($customerMock); + $quoteMock->expects($this->once())->method('setCustomerIsGuest')->with(0); + + $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock); + + $this->model->assignCustomer($cartId, $customerId, $storeId); + } + public function testSubmit() { $orderData = []; @@ -161,7 +523,8 @@ class QuoteManagementTest extends \PHPUnit_Framework_TestCase ->willReturn($baseOrder); $this->quoteAddressToOrderAddress->expects($this->at(0)) ->method('convert') - ->with($shippingAddress, + ->with( + $shippingAddress, [ 'address_type' => 'shipping', 'email' => 'customer@example.com' @@ -170,7 +533,8 @@ class QuoteManagementTest extends \PHPUnit_Framework_TestCase ->willReturn($convertedShippingAddress); $this->quoteAddressToOrderAddress->expects($this->at(1)) ->method('convert') - ->with($billingAddress, + ->with( + $billingAddress, [ 'address_type' => 'billing', 'email' => 'customer@example.com' @@ -208,6 +572,8 @@ class QuoteManagementTest extends \PHPUnit_Framework_TestCase ->method('dispatch') ->with('sales_model_service_quote_submit_success', ['order' => $order, 'quote' => $quote]); + $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quote); + $this->assertEquals($order, $this->model->submit($quote, $orderData)); } @@ -331,4 +697,15 @@ class QuoteManagementTest extends \PHPUnit_Framework_TestCase return $order; } + + public function testGetCartForCustomer() + { + $customerId = 100; + $cartMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActiveForCustomer') + ->with($customerId) + ->willReturn($cartMock); + $this->assertEquals($cartMock, $this->model->getCartForCustomer($customerId)); + } } diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteRepositoryTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteRepositoryTest.php index 0f1d190d36381995d9407c3f0b9757e70d34044b..451d2281e49646a03b5bd2c690e62f79686f59b4 100644 --- a/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteRepositoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteRepositoryTest.php @@ -7,7 +7,7 @@ namespace Magento\Quote\Model; -use Magento\Quote\Model\QuoteRepository; +use Magento\Framework\Api\SearchCriteria; class QuoteRepositoryTest extends \PHPUnit_Framework_TestCase { @@ -36,6 +36,16 @@ class QuoteRepositoryTest extends \PHPUnit_Framework_TestCase */ protected $quoteMock; + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $searchResultsBuilderMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $quoteCollectionMock; + protected function setUp() { $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); @@ -51,11 +61,23 @@ class QuoteRepositoryTest extends \PHPUnit_Framework_TestCase false ); $this->storeMock = $this->getMock('\Magento\Store\Model\Store', [], [], '', false); + $this->searchResultsBuilderMock = $this->getMock( + '\Magento\Quote\Api\Data\CartSearchResultsDataBuilder', + ['setSearchCriteria', 'setTotalCount', 'setItems', 'create'], + [], + '', + false + ); + + $this->quoteCollectionMock = $this->getMock('Magento\Quote\Model\Resource\Quote\Collection', [], [], '', false); + $this->model = $objectManager->getObject( 'Magento\Quote\Model\QuoteRepository', [ 'quoteFactory' => $this->quoteFactoryMock, 'storeManager' => $this->storeManagerMock, + 'searchResultsBuilder' => $this->searchResultsBuilderMock, + 'quoteCollection' => $this->quoteCollectionMock, ] ); } @@ -280,4 +302,77 @@ class QuoteRepositoryTest extends \PHPUnit_Framework_TestCase $this->model->delete($this->quoteMock); } + + /** + * @param int $direction + * @param string $expectedDirection + * @dataProvider getListSuccessDataProvider + */ + public function testGetListSuccess($direction, $expectedDirection) + { + $searchResult = $this->getMock('\Magento\Quote\Api\Data\CartSearchResultsInterface', [], [], '', false); + $searchCriteriaMock = $this->getMock('\Magento\Framework\Api\SearchCriteria', [], [], '', false); + $cartMock = $this->getMock('Magento\Payment\Model\Cart', [], [], '', false); + $filterMock = $this->getMock('\Magento\Framework\Api\Filter', [], [], '', false); + $pageSize = 10; + + $this->searchResultsBuilderMock + ->expects($this->once()) + ->method('setSearchCriteria'); + + $filterGroupMock = $this->getMock('\Magento\Framework\Api\Search\FilterGroup', [], [], '', false); + $searchCriteriaMock + ->expects($this->any()) + ->method('getFilterGroups') + ->will($this->returnValue([$filterGroupMock])); + + //addFilterGroupToCollection() checks + $filterGroupMock->expects($this->any())->method('getFilters')->will($this->returnValue([$filterMock])); + $filterMock->expects($this->once())->method('getField')->will($this->returnValue('store_id')); + $filterMock->expects($this->any())->method('getConditionType')->will($this->returnValue('eq')); + $filterMock->expects($this->once())->method('getValue')->will($this->returnValue('filter_value')); + + //back in getList() + $this->quoteCollectionMock->expects($this->once())->method('getSize')->willReturn($pageSize); + $this->searchResultsBuilderMock->expects($this->once())->method('setTotalCount')->with($pageSize); + $sortOrderMock = $this->getMockBuilder('Magento\Framework\Api\SortOrder') + ->setMethods(['getField', 'getDirection']) + ->disableOriginalConstructor() + ->getMock(); + + //foreach cycle + $searchCriteriaMock + ->expects($this->once()) + ->method('getSortOrders') + ->will($this->returnValue([$sortOrderMock])); + $sortOrderMock->expects($this->once())->method('getField')->will($this->returnValue('id')); + $sortOrderMock->expects($this->once())->method('getDirection')->will($this->returnValue($direction)); + $this->quoteCollectionMock->expects($this->once())->method('addOrder')->with('id', $expectedDirection); + + + $searchCriteriaMock->expects($this->once())->method('getCurrentPage')->will($this->returnValue(1)); + $searchCriteriaMock->expects($this->once())->method('getPageSize')->will($this->returnValue(10)); + $this->quoteCollectionMock->expects($this->once())->method('setCurPage')->with(1); + $this->quoteCollectionMock->expects($this->once())->method('setPageSize')->with(10); + + + $this->quoteCollectionMock->expects($this->once())->method('getItems')->willReturn([$cartMock]); + $this->searchResultsBuilderMock->expects($this->once())->method('setItems')->with([$cartMock]); + $this->searchResultsBuilderMock + ->expects($this->once()) + ->method('create') + ->will($this->returnValue($searchResult)); + $this->assertEquals($searchResult, $this->model->getList($searchCriteriaMock)); + } + + /** + * @return array + */ + public function getListSuccessDataProvider() + { + return [ + 'asc' => [SearchCriteria::SORT_ASC, 'ASC'], + 'desc' => [SearchCriteria::SORT_DESC, 'DESC'] + ]; + } } diff --git a/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteTest.php index 0ccd1c6b100fe73ec238e62a97fc167fee45eb87..4956334694371ba507536dc8c3fe06c499d1e8cb 100644 --- a/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/QuoteTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Quote\Model; use Magento\Quote\Model\Quote\Address; @@ -13,6 +16,7 @@ use Magento\TestFramework\Helper\ObjectManager; * Test class for \Magento\Quote\Model * * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * @SuppressWarnings(PHPMD.TooManyFields) */ class QuoteTest extends \PHPUnit_Framework_TestCase { @@ -523,6 +527,9 @@ class QuoteTest extends \PHPUnit_Framework_TestCase $this->assertInstanceOf('Magento\Quote\Model\Quote', $result); } + /** + * @SuppressWarnings(PHPMD.UnusedLocalVariable) + */ public function testSetCustomerAddressData() { $customerId = 1; diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/ShippingAddressManagementTest.php similarity index 54% rename from dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceTest.php rename to dev/tests/unit/testsuite/Magento/Quote/Model/ShippingAddressManagementTest.php index ec444630c5c72ab93636b42e6b68c01a421b913b..b328b4b5ad5d0960f157f9d1129a3d43982ba409 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/Address/Shipping/WriteServiceTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/ShippingAddressManagementTest.php @@ -5,12 +5,14 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\Address\Shipping; +// @codingStandardsIgnoreFile -class WriteServiceTest extends \PHPUnit_Framework_TestCase +namespace Magento\Quote\Model; + +class ShippingAddressManagementTest extends \PHPUnit_Framework_TestCase { /** - * @var WriteService + * @var ShippingAddressManagement */ protected $service; @@ -19,11 +21,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase */ protected $quoteRepositoryMock; - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $addressFactoryMock; - /** * @var \PHPUnit_Framework_MockObject_MockObject */ @@ -34,11 +31,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase */ protected $validatorMock; - /** - * @var \PHPUnit_Framework_MockObject_MockObject - */ - protected $converterMock; - /** * @var \Magento\TestFramework\Helper\ObjectManager */ @@ -47,38 +39,21 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase protected function setUp() { $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); - $this->addressFactoryMock = $this->getMock( - '\Magento\Quote\Model\Quote\AddressFactory', ['create', '__wakeup'], [], '', false - ); - $this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); $this->quoteAddressMock = $this->getMock( '\Magento\Quote\Model\Quote\Address', - ['getCustomerId', 'load', 'getData', 'setData', 'setStreet', 'setRegionId', 'setRegion', '__wakeup'], + ['setSameAsBilling', 'setCollectShippingRates', '__wakeup'], [], '', false ); - $this->addressFactoryMock->expects($this->any()) - ->method('create') - ->will($this->returnValue($this->quoteAddressMock)); - $this->validatorMock = $this->getMock( - '\Magento\Checkout\Service\V1\Address\Validator', [], [], '', false + 'Magento\Quote\Model\QuoteAddressValidator', [], [], '', false ); - - $this->converterMock = $this->getMock( - '\Magento\Checkout\Service\V1\Address\Converter', [], [], '', false - ); - - $this->service = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\Address\Shipping\WriteService', - [ - 'quoteRepository' => $this->quoteRepositoryMock, - 'quoteAddressFactory' => $this->addressFactoryMock, - 'addressValidator' => $this->validatorMock, - 'addressConverter' => $this->converterMock, - ] + $this->service = new ShippingAddressManagement( + $this->quoteRepositoryMock, + $this->validatorMock, + $this->getMock('\Psr\Log\LoggerInterface') ); } @@ -97,7 +72,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->validatorMock->expects($this->once())->method('validate') ->will($this->throwException(new \Magento\Framework\Exception\NoSuchEntityException('error345'))); - $this->service->setAddress('cart654', null); + $this->service->assign('cart654', $this->quoteAddressMock); } public function testSetAddress() @@ -109,27 +84,11 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->will($this->returnValue($quoteMock)); $quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false)); - $builder = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\Address\RegionBuilder', ['create'], [], '', false - ); - - /** @var \Magento\Checkout\Service\V1\Data\Cart\AddressBuilder $addressDataBuilder */ - $addressDataBuilder = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\Data\Cart\AddressBuilder', - ['regionBuilder' => $builder] - ); - - /** @var \Magento\Checkout\Service\V1\Data\Cart\Address $addressData */ - $addressData = $addressDataBuilder->setId(356)->create(); $this->validatorMock->expects($this->once())->method('validate') - ->with($addressData) + ->with($this->quoteAddressMock) ->will($this->returnValue(true)); - $this->converterMock->expects($this->once())->method('convertDataObjectToModel') - ->with($addressData, $this->quoteAddressMock) - ->will($this->returnValue($this->quoteAddressMock)); - $quoteMock->expects($this->once())->method('setShippingAddress')->with($this->quoteAddressMock); $quoteMock->expects($this->once())->method('setDataChanges')->with(true); $this->quoteRepositoryMock->expects($this->once())->method('save')->with($quoteMock); @@ -140,7 +99,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $quoteMock->expects($this->once())->method('getShippingAddress') ->will($this->returnValue($shippingAddressMock)); - $this->assertEquals($addressId, $this->service->setAddress('cart867', $addressData)); + $this->assertEquals($addressId, $this->service->assign('cart867', $this->quoteAddressMock)); } /** @@ -156,25 +115,12 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->will($this->returnValue($quoteMock)); $quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(true)); - $builder = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\Address\RegionBuilder', ['create'], [], '', false - ); - - /** @var \Magento\Checkout\Service\V1\Data\Cart\AddressBuilder $addressDataBuilder */ - $addressDataBuilder = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\Data\Cart\AddressBuilder', - ['regionBuilder' => $builder] - ); - - /** @var \Magento\Checkout\Service\V1\Data\Cart\Address $addressData */ - $addressData = $addressDataBuilder->setId(356)->create(); - $this->validatorMock->expects($this->never())->method('validate'); $quoteMock->expects($this->never())->method('setShippingAddress'); $quoteMock->expects($this->never())->method('save'); - $this->service->setAddress('cart867', $addressData); + $this->service->assign('cart867', $this->quoteAddressMock); } /** @@ -190,27 +136,10 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->will($this->returnValue($quoteMock)); $quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(false)); - $builder = $this->getMock( - '\Magento\Checkout\Service\V1\Data\Cart\Address\RegionBuilder', ['create'], [], '', false - ); - - /** @var \Magento\Checkout\Service\V1\Data\Cart\AddressBuilder $addressDataBuilder */ - $addressDataBuilder = $this->objectManager->getObject( - 'Magento\Checkout\Service\V1\Data\Cart\AddressBuilder', - ['regionBuilder' => $builder] - ); - - /** @var \Magento\Checkout\Service\V1\Data\Cart\Address $addressData */ - $addressData = $addressDataBuilder->setId(356)->create(); - $this->validatorMock->expects($this->once())->method('validate') - ->with($addressData) + ->with($this->quoteAddressMock) ->will($this->returnValue(true)); - $this->converterMock->expects($this->once())->method('convertDataObjectToModel') - ->with($addressData, $this->quoteAddressMock) - ->will($this->returnValue($this->quoteAddressMock)); - $quoteMock->expects($this->once())->method('setShippingAddress')->with($this->quoteAddressMock); $quoteMock->expects($this->once())->method('setDataChanges')->with(true); $this->quoteRepositoryMock->expects($this->once()) @@ -219,6 +148,36 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->willThrowException( new \Exception('Some DB Error') ); - $this->service->setAddress('cart867', $addressData); + $this->service->assign('cart867', $this->quoteAddressMock); + } + + public function testGetAddress() + { + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with('cartId')->will( + $this->returnValue($quoteMock) + ); + + $addressMock = $this->getMock('\Magento\Quote\Model\Quote\Address', [], [], '', false); + $quoteMock->expects($this->any())->method('getShippingAddress')->will($this->returnValue($addressMock)); + $quoteMock->expects($this->any())->method('isVirtual')->will($this->returnValue(false)); + $this->assertEquals($addressMock, $this->service->get('cartId')); + } + + /** + * @expectedException \Exception + * @expectedExceptionMessage Cart contains virtual product(s) only. Shipping address is not applicable + */ + public function testGetAddressOfQuoteWithVirtualProducts() + { + $quoteMock = $this->getMock('\Magento\Quote\Model\Quote', [], [], '', false); + $this->quoteRepositoryMock->expects($this->once())->method('getActive')->with('cartId')->will( + $this->returnValue($quoteMock) + ); + + $quoteMock->expects($this->any())->method('isVirtual')->will($this->returnValue(true)); + $quoteMock->expects($this->never())->method('getShippingAddress'); + + $this->service->get('cartId'); } } diff --git a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceTest.php b/dev/tests/unit/testsuite/Magento/Quote/Model/ShippingMethodManagementTest.php similarity index 53% rename from dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceTest.php rename to dev/tests/unit/testsuite/Magento/Quote/Model/ShippingMethodManagementTest.php index 5d2de490851aab61f9546e27e10ea08114877eb9..e9e69c90ea8a502c972917ad580ca8f7e4adebf2 100644 --- a/dev/tests/unit/testsuite/Magento/Checkout/Service/V1/ShippingMethod/WriteServiceTest.php +++ b/dev/tests/unit/testsuite/Magento/Quote/Model/ShippingMethodManagementTest.php @@ -5,79 +5,272 @@ * See COPYING.txt for license details. */ -namespace Magento\Checkout\Service\V1\ShippingMethod; +namespace Magento\Quote\Model; -class WriteServiceTest extends \PHPUnit_Framework_TestCase +use Magento\Quote\Api\Data\ShippingMethodInterface; +use Magento\TestFramework\Helper\ObjectManager; + +class ShippingMethodManagementTest extends \PHPUnit_Framework_TestCase { /** - * @var WriteService + * @var ShippingMethodManagement */ - protected $service; + protected $model; /** * @var \PHPUnit_Framework_MockObject_MockObject */ - protected $addressFactoryMock; + protected $quoteRepositoryMock; /** * @var \PHPUnit_Framework_MockObject_MockObject */ - protected $quoteRepositoryMock; + protected $quoteMock; /** * @var \PHPUnit_Framework_MockObject_MockObject */ - protected $quoteMock; + protected $shippingAddressMock; /** * @var \PHPUnit_Framework_MockObject_MockObject */ - protected $shippingAddressMock; + protected $methodBuilderMock; + + /** + * @var \PHPUnit_Framework_MockObject_MockObject + */ + protected $converterMock; + + /** + * @var \Magento\TestFramework\Helper\ObjectManager + */ + protected $objectManager; protected function setUp() { - $objectManager = new \Magento\TestFramework\Helper\ObjectManager($this); - $this->addressFactoryMock = $this->getMock('\Magento\Quote\Model\Quote\AddressFactory', [], [], '', false); + $this->objectManager = new ObjectManager($this); $this->quoteRepositoryMock = $this->getMock('\Magento\Quote\Model\QuoteRepository', [], [], '', false); + $this->methodBuilderMock = $this->getMock( + '\Magento\Quote\Api\Data\ShippingMethodDataBuilder', + ['populateWithArray', 'create'], + [], + '', + false + ); + $this->storeMock = $this->getMock('\Magento\Store\Model\Store', [], [], '', false); $this->quoteMock = $this->getMock( '\Magento\Quote\Model\Quote', [ - 'getItemsCount', - 'isVirtual', 'getShippingAddress', + 'isVirtual', + 'getItemsCount', + 'getQuoteCurrencyCode', 'getBillingAddress', 'collectTotals', 'save', - '__wakeup' + '__wakeup', ], [], '', false ); - $this->shippingAddressMock = $this->getMock( '\Magento\Quote\Model\Quote\Address', [ - 'setShippingMethod', - 'requestShippingRates', - 'save', 'getCountryId', - '__wakeup' + 'getShippingMethod', + 'getShippingDescription', + 'getShippingAmount', + 'getBaseShippingAmount', + 'getGroupedAllShippingRates', + 'collectShippingRates', + 'requestShippingRates', + 'setShippingMethod', + '__wakeup', ], [], '', false ); + $this->converterMock = $this->getMock( + '\Magento\Quote\Model\Cart\ShippingMethodConverter', + [], + [], + '', + false + ); - $this->service = $objectManager->getObject( - 'Magento\Checkout\Service\V1\ShippingMethod\WriteService', + $this->model = $this->objectManager->getObject( + 'Magento\Quote\Model\ShippingMethodManagement', [ - 'addressFactory' => $this->addressFactoryMock, - 'quoteRepository' => $this->quoteRepositoryMock + 'quoteRepository' => $this->quoteRepositoryMock, + 'methodBuilder' => $this->methodBuilderMock, + 'converter' => $this->converterMock, ] ); } + /** + * @expectedException \Magento\Framework\Exception\StateException + * @expectedExceptionMessage Shipping address not set. + */ + public function testGetMethodWhenShippingAddressIsNotSet() + { + $cartId = 666; + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); + $this->quoteMock->expects($this->once()) + ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); + $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(null)); + + $this->assertNull($this->model->get($cartId)); + } + + /** + * @expectedException \Magento\Framework\Exception\InputException + * @expectedExceptionMessage Line "WrongShippingMethod" doesn't contain delimiter _ + */ + public function testGetMethodWhenShippingMethodIsInvalid() + { + $cartId = 884; + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); + $this->quoteMock->expects($this->once()) + ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); + $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(34)); + $this->shippingAddressMock->expects($this->exactly(2)) + ->method('getShippingMethod') + ->will($this->returnValue('WrongShippingMethod')); + + $this->assertNull($this->model->get($cartId)); + } + + public function testGetMethod() + { + $cartId = 666; + $countryId = 1; + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); + $this->quoteMock->expects($this->once()) + ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); + $this->shippingAddressMock->expects($this->any()) + ->method('getCountryId')->will($this->returnValue($countryId)); + $this->shippingAddressMock->expects($this->any()) + ->method('getShippingMethod')->will($this->returnValue('one_two')); + $this->shippingAddressMock->expects($this->once()) + ->method('getShippingDescription')->will($this->returnValue('carrier - method')); + $this->shippingAddressMock->expects($this->once()) + ->method('getShippingAmount')->will($this->returnValue(123.56)); + $this->shippingAddressMock->expects($this->once()) + ->method('getBaseShippingAmount')->will($this->returnValue(100.06)); + $output = [ + ShippingMethodInterface::CARRIER_CODE => 'one', + ShippingMethodInterface::METHOD_CODE => 'two', + ShippingMethodInterface::CARRIER_TITLE => 'carrier', + ShippingMethodInterface::METHOD_TITLE => 'method', + ShippingMethodInterface::SHIPPING_AMOUNT => 123.56, + ShippingMethodInterface::BASE_SHIPPING_AMOUNT => 100.06, + ShippingMethodInterface::AVAILABLE => true, + ]; + $this->methodBuilderMock->expects($this->once()) + ->method('populateWithArray')->with($output)->will($this->returnValue($this->methodBuilderMock)); + $this->methodBuilderMock->expects($this->once())->method('create'); + + $this->model->get($cartId); + } + + public function testGetMethodIfMethodIsNotSet() + { + $cartId = 666; + $countryId = 1; + + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); + $this->quoteMock->expects($this->once()) + ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); + $this->shippingAddressMock->expects($this->any()) + ->method('getCountryId')->will($this->returnValue($countryId)); + $this->shippingAddressMock->expects($this->any()) + ->method('getShippingMethod')->will($this->returnValue(null)); + + $this->assertNull($this->model->get($cartId)); + } + + public function testGetListForVirtualCart() + { + $cartId = 834; + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); + $this->quoteMock->expects($this->once()) + ->method('isVirtual')->will($this->returnValue(true)); + + $this->assertEquals([], $this->model->getList($cartId)); + } + + public function testGetListForEmptyCart() + { + $cartId = 834; + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); + $this->quoteMock->expects($this->once()) + ->method('isVirtual')->will($this->returnValue(false)); + $this->quoteMock->expects($this->once()) + ->method('getItemsCount')->will($this->returnValue(0)); + + $this->assertEquals([], $this->model->getList($cartId)); + } + + /** + * @expectedException \Magento\Framework\Exception\StateException + * @expectedExceptionMessage Shipping address not set. + */ + public function testGetListWhenShippingAddressIsNotSet() + { + $cartId = 834; + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); + $this->quoteMock->expects($this->once()) + ->method('isVirtual')->will($this->returnValue(false)); + $this->quoteMock->expects($this->once()) + ->method('getItemsCount')->will($this->returnValue(3)); + $this->quoteMock->expects($this->once()) + ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); + $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(null)); + + $this->model->getList($cartId); + } + + public function testGetList() + { + $cartId = 834; + $this->quoteRepositoryMock->expects($this->once()) + ->method('getActive')->with($cartId)->will($this->returnValue($this->quoteMock)); + $this->quoteMock->expects($this->once()) + ->method('isVirtual')->will($this->returnValue(false)); + $this->quoteMock->expects($this->once()) + ->method('getItemsCount')->will($this->returnValue(3)); + $this->quoteMock->expects($this->once()) + ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); + $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(345)); + $this->shippingAddressMock->expects($this->once())->method('collectShippingRates'); + $shippingRateMock = $this->getMock('\Magento\Quote\Model\Quote\Address\Rate', [], [], '', false); + $this->shippingAddressMock->expects($this->once()) + ->method('getGroupedAllShippingRates') + ->will($this->returnValue([[$shippingRateMock]])); + + $currencyCode = 'EUR'; + $this->quoteMock->expects($this->once()) + ->method('getQuoteCurrencyCode') + ->will($this->returnValue($currencyCode)); + + $this->converterMock->expects($this->once()) + ->method('modelToDataObject') + ->with($shippingRateMock, $currencyCode) + ->will($this->returnValue('RateValue')); + $this->assertEquals(['RateValue'], $this->model->getList($cartId)); + } + /** * @expectedException \Magento\Framework\Exception\InputException * @expectedExceptionMessage Shipping method is not applicable for empty cart @@ -92,7 +285,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(0)); $this->quoteMock->expects($this->never())->method('isVirtual'); - $this->service->setMethod($cartId, $carrierCode, $methodCode); + $this->model->set($cartId, $carrierCode, $methodCode); } /** @@ -110,7 +303,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->quoteMock->expects($this->once())->method('getItemsCount')->will($this->returnValue(1)); $this->quoteMock->expects($this->once())->method('isVirtual')->will($this->returnValue(true)); - $this->service->setMethod($cartId, $carrierCode, $methodCode); + $this->model->set($cartId, $carrierCode, $methodCode); } /** @@ -130,7 +323,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); $this->shippingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(null)); - $this->service->setMethod($cartId, $carrierCode, $methodCode); + $this->model->set($cartId, $carrierCode, $methodCode); } /** @@ -163,7 +356,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->method('getBillingAddress')->will($this->returnValue($billingAddressMock)); $billingAddressMock->expects($this->once())->method('getCountryId')->will($this->returnValue(null)); - $this->service->setMethod($cartId, $carrierCode, $methodCode); + $this->model->set($cartId, $carrierCode, $methodCode); } /** @@ -200,7 +393,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->method('requestShippingRates')->will($this->returnValue(false)); $this->shippingAddressMock->expects($this->never())->method('save'); - $this->service->setMethod($cartId, $carrierCode, $methodCode); + $this->model->set($cartId, $carrierCode, $methodCode); } /** @@ -246,7 +439,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->with($this->quoteMock) ->willThrowException($exception); - $this->service->setMethod($cartId, $carrierCode, $methodCode); + $this->model->set($cartId, $carrierCode, $methodCode); } /** @@ -266,7 +459,7 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase ->method('getShippingAddress')->will($this->returnValue($this->shippingAddressMock)); $this->shippingAddressMock->expects($this->once())->method('getCountryId'); - $this->service->setMethod($cartId, $carrierCode, $methodCode); + $this->model->set($cartId, $carrierCode, $methodCode); } public function testSetMethod() @@ -303,6 +496,6 @@ class WriteServiceTest extends \PHPUnit_Framework_TestCase $this->quoteMock->expects($this->once())->method('collectTotals')->will($this->returnSelf()); $this->quoteRepositoryMock->expects($this->once())->method('save')->with($this->quoteMock); - $this->assertTrue($this->service->setMethod($cartId, $carrierCode, $methodCode)); + $this->assertTrue($this->model->set($cartId, $carrierCode, $methodCode)); } } diff --git a/dev/tests/unit/testsuite/Magento/Reports/Model/Resource/Report/Collection/AbstractCollectionTest.php b/dev/tests/unit/testsuite/Magento/Reports/Model/Resource/Report/Collection/AbstractCollectionTest.php index d4456023c269cca969978f74a5c7a7531af5d4c7..7256703d3c0b5761b807f976783b50880e46025e 100644 --- a/dev/tests/unit/testsuite/Magento/Reports/Model/Resource/Report/Collection/AbstractCollectionTest.php +++ b/dev/tests/unit/testsuite/Magento/Reports/Model/Resource/Report/Collection/AbstractCollectionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Reports\Model\Resource\Report\Collection; class AbstractCollectionTest extends \PHPUnit_Framework_TestCase @@ -49,4 +52,4 @@ class AbstractCollectionTest extends \PHPUnit_Framework_TestCase $this->_model->setIsSubTotals(false); $this->assertFalse($this->_model->isSubTotals()); } -} \ No newline at end of file +} diff --git a/dev/tests/unit/testsuite/Magento/Review/Controller/Adminhtml/Product/PostTest.php b/dev/tests/unit/testsuite/Magento/Review/Controller/Adminhtml/Product/PostTest.php index 10cd08f64b884492f05e9278fa03d387130cf8a3..1dd384080fc18d6f4dd3b9620d7a65178a7b2582 100644 --- a/dev/tests/unit/testsuite/Magento/Review/Controller/Adminhtml/Product/PostTest.php +++ b/dev/tests/unit/testsuite/Magento/Review/Controller/Adminhtml/Product/PostTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Review\Controller\Adminhtml\Product; /** diff --git a/dev/tests/unit/testsuite/Magento/Rss/Model/RssManagerTest.php b/dev/tests/unit/testsuite/Magento/Rss/Model/RssManagerTest.php index 7bf84d58692ff0d62aad6c721380516190081abb..c2181d1c2ef39c599a1e01d58500d9596702d9c5 100644 --- a/dev/tests/unit/testsuite/Magento/Rss/Model/RssManagerTest.php +++ b/dev/tests/unit/testsuite/Magento/Rss/Model/RssManagerTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Rss\Model; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; diff --git a/dev/tests/unit/testsuite/Magento/Rss/Model/UrlBuilderTest.php b/dev/tests/unit/testsuite/Magento/Rss/Model/UrlBuilderTest.php index 37ca6fa878caa8c1dc50ca9a9339b347ad278c56..d4f72b1f046ffef32b2800c8dc197fce871badad 100644 --- a/dev/tests/unit/testsuite/Magento/Rss/Model/UrlBuilderTest.php +++ b/dev/tests/unit/testsuite/Magento/Rss/Model/UrlBuilderTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Rss\Model; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; diff --git a/dev/tests/unit/testsuite/Magento/Rule/Model/Condition/Product/AbstractProductTest.php b/dev/tests/unit/testsuite/Magento/Rule/Model/Condition/Product/AbstractProductTest.php index a33faf44642cbf3a14ea2a9c33b245356f12b579..04ad345d5a35ccf0b27c057be4f0876c86c0b39a 100644 --- a/dev/tests/unit/testsuite/Magento/Rule/Model/Condition/Product/AbstractProductTest.php +++ b/dev/tests/unit/testsuite/Magento/Rule/Model/Condition/Product/AbstractProductTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Rule\Model\Condition\Product; use ReflectionMethod; @@ -284,6 +286,7 @@ class AbstractProductTest extends \PHPUnit_Framework_TestCase * @param array $expectedValueSelectOptions * @param array $expectedValueOption * @dataProvider prepareValueOptionsDataProvider + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function testPrepareValueOptions( $setData, @@ -364,6 +367,7 @@ class AbstractProductTest extends \PHPUnit_Framework_TestCase /** * @return array + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function prepareValueOptionsDataProvider() { diff --git a/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Items/GridTest.php b/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Items/GridTest.php index 8141a6af4c9ee6aab626a6e5293f3c1458b045c3..7c2a10dfdae997b98d3354504eeef61bf7dc8aff 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Items/GridTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/Items/GridTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Block\Adminhtml\Order\Create\Items; class GridTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/TotalsTest.php b/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/TotalsTest.php index 48fa0c73b85977ff2b1d525a8a123fa16c42040c..7e469e1be6214ce0f4ee2015446e3bd74c0e7936 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/TotalsTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Block/Adminhtml/Order/Create/TotalsTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Block\Adminhtml\Order\Create; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Email/Items/DefaultItemsTest.php b/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Email/Items/DefaultItemsTest.php index 2953d3c2702dc7a2e58d28d41708b0a03d5e4f25..84cbd4ac31d7b241afcb7166f422cf97f03a3c3e 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Email/Items/DefaultItemsTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Email/Items/DefaultItemsTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Block\Order\Email\Items; class DefaultItemsTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Email/Items/Order/DefaultOrderTest.php b/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Email/Items/Order/DefaultOrderTest.php index 556fcb44b87d8699d5d3db7f0a9a8b55f9c3d78f..409b5029e0da4d76a9ec15233b672d246c95a725 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Email/Items/Order/DefaultOrderTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Email/Items/Order/DefaultOrderTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Block\Order\Email\Items\Order; class DefaultOrderTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Item/Renderer/DefaultRendererTest.php b/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Item/Renderer/DefaultRendererTest.php index 16aa530cf3c85295477749571de1690f40f0e347..29c757617b4da4797aaeb9bd795961545c0ed6b7 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Item/Renderer/DefaultRendererTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Block/Order/Item/Renderer/DefaultRendererTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Block\Order\Item\Renderer; class DefaultRendererTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/NewActionTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/NewActionTest.php index 2e06d59121eafa84e2ce84f633170dc0702817f6..6a97735ce2f02df08d9989bdb70f3e763c7b3491 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/NewActionTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/NewActionTest.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Controller\Adminhtml\Order\Creditmemo; /** * Class NewActionTest + * @SuppressWarnings(PHPMD.TooManyFields) */ class NewActionTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php index 3c826d716a41b9b032b6d4054318512f8fa0d512..bbbc973d67f1a49bdb9e82c6ad7234b849ed729a 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Controller\Adminhtml\Order\Creditmemo; /** * Class PrintActionTest + * @SuppressWarnings(PHPMD.TooManyFields) */ class PrintActionTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php index fb76705531a7d636eff714a8bd5eb6f7d43a2b17..5a395357753827ebff92b7cbb2196154ccca72af 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Controller\Adminhtml\Order\Creditmemo; class SaveTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php index 672c8c22abdc69582c586f1b1f300e1233c07c5f..5da711e94fd3eb5977c2bd25e1ecdda324606528 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Controller\Adminhtml\Order\Creditmemo; /** * Class ViewTest + * @SuppressWarnings(PHPMD.TooManyFields) */ class ViewTest extends \PHPUnit_Framework_TestCase { @@ -90,6 +91,9 @@ class ViewTest extends \PHPUnit_Framework_TestCase */ protected $pageTitleMock; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function setUp() { $this->invoiceMock = $this->getMockBuilder('Magento\Sales\Model\Order\Invoice') diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php index e0c5b08a36a4aa73bc9056eccaba08c26cd3df09..8030ee2d527c2ea565db444c97433539f7d95c9c 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Model/AdminOrder/CreateTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\AdminOrder; use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; @@ -77,6 +80,9 @@ class CreateTest extends \PHPUnit_Framework_TestCase */ protected $objectFactory; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ protected function setUp() { $objectManagerMock = $this->getMock('Magento\Framework\ObjectManagerInterface'); diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Grid/Child/CollectionUpdaterTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Grid/Child/CollectionUpdaterTest.php index 352c5fd0faad856a83b5b834bc834d8f024d8ddb..acc4e818fb6582503a003560141ee0477495dd1a 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Model/Grid/Child/CollectionUpdaterTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Grid/Child/CollectionUpdaterTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Grid\Child; class CollectionUpdaterTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Grid/CollectionUpdaterTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Grid/CollectionUpdaterTest.php index 4d86a04806fe18268bbbda82c2336c23e7410cb3..f7c1faf7488986cf5a04f26d8c907b1c8463d8d7 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Model/Grid/CollectionUpdaterTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Grid/CollectionUpdaterTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Grid; class CollectionUpdaterTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/TaxTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/TaxTest.php index d26e6a2d943bff106b9f2373ed68cbd8dadf80d1..c4d57221c8bdb833dbde02b5e6a9364e9bfaecd1 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/TaxTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/TaxTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order\Creditmemo\Total; use Magento\Framework\Object as MagentoObject; diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/CreditmemoTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/CreditmemoTest.php index 0cd264330cc613cf7590f1a4f23838cf1743bf8c..7e9d43e006f81036f76a525c1b00a28d5cd23974 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/CreditmemoTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/CreditmemoTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order; use Magento\Sales\Model\Resource\OrderFactory; diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Invoice/Total/ShippingTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Invoice/Total/ShippingTest.php index 55d44e69c65b6aa31493ecdb616f88f9dd252224..42830ceaa2f723492c030d85a8ed70dbf6b9241e 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Invoice/Total/ShippingTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Invoice/Total/ShippingTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order\Invoice\Total; class ShippingTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/InvoiceTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/InvoiceTest.php index 85a2112ccb2a192441f3d0aad86fbbb2c0dec002..55dd44cad8832a41e18cc3a4249f0ed485dfa4d8 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/InvoiceTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/InvoiceTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Order; use Magento\Sales\Model\Resource\OrderFactory; diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Resource/GridPoolTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Resource/GridPoolTest.php index ffc7d9a3bf9626e1552c816dfd2859aa5330bd0a..e05b0644048e65d5a9642812ca213a768e47363e 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Model/Resource/GridPoolTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Resource/GridPoolTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Resource; /** diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Resource/Order/StatusTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Resource/Order/StatusTest.php index 5e36dd8bfacba70c50249452d248b25013372513..7e4c91295407249a3d22638c97cbc49e9e4d9cd6 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Model/Resource/Order/StatusTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Resource/Order/StatusTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Sales\Model\Resource\Order; /** diff --git a/dev/tests/unit/testsuite/Magento/SalesRule/Model/Resource/Report/CollectionTest.php b/dev/tests/unit/testsuite/Magento/SalesRule/Model/Resource/Report/CollectionTest.php index d48db1e2a6ccb7e0502ee03832ad0dc4e16cc592..08e15499e1418cf25f7c56ef44638ba9f99474df 100644 --- a/dev/tests/unit/testsuite/Magento/SalesRule/Model/Resource/Report/CollectionTest.php +++ b/dev/tests/unit/testsuite/Magento/SalesRule/Model/Resource/Report/CollectionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\SalesRule\Model\Resource\Report; class CollectionTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/SalesRule/Model/UtilityTest.php b/dev/tests/unit/testsuite/Magento/SalesRule/Model/UtilityTest.php index 4867f781ae19d53b87b246658a5ae0337dfbb742..048bbd7107d3e0473d7e5bce22228ed97d1bbc8f 100644 --- a/dev/tests/unit/testsuite/Magento/SalesRule/Model/UtilityTest.php +++ b/dev/tests/unit/testsuite/Magento/SalesRule/Model/UtilityTest.php @@ -8,6 +8,7 @@ namespace Magento\SalesRule\Model; /** * Class UtilityTest * + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class UtilityTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/AddTrackTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/AddTrackTest.php index ee296fb5be01747063d1afbfb63e3d2067f58baa..47558f5000221e16f7eec5526b159c4104ad3b46 100644 --- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/AddTrackTest.php +++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/AddTrackTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Shipping\Controller\Adminhtml\Order\Shipment; use Magento\Backend\App\Action; @@ -156,6 +158,9 @@ class AddTrackTest extends \PHPUnit_Framework_TestCase ); } + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function testExecute() { $carrier = 'carrier'; diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/NewActionTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/NewActionTest.php index b8ee7eb5bad75c22f717180b562bfe2e873eaea0..ca913d99f871183b9c3945addb97600c26c3bf56 100644 --- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/NewActionTest.php +++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/NewActionTest.php @@ -86,6 +86,9 @@ class NewActionTest extends \PHPUnit_Framework_TestCase */ protected $pageTitleMock; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function setUp() { $objectManagerHelper = new ObjectManagerHelper($this); diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/SaveTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/SaveTest.php index 6d5637136adb1a8aa2ae496b3d6dc9cf79b67a4e..49462a66801a8dca454b47dfd510c3484d56ccca 100644 --- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/SaveTest.php +++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/SaveTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Shipping\Controller\Adminhtml\Order\Shipment; use Magento\Backend\App\Action; diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/ViewTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/ViewTest.php index cd0423d4523a157ef8475f0c88cfa015d27f2f6d..d18f836bd35b26fab3d776e0299a035da60cba4a 100644 --- a/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/ViewTest.php +++ b/dev/tests/unit/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/ViewTest.php @@ -7,6 +7,7 @@ namespace Magento\Shipping\Controller\Adminhtml\Order\Shipment; /** * Class ViewTest + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class ViewTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/Shipping/Model/ShipmentTest.php b/dev/tests/unit/testsuite/Magento/Shipping/Model/ShipmentTest.php index 85eb9f1cdf193b80b3de91b80555f79b0366eda0..2b416097f02548757f57ba91ea3a36615bc03cae 100644 --- a/dev/tests/unit/testsuite/Magento/Shipping/Model/ShipmentTest.php +++ b/dev/tests/unit/testsuite/Magento/Shipping/Model/ShipmentTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Shipping\Model; use Magento\Sales\Model\Resource\OrderFactory; diff --git a/dev/tests/unit/testsuite/Magento/Store/App/Action/Plugin/ContextTest.php b/dev/tests/unit/testsuite/Magento/Store/App/Action/Plugin/ContextTest.php index 4d4eb13bcc9ec17b583e90d76ef724b751d43d02..aa33762fefdb13f1a58b86c5bd6442eaa938a6ca 100644 --- a/dev/tests/unit/testsuite/Magento/Store/App/Action/Plugin/ContextTest.php +++ b/dev/tests/unit/testsuite/Magento/Store/App/Action/Plugin/ContextTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Store\App\Action\Plugin; /** diff --git a/dev/tests/unit/testsuite/Magento/Store/App/Action/Plugin/StoreCheckTest.php b/dev/tests/unit/testsuite/Magento/Store/App/Action/Plugin/StoreCheckTest.php index 2d5a9822dbbd90a6c9c4fda2460fc6efba647cb2..1d37e60cee1d1ed01c0ef12ab3a7930bf1a6d8f2 100644 --- a/dev/tests/unit/testsuite/Magento/Store/App/Action/Plugin/StoreCheckTest.php +++ b/dev/tests/unit/testsuite/Magento/Store/App/Action/Plugin/StoreCheckTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Store\App\Action\Plugin; class StoreCheckTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Store/Model/App/EmulationTest.php b/dev/tests/unit/testsuite/Magento/Store/Model/App/EmulationTest.php index d09271bdfd36c56921741f785ae701de299cbe36..725f6fa510286f295d4d2574aef1e66b6440267b 100644 --- a/dev/tests/unit/testsuite/Magento/Store/Model/App/EmulationTest.php +++ b/dev/tests/unit/testsuite/Magento/Store/Model/App/EmulationTest.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Store\Model\App; class EmulationTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Store/Model/Config/Reader/ReaderPoolTest.php b/dev/tests/unit/testsuite/Magento/Store/Model/Config/Reader/ReaderPoolTest.php index 577c58a6f788a12325d45c11ad051142376b3e00..d169e36f832ab5b12a9ae1801e55d345623840f2 100644 --- a/dev/tests/unit/testsuite/Magento/Store/Model/Config/Reader/ReaderPoolTest.php +++ b/dev/tests/unit/testsuite/Magento/Store/Model/Config/Reader/ReaderPoolTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Store\Model\Config\Reader; class ReaderPoolTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Store/Model/Storage/DbTest.php b/dev/tests/unit/testsuite/Magento/Store/Model/Storage/DbTest.php index f33892680122b0581355ea946e658534771b91b7..ac869a0ecaa3fdc69edc7d462517c3ce974d5f84 100644 --- a/dev/tests/unit/testsuite/Magento/Store/Model/Storage/DbTest.php +++ b/dev/tests/unit/testsuite/Magento/Store/Model/Storage/DbTest.php @@ -4,6 +4,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Store\Model\Storage; /** diff --git a/dev/tests/unit/testsuite/Magento/Store/Model/StoreTest.php b/dev/tests/unit/testsuite/Magento/Store/Model/StoreTest.php index ea561e593e4a51922c1a37a320933d74b52d5b2e..86b2436be1fe13a79581fc56df11d767a8d45a2c 100644 --- a/dev/tests/unit/testsuite/Magento/Store/Model/StoreTest.php +++ b/dev/tests/unit/testsuite/Magento/Store/Model/StoreTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Store\Model; use Magento\Framework\App\Config\ReinitableConfigInterface; diff --git a/dev/tests/unit/testsuite/Magento/Tax/Block/Checkout/Cart/Sidebar/TotalsTest.php b/dev/tests/unit/testsuite/Magento/Tax/Block/Checkout/Cart/Sidebar/TotalsTest.php index 7b19944d642cef2323cabba046436690a30d640c..f05de539943bd120524d5a2b9e8c165fd10778eb 100644 --- a/dev/tests/unit/testsuite/Magento/Tax/Block/Checkout/Cart/Sidebar/TotalsTest.php +++ b/dev/tests/unit/testsuite/Magento/Tax/Block/Checkout/Cart/Sidebar/TotalsTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tax\Block\Checkout\Cart\Sidebar; use Magento\Framework\Object; diff --git a/dev/tests/unit/testsuite/Magento/Tax/Helper/DataTest.php b/dev/tests/unit/testsuite/Magento/Tax/Helper/DataTest.php index 6bc869feb90224c5ff1c3ddde91d62699b82c864..eb0e628c4ec162eaecfdbf751212f437143ba917 100644 --- a/dev/tests/unit/testsuite/Magento/Tax/Helper/DataTest.php +++ b/dev/tests/unit/testsuite/Magento/Tax/Helper/DataTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tax\Helper; use Magento\Framework\Object as MagentoObject; @@ -122,6 +125,7 @@ class DataTest extends \PHPUnit_Framework_TestCase * * @param $inputArray * @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Tax\Api\Data\OrderTaxDetailsInterface + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function mapOrderTaxItemDetail($inputArray) { diff --git a/dev/tests/unit/testsuite/Magento/Tax/Model/Calculation/RowBaseAndTotalBaseCalculatorTestCase.php b/dev/tests/unit/testsuite/Magento/Tax/Model/Calculation/RowBaseAndTotalBaseCalculatorTestCase.php index fc6e23be50d26f99f4e7d9b10eff6b8f53bcf38b..7e6651d4b474c35aeb0b18e0116b8c1e7b591b6a 100644 --- a/dev/tests/unit/testsuite/Magento/Tax/Model/Calculation/RowBaseAndTotalBaseCalculatorTestCase.php +++ b/dev/tests/unit/testsuite/Magento/Tax/Model/Calculation/RowBaseAndTotalBaseCalculatorTestCase.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Tax\Model\Calculation; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/Tax/Model/Config/TaxClassTest.php b/dev/tests/unit/testsuite/Magento/Tax/Model/Config/TaxClassTest.php index 87c5922f502ea69231b0d8fe2351b29f4bfd174e..7165f38b0b24984b376191c03f9e2e968ae431df 100644 --- a/dev/tests/unit/testsuite/Magento/Tax/Model/Config/TaxClassTest.php +++ b/dev/tests/unit/testsuite/Magento/Tax/Model/Config/TaxClassTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test class for \Magento\Tax\Model\Config\TaxClass */ diff --git a/dev/tests/unit/testsuite/Magento/Tax/Model/ConfigTest.php b/dev/tests/unit/testsuite/Magento/Tax/Model/ConfigTest.php index ae62bb24f3ccd7ffc3e8f14581953f8b2743e22c..81a26c41c488c2a8332fbbb71a1dc729e506ac4d 100644 --- a/dev/tests/unit/testsuite/Magento/Tax/Model/ConfigTest.php +++ b/dev/tests/unit/testsuite/Magento/Tax/Model/ConfigTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test class for \Magento\Tax\Model\Config */ diff --git a/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/CommonTaxCollectorTest.php b/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/CommonTaxCollectorTest.php index 9eb797bde35ad40001b3ab997fd846ab2d0537d8..424ceac9bc63f26b06862a4fdb5af7fa8e1e1622 100644 --- a/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/CommonTaxCollectorTest.php +++ b/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/CommonTaxCollectorTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tax\Model\Sales\Total\Quote; /** diff --git a/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/ShippingTest.php b/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/ShippingTest.php index 6aa1ca9aa3461cc4bc59d2e9611de36405d85757..2e90d16eaacf8b05629ce3ffd225782dd09a54fb 100644 --- a/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/ShippingTest.php +++ b/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/ShippingTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tax\Model\Sales\Total\Quote; class ShippingTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php b/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php index 85eed412a95990d25cbf2d55e476513e760e8fb5..1e7ff2e174f73e922ffc38ff3d4487f678cac7e6 100644 --- a/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php +++ b/dev/tests/unit/testsuite/Magento/Tax/Model/Sales/Total/Quote/TaxTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tax\Model\Sales\Total\Quote; /** @@ -27,6 +30,7 @@ class TaxTest extends \PHPUnit_Framework_TestCase * * @dataProvider dataProviderCollectArray * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function testCollect($itemData, $appliedRatesData, $taxDetailsData, $quoteDetailsData, $addressData, $verifyData diff --git a/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/CssTest.php b/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/CssTest.php index 116115af88250c961d82c96751427db239f2c250..c33fae6fb629a28a7562c3fc9889f7dba2916de7 100644 --- a/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/CssTest.php +++ b/dev/tests/unit/testsuite/Magento/Theme/Block/Adminhtml/System/Design/Theme/Tab/CssTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Theme\Block\Adminhtml\System\Design\Theme\Tab; class CssTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Theme/Model/Url/Plugin/SignatureTest.php b/dev/tests/unit/testsuite/Magento/Theme/Model/Url/Plugin/SignatureTest.php index fcd11c1539908052d3013241f393c5e3ea5970fe..6a13ea689275577c23e17de44b241d3b8b00353e 100644 --- a/dev/tests/unit/testsuite/Magento/Theme/Model/Url/Plugin/SignatureTest.php +++ b/dev/tests/unit/testsuite/Magento/Theme/Model/Url/Plugin/SignatureTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Theme\Model\Url\Plugin; class SignatureTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Tools/Di/App/Task/OperationFactoryTest.php b/dev/tests/unit/testsuite/Magento/Tools/Di/App/Task/OperationFactoryTest.php index c15e189b777db4530e0a62c2d69de53a6c03ef3c..359adca36a68a1d9bf117662bf270058d4822926 100644 --- a/dev/tests/unit/testsuite/Magento/Tools/Di/App/Task/OperationFactoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Tools/Di/App/Task/OperationFactoryTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tools\Di\App\Task; class OperationFactoryTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Tools/Di/Compiler/ArgumentsResolverTest.php b/dev/tests/unit/testsuite/Magento/Tools/Di/Compiler/ArgumentsResolverTest.php index b2b9295f91a55b5139e2a53fd5e4b74076c4b31f..a916357b873e6a3649cd33210c2dd7c2ae467bca 100644 --- a/dev/tests/unit/testsuite/Magento/Tools/Di/Compiler/ArgumentsResolverTest.php +++ b/dev/tests/unit/testsuite/Magento/Tools/Di/Compiler/ArgumentsResolverTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tools\Di\Compiler; class ArgumentsResolverTest extends \PHPUnit_Framework_TestCase diff --git a/dev/tests/unit/testsuite/Magento/Tools/Di/Definition/CollectionTest.php b/dev/tests/unit/testsuite/Magento/Tools/Di/Definition/CollectionTest.php index 21b2b5cca11dec72309d8dbd3718c40c83b8110f..b41a11b6c1e234e71f8dfbf2773fc4b423c58b0c 100644 --- a/dev/tests/unit/testsuite/Magento/Tools/Di/Definition/CollectionTest.php +++ b/dev/tests/unit/testsuite/Magento/Tools/Di/Definition/CollectionTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tools\Di\Definition; /** diff --git a/dev/tests/unit/testsuite/Magento/Tools/I18n/Parser/ParserTest.php b/dev/tests/unit/testsuite/Magento/Tools/I18n/Parser/ParserTest.php index 5c9ba57c3a13809713b8597b7a7d75e4495023ef..1371b705ecf8ed406176f37b1c9e9282a250945c 100644 --- a/dev/tests/unit/testsuite/Magento/Tools/I18n/Parser/ParserTest.php +++ b/dev/tests/unit/testsuite/Magento/Tools/I18n/Parser/ParserTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Tools\I18n\Parser; use Magento\Tools\I18n\Parser as Parser; diff --git a/dev/tests/unit/testsuite/Magento/Ui/Component/FilterPoolTest.php b/dev/tests/unit/testsuite/Magento/Ui/Component/FilterPoolTest.php index 2f1b6f707abb51bc28b07ca4e51b90be96cc433a..1873f02eec1b06b13ae90797e56ce0f21d2c5a01 100644 --- a/dev/tests/unit/testsuite/Magento/Ui/Component/FilterPoolTest.php +++ b/dev/tests/unit/testsuite/Magento/Ui/Component/FilterPoolTest.php @@ -148,6 +148,7 @@ class FilterPoolTest extends \PHPUnit_Framework_TestCase * Run test prepare method * * @return void + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function testPrepare() { diff --git a/dev/tests/unit/testsuite/Magento/Ui/Component/ListingTest.php b/dev/tests/unit/testsuite/Magento/Ui/Component/ListingTest.php index 2baffadf113c2c25835ded43879f37a2b7fe1d07..92819b91a1f6b9a10737af8f000c4d150a07b8aa 100644 --- a/dev/tests/unit/testsuite/Magento/Ui/Component/ListingTest.php +++ b/dev/tests/unit/testsuite/Magento/Ui/Component/ListingTest.php @@ -12,6 +12,9 @@ use Magento\Ui\Component\Listing\OptionsFactory; use Magento\Ui\Component\Listing\RowPool; use Magento\Ui\Context\ConfigurationFactory; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class ListingTest extends \PHPUnit_Framework_TestCase { /** diff --git a/dev/tests/unit/testsuite/Magento/UrlRewrite/Block/Catalog/Edit/FormTest.php b/dev/tests/unit/testsuite/Magento/UrlRewrite/Block/Catalog/Edit/FormTest.php index 5b2cb6669e0f2cfad181df24411f5faccd7b15cd..ac2af1521f01ad2ec3abaa475a9933d40bf58aa6 100644 --- a/dev/tests/unit/testsuite/Magento/UrlRewrite/Block/Catalog/Edit/FormTest.php +++ b/dev/tests/unit/testsuite/Magento/UrlRewrite/Block/Catalog/Edit/FormTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\UrlRewrite\Block\Catalog\Edit; use Magento\TestFramework\Helper\ObjectManager; diff --git a/dev/tests/unit/testsuite/Magento/UrlRewrite/Model/Storage/DbStorageTest.php b/dev/tests/unit/testsuite/Magento/UrlRewrite/Model/Storage/DbStorageTest.php index 15495e3e0c19e597add31475134055b917b57966..0d0df18749c3fb0fd5898cbfb85b54f887088d62 100644 --- a/dev/tests/unit/testsuite/Magento/UrlRewrite/Model/Storage/DbStorageTest.php +++ b/dev/tests/unit/testsuite/Magento/UrlRewrite/Model/Storage/DbStorageTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\UrlRewrite\Model\Storage; use Magento\Framework\App\Resource; diff --git a/dev/tests/unit/testsuite/Magento/Webapi/Controller/RestTest.php b/dev/tests/unit/testsuite/Magento/Webapi/Controller/RestTest.php index 6d3a0178846b8d3ddcd7ed0af0039e6dce3da220..bad175a1d6b75c69e1a83780c5fccff8991e037b 100644 --- a/dev/tests/unit/testsuite/Magento/Webapi/Controller/RestTest.php +++ b/dev/tests/unit/testsuite/Magento/Webapi/Controller/RestTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Webapi\Controller; use Magento\Authorization\Model\UserContextInterface; diff --git a/dev/tests/unit/testsuite/Magento/Webapi/Controller/Soap/Request/HandlerTest.php b/dev/tests/unit/testsuite/Magento/Webapi/Controller/Soap/Request/HandlerTest.php index a4c62ceab731c5efffb24a10d8aca786b2a88232..227db3f99c278383b328dbf6171975d0b9b0561b 100644 --- a/dev/tests/unit/testsuite/Magento/Webapi/Controller/Soap/Request/HandlerTest.php +++ b/dev/tests/unit/testsuite/Magento/Webapi/Controller/Soap/Request/HandlerTest.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Webapi\Controller\Soap\Request; use Magento\Framework\Api\SimpleDataObjectConverter; diff --git a/dev/tests/unit/testsuite/Magento/Webapi/_files/test_interfaces.php b/dev/tests/unit/testsuite/Magento/Webapi/_files/test_interfaces.php index d0d312be691d5e84b02d4056085db3fe9c91c459..b777c141eb81bf658fef378712093f40e271f240 100644 --- a/dev/tests/unit/testsuite/Magento/Webapi/_files/test_interfaces.php +++ b/dev/tests/unit/testsuite/Magento/Webapi/_files/test_interfaces.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Module\Service; /** diff --git a/dev/tests/unit/testsuite/Magento/Weee/Model/Attribute/Backend/Weee/TaxTest.php b/dev/tests/unit/testsuite/Magento/Weee/Model/Attribute/Backend/Weee/TaxTest.php index 6a2ad785605f313bf87af84a2e32255ddd0d9676..71e38fd6b8813d491b2d6f1c2a127661137ca543 100644 --- a/dev/tests/unit/testsuite/Magento/Weee/Model/Attribute/Backend/Weee/TaxTest.php +++ b/dev/tests/unit/testsuite/Magento/Weee/Model/Attribute/Backend/Weee/TaxTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Test class for \Magento\Weee\Model\Attribute\Backend\Weee\Tax */ diff --git a/dev/tests/unit/testsuite/Magento/Weee/Pricing/AdjustmentTest.php b/dev/tests/unit/testsuite/Magento/Weee/Pricing/AdjustmentTest.php index 4b0abf2d783cc09023cf1940bb103b7a88528986..118703306cd1760075b0879c7302fb28babd34c2 100644 --- a/dev/tests/unit/testsuite/Magento/Weee/Pricing/AdjustmentTest.php +++ b/dev/tests/unit/testsuite/Magento/Weee/Pricing/AdjustmentTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Weee\Pricing; use Magento\Framework\Pricing\Object\SaleableInterface; diff --git a/dev/tests/unit/testsuite/Magento/Wishlist/Controller/Index/CartTest.php b/dev/tests/unit/testsuite/Magento/Wishlist/Controller/Index/CartTest.php index 7120d0bfedc9331b03dc33dbcabd15ae63ccf2c0..e5b2e125e866bb7d4267cda5e019ea533bb168d5 100644 --- a/dev/tests/unit/testsuite/Magento/Wishlist/Controller/Index/CartTest.php +++ b/dev/tests/unit/testsuite/Magento/Wishlist/Controller/Index/CartTest.php @@ -6,6 +6,10 @@ namespace Magento\Wishlist\Controller\Index; +/** + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class CartTest extends \PHPUnit_Framework_TestCase { /** @@ -88,6 +92,9 @@ class CartTest extends \PHPUnit_Framework_TestCase */ protected $urlMock; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ protected function setUp() { $this->wishlistProviderMock = $this->getMockBuilder('Magento\Wishlist\Controller\WishlistProviderInterface') @@ -263,6 +270,9 @@ class CartTest extends \PHPUnit_Framework_TestCase $this->assertEquals($this->responseMock, $this->model->execute()); } + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function testExecuteWithQuantityArray() { $itemId = 2; @@ -473,6 +483,9 @@ class CartTest extends \PHPUnit_Framework_TestCase $this->assertEquals($this->responseMock, $this->model->execute()); } + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function testExecuteWithoutQuantityArrayAndOutOfStock() { $itemId = 2; @@ -633,6 +646,9 @@ class CartTest extends \PHPUnit_Framework_TestCase $this->assertEquals($this->responseMock, $this->model->execute()); } + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function testExecuteWithoutQuantityArrayAndConfigurable() { $itemId = 2; diff --git a/dev/tests/unit/testsuite/Magento/Wishlist/Model/Rss/WishlistTest.php b/dev/tests/unit/testsuite/Magento/Wishlist/Model/Rss/WishlistTest.php index 25835867f17d0663ac0951e047a499e9839a5f10..5ab6017080d670befceb66456d0b08439cbd9c70 100644 --- a/dev/tests/unit/testsuite/Magento/Wishlist/Model/Rss/WishlistTest.php +++ b/dev/tests/unit/testsuite/Magento/Wishlist/Model/Rss/WishlistTest.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Wishlist\Model\Rss; class WishlistTest extends \PHPUnit_Framework_TestCase diff --git a/lib/internal/Magento/Framework/Acl/Resource/Provider.php b/lib/internal/Magento/Framework/Acl/Resource/Provider.php index 73a405f88c27b68c65694eec9f818583291db4e8..c85b13805249a09920baacc9f81b394d09324074 100644 --- a/lib/internal/Magento/Framework/Acl/Resource/Provider.php +++ b/lib/internal/Magento/Framework/Acl/Resource/Provider.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Acl\Resource; class Provider implements ProviderInterface diff --git a/lib/internal/Magento/Framework/App/Action/Action.php b/lib/internal/Magento/Framework/App/Action/Action.php index 335d6d57a47b21b5ac76cb645f0fcfaa009c87d1..38e64f43b23e06331703729e065501a48a2628c7 100644 --- a/lib/internal/Magento/Framework/App/Action/Action.php +++ b/lib/internal/Magento/Framework/App/Action/Action.php @@ -12,6 +12,7 @@ use Magento\Framework\App\ResponseInterface; * Default implementation of application action controller * * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Action extends AbstractAction { diff --git a/lib/internal/Magento/Framework/Archive/Helper/File.php b/lib/internal/Magento/Framework/Archive/Helper/File.php index 9336f7af13bf3ca5ce44d14dabb0da9e3bed248a..f824c06a7b0410d0c13a9ea5aadd4b7c10143c27 100644 --- a/lib/internal/Magento/Framework/Archive/Helper/File.php +++ b/lib/internal/Magento/Framework/Archive/Helper/File.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Helper class that simplifies files stream reading and writing */ @@ -86,6 +88,7 @@ class File * @param int $chmod * @return void * @throws MagentoException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function open($mode = 'w+', $chmod = 0666) { diff --git a/lib/internal/Magento/Framework/Archive/Helper/File/Gz.php b/lib/internal/Magento/Framework/Archive/Helper/File/Gz.php index d3eca2ecd529c43fbdeb6330085ee68c5a35bc7d..52d18ed04f0430aa6206d48273fb01cd3ed6d4f7 100644 --- a/lib/internal/Magento/Framework/Archive/Helper/File/Gz.php +++ b/lib/internal/Magento/Framework/Archive/Helper/File/Gz.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Helper class that simplifies gz files stream reading and writing */ diff --git a/lib/internal/Magento/Framework/Archive/Tar.php b/lib/internal/Magento/Framework/Archive/Tar.php index 85a838cae1623ef7575c44de665483e643bd2314..d8a532e0cc25ac4213c2eaaf3ffe239f8ca8a707 100644 --- a/lib/internal/Magento/Framework/Archive/Tar.php +++ b/lib/internal/Magento/Framework/Archive/Tar.php @@ -311,6 +311,8 @@ class Tar extends \Magento\Framework\Archive\AbstractArchive implements \Magento * * @param bool $long * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _composeHeader($long = false) { @@ -380,6 +382,7 @@ class Tar extends \Magento\Framework\Archive\AbstractArchive implements \Magento * @param string $destination path to file is unpacked * @return string[] list of files * @throws \Magento\Framework\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _unpackCurrentTar($destination) { @@ -515,6 +518,7 @@ class Tar extends \Magento\Framework\Archive\AbstractArchive implements \Magento * @param string $destination * @param bool $skipRoot * @return string + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function pack($source, $destination, $skipRoot = false) { diff --git a/lib/internal/Magento/Framework/Backup/AbstractBackup.php b/lib/internal/Magento/Framework/Backup/AbstractBackup.php index fbf1d5375ea7abcb23703e342980c00413cd4a20..f980455dd5a6afd73d54141f63cf5cbff7d6778b 100644 --- a/lib/internal/Magento/Framework/Backup/AbstractBackup.php +++ b/lib/internal/Magento/Framework/Backup/AbstractBackup.php @@ -216,6 +216,7 @@ abstract class AbstractBackup implements BackupInterface * Check whether last operation completed successfully * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsSuccess() { diff --git a/lib/internal/Magento/Framework/Backup/Archive/Tar.php b/lib/internal/Magento/Framework/Backup/Archive/Tar.php index 8920bf2f730f6612df1203850b4b61fe9957084f..19d96a80a58498fac20f044fd8a0d4bcb7507fc3 100644 --- a/lib/internal/Magento/Framework/Backup/Archive/Tar.php +++ b/lib/internal/Magento/Framework/Backup/Archive/Tar.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Extended version of \Magento\Framework\Archive\Tar that supports filtering * diff --git a/lib/internal/Magento/Framework/Backup/Db/BackupFactory.php b/lib/internal/Magento/Framework/Backup/Db/BackupFactory.php index 8f0c18e8755288d43722c87c4d8c9af8dd328c2e..fc89599c1672a3b9bc147092dfb1bc23d489c50d 100644 --- a/lib/internal/Magento/Framework/Backup/Db/BackupFactory.php +++ b/lib/internal/Magento/Framework/Backup/Db/BackupFactory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Backup\Db; class BackupFactory diff --git a/lib/internal/Magento/Framework/Backup/Factory.php b/lib/internal/Magento/Framework/Backup/Factory.php index 6f680945b0663c1d3f2c3eb8bb7c97461aae24e1..ba120c45615844b441b490d86e5bd9ba8e3be44b 100644 --- a/lib/internal/Magento/Framework/Backup/Factory.php +++ b/lib/internal/Magento/Framework/Backup/Factory.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Backup; class Factory diff --git a/lib/internal/Magento/Framework/Backup/Filesystem.php b/lib/internal/Magento/Framework/Backup/Filesystem.php index e3a9cb1fd1bd5e5edc70410bfc88993a21719b3e..24ffe43be56c49f15cdc8fcdf4f85b45bbc50e04 100644 --- a/lib/internal/Magento/Framework/Backup/Filesystem.php +++ b/lib/internal/Magento/Framework/Backup/Filesystem.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Backup; /** diff --git a/lib/internal/Magento/Framework/Backup/Filesystem/Helper.php b/lib/internal/Magento/Framework/Backup/Filesystem/Helper.php index a549234baca5670e6135332936a78572f42171ed..5a2df37545d25b7ad98a628dedab4d505d86b63b 100644 --- a/lib/internal/Magento/Framework/Backup/Filesystem/Helper.php +++ b/lib/internal/Magento/Framework/Backup/Filesystem/Helper.php @@ -52,6 +52,7 @@ class Helper * @param bool $removeRoot * @return void * @throws \Magento\Framework\Exception + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function rm($path, $skipPaths = [], $removeRoot = false) { @@ -78,6 +79,8 @@ class Helper * @param int $infoOptions * @param array $skipFiles * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getInfo($path, $infoOptions = self::INFO_ALL, $skipFiles = []) { diff --git a/lib/internal/Magento/Framework/Backup/Filesystem/Rollback/Ftp.php b/lib/internal/Magento/Framework/Backup/Filesystem/Rollback/Ftp.php index b4510f077d81ad88748e1c5118135c7db33ee0c9..b9c0a9c6270db7bfac6e92fa5fad3df7211a69cf 100644 --- a/lib/internal/Magento/Framework/Backup/Filesystem/Rollback/Ftp.php +++ b/lib/internal/Magento/Framework/Backup/Filesystem/Rollback/Ftp.php @@ -158,6 +158,7 @@ class Ftp extends AbstractRollback * @param string $tmpDir * @return void * @throws \Magento\Framework\Exception + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _uploadBackupToFtp($tmpDir) { diff --git a/lib/internal/Magento/Framework/Cache/Backend/Database.php b/lib/internal/Magento/Framework/Cache/Backend/Database.php index fb2d2ebecf69d64acfe839e748a64dbe90af0ebe..b1233e1301b24e981d92dd8a0c98c02217390225 100644 --- a/lib/internal/Magento/Framework/Cache/Backend/Database.php +++ b/lib/internal/Magento/Framework/Cache/Backend/Database.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** Tables declaration: @@ -499,6 +501,7 @@ class Database extends \Zend_Cache_Backend implements \Zend_Cache_Backend_Extend * @param string $mode * @param string[] $tags * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _cleanByTags($mode, $tags) { diff --git a/lib/internal/Magento/Framework/Cache/Backend/Eaccelerator.php b/lib/internal/Magento/Framework/Cache/Backend/Eaccelerator.php index cf4e05ea3ffbf43910ffa87095f11497fc932a90..9a3d4272af4dcb8161a2c4daabfcf9484d55f257 100644 --- a/lib/internal/Magento/Framework/Cache/Backend/Eaccelerator.php +++ b/lib/internal/Magento/Framework/Cache/Backend/Eaccelerator.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Cache\Backend; class Eaccelerator extends \Zend_Cache_Backend implements \Zend_Cache_Backend_ExtendedInterface @@ -36,6 +39,7 @@ class Eaccelerator extends \Zend_Cache_Backend implements \Zend_Cache_Backend_Ex * @param string $id cache id * @param boolean $doNotTestCacheValidity if set to true, the cache validity won't be tested * @return string cached datas (or false) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function load($id, $doNotTestCacheValidity = false) { @@ -108,6 +112,7 @@ class Eaccelerator extends \Zend_Cache_Backend implements \Zend_Cache_Backend_Ex * @param string[] $tags array of tags * @throws \Zend_Cache_Exception * @return bool|void true if no problem + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function clean($mode = \Zend_Cache::CLEANING_MODE_ALL, $tags = []) { @@ -170,6 +175,7 @@ class Eaccelerator extends \Zend_Cache_Backend implements \Zend_Cache_Backend_Ex * * @param array $tags array of tags * @return string[] array of matching cache ids (string) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getIdsMatchingTags($tags = []) { @@ -184,6 +190,7 @@ class Eaccelerator extends \Zend_Cache_Backend implements \Zend_Cache_Backend_Ex * * @param string[] $tags array of tags * @return string[] array of not matching cache ids (string) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getIdsNotMatchingTags($tags = []) { @@ -198,6 +205,7 @@ class Eaccelerator extends \Zend_Cache_Backend implements \Zend_Cache_Backend_Ex * * @param string[] $tags array of tags * @return string[] array of any matching cache ids (string) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getIdsMatchingAnyTags($tags = []) { @@ -209,6 +217,7 @@ class Eaccelerator extends \Zend_Cache_Backend implements \Zend_Cache_Backend_Ex * Return an array of stored cache ids * * @return string[] array of stored cache ids (string) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getIds() { @@ -230,6 +239,7 @@ class Eaccelerator extends \Zend_Cache_Backend implements \Zend_Cache_Backend_Ex * * @param string $id cache id * @return array|false array of metadatas (false if the cache id is not found) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getMetadatas($id) { diff --git a/lib/internal/Magento/Framework/Code/Reader/ArgumentsReader.php b/lib/internal/Magento/Framework/Code/Reader/ArgumentsReader.php index 697903f2504dc9e1d23ef6ef1cf91257b3b3ecd3..98eafe0f910928432718435f533c032980bd8e38 100644 --- a/lib/internal/Magento/Framework/Code/Reader/ArgumentsReader.php +++ b/lib/internal/Magento/Framework/Code/Reader/ArgumentsReader.php @@ -16,6 +16,8 @@ class ArgumentsReader * @param bool $groupByPosition * @param bool $inherited * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getConstructorArguments(\ReflectionClass $class, $groupByPosition = false, $inherited = false) { diff --git a/lib/internal/Magento/Framework/Code/Reader/SourceArgumentsReader.php b/lib/internal/Magento/Framework/Code/Reader/SourceArgumentsReader.php index c31fa9c00d8abd8a1620b08d0943dcb031e9bf13..29b48c744ba5ce72730faebe0cb820a8276da4a8 100644 --- a/lib/internal/Magento/Framework/Code/Reader/SourceArgumentsReader.php +++ b/lib/internal/Magento/Framework/Code/Reader/SourceArgumentsReader.php @@ -18,6 +18,9 @@ class SourceArgumentsReader * @param \ReflectionClass $class * @param bool $inherited * @return array List of constructor argument types. + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getConstructorArgumentTypes(\ReflectionClass $class, $inherited = false) { @@ -115,6 +118,7 @@ class SourceArgumentsReader * * @param array $file * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function getImportedNamespaces(array $file) { diff --git a/lib/internal/Magento/Framework/Code/Validator/ArgumentSequence.php b/lib/internal/Magento/Framework/Code/Validator/ArgumentSequence.php index 08fa179c95d0a4386b41df6336004329ffa5b891..382983e35db84b77357773a611b84258a81ef57a 100644 --- a/lib/internal/Magento/Framework/Code/Validator/ArgumentSequence.php +++ b/lib/internal/Magento/Framework/Code/Validator/ArgumentSequence.php @@ -40,6 +40,7 @@ class ArgumentSequence implements ValidatorInterface * @param string $className * @return bool * @throws ValidationException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function validate($className) { @@ -135,6 +136,8 @@ class ArgumentSequence implements ValidatorInterface * @param array $classArguments * @param array $parentArguments * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _buildsSequence(array $classArguments, array $parentArguments = []) { diff --git a/lib/internal/Magento/Framework/Code/Validator/ConstructorIntegrity.php b/lib/internal/Magento/Framework/Code/Validator/ConstructorIntegrity.php index 321ba05b1e7492adb7a55a72ebf7257c542ca5c5..63929f4a08ad7e24c1ff2ef93d3949fff6c7e7c9 100644 --- a/lib/internal/Magento/Framework/Code/Validator/ConstructorIntegrity.php +++ b/lib/internal/Magento/Framework/Code/Validator/ConstructorIntegrity.php @@ -30,6 +30,8 @@ class ConstructorIntegrity implements ValidatorInterface * @param string $className * @return bool * @throws \Magento\Framework\Code\ValidationException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function validate($className) { diff --git a/lib/internal/Magento/Framework/Config/Composer/Package.php b/lib/internal/Magento/Framework/Config/Composer/Package.php index ce9742f2c384f24a9fd21c66d39ea4903f899281..e9c3dfdab2fecc9b675310dcb97af370e01d0a85 100644 --- a/lib/internal/Magento/Framework/Config/Composer/Package.php +++ b/lib/internal/Magento/Framework/Config/Composer/Package.php @@ -59,6 +59,7 @@ class Package * @param string $propertyPath * @param string $filter pattern to filter out the properties * @return mixed + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function get($propertyPath, $filter = null) { diff --git a/lib/internal/Magento/Framework/Config/Data.php b/lib/internal/Magento/Framework/Config/Data.php index 8579c742b8e2e71483431cc952523077123aaedc..f3c09c5da4028cf3c6738fcdf1e4d813705df256 100644 --- a/lib/internal/Magento/Framework/Config/Data.php +++ b/lib/internal/Magento/Framework/Config/Data.php @@ -7,6 +7,9 @@ */ namespace Magento\Framework\Config; +/** + * @SuppressWarnings(PHPMD.NumberOfChildren) + */ class Data implements \Magento\Framework\Config\DataInterface { /** diff --git a/lib/internal/Magento/Framework/Config/Dom.php b/lib/internal/Magento/Framework/Config/Dom.php index fa789f9346b58846e1470e77c7d1c97e05b6c1d4..57c18e8e6eb021cde44233bfaa54e6d2cc06ef46 100644 --- a/lib/internal/Magento/Framework/Config/Dom.php +++ b/lib/internal/Magento/Framework/Config/Dom.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Magento configuration XML DOM utility */ @@ -114,6 +116,7 @@ class Dom * @param \DOMElement $node * @param string $parentPath path to parent node * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _mergeNode(\DOMElement $node, $parentPath) { diff --git a/lib/internal/Magento/Framework/Config/Theme.php b/lib/internal/Magento/Framework/Config/Theme.php index 16a583ac2d1367e35d8520b4e04c75161e12983f..aaa6c4f95a45da7d2ed5bec0641783e61952efa7 100644 --- a/lib/internal/Magento/Framework/Config/Theme.php +++ b/lib/internal/Magento/Framework/Config/Theme.php @@ -50,6 +50,7 @@ class Theme * * @param string $configContent * @return array + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _extractData($configContent) { diff --git a/lib/internal/Magento/Framework/CurrencyFactory.php b/lib/internal/Magento/Framework/CurrencyFactory.php index 69f58e8255096955e0c7a5d3a2ee99bea4070f1e..a1a126aecd1f99f568e00437842cd9e652184fb6 100644 --- a/lib/internal/Magento/Framework/CurrencyFactory.php +++ b/lib/internal/Magento/Framework/CurrencyFactory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework; class CurrencyFactory diff --git a/lib/internal/Magento/Framework/DB/AbstractMapper.php b/lib/internal/Magento/Framework/DB/AbstractMapper.php index 2bc7d790dedd6b60bb4510086f6bca1875a963cc..7a1206c095b87ab59a779acd070667961b1c946d 100644 --- a/lib/internal/Magento/Framework/DB/AbstractMapper.php +++ b/lib/internal/Magento/Framework/DB/AbstractMapper.php @@ -15,6 +15,7 @@ use Magento\Framework\Object; /** * Class AbstractMapper * @package Magento\Framework\DB + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ abstract class AbstractMapper implements MapperInterface { diff --git a/lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php b/lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php index 654a741fcbe1c14ce18f96867752ec62c81814f5..83467bf6bcc316c254cdc91f4fd5809da49d9948 100644 --- a/lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php +++ b/lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\DB\Adapter\Pdo; use Magento\Framework\Cache\FrontendInterface; @@ -18,6 +21,12 @@ use Magento\Framework\DB\Statement\Parameter; use Magento\Framework\Stdlib\DateTime; use Magento\Framework\Stdlib\String; +/** + * @SuppressWarnings(PHPMD.ExcessivePublicCount) + * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface { const TIMESTAMP_FORMAT = 'Y-m-d H:i:s'; @@ -400,6 +409,7 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * @param mixed $bind An array of data or data itself to bind to the placeholders. * @return \Zend_Db_Statement_Pdo|void * @throws \Zend_Db_Adapter_Exception To re-throw \PDOException. + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function query($sql, $bind = []) { @@ -651,6 +661,8 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * * @param string $sql * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _splitMultiQuery($sql) { @@ -1130,6 +1142,9 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * * @param array $tables * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function modifyTables($tables) { @@ -1516,6 +1531,8 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * * @param array $columnData * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getColumnCreateByDescribe($columnData) { @@ -1657,6 +1674,7 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * * @param array $column * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _getColumnTypeByDdl($column) { @@ -1753,6 +1771,8 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * @param array $fields update fields pairs or values * @return int The number of affected rows. * @throws \Zend_Db_Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function insertOnDuplicate($table, array $data, array $fields = []) { @@ -1959,6 +1979,7 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * @param \Magento\Framework\DB\Ddl\Table $table * @throws \Zend_Db_Exception * @return \Zend_Db_Pdo_Statement + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function createTemporaryTable(\Magento\Framework\DB\Ddl\Table $table) { @@ -2193,6 +2214,10 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * @throws \Magento\Framework\Exception * @return string * @throws \Zend_Db_Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ protected function _getColumnDefinition($options, $ddlType = null) { @@ -2428,6 +2453,8 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * @return \Zend_Db_Statement_Interface * @throws \Zend_Db_Exception * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function addIndex( $tableName, @@ -2553,6 +2580,7 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * @param string $schemaName * @param string $refSchemaName * @return \Zend_Db_Statement_Interface + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function addForeignKey( $fkName, @@ -2667,6 +2695,7 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * @param string $fieldName * @param integer|string|array $condition * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function prepareSqlCondition($fieldName, $condition) { @@ -2773,6 +2802,9 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * @param array $column the column describe array * @param mixed $value * @return mixed + * + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function prepareColumnValue(array $column, $value) { @@ -3358,6 +3390,8 @@ class Mysql extends \Zend_Db_Adapter_Pdo_Mysql implements AdapterInterface * @param string|array $table * @return string * @throws \Magento\Framework\DB\DBException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function updateFromSelect(Select $select, $table) { diff --git a/lib/internal/Magento/Framework/DB/Ddl/Table.php b/lib/internal/Magento/Framework/DB/Ddl/Table.php index ec7fe5d3385f638b1c754877cbbe044292d9224a..f1044732a712352479defd67010779f08e065b41 100644 --- a/lib/internal/Magento/Framework/DB/Ddl/Table.php +++ b/lib/internal/Magento/Framework/DB/Ddl/Table.php @@ -270,6 +270,9 @@ class Table * @param string $comment column description * @return $this * @throws \Zend_Db_Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function addColumn($name, $type, $size = null, $options = [], $comment = null) { @@ -405,6 +408,7 @@ class Table * @param string $onUpdate the action on update * @return $this * @throws \Zend_Db_Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function addForeignKey($fkName, $column, $refTable, $refColumn, $onDelete = null, $onUpdate = null) { @@ -455,6 +459,7 @@ class Table * @param array $options array of additional options * @return $this * @throws \Zend_Db_Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function addIndex($indexName, $fields, $options = []) { diff --git a/lib/internal/Magento/Framework/DB/GenericMapper.php b/lib/internal/Magento/Framework/DB/GenericMapper.php index 5b507baf56ce0f3f3462ea9a3840f9e5e0d4330f..d3e07450ae4736a4ac151075c505273729b32ac4 100644 --- a/lib/internal/Magento/Framework/DB/GenericMapper.php +++ b/lib/internal/Magento/Framework/DB/GenericMapper.php @@ -87,6 +87,7 @@ class GenericMapper extends AbstractMapper * @param array $fields * @throws \Zend_Db_Select_Exception * @return void + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function mapFields(array $fields) { diff --git a/lib/internal/Magento/Framework/DB/Helper.php b/lib/internal/Magento/Framework/DB/Helper.php index 59107055c6eae70862a27110d3e4c4b25f93a27f..31f404f4867b722ba850139c99626dc490b6767b 100644 --- a/lib/internal/Magento/Framework/DB/Helper.php +++ b/lib/internal/Magento/Framework/DB/Helper.php @@ -182,6 +182,8 @@ class Helper extends \Magento\Framework\DB\Helper\AbstractHelper * @param string|null $groupByCondition OPTIONAL * @return mixed|array * @throws \Zend_Db_Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function prepareColumnsList(\Magento\Framework\DB\Select $select, $groupByCondition = null) { diff --git a/lib/internal/Magento/Framework/DB/MapperFactory.php b/lib/internal/Magento/Framework/DB/MapperFactory.php index 495578f6261bd316ebd209a8e656df6d9bfb03a6..0c701803e9b30b750174c7020d1d6bbaf164f9c0 100644 --- a/lib/internal/Magento/Framework/DB/MapperFactory.php +++ b/lib/internal/Magento/Framework/DB/MapperFactory.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\DB; /** diff --git a/lib/internal/Magento/Framework/DB/QueryFactory.php b/lib/internal/Magento/Framework/DB/QueryFactory.php index 90420d2c7cf05040007993d3253fa340619b3016..a78004fb03e48c4565b28379e825ebdbf3ad91d0 100644 --- a/lib/internal/Magento/Framework/DB/QueryFactory.php +++ b/lib/internal/Magento/Framework/DB/QueryFactory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\DB; /** diff --git a/lib/internal/Magento/Framework/DB/Select.php b/lib/internal/Magento/Framework/DB/Select.php index 2892a57da352ae5ff08fa4009c24e1c089d65577..41e87249ca198f4abecd7d2b42ef0a2d74b6fc94 100644 --- a/lib/internal/Magento/Framework/DB/Select.php +++ b/lib/internal/Magento/Framework/DB/Select.php @@ -184,6 +184,8 @@ class Select extends \Zend_Db_Select * Reset unused LEFT JOIN(s) * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function resetJoinLeft() { diff --git a/lib/internal/Magento/Framework/DB/Statement/Parameter.php b/lib/internal/Magento/Framework/DB/Statement/Parameter.php index b1ada9687946f5172054056696cb6cdd8bddbadf..f7f887ff59fc4425e043a5dbfa70aef6888001ab 100644 --- a/lib/internal/Magento/Framework/DB/Statement/Parameter.php +++ b/lib/internal/Magento/Framework/DB/Statement/Parameter.php @@ -115,6 +115,7 @@ class Parameter * @return bool * * @see setIsBlob + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsBlob() { diff --git a/lib/internal/Magento/Framework/DB/Statement/Pdo/Mysql.php b/lib/internal/Magento/Framework/DB/Statement/Pdo/Mysql.php index 62a60436df2d3c582cb460fbe1f6aaa4acf009ba..0a98d1f658fa86e3271c50e6a7f58e35cfe882fe 100644 --- a/lib/internal/Magento/Framework/DB/Statement/Pdo/Mysql.php +++ b/lib/internal/Magento/Framework/DB/Statement/Pdo/Mysql.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Mysql DB Statement * @@ -22,6 +24,7 @@ class Mysql extends \Zend_Db_Statement_Pdo * @param array $params Array of values to bind to parameter placeholders. * @return bool * @throws \Zend_Db_Statement_Exception + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function _executeWithBinding(array $params) { diff --git a/lib/internal/Magento/Framework/DB/Tree.php b/lib/internal/Magento/Framework/DB/Tree.php index 93080bf7d650716c54cc9aef67a55913fe897043..e0a7b800b5df3925c8478680a09e815487a620f8 100644 --- a/lib/internal/Magento/Framework/DB/Tree.php +++ b/lib/internal/Magento/Framework/DB/Tree.php @@ -16,6 +16,9 @@ use Magento\Framework\DB\Tree\TreeException; * Magento Library */ require_once 'Tree/TreeException.php'; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Tree { /** @@ -77,6 +80,8 @@ class Tree /** * @param array $config * @throws TreeException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function __construct($config = []) { @@ -274,6 +279,7 @@ class Tree * @param string|int $nodeId * @param array $data * @return false|string + * @SuppressWarnings(PHPMD.ExitExpression) */ public function appendChild($nodeId, $data) { @@ -441,6 +447,10 @@ class Tree * @param string|int $pId * @param string|int $aId * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * @SuppressWarnings(PHPMD.ExitExpression) */ public function moveNode($eId, $pId, $aId = 0) { @@ -771,6 +781,11 @@ class Tree * @param string|int $pId * @param string|int $aId * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) + * @SuppressWarnings(PHPMD.ExitExpression) */ public function moveNodes($eId, $pId, $aId = 0) { @@ -991,6 +1006,7 @@ class Tree * @param int $startLevel * @param int $endLevel * @return NodeSet + * @SuppressWarnings(PHPMD.ExitExpression) */ public function getChildren($nodeId, $startLevel = 0, $endLevel = 0) { diff --git a/lib/internal/Magento/Framework/DB/Tree/Node.php b/lib/internal/Magento/Framework/DB/Tree/Node.php index 397081bc5a22d11c9916540f9c33bc340a7b6877..80aa840e9de0563351cfc43171d2e0ab75e5f8c5 100644 --- a/lib/internal/Magento/Framework/DB/Tree/Node.php +++ b/lib/internal/Magento/Framework/DB/Tree/Node.php @@ -7,6 +7,9 @@ namespace Magento\Framework\DB\Tree; use Magento\Framework\DB\Tree\Node\NodeException; +/** + * @SuppressWarnings(PHPMD.UnusedPrivateField) + */ class Node { /** diff --git a/lib/internal/Magento/Framework/Data/Collection.php b/lib/internal/Magento/Framework/Data/Collection.php index 979c258772a3f23c4a83208373a3d12f7b5781c1..72c51669064cdd51c21e782e177545db45d907be 100644 --- a/lib/internal/Magento/Framework/Data/Collection.php +++ b/lib/internal/Magento/Framework/Data/Collection.php @@ -167,6 +167,7 @@ class Collection implements \IteratorAggregate, \Countable, ArrayInterface, Coll * @param string|int|array $condition * @throws \Magento\Framework\Exception if some error in the input could be detected. * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function addFieldToFilter($field, $condition) { @@ -646,6 +647,7 @@ class Collection implements \IteratorAggregate, \Countable, ArrayInterface, Coll * * @param bool $flag * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function distinct($flag) { @@ -658,6 +660,7 @@ class Collection implements \IteratorAggregate, \Countable, ArrayInterface, Coll * @param bool $printQuery * @param bool $logQuery * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function loadData($printQuery = false, $logQuery = false) { diff --git a/lib/internal/Magento/Framework/Data/Collection/Db.php b/lib/internal/Magento/Framework/Data/Collection/Db.php index 61eef60817afdc9027a34c9dbd18c3a694f42f77..3b7dc9de3a9b0f7eaad48c1d9d1acfcc4d741865 100644 --- a/lib/internal/Magento/Framework/Data/Collection/Db.php +++ b/lib/internal/Magento/Framework/Data/Collection/Db.php @@ -12,6 +12,7 @@ use Psr\Log\LoggerInterface as Logger; /** * Base items collection class + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Db extends \Magento\Framework\Data\Collection { diff --git a/lib/internal/Magento/Framework/Data/Collection/Filesystem.php b/lib/internal/Magento/Framework/Data/Collection/Filesystem.php index 19d7da09b2d2a940b3e211b1700cacac7ce4058e..817c4b420519697de1ad27984ca0d286e151a125 100644 --- a/lib/internal/Magento/Framework/Data/Collection/Filesystem.php +++ b/lib/internal/Magento/Framework/Data/Collection/Filesystem.php @@ -231,6 +231,8 @@ class Filesystem extends \Magento\Framework\Data\Collection * * @param string|array $dir * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _collectRecursive($dir) { @@ -433,6 +435,8 @@ class Filesystem extends \Magento\Framework\Data\Collection * * @param array $row * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + * @SuppressWarnings(PHPMD.EvalExpression) */ protected function _filterRow($row) { @@ -474,6 +478,7 @@ class Filesystem extends \Magento\Framework\Data\Collection * @param callback $callback * @param array $callbackParams * @return bool + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _invokeFilter($callback, $callbackParams) { @@ -492,6 +497,9 @@ class Filesystem extends \Magento\Framework\Data\Collection * @param string $type 'and' | 'or' * @see Db::addFieldToFilter() * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function addFieldToFilter($field, $cond, $type = 'and') { @@ -731,6 +739,7 @@ class Filesystem extends \Magento\Framework\Data\Collection * @return bool * @see addFieldToFilter() * @see addCallbackFilter() + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function filterCallbackIsNull($field, $filterValue, $row) { diff --git a/lib/internal/Magento/Framework/Data/Form/Element/AbstractElement.php b/lib/internal/Magento/Framework/Data/Form/Element/AbstractElement.php index 69190f8863cd617f5d15a0afa5b5e1fa4bc228af..5583f90b9e6ae3d83641bb33dd4174dc08960c6c 100644 --- a/lib/internal/Magento/Framework/Data/Form/Element/AbstractElement.php +++ b/lib/internal/Magento/Framework/Data/Form/Element/AbstractElement.php @@ -14,6 +14,7 @@ use Magento\Framework\Escaper; * Data form abstract class * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractElement extends AbstractForm { @@ -530,6 +531,7 @@ abstract class AbstractElement extends AbstractForm * @param string|int|array $values * @param bool $overwrite * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function addElementValues($values, $overwrite = false) { diff --git a/lib/internal/Magento/Framework/Data/Form/Element/Checkbox.php b/lib/internal/Magento/Framework/Data/Form/Element/Checkbox.php index 689a569e592bb61cb677dcce1309a2e8a61aeeb1..7f079c6e1b514093f27447a60278a9537f867688 100644 --- a/lib/internal/Magento/Framework/Data/Form/Element/Checkbox.php +++ b/lib/internal/Magento/Framework/Data/Form/Element/Checkbox.php @@ -52,6 +52,7 @@ class Checkbox extends AbstractElement /** * @return string + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getElementHtml() { @@ -79,6 +80,7 @@ class Checkbox extends AbstractElement * Return check status of checkbox * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsChecked() { diff --git a/lib/internal/Magento/Framework/Data/Form/Element/Editor.php b/lib/internal/Magento/Framework/Data/Form/Element/Editor.php index 4bfeea0ded5b960cf038c96c3fcf9a35d78f807b..c8e58d064926d4e0aff3ec2aea9aba1f4c911f94 100644 --- a/lib/internal/Magento/Framework/Data/Form/Element/Editor.php +++ b/lib/internal/Magento/Framework/Data/Form/Element/Editor.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Data\Form\Element; use Magento\Framework\Escaper; @@ -39,6 +42,7 @@ class Editor extends Textarea /** * @return string + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function getElementHtml() { @@ -218,6 +222,8 @@ class Editor extends Textarea * * @param bool $visible Display button or not * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getPluginButtonsHtml($visible = true) { @@ -332,6 +338,7 @@ class Editor extends Textarea * * @param array $data Button params * @return string + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _getButtonHtml($data) { diff --git a/lib/internal/Magento/Framework/Data/Form/Element/Gallery.php b/lib/internal/Magento/Framework/Data/Form/Element/Gallery.php index fa022498d35530189eff3b601e08efce8b2004f2..cc2798e8f702cf4e5cb860b17a3283a093f89de3 100644 --- a/lib/internal/Magento/Framework/Data/Form/Element/Gallery.php +++ b/lib/internal/Magento/Framework/Data/Form/Element/Gallery.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Category form input image element * @@ -33,6 +35,8 @@ class Gallery extends AbstractElement /** * @return string + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getElementHtml() { diff --git a/lib/internal/Magento/Framework/Data/Form/Element/Multiline.php b/lib/internal/Magento/Framework/Data/Form/Element/Multiline.php index 3439846888ee59e2d20f8fbb3f878d7b76ac96d3..e596cc69c7ffe7a96de2f60f3554f7010a2cddde 100644 --- a/lib/internal/Magento/Framework/Data/Form/Element/Multiline.php +++ b/lib/internal/Magento/Framework/Data/Form/Element/Multiline.php @@ -101,6 +101,7 @@ class Multiline extends AbstractElement /** * @return mixed + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getDefaultHtml() { diff --git a/lib/internal/Magento/Framework/Data/Form/Element/Time.php b/lib/internal/Magento/Framework/Data/Form/Element/Time.php index d23418c1453afa66c3c16e8f38a1880c4092356d..3fe64c7b21106eb00e3fc2b772a8c63d81b3892f 100644 --- a/lib/internal/Magento/Framework/Data/Form/Element/Time.php +++ b/lib/internal/Magento/Framework/Data/Form/Element/Time.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Form time element * @@ -45,6 +47,8 @@ class Time extends AbstractElement /** * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getElementHtml() { diff --git a/lib/internal/Magento/Framework/Data/FormFactory.php b/lib/internal/Magento/Framework/Data/FormFactory.php index 8b31904077ddf4e1b074d78bc3c861d1c56c4c16..cd35382e2644672c17e2d5cbe458835172fde526 100644 --- a/lib/internal/Magento/Framework/Data/FormFactory.php +++ b/lib/internal/Magento/Framework/Data/FormFactory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Data; /** diff --git a/lib/internal/Magento/Framework/Data/Tree.php b/lib/internal/Magento/Framework/Data/Tree.php index 79ec96e3ec135864320d0b51e3c2eb24a49a1118..767d7d8c1766cc78866ec4e1788e168eb96e5e18 100644 --- a/lib/internal/Magento/Framework/Data/Tree.php +++ b/lib/internal/Magento/Framework/Data/Tree.php @@ -46,6 +46,7 @@ class Tree * * @param Node $parentNode * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function load($parentNode = null) { @@ -56,6 +57,7 @@ class Tree * * @param int|string $nodeId * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function loadNode($nodeId) { @@ -68,6 +70,7 @@ class Tree * @param Node $parentNode * @param Node $prevNode * @return Node + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function appendChild($data, $parentNode, $prevNode = null) { @@ -103,6 +106,7 @@ class Tree * @param Node $parentNode * @param Node $prevNode * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function moveNodeTo($node, $parentNode, $prevNode = null) { @@ -115,6 +119,7 @@ class Tree * @param Node $parentNode * @param Node $prevNode * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function copyNodeTo($node, $parentNode, $prevNode = null) { @@ -142,6 +147,7 @@ class Tree * @param Node $parentNode * @param Node $prevNode * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function createNode($parentNode, $prevNode = null) { @@ -152,6 +158,7 @@ class Tree * * @param Node $node * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getChild($node) { @@ -162,6 +169,7 @@ class Tree * * @param Node $node * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getChildren($node) { diff --git a/lib/internal/Magento/Framework/Data/Tree/Node.php b/lib/internal/Magento/Framework/Data/Tree/Node.php index 747e5a755e9b27ab98f20154bae39de938e4126d..69bb2b8d4747492bc401243e1e1243ed43d1d3c6 100644 --- a/lib/internal/Magento/Framework/Data/Tree/Node.php +++ b/lib/internal/Magento/Framework/Data/Tree/Node.php @@ -169,6 +169,7 @@ class Node extends \Magento\Framework\Object /** * @param Node $node * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function isChildOf($node) { diff --git a/lib/internal/Magento/Framework/Debug.php b/lib/internal/Magento/Framework/Debug.php index 8c42e03489b57a8d942f9dfe76e0767725847781..b1c3ecacd1ff71f749678d4d904ff73d643afb39 100644 --- a/lib/internal/Magento/Framework/Debug.php +++ b/lib/internal/Magento/Framework/Debug.php @@ -61,6 +61,8 @@ class Debug * @param bool $html output in HTML format * @param bool $withArgs add short arguments of methods * @return string|bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public static function trace(array $trace, $return = false, $html = true, $withArgs = true) { @@ -141,6 +143,7 @@ class Debug * * @param mixed $arg * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected static function _formatCalledArgument($arg) { diff --git a/lib/internal/Magento/Framework/Encryption/Crypt.php b/lib/internal/Magento/Framework/Encryption/Crypt.php index 1cb3f7ab0349face1424da81c560687e97a067b3..9185fc38c03fa08e8a0d49d643cf49f267c3adfe 100644 --- a/lib/internal/Magento/Framework/Encryption/Crypt.php +++ b/lib/internal/Magento/Framework/Encryption/Crypt.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Encryption; /** diff --git a/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php b/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php index d536031ab0d16fe43cff175ead340d60550f0ec8..ede5035b9f945c5daaed59661a8afbd23f69b1a0 100644 --- a/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php +++ b/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Event\Invoker; use Magento\Framework\Event\Observer; diff --git a/lib/internal/Magento/Framework/Event/Observer/Cron.php b/lib/internal/Magento/Framework/Event/Observer/Cron.php index 39ae34a5116af3a1b3046c2c78340ca7286a2bcf..8a0cdcd7f31a0370b1fbf73f068f0559240a8759 100644 --- a/lib/internal/Magento/Framework/Event/Observer/Cron.php +++ b/lib/internal/Magento/Framework/Event/Observer/Cron.php @@ -20,6 +20,7 @@ class Cron extends \Magento\Framework\Event\Observer * * @param \Magento\Framework\Event $event * @return boolean + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function isValidFor(\Magento\Framework\Event $event) { @@ -63,6 +64,8 @@ class Cron extends \Magento\Framework\Event\Observer * @param string $expr * @param int $num * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function matchCronExpression($expr, $num) { diff --git a/lib/internal/Magento/Framework/File/Csv.php b/lib/internal/Magento/Framework/File/Csv.php index 95e7921a5d2a63e9c7579c50a2aea8fd965b41e1..4844401ac672ad7d3d66571aa9c903f661fecd3f 100644 --- a/lib/internal/Magento/Framework/File/Csv.php +++ b/lib/internal/Magento/Framework/File/Csv.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\File; /** @@ -137,6 +140,7 @@ class Csv * @param string $delimiter * @param string $enclosure * @return int + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function fputcsv(&$handle, $fields = [], $delimiter = ',', $enclosure = '"') { diff --git a/lib/internal/Magento/Framework/File/CsvMulty.php b/lib/internal/Magento/Framework/File/CsvMulty.php index de0897c4f8134c7538be28babf64acb6c8c43d69..71de4e8f7d269bb957613f85df9868c9df908c2a 100644 --- a/lib/internal/Magento/Framework/File/CsvMulty.php +++ b/lib/internal/Magento/Framework/File/CsvMulty.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Csv parse * diff --git a/lib/internal/Magento/Framework/File/Transfer/Adapter/Http.php b/lib/internal/Magento/Framework/File/Transfer/Adapter/Http.php index b56823b01e492070d9ab72ed6b38f9cca94bca7a..0cd0fe3eac6bde8a9ea4e7a7ec9bb84be5eeb6d3 100644 --- a/lib/internal/Magento/Framework/File/Transfer/Adapter/Http.php +++ b/lib/internal/Magento/Framework/File/Transfer/Adapter/Http.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\File\Transfer\Adapter; class Http diff --git a/lib/internal/Magento/Framework/File/Uploader.php b/lib/internal/Magento/Framework/File/Uploader.php index 885de2b8d63f0709ee546bcaf9b3a1b633f2d082..cfc862a635bc137a62320b56ff2563fcdbb2a529 100644 --- a/lib/internal/Magento/Framework/File/Uploader.php +++ b/lib/internal/Magento/Framework/File/Uploader.php @@ -170,6 +170,7 @@ class Uploader * * @param array $result * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _afterSave($result) { @@ -184,6 +185,7 @@ class Uploader * @param string $newFileName * @return array * @throws \Exception + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function save($destinationFolder, $newFileName = null) { @@ -487,6 +489,7 @@ class Uploader * @param string|array $fileId * @return void * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ private function _setUploadFileId($fileId) { diff --git a/lib/internal/Magento/Framework/Filesystem/Driver/Http.php b/lib/internal/Magento/Framework/Filesystem/Driver/Http.php index e025c61a4ebba705cdb10460c459d76b5e2581cf..09586e4576124964fcf01fc201fbf31a6a98e0c6 100644 --- a/lib/internal/Magento/Framework/Filesystem/Driver/Http.php +++ b/lib/internal/Magento/Framework/Filesystem/Driver/Http.php @@ -49,6 +49,7 @@ class Http extends File * * @param string $path * @return array + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function stat($path) { @@ -123,6 +124,7 @@ class Http extends File * @param string $mode * @return resource file * @throws FilesystemException + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function fileOpen($path, $mode) { @@ -202,6 +204,7 @@ class Http extends File * @param string $path * @param string|null $scheme * @return string + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getAbsolutePath($basePath, $path, $scheme = null) { diff --git a/lib/internal/Magento/Framework/Filter/Input.php b/lib/internal/Magento/Framework/Filter/Input.php index fb2f1988ba719e8fde6bf6055df0fb92f3c0c665..cfcf50919a28f0f8ddd45d41da9ed53284c0f4e1 100644 --- a/lib/internal/Magento/Framework/Filter/Input.php +++ b/lib/internal/Magento/Framework/Filter/Input.php @@ -206,6 +206,7 @@ class Input implements \Zend_Filter_Interface * @param bool $isFilterListSimple * @return array * @throws \Exception when filter is not found or not instance of defined instances + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _filter(array $data, &$filters = null, $isFilterListSimple = false) { diff --git a/lib/internal/Magento/Framework/Filter/Input/MaliciousCode.php b/lib/internal/Magento/Framework/Filter/Input/MaliciousCode.php index 4d34329cae59c39e783d401fcb5b0037d9bf317e..72d30d3373709f369d338855d1c9271db7a3e8b8 100644 --- a/lib/internal/Magento/Framework/Filter/Input/MaliciousCode.php +++ b/lib/internal/Magento/Framework/Filter/Input/MaliciousCode.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Filter\Input; class MaliciousCode implements \Zend_Filter_Interface diff --git a/lib/internal/Magento/Framework/Filter/RemoveAccents.php b/lib/internal/Magento/Framework/Filter/RemoveAccents.php index ee71192ad0b1a6d0a45ec324f79ebfcbfbc5179f..fb153f56ed3c1cbd6c277ab5808db79cdc597046 100644 --- a/lib/internal/Magento/Framework/Filter/RemoveAccents.php +++ b/lib/internal/Magento/Framework/Filter/RemoveAccents.php @@ -26,6 +26,7 @@ class RemoveAccents implements \Zend_Filter_Interface /** * @param string $string * @return string + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function filter($string) { diff --git a/lib/internal/Magento/Framework/Filter/Template.php b/lib/internal/Magento/Framework/Filter/Template.php index 52a4ed62a0622ff533ac291ea08db3c6d54a3082..50db67715c20e9c3dd1adaea1bbb8e98a181cb4e 100644 --- a/lib/internal/Magento/Framework/Filter/Template.php +++ b/lib/internal/Magento/Framework/Filter/Template.php @@ -96,6 +96,7 @@ class Template implements \Zend_Filter_Interface * @param string $value * @return string * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function filter($value) { @@ -236,6 +237,7 @@ class Template implements \Zend_Filter_Interface * @param string $value raw parameters * @param string $default default value * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _getVariable($value, $default = '{no_value_defined}') { diff --git a/lib/internal/Magento/Framework/Filter/Template/Tokenizer/Parameter.php b/lib/internal/Magento/Framework/Filter/Template/Tokenizer/Parameter.php index 9b392e5330f8cf48bd70a3e3a9df9bea6b5f58eb..00161bf427edb7dd1449804bc1d496a0fe66f95e 100644 --- a/lib/internal/Magento/Framework/Filter/Template/Tokenizer/Parameter.php +++ b/lib/internal/Magento/Framework/Filter/Template/Tokenizer/Parameter.php @@ -36,6 +36,7 @@ class Parameter extends \Magento\Framework\Filter\Template\Tokenizer\AbstractTok * Get string value in parameters through tokenize * * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getValue() { diff --git a/lib/internal/Magento/Framework/Filter/Template/Tokenizer/Variable.php b/lib/internal/Magento/Framework/Filter/Template/Tokenizer/Variable.php index 531e6de40e1898fc0fb60dcde64f2a0572ceeeca..377219601d2d6481ff560f220b87d7fa71f7eae0 100644 --- a/lib/internal/Magento/Framework/Filter/Template/Tokenizer/Variable.php +++ b/lib/internal/Magento/Framework/Filter/Template/Tokenizer/Variable.php @@ -14,6 +14,7 @@ class Variable extends \Magento\Framework\Filter\Template\Tokenizer\AbstractToke * Tokenize string and return getted variable stack path * * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function tokenize() { @@ -59,6 +60,7 @@ class Variable extends \Magento\Framework\Filter\Template\Tokenizer\AbstractToke * Get string value for method args * * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getString() { diff --git a/lib/internal/Magento/Framework/Gdata/Gshopping/Entry.php b/lib/internal/Magento/Framework/Gdata/Gshopping/Entry.php index b12e717f9f8c995520a9812ca00d2376bdc17496..275489ecdc2919be679a591c4441c21a1b050cef 100644 --- a/lib/internal/Magento/Framework/Gdata/Gshopping/Entry.php +++ b/lib/internal/Magento/Framework/Gdata/Gshopping/Entry.php @@ -78,6 +78,7 @@ class Entry extends \Zend_Gdata_Entry * * @param \DOMNode $child The \DOMNode to process * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function takeChildFromDOM($child) { @@ -223,6 +224,7 @@ class Entry extends \Zend_Gdata_Entry * * @param string $name The name of the Content attribute to look for * @return string[] $matches Array of Attribute + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function getContentAttributesByName($name) { diff --git a/lib/internal/Magento/Framework/Gdata/Gshopping/HttpException.php b/lib/internal/Magento/Framework/Gdata/Gshopping/HttpException.php index f1f61974937de5a86023e90e45c46e04de24d8a6..c348c15cb75fc2c86c30f3ad3c9f3ea17ab20213 100644 --- a/lib/internal/Magento/Framework/Gdata/Gshopping/HttpException.php +++ b/lib/internal/Magento/Framework/Gdata/Gshopping/HttpException.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Gdata\Gshopping; /** diff --git a/lib/internal/Magento/Framework/HTTP/Adapter/Curl.php b/lib/internal/Magento/Framework/HTTP/Adapter/Curl.php index 07d55c651f9ed388ca419e2fd67df295e3249722..a677dbd5453f69941584de7f2c33d938fabde4cb 100644 --- a/lib/internal/Magento/Framework/HTTP/Adapter/Curl.php +++ b/lib/internal/Magento/Framework/HTTP/Adapter/Curl.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * HTTP CURL Adapter * @@ -51,6 +53,8 @@ class Curl implements \Zend_Http_Client_Adapter_Interface * Apply current configuration array to transport resource * * @return \Magento\Framework\HTTP\Adapter\Curl + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _applyConfig() { @@ -137,6 +141,7 @@ class Curl implements \Zend_Http_Client_Adapter_Interface * @param array $headers * @param string $body * @return string Request as text + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function write($method, $url, $http_ver = '1.1', $headers = [], $body = '') { diff --git a/lib/internal/Magento/Framework/HTTP/Client/Curl.php b/lib/internal/Magento/Framework/HTTP/Client/Curl.php index ce030bcc9e641c713a9e9d9a03a33a2cc53d7417..a8f5548b4f63568db90fb5520d89f6656e99e52a 100644 --- a/lib/internal/Magento/Framework/HTTP/Client/Curl.php +++ b/lib/internal/Magento/Framework/HTTP/Client/Curl.php @@ -331,6 +331,8 @@ class Curl implements \Magento\Framework\HTTP\ClientInterface * @param string $uri * @param array $params * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function makeRequest($method, $uri, $params = []) { @@ -406,6 +408,7 @@ class Curl implements \Magento\Framework\HTTP\ClientInterface * @param resource $ch curl handle, not needed * @param string $data * @return int + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function parseHeaders($ch, $data) { diff --git a/lib/internal/Magento/Framework/HTTP/Client/Socket.php b/lib/internal/Magento/Framework/HTTP/Client/Socket.php index 2174b15a21ad60c642a76d729ddf583c470bbaed..949ef777adf302e0081d6dc10f61c7a707efb981 100644 --- a/lib/internal/Magento/Framework/HTTP/Client/Socket.php +++ b/lib/internal/Magento/Framework/HTTP/Client/Socket.php @@ -11,6 +11,12 @@ */ namespace Magento\Framework\HTTP\Client; +/** + * @SuppressWarnings(PHPMD.UnusedPrivateField) + */ +/** + * @SuppressWarnings(PHPMD.UnusedPrivateField) + */ class Socket implements \Magento\Framework\HTTP\ClientInterface { /** @@ -407,6 +413,7 @@ class Socket implements \Magento\Framework\HTTP\ClientInterface * Process response * * @return void + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function processResponse() { @@ -517,6 +524,7 @@ class Socket implements \Magento\Framework\HTTP\ClientInterface * * @param array $arr * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setOptions($arr) { @@ -529,6 +537,7 @@ class Socket implements \Magento\Framework\HTTP\ClientInterface * @param string $name * @param string $value * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setOption($name, $value) { diff --git a/lib/internal/Magento/Framework/HTTP/Header.php b/lib/internal/Magento/Framework/HTTP/Header.php index 5f3c6283cafd14f4d89dc395a7728d677da89fd2..7dba8faecfe359099e1c2e8419a5127f183dc879 100644 --- a/lib/internal/Magento/Framework/HTTP/Header.php +++ b/lib/internal/Magento/Framework/HTTP/Header.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\HTTP; /** diff --git a/lib/internal/Magento/Framework/Image/Adapter/AbstractAdapter.php b/lib/internal/Magento/Framework/Image/Adapter/AbstractAdapter.php index bcd7cd03144c9bcd63d50c1adec98c00e778d689..3a7742a7efb1faa0afd922c5f4d0a7188537effe 100644 --- a/lib/internal/Magento/Framework/Image/Adapter/AbstractAdapter.php +++ b/lib/internal/Magento/Framework/Image/Adapter/AbstractAdapter.php @@ -10,6 +10,7 @@ use Magento\Framework\App\Filesystem\DirectoryList; /** * @file Abstract.php * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.TooManyFields) */ abstract class AbstractAdapter implements AdapterInterface { @@ -263,6 +264,7 @@ abstract class AbstractAdapter implements AdapterInterface * @param \Magento\Framework\Filesystem $filesystem * @param \Psr\Log\LoggerInterface $logger * @param array $data + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function __construct( \Magento\Framework\Filesystem $filesystem, diff --git a/lib/internal/Magento/Framework/Image/Adapter/Gd2.php b/lib/internal/Magento/Framework/Image/Adapter/Gd2.php index b561fec0a8db82643d569c9286358ee8fbfe8056..441a45afae58a385fb1341922404432aeb15d92e 100644 --- a/lib/internal/Magento/Framework/Image/Adapter/Gd2.php +++ b/lib/internal/Magento/Framework/Image/Adapter/Gd2.php @@ -203,6 +203,7 @@ class Gd2 extends \Magento\Framework\Image\Adapter\AbstractAdapter * @param resource &$imageResourceTo * @return int * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ private function _fillBackgroundColor(&$imageResourceTo) { @@ -276,6 +277,7 @@ class Gd2 extends \Magento\Framework\Image\Adapter\AbstractAdapter * @param bool &$isAlpha * @param bool &$isTrueColor * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ private function _getTransparency($imageResource, $fileType, &$isAlpha = false, &$isTrueColor = false) { @@ -366,6 +368,9 @@ class Gd2 extends \Magento\Framework\Image\Adapter\AbstractAdapter * @param int $opacity * @param bool $tile * @return void + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function watermark($imagePath, $positionX = 0, $positionY = 0, $opacity = 30, $tile = false) { diff --git a/lib/internal/Magento/Framework/Image/Adapter/ImageMagick.php b/lib/internal/Magento/Framework/Image/Adapter/ImageMagick.php index 33ee1a1303954e81ea8833d6303c4e52401ebe94..1d3b133279ae43d9439bc1fa521854c926f66e3c 100644 --- a/lib/internal/Magento/Framework/Image/Adapter/ImageMagick.php +++ b/lib/internal/Magento/Framework/Image/Adapter/ImageMagick.php @@ -235,6 +235,8 @@ class ImageMagick extends \Magento\Framework\Image\Adapter\AbstractAdapter * @return void * @throws \LogicException * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function watermark($imagePath, $positionX = 0, $positionY = 0, $opacity = 30, $tile = false) { diff --git a/lib/internal/Magento/Framework/Image/Factory.php b/lib/internal/Magento/Framework/Image/Factory.php index b3b4fc87df06fbd47c2b957e8ca9545a113591e8..256df1ca68c3c89b0ecb1ee6df0c7148e529a1b2 100644 --- a/lib/internal/Magento/Framework/Image/Factory.php +++ b/lib/internal/Magento/Framework/Image/Factory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Image; use Magento\Framework\ObjectManagerInterface; diff --git a/lib/internal/Magento/Framework/Interception/Code/Generator/Interceptor.php b/lib/internal/Magento/Framework/Interception/Code/Generator/Interceptor.php index 5d8b2b289ee91d408b5f028260ef19499a8cda0e..2671cbebb7d37cf0af38962c116543ab246a2e32 100644 --- a/lib/internal/Magento/Framework/Interception/Code/Generator/Interceptor.php +++ b/lib/internal/Magento/Framework/Interception/Code/Generator/Interceptor.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Interception\Code\Generator; class Interceptor extends \Magento\Framework\Code\Generator\EntityAbstract diff --git a/lib/internal/Magento/Framework/Interception/Code/InterfaceValidator.php b/lib/internal/Magento/Framework/Interception/Code/InterfaceValidator.php index 7086a3e6b5ba6de0f8171f61268a017472e6e4f4..1c188ff2c3d237bfba3b21f00464fb1d120b39a3 100644 --- a/lib/internal/Magento/Framework/Interception/Code/InterfaceValidator.php +++ b/lib/internal/Magento/Framework/Interception/Code/InterfaceValidator.php @@ -36,6 +36,8 @@ class InterfaceValidator * * @return void * @throws ValidatorException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function validate($pluginClass, $interceptedType) { diff --git a/lib/internal/Magento/Framework/Interception/PluginList/PluginList.php b/lib/internal/Magento/Framework/Interception/PluginList/PluginList.php index 568fab873e3d7dced79e7bd7c7e0959244442c7d..0b95374f8eb90b4e87979583a6d55ed65b05b028 100644 --- a/lib/internal/Magento/Framework/Interception/PluginList/PluginList.php +++ b/lib/internal/Magento/Framework/Interception/PluginList/PluginList.php @@ -19,6 +19,9 @@ use Magento\Framework\ObjectManager\DefinitionInterface as ClassDefinitions; use Magento\Framework\ObjectManagerInterface; use Zend\Soap\Exception\InvalidArgumentException; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class PluginList extends Scoped implements InterceptionPluginList { /** @@ -84,6 +87,7 @@ class PluginList extends Scoped implements InterceptionPluginList * @param ClassDefinitions $classDefinitions * @param array $scopePriorityScheme * @param string $cacheId + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( ReaderInterface $reader, @@ -113,6 +117,7 @@ class PluginList extends Scoped implements InterceptionPluginList * @return array * @throws InvalidArgumentException * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _inheritPlugins($type) { diff --git a/lib/internal/Magento/Framework/Io/AbstractIo.php b/lib/internal/Magento/Framework/Io/AbstractIo.php index d20bcf55c6fb766890c63f86b14bcfe0da6e5964..629ba1e6eedbc730563442487eaf776b063aa68f 100644 --- a/lib/internal/Magento/Framework/Io/AbstractIo.php +++ b/lib/internal/Magento/Framework/Io/AbstractIo.php @@ -53,6 +53,7 @@ abstract class AbstractIo implements IoInterface /** * @param string $path * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function getCleanPath($path) { diff --git a/lib/internal/Magento/Framework/Io/File.php b/lib/internal/Magento/Framework/Io/File.php index e1e65b3f5aad941b3744ac0431491585c2939302..5c9225067a10e59f103d470de83e366591f9557b 100644 --- a/lib/internal/Magento/Framework/Io/File.php +++ b/lib/internal/Magento/Framework/Io/File.php @@ -7,6 +7,7 @@ namespace Magento\Framework\Io; /** * Filesystem client + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) */ class File extends AbstractIo { @@ -367,6 +368,8 @@ class File extends AbstractIo * @param array $dirCallback * @return mixed * @throws \InvalidArgumentException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected static function _recursiveCallback($dir, array $fileCallback, array $dirCallback = []) { @@ -417,6 +420,7 @@ class File extends AbstractIo * @param string $dir * @return true * @throws \Exception + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function cd($dir) { @@ -459,6 +463,7 @@ class File extends AbstractIo * @param string|resource $src * @param int $mode * @return int|bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function write($filename, $src, $mode = null) { @@ -594,6 +599,7 @@ class File extends AbstractIo * * @param string $filename * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function rm($filename) { @@ -609,6 +615,7 @@ class File extends AbstractIo * @param string $src * @param string $destination * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function mv($src, $destination) { @@ -624,6 +631,7 @@ class File extends AbstractIo * @param string $src * @param string $destination * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function cp($src, $destination) { @@ -679,6 +687,8 @@ class File extends AbstractIo * @param string|null $grep * @return array * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function ls($grep = null) { @@ -782,6 +792,8 @@ class File extends AbstractIo * @param int $mode * @access protected * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _parsePermissions($mode) { diff --git a/lib/internal/Magento/Framework/Io/Ftp.php b/lib/internal/Magento/Framework/Io/Ftp.php index b6b94ccdeb92585b56d67f2540239bc97368fd75..e7c8ee79cf8d574dc8d325d99bc1dff0b254eb93 100644 --- a/lib/internal/Magento/Framework/Io/Ftp.php +++ b/lib/internal/Magento/Framework/Io/Ftp.php @@ -67,6 +67,8 @@ class Ftp extends AbstractIo * @param array $args * @return true * @throws IoException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function open(array $args = []) { @@ -184,6 +186,7 @@ class Ftp extends AbstractIo * * @param string $dir * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function cd($dir) { @@ -261,6 +264,7 @@ class Ftp extends AbstractIo * * @param string $filename * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function rm($filename) { @@ -273,6 +277,7 @@ class Ftp extends AbstractIo * @param string $src * @param string $dest * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function mv($src, $dest) { @@ -294,6 +299,7 @@ class Ftp extends AbstractIo /** * @param null $grep ignored parameter * @return array + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function ls($grep = null) { diff --git a/lib/internal/Magento/Framework/Io/IoInterface.php b/lib/internal/Magento/Framework/Io/IoInterface.php index 52e6d9401bce69deafeb9576d46eb864a799d6d0..85ece039f2b21134fb22bcce6b53f40dc5008bd7 100644 --- a/lib/internal/Magento/Framework/Io/IoInterface.php +++ b/lib/internal/Magento/Framework/Io/IoInterface.php @@ -56,6 +56,7 @@ interface IoInterface * * @param string $dir * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function cd($dir); @@ -83,6 +84,7 @@ interface IoInterface * * @param string $filename * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function rm($filename); @@ -92,6 +94,7 @@ interface IoInterface * @param string $src * @param string $dest * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function mv($src, $dest); @@ -109,6 +112,7 @@ interface IoInterface * * @param string|null $grep * @return array + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function ls($grep = null); diff --git a/lib/internal/Magento/Framework/Io/Sftp.php b/lib/internal/Magento/Framework/Io/Sftp.php index cf31017c4dadc296cb17fd45bce511b00e578ff1..d66a67d5fc00def21efdfa08b3f5d6b3e330f2b7 100644 --- a/lib/internal/Magento/Framework/Io/Sftp.php +++ b/lib/internal/Magento/Framework/Io/Sftp.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Io; /** @@ -97,6 +100,7 @@ class Sftp extends AbstractIo implements IoInterface * @param bool $recursive * @return bool * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function rmdir($dir, $recursive = false) { @@ -148,6 +152,7 @@ class Sftp extends AbstractIo implements IoInterface * * @param string $dir * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function cd($dir) { @@ -188,6 +193,7 @@ class Sftp extends AbstractIo implements IoInterface * * @param string $filename * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function rm($filename) { @@ -200,6 +206,7 @@ class Sftp extends AbstractIo implements IoInterface * @param string $source * @param string $destination * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function mv($source, $destination) { @@ -223,6 +230,7 @@ class Sftp extends AbstractIo implements IoInterface * * @param null $grep ignored parameter * @return array + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function ls($grep = null) { diff --git a/lib/internal/Magento/Framework/Less/PreProcessor/Instruction/Import.php b/lib/internal/Magento/Framework/Less/PreProcessor/Instruction/Import.php index 90414cf66f27f33207fd95300b9ed0f84c9dc2a6..80adab5f41046a1086fc062fa98e879b5f541be9 100644 --- a/lib/internal/Magento/Framework/Less/PreProcessor/Instruction/Import.php +++ b/lib/internal/Magento/Framework/Less/PreProcessor/Instruction/Import.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework\Less\PreProcessor\Instruction; use Magento\Framework\View\Asset\LocalInterface; diff --git a/lib/internal/Magento/Framework/Locale/Lists.php b/lib/internal/Magento/Framework/Locale/Lists.php index 6da8268cf8c6d24229716b33deede24cd3a4a641..168355d54c45dd75d54bc0f701d90155b6639026 100644 --- a/lib/internal/Magento/Framework/Locale/Lists.php +++ b/lib/internal/Magento/Framework/Locale/Lists.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Locale; class Lists implements \Magento\Framework\Locale\ListsInterface @@ -63,6 +66,7 @@ class Lists implements \Magento\Framework\Locale\ListsInterface * * @param bool $translatedName translation flag * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _getOptionLocales($translatedName = false) { diff --git a/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php b/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php index 083358a4f7d40c0767b5985784e3607d600a3d97..5cfae3507d6f443c117bb0a9bd4eb5170d249f69 100644 --- a/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php +++ b/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Mail\Template; class TransportBuilder diff --git a/lib/internal/Magento/Framework/Message/AbstractMessage.php b/lib/internal/Magento/Framework/Message/AbstractMessage.php index d3226ca88999e41cc9cd91e01e6036551e7cd605..b0a096bf8040ad50ffe49846ec55bd840f0994f9 100644 --- a/lib/internal/Magento/Framework/Message/AbstractMessage.php +++ b/lib/internal/Magento/Framework/Message/AbstractMessage.php @@ -100,6 +100,7 @@ abstract class AbstractMessage implements MessageInterface * Getter for flag. Whether message is sticky * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsSticky() { diff --git a/lib/internal/Magento/Framework/Message/Factory.php b/lib/internal/Magento/Framework/Message/Factory.php index c6f3f0443805aa8ab7403c03c6e5c72e185726c1..4c16064b5b6599dbb98f48307601dfff7eda1ee3 100644 --- a/lib/internal/Magento/Framework/Message/Factory.php +++ b/lib/internal/Magento/Framework/Message/Factory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Message; use Magento\Framework\ObjectManagerInterface; diff --git a/lib/internal/Magento/Framework/Message/Manager.php b/lib/internal/Magento/Framework/Message/Manager.php index 6b1564b12f592b4d4c2728f71d28aa27b0872a37..73b212a58e3ee88769bd653a815c15ecafde2578 100644 --- a/lib/internal/Magento/Framework/Message/Manager.php +++ b/lib/internal/Magento/Framework/Message/Manager.php @@ -10,6 +10,7 @@ use Psr\Log\LoggerInterface as Logger; /** * Message manager model + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Manager implements ManagerInterface { diff --git a/lib/internal/Magento/Framework/Message/MessageInterface.php b/lib/internal/Magento/Framework/Message/MessageInterface.php index 9dcad0808fba253937b541b136a7e78873c440ce..e5342f49ac042e79fb0b572fca328a1285ab8b22 100644 --- a/lib/internal/Magento/Framework/Message/MessageInterface.php +++ b/lib/internal/Magento/Framework/Message/MessageInterface.php @@ -79,6 +79,7 @@ interface MessageInterface * Getter for flag. Whether message is sticky * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getIsSticky(); diff --git a/lib/internal/Magento/Framework/Model/AbstractExtensibleModel.php b/lib/internal/Magento/Framework/Model/AbstractExtensibleModel.php index 1d80e645d44d914af1fe7095a115e2e641912506..8e692e8ce312180785a25f5238ea128d9328fe5c 100644 --- a/lib/internal/Magento/Framework/Model/AbstractExtensibleModel.php +++ b/lib/internal/Magento/Framework/Model/AbstractExtensibleModel.php @@ -16,6 +16,7 @@ use Symfony\Component\DependencyInjection\Exception\LogicException; * * This class defines basic data structure of how custom attributes are stored in an ExtensibleModel. * Implementations may choose to process custom attributes as their persistence requires them to. + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractExtensibleModel extends AbstractModel implements ExtensibleDataInterface { diff --git a/lib/internal/Magento/Framework/Model/AbstractModel.php b/lib/internal/Magento/Framework/Model/AbstractModel.php index f3db950bc62355ad0aebc228a4e42e7098aee043..1701fe5d57f1911fd1fd8bf92ab8e4ee45cf0db6 100644 --- a/lib/internal/Magento/Framework/Model/AbstractModel.php +++ b/lib/internal/Magento/Framework/Model/AbstractModel.php @@ -11,6 +11,7 @@ namespace Magento\Framework\Model; * * @SuppressWarnings(PHPMD.CouplingBetweenObjects) * @SuppressWarnings(PHPMD.NumberOfChildren) + * @SuppressWarnings(PHPMD.TooManyFields) */ abstract class AbstractModel extends \Magento\Framework\Object { diff --git a/lib/internal/Magento/Framework/Model/Exception.php b/lib/internal/Magento/Framework/Model/Exception.php index d68bde4b09531cf6fe84ef3e13310cf4f74b6037..e886d6334dff640305091344ff2b0ad9a8b3fec9 100644 --- a/lib/internal/Magento/Framework/Model/Exception.php +++ b/lib/internal/Magento/Framework/Model/Exception.php @@ -9,6 +9,7 @@ namespace Magento\Framework\Model; * Magento Model Exception * * This class will be extended by other modules + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Exception extends \Exception { diff --git a/lib/internal/Magento/Framework/Model/Resource/AbstractResource.php b/lib/internal/Magento/Framework/Model/Resource/AbstractResource.php index de3f520930421c97c1b889cd358d96880362abf4..831dcf5ae71fb2f832a7372efd8abdfe49a0ac40 100644 --- a/lib/internal/Magento/Framework/Model/Resource/AbstractResource.php +++ b/lib/internal/Magento/Framework/Model/Resource/AbstractResource.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Model\Resource; /** diff --git a/lib/internal/Magento/Framework/Model/Resource/Db/AbstractDb.php b/lib/internal/Magento/Framework/Model/Resource/Db/AbstractDb.php index 1913652a13297df264499f66787fb4238832df35..e61f60533d5e6d0a8482f9e0c6cc49decd070a69 100644 --- a/lib/internal/Magento/Framework/Model/Resource/Db/AbstractDb.php +++ b/lib/internal/Magento/Framework/Model/Resource/Db/AbstractDb.php @@ -10,6 +10,7 @@ use Magento\Framework\Model\Exception as ModelException; /** * Abstract resource model class + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractResource { @@ -356,6 +357,7 @@ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractReso * @param mixed $value * @param \Magento\Framework\Model\AbstractModel $object * @return \Zend_Db_Select + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _getLoadSelect($field, $value, $object) { @@ -369,6 +371,7 @@ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractReso * * @param \Magento\Framework\Model\AbstractModel $object * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function save(\Magento\Framework\Model\AbstractModel $object) { @@ -508,6 +511,7 @@ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractReso * * @param \Magento\Framework\Model\AbstractModel $object * @return void + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function unserializeFields(\Magento\Framework\Model\AbstractModel $object) { @@ -593,6 +597,7 @@ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractReso * @param \Magento\Framework\Model\AbstractModel $object * @return $this * @throws ModelException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _checkUnique(\Magento\Framework\Model\AbstractModel $object) { @@ -655,6 +660,7 @@ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractReso * * @param \Magento\Framework\Model\AbstractModel|\Magento\Framework\Object $object * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _afterLoad(\Magento\Framework\Model\AbstractModel $object) { @@ -666,6 +672,7 @@ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractReso * * @param \Magento\Framework\Model\AbstractModel|\Magento\Framework\Object $object * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _beforeSave(\Magento\Framework\Model\AbstractModel $object) { @@ -677,6 +684,7 @@ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractReso * * @param \Magento\Framework\Model\AbstractModel|\Magento\Framework\Object $object * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _afterSave(\Magento\Framework\Model\AbstractModel $object) { @@ -688,6 +696,7 @@ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractReso * * @param \Magento\Framework\Model\AbstractModel|\Magento\Framework\Object $object * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _beforeDelete(\Magento\Framework\Model\AbstractModel $object) { @@ -699,6 +708,7 @@ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractReso * * @param \Magento\Framework\Model\AbstractModel|\Magento\Framework\Object $object * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ protected function _afterDelete(\Magento\Framework\Model\AbstractModel $object) { @@ -710,6 +720,7 @@ abstract class AbstractDb extends \Magento\Framework\Model\Resource\AbstractReso * * @param \Magento\Framework\Model\AbstractModel $object * @return void + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ protected function _serializeFields(\Magento\Framework\Model\AbstractModel $object) { diff --git a/lib/internal/Magento/Framework/Model/Resource/Db/Collection/AbstractCollection.php b/lib/internal/Magento/Framework/Model/Resource/Db/Collection/AbstractCollection.php index f51d9f86c29f9508874ed4627c62b163fb30af34..725b39484dcc648022a2c854d34cf3700f53c2a7 100644 --- a/lib/internal/Magento/Framework/Model/Resource/Db/Collection/AbstractCollection.php +++ b/lib/internal/Magento/Framework/Model/Resource/Db/Collection/AbstractCollection.php @@ -3,10 +3,14 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Model\Resource\Db\Collection; /** * Abstract Resource Collection + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractCollection extends \Magento\Framework\Data\Collection\Db { @@ -191,6 +195,8 @@ abstract class AbstractCollection extends \Magento\Framework\Data\Collection\Db * Init fields for select * * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _initSelectFields() { diff --git a/lib/internal/Magento/Framework/Model/Resource/Type/Db/Pdo/Mysql.php b/lib/internal/Magento/Framework/Model/Resource/Type/Db/Pdo/Mysql.php index 88448af0eead10a85d3d83d24a264e4c2c4724d7..162526fba27ae3f0151e65969b2f12f04d1397d3 100644 --- a/lib/internal/Magento/Framework/Model/Resource/Type/Db/Pdo/Mysql.php +++ b/lib/internal/Magento/Framework/Model/Resource/Type/Db/Pdo/Mysql.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Model\Resource\Type\Db\Pdo; use Magento\Framework\App\Resource\ConnectionAdapterInterface; diff --git a/lib/internal/Magento/Framework/Module/DataSetup.php b/lib/internal/Magento/Framework/Module/DataSetup.php index 06a3109d39b360ab04adb35189ae73736f5834ad..8d1ff06be4b756ef12bed239845849eb7bf5d551 100644 --- a/lib/internal/Magento/Framework/Module/DataSetup.php +++ b/lib/internal/Magento/Framework/Module/DataSetup.php @@ -263,6 +263,7 @@ class DataSetup extends \Magento\Framework\Module\Setup implements \Magento\Fram * @param string $toVersion * @param array $arrFiles * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _getModifySqlFiles($actionType, $fromVersion, $toVersion, $arrFiles) { @@ -384,6 +385,7 @@ class DataSetup extends \Magento\Framework\Module\Setup implements \Magento\Fram * @param string $parentField * @param string|integer $parentId * @return $this + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function updateTableRow($table, $idField, $rowId, $field, $value = null, $parentField = null, $parentId = 0) { @@ -416,6 +418,7 @@ class DataSetup extends \Magento\Framework\Module\Setup implements \Magento\Fram * Check call afterApplyAllUpdates method for setup class * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCallAfterApplyAllUpdates() { diff --git a/lib/internal/Magento/Framework/Module/ModuleList/Loader.php b/lib/internal/Magento/Framework/Module/ModuleList/Loader.php index 03c810ebe2dd6201119a20293ebd34df21c05fba..6c5697243d8647a82de5e655a8b10b22677fe5cd 100644 --- a/lib/internal/Magento/Framework/Module/ModuleList/Loader.php +++ b/lib/internal/Magento/Framework/Module/ModuleList/Loader.php @@ -66,6 +66,7 @@ class Loader * * @param array $origList * @return array + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ private function sortBySequence($origList) { diff --git a/lib/internal/Magento/Framework/Module/Plugin/DbStatusValidator.php b/lib/internal/Magento/Framework/Module/Plugin/DbStatusValidator.php index 6d1293a0ad5b24f2d12b337c06e1dd470d576f3c..52cbea3c74f5deb867a27b2b12b944c443cce3b3 100644 --- a/lib/internal/Magento/Framework/Module/Plugin/DbStatusValidator.php +++ b/lib/internal/Magento/Framework/Module/Plugin/DbStatusValidator.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Module\Plugin; use Magento\Framework\Cache\FrontendInterface; diff --git a/lib/internal/Magento/Framework/Module/Resource.php b/lib/internal/Magento/Framework/Module/Resource.php index bfd1238931dc0c0a5865a859a9ac1bc289ab7393..f054cb1480ec3260ffdfbfa558a14cb77a71c4f8 100644 --- a/lib/internal/Magento/Framework/Module/Resource.php +++ b/lib/internal/Magento/Framework/Module/Resource.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Module; diff --git a/lib/internal/Magento/Framework/Module/Setup/MigrationFactory.php b/lib/internal/Magento/Framework/Module/Setup/MigrationFactory.php index 5bd5bb434c40a533272ee8daf764047ed9851a08..01424e0d979ffa78a041bd9bd388080821519c8e 100644 --- a/lib/internal/Magento/Framework/Module/Setup/MigrationFactory.php +++ b/lib/internal/Magento/Framework/Module/Setup/MigrationFactory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Module\Setup; /** diff --git a/lib/internal/Magento/Framework/Mview/ActionFactory.php b/lib/internal/Magento/Framework/Mview/ActionFactory.php index b3ea8fafd04aa35bcc3f820933aeccc06583ef3d..c675bf1bccb97d3a78254580bb73577ca5b83ced 100644 --- a/lib/internal/Magento/Framework/Mview/ActionFactory.php +++ b/lib/internal/Magento/Framework/Mview/ActionFactory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Mview; class ActionFactory diff --git a/lib/internal/Magento/Framework/Mview/View.php b/lib/internal/Magento/Framework/Mview/View.php index c476171608fbc4bf20306cee1c7694442d9eede7..47b43916febc51d04a94035a3dbb9b68992fff04 100644 --- a/lib/internal/Magento/Framework/Mview/View.php +++ b/lib/internal/Magento/Framework/Mview/View.php @@ -3,8 +3,14 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Mview; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class View extends \Magento\Framework\Object implements ViewInterface { /** diff --git a/lib/internal/Magento/Framework/Mview/View/Subscription.php b/lib/internal/Magento/Framework/Mview/View/Subscription.php index 0d64eb27bb14aab52b1c0ec46d73840e131eeb4b..498cb0e147801ef8709a89a13def616677662be3 100644 --- a/lib/internal/Magento/Framework/Mview/View/Subscription.php +++ b/lib/internal/Magento/Framework/Mview/View/Subscription.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Mview\View; class Subscription implements SubscriptionInterface diff --git a/lib/internal/Magento/Framework/Object.php b/lib/internal/Magento/Framework/Object.php index 695be22ce6da3ed9db4e5dbd68c03c38237a9bf7..62a154337eb9da2a7a9302839f01a4498cb4132a 100644 --- a/lib/internal/Magento/Framework/Object.php +++ b/lib/internal/Magento/Framework/Object.php @@ -9,6 +9,7 @@ namespace Magento\Framework; * Universal data container with array access implementation * * @author Magento Core Team <core@magentocommerce.com> + * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Object implements \ArrayAccess { diff --git a/lib/internal/Magento/Framework/Object/Cache.php b/lib/internal/Magento/Framework/Object/Cache.php index 3f24b856c9fa3674bcbb8f1a62911a250f3a6a3a..57d8a5625a980bbad4b2e24278875b7fc9444598 100644 --- a/lib/internal/Magento/Framework/Object/Cache.php +++ b/lib/internal/Magento/Framework/Object/Cache.php @@ -123,6 +123,8 @@ class Cache * @param array|string $tags * @return string * @throws \Magento\Framework\Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function save($object, $idx = null, $tags = null) { @@ -274,6 +276,7 @@ class Cache * * @param array|string $tags * @return true + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function deleteByTags($tags) { @@ -348,6 +351,7 @@ class Cache * * @param array|string $tags * @return array + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function findByTags($tags) { @@ -389,6 +393,7 @@ class Cache * @param string $idx * @param object|null $object * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function debug($idx, $object = null) { diff --git a/lib/internal/Magento/Framework/Object/Mapper.php b/lib/internal/Magento/Framework/Object/Mapper.php index bffeefb451d0ce21da9275aa19acd10ef545c28a..ffa9bcb041e8c8f2965710498142e69622193d97 100644 --- a/lib/internal/Magento/Framework/Object/Mapper.php +++ b/lib/internal/Magento/Framework/Object/Mapper.php @@ -9,6 +9,10 @@ */ namespace Magento\Framework\Object; +/** + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + */ class Mapper { /** diff --git a/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Persistor.php b/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Persistor.php index abb3869c42c7aa159e168347b84e305889e393a4..45c3886ff2fbe9a4d76287cb7e5042d28056b689 100644 --- a/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Persistor.php +++ b/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Persistor.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\ObjectManager\Code\Generator; /** diff --git a/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Repository.php b/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Repository.php index ff98d5584a74c1dce7f9ee7843793f30928265e6..d098d3a9bb30469ab0dab68b300bf8d41bceff70 100644 --- a/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Repository.php +++ b/lib/internal/Magento/Framework/ObjectManager/Code/Generator/Repository.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\ObjectManager\Code\Generator; /** diff --git a/lib/internal/Magento/Framework/ObjectManager/DefinitionFactory.php b/lib/internal/Magento/Framework/ObjectManager/DefinitionFactory.php index c71e32ac3cf7a2667cf45b3e64040634ca36b26f..d735a93154406cd341876c4cfc69e2a0d5c79005 100644 --- a/lib/internal/Magento/Framework/ObjectManager/DefinitionFactory.php +++ b/lib/internal/Magento/Framework/ObjectManager/DefinitionFactory.php @@ -6,6 +6,9 @@ * See COPYING.txt for license details. * */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\ObjectManager; use Magento\Framework\Api\Code\Generator\DataBuilder as DataBuilderGenerator; diff --git a/lib/internal/Magento/Framework/Parse/Zip.php b/lib/internal/Magento/Framework/Parse/Zip.php index 6cac80ecd8d1c98395c30765db199a3e82dde3f2..aebc4af30e9f66b57aae094742420145247067ec 100644 --- a/lib/internal/Magento/Framework/Parse/Zip.php +++ b/lib/internal/Magento/Framework/Parse/Zip.php @@ -45,6 +45,9 @@ class Zip * * @param string $zipRange * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public static function zipRangeToZipPattern($zipRange) { diff --git a/lib/internal/Magento/Framework/Pricing/Render/RendererPool.php b/lib/internal/Magento/Framework/Pricing/Render/RendererPool.php index 8e956dfeccaf6bd4bbb9942a79dba746206c11f5..c501e4adf70fdc644f682fc69a0347313efb5eb0 100644 --- a/lib/internal/Magento/Framework/Pricing/Render/RendererPool.php +++ b/lib/internal/Magento/Framework/Pricing/Render/RendererPool.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Pricing\Render; use Magento\Framework\Pricing\Amount\AmountInterface; diff --git a/lib/internal/Magento/Framework/Profiler/Driver/Factory.php b/lib/internal/Magento/Framework/Profiler/Driver/Factory.php index 095f65b6b57c5b47c542dec9dc17427761cf3cc0..143520c7560929d9d837296d44b15ba0c2209de6 100644 --- a/lib/internal/Magento/Framework/Profiler/Driver/Factory.php +++ b/lib/internal/Magento/Framework/Profiler/Driver/Factory.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Profiler\Driver; use Magento\Framework\Profiler\DriverInterface; diff --git a/lib/internal/Magento/Framework/Search/Adapter/Mysql/Aggregation/Interval.php b/lib/internal/Magento/Framework/Search/Adapter/Mysql/Aggregation/Interval.php index 1ee710cab14e6322112d524915467ca25ef553dd..d33d1e914e801165b35161cddf46a3b023e20fb4 100644 --- a/lib/internal/Magento/Framework/Search/Adapter/Mysql/Aggregation/Interval.php +++ b/lib/internal/Magento/Framework/Search/Adapter/Mysql/Aggregation/Interval.php @@ -41,6 +41,7 @@ class Interval implements IntervalInterface /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function load($limit, $offset = null, $lower = null, $upper = null) { @@ -63,6 +64,7 @@ class Interval implements IntervalInterface /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function loadPrevious($data, $index, $lower = null) { @@ -84,6 +86,7 @@ class Interval implements IntervalInterface /** * {@inheritdoc} + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function loadNext($data, $rightIndex, $upper = null) { diff --git a/lib/internal/Magento/Framework/Search/Adapter/Mysql/Mapper.php b/lib/internal/Magento/Framework/Search/Adapter/Mysql/Mapper.php index 959ba62775a47d2e97750ac7ff2f194fafcfb1d0..2f8579a79e2dc678bba7880661b7d764bf6faba5 100644 --- a/lib/internal/Magento/Framework/Search/Adapter/Mysql/Mapper.php +++ b/lib/internal/Magento/Framework/Search/Adapter/Mysql/Mapper.php @@ -16,6 +16,7 @@ use Magento\Framework\Search\RequestInterface; /** * Mapper class. Maps library request to specific adapter dependent query + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class Mapper { diff --git a/lib/internal/Magento/Framework/Search/Dynamic/Algorithm.php b/lib/internal/Magento/Framework/Search/Dynamic/Algorithm.php index 13223af7352198aea764e010897ae5c2a355ba13..317a0b559148f7b7b6cb09817e0be815f1d286ec 100644 --- a/lib/internal/Magento/Framework/Search/Dynamic/Algorithm.php +++ b/lib/internal/Magento/Framework/Search/Dynamic/Algorithm.php @@ -163,6 +163,8 @@ class Algorithm * * @param IntervalInterface $interval * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function calculateSeparators(IntervalInterface $interval) { @@ -259,6 +261,9 @@ class Algorithm * @param int $quantileNumber should be from 1 to n-1 where n is number of intervals * @param IntervalInterface $interval * @return array|null + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ protected function _findValueSeparator($quantileNumber, IntervalInterface $interval) { @@ -419,6 +424,8 @@ class Algorithm * @param bool $returnEmpty whether empty result is acceptable * @param null|float $roundingFactor if given, checks for range to contain the factor * @return false|array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _findRoundValue($lowerValue, $upperValue, $returnEmpty = true, $roundingFactor = null) { @@ -548,6 +555,8 @@ class Algorithm * @param float $value * @param null|float[] $limits search [from, to] * @return int + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _binarySearch($value, $limits = null) { diff --git a/lib/internal/Magento/Framework/Search/Request/Binder.php b/lib/internal/Magento/Framework/Search/Request/Binder.php index 9eac805147d15b5e24db49d8a740d92ce4bd58a1..a6ec65f17510b6a2a77b3309332c6a98978ecbd6 100644 --- a/lib/internal/Magento/Framework/Search/Request/Binder.php +++ b/lib/internal/Magento/Framework/Search/Request/Binder.php @@ -48,6 +48,7 @@ class Binder * @param array $data * @param array $bindData * @return array + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ private function processDimensions($data, $bindData) { diff --git a/lib/internal/Magento/Framework/Search/Request/Cleaner.php b/lib/internal/Magento/Framework/Search/Request/Cleaner.php index d50c955609d5002044f5e9f6e2f5ee36c487e8cd..b3182007c3a3d9fe7617654a8f39e803b201bdc2 100644 --- a/lib/internal/Magento/Framework/Search/Request/Cleaner.php +++ b/lib/internal/Magento/Framework/Search/Request/Cleaner.php @@ -65,6 +65,8 @@ class Cleaner * @return void * @throws StateException * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ private function cleanQuery($queryName) { @@ -130,6 +132,7 @@ class Cleaner * @return void * @throws StateException * @throws \Exception + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ private function cleanFilter($filterName) { diff --git a/lib/internal/Magento/Framework/Search/Request/Mapper.php b/lib/internal/Magento/Framework/Search/Request/Mapper.php index 346b5a6603980651eaa65ee3ae26b80e6dc727a9..488880d07a00053431c277993b0715cc95f01b69 100644 --- a/lib/internal/Magento/Framework/Search/Request/Mapper.php +++ b/lib/internal/Magento/Framework/Search/Request/Mapper.php @@ -8,6 +8,9 @@ namespace Magento\Framework\Search\Request; use Magento\Framework\Exception\StateException; use Magento\Framework\Search\Request\Query\Filter; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class Mapper { /** @@ -96,6 +99,7 @@ class Mapper * @throws \Exception * @throws \InvalidArgumentException * @throws StateException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ private function mapQuery($queryName) { diff --git a/lib/internal/Magento/Framework/Session/Config.php b/lib/internal/Magento/Framework/Session/Config.php index 8ded4ded7584f60135ca3ae0cfb059aa11839330..ff11331c7a904855cb289e9438ba55f0e96d9d92 100644 --- a/lib/internal/Magento/Framework/Session/Config.php +++ b/lib/internal/Magento/Framework/Session/Config.php @@ -110,6 +110,7 @@ class Config implements ConfigInterface * @param DeploymentConfig $deploymentConfig * @param string $scopeType * @param string $lifetimePath + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function __construct( \Magento\Framework\ValidatorFactory $validatorFactory, @@ -407,6 +408,7 @@ class Config implements ConfigInterface * Get session.cookie_secure * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCookieSecure() { @@ -429,6 +431,7 @@ class Config implements ConfigInterface * Get session.cookie_httponly * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCookieHttpOnly() { @@ -451,6 +454,7 @@ class Config implements ConfigInterface * Get session.use_cookies * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseCookies() { diff --git a/lib/internal/Magento/Framework/Session/Config/ConfigInterface.php b/lib/internal/Magento/Framework/Session/Config/ConfigInterface.php index accba2d69b8293575c1aa757998b8a3a23a1aedd..6c2372d20be4fc7c759618cdda8a93dfad19fc21 100644 --- a/lib/internal/Magento/Framework/Session/Config/ConfigInterface.php +++ b/lib/internal/Magento/Framework/Session/Config/ConfigInterface.php @@ -135,6 +135,7 @@ interface ConfigInterface * Get session.cookie_secure * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCookieSecure(); @@ -150,6 +151,7 @@ interface ConfigInterface * Get session.cookie_httponly * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCookieHttpOnly(); @@ -165,6 +167,7 @@ interface ConfigInterface * Get session.use_cookies * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseCookies(); } diff --git a/lib/internal/Magento/Framework/Session/SaveHandler.php b/lib/internal/Magento/Framework/Session/SaveHandler.php index 324c155d16c1145c50599d7c7bf41565792b08cd..bfd8a6958a712c8a52d9e2031748180c675e6d53 100644 --- a/lib/internal/Magento/Framework/Session/SaveHandler.php +++ b/lib/internal/Magento/Framework/Session/SaveHandler.php @@ -102,6 +102,7 @@ class SaveHandler implements SaveHandlerInterface * * @param int $maxLifetime * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function gc($maxLifetime) { diff --git a/lib/internal/Magento/Framework/Session/SaveHandler/DbTable.php b/lib/internal/Magento/Framework/Session/SaveHandler/DbTable.php index 7cdc3feac29471d82f9677463312ba792e34820f..5d05e5ffbe9c388015ef853c1ccee955b30eae87 100644 --- a/lib/internal/Magento/Framework/Session/SaveHandler/DbTable.php +++ b/lib/internal/Magento/Framework/Session/SaveHandler/DbTable.php @@ -58,6 +58,7 @@ class DbTable extends \SessionHandler * @param string $savePath ignored * @param string $sessionName ignored * @return bool + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function open($savePath, $sessionName) { @@ -145,6 +146,7 @@ class DbTable extends \SessionHandler * * @param int $maxLifeTime * @return bool + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function gc($maxLifeTime) { diff --git a/lib/internal/Magento/Framework/Session/SessionManager.php b/lib/internal/Magento/Framework/Session/SessionManager.php index 018a0717d2b35d1125b83dd61b61edd9088e7eb6..8c2c03d0dd849cf1abf8d205f47a43684b9d7fc6 100644 --- a/lib/internal/Magento/Framework/Session/SessionManager.php +++ b/lib/internal/Magento/Framework/Session/SessionManager.php @@ -343,6 +343,7 @@ class SessionManager implements SessionManagerInterface * * @param string $urlHost can be host or url * @return string {session_id_key}={session_id_encrypted} + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getSessionIdForHost($urlHost) { diff --git a/lib/internal/Magento/Framework/Session/SidResolver.php b/lib/internal/Magento/Framework/Session/SidResolver.php index 7276012389b84805c1781dd7d41da94f6e71ccae..0eedd921cea9905668d6894276e7f2b7a7f2bf25 100644 --- a/lib/internal/Magento/Framework/Session/SidResolver.php +++ b/lib/internal/Magento/Framework/Session/SidResolver.php @@ -127,6 +127,7 @@ class SidResolver implements SidResolverInterface * Retrieve use flag session var instead of SID for URL * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseSessionVar() { @@ -149,6 +150,7 @@ class SidResolver implements SidResolverInterface * Retrieve use session in URL flag * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseSessionInUrl() { diff --git a/lib/internal/Magento/Framework/Session/SidResolverInterface.php b/lib/internal/Magento/Framework/Session/SidResolverInterface.php index 63c14f353f64c6d39d681c0f0cf53dc48c42d411..b3467a5d0ef133b316b56a45ec7b0cc681e40ca1 100644 --- a/lib/internal/Magento/Framework/Session/SidResolverInterface.php +++ b/lib/internal/Magento/Framework/Session/SidResolverInterface.php @@ -42,6 +42,7 @@ interface SidResolverInterface * Retrieve use flag session var instead of SID for URL * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseSessionVar(); @@ -57,6 +58,7 @@ interface SidResolverInterface * Retrieve use session in URL flag * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseSessionInUrl(); } diff --git a/lib/internal/Magento/Framework/Simplexml/Config.php b/lib/internal/Magento/Framework/Simplexml/Config.php index ba38f560de34f06a98284af6405f8fbc5d9839c9..f94ec099c6fc5124217d1fbd52b3a3fae5b95d1c 100644 --- a/lib/internal/Magento/Framework/Simplexml/Config.php +++ b/lib/internal/Magento/Framework/Simplexml/Config.php @@ -184,6 +184,7 @@ class Config * Enter description here... * * @return boolean + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getCacheSaved() { diff --git a/lib/internal/Magento/Framework/Simplexml/Element.php b/lib/internal/Magento/Framework/Simplexml/Element.php index 69e04dc7692ce245332819c0e8166b561ffe219b..98c881f1dd274ddb61fad6391ee6d2d500215bc8 100644 --- a/lib/internal/Magento/Framework/Simplexml/Element.php +++ b/lib/internal/Magento/Framework/Simplexml/Element.php @@ -27,6 +27,7 @@ class Element extends \SimpleXMLElement * * @param \Magento\Framework\Simplexml\Element $element * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function setParent($element) { @@ -59,6 +60,7 @@ class Element extends \SimpleXMLElement * Enter description here... * * @return boolean + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function hasChildren() { @@ -93,6 +95,7 @@ class Element extends \SimpleXMLElement * @todo param string $path Subset of xpath. Example: "child/grand[@attrName='attrValue']/subGrand" * @param string $path Example: "child/grand@attrName=attrValue/subGrand" (to make it faster without regex) * @return \Magento\Framework\Simplexml\Element + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function descend($path) { @@ -222,6 +225,8 @@ class Element extends \SimpleXMLElement * @param string $filename * @param int|boolean $level if false * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function asNiceXml($filename = '', $level = 0) { @@ -368,6 +373,8 @@ class Element extends \SimpleXMLElement * @param \Magento\Framework\Simplexml\Element $source * @param boolean $overwrite * @return $this + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.UnusedLocalVariable) */ public function extendChild($source, $overwrite = false) { diff --git a/lib/internal/Magento/Framework/Stdlib/ArrayUtils.php b/lib/internal/Magento/Framework/Stdlib/ArrayUtils.php index 06fd8901909ee9d8efbf27d651a337231281e761..cde6db70a5b429ef72b937b32cd0a8baf8c043ed 100644 --- a/lib/internal/Magento/Framework/Stdlib/ArrayUtils.php +++ b/lib/internal/Magento/Framework/Stdlib/ArrayUtils.php @@ -56,6 +56,8 @@ class ArrayUtils * @param string $prefix * @param bool $forceSetAll * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function decorateArray($array, $prefix = 'decorated_', $forceSetAll = false) { diff --git a/lib/internal/Magento/Framework/Stdlib/DateTime/DateInterface.php b/lib/internal/Magento/Framework/Stdlib/DateTime/DateInterface.php index 0da79c1abe940c74aa2f237abe1ecbb1a6d04eb1..369139a054ad4457108ae647b9d15933e0d772b8 100644 --- a/lib/internal/Magento/Framework/Stdlib/DateTime/DateInterface.php +++ b/lib/internal/Magento/Framework/Stdlib/DateTime/DateInterface.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Stdlib\DateTime; interface DateInterface diff --git a/lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php b/lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php index 19f1532aeea077c77dc321babe35e477ebc4e465..725f64ec64034ff9aaaf72d033d9e98f3005d2b6 100644 --- a/lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php +++ b/lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Stdlib\DateTime; interface TimezoneInterface diff --git a/lib/internal/Magento/Framework/Stdlib/String.php b/lib/internal/Magento/Framework/Stdlib/String.php index 5b2cd7ccc4d220ba082616c5c95c8c2545ebb19b..bdf506b3b5d25280071812760c29212812dd3c8f 100644 --- a/lib/internal/Magento/Framework/Stdlib/String.php +++ b/lib/internal/Magento/Framework/Stdlib/String.php @@ -66,6 +66,8 @@ class String * @param bool $trim * @param string $wordSeparatorRegex * @return string[] + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function split($value, $length = 1, $keepWords = false, $trim = false, $wordSeparatorRegex = '\s') { diff --git a/lib/internal/Magento/Framework/System/Dirs.php b/lib/internal/Magento/Framework/System/Dirs.php index 48135e6214e33a7a3e4420b80124746f3317462b..aa8731c6fce2fe7175c53f6d497a83b0036cc022 100644 --- a/lib/internal/Magento/Framework/System/Dirs.php +++ b/lib/internal/Magento/Framework/System/Dirs.php @@ -10,6 +10,9 @@ class Dirs /** * @param string[]|string $dirname * @return bool + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ShortMethodName) */ public static function rm($dirname) { @@ -91,6 +94,7 @@ class Dirs * @param string $dest * @return void * @throws \Exception + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public static function copyFileStrict($source, $dest) { diff --git a/lib/internal/Magento/Framework/System/Ftp.php b/lib/internal/Magento/Framework/System/Ftp.php index 6d550651b7a0ac00d0de5cb2a53e1475888764f0..d02ceec99093e67f3b2a514d9fcf986f4c7aad3c 100644 --- a/lib/internal/Magento/Framework/System/Ftp.php +++ b/lib/internal/Magento/Framework/System/Ftp.php @@ -333,6 +333,7 @@ class Ftp * @param int $fileMode FTP_BINARY | FTP_ASCII * @param int $resumeOffset * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function get($localFile, $remoteFile, $fileMode = FTP_BINARY, $resumeOffset = 0) { @@ -427,6 +428,7 @@ class Ftp * @param string $dir * @param bool $recursive * @return array + * @SuppressWarnings(PHPMD.ShortMethodName) */ public function ls($dir = "/", $recursive = false) { diff --git a/lib/internal/Magento/Framework/Test/Utility/Files.php b/lib/internal/Magento/Framework/Test/Utility/Files.php index 30ad68f115fb88a5e2e99b2ba0a77e6e238a6449..edb0b8a83d9edda2c79330f4fda83d7542068fc9 100644 --- a/lib/internal/Magento/Framework/Test/Utility/Files.php +++ b/lib/internal/Magento/Framework/Test/Utility/Files.php @@ -1069,7 +1069,7 @@ class Files */ $files = glob(self::init()->getPathToSource() . '/' . $pattern, GLOB_BRACE); if (empty($files)) { - throw new \Exception("The glob() pattern '{$pattern}' didn't return any result."); + continue; } $result = array_merge($result, $files); } diff --git a/lib/internal/Magento/Framework/Translate/Adapter.php b/lib/internal/Magento/Framework/Translate/Adapter.php index 07f907011a2262f6ba68cb8b85b16bd3c38747e2..39a8c338b63560b65cb965dae7b32352654a6c8b 100644 --- a/lib/internal/Magento/Framework/Translate/Adapter.php +++ b/lib/internal/Magento/Framework/Translate/Adapter.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Magento translate adapter */ diff --git a/lib/internal/Magento/Framework/Translate/AdapterInterface.php b/lib/internal/Magento/Framework/Translate/AdapterInterface.php index d2344d4a49aae13ea826c799f1559f464c463abb..19a4bbdc7f908289602baecb4142a72a5ff5572d 100644 --- a/lib/internal/Magento/Framework/Translate/AdapterInterface.php +++ b/lib/internal/Magento/Framework/Translate/AdapterInterface.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Magento translate adapter interface */ diff --git a/lib/internal/Magento/Framework/Translate/Inline.php b/lib/internal/Magento/Framework/Translate/Inline.php index 27d6931281b6771cfd5cb575c0449f085a19c9f7..21730dc60a2cda5a6d45e70fa790442644e18cf2 100644 --- a/lib/internal/Magento/Framework/Translate/Inline.php +++ b/lib/internal/Magento/Framework/Translate/Inline.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Translate; class Inline implements \Magento\Framework\Translate\InlineInterface @@ -166,6 +169,7 @@ class Inline implements \Magento\Framework\Translate\InlineInterface * * @param mixed|string|null $tagName * @return null + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function getAdditionalHtmlAttribute($tagName = null) { diff --git a/lib/internal/Magento/Framework/Translate/Locale/Resolver/Plugin.php b/lib/internal/Magento/Framework/Translate/Locale/Resolver/Plugin.php index f91c0f380957e1b4e6dac397b2bcddb22c4fd6b4..2112b33aad7b352985895fb44f318b3bbbc33d4c 100644 --- a/lib/internal/Magento/Framework/Translate/Locale/Resolver/Plugin.php +++ b/lib/internal/Magento/Framework/Translate/Locale/Resolver/Plugin.php @@ -27,6 +27,7 @@ class Plugin * @param \Magento\Framework\Locale\ResolverInterface $subject * @param string|null $localeCode * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterEmulate(\Magento\Framework\Locale\ResolverInterface $subject, $localeCode) { @@ -37,6 +38,7 @@ class Plugin * @param \Magento\Framework\Locale\ResolverInterface $subject * @param string|null $localeCode * @return void + * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ public function afterRevert(\Magento\Framework\Locale\ResolverInterface $subject, $localeCode) { diff --git a/lib/internal/Magento/Framework/Url.php b/lib/internal/Magento/Framework/Url.php index 52e81323a25e6ddf7c4781e369f5bab16dc158d6..b49406a36caf43966d5180a804bd64d4ff0054f4 100644 --- a/lib/internal/Magento/Framework/Url.php +++ b/lib/internal/Magento/Framework/Url.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + namespace Magento\Framework; /** @@ -53,6 +55,7 @@ namespace Magento\Framework; * - F: host_url * - G: route_path * - H: route_url + * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) */ class Url extends \Magento\Framework\Object implements \Magento\Framework\UrlInterface { @@ -159,6 +162,7 @@ class Url extends \Magento\Framework\Object implements \Magento\Framework\UrlInt * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig * @param string $scopeType * @param array $data + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( \Magento\Framework\App\Route\ConfigInterface $routeConfig, @@ -230,6 +234,7 @@ class Url extends \Magento\Framework\Object implements \Magento\Framework\UrlInt * Retrieve use session rule * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseSession() { @@ -426,6 +431,7 @@ class Url extends \Magento\Framework\Object implements \Magento\Framework\UrlInt * * @param string $data * @return \Magento\Framework\UrlInterface + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _setRoutePath($data) { @@ -506,6 +512,7 @@ class Url extends \Magento\Framework\Object implements \Magento\Framework\UrlInt * * @param array $routeParams * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ protected function _getRoutePath($routeParams = []) { @@ -763,6 +770,8 @@ class Url extends \Magento\Framework\Object implements \Magento\Framework\UrlInt * @param string|null $routePath * @param array|null $routeParams * @return string + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function getUrl($routePath = null, $routeParams = null) { diff --git a/lib/internal/Magento/Framework/UrlFactory.php b/lib/internal/Magento/Framework/UrlFactory.php index 4521f2158ed5bee24d48f8754c2ad49857b3c057..f3e65d808ca58ceb6aba8bbc05f24daa62b878b5 100644 --- a/lib/internal/Magento/Framework/UrlFactory.php +++ b/lib/internal/Magento/Framework/UrlFactory.php @@ -3,6 +3,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework; class UrlFactory diff --git a/lib/internal/Magento/Framework/UrlInterface.php b/lib/internal/Magento/Framework/UrlInterface.php index 08991834c0b14e08d7cfe1dd210a199205701c83..61ca29f245fe12ae8e4d53573ba919027925c95c 100644 --- a/lib/internal/Magento/Framework/UrlInterface.php +++ b/lib/internal/Magento/Framework/UrlInterface.php @@ -49,6 +49,7 @@ interface UrlInterface * Retrieve use session rule * * @return bool + * @SuppressWarnings(PHPMD.BooleanGetMethodName) */ public function getUseSession(); diff --git a/lib/internal/Magento/Framework/Validator/Builder.php b/lib/internal/Magento/Framework/Validator/Builder.php index cc6a4b7e81784766a70893ebf9b93bbdbfd8eb2f..adf856aa0e09315315ab1c74013708e6204a84f2 100644 --- a/lib/internal/Magento/Framework/Validator/Builder.php +++ b/lib/internal/Magento/Framework/Validator/Builder.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Validator; use Magento\Framework\Validator\Constraint\OptionInterface; diff --git a/lib/internal/Magento/Framework/Validator/Constraint/Property.php b/lib/internal/Magento/Framework/Validator/Constraint/Property.php index 253b0dba0c947454901b2e0b2f6fb4a1a7b96775..4bbce4c5da6686a1cf56a8ee0b511f4deec1e86c 100644 --- a/lib/internal/Magento/Framework/Validator/Constraint/Property.php +++ b/lib/internal/Magento/Framework/Validator/Constraint/Property.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Validator\Constraint; class Property extends \Magento\Framework\Validator\Constraint diff --git a/lib/internal/Magento/Framework/Validator/ConstraintFactory.php b/lib/internal/Magento/Framework/Validator/ConstraintFactory.php index a503e4693f0d740309793a0a7969b8a6dd0f25f9..afd466ddb153c76bb6ae741f854085078d8ec54a 100644 --- a/lib/internal/Magento/Framework/Validator/ConstraintFactory.php +++ b/lib/internal/Magento/Framework/Validator/ConstraintFactory.php @@ -4,6 +4,8 @@ * See COPYING.txt for license details. */ +// @codingStandardsIgnoreFile + /** * Factory class for \Magento\Framework\Validator\Constraint */ diff --git a/lib/internal/Magento/Framework/Validator/Factory.php b/lib/internal/Magento/Framework/Validator/Factory.php index 42a9960c9de8ad210064b82ad1748673f0b4d956..a663b91cc745f01f164e1d30a1f6e9f04682087b 100644 --- a/lib/internal/Magento/Framework/Validator/Factory.php +++ b/lib/internal/Magento/Framework/Validator/Factory.php @@ -5,6 +5,9 @@ * Copyright © 2015 Magento. All rights reserved. * See COPYING.txt for license details. */ + +// @codingStandardsIgnoreFile + namespace Magento\Framework\Validator; class Factory diff --git a/lib/internal/Magento/Framework/View/Element/AbstractBlock.php b/lib/internal/Magento/Framework/View/Element/AbstractBlock.php index 07de1f3de9c10940bbb71ac9e1526e23f5cde2ea..73f90325de211f2ba007a0eef0125ece92d531ad 100644 --- a/lib/internal/Magento/Framework/View/Element/AbstractBlock.php +++ b/lib/internal/Magento/Framework/View/Element/AbstractBlock.php @@ -15,6 +15,7 @@ namespace Magento\Framework\View\Element; * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) * @SuppressWarnings(PHPMD.CouplingBetweenObjects) * @SuppressWarnings(PHPMD.TooManyFields) + * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractBlock extends \Magento\Framework\Object implements BlockInterface { diff --git a/lib/internal/Magento/Framework/Xml/Generator.php b/lib/internal/Magento/Framework/Xml/Generator.php index d2112b3e6f6e05cdd9f4e81ac1d0a8b51c58f278..5bb3820c3a5f7d82e87a35378fd12d54adefb849 100644 --- a/lib/internal/Magento/Framework/Xml/Generator.php +++ b/lib/internal/Magento/Framework/Xml/Generator.php @@ -68,6 +68,7 @@ class Generator * @param array $content * @return $this * @throws \DOMException + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function arrayToXml($content) { diff --git a/lib/internal/Magento/Framework/Xml/Parser.php b/lib/internal/Magento/Framework/Xml/Parser.php index a67d1575f6f532769f70fba1752bf7e238c0d38f..46e1303d39fa481cb9420d620d939a06945bd878 100644 --- a/lib/internal/Magento/Framework/Xml/Parser.php +++ b/lib/internal/Magento/Framework/Xml/Parser.php @@ -70,6 +70,8 @@ class Parser /** * @param bool $currentNode * @return array + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ protected function _xmlToArray($currentNode = false) {