From bfd1d867ed24cb580f33ebc6f585a04a20507e9e Mon Sep 17 00:00:00 2001 From: Joan He <johe@magento.com> Date: Thu, 20 Oct 2016 16:51:14 -0500 Subject: [PATCH] MAGETWO-59444: Create serializer interface and json class in framework - Address code review comments --- .../Framework/Serialize/Test/Unit/Serializer/JsonTest.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/internal/Magento/Framework/Serialize/Test/Unit/Serializer/JsonTest.php b/lib/internal/Magento/Framework/Serialize/Test/Unit/Serializer/JsonTest.php index 59e9eeed190..88e06d89e37 100644 --- a/lib/internal/Magento/Framework/Serialize/Test/Unit/Serializer/JsonTest.php +++ b/lib/internal/Magento/Framework/Serialize/Test/Unit/Serializer/JsonTest.php @@ -22,7 +22,8 @@ class JsonTest extends \PHPUnit_Framework_TestCase } /** - * @param null|bool|array $value + * @param string|int|float|bool|array|null $value + * @param string $expected * @dataProvider serializeDataProvider */ public function testSerialize($value, $expected) @@ -49,7 +50,8 @@ class JsonTest extends \PHPUnit_Framework_TestCase } /** - * @param null|bool|array $value + * @param string $value + * @param string|int|float|bool|array|null $expected * @dataProvider unserializeDataProvider */ public function testUnserialize($value, $expected) -- GitLab