From b9cdf76b95e53ecf4c32c47b601e891804101b19 Mon Sep 17 00:00:00 2001
From: Anton Kaplya <akaplya@ebay.com>
Date: Tue, 10 Mar 2015 16:40:17 +0200
Subject: [PATCH] MAGETWO-34729: Code coverage
---
.../Order/Creditmemo/Total/DiscountTest.php | 29 ++++++++++-----
.../Order/Creditmemo/Total/SubtotalTest.php | 32 +++++++++++------
.../Model/Order/Grid/Row/UrlGeneratorTest.php | 6 ++--
.../Sales/Model/Order/Invoice/ItemTest.php | 35 ++++++++++++-------
4 files changed, 68 insertions(+), 34 deletions(-)
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/DiscountTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/DiscountTest.php
index 660fec3b44f..4aa6012eb9a 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/DiscountTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/DiscountTest.php
@@ -34,18 +34,31 @@ class DiscountTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
- $this->orderMock = $this->getMock('Magento\Sales\Model\Order', [
- 'getBaseShippingDiscountAmount', 'getBaseShippingAmount', 'getShippingAmount'
- ], [], '', false);
+ $this->orderMock = $this->getMock(
+ 'Magento\Sales\Model\Order',
+ ['getBaseShippingDiscountAmount', 'getBaseShippingAmount', 'getShippingAmount'],
+ [],
+ '',
+ false
+ );
$this->orderItemMock = $this->getMock('Magento\Sales\Model\Order',
[
'isDummy', 'getDiscountInvoiced', 'getBaseDiscountInvoiced', 'getQtyInvoiced', 'getQty',
'getDiscountRefunded', 'getQtyRefunded'
- ], [], '', false);
- $this->creditmemoMock = $this->getMock('\Magento\Sales\Model\Order\Creditmemo', [
- 'setBaseCost', 'getAllItems', 'getOrder', 'getBaseShippingAmount', 'roundPrice', 'setDiscountAmount',
- 'setBaseDiscountAmount'
- ], [], '', false);
+ ],
+ [],
+ '',
+ false
+ );
+ $this->creditmemoMock = $this->getMock('\Magento\Sales\Model\Order\Creditmemo',
+ [
+ 'setBaseCost', 'getAllItems', 'getOrder', 'getBaseShippingAmount', 'roundPrice',
+ 'setDiscountAmount', 'setBaseDiscountAmount'
+ ],
+ [],
+ '',
+ false
+ );
$this->creditmemoItemMock = $this->getMock(
'\Magento\Sales\Model\Order\Creditmemo\Item',
[
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/SubtotalTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/SubtotalTest.php
index 1cfa0bb6b04..619ec8dc3e1 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/SubtotalTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Creditmemo/Total/SubtotalTest.php
@@ -30,19 +30,32 @@ class SubtotalTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
- $this->orderMock = $this->getMock('Magento\Sales\Model\Order', [
- 'getBaseShippingDiscountAmount', 'getBaseShippingAmount', 'getShippingAmount'
- ], [], '', false);
+ $this->orderMock = $this->getMock('Magento\Sales\Model\Order',
+ ['getBaseShippingDiscountAmount', 'getBaseShippingAmount', 'getShippingAmount'],
+ [],
+ '',
+ false
+ );
$this->orderItemMock = $this->getMock('Magento\Sales\Model\Order',
[
'isDummy', 'getDiscountInvoiced', 'getBaseDiscountInvoiced', 'getQtyInvoiced', 'getQty',
'getDiscountRefunded', 'getQtyRefunded'
- ], [], '', false);
- $this->creditmemoMock = $this->getMock('\Magento\Sales\Model\Order\Creditmemo', [
- 'setBaseCost', 'getAllItems', 'getOrder', 'getBaseShippingAmount', 'roundPrice', 'setDiscountAmount',
- 'setBaseDiscountAmount', 'setSubtotal', 'setBaseSubtotal', 'setSubtotalInclTax', 'setBaseSubtotalInclTax',
- 'getGrandTotal', 'setGrandTotal', 'getBaseGrandTotal', 'setBaseGrandTotal'
- ], [], '', false);
+ ],
+ [],
+ '',
+ false
+ );
+ $this->creditmemoMock = $this->getMock('\Magento\Sales\Model\Order\Creditmemo',
+ [
+ 'setBaseCost', 'getAllItems', 'getOrder', 'getBaseShippingAmount', 'roundPrice',
+ 'setDiscountAmount', 'setBaseDiscountAmount', 'setSubtotal', 'setBaseSubtotal',
+ 'setSubtotalInclTax', 'setBaseSubtotalInclTax', 'getGrandTotal', 'setGrandTotal',
+ 'getBaseGrandTotal', 'setBaseGrandTotal'
+ ],
+ [],
+ '',
+ false
+ );
$this->creditmemoItemMock = $this->getMock(
'\Magento\Sales\Model\Order\Creditmemo\Item',
[
@@ -83,7 +96,6 @@ class SubtotalTest extends \PHPUnit_Framework_TestCase
$this->creditmemoItemMock->expects($this->once())
->method('getBaseRowTotalInclTax')
->willReturn(1);
-
$this->creditmemoMock->expects($this->once())
->method('setSubtotal')
->with(1)
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Grid/Row/UrlGeneratorTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Grid/Row/UrlGeneratorTest.php
index 0b18010b304..51dcfffa426 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Grid/Row/UrlGeneratorTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Grid/Row/UrlGeneratorTest.php
@@ -30,9 +30,9 @@ class UrlGeneratorTest extends \PHPUnit_Framework_TestCase
'Magento\Framework\AuthorizationInterface', [], '', false, false, true, []
);
$this->urlGenerator = new \Magento\Sales\Model\Order\Grid\Row\UrlGenerator(
- $this->urlMock, $this->authorizationMock, [
- 'path' => 'path'
- ]
+ $this->urlMock,
+ $this->authorizationMock,
+ ['path' => 'path']
);
}
diff --git a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Invoice/ItemTest.php b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Invoice/ItemTest.php
index 403c9697316..bf6457146c5 100644
--- a/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Invoice/ItemTest.php
+++ b/dev/tests/unit/testsuite/Magento/Sales/Model/Order/Invoice/ItemTest.php
@@ -36,29 +36,38 @@ class ItemTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
$this->objectManager = new \Magento\TestFramework\Helper\ObjectManager($this);
- $this->orderItemFactoryMock = $this->getMock(
- 'Magento\Sales\Model\Order\ItemFactory', ['create'], [], '', false
+ $this->orderItemFactoryMock = $this->getMock('Magento\Sales\Model\Order\ItemFactory',
+ ['create'],
+ [],
+ '',
+ false
);
- $this->invoiceMock = $this->getMock(
- 'Magento\Sales\Model\Order\Invoice', [
-
- ], [], '', false
+ $this->invoiceMock = $this->getMock('Magento\Sales\Model\Order\Invoice',
+ [],
+ [],
+ '',
+ false
);
- $this->orderMock = $this->getMock(
- 'Magento\Sales\Model\Order', [], [], '', false
+ $this->orderMock = $this->getMock('Magento\Sales\Model\Order',
+ [],
+ [],
+ '',
+ false
);
- $this->orderItemMock = $this->getMock(
- 'Magento\Sales\Model\Order\Item', [
+ $this->orderItemMock = $this->getMock('Magento\Sales\Model\Order\Item',
+ [
'load', 'isDummy', 'getIsQtyDecimal', 'getQtyToInvoice', 'getQtyInvoiced', 'getTaxInvoiced',
'getBaseTaxInvoiced', 'getHiddenTaxInvoiced', 'getBaseHiddenTaxInvoiced', 'getDiscountInvoiced',
'getBaseDiscountInvoiced', 'getRowInvoiced', 'getBaseRowInvoiced', 'setQtyInvoiced', 'setTaxInvoiced',
'setBaseTaxInvoiced', 'setHiddenTaxInvoiced', 'setBaseHiddenTaxInvoiced', 'setDiscountInvoiced',
'setBaseDiscountInvoiced', 'setRowInvoiced', 'setBaseRowInvoiced', 'getQtyOrdered', 'getRowTotal',
'getBaseRowTotal', 'getRowTotalInclTax', 'getBaseRowTotalInclTax'
- ], [], '', false
+ ],
+ [],
+ '',
+ false
);
- $this->item = $this->objectManager->getObject(
- 'Magento\Sales\Model\Order\Invoice\Item',
+ $this->item = $this->objectManager->getObject('Magento\Sales\Model\Order\Invoice\Item',
[
'orderItemFactory' => $this->orderItemFactoryMock
]
--
GitLab