From 9b16e366288c08ffe1df21184ed00570a3a26386 Mon Sep 17 00:00:00 2001 From: Joan He <johe@magento.com> Date: Fri, 23 Dec 2016 17:07:02 -0600 Subject: [PATCH] MAGETWO-62253: Refactor code to remove unserialize - address code review comments --- .../Backend/Test/Unit/Model/Menu/ItemTest.php | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/app/code/Magento/Backend/Test/Unit/Model/Menu/ItemTest.php b/app/code/Magento/Backend/Test/Unit/Model/Menu/ItemTest.php index f8b26ce7aae..218dfb62ba8 100644 --- a/app/code/Magento/Backend/Test/Unit/Model/Menu/ItemTest.php +++ b/app/code/Magento/Backend/Test/Unit/Model/Menu/ItemTest.php @@ -377,7 +377,7 @@ class ItemTest extends \PHPUnit_Framework_TestCase $menuMock = $this->getMock(\Magento\Backend\Model\Menu::class, [], [], '', false); $this->_menuFactoryMock->method('create')->will($this->returnValue($menuMock)); $menuMock->method('toArray') - ->willReturn(isset($constructorData['sub_menu']) ? $constructorData['sub_menu'] : null); + ->willReturn(['submenuArray']); $model = $this->objectManager->getObject( \Magento\Backend\Model\Menu\Item::class, @@ -468,7 +468,7 @@ class ItemTest extends \PHPUnit_Framework_TestCase 'depends_on_module' => null, 'tooltip' => '', 'title' => null, - 'sub_menu' => null + 'sub_menu' => ['submenuArray'] ], ], 'data with submenu to constructor' => [ @@ -520,15 +520,7 @@ class ItemTest extends \PHPUnit_Framework_TestCase 'depends_on_module' => null, 'tooltip' => '', 'title' => null, - 'sub_menu' => [ - 'id' => 'item', - 'title' => 'Item Title', - 'action' => '/system/config', - 'resource' => 'Magento_Config::config', - 'depends_on_module' => 'Magento_Backend', - 'depends_on_config' => 'system/config/isEnabled', - 'tooltip' => 'Item tooltip', - ] + 'sub_menu' => ['submenuArray'] ], ] ]; -- GitLab