From 96fb283db2308fcbec05b1d34f968b796adfe33c Mon Sep 17 00:00:00 2001 From: Dmytro Poperechnyy <dpoperechnyy@magento.com> Date: Fri, 12 Jan 2018 14:05:20 +0200 Subject: [PATCH] MAGETWO-86154: Wrong page cached for logged in user - Update unit test; --- .../Framework/App/Test/Unit/Response/HttpTest.php | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/internal/Magento/Framework/App/Test/Unit/Response/HttpTest.php b/lib/internal/Magento/Framework/App/Test/Unit/Response/HttpTest.php index 47974f8d24e..f9aed16ec6a 100644 --- a/lib/internal/Magento/Framework/App/Test/Unit/Response/HttpTest.php +++ b/lib/internal/Magento/Framework/App/Test/Unit/Response/HttpTest.php @@ -45,6 +45,9 @@ class HttpTest extends \PHPUnit\Framework\TestCase /** @var ConfigInterface|\PHPUnit_Framework_MockObject_MockObject */ private $sessionConfigMock; + /** @var int */ + private $cookieLifeTime = 3600; + protected function setUp() { $this->objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this); @@ -111,11 +114,11 @@ class HttpTest extends \PHPUnit\Framework\TestCase $this->sessionConfigMock->expects($this->once()) ->method('getCookieLifetime') - ->willReturn(3600); + ->willReturn($this->cookieLifeTime); $this->cookieMetadataFactoryMock->expects($this->once()) ->method('createSensitiveCookieMetadata') - ->with([CookieMetadata::KEY_DURATION => 3600]) + ->with([CookieMetadata::KEY_DURATION => $this->cookieLifeTime]) ->willReturn($sensitiveCookieMetadataMock); $this->cookieManagerMock->expects($this->once()) @@ -135,12 +138,8 @@ class HttpTest extends \PHPUnit\Framework\TestCase $this->contextMock->expects($this->once()) ->method('getVaryString') ->willReturn(null); - $this->sessionConfigMock->expects($this->once()) - ->method('getCookieLifetime') - ->willReturn(120); $this->cookieMetadataFactoryMock->expects($this->once()) ->method('createSensitiveCookieMetadata') - ->with([CookieMetadata::KEY_DURATION => 120]) ->willReturn($cookieMetadataMock); $this->cookieManagerMock->expects($this->once()) ->method('deleteCookie') -- GitLab