From 77044296e23d4884d2817cade3345db74abfbcfd Mon Sep 17 00:00:00 2001 From: Ankur Kaneria <akaneria@magento.com> Date: Tue, 17 May 2016 15:12:01 -0500 Subject: [PATCH] MAGETWO-52000: [Github][PR]impossible to see what is wrong with cron - unhelpful error message #3189 - Code update to fix QA issues --- .../Setup/Model/Cron/SetupLoggerFactory.php | 36 +++---------------- 1 file changed, 4 insertions(+), 32 deletions(-) diff --git a/setup/src/Magento/Setup/Model/Cron/SetupLoggerFactory.php b/setup/src/Magento/Setup/Model/Cron/SetupLoggerFactory.php index 7b922ad6b77..251930cefad 100644 --- a/setup/src/Magento/Setup/Model/Cron/SetupLoggerFactory.php +++ b/setup/src/Magento/Setup/Model/Cron/SetupLoggerFactory.php @@ -6,37 +6,11 @@ namespace Magento\Setup\Model\Cron; -use Magento\Setup\Model\ObjectManagerProvider; - /** * Class to get PSR-3 compliant logger instance */ class SetupLoggerFactory { - /** - * @var ObjectManagerProvider - */ - private $objectManagerProvider; - - /** - * @var SetupStreamHandler - */ - private $setupStreamHandler; - - /** - * Constructor - * - * @param ObjectManagerProvider $objectManagerProvider - * @param SetupStreamHandler $setupStreamHandler - */ - public function __construct( - ObjectManagerProvider $objectManagerProvider, - SetupStreamHandler $setupStreamHandler - ) { - $this->objectManagerProvider = $objectManagerProvider; - $this->setupStreamHandler = $setupStreamHandler; - } - /** * Create logger instance. * @@ -44,13 +18,11 @@ class SetupLoggerFactory * * @return \Psr\Log\LoggerInterface */ - public function create($channelName) + public function create($channelName = 'setup-cron') { - /** @var \Magento\Framework\Logger\Monolog $logger */ - $logger = $this->objectManagerProvider - ->get() - ->create('Magento\Framework\Logger\Monolog', ['name' => $channelName]); - $logger->pushHandler($this->setupStreamHandler); + $logger = new \Monolog\Logger($channelName); + $path = BP . '/var/log/update.log'; + $logger->pushHandler(new \Monolog\Handler\StreamHandler($path)); return $logger; } } -- GitLab