diff --git a/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php b/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php index 5d82eb6380c34bbcb735228dce65c15449bbdbf4..bbd0a44254e89ce2e84d3bbe7e043ac80c76a435 100644 --- a/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php +++ b/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php @@ -7,7 +7,6 @@ namespace Magento\Setup\Console\Command; use Magento\Framework\Setup\ConsoleLogger; use Magento\Setup\Model\InstallerFactory; -use Magento\Setup\Model\ObjectManagerProvider; use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; @@ -29,21 +28,14 @@ class UpgradeCommand extends AbstractSetupCommand */ private $installerFactory; - /** - * @var \Magento\Setup\Model\ObjectManagerProvider; - */ - private $objectManagerProvider; - /** * Constructor * * @param InstallerFactory $installerFactory - * @param ObjectManagerProvider $objectManagerProvider */ - public function __construct(InstallerFactory $installerFactory, ObjectManagerProvider $objectManagerProvider) + public function __construct(InstallerFactory $installerFactory) { $this->installerFactory = $installerFactory; - $this->objectManagerProvider = $objectManagerProvider; parent::__construct(); } diff --git a/setup/src/Magento/Setup/Test/Unit/Console/Command/UpgradeCommandTest.php b/setup/src/Magento/Setup/Test/Unit/Console/Command/UpgradeCommandTest.php index 17d78718e4bf4bcdc2978c946fe98223b8169011..7c1f72a4edd27fb111ded76cc0b16a52f95d4865 100644 --- a/setup/src/Magento/Setup/Test/Unit/Console/Command/UpgradeCommandTest.php +++ b/setup/src/Magento/Setup/Test/Unit/Console/Command/UpgradeCommandTest.php @@ -7,35 +7,19 @@ namespace Magento\Setup\Test\Unit\Console\Command; use Magento\Setup\Console\Command\UpgradeCommand; use Symfony\Component\Console\Tester\CommandTester; +use Magento\Framework\Console\Cli; class UpgradeCommandTest extends \PHPUnit_Framework_TestCase { public function testExecute() { $installerFactory = $this->getMock('Magento\Setup\Model\InstallerFactory', [], [], '', false); - $objectManagerProvider = $this->getMock('\Magento\Setup\Model\ObjectManagerProvider', [], [], '', false); - $objectManager = $this->getMockForAbstractClass('Magento\Framework\ObjectManagerInterface'); - $configLoader = $this->getMockForAbstractClass('Magento\Framework\ObjectManager\ConfigLoaderInterface'); - $configLoader->expects($this->once())->method('load')->willReturn(['some_key' => 'some_value']); - $state = $this->getMock('Magento\Framework\App\State', [], [], '', false); - $state->expects($this->once())->method('setAreaCode')->with('setup'); - $objectManagerProvider->expects($this->once())->method('get')->willReturn($objectManager); - $objectManager->expects($this->once())->method('configure'); - $state->expects($this->once())->method('setAreaCode')->with('setup'); $installer = $this->getMock('Magento\Setup\Model\Installer', [], [], '', false); $installer->expects($this->at(0))->method('updateModulesSequence'); $installer->expects($this->at(1))->method('installSchema'); $installer->expects($this->at(2))->method('installDataFixtures'); $installerFactory->expects($this->once())->method('create')->willReturn($installer); - - $objectManager->expects($this->exactly(2)) - ->method('get') - ->will($this->returnValueMap([ - ['Magento\Framework\App\State', $state], - ['Magento\Framework\ObjectManager\ConfigLoaderInterface', $configLoader] - ])); - - $commandTester = new CommandTester(new UpgradeCommand($installerFactory, $objectManagerProvider)); - $commandTester->execute([]); + $commandTester = new CommandTester(new UpgradeCommand($installerFactory)); + $this->assertSame(Cli::RETURN_SUCCESS, $commandTester->execute([])); } }