diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/View.php b/app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/View.php index 8b8b1d411d158ccffc89d70e9e1528c1bef4b2eb..06e42091731751c2306be89d9742abcf0328a624 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/View.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/View.php @@ -40,7 +40,7 @@ class View extends \Magento\Backend\App\Action public function execute() { $resultForward = $this->resultForwardFactory->create(); - if ($creditmemoId = $this->getRequest()->getParam('creditmemo_id')) { + if ($this->getRequest()->getParam('creditmemo_id')) { $resultForward->setController('order_creditmemo'); $resultForward->setParams(['come_from' => 'sales_creditmemo']); $resultForward->forward('view'); diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/CommentsHistory.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/CommentsHistory.php index 68f062373343eb09862dd2c2690e046f0187ad32..737fa3bfed281122037be5dcffbba176b3dc76d6 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/CommentsHistory.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/CommentsHistory.php @@ -26,6 +26,8 @@ class CommentsHistory extends \Magento\Sales\Controller\Adminhtml\Order * @param \Magento\Framework\View\Result\LayoutFactory $resultLayoutFactory * @param \Magento\Framework\Controller\Result\RawFactory $resultRawFactory * @param \Magento\Framework\View\LayoutFactory $layoutFactory + * + * @SuppressWarnings(PHPMD.ExcessiveParameterList) */ public function __construct( Action\Context $context, diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/Create/Save.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/Create/Save.php index 2f0c4dd49369f39b19533b88c2e0071c8e1e1f4d..a3dfe5d004febe5e5dc407996eacecc49d6e2013 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/Create/Save.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/Create/Save.php @@ -11,6 +11,8 @@ class Save extends \Magento\Sales\Controller\Adminhtml\Order\Create * Saving quote and create order * * @return \Magento\Backend\Model\View\Result\Forward|\Magento\Backend\Model\View\Result\Redirect + * + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Save.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Save.php index 8cb6adf232ea819ee41a2eb556aefe7c4bf38db4..a505050d951412ccac147e0575be9908f5909a40 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Save.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Save.php @@ -65,6 +65,9 @@ class Save extends \Magento\Backend\App\Action * We can save only new creditmemo. Existing creditmemos are not editable * * @return \Magento\Backend\Model\View\Result\Redirect|\Magento\Backend\Model\View\Result\Forward + * + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/Save.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/Save.php index c4707bb557762d3907fdcaa497b45eba70d2e997..2016270003fdcdc3f06dbc9799fcf15999735fcf 100755 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/Save.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/Save.php @@ -104,6 +104,10 @@ class Save extends \Magento\Backend\App\Action * We can save only new invoice. Existing invoices are not editable * * @return \Magento\Framework\Controller\ResultInterface + * + * @SuppressWarnings(PHPMD.CyclomaticComplexity) + * @SuppressWarnings(PHPMD.NPathComplexity) + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Order/Pdfdocs.php b/app/code/Magento/Sales/Controller/Adminhtml/Order/Pdfdocs.php index e43302c73d23e195cbac820d49ba15f42a841f39..498c72f47cdb59e517ec9a9c4b9c8c7f3ab28518 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Order/Pdfdocs.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Order/Pdfdocs.php @@ -14,6 +14,8 @@ class Pdfdocs extends \Magento\Sales\Controller\Adminhtml\Order * Print all documents for selected orders * * @return ResponseInterface|\Magento\Backend\Model\View\Result\Redirect + * + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/app/code/Magento/Sales/Controller/Adminhtml/Shipment/AbstractShipment/View.php b/app/code/Magento/Sales/Controller/Adminhtml/Shipment/AbstractShipment/View.php index b6cd85fdaa1d399d9fa7bef952392c58a8bfea84..150f98e597b106cb50e7d0dccd1c30574d1ce6dd 100644 --- a/app/code/Magento/Sales/Controller/Adminhtml/Shipment/AbstractShipment/View.php +++ b/app/code/Magento/Sales/Controller/Adminhtml/Shipment/AbstractShipment/View.php @@ -45,7 +45,7 @@ abstract class View extends \Magento\Backend\App\Action { /** @var \Magento\Backend\Model\View\Result\Forward $resultForward */ $resultForward = $this->resultForwardFactory->create(); - if ($shipmentId = $this->getRequest()->getParam('shipment_id')) { + if ($this->getRequest()->getParam('shipment_id')) { $resultForward->setController('order_shipment') ->setModule('admin') ->setParams(['come_from' => 'shipment']) diff --git a/app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php b/app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php index d23334396e3c7ecadfd3610155d3f1a8d04a20a3..41672127ee11904497c36a13f859e6e7fb1505da 100644 --- a/app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php +++ b/app/code/Magento/Sales/Controller/Download/DownloadCustomOption.php @@ -42,6 +42,8 @@ class DownloadCustomOption extends \Magento\Framework\App\Action\Action * Custom options download action * * @return void|\Magento\Framework\Controller\Result\Forward + * + * @SuppressWarnings(PHPMD.CyclomaticComplexity) */ public function execute() { diff --git a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php index e838cf19ac13114abfa742b94bb4f9e8e4211c61..4d23754e8f950f99d98d5089996b0822f0251a7d 100644 --- a/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php +++ b/dev/tests/unit/testsuite/Magento/Customer/Controller/Account/ConfirmTest.php @@ -14,6 +14,7 @@ use Magento\Store\Model\ScopeInterface; /** * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + * @SuppressWarnings(PHPMD.TooManyFields) */ class ConfirmTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Invoice/AbstractInvoice/EmailTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Invoice/AbstractInvoice/EmailTest.php index d46f89612d4160825a36c5d9ccf797509fec5ee3..e956fe60276cb3503e9b3a3be30a7a064d0159c0 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Invoice/AbstractInvoice/EmailTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Invoice/AbstractInvoice/EmailTest.php @@ -13,6 +13,7 @@ use Magento\TestFramework\Helper\ObjectManager as ObjectManagerHelper; * Class EmailTest * * @package Magento\Sales\Controller\Adminhtml\Invoice\AbstractInvoice + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class EmailTest extends \PHPUnit_Framework_TestCase { @@ -85,7 +86,7 @@ class EmailTest extends \PHPUnit_Framework_TestCase { $objectManagerHelper = new ObjectManagerHelper($this); $this->context = $this->getMock('Magento\Backend\App\Action\Context', [], [], '', false); - $this->response = $this->getMock('Magento\Framework\App\ResponseInterface', [], [], '', false ); + $this->response = $this->getMock('Magento\Framework\App\ResponseInterface', [], [], '', false); $this->request = $this->getMock('Magento\Framework\App\RequestInterface', [], [], '', false); $this->objectManager = $this->getMock('Magento\Framework\ObjectManager\ObjectManager', [], [], '', false); $this->messageManager = $this->getMock('Magento\Framework\Message\Manager', [], [], '', false); diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php index f14ced4cbad7873ae7ffecc257c52da767deb733..8173d67f13fe1dee49fb9190589918e6c6387595 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/PrintActionTest.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Controller\Adminhtml\Order\Creditmemo; /** * @covers \Magento\Sales\Controller\Adminhtml\Order\Creditmemo\PrintAction + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class PrintActionTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php index 6f1dbb52a6fe6d5afc72f3ab8c2112c1d2a5dcb3..d41004a8daa3fe9a2b0f04e1e9c471672807cbb8 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/SaveTest.php @@ -8,6 +8,9 @@ namespace Magento\Sales\Controller\Adminhtml\Order\Creditmemo; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class SaveTest extends \PHPUnit_Framework_TestCase { /** diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/UpdateQtyTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/UpdateQtyTest.php index 27140e0983a1fc2509df5eace2463250a2e90306..2b20cdac359952d255addbecce0808b8d26cfae9 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/UpdateQtyTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/UpdateQtyTest.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Controller\Adminhtml\Order\Creditmemo; /** * Class UpdateQtyTest + * @SuppressWarnings(PHPMD.TooManyFields) */ class UpdateQtyTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php index 82076d7134d37651942e3c6c156dd5327214f42f..d6c1ea00b10af2bf2fa4a905e2c125bcc8c4005c 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ViewTest.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Controller\Adminhtml\Order\Creditmemo; /** * Class ViewTest + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class ViewTest extends \PHPUnit_Framework_TestCase { @@ -100,6 +101,9 @@ class ViewTest extends \PHPUnit_Framework_TestCase */ protected $resultForwardMock; + /** + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) + */ public function setUp() { $titleMock = $this->getMockBuilder('Magento\Framework\App\Action\Title') diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/VoidTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/VoidTest.php index afe16d5df05481e94ab68c10b360666efe6d8490..3e3a9460618810e1bce2ef380b0239b4e79e2f82 100644 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/VoidTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/VoidTest.php @@ -7,6 +7,7 @@ namespace Magento\Sales\Controller\Adminhtml\Order\Creditmemo; /** * Class VoidTest + * @SuppressWarnings(PHPMD.TooManyFields) */ class VoidTest extends \PHPUnit_Framework_TestCase { diff --git a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewActionTest.php b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewActionTest.php index cb07128c7f870b74f539136cd1be42bb9319a15e..6d06bf0d76155db4c34b7a664b8f755e12909599 100755 --- a/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewActionTest.php +++ b/dev/tests/unit/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewActionTest.php @@ -10,6 +10,7 @@ use Magento\TestFramework\Helper\ObjectManager; /** * Class NewActionTest * @package Magento\Sales\Controller\Adminhtml\Order\Invoice + * @SuppressWarnings(PHPMD.ExcessiveMethodLength) */ class NewActionTest extends \PHPUnit_Framework_TestCase {