From 64bf208aea55998942fe2035a9679e1f470bed8d Mon Sep 17 00:00:00 2001
From: Carlos Lizaga <carlos.lizaga@pronovias.com>
Date: Wed, 22 Nov 2017 19:26:54 +0100
Subject: [PATCH] Eslint improvements and logical fixes for unit testing.
---
.../js/jasmine/tests/lib/mage/accordion.test.js | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/dev/tests/js/jasmine/tests/lib/mage/accordion.test.js b/dev/tests/js/jasmine/tests/lib/mage/accordion.test.js
index 12ca91a4ae0..19a54d95cf7 100644
--- a/dev/tests/js/jasmine/tests/lib/mage/accordion.test.js
+++ b/dev/tests/js/jasmine/tests/lib/mage/accordion.test.js
@@ -10,7 +10,7 @@ define([
describe('Test for mage/accordion jQuery plugin', function () {
it('check if accordion can be initialized', function () {
- var accordion = $("<div/>");
+ var accordion = $('<div/>');
accordion.accordion();
expect(accordion.is(':mage-accordion')).toBeTruthy();
@@ -50,12 +50,11 @@ define([
});
it('check multi-collapsible element accordion', function () {
var accordion = $('<div/>'),
+ title1 = $('<div data-role="collapsible"></div>').appendTo(accordion),
content1 = $('<div data-role="content"></div>').appendTo(accordion),
title2 = $('<div data-role="collapsible"></div>').appendTo(accordion),
content2 = $('<div data-role="content"></div>').appendTo(accordion);
- $('<div data-role="collapsible"></div>').appendTo(accordion);
-
accordion.appendTo('body');
accordion.accordion({
@@ -63,17 +62,18 @@ define([
});
expect(accordion.is(':mage-accordion')).toBeTruthy();
-
expect(content1.is(':visible')).toBeTruthy();
expect(content2.is(':hidden')).toBeTruthy();
- title2.trigger('click');
+ $(title1).trigger('click');
+ expect(content1.is(':visible')).toBeTruthy();
+ expect(content2.is(':hidden')).toBeTruthy();
+ $(title2).trigger('click');
expect(content1.is(':visible')).toBeTruthy();
expect(content2.is(':visible')).toBeTruthy();
accordion.accordion('destroy');
-
expect(accordion.is(':mage-accordion')).toBeFalsy();
});
});
--
GitLab