From 5ed5b224887484319fea1464ca0aa8e8c76a165a Mon Sep 17 00:00:00 2001 From: Christopher O'Toole <otoolec@x.com> Date: Mon, 26 Jan 2015 09:01:00 -0600 Subject: [PATCH] MAGETWO-32870: [GITHUB] extra tests for current interception behavior #965 - Suppress warnings for test fixtures --- .../Interception/Fixture/Intercepted.php | 15 +++++++ .../Fixture/Intercepted/FirstPlugin.php | 42 +++++++++++++++++++ .../Fixture/Intercepted/Plugin.php | 24 +++++++++++ 3 files changed, 81 insertions(+) diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php index 6248d50fea2..6213b569b94 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php @@ -78,26 +78,41 @@ class Intercepted extends InterceptedParent implements InterceptedInterface return '<K>' . $param1 . '</K>'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function V($param1) { return '<V>' . $param1 . '</V>'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function W($param1) { return '<W>' . $param1 . '</W>'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function X($param1) { return '<X>' . $param1 . '</X>'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function Y($param1) { return '<Y>' . $param1 . '</Y>'; } + /** + * @SuppressWarnings(PHPMD.ShortMethodName) + */ public function Z($param1) { return '<Z>' . $param1 . '</Z>'; diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/FirstPlugin.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/FirstPlugin.php index 596f8c38d72..3babf53be8f 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/FirstPlugin.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/FirstPlugin.php @@ -14,73 +14,115 @@ class FirstPlugin */ protected $_counter = 0; + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundC(Intercepted $subject, \Closure $next, $param1) { return '<F:C>' . $next($param1) . '</F:C>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundD(Intercepted $subject, \Closure $next, $param1) { $this->_counter++; return '<F:D>' . $this->_counter . ': ' . $next($param1) . '</F:D>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundK(Intercepted $subject, \Closure $next, $param1) { $result = $subject->C($param1); return '<F:K>' . $subject->F($result) . '</F:K>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function beforeG(Intercepted $subject, $param1) { return ['<F:bG>' . $param1 . '</F:bG>']; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundG(Intercepted $subject, \Closure $next, $param1) { return $next('<F:G>' . $param1 . '</F:G>'); } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function afterG(Intercepted $subject, $result) { return '<F:aG>' . $result . '</F:aG>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function beforeV(Intercepted $subject, $param1) { return ['<F:bV/>']; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundV(Intercepted $subject, \Closure $next, $param1) { return '<F:V>' . $param1 . '<F:V/>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function beforeW(Intercepted $subject, $param1) { return ['<F:bW/>']; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundW(Intercepted $subject, \Closure $next, $param1) { return '<F:W>' . $param1 . '<F:W/>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function afterW(Intercepted $subject, $result) { return '<F:aW/>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function beforeX(Intercepted $subject, $param1) { return ['<F:bX/>']; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundY(Intercepted $subject, \Closure $next, $param1) { return '<F:Y>' . $param1 . '<F:Y/>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function afterZ(Intercepted $subject, $result) { return '<F:aZ/>'; diff --git a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/Plugin.php b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/Plugin.php index e8155a4d589..fab9c11c709 100644 --- a/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/Plugin.php +++ b/dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted/Plugin.php @@ -65,41 +65,65 @@ class Plugin return '<P:aG>' . $result . '</P:aG>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function beforeV(Intercepted $subject, $param1) { return ['<P:bV/>']; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundV(Intercepted $subject, \Closure $next, $param1) { return '<P:V>' . $param1 . '<P:V/>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function beforeW(Intercepted $subject, $param1) { return ['<P:bW/>']; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundW(Intercepted $subject, \Closure $next, $param1) { return '<P:W>' . $param1 . '<P:W/>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function afterW(Intercepted $subject, $result) { return '<P:aW/>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function beforeX(Intercepted $subject, $param1) { return ['<P:bX/>']; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function aroundY(Intercepted $subject, \Closure $next, $param1) { return '<P:Y>' . $param1 . '<P:Y/>'; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ public function afterZ(Intercepted $subject, $result) { return '<P:aZ/>'; -- GitLab