From 5b9f11d50cb1be00c1632209239a8344a8fed482 Mon Sep 17 00:00:00 2001 From: Dale Sikkema <dsikkema@ebay.com> Date: Mon, 19 Oct 2015 16:54:26 -0500 Subject: [PATCH] =?UTF-8?q?MAGETWO-43435:=20[Github]=20=C2=ABi18n:collect-?= =?UTF-8?q?phrases=C2=BB=20command=20wrongly=20handles=20PHP=20string=20co?= =?UTF-8?q?ncatenation=20=20-=20style=20test=20fixes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../Setup/Console/Command/_files/phrases/TestPhrases.php | 3 +++ .../Parser/Adapter/Php/Tokenizer/PhraseCollectorTest.php | 6 +++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/dev/tests/integration/testsuite/Magento/Setup/Console/Command/_files/phrases/TestPhrases.php b/dev/tests/integration/testsuite/Magento/Setup/Console/Command/_files/phrases/TestPhrases.php index 1e46c79299a..f3306a521ad 100644 --- a/dev/tests/integration/testsuite/Magento/Setup/Console/Command/_files/phrases/TestPhrases.php +++ b/dev/tests/integration/testsuite/Magento/Setup/Console/Command/_files/phrases/TestPhrases.php @@ -8,6 +8,9 @@ use Magento\Framework\Phrase; +/** + * @SuppressWarnings(PHPMD) + */ class TestPhrases { public function awesomeFunction() diff --git a/setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/Php/Tokenizer/PhraseCollectorTest.php b/setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/Php/Tokenizer/PhraseCollectorTest.php index e4dccc6fd63..b4f7d60a1ca 100644 --- a/setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/Php/Tokenizer/PhraseCollectorTest.php +++ b/setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/Php/Tokenizer/PhraseCollectorTest.php @@ -215,7 +215,11 @@ class PhraseCollectorTest extends \PHPUnit_Framework_TestCase $phraseTokens = [$firstPartToken, $concatenationToken, $secondPartToken]; $phraseString = "'first part' . ' second part'"; - $reflectionMethod = new \ReflectionMethod('\Magento\Setup\Module\I18n\Parser\Adapter\Php\Tokenizer\PhraseCollector', '_collectPhrase'); + $reflectionMethod = new \ReflectionMethod( + '\Magento\Setup\Module\I18n\Parser\Adapter\Php\Tokenizer\PhraseCollector', + '_collectPhrase' + ); + $reflectionMethod->setAccessible(true); $this->assertSame($phraseString, $reflectionMethod->invoke($this->phraseCollector, $phraseTokens)); } -- GitLab