From 4f9c5c383a3135d7a7dbe47a16976cf0eafe66a9 Mon Sep 17 00:00:00 2001 From: Igor Melnikov <imelnikov@magento.com> Date: Thu, 6 Oct 2016 16:49:17 -0500 Subject: [PATCH] MAGETWO-58017: [GITHUB] Error creating configurable products in 2.1.1 #6424 Improving retrieving of the version --- .../Test/Unit/View/Deployment/VersionTest.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/internal/Magento/Framework/App/Test/Unit/View/Deployment/VersionTest.php b/lib/internal/Magento/Framework/App/Test/Unit/View/Deployment/VersionTest.php index badd9e580cf..187c043945d 100644 --- a/lib/internal/Magento/Framework/App/Test/Unit/View/Deployment/VersionTest.php +++ b/lib/internal/Magento/Framework/App/Test/Unit/View/Deployment/VersionTest.php @@ -82,20 +82,20 @@ class VersionTest extends \PHPUnit_Framework_TestCase } /** - * $param bool $unexpectedValueExceptionThrown - * $param bool $fileSystemExceptionThrown + * $param bool $isUnexpectedValueExceptionThrown + * $param bool $isFileSystemExceptionThrown * @dataProvider getValueDefaultModeDataProvider */ public function testGetValueDefaultMode( - $unexpectedValueExceptionThrown, - $fileSystemExceptionThrown = null + $isUnexpectedValueExceptionThrown, + $isFileSystemExceptionThrown = null ) { $versionType = 'integer'; $this->appStateMock ->expects($this->once()) ->method('getMode') ->willReturn(\Magento\Framework\App\State::MODE_DEFAULT); - if ($unexpectedValueExceptionThrown) { + if ($isUnexpectedValueExceptionThrown) { $storageException = new \UnexpectedValueException('Does not exist in the storage'); $this->versionStorageMock ->expects($this->once()) @@ -104,7 +104,7 @@ class VersionTest extends \PHPUnit_Framework_TestCase $this->versionStorageMock->expects($this->once()) ->method('save') ->with($this->isType($versionType)); - if ($fileSystemExceptionThrown) { + if ($isFileSystemExceptionThrown) { $fileSystemException = new FileSystemException( new \Magento\Framework\Phrase('Can not load static content version') ); @@ -144,17 +144,17 @@ class VersionTest extends \PHPUnit_Framework_TestCase } /** - * @param bool $unexpectedValueExceptionThrown + * @param bool $isUnexpectedValueExceptionThrown * @dataProvider getValueProductionModeDataProvider */ public function testGetValueProductionMode( - $unexpectedValueExceptionThrown + $isUnexpectedValueExceptionThrown ) { $this->appStateMock ->expects($this->once()) ->method('getMode') ->willReturn(\Magento\Framework\App\State::MODE_PRODUCTION); - if ($unexpectedValueExceptionThrown) { + if ($isUnexpectedValueExceptionThrown) { $storageException = new \UnexpectedValueException('Does not exist in the storage'); $this->versionStorageMock ->expects($this->once()) -- GitLab