diff --git a/lib/internal/Magento/Framework/DB/TemporaryTableService.php b/lib/internal/Magento/Framework/DB/TemporaryTableService.php index a2c6f6d46515f4fc0011a65069d5c29af629ac31..7eabdf1af926c5acc8e99fe644114420aab42d12 100644 --- a/lib/internal/Magento/Framework/DB/TemporaryTableService.php +++ b/lib/internal/Magento/Framework/DB/TemporaryTableService.php @@ -16,8 +16,8 @@ use Magento\Framework\DB\Select; */ class TemporaryTableService { - CONST HASH = 'HASH'; - CONST INNODB = 'INNODB'; + const INDEX_METHOD_HASH = 'HASH'; + const INDEX_METHOD_INNODB = 'INNODB'; /** * @var string[] @@ -46,8 +46,8 @@ class TemporaryTableService */ public function __construct( \Magento\Framework\Math\Random $random, - $allowedIndexMethods = [self::HASH], - $allowedEngines = [self::INNODB] + $allowedIndexMethods = [], + $allowedEngines = [] ) { $this->random = $random; $this->allowedIndexMethods = $allowedIndexMethods; @@ -83,18 +83,18 @@ class TemporaryTableService Select $select, AdapterInterface $adapter, array $indexes = [], - $indexMethod = self::HASH, - $dbEngine = self::INNODB + $indexMethod = self::INDEX_METHOD_HASH, + $dbEngine = self::INDEX_METHOD_INNODB ) { if (!in_array($indexMethod, $this->allowedIndexMethods)) { throw new \InvalidArgumentException( - sprintf('indexMethod must be of type %s', implode(',', $this->allowedIndexMethods)) + sprintf('indexMethod must be one of %s', implode(',', $this->allowedIndexMethods)) ); } if (!in_array($dbEngine, $this->allowedEngines)) { throw new \InvalidArgumentException( - sprintf('dbEngine must be of type %s', implode(',', $this->allowedEngines)) + sprintf('dbEngine must be one of %s', implode(',', $this->allowedEngines)) ); } diff --git a/lib/internal/Magento/Framework/DB/Test/Unit/TemporaryTableServiceTest.php b/lib/internal/Magento/Framework/DB/Test/Unit/TemporaryTableServiceTest.php index 68ccad5e3855df6d947cf3b365f837aaf72c595e..960e5eb07e94a0ac4643d271aec4e53789a92acc 100644 --- a/lib/internal/Magento/Framework/DB/Test/Unit/TemporaryTableServiceTest.php +++ b/lib/internal/Magento/Framework/DB/Test/Unit/TemporaryTableServiceTest.php @@ -46,7 +46,9 @@ class TemporaryTableServiceTest extends \PHPUnit_Framework_TestCase $this->temporaryTableService = (new ObjectManager($this))->getObject( TemporaryTableService::class, [ - 'random' => $this->randomMock + 'random' => $this->randomMock, + 'allowedIndexMethods' => ['HASH'], + 'allowedEngines' => ['INNODB'] ] ); } @@ -72,8 +74,8 @@ class TemporaryTableServiceTest extends \PHPUnit_Framework_TestCase $this->selectMock, $this->adapterMock, $indexes, - TemporaryTableService::HASH . "Other", - TemporaryTableService::INNODB . "Other" + TemporaryTableService::INDEX_METHOD_HASH . "Other", + TemporaryTableService::INDEX_METHOD_INNODB . "Other" ) ); }