From 35a6ebba9944c66525d4c52b0f84fa8662681a76 Mon Sep 17 00:00:00 2001 From: Alexander Shkurko <coderimus@gmail.com> Date: Thu, 28 Dec 2017 09:32:33 +0100 Subject: [PATCH] FIX: remove not used count from templates --- .../templates/sales/order/creditmemo/items/renderer.phtml | 1 - .../templates/sales/order/invoice/items/renderer.phtml | 1 - .../frontend/templates/sales/order/items/renderer.phtml | 1 - .../templates/sales/order/shipment/items/renderer.phtml | 1 - .../view/frontend/templates/order/creditmemo/items.phtml | 1 - .../view/frontend/templates/order/invoice/items.phtml | 1 - .../view/frontend/templates/order/print/creditmemo.phtml | 7 +++---- .../view/frontend/templates/order/print/invoice.phtml | 7 +++---- .../Magento/Shipping/view/frontend/templates/items.phtml | 1 - 9 files changed, 6 insertions(+), 15 deletions(-) diff --git a/app/code/Magento/Bundle/view/frontend/templates/sales/order/creditmemo/items/renderer.phtml b/app/code/Magento/Bundle/view/frontend/templates/sales/order/creditmemo/items/renderer.phtml index b4c2c00e5ac..b9d075966c5 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/sales/order/creditmemo/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/sales/order/creditmemo/items/renderer.phtml @@ -12,7 +12,6 @@ <?php $items = $block->getChildren($parentItem) ?> <?php $_order = $block->getItem()->getOrderItem()->getOrder() ?> -<?php $_count = count($items) ?> <?php $_index = 0 ?> <?php $_prevOptionId = '' ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/sales/order/invoice/items/renderer.phtml b/app/code/Magento/Bundle/view/frontend/templates/sales/order/invoice/items/renderer.phtml index f3866d7b1b6..e18d75ce77b 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/sales/order/invoice/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/sales/order/invoice/items/renderer.phtml @@ -12,7 +12,6 @@ <?php $_order = $block->getItem()->getOrderItem()->getOrder() ?> <?php $items = $block->getChildren($parentItem) ?> -<?php $_count = count($items) ?> <?php $_index = 0 ?> <?php $_prevOptionId = '' ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/sales/order/items/renderer.phtml b/app/code/Magento/Bundle/view/frontend/templates/sales/order/items/renderer.phtml index 84cbd54d3bd..063d66edb9e 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/sales/order/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/sales/order/items/renderer.phtml @@ -10,7 +10,6 @@ ?> <?php $parentItem = $block->getItem() ?> <?php $items = array_merge([$parentItem], $parentItem->getChildrenItems()); ?> -<?php $_count = count($items) ?> <?php $_index = 0 ?> <?php $_prevOptionId = '' ?> diff --git a/app/code/Magento/Bundle/view/frontend/templates/sales/order/shipment/items/renderer.phtml b/app/code/Magento/Bundle/view/frontend/templates/sales/order/shipment/items/renderer.phtml index bd99afc59a8..0cd39156b25 100644 --- a/app/code/Magento/Bundle/view/frontend/templates/sales/order/shipment/items/renderer.phtml +++ b/app/code/Magento/Bundle/view/frontend/templates/sales/order/shipment/items/renderer.phtml @@ -12,7 +12,6 @@ <?php $parentItem = $block->getItem() ?> <?php $items = array_merge([$parentItem->getOrderItem()], $parentItem->getOrderItem()->getChildrenItems()) ?> <?php $shipItems = $block->getChildren($parentItem) ?> -<?php $_count = count($items) ?> <?php $_index = 0 ?> <?php $_prevOptionId = '' ?> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items.phtml b/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items.phtml index a90300efaf5..ddd623a7b97 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/creditmemo/items.phtml @@ -40,7 +40,6 @@ </tr> </thead> <?php $_items = $_creditmemo->getAllItems(); ?> - <?php $_count = count($_items) ?> <?php foreach ($_items as $_item): ?> <?php if ($_item->getOrderItem()->getParentItem()) { continue; diff --git a/app/code/Magento/Sales/view/frontend/templates/order/invoice/items.phtml b/app/code/Magento/Sales/view/frontend/templates/order/invoice/items.phtml index 980710569fa..58ce8bff0b9 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/invoice/items.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/invoice/items.phtml @@ -37,7 +37,6 @@ </tr> </thead> <?php $_items = $_invoice->getAllItems(); ?> - <?php $_count = count($_items) ?> <?php foreach ($_items as $_item): ?> <?php if ($_item->getOrderItem()->getParentItem()) { continue; diff --git a/app/code/Magento/Sales/view/frontend/templates/order/print/creditmemo.phtml b/app/code/Magento/Sales/view/frontend/templates/order/print/creditmemo.phtml index d68b4cdb62f..75f210d46bb 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/print/creditmemo.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/print/creditmemo.phtml @@ -34,11 +34,10 @@ </tr> </thead> <?php $_items = $_creditmemo->getAllItems(); ?> - <?php $_count = count($_items); ?> <?php foreach ($_items as $_item): ?> - <?php if ($_item->getOrderItem()->getParentItem()) { - continue; -} ?> + <?php if ($_item->getOrderItem()->getParentItem()): ?> + continue; + <?php endif; ?> <tbody> <?= $block->getItemHtml($_item) ?> </tbody> diff --git a/app/code/Magento/Sales/view/frontend/templates/order/print/invoice.phtml b/app/code/Magento/Sales/view/frontend/templates/order/print/invoice.phtml index 5aa1cab686e..db6b7ba5ba7 100644 --- a/app/code/Magento/Sales/view/frontend/templates/order/print/invoice.phtml +++ b/app/code/Magento/Sales/view/frontend/templates/order/print/invoice.phtml @@ -32,11 +32,10 @@ </tr> </thead> <?php $_items = $_invoice->getItemsCollection(); ?> - <?php $_count = $_items->count(); ?> <?php foreach ($_items as $_item): ?> - <?php if ($_item->getOrderItem()->getParentItem()) { - continue; -} ?> + <?php if ($_item->getOrderItem()->getParentItem()): ?> + continue; + <?php endif; ?> <tbody> <?= $block->getItemHtml($_item) ?> </tbody> diff --git a/app/code/Magento/Shipping/view/frontend/templates/items.phtml b/app/code/Magento/Shipping/view/frontend/templates/items.phtml index 1f4958d1775..197823b1e07 100644 --- a/app/code/Magento/Shipping/view/frontend/templates/items.phtml +++ b/app/code/Magento/Shipping/view/frontend/templates/items.phtml @@ -66,7 +66,6 @@ </tr> </thead> <?php $_items = $_shipment->getAllItems(); ?> - <?php $_count = count($_items) ?> <?php foreach ($_items as $_item): ?> <?php if ($_item->getOrderItem()->getParentItem()) { continue; -- GitLab