From 34b64380a1d2eb35d1155ea94dd117518d1d040e Mon Sep 17 00:00:00 2001 From: Oleksandr Miroshnichenko <omiroshnichenko@magento.com> Date: Mon, 11 Dec 2017 14:43:15 +0200 Subject: [PATCH] 12468: Sort by Price not working on CatalogSearch Page in Magento 2 --- .../Magento/Catalog/Block/Product/ProductList/Toolbar.php | 2 +- .../Catalog/view/frontend/web/js/product/list/toolbar.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php b/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php index df98969c262..dfbaf3a6242 100644 --- a/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php +++ b/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php @@ -689,7 +689,7 @@ class Toolbar extends \Magento\Framework\View\Element\Template 'limit' => ToolbarModel::LIMIT_PARAM_NAME, 'modeDefault' => $defaultMode, 'directionDefault' => $this->_direction ?: ProductList::DEFAULT_SORT_DIRECTION, - 'orderDefault' => $this->_productListHelper->getDefaultSortField(), + 'orderDefault' => $this->getOrderField(), 'limitDefault' => $this->_productListHelper->getDefaultLimitPerPageValue($defaultMode), 'url' => $this->getPagerUrl(), ]; diff --git a/app/code/Magento/Catalog/view/frontend/web/js/product/list/toolbar.js b/app/code/Magento/Catalog/view/frontend/web/js/product/list/toolbar.js index 259ca979206..88be03a04e7 100644 --- a/app/code/Magento/Catalog/view/frontend/web/js/product/list/toolbar.js +++ b/app/code/Magento/Catalog/view/frontend/web/js/product/list/toolbar.js @@ -78,7 +78,6 @@ define([ ); }, - /*eslint-disable no-unused-vars*/ /** * @param {String} paramName * @param {*} paramValue @@ -100,13 +99,14 @@ define([ } paramData[paramName] = paramValue; + if (paramValue == defaultValue) { //eslint-disable-line eqeqeq + delete paramData[paramName]; + } paramData = $.param(paramData); location.href = baseUrl + (paramData.length ? '?' + paramData : ''); } }); - /*eslint-enable no-unused-vars*/ - return $.mage.productListToolbarForm; }); -- GitLab