diff --git a/app/code/Magento/Paypal/Model/Config/Rules/Converter.php b/app/code/Magento/Paypal/Model/Config/Rules/Converter.php index b2dad4af6f4b669b1e2ea798a107f84d51a1013c..5528f79b385758a89b1c4c1fad3d2fa90e92b08e 100644 --- a/app/code/Magento/Paypal/Model/Config/Rules/Converter.php +++ b/app/code/Magento/Paypal/Model/Config/Rules/Converter.php @@ -58,7 +58,6 @@ class Converter implements ConverterInterface protected function createEvents(\DOMElement $node) { $result = []; - /** @var \DOMElement $child */ foreach ($node->childNodes as $child) { /** @var \DOMElement $child */ if ($this->hasNodeElement($child)) { diff --git a/app/code/Magento/Paypal/view/adminhtml/web/js/rules/conflict.js b/app/code/Magento/Paypal/view/adminhtml/web/js/rules/conflict.js index ab0ca8b9f608c356d024f09d0d4f041787ef1851..54b263be6421dcdd7534f811c7ef80a02be12e99 100644 --- a/app/code/Magento/Paypal/view/adminhtml/web/js/rules/conflict.js +++ b/app/code/Magento/Paypal/view/adminhtml/web/js/rules/conflict.js @@ -33,7 +33,7 @@ if (!isDisabled && !executed) { executed = true; alert({ - content: 'The following error(s) occurred:\n\r' + + content: 'The following error(s) occurred:' + newLine + 'Some PayPal solutions conflict.' + newLine + diff --git a/app/code/Magento/Paypal/view/adminhtml/web/js/rules/payflow/bml/enable-conditional.js b/app/code/Magento/Paypal/view/adminhtml/web/js/rules/payflow/bml/enable-conditional.js index 77d3e28aa726cba72ea2560b8960d3361992aca8..9770d463f45fc676eeda339a9d7849368822f93f 100644 --- a/app/code/Magento/Paypal/view/adminhtml/web/js/rules/payflow/bml/enable-conditional.js +++ b/app/code/Magento/Paypal/view/adminhtml/web/js/rules/payflow/bml/enable-conditional.js @@ -10,7 +10,7 @@ define(['underscore'], function (_) { _.every(data.argument, function (name) { if (data.solutionsElements[name] && - data.solutionsElements[name].find(data.enableButton).val() == 1 + data.solutionsElements[name].find(data.enableButton).val() === '1' ) { isDisabled = false; diff --git a/app/code/Magento/Paypal/view/adminhtml/web/js/rules/paypal/express/unlock-configuration.js b/app/code/Magento/Paypal/view/adminhtml/web/js/rules/paypal/express/unlock-configuration.js index a13142e359e1ddf987f63475a119f7abaca63c66..fda160c6d94f4babe5257180db769a37aa667537 100644 --- a/app/code/Magento/Paypal/view/adminhtml/web/js/rules/paypal/express/unlock-configuration.js +++ b/app/code/Magento/Paypal/view/adminhtml/web/js/rules/paypal/express/unlock-configuration.js @@ -10,7 +10,7 @@ define(['underscore'], function (_) { _.every(data.argument, function (name) { if (data.solutionsElements[name] && - data.solutionsElements[name].find(data.enableButton).val() == 1 + data.solutionsElements[name].find(data.enableButton).val() === '1' ) { isUnlock = false;