diff --git a/setup/pub/magento/setup/readiness-check.js b/setup/pub/magento/setup/readiness-check.js index 58f2c69e6c3ef0d1f07ab1dfbc1cb407e115246f..3abe557a22d2ce429bb8bc8fb28742e53341fd50 100644 --- a/setup/pub/magento/setup/readiness-check.js +++ b/setup/pub/magento/setup/readiness-check.js @@ -287,21 +287,15 @@ angular.module('readiness-check', []) $scope.query = function(item) { if (item.params) { if (item.useGet === true) { - item.url = item.url + '?type=' + item.params; - // The http request type has been changed from POST to GET for a reason. The POST request // results in PHP throwing a warning regards to 'always_populate_raw_post_data' // being incorrectly set to a value different than -1. This warning is throw during the initial // boot up sequence when POST request is received before the control gets transferred over to - // the magento customer error handler, hence not catachable. To avoid that warning, the HTTP - // request type is being changed from POST to GET for select queries. - return $http.get(item.url) - .success(function (data) { - item.process(data) - }) - .error(function (data, status) { - item.fail(); - }); + // the Magento customer error handler, hence not catchable. To avoid that warning, the HTTP + // request type is being changed from POST to GET for select queries. Those queries are: + // (1) PHP Version Check (2) PHP Settings Check and (3) PHP Extensions Check. + + item.url = item.url + '?type=' + item.params; } else { return $http.post(item.url, item.params) .success(function (data) { diff --git a/setup/src/Magento/Setup/Model/PhpReadinessCheck.php b/setup/src/Magento/Setup/Model/PhpReadinessCheck.php index f05f1a97866690a0448d5f4cc6bb6d44265e4331..b6bed9a9d1cb26c3d5076c4a153884b4dbfc61b0 100644 --- a/setup/src/Magento/Setup/Model/PhpReadinessCheck.php +++ b/setup/src/Magento/Setup/Model/PhpReadinessCheck.php @@ -218,7 +218,7 @@ class PhpReadinessCheck 'message' => $message, 'helpUrl' => 'http://php.net/manual/en/ini.core.php#ini.always-populate-settings-data', 'error' => $error - ]; + ]; return $data; }