From 2891de9822009b25ef8c2c9807321e4dd84c72cb Mon Sep 17 00:00:00 2001 From: Igor Melnikov <imelnikov@magento.com> Date: Thu, 3 Nov 2016 09:59:52 -0500 Subject: [PATCH] MAGETWO-60442: Add optional SerializerInterface dependency to child classes of \Magento\Framework\Config\Data Adding SerializerInterface dependency in the constructor --- app/code/Magento/Indexer/Model/Config/Data.php | 3 +++ lib/internal/Magento/Framework/Config/Data.php | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Indexer/Model/Config/Data.php b/app/code/Magento/Indexer/Model/Config/Data.php index 2e1e433e4be..cf6ea584196 100644 --- a/app/code/Magento/Indexer/Model/Config/Data.php +++ b/app/code/Magento/Indexer/Model/Config/Data.php @@ -6,6 +6,8 @@ namespace Magento\Indexer\Model\Config; use Magento\Framework\Serialize\SerializerInterface; +use Magento\Framework\Serialize\Serializer\Serialize; +use Magento\Framework\App\ObjectManager; class Data extends \Magento\Framework\Config\Data { @@ -29,6 +31,7 @@ class Data extends \Magento\Framework\Config\Data SerializerInterface $serializer = null ) { $this->stateCollection = $stateCollection; + $serializer = $serializer ?: ObjectManager::getInstance()->get(Serialize::class); $isCacheExists = $cache->test($cacheId); diff --git a/lib/internal/Magento/Framework/Config/Data.php b/lib/internal/Magento/Framework/Config/Data.php index e3e09f0fca6..0723e40dbfe 100644 --- a/lib/internal/Magento/Framework/Config/Data.php +++ b/lib/internal/Magento/Framework/Config/Data.php @@ -1,7 +1,5 @@ <?php /** - * Config data. Represents loaded and cached configuration data. Should be used to gain access to different types - * * Copyright © 2016 Magento. All rights reserved. * See COPYING.txt for license details. */ @@ -11,6 +9,8 @@ use Magento\Framework\Serialize\SerializerInterface; use Magento\Framework\App\ObjectManager; /** + * Represents loaded and cached configuration data, should be used to gain access to different types + * * @SuppressWarnings(PHPMD.NumberOfChildren) */ class Data implements \Magento\Framework\Config\DataInterface -- GitLab