diff --git a/setup/src/Magento/Setup/Model/DateTime/DateTimeProvider.php b/setup/src/Magento/Setup/Model/DateTime/DateTimeProvider.php index 073b6ee027bea71d8b6754d21550d9b7b26a93fc..6997b7ac0ab89676e97590ccf17b808b4e270a82 100644 --- a/setup/src/Magento/Setup/Model/DateTime/DateTimeProvider.php +++ b/setup/src/Magento/Setup/Model/DateTime/DateTimeProvider.php @@ -15,7 +15,7 @@ class DateTimeProvider /** * Timezone provider * - * @var TimezoneProvider + * @var TimeZoneProvider */ private $tzProvider; @@ -36,10 +36,10 @@ class DateTimeProvider /** * Init * - * @param TimezoneProvider $tzProvider + * @param TimeZoneProvider $tzProvider * @param ObjectManagerProvider $objectManagerProvider */ - public function __construct(TimezoneProvider $tzProvider, ObjectManagerProvider $objectManagerProvider) + public function __construct(TimeZoneProvider $tzProvider, ObjectManagerProvider $objectManagerProvider) { $this->tzProvider = $tzProvider; $this->objectManagerProvider = $objectManagerProvider; diff --git a/setup/src/Magento/Setup/Model/DateTime/TimezoneProvider.php b/setup/src/Magento/Setup/Model/DateTime/TimeZoneProvider.php similarity index 98% rename from setup/src/Magento/Setup/Model/DateTime/TimezoneProvider.php rename to setup/src/Magento/Setup/Model/DateTime/TimeZoneProvider.php index dfff802bc793cc0a08fe280344bd9eed3fa8e84b..85a84cbeb9bcde17b397d5e6b8147541b2249689 100644 --- a/setup/src/Magento/Setup/Model/DateTime/TimezoneProvider.php +++ b/setup/src/Magento/Setup/Model/DateTime/TimeZoneProvider.php @@ -11,7 +11,7 @@ use Magento\Setup\Model\ObjectManagerProvider; /** * Provider of Timezone instance */ -class TimezoneProvider +class TimeZoneProvider { /** * Object Manager provider diff --git a/setup/src/Magento/Setup/Model/PackagesData.php b/setup/src/Magento/Setup/Model/PackagesData.php index f2a759aca54211295e4dd427932bab4eb00c63ec..4d113728a8b7ebfced96d32f64a6166872db2c18 100644 --- a/setup/src/Magento/Setup/Model/PackagesData.php +++ b/setup/src/Magento/Setup/Model/PackagesData.php @@ -40,6 +40,11 @@ class PackagesData */ private $packagesAuth; + /** + * @var \Magento\Setup\Model\DateTime\TimeZoneProvider + */ + private $timeZoneProvider; + /** * @var \Magento\Setup\Model\ObjectManagerProvider */ @@ -49,18 +54,21 @@ class PackagesData * PackagesData constructor. * * @param \Magento\Framework\Composer\ComposerInformation $composerInformation, + * @param \Magento\Setup\Model\DateTime\TimeZoneProvider $timeZoneProvider, * @param \Magento\Setup\Model\PackagesAuth $packagesAuth, * @param \Magento\Framework\Filesystem $filesystem, * @param \Magento\Setup\Model\ObjectManagerProvider $objectManagerProvider */ public function __construct( \Magento\Framework\Composer\ComposerInformation $composerInformation, + \Magento\Setup\Model\DateTime\TimeZoneProvider $timeZoneProvider, \Magento\Setup\Model\PackagesAuth $packagesAuth, \Magento\Framework\Filesystem $filesystem, \Magento\Setup\Model\ObjectManagerProvider $objectManagerProvider ) { $this->objectManagerProvider = $objectManagerProvider; $this->composerInformation = $composerInformation; + $this->timeZoneProvider = $timeZoneProvider; $this->packagesAuth = $packagesAuth; $this->filesystem = $filesystem; } @@ -125,9 +133,7 @@ class PackagesData */ private function formatSyncDate($syncDate) { - $objectManager = $this->objectManagerProvider->get(); - $timeZoneProvider = $objectManager->get('Magento\Setup\Model\DateTime\TimeZoneProvider'); - $timezone = $timeZoneProvider->get(); + $timezone = $this->timeZoneProvider->get(); return [ 'date' => $timezone->formatDateTime( new \DateTime('@'.$syncDate), diff --git a/setup/src/Magento/Setup/Test/Unit/Model/DateTime/DateTimeProviderTest.php b/setup/src/Magento/Setup/Test/Unit/Model/DateTime/DateTimeProviderTest.php index 4d24e73a02e2685df5e56a6e6d05c0f1b5fc0bb7..312129a01b328ee4e25687e23076bcd50adc531f 100644 --- a/setup/src/Magento/Setup/Test/Unit/Model/DateTime/DateTimeProviderTest.php +++ b/setup/src/Magento/Setup/Test/Unit/Model/DateTime/DateTimeProviderTest.php @@ -6,7 +6,7 @@ namespace Magento\Setup\Test\Unit\Model\DateTime; use Magento\Setup\Model\DateTime\DateTimeProvider; -use Magento\Setup\Model\DateTime\TimezoneProvider; +use Magento\Setup\Model\DateTime\TimeZoneProvider; use Magento\Setup\Model\ObjectManagerProvider; class DateTimeProviderTest extends \PHPUnit_Framework_TestCase @@ -14,8 +14,8 @@ class DateTimeProviderTest extends \PHPUnit_Framework_TestCase public function testGet() { $dateTime = $this->getMock('\Magento\Framework\Stdlib\DateTime\DateTime', [], [], '', false); - /** @var TimezoneProvider|\PHPUnit_Framework_MockObject_MockObject $timeZoneProvider */ - $timeZoneProvider = $this->getMock('\Magento\Setup\Model\DateTime\TimezoneProvider', [], [], '', false); + /** @var TimeZoneProvider|\PHPUnit_Framework_MockObject_MockObject $timeZoneProvider */ + $timeZoneProvider = $this->getMock('\Magento\Setup\Model\DateTime\TimeZoneProvider', [], [], '', false); $timeZone = $this->getMock('\Magento\Framework\Stdlib\DateTime\Timezone', [], [], '', false); $timeZoneProvider->expects($this->any()) ->method('get') diff --git a/setup/src/Magento/Setup/Test/Unit/Model/DateTime/TimezoneProviderTest.php b/setup/src/Magento/Setup/Test/Unit/Model/DateTime/TimeZoneProviderTest.php similarity index 88% rename from setup/src/Magento/Setup/Test/Unit/Model/DateTime/TimezoneProviderTest.php rename to setup/src/Magento/Setup/Test/Unit/Model/DateTime/TimeZoneProviderTest.php index 63c4df875e280d11c32e7e20aa75085c0ed94f19..a6a80b3a0976f2088d49fb12c45e1d699637a2c5 100644 --- a/setup/src/Magento/Setup/Test/Unit/Model/DateTime/TimezoneProviderTest.php +++ b/setup/src/Magento/Setup/Test/Unit/Model/DateTime/TimeZoneProviderTest.php @@ -6,10 +6,10 @@ namespace Magento\Setup\Test\Unit\Model\DateTime; use Magento\Framework\App\Config\ScopeConfigInterface; -use Magento\Setup\Model\DateTime\TimezoneProvider; +use Magento\Setup\Model\DateTime\TimeZoneProvider; use Magento\Setup\Model\ObjectManagerProvider; -class TimezoneProviderTest extends \PHPUnit_Framework_TestCase +class TimeZoneProviderTest extends \PHPUnit_Framework_TestCase { public function testGet() { @@ -27,7 +27,7 @@ class TimezoneProviderTest extends \PHPUnit_Framework_TestCase $objectManagerProvider->expects($this->any()) ->method('get') ->willReturn($objectManager); - $object = new TimezoneProvider($objectManagerProvider); + $object = new TimeZoneProvider($objectManagerProvider); $this->assertSame($timeZone, $object->get()); // Assert that the provider always returns the same object $this->assertSame($timeZone, $object->get()); diff --git a/setup/src/Magento/Setup/Test/Unit/Model/PackagesDataTest.php b/setup/src/Magento/Setup/Test/Unit/Model/PackagesDataTest.php index 60623b5eeb1e9bfaaf3b2cd95ed5417c9bef3e59..3c096fa1faf6f98c497e0b5c80c9a8b1da0ba323 100644 --- a/setup/src/Magento/Setup/Test/Unit/Model/PackagesDataTest.php +++ b/setup/src/Magento/Setup/Test/Unit/Model/PackagesDataTest.php @@ -51,10 +51,8 @@ class PackagesDataTest extends \PHPUnit_Framework_TestCase $applicationFactory->expects($this->any())->method('create')->willReturn($application); $objectManager->expects($this->any()) ->method('get') - ->will($this->returnValueMap([ - ['Magento\Framework\Composer\MagentoComposerApplicationFactory', $applicationFactory], - ['Magento\Setup\Model\DateTime\TimeZoneProvider', $timeZoneProvider] - ])); + ->with('Magento\Framework\Composer\MagentoComposerApplicationFactory') + ->willReturn($applicationFactory); $objectManagerProvider->expects($this->any())->method('get')->willReturn($objectManager); $directoryWrite = $this->getMockForAbstractClass('\Magento\Framework\Filesystem\Directory\WriteInterface'); @@ -88,6 +86,7 @@ class PackagesDataTest extends \PHPUnit_Framework_TestCase $this->packagesData = new PackagesData( $composerInformation, + $timeZoneProvider, $packagesAuth, $filesystem, $objectManagerProvider