From 1b4765aa1e121545af23471a5518a9ec15e8d989 Mon Sep 17 00:00:00 2001 From: Anton Kaplya <akaplya@ebay.com> Date: Tue, 17 Mar 2015 13:47:39 +0200 Subject: [PATCH] MAGETWO-34729: Code coverage --- .../Order/Creditmemo/Total/DiscountTest.php | 6 ++++-- .../Order/Grid/Massaction/ItemsUpdaterTest.php | 2 +- .../Model/Order/Grid/Row/UrlGeneratorTest.php | 18 +++++++++++++++--- .../Invoice/Grid/Row/UrlGeneratorTest.php | 16 ++++++++++++++-- .../Test/Unit/Model/Order/Invoice/ItemTest.php | 15 ++++++++++----- 5 files changed, 44 insertions(+), 13 deletions(-) diff --git a/app/code/Magento/Sales/Test/Unit/Model/Order/Creditmemo/Total/DiscountTest.php b/app/code/Magento/Sales/Test/Unit/Model/Order/Creditmemo/Total/DiscountTest.php index 96c05732d3c..c850a30af84 100644 --- a/app/code/Magento/Sales/Test/Unit/Model/Order/Creditmemo/Total/DiscountTest.php +++ b/app/code/Magento/Sales/Test/Unit/Model/Order/Creditmemo/Total/DiscountTest.php @@ -41,7 +41,8 @@ class DiscountTest extends \PHPUnit_Framework_TestCase '', false ); - $this->orderItemMock = $this->getMock('Magento\Sales\Model\Order', + $this->orderItemMock = $this->getMock( + 'Magento\Sales\Model\Order', [ 'isDummy', 'getDiscountInvoiced', 'getBaseDiscountInvoiced', 'getQtyInvoiced', 'getQty', 'getDiscountRefunded', 'getQtyRefunded' @@ -50,7 +51,8 @@ class DiscountTest extends \PHPUnit_Framework_TestCase '', false ); - $this->creditmemoMock = $this->getMock('\Magento\Sales\Model\Order\Creditmemo', + $this->creditmemoMock = $this->getMock( + '\Magento\Sales\Model\Order\Creditmemo', [ 'setBaseCost', 'getAllItems', 'getOrder', 'getBaseShippingAmount', 'roundPrice', 'setDiscountAmount', 'setBaseDiscountAmount' diff --git a/app/code/Magento/Sales/Test/Unit/Model/Order/Grid/Massaction/ItemsUpdaterTest.php b/app/code/Magento/Sales/Test/Unit/Model/Order/Grid/Massaction/ItemsUpdaterTest.php index 8726d814b06..b7462307b57 100644 --- a/app/code/Magento/Sales/Test/Unit/Model/Order/Grid/Massaction/ItemsUpdaterTest.php +++ b/app/code/Magento/Sales/Test/Unit/Model/Order/Grid/Massaction/ItemsUpdaterTest.php @@ -46,4 +46,4 @@ class ItemsUpdaterTest extends \PHPUnit_Framework_TestCase ); $this->assertEquals(['other' => null], $this->itemUpdater->update($arguments)); } -} \ No newline at end of file +} diff --git a/app/code/Magento/Sales/Test/Unit/Model/Order/Grid/Row/UrlGeneratorTest.php b/app/code/Magento/Sales/Test/Unit/Model/Order/Grid/Row/UrlGeneratorTest.php index 33c7ee0b130..7ff72976db9 100644 --- a/app/code/Magento/Sales/Test/Unit/Model/Order/Grid/Row/UrlGeneratorTest.php +++ b/app/code/Magento/Sales/Test/Unit/Model/Order/Grid/Row/UrlGeneratorTest.php @@ -6,7 +6,7 @@ namespace Magento\Sales\Test\Unit\Model\Order\Grid\Row; -class UrlGeneratorTest extends \PHPUnit_Framework_TestCase +class UrlGeneratorTest extends \PHPUnit_Framework_TestCase { /** * @var \Magento\Sales\Model\Order\Grid\Row\UrlGenerator @@ -24,10 +24,22 @@ class UrlGeneratorTest extends \PHPUnit_Framework_TestCase public function setUp() { $this->urlMock = $this->getMockForAbstractClass( - 'Magento\Backend\Model\UrlInterface', [], '', false, false, true, [] + 'Magento\Backend\Model\UrlInterface', + [], + '', + false, + false, + true, + [] ); $this->authorizationMock = $this->getMockForAbstractClass( - 'Magento\Framework\AuthorizationInterface', [], '', false, false, true, [] + 'Magento\Framework\AuthorizationInterface', + [], + '', + false, + false, + true, + [] ); $this->urlGenerator = new \Magento\Sales\Model\Order\Grid\Row\UrlGenerator( $this->urlMock, diff --git a/app/code/Magento/Sales/Test/Unit/Model/Order/Invoice/Grid/Row/UrlGeneratorTest.php b/app/code/Magento/Sales/Test/Unit/Model/Order/Invoice/Grid/Row/UrlGeneratorTest.php index 2eeebb26091..e00487e8bec 100644 --- a/app/code/Magento/Sales/Test/Unit/Model/Order/Invoice/Grid/Row/UrlGeneratorTest.php +++ b/app/code/Magento/Sales/Test/Unit/Model/Order/Invoice/Grid/Row/UrlGeneratorTest.php @@ -24,10 +24,22 @@ class UrlGeneratorTest extends \PHPUnit_Framework_TestCase public function setUp() { $this->urlMock = $this->getMockForAbstractClass( - 'Magento\Backend\Model\UrlInterface', [], '', false, false, true, [] + 'Magento\Backend\Model\UrlInterface', + [], + '', + false, + false, + true, + [] ); $this->authorizationMock = $this->getMockForAbstractClass( - 'Magento\Framework\AuthorizationInterface', [], '', false, false, true, [] + 'Magento\Framework\AuthorizationInterface', + [], + '', + false, + false, + true, + [] ); $this->urlGenerator = new \Magento\Sales\Model\Order\Invoice\Grid\Row\UrlGenerator( $this->urlMock, $this->authorizationMock, [ diff --git a/app/code/Magento/Sales/Test/Unit/Model/Order/Invoice/ItemTest.php b/app/code/Magento/Sales/Test/Unit/Model/Order/Invoice/ItemTest.php index 0303f1855ee..8e4abcc3768 100644 --- a/app/code/Magento/Sales/Test/Unit/Model/Order/Invoice/ItemTest.php +++ b/app/code/Magento/Sales/Test/Unit/Model/Order/Invoice/ItemTest.php @@ -36,25 +36,29 @@ class ItemTest extends \PHPUnit_Framework_TestCase public function setUp() { $this->objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this); - $this->orderItemFactoryMock = $this->getMock('Magento\Sales\Model\Order\ItemFactory', + $this->orderItemFactoryMock = $this->getMock( + 'Magento\Sales\Model\Order\ItemFactory', ['create'], [], '', false ); - $this->invoiceMock = $this->getMock('Magento\Sales\Model\Order\Invoice', + $this->invoiceMock = $this->getMock( + 'Magento\Sales\Model\Order\Invoice', [], [], '', false ); - $this->orderMock = $this->getMock('Magento\Sales\Model\Order', + $this->orderMock = $this->getMock( + 'Magento\Sales\Model\Order', [], [], '', false ); - $this->orderItemMock = $this->getMock('Magento\Sales\Model\Order\Item', + $this->orderItemMock = $this->getMock( + 'Magento\Sales\Model\Order\Item', [ 'load', 'isDummy', 'getIsQtyDecimal', 'getQtyToInvoice', 'getQtyInvoiced', 'getTaxInvoiced', 'getBaseTaxInvoiced', 'getHiddenTaxInvoiced', 'getBaseHiddenTaxInvoiced', 'getDiscountInvoiced', @@ -67,7 +71,8 @@ class ItemTest extends \PHPUnit_Framework_TestCase '', false ); - $this->item = $this->objectManager->getObject('Magento\Sales\Model\Order\Invoice\Item', + $this->item = $this->objectManager->getObject( + 'Magento\Sales\Model\Order\Invoice\Item', [ 'orderItemFactory' => $this->orderItemFactoryMock ] -- GitLab