From 182528e5541cdcffca59e6405594d1d2f170f1ca Mon Sep 17 00:00:00 2001
From: Igor Melnikov <imelnikov@magento.com>
Date: Mon, 28 Nov 2016 17:30:35 -0600
Subject: [PATCH] MAGETWO-61240: Fix
 \Magento\Sniffs\Translation\ConstantUsageSniff

Addressing code review feedback
---
 .../Translation/_files/correct_arguments.txt  | 22 +++++++++----------
 .../_files/incorrect_arguments.txt            | 20 ++++++++---------
 2 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/_files/correct_arguments.txt b/dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/_files/correct_arguments.txt
index 2ea7c6ed532..536029811fd 100644
--- a/dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/_files/correct_arguments.txt
+++ b/dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/_files/correct_arguments.txt
@@ -4,26 +4,26 @@
  * See COPYING.txt for license details.
  */
 
-$item[ConfigConverter::KEY_TITLE] = __($item)
+__($variable)
 
-$item[ConfigConverter::KEY_TITLE] = __($item[Converter::KEY_TITLE])
+__($variable[Class::CONSTANT])
 
-$item[ConfigConverter::KEY_TITLE] = __($item['\Magento\Support\Model\Report\Config\Converter::KEY_TITLE'])
+__($variable[\Namespace\Class::CONSTANT])
 
-$item[ConfigConverter::KEY_TITLE] = __($item['value'])
+__($variable['value'])
 
-$item[ConfigConverter::KEY_TITLE] = __(
-    $item
+__(
+    $variable
 )
 
-Phrase($item)
+Phrase($variable)
 
-Phrase($item[Converter::KEY_TITLE])
+Phrase($variable[Class::CONSTANT])
 
-Phrase($item['\Magento\Support\Model\Report\Config\Converter::KEY_TITLE'])
+Phrase($variable[\Namespace\Class::CONSTANT])
 
-\Magento\Framework\Phrase($item['value'])
+\Magento\Framework\Phrase($variable['value'])
 
 \Magento\Framework\Phrase(
-    $item[Converter::KEY_TITLE]
+    $variable[Class::CONSTANT]
 )
diff --git a/dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/_files/incorrect_arguments.txt b/dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/_files/incorrect_arguments.txt
index d2e60b65c06..6112ce567ce 100644
--- a/dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/_files/incorrect_arguments.txt
+++ b/dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/_files/incorrect_arguments.txt
@@ -4,24 +4,24 @@
  * See COPYING.txt for license details.
  */
 
-$item[ConfigConverter::KEY_TITLE] = __(Converter::KEY_TITLE)
+__(Class::CONSTANT)
 
-$item[ConfigConverter::KEY_TITLE] = __(self::KEY_TITLE)
+__(self::CONSTANT)
 
-$item[ConfigConverter::KEY_TITLE] = __(\Magento\Support\Model\Report\Config\Converter::KEY_TITLE)
+__(\Namespace\Class::CONSTANT)
 
-$item[ConfigConverter::KEY_TITLE] = __(
-    Converter::KEY_TITLE
+__(
+    Class::CONSTANT
 )
 
-Phrase(Converter::KEY_TITLE)
+Phrase(Class::CONSTANT)
 
-Phrase(self::KEY_TITLE)
+Phrase(self::CONSTANT)
 
-Phrase(\Magento\Support\Model\Report\Config\Converter::KEY_TITLE)
+Phrase(\Namespace\Class::CONSTANT)
 
-\Magento\Framework\Phrase(Converter::KEY_TITLE)
+\Magento\Framework\Phrase(Class::CONSTANT)
 
 \Magento\Framework\Phrase(
-    Converter::KEY_TITLE
+    Class::CONSTANT
 )
-- 
GitLab