From 149fe6919f2e77b6212dd3f631a3de9d681d8be3 Mon Sep 17 00:00:00 2001 From: Leonid Poluyanov <lpoluyanov@magento.com> Date: Fri, 4 Nov 2016 11:58:03 +0200 Subject: [PATCH] MAGETWO-60037: User is able to create empty URL key for category which leads to numerous errors --- .../Observer/CategoryUrlPathAutogeneratorObserver.php | 1 - .../Model/CategoryUrlRewriteGeneratorTest.php | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app/code/Magento/CatalogUrlRewrite/Observer/CategoryUrlPathAutogeneratorObserver.php b/app/code/Magento/CatalogUrlRewrite/Observer/CategoryUrlPathAutogeneratorObserver.php index 9e5a708c22e..cb30f7abc71 100644 --- a/app/code/Magento/CatalogUrlRewrite/Observer/CategoryUrlPathAutogeneratorObserver.php +++ b/app/code/Magento/CatalogUrlRewrite/Observer/CategoryUrlPathAutogeneratorObserver.php @@ -5,7 +5,6 @@ */ namespace Magento\CatalogUrlRewrite\Observer; -use Doctrine\Instantiator\Exception\InvalidArgumentException; use Magento\Catalog\Model\Category; use Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator; use Magento\CatalogUrlRewrite\Service\V1\StoreViewService; diff --git a/dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGeneratorTest.php b/dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGeneratorTest.php index b3831d09a0d..93fe95f83cb 100644 --- a/dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGeneratorTest.php +++ b/dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGeneratorTest.php @@ -94,7 +94,7 @@ class CategoryUrlRewriteGeneratorTest extends \PHPUnit_Framework_TestCase * @magentoDbIsolation enabled * @magentoAppIsolation enabled * @param string $urlKey - * @dataProvider IncorrectUrlRewritesDataProvider + * @dataProvider incorrectUrlRewritesDataProvider */ public function testGenerateUrlRewritesWithIncorrectUrlKey($urlKey) { @@ -112,7 +112,7 @@ class CategoryUrlRewriteGeneratorTest extends \PHPUnit_Framework_TestCase /** * @return array */ - public function IncorrectUrlRewritesDataProvider() + public function incorrectUrlRewritesDataProvider() { return [ ['#'], -- GitLab