From 109e7c12e252ff3699be81281280a2e959d8248f Mon Sep 17 00:00:00 2001
From: Leonid Poluyanov <lpoluyanov@magento.com>
Date: Mon, 15 Jan 2018 19:40:56 +0200
Subject: [PATCH] MAGETWO-83293: Inefficient SQL query on applying filter on
 sales order grid

---
 app/code/Magento/Ui/Component/Filters.php     |  2 +-
 .../Ui/Test/Unit/Component/FiltersTest.php    | 79 +++++++++++++++++++
 2 files changed, 80 insertions(+), 1 deletion(-)
 create mode 100644 app/code/Magento/Ui/Test/Unit/Component/FiltersTest.php

diff --git a/app/code/Magento/Ui/Component/Filters.php b/app/code/Magento/Ui/Component/Filters.php
index 3085485521c..fe02c23af9c 100644
--- a/app/code/Magento/Ui/Component/Filters.php
+++ b/app/code/Magento/Ui/Component/Filters.php
@@ -82,7 +82,7 @@ class Filters extends AbstractComponent implements ObserverInterface
                 return;
             }
 
-            if (isset($this->filterMap[$filterType])) {
+            if (isset($this->filterMap[$filterType]) && !isset($this->columnFilters[$component->getName()])) {
                 $filterComponent = $this->uiComponentFactory->create(
                     $component->getName(),
                     $this->filterMap[$filterType],
diff --git a/app/code/Magento/Ui/Test/Unit/Component/FiltersTest.php b/app/code/Magento/Ui/Test/Unit/Component/FiltersTest.php
new file mode 100644
index 00000000000..3935842aa64
--- /dev/null
+++ b/app/code/Magento/Ui/Test/Unit/Component/FiltersTest.php
@@ -0,0 +1,79 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Ui\Test\Unit\Component;
+
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
+use \Magento\Ui\Component\Filters;
+
+/**
+ * Unit tests for \Magento\Ui\Component\Filters class
+ */
+class FiltersTest extends \PHPUnit\Framework\TestCase
+{
+    /** @var Filters|\PHPUnit_Framework_MockObject_MockObject */
+    private $filters;
+
+    /** @var \Magento\Framework\View\Element\UiComponentInterface|\PHPUnit_Framework_MockObject_MockObject */
+    private $uiComponentInterface;
+
+    /** @var \Magento\Framework\View\Element\UiComponentFactory|\PHPUnit_Framework_MockObject_MockObject */
+    private $uiComponentFactory;
+
+    /** @var \Magento\Framework\View\Element\UiComponent\ContextInterface|\PHPUnit_Framework_MockObject_MockObject */
+    private $context;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp()
+    {
+        $objectManager = new ObjectManager($this);
+        $this->uiComponentInterface = $this->getMockBuilder(\Magento\Framework\View\Element\UiComponentInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->uiComponentFactory = $this->getMockBuilder(\Magento\Framework\View\Element\UiComponentFactory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->context = $this->getMockBuilder(\Magento\Framework\View\Element\UiComponent\ContextInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->filters = $objectManager->getObject(
+            Filters::class,
+            [
+                'columnFilters' => ['select' => $this->uiComponentInterface],
+                'uiComponentFactory' => $this->uiComponentFactory,
+                'context' => $this->context
+            ]
+        );
+    }
+
+    public function testUpdate()
+    {
+        $componentName = 'component_name';
+        $componentConfig = [0, 1, 2];
+        $columnInterface = $this->getMockBuilder(\Magento\Ui\Component\Listing\Columns\ColumnInterface::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['getData', 'getName', 'getConfiguration'])
+            ->getMockForAbstractClass();
+        $columnInterface->expects($this->atLeastOnce())->method('getData')->with('config/filter')->willReturn('text');
+        $columnInterface->expects($this->atLeastOnce())->method('getName')->willReturn($componentName);
+        $columnInterface->expects($this->once())->method('getConfiguration')->willReturn($componentConfig);
+        $filterComponent = $this->getMockBuilder(\Magento\Framework\View\Element\UiComponentInterface::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['setData', 'prepare'])
+            ->getMockForAbstractClass();
+        $filterComponent->expects($this->once())->method('setData')->with('config', $componentConfig)
+            ->willReturnSelf();
+        $filterComponent->expects($this->once())->method('prepare')->willReturnSelf();
+        $this->uiComponentFactory->expects($this->once())->method('create')
+            ->with($componentName, 'filterInput', ['context' => $this->context])
+            ->willReturn($filterComponent);
+
+        $this->filters->update($columnInterface);
+        /** Verify that filter is already set and it wouldn't be set again */
+        $this->filters->update($columnInterface);
+    }
+}
-- 
GitLab