From 0c97598113d04d7015d636f18ec091025f6afc4d Mon Sep 17 00:00:00 2001 From: Joan He <joan@x.com> Date: Mon, 26 Jan 2015 15:41:47 -0600 Subject: [PATCH] MAGETWO-31938: added unit tests --- dev/tests/unit/testsuite/Magento/Framework/App/AreaTest.php | 3 +++ .../Magento/Framework/App/Config/Data/ProcessorFactoryTest.php | 2 +- .../Magento/Framework/App/Response/Http/FileFactory.php | 3 +++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/AreaTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/AreaTest.php index 864f5e6c07c..bf2f452a45a 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/App/AreaTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/App/AreaTest.php @@ -6,6 +6,9 @@ namespace Magento\Framework\App; +/** + * @SuppressWarnings(PHPMD.CouplingBetweenObjects) + */ class AreaTest extends \PHPUnit_Framework_TestCase { const SCOPE_ID = '1'; diff --git a/dev/tests/unit/testsuite/Magento/Framework/App/Config/Data/ProcessorFactoryTest.php b/dev/tests/unit/testsuite/Magento/Framework/App/Config/Data/ProcessorFactoryTest.php index eacb9eac5fd..807f2cf9e59 100644 --- a/dev/tests/unit/testsuite/Magento/Framework/App/Config/Data/ProcessorFactoryTest.php +++ b/dev/tests/unit/testsuite/Magento/Framework/App/Config/Data/ProcessorFactoryTest.php @@ -53,7 +53,7 @@ class ProcessorFactoryTest extends \PHPUnit_Framework_TestCase /** * @covers \Magento\Framework\App\Config\Data\ProcessorFactory::get * @expectedException \InvalidArgumentException - * @expectedExceptionMessage Magento\Framework\App\Config\Data\WrongBackendModel is not instance of \Magento\Framework\App\Config\Data\ProcessorInterface + * @expectedExceptionMessageRegExp /\w+\\WrongBackendModel is not instance of \w+\\ProcessorInterface/ */ public function testGetModelWithWrongInterface() { diff --git a/lib/internal/Magento/Framework/App/Response/Http/FileFactory.php b/lib/internal/Magento/Framework/App/Response/Http/FileFactory.php index 3f90403f8d0..539448a1baa 100644 --- a/lib/internal/Magento/Framework/App/Response/Http/FileFactory.php +++ b/lib/internal/Magento/Framework/App/Response/Http/FileFactory.php @@ -124,6 +124,9 @@ class FileFactory /** * Call exit + * + * @return void + * @SuppressWarnings(PHPMD.ExitExpression) */ protected function callExit() { -- GitLab